id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-1517-6c1fe080 | DERBY-1756
patch Derby1756.2.diff.txt contributed by Sunitha Kambhampati
with derby-962 changes, if client jvm supports EUSRIDPWD then the client would
use EUSRIDPWD as the security mechanism. But it is possible that the server jvm
might not support EUSRIDPWD and the connection can fail.
When DERBY-1517, DERBY-1755 is fixed, there might be a way to use EUSRIDPWD
when both client and server vm's have support for it.
This patch does the following:
o Do not use EUSRIDPWD as the default security mechanism even if the client vm can support it.
o Fix comments in testSecMec.java.
o Existing tests in testSecMec.java cover this codepath and the master file
output reflects the changes made. Note, only the ibm14 client master file has
changed since only ibm141 and greater jvms come with jce that can support
eusridpwd.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@439775 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/ClientBaseDataSource.java",
"hunks": [
{
"added": [
" * 2. if password is available,then USRIDPWD is returned."
],
"header": "@@ -277,10 +277,7 @@ public abstract class ClientBaseDataSource implements Serializable, Refe... |
derby-DERBY-1519-faf6742e | DERBY-1519: 'setAsciiStream' uses different encodings for embedded and client. Client changed to use ISO-8859-1 to comply with JDBC and the embedded driver. This change can cause incompatibilities for certain applications (see release notes).
Patch file: derby-1519-1a.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@544424 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Clob.java",
"hunks": [
{
"added": [
" //\"ISO-8859-1\", \"UTF-8\", or \"UnicodeBigUnmarked\""
],
"header": "@@ -100,7 +100,7 @@ public class Clob extends Lob implements java.sql.Clob {",
"removed": [
... |
derby-DERBY-1521-145baeed | DERBY-1521 Attaching a patch 'd1521-patch1-v1.diff' which modifies UpgradeTester to test the grant/revoke feature. This is a preliminary patch which tests the default upgrade behaviour: In upgrades from versions earlier than 10.2,
* grant/revoke feature is not available in soft upgrade
* grant/revoke feature is not available in full upgrade (by default). This feature will be available after full upgrade only if "derby.database.sqlAuthorization" is true.
Patch contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425846 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1521-fee30aa2 | DERBY-1521 Patch which sets "derby.database.sqlAuthorization" for an upgraded database and tests that grant/revoke is available.
Patch submitted by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@428160 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1522-f05a2f83 | DERBY-1522
contributed by Deepa Remesh, dremesh@gmail.com
Attaching a patch 'derby1522_v2.diff. It includes a JUnit test for testing the
switch to SQL standard authorization. It tests following:
1. grant/revoke is not available if derby.database.sqlAuthorization property
is not set.
2. grant/revoke is available when derby.database.sqlAuthorization is set to true.
3. Once derby.database.sqlAuthorization is set to true, it cannot be set to any other value.
This patch also modifies DatabasePropertyTestSetup.tearDown method. The tearDown method resets the property values to old values. It will now ignore exceptions when property reset is not supported. I am including this small change in the above patch. (I had opened DERBY-1827 for the issue with tearDown method. ). I am using TestUtil.getConnection method to shutdown the database. I have opened DERBY-1826 to add methods to Derby's JUnit classes for shutdown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@441584 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/DatabasePropertyTestSetup.java",
"hunks": [
{
"added": [
"import org.apache.derbyTesting.functionTests.util.SQLStateConstants;",
""
],
"header": "@@ -29,6 +29,8 @@ import java.util.Properties;",
"... |
derby-DERBY-1527-d45f7d3f | DERBY-1527: Factor out type checks in EmbedResultSet and EmbedPreparedStatement
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@423912 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedPreparedStatement.java",
"hunks": [
{
"added": [
" checkAsciiStreamConditions(parameterIndex);"
],
"header": "@@ -567,8 +567,7 @@ public abstract class EmbedPreparedStatement",
"removed": [
... |
derby-DERBY-153-86be8370 | DERBY-153: Fix Eclipse plugin version specification.
Committed for Rajesh Kartha <kartha@source-zone.org>
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@161100 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/eclipse/DerbyEclipsePlugin.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derbyBuild.eclipse.DerbyEclipsePlugin",
"",
" Copyright 2002, 2004 The Apache Software Foundation or ... |
derby-DERBY-1530-ebdced0d | DERBY-1530: Commit derby-1530_v01.diff, aligning Derby with the last JDBC4 signature changes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430815 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [
" * <code>EmbedDatabaseMetaData.getFunctionColumns(String,String,"
],
"header": "@@ -1183,7 +1183,7 @@ public abstract class DatabaseMetaData implements java.sql.Data... |
derby-DERBY-1533-505bb8a1 | DERBY-1533: ArrayIndexOutOfBoundsException in DDMReader
DERBY-1533 follows in a series of bugs (DERBY-170, DERBY-428, DERBY-491,
DERBY-492, DERBY-614 among others) which have to do with the particulars of
the DRDA protocols used for handling long messages and large amounts of data.
In this particular issue, the problems involve the situation in which the
server is receiving a message which is segmented across multiple layer A
blocks using DSS continuations. This is a relatively unusual case, as
generally large amounts of data flow from the server to the client, not vice
versa.
This change contains two modifications to DDMReader, as well as some tests:
1) The Network Server method DDMReader.compressBLayerData was incorrect in
several respects. Rather than going through that code in detail, I noticed
that an almost identical version of this routine exists in the DerbyNetClient,
in the class Reply, and I am pretty confident that the client side code is
working, so I just wholesale modified the server's compressBLayerData method
so that it matched the client's method.
2) When the client is sending parameter data to the server, and the data to be
sent is a large array of bytes for a blob, the client, the client may send the
data inline as DRDA_TYPE_NVARBYTE, or it may externalize the data and send it
as DRDA_TYPE_NLOBBYTES. I believe that similar things happen with CLOB.
The client makes this decision based on the length of the data to be sent;
short values are sent inline, and long values are sent externalized.
When the server receives the data, it must decide whether it is reading an
inline string of bytes, or externalized data, and it, too, makes this decision
based on the length of the data. However, the server's code for this was
comparing the length of the byte string against the amount of data left in the
current segment, as opposed to comparing it against the constant threshold
value for switching from inline bytes to externalized bytes; hence if a long
byte string happened to start late in a buffer, and was then segmented
(continued) into a subsequent buffer, the server would mistakenly think the
byte string was being sent as externalized bytes, when in fact it was sent as
inline bytes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430077 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DDMReader.java",
"hunks": [
{
"added": [
"\t\tif (length < DssConstants.MAX_DSS_LENGTH)"
],
"header": "@@ -1321,7 +1321,7 @@ class DDMReader",
"removed": [
"\t\tif (length < dssLength)"
]
... |
derby-DERBY-1536-f6313172 | DERBY-1536: Extend tests for Wrapper interface
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@423800 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1537-17b031d5 | DERBY-1537: Don't put metadata.properties into derbytools.jar. Avoids boot-time
exception when running tests with derbytools.jar in front of derby.jar in the
classpath.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@427816 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/classlister.java",
"hunks": [
{
"added": [
" // The following block of code checks the package of each class",
" // scanned to see if there is a corresponding properties file",
" ... |
derby-DERBY-1538-4f5dc7df | DERBY-1538: Disable GRANT or REVOKE operations for object owners and raise an error when attempted. Also Database owner will not be able to revoke or grant access to object owners as well.
Submitted by Satheesh Bandaram (bandaram@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432929 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/PrivilegeNode.java",
"hunks": [
{
"added": [
"import java.util.List;"
],
"header": "@@ -35,6 +35,7 @@ import org.apache.derby.impl.sql.execute.PrivilegeInfo;",
"removed": []
},
{
"add... |
derby-DERBY-1539-08313de0 | DERBY-1539 Supports basic revoke functionality for triggers.
If revoke statement finds a trigger dependent on the table/column/routine
on which privilege is being revoked, the trigger will be dropped automatically.
Patch contributed by Mamta Satoor
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425836 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/depend/DependencyManager.java",
"hunks": [
{
"added": [
"\tis a general purpose interface which is associated with a"
],
"header": "@@ -31,7 +31,7 @@ import org.apache.derby.iapi.sql.conn.LanguageConnectionContext;",
... |
derby-DERBY-1554-0bf06221 | DERBY-1554: Revert IDENTITY_VAL_LOCAL() behavior on multi-row inserts to that seen in 10.1.3. Applying patch derby1554trunkdiff02.txt.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429425 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/InsertResultSet.java",
"hunks": [
{
"added": [
" // checks if source result set is a RowResultSet type.",
" private boolean isSingleRowResultSet()",
" {",
" boolean isRow = false;",... |
derby-DERBY-1555-03a99e2c | DERBY-1555 Change BaseJDBCTestCase.getXConnection() to getConnection and provide consistent initialization
of all connections returned by instance methods of BaseJDBCTestCase.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@434192 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1555-09ffc9bc | DERBY-1555 DERBY-1701 (partial) Convert more tests to use the instance based get[X]Connection method
or the static openDefault method.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432028 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1555-576a49fd | DERBY-1555 (partial) Minor cleanup on some JUnit tests, make the base test classes abstract.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@424135 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1555-7ebfefeb | DERBY-1555 DERBY-1701 (partial) Add utiltiy methods to BaseJDBCTestCase to get Statements, PreparedStatements against
the default connection for the test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432222 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1555-8f784a46 | DERBY-1555 DERBY-1562 (partial) Add new classes BaseJDBCTestSetup and JDBC to support
JDBC Unit test development.
BaseJDBCTestSetup is a TestSetup decorator for setup that uses JDBC.
JDBC class is a holder for JDBC test utility methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@424388 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/JDBC.java",
"hunks": [
{
"added": [
"/*",
" *",
" * Derby - Class org.apache.derbyTesting.functionTests.util.JDBC",
" *",
" * Copyright 2006 The Apache Software Foundation or it... |
derby-DERBY-1555-92f9877b | DERBY-1555 (partial) Add some top level JUnit suites that run all the tests in the packages (AllPackages),
all the tests in Embedded and (Derby) Client configurations and run All the configurations.
Also adds the logic in TestConfiguration to switch configurations to Client.
Just a checkpoint (incremental development), more work needed, see some failures running All.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@436957 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
"import java.lang.reflect.Method;"
],
"header": "@@ -20,6 +20,7 @@",
"removed": []
},
{
"added": [
" static void setCurrent(... |
derby-DERBY-1555-d57bbd3f | DERBY-1555 Add configuration decorator to change the default user for a configuaration
and use it in the NistScripts JUnit test. NistScripts is an initial pass at the setup of running
nist under JUnit, it fails at the moment in about a third of the test cases probably due to
output that is being sed'ed in the old harness and should not be.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@438299 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
" public static Test changeUserDecorator(Test test, String user, String password)",
" {",
" return new ChangeUserSetup(test, user, password);",
... |
derby-DERBY-1555-df2b52c0 | DERBY-1555 DERBY-1701 (partial) Change the name of the TestConfiguration methods to openConnection from getConnection.
Step to having BaseJDBCTestCase.getConnection() be a method matching BaseJDBCTestSetup.getConnection, a handle
to a default connection stored in the instance. This will remove a lot of code in the classes that extend BaseJDBCTestCase
that store a connection locally and have N different ways of cleaning it up.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431919 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/BaseJDBCTestSetup.java",
"hunks": [
{
"added": [
" * @see TestConfiguration#openDefaultConnection()"
],
"header": "@@ -60,7 +60,7 @@ public abstract class BaseJDBCTestSetup",
"removed": [
... |
derby-DERBY-1555-e0104e8b | DERBY-1555 (partial) Remove access and use of static variables to store the current test configuration.
Changed to use a ThreadLocal private to TestConfiguration and access to the current configuration
is through utility methods in the base classes or TestConfiguration.getCurrent().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@434257 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [],
"header": "@@ -43,9 +43,6 @@ final public class NetworkServerTestSetup extends TestSetup {",
"removed": [
" ",
" this.config = TestCon... |
derby-DERBY-1555-f308936b | DERBY-1555 (partial) Move the code to obtain a default connection into TestConfiuration
for the JUnit test setup to allow it to be shared across multiple classes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@424368 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestConfiguration.java",
"hunks": [
{
"added": [
"import java.sql.Connection;",
"import java.sql.DriverManager;",
"import java.sql.SQLException;"
],
"header": "@@ -20,6 +20,9 @@",
... |
derby-DERBY-1555-f7672a4a | DERBY-1555 Add some code to allow different JUnit TestConfigurations at start up based upon if the TestConfiguration
class determines it is running within the old harness or not. Add a utility method to allow JUnit suites or tests
to determine if they are running in the harness or not, and thus have temporary code to ease transistion from
the old harness. With this commit the code is setup to assume it's always running in the harness, need some
more testing to fully support this flag when running outside the harness.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@438975 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
" /**",
" * Default values for configurations",
" */",
" private final static String DEFAULT_DBNAME = \"wombat\";",
" privat... |
derby-DERBY-1555-fb2bfd52 | DERBY-1555 DERBY-1701 (partial) Incremental step in changing the tests that extend
SURBaseTest to use the single connection provided by BaseJDBCTestCase. Added
initialize method to BaseJDBCTestCase to allow tests to have a consistent
initial state for a connection. The SURBaseTest still has its con variable,
will be cleaned up in subsequent commits.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432438 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1555-ff658306 | DERBY-1555 DERBY-1701 (partial) Change the tests that extend SURBaseTest to use the utilitiy methods
rather than the con field from SURBaseTest to fit into the generic single connection model provided
by BaseJDBCTestCase. Incremental development, next step will be to remove the con field from SURBaseTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432450 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1555-ffe3f662 | DERBY-1555 DERBY-1701 (partial) Improve the BaseJDBCTest by adding support for a default connection
exactly like BaseJDBCTestSetup. Provides consistent handling for a connection in the common case
of a test using just one. Removes duplicated/inconistent code across many tests. First step
has the getConnection method called getXConnection until all the tests ahve stopped using the getConnection
static method and instead use the openDefaultConnection method.
Change the tests in jdbcapi to the new scheme.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431999 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1556-7d16ff3d | DERBY-1556 (partial) Add the initial implementation of a utility method in the JUnit JDBC class to drop a schema
and all of its objects. Will be called by a test decorator I will be committing soon.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430853 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/JDBC.java",
"hunks": [
{
"added": [
"\t/**",
"\t * Drop a database schema by dropping all objects in it",
"\t * and then executing DROP SCHEMA. If the schema is",
"\t * APP it is cleaned ... |
derby-DERBY-1556-f061ecd1 | DERBY-1556 (partial) Add an initial test decorator that cleans a database using the utility method JDBC.dropSchema.
More work is needed to drop functions, synonyms and handle dependencies between objects.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430867 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/CleanDatabaseTestSetup.java",
"hunks": [
{
"added": [
"/*",
" *",
" * Derby - Class org.apache.derbyTesting.functionTests.util.CleanDatabase",
" *",
" * Licensed to the Apache S... |
derby-DERBY-1563-c9a2190f | DERBY-1563: derbynet/ShutDownDBWhenNSShutsDownTest.junit fails on
Solaris sparc
The attached patch (derby-1563.diff) fixes the problem by waiting
before checking if the file exists.
Patch contributed by Fernanda Pizzorno.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425719 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1567-648e3486 | DERBY-3902; correct messages.xml and translated files for SQLState 2003.S.4
(was accidentally listed as 2004.S.4 - see also comment in DERBY-1567).
Also fix up MessageBundleTest to ignore two sqlstates that are not exposed to
the user so don't need text.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@703259 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1571-196bf05a | DERBY-1571: NetworkServerControlImpl.consoleExceptionPrintTrace()
prints stack trace even when logWriter is null
Made NetworkServerControlImpl.shutdown() set logWriter to a silent
stream instead of null to avoid printing stack traces of expected
exceptions during shutdown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425703 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"import java.io.FilterOutputStream;"
],
"header": "@@ -23,6 +23,7 @@ package org.apache.derby.impl.drda;",
"removed": []
},
{
"added": [... |
derby-DERBY-1573-265ba2fa | DERBY-1573: Unsafe synchronization in NetworkServerControlImpl
Contributed by Thomas Nielsen.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@549412 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
"\t\tPrintWriter lw = logWriter;",
"\t\tif (lw != null)",
"\t\t\tsynchronized (lw) {",
"\t\t\t\te.printStackTrace(lw);"
],
"header": "... |
derby-DERBY-1576-13d34b0c | DERBY-1576: Extend the CASE expression syntax for "simple case"
Forbid untyped parameters in the case operand.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1596492 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1576-2455f1ac | DERBY-1576: Extend the CASE expression syntax for "simple case"
Implement simple case as described by the SQL:1999 standard, including the
SQL:2003 extension F262 "Extended CASE expression", and the SQL:2011
extension F263 "Comma-separated predicates in simple CASE expression".
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1595778 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java",
"hunks": [
{
"added": [
" /**",
" * The case operand if this is a simple case expression. Otherwise, it",
" * is {@code null}.",
" */",
" private ... |
derby-DERBY-1576-2bd5cbdb | DERBY-1576: Extend the CASE expression syntax for "simple case"
Allow untyped parameters in the case operand.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1598472 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.Visitable;"
],
"header": "@@ -32,6 +32,7 @@ import org.apache.derby.iapi.services.context.ContextManager;",
"remov... |
derby-DERBY-1576-d75118e9 | DERBY-1576: Extend the CASE expression syntax for "simple case"
Add test cases for subqueries.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1597082 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1576-f2dfe060 | DERBY-1576: Extend the CASE expression syntax for "simple case"
Cache the case operand so that it is only evaluated once per
evaluation of the CASE expression.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1597979 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java",
"hunks": [
{
"added": [
" private CachedValueNode caseOperand;"
],
"header": "@@ -50,7 +50,7 @@ class ConditionalNode extends ValueNode",
"removed": [
" private Val... |
derby-DERBY-158-02e0ae52 | Fix for DERBY-158 PRIMARY KEY does not imply NOT NULL
Columns specified in a PRIMARY KEY constraint in CREATE TABLE
are implicitly set to NOT NULL per the SQL spec.
If a PRIMARY KEY constraint is added using ALTER TABLE then all
columns must also be NOT NULL. Similarly, columns
specified in a UNIQUE constraint must still be explictly NOT NULL.
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@156570 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/TableElementList.java",
"hunks": [
{
"added": [],
"header": "@@ -33,7 +33,6 @@ import org.apache.derby.iapi.sql.dictionary.ConstraintDescriptor;",
"removed": [
"import org.apache.derby.iapi.sql.dictionary.Column... |
derby-DERBY-1581-4eece411 | DERBY-1581 (partial) Clean-up some descriptor objects as a step to ensuring their identity is immutable
once created and/or fully populated. Remove some unused methods.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425116 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConstraintDescriptor.java",
"hunks": [
{
"added": [
"\tfinal String\t\t\t\tconstraintName;",
"\tprivate final boolean\t\t\t\tdeferrable;",
"\tprivate final boolean\t\t\t\tinitiallyDeferred;",
"\... |
derby-DERBY-1581-55de888a | DERBY-1581 Avoid reloading the Provider from the data dictionary when
executing an invalidateFor on the Provider. Previosuly the code
when loading the stored dependencies and converting them to an in-memory from
reloaded the provider once per dependent. This patch re-uses the Provider
passed into the invalidateFor method.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425479 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/depend/BasicDependencyManager.java",
"hunks": [
{
"added": [
"\t * @param providerForList The provider if this list is being created",
"\t * for a list of dependents. Null otherwise.",
"\tpriv... |
derby-DERBY-1585-0f450705 | DERBY-3304
DERBY-3037
DERBY-1585
I am adding a test case to check for the resultset from the java procedure call when the
java procedure has done a rollback inside it. This test shows that in trunk, after checkin
602991 for DERBY-1585, a procedure does not return a resultset if there was a rollbck
inside the procedure with resultset creation before rollback. This behavior is different
than what happens in 10.2 codeline. In 10.2, a procedure will return a *closed* resultset
if there was a rollback inside the procedure. But a procedure should not return closed
result sets, so it appears that trunk is behaving correctly and 10.2's behavior was
incorrect.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@628130 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" * Assert that the statement has no more results(getMoreResults) and it ",
" * indeed does not return any resultsets(by checking getResultSet). ",
" * Also, ensu... |
derby-DERBY-1585-5b2b352a | DERBY-1585 For a CALL statement that generates dynamic result sets add code so that the result sets are closed if they are inaccessible following the SQL Standard.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@602991 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/jdbc/ConnectionContext.java",
"hunks": [
{
"added": [],
"header": "@@ -21,7 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.error.StandardException;"
]
}
]
},
{
"file": "java/engine/org/apach... |
derby-DERBY-1586-5d18b03d | DERBY-1586 (partial) The attributesAsPassword property doesn't work
correctly with EmbeddedConnectionPoolDataSource
This patch adds a JUnit test which reproduces the bug. The test is not
run in any suite since the bug is not fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@425385 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1589-52a0f73d | DERBY-3376: Test case in GrantRevokeDDLTest commented out
This change adds some additional tests to GrantRevokeDDLTest.
The test cases were originally contributed by Yip Ng (yipng168 at gmail dot com)
The tests were originally written during buddy testing of Derby 10.2, and
were committed as part of DERBY-1736, but were commented out at the
time due to DERBY-1589. The test cases now pass, and so this change
enables the tests as part of GrantRevokeDDLTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@831762 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1595-3f3312eb | DERBY-1595: Network server fails with DRDAProtocolException if a BLOB with size 2147483647 is streamed from client
Switched from int to long when dealing with scalar streams, which can be longer
than Integer.MAX_VALUE and cause arithmetic overflow.
Introduced 'nullIndicatorSize' to duplicate less code.
Patch file: derby-1595-2a-client_int_overflow.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@958939 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/Request.java",
"hunks": [
{
"added": [
"import org.apache.derby.client.am.DateTimeValue;",
"import org.apache.derby.shared.common.sanity.SanityManager;",
"import java.io.IOException;"
],
"header": ... |
derby-DERBY-1595-53795a1a | DERBY-1595 (partial): Network server fails with DRDAProtocolException if a BLOB with size 2147483647 is streamed from client
Fixed protocol disagreement, where the client sent eight bytes for the
extended length bytes and the server expected six bytes (changed the client
behavior).
Patch file: derby-1595-1a-client_write6bytes.diff
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@955540 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/SignedBinary.java",
"hunks": [
{
"added": [
" /** Maximum value that cen be encoded by 6 bytes (signed). */",
" public static final long MAX_LONG_6_BYTES_SIGNED = 0x7FFFFFFFFFFFL;",
""
],
"hea... |
derby-DERBY-1605-82cb66b5 | DERBY-1605: To determine whether or not JVM has JDBC4, compare with
java.specification.version, not java.vm.version.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@427193 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1609-2b477108 | DERBY-1609 (partial) Have ij.runScript use utilMain directly, rather than Main,
to avoid one additional object.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@426893 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/tools/ij.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.tools.ij.utilMain;"
],
"header": "@@ -26,6 +26,7 @@ import org.apache.derby.iapi.tools.i18n.LocalizedOutput;",
"removed": []
},
{
"... |
derby-DERBY-1609-2d5faea2 | DERBY-1609 (partial) Minor cleanup in ij.Main.java, remove unused field & method
and make two public fields private.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@426671 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/Main.java",
"hunks": [
{
"added": [
"\tprivate LocalizedOutput out;",
"\tprivate utilMain utilInstance;"
],
"header": "@@ -57,11 +57,8 @@ import java.util.*;",
"removed": [
"\tpublic Loca... |
derby-DERBY-1609-351dad86 | DERBY-1609 (partial) Fix a security exception reading the system property ij.showErrorCode.
Add code to return an error count for runScript (still needs to be tested).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433273 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/utilMain.java",
"hunks": [
{
"added": [
"\t/**",
"\t * True if to display the error code when",
"\t * displaying a SQLException.",
"\t */",
"\tprivate final boolean showErrorCode;"
],... |
derby-DERBY-1609-43e6994a | DERBY-1609 (partial) Move initializing connections from system properties
in ij's utilMain into a separate method from the constructor. Allows ij's
runScript method to create a constructor without creating unrequired
connections based upon System properties.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@427293 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/Main.java",
"hunks": [
{
"added": [],
"header": "@@ -57,7 +57,6 @@ import java.util.*;",
"removed": [
"\tprivate LocalizedOutput out;"
]
},
{
"added": [
"\tprivate void go(Local... |
derby-DERBY-1609-79b6c666 | DERBY-1609 (partial) Remove some unused code in JDBCDisplayUtil.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433274 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/tools/JDBCDisplayUtil.java",
"hunks": [
{
"added": [],
"header": "@@ -67,40 +67,6 @@ public class JDBCDisplayUtil {",
"removed": [
"",
"\t//-----------------------------------------------------------------",
"... |
derby-DERBY-1609-95011a07 | DERBY-1609 Add IJRunScriptTest and _Suite JUnit tests for the testing of ij.runScript.
Modify runScript to take an OutputStream instead of a PrintStream, fix it to
correctly return the number of errors seen while running the script.
Add utility methods to BaseJDBCTestCase to run setup scripts from an InputStream or a String.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433331 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/utilMain.java",
"hunks": [
{
"added": [
" ",
" /**",
" * Value of the system property ij.execptionTrace",
" */",
" private final String ijExceptionTrace;"
],
... |
derby-DERBY-1609-a5a98ce8 | DERBY-1609 (partial) Add a runScript method to ij. Initial version runs a script
successfully using the passed in connection. More work is needed to avoid the
standard ij startup which opens connections and to return the number of errors.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@426849 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/iapi/tools/i18n/LocalizedResource.java",
"hunks": [
{
"added": [
"\tprivate static final boolean HAVE_BIG_DECIMAL;",
"\tstatic {"
],
"header": "@@ -44,9 +44,9 @@ import java.sql.Types;",
"removed": [
"... |
derby-DERBY-1610-211c9859 | - DERBY-1610 Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Fix to resolve error in jdk13 test of compatibility suite - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@454098 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/PreparedStatement.java",
"hunks": [
{
"added": [
" final int paramType = getColumnMetaDataX().getColumnType(parameterIndex) ;"
],
"header": "@@ -405,7 +405,7 @@ public class PreparedStatement extends Sta... |
derby-DERBY-1610-486f51a8 | - DERBY-1610 Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@453886 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/PreparedStatement.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.sanity.SanityManager;",
"import java.util.Arrays;"
],
"header": "@@ -23,11 +23,13 @@ package org.apache.derby.client.am;... |
derby-DERBY-1610-a2006aed | DERBY-1610: Resolve difference of type compatibility between Embedded
and NetworkServer/NetworkDriver
Fixed failures in the JDBC 4.0 tests. Description of the patch:
* Check for unsupported types before checking incompatibilities
since JDBC 4.0 specifies that SQLFeatureNotSupportedException
should be raised for certain types if they are unsupported.
* Change timing of calls to checkForClosedStatement() to make
ClosedObjectTest get the expected SQLState when the statement is
closed.
* Add type checking to the JDBC 4.0 length-less blob/clob overloads.
* Since the type checking already checks for closed statement and
invalid parameter index, remove those tests from
checkSetterPreconditions(). Since the only code that is left in
checkSetterPreconditions() after the removal of those checks is a
call to checkForEscapedCallWithResult(), replace all calls to
checkSetterPreconditions() with calls to
checkForEscapedCallWithResult().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@462784 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/PreparedStatement.java",
"hunks": [
{
"added": [
"",
" checkForClosedStatement();",
"",
" // JDBC 4.0 requires us to throw",
" // SQLFeatureNotSuppor... |
derby-DERBY-1610-bc52552f | - DERBY-1610 Resolve difference of type compatibility between Embedded and NetworkServer/NetworkDriver - adjust index for parameter using checkForEscapedCallWithResult method. - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@454312 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/PreparedStatement.java",
"hunks": [
{
"added": [
" final int paramType = ",
" getColumnMetaDataX().getColumnType( checkForEscapedCallWithResult(parameterIndex) ) ;"
],
"heade... |
derby-DERBY-1612-e87a9fde | DERBY-1612 (partial) If revoke statement finds a constraint dependent on the table/column on which privilege
is being revoked, the constraint will be dropped automatically. This functionality is similar to what is
supported for triggers and views. And just like triggers and views, more work is required so that constraint will get
dropped only if it depends on the particular privilege TYPE or particular column that is being revoked.
Patch contributed by Mamta Satoor.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@428801 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConstraintDescriptor.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.sql.execute.DropConstraintConstantAction;",
""
],
"header": "@@ -35,6 +35,8 @@ import org.apache.derby.iapi.services... |
derby-DERBY-1614-fe549441 | DERBY-1614: Do not set any heap size flags or network server apart from those
specified by the jvmflags property.
Committed for John Embretsen <John.Embretsen@sun.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429550 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/NetServer.java",
"hunks": [
{
"added": [
" // Set no flags by default (DERBY-1614).",
" // The jvmflags property can be used to set any kind of JVM option."
],
"heade... |
derby-DERBY-1618-479e2bca |
DERBY-1618: (store/BootAllTest.junit fails on with jdk13 based jvms)
Patch Contributed by Myrna van Lunteren.
On jdk131, in the situation invoked by the testSettingBootAllPropertyWithHomePropertySet()
test in BootAllTest.java, when the DriverPropertyInfo.choices were accessed.
the problem was because in BaseMonitor.java there were no elements found resulting from
provider.getBootTimeServices().
underlying real issue was database directory was not getting set to the
correct path in the storage factory (DirStorageFactory.java), when all the
database are loaded (derby.system.bootAll=true) and system home is set.
This patch correctly sets the database directory in the storage factory, in the
above mentioed scenario.
Modified the test lang/GetPropertyInfoTest.java to access the choices,
description, and required fields, but it didn't actually duplicate the problem
in BootAllTest.java. But as that's in that test I thought it was unnecessary to
add more.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@443038 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1620-a1d6109b | DERBY-1620: Minor cleanup to follow svn # 520173, plus a new JUnit test to
verify the behavior fixed with DERBY-1620.
Contributed by: John Peterson (john.peterson@pega.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@544974 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java",
"hunks": [
{
"added": [
"\t/**",
"\t * Checks if the provided node is a CastNode.",
"\t *",
"\t * @param node\tThe node to check.",
"\t * @return \t\tTrue if this n... |
derby-DERBY-1620-fa3b4252 | DERBY-1620: Changes to look more closely at the "then" and "else" nodes
of an SQL CASE statement and, in situations where one or more SQL NULLs
exist, to cast the NULLs to an appropriate type (instead of just casting
them to CHAR, which is what Derby did previously).
Contributed by: John Peterson (john.peterson@pega.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@520173 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java",
"hunks": [
{
"added": [
"\tprivate boolean isCastNode(ValueNode node) {",
"\t\tif (node.getNodeType() == C_NodeTypes.CAST_NODE)",
"\t\t\treturn true;",
"\t\telse",
... |
derby-DERBY-1621-3d7a3d4b | DERBY-1621: Commit derby1621trunkdiff04.txt, causing recompilation of trigger actions after ddl.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@434046 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/depend/DependencyManager.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.store.access.TransactionController;"
],
"header": "@@ -27,6 +27,7 @@ import org.apache.derby.iapi.error.StandardException;",
... |
derby-DERBY-1623-a0f12c0e | DERBY-1623: Fix javadoc errors caused by svn 546183.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@546652 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLChar.java",
"hunks": [
{
"added": [
"\t *",
"\t * @param trimType Type of trim (LEADING, TRAILING, or BOTH)",
"\t * @param trimChar Character to trim",
"\t * @param source String from which to tr... |
derby-DERBY-1630-ff5c96fc | DERBY-1630: Remove reference to engine class in NetConnection40. Generate
client exception using client.am.SqlException.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@428065 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnection40.java",
"hunks": [
{
"added": [
"import java.sql.SQLClientInfoException;"
],
"header": "@@ -26,12 +26,12 @@ import java.sql.QueryObjectFactory;",
"removed": [
"import java.sql.SQLClien... |
derby-DERBY-1633-cafb31f9 | DERBY-1681, submitted by Army Brown
Fixes the following issue:
If Derby chooses to do a join between two FromTables and the right table is a chain of UNIONs, then the optimizer may choose to push the join predicate (if provided) down into the UNION and to both children of every UNION in the chain. But if the predicate cannot be pushed to the children of any of the UNIONs (except the top-level one) the predicate can end up being ignored altogether with respect to that UNION's children. The result is that query execution can return rows that do not satisfy the predicate.
This is a regression introduced in 10.1.2.4 and thus it affects 10.1.3 and 10.2. I came across this while tracing through code for DERBY-1633.
For more detailed explanation of problem and solution see html doc attached to
DERBY-1681.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432367 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SetOperatorNode.java",
"hunks": [
{
"added": [
"\t\t/* Now see if there are any left over predicates; if so, then we",
"\t\t * have to generate a ProjectRestrictNode. Note: we walk the",
"\t\t * entire chai... |
derby-DERBY-1633-df88f639 | DERBY-1633: Commit Army's d1633_v3 patches, fixing the regression introduced by DERBY-805 in the behavior of views that involve joins.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@434111 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryRelationalOperatorNode.java",
"hunks": [
{
"added": [
"\t * exactly one operand in the predicate to which this operator belongs"
],
"header": "@@ -1267,7 +1267,7 @@ public class BinaryRelationalOperatorNod... |
derby-DERBY-1638-481d0c6d | DERBY-1638 Add methods to JDBC for JUnit that indicates if the virtual machine environment
supports JDBC 2,3 or 4 and JSR169. Naming of methods indicates that the define the vm
level of support rather than the clients level.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429154 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestConfiguration.java",
"hunks": [
{
"added": [],
"header": "@@ -25,8 +25,6 @@ import java.sql.DriverManager;",
"removed": [
"import org.apache.derby.iapi.services.info.JVMInfo;",
""
... |
derby-DERBY-1643-71408abc | DERBY-1643 Rename the Dependency manager invalidation constant to represent its use of revoke restrict.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430170 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConstraintDescriptor.java",
"hunks": [
{
"added": [
"\t\t\t//When REVOKE_PRIVILEGE gets sent (this happens for privilege ",
"\t\t\t//types SELECT, UPDATE, DELETE, INSERT, REFERENCES, TRIGGER), we ",
"\t\... |
derby-DERBY-1643-f8fa8cfa | DERBY-1643 In Derby, the execute permission on a routine can't be revoked as long as there are dependent objects
relying on that permissions. This patch implements that behavior by adding a new revoke invalidation action
REVOKE_EXECUTE_PRIVILEGE, just for routine revoke. This invalidation gets sent when a revoke execute is issued.
When dependents, a ViewDescriptor and/or a TriggerDescriptor, get this invalidation action, they will
raise error that revoke execute can't be performed because there is a dependent object on that permission.
Patch submitted by Mamta Satoor
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@428930 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ConstraintDescriptor.java",
"hunks": [
{
"added": [
"\t\t\t//Notice that REVOKE_EXECUTE_PRIVILEGE is not included here.",
"\t\t\t//In Derby, at this point, a constraint can't depend on a ",
"\t\t //rou... |
derby-DERBY-1644-0958c84f | DERBY-1644: NPE when inserting values to tbl w/ identity col gen by default
When the VALUES clause encounters multiple rows, it generates a UNION
node tree to combine the rows to be inserted. InsertNode notices the
top-level UNION node and calls the special checkAutoincrementUnion()
method which knows how to recursively traverse the Union tree and
call checkAutoIncrement() on the underlying RowResultSetNode instances
at the leaf level of the tree.
HOWEVER, when the number of columns in the rows in the VALUES clause
is a subset of the number of columns in the table we're inserting into,
the top node of the tree is not a UnionNode, but is rather a
ProjectRestrictNode. This means that we skip past the UnionNode test and
just call checkAutoincrement(), which processes the PRN but doesn't
go down to the RowResultSetNode(s) at the leaf level.
This leaves the ResultColumn instance at the leaf level with a NULL column
descriptor, which causes the NPE during the code generation phase.
And, there is a second, related problem. The enhanceRCLForInsert() call
is also only made at the top level of the tree. However, this call is a
necessary pre-condition for calling checkAutoincrement() because
enhanceRCLForInsert() ensures that the proper ResultColumnList values are
in place prior to the checkAutoincrement() reconciliation of the column lists.
The patch solves these problems by merging the code from InsertNode.bind
together with the current recursive processing in
ResultColumnList.checkAutoincrementUnion() to produce a new recursive
routine, which I have called enhanceAndCheckForAutoincrement(), which will
recursively traverse the ResultSet tree, calling *both* enhanceRCLForInsert()
and checkAutoincrement() on the various nodes in the tree.
Thus the primary ideas involved in this patch are:
- When an INSERT statement will insert multiple rows from the VALUES
clause, the compiler will compile the various values into a tree of
UnionNodes with RowResultSetNodes at the leaves of the three
- The columns specified in the INSERT statement may be a subset
of the rows in the table. The "extra" columns need to be constructed by
the INSERT statement, either by generating NULL values for those
columns which are nullable, or by compiling a default values for those
columns which have DEFAULT values, or by generating a value for an IDENTITY
column which is GENERATED. The work of constructing these extra
column values is done by genNewRCForInsert.
- For columns which are GENERATED ALWAYS, we must make sure that
the INSERT statement doesn't allow the user to insert their own value for
the generated column.
- The columns which are specified in the INSERT column spec may not match
the order in which the columns arise in the table. Therefore, the column
values may need to be re-ordered by the INSERT statement so that they
occur in the proper order.
- In the case when the ResultSet which provides the values for the INSERT
statement is not just a single node, but is rather a tree of UnionNodes, the
above processing needs to happen throughout the tree, not just at
the root node.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@487414 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [
"\t\tenhanceAndCheckForAutoincrement(resultSet, inOrder,",
"\t\t\t\tnumTableColumns, colMap, dataDictionary,",
"\t\t\t\ttargetTableDescriptor, targetVTI);"
]... |
derby-DERBY-1644-a8db6658 | DERBY-4442: Default value and identity in an INSERT result set evaluated too early
Always add a ProjectRestrictNode on top of the source result set for an
insert if the source columns are not ordered the same way as the target
columns, or if inserting into a subset of the columns, and the source is not
a table constructor. Then the adding of default values to the source result
column list happens on top of the original source result node, and not
inside that node. This means that the source result is produced before the
default values are added, and the generation of the defaults happens at the
correct time.
As a side-effect, these other issues are fixed:
DERBY-3 Identity column not filled consecutively with "insert ... select distinct"
DERBY-4433 Cannot insert from EXCEPT/INTERSECT when target table has more columns than the source
Much of the added code is actually old code revived from the Subversion
history. Before DERBY-1644, we used to put a ProjectRestrictNode on top of
the source result if it was a SetOperatorNode. The code that inserted the
ProjectRestrictNode was added back and changed to operate on ResultSetNode
instead of SetOperatorNode.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@885421 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [
"\t\tresultSet = enhanceAndCheckForAutoincrement(resultSet, inOrder, colMap);"
],
"header": "@@ -411,9 +411,7 @@ public final class InsertNode extends DMLModStatementNod... |
derby-DERBY-1652-dd2accde | DERBY-1652, submitted by Yip Ng
The cause of the problem is that the trigger descriptor is created after the stored prepared statement(SPS) has been compiled, so the compiled form of the SPS is not aware of that its trigger action can fire on the trigger table itself. Hence, the constant action was not generated correctly.
During upgrade, the SPSs are invalidated at database boot time. The SPS will be recompile when it is being invoked and the recompilation at this point will of course detect the relevent trigger and generate the correct constant action for the SPS and produce the expected behavior when the SPS is executed - throwing an error when it exceeds the trigger's maximum depth in the above case.
The simplest solution without introducing another revalidation of the SPS is to create the trigger descriptor first before compiling the SPS. I ran derbyall and had to go over the testcases which have the wrong master outputs and I have corrected them on this patch.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431698 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/CreateTriggerConstantAction.java",
"hunks": [
{
"added": [
"\t\tactionSPSId = (actionSPSId == null) ? ",
"\t\t\tdd.getUUIDFactory().createUUID() : actionSPSId;",
" ",
"\t\t** Create the trigger des... |
derby-DERBY-1664-621d67a1 | DERBY-1664: (Partial) This is the first pass at a test that can be used
to gauge how long it takes to do each part of the startup process.
This could likely be extended to also test how long it takes to create
tables of different size, how long it takes to insert rows, etc.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431395 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/JarUtil.java",
"hunks": [
{
"added": [
"/*",
" ",
" Derby - Class org.apache.derbyTesting.functionTests.util.JartUtil",
" ",
" Licensed to the Apache Software Foundation (AS... |
derby-DERBY-1665-e38e660c | DERBY-1665 (partial): fix formatting of javadoc for iapi.store.access.Qualifier.
The content of the javadoc for this class needs a review to address the other
comments in this JIRA issue.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@446536 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/Qualifier.java",
"hunks": [
{
"added": [
" <p>"
],
"header": "@@ -26,7 +26,7 @@ import org.apache.derby.iapi.types.DataValueDescriptor;",
"removed": [
""
]
},
{
"a... |
derby-DERBY-1674-55f1cc92 | DERBY-1674 (partial) Move PermissionsCatalogRowFactory into its correct location under impl/sql/catalog.
System tables are a detail of the catalog implementation, not the dictionary api. The class was only ever referenced
in the impl/sql/catalog package.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432972 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -29,7 +29,6 @@ import org.apache.derby.iapi.sql.conn.Authorizer;",
"removed": [
"import org.apache.derby.iapi.sql.dictionary.PermissionsCatalogRo... |
derby-DERBY-1674-5b76a527 | DERBY-1674 (partial) Remove IndexScan class from impl.sql.catalog as it is never used.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433685 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/IndexScan.java",
"hunks": [
{
"added": [],
"header": "@@ -1,198 +0,0 @@",
"removed": [
"/*",
"",
" Derby - Class org.apache.derby.impl.sql.catalog.IndexScan",
"",
" Li... |
derby-DERBY-1674-7aa6fa86 | DERBY-1674 (partial) CatalogRowFactory.buildEmptyIndexRow() row was implemented in all the sub-classes but could
never be called, except for SYSTABLESRowFactory. Seen by code inspection and double checked with the code
coverage. Remove all the methods (except SYSTABLESRowFactory) and abstract definition in CatalogRowFactory.
Changed DataDictionaryImpl to call buildEmptyIndexRow using a reference to SYSTABLESRowFactory since it
was special case code for SYSTABLES.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@434100 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/SYSTABLESRowFactory.java",
"hunks": [
{
"added": [
"class SYSTABLESRowFactory extends CatalogRowFactory"
],
"header": "@@ -55,7 +55,7 @@ import org.apache.derby.iapi.services.uuid.UUIDFactory;",
"removed... |
derby-DERBY-1674-8d26d289 | DERBY-1674 (partial) Remove TabInfo interface as the implementation of system tables is private to the impl/sql/catalog package.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@437823 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/TabInfoImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -30,7 +30,6 @@ import org.apache.derby.iapi.sql.conn.LanguageConnectionContext;",
"removed": [
"import org.apache.derby.iapi.sql.dictionary.TabInfo;"
... |
derby-DERBY-1674-a7d7f12f | DERBY-1674 Remove some unused methods related to TabInfo classes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433632 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDictionary.java",
"hunks": [
{
"added": [],
"header": "@@ -272,21 +272,6 @@ public interface DataDictionary",
"removed": [
"\t/**",
" \t *\tGet the tabinfo of a system catalog. Paw through the ... |
derby-DERBY-1674-c4c6000f | DERBY-1674 (partial) Clean up SystemColumn interface and implementation to hold the data type of
the column using the standard DataTypeDescriptor class rather than individual fields.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432895 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/SystemColumn.java",
"hunks": [
{
"added": [
"",
""
],
"header": "@@ -20,10 +20,9 @@",
"removed": [
"import org.apache.derby.iapi.error.StandardException;",
"import org.ap... |
derby-DERBY-1674-f7e090fc | DERBY-1674 (partial) Step towards removing iapi.sql.dictionary.TabInfo as its implementation TabInfoImpl
should be package private to impl.sql.catalog. All references now use TabInfoImpl directly instead
of TabInfo. Next step is to move the javadoc comments from TabInfo into TabInfoImpl and remove the class.
Simplify TabInfoImpl and IndexInfoImpl to not duplicate variables from CatalogRowFactory.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433688 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java",
"hunks": [
{
"added": [],
"header": "@@ -30,7 +30,6 @@ import org.apache.derby.iapi.sql.dictionary.ConglomerateDescriptor;",
"removed": [
"import org.apache.derby.iapi.sql.dictionary.TabInfo;"
... |
derby-DERBY-1675-3c53f6c2 | DERBY-1675: Network Server should not send to client that it supports
EUSRIDPWD when running against Sun JVM
Updating comments. Patch contributed by Sunitha Kambhampati.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@441779 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" /**",
" * Can EUSRIDPWD security mechanism be used with ",
" * the current JVM",
" */",
" /*",
" * DRDA Sp... |
derby-DERBY-1675-b4e48e9c | DERBY-1675
contributed by Sunitha Kambhampati
USRIDPWD support depends on the JCE available in the classpath of the server
This patch(derby1675.diff.txt) does the following
1. Add code to check if server jvm can support EUSRIDPWD.
2. Throw an error if the derby.drda.securityMechanism is set to ENCRYPTED_USER_AND_PASSWORD_SECURITY
and if the server jvm cannot support EUSRIDPWD.
3. Server sends the client the list of supported security mechanisms as part of ACCSECRD. Now, the server will correctly only send EUSRIDPWD as an option if the running server can support this security mechanism.
Test related changes:
Changes were made to testProtocol.java and a new method readSecMecAndSECCHKCD is added to TestProto to read the SECMEC and SECCHKCD values. Note, that with ibm142 and ibm15 jvms that support eusridpwd, the SECMEC value 9 (eusridpwd) will be sent as part of the ACCSECRD response. But for the jvms that dont support the eusridpwd, the SECMEC value of 9 wont be sent. The new method readSecMecAndSECCHKCD takes
care of printing out the SECMEC values that are sent by the server - this results in the need for a new master file for the jvm that support eusridpwd and the jvm that cannot support it. A new master file has been added for ibm14.
Tests for codepath that covers #2 is already present in testSecMec.java. This results in themaster updates for the jvms that do not support eusridpwd for the case where server is started with
derby..drda.securityMechanism=ENCRYPTED_USER_AND_PASSWORD_SECURITY.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@441722 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" if (((securityMechanism != CodePoint.SECMEC_EUSRIDPWD) ||",
" (securityMechanism == CodePoint.SECMEC_EUSRIDPWD && ",
... |
derby-DERBY-1681-cafb31f9 | DERBY-1681, submitted by Army Brown
Fixes the following issue:
If Derby chooses to do a join between two FromTables and the right table is a chain of UNIONs, then the optimizer may choose to push the join predicate (if provided) down into the UNION and to both children of every UNION in the chain. But if the predicate cannot be pushed to the children of any of the UNIONs (except the top-level one) the predicate can end up being ignored altogether with respect to that UNION's children. The result is that query execution can return rows that do not satisfy the predicate.
This is a regression introduced in 10.1.2.4 and thus it affects 10.1.3 and 10.2. I came across this while tracing through code for DERBY-1633.
For more detailed explanation of problem and solution see html doc attached to
DERBY-1681.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432367 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SetOperatorNode.java",
"hunks": [
{
"added": [
"\t\t/* Now see if there are any left over predicates; if so, then we",
"\t\t * have to generate a ProjectRestrictNode. Note: we walk the",
"\t\t * entire chai... |
derby-DERBY-1686-17f76265 | DERBY-1686 The original fix retrieves all the relevent providers such as table, view, and routine descriptor(s)
of the given view at bind time and pass this information to runtime later
for it to determine if the privilege is grantable or not by the grantor.
Patch contributed by Yip Ng - yipng168@gmail.com
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@441131 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
" return getUncachedTablePermsDescriptor( key );"
],
"header": "@@ -9968,7 +9968,7 @@ public final class\tDataDictionaryImpl",
"removed": [
... |
derby-DERBY-1688-cc8ea120 | DERBY-1688: ConsistencyToken.hashCode() is not thread safe
Rewrite the method to use a thread-safe approach as suggested by The
"Double-Checked Locking is Broken" Declaration.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431603 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/ConsistencyToken.java",
"hunks": [
{
"added": [
" // ConsistencyToken objects might be kept for a long time and are",
" // frequently used as keys in hash tables. Therefore, it is a good idea",
" ... |
derby-DERBY-1691-c4ce097d | DERBY-1691 blobclob4BLOB.java fails under DerbyNet framework. Fixed by printing stack traces to stdout. Contributed by Oystein.Grovlen@sun.com
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@442199 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1694-02a8e2e3 | DERBY-1694
contributed by Sunitha Kambhampati
I was looking at the testProperties issue that caused problems because of test hang. The test doesnt hang in my environment but I thought I would look to see why the test didnt timeout.
I found couple of issues here:
0. The testProperties.java and several networkserver tests exec new processes to start server, test properties,shutdown server etc. In some cases, we wait to capture the output from the subprocess that is started. ProcessStreamResult is used for this purpose. ProcessStreamResult is part of the harness (see org.apache.derbyTesting.functionTests.harness.ProcessStreamResult) and it starts a thread to read data from the process's stream and writes it out. Once EOS (-1) is reached, the thread exits after doing a notifyAll.
1. ProcessStreamResult.Wait() does not work with the timeout case. I think the original intention of the method that takes the timeout was to force the thread to stop, once the timeout period has elapsed. The method Wait() does not handle this case.
2. On timeout, the myThread needs to stop its work. The run() method does not handle this case.
3. testProperties test does not make use of the ProcessStreamResult timeout mechanism.
4. Process's are exec'd in the tests and they are not destroyed within a timeout period. The network server tests start server using Process, and then cleanup by shutting them down. It will all work ok, if no deadlock or blocking of process's occur. It seems to me though, that we should have a way to destroy the processes that are
started as part of each test given a timeout period. Each test must learn to do the cleanup when it leaves and the test has knowledge of all the sub-processes that it has exec'd. The current test harness has a class TimedProcess which could work.
In the spirit of incremental development, I am attaching a patch(derby1694.p2.diff.txt and corresponding stat file - derby1694.p2.stat.txt) that fixes problems 1,2 and 3. I think #4 can be handled as a separate issue/patch.
This patch
-- fixes the timeout handling in ProcessStreamResult. Instance variable 'interrupted' is a flag to indicate if a timeout has occurred or if the thread's work has been interrupted in between. The flag 'finished' indicates whether the work has been finished by the thread. Changes are in Wait() method to make use of wait(timeoutms) if a timeout is specified in ProcessStreamResult. If timeout time has elapsed, then the interrupted flag is set to true.
-- Adds condition in the run() method to check if interrupted is true. If so, the thread will stop its work and leave.
-- correctly return if the thread's work was interrupted either because of a timeout or if it was interrupted.
-- Make use of the ProcessStreamResult with a timeout setting of 2 minutes in testProperties test. Note, the timeout handling only comes into effect when ProcessStreamResult.Wait() method is called.
other notes:
-- when you run a test, the suite property for timeout does not get picked up. I think this is intentional behavior.
-- Issues mentioned above are not specific to just testProperties but exist for other networkserver tests. There are a total of 7 files in derbynet that make use of this.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@447736 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/ProcessStreamResult.java",
"hunks": [
{
"added": [
"",
" /**",
" * Flag to find out if the work was finished ",
" * successfully without being interrupted ",
" ... |
derby-DERBY-1694-68a8fb10 | DERBY-1694 Cleanup derbynet/testProperties so that it always handles the output from the processes it forks.
Not handling the output can lead to hangs according to the javadoc for java.lang.Process.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431697 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-1698-b9df96ab | DERBY-1698, contributed by Deepa Remesh
adds an additional test to jdbcapi/SetQueryTimeoutTest.java. This patch adds a test for executeUpdate method call.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@436904 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-170-505bb8a1 | DERBY-1533: ArrayIndexOutOfBoundsException in DDMReader
DERBY-1533 follows in a series of bugs (DERBY-170, DERBY-428, DERBY-491,
DERBY-492, DERBY-614 among others) which have to do with the particulars of
the DRDA protocols used for handling long messages and large amounts of data.
In this particular issue, the problems involve the situation in which the
server is receiving a message which is segmented across multiple layer A
blocks using DSS continuations. This is a relatively unusual case, as
generally large amounts of data flow from the server to the client, not vice
versa.
This change contains two modifications to DDMReader, as well as some tests:
1) The Network Server method DDMReader.compressBLayerData was incorrect in
several respects. Rather than going through that code in detail, I noticed
that an almost identical version of this routine exists in the DerbyNetClient,
in the class Reply, and I am pretty confident that the client side code is
working, so I just wholesale modified the server's compressBLayerData method
so that it matched the client's method.
2) When the client is sending parameter data to the server, and the data to be
sent is a large array of bytes for a blob, the client, the client may send the
data inline as DRDA_TYPE_NVARBYTE, or it may externalize the data and send it
as DRDA_TYPE_NLOBBYTES. I believe that similar things happen with CLOB.
The client makes this decision based on the length of the data to be sent;
short values are sent inline, and long values are sent externalized.
When the server receives the data, it must decide whether it is reading an
inline string of bytes, or externalized data, and it, too, makes this decision
based on the length of the data. However, the server's code for this was
comparing the length of the byte string against the amount of data left in the
current segment, as opposed to comparing it against the constant threshold
value for switching from inline bytes to externalized bytes; hence if a long
byte string happened to start late in a buffer, and was then segmented
(continued) into a subsequent buffer, the server would mistakenly think the
byte string was being sent as externalized bytes, when in fact it was sent as
inline bytes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430077 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DDMReader.java",
"hunks": [
{
"added": [
"\t\tif (length < DssConstants.MAX_DSS_LENGTH)"
],
"header": "@@ -1321,7 +1321,7 @@ class DDMReader",
"removed": [
"\t\tif (length < dssLength)"
]
... |
derby-DERBY-170-fc30c5f2 | DERBY-170 Inserting large string value into non-existent table causes communication link failure over Network Server.
Attached is a proposed patch for DERBY-170, which teaches the skipDSS method how to handle segmented DDM objects. changes.html attached to DERBY-170 provides a bit of background and discussion for the reviewer. I have successfully run derbyall with this patch. The patch includes a new test, and new master output files.
Contributed by Bran Pendleton
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@369549 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DDMReader.java",
"hunks": [
{
"added": [
"\t\twhile (dssIsContinued)",
"\t\t{",
"\t\t\tskipBytes((int)dssLength);",
"\t\t\treadDSSContinuationHeader();",
"\t\t}"
],
"header": "@@ -... |
derby-DERBY-1700-9e6e461e | DERBY-1700 Next step that changes the methods in ResultSetFactory not to have a closeCleanup method parameter
which due to the previous patches was always being passed in as null. Changed all callers to not pass the null
and thus remove the closeMethodArgument in ResultSetNode.
Since most of the calls are to ResultSetFactory methods are by generated code cannot rely on compile time checks
to ensure all callers are correct. Needed to reduced the argument count by one for the generated method call for
any getXXXResultSet that no longer passes the closeCleanup (null) argument. Have confidence in the change as derbyall
passes and the code coverage numbers at http://wiki.apache.org/db-derby/CodeCoverage show complete coverage of these
factory methods except for ones related to VTIs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@448286 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/execute/ResultSetFactory.java",
"hunks": [
{
"added": [],
"header": "@@ -293,7 +293,6 @@ public interface ResultSetFactory {",
"removed": [
"\t\t@param closeCleanup\tany cleanup the activation needs to do on close."
... |
derby-DERBY-1700-a30fb433 | DERBY-1700 (partial) Initial version of a TimeHandlingTest that includes tests for CURRENT TIME.
Will expand to also test CURRENT DATE and CURRENT TIMESTAMP.
Not yet added to the suites.
Improve CleanDatabaseTestSetup to allow it to be the super-class for a decorator that
performs initial schema setup with automatic dropping of everything.
Improved CleanDatabaseTestSetup to drop functions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@439861 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/CleanDatabaseTestSetup.java",
"hunks": [
{
"added": [
"import org.apache.derbyTesting.functionTests.tests.lang.TimeHandlingTest;",
""
],
"header": "@@ -24,6 +24,8 @@ import java.util.ArrayList;",
... |
derby-DERBY-1700-f77f36d1 | DERBY-1700 Patch the removes closeCleanup from ResultSet implementations:
- remove any field storing the reference to a close cleanup method
- remove any calling of the method
- remove passing the reference to the method in the constructor.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@441232 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/BaseActivation.java",
"hunks": [
{
"added": [
"\t\t\t\t\t\t\t\t\t\t0);"
],
"header": "@@ -1473,8 +1473,7 @@ public abstract class BaseActivation implements CursorActivation, GeneratedByteC",
"removed": [... |
derby-DERBY-1701-09ffc9bc | DERBY-1555 DERBY-1701 (partial) Convert more tests to use the instance based get[X]Connection method
or the static openDefault method.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@432028 13f79535-47bb-0310-9956-ffa450edef68
| [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.