id
stringlengths
22
25
commit_message
stringlengths
137
6.96k
diffs
listlengths
0
63
derby-DERBY-1952-3ca3bd45
DERBY-1952 DERBY-2047 Remove the remaining code directly related to derbyTesting.xa.single. This functionality has been replaced with a decorator. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473079 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [], "header": "@@ -60,7 +60,6 @@ public class TestConfiguration {", "removed": [ " private final static String KEY_SINGLE_LEG_XA = \"derbyTesting.xa.single\";" ...
derby-DERBY-1952-4f1a9939
DERBY-1952 (partial) Add a top-level encryption suite EncryptionSuite that runs a set of tests in encrypted databases with different algorithms. A replacement mechanism for the encrypted suite in the old harness. Only includes a single test at the moment, since that is the only converted test that run under the old harness with encrpytion. EncryptionSuite is not added to suites.All as I'd like to see some more testing on other platforms before enabling for all. Added the encryptedDatabase decorators to a new class junit.Decorator to stop TestConfiguration becoming clogged with decorators. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@502400 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/Decorator.java", "hunks": [ { "added": [ "/*", "", " Derby - Class org.apache.derbyTesting.junit.Decorator", "", " Licensed to the Apache Software Foundation (ASF) under one or more", ...
derby-DERBY-1952-76da2f37
DERBY-1952 (partial) Add a test case to the AutoloadTest that sees if when auto-loading the embedded driver via jdbc.drivers the network server is booted correctly depending on the state of the property derby.drda.startNetworkServer. Make the ping network server method in NetworkServerSetup more useful by splitting it into two, one that pings for 60 seconds and returns if it made contact, and the previous version which 'fails' if contact could not be made. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@497549 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java", "hunks": [ { "added": [ " throws InterruptedException ", " {", " if (!pingForServerStart(networkServerController))", " fail(\"Timed out waiting...
derby-DERBY-1952-81450898
DERBY-1952 (partial) Add some junit test cases that are wrappers around jdbcapi.autoloadTest that set jdbc.drivers as a System property before running jdbcapi.autoloadTest fixtures. These tests are intended only to be run standalone, ie a single run on one test class in a jvm, as they test autoloading of Derby's drivers by the DriverManager class. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@495704 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1952-8c9e99ff
DERBY-1952 Remove the jdbc4/AutoloadBooting.test as the final JUnit test run as a '.junit' test through the old harness. Test has been replaced by the generic jdbcapi.AutoloadTest and its siblings. The variants of the autoload tests are run through the ant junit target as they require a clean jvm. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@545334 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1952-985662bc
DERBY-1952 (partial) DERBY-1971 (partial) Change more of the tests run from jdbcapi._Suite to return suites that run in embedded and client as primary configurations. Name some of the TestSuites returned from TestConfiguration to make the hierarchy view in the Swing Test Runner more useful. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@464999 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " final TestSuite suite = new TestSuite(suiteName(testClass));" ], "header": "@@ -169,7 +169,7 @@ public class TestConfiguration {", "removed": [ ...
derby-DERBY-1952-987f4fd7
DERBY-1952 Add a check to the AutoloadTest that indicates in a somewhat non-internal way that Derby's embedded engine was actually booted in not. Will replace the use of internal apis and checking for a NPE in the jdbc4 version of the test. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@545332 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1952-9f5c33fc
DERBY-1952 (partial) Refactor VerifySignatures to run as a single test case per configuration and thus not rely on the old test harness. Added the test to jdbc4._Suite and removed from the old jdbc40 harness suite. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@495318 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1952-9f608bd0
DERBY-1952 (partial) Copy & refactor AutoloadTest as jdbcapi.AutoloadTest as it can be used on non-JDBC 4 environments as long as it is not compiled using Java SE 6. Split into a number of test cases including one to ensure the junit setup is not autoloading the test (thus potentially hiding real issues) when autoloading is not enabled. Test runs successfully without the old harness but not yet added to any ant target as it needs to set the property jdbc.drivers for effective testing. The jdbc4 version is not removed until this version is running as part of the ant targets. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@495364 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1952-b1c5200c
DERBY-1952 DERBY-2047 Convert store/BootAllTest to run as a standard JUNit test and not within the harness. Added a store._Suite and hooked it into the suites.All and the ant junit-all target. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473175 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/DropDatabaseSetup.java", "hunks": [ { "added": [ "class DropDatabaseSetup extends BaseJDBCTestSetup {" ], "header": "@@ -30,7 +30,7 @@ import junit.framework.Test;", "removed": [ "class DropDataba...
derby-DERBY-1952-c40688b6
DERBY-1952 (partial) Setup methods in TestConfiguration to allow tests' suite() methods to add tests that run in the client/server configuration. Change TimeHandlingTest and LangScripts to use these methods so that by themselves they run embedded and network server tests. Remove the Client and Embedded top-level suites as that choice is now driven into a test itself. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@464607 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ "import junit.framework.TestSuite;" ], "header": "@@ -29,6 +29,7 @@ import java.util.Properties;", "removed": [] }, { "added": [ ...
derby-DERBY-1952-c7641f3c
DERBY-1952 (partial) Minor refactoring of jdbc4.VerifySignatures test to make the checks in the current MethodTestCase use a static method in the parent class. This is just to set up for the next step where checking will occur without a test case per method. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@495301 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1952-eba07fcf
DERBY-1952 (partial) Add some utility methods in TestConfiguration to allow test classes to easily implement suite() methods that run in embedded and/or client server. Convert some tests to use these utility methods. Change NetworkServerTestSetup to create a server console output file in the logs folder in append mode. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@464785 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java", "hunks": [ { "added": [ "import java.io.File;" ], "header": "@@ -21,6 +21,7 @@ package org.apache.derbyTesting.junit;", "removed": [] }, { "added": [ ...
derby-DERBY-1952-ee7f6684
DERBY-2047 DERBY-1952 (partial) Implement the ability to run with the default connction coming from an XADataSource as a decorator via the utility method TestConfiguration.connectionXADecorator. This will replace the functionality driven by the property derbyTesting.xa.single. Improved jdbc4.ConnectionTest and PreparedStatementTest to also run their test fixtures with this XA decorator. This will replace the old harness suite jdbcxa40 which does not seem to be part of derbyall but the new runs are part of jdbc4._Suite. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472722 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " /**", " * Return a decorator that changes the configuration to obtain", " * connections from an XADataSource using", " * <code>", ...
derby-DERBY-1952-f2e3e690
DERBY-1952 (partial) Ensure fixtures in jdbcapi.AutoloadTest are ordered and add a fixture to test that explicitly loading Derby's JDBC driver works when auto-loading is enabled. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@495603 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1953-5e4e33b5
DERBY-1953 Test changes. MODE DB2SQL removed from most tests git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@469102 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/dblook/DB_Trigger.java", "hunks": [ { "added": [], "header": "@@ -176,9 +176,6 @@ public class DB_Trigger {", "removed": [ "\t\t// DB2 requires the following keywords in order to work.", "\t\tsb.append(\"MODE...
derby-DERBY-1956-960054b0
DERBY-1956: Remove stale code from the statement classes in the client driver The patch removes escapedProcedureCallWithResult_ and all code that is only executed when the flag is true. It also removes a couple of methods that became no-ops, and SQLStates and messages that are never used. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@463565 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/CallableStatement.java", "hunks": [ { "added": [], "header": "@@ -162,7 +162,6 @@ public class CallableStatement extends PreparedStatement", "removed": [ " parameterIndex = checkForEscapedCallWithResult(paramete...
derby-DERBY-1958-26c2de4c
DERBY-1958: Improve XSDG3 error to print container, operation, and name This patch was contributed by Eranda Sooriyabandara (070468D at gmail dot com) This patch modifies message XSDG3 ("Metadata for container could not be accessed") to provide additional information about which container, precisely, is having the problem. The message now includes the container identity and the container file name, as well as the type of access to the container that encountered the problem. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@989696 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java", "hunks": [ { "added": [ " private String fileName;" ], "header": "@@ -94,6 +94,7 @@ class RAFContainer extends FileContainer implements PrivilegedExceptionAction", "removed"...
derby-DERBY-1961-106ea47b
Checked in the performance tests used in DERBY-1961 and DERBY-2911. The following command prints information on how to run the tests: java org.apache.derbyTesting.perf.clients.Runner git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@619404 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/perf/clients/WisconsinFiller.java", "hunks": [ { "added": [ "/*", "", "Derby - Class org.apache.derbyTesting.perf.clients.WisconsinFiller", "", "Licensed to the Apache Software Foundation (ASF) un...
derby-DERBY-1966-5b5091ff
DERBY-1966 (partial) Cleanup of some code in DRDAServerStarter. Add some comments and remove use of priv blocks to access public methods in public classes. Step in an incremental approach to clarify the interaction between this class and NetworkServerControlImpl. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@511360 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/jdbc/DRDAServerStarter.java", "hunks": [ { "added": [ "/**", " * Class that starts the network server in its own daemon thread.", " * Works in two situations.", " * <BR>", " * As a module in the engi...
derby-DERBY-1970-f8fd911c
DERBY-1970 Add JDBCPerfTestCase as initial step in adding performance tests to Derby's testing. Contributed by Sunitha Kambhampati ksunithaghm@gmail.com git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@469567 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-1971-985662bc
DERBY-1952 (partial) DERBY-1971 (partial) Change more of the tests run from jdbcapi._Suite to return suites that run in embedded and client as primary configurations. Name some of the TestSuites returned from TestConfiguration to make the hierarchy view in the Swing Test Runner more useful. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@464999 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " final TestSuite suite = new TestSuite(suiteName(testClass));" ], "header": "@@ -169,7 +169,7 @@ public class TestConfiguration {", "removed": [ ...
derby-DERBY-1974-c61536a1
DERBY-1974 Add utility method TestConfiguration.sqlAuthorizationDecorator to change the default database to one that has SQL authorization mode enabled. Have PrepareExecuteDDL use this decorator and add this test to lang._Suite. Fix a bug in assertDrainResults() where the wrong variable was being used to check an assert. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470024 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " private final static String DEFAULT_DBNAME_SQL = \"dbsqlauth\";", " " ], "header": "@@ -41,6 +41,8 @@ public class TestConfiguration {", "r...
derby-DERBY-1975-b83e61a0
DERBY-1975 (partial) Add some incremental work to support a single use database for a test. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@469594 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " /**", " * Decorate a test to use a new database that is created upon the", " * first connection request to the database and shutdown & deleted at", ...
derby-DERBY-1975-d488449a
DERBY-1975 Enhance the single database decorator and DropDatabaseSetup to use a unique database name and to drop the database at tearDown. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@469632 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " ", " /**", " * Simple count to provide a unique number for database", " * names.", " */", " private static i...
derby-DERBY-1993-ff22a628
DERBY-1993: Checkin derby-1993-v03.diff, which puts the demo classes in the org.apache.derbyDemo namespace. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470372 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/demo/scores/java/server/org/apache/derbyDemo/scores/proc/Procedures.java", "hunks": [ { "added": [ "/*", "", " Derby - Class org.apache.derbyDemo.scores.proc.Procedures", "", " Licensed to the Apache Software Foundation (ASF...
derby-DERBY-1997-b06ac7ae
DERBY-1997: Remove custom exception printing methods and replace with printStackTrace as suggested git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1496870 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/demo/workingwithderby/WwdEmbedded.java", "hunks": [ { "added": [ " e.printStackTrace(System.out);" ], "header": "@@ -143,32 +143,8 @@ public class WwdEmbedded", "removed": [ " errorPrint(e);", " // ...
derby-DERBY-2000-23c0fede
DERBY-2000 Add a BaseTestSetup class that installs the security manager so that it is in place during the decorator's methods. Changed the various Derby decorators to extend this new class. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@541044 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/Decorator.java", "hunks": [ { "added": [ " test = new BaseTestSetup(test) {" ], "header": "@@ -61,7 +61,7 @@ public class Decorator {", "removed": [ " test = new TestSetup(test) {" ...
derby-DERBY-2002-6f52e78a
DERBY-2002: Case expression allows NULL in all parts of <result> Require at least one expression with a known type (that is, not NULL or a ? parameter) in the THEN and ELSE clauses of a CASE expression. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1599142 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java", "hunks": [ { "added": [], "header": "@@ -21,7 +21,6 @@", "removed": [ "import java.sql.Types;" ] }, { "added": [], "header": "@@ -109,41 +108,6 @@ class...
derby-DERBY-2003-be115c44
DERBY-2003 Add a utility method to allow setting the lock timeouts as a decorator building off DatabasePropertyTestSetup. Use this decorator in BlobClob4Blob to reduce the wait time. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@468209 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/DatabasePropertyTestSetup.java", "hunks": [ { "added": [ " ", " /**", " * Decorator to change the lock time outs.", " * If either time is less than zero then that property is", ...
derby-DERBY-2006-87662285
DERBY-2006: Add a top-level Ant target that runs the junit tests and generates a report. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470604 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java", "hunks": [ { "added": [ "", "\t\t//We need the junit classes to instantiate this class, so the", "\t\t//following should not cause runtime errors.", " URL junit = nu...
derby-DERBY-2007-552e94e0
DERBY-2007 (partial) The dropping of tables in CleanDatabaseTestSetup needs to be smarter for the nist suite since it has tables that depend on each other. This is an incremental change that copes with tables in the same schema depending on each other except when two tables reference each other. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@468447 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBC.java", "hunks": [ { "added": [ "import java.util.ArrayList;", "import java.util.Iterator;", "import java.util.List;", "import java.util.ListIterator;" ], "header": "@@ -20,6 +20,1...
derby-DERBY-2007-64c254cd
DERBY-2007 Add a convenience method in DatabasePropertyTestSetup that returns a decorator that sets up BUILTIN authentication with the passed in list of users. Use this for the NIST test as seemed to be the intention under the old harness. Remove the remaining harness properties files for the nist suite. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@468803 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/DatabasePropertyTestSetup.java", "hunks": [ { "added": [ " private final boolean staticProperties;" ], "header": "@@ -40,6 +40,7 @@ public class DatabasePropertyTestSetup extends BaseJDBCTestSetup {", "r...
derby-DERBY-2007-8919a15e
DERBY-2007 (partial) Improve CleanDatabaseTestSetup to handle tables in a dependency loop due to foreign key constraints and simple cases for objects that are dependent across schemas. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@468502 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBC.java", "hunks": [ { "added": [ " ", " // At this point there may be tables left due to", " // foreign key constraints leading to a dependency loop.", " // Drop any con...
derby-DERBY-2008-1d4b49f7
DERBY-2014: NullPointerException with NULLIF in GROUP BY clause This change was contributed by Yip Ng (yipng168@gmail.com) The NPE happens in isEquivalent() method where it does not handle value is null. (same symptom as DERBY-2008) and the patch addresses this + additonal testcases. The isEquivalent() method is used to compare the select column against the group by with expression. Note that it is comparing the structural form of the two expressions for equivalence at bind phase and not comparing the actual row values at runtime to produce a result. This patch converts all the tests in the previous patch into junit. Also the javadoc for ValueNode.isEquivalent() method has been updated. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@471459 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2014-1d4b49f7
DERBY-2014: NullPointerException with NULLIF in GROUP BY clause This change was contributed by Yip Ng (yipng168@gmail.com) The NPE happens in isEquivalent() method where it does not handle value is null. (same symptom as DERBY-2008) and the patch addresses this + additonal testcases. The isEquivalent() method is used to compare the select column against the group by with expression. Note that it is comparing the structural form of the two expressions for equivalence at bind phase and not comparing the actual row values at runtime to produce a result. This patch converts all the tests in the previous patch into junit. Also the javadoc for ValueNode.isEquivalent() method has been updated. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@471459 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2016-44937d74
DERBY-2016 ArrayIndexOutOfBoundsException for COALESCE with aggregate functions Patch DERBY-2016d. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@597278 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/CoalesceFunctionNode.java", "hunks": [ { "added": [ "", "\t/**", "\t * The generated method will generate code to call coalesce on", "\t * this non-parameter argument.", "\t */", ...
derby-DERBY-2017-93c4b079
DERBY-2017: Client driver can insert and commit partial data when a LOB stream throws IOException or does not match the specified length Remove workaround for DERBY-2017 (the test accepted a row that shouldn't have been committed). Patch file: derby-2017-4a-remove_test_workaround.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@937198 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2017-ed6bf515
DERBY-2017: Client driver can insert and commit partial data when a LOB stream throws IOException or does not match the specified length Enabled tests as part of the suites. Added tests for binary data. Patch file: derby-2017-5a-binary_tests.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@937655 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2020-a1c5a361
DERBY-2020 (partial) Change file option for syncing log file to disk from rws to rwd 1. Rename the method called supportsRws() to supportWriteSync() in WritableStorageFactory and all of its implementations. 2. Fixed code comments referring to "rws" to also include "rwd" so that the comments also will be valid if rwd is used. Patch contributed by Olav Sandstå. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@532635 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java", "hunks": [ { "added": [ "\t * sync(rws and rwd modes) mechanism can be used correctly." ], "header": "@@ -439,7 +439,7 @@ public final class LogToFile implements LogFactory, ModuleControl, Mod...
derby-DERBY-2020-d617193c
DERBY-2020 (partial) Move check for JVM bug (DERBY-1) into separate method. Patch contributed by Olav Sandstå. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@530807 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/log/LogToFile.java", "hunks": [ { "added": [ " /**", " * Status for whether the check on the sync error on some JVMs has been", " * done or not. See the checkJvmSyncError method for details.", ...
derby-DERBY-2021-16c6f358
DERBY-2021 Fix DataSourceProperties and SURQueryMixTest to runs tests in client and embedded as needed. Fix DataSourceProperties to actually run some tests. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470476 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2021-283931ee
DERBY-2021 (partial) Change ProcedureTest.suite() to run tests embedded and client. Cleanup the creation of tables and procedures to use the decorateSQL method of CleanDatabaseTestSetup rather than a test specific way to drop objects. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470233 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2021-4f37d7ca
DERBY-2021 Fix ConcurrencyTest to run embedded and client. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470492 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2021-a708311a
DERBY-2021 Fix SURTest.suite() to run client & embedded. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470418 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2021-bbdb3fd9
DERBY-2021 (partial) Fix UpdateXXXTest and ResultSetCloseTest suite() methods to run in client as well. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470221 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2023-8ed08b20
DERBY-2023 DERBY-2047 Add JUnit utility class J2EEDataSource to return XA and ConnectionPooling data source implementations. Split out from JDBCDataSource to ensure no class not found exceptions when running in JSR169. Changed JUnit tests using the old harness class TestDataSourceFactory to use the J2EEDataSource and/or JDBCDataSource. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472228 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/J2EEDataSource.java", "hunks": [ { "added": [ "/*", " *", " * Derby - Class org.apache.derbyTesting.junit.JDBCDataSource", " *", " * Licensed to the Apache Software Foundation (ASF) under on...
derby-DERBY-2023-ec5ae26d
DERBY-2023: Ensure all tests called by jdbc40._Suite run in embedded and client as required The attached patch (derby-2023.diff) makes most of the tests in jdbc4._Suite run in client and embedded. The exceptions are - ClosedObjectTest - StatementEventsTest - XA40Test - UnsupportedVetter - DataSourceTest These tests can only run in embedded mode until DERBY-2047 has been fixed, and I have added a note about it in their suite() methods. jdbc4._Suite is removed from jdbc40.runall. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472016 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2026-67f6bb01
DERBY-2026 Setting a login timeout in client driver can lead to query timeout git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@986689 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/net/NetConnection.java", "hunks": [ { "added": [ " //DERBY-2026. reset timeout after connection is made", " netAgent_.setTimeout(0);" ], "header": "@@ -218,6 +218,8 @@ public class NetConnection ex...
derby-DERBY-2026-73863c93
DERBY-2026 Setting a login timeout in client driver can lead to query timeout Change tests to set loginTimeout to 0 after test completes, so later tests won't be impacted. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@986834 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2031-463fe167
DERBY-2031: Convert derbynet/testProtocol.java to JUnit. Enabled the ProtocolTest JUnit test. It can be run as part of the package private test suite; ant junit-pptesting Patch file: derby-2031-3b-enable_test.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@672770 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/SecurityManagerSetup.java", "hunks": [ { "added": [ " * <BR>", " * derbyTesting.ppcodeclasses set to URL of the 'classes.pptesting' folder", " * if it exists on the classpath. The existence of the p...
derby-DERBY-2031-816270f3
DERBY-4746: Server support for UTF8 in DRDA This patch was contributed by Tiago R. Espinha (tiago dot derby at yahoo dot co dot uk) The code portion of this change puts in place all the switches necessary on the server-side to enable and disable UTF8 support. Principally, the new internal methods switchToUtf8() and switchToEbcdic() are added to DRDAConnThread, and called appropriately from the ACCSEC code point. The test portion of this change contains the protocol tests and changes to the framework required for the UTF8 protocol tests. The test changes implement the command 'switchToUtf8CcsidManager' in the protocol tests that essentially tells the framework to switch its DDMWriter and Reader to UTF8. Normally, a client would negotiate this through the MGRLVLS but the ProtocolTest doesn't take this into consideration and has to be forced into UTF8 mode. Note that due to DERBY-2031, each time we add a feature to the JUnit protocol test we have to do the same for the other or it'll break. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@980800 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/AppRequester.java", "hunks": [ { "added": [ "\t\t\t\t\t\t\t\t\t\t\t1208, // UNICODEMGR" ], "header": "@@ -52,6 +52,7 @@ class AppRequester", "removed": [] } ] }, { "file": "java/drda/org/apache/...
derby-DERBY-2031-bbbeea75
DERBY-2031: Convert derbynet/testProtocol.java to JUnit. Close opened readers/streams (caused failure on Windows). Patch file: derby-2031-4a-close_streams.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@681302 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2031-bec8b0d6
DERBY-2031: Convert derbynet/testProtocol.java to JUnit Removed the package-private version of the test. This used to be run as 'ant junit-pptesting'. Patch file: derby-2031-6a-pptesting_removal.diff git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1300285 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derby/impl/drda/_Suite.java", "hunks": [ { "added": [], "header": "@@ -1,53 +0,0 @@", "removed": [ "/*", "", " Derby - Class org.apache.derby.impl.drda._Suite", "", " Licensed to the Apache...
derby-DERBY-2032-b9989a85
DERBY-2032 Convert MathTrigFunctionsTest to use PreparedStatements instead of many compiled Statements and thus reduce execution time from eighty seconds to around ten seconds. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@470463 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2036-cef7d1e0
DERBY-2036 DERBY-2043 DERBY-2047 (partial) Re-work connection handling in JUnit tests. Create connection factory Connector with two implementations, DataSourceConnector and DriverManagerConnector. This ensures that running tests does not attempt to load DriverManager when running tests with JSR169. Ensure DataSource implementation sets user name and password from configuration for the getConnection() method to ensure the ChangerUserTestSetup works. Refactor the setting of data source Java bean properties to be from a HashMap rather than a Properties object to ensure that no special code exists at the lowest level to deal with different property types. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472187 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBCClient.java", "hunks": [ { "added": [ "import junit.framework.Assert;", "" ], "header": "@@ -19,6 +19,8 @@", "removed": [] }, { "added": [ " private static fin...
derby-DERBY-2040-2b7530f1
DERBY-2040 (partial) Change the api for jarReader to return the StorageFile rather than the (potentially) opened jar. Removes the possibility for user code to access the jar by calling methods of JarReader directly (and hence abusing any privileged blocks that would be required while opening the jar). Cleans up JarLoader by having explict calls to open the stream or file within the class loader. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@486201 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/loader/JarReader.java", "hunks": [ { "added": [ "import org.apache.derby.io.StorageFile;" ], "header": "@@ -22,6 +22,7 @@", "removed": [] } ] }, { "file": "java/engine/org/apache/derby/imp...
derby-DERBY-2040-420f9d68
DERBY-2040 (partial) Create the class loaders (JarLoader instances) for database class loading within a privileged block. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473387 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/reflect/UpdateLoader.java", "hunks": [ { "added": [ "import java.security.AccessController;", "class UpdateLoader {" ], "header": "@@ -40,12 +40,13 @@ import org.apache.derby.iapi.services.property.Proper...
derby-DERBY-2040-fb934605
DERBY-538 DERBY-2040 Remove the FileResource.getAsStream method as the getAsFile() method now returns a StorageFile and that class has a getInputStream method. Incremental step in pushing the JarClassLoader to work off URLs for the jar files and thus allow use of the standard java.net.URLClassLoader. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@484722 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/db/BasicDatabase.java", "hunks": [ { "added": [ "import org.apache.derby.io.StorageFile;" ], "header": "@@ -70,6 +70,7 @@ import org.apache.derby.iapi.services.property.PropertySetCallback;", "removed": [] } ...
derby-DERBY-2041-23362a43
DERBY-2041: Trigger should register a dependency on tables and columns used in its body Add an upgrade test to verify how the dependencies are handled after upgrade and downgrade. Skip some cross checking between getColumns() and ResultSetMetaData for views in DatabaseMetaDataTest, since those checks only pass for tables. The upgrade test case adds a view that upsets the meta-data test. (This is the first upgrade test that uses views.) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1548032 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2041-cc67949e
DERBY-2041: Trigger should register a dependency on tables and columns used in its body git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1545179 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/TriggerDescriptor.java", "hunks": [ { "added": [ " ** We are dependent on the underlying table, our SPSs, any tables", " ** or other SQL objects that are referenced from the trigger, and" ...
derby-DERBY-2041-dd7698b8
DERBY-6684(Failure in testDERBY5120NumRowsInSydependsForTrigger when upgrading from 10.11.1.0 to trunk) We ran into DERBY-6684 after the fix for DERBY-2041 went into 10.11 The failure is the expected behavior since when dropping a table, we should detect any dependent triggers defined on other tables and drop table should fail if such dependencies exist. To fix the test failure, we just need to switch the order of drop table DERBY-2041(Trigger should register a dependency on tables and columns used in its body) Drop ATDC_TAB1 before ATDC_BKUP1 because ATDC_TAB1 has a trigger on it which references ATDC_BKUP1. If we try dropping ATDC_BKUP1 without first dropping ATDC_TAB1, there will be an error message that trigger ATDC_TAB1_TRG1 depends on ATDC_BKUP1 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1617641 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2047-01fe8675
DERBY-2047 Remove TestDataSourceFactory and clean up associated code. Functionality has been replaced by JDBCDataSource and J2EEDataSource which allows clean separation for JSR169 which does not include the XA and connection pooling data sources. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473366 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [], "header": "@@ -32,8 +32,6 @@ import junit.framework.Test;", "removed": [ "import org.apache.derbyTesting.functionTests.util.TestDataSourceFactory;", "" ...
derby-DERBY-2047-3ca3bd45
DERBY-1952 DERBY-2047 Remove the remaining code directly related to derbyTesting.xa.single. This functionality has been replaced with a decorator. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473079 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [], "header": "@@ -60,7 +60,6 @@ public class TestConfiguration {", "removed": [ " private final static String KEY_SINGLE_LEG_XA = \"derbyTesting.xa.single\";" ...
derby-DERBY-2047-419724b6
DERBY-2047 (partial) Expose the generic data source (bean) property setting method in JDBCDataSource and change DataSourcePropertiesTest to use it as part of clean up to ensure clean separation between old harness code and JUnit code. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472707 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " private static Properties getDataSourcePropertiesForDatabase" ], "header": "@@ -823,7 +823,7 @@ public class TestConfiguration {", "removed": [ ...
derby-DERBY-2047-45da985a
DERBY-2043 DERBY-2047 (partial) More connection utility method cleanup to provide a single consistent shutdownEngine() method. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@471808 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " private Connection getDefaultConnection(String connAttrs)" ], "header": "@@ -588,7 +588,7 @@ public class TestConfiguration {", "removed": [ "...
derby-DERBY-2047-8ed08b20
DERBY-2023 DERBY-2047 Add JUnit utility class J2EEDataSource to return XA and ConnectionPooling data source implementations. Split out from JDBCDataSource to ensure no class not found exceptions when running in JSR169. Changed JUnit tests using the old harness class TestDataSourceFactory to use the J2EEDataSource and/or JDBCDataSource. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472228 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/J2EEDataSource.java", "hunks": [ { "added": [ "/*", " *", " * Derby - Class org.apache.derbyTesting.junit.JDBCDataSource", " *", " * Licensed to the Apache Software Foundation (ASF) under on...
derby-DERBY-2047-b1c5200c
DERBY-1952 DERBY-2047 Convert store/BootAllTest to run as a standard JUNit test and not within the harness. Added a store._Suite and hooked it into the suites.All and the ant junit-all target. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473175 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/DropDatabaseSetup.java", "hunks": [ { "added": [ "class DropDatabaseSetup extends BaseJDBCTestSetup {" ], "header": "@@ -30,7 +30,7 @@ import junit.framework.Test;", "removed": [ "class DropDataba...
derby-DERBY-2047-cef7d1e0
DERBY-2036 DERBY-2043 DERBY-2047 (partial) Re-work connection handling in JUnit tests. Create connection factory Connector with two implementations, DataSourceConnector and DriverManagerConnector. This ensures that running tests does not attempt to load DriverManager when running tests with JSR169. Ensure DataSource implementation sets user name and password from configuration for the getConnection() method to ensure the ChangerUserTestSetup works. Refactor the setting of data source Java bean properties to be from a HashMap rather than a Properties object to ensure that no special code exists at the lowest level to deal with different property types. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472187 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBCClient.java", "hunks": [ { "added": [ "import junit.framework.Assert;", "" ], "header": "@@ -19,6 +19,8 @@", "removed": [] }, { "added": [ " private static fin...
derby-DERBY-2047-ec5ae26d
DERBY-2023: Ensure all tests called by jdbc40._Suite run in embedded and client as required The attached patch (derby-2023.diff) makes most of the tests in jdbc4._Suite run in client and embedded. The exceptions are - ClosedObjectTest - StatementEventsTest - XA40Test - UnsupportedVetter - DataSourceTest These tests can only run in embedded mode until DERBY-2047 has been fixed, and I have added a note about it in their suite() methods. jdbc4._Suite is removed from jdbc40.runall. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472016 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2047-ee7f6684
DERBY-2047 DERBY-1952 (partial) Implement the ability to run with the default connction coming from an XADataSource as a decorator via the utility method TestConfiguration.connectionXADecorator. This will replace the functionality driven by the property derbyTesting.xa.single. Improved jdbc4.ConnectionTest and PreparedStatementTest to also run their test fixtures with this XA decorator. This will replace the old harness suite jdbcxa40 which does not seem to be part of derbyall but the new runs are part of jdbc4._Suite. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472722 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " /**", " * Return a decorator that changes the configuration to obtain", " * connections from an XADataSource using", " * <code>", ...
derby-DERBY-2048-25dd7cdc
DERBY-2048 Add an additional cleanup step(compression) to cleanDatabase() method. After objects removal is performed via removeObjects(), object compression is performed in the new compressObjects() method on the SYS.SYSDEPENDS to compact the system table. (Currently it only compress this system table.) Contributed by Yip Ng yipng168@gmail.com git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472613 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/CleanDatabaseTestSetup.java", "hunks": [ { "added": [ " compressObjects(conn);" ], "header": "@@ -109,7 +109,7 @@ public class CleanDatabaseTestSetup extends BaseJDBCTestSetup {", "removed": [ ...
derby-DERBY-205-27e2c4b9
DERBY-205 spin off - clean up handling of derby.stream.error properties - Removed the (redundant) reading of these stream name properties from NetworkServerControlImpl.java: derby.stream.error.file derby.stream.error.method derby.stream.error.field - Modified DRDAConnThread.java to get the stream name via Monitor.getStream().getName (a new method). DRDAConnThread was the sole client and reason for the redundancy Kathey spotted. - Augmented HeaderPrintWriter interface with a new method, getName. - Augmented BasicHeaderPrintWriter to hold the stream name of the error log. - Moved hard coded constants for the stream name attributes from SingleStream.java to the Property interface and documented them there. - Removed the errorLogLocation field and the getErrorLogLocation from NetworkServerControlImpl.java - Cleaned up some Javadoc for the items I touched. I have run derbyall with JDK1.4.2 on Solaris/x86. derbyall runs with errors, but the same errors are present on a clean checkout as well There are some additional changes to the sed file for the new errorstream test. Checking in all but the addition to the suite. contributed by Dag H. Wanvik git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@179584 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java", "hunks": [ { "added": [], "header": "@@ -121,14 +121,6 @@ public class NetworkServerControlImpl {", "removed": [ "\tprivate final static String", "\t\tNETWORKSERVER_PROP_STREAM_E...
derby-DERBY-2050-4882b305
DERBY-2050: Manipulating CachedItems could be more efficient Use five boolean fields instead of one int to record CachedItem's state. Contributed by Dyre Tjeldvoll. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472803 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/cache/CachedItem.java", "hunks": [ { "added": [ "\tprivate boolean valid_ = false;", "\tprivate boolean removeRequested_ = false;", "\tprivate boolean settingIdentity_ = false;", "\tprivate boolean re...
derby-DERBY-2051-ac5a3a2d
DERBY-2051: Remove the unused CachedItem class git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1625521 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/cache/CachedItem.java", "hunks": [ { "added": [], "header": "@@ -1,330 +0,0 @@", "removed": [ "/*", "", " Derby - Class org.apache.derby.impl.services.cache.CachedItem", "", ...
derby-DERBY-2052-c5eb0bcc
DERBY-2052: JDBC.assertRowInResultSet compares the wrong value if using trimmed strings and a SMALLINT column exists. Patch that 1) moves the locally scoped variables in JDBC.assertRowInResultSet() into the for loop, and 2) sets the "obj" variable through all paths. Contributed by Dan Debrunner (djd@apache.org) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@472391 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBC.java", "hunks": [ { "added": [ " Object obj;" ], "header": "@@ -597,12 +597,10 @@ public class JDBC {", "removed": [ " String s;", " boolean ok;", ...
derby-DERBY-2063-0c9f73e3
DERBY-2063 (partial) Change ShutdownDBWhenNSShutsDown from being a JUnit test run under the old harness to one that is run as a regular JUnit tests. Add a new _Suite for derbynet and hook it into suites.All and the ant junit-all target. Required fixing some bugs in the DriverManager connection handling. Also refactored NetworkServerTestSetup to allow starting the server from the "command line" and to provide some utility methods for tests, e.g. to get a correctly setup NetworkServerControl. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473123 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/DriverManagerConnector.java", "hunks": [ { "added": [ "import java.util.Properties;" ], "header": "@@ -22,6 +22,7 @@ package org.apache.derbyTesting.junit;", "removed": [] }, { "added": ...
derby-DERBY-2067-cb705acc
DERBY-2067: Assert failure in EmbedConnection.restoreContextStack() when running lang/closed.java Change the assert so that it doesn't raise an error if the engine has been shut down. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@473687 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java", "hunks": [ { "added": [ "\t\t\tif (tr.getCsf() != null) {", "\t\t\t\tContextManager cm1 = tr.getCsf().getCurrentContextManager();", "\t\t\t\tContextManager cm2 = tr.getContextManager();", ...
derby-DERBY-2074-877a43d4
DERBY-2074: NullPointerException when two threads load sort factory concurrently Added a flag in ModuleInstance that tells whether the module is fully booted. This flag is checked when we go through the list of modules, so that we can avoid using partly booted instances. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@788670 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/monitor/ModuleInstance.java", "hunks": [ { "added": [ " /** Flag that tells whether booting of the module has completed. */", " private boolean booted;", "" ], "header": "@@ -56,6 +56,9 @@...
derby-DERBY-2083-02985805
DERBY-2033 Convert remaining tests from dcl.sql to DatabaseClassLoadingTest including those that execute against a database in a jar. Database in a jar tests pass but cause an issue on clenaup which is entered as DERBY-2083. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@474878 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2083-55ffdfb0
DERBY-2083 Ensure the store closes the StorageFactory it is using at database shutdown time. Add shutdown code for the JarStorageFactory to close the jar file it has opened. Ensure the monitor does not use a stream opened from a StorageFactory after it has called shutdown(). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@483606 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/io/JarStorageFactory.java", "hunks": [ { "added": [ "import org.apache.derby.io.StorageFile;", "" ], "header": "@@ -21,21 +21,12 @@", "removed": [ "import org.apache.derby.iapi.services.sanity.Sa...
derby-DERBY-2085-f2220fd2
DERBY-2085: Misleading error message for non-matching ORDER BY clause This change modifies the SQL compiler to change the error message that is displayed for the query: SELECT i FROM t GROUP BY i ORDER BY j After this patch, Derby will once again issue the error message that it issued in release 10.1 and earlier: ERROR 42Y36: Column reference 'J' is invalid. For a SELECT list with a GROUP BY, the list may only contain grouping columns and valid aggregate expressions. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@653988 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2087-3df869c3
DERBY-2087 Create a TestConfiguration.singleUseDatabaseDecorator(Test, String dbName, boolean asDefault) and also the methods openConnection(databaseName) to BaseJDBCTestCase and all the required infrustructure. TestConfiguration manages a list of databases in use in a usedDbNames property. The singleUseDatabaseDecorator creates a new configuration and appends a passed (or generated) database name at the end of the old database list. Optionally, if specified, the default database might be also changed. Renamed the TestConfiguration.getDatabaseName to getDefaultDatabaseName, since it is more accurate now. Contributed by Julius Stroffek - Julius.Stroffek@sun.com git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@499100 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/Connector.java", "hunks": [ { "added": [ " /**", " * Open a connection with the database, user and password", " * defined by the configuration passed to setConfiguration.", " * If the d...
derby-DERBY-2087-e5c9e58c
DERBY-2087 Uses logical database names in additionalDatabaseDecorator method (which replaces singleUseDatabaseDecorator with database name). Contributed by Julius Stroffek Julius.Stroffek@sun.com git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@509258 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ "import java.util.Hashtable;" ], "header": "@@ -28,6 +28,7 @@ import java.sql.SQLException;", "removed": [] }, { "added": [ " *...
derby-DERBY-2091-077d16c4
DERBY-2091: Increase coverage for StatementEventsTest git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1504820 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-2093-1573d084
DERBY-2093 Fixed error in initSlotTable() to print the right page info in case of error during initialization of page from disk into cache. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@476190 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java", "hunks": [ { "added": [ "\t\t\tinitSlotTable(newIdentity);" ], "header": "@@ -795,7 +795,7 @@ public class StoredPage extends CachedPage", "removed": [ "\t\t\tinitSlotTable...
derby-DERBY-2096-354d5e84
DERBY-2096 Move remaining methods that are limited to StatementNode from QueryTreeNode. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@481421 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/QueryTreeNode.java", "hunks": [ { "added": [], "header": "@@ -209,18 +209,6 @@ public abstract class QueryTreeNode implements Visitable", "removed": [ "\t/**", "\t * Get the name of the SPS that is use...
derby-DERBY-2096-8a934404
DERBY-2096 (partial) Move needsSavepoint() to StatementNode, remove QueryTreeNode.bind and optimize. Have GenericStatement use StatementNode for the head of the statement's query tree. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@479886 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/GenericStatement.java", "hunks": [ { "added": [ "import org.apache.derby.impl.sql.compile.StatementNode;" ], "header": "@@ -44,10 +44,9 @@ import org.apache.derby.iapi.sql.conn.StatementContext;", "removed": [ ...
derby-DERBY-2096-be0b54fa
DERBY-2096 (partial) Change the main return type from parsing a statement to a StatementNode. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@478031 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/compile/Parser.java", "hunks": [ { "added": [ "import org.apache.derby.impl.sql.compile.StatementNode;" ], "header": "@@ -27,7 +27,7 @@ import org.apache.derby.iapi.error.StandardException;", "removed": [ ...
derby-DERBY-2096-cc770d8f
DERBY-2096 (partial) Rename the bind() method for StatementNode to bindStatement() as a step in switching the return type of a parse statement to StatementNode. Make bindStatement() void as no implementation ever switches the type and several implementations did not handle the type switching anyway. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@477371 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/AlterTableNode.java", "hunks": [ { "added": [ "\tpublic void bindStatement() throws StandardException" ], "header": "@@ -208,11 +208,10 @@ public class AlterTableNode extends DDLStatementNode", "removed"...
derby-DERBY-2096-d725d435
DERBY-2096 (partial) Rename the optimize() method for StatementNode to optimizeStatement() as a step in switching the return type of a parse statement to StatementNode. Make optimizeStatement() void as no implementation ever switches the type and several implementations did not handle the type switching anyway. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@477420 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/CallStatementNode.java", "hunks": [ { "added": [ "\tpublic void optimizeStatement() throws StandardException" ], "header": "@@ -189,12 +189,11 @@ public class CallStatementNode extends DMLStatementNode", ...
derby-DERBY-210-64b55c26
DERBY-210 reverting change until jdk1.5 lang/updatableResultset.java diff can be resolved git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370275 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [ " // Since DERBY prepared statements must be re-prepared after a commit,", " // then we must traverse this list after a commit and notify statements", " // that th...
derby-DERBY-210-bd644c6e
patch 4 toward resolving DERBY-210 Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed Contributed by Deepa Remesh Changes the finalizer method in Statement and PreparedStatement to not send commits or CLSQRY to the server n PreparedStatement class, the finalizer was calling closeX method, which was doing: * Call super.closeX() ---> Statement.closeX() * Cleanup parameter objects - parameterMetaData_, sql_, parameters_ array * Remove the PreparedStatement from connection_.CommitAndRollbackListeners_ list Changes done by patch: * Add a new method markClosed() which will free client-side resources. * The new method is named markClosed() to keep it uniform with naming convention in superclass. * This method is called from close() and finalize() methods. * markClosed() method will call super.markClosed() to perform cleanup of parent class. It will cleanup the objects specific to PreparedStatement, which are ParameterMetaData and parameters. It also removes the PreparedStatement form the list in Connection object. 2. In Statement class, the finalizer was calling closeX method, which was doing: * Close any open cursors for this statement on the server. - If result set is open on server, send CLSQRY to the server. - check if autocommit is required when closing result sets and flow a commit to server, if required * Call Statement.markClosed(), which does - Mark close the result sets on the client - If cursor name was set on the statement, remove it from Connection.clientCursorNameCache_ - Call markClosed() on prepared statements for auto generated keys - Call markClosedOnServer(), which frees up the section. The freed section will be re-used by new statements. * Remove the Statement from Connection.openStatements_ list * Cleanup ResultSetMetaData Changes done by patch: * Move the cleanup of ResultSetMetaData and remove of Statement from Connection.openStatements_ list into markClosed() method. This will keep all client-side cleanup in markClosed(). * Change the finalizer to just call markClosed(). This method frees up client-side resources and operates on synchronized collections. So I have removed the synchronize block from the finalizer. * The autocommit logic does not exist in the finalizer since only markClosed() is called from finalizer. This will avoid untimely commits which was causing the regression in the test lang/updatableResultSet.java -This line, and those below, will be ignored-- M java/client/org/apache/derby/client/am/Statement.java M java/client/org/apache/derby/client/am/PreparedStatement.java git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@380892 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/PreparedStatement.java", "hunks": [ { "added": [], "header": "@@ -219,18 +219,6 @@ public class PreparedStatement extends Statement", "removed": [ " protected void finalize() throws java.lang.Throwable {", ...
derby-DERBY-210-ca8747c0
DERBY-210 cleanup patch in preparation for change Attaching a patch 'derby-210-patch1.diff' which removes the list 'RollbackOnlyListeners_' from org.apache.derby.client.am.Connection class since this is not being used. This is an incremental patch and does not solve the issue fully. While working on this issue, I found one of the causes of memory leaks is object references stored in the lists in the Connection class. On looking at the lists, I found that 'RollbackOnlyListeners' is not being used anywhere in the client code. Submitting this patch to remove this. Contributed by Deepa Remesh git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376874 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [ " // Some statuses of DERBY objects may be invalid on server", " // after both commit and rollback. For example," ], "header": "@@ -38,14 +38,12 @@ public abstr...
derby-DERBY-210-cff2860a
DERBY-210 - Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed I am uploading a combined patch 'derby-210.diff' which solves the memory leak. As Bryan suggested, I am uploading this patch and will open jira issues for other optimizations. Patch does the following: * Eliminates the below references to PreparedStatement objects by using WeakHashMap instead of LinkedList. When there are no other references to the keys in a WeakHashMap, they will get removed from the map and can thus get garbage-collected. They do not have to wait till the Connection object is collected. - 'openStatements_' in org.apache.derby.client.am.Connection - 'CommitAndRollbackListeners_' in org.apache.derby.client.am.Connection * Removes the list 'RollbackOnlyListeners_' since this is not being used. * Updates the following comment for openStatements_: // Since DERBY prepared statements must be re-prepared after a commit, // then we must traverse this list after a commit and notify statements // that they are now in an un-prepared state. final java.util.LinkedList openStatements_ = new java.util.LinkedList(); In the code, I did not see this list being traversed after a commit to re-prepare statements. Also, I think this is not needed since Derby does not require re-prepare of statements after a commit. Currently, this list is used to close all open statements when the originating connection is closed. * Removes all ResultSets from HashTable 'positionedUpdateCursorNameToResultSet_' in SectionManager. Only result sets of positioned update statements were being removed from this hashtable whereas all result sets were added. Because of this, client driver was holding on to result sets and statements even after rs.close() was called. * Adds a test 'derbyStress.java' to jdbcapi suite. This test is based on the repro for this patch. Without this patch, it fails when run with client driver. Kathey had suggested in another mail that tests for client memory leak problems (DERBY-557, DERBY-210) can be added to same test. I did not see an existing test. So I created this new test. If DERBY-557 does not have a test, I think it can be added to this new test. * Excludes the new test from running with jcc because jcc gives out of memory error. * Creates 'derbyStress_app.properties' with following property 'jvmflags=-Xmx64M' to guarantee the test fails on all machines. Successfully ran derbyall with Sun JDK 1.4.2 on Windows XP. Please take a look at this patch. Contributed by Deepa Remesh git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@369612 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [ " ", " // WeakHashMap is used to store references so that the objects added to ", " // the map can get garbage-collected without waiting for the Connection object....
derby-DERBY-210-d51b773e
DERBY-1036: Embedded and client differ with regard to Statement.setCursor Name. client will disallow duplicate cursor names. Embedded will allow it. and DERBY-1183: Client java.sql.ResultSet.getCursorName() does not return the correct cursor name for Statements after the first execution Patch description: The problem underlying DERBY-1183 is the following: A Statement (and by inheritance, PreparedStatement and CallableStatement) will have a cursor name associated with result set generated by the statement. Such names are either set by the user (Statement#setCursorName) or assigned by the system (aka "canned" cursor names in the client driver). In either case, the user can get at the cursor name attached to a statement by calling Resultset#getCursorName. This string can be used to construct the SQL text of positioned update or delete statement. Currently, when a cursor name is set on a statement, the following actions are taken (Statement#setCursorName): 1. The statement's string variable cursorName_ is set to the new string. This keeps track of the user cursor name set for this statement. 2. A cache (clientCursorNameCache) of cursor names set by the user for this connection is maintained to avoid having any two identical cursor name for the same statement/result set. When the cursor name is set, the check is performed (2a) and the cache is updated with the new cursor name if all is well (2b). If the statement (only applies for PreparedStatement and CallableStatement) already has a DRDA section (ch 7.14) allocated, the following is also performed: 3. A map (cursor name -> section) is updated. 4. The section associated with this statement gets its variable clientCursorName set to the supplied cursor name. For Statement, this association (steps 3 and 4) is performed at statement execution time (inside flowExecute, just after the new section is allocated for a query). 5. Also in flowExecute (of Statement, PreparedStatement) the cursor (user set or canned) is associated with the result set (call to mapCursorNameToResultSet). The symptom of this bug is that the cursor name set for a statement seems to be lost after one execution of that statement, reverting to a canned cursor name for executions 2..n. This happens because the cursor name is actually reset as part of the next execute on a statement object: 6. Open result sets for a statement are closed when flowExecute calls readCloseResultSets. During the closing of a result set, ResultSet#markClosed calls statement_.removeClientCursorNameFromCache, which in addition to removing the user cursor name from the cache also sets the statements cursorName_ to null, causing it effectively to be forgotten. Since #5 happens *after* #6 in flowExecute, the execution still works, but with a canned cursor instead of the user named cursor (see mapCursorNameToResultSet). This "race condition" suggests deferring the setup of mappings and insertion into the name cache till execution time (*after* the closing of open result sets on this statement). When studying this I found there was already a bug filed (DERBY-1036) which advises that we defer the check of duplicates till execution time, so this patch fixes both DERBY-1183 and DERBY-1036. In the patch, Statement#setCursorName now only sets the string variable cursorName_. The patch also removes the resetting of cursorName_ in removeClientCursorNameFromCache, so it won't be forgotten. It is still removed from the cache when the result set is closed (and current maps deleted). Furthermore, it moves #2, #3 and #4 till execution time (flowExecute). Item #2a is performed at the start of flowExecute, so we can avoid starting any protocol action if it turns out that we should not start execution (duplicate name). The actions needed in Statement#flowExecute and PreparedStatement#flowExecute are similar, so I factored these out into the methods Statement# checkForDuplicateCursorName and Statement#setupCursorNameCacheAndMappings. Next, I removed code from getCursorName which redundantly performs #3 (now always handled at execute time). CAVEAT: When working on understanding what goes on here, I found that the Statement finalizer can lead to cursors being released; this is part of the client side clean-up for statements that are not explicitly closed (DERBY-210). This can sometimes lead to time variability in canned cursor names in client driver tests which do not close statements explicitly. If the canned cursor name occurs in the canon file, we can see spurious diff due to this. I think we have seen this in the past. Avoid it by closing statements or by naming the cursors explicitly. Finally, I removed work-around code in jdbcapi/checkDataSource.java for derby-1036 and derby-1183 and updated masters to reflect that the cursor names are no longer forgotten. Patch submitted by Dag H. Wanvik. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@416661 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/PreparedStatement.java", "hunks": [ { "added": [ " // DERBY-1036: Moved check till execute time to comply with embedded", " // behavior. Since we check here and not in setCursorName, several", " ...
derby-DERBY-210-dd7d579b
DERBY-210 Network Server will leak prepared statements if not explicitly closed by the user until the connection is closed Contributed by Deepa Remesh ---------------------------------------------------------------- Summary of patch: 'derby-210-patch5-v1.diff' ----------------------------------------------------------------- 1. Eliminates the below references to PreparedStatement objects by using WeakHashMap instead of LinkedList. When there are no other references to the keys in a WeakHashMap, they will get removed from the map and can thus get garbage-collected. They do not have to wait till the Connection object is collected. - 'openStatements_' in org.apache.derby.client.am.Connection - 'CommitAndRollbackListeners_' in org.apache.derby.client.am.Connection 2. Updates the following comment for openStatements_: // Since DERBY prepared statements must be re-prepared after a commit, // then we must traverse this list after a commit and notify statements // that they are now in an un-prepared state. final java.util.LinkedList openStatements_ = new java.util.LinkedList(); In the code, I did not see this list being traversed after a commit to re-prepare statements. Also, I think this is not needed since Derby does not require re-prepare of statements after a commit. Currently, this list is used to close all open statements when the originating connection is closed. 3. Removes all ResultSets from HashTable 'positionedUpdateCursorNameToResultSet_' in SectionManager. Only result sets of positioned update statements were being removed from this hashtable whereas all result sets were added. Because of this, client driver was holding on to result sets and statements even after rs.close() was called. 4. Modifies the test jdbcapi/derbyStress.java to run the test for derby-210. The test was checked in as patch2 but disabled for client framework. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@384331 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/am/Connection.java", "hunks": [ { "added": [ " // DERBY-210 - WeakHashMap is used to store references to objects to avoid", " // memory leaks. When there are no other references to the keys in a ", " // Weak...
derby-DERBY-2102-4631dd7d
DERBY-2102: JDBC.assertFullResultSet should handle byte arrays Patch contributed by Øystein Grøvlen. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@477645 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBC.java", "hunks": [ { "added": [ "import java.util.Arrays;" ], "header": "@@ -21,6 +21,7 @@ package org.apache.derbyTesting.junit;", "removed": [] }, { "added": [ " ...
derby-DERBY-2107-1d8153ce
DERBY-2107: Move page latching out of the lock manager Removed the latch methods from the lock manager and the unit tests. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@504462 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/locks/LockFactory.java", "hunks": [ { "added": [], "header": "@@ -77,39 +77,6 @@ public interface LockFactory extends PropertySetCallback {", "removed": [ "\t/**", "\t\tLock an object within a compatabili...
derby-DERBY-2107-363cf3ae
DERBY-2107: Move page latching out of the lock manager Handle latches locally in BasePage instead of going through the lock manager. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@503440 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/store/raw/data/BasePage.java", "hunks": [ { "added": [], "header": "@@ -25,12 +25,6 @@ import org.apache.derby.iapi.reference.SQLState;", "removed": [ "import org.apache.derby.iapi.services.io.DynamicByteArrayOutputStream;"...