id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-6228-4c9b831a | DERBY-6228: Add parsing of SQLCARD warnings after next(). Don't commit tx when calling getWarnings(). Fix various locator-release errors when navigating SURs.
Patch file derby-6228-a.diff. (+ typo fix mentioned in review)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1537881 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientResultSet.java",
"hunks": [
{
"added": [
" private boolean savedIsValidCursorPosition_ = false;"
],
"header": "@@ -139,6 +139,7 @@ public abstract class ClientResultSet implements ResultSet,",
"removed... |
derby-DERBY-6230-af88ec8d | DERBY-6230: Use the JVM's cache of Number instances in ReuseFactory
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1487773 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/util/ReuseFactory.java",
"hunks": [
{
"added": [
" return Integer.valueOf(i);",
" return Short.valueOf(i);",
" return Byte.valueOf(i);",
" return Long.valueOf(i);",
" ... |
derby-DERBY-6233-3983f42f | DERBY-6233: XMLBindingTest fails on latest JDK 8 EA
Set the system property javax.xml.accessExternalDTD in the test to
allow the XML parser to access the DTD.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1488116 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/SystemPropertyTestSetup.java",
"hunks": [
{
"added": [
"",
" /**",
" * Decorate a test so that it sets a single system property in",
" * {@code setUp()} and resets it in {@code tearDown()}.... |
derby-DERBY-6237-a22130db | DERBY-6237(PreparedStatement.execute() fails starting 10.2 when multiple rows are updated and PreparedStatement.setCharacterStream(int, Reader, int) is used)
This commit tests setCharacterStream on CLOB and VARCHAR columns as 2 separate tests. This way failure of one data type will not mask the behavior of the other data type.
I found through these tests that in trunk,
1)setCharacterStream on VARCHAR columns work fine(just like 10.1 through 10.10 releases) for both one row and multi-row update through prepared statement.
2)But setCharacterStream on CLOB column when update touches more than one row(both for embedded and network server) fails in trunk.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1489246 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6238-1fec7db8 | DERBY-6238: Lock timeout in GrantRevokeTest.testGrantRollbackAndCommit
Improve error reporting to help debugging:
- Check that all exceptions are as expected
- Provide stack trace for all unexpected exceptions
- Dump lock table on lock timeouts
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1488896 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6242-a809756d | DERBY-6242: Merge ConcurrentXactFactory into XactFactory
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1488905 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java",
"hunks": [
{
"added": [
"import java.util.concurrent.ConcurrentHashMap;"
],
"header": "@@ -35,13 +35,11 @@ import org.apache.derby.iapi.store.raw.log.LogInstant;",
"removed": [... |
derby-DERBY-6243-4e5e9650 | DERBY-6243: Fold Java5ClassFactory into ReflectClassesJava2
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1489314 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/loader/ClassInspector.java",
"hunks": [
{
"added": [
"import java.util.ArrayList;",
"import java.util.HashMap;"
],
"header": "@@ -28,6 +28,8 @@ import org.apache.derby.iapi.error.StandardException;",
... |
derby-DERBY-6247-0fb596b0 | DERBY-6247; updatelocksJDBC30 test failing in nightly regression tests
addressing the issue by merging the test into junit test UdateLocksTest.java
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1629099 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6250-6e6ee8d9 | DERBY-6250; nightly regression test failure: jdbc4.LoginTimeoutTest testBasic client/server java.sql.SQLTimeoutException: XBDA0, Login timeout Exceeded and junit.framework.AssertionFailedError: Should not have been able to connect!
attempt to add more time for failing situations, and add more details to error message on failure.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1575065 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6253-aa5c5de5 | DERBY-6253: Collapse SQLException factories
- Move functionality from SQLExceptionFactory40 to SQLExceptionFactory
- Move logic for retrieving the exception factory from Util to
ExceptionFactory in order to reduce compile-time dependencies on
impl classes from iapi classes
- Use varargs in Util's helper methods in order to reduce the number
of methods
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1493701 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" SQLException se = StandardException.getArgumentFerry(sqlException);"
],
"header": "@@ -1380,8 +1380,7 @@ class DRDAConnThread extends Thread {",
"removed": [... |
derby-DERBY-6254-97f7c7af | DERBY-6254: Reduce number of factory methods in StandardException
Generalize the factory methods by using varargs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1491366 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/error/StandardException.java",
"hunks": [
{
"added": [],
"header": "@@ -71,11 +71,6 @@ public class StandardException extends Exception",
"removed": [
"\tprotected StandardException(String messageID, Object[] args)",
... |
derby-DERBY-6256-23643e8a | DERBY-6256: Commit derby-6256-02-aa-allowParentTags.diff, allowing XmlVTIs to inherit columns from outer xml elements in which the primary row element is nested.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1491490 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/XmlVTI.java",
"hunks": [
{
"added": [
"import java.io.InputStream;",
"import java.sql.ResultSetMetaData;",
"import java.sql.SQLException;",
"import java.util.ArrayList;",
"import javax.xml.parsers.Doc... |
derby-DERBY-6256-3397f9f0 | DERBY-6256: Make XmlVTI take a file name argument rather than a file URL argument; commit derby-6256-03-aa-useFileNotURL.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1499484 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/XmlVTI.java",
"hunks": [
{
"added": [
"import java.io.File;",
"import java.io.FileInputStream;"
],
"header": "@@ -21,8 +21,8 @@ limitations under the License.",
"removed": [
"import java.io.InputS... |
derby-DERBY-6256-d08ab9b8 | DERBY-6256: Add basic tests for XmlVTIs, including a new way to create XmlVTIs from url strings; tests passed cleanly on derby-6256-04-aa-addURLFactoryMethodAndTests.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1500706 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/XmlVTI.java",
"hunks": [
{
"added": [
"import java.io.InputStream;",
"import java.net.URL;"
],
"header": "@@ -23,7 +23,9 @@ package org.apache.derby.vti;",
"removed": []
},
{
"added": [
... |
derby-DERBY-6258-29435de7 | DERBY-6258: Restrict permissions on BACKUP.HISTORY
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1492110 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile4.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.io.FileUtil;"
],
"header": "@@ -37,6 +37,7 @@ import java.nio.channels.FileChannel;",
"removed": []
}
]
}
] |
derby-DERBY-6259-2ae1afef | DERBY-6259: Commit derby-6259-01-aa-collapseOptimizers.diff, eliminating the level 2 optimizer.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1492641 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OptimizerFactoryImpl.java",
"hunks": [
{
"added": [
"\t\treturn true;"
],
"header": "@@ -181,7 +181,7 @@ public class OptimizerFactoryImpl",
"removed": [
"\t\treturn false;"
]
}
... |
derby-DERBY-6259-7f6b163b | DERBY-6259: Make optimizer fields private: tests passed cleanly on derby-6259-02-aa-increasePrivacy.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1492766 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OptimizerImpl.java",
"hunks": [
{
"added": [
"class OptimizerImpl implements Optimizer ",
"\tprivate LanguageConnectionContext lcc;",
"\tprivate DataDictionary\t\t\t dDictionary;",
"\tprivate int\t... |
derby-DERBY-626-3d61c1cc | DERBY-626 Re-work code to ensure that obtaining the enumeration of modules.properties
files as well as opening them is in a priviledge block. Removes the requirement for
read permission on derby.jar to be granted all the way up the stack when running with the
security manager.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@326727 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java",
"hunks": [
{
"added": [
"\tprivate Vector getImplementations(Properties moduleList, boolean actualModuleList) {"
],
"header": "@@ -1056,7 +1056,7 @@ abstract class BaseMonitor",
"... |
derby-DERBY-6261-80f5d3cd | DERBY-6261; test getCurConnJdbc20.sql is no longer useful and can be removed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1492870 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6262-1f18dc31 | DERBY-6262: Simplify message-generating methods using varargs
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1493714 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/SqlException.java",
"hunks": [
{
"added": [
" * using initCause()."
],
"header": "@@ -158,9 +158,7 @@ public class SqlException extends Exception implements Diagnosable {",
"removed": [
" ... |
derby-DERBY-6262-434e1655 | DERBY-6262: Simplify message-generating methods using varargs
Use varargs in EmbedConnection.newSQLException() and
ConnectionChild.newSQLException().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1496449 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
" newSQLException(SQLState.LOGIN_FAILED, \"java.lang.OutOfMemoryError\");"
],
"header": "@@ -137,7 +137,7 @@ public class EmbedConnection implements EngineConnectio... |
derby-DERBY-6262-b5a921a8 | DERBY-6262: Simplify message-generating methods using varargs
Reduce number of trace methods in LogWriter using varargs and
auto-boxing.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1496410 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/LogWriter.java",
"hunks": [
{
"added": [
" // --------------------------- method entry tracing --------------------------",
" public void traceEntry(Object instance, String methodName, Object... args) {",
" ... |
derby-DERBY-6262-c465481d | DERBY-6262: Simplify message-generating methods using varargs
Reduce number of methods that format messages in tools classes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1495023 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java",
"hunks": [
{
"added": [
" Object[] argMsg = null;",
"",
" argMsg = new String[args.length];"
],
"header": "@@ -3496,11 +3496,12 @@ public final class ... |
derby-DERBY-6262-e1a79c33 | DERBY-6262: Simplify message-generating methods using varargs
Use varargs in more constructors in SqlException and
DisconnectException. Since the message arguments in some of those
methods were not the last arguments, some reordering of arguments in
the callers was needed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1494541 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientResultSet.java",
"hunks": [
{
"added": [
" ioe, \"java.io.IOException\", ioe.getMessage());"
],
"header": "@@ -5515,7 +5515,7 @@ public abstract class ClientResultSet implements ResultSet,"... |
derby-DERBY-6263-54d20ec0 | DERBY-6263: Add missing clauses to Visitor logic of SelectNode; tests passed cleanly on derby-6263-02-aa-ignored-clauses-in-SelectNode.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1493789 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SelectNode.java",
"hunks": [
{
"added": [
"",
" // visiting these clauses was added as part of DERBY-6263. a better fix might be to fix the",
" // visitor rather than skip it.",
" ... |
derby-DERBY-6263-65ffd9b1 | DERBY-6263: Add defensive code to Visitor support in SelectNode; tests passed cleanly on derby-6263-03-ab-defensiveNullChecking-in-SelectNode.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1494220 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SelectNode.java",
"hunks": [
{
"added": [
" if (orderByLists != null)",
" {",
" for (int i = 0; i < orderByLists.length; i++)",
" {",
"... |
derby-DERBY-6263-91405aff | DERBY-6263: Make the Visitor logic inspect ORDER BY, FETCH, and OFFSET CLAUSES. Tests passed cleanly for me on derby-6263-01-aa-visit-ignored-clauses.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1493123 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CursorNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.Visitor;"
],
"header": "@@ -30,6 +30,7 @@ import org.apache.derby.iapi.reference.SQLState;",
"removed": []
},
... |
derby-DERBY-6266-b197ffaf | DERBY-6266: Add ability to print Derby execution ResultSet graph as xml.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1494115 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/ResultSet.java",
"hunks": [
{
"added": [
"import org.w3c.dom.Element;"
],
"header": "@@ -29,6 +29,7 @@ import org.apache.derby.iapi.sql.Row;",
"removed": []
}
]
},
{
"file": "java/engine/org/ap... |
derby-DERBY-6267-8eb8753d | DERBY-6267: Add tests for compact optimizer overrides on queries with FETCH/OFFSET clauses; commit derby-6267-04-aa-fetchOffsetTest.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1506054 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6267-a56ecfa3 | DERBY-6267: Add first rev of complete plan overrides; merged derby-6267-01-ae-compactSyntax.diff to head of trunk.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1499012 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/StatementUtil.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.CompilerContext;",
"import org.apache.derby.iapi.sql.dictionary.DataDictionary;",
"import org.apache.derby.iapi.sql.dictionary.S... |
derby-DERBY-6267-a80adcad | DERBY-6267: Add optimizer override tests for more kinds of subqueries; tests for derby-6267-03-aa-moreSubqueryTests.diff passed cleanly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1501891 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6267-bbb545ef | DERBY-6267: Count row sources in optimizer overrides at optimize() time rather than bind() time; add more tests for optimizer overrides; tests passed cleanly on derby-6267-02-aa-moreTests.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1501411 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/OptimizerPlan.java",
"hunks": [
{
"added": [
" CompilerContext cc"
],
"header": "@@ -94,8 +94,7 @@ public abstract class OptimizerPlan",
"removed": [
" CompilerContext cc,",
... |
derby-DERBY-6268-da3d219a | DERBY-6268: Run-time statistics not collected if query contains always false predicate
Make ProjectRestrictResultSet.close() call super.close() so that the
logic for dumping run-time statistics gets executed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1495943 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6272-ddca784d | DERBY-6272: LoginTimeoutTest fails if server is missing
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1496406 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6273-cd5717c7 | DERBY-6273: NullPointerException when using more than one parameter in COALESCE
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1496837 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-628-f225091f | DERBY-628: Allow setting a CLOB to NULL using any character types for setNull.
Submitted by Satheesh Bandaram(satheesh@sourcery.org)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@375877 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6280-29357110 | DERBY-6280; test failure in SetQueryTimeoutTest ComparisonFailure: Output at line 16 expected:<Test[ing that PreparedStatement remembers timeout.]> but was:<Test[ SetQueryTimeoutTest FAILED]>
adding details to the failure messages for this case
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1571534 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6283-a2f00b4a | DERBY-6283 indexStat daemon processing tables over and over even when there are no changes in the tables in soft upgraded database.
Changed system to always drop orphaned stats during update statistics call.
Without this change soft upgraded systems running on 10.8 or higher derby
software, that had an orphaned statistic would spin forever in the index
stat daemon due to the same problem fixed by DERBY-5680 for hard
upgraded databases.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1502319 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/daemon/IndexStatisticsDaemonImpl.java",
"hunks": [
{
"added": [
"",
" // can only properly identify disposable stats if cds == null, ",
" // which means we are processing all indexes on the conglo... |
derby-DERBY-6285-daaa0466 | DERBY-6285: Use factory method to create thread pool for timed login
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1499257 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/InternalDriver.java",
"hunks": [
{
"added": [
"import java.util.concurrent.ExecutorService;",
"import java.util.concurrent.Executors;"
],
"header": "@@ -38,10 +38,10 @@ import java.util.Properties;",
"remo... |
derby-DERBY-6287-edd6d3c8 | DERBY-6287: Don't use reflection to call Java 6 methods in FileUtil
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1499317 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FileUtil.java",
"hunks": [
{
"added": [],
"header": "@@ -594,13 +594,7 @@ nextFile:\tfor (int i = 0; i < list.length; i++) {",
"removed": [
" // Reflection helper objects for calling into Java >= 6",
... |
derby-DERBY-6296-221abb6f | DERBY-6296: Simplify PropertyUtil using Properties.stringPropertyNames()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1504809 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/util/PropertyUtil.java",
"hunks": [
{
"added": [
"import java.util.Arrays;",
"import java.util.Collections;",
"import java.util.Set;"
],
"header": "@@ -22,9 +22,11 @@",
"removed": [
"im... |
derby-DERBY-6297-643e68c9 | DERBY-6297: Intermittent failures in XplainStatisticsTest.testSimpleXplainOnly
Make AccessDatabase.schemaExists() close the ResultSet.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1518111 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/planexporter/AccessDatabase.java",
"hunks": [
{
"added": [
" try {",
" while (result.next()) {",
" if (result.getString(1).equals(schema)) {",
" // Foun... |
derby-DERBY-630-16c8b880 | DERBY-630: CREATE TRIGGER fails with null pointer exception
This patch was contributed by Yip Ng (yipng168@gmail.com)
The current implementation for CREATE TRIGGER needs to handle null compilation
schema. A compilation schema with null value indicates that the
trigger action statement text does not depend on the current schema. This means:
1. It is safe to compile this statement in any schema since there is no dependency with
the CURRENT SCHEMA. i.e.: All relevent fields are qualified with a specific schema.
2. The statement cache mechanism can utilize this piece of information to enable
better statement plan sharing across different schemas; thus, avoiding unnecessary
statement compilation.
So the proposal is:
a) Allow null compilation schema. The system catalog first needs to change the
compiliation schema id column of SYS.SYSSTATEMENTS and SYS.SYSVIEWS system
table's nullability to true. This would also require a soft upgrade for the
previous versions of Derby. This step will resolve the NPE problem of this jira.
b) Handle null compilation schema in statement preparation logic. This can be filed
as a separate jira as improvement. It may require some work on the SQL parser to
determine whether the compiled statement depends on the CURRENT SCHEMA or not, so
that the compilation schema can be properly set.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@464215 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java",
"hunks": [
{
"added": [
"\t\tcase DataDictionary.DD_VERSION_DERBY_10_3:",
"\t\t\treturn \"10.3\";"
],
"header": "@@ -148,6 +148,8 @@ public\tclass DD_Version implements\tFormatable",
... |
derby-DERBY-6306-9850fb9a | DERBY-6306: XplainStatisticsTest.testSimpleQuery: BEGIN_COMP_TIME unexpectedly NULL
Clear the statement cache between test cases so that statements from
earlier test cases don't affect the results.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1518533 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6314-489530b1 | DERBY-6314: Upgrade from 10.10 fails with ClassCastException
Make ExecRowBuilder implement the Formatable interface so that any
Formatable instances referenced from its fields are stored using
Formatable logic instead of Serializable logic.
Add type checking in FormatIdInputStream's error handlers to prevent
the underlying exception from being shadowed by a ClassCastException
under certain circumstances.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1517761 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FormatIdInputStream.java",
"hunks": [
{
"added": [],
"header": "@@ -27,7 +27,6 @@ import java.io.InputStream;",
"removed": [
"import org.apache.derby.shared.common.sanity.SanityManager;"
]
},
... |
derby-DERBY-6314-e6ea6446 | DERBY-6314: Upgrade from 10.10 fails with ClassCastException
Make sure stored plans for metadata queries are cleared the same
way as trigger plans during upgrade, so that upgrade doesn't fail
if the format of the old metadata plans cannot be read by the new
version.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1517533 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DD_Version.java",
"hunks": [
{
"added": [
" // Make sure all stored plans are cleared, both for triggers and",
" // for metadata queries. The plans will be recompiled automatically",
" ... |
derby-DERBY-6317-b25e3a78 | DERBY-6317 Optmizer can choose the wrong path when BTreeCostController.java returns an estimate cost and row count of 0.0
The Optimizer estimates do not handle well 0 row counts coming out of store.
These estimates end up getting multiplied by other estimates and the resulting
0 costs caused the incorrect plan to be picked in the repro included with
this fix. This fix changes store cost to always return at least a minimum
of one row when asked to estimate the number of rows in an exact range of
keys from an index. This minimum is consistent with the optimizer assumption
that an exact key match on a unique index will also return 1 row.
Thanks to Brett Bergquist for debugging and suggesting a fix and to mamta
satoor for providing a reproducible test case for the bug.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1521310 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/btree/BTreeCostController.java",
"hunks": [
{
"added": [
" // DERBY-6317",
" // In the case of unique indexes we always estimate a return of",
" // 1 row for a equality term... |
derby-DERBY-6318-638cea5e | DERBY-6318: Simplify setting of possibly null parameters in XPLAIN descriptors
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1518534 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/XPLAINResultSetTimingsDescriptor.java",
"hunks": [
{
"added": [],
"header": "@@ -26,7 +26,6 @@ import java.sql.SQLException;",
"removed": [
"import org.apache.derby.impl.sql.catalog.SystemColumnImpl;"
]
... |
derby-DERBY-6320-e8e1864a | DERBY-6320 Log a page dump to derby.log if ERROR nospc: nospc.U is returned to the user
This patch adds the ability to dump a page in an insane build, and adds 2 calls to do so in 2 outstanding nospc error cases. In those two cases a new user
level error is thrown and nests the nospc.U error so that we still know the
original stack trace where the lowest error was thrown.
The patch passes all tests and the specific errors were hand tested, one of
them using the test case filed in DERBY-4923 and in the other case just by hand forcing the codepath.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1535075 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/StoredPage.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.reference.MessageId;"
],
"header": "@@ -32,6 +32,7 @@ import java.util.Arrays;",
"removed": []
},
{
"added":... |
derby-DERBY-6323-f668d94d | DERBY-6323: Fix incorrect @throws and @exception tags in javadoc
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1519954 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientDatabaseMetaData.java",
"hunks": [
{
"added": [
" * @exception SQLException if a database error occurs"
],
"header": "@@ -1167,7 +1167,7 @@ public abstract class ClientDatabaseMetaData implements DatabaseMeta... |
derby-DERBY-6324-b6cdb88b | DERBY-6324; DatabaseMetaData.getJDBCMinorVersion() should return 2 now that we've implemented JDBC 4.2
Adding logic to JVMInfo to identify the supported JDBC level based on the
(currently supported) JVM versions, which then is used in the client and embedded drivers.
Tests are changed to reflect this.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1519785 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientDatabaseMetaData.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
],
"header": "@@ -29,6 +29,7 @@ import java.sql.SQLException;",
"removed": []
},
{
... |
derby-DERBY-6337-47758e26 | DERBY-6337(derbynet.ServerPropertiesTest.ttestSetPortPriority prints exception java.lang.Exception: DRDA_InvalidReplyTooShort.S:Invalid reply f rom network server: Insufficient data. but test passes)
Basically the issue is that sometimes when server is shutting down and a ping is sent to it around the same time, ping might be able to connect to server but before the ping hand shake can complete, the server might shutdown thus resulting in the ping client receiving a DRDA_InvalidReplyTooShort. This is probably why the test in this issue fails intermittently. To fix the issue, if ping does run into DRDA_InvalidReplyTooShort.S:Invalidreply, we will send another ping after waiting for a little time, and this time around we should get expected can't connect to server exception because server is down by now.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1594435 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
" //DERBY-6337(derbynet.ServerPropertiesTest.ttestSetPortPriority prints ",
" // exception java.lang.Exception: ",
" // DRDA_InvalidRep... |
derby-DERBY-634-f18825aa | DERBY-634: Prevent StackOverflow due to bad subquery optimization. Prevent cases of subquery optimization that can cause runtime stack overflow.
Submitted by Satheesh Bandaram (satheesh@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@431293 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/BaseActivation.java",
"hunks": [
{
"added": [
"\t * Optimization implemented as part of Beetle: 4373 can cause severe stack overflow",
"\t * problems. See JIRA entry DERBY-634. With default MAX_MEMORY_PER_TABLE of 1MG... |
derby-DERBY-6342-709b46ee | DERBY-6342: failure in ConglomerateSharingTest.testConstraintDrops
Accept different errors from statements that violate multiple
constraints, since it's not deterministic which constraint is checked
first.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1610373 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6346-3249e773 | DERBY-6346: Fix LEFT JOIN involving a table with a generated column; tests passed cleanly on derby-6346-02-aa-generateNullForLeftJoins.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1524194 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6348-1061fd20 | DERBY-6348: NPE or assert failure in recursive trigger
Reset the activation in the statement context before setting up the
activation for the next trigger, so that the nested trigger activation
is a child of the top-level activation, and not a child of the
previous trigger's activation.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1537393 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6349-37ad9f35 | DERBY-6349 DaylightSavingTest - java.security.AccessControlException
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1524579 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TimeZoneTestSetup.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;"
],
"header": "@@ -19,6 +19,8 @@",
"removed": []
},
{... |
derby-DERBY-6350-24d620a6 | DERBY-6350 (Provide a rolling file implementation of derby.log)
Committing patch submitted by Brett Bergquist
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1533320 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/reference/Property.java",
"hunks": [
{
"added": [
" ",
" /**",
"\t\tderby.stream.error.style=<b>The error stream error style.</b>",
" <b>rollingFile<b> is the only file currently supported.",
... |
derby-DERBY-6351-29f83260 | DERBY-6351: Syntax error on equal transition table name and correlation name in statement trigger
Change how CreateTriggerNode.bindReferencesClause() checks for the
lack of a correlation name. Instead of checking it indirectly (and
unreliably) by seeing if the table name matches the base table name,
check directly if the correlation name is null.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1526406 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateTriggerNode.java",
"hunks": [
{
"added": [],
"header": "@@ -602,7 +602,6 @@ class CreateTriggerNode extends DDLStatementNode",
"removed": [
"\t\t\t\tString refTableName = fromTable.getTableName().getTableN... |
derby-DERBY-6352-636f0a05 | DERBY-6352; Access denied ("java.lang.RuntimePermission" "modifyThread") in store.RecoveryAfterBackup test
adding try/catch code to provide more information when this happens
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1531721 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/context/ContextService.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
],
"header": "@@ -27,6 +27,7 @@ import java.util.HashSet;",
"removed": []
},
{
... |
derby-DERBY-6352-770bedf7 | DERBY-6352; Access denied ("java.lang.RuntimePermission" "modifyThread") highly intermittent, but e.g. in store.RecoveryAfterBackup test
When we see a AccessControlException during shutdown in the notifyAll call, do nothing, which lets the Thread finish on its own.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1590817 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/context/ContextService.java",
"hunks": [
{
"added": [],
"header": "@@ -27,7 +27,6 @@ import java.util.HashSet;",
"removed": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
]
},
{
... |
derby-DERBY-6356-9698d412 | DERBY-6356; java.security.AccessControlException in i18n.LocalizedDisplayScriptTest
switching the test to use TimeZoneTestSetup which already has the required privilege blocks.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1527143 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6357-1a58030d | DERBY-6357: CREATE TRIGGER doesn't detect all illegal references to SESSION schema
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1527963 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6361-99aa2411 | DERBY-6361: Valid statements rejected if Derby has not implicitly
created the current user's schema.
Make compilation of the generation clause accept that the original
compilation schema does not exist.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1532997 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6362-69f8afa5 | DERBY-6362: CHECK constraint uses wrong schema for unqualified routine invocations
Part 1: Make sure visitors descend into all TableName nodes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1548127 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/AggregateNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.Visitor;"
],
"header": "@@ -31,6 +31,7 @@ import org.apache.derby.iapi.services.loader.ClassFactory;",
"removed": []... |
derby-DERBY-6362-9d9f6dd0 | DERBY-6362: CHECK constraint uses wrong schema for unqualified routine invocations
Part 3:
- Refactor code that rewrites trigger actions so that it can be reused
for rewriting CHECK constraints.
- Rewrite CHECK constraints and make all identifiers schema qualified
before storing them in the dictionary.
- Make the parser preserve the TableName node for the target type in
CAST expressions for user-defined types, so that they get detected
by the rewrite logic.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1548132 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -32,7 +32,6 @@ import java.sql.Types;",
"removed": [
"import java.util.Comparator;"
]
},
{
"added": [
"impo... |
derby-DERBY-6363-2335e5c5 | DERBY-6363: Incorrect evaluation of logical expressions in CASE
Skip conversion of OR nodes to IN lists if the OR node is not on
conjunctive normal form.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1529099 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/OrNode.java",
"hunks": [
{
"added": [
" *",
" * We only convert the OR chain to an IN list if it has been",
" * normalized to conjunctive normal form (CNF) first. That is, the",
... |
derby-DERBY-6370-0342a825 | DERBY-6370: dblook doesn't schema-qualify identifiers in trigger actions
Remove no longer needed offset fields in CreateTriggerNode.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1592695 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateTriggerNode.java",
"hunks": [
{
"added": [],
"header": "@@ -71,8 +71,6 @@ class CreateTriggerNode extends DDLStatementNode",
"removed": [
" private final int whenOffset;",
" priva... |
derby-DERBY-6370-0cefeda9 | DERBY-6370: dblook doesn't schema-qualify identifiers in trigger actions
Rewrite the triggered SQL statement and the WHEN clause of a trigger
so that all identifiers are fully qualified, before they are stored in
SYS.SYSTRIGGERS and SYS.SYSSTATEMENTS. This way, dblook is able to use
the information in the system tables to produce DDL that is
independent of the schema in which it is executed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1591216 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/DataDictionary.java",
"hunks": [
{
"added": [
" *",
" * @param replacements a list that will be populated with objects that",
" * describe how {@code triggerDefinition} has been transformed i... |
derby-DERBY-6370-eab88ec5 | DERBY-6370: dblook doesn't schema-qualify identifiers in trigger actions
Remove unnecessary DataDictionary parameter from TableName.bind().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1592726 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CurrentOfNode.java",
"hunks": [
{
"added": [
" if (columnsTableName != null",
" && columnsTableName.getSchemaName() == null",
" && correlationName == null) {",
... |
derby-DERBY-6371-6c2e1b4a | DERBY-6371: DROP COLUMN looks in wrong schema when checking trigger dependencies
Use the same schema during dependency checking as during compilation
of the trigger action.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1530517 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java",
"hunks": [
{
"added": [],
"header": "@@ -22,7 +22,6 @@",
"removed": [
"import java.util.Iterator;"
]
},
{
"added": [
" SchemaDescripto... |
derby-DERBY-6373-d3fbd727 | DERBY-6373: NPE in Statement.getWarnings()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1534523 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-638-2ba89c55 | DERBY-638 Network driver setTransactionIsolation() causes a commit, but does not complete it locally
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@474720 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6380-1850f649 | DERBY-6380; Rolling log files do not get copied in failed directory when a junit test fails
removing two 'fail' commands left over from debugging, and streamlining clean up in ErrorStreamTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1545957 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6380-ccf120cb | DERBY-6380; Rolling log files do not get copied in failed directory when a junit test fails
adjusting ErrorStreamTest to copy files created in it on fail, and BaseTestCase to copy defaults on fail.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1545935 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6383-10982582 | DERBY-6383(Update trigger defined on one column fires on update of other columns)
Adding more junit tests for checking the affects of adding/dropping columns to the table with update triggers defined on it.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1541170 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6383-374d58fe | DERBY-6383(Update trigger defined on one column fires on update of other columns).
This regression is caused by DERBY-4874(Trigger does not recognize new size of VARCHAR column expanded with ALTER TABLE. It fails with ERROR 22001: A truncation error was
encountered trying to shrink VARCHAR)
The regression is for Statement level triggers. The statement trigger gets fired incorrectly for any column update rather than just the column specified in the UPDATE of column clause. The fix is going to ensure that SYSTRIGGERS has the correct list of columns on which trigger should be fired. Row level triggers work fine. The only workaround at this point is to drop and recreate the statement triggers.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1537593 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateTriggerNode.java",
"hunks": [
{
"added": [
"\t\t\t//then it means that a set of trigger columns are specified",
"\t\t\t//in the CREATE TRIGGER statement. This can only happen for",
"\t\t\t//an UPDATE t... |
derby-DERBY-6396-d32b042d | DERBY-6396: NullPointerException in DirFile
Check that the array returned by File.list() is non-null before
attempting to iterate through it. Null is a valid return value.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1537394 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile.java",
"hunks": [
{
"added": [
" // Nothing to do if the file doesn't exist.",
" if (!exists()) {",
" }",
"",
" // If the file is a directory, delete its conten... |
derby-DERBY-64-1453acc5 | DERBY-64 (partial): Implement CREATE TABLE ... AS ... WITH NO DATA
functionality in accordance with SQL 2003 standards. In this patch:
- SQLState.java and messages.xml were modified to add three messages
to flag various errors. These error messages are similar to those
used by CREATE VIEW.
- sqlgrammer.jj was modified to support the following syntax:
CREATE TABLE new_table AS subquery WITH [NO] DATA
- CreateTableNode.java was modified to define a new init method to
take a result column list and a query expression. The bindStatement
method was modified to bind the quiery expression and create the
table element list from the result column list and the query
expression.
- A new JUnit test, CreateTableFromQueryTest, was added to the lang
suite.
The current patch does not implement the WITH DATA option.
Contributed by James F. Adams (derby@xemaps.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@495750 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateTableNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.depend.ProviderList;",
"import org.apache.derby.iapi.sql.compile.CompilerContext;",
"import org.apache.derby.iapi.sql.conn.Aut... |
derby-DERBY-6400-b2686e64 | DERBY-6400; harness.NetServer method waitFor() is not reflecting timeout values
adding code to pass on a timeout value when specified on in the commandline
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1538692 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/NetServer.java",
"hunks": [
{
"added": [
"\tint timeout=60;"
],
"header": "@@ -41,6 +41,7 @@ public class NetServer",
"removed": []
},
{
"added": [
"\t",
... |
derby-DERBY-6401-68e06acc | DERBY-6401 Create a test option to stop running Junit tests after first failure or error
Adds test option. If run with -Dderby.tests.stopAfterFirstFail=true tests will stop after first failure or error
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1539729 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
"",
" /**",
" * derby.tests.stopAfterFirstFail - debugging property to exit after ",
" * first failure. Can be useful for debugging cascadin... |
derby-DERBY-6410-d27662da | DERBY-6410: ClassCastException when launching derby from windows subst drive
Avoid calling Files.getFileStore() since it fails when called on a
file that lives on a subst drive. (Because of a bug in the JVM:
JDK-8034057.)
It is used for checking if a specific FileAttributeView is supported
on the file system. The same information can be found by checking if
Files.getFileAttributeView() returns null, which we already do, so
skip the failing call.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1585407 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FilePermissionServiceImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -23,7 +23,6 @@ package org.apache.derby.iapi.services.io;",
"removed": [
"import java.nio.file.FileStore;"
]
}
]
}
] |
derby-DERBY-6411-e3720ab0 | DERBY-6411: Minimal select privilege should be checked in subqueries
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1541461 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CompilerContextImpl.java",
"hunks": [
{
"added": [
" // If we are here for MIN_SELECT_PRIV requirement, then first",
" // check if there is already a SELECT privilege requirement on any",
... |
derby-DERBY-6414-a826375a | CERBY-6414(Incorrect handling when using an UPDATE to SET an identity column to DEFAULT)
I have created DERBY-6742 for JDBC part of this feature so we can generate auto generated resultset for an update statement updating generated columns. This implementation is supported through Statement.RETURN_GENERATED_KEYS flag.
Junit tests for this feature are in GeneratedColumnsTest.java. Upgrade tests are in Changes10_12.java. Upgrade test shows that a soft upgrade from pre-10.11 will not support update of generated columns using DEFAULT but 10.11 to trunk soft upgrade will allow it. This is because starting 10.11, we have started using sequence generator to create unique ids. If we want to support updating of idetity columns for pre-10.11 releases, we will need to maintain the code for old way of generating unique ids. In order to avoid that, this feature is available to only 10.11 db during soft upgrade.
For UPDATE of identity column to work in the MERGE sql, we need to make changes to MERGE code(DERBY-6743). MERGE already has required code for insert putting DEFAULT in generated columns. Implementation needs to be added for update putting DEFAULT in generated columns in case of MERGE. In the mean time, I have renamed existing junit test test_015_bug_6414 to atest_015_bug_6414 in MergeStatementTest.java so we do not run into failures.
Some detail about the part of the implementation that was tricky for DERBY-6414.
The existing code was originally written to handle inserting values in identity columns using DEFAULT. In case of insert, InsertResultSet uses ColumnDescriptors in resultDescription to find the type of the generated columns. This data structure holds the column descriptors of all the columns in the table. All the columns are in this data structure because even though INSERT statement may not explicitly assign a value to each and every column in the table, all the columns end up getting some value in them through an INSERT statement. The code in InsertResultSet.initializeAIcache method relies on availability of all the columns type information. But in case of Update, resultDescription does not include all the columns in the table. It only has the columns being touched by the Update statement(the rest of the columns in the table will retain their original values), and for each of those touched columns, it has a duplicate entry in resultDescription in order to have before and after values for the changed column values. This difference in array content of resultDescription requires us to have separate implementation of initializeAIcache method for insert and update.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1625884 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [],
"header": "@@ -41,13 +41,11 @@ import org.apache.derby.iapi.sql.dictionary.ColumnDescriptorList;",
"removed": [
"import org.apache.derby.iapi.sql.dictionary.SequenceDe... |
derby-DERBY-642-20cc8ad0 | DERBY-642: SELECT MAX doesn't use indices optimally
First attempt on a B-tree max scan that walks backwards. Includes some
test cases that test latch conflicts.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1071171 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/btree/BTreeMaxScan.java",
"hunks": [
{
"added": [],
"header": "@@ -27,11 +27,6 @@ import org.apache.derby.iapi.services.sanity.SanityManager;",
"removed": [
"import org.apache.derby.iapi.store.access.RowUtil;",... |
derby-DERBY-642-9d9c1422 | DERBY-642: SELECT MAX doesn't use indices optimally
Added test case to verify that serializable transactions will discover
that a new row with a higher value was inserted while the scan was
waiting for a lock.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1074196 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-642-e47817ab | DERBY-642: SELECT MAX doesn't use indices optimally
In the case of a WaitError, wait until the latch on the left sibling
has been released before repositioning. If the repositioning happens
earlier, it will just hit the same WaitError and the work will be
wasted.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1075248 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/btree/BTreeMaxScan.java",
"hunks": [
{
"added": [
" // position and let the caller retry. But first, let's save the",
" // page number of the left sibling so that we can try again to",
... |
derby-DERBY-6421-35c061a6 | DERBY-6421: Cast to UDT in CHECK constraint causes NPE or assert failure
Delay binding of target UDT in CastNode till bind time.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1548104 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CastNode.java",
"hunks": [
{
"added": [
"",
" /** The original, unbound descriptor for the target type, if it is a UDT. */",
" private DataTypeDescriptor targetUDT;",
""
],
"h... |
derby-DERBY-6423-aaac214f | DERBY-6423: The expression syntax in CASE's THEN clause doesn't accept boolean value expression
Allow boolean value expressions in CASE and NULLIF expressions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1592465 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6429-070d37e3 | DERBY-6429: Bring privilege checks on UPDATE statements into closer alignment with the SQL Standard; tests passed cleanly on derby-6429-01-af-privilegeFilters.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1553197 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/Visitable.java",
"hunks": [
{
"added": [
"import java.util.List;",
""
],
"header": "@@ -21,6 +21,8 @@",
"removed": []
}
]
},
{
"file": "java/engine/org/apache/derby/iapi/sql/c... |
derby-DERBY-6432-dc3a0d79 | DERBY-6434: Test case verifying that DERBY-6432 has been fixed; commit derby-6434-03-ac-testCaseForDerby-6432.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558398 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6433-d1ad6c97 | DERBY-6434: Don't make INSERT statements require USAGE privilege on the datatypes of generated columns; fix remaining problem described by DERBY-6433; commit derby-6434-04-aa-dontNeedPrivOnGeneratedColumnTypeForInsert.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558559 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [],
"header": "@@ -265,7 +265,6 @@ public final class InsertNode extends DMLModStatementNode",
"removed": [
" getCompilerContext().removePrivilegeFilter( ignorePerm... |
derby-DERBY-6434-3d2d88b7 | DERBY-6434: Correct privileges required for INSERT statements; tests passed cleanly on derby-6434-01-ac-correctInsertPrivs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1556571 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.IgnoreFilter;"
],
"header": "@@ -33,6 +33,7 @@ import org.apache.derby.iapi.services.io.FormatableBitSet;",
"removed": ... |
derby-DERBY-6434-9a9d6589 | DERBY-6434: Don't require privileges implicitly added by SELECT-driven INSERTS; tests passed cleanly on derby-6434-05-aa-selectDrivenInserts.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1573686 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/SelectNode.java",
"hunks": [
{
"added": [
" //",
" // Don't add USAGE privilege on user-defined types.",
" //",
" boolean wasSkippingTypePrivileges = getCompilerContext(... |
derby-DERBY-6434-d1ad6c97 | DERBY-6434: Don't make INSERT statements require USAGE privilege on the datatypes of generated columns; fix remaining problem described by DERBY-6433; commit derby-6434-04-aa-dontNeedPrivOnGeneratedColumnTypeForInsert.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558559 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/InsertNode.java",
"hunks": [
{
"added": [],
"header": "@@ -265,7 +265,6 @@ public final class InsertNode extends DMLModStatementNode",
"removed": [
" getCompilerContext().removePrivilegeFilter( ignorePerm... |
derby-DERBY-6434-dc3a0d79 | DERBY-6434: Test case verifying that DERBY-6432 has been fixed; commit derby-6434-03-ac-testCaseForDerby-6432.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558398 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6434-fc9fd0d2 | DERBY-6434: Correct privilege checks for DELETE statements; commit derby-6434-02-ac-correctDeletePrivs.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1558387 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/compile/CompilerContext.java",
"hunks": [
{
"added": [
" public static final String WHERE_SCOPE = \"whereScope\";",
" "
],
"header": "@@ -132,6 +132,8 @@ public interface CompilerContext extends Con... |
derby-DERBY-6437-abd7a122 | DERBY-6437; ConstraintCharachteristicsTest testLockingWithRollback or testLockingWithCommit failing on trunk with AssertionFailedError - isolation levels ...
adjusting the derby.locks.waitTimeout.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1563032 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6440-b412f102 | DERBY-6440: Drop connection to foreign database when foreignViews optional tool is unloaded.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1553269 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/optional/ForeignDBViews.java",
"hunks": [
{
"added": [
"import org.apache.derby.vti.ForeignTableVTI;"
],
"header": "@@ -34,6 +34,7 @@ import org.apache.derby.iapi.sql.dictionary.OptionalTool;",
"removed": []
... |
derby-DERBY-6441-acbecbb9 | DERBY-6441: Add ORDER BY clauses to a number of queries in GrantRevokeDDLTest in order to force deterministic results; checks in derby-6441-01-addOrderByClauses.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1553280 13f79535-47bb-0310-9956-ffa450edef68
| [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.