id
stringlengths
22
25
commit_message
stringlengths
137
6.96k
diffs
listlengths
0
63
derby-DERBY-6443-065a81f2
DERBY-6443: ArrayIndexOutOfBoundsException when calling function from trigger StaticMethodCallNode.bindExpression() was a no-op if the node had already been bound. This caused problems for queries that need to bind expressions multiple times (for example INSERT INTO ... SELECT). This fix makes StaticMethodCallNode.bindExpression() work if it's called a second time, while still making it a no-op if it is called recursively in order to prevent infinite recursion. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1556809 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/StaticMethodCallNode.java", "hunks": [ { "added": [ "", " /**", " * This flag is true while bindExpression() is executing. It is used to", " * avoid infinite recursion when bindExpressio...
derby-DERBY-6447-584c0fb1
DERBY-6447: Use StrictMath for more functions in SYSFUN Make LOG10, COSH, SINH and TANH use the corresponding methods in java.lang.StrictMath instead of custom implementations. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1556810 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/catalog/SystemProcedures.java", "hunks": [ { "added": [], "header": "@@ -62,8 +62,6 @@ import org.apache.derby.impl.sql.catalog.XPLAINStatementTimingsDescriptor;", "removed": [ "import org.apache.derby.iapi.sql.dictionary.Catalo...
derby-DERBY-6453-f1677626
DERBY-6453 Remove dead code in InsertResultSet and flag skipCheckConstraints Patch _*cleanup-misc-3*_ which removes dead code but inserts asserts in sane mode if we should somehow end up with triggers in bulk insert mode and also removes a boolean variable in some interfaces which was always called with false: {{skipCheckConstraints}}. It adds a new test case, {{CheckConstraintTest#testbulkInsert}}. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1556938 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/TableDescriptor.java", "hunks": [ { "added": [], "header": "@@ -731,7 +731,6 @@ public class TableDescriptor extends UniqueSQLObjectDescriptor", "removed": [ "\t * @param\tskipCheckConstraints\tSkip check co...
derby-DERBY-6455-1d5c5918
DERBY-6455: Infinite loop in NetworkServerControlImpl.ensureDataInBuffer Make NetworkServerControlImpl.ensureDataInBuffer() stop immediately if it reaches end-of-stream. Based on patch contributed by Martin Janda. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1559946 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/NetworkServerControlImpl.java", "hunks": [ { "added": [ " * Ensure the reply buffer is large enough to hold all the data;", " * @param failOnEOS tells whether or not an error should be raised if", " * end...
derby-DERBY-6456-4a2a0386
DERBY-6456: Infinite loop in NetworkServerControlImpl when reply >= 32k Make sure the reply buffer in NetworkServerControlImpl is able to hold the longest possible reply that it could see. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1559943 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6457-badaed78
DERBY-6457: NetworkServerControl API breaks when username or password contains non-ascii characters Make NetworkServerControlImpl.writeLDString() write the length in bytes instead of characters to match how it is read by NetworkServerControlImpl.readLDString(). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1560311 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/SystemPropertyTestSetup.java", "hunks": [ { "added": [ " // Shut down the engine to restore any static properties. Do that", " // before the properties are reset to their old values, since the", "...
derby-DERBY-6464-3c6be538
DERBY-6464: Make more fields in ResultColumn private; tests passed cleanly on derby-6464-03-aa-morePrivateFields.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1563987 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumn.java", "hunks": [ { "added": [ "\tprivate boolean\t\t\t_autoincrementGenerated;", "\tprivate boolean \t\t_autoincrement;", "\tprivate ColumnReference _reference; // used to verify quals at bind ...
derby-DERBY-6464-b0456a0d
DERBY-6464: Improve encapsulation of ResultColumn and ColumnReference; tests passed cleanly for me on derby-6464-01-aa-makeFieldsPrivate.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1563368 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java", "hunks": [ { "added": [ "\t\t\t\tTableName tableName = ref.getQualifiedTableName();" ], "header": "@@ -4942,7 +4942,7 @@ public final class\tDataDictionaryImpl", "removed": [ ...
derby-DERBY-6468-27905092
DERBY-6468; Add a version number to derbyTesting.jar - a new properties file, org/apache/derby/info/tsting.properties, is generated with the required info - this file is inserted in to derbyTesting.jar - sysinfo reflects the location of the org.apache.derbyTesting package if an indicative class is found in the classpath git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1581885 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/sysinfo/Main.java", "hunks": [ { "added": [ " ", " // derbyTesting info", " try {", " reportTesting(aw);", " }", " catch (Exception e) {", " // i...
derby-DERBY-647-ece3ee65
DERBY-647 Fix code in MultiTest to generate correct log file names when the path contains a dot. Previous code was trying to be too smart, simplified to pass in directory and file name required. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@328515 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6477-8ab61cc5
DERBY-6477: OutOfMemoryError selecting from SYS.SYSALIASES Disable LIKE optimization for very long columns. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1567604 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/LikeEscapeOperatorNode.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.reference.Limits;" ], "header": "@@ -25,6 +25,7 @@ import java.sql.Types;", "removed": [] } ] } ]
derby-DERBY-6484-d6401b1d
DERBY-6484: Include SQLState in client exception messages git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1571615 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6488-28dc366e
DERBY-6488: Remove the EmbedSQLException class and the associated DerbySQLException interface. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1573534 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java", "hunks": [ { "added": [], "header": "@@ -65,7 +65,6 @@ import org.apache.derby.shared.common.sanity.SanityManager;", "removed": [ "import org.apache.derby.impl.jdbc.EmbedSQLException;" ] ...
derby-DERBY-6488-63574ff9
DERBY-6488: Get rid of the EmbedSQLException class Remove the newEmbedSQLException methods, since they don't produce EmbedSQLExceptions anymore, and use the SQLExceptionFactory methods instead. Add a Throwable parameter to seeNextException() so that the root cause will be shown when printStackTrace() is called on the top-level exception. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1573934 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java", "hunks": [ { "added": [ " handleException(mse), mse, dbname);" ], "header": "@@ -2645,8 +2645,7 @@ public class EmbedConnection implements EngineConnection"...
derby-DERBY-649-c700973f
DERBY-649: Push single table predicates that can be pushed into underlying SELECTs of a union. Merging from 10.1 branch. It is possible to further improve the patch to handle more cases for this optimization. Submitted by Satheesh Bandaram (satheesh@sourcery.org) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370247 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/PredicateList.java", "hunks": [ { "added": [ "\t * views or derived tables or into unions.", "\t * @param select\t\t\tThe underlying SelectNode.", "\t * @param copyPredicate\t\tWhether to make a copy of the ...
derby-DERBY-6491-b93f9db8
DERBY-6491: Don't require USAGE priv on the datatypes of SELECTed columns; commit derby-6491-ab-stopRequiringUsagePriv.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1573030 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/CompilerContextImpl.java", "hunks": [ { "added": [ " skippingTypePrivileges = false;" ], "header": "@@ -146,6 +146,7 @@ public class CompilerContextImpl extends ContextImpl", "removed": [] }...
derby-DERBY-6493-cb184fe8
DERBY-6493: Improve reporting of exceptions wrapped in InvocationTargetException Unwrap InvocationTargetException and PrivilegedActionException before reporting them so that it is easier to see what the real error is. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574425 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/error/StandardException.java", "hunks": [ { "added": [ "import java.lang.reflect.InvocationTargetException;", "import java.security.PrivilegedActionException;" ], "header": "@@ -21,6 +21,8 @@", "removed": ...
derby-DERBY-6495-b1c9bd27
DERBY-6495; Error in SelectivityTest.testBasic add more columns to a number of order by statements to pin the results down. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574634 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6496-4e7a614b
DERBY-6496: Simplify the test case git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574946 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6496-63ecb285
DERBY-6496: Fix NPE in loading of the optimizer tracing tool; tests passed cleanly on derby-6496-02-aa-optimizerTracer.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1574927 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/OptimizerTracer.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.services.loader.ClassFactoryContext;" ], "header": "@@ -31,7 +31,7 @@ import org.apache.derby.iapi.reference.SQLState;", "remo...
derby-DERBY-6500-0ee1994f
DERBY-6500: Add ORDER BY clauses to the queries in AutoIncrementTest in order to eliminate row ordering diffs in the test results; commit derby-6500-01-aa-addOrderByClauses.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1577190 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6502-dc1acc4b
DERBY-6502; Failure in OnlineCompressTest adding calls to wait for post commit tasks in the hope of addressing instability in OnlineCompressTest. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1592630 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6503-4f7eee8a
DERBY-6503: ClassCastException when network server cannot restrict file permissions Make sure the underlying IOException is exposed if the network server fails to restrict file permissions. The original exception used to be shadowed by a ClassCastException. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1580789 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/DssTrace.java", "hunks": [ { "added": [], "header": "@@ -25,7 +25,6 @@ import java.io.FileNotFoundException;", "removed": [ "import java.security.PrivilegedAction;" ] } ] }, { "file": "java/engi...
derby-DERBY-6505-030bfacb
DERBY-6505: Clean up dead code in FileUtil Add test that exercises FileUtil methods that are only used in soft upgrade from 10.8 or earlier when backing up databases that contain jar files. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1576691 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6505-d56ee6a7
DERBY-6505: Clean up dead code in FileUtil git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1576673 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FileUtil.java", "hunks": [ { "added": [], "header": "@@ -102,94 +102,6 @@ public abstract class FileUtil {", "removed": [ "\tpublic static boolean removeDirectory(String directory)", "\t{", "...
derby-DERBY-651-21d74bf3
DERBY-651: Add tests verifying that you can't drop a UDT or revoke USAGE on it if this would orphan a trigger. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@892354 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-651-2209325d
DERBY-651: Add dependencies of routines on UDTs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@890115 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/AliasDescriptor.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.sql.depend.Dependent;", "import org.apache.derby.iapi.reference.SQLState;" ], "header": "@@ -23,9 +23,11 @@ package org.a...
derby-DERBY-651-3210ebc9
DERBY-651: Adjust JDBC metadata to account for UDTs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@893224 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java", "hunks": [ { "added": [ " private static final int ILLEGAL_UDT_TYPE = 0;", " " ], "header": "@@ -88,6 +88,8 @@ import java.io.InputStream;", "removed": [] } ...
derby-DERBY-651-7a2d290a
DERBY-651: Add tests for big UDTs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@907509 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-651-90f42b43
DERBY-651: Prevent a schema from being dropped if it contains any UDTs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@892485 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/JDBC.java", "hunks": [ { "added": [ " \" AND CHAR(A.ALIASTYPE) = ? \" +", " psf.setString(1, \"F\" );", " psf.setString(2, schema);", "" ], "header": "@@ -...
derby-DERBY-651-989beca3
DERBY-651: Address instability in UDTPermsTest caused by different string representation of timestamp 0L on different platforms. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@892327 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-651-b4af7da0
DERBY-651: Make it possible to have UDT columns in table functions. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@907097 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/QueryTreeNode.java", "hunks": [ { "added": [ "import org.apache.derby.catalog.TypeDescriptor;", "import org.apache.derby.catalog.types.RowMultiSetImpl;" ], "header": "@@ -26,6 +26,8 @@ import java.util...
derby-DERBY-651-b8c61104
DERBY-651: Wire UDT dependency dropping logic into DROP TABLE. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@889822 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/DDLConstantAction.java", "hunks": [ { "added": [ " DataDictionary dd,", " TableDescriptor td,", " ColumnInfo[] columnInfos,", " ...
derby-DERBY-651-d039cedd
DERBY-651: Add ability to declare UDT columns, parameters, and return values. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@884970 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/catalog/types/BaseTypeIdImpl.java", "hunks": [ { "added": [ " // schema where the type lives. only for UDTs", " private String schemaName;", "", " // unqualified type name", " String unqualifi...
derby-DERBY-651-d6c20471
DERBY-651: Add dependencies of views on UDTs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@889876 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-651-e126f586
DERBY-651: Add dependency tracking between tables and UDTs. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@888811 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/sql/dictionary/TableDescriptor.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.reference.SQLState;", "import org.apache.derby.iapi.sql.conn.LanguageConnectionContext;", "import org.apache.derby.iapi.sql.dep...
derby-DERBY-651-e5114fdd
DERBY-651: Add test to verify that Derby still does not support SQLData types. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@907668 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-651-fa292b99
DERBY-651: Add CREATE/DROP TYPE. This initial increment does not allow you to create table columns or parameters whose types are used-defined. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@882569 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/catalog/AliasInfo.java", "hunks": [ { "added": [ "\tpublic static final char ALIAS_TYPE_UDT_AS_CHAR\t\t= 'A';", "\tpublic static final String ALIAS_TYPE_UDT_AS_STRING\t\t= \"A\";" ], "header": "@@ -39,10 +39,12 @@ publ...
derby-DERBY-6511-8c39c1c3
DERBY-6511: Convert primitives to wrapper types as appropriate when chaining functions; tests passed cleanly on derby-6511-01-aa-fixPrimitiveToWrapper.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1578479 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/JSQLType.java", "hunks": [ { "added": [ "\tpublic\tstatic String\tgetWrapperClassName" ], "header": "@@ -327,7 +327,7 @@ public final class JSQLType implements Formatable", "removed": [ "\tprivate\ts...
derby-DERBY-6516-78227e48
DERBY-6516 Convert lang/nestedCommit.sql to JUnit NestedCommitTest Patch derby-6516-gc to fix the intermittent error we saw on this issue. The patch makes sure we close the result set for the statement 'values doConnCommitInt()' when executed inside a stored procedure. Previously, it was executed by the stored procedure "doConnStmtIntNoRS". We changed that to "doConnStmtInt" since this statement does indeed have a result set. The supporting procedure in Triggers#doConnStmt also had to be fixed a bit, since this particular result set closes itself by performing a commit inside the store procedure, which led the second ResultSet#next to throw XLC16. With the patch, I do not see the original error even when disabling the explicit garbage collection (Java option -XX:+DisableExplicitGC). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1584638 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/functionTests/util/Triggers.java", "hunks": [ { "added": [ " private static final String RESULT_SET_NOT_OPEN = \"XCL16\";", "", " private Triggers()" ], "header": "@@ -21,17 +21,16 @@", ...
derby-DERBY-6518-c40b7edf
DERBY-6518: JVMInfo should not use parseFloat() to parse java.specification.version Change the parse logic so that it recognizes that version 1.10 is greater than 1.9. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1581777 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/info/JVMInfo.java", "hunks": [ { "added": [ " // Extract major and minor version out of the spec version.", " String[] ver = javaVersion.split(\"[.]\");", " int majo...
derby-DERBY-6520-8a59583b
DERBY-6520 Convert lang/triggerGeneral.sql to JUnit TriggerGeneralTest Patch derby-6520-3. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1579768 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/functionTests/util/Triggers.java", "hunks": [ { "added": [], "header": "@@ -35,19 +35,6 @@ public class Triggers", "removed": [ "\tpublic static String triggerFiresMinimal(String string) throws Throwable", "\t{...
derby-DERBY-6521-1fa09cea
DERBY-6521: Improve error handling when restricting file permissions git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1589396 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/services/io/FileUtil.java", "hunks": [ { "added": [], "header": "@@ -36,7 +36,6 @@ import java.net.URL;", "removed": [ "import org.apache.derby.shared.common.sanity.SanityManager;" ] }, { "added"...
derby-DERBY-6529-a24468bd
DERBY-6529 nightly regression test failure in newly added junit test TriggerGeneralTest Patch to make the test work also on Windows (CR LF issue). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1583343 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6533-0c997ed8
DERBY-6533: Plug another NPE in NsTest; commit derby-6533-aa-anotherNPE.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1588289 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/tester/TesterObject.java", "hunks": [ { "added": [ " /** Get a new connection and raise an error if this can't be done */", " public Connection getNewConnection()", " {", " C...
derby-DERBY-6533-2c381e05
DERBY-6533: Sort NsTest errors by the timestamp of their first occurrence; commit derby-6533-08-aa-sortErrors.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1589747 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/NsTestError.java", "hunks": [ { "added": [ "public class NsTestError implements Comparable<NsTestError>" ], "header": "@@ -26,7 +26,7 @@ package org.apache.derbyTesting.system.nstest;", "removed"...
derby-DERBY-6533-5a56bccd
DERBY-6533: Add more defensive code to NsTest; commit derby-6533-05-aa-dieQuickly.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1587581 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/tester/Tester1.java", "hunks": [ { "added": [ "", " // if you can't change the autocommit state, the connection is unusable.", " // get out of here.", " return...
derby-DERBY-6533-5ccbc167
DERBY-6533: Add more defensive code to NsTest; commit derby-6533-07-aa-moreDefensiveCode.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1589404 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/NsTestError.java", "hunks": [ { "added": [ " private long _firstOccurrenceTime;", " private long _lastOccurrenceTime;" ], "header": "@@ -42,6 +42,8 @@ public class N...
derby-DERBY-6533-777a463e
DERBY-6533: Add a knob to NsTest, allowing you to set a time limit for the test run; commit derby-6533-03-timerThread.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1584636 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/TimerThread.java", "hunks": [ { "added": [ "/*", "", " Derby - Class org.apache.derbyTesting.system.nstest.TimerThread", "", " Licensed to the Apache Software Foundation (ASF) under ...
derby-DERBY-6533-b13fb1c7
DERBY-6533: Add a sequence generator to NsTest along with start and end timestamps; commit derby-6533-02-aa-sequencesAndMoreStats.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1583749 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/init/DbSetup.java", "hunks": [ { "added": [ "\t\t\t\t\t\t+ \"sequenceColumn bigint, \"" ], "header": "@@ -86,6 +86,7 @@ public class DbSetup {", "removed": [] }, { "added": [ ...
derby-DERBY-6533-e225bfbf
DERBY-6533: Give NsTest more defenses against OutOfMemoryErrors; commit derby-6533-04-outOfMemory.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1586366 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/system/nstest/utils/MemCheck.java", "hunks": [ { "added": [ " long totalMemory = rt.totalMemory();", " long freeMemory = rt.freeMemory();", " NsTest.updateMemoryTracker( totalMemory, freeMe...
derby-DERBY-6534-8ae4e158
DERBY-6534: Remove StorageFile.getURL() and its implementations git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1583578 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/io/DirFile.java", "hunks": [ { "added": [], "header": "@@ -34,8 +34,6 @@ import java.io.FileInputStream;", "removed": [ "import java.net.MalformedURLException;", "import java.net.URL;" ] } ] },...
derby-DERBY-6535-ccbbcd4b
DERBY-6535: Remove storageFactory field from subclasses of InputStreamFile git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1583650 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/io/InputStreamFile.java", "hunks": [ { "added": [ " * @param <F> the storage factory class used by the subsubprotocol", "abstract class InputStreamFile<F extends BaseStorageFactory>", " implements StorageFile", ...
derby-DERBY-6540-d8804a85
DERBY-6540: Schema-qualified table names could be mistaken for transition tables Don't treat schema-qualified table names as transition tables, as transition table names are always unqualified. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1586226 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java", "hunks": [ { "added": [ " if (!isTransitionVariable(", " tableName, oldReferencingName, newReferencingName))" ], "header": "@@ -4879,9 +4...
derby-DERBY-6542-7fd0c6ef
DERBY-6542: Add catalog support for using sequence generators to implement identity columns; commit derby-6542-01-ab-catalog.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1589379 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/DataTypeDescriptor.java", "hunks": [ { "added": [ "", " public static final int MIN_VALUE_IDX = 0;", " public static final int MAX_VALUE_IDX = MIN_VALUE_IDX + 1;", " public static fina...
derby-DERBY-6542-8612b0bf
DERBY-6542: Raise LockTimeout when there is too much contention on an identity column; commit derby-6542-03-aa-lockTimeoutForIdentityContention.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1596619 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/SequenceUpdater.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.sql.dictionary.SchemaDescriptor;" ], "header": "@@ -37,6 +37,7 @@ import org.apache.derby.iapi.services.property.PropertyUtil;", ...
derby-DERBY-6543-7b9e6859
DERBY-6543: Syntax error when reference to transition variable has whitespace around it git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1589036 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java", "hunks": [ { "added": [], "header": "@@ -4976,14 +4976,12 @@ public final class\tDataDictionaryImpl", "removed": [ "\t\t\tint tokEndOffset = tableName.getEndOffset();", "\t\t\...
derby-DERBY-6544-435459ec
DERBY-6544: Run locale-sensitive Lucene tests in single-use databases; commit derby-6544-01-aa-singleUseDatabases.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1588933 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java", "hunks": [ { "added": [ " {", " return sqlAuthorizationDecoratorSingleUse( test, DEFAULT_DBNAME_SQL, true );", " }", " ", " /**", " ...
derby-DERBY-6546-689206ce
DERBY-6546: Database can't be dropped on Windows using the decoration of LuceneSupportPermsTest Move database shutdown from the tearDown() method of the test case to DropDatabaseTestSuite so that no intermediate decorators reboot the database before it is dropped. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1589624 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/DropDatabaseSetup.java", "hunks": [ { "added": [ " private final String logicalDBName;", " private final boolean shutdownBeforeDrop;", "", " this(test, logicalDBName, true);", "...
derby-DERBY-655-e1d51e30
DERBY-655: Generate unique logical conglomerateId for duplicate indexes, instead of just reusing existing conglomerateId. Submitted by Mamta A. Satoor(msatoor@gmail.com) git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@411399 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6550-0806f736
DERBY-6550: Bulk-insert causes identity columns to cycle when they shouldn't This change was contributed by Danoja Dias (danojadias at gmail dot com) Adds a new test case to verify that a bigint identity column correctly refuses to cycle when the identity value reaches the maximum value. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1747486 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6552-7863d831
DERBY-6552 The public api includes methods inherited from superclasses which aren't in the public api and so have no javadoc comments Patch derby-6552-restructure-more: - adds wrappers so that the exposed classes have the expected methods and constants. - changes the doc build for publishedapi so that we have a "sourcepath" for Javadoc which contains all the sources. This is necessary to make the wrappers inherit the (common for Basic* and regular data sources) javadoc from a class that is otherwise not in the API. - added reference "link"s to official Java Javadocs for ease of reading (SE: 8, J2EE: 7) - removed ClientBaseDataSourceRoot putting its contents into BasicClientDataSource40 - removed ClientBaseDataSource moving its contents into ClientDataSource - added new serialized data source tests for 10.11 git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1603019 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/client/ClientPooledConnection.java", "hunks": [ { "added": [ "import org.apache.derby.jdbc.BasicClientDataSource40;" ], "header": "@@ -39,7 +39,7 @@ import org.apache.derby.client.am.SqlException;", "removed": [ ...
derby-DERBY-6552-a0866201
DERBY-6552 The public api includes methods inherited from superclasses which aren't in the public api and so have no javadoc comments Follow-up patch derby-6552-restructure-even-more. This restructures the embedded hierarchy to avoid duplication also. It eliminates EmbeddedBaseDataSource. Removed a slew of warnings in the IDE also by some code washing, and regenerated the 10.11 serialized data sources for the SerializedDataSourceTest. I removed some Javadoc from non-public members in the API classes, and replaced them with end-of-line comments instead (to avoid user confusion). git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1603022 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/jdbc/BasicEmbeddedConnectionPoolDataSource40.java", "hunks": [ { "added": [ " * This data source is suitable for an application using embedded Derby," ], "header": "@@ -24,7 +24,7 @@ import java.sql.SQLException;", "remo...
derby-DERBY-6552-b004dff2
DERBY-6552 The public api includes methods inherited from superclasses which aren't in the public api and so have no javadoc comments Patch derby-6552-only-public-members. Changes the way we generate public API javadocs by restricting it to public class members. Adds back Javadocs for private, class private and protected members removed before. Added some missing Javadocs. Moved the top level class javadocs that were nto visible (root classes) down to the first level visible data sources, so we can get the data source properties documented for embedded. Added this for client. Cf. BasicEmbeddedDataSource40 and BasicClientDataSource40 respectively. Added missing @serial tags git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1603549 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/client/org/apache/derby/jdbc/BasicClientDataSource40.java", "hunks": [ { "added": [ " * <p/>", " * * The standard attributes provided are, cf. e.g. table", " * 9.1 in the JDBC 4.2 specification.", " * <ul>", " * <li>databaseN...
derby-DERBY-6553-c077ea00
DERBY-6553: Adding test cases to verify that we can create trigger-invoking sequences: commit derby-6553-01-aa-verifyFix.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1595977 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6554-7953b49b
DERBY-6554: Fix some bugs in cache management for sequence generators; commit derby-6554-01-ad-bugfixes.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1591703 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/catalog/SequenceUpdater.java", "hunks": [ { "added": [ "import java.util.HashMap;", "" ], "header": "@@ -20,6 +20,8 @@", "removed": [] }, { "added": [ " //", ...
derby-DERBY-6554-9819cf8e
DERBY-6554: Raise SelfDeadlock when a nested subtransaction can't immediately get a lock because it is blocked by its parent transaction; commit derby-6554-02-ae-selfDeadlock_sps_compress.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1593702 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/store/raw/RawStoreFactory.java", "hunks": [ { "added": [ " @param parentTransaction parent transaction" ], "header": "@@ -660,6 +660,7 @@ public interface RawStoreFactory extends Corruptable {", "removed": []...
derby-DERBY-6559-9179199d
DERBY-6559 A immediate Fk constraint blows up iff its referenced PK is deferred and we delete a duplicate Patch derby-6559 changes ReferencedKeyRIChecker to omit checking dependent tables iff the referenced key is deferred and has rows with duplicate keys one of whom is attempted deleted. So, in effect, the check in such a case happens only if the row is "the last of its kind", i.e. the last row having a particular referenced key. Added tests for this behavior. To determine whether we have duplicates, we open an extra scan on the index. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1593557 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/DMLModStatementNode.java", "hunks": [ { "added": [], "header": "@@ -33,7 +33,6 @@ import org.apache.derby.iapi.services.classfile.VMOpcode;", "removed": [ "import org.apache.derby.shared.common.sanity.SanityMana...
derby-DERBY-656-381dfaf5
DERBY-656 Use the size estimates from the catalog to avoid security issues in BackingStoreHashtable. This matches the other uses of the class size utilities, eg. for the DataValueDescriptors. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@330133 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java", "hunks": [ { "added": [ " /**", " * The estimated number of bytes used by Vector(0)", " */ ", " private final static int vectorSize = ClassSize.estimate...
derby-DERBY-6563-f2735816
DERBY-6563: NOT elimination for CASE expressions is broken git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1592945 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6565-591ff9f9
DERBY-6565 ROW_NUMBER function throws NullPointerException in UPDATE statement Patch *derby-6565-forbid.diff* which makes it illegal to use window functions in the update source. Adds a new test for this error condition. Also cleans up some Javadocs and modernizes some loops. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1615982 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/compile/UpdateNode.java", "hunks": [ { "added": [], "header": "@@ -35,13 +35,11 @@ import org.apache.derby.iapi.services.classfile.VMOpcode;", "removed": [ "import org.apache.derby.shared.common.sanity.SanityManager;", ...
derby-DERBY-6567-d6b5ab35
DERBY-6567: Incorrect nullability for CASE expression with parameter Make sure the result of a CASE expression is nullable if (and only if) at least one of the result expressions is nullable. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1593495 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6569-1f1b46b1
DERBY-6569: NULLIF may return incorrect results if first operand calls non-deterministic function Make sure the left operand of the NULLIF expression is only evaluated once, so that it does not matter if it is non-deterministic. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1625520 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6576-72446ed8
DERBY-6576 A immediate Fk constraint blows up iff its referenced PK is deferred and we modify a duplicate key column A follow-up patch, derby-6576-repeatable-read. In the case where we do not throw an exception because the deferred unique/pk constraint referenced by an fk is upheld by another row, we need to make sure that condition holds until we commit. This patch changes the check (in ReferencedKeyRIChecker#isDuplicated) to scan using repeatable read isolation level instead of read committed. This will set a read lock on any (well, the first we find) duplicate row till transaction end and thus ensure things are good till we commit. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1600779 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/sql/execute/ReferencedKeyRIChecker.java", "hunks": [ { "added": [ "", " // Use repeatable read here, since we rely on the row being", " // present till we commit if we accept this r...
derby-DERBY-6577-39e20ff2
DERBY-6577: Quantified comparison returns wrong result in CASE, COALESCE, IN and BETWEEN ValueNodeList.preprocess() should update the list with the rewritten expressions. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1594816 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-658-1edcdb31
DERBY-658: Improve the test harness' ability to run on platforms with non-ASCII native encoding. Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394770 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/iapi/tools/i18n/LocalizedResource.java", "hunks": [ { "added": [ "" ], "header": "@@ -212,6 +212,7 @@ public final class LocalizedResource implements java.security.PrivilegedAction", "removed": [] } ] }, { ...
derby-DERBY-658-93e65c71
DERBY-658: Update README.htm for testing, fix TestProto and multi tests to run on non-ASCII systems. Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com> git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395486 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/impl/drda/TestProto.java", "hunks": [ { "added": [ "import java.io.BufferedReader;", "import java.io.FileInputStream;", "import java.io.FileNotFoundException;", "import java.io.InputStreamReader;", "import ...
derby-DERBY-6587-7d2377d6
DERBY-6587; Foreign Key constraint not matched when using UUID in a composite foreign key when using SYSCS_UTIL.SYSCS_IMPORT_TABLE Adding a test for this issue git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1600788 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6590-844595b2
DERBY-6590 Make JUnit tests run the fixtures in a deterministic order. Javadoc fix. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1608810 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/BaseTestSuite.java", "hunks": [ { "added": [ " * Derby replacement for {@code junit.framework.TestSuite}. This version, when", " * provided with a {@code Class} argument in a constructor or method,", " * constr...
derby-DERBY-6596-4f7c1430
DERBY-6596: Forbid null args to lucene support routines; derby-6596-01-aa-checkNotNull.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1601465 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/optional/org/apache/derby/optional/lucene/LuceneSupport.java", "hunks": [ { "added": [ " vetIdentifiers( schema, table, textcol );", "" ], "header": "@@ -367,6 +367,8 @@ public class LuceneSupport implements OptionalTool", "rem...
derby-DERBY-6600-515a63e8
DERBY-6600: Make it possible to bind functions to methods in the org.apache.derby.optional.api package; tests passed cleanly on derby-6600-02-aa-addAPIpackage.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1600928 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6600-a4094369
DERBY-6600: Make Derby resolve custom Lucene Analyzers and QueryParsers by using the database classpath. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1600866 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/optional/org/apache/derby/optional/lucene/LuceneQueryVTI.java", "hunks": [ { "added": [ "import org.apache.derby.iapi.services.loader.ClassInspector;" ], "header": "@@ -34,6 +34,7 @@ import java.sql.Time;", "removed": [] }, { ...
derby-DERBY-6602-abb2084e
DERBY-6602: Make the lucene plugin handle null keys; commit derby-6602-01-aa-handleNullKeys.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1601440 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/optional/org/apache/derby/optional/lucene/LuceneQueryVTI.java", "hunks": [ { "added": [ "", " // true if last column read was null", " private boolean _wasNull;" ], "header": "@@ -102,6 +102,9 @@ public class LuceneQueryVTI ex...
derby-DERBY-6611-11da6184
DERBY-6611 Broken link in API docs to derby.drda.keepAlive documentation Javadoc fixup for this issue: Use textual cross reference instead. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1607135 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/drda/org/apache/derby/mbeans/drda/NetworkServerMBean.java", "hunks": [ { "added": [ " * Reports whether or not the Derby Network Server will send keep-alive ", " * value of the {@code derby.drda.keepAlive} property).</p>", " * If {@code...
derby-DERBY-6615-6a920060
DERBY-6615: Remove unused newInstance() method in BaseMonitor git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1603099 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java", "hunks": [ { "added": [], "header": "@@ -772,31 +772,6 @@ abstract class BaseMonitor", "removed": [ "\t/**", "\t*/", "\tprivate Object newInstance(String className) {"...
derby-DERBY-6617-5e5e3c36
DERBY-6617: Make MissingPermissionsTest run cleanly on IBM The error message of the AccessControlException on IBM is the string "Access denied" (with capital A), whereas the expected message was "access denied" (lowercase a). Adjust the regular expressions used to check the messages so that they accept both. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1611546 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6617-84e1fb36
DERBY-6617: Make MissingPermissionsTest look for different error text on Java 6; commit derby-6617-04-aa-platformSpecificErrorText.diff. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1610406 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6617-ec4eb072
DERBY-6617: Fix setting of permissions in MissingPermissionTest - When forking a new JVM, pass on the properties that tell where various jar files are located. - The specialized policy files for the test should include permissions required when running the test from Ant. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1610374 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6617-f6df1849
DERBY-6617: Stabilize MissingPermissionsTest Make sure the ij process is shut down cleanly to make the exit code stable. Use a regular expression to check for messages in the test output. The regular expression accepts both double-quoted and unquoted names, and any directory separator, to account for platform differences. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1610662 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6619-493b80e2
DERBY-6619 After silently swallowing SecurityExceptions, Derby can leak class loaders Patch derby-6619-2. The fix introduced in DERBY-3745 correctly is there in order to protect against the case where the thread that starts Derby, has a context class loader that is different from the system class loader. In such cases, if the timer thread inherits the context class loader, the context class loader will stay in memory until the Derby engine is shut down, even if all other references to the class loader are gone. If the context class loader is the same as the system class loader, on the other hand, such a "leak" would not be a problem, since the system class loader will stay in memory until the JVM is shut down anyway. We take advantage of this and only attempt to change the context class loader if it is different from the system class loader. With this patch, no warning is printed to derby.log when starting the server from the command line, and there's no warning when starting the server using the API with a security manager installed when the context class loader hasn't been changed from the default. However, if the server is started using the API with a non-default context class loader, we do see warnings in derby.log if a security manager is installed and the permission to set the class loader is missing. Added tests for this behavior. Moved utility methods from UpgradeClassLoader to ClassLoaderTestSetup, a new decorator. It seemed more logical to put them there to allow reuse. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1620379 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/testing/org/apache/derbyTesting/junit/ClassLoaderTestSetup.java", "hunks": [ { "added": [ "/*", " * Derby - Class org.apache.derbyTesting.junit.ClassLoaderTestSetup", " *", " * Licensed to the Apache Software Foundation (ASF) under one or...
derby-DERBY-6619-7f532129
DERBY-6619 After silently swallowing SecurityExceptions, Derby can leak class loaders Patch derby-6619 which prints warnings on derby.log if permissions are missing to get and set the context class loader in SingletonTimerFactory (which can lead to classloader leak). Also adds a test of this by checking derby.log in SecureServerTest. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1618955 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java", "hunks": [ { "added": [ "import java.io.IOException;", "import java.io.InputStream;", "import java.io.InputStreamReader;", "import java.io.PrintWriter;", "import j...
derby-DERBY-6619-921e39ea
DERBY-6619 After silently swallowing SecurityExceptions, Derby can leak class loaders Patch derby-6619-2-refinement which implements the following refinements to the test to avoid changing the context class loader in SingletonTimerFactory (suggested by Knut): The orginal test tested against the system class loader. This new patch will: 1) Check if the context class loader is the same as the loader of the SingletonTimerFactory class (that is, the class loader from which Derby classes are loaded). Even if this isn't the same as the system class loader, it would be safe to skip the workaround for DERBY-3745, since the class loader for the Derby classes would not be eligible for garbage collection until the engine is shut down anyway. This would prevent some more false positives from being reported in derby.log. I'd assume this is a kind of false positive that could easily occur in an application server environment where the Derby classes are not found on the system class loader. 2) Check against Thread.class.getClassLoader() instead of ClassLoader.getSystemClassLoader(). Normally, those two checks would be identical. If however the setup is such that they aren't identical, we'd still know that the class loader actually used for system classes such as the Thread class would have to stay in memory for as long as the timer thread is alive, regardless of the context class loader of the thread, so the workaround for DERBY-3745 can be skipped if it's the same as the context class loader. The check will be a bit more specific this way. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1620385 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/timer/SingletonTimerFactory.java", "hunks": [ { "added": [ " if (cl == getClass().getClassLoader() ||", " cl == Thread.class.getClassLoader()) {", " ...
derby-DERBY-6619-c0f956b4
DERBY-6619: Improve comments git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1620539 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/timer/SingletonTimerFactory.java", "hunks": [ { "added": [ " * Check if the current context class loader could cause a memory leak", " * (DERBY-3745) if it is inherited by the timer thread, and return it if", ...
derby-DERBY-662-8fa60644
Fix for DERBY-662. The change is an obvious fix to BaseDataFileFactory.java code which creates a conglomerates container file name given it's conglomerate number. This is a simple hex conversion which was missing from one of the paths through the code. The path is almost never taken, but in the following circumstance during redo crasch recovery this bug could cause derby to delete the underlying file of a table. The circumstances are as follows: 1) The OS/filesystem must be case insensitive such that a request to delete a file named C2080.dat would also remove c2080.dat. This is true in windows default file systems, not true in unix/linux filesystems that I am aware of. 2) The system must be shutdown not in a clean manner, such that a subsequent access of the database causes a REDO recovery action of a drop table statement. This means that a drop table statement must have happened since the last checkpoint in the log file. Examples of things that cause checkpoints are: o clean shutdown from ij using the "exit" command o clean shutdown of database using the "shutdown=true" url o calling the checkpoint system procedure o generating enough log activity to cause a regularly scheduled checkpoint. 3) If the conglomerate number of the above described drop table is TABLE_1, then for a problem to occur there must also exist in the database a table such that it's HEX(TABLE_2) = TABLE_1 4) Either TABLE_2 must not be accessed during REDO prior to the REDO operation of the drop of TABLE_1 or there must be enough other table references during the REDO phase to push the caching of of the open of TABLE_2 out of cache. The fix adds a test case which before the fix will force a container not found error on an existing table. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@329494 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6624-1ffa77b9
DERBY-6624: Use javax.xml.xpath interfaces for XPath support Stop using the interfaces in the org.w3c.dom.xpath package, since they are not part of the Java SE specification. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1604758 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java", "hunks": [ { "added": [ "import java.util.Iterator;", "import org.w3c.dom.NodeList;", "import javax.xml.XMLConstants;", "", "import javax.xml.namespace.NamespaceContext;", ...
derby-DERBY-6626-0196a8f1
DERBY-6626: Check type of user-supplied modules before creating instances Check explicitly that a custom tool implements the OptionalTool interface. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1609099 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/catalog/Java5SystemProcedures.java", "hunks": [ { "added": [], "header": "@@ -23,7 +23,6 @@ package org.apache.derby.catalog;", "removed": [ "import org.apache.derby.iapi.sql.conn.ConnectionUtil;" ] }, { ...
derby-DERBY-6626-59f29e43
DERBY-6626: Check type of user-supplied modules before creating instances Make SequenceUpdater verify that the class specified by the derby.language.sequence.preallocator property is a SequencePreallocator before attempting to create an instance of it. Make dblook and ij verify that user-specified JDBC driver class names and DataSource class names implement the correct interfaces before attempting to create and use them. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1607795 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/tools/org/apache/derby/impl/tools/ij/util.java", "hunks": [ { "added": [ "import java.sql.Driver;" ], "header": "@@ -33,6 +33,7 @@ import java.lang.reflect.InvocationTargetException;", "removed": [] }, { "added": [ ...
derby-DERBY-6626-9b8c04f9
DERBY-6626: Check type of user-supplied modules before creating instances Check that the encryptionProvider connection attribute specifies an implementation of java.security.Provider before trying to create an instance of it. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1607266 13f79535-47bb-0310-9956-ffa450edef68
[ { "file": "java/engine/org/apache/derby/impl/services/jce/JCECipherFactory.java", "hunks": [ { "added": [ "import java.security.AccessController;", "import java.security.PrivilegedAction;", "import java.security.PrivilegedExceptionAction;" ], "head...
derby-DERBY-6628-0bfd4d7c
DERBY-6628 Intermittent error in TriggerGeneralTest Patch derby-6628-more-diagnostics: a diagnostics patch that will dump the entire lock table in if we see the unexpected set of locks seen in this issue. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1606723 13f79535-47bb-0310-9956-ffa450edef68
[]
derby-DERBY-6628-5bfb3389
DERBY-6628 Intermittent error in TriggerGeneralTest Patch derby-6628-2. We decided, instead of filering the unexpected system table locks, to retry the assert for the lock result set for a while to rule out slow, lingering (re)compilation locks (by the index statistics daemon?). If the locks of the system tables hang around for a minute (max waiting time), something fishy is going on. We'll run with this for a while, and if we don't see this issue again, close the issue. git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1621223 13f79535-47bb-0310-9956-ffa450edef68
[]