id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-756-59b3eae1 | DERBY-756: Close scan controller in DistinctScalarAggregateResultSet to avoid memory leak.
Submitted by Manish Khettry (manish_khettry@yahoo.com)
Here is more info from the contributor:
It looks like the scan controller created in DistinctScalarAggregateResultSet is never closed. This causes the scanController instance variable in RAMTransaction to continue to grow with each open/close.
Shouldn't DistinctScalarAggregateRS implement a close or a finish method (not sure what the difference is) and close the scan controller there.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370978 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/DistinctScalarAggregateResultSet.java",
"hunks": [
{
"added": [],
"header": "@@ -20,17 +20,8 @@",
"removed": [
"import org.apache.derby.iapi.services.monitor.Monitor;",
"",
"import org.apache... |
derby-DERBY-757-62721e65 | DERBY-757
Now that this routine can be called while concurrently with XA transactions
being created and committed, checks have to be made to make sure the object
being searched for does not go null while we are looking at it. The search
is for existing xacts, so skipping when we find a null is fine.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370967 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/xact/TransactionTable.java",
"hunks": [
{
"added": [
" * This routine use to be only called during offline recovery so performance",
" * was not critical. Since that time more calls have been made, including",
... |
derby-DERBY-774-dd5a8720 | DERBY-774 DRDAConnThread::doneData should use statically allocated SQLException objects. Submitted by Dyre.Tjeldvoll@Sun.COM
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@358560 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" ",
" // The use of static exception objects is normally a bad idea,",
" // but qryscraft_ and notQryscraft_ are not true exceptions and",
" // wil... |
derby-DERBY-777-18c4da72 | DERBY-777 Remove use of java.io.InputStreamReader.getEncoding to get the
platform's default encoding. Creating this reader on System.in was causing
a hang on Z/OS.
Now simply use the stream/reader constructors that do not take a encoding
argument and thus use the default. With this Derby does not need to know
the actual value of default encoding.
Merge of 358137 from 10.1
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@359833 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/load/ControlInfo.java",
"hunks": [
{
"added": [],
"header": "@@ -118,10 +118,6 @@ class ControlInfo",
"removed": [
" // set the default code set to the platform default encoding value",
" String default_data... |
derby-DERBY-781-0be2d6ec | DERBY-781: Materialize select subqueries where possible to avoid recreating their resultsets multiple times. Here is more info from the contributor.
Attaching a patch (d781_v1.patch) to address this issue by allowing the optimizer to consider and choose hash joins with subqueries, which is a more general case of the specific union example mentioned in the description for this issue. In brief, the patch does this by following up on the suggestions given by Jeff Lichtman in comments above and also in the following thread:
http://article.gmane.org/gmane.comp.apache.db.derby.devel/12208
Since result set materialization comes for "free" with hash joins, that fact we now allow hash joins with subqueries (as of this patch) means that we implicitly have a way to materialize the subquery result sets.
The details of the patch are included as DERBY-781_v1.html. I added a simple test to lang/subquery.sql to demonstrate that the optimizer can and will choose to do hash joins for subqueries, and I updated one other master file--predicatesIntoViews--for which the optimizer is now choosing a hash join instead of a nested loop. Testing of "unsafe" hash joins (see section VII of the document) and generation of correct plans is done through existing tests, esp. the lang/lojreorder.sql test, which was very useful in helping to verify the correctness of the changes.
Note that I did not add the sample union query shown in the description for this issue to the tests because when I run it against the current codeline, the optimizer will already choose to do materialization of the UnionNode (via hash join) even without the patch for this issue, and thus it didn't seem like that particular test case was useful. The new test in subqery.sql is more relevant because the optimizer will choose to do a nested loop join with the subquery before my changes and will do a hash join after my changes, which seems to more accurately reflect what this issue is about.
I ran derbyall using sane jars on Red Hat Linux with ibm142 and saw no new failures, and the overall execution time does not change despite the extra work the optimizer is doing.
Submitted by Army Brown (qozinx@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@423989 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryRelationalOperatorNode.java",
"hunks": [
{
"added": [
"\t// Visitor for finding base tables beneath optimizables and column",
"\t// references. Created once and re-used thereafter.",
"\tprivate BaseTa... |
derby-DERBY-783-6a5edfc0 | DERBY-783: Enhance ALTER TABLE to support RESTART option to enable setting of identity column start value.
Submitted by Mamta Satoor (msatoor@gmail.com)
Here is more info from the contributor:
I have attached a review package for this feature to the JIRA entry. Following is a brief description of the changes involved.
Changed sqlgrammar.jj to add parser support for ALTER TABLE <tablename> ALTER <columnName> RESTART WITH integer-constant
Also, added another element to the array which keeps track of autoincrement information in the parser. This 4th element will record if the autoincrement column is getting added or it is getting altered for INCREMENT BY value change or it is getting altered for RESTART WITH value change. This information is required later in the compile and execute phase.
In the compile phase, this information is used to see if a user is trying to sneak in a value of 0 for INCREMENT BY. A value of 0 for INCREMENT BY should be caught at the time of autoincrement column add or at the time of autoincrement column alter to change the INCREMENT BY value. At the time of autoincrement column alter to change the RESTART WITH value, the INCREMENT BY value should not be checked. This is done in ColumnDefinitionNode.java. TableElementList generates ColumnInfo which needs to keep track of autoincrement column change status from ColumnDefinitionNode. This infromation in ColumnInfo will be used at execute time.
In the execute phase, we need to know which columns of SYSCOLUMNS table need to be changed for an ALTER TABLE command on the autoincrement column. In the past, we only allowed to change the INCREMENT BY criteria of an autoincrement column but with this feature, it is possible for a user to change the start with value of autoincrement column and leave the INCREMENT BY unchanged. This autoincrement column change information is passed to the execute phase via ColumnInfo.
In order to provide this distinction between ALTER BY..INCREMENT BY.. and ALTER BY..RESTART WITH.., I have had to add a variable in ColumnDefinitionNode.java, ColumnInfo.java and ColumnDescriptor.java. The value of the variable in each of these classes depend on what parser recorded for the autoincrement column status ie adding an autoincrement column/changing INCREMENT BY of the autoincrement column/changing RESTART WITH of the autoincrement column.
Hope this information along with the comments in the code will help in the code review. Please let me know if you have any comments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370885 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ColumnDescriptor.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.sql.compile.ColumnDefinitionNode;",
""
],
"header": "@@ -30,6 +30,8 @@ import org.apache.derby.iapi.sql.StatementType;",... |
derby-DERBY-790-b2c17727 | DERBY-790: SQLException used by the networked interface to Derby is not serializable
Patch contributed by Francois Orsini.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@504630 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/SqlException.java",
"hunks": [
{
"added": [
" protected transient Sqlca sqlca_ = null; // for engine generated errors only",
" protected String cachedMessage_ = null;"
],
"header": "@@ -74,8 +74,9 @@ im... |
derby-DERBY-791-9d08b6af | DERBY-791: Make InsertNode visitors process the target column list.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@835417 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/DMLModStatementNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.compile.Visitable;",
"import org.apache.derby.iapi.sql.compile.Visitor;"
],
"header": "@@ -42,6 +42,8 @@ import org.... |
derby-DERBY-797-bc508402 | DERBY-918: Introduce new "junit" test type
DERBY-934: Create a set of JUnit tests for scrollable updatable cursors. I
also added these tests to the jdbcapi and derbynetclientmats suites (except
for ConcurrencyTest, which takes too long to run currently)
DERBY-797: After calling ResultSet.relative(0) the cursor loses its position
These are all submitted together because of interdependencies.
All contributed by Andreas Kornelliusen
NOTE: This may cause test failures on the IBM JDK; I did not test it with
this JDK, nor did I exclude these tests from running on this JDK, as I
couldn't say whether they work or not (I don't have the IBM JDK).
I did exclude running these tests on DerbyNet, because they have a hard
failure saying "null user not supported."
Ran these tests on JDK 1.4, JDK 1.3, with both embedded and network
client drivers. Note that the SURTest.out has failures; this is because
(a) the scrollable updatable result set work is not yet finished and
(b) there are differences between network client and embedded client which
need to be resolved.
--------
DERBY-797 files:
M java/engine/org/apache/derby/impl/sql/execute/ScrollInsensitiveResultSet.java
DERBY-918 files:
M java/testing/org/apache/derbyTesting/functionTests/util/TestUtil.java
M java/testing/org/apache/derbyTesting/functionTests/harness/testtypes.properties
M java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java
DERBY-934 files:
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ConcurrencyTest_app.properties
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURBaseTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURQueryMixTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURQueryMixTest_app.properties
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ConcurrencyTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURDataModelSetup.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURTest_app.properties
A java/testing/org/apache/derbyTesting/functionTests/master/SURTest.out
A java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/SURTest.out
M java/testing/org/apache/derbyTesting/functionTests/suites/jdbcapi.runall
M java/testing/org/apache/derbyTesting/functionTests/suites/derbynetclientmats.runall
M java/testing/org/apache/derbyTesting/functionTests/suites/DerbyNet.exclude
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@378045 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestUtil.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;",
"import java.security.PrivilegedExceptionAction;",
"import java... |
derby-DERBY-8-f578f070 | Fix for
DERBY-8
Connection object gets created with un-supported holdability on getting Connection object from XAConnection "inside" the global transaction
DERBY-366
In jdk13, when a connection transitions from global transaction to local transaction, its default holdability of HOLD_CURSORS_OVER_COMMIT is not restored.
have a patch to fix Derby-8 (Connection object gets created with un-supported holdability on getting Connection object from XAConnection "inside" the global transaction) and Derby-366 (In jdk13, when a connection transitions from global transaction to local transaction, its default holdability of HOLD_CURSORS_OVER_COMMIT is not restored.) The patch is attached to both Derby-8 and Derby-366.
The fix for both these bugs was centered around fixing the holdability handling in BrokeredConnection.java This was because BrokeredConnection.java had no code for restoring the holdability of real connection object and no code for saving the current holdability state of real connection object. I put fix for both these issues in BrokeredConnection.java so that both jdk13 and jdk14+ environments will be handled correctly. Had to use reflection for this holdability work
because Connection.setHoldability and Connection.getHoldability methods are not available through JDK13 apis.
Contributed by Mamta Satoor
git-svn-id: https://svn.apache.org/repos/asf/incubator/derby/code/trunk@191755 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/jdbc/BrokeredConnection.java",
"hunks": [
{
"added": [
"import java.lang.reflect.*;",
"",
"import org.apache.derby.iapi.reference.JDBC30Translation;",
"import org.apache.derby.iapi.error.PublicAPI;",
... |
derby-DERBY-801-55a6cdc3 | DERBY-801 (partial) Allow parallel access to data files
Adding RAFContainer4 which is used instead of RAFContainer on jdk1.4
and higher. RAFContainer4 uses FileChannels to access the data files,
and therefore multiple threads may access them in parallel.
Patch contributed by Anders Morken.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@447815 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/BaseDataFileFactory.java",
"hunks": [
{
"added": [
"\t// Creates RAFContainer instances tailored to the running VM",
"\tprivate RAFContainerFactory rafContainerFactory = new RAFContainerFactory();",
""
... |
derby-DERBY-801-5cc38754 | DERBY-801: Allow parallel access to data files
This patch (DERBY-801-7.patch) turns the DEBUG_PRINT messages in
RAFContainer4 into assertions guarding the method entry points.
Patch contributed by Anders Morken.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@474695 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer4.java",
"hunks": [
{
"added": [
" // If ioChannel == null and fileData supports getChannel()",
" // we have a problem. See this.openContainer(ContainerKey ",
" ... |
derby-DERBY-801-f0cd4bf3 | DERBY-801 (partial) Allow parallel access to data files
Backing out the patch for DERBY-733 as it is not needed anymore and
the code is cleaner without it.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@447856 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java",
"hunks": [
{
"added": [],
"header": "@@ -55,8 +55,6 @@ import java.io.RandomAccessFile;",
"removed": [
"import java.lang.reflect.Method;",
"import java.lang.reflect.Constructor;"... |
derby-DERBY-802-b7c1f3b0 | DERBY-802 OufOfMemoryError when using BLOB from scrollable insensitive result sets. The fix is to avoid the use of cloning the rows before inserting them into the BackingStoreHashTable. The BackingStoreHashTable has been fixed so that it does not do unnecessary cloning. The estimateMemoryUsage methods of SQLBinary and its subclasses has been improved to return a better estimate, so that rows with BLOBs will be backed to disk when using BackingStoreHashTable. Tests have been committed separately.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@423034 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/store/access/BackingStoreHashtable.java",
"hunks": [
{
"added": [
" ",
" add_row_to_hash_table(hash_table, row, needsToClone);"
],
"header": "@@ -279,16 +279,8 @@ public class BackingS... |
derby-DERBY-806-3f3b5e6a | DERBY-806
Rather than allocating a scratch RowPosition for every delete/replace/fetch,
changed to use a single copy of a RowPosition allocated on demand per
openGenericConglomerateController. If multiple calls to delete, replace,
and/or fetch are made in the same open controller only one of these objects
will be allocated.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@535878 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/conglomerate/GenericConglomerateController.java",
"hunks": [
{
"added": [
" RowPosition pos = ",
" open_conglom.getRuntimeMem().get_scratch_row_position();"
],
"header": "@@ -166,7 +... |
derby-DERBY-808-59126251 | DERBY-808: PreparedStatements could take longer to execute than equivalent statements, because of incorect code in search clause transitive closure method.
Handle the case of ParameterNodes, in addition to ConstantNodes on the rightside.
Submitted by Satheesh Bandaram(satheesh@sourcery.org)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370217 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/PredicateList.java",
"hunks": [
{
"added": [
"\t\t\t\t// RESOLVE: Consider using variant type of the expression, instead of",
"\t\t\t\t// ConstantNode or ParameterNode in the future.",
"\t\t\t\tif (left inst... |
derby-DERBY-809-0c1cb148 | DERBY-809 Incorrect documentation for NetworkServerControl.logConnections
Patch contributed by Kristian Waagan
This is a small patch for the javadoc of NetworkServerControl and
NetworkServerControlImpl, removing the false statement that
disconnections are logged to derby.log.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@381375 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetworkServerControl.java",
"hunks": [
{
"added": [
"\tThis turns logging of connections on or off. ",
"\tConnections are logged to derby.log. "
],
"header": "@@ -62,8 +62,8 @@ import org.apache.derby.impl.drda.Net... |
derby-DERBY-818-2a6e4592 | DERBY-818 Remove the object allocation and reseting overhead for updateable ResultSet information
when the ResultSet is read-only. Similar changes for the stream single fetch (getXXXStream) logic.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@370574 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet.java",
"hunks": [
{
"added": [
"import java.util.Arrays;"
],
"header": "@@ -72,6 +72,7 @@ import java.io.InputStream;",
"removed": []
},
{
"added": [
" /**",
... |
derby-DERBY-821-5e883125 | DERBY-821 Client driver: Implicitly close exhausted result sets on the server.
Submitted by Knut Anders Hatlen
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@377367 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Cursor.java",
"hunks": [
{
"added": [
" private boolean allRowsReceivedFromServer_;"
],
"header": "@@ -69,7 +69,7 @@ public abstract class Cursor {",
"removed": [
" public boolean allRowsReceive... |
derby-DERBY-822-a10e4569 | DERBY-822: Client driver: Pre-fetch data on executeQuery()
This patch makes the network server include query data when it replies
to an OPNQRY command. (Query data is only included when there are no
LOB columns and the protocol is limited block protocol.)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394859 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" /**",
" * Cleans up and closes a result set if an exception is thrown",
" * when collecting QRYDTA in response to OPNQRY or CNTQRY.",
" *",
... |
derby-DERBY-822-fc6efec2 | DERBY-1014: Make tests less sensitive to pre-fetching
Attached a patch (DERBY-1014-v1.diff) which modifies tests in
preparation for DERBY-822. There are two types of changes:
1) Invoke ResultSet.next() to expose error even when the driver
isn't pre-fetching data.
2) Filter out some of the run-time statistics before comparing with
the canon.
lang/wisconsin.java:
* Added patterns to the sed file. Cursor names and some of the
run-time statistics are filtered out.
* Canons for DerbyNet and DerbyNetClient were deleted since they are
no longer needed. Each of these files is 1.5M, so the diff is
huge.
lang/scrollCursors1.sql:
* Added patterns to the sed file. Number of rows seen and number of
reads from hash table will be filtered out.
jdbcapi/parameterMetaDataJdbc30.java:
* Added a call to ResultSet.next() to provoke an error in a test
case for DERBY-44 regardless of framework/pre-fetching.
jdbcapi/resultset.java:
* Don't print column headers until one row is successfully retrieved
(achieved by calling ResultSet.next() earlier).
jdbcapi/setTransactionIsolation.java:
* Added a call to ResultSet.next() to provoke a timeout regardless
of framework/pre-fetching.
* Added patterns to the sed file. Filtered out number of pages
visited, number of rows qualified/visited etc.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@387214 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-826-379f95fb | DERBY-826: Improve sysinfo behavior in situations where the Derby classes are
loaded indirectly, such as through the manifest Class-Path attribute.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394334 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/sysinfo/Main.java",
"hunks": [
{
"added": [
" Copyright 1998, 2004, 2006 The Apache Software Foundation or its licensors, as applicable."
],
"header": "@@ -2,7 +2,7 @@",
"removed": [
" Copyright 1... |
derby-DERBY-827-109cb266 | DERBY-827 (partial) Performance can be improved by re-using language
ResultSets across Activation executions
Reset candidate row array between executions. Based on patch/ideas
from Dyre Tjeldvoll.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537353 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/DependentResultSet.java",
"hunks": [
{
"added": [
"class DependentResultSet extends ScanResultSet implements CursorResultSet"
],
"header": "@@ -58,7 +58,7 @@ import org.apache.derby.iapi.services.i18n.MessageSer... |
derby-DERBY-827-698ab621 | DERBY-4204: Runtime statistics not collected on re-execution of statement
Make sure NoRowsResultSetImpl.close() prints the collected runtime
statistics each time close() is called on a result set that is not
currently closed. After DERBY-827 close() didn't print the statistics
if the result set had been closed and reopened.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@774281 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/NoRowsResultSetImpl.java",
"hunks": [
{
"added": [],
"header": "@@ -62,7 +62,6 @@ import org.apache.derby.iapi.types.DataValueDescriptor;",
"removed": [
"\tprivate boolean dumpedStats;"
]
},
... |
derby-DERBY-827-95e850d9 | DERBY-827 (partial) Clean up generation of execute() method of activation to ensure
that if the ResultSet is re-used then the execute actions are still called per-execute
instead of once when the result set is created.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@521882 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ActivationClassBuilder.java",
"hunks": [
{
"added": [
"\tprivate\tMethodBuilder\tbeginExecuteMethod()"
],
"header": "@@ -201,7 +201,7 @@ class ActivationClassBuilder\textends\tExpressionClassBuilder",
"r... |
derby-DERBY-827-a3363333 | DERBY-827 (partial) Make MultiProbeTableScanResultSet reusable across
executions. Patch contributed by A B <qozinx@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@528973 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MultiProbeTableScanResultSet.java",
"hunks": [
{
"added": [
" /**",
" * The values with which we will probe the table, as they were passed to",
" * the constructor. We need to keep them unchanged ... |
derby-DERBY-827-b56d957e | DERBY-827 (partial) Performance can be improved by re-using language
ResultSets across Activation executions.
Set members to their initial values in ScrollInsensitiveResultSet's
openCore() method.
Contributed by Dyre Tjeldvoll.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@533003 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/ScrollInsensitiveResultSet.java",
"hunks": [
{
"added": [
"\t\t// When re-using language result sets (DERBY-827) we need to",
"\t\t// reset some member variables to the value they would have",
"\t\t// had in... |
derby-DERBY-827-c66c4e1d | DERBY-827 (partial) Test recreating the tables and changing the isolation
level between executions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@531820 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-827-f5d9f6c9 | DERBY-827 (partial) Make sure MiscResultSet picks up a new
ConstantAction after a recompile.
Patch contributed by Dyre Tjeldvoll.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@531349 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/MiscResultSet.java",
"hunks": [
{
"added": [
" * This is a wrapper class which invokes the Execution-time logic for",
" * Misc statements. The real Execution-time logic lives inside the",
" * executeConstant... |
derby-DERBY-827-fbf13816 | DERBY-827: Performance can be improved by re-using language ResultSets
across Activation executions
This patch enables re-use of language ResultSets.
Contributed by Daniel John Debrunner.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@540921 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/BaseActivation.java",
"hunks": [
{
"added": [],
"header": "@@ -244,10 +244,6 @@ public abstract class BaseActivation implements CursorActivation, GeneratedByteC",
"removed": [
"\tpublic void clearResultSet() {",... |
derby-DERBY-853-4afca481 | DERBY-853: ResultSetMetaData.getScale returns inconsistent values
This patch was contributed by Danoja Dias (danojadias at gmail dot com)
When a SQL statement contains arithmetic expressions, the result of the
expression may be of a different type than the operands to the expression,
due to type precedence rules which may require promoting the operand
values during evaluation of the expression.
For example, subtracting a DOUBLE from a DECIMAL results in a DOUBLE.
In some of these cases, Derby was reporting that the result column
had a non-zero scale, although the result column was not of DECIMAL type.
This change modifies the NumericTypeCompiler so that it only computes
a non-zero scale for the result column when it is of DECIMAL type.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1755133 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/NumericTypeCompiler.java",
"hunks": [
{
"added": [
"\t\t\tscale = higherTC.getScale(operator, leftType, rightType);"
],
"header": "@@ -255,10 +255,10 @@ public final class NumericTypeCompiler extends BaseTypeCom... |
derby-DERBY-857-25449226 | DERBY-857 LDAP Does not work under security manager.
Wrap InitialDirContext and debug tracing in privilege blocks. Disable debug tracing if an exception occurs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586052 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/LDAPAuthenticationSchemeImpl.java",
"hunks": [
{
"added": [
"import java.io.FileOutputStream;",
"import java.io.IOException;",
"import java.security.AccessController;",
"import java.securit... |
derby-DERBY-857-9c68d544 | DERBY-857 Inline FileOutputStream privilege block. Fix javadoc warning
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@586599 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/LDAPAuthenticationSchemeImpl.java",
"hunks": [
{
"added": [
" fos = ((FileOutputStream)AccessController.doPrivileged(",
" new ... |
derby-DERBY-858-05829c13 | DERBY-858 - ijConnName test output order is non-deterministic
Also adjusted similarly vulnerable tests tools/ij5.sql, and junit tests
derbynet.SysinfoTest and derbynet.ServerPropertiesTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@835153 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-862-9ec13b2c | DERBY-862: Commit bug 862_misc5.diff, more miscellaneous javadoc warnings.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@405210 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientJDBCObjectFactory.java",
"hunks": [
{
"added": [
" * Returns an instance of LogicalConnection."
],
"header": "@@ -78,7 +78,7 @@ public interface ClientJDBCObjectFactory {",
"removed": [
" ... |
derby-DERBY-866-04cfd282 | DERBY-866: Add syscs_reset_password() and syscs_modify_password() system procedures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1221423 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [],
"header": "@@ -2054,7 +2054,6 @@ public class SystemProcedures {",
"removed": [
" DataDescriptorGenerator ddg = dd.getDataDescriptorGenerator();"
]
... |
derby-DERBY-866-10f4b0f6 | DERBY-866: Prevent credentials db from being created with empty username or password.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1297528 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
" // which is being created now. Allow this to succeed. However, here we make sure that",
" // the credentials are legal. This prevents the credentials db ... |
derby-DERBY-866-3b95c636 | DERBY-866: Add tests for GRANT/REVOKE of execute permission on the NATIVE procs with NATIVE authentication turned on.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1245451 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-47f286f6 | DERBY-866: Add tests for encrypted credentials db.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1294183 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/ConnectionPoolDataSourceConnector.java",
"hunks": [
{
"added": [
"import java.util.Properties;"
],
"header": "@@ -22,6 +22,7 @@ package org.apache.derbyTesting.junit;",
"removed": []
},
{
... |
derby-DERBY-866-49901a4b | DERBY-866: Add expiration limits for NATIVE passwords.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1238727 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/NativeAuthenticationServiceImpl.java",
"hunks": [
{
"added": [
"import java.sql.SQLWarning;"
],
"header": "@@ -26,6 +26,7 @@ import java.security.MessageDigest;",
"removed": []
},
{
... |
derby-DERBY-866-601e027b | DERBY-866: Cleanup an NPE in NATIVE authentication and add some defensive code to frustrate blackhats.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1295189 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/authentication/NativeAuthenticationServiceImpl.java",
"hunks": [
{
"added": [
" if ( userPassword == null ) { return false; }"
],
"header": "@@ -284,6 +284,7 @@ public final class NativeAuthenticationService... |
derby-DERBY-866-61b02b72 | DERBY-866: Add test for replicating databases when NATIVE authentication is on.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1294812 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-8e6d8a0c | DERBY-866: Add regression tests for GRANT/REVOKE on new procedures supporting NATIVE authentication.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1221456 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-92268ace | DERBY-866: Add syscs_create_user() and syscs_drop_user() system procedures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1220807 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"import java.sql.Timestamp;"
],
"header": "@@ -30,6 +30,7 @@ import java.sql.Statement;",
"removed": []
},
{
"added": [
"import org.ap... |
derby-DERBY-866-92a2169d | DERBY-866: Add tests for NATIVE/LOCAL authentication in databases accessed via the jar and classpath subprotocols.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1244666 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/TestConfiguration.java",
"hunks": [
{
"added": [
" /**",
" * Open connection to the specified database using the supplied username and password.",
" * Treat the database name as a physical database n... |
derby-DERBY-866-9495437c | DERBY-866: Remove SQLPassword internal data type.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1222215 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" String password"
],
"header": "@@ -2046,7 +2046,7 @@ public class SystemProcedures {",
"removed": [
" char[] password"
]
... |
derby-DERBY-866-9efa6492 | DERBY-866: Add new upgrade test for NATIVE authentication and improve error raised when trying to read credentials in a database which hasn't been hard-upgraded to 10.9.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1236340 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-a3d7a74e | DERBY-866: Prevent authentication service from booting if NATIVE::LOCAL is specified at the system level.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1241479 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-a84fc267 | DERBY-866: Wire the new NATIVE password-management procedures to the recently checked-in password hashing improvements.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1227150 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.PasswordHasher;"
],
"header": "@@ -66,6 +66,7 @@ import org.apache.derby.iapi.sql.dictionary.CatalogRowFactory;",
"remo... |
derby-DERBY-866-aa1dc7a9 | DERBY-866: Prevent anyone other than the DBO from turning on NATIVE authentication.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1328431 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" // the first credentials must be those of the DBO and only the DBO",
" // can add them"
],
"header": "@@ -2054,7 +2054,8 @@ public class SystemPro... |
derby-DERBY-866-aa609d54 | DERBY-866: Add SYSUSERS table.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1212562 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLChar.java",
"hunks": [
{
"added": [
"import java.util.Arrays;"
],
"header": "@@ -72,6 +72,7 @@ import java.sql.Time;",
"removed": []
},
{
"added": [
" /**",
" ... |
derby-DERBY-866-ae21afbc | DERBY-866: Add tests for system-wide authentication using a credentials db accessed via the jar and classpath protocols.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1245126 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-c0399dce | DERBY-866: Prevent illegal changes to the on-disk version of derby.authentication.provider.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1235750 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/property/PropertyUtil.java",
"hunks": [
{
"added": [
" //",
" // Once NATIVE authentication has been set in the database, it cannot",
" // be overridden.",
" //",
... |
derby-DERBY-866-c1152a40 | DERBY-866: Adjust RolesTest to account for new tuple in SYSROUTINEPERMS.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1221434 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-866-c5b9acbe | DERBY-866: Mark a database as a credentials DB iff the DBO's credentials are stored in SYS.SYSUSERS.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1302868 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/SystemProcedures.java",
"hunks": [
{
"added": [
" // the first credentials must be those of the DBO",
" try {",
" DataDictionary dd = lcc.getDataDictionary();",
" String ... |
derby-DERBY-866-dc9cd0fe | DERBY-866: Add test for database restoration using NATIVE authentication.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1240152 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java",
"hunks": [
{
"added": [
""
],
"header": "@@ -459,7 +459,7 @@ final public class NetworkServerTestSetup extends BaseTestSetup {",
"removed": [
" "
]... |
derby-DERBY-876-97b7bcee | DERBY-876: DatabaseMetaData.getSchemas() is not JDBC 3.0 compliant
Added missing column to the result set returned by
EmbedDatabaseMetaData.getSchemas().
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395878 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java",
"hunks": [
{
"added": [
" * <P>The schema columns are:",
" * <li><strong>TABLE_SCHEM</strong> String => schema name</li>",
" * <li><strong>TABLE_CATALOG</strong> String... |
derby-DERBY-877-491c5b6e | DERBY-877 zOS - with DerbyClient getDate(#) fails with IllegalArgumentException - unsupported date format - resultset.java
The patch fixes issues with getString, getTimeStamp, getDate and getTime on TIMESTAMP, DATE and TIME columns when the client JVM encoding does not match the server encoding for the characters being evaluated in DateTime.java methods
- Changes the following methods in DateTime.java to take encoding parameter and create string based on encoding.
dateBytesToDate, timeBytesToTime, timeBytesToTimeStamp, dateBytesToTimeStamp, timestampBytesToDate, timestampBytesToTime
- Changes calling code to pass column encoding and throw SQLExceptions for UnsupportedEncoding exceptions if thrown from the methods above.
Tests: derbyall passed as did the repro attached to this issue on Windows with Sun JDK 1.5 . Verified on zOS
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@374271 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Cursor.java",
"hunks": [
{
"added": [
"import java.io.UnsupportedEncodingException;"
],
"header": "@@ -19,10 +19,10 @@",
"removed": [
""
]
}
]
},
{
"file": "java/client/org/a... |
derby-DERBY-877-b69e1e8f | DERBY-877 second patch to fix javadoc warnings
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@374585 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DateTime.java",
"hunks": [
{
"added": [
" * @return Date translated from buffer with specified encoding"
],
"header": "@@ -53,7 +53,7 @@ public class DateTime {",
"removed": [
" * @return"
... |
derby-DERBY-885-9082f658 | DERBY-1785
contributed by Myrna van Lunteren
patch: DERBY-1785_20061007.diff
Attaching a band-aid patch for this issue. I chose to comment out the method
rather than remove as a way to document the quirky behavior.
Having the method setSecurityProps overload the one in jvm.java causes
problems when running the junit tests - they *do* successfully run with
securityManager.
Foundation class tests actually run ok with security manager - except when
useprocess is false. This is caused by a bug in the jvm. See also DERBY-885.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@462607 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/j9_foundation.java",
"hunks": [
{
"added": [
"// Having the following method overload the one in jvm.java causes problems when running",
"// the junit tests - they *do* successfully run with securityManag... |
derby-DERBY-885-fec6b7be | DERBY-885 Disable running with the security manager for useProcess=false
for j9 vms. Causes some unexpected execption that needs to be investigated
and halts test runs. This is a workaround that will cause dml160 to fail
with j9 vms, as it checks to see a security manager is installed.
Will be investigating, but this will allow derbyall runs to complete.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@373011 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-887-07d11082 | DERBY-887: Remove implicit and explicit casting between BOOLEANs and datatypes other than BOOLEAN and strings. This conforms Derby behavior to the SQL Standard.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@827505 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ODBCMetadataGenerator.java",
"hunks": [
{
"added": [
"\t// Used for casting BOOLEANS to INTEGERS",
"\tprivate\tstatic\tfinal\tString\tBOOLEAN_COLUMNS[] =",
"\t{",
"\t\t\"CASE_SENSITIVE\",",
"\t\t\"FIX... |
derby-DERBY-888-0380d9cb | DERBY-888
initial partial checkin of allocation improvement. This checkin changes
the default of the system to not sync on allocation. All tests pass,
and hand testing of allocation encountering bad pages during redo worked.
Also adds back in development only path to be able to turn on and off
various sync options under an insane build, to compare affect of log sync,
vs. allocation sync, vs. checkpoint sync.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@375583 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/cache/CacheManager.java",
"hunks": [
{
"added": [
"\t\tin the cache at the time of the call are placed in the clean state ",
" sometime during this call. Objects that are added to the cache during ",
" ... |
derby-DERBY-888-f57b07d2 | DERBY-888
Add specific errors for failure while doing initpage redo recovery attempt.
Remove "loadTran" references, that term isn't really useful to current code.
All cases now apply to redo recovery.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376502 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/BaseContainerHandle.java",
"hunks": [
{
"added": [
" /**",
" * ReCreate a page for rollforward recovery. ",
" * <p>",
" * During redo recovery it is possible for the system to tr... |
derby-DERBY-889-bde12207 | DERBY-889 with client getTimestamp on a TIME column will print the date 1900-01-01 instead of the current date
Committed Bryan's fix unchanged and enabled test cases in TimeHandlingTest
Contributed by Bryan Pendleton
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@537252 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-892-ee43510e | DERBY-892: Allow for test-specific additions to the derby_tests.policy file.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@407642 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-896-c1a0ff21 | DERBY-896: Allow casts from DATE and TIME to TIMESTAMP
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1568924 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-898-6f5654cc | DERBY-898 setAutoCommit(false) is not working properly with connections objtained with ClientXADataSource.
- Changes server side connection for network server XA to autocommit false. Even when the client has autocommit on, the server side connection should be autocommit false and let the client drive the commits.
- Adds connections obtained from an XADataSource to the savepointJdbc30_XA test to verify that autocommit is being set properly and also verify that DERBY-899 (a dup of this issue) is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376296 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-899-6f5654cc | DERBY-898 setAutoCommit(false) is not working properly with connections objtained with ClientXADataSource.
- Changes server side connection for network server XA to autocommit false. Even when the client has autocommit on, the server side connection should be autocommit false and let the client drive the commits.
- Adds connections obtained from an XADataSource to the savepointJdbc30_XA test to verify that autocommit is being set properly and also verify that DERBY-899 (a dup of this issue) is fixed.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376296 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-900-99683a9c | DERBY-900 - Remove use of String(byte[]) and String(byte[], int, int) constructors in network client leading to non-portable behaviour
Decided earlier to break up the derby900.p2.diff.txt, so I am attaching now a patch with the cleanup changes separately in derby900_p2_cleanup.diff.txt. Changes are:
-- remove unnecessary conversion from sqlstate string to bytes and back to string , in parseSQLDCGRP(Sqlca[] rowsetSqlca, int lastRow) in NetConnectionReply.
This has been done by adding a constructor in NetSqlca to take in the sqlstate as string.
-- cleanup method getSqlState() in Sqlca.
-- cleanup of ccsid_ in Sqlca as it is not used.
Please note, the parseSQLDCGRP method in the diff shows more changes because of change in indentation because of removal of the try block.
-- ran derbynetclientmats on ibm142/linux OK.
Contributed by Sunitha Kambhampati
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@406120 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Sqlca.java",
"hunks": [
{
"added": [
" "
],
"header": "@@ -42,9 +42,7 @@ public abstract class Sqlca {",
"removed": [
" protected byte[] sqlStateBytes_;",
"",
" protected ... |
derby-DERBY-900-eb7b240b | DERBY-900 Remove use of String(byte[]) and String(byte[], int, int) constructors in network client leading to non-portable behaviour
This patch derby900.p2_encodingChange.diff.txt makes the encoding related change to remove the non portable String.getBytes() method.
Additonal patch for cleanup will follow
Contributed by Sunitha Kambhampati
-- use correct encoding UTF8 for sqlstate in NetConnectionReply.::parseSQLDCGRP(Sqlca[] rowsetSqlca, int lastRow)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@398944 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnectionReply.java",
"hunks": [
{
"added": [
"import java.io.UnsupportedEncodingException;"
],
"header": "@@ -28,6 +28,7 @@ import org.apache.derby.client.am.DisconnectException;",
"removed": []
},
... |
derby-DERBY-901-66bdd78e | DERBY-901 encoding test for client messages.
Contributed by Sunitha Kamhampati
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395430 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-901-a2be028f | DERBY-901
Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
Contributed by Sunitha Kambhampati
I am attaching the patch ( derby901.p2.diff.txt, derby901.p2.stat.txt) to fix the remaining places that the String(byte[]) constructor is used in Network Server.
remove use of default String(byte[]) constructor in
-- trace method in DRDAConnThread.readAndSetParams to print out the hex string of the bytes .
-- use SQLERRMC_TOKEN_DELIMITER in SQLDIAGCI .
some cleanup
-- define the SQLERRMC_MESSAGE_DELIMITER in SystemProcedures and use that in DRDAConnThread.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395416 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"import org.apache.derby.catalog.SystemProcedures;"
],
"header": "@@ -44,6 +44,7 @@ import java.util.Date;",
"removed": []
},
{
"added": [
... |
derby-DERBY-901-b001c685 | DERBY-901 Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
Contributed by Sunitha Kambhampati
patch1 - Remove use of String(byte[]) constructors in network server leading to non-portable behaviour
This fixes
- SQLERRMC_TOKEN_DELIMITER, SQLERRMC_MESSAGE_DELIMITER and the corresponding usage of it in SystemProcedures to not use the default string constructors that are non portable.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394205 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" // The token delimiter value will be used to parse the MessageId from the ",
"\t// SQLERRMC in MessageService.getLocalizedMessage and the MessageId will be",
" //... |
derby-DERBY-903-9adc0223 | DERBY-903: Followup patch to remove use of String(byte[]) in two tests and
print an error message instead.
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379643 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-903-bb5e9caf | DERBY-903: Remove use of String(byte[]) constructors in tests. Also, fix casing
of previously committed errorCode master
Committed for Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@378337 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-907-c12c97d6 | DERBY-907 regression test failure in RecoveryAfterBackup on wssd5.6 ibm jvm (j2me)
* Modifies app_properties files to add ij.dataSource properties. Also changed 'database' to 'ij.database' property. Removed usedefaults to avoid conflict with default property.
* Adds a method getConnection to TestUtil to get connection using different set of attributes than what is specified in _app.properties file.
* Changes the test store/RecoveryAfterBackup to use the above method to shutdown and get connection. I'll change other tests to use the new method in a later patch.
With the patch, I ran the RecoveryAfterBackup tests with Sun JDK1.4.2, j9 and j9 foundation vm.
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376804 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestUtil.java",
"hunks": [
{
"added": [
" ",
" /**",
" * Get connection to given database using the connection attributes. This",
" * method is used by tests to get a second... |
derby-DERBY-918-bc508402 | DERBY-918: Introduce new "junit" test type
DERBY-934: Create a set of JUnit tests for scrollable updatable cursors. I
also added these tests to the jdbcapi and derbynetclientmats suites (except
for ConcurrencyTest, which takes too long to run currently)
DERBY-797: After calling ResultSet.relative(0) the cursor loses its position
These are all submitted together because of interdependencies.
All contributed by Andreas Kornelliusen
NOTE: This may cause test failures on the IBM JDK; I did not test it with
this JDK, nor did I exclude these tests from running on this JDK, as I
couldn't say whether they work or not (I don't have the IBM JDK).
I did exclude running these tests on DerbyNet, because they have a hard
failure saying "null user not supported."
Ran these tests on JDK 1.4, JDK 1.3, with both embedded and network
client drivers. Note that the SURTest.out has failures; this is because
(a) the scrollable updatable result set work is not yet finished and
(b) there are differences between network client and embedded client which
need to be resolved.
--------
DERBY-797 files:
M java/engine/org/apache/derby/impl/sql/execute/ScrollInsensitiveResultSet.java
DERBY-918 files:
M java/testing/org/apache/derbyTesting/functionTests/util/TestUtil.java
M java/testing/org/apache/derbyTesting/functionTests/harness/testtypes.properties
M java/testing/org/apache/derbyTesting/functionTests/harness/RunTest.java
DERBY-934 files:
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ConcurrencyTest_app.properties
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURBaseTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURQueryMixTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURQueryMixTest_app.properties
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/ConcurrencyTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURDataModelSetup.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURTest.java
AM java/testing/org/apache/derbyTesting/functionTests/tests/jdbcapi/SURTest_app.properties
A java/testing/org/apache/derbyTesting/functionTests/master/SURTest.out
A java/testing/org/apache/derbyTesting/functionTests/master/DerbyNetClient/SURTest.out
M java/testing/org/apache/derbyTesting/functionTests/suites/jdbcapi.runall
M java/testing/org/apache/derbyTesting/functionTests/suites/derbynetclientmats.runall
M java/testing/org/apache/derbyTesting/functionTests/suites/DerbyNet.exclude
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@378045 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestUtil.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;",
"import java.security.PrivilegedExceptionAction;",
"import java... |
derby-DERBY-924-0223b95e | DERBY-924: new JDBC4 metadata API getFunctions() needs to be implemented
Implementation of DatabaseMetaData.getFunctions() in the client
driver. Added tests for getFunctions() in the metadata test and the
upgrade test.
Patch contributed by Dyre Tjeldvoll <Dyre.Tjeldvoll@Sun.COM>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393304 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-924-178ae9d0 | Partial patch for DERBY-924, DERBY-925 and DERBY-970.
New method added: DatabaseMetaData.checkServerJdbcVersionX() - checks
whether the server supports a given JDBC version. Throws an exception
if it doesn't.
Contributed by Dyre Tjeldvoll <Dyre.Tjeldvoll@Sun.COM>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393164 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [
" /** The JDBC major version supported by the server. */",
" private final int serverJdbcMajorVersion;",
" /** The JDBC minor version supported by the server... |
derby-DERBY-924-502d6677 | Dyre's patch for DERBY-924: Implementing new JDBC4 method for embedded case, DatabaseMetadata.getFunctions()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@382379 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-924-89d3ce53 | DERBY-968: Added new metadata methods to embedded client. This
revision returns EMPTY RESULT SETS for the new methods getFunctions()
and getFunctionParameters(). DERBY-924 and DERBY-925 have been opened
for these, and linked to this issue.
I also fixed some existing metadata calls that throw a not-implemented
exception when they should have been returning empty result sets.
I also fixed a bug in Driver40 where it did not override
newEmbedDatabaseMetaData(), so EmbedDatabaseMetaData40 was not being
used.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@377503 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java",
"hunks": [
{
"added": [
" "
],
"header": "@@ -98,7 +98,7 @@ public class EmbedDatabaseMetaData extends ConnectionChild",
"removed": [
""
]
},
{
... |
derby-DERBY-925-178ae9d0 | Partial patch for DERBY-924, DERBY-925 and DERBY-970.
New method added: DatabaseMetaData.checkServerJdbcVersionX() - checks
whether the server supports a given JDBC version. Throws an exception
if it doesn't.
Contributed by Dyre Tjeldvoll <Dyre.Tjeldvoll@Sun.COM>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@393164 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [
" /** The JDBC major version supported by the server. */",
" private final int serverJdbcMajorVersion;",
" /** The JDBC minor version supported by the server... |
derby-DERBY-925-89d3ce53 | DERBY-968: Added new metadata methods to embedded client. This
revision returns EMPTY RESULT SETS for the new methods getFunctions()
and getFunctionParameters(). DERBY-924 and DERBY-925 have been opened
for these, and linked to this issue.
I also fixed some existing metadata calls that throw a not-implemented
exception when they should have been returning empty result sets.
I also fixed a bug in Driver40 where it did not override
newEmbedDatabaseMetaData(), so EmbedDatabaseMetaData40 was not being
used.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@377503 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedDatabaseMetaData.java",
"hunks": [
{
"added": [
" "
],
"header": "@@ -98,7 +98,7 @@ public class EmbedDatabaseMetaData extends ConnectionChild",
"removed": [
""
]
},
{
... |
derby-DERBY-925-e4233337 | DERBY-925: Dyre's derby-925.v1.diff patch enabling new JDBC4 getFunctionParamaters() metadata method.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@395414 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/DatabaseMetaData.java",
"hunks": [
{
"added": [],
"header": "@@ -1100,7 +1100,6 @@ public abstract class DatabaseMetaData implements java.sql.DatabaseMetaData {",
"removed": [
""
]
}
]
},
{
"f... |
derby-DERBY-927-00978657 | DERBY-927 (partial) Clarify purpose of stripping derby.* properties from
the set of JDBC attributes passed into a connection request.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376034 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedConnection.java",
"hunks": [
{
"added": [
"\t/**",
"\t * Filter out properties from the passed in set of JDBC attributes",
"\t * to remove any derby.* properties. This is to ensure that setting",
"\t... |
derby-DERBY-927-00c5b52d | DERBY-927 (partial) Remove the (unused) code path that incorrectly seemed to allow
service providers (implementations for a service, e.g. a database) and
storage factory implementations to be set from the Properties object passed
into a connection. This would be a security hole as it would allow remote
users to possibly change the implementation used to access the database,
thus changing the security environment. The code could not be exercised
as the embedded driver correctly stripped out derby.* properties from
the JDBC attributes passed in with a connection request.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@376897 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/monitor/ModuleFactory.java",
"hunks": [
{
"added": [
" public PersistentService getServiceProvider(String subSubProtocol) throws StandardException;"
],
"header": "@@ -103,7 +103,7 @@ public interface ModuleFacto... |
derby-DERBY-927-0767f34d | DERBY-927 (partial) Clean up code related to serviceProviders to aid progress towards
merging services and storage factories in the monitor.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@475780 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java",
"hunks": [
{
"added": [
"import java.util.Collections;",
"import java.util.Iterator;",
"import java.util.Map;"
],
"header": "@@ -75,8 +75,11 @@ import java.io.InputStr... |
derby-DERBY-927-e30b79b3 | DERBY-927 (partial) Load sub-sub protocol implementations (derby.subSubProtocol.*)
from implementation locations using the same mechanism as modules (derby.module.*).
This allows sub-sub protocols to utilize the environment requirement variables
derby.env.jdk.* and derby.env.classes.* to control their booting.
Move some constants into Property.java with detailed comments.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@377272 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/reference/Property.java",
"hunks": [
{
"added": [
" ",
" /**",
" * derby.module.modulename",
" * <P>",
" * Defines a new module. Modulename is a name used when loading the definitio... |
derby-DERBY-928-cf3c4cb4 | DERBY-928 Add ability to network server to accept connections with a certain security mechanism.
Add derby.drda.securityMechanism property to restrict securityMechanisms accepted from client
Detailed description of patch in bug
https://issues.apache.org/jira/browse/DERBY-928#action_12366294
Contrbuted by Sunitha Kambhampati
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@382019 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
" ",
" // if Property.DRDA_PROP_SECURITYMECHANISM has been set, then",
" // network server only accepts connectio... |
derby-DERBY-930-f4e03230 | DERBY-930: Enable autoloading of client drivers now that build 81 of jdk1.6 fixes a problem with autoloading under the SecurityManager.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@396638 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/TestConfiguration.java",
"hunks": [
{
"added": [
"import java.security.*;",
"import org.apache.derby.iapi.services.info.JVMInfo;",
""
],
"header": "@@ -19,10 +19,11 @@",
"re... |
derby-DERBY-937-ffb23e9b | DERBY-937, committing change by Andreas Korneliussen.
notes by Andreas:
I was able to reproduce this problem on every run on a very fast laptop (it was not reproducible on any other Windows lab machine I have tried). This laptop happens to be the same kind as Ole uses for the nightly tests.
Adding a 10 second sleeping period after the population of the tables, did not have any effect. I therefore tried to do run a compress on the tables (based on the assumption that statistics is updated on compress), and now the test does not fail for me anymore.
Attached is the patch which makes this test stop failing. The patch does not seem to have any sideeffects on other platforms (Solaris) tested, however the test will use more time.
note by mike:
I ran this change 20 times and it worked on my laptop, it would always fail
a few times out of 20 before the fix. I am not sure why this fix works as
the test seems to already create indexes after tables so statistics should
already be up to date.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@418108 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-938-a50c94c0 | DERBY-938 Optimize ContextManager
Use an unsynchronized collection for the manager since
it is owned by a single thread, provide optimized
access to a set of contexts with the same identifier.
Contributed by Dyre Tjeldvoll Dyre.Tjeldvoll@sun.com
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379265 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/context/ContextManager.java",
"hunks": [
{
"added": [
"import java.util.HashMap;",
"import java.util.ArrayList;",
"import java.util.List;",
"import java.util.Collections;"
],
"header":... |
derby-DERBY-939-6f2391f7 | DERBY-939: NullPointerException at ResultSet.close() time for simple
query using UNION and INTERSECT. Contributed by Yip Ng.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@427899 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/RealResultSetStatisticsFactory.java",
"hunks": [
{
"added": [
"import org.apache.derby.impl.sql.execute.SetOpResultSet;"
],
"header": "@@ -62,6 +62,7 @@ import org.apache.derby.impl.sql.execute.ProjectRestrictRe... |
derby-DERBY-941-448ecb0e | DERBY-941: Commit Narayanan's statementeventlisteners_embedded_v2.diff patch, implementing embedded support for JDBC4 statement event listening.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@394788 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedPreparedStatement.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.jdbc.BrokeredConnectionControl;"
],
"header": "@@ -68,6 +68,7 @@ import java.io.EOFException;",
"removed": []
},
{... |
derby-DERBY-941-712b41b8 | DERBY-941 (partial): Add JDBC4 support for Statement Events
a) provide the imlementation for StatementEventListener methods in
EmbedXAConnection40
b) Modify TestUtil.java to return EmbedXADataSource40 when running
with mustang
c) remove testing for LSE_COMPILATION_PREFIX as the prefix for the
SQLState when throwing the Statement Error Occurred events.
Patch contributed by V. Narayanan <V.Narayanan@Sun.COM>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@396859 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedPreparedStatement.java",
"hunks": [
{
"added": [
"\t * Additional close to close our activation.",
"\t * In the case that a XAConnection is involved in the creation of this",
"\t * PreparedStatement for e.g in... |
derby-DERBY-942-94057f1e | DERBY-942: Commit Kristian's derby-942-connectiontest-rewrite.diff, which generalizes the connection test to run under XA also.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@410945 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-944-c0119bde | Commit Kristian's patch for DERBY-944: raising appropriate exceptions for RowID calls.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@389571 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-947-8c78a280 | DERBY-947: Miscellaneous PreparedStatement methods added by JDBC4
As described in the JDBC 4 spec sections 13.2 and 3.1.
This involves building support for JDBC4 methods added to
PreparedStatement and not addressed by other JIRAs: isPoolable() and
setPoolable().
Patch contributed by Francois Orsini.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@384753 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/PreparedStatement40.java",
"hunks": [
{
"added": [
" // By default a PreparedStatement is poolable when it is created",
" private boolean isPoolable = true;",
""
],
"header": "@@ -29,6 +29,9 @... |
derby-DERBY-948-c6390ccc | DERBY-948: Miscellaneous ResultSet methods added by JDBC 4
Implemented new methods defined by the JDBC 4 spec:
* ResultSet.getHoldability()
* ResultSet.isClosed()
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@382710 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/EmbedResultSet40.java",
"hunks": [
{
"added": [
"import java.sql.Statement;",
"/**",
" * Implementation of JDBC 4 specific ResultSet methods.",
" */"
],
"header": "@@ -25,7 +25,11 @@ impor... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.