id stringlengths 22 25 | commit_message stringlengths 137 6.96k | diffs listlengths 0 63 |
|---|---|---|
derby-DERBY-680-3b118182 | DERBY-2228 Fix ij's util class to make correct determination if running on J2SE or JSR 169.
Also set DECIMAL parameter in PreparedStatement using setString and retry using setLong if
a conversion error occurs. This fixes the NullPointerExcecption seen in DERBY-680. Previously
the code was using the ResultSetMetaData which was incorrect, as it has no relationship
to the types of the parameters.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@498842 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/tools/org/apache/derby/impl/tools/ij/util.java",
"hunks": [
{
"added": [
"\tprivate static boolean IS_AT_LEAST_JDBC2;",
"\t\tboolean isAtLeastJDBC2;",
" // Need to test to see if this is",
" // currently JDBC 2 or JS... |
derby-DERBY-6807-0a1be27f | DERBY-6810: Add regression tests for XXE vulnerability.
This patch was contributed by Abhinav Gupta (abhinavgupta2004 at gmail dot com)
This change adds a new regression test suite to hold tests for XXE
vulnerabilities in XML data type processing.
The new test case is in a suite by its own because we want to control the
overall security configuration (e.g., we want to ensure that no security
manager is installed).
Over time, as other types of XXE vulnerabilities are studied, we can add
additional test cases to this test suite.
Note that this test case demonstrates incorrect behavior, we believe. When
DERBY-6807 is fixed, this test case will need to be changed accordingly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1684807 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6807-7643f965 | DERBY-6807: XXE attack possible by using XmlVTI and the XML datatype
This change enhances the DocumentBuilderFactory which is used by the
XmlVTI for parsing XML documents. The XmlVTI now automatically disables
external entity expansion and enables FEATURE_SECURE_PROCESSING.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1690855 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/XmlVTI.java",
"hunks": [
{
"added": [
"import javax.xml.XMLConstants;"
],
"header": "@@ -35,6 +35,7 @@ import java.text.ParseException;",
"removed": []
},
{
"added": [
" * <p>",
... |
derby-DERBY-681-8443b6fc | DERBY-681 (followup): Make the visibleSize() method of ResultColumnList less
restrictive by taking into account all generated columns, not just those added
in GroupByList#bindGroupByColumns. Also, add an example query to subquery.sql
that shows why this change is needed.
Contributed by: Manish Khettry (manish_khettry@yahoo.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@518687 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ResultColumnList.java",
"hunks": [
{
"added": [
"\tprivate int numGeneratedColumns() ",
"\t{",
"\t\tint numGenerated = 0;",
"\t\tint sz = size();",
"\t\tfor (int i = sz - 1; i >= 0; i--) ... |
derby-DERBY-681-d5ef9067 | DERBY-681: Remove the "wrap group by's in a subselect" rewrite in the parser.
This patch preserves the having clause through bind and optimize phases and
then, during the final rewrite for aggregates in the GroupByNode, it transforms
the having clause to a valid restriction. See text file attached to the Jira
for more information.
Contributed by Manish Khettry (manish_khettry@yahoo.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@516454 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateTableNode.java",
"hunks": [
{
"added": [
"\t\t\t\tif (resultColumns.size() != qeRCL.visibleSize())"
],
"header": "@@ -280,7 +280,7 @@ public class CreateTableNode extends DDLStatementNode",
"remove... |
derby-DERBY-681-dcd2b043 | DERBY-4450 GROUP BY in an IN-subquery inside HAVING clause whose select list is subset of group by columns, gives NPE
Patch derby-4450b + Knut's simplification of the autocommit call in GrooupByTest#testDerby4450.
This solves the problem seen in this issue, which was a regression
from DERBY-681. The crux of the problem is that a PRN is added in the
result set tree without adjusting a higher level reference so that
wrong code is generated. The solution here is to reuse the result
column list in the inserted PRN, so that reference from above will
point correctly even after the PRN insertion (more details in JIRA).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@882732 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6825-4394bdd1 | DERBY-6825: Add SimpleJsonVTI and helper functions to the simpleJson optional tool; commit derby-6825-02-aa-vti.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1693506 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/optional/org/apache/derby/optional/api/SimpleJsonUtils.java",
"hunks": [
{
"added": [
"import java.io.FileInputStream;",
"import java.io.InputStream;",
"import java.io.InputStreamReader;",
"import java.io.IOException;",
"import ... |
derby-DERBY-6825-961b0f44 | DERBY-6825: Add to the simpleJson tool a function which converts a JSONArray into a Clob; commit derby-6825-05-aa-toClobFunction.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1701885 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/optional/org/apache/derby/optional/api/SimpleJsonUtils.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.HarmonySerialClob;"
],
"header": "@@ -46,6 +46,7 @@ import org.json.simple.JSONArray;",
"removed": []
}
]
}
] |
derby-DERBY-683-fb605fe1 | DERBY-683: Commit _tstpatch3_ by Myrna. Adds derbyTesting.encoding property to
harness. Excludes encodingTests from all JDKs except Sun JDK 1.5. Further
investigation is required to understand why this is necessary. The changes
introduced in this patch (specifically, setting -Dfile.encoding on the command-
line of the spawned JVM) should not cause NoClassDefFoundErrors on JDK 1.4.2,
but they do.
Committed for Deepa Remesh <dremesh@gmail.com> and
Myrna Van Lunteren <m.v.lunteren@gmail.com>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@379723 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/HandleResult.java",
"hunks": [
{
"added": [
"\tpublic static String handleResult(int exitCode, InputStream stdout,",
"\t InputStream stderr, PrintWriter printWriter)",
"\t throws I... |
derby-DERBY-6852-d055adb2 | DERBY-6852: Allow identity columns to cycle
This patch was contributed by Danoja Dias (danojadias at gmail dot com)
This change introduces the new CYCLE keyword to the syntax of a
generated identity column. The CYCLE keyword, if specified, causes Derby
to select the CYCLE option in the sequence object that is created
internally to implement the identity column.
In turn, this means that values can be generated for the identity column
beyond the maximum value for the column's datatype; when that maximum
is reached, the sequence "cycles" and begins over again, (re-)generating
the values all over again.
Note that, as part of this change, when a Derby sequence cycles, it now
cycles to its minimum/maximum value (depending on whether it has a
positive increment or a negative increment) rather than to its start
value; we believe this is improved behavior and is still standards-compliant.
With this change, the basic behavior is operational and there are tests
to demonstrate this. Various syntax checks are made, and the underlying
sequence is created correctly.
There is follow-up work to be done, which will be addressed possibly as
separate projects; we believe the basic feature is certainly usable
as of this change (and once we add documentation for it).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1756287 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ColumnDefinitionNode.java",
"hunks": [
{
"added": [
" long autoincrementCycle;"
],
"header": "@@ -66,6 +66,7 @@ public class ColumnDefinitionNode extends TableEl... |
derby-DERBY-6854-a9431f51 | DERBY-6854: Fix the tests so that they run on the early access build 100 of Java 9; tests ran cleanly for me on derby-6854-01-aa-fixFor9-ea.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1725139 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6854-cd362863 | DERBY-6854: Make it possible to run Derby tests on early access
versions of JDK 9
JDK 9 will move the JDBC classes out of the boot class loader and into
the platform class loader (see JDK-8154189 in the OpenJDK bug
tracker).
Derby has some test and debug code that assumes that the JDBC classes
live in the boot class loader.
1) Some tests create a new class loader in order to make the test load
the Derby classes afresh (SysinfoLocaleTest), or to test against a
different version of Derby (the upgrade tests). To achieve this, they
create a URLClassLoader which contains the Derby jar files they want
to test against, and set the parent of the URLClassLoader to null,
which means that the boot class loader is the parent.
Now that the JDBC classes are not on the boot class loader, this
URLClassLoader is not able to find the JDBC classes, and the tests
fail with NoClassDefFoundErrors when trying to load them.
This is fixed by setting the parent of the created URLClassLoader to
what java.sql.Connection.class.getClassLoader() returns. On JDK 8 and
earlier it returns null, so nothing changes there. On JDK 9 it returns
the platform class loader, which is capable of loading the JDBC
classes.
2) The org.apache.derby.impl.services.bytecode.d_BCValidate class
contains some debug code (only included in the sane jars) which runs
some sanity checks on the generated byte code. To do this, it accesses
the class loader of all the classes in the method signatures.
When getClassLoader() is called on JDBC classes, a RuntimePermission
is needed now. This was not the case before when the JDBC classes were
in the boot class loader, since Class.getClassLoader() does not check
for permissions if the class loader is null. Now this causes an
AccessControlException in tests that run with a security manager. The
tests actually grant the required permission to derby.jar, but the
call is not wrapped in AccessController.doPrivileged(), so it fails
because the permission is not granted to the test code.
The fix is to wrap the call to getClassLoader() in a doPrivileged()
block. Additionally, because RuntimePermission("getClassLoader") is
not a mandatory permission for derby.jar, we need to check if it
raises a security exception. d_BCValidate only needs the class loader
in order to check if it is the same class loader as d_BCValidate's own
class loader. Since Class.getClassLoader() does not require any
permissions if the class has the same class loader as the calling
class, we can conclude that the class loaders are different if a
security exception is raised.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1744989 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/bytecode/d_BCValidate.java",
"hunks": [
{
"added": [
"import java.security.AccessController;",
"import java.security.PrivilegedAction;",
"import java.util.Objects;"
],
"header": "@@ -22,11 +22,1... |
derby-DERBY-6856-44694000 | DERBY-6856: Eliminate build warnings related to RoundingMode and Class.newInstance() introduced by build 118 of JDK 9: commit derby-6856-05-ag-roundingMode-Class.newInstance.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1745932 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ClientPreparedStatement.java",
"hunks": [
{
"added": [
"import java.math.RoundingMode;"
],
"header": "@@ -25,6 +25,7 @@ import java.io.InputStream;",
"removed": []
}
]
},
{
"file": "java/clien... |
derby-DERBY-6856-4ba78a4b | DERBY-6856: Accidentally checked in the ShardingKey changes again; reverting.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1746068 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/BasicClientXADataSource40.java",
"hunks": [
{
"added": [],
"header": "@@ -21,9 +21,7 @@",
"removed": [
"import java.sql.ShardingKeyBuilder;",
"import java.sql.SQLFeatureNotSupportedException;"
]
}
... |
derby-DERBY-6856-80d39eee | DERBY-6856: Revert ShardingKey changes introduced by revision 1742858.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1742861 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/BasicClientXADataSource40.java",
"hunks": [
{
"added": [],
"header": "@@ -21,9 +21,7 @@",
"removed": [
"import java.sql.ShardingKeyBuilder;",
"import java.sql.SQLFeatureNotSupportedException;"
]
}
... |
derby-DERBY-6856-a12152ae | DERBY-6856: Remove deprecation warnings related to Observer/Observable by adding Derby implementations of the observable behavior.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1746066 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/BasicClientXADataSource40.java",
"hunks": [
{
"added": [
"import java.sql.ShardingKeyBuilder;",
"import java.sql.SQLFeatureNotSupportedException;"
],
"header": "@@ -21,7 +21,9 @@",
"removed": []
}
... |
derby-DERBY-6856-ce40a31d | DERBY-6856: Fix more deprecation warnings when Derby is compiled with JDK 9 build 116; commit derby-6856-04-ab-autoboxingDeprecationWarnings-part2.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1742858 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/jdbc/BasicClientXADataSource40.java",
"hunks": [
{
"added": [
"import java.sql.ShardingKeyBuilder;",
"import java.sql.SQLFeatureNotSupportedException;"
],
"header": "@@ -21,7 +21,9 @@",
"removed": []
}
... |
derby-DERBY-6856-ddebc878 | DERBY-6856: Disable SystemPrivilegesPermissionTest.testSerialization(), an unnecessary test case which fails on JDK 9. Tests passed cleanly on derby-6856-10-aa-disable-permissions-subverting-test.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1778945 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6857-0d57d84c | DERBY-6857: Deprecate support for building Derby under JDKs 6 and 7
Remove the JVMInfo constants for Java 6 and 7, since they are no longer
supported.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728767 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetworkServerControl.java",
"hunks": [
{
"added": [],
"header": "@@ -31,7 +31,6 @@ import java.security.PrivilegedAction;",
"removed": [
"import org.apache.derby.iapi.services.info.JVMInfo;"
]
}
]
},
{
... |
derby-DERBY-6857-0feae43b | DERBY-6857: Deprecate support for building Derby under JDKs 6 and 7
Make ClassInvestigator understand the new byte codes added in Java 7
to support InvokeDynamic and lambda. Also transform an inner class to
a lambda in the NetworkServerControl class to test that
ClassInvestigator understands the new codes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728732 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/drda/NetworkServerControl.java",
"hunks": [
{
"added": [
"import java.security.PrivilegedAction;"
],
"header": "@@ -27,7 +27,7 @@ import java.net.InetAddress;",
"removed": [
"import java.security.PrivilegedExcept... |
derby-DERBY-6857-c491355c | DERBY-6857: Make classlister prune the constants files from the rosters of jar file contents; commit derby-6857-04-aa-pruneConstantClasses.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1727680 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/classlister.java",
"hunks": [
{
"added": [
" //",
" // Exclude classes which are referenced only by the compiler",
" // in order to copy constants into the target class. These were not recorded",
" ... |
derby-DERBY-6864-3602a8c8 | DERBY-6864: RawDBReaderTest fails on Windows
RawDBReaderTest.runRecoveryScript() opens a FileReader, but doesn't
close it. When the test harness tries to delete the test directory
upon completion of the test, it fails because one of the files in the
directory is still open.
This patch makes runRecoveryScript() open the FileReader in a
try-with-resources statement, so that it is automatically closed when
it goes out of scope.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728370 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6864-5a3453db | DERBY-6864: RawDBReaderTest fails on Windows
DataFileVTI.makeDecryptionEngine() opens a stream that reads from
service.properties, but it never closes the stream. This prevents the
file from being deleted later. This patch makes it open the stream in
a try-with-resources statement so that it gets closed automatically.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728459 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/optional/org/apache/derby/optional/dump/DataFileVTI.java",
"hunks": [
{
"added": [],
"header": "@@ -29,17 +29,11 @@ import java.io.FileInputStream;",
"removed": [
"import java.io.ObjectInput;",
"import java.io.ObjectInputStream;",
"... |
derby-DERBY-6864-5eb3cdfe | DERBY-6864: RawDBReaderTest fails on Windows
Use BaseTestCase.assertDirectoryDeleted() instead of File.delete()
to delete the db directory, so that we get more information if the
directory cannot be deleted.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728426 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6865-14248ac9 | DERBY-6865: RestrictiveFilePermissionsTest fails on Windows
Move the contents of FilePermissionServiceImpl into FileUtil. It was
originally separated out of FileUtil because it used functionality
only available on Java 7 and higher, so it had to be loaded via
reflection. Since Java 8 is the minimum level on trunk, it could be
used directly from FileUtil without reflection.
The reason for the test failure was that a recent change caused
FilePermissionServiceImpl to be excluded from derby.jar, so that its
services were not used, and the database files ended up with unexpected
permissions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728681 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/FileUtil.java",
"hunks": [
{
"added": [
"import java.nio.file.Files;",
"import java.nio.file.Path;",
"import java.nio.file.attribute.AclEntry;",
"import java.nio.file.attribute.AclEntryPermission;"... |
derby-DERBY-6865-8aa8deb9 | DERBY-6865: RestrictiveFilePermissionsTest fails on Windows
Remove use of reflection in the test. Reflection was used to access
functionality only available on Java 7 and higher. Since Java 8 is
the minimum level now, reflection is no longer needed.
This doesn't fix the test failure, but it makes it easier to debug
the test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1728667 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6868-949e80b7 | DERBY-6868: Remove the dependency on Jakarta ORO
Rewrite the Sed class so that it uses java.util.regex instead of
Jakarta ORO for regular expression matching and substitution.
Remove tools/java/jakarta-oro-2.0.8.jar and all references to it.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1729326 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/harness/Sed.java",
"hunks": [
{
"added": [
" * written using the java.util.regex regular expression classes.",
"import java.util.List;",
"import java.util.regex.Pattern;",
"import java.util.st... |
derby-DERBY-6869-3592c633 | DERBY-6869: XMLXXETest fails in non-English locales
Decorate the test with a LocaleTestSetup that forces it to run in US
locale, so that it always sees English error messages.
Change the failing assert so that it reports the original exception in
case it doesn't get the expected exception. Makes it easier to debug
the test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1729402 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6875-9a1012a6 | DERBY-6875: Mirror selection broken on Derby download pages.
This change changes the tool which generates the Derby download page for
a new release, to remove the comment markers from the mirror selection
portion of the page.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1732683 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/ReleaseNotesTransformer.java",
"hunks": [
{
"added": [
" \"[if-any http] [for http]\\n\" +",
" \"[end] [end]\\n\" +",
" \"[if-any ftp] [for ftp]\\n\" +",
" \"[end] [end]\\n\" +",
... |
derby-DERBY-6879-677a71c4 | DERBY-6879: Engine deadlock between XA timeout handling and cleanupOnError
This patch was contributed by Brett Bergquist (brett at thebergquistfamily dot com)
The original problem to be solved is that a connection that is performing a
XA transaction that discovers an error that must be cleaned up is going to
have a lock on a EmbedConnection and will then require a lock on the
XATransactionState.
And if the same XA transaction times out (because of the XA transaction
timer value) while the original XA transaction is being worked, then the
timeout handling is going to have a lock on the XATransactionState and then
require a lock on the EmbedConnection, triggering the deadlock.
The change in the patch fixes this problem by altering the locking on
the XATransactionState when invoked via the timeout by removing the
synchronization on the "cancel" method and instead using inline
synchronization on the "XATransactionState" while its internals are being
altered.
Then, it releases the XATransactionState lock to allow the
EmbedConnection.rollback method to be invoked without the lock.
Finally, it acquires the lock again to finish cleaning up the XATransactionState.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1751978 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/functionTests/util/DeadlockWatchdog.java",
"hunks": [
{
"added": [
"/*",
" * Derby - Class org.apache.derbyTesting.functionTests.util.Barrier",
" *",
" * Licensed to the Apache Software Foundation (ASF) und... |
derby-DERBY-6879-698bfec5 | DERBY-6879: Engine deadlock between XA timeout handling and cleanupOnError
This patch was contributed by Brett Bergquist (brett at thebergquistfamily dot com)
This change is a follow-up to revision 1751977.
The problem with that revision occurs if a timeout occurs calling "cancel"
and if an error occurs on the clients connection causing the "cleanupOnError"
to be called at the same time.
This change creates a new private static class that is used to track if
"cancel" or "cleanupOnError" has been invoked. The methods are synchronized
so that there is no timing issue on checking and recording the state.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1753333 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/XATransactionState.java",
"hunks": [
{
"added": [
" ",
" /**",
" * A class used to monitor if the transaction is in the middle of",
" * cancelling or cleaning up on an error. ",
" ... |
derby-DERBY-6879-88b727b0 | DERBY-6879: Engine deadlock between XA timeout handling and cleanupOnError
This patch was contributed by Brett Bergquist (brett at thebergquistfamily dot com)
The original problem to be solved is that a connection that is performing a
XA transaction that discovers an error that must be cleaned up is going to
have a lock on a EmbedConnection and will then require a lock on the
XATransactionState.
And if the same XA transaction times out (because of the XA transaction
timer value) while the original XA transaction is being worked, then the
timeout handling is going to have a lock on the XATransactionState and then
require a lock on the EmbedConnection, triggering the deadlock.
The change in the patch fixes this problem by altering the locking on
the XATransactionState when invoked via the timeout by removing the
synchronization on the "cancel" method and instead using inline
synchronization on the "XATransactionState" while its internals are being
altered.
Then, it releases the XATransactionState lock to allow the
EmbedConnection.rollback method to be invoked without the lock.
Finally, it acquires the lock again to finish cleaning up the XATransactionState.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1751977 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/jdbc/XATransactionState.java",
"hunks": [
{
"added": [
" public synchronized boolean cancel() {",
" public synchronized void run() {",
" if (null != xaState) {",
" xa... |
derby-DERBY-688-24f43da2 | DERBY-688: Enhancements to XML functionality toward XPath/XQuery support
This revision contains d688_phase2_v1_code.patch and d688_phase2_v3_tests.patch
This patch was contributed by Army Brown (qozinx@gmail.com).
Attaching a "phase 2" patch that does the following:
- Adds syntax and binding logic for XMLQUERY operator
- Updates syntax for XMLEXISTS to match XMLQUERY and does some refactoring
so that the two can share code. The most user-visible change in this area
is the change from BY VALUE to BY REF syntax, which required test updates
and corresponding master file updates.
Also as part of these changes I've rewritten some of the parse logic to
make it more easily extendible to a broader XMLQUERY syntax (as defined in
SQL/XML[2006]) when/if Derby supports the broader syntax (esp. optional
context items and variable bindings) in the future.
- These phase 2 patches do *not* actually implement the XMLQUERY operator
yet; they just allow parsing and binding of the operator. Execution-time
logic will come in a subsequent patch.
For the sake of review I've separated the Phase 2 patches into two
different parts:
d688_phase2_v1_code.patch: The code changes.
d688_phase2_v3_tests.patch: The test/master changes.
When committed, though, *both* patches should be committed together
in order to avoid test diffs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429764 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/BinaryOperatorNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.services.io.StoredFormatIds;",
""
],
"header": "@@ -29,6 +29,8 @@ import org.apache.derby.iapi.error.StandardException;",... |
derby-DERBY-688-3bcc92e6 | DERBY-688: Enhancements to XML functionality toward XPath and XQuery support
This revision contains d688_phase5_v1.patch.
This patch was contributed by Army Brown (qozinx@gmail.com).
The phase 5 patch, d688_phase5_v1.patch, adds code to determine whether or
not the user's classpath has the required XML classes and, if not, to throw
a user-friendly(-ier) error message whenver the user attempts to use any of
the XML operators.
I inquired as to the best way to do this in the following thread:
http://thread.gmane.org/gmane.comp.apache.db.derby.devel/25307/focus=25315
Dan suggested a) looking at the Derby code that loads modules, and
b) adding a new utility method to the ClassInspector class.
I looked at the module-loading code and it ultimately just makes a call to
Class.forName() and ignores a module if that call throws a LinkageError or
a ClassNotFoundException; see the getImplementations() method in
BaseMonitor.java. So based on that I added a utility method to ClassInspector
that does the same thing, except that it just returns "true" if the call
to Class.forName() succeeds and "false" otherwise. I made the new method
static because it doesn't rely on any state specific to ClassInspector and
because it would have taken a good deal of searching for me to figure out
how to instantiate an instance of ClassInspector correctly from within
the XML datatype class.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430670 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java",
"hunks": [
{
"added": [
" * deeper in the execution codepath. The initial check for the",
" * required XML classes can be found in XML.checkXMLRequirements()."
],
"header": "@@... |
derby-DERBY-688-6e7bbc8c | DERBY-688: Enhancements to XML functionality toward XPath/XQuery support
This revision contains d688_phase1_v3.patch.
This patch was contributed by Army Brown (qozinx@gmail.com).
Attaching a "phase 1" patch, d688_phase1_v1.patch, for this issue that does the following:
1. Reorganizes XML-specific code as follows:
- Moves all code that relies on JAXP and Xalan classes
out of XML.java and into a new class, SqlXmlUtil.java.
See comments at the beginning of SqlXmlUtil for an
explanation of why this was done.
- Creates a new class, SqlXmlExecutor, in the impl.sql.execute
package that serves as the class on which all XML operator
calls are generated. Ex. for XMLEXISTS, instead of
generating:
<xmlOperand>.XMLExists(<query-expr>, xmlOperand)
we now generate:
<SqlXmlExecutor>.XMLSerialize(<query-expr>, xmlOperand)
Along with making the code cleaner by allowing all
XML operator calls to be defined in the same class,
this new class has other benefits, as well--see
comments at the beginning of SqlXmlExecutor for
more of an explanation.
2. Changes implementation of XPath from XSLT processing to
the low-level Xalan API, which is faster, more flexible,
and better for implementation of the XMLQUERY operator
(the XMLQUERY operator will be coming in subsequent
phases). Note that as part of this change I've removed
the dependency on an explicit declaration of Xerces
as the parser; Derby will now pick up the parser from
the JVM (i.e. this patch resolves DERBY-567).
3. Makes a small change to the XMLEXISTS operator to bring
it more in line with SQL/XML spec. More specifically,
the query expression that is specified must now be a string
literal; parameters and other expressions are not allowed.
4. Updates the XML test and master files (lang/xml_general.sql
and lang/xmlBinding.java) to bring them in sync with the latest
Derby codeline. Since the XML tests are not (yet) run
as part of derbyall, the master files need to be updated
to reflect some client/server changes that have gone into
the codeline for 10.2 (for example, server pre-fetching
behavior).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429698 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/XML.java",
"hunks": [
{
"added": [],
"header": "@@ -46,28 +46,6 @@ import java.io.ObjectOutput;",
"removed": [
"import org.xml.sax.ErrorHandler;",
"import org.xml.sax.XMLReader;",
"import org.xml.s... |
derby-DERBY-688-9f654e53 | DERBY-688: Enhancements to XML functionality toward XPath/XQuery support
This revision contains d688_phase3_v1_code.patch and d688_phase3_v1_tests.patch
This patch was contributed by Army Brown (qozinx@gmail.com).
Attaching a "phase 3" patch that implements the XMLQUERY operator. The patch is in two parts:
- d688_phase3_v1_code.patch
- d688_phase3_v1_tests.patch
When committed, though, *both* patches should be committed together in
order to avoid test diffs.
The SQL parsing/compile time logic was added as part of the phase 2 patch;
this patch handles the execution-time logic by making the necessary Xalan
calls to evaluate an expression and to retrieve the results.
The phase 3 patch also adds logic to distinguish between two "types" of XML:
XML(DOCUMENT(ANY)) and XML(SEQUENCE), as defined in the SQL/XML[2006]
specification. The reason we need to distinguish between the two is that
the result of evaluating an XML query expression against an XML document
can be an arbitrary list of items including atomic values, attributes,
etc.--i.e. a sequence of items that is *not* required to form a valid
DOCUMENT node. For now, though, we only allow valid DOCUMENTs to be
inserted into XML columns, so we have to be able to look at the results
of the XMLQUERY operator to determine whether or not it's a valid DOCUMENT,
and if not we disallow insertion of that result into an XML column.
We can, however, keep the result transiently and pass it into other
operations that accept an XML value (namely, XMLSERIALIZE, which a user
can then use to retrieve the results in serialized form).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@429847 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java",
"hunks": [
{
"added": [
"import org.w3c.dom.Element;",
"import org.w3c.dom.NodeList;"
],
"header": "@@ -32,7 +32,9 @@ import java.io.StringReader;",
"removed": []
},
{
... |
derby-DERBY-688-e1858949 | DERBY-688: Enhancements to XML functionality toward XPath/XQuery support
This patch was contributed by Army Brown (qozinx@gmail.com)
This change contains d688_phase6_v1.patch, which changes the SQLSTATEs for
XML errors to match the SQL/XML specification where possible, and that
moves the Derby-specific XML sql states to a compile-time range
(42Z70 - 42Z7Z) instead of an execution-time range (X0Xxx).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@433450 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/XML.java",
"hunks": [
{
"added": [
" SQLState.LANG_NOT_AN_XML_DOCUMENT);"
],
"header": "@@ -377,7 +377,7 @@ public class XML",
"removed": [
" SQLState.LANG_INVALID_XML_C... |
derby-DERBY-688-f67c2ee7 | DERBY-688: Enhancements to XML functionality toward XPath/XQuery support
This patch was submitted by Army Brown (qozinx@gmail.com)
Attaching a "phase 7" patch, d688_phase7_v1.patch, that does the following:
1 - Makes changes to catch all "Throwable" errors that might be
thrown by Xalan or JAXP, instead of just catching the exceptions
declared by the APIs. This is per the email thread here:
http://www.nabble.com/xalan-assertion-when-execution-a-xml-query...-tf2149830.html#a5953476
This allows Derby to continue working as normal if/when an
unexpected Xalan/JAXP error (such NPE or assertion failure)
occurs. In that case the statement itself will fail and the
error will be printed, but Derby will continue to work as
expected after the failure.
2 - Slight change so that, in the event of an unexpected Xalan
compilation error, the name of the operator that encountered
the error will be printed as part of Derby's message. Currently
the operator name isn't passed in and thus "{0}" shows up
in the error message, which is incorrect.
3 - Fixes a small bug in XML query execution code that was leading
to NPEs in Xalan. Namely, the current code passes a null argument
into Xalan where a non-null is expected (and required) for namespace
prefix resolution.
4 - Makes the first of two changes required to ensure Derby SQL/XML
support agrees with the specification. The two changes are
mentioned in my previous comments; this phase 7 patch addresses
the first one (insertion of a non-Document node into a Derby XML
column should not be allowed).
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@434556 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SqlXmlUtil.java",
"hunks": [
{
"added": [
"import org.apache.xml.utils.PrefixResolverDefault;",
""
],
"header": "@@ -56,6 +56,8 @@ import org.apache.xpath.XPathContext;",
"removed": []
},
... |
derby-DERBY-6880-21044de3 | DERBY-6880: Update failing with java.sql.SQLDataException
This change reverts part of the changes made by revision 1628596 for DERBY-6742.
Specifically, the section of code added to UpdateResultSet.collectAffectedRows
is removed. That code caused problems with certain SQL UPDATE statements
which were compiled with Statement.RETURN_GENERATED_KEYS. The new test cases
added by this change include several examples of such SQL statements.
The JDBC documentation for the intended behavior of UPDATE statements with the
RETURN_GENERATED_KEYS option is unclear; the intended behavior is much
clearer with INSERT statements. Given that I don't understand the intended
behavior, it seems safer to me to return Derby to the previous state for
UPDATE statements; namely, that no attempt is made to compute the set of
generated keys for an UPDATE statement.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1741380 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6881-349d2a29 | DERBY-6881: Test failures with JDK 9-ea b111
ClassLoaderTestSetup casts the context class loader to URLClassLoader
in order to create a new URLClassLoader with the same URLs as the
original class loader. In JDK 9, the context class loader is no longer
a URLClassLoader after JEP 261. This code now results in a
ClassCastException.
The point of ClassLoaderTestSetup is to change the context class
loader to something which is not the system class loader. It does not
have to be a clone of the original context class loader. This patch
therefore changes ClassLoaderTestSetup so that it sets the context
class loader to an empty URLClassLoader which wraps the system class
loader. This avoids the unreliable cast and the resulting
ClassCastException.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1737188 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/ClassLoaderTestSetup.java",
"hunks": [
{
"added": [],
"header": "@@ -24,7 +24,6 @@ import java.net.URLClassLoader;",
"removed": [
"import org.apache.derbyTesting.functionTests.tests.upgradeTests.UpgradeClassLoader;... |
derby-DERBY-6882-5b838fd0 | DERBY-6882: Add ALTER TABLE ALTER COLUMN ... SET GENERATED functionality, which switches an identity column from ALWAYS to BY DEFAULT and vice-versa.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1738368 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ColumnDefinitionNode.java",
"hunks": [
{
"added": [
"\t//alter table command to change the ALWAYS vs DEFAULT nature of an autoinc column",
"\tpublic static final int MODIFY_AUTOINCREMENT_ALWAYS_VS_DEFAULT = 3;"
... |
derby-DERBY-6885-bb5be6f1 | DERBY-6885: Remove ReuseFactory
The methods getInteger(), getShort(), getByte(), getLong() and
getBoolean() are now simple wrappers around Integer.valueOf(),
Short.valueOf(), and so on. They no longer have any purpose, and can
be removed. Callers can either call the corresponding valueOf() method
directly or rely on auto-boxing (which use valueOf() implicitly).
The remaining method, getZeroLenByteArray(), which returns a static
instance of an empty byte array, is replaced with a static final field
in the ArrayUtil class.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1740842 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/ArrayInputStream.java",
"hunks": [
{
"added": [],
"header": "@@ -27,10 +27,6 @@ import java.io.EOFException;",
"removed": [
"import org.apache.derby.iapi.services.io.LimitObjectInput;",
"import org.apa... |
derby-DERBY-6890-dc05c9d8 | DERBY-6890: ALTER TABLE DROP COLUMN corrupts secondary index collation data.
During ALTER TABLE DROP COLUMN, we rebuild all the indexes on the table. Some
indexes may be entirely dropped, some indexes may be rebuilt with a subset
of columns, some indexes are simply rebuild with essentially the same content.
The issue is that the index rebuild logic was incorrectly setting the
collation data for each index. So the indexes had the right data, but the
wrong collation information, causing them to be damaged.
This change moves the computation of the index collation ids out of the
setUpAllSorts method, into the getAffectedIndexes method, where it is simpler
to compute the index collation ids appropriately, because the code in that
location already has logic to manipulate both the old (pre-DROP) and new
(post-DROP) table descriptions, and so it is straightforward to compute the
correct collation ids there.
As part of this change, an old test case in CollationTest2, which was marked
with the comment "this test does not work yet", and was disabled, is changed
(un-commented) and is now enabled.
I found no new problems with this test case. I believe that, at the time
that comment was written, there were bugs in Derby that have since been
repaired, and hence it is appropriate to enable this test case at this time.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1749069 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java",
"hunks": [
{
"added": [
"\t\t\tcollation = new int[numIndexes][]; ",
"\t\t\t\t// Setup collation id array to be passed in on call to create index.",
"\t\t\t\tcollation[i] = ",... |
derby-DERBY-6891-f5bf9a9e | DERBY-6891: Improve the synchronization behavior of DerbyObservable; commit derby-6891-01-ab-synchronizeMethods.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1750214 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/monitor/DerbyObservable.java",
"hunks": [
{
"added": [
"import java.util.ArrayList;"
],
"header": "@@ -21,7 +21,7 @@",
"removed": [
"import java.util.Vector;"
]
},
{
"a... |
derby-DERBY-6902-3ef48bb1 | DERBY-6902: Value out of range error
This change adds still more new test cases to ParameterMappingTest, derived
from the original scenario described in the issue.
The new test cases explore some datatype conversions from string-to-integer.
They also look at some other variations on the original query from the
issue, demonstrating that the details of the phrasing of the query affect
the query compiler's decisions about intermediate data types.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1770458 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6902-9fbbcb81 | DERBY-6902: Value out of range error
This change adds several new test cases to ParameterMappingTest, derived
from the original scenario described in the issue.
These test cases are designed to demonstrate the particular exception
discussed in the issue, as well as to demonstrate several ways to use
a CAST operator so that the query executes as desired.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1769904 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6904-f15ef888 | DERBY-6903: ALTER TABLE ALTER COLUMN resets CYCLE option
DERBY-6904: Enhance ALTER TABLE to allow CYCLE option to be changed
DERBY-6905: Enhance SYS.SYSCOLUMNS to report the CYCLE value
DERBY-6906: Allow a GENERATED column to explicitly specify NO CYCLE
This patch was contributed by Harshvardhan Gupta (harshvardhan145 at gmail dot com)
The patch adds the CYCLE property as a fundamental property associated
with a column similar to current increment value, current increment step etc.
* SYS.SYSCOLUMNS extended to hold the cycle value of identity column.
* Extended the grammar to accept "cycle","no cycle" in alter clause
and changed the underlying column descriptor and sequencing objects.
* ALTER clause not involving cycle option (i.e increment and restart)
won't affect the cycle option.
The code flow for the upgrade handling was modelled after Derby-534
for introducing a new in column SYSTRIGGERS. There are new behaviors
for SYSCOLUMNS in both soft- and hard-upgrade scenarios.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1797283 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/ColumnDescriptor.java",
"hunks": [
{
"added": [
"\tprivate boolean\t\t\t\tautoincCycle;"
],
"header": "@@ -66,6 +66,7 @@ public final class ColumnDescriptor extends TupleDescriptor",
"removed": []
... |
derby-DERBY-6918-43d83c68 | DERBY-6918: Problem with schema name containing a period
When processing DELETE statements in a database schema including
referential integrity constraints that specify ON DELETE CASCADE,
it is easiest to keep the schema name and table name separate,
rather than pasting them together into a compound name joined with
a period, because pasting them together results in ambiguity about
which period separates the schema name from the table name, and
which period was simply part of the schema name proper.
Adjusted the logic in DeleteNode and DMLModStatementNode accordingly.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1772428 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/DMLModStatementNode.java",
"hunks": [
{
"added": [
"\tprotected String[] fkSchemaNames; // referencing schema names."
],
"header": "@@ -95,6 +95,7 @@ abstract class DMLModStatementNode extends DMLStatementNode",... |
derby-DERBY-694-ad94e28d | DERBY-694: Commit Narayanan's DERBY-694_v6.diff patch so that statement severity errors don't close jdbc objects which they shouldn't.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@430051 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/Connection.java",
"hunks": [
{
"added": [
" ",
" /**",
" * ",
" * Rollback the specific UnitOfWorkListener. ",
" * @param uwl The UnitOfWorkLitener to be rolled back",
... |
derby-DERBY-6956-2a5acb4b | DERBY-6956: CREATE TABLE AS SELECT cannot copy DECIMAL(31,6)
This change adds several test tests to serve as regression tests.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1805356 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6959-2636edd9 | DERBY-6959: Require Standard SET keyword when changing the cycling behavior of an identity column; commit derby-6959-01-ab-requireSETkeyword.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1808071 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-6961-71bdb5f4 | DERBY-6961: Correctly handle ALTER TABLE...SET [NO] CYCLE on exhausted identity columns; commit derby-6961-01-aa-recyclingExhaustedIdentityColumns.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1808668 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/AlterTableConstantAction.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.TypeId;"
],
"header": "@@ -80,6 +80,7 @@ import org.apache.derby.iapi.store.access.TransactionController;",
"re... |
derby-DERBY-6974-e1dddd62 | DERBY-6974: Convert Derby build to JDK 9 and compile at Java 9 byte code level.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1813709 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/build/org/apache/derbyBuild/javadoc/DiskLayoutTaglet.java",
"hunks": [
{
"added": [
"import jdk.javadoc.doclet.Taglet;",
"import com.sun.source.doctree.DocTree;",
"import com.sun.source.doctree.TextTree;",
"import com.sun.source.doctree.U... |
derby-DERBY-6977-5cc99059 | DERBY-6977: Eliminate collisions on generated names for constraints; commit derby-6977-01-ad-useUUID.diff.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1815172 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/catalog/DataDictionaryImpl.java",
"hunks": [
{
"added": [
" // Used for generating system names which are strictly increasing",
" // within a VM instance. This ordering is purely in order to preserve",
" //... |
derby-DERBY-7-2537b48c | DERBY-7: The NULLIF built-in function of Derby seems to accept
only string types. Passing any other type argument raises error.
Fix submitted by Mamta Satoor (msatoor@gmail.com)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@227281 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/ConditionalNode.java",
"hunks": [
{
"added": [
"\t//true means we are here for NULLIF(V1,V2), false means we are here for following",
"\t//CASE WHEN BooleanExpression THEN thenExpression ELSE elseExpression END",
... |
derby-DERBY-700-48ceb6e4 | DERBY-700 backout change pending discussion on StorageFile changes.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547062 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile.java",
"hunks": [
{
"added": [],
"header": "@@ -196,19 +196,6 @@ class DirFile extends File implements StorageFile",
"removed": [
" ",
" /**",
" * Return Random Acess file to the loc... |
derby-DERBY-700-6e1c9cd2 | DERBY-700 Derby does not prevent dual boot of database from different
ClassLoaders on Linux
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547042 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/io/DirFile.java",
"hunks": [
{
"added": [
" ",
" /**",
" * Return Random Acess file to the lock file, that is used to ",
" * get the exclusing file lock. File locks are not acquired on ",
... |
derby-DERBY-700-8a393cee | DERBY-700 part 2 add ClassLoaderBootTest
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@547046 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-700-992b79d1 | DERBY-4588 Provide a diagnostic property that will print a stack trace on succes
sful boot to help diagnose dual boot issues after the DERBY-700 fix
To use, set the property derby.stream.error.logBootTrace=true
A stack trace will print in the derby.log on boot and shutdown.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@934996 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/BaseDataFileFactory.java",
"hunks": [
{
"added": [
" boolean logBootTrace = Boolean.valueOf(startParams.getProperty(Property.LOG_BOOT_TRACE,",
" PropertyUtil.getSystemProperty(Property.LOG_BOOT... |
derby-DERBY-700-c73be02b | DERBY-700: Some cleanup of ClassLoaderBootTest.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@805858 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-704-23c70bdc | Fix to DERBY-704, submitted by Knut Anders Hatlen
From Knut:
<quote>
The patch modifies the search for a free slot in the page cache
(org.apache.derby.impl.services.cache.Clock.findFreeItem()) in the
following way:
1) find out how many invalid pages there are in the page cache
2) check whether pages that are skipped in the search are invalid
3) if the number of skipped invalid pages equals the number of
invalid pages, stop the search for invalid pages
</quote>
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@344270 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/cache/Clock.java",
"hunks": [
{
"added": [
"\t\t// no need to sync on getting the sizes since if they are",
"\t\t// wrong we will discover it in the loop.",
"\t\t\t\tint invalidItems = holders.size() - validIte... |
derby-DERBY-704-688ccfab | DERBY-704 Large page cache kills initial performance, additional comments from Knut.Hatlen@Sun.COM
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@345215 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/services/cache/Clock.java",
"hunks": [
{
"added": [
"\t\t\t\t// 1) find out how many invalid items there are in the",
"\t\t\t\t// cache",
"\t\t\t\t// 2) search for a free invalid item",
"\t\t\t\t// 3) stop ... |
derby-DERBY-706-2e4a44ee | DERBY-706 Improve testing and increase code coverage for Network Server classes
have attached a second patch 'derby-706_2.diff' which adds some more tests and re-arranges/removes some internal methods. Details of patch are:
* DDMWriter: Removes min method because Math.min is used. Use doesRequestContainData() method.
* DDMReader: Use readCodePoint() method
* DRDAConnThread: QRYOPTVAL codepoint is not part of DRDA spec. parseCcsidSBC was giving NPE.
* CodePointNameTable: Add codepoints to be used in protocol.tests
* protocol.tests: Added tests to cover methods which were not tested before.
* Session, DRDAStatement, Database, DRDAProtocolException: Remove some methods which are not needed. The same can be done using other methods.
* TestProto: Use lookup method.
* testProtocol: Added "derby.drda.traceAll=true" to derby.properties file to test methods in DssTrace
* testProperties: Added test for trace off command. Added "derby.drda.traceAll=true" to derby.properties file to test memcheck.
* runtimeinfo: Rearranged test because the output was not predictable on different jvms/machines.
Ran derbyall with Sun JDK 1.4.2 on WinXP. No failures.
Contributed by Deepa Remesh
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@356553 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/CodePointNameTable.java",
"hunks": [
{
"added": [
" put (new Integer (CodePoint.MONITOR), \"MONITOR\");"
],
"header": "@@ -70,6 +70,7 @@ class CodePointNameTable extends java.util.Hashtable",
"removed": []
... |
derby-DERBY-706-82c7dde0 | DERBY-706 Improve testing and increase code coverage for Network Server classes
Contributed by Deepa Remesh
This patch adds some tests for network server and re-arranges/removes some internal methods which are not used.
Details of patch are: * derbynet/getCurrentProperties.java - Added tests for NetworkServerControl.logConnections and setTraceDirectory methods. Modified getCurrentProperties_sed.properties to use a substitute instead of delete for traceDirectory. * derbynet/testProperties.java - Added some more command line tests. * derbynet/timeslice.java and maxthreads.java - Added tests for invalid values. * derbynet/runtimeinfo.java and sysinfo.java - Added test to call methods in NetworkServer control * Modified master files. * DRDAResultSet.java - removed unused constructor "DRDAResultSet(ResultSet rs)" * DRDAStatement.java - Changed getNumRsCols() to use getRsDRDATypes() instead of directly calling DRDAResultSet method. Removed isProcedure() method which is not used. Changed getResultSetCursorName() to call drdaRs.getResultSetCursorName() which handles case for null result set. * NetworkServerControlImpl.java - Removed methods for connection pooling which is not implemented and not used. With this patch, I ran derbyall with Sun JDK 1.4.2. No failures.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@348577 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAStatement.java",
"hunks": [
{
"added": [],
"header": "@@ -802,7 +802,6 @@ class DRDAStatement",
"removed": [
""
]
},
{
"added": [
"\t\tint[] rsDrdaTypes = getRsDRDATypes();"
... |
derby-DERBY-707-b7cdec2d | DERBY-707 providing RowLocation for deleted+purged row to GenericConglomerateController causes nullpointerexception, submitted by andreas.korneliussen@sun.com
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@345237 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/access/conglomerate/GenericConglomerateController.java",
"hunks": [
{
"added": [
" if (!open_conglom.latchPage(pos)) ",
" {",
" return false;",
" }"
],
"he... |
derby-DERBY-709-a4b59331 | DERBY-709, committing on behalf of Suresh Thalamati
-- Removed the requirement for read permission on "user.dir" for backup to
run under security manager. Absolute Path were used only to log into backup
history file. Changed it to log canonical paths only if it can be obtainer
,otherwise only relative paths are written to the backup history file.
-- Added a missing privileged blocks to the save service.properties file into
the backup.
-- Added privileged blocks for test util file functions that are called
through SQL functions/procedures.
-- Enabled some of the tests which were not running under security manager
earlier because of this bug to run by default with security manager.
Backup tests that test backup with jar Operations still can not be run under
security manager due to bug DERBY-537.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@381389 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/RawStore.java",
"hunks": [
{
"added": [
" private static final int REGULAR_FILE_GET_CANONICALPATH_ACTION = 15;",
" private static final int STORAGE_FILE_GET_CANONICALPATH_ACTION = 16;"
],
"header":... |
derby-DERBY-709-e9308b5f | DERBY-709, committing on behalf of Suresh Thalamati
This patch (derby-709_latest.diff) fixes the problems appreared with earlier
patch when tests are run againest JARS.
--- correctly catch the Security Exception when there is no permission to get
a canonical path.
--- Modified the deryb_tests.plocy to allow deltes in
${user.dir}${/}extinout${/}- .,
It is needed because, backup tests deletes the old copy of the backup at the
backup location.
--- set noSecurityManager = true for the tests that can not be run under
security manager due to bug : 1066
--- changes st_1 properties to use external tests dirs , so that tests does not
required "user.dir" permission to create parent directories for the backup
paths.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@381883 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/RawStore.java",
"hunks": [
{
"added": [
"import java.lang.SecurityException;",
""
],
"header": "@@ -83,6 +83,8 @@ import java.net.MalformedURLException;",
"removed": []
},
{
"... |
derby-DERBY-712-139ca850 | DERBY-712: Wire in cacheable sequence generation, making the NEXT VALUE FOR clause behave as expected.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@907654 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/dictionary/SequenceDescriptor.java",
"hunks": [
{
"added": [
" * See the header comment of SYSSEQUENCESRowFactory for the",
" * contract of that table. In particular, if the CURRENTVALUE column",
" * is null, then t... |
derby-DERBY-712-1c7cfce2 | DERBY-712: Support for sequences
Added NextSequenceNode.java that was forgotten in the previous
commit. Contributed by Suran Jayathilaka <suranjay@gmail.com>.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@894146 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/NextSequenceNode.java",
"hunks": [
{
"added": [
"/*",
"",
" Derby - Class org.apache.derby.impl.sql.compile.NextSequenceNode",
"",
" Licensed to the Apache Software Foundation (ASF) u... |
derby-DERBY-712-2f4a1a09 | DERBY-712: Only allow RESTRICTed drops of sequences.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@910255 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/testing/org/apache/derbyTesting/junit/JDBC.java",
"hunks": [
{
"added": [
" if ( \"TYPE\".equals( dropType ) || \"SEQUENCE\".equals( dropType ) ) { raw = raw + \" restrict \"; }"
],
"header": "@@ -389,7 +389,7 @@ public class JDBC {",
... |
derby-DERBY-712-4e119ab7 | DERBY-712: Fix problem in 888060 having to do with placement of sanity ifdefs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@888129 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/PrivilegeNode.java",
"hunks": [
{
"added": [
" }",
" switch( this.objectType)",
" {",
" case TABLE_PRIVILEGES:",
" if( SanityManager.DEBUG)",
... |
derby-DERBY-712-66d9f5a2 | DERBY-712: Small cleanup of PrivilegeNode before adding support for USAGE privilege.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@888060 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/PrivilegeNode.java",
"hunks": [
{
"added": [
" private TableName objectName;",
" private TablePrivilegesNode specificPrivileges; // Null for routine and usage privs",
" private RoutineDesignator rou... |
derby-DERBY-712-80eb35f4 | DERBY-712: Committed Suran Jayathilaka's create_drop_sequence_d.patch. This adds CREATE/DROP SEQUENCE commands.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@810151 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/sql/depend/DependencyManager.java",
"hunks": [
{
"added": [
"\tdatadictionary keeping track of dependencies between objects that it handles"
],
"header": "@@ -35,7 +35,7 @@ import org.apache.derby.iapi.store.access.Transact... |
derby-DERBY-712-9ce74923 | DERBY-712: Add dblook support for sequences.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@898123 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateSequenceNode.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.DataTypeDescriptor;",
"import org.apache.derby.iapi.reference.SQLState;",
"import org.apache.derby.iapi.types.TypeId;",
... |
derby-DERBY-712-a4cbe6f7 | DERBY-712: Wire in USAGE privilege for SEQUENCEs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@896883 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/execute/DDLConstantAction.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.sql.dictionary.StatementGenericPermission;"
],
"header": "@@ -55,6 +55,7 @@ import org.apache.derby.iapi.sql.dictionary.RoleGrantDes... |
derby-DERBY-712-bb219830 | DERBY-712: Committed Suran's patch createseq_args_bind_b.diff, making it possible to create sequences with different datatypes, boundaries, steps, and cycling.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@905369 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/CreateSequenceNode.java",
"hunks": [
{
"added": [
"",
" if (dataType != null) {",
" _dataType = (DataTypeDescriptor) dataType;",
" } else {",
" _dataTy... |
derby-DERBY-712-bb40bcbe | DERBY-712: Commit Suran Jayathilaka's first increment of work for sequence generators: this patch adds two new system catalogs, SYSSEQUENCES and SYSPERMS.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@792245 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/services/io/StoredFormatIds.java",
"hunks": [
{
"added": [
"",
" /**",
" class org.apache.derby.impl.sql.catalog.SequenceDescriptorFinder",
" */",
" static public final int SEQUENCE_DESC... |
derby-DERBY-716-2d3677b5 | DERBY-716: Datatype tests and fix to collation of string columns returned by table functions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@585710 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/TypeDescriptorImpl.java",
"hunks": [
{
"added": [
"import org.apache.derby.shared.common.reference.JDBC40Translation;",
""
],
"header": "@@ -21,6 +21,8 @@",
"removed": []
}
]
},
{
... |
derby-DERBY-716-3953c9e5 | DERBY-716: Expose VTICosting and VTIEnvironment in Derby's public api.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@574945 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/vti/VTICosting.java",
"hunks": [
{
"added": [
" * <P>",
" * to cost Table Functions. The methods on this interface provide the optimizer",
" * </P>",
" *",
" * <UL> ",
" * <LI> The estimat... |
derby-DERBY-716-4aef9b04 | DERBY-716: Commit first increment of VTI work, enabling DDL for table functions and their invocation in simple SELECTs.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@555032 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/types/BaseTypeIdImpl.java",
"hunks": [
{
"added": [
" \": \" + getSQLTypeName();"
],
"header": "@@ -195,7 +195,7 @@ public class BaseTypeIdImpl implements Formatable",
"removed": [
" ... |
derby-DERBY-716-524a8b4d | DERBY-716: Add optimizer support for Derby-style Table Functions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@574276 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/sql/compile/FromVTI.java",
"hunks": [
{
"added": [
"import java.lang.reflect.Modifier;"
],
"header": "@@ -78,6 +78,7 @@ import org.apache.derby.iapi.sql.execute.ExecutionContext;",
"removed": []
},
{
... |
derby-DERBY-716-83ce7fb7 | DERBY-716: Add test verifying correct behavior of table functions in subqueries with correlated references to outer query blocks.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@587491 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-716-c6c266ba | DERBY-716: Exclude summary row 0 from getFunctionColumns() result for Table Functions.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@564800 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/catalog/GetProcedureColumns.java",
"hunks": [
{
"added": [
"\t\tint functionParamCursor = -2;",
""
],
"header": "@@ -133,6 +133,8 @@ public class GetProcedureColumns extends org.apache.derby.vti.VTITemplate",
... |
derby-DERBY-716-e9ff7be5 | DERBY-716: Prevent table function creation after soft-upgrade, verify with a regression test.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@578452 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-718-11ee500e | DERBY-718 Network client: deleteRow() makes getter methods return nulls for the following rows. Submitted by Fernanda.Pizzorno@Sun.COM
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@348798 13f79535-47bb-0310-9956-ffa450edef68
| [] |
derby-DERBY-721-31f29a4b | - DERBY-721_4 - State of InputStream retrieved from resultset is not clean , if there exists previous InputStream . Patch to throw exception if user get stream for a value in result set twice . by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@357435 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/am/ResultSet.java",
"hunks": [
{
"added": [
" ",
" private boolean[] streamUsedFlags_;",
" "
],
"header": "@@ -188,7 +188,9 @@ public abstract class ResultSet implements java.sql.ResultSet,",
... |
derby-DERBY-721-947123bc | - DERBY-721 State of InputStream retrieved from resultset is not clean , if there exists previous InputStream - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@349079 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/BinaryToRawStream.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.Resetable;",
"import org.apache.derby.iapi.error.StandardException;"
],
"header": "@@ -21,6 +21,8 @@",
"removed": [... |
derby-DERBY-721-ce0c6c47 | - DERBY-721_2 State of Reader retrieved from resultset is not clean , if there exists previous Reader - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@349718 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/UTF8Reader.java",
"hunks": [
{
"added": [
"import org.apache.derby.iapi.types.Resetable;",
"import org.apache.derby.iapi.error.StandardException;",
" ",
" *",
" * If source InputStream of thi... |
derby-DERBY-721-da10c02a | - rollback DERBY-721 and DERBY-721_2 because they will implicitly restrict spec of network driver. - Patch by Tomohito Nakayama (tomonaka@basil.ocn.ne.jp)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@355437 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/jdbc/BinaryToRawStream.java",
"hunks": [
{
"added": [],
"header": "@@ -21,8 +21,6 @@",
"removed": [
"import org.apache.derby.iapi.types.Resetable;",
"import org.apache.derby.iapi.error.StandardException;"
... |
derby-DERBY-728-1451af79 | DERBY-728 subtask DERBY-4757 (Client) Implement UTF8 support on DRDA
(partial) Consolidate references to CcsidManager to facilitate switch from EBCDIC to UTF8
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@987667 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetAgent.java",
"hunks": [
{
"added": [
" NetXAConnectionRequest netXAConnectionRequest_ = new NetXAConnectionRequest(this, netConnection_.commBufferSize_);"
],
"header": "@@ -192,7 +192,7 @@ public class N... |
derby-DERBY-728-802cd1c7 | DERBY-728 Unable to create databases whose name containg Chinese characters through the client driver (partial)
Fix SanityManger usage to be wrapped in if (SanityManager.DEBUG) blocks.
Contrubuted by Tiago R. Espinha ( tiago dot derby at yahoo dot co dot uk )
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@959089 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/Utf8CcsidManager.java",
"hunks": [
{
"added": [
" if (SanityManager.DEBUG) {",
" SanityManager.THROWASSERT(\"Could not convert Java String to byte[] in UTF-8\", e);",
" }"
... |
derby-DERBY-728-cdfb2d18 | DERBY-728 Unable to create databases whose name containg Chinese characters through the client driver
Incremental patches DERBY-728_p2.diff, DERBY-728_p2-test.diff
Add server side UTf8CcsidManager and unit test.
Change names of "convertXXXUCS2" methods to "convertXXXJavaString" for clarification.
UNICODEMGR level negotiation to use the the code has not yet been added.
contributed by Tiago R. Espinha tiago dot derby at yahoo dot co dot uk
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@957580 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/CcsidManager.java",
"hunks": [
{
"added": [
" abstract byte[] convertFromJavaString (String sourceString);"
],
"header": "@@ -44,7 +44,7 @@ abstract class CcsidManager",
"removed": [
" abstract byte[]... |
derby-DERBY-728-df2ca5a3 | DERBY-728 Unable to create databases whose name containg Chinese characters through the client driver
Small cleanup patch to add getters for short and regular datbase name.
Contributed by Tiago Espina (tiago dot derby at yahoo dot com )
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@953058 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/drda/org/apache/derby/impl/drda/DRDAConnThread.java",
"hunks": [
{
"added": [
"\t\t\treturn database.getDatabaseName();"
],
"header": "@@ -421,7 +421,7 @@ class DRDAConnThread extends Thread {",
"removed": [
"\t\t\treturn database.dbN... |
derby-DERBY-728-ffe112b1 | DERBY-4009 (partial) Accommodate length delimited DRDA strings where character length does not equal byte length
Change client RDBNAM, USERID, and PASSWORD to allow for CcsidManager where the byte length might not equal the string length. Right now we just have EbcdicCcsidManager which has a maximum bytes per char as 1. But, this lays the groundwork for UTF8 which will be added later as part of DERBY-728
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@747881 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/client/org/apache/derby/client/net/NetConnectionRequest.java",
"hunks": [
{
"added": [
" ",
" writeScalarString(CodePoint.RDBNAM, rdbnam,",
" NetConfiguration.PKG_IDENTIFIER_FIXED_LEN, //minimum RDBNAM length in bytes",... |
derby-DERBY-729-985f758e | DERBY-729 Scalar time and date functions return 0 instead NULL when argument is NULL. Submitted by Bernt M. Johnsen
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@451147 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/types/SQLDate.java",
"hunks": [
{
"added": [
" NumberDataValue nullValueInt() {",
" return new SQLInteger();",
" }",
"",
" ",
" throws StandardException",
"... |
derby-DERBY-733-9008adea | DERBY-733, committed on behalf of Knut Anders Hatlen.
Attached patch (DERBY-733-more-exception-handling.diff) that addresses
Mike's concerns for exception handling. If something goes wrong when
locking, Derby will now fall back to the old behaviour.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@357275 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java",
"hunks": [
{
"added": [
"\t\t\t\t// couldn't construct the lock, fall back to old behaviour",
"",
"\t\t\t\thasJava5FairLocks = false;"
],
"header": "@@ -148,6 +148,9 @@... |
derby-DERBY-733-a2f90d4f | Fix for DERBY-733. Committed on behalf of Knut Anders Hatlen.
I have attached a patch which invokes ReentrantLock.lock() and
unlock() when reading in a page from disk. I did not build my own
ReentrantLock replacement, as I said I would. Instead, I have used
reflection to enable this feature if the JVM supports it. This seemed
like an easier approach, and I also discovered that the handling of
threads waiting for monitors had changed between 1.4 and 1.5 and that
this issue was not so serious on 1.4.
The maximum response time was drastically reduced in the disk-bound
case. Derbyall ran successfully on both Sun JVM 1.4.2 and 1.5.0. I
have also tested the performance, and I could not see any change in
throughput or CPU usage. (The performance test was run with a very
small page cache and with a database that was many times bigger than
the page cache, but smaller than the file system cache. This way,
Derby called readPage() very often, but it was CPU-bound since the
requested page always was in the file system cache.)
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@356884 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java",
"hunks": [
{
"added": [
"import java.lang.reflect.Method;",
"import java.lang.reflect.Constructor;"
],
"header": "@@ -54,6 +54,8 @@ import java.io.RandomAccessFile;",
"re... |
derby-DERBY-733-f0cd4bf3 | DERBY-801 (partial) Allow parallel access to data files
Backing out the patch for DERBY-733 as it is not needed anymore and
the code is cleaner without it.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@447856 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/impl/store/raw/data/RAFContainer.java",
"hunks": [
{
"added": [],
"header": "@@ -55,8 +55,6 @@ import java.io.RandomAccessFile;",
"removed": [
"import java.lang.reflect.Method;",
"import java.lang.reflect.Constructor;"... |
derby-DERBY-737-da67b78a | DERBY-737: SYSCS_UTIL.SYSCS_COMPRESS_TABLE should create statistics
This patch was contributed by Mamta A. Satoor (msatoor@gmail.com)
The changes have been very localized in
AlterTableConstantAction.java!updateIndex(). Currently, this method checks
if statistics already exist for an index. If yes, then it sets a flag
updateStatistics to true. Later, the code checks for this flag and drops
the existing statistics and creates new statistics for that index provided
the user table at this point is not empty. So, as we can see, if there is
an index with no preexisting statistics, the flag updateStatistics will be
set to false and hence no statistics related code is executed and hence
even though the user table is not empty at the time of compress, no
statistics get generated for such an index.
I am proposing to fix the problem by still using the flag to see if
an index has pre-existing statistics. If yes, then we should drop
those statistics. Next, whether the index has pre-existing statistics or
not, go ahead and create new statistics for the index provided the
user table is not currently empty.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@464551 13f79535-47bb-0310-9956-ffa450edef68
| [
{
"file": "java/engine/org/apache/derby/iapi/db/OnlineCompress.java",
"hunks": [
{
"added": [
" // key column in base row. All offsets are 0 "
],
"header": "@@ -334,7 +334,7 @@ public class OnlineCompress",
"removed": [
... |
derby-DERBY-750-7e95befd | DERBY-750, committing on behalf of Suresh Thalamati.
By looking at the stacks, my suspicion is backup is looking at a table that
is not completely created yet, container file might be there but the
first page (Alloc page) might have been created.
It might take some time for me to fix this one. As a temporary solution,
attached patch comments out the section of the test that might be hitting this
problem.
git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@357272 13f79535-47bb-0310-9956-ffa450edef68
| [] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.