id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
ca8642f606ce22de23bae08a5044067f98de855b
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix off by one in IOMMU check
Problem Details: Fix off by one when checking if the machine has enougn memory to need IOMMU This caused the IOMMUs to be needlessly enabled for mem=4G Based on a patch from Jon Mason Signed-off-by: jdmason@us.ibm.com Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/aperture.c b/arch/x86_64/kernel/aperture.c index c7f4fdd20f05..e4e2b7d01f89 100644 --- a/arch/x86_64/kernel/aperture.c +++ b/arch/x86_64/kernel/aperture.c @@ -23,6 +23,7 @@ #include <asm/io.h> #include <asm/proto.h> #include <asm/pci-direct.h> +#include <asm/dma.h> int iomm...
01b8faaef5d239aeabb1e712c5d9619f29e808dd
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Report hardware breakpoints in user space when triggered by the kernel
Problem Details: I would like to throw out a suggestion for a possible change in the way that the debug register traps are handled in do_debug() when the trap occurs in kernel-mode. In the x86_64 version of do_debug(), the code will skip around sending a SIGTRAP to the current task if the trap occurred while in kernel...
```diff diff --git a/arch/x86_64/kernel/traps.c b/arch/x86_64/kernel/traps.c index 1a9094dab682..8d21d87b0d77 100644 --- a/arch/x86_64/kernel/traps.c +++ b/arch/x86_64/kernel/traps.c @@ -726,11 +726,9 @@ asmlinkage void __kprobes do_debug(struct pt_regs * regs, info.si_signo = SIGTRAP; info.si_errno = 0; info.si_...
79c62cf1789f935280138b412bb750be84aec747
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Make udelay more accurate
Problem Details: The attempt to avoid overflow in __delay caused varying precision on different CPUs depending on differences in the CPU speed. We should be able to do this multiplication with out overflowing provided the cpu is running at less than about 128 GHz. xloops < 20000 * 0x10c6. loops_per_jiffy * HZ <= cpu_...
```diff diff --git a/arch/x86_64/lib/delay.c b/arch/x86_64/lib/delay.c index 841bd738a189..03c460cbdd1c 100644 --- a/arch/x86_64/lib/delay.c +++ b/arch/x86_64/lib/delay.c @@ -39,7 +39,7 @@ void __delay(unsigned long loops) inline void __const_udelay(unsigned long xloops) { - __delay(((xloops * cpu_data[raw_smp_proc...
7a4a76cc1057de0dc96ee481590347aa8c5b9ffb
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix off by one in acpi table mapping
Problem Details: And fix the test to include the size Noticed by Vivek Goyal Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c index 447fa9e33ffb..2111529dea77 100644 --- a/arch/i386/kernel/acpi/boot.c +++ b/arch/i386/kernel/acpi/boot.c @@ -108,7 +108,7 @@ char *__acpi_map_table(unsigned long phys_addr, unsigned long size) if (!phys_addr || !size) return NULL...
7180d4fb83085fef9d24b353f5bd79cf6fd98447
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Fix 64bit FXSAVE encoding
Problem Details: The separation of the rex64 prefix (on fxsave/fxrstor) by way of using a semicolon resulted in the prefix not always taking effect (because when extended registers are needed for addressing, another rex prefix would have been generated by the compiler), thus (depending on the build) resulting in eventu...
```diff diff --git a/include/asm-x86_64/i387.h b/include/asm-x86_64/i387.h index aa39cfd0e001..57f7e1433849 100644 --- a/include/asm-x86_64/i387.h +++ b/include/asm-x86_64/i387.h @@ -75,7 +75,8 @@ extern int set_fpregs(struct task_struct *tsk, static inline int restore_fpu_checking(struct i387_fxsave_struct *fx) { ...
e99286744599a66195de4cd975d7ef4d643c2789
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Generalize DMI and enable for x86-64
Problem Details: Some people need it now on 64bit so reuse the i386 code for x86-64. This will be also useful for future bug workarounds. It is a bit simplified there because there is no need to do it very early on x86-64. This means it doesn't need early ioremap et.al. We run it as a core initcall right now. I hope ...
```diff diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig index 815878ebd30f..81ae9627701d 100644 --- a/arch/i386/Kconfig +++ b/arch/i386/Kconfig @@ -41,6 +41,10 @@ config ARCH_MAY_HAVE_PC_FDC bool default y +config DMI + bool + default y + source "init/Kconfig" menu "Processor type and features" diff --git ...
636dd2b7def5c9c72551b51d4d516a65c269de08
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: fls in asm for x86_64
Problem Details: Use single instruction for find largest set bit on x86_64. [Updated by Jan Beulich to fix wrong asm constraints in original patch -AK] Cc: jbeulich@novell.com Signed-off-by: Stephen Hemminger <shemminger@osdl.org> Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org...
```diff diff --git a/include/asm-x86_64/bitops.h b/include/asm-x86_64/bitops.h index 3638ffff87fd..eb4df23e1e41 100644 --- a/include/asm-x86_64/bitops.h +++ b/include/asm-x86_64/bitops.h @@ -396,6 +396,22 @@ static __inline__ int fls64(__u64 x) return __fls(x) + 1; } +/** + * fls - find last bit set + * @x: the wo...
bd9cb64df1d99c07ea9672661ede6ca3ba5c6579
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: fix page fault from show_trace()
Problem Details: The introduction of call_softirq switching to the interrupt stack several releases earlier resulted in a problem with the code in show_trace, which assumes that it can pick the previous stack pointer from the end of the interrupt stack. Cc: Andi Kleen <ak@muc.de> Cc: Arjan van de Ven <arjanv@redhat.co...
```diff diff --git a/arch/x86_64/kernel/entry.S b/arch/x86_64/kernel/entry.S index 28b3c8e6b044..45e0ab8a1fca 100644 --- a/arch/x86_64/kernel/entry.S +++ b/arch/x86_64/kernel/entry.S @@ -1045,17 +1045,15 @@ ENTRY(call_debug) ENTRY(call_softirq) CFI_STARTPROC movq %gs:pda_irqstackptr,%rax - pushq %r15 - CFI_ADJUST_...
4724e3e86d806860c90917f9b73d4354e388b39b
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: fix single step handling for 32bit processes
Problem Details: Be more careful with TF handling to fix some copy protection codes in wine patch originally for i386 by Linus, then ported to x86_64 by Andi Kleen see: [PATCH] x86_64: Some fixes for single step handling commit: be61bff789fe44bfb6d9282d8f7eccc860bdcfb6 But it was never applied to the ia32 emulation c...
```diff diff --git a/arch/x86_64/ia32/ia32_signal.c b/arch/x86_64/ia32/ia32_signal.c index 0903cc1faef2..e0a92439f634 100644 --- a/arch/x86_64/ia32/ia32_signal.c +++ b/arch/x86_64/ia32/ia32_signal.c @@ -353,7 +353,6 @@ ia32_setup_sigcontext(struct sigcontext_ia32 __user *sc, struct _fpstate_ia32 __ struct pt_regs *...
6e3fbee5f11a8135109b08bfcbc05a29eb4eabe8
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386/x86-64: Don't IPI to offline cpus on shutdown
Problem Details: So why are we calling smp_send_stop from machine_halt? We don't. Looking more closely at the bug report the problem here is that halt -p is called which triggers not a halt but an attempt to power off. machine_power_off calls machine_shutdown which calls smp_send_stop. If pm_power_off is set we sho...
```diff diff --git a/arch/i386/kernel/reboot.c b/arch/i386/kernel/reboot.c index 2fa5803a759d..d207242976d3 100644 --- a/arch/i386/kernel/reboot.c +++ b/arch/i386/kernel/reboot.c @@ -12,6 +12,7 @@ #include <linux/efi.h> #include <linux/dmi.h> #include <linux/ctype.h> +#include <linux/pm.h> #include <asm/uaccess.h> ...
b556b35e98ad2b9174a7a623d152cdf412d1a999
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Move int 3 handler to debug stack and allow to increase it.
Problem Details: This - switches the INT3 handler to run on an IST stack (to cope with breakpoints set by a kernel debugger on places where the kernel's %gs base hasn't been set up, yet); the IST stack used is shared with the INT1 handler's [AK: this also allows setting a kprobe on the interrupt/exception entry p...
```diff diff --git a/arch/x86_64/kernel/asm-offsets.c b/arch/x86_64/kernel/asm-offsets.c index aaa6d3833517..00a08d13230a 100644 --- a/arch/x86_64/kernel/asm-offsets.c +++ b/arch/x86_64/kernel/asm-offsets.c @@ -64,5 +64,9 @@ int main(void) DEFINE(pbe_address, offsetof(struct pbe, address)); DEFINE(pbe_orig_address,...
39b3a7910556005a7a0d042ecb7ff98bfa84ea57
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386/x86-64: Generalize X86_FEATURE_CONSTANT_TSC flag
Problem Details: Define it for i386 too. This is a synthetic flag that signifies that the CPU's TSC runs at a constant P state invariant frequency. Fix up the logic on x86-64/i386 to set it on all known CPUs. Use the AMD defined bit to set it on future AMD CPUs. Cc: venkatesh.pallipadi@intel.com Signed-off-by: Andi...
```diff diff --git a/arch/i386/kernel/cpu/amd.c b/arch/i386/kernel/cpu/amd.c index e7697e077f6b..4397f61705e2 100644 --- a/arch/i386/kernel/cpu/amd.c +++ b/arch/i386/kernel/cpu/amd.c @@ -216,6 +216,11 @@ static void __init init_amd(struct cpuinfo_x86 *c) c->x86_max_cores = 1; } + if (cpuid_eax(0x80000000) >= 0x...
2d52ede9876ba566b583f255fdc43800eea81baa
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Remove enable/disable_hlt
Problem Details: Was only used by the floppy driver to work around some ancient hardware bug that should never occur on any 64bit system. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/process.c b/arch/x86_64/kernel/process.c index 3060ed97b755..c9df991150bb 100644 --- a/arch/x86_64/kernel/process.c +++ b/arch/x86_64/kernel/process.c @@ -55,8 +55,6 @@ asmlinkage extern void ret_from_fork(void); unsigned long kernel_thread_flags = CLONE_VM | CLONE_UNTRACED; ...
f62a91f6911479642c0018290d4248ace4287648
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Don't reserve hotplug CPUs by default
Problem Details: Most users don't need it so no need to waste memory. This means an user has to specify the appropiate number of hotplug CPUs on the command line with additional_cpus=... or fix their BIOS to follow the convention in Documentation/x86-64/cpu-hotplug-spec Signed-off-by: Andi Kleen <ak@suse.de> Signed-of...
```diff diff --git a/Documentation/x86_64/boot-options.txt b/Documentation/x86_64/boot-options.txt index e566affeed7f..72ab9b99b22c 100644 --- a/Documentation/x86_64/boot-options.txt +++ b/Documentation/x86_64/boot-options.txt @@ -125,7 +125,7 @@ SMP cpumask=MASK only use cpus with bits set in mask additional...
1f6818b90dbb887261c616a318733703ed526f0a
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Minor GFP_DMA32 comment fix
Problem Details: Pretty obvious Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 7e4ae6ab1977..34cbefd2ebde 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -98,7 +98,7 @@ struct per_cpu_pageset { /* * On machines where it is needed (eg PCs) we divide physical memory - * into multiple physical zones. ...
0a5215882166dd33a95b313637dd318e4c143113
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: fix bound check IDT gate
Problem Details: Other than apparently commonly assumed, the bound instruction does not require the corresponding IDT entry to have DPL 3. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/kernel/traps.c b/arch/x86_64/kernel/traps.c index bf337f493189..7ecc72a48cdd 100644 --- a/arch/x86_64/kernel/traps.c +++ b/arch/x86_64/kernel/traps.c @@ -881,8 +881,8 @@ void __init trap_init(void) set_intr_gate_ist(1,&debug,DEBUG_STACK); set_intr_gate_ist(2,&nmi,NMI_STACK); set_s...
6e0c47ede7b1473a4e2ab65a0fecf0385ab23c03
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: Separate CONFIG_UNWIND_INFO from CONFIG_DEBUG_INFO
Problem Details: As a follow-up to the introduction of CONFIG_UNWIND_INFO, this separates the generation of frame unwind information for x86-64 from that of full debug information. Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/Makefile b/arch/x86_64/Makefile index 51d83288d62b..2d3e9be229c0 100644 --- a/arch/x86_64/Makefile +++ b/arch/x86_64/Makefile @@ -38,8 +38,10 @@ CFLAGS += -pipe # actually it makes the kernel smaller too. CFLAGS += -fno-reorder-blocks CFLAGS += -Wno-sign-compare -ifneq ($(CONFIG_DEB...
2765130b020c22f803afba74772f33f2ad13bf28
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86_64: More CFI fixes for 32bit entry code
Problem Details: Frame unwind information was still incorrect for ia32_ptregs_common (sorry, my fault), and could be improved for some of the other entry points. Signed-Off-By: Jan Beulich <jbeulich@novell.com> Signed-off-by: Andi Kleen <ak@suse.de> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/x86_64/ia32/ia32entry.S b/arch/x86_64/ia32/ia32entry.S index 2ff07b47ea9c..8172e61c3f6f 100644 --- a/arch/x86_64/ia32/ia32entry.S +++ b/arch/x86_64/ia32/ia32entry.S @@ -35,6 +35,18 @@ movq %rax,R8(%rsp) .endm + .macro CFI_STARTPROC32 simple + CFI_STARTPROC \simple + CFI_UNDEFINED r8 + CF...
eb3a72921c8276bf2cd028a458bb83435f16c91c
Analyze and fix the following issue in the Linux kernel code: [PATCH] kprobes: fix race in recovery of reentrant probe
Problem Details: There is a window where a probe gets removed right after the probe is hit on some different cpu. In this case probe handlers can't find a matching probe instance related to break address. In this case we need to read the original instruction at break address to see if that is not a break/int3 instruc...
```diff diff --git a/arch/i386/kernel/kprobes.c b/arch/i386/kernel/kprobes.c index 2f372dbd34fd..6483eeb1a4e8 100644 --- a/arch/i386/kernel/kprobes.c +++ b/arch/i386/kernel/kprobes.c @@ -188,6 +188,19 @@ static int __kprobes kprobe_handler(struct pt_regs *regs) kcb->kprobe_status = KPROBE_REENTER; return 1; ...
df019b1d8b893d0f0ee5a9b0f71486f0892561ae
Analyze and fix the following issue in the Linux kernel code: [PATCH] kprobes: fix unloading of self probed module
Problem Details: When a kprobes modules is written in such a way that probes are inserted on itself, then unload of that moudle was not possible due to reference couning on the same module. The below patch makes a check and incrementes the module refcount only if it is not a self probed module. We need to allow modul...
```diff diff --git a/include/linux/kprobes.h b/include/linux/kprobes.h index 10005bc92a31..669756bc20a2 100644 --- a/include/linux/kprobes.h +++ b/include/linux/kprobes.h @@ -68,6 +68,9 @@ struct kprobe { /* list of kprobes for multi-handler support */ struct list_head list; + /* Indicates that the corresponding ...
ef43bc4fc32bec8fda7bae8948b774616dc9e496
Analyze and fix the following issue in the Linux kernel code: [PATCH] reiserfs: fix assertion failure in reiserfs+journaled quotas
Problem Details: Sometimes we call do_journal_end() with t_refcount == 0. If quota is turned on and we happen to have some inode with preallocation bad things happen as we try to use the current handle for quota operations. Checks for t_refcount in journal_begin() fail and we Oops. We raise t_refcount to make those ...
```diff diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index 3f17ef844fb6..4491fcf2a0e6 100644 --- a/fs/reiserfs/journal.c +++ b/fs/reiserfs/journal.c @@ -3925,10 +3925,13 @@ static int do_journal_end(struct reiserfs_transaction_handle *th, flush = 1; } #ifdef REISERFS_PREALLOCATE - /* quota ops might...
9e9e3941d0a3497c1e7fb9ce62059705825bb775
Analyze and fix the following issue in the Linux kernel code: [PATCH] kdump: vmcore compilation warning fix
Problem Details: o fs/proc/vmcore.c compilation gives warnings on ppc64. The reason being that u64 is defined as unsigned long hence u64* is not same as loff_t* and compiler cribs. o Changed the parameter type to u64* instead of loff_t* to resolve the conflict. Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Sig...
```diff diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index 124e35442ac8..4063fb32f78c 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -41,7 +41,7 @@ struct proc_dir_entry *proc_vmcore = NULL; /* Reads a page from the oldmem device from given offset. */ static ssize_t read_from_oldmem(char *buf, size_t c...
fd85d765b75db608500c783e5bc41b63627957c8
Analyze and fix the following issue in the Linux kernel code: [PATCH] cs89x0: Fix the Kconfig help text
Problem Details: Fix the help text of the cs89x0 network driver Kconfig entry. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index ef47edc15081..5c15f3e9ea07 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -1397,7 +1397,7 @@ config CS89x0 To compile this driver as a module, choose M here and read <file:Documentation/networking/net-modules.txt>. The module...
91e1c46356beddf984ce0ce5ec4fbaea43a07ec8
Analyze and fix the following issue in the Linux kernel code: [PATCH] cs89x0: fix setting of ALLOW_DMA
Problem Details: There's an ifdef in cs89x0.c that seems to have been the wrong way round since it was merged (and noone seems to have noticed) -- the IXDP2x01 doesn't support ISA-style DMA, but when building for IXDP2x01, cs89x0's ALLOW_DMA is set to 1, and when building for another platform, ALLOW_DMA is set to 0. S...
```diff diff --git a/drivers/net/cs89x0.c b/drivers/net/cs89x0.c index 907c01009746..e2cfde7e31ec 100644 --- a/drivers/net/cs89x0.c +++ b/drivers/net/cs89x0.c @@ -100,7 +100,7 @@ * Note that even if DMA is turned off we still support the 'dma' and 'use_dma' * module options so we don't break any startup scripts. ...
4ab2495a30bb3de1cfe41a886f83afb68616ab7d
Analyze and fix the following issue in the Linux kernel code: [PATCH] tclk: fix typos, exclamation mark frenzy and missing device id on messages
Problem Details: I sent this out a couple of months ago and the driver author said it he'd merge it. Nothing has happened since so I'm submitting it directly. No functionality changes just texts. Signed-off-by: Alan Cox <alan@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torv...
```diff diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index 12167c04fa4c..bc56df8a3474 100644 --- a/drivers/char/tlclk.c +++ b/drivers/char/tlclk.c @@ -211,7 +211,7 @@ static int tlclk_open(struct inode *inode, struct file *filp) result = request_irq(telclk_interrupt, &tlclk_interrupt, SA_INTERRUP...
e56d5ae305b9be17edfee20740ec84257e518747
Analyze and fix the following issue in the Linux kernel code: [PATCH] ext3: fix documentation of online resizing
Problem Details: Undocument the non-working resize= mount option in ext3, and add some references to the ext2resize package instead, which appears to be the only proper way of doing online resizing of ext3 filesystems. Signed-off-by: Tore Anderson <tore@fud.no> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-b...
```diff diff --git a/Documentation/filesystems/ext3.txt b/Documentation/filesystems/ext3.txt index f4d0de6bac63..afb1335c05d6 100644 --- a/Documentation/filesystems/ext3.txt +++ b/Documentation/filesystems/ext3.txt @@ -84,8 +84,6 @@ reservation noreservation -resize= - bsddf (*) Make 'df' act like BSD. minixdf...
621009f4baf24581211dbb7b0816e01ed9fa8496
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix debug output on x86_64
Problem Details: The debug-stub patch was broken on x86_64 because it thinks the frame size there is 168 words. In reality, it is 168 bytes, and using HOST_FRAME_SIZE, which is expressed in consistent units across architectures, fixes this. Signed-off-by: Jeff Dike <jdike@addtoit.com> Signed-off-by: Andrew Morton <ak...
```diff diff --git a/arch/um/kernel/skas/process.c b/arch/um/kernel/skas/process.c index 9264d4021dfe..3b3955d84407 100644 --- a/arch/um/kernel/skas/process.c +++ b/arch/um/kernel/skas/process.c @@ -68,7 +68,7 @@ void wait_stub_done(int pid, int sig, char * fname) if((n < 0) || !WIFSTOPPED(status) || ...
4ee189a9260849ebacbdd3caf1fd5eb077fcf6a9
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix missing KBUILD_BASENAME
Problem Details: 2.6.15-mm1 caused kernel-offsets.c to stop compiling with a syntax error in a header. The problem was with KBUILD_BASENAME, which didn't get a definition with the by-hand compilation in the main UML Makefile. This was OK before since the expansion was syntactically the same as the KBUILD_BASENAME tok...
```diff diff --git a/arch/um/Makefile b/arch/um/Makefile index 1b12feeba368..322972fd064e 100644 --- a/arch/um/Makefile +++ b/arch/um/Makefile @@ -189,6 +189,12 @@ define filechk_umlconfig sed 's/ CONFIG/ UML_CONFIG/' endef +$(ARCH_DIR)/include/uml-config.h : include/linux/autoconf.h + $(call filechk,umlconfig) + ...
a113bc787e9b0e792f316e803b619d31af1397ad
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3352): Some fixes to compat_ioctl32
Problem Details: - Adds suppport or fix support for VIDIOC_ENUMSTD, VIDIOC_ENUMINPUT, VIDIOC_G_TUNER and VIDIOC_S_TUNER. - Fix the warnings at compile time and add checks for the pointer validity using access_ok(). - v4l_print_ioctl() has also be added to identify possible missing ioctls. - Has been tested on sparc64 a...
```diff diff --git a/drivers/media/video/compat_ioctl32.c b/drivers/media/video/compat_ioctl32.c index 6194b0125576..297c32ab51e3 100644 --- a/drivers/media/video/compat_ioctl32.c +++ b/drivers/media/video/compat_ioctl32.c @@ -18,8 +18,11 @@ #include <linux/videodev2.h> #include <linux/module.h> #include <linux/smp_...
b5fc71440f63f653d86c75c2930fe22ad84c909d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3348): debug renamed to cx25840_debug
Problem Details: - Debug var renamed to cx25840 to avoid conflicts with other var with the same name at kernel Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c index 847b166d8b15..1d75a42629d1 100644 --- a/drivers/media/video/cx25840/cx25840-core.c +++ b/drivers/media/video/cx25840/cx25840-core.c @@ -43,9 +43,9 @@ MODULE_LICENSE("GPL"); static unsigned short normal_i2...
bb7e8c5a55c1f5d4192f4b61a84a791796ebf0c3
Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED] net/sched/Kconfig: fix typo in NET_EMATCH_META description
Problem Details: Noted by Matt LaPlante <webmaster@cyberdogtech.com>. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/sched/Kconfig b/net/sched/Kconfig index 55cd5327fbd7..8a260d43ceef 100644 --- a/net/sched/Kconfig +++ b/net/sched/Kconfig @@ -411,7 +411,7 @@ config NET_EMATCH_META tristate "Metadata" depends on NET_EMATCH ---help--- - Say Y here if you want to be ablt to classify packets based on + ...
c3f343e4d7b99638b8a4f05c12b542d32405cfc4
Analyze and fix the following issue in the Linux kernel code: [NET]: Fix diverter build.
Problem Details: Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/core/dv.c b/net/core/dv.c index c5deb3655257..1516a90a138d 100644 --- a/net/core/dv.c +++ b/net/core/dv.c @@ -457,7 +457,7 @@ void divert_frame(struct sk_buff *skb) unsigned char *skb_data_end = skb->data + skb->len; /* Packet is already aimed at us, return */ - if (!compare_ether_addr(...
ae0f7d5f83236a43c572a744e4bbb30e8702d821
Analyze and fix the following issue in the Linux kernel code: [IPV6]: Avoid calling ip6_xmit() with NULL sk
Problem Details: The ip6_xmit() function now assumes that its sk argument is non-NULL, which isn't currently true when TCPv6 code is sending RST or ACK packets. This fixes that code to use a socket of its own for sending such packets, as TCPv4 does. (Thanks Andi for the pointer). Signed-off-by: David Woodhouse <dwmw2@...
```diff diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index a25f4e8a8ada..66d04004afda 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -67,6 +67,9 @@ #include <linux/proc_fs.h> #include <linux/seq_file.h> +/* Socket used for sending RSTs and ACKs */ +static struct socket *tcp6_socket; + stat...
607f4e3864a4306be0d0ad11ff34284c239aad1b
Analyze and fix the following issue in the Linux kernel code: [PATCH] new tty buffering access fix
Problem Details: Fix typos in new tty buffering that incorrectly access and update buffers in pending queue. Signed-off-by: Paul Fulghum <paulkf@microgate.com> Acked-by: Alan Cox <alan@redhat.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 1eda82b31a61..eb8b5be4e249 100644 --- a/drivers/char/tty_io.c +++ b/drivers/char/tty_io.c @@ -312,7 +312,7 @@ static struct tty_buffer *tty_buffer_find(struct tty_struct *tty, size_t size) int tty_buffer_request_room(struct tty_struct *tty, siz...
61943c5015acae42fe355bf033bbee8d63691fe3
Analyze and fix the following issue in the Linux kernel code: [SPARC64] arch/sparc64/Kconfig: fix HUGETLB_PAGE_SIZE_64K dependencies
Problem Details: This patch fixes a typo in the dependencies of HUGETLB_PAGE_SIZE_64K. It might be more logical to rename the HUGETLB_PAGE_SIZE_*K dependencies to HUGETLB_PAGE_SIZE_*KB, but let's fix this bug first. This bug was reported by Jean-Luc Leger <reiga@dspnet.fr.eu.org>. Signed-off-by: Adrian Bunk <bunk@st...
```diff diff --git a/arch/sparc64/Kconfig b/arch/sparc64/Kconfig index b775ceb4cf98..ab733be9af08 100644 --- a/arch/sparc64/Kconfig +++ b/arch/sparc64/Kconfig @@ -179,7 +179,7 @@ config HUGETLB_PAGE_SIZE_512K bool "512K" config HUGETLB_PAGE_SIZE_64K - depends on !SPARC64_PAGE_SIZE_4MB && !SPARC64_PAGE_SIZE_512K + ...
4cec87361462d570d6a67888feda41e77e0a9562
Analyze and fix the following issue in the Linux kernel code: Fix mutex_trylock() copy-and-paste bug (x86, x86-64, generic mutex-dec.h)
Problem Details: Noticed by Arjan originally on x86-64, then Ingo on x86, and finally me grepping for it in the generic version. Bad parenthesis nesting. Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-generic/mutex-dec.h b/include/asm-generic/mutex-dec.h index 74b18cda169f..40c6d1f86598 100644 --- a/include/asm-generic/mutex-dec.h +++ b/include/asm-generic/mutex-dec.h @@ -97,7 +97,7 @@ __mutex_fastpath_trylock(atomic_t *count, int (*fail_fn)(atomic_t *)) * the mutex state would be...
0d1335b3106687d87fcfa0e4d90f2a961bd7e1db
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix follow_link when dealing with symlinks larger than 256 bytes.
Problem Details: Thanks to Yamamoto Takashi. SGI-PV: 947953 SGI-Modid: xfs-linux-melb:xfs-kern:24962a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index d388d14efe3e..129403958044 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c @@ -546,7 +546,7 @@ linvfs_follow_link( ASSERT(dentry); ASSERT(nd); - link = (char *)kmalloc(MAXNAMELEN+1, GFP_KERNEL); + link ...
f9195ded25a4e8fba09c67aa24b42cd98a242d7d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3347): Fixes some bad global variables
Problem Details: - Debug global var is already used inside kernel, so renamed debug to tuner_debug for the tuner module Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
```diff diff --git a/drivers/media/video/mt20xx.c b/drivers/media/video/mt20xx.c index 2c19c9588c02..0bf1caac5887 100644 --- a/drivers/media/video/mt20xx.c +++ b/drivers/media/video/mt20xx.c @@ -21,7 +21,7 @@ static unsigned int radio_antenna = 0; module_param(radio_antenna, int, 0644); /* from tuner-core.c */ ...
d4437d3fada351d7f40bcc48a62c12b92e2ad9d8
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3344b): don't ignore return from i2c_add_driver() for tuner-3036
Problem Details: The call to i2c_add_driver() may actually fail, but tuner-3036 ignores this and always returns 0, regardless. Fix it up so it returns what i2c_add_driver() does, instead. Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Mauro Carvalho Ch...
```diff diff --git a/drivers/media/video/tuner-3036.c b/drivers/media/video/tuner-3036.c index d97f66804c37..c4a78e7a5a58 100644 --- a/drivers/media/video/tuner-3036.c +++ b/drivers/media/video/tuner-3036.c @@ -193,8 +193,7 @@ static struct i2c_client client_template = static int __init tuner3036_init(void) { - i2c_...
a4fc7ab1d065a9dd89ed0e74439ef87d4a16e980
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix/simplify mutex debugging code
Problem Details: Let's switch mutex_debug_check_no_locks_freed() to take (addr, len) as arguments instead, since all its callers were just calculating the 'to' address for themselves anyway... (and sometimes doing so badly). Signed-off-by: David Woodhouse <dwmw2@infradead.org> Acked-by: Ingo Molnar <mingo@elte.hu> Sig...
```diff diff --git a/arch/i386/mm/pageattr.c b/arch/i386/mm/pageattr.c index e8a53552b13d..d0cadb33b54c 100644 --- a/arch/i386/mm/pageattr.c +++ b/arch/i386/mm/pageattr.c @@ -224,7 +224,7 @@ void kernel_map_pages(struct page *page, int numpages, int enable) return; if (!enable) mutex_debug_check_no_locks_freed(...
6ab65429b4871c42bfd0013f7f5e49d40c0642cd
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix compiler warnings from older gcc versions wrt printfalike
Problem Details: arguments. SGI-PV: 907752 SGI-Modid: xfs-linux-melb:xfs-kern:24901a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c index d72c83d22ee0..5c6d873e292c 100644 --- a/fs/xfs/xfs_iomap.c +++ b/fs/xfs/xfs_iomap.c @@ -551,8 +551,10 @@ xfs_iomap_write_direct( "extent-state : %x \n", (ip->i_mount)->m_fsname, ...
ca5ccbf98d792d8727e893765cc2df479ba399f2
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix some build fallout from atime changes.
Problem Details: SGI-PV: 946679 SGI-Modid: xfs-linux-melb:xfs-kern:24899a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_vnode.h b/fs/xfs/linux-2.6/xfs_vnode.h index f2bbb327c081..0fe2419461d6 100644 --- a/fs/xfs/linux-2.6/xfs_vnode.h +++ b/fs/xfs/linux-2.6/xfs_vnode.h @@ -565,6 +565,25 @@ static inline int VN_BAD(struct vnode *vp) return is_bad_inode(LINVFS_GET_IP(vp)); } +/* + * Extracting...
1259845d3f3e1d1cf96b2a78f3aec824b9d1e109
Analyze and fix the following issue in the Linux kernel code: [XFS] remove XFS_LOG_RES_DEBUG and turn on the res history all the time to
Problem Details: get more useful error info on space for trans items SGI-PV: 947110 SGI-Modid: xfs-linux-melb:xfs-kern:24886a Signed-off-by: Tim Shimmin <tes@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index f6bac20af7aa..3d9a36e77363 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -1591,7 +1591,6 @@ xlog_state_finish_copy(xlog_t *log, * print out info relating to regions written which consume * the reservation */ -#if defined(XFS_LOG_RES_DEBUG) ...
71df099dc3f9cd17e8564eb647d7c1fb2ee83e2d
Analyze and fix the following issue in the Linux kernel code: [XFS] xfssyncd is responsible for flushing inode or device's data by
Problem Details: extracting the work from its queue. In addition, this processing also decrement the inode's i_count. If there are any remaining works in queue before this process terminates, we have unbalanced increment and decrement of i_count. Thus it can cause assertion failure of vn_count. The fix allows xyssyncd ...
```diff diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c index 556c1437b17d..f22e426d9e42 100644 --- a/fs/xfs/linux-2.6/xfs_super.c +++ b/fs/xfs/linux-2.6/xfs_super.c @@ -579,7 +579,7 @@ xfssyncd( timeleft = schedule_timeout_interruptible(timeleft); /* swsusp */ try_to_freeze(); - if (...
204ab25f36fbd44a24458c0227cf2629c8caf00d
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix up offset type inconsistencies and gcc warnings from earlier
Problem Details: changes. SGI-PV: 947038 SGI-Modid: xfs-linux-melb:xfs-kern:24875a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c index 6282f034b269..e44b7c1a3a36 100644 --- a/fs/xfs/linux-2.6/xfs_buf.c +++ b/fs/xfs/linux-2.6/xfs_buf.c @@ -223,7 +223,7 @@ STATIC void _xfs_buf_initialize( xfs_buf_t *bp, xfs_buftarg_t *target, - loff_t range_base, + xfs_off_t ran...
da7f93e9eec0885317351eb8a20cc550ed48f470
Analyze and fix the following issue in the Linux kernel code: [XFS] fix up per-device xfsbufd
Problem Details: SGI-PV: 947098 SGI-Modid: xfs-linux-melb:xfs-kern:203831a Signed-off-by: Christoph Hellwig <hch@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c index cb77f99cbef1..6282f034b269 100644 --- a/fs/xfs/linux-2.6/xfs_buf.c +++ b/fs/xfs/linux-2.6/xfs_buf.c @@ -1649,14 +1649,13 @@ xfsbufd_wakeup( int priority, gfp_t mask) { - xfs_buftarg_t *btp, *n; + xfs_buftarg_t *btp; spin_l...
f5e596bbef3b0fa583c66c5a83dc9737c0fe2610
Analyze and fix the following issue in the Linux kernel code: [XFS] fix writeback control handling fix a reversed condition on where to
Problem Details: trylock and deal with block layer congestion properly. Patch from David Chinner and Christoph Hellwig. SGI-PV: 947118 SGI-Modid: xfs-linux-melb:xfs-kern:203830a Signed-off-by: Christoph Hellwig <hch@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index 9ea33ea6a225..52707b5ddcb8 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c @@ -722,8 +722,17 @@ xfs_convert_page( SetPageUptodate(page); if (startio) { - if (count) - wbc->nr_to_write--; + if (coun...
9260dc6b2ee011f728bae50edce11022567be096
Analyze and fix the following issue in the Linux kernel code: [XFS] various fixes for xfs_convert_page fix various bogusities in
Problem Details: handling offets From David Chinner and Christoph Hellwig SGI-PV: 947118 SGI-Modid: xfs-linux-melb:xfs-kern:203826a Signed-off-by: Christoph Hellwig <hch@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index b306e25f0f07..64c909e5c1e5 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c @@ -624,12 +624,13 @@ xfs_convert_page( int all_bh) { struct buffer_head *bh, *head; - unsigned long p_offset, end_offset; + ...
886c98d78652f78a64cb21516d3b25ffd5c05e94
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: Fix clean_files in arch/powerpc/boot Makefile
Problem Details: clean-files was being set twice rather than being appended to. Signed-off-by: Kumar Gala <galak@kernel.crashing.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index 22726aefc8ea..b53d677f6742 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -176,4 +176,4 @@ $(obj)/uImage: $(obj)/vmlinux.gz install: $(CONFIGURE) $(BOOTIMAGE) sh -x $(srctree)/$(src)/install.sh "$(KERNELRE...
c38a04b1ba67e488d94ec680a7dddd4e32d6ddfb
Analyze and fix the following issue in the Linux kernel code: powerpc/32: Fix compile error caused by pud_t/pgt_t confusion
Problem Details: PPC32 is still using asm-generic/4level-fixup.h, but asm-powerpc/page.h was defining pud_t and pgd_t. Depending on the order in which files got included, this could result in a compilation error. Tweak the ifdef so that page.h doesn't try to define pud_t on ppc32 (which uses 2-level page tables). Si...
```diff diff --git a/include/asm-powerpc/page.h b/include/asm-powerpc/page.h index 76d7cb4b4ffc..0b82df483f7f 100644 --- a/include/asm-powerpc/page.h +++ b/include/asm-powerpc/page.h @@ -178,7 +178,7 @@ typedef unsigned long pmd_t; #define pmd_val(x) (x) #define __pmd(x) (x) -#ifndef CONFIG_PPC_64K_PAGES +#if defin...
d274ba2081cce6ff59f94e608a348f20ba1fe775
Analyze and fix the following issue in the Linux kernel code: x86: fix "make install" target
Problem Details: Removing the dependency on the boot image build was good, but it also meant that the $< expansion by make needed to be done explicitly. Noted by Stephen Hemminger. Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/i386/boot/Makefile b/arch/i386/boot/Makefile index 0fea75dd4e31..f136752563b1 100644 --- a/arch/i386/boot/Makefile +++ b/arch/i386/boot/Makefile @@ -101,4 +101,4 @@ zlilo: $(BOOTIMAGE) if [ -x /sbin/lilo ]; then /sbin/lilo; else /etc/lilo/install; fi install: - sh $(srctree)/$(src)/instal...
5bf887f2ff874e2cd881c34bbed974bee2c90808
Analyze and fix the following issue in the Linux kernel code: [IPV6]: Fix modular build with netfilter enabled.
Problem Details: Also, drop __exit marker from ipv6_netfilter_fini() as this can be invoked from inet6_init() error handling paths. Based upon a report from Stephen Hemminger. Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/ipv6/Makefile b/net/ipv6/Makefile index bf18cff13120..41877abd22e6 100644 --- a/net/ipv6/Makefile +++ b/net/ipv6/Makefile @@ -12,13 +12,14 @@ ipv6-objs := af_inet6.o anycast.o ip6_output.o ip6_input.o addrconf.o sit.o \ ipv6-$(CONFIG_XFRM) += xfrm6_policy.o xfrm6_state.o xfrm6_input.o \ xf...
68bdb6eabcd2869caa795019961a5445a11b5bc1
Analyze and fix the following issue in the Linux kernel code: [XFS] Fixed delayed_blks assert failure during umount. The delayed_blks
Problem Details: was caused by ENOSPC but not Rreclaimed by xfs_release or xfs_inactive. The fix changed the condition in xfs_release and xfs_inactive to invoke xfs_inactive_free_eofblocks for this special case, changed xfs_inactive_free_eofblocks to clean the delayed blks after eof. It also changed xfs_write to set co...
```diff diff --git a/fs/xfs/linux-2.6/xfs_lrw.c b/fs/xfs/linux-2.6/xfs_lrw.c index 563cb9e975d2..147a28861f6b 100644 --- a/fs/xfs/linux-2.6/xfs_lrw.c +++ b/fs/xfs/linux-2.6/xfs_lrw.c @@ -809,6 +809,10 @@ retry: goto retry; } + isize = i_size_read(inode); + if (unlikely(ret < 0 && ret != -EFAULT && *offset > isiz...
a6867a6815fa0241848d4620f2dbd2954f4405d7
Analyze and fix the following issue in the Linux kernel code: [XFS] Introduce per-filesystem delwri pagebuf flushing to reduce
Problem Details: contention between filesystems and prevent deadlocks between filesystems when a flush dependency exists between them. SGI-PV: 947098 SGI-Modid: xfs-linux-melb:xfs-kern:24844a Signed-off-by: David Chinner <dgc@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_buf.c b/fs/xfs/linux-2.6/xfs_buf.c index 6fe21d2b8847..2a8acd38fa1e 100644 --- a/fs/xfs/linux-2.6/xfs_buf.c +++ b/fs/xfs/linux-2.6/xfs_buf.c @@ -33,6 +33,7 @@ STATIC kmem_cache_t *pagebuf_zone; STATIC kmem_shaker_t pagebuf_shake; +STATIC int xfsbufd(void *); STATIC int xfs...
60a204f096dd67683f3993798e14905ee9828ba5
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix a thinko when generating a forced shutdown stack trace.
Problem Details: SGI-PV: 929558 SGI-Modid: xfs-linux-melb:xfs-kern:203817a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index 2eb6027762f2..d3d714e6b32a 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c @@ -1027,10 +1027,10 @@ xfs_trans_cancel( * filesystem. This happens in paths where we detect * corruption and decide to give up. */ - if ((tp->t_flags & XFS_T...
77a7cce42509461067f49c484aee626f62162fbc
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix quotaoff logitem for project quota, affects log recovery only.
Problem Details: SGI-PV: 946444 SGI-Modid: xfs-linux-melb:xfs-kern:24768a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c index d0c9fc4fed60..7d46cbd6a07a 100644 --- a/fs/xfs/xfs_log_recover.c +++ b/fs/xfs/xfs_log_recover.c @@ -2562,10 +2562,12 @@ xlog_recover_do_quotaoff_trans( /* * The logitem format's flag tells us if this was user quotaoff, - * group quot...
c2cd2550603d847b709035c4c6b666adf560d7b8
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix v2 log bufsize reporting in /proc/mounts.
Problem Details: SGI-PV: 946760 SGI-Modid: xfs-linux-melb:xfs-kern:24765a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_vfsops.c b/fs/xfs/xfs_vfsops.c index f22bebf8f513..b6ad370fab3d 100644 --- a/fs/xfs/xfs_vfsops.c +++ b/fs/xfs/xfs_vfsops.c @@ -333,10 +333,11 @@ xfs_finish_flags( /* Fail a mount where the logbuf is smaller then the log stripe */ if (XFS_SB_VERSION_HASLOGV2(&mp->m_sb)) { - if ((ap...
42fe2b1f7fe788ed5304a7bfa0a0b0db81bc03a8
Analyze and fix the following issue in the Linux kernel code: [XFS] fix, speedup and simplify atime handling let the VFS handle atime
Problem Details: updates and only sync back to the xfs inode when nessecary SGI-PV: 946679 SGI-Modid: xfs-linux-melb:xfs-kern:203362a Signed-off-by: Christoph Hellwig <hch@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/linux-2.6/xfs_iops.c b/fs/xfs/linux-2.6/xfs_iops.c index 97fb1470cf28..8fd274fc26d5 100644 --- a/fs/xfs/linux-2.6/xfs_iops.c +++ b/fs/xfs/linux-2.6/xfs_iops.c @@ -57,6 +57,24 @@ #define IS_NOATIME(inode) ((inode->i_sb->s_flags & MS_NOATIME) || \ (S_ISDIR(inode->i_mode) && inode->i_sb->s_f...
f6cc82fc0b2b6be9ab25f0bfc285e6358db3597a
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: fix for compile problem in kdump code when SMP disabled
Problem Details: This patch fixes the compilation error (shown below) when CONFIG_SMP=n. arch/powerpc/kernel/crash.c: In function `crash_kexec_prepare_cpus': arch/powerpc/kernel/crash.c:236: error: implicit declaration of function `smp_release_cpus' Signed-off-by: Haren Myneni <haren@us.ibm.com> Signed-off...
```diff diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index 4681155121ef..5f248e3fdf82 100644 --- a/arch/powerpc/kernel/crash.c +++ b/arch/powerpc/kernel/crash.c @@ -18,7 +18,6 @@ #include <linux/kexec.h> #include <linux/bootmem.h> #include <linux/crash_dump.h> -#include <linux/irq.h> #incl...
ee2a4f7caa4a72cdf2329081a1f7eb9939df3aab
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix an intermittent pquota panic caused by dodgey quota flags to an
Problem Details: umount dquot flush call. SGI-PV: 946444 SGI-Modid: xfs-linux-melb:xfs-kern:24680a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/quota/xfs_qm.c b/fs/xfs/quota/xfs_qm.c index c04c34776c43..7dcdd0640c32 100644 --- a/fs/xfs/quota/xfs_qm.c +++ b/fs/xfs/quota/xfs_qm.c @@ -1920,9 +1920,7 @@ xfs_qm_quotacheck( * at this point (because we intentionally didn't in dqget_noattach). */ if (error) { - xfs_qm_dqpurge_all(m...
6bac953fa424519f784ba2589fefd8f040ce54f0
Analyze and fix the following issue in the Linux kernel code: powerpc: Fix compile error when CONFIG_PROC_VMCORE is not defined
Problem Details: We were getting elfcorehdr_addr undefined in this case. Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/kernel/crash_dump.c b/arch/powerpc/kernel/crash_dump.c index 87effa3f21a7..211d72653ea6 100644 --- a/arch/powerpc/kernel/crash_dump.c +++ b/arch/powerpc/kernel/crash_dump.c @@ -55,6 +55,7 @@ void __init kdump_setup(void) DBG(" <- kdump_setup()\n"); } +#ifdef CONFIG_PROC_VMCORE st...
1661dc8e7a2c6aeb8f2fb6a8197909c95c220a71
Analyze and fix the following issue in the Linux kernel code: [XFS] Fixed an assertion failure in xfs_reclaim caused by delayed block.
Problem Details: The assertion failure came from XFS QA41. The fix is done by enabling truncate for delayed block in xfs_inactive. SGI-PV: 945412 SGI-Modid: xfs-linux-melb:xfs-kern:202521a Signed-off-by: Yingping Lu <yingping@sgi.com> Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index a2b422c984f2..f6aed9ef6a61 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c @@ -1612,7 +1612,8 @@ xfs_inactive( * only one with a reference to the inode. */ truncate = ((ip->i_d.di_nlink == 0) && - ((ip->i_d.di_size != 0)...
70a061f1fdbfa4805233a113868d059e9614731a
Analyze and fix the following issue in the Linux kernel code: [XFS] Fix typo from when enabling write barriers by default, flags botch
Problem Details: in showargs. SGI-PV: 912426 SGI-Modid: xfs-linux-melb:xfs-kern:24383a Signed-off-by: Nathan Scott <nathans@sgi.com>
```diff diff --git a/fs/xfs/xfs_vfsops.c b/fs/xfs/xfs_vfsops.c index 3406399e25b3..e344906bdcbb 100644 --- a/fs/xfs/xfs_vfsops.c +++ b/fs/xfs/xfs_vfsops.c @@ -1924,36 +1924,30 @@ xfs_showargs( if (mp->m_logbufs > 0) seq_printf(m, "," MNTOPT_LOGBUFS "=%d", mp->m_logbufs); - if (mp->m_logbsize > 0) seq_printf...
415c2e083a85f0daf6cbb4988691ac3ea9279509
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: fix up iSeries console after TTY layer buffering revamp
Problem Details: Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/drivers/char/viocons.c b/drivers/char/viocons.c index bead38a4a68a..faee5e7acaf7 100644 --- a/drivers/char/viocons.c +++ b/drivers/char/viocons.c @@ -904,6 +904,7 @@ static void vioHandleData(struct HvLpEvent *event) struct viocharlpevent *cevent = (struct viocharlpevent *)event; struct port_in...
7a0268fa1a3613f2c526a9b3058701b277f6abe1
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc/64: per cpu data optimisations
Problem Details: The current ppc64 per cpu data implementation is quite slow. eg: lhz 11,18(13) /* smp_processor_id() */ ld 9,.LC63-.LCTOC1(30) /* per_cpu__variable_name */ ld 8,.LC61-.LCTOC1(30) /* __per_cpu_offset */ sldi 11,11,3 /* form index into __per_cpu_off...
```diff diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index 0420418f317a..e29b275e09e0 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c @@ -33,6 +33,7 @@ #include <linux/unistd.h> #include <linux/serial.h> #include <linux/serial_8250.h> +#include <linux/...
193cac99f6d8604aca71e5a966a8cd1dfb84819d
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: parallel port init fix
Problem Details: This stops parport from accessing nonexistent parallel ports. Signed-off-by: Michael Neuling <mikey@neuling.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/include/asm-powerpc/parport.h b/include/asm-powerpc/parport.h index 897e49a88a6b..3fca21ddf546 100644 --- a/include/asm-powerpc/parport.h +++ b/include/asm-powerpc/parport.h @@ -10,10 +10,34 @@ #define _ASM_POWERPC_PARPORT_H #ifdef __KERNEL__ -static int __devinit parport_pc_find_isa_ports (int...
296167ae1799815b9ed2d135a847436502f2ee91
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: Make early debugging configurable via Kconfig
Problem Details: This patch adds Kconfig entries to control the early debugging options, currently in setup_64.c. Doing this via Kconfig rather than #defines means you can have one source tree, which is buildable for multiple platforms - and you can enable the correct early debug option for each platform via .config. ...
```diff diff --git a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug index 30a30bf559ea..9254806f7032 100644 --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -115,4 +115,46 @@ config PPC_OCP depends on IBM_OCP || XILINX_OCP default y +choice + prompt "Early debugging (dangerous)" + boo...
f481f1edee77b3d623457685add1c6b507c25d6f
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: remove remaining crash_notes variable from machine_kexec.c
Problem Details: remove remaining crash_notes definition to fix compile error /dev/shm/linux-2.6/arch/powerpc/kernel/machine_kexec.c:21: error: conflicting types for `crash_notes' /dev/shm/linux-2.6/include/linux/kexec.h:129: error: previous declaration of `crash_notes' Signed-off-by: Olaf Hering <olh@suse.de> Signed...
```diff diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c index a91e40c9ae45..a81ca1b841ec 100644 --- a/arch/powerpc/kernel/machine_kexec.c +++ b/arch/powerpc/kernel/machine_kexec.c @@ -14,12 +14,6 @@ #include <linux/threads.h> #include <asm/machdep.h> -/* - * Provide a dummy cr...
9819d85c210f5953fffc1052060e589d633f20ed
Analyze and fix the following issue in the Linux kernel code: Fix net/core/wireless.c link failure
Problem Details: It needs <linux/etherdevice.h> for compare_ether_addr()
```diff diff --git a/net/core/wireless.c b/net/core/wireless.c index f88b0affb3b9..2add7ed609e9 100644 --- a/net/core/wireless.c +++ b/net/core/wireless.c @@ -78,6 +78,7 @@ #include <linux/seq_file.h> #include <linux/init.h> /* for __init */ #include <linux/if_arp.h> /* ARPHRD_ETHER */ +#include <linux/etherdevic...
58b6c58caef7a34eab7ec887288fa495696653e7
Analyze and fix the following issue in the Linux kernel code: [PARISC] Use STABS_DEBUG macro from vmlinux.lds.h
Problem Details: Cleanup vmlinux.lds.S by using STABS_DEBUG macro from vmlinux.lds.h instead of repeating the sections. Signed-off-by: Matthew Wilcox <willy@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/arch/parisc/kernel/vmlinux.lds.S b/arch/parisc/kernel/vmlinux.lds.S index b8b9174f6425..6d6436a6b624 100644 --- a/arch/parisc/kernel/vmlinux.lds.S +++ b/arch/parisc/kernel/vmlinux.lds.S @@ -68,7 +68,7 @@ SECTIONS RODATA /* writeable */ - . = ALIGN(4096); /* Make sure this is paged aligned...
f45adcf977ac3c5512c17fd97b073bda99c81232
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix Dino reporting on J2240
Problem Details: Fix Dino reporting on J2240. This particular machine thought it had a Cujo. Also add J2240 Dino chip to the hp_hardware_list. Signed-off-by: Matthew Wilcox <willy@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/arch/parisc/kernel/hardware.c b/arch/parisc/kernel/hardware.c index 2071b5bba15c..3058bffd8a2c 100644 --- a/arch/parisc/kernel/hardware.c +++ b/arch/parisc/kernel/hardware.c @@ -551,6 +551,7 @@ static struct hp_hardware hp_hardware_list[] __initdata = { {HPHW_BCPORT, 0x804, 0x0000C, 0x10, "REO I/...
daaeb6f8d3afdfa58ffeffb7ba168ccbd5969858
Analyze and fix the following issue in the Linux kernel code: [PARISC] stifb: Fix framebuffer console at 32bpp
Problem Details: Fix stifb framebuffer console at 32bpp on a HCRX-24 card by properly setting DIRECTCOLOR. Also a few nice cleanups to the code. Signed-off-by: Helge Deller <deller@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/drivers/video/stifb.c b/drivers/video/stifb.c index 83cd76ca0265..3f050a770a15 100644 --- a/drivers/video/stifb.c +++ b/drivers/video/stifb.c @@ -3,7 +3,7 @@ * Low level Frame buffer driver for HP workstations with * STI (standard text interface) video firmware. * - * Copyright (C) 2001-2004...
7c0b67efe9e15fa81cfa332a9a6f6cd5f7941bbc
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix parport_gsc by selecting PARPORT_NOT_PC
Problem Details: PARPORT_GSC requires selecting PARPORT_NOT_PC in order to work properly. Signed-off-by: Guy Martin <gmsoft@tuxicoman.be> Signed-off-by: Helge Deller <deller@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/drivers/parport/Kconfig b/drivers/parport/Kconfig index a665951b1586..f605dea57224 100644 --- a/drivers/parport/Kconfig +++ b/drivers/parport/Kconfig @@ -121,6 +121,7 @@ config PARPORT_GSC tristate default GSC depends on PARPORT + select PARPORT_NOT_PC config PARPORT_SUNBPP tristate "Spa...
49efdd46eed353027096a765f40dd8af52ece5ae
Analyze and fix the following issue in the Linux kernel code: [PARISC] OSS: Fix build of parisc harmony driver
Problem Details: OSS Harmony got missed on the conversion of parisc_device.hpa to a struct resource... fix its build. Signed-off-by: Stuart Brady <sdb@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/sound/oss/harmony.c b/sound/oss/harmony.c index bee9d344cd26..591683c55f27 100644 --- a/sound/oss/harmony.c +++ b/sound/oss/harmony.c @@ -1236,7 +1236,7 @@ harmony_driver_probe(struct parisc_device *dev) } /* Set the HPA of harmony */ - harmony.hpa = (struct harmony_hpa *)dev->hpa; + harmony....
5cdb8205e917c09fd1348e4b22e26492e8c45b36
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix BLK_BOUNCE_HIGH on parisc by initializing max_low_pfn
Problem Details: max_low_pfn was not being set in arch/parisc/mm/init.c, causing severe problems whenever anything tried to use BLK_BOUNCE_HIGH. Set it to max_pfn like other similar architectures do. Signed-off-by: Grant Grundler <grundler@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c index f2e7f13ddeeb..720287d46e55 100644 --- a/arch/parisc/mm/init.c +++ b/arch/parisc/mm/init.c @@ -300,6 +300,13 @@ static void __init setup_bootmem(void) max_pfn = start_pfn + npages; } + /* IOMMU is always used to access "high mem" on those b...
6ca45a24ccb847251f71aec8906746d33e99f33e
Analyze and fix the following issue in the Linux kernel code: [PARISC] Truncate overlapping PAT PDC reported ranges
Problem Details: Deal with overlapping LBA MMIO resources, rp3440 PDC BUG: PDC reports lmmio range for the last rope that overlaps with the CPU HPA. Console output was: ... Found devices: 1. Storm Peak Fast at 0xfffffffffe798000 [152] { 0, 0x0, 0x889, 0x00004 } 2. Storm Peak Fast at 0xfffffffffe799000 [153] { 0, 0x0,...
```diff diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c index 4f6bdf0881b5..cbae8c8963fa 100644 --- a/drivers/parisc/lba_pci.c +++ b/drivers/parisc/lba_pci.c @@ -695,11 +695,71 @@ lba_claim_dev_resources(struct pci_dev *dev) } } } + + +/* + * truncate_pat_collision: Deal with overlaps or outrigh...
4d64c9f58e618b1bdbc91cb071e6c8d90f43d620
Analyze and fix the following issue in the Linux kernel code: [PARISC] Introduce DINO_LOCAL_IRQS and use it for gsc_find_local_irq
Problem Details: Fix dino by using DINO_LOCAL_IRQS as the limit for gsc_find_local_irq() instead of the irq itself. Signed-off-by: Helge Deller <deller@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c index 595d1987e997..45a1a494c1cc 100644 --- a/drivers/parisc/dino.c +++ b/drivers/parisc/dino.c @@ -124,6 +124,7 @@ #define DINO_IRQS 11 /* bits 0-10 are architected */ #define DINO_IRR_MASK 0x5ff /* only 10 bits are implemented */ +#define DINO_LO...
a01c8cb126cb5f5a592f01b08ff8859508c75ba1
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix GSC graphics cards with 64MB regions
Problem Details: Make knapps work with its 64MB gfx card. I probably just broke another machine in the process, but assuming 64MB when 64MB aligned is probably safer than assuming 32MB all the time. Signed-off-by: Matthew Wilcox <willy@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/arch/parisc/kernel/drivers.c b/arch/parisc/kernel/drivers.c index 041524d24ef1..1eaa0d37f677 100644 --- a/arch/parisc/kernel/drivers.c +++ b/arch/parisc/kernel/drivers.c @@ -515,8 +515,13 @@ alloc_pa_dev(unsigned long hpa, struct hardware_path *mod_path) (iodc_data[5] << 8) | iodc_data[6]; de...
e0565a1c83a1045d8fae728056082262e712b201
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix and cleanup ioremap.c to work with 4level-fixup.h
Problem Details: Fixup ioremap a bit. It seems to work on 32-bit kernels, but fails miserably on the first ioremapped access on 64-bit kernels. Also, having STI enabled causes it to fail. Probably because we're passing an ioremapped region to a real-mode STI call... Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/arch/parisc/mm/ioremap.c b/arch/parisc/mm/ioremap.c index 5c7a1b3b9326..edd9a9559cba 100644 --- a/arch/parisc/mm/ioremap.c +++ b/arch/parisc/mm/ioremap.c @@ -1,12 +1,9 @@ /* * arch/parisc/mm/ioremap.c * - * Re-map IO memory to kernel address space so that we can access it. - * This is needed f...
04d35d7324ed35983189bd396db7874a50bbea43
Analyze and fix the following issue in the Linux kernel code: [PARISC] Fix Cirrus 6832 Cardbus on RDI Tadpole PARISC Laptop
Problem Details: Fix irq-off-by-one for Cirrus 6832 Cardbus on RDI Tadpole PARISC Laptop. We just DECLARE_PCI_FIXUP_ENABLE as it is unlikely that this will be found in any other parisc system. Signed-off-by: Helge Deller <deller@parisc-linux.org> Signed-off-by: Kyle McMartin <kyle@parisc-linux.org>
```diff diff --git a/drivers/parisc/dino.c b/drivers/parisc/dino.c index 5ab75334c579..595d1987e997 100644 --- a/drivers/parisc/dino.c +++ b/drivers/parisc/dino.c @@ -435,6 +435,21 @@ static void dino_choose_irq(struct parisc_device *dev, void *ctrl) dino_assign_irq(dino, irq, &dev->irq); } + +/* + * Cirrus 6832 C...
864913f30dbd6f75b94045cd20ea0b082996287e
Analyze and fix the following issue in the Linux kernel code: cpuset two little doc fixes
Problem Details: Two little cpuset documentation fixes. Signed-off-by: Paul Jackson <pj@sgi.com> Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/Documentation/cpusets.txt b/Documentation/cpusets.txt index 9e49b1c35729..990998ee10b6 100644 --- a/Documentation/cpusets.txt +++ b/Documentation/cpusets.txt @@ -135,7 +135,7 @@ Cpusets extends these two mechanisms as follows: The implementation of cpusets requires a few, simple hooks into the re...
7823c7c121839f5a003acdf9c2f1839bfa2f6c43
Analyze and fix the following issue in the Linux kernel code: ext2: trivial indentation fix.
Problem Details: This memset() line was indented with seven spaces, this patch fixes it to use a tab instead. Yes, very trivial but it's the third time I have to look at this line.. Signed-off-by: Luiz Capitulino <lcapitulino@mandriva.com.br> Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c index 5b5f52876b42..7442bdd1267a 100644 --- a/fs/ext2/dir.c +++ b/fs/ext2/dir.c @@ -592,7 +592,7 @@ int ext2_make_empty(struct inode *inode, struct inode *parent) goto fail; } kaddr = kmap_atomic(page, KM_USER0); - memset(kaddr, 0, chunk_size); + memset(ka...
73165b88ffd29813bf73b331eaf90d3521443236
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix i386 mutex fastpath on FRAME_POINTER && !DEBUG_MUTEXES
Problem Details: Call the mutex slowpath more conservatively - e.g. FRAME_POINTERS can change the calling convention, in which case a direct branch to the slowpath becomes illegal. Bug found by Hugh Dickins. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-i386/mutex.h b/include/asm-i386/mutex.h index 4e5e3de1b9a6..c657d4b09f0a 100644 --- a/include/asm-i386/mutex.h +++ b/include/asm-i386/mutex.h @@ -28,7 +28,13 @@ do { \ \ __asm__ __volatile__( \ LOCK " decl (%%eax) \n" \ - " js "#fail_fn" \n" \ + "...
042c904c3e35e95ac911e8a2bf4097099b059e1a
Analyze and fix the following issue in the Linux kernel code: [PATCH] remove unnecessary asm/mutex.h from kernel/mutex-debug.c
Problem Details: Remove unnecessary (and incorrect) inclusion of asm/mutex.h, pointed out by David Howells. Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/mutex-debug.c b/kernel/mutex-debug.c index 4fcb051a8b9e..3dec75363786 100644 --- a/kernel/mutex-debug.c +++ b/kernel/mutex-debug.c @@ -20,8 +20,6 @@ #include <linux/kallsyms.h> #include <linux/interrupt.h> -#include <asm/mutex.h> - #include "mutex-debug.h" /* ```
ad8e4b75c8a7bed475d72ce09bf5267188621961
Analyze and fix the following issue in the Linux kernel code: [AF_NETLINK]: Fix DoS in netlink_rcv_skb()
Problem Details: From: Martin Murray <murrayma@citi.umich.edu> Sanity check nlmsg_len during netlink_rcv_skb. An nlmsg_len == 0 can cause infinite loop in kernel, effectively DoSing machine. Noted by Matin Murray. Signed-off-by: Chris Wright <chrisw@sous-sol.org> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index a67f1b44c9a3..bb50c8a9fcad 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1422,7 +1422,7 @@ static int netlink_rcv_skb(struct sk_buff *skb, int (*cb)(struct sk_buff *, while (skb->len >= nlmsg_total_size(0)) { ...
babbdb1a18d37e57acae7e348ef122f2b905df0a
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix timeout sysctls on big-endian 64bit architectures
Problem Details: The connection tracking timeout variables are unsigned long, but proc_dointvec_jiffies is used with sizeof(unsigned int) in the sysctl tables. Since there is no proc_doulongvec_jiffies function, change the timeout variables to unsigned int. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-b...
```diff diff --git a/net/ipv4/netfilter/ip_conntrack_proto_generic.c b/net/ipv4/netfilter/ip_conntrack_proto_generic.c index 88c3712bd251..f891308b5e4c 100644 --- a/net/ipv4/netfilter/ip_conntrack_proto_generic.c +++ b/net/ipv4/netfilter/ip_conntrack_proto_generic.c @@ -12,7 +12,7 @@ #include <linux/netfilter.h> #inc...
c07bc1ffbdc14312b214b56fa39f4a4ab1406b8e
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix return value confusion in PPTP NAT helper
Problem Details: ip_nat_mangle_tcp_packet doesn't return NF_* values but 0/1 for failure/success. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/ipv4/netfilter/ip_nat_helper_pptp.c b/net/ipv4/netfilter/ip_nat_helper_pptp.c index 50960cb681f8..ac004895781a 100644 --- a/net/ipv4/netfilter/ip_nat_helper_pptp.c +++ b/net/ipv4/netfilter/ip_nat_helper_pptp.c @@ -299,8 +299,6 @@ pptp_inbound_pkt(struct sk_buff **pskb, u_int16_t msg, new_cid ...
03b9feca89366952ae5dfe4ad8107b1ece50b710
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix another crash in ip_nat_pptp
Problem Details: The PPTP NAT helper calculates the offset at which the packet needs to be mangled as difference between two pointers to the header. With non-linear skbs however the pointers may point to two seperate buffers on the stack and the calculation results in a wrong offset beeing used. Signed-off-by: Patrick...
```diff diff --git a/net/ipv4/netfilter/ip_nat_helper_pptp.c b/net/ipv4/netfilter/ip_nat_helper_pptp.c index 8ad7b36e242d..50960cb681f8 100644 --- a/net/ipv4/netfilter/ip_nat_helper_pptp.c +++ b/net/ipv4/netfilter/ip_nat_helper_pptp.c @@ -148,14 +148,14 @@ pptp_outbound_pkt(struct sk_buff **pskb, { struct ip_ct_pptp...
15db34702cfafd24acc60295cf14861e497502ab
Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix crash in ip_nat_pptp
Problem Details: When an inbound PPTP_IN_CALL_REQUEST packet is received the PPTP NAT helper uses a NULL pointer in pointer arithmentic to calculate the offset in the packet which needs to be mangled and corrupts random memory or crashes. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller ...
```diff diff --git a/net/ipv4/netfilter/ip_nat_helper_pptp.c b/net/ipv4/netfilter/ip_nat_helper_pptp.c index e546203f5662..8ad7b36e242d 100644 --- a/net/ipv4/netfilter/ip_nat_helper_pptp.c +++ b/net/ipv4/netfilter/ip_nat_helper_pptp.c @@ -315,7 +315,7 @@ pptp_inbound_pkt(struct sk_buff **pskb, break; case PPTP_IN_...
19dbaf6f6f0f3b766df08594446d64747a5cced3
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: save reg a5 on context change
Problem Details: Fix a5 register corruption when processing user space signals handlers. We need to save a5 through each contenxt change. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-m68knommu/sigcontext.h b/include/asm-m68knommu/sigcontext.h index 84bf36dc7a83..36c293fc133d 100644 --- a/include/asm-m68knommu/sigcontext.h +++ b/include/asm-m68knommu/sigcontext.h @@ -8,6 +8,7 @@ struct sigcontext { unsigned long sc_d1; unsigned long sc_a0; unsigned long sc_a...
3960f2faaf0a67ad352bd5d4085e43f19f33ab91
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix find_next_zero_bit in bitops.h
Problem Details: We're starting a number of big applications (memory footprint app. 1MByte) on our Arcturus uC5272. Therefore memory fragmentation is a real pain for us. We've switched to uClinux-2.4.27-uc1 and found that page_alloc2 fragments the memory heavily. Digging into it we found a bug in the find_next_zero_...
```diff diff --git a/include/asm-m68knommu/bitops.h b/include/asm-m68knommu/bitops.h index 4058dd086a02..25d8a3cfef90 100644 --- a/include/asm-m68knommu/bitops.h +++ b/include/asm-m68knommu/bitops.h @@ -290,7 +290,7 @@ static __inline__ int find_next_zero_bit (const void * addr, int size, int offse tmp = *p; found...
694d855fbc797141960a3907019c442240ed8a0f
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix ram length of m5208evb board
Problem Details: Adjust length of M5208EVB ram define. It should size up to 32MB after adding in the dBUG reserved 128k. Problem pointed out be Milton Miller <miltonm@bga.com>. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m68knommu/kernel/vmlinux.lds.S b/arch/m68knommu/kernel/vmlinux.lds.S index 0eab92ca4b97..ac9de2661c0b 100644 --- a/arch/m68knommu/kernel/vmlinux.lds.S +++ b/arch/m68knommu/kernel/vmlinux.lds.S @@ -129,7 +129,7 @@ */ #if defined(CONFIG_M5208EVB) #define RAM_START 0x40020000 -#define RAM_LEN...
01829e7212dd9ba3fa68bf8afffc9a175c44cb04
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix a5 reg corruption in signal handlers
Problem Details: This is a patch adapted from a posting by Andrea Tarani which was pointed out to me by Bernardo Innocenti. Thanks to both of them for their help and patience. The original posting is here: http://mailman.uclinux.org/pipermail/uclinux-dev/2005-July/033543.html The problem first manifest itself as b...
```diff diff --git a/arch/m68knommu/kernel/signal.c b/arch/m68knommu/kernel/signal.c index 43a2726c0d0a..e1b3aa39e270 100644 --- a/arch/m68knommu/kernel/signal.c +++ b/arch/m68knommu/kernel/signal.c @@ -285,6 +285,7 @@ restore_sigcontext(struct pt_regs *regs, struct sigcontext *usc, void *fp, regs->d1 = context.sc_d1...
afc7cd8950572786c87ad081d8e65e5ea58b563c
Analyze and fix the following issue in the Linux kernel code: [PATCH] m68knommu: fix mangled 'truct' in ptrace.c
Problem Details: Fix broken "truct" -> "struct" in arch_ptrace() parameter list. Signed-off-by: Greg Ungerer <gerg@uclinux.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m68knommu/kernel/ptrace.c b/arch/m68knommu/kernel/ptrace.c index 262ab8c72e5f..382ca5797b97 100644 --- a/arch/m68knommu/kernel/ptrace.c +++ b/arch/m68knommu/kernel/ptrace.c @@ -101,7 +101,7 @@ void ptrace_disable(struct task_struct *child) put_reg(child, PT_SR, tmp); } -long arch_ptrace(t...
b016450f9f603210239e1a91e3c28f17c310dcc7
Analyze and fix the following issue in the Linux kernel code: [ARM] 3250/1: Change pxa2xx PCMCIA drivers to use platform_device_alloc
Problem Details: Patch from Richard Purdie Change mainstone and sharpsl pxa2xx pcmcia drivers to use platform_device_alloc which fixes a memory leak. Signed-off-by: Richard Purdie <rpurdie@rpsys.net> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/drivers/pcmcia/pxa2xx_mainstone.c b/drivers/pcmcia/pxa2xx_mainstone.c index 5d957dfe23d9..fda06941e730 100644 --- a/drivers/pcmcia/pxa2xx_mainstone.c +++ b/drivers/pcmcia/pxa2xx_mainstone.c @@ -171,27 +171,22 @@ static int __init mst_pcmcia_init(void) { int ret; - mst_pcmcia_device = kzalloc(s...
4f47707b056bd2e3627ef390557ee93d312daba5
Analyze and fix the following issue in the Linux kernel code: Fix rpc shutdown event condition bug
Problem Details: We want to wait for the cl_users to go down to zero, not for it to stay positive. Quoth Trond (who wasn't even the author, but acked the wrong version): "Argh! I need to increase my daily caffeine dosages." Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index a44da8b3d240..4cef7fa2b740 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -269,7 +269,7 @@ rpc_shutdown_client(struct rpc_clnt *clnt) clnt->cl_dead = 0; rpc_killall_tasks(clnt); wait_event_timeout(destroy_wait, - atomic_read(&clnt->c...
a9c828155ae8d1a1576f9648cc4d9677aea53f89
Analyze and fix the following issue in the Linux kernel code: [PATCH] rcu: fix hotplug-cpu ->donelist leak
Problem Details: Pointed out by Srivatsa Vaddagiri <vatsa@in.ibm.com>. rcu_do_batch() stops after processing maxbatch callbacks on ->donelist leaving rcu_tasklet in TASKLET_STATE_SCHED state. If CPU_DEAD event happens remaining ->donelist entries are lost, rcu_offline_cpu() kills this tasklet. With this patch ->done...
```diff diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c index e18f9190eafa..0cf8146bd585 100644 --- a/kernel/rcupdate.c +++ b/kernel/rcupdate.c @@ -343,8 +343,9 @@ static void __rcu_offline_cpu(struct rcu_data *this_rdp, spin_unlock_bh(&rcp->lock); rcu_move_batch(this_rdp, rdp->curlist, rdp->curtail); rcu_move...
c8d52465f95c4187871f8e65666c07806ca06d41
Analyze and fix the following issue in the Linux kernel code: [PATCH] Work around ppc64 compiler bug
Problem Details: In the process of optimising our per cpu data code, I found a ppc64 compiler bug that has been around forever. Basically the current RELOC_HIDE can end up trashing r30. Details of the bug can be found at http://gcc.gnu.org/bugzilla/show_bug.cgi?id=25572 This bug is present in all compilers before 4...
```diff diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 2e05e1e6b0e6..6e1c44a935d4 100644 --- a/include/linux/compiler-gcc.h +++ b/include/linux/compiler-gcc.h @@ -11,9 +11,15 @@ /* This macro obfuscates arithmetic on a variable address so that gcc shouldn't recognize the original ...
9979ead5d1eb23191a00453559927c5abf9087e2
Analyze and fix the following issue in the Linux kernel code: [PATCH] fs/hfsplus/: remove the hfsplus_inode_check() debug function
Problem Details: This patch removes the hfsplus_inode_check() debug function. It also removes the now obsolete last_inode_cnt and inode_cnt from struct hfsplus_sb_info. Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Roman Zippel <zippel@linux-m68k.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by...
```diff diff --git a/fs/hfsplus/hfsplus_fs.h b/fs/hfsplus/hfsplus_fs.h index df16fcbff3fb..0fa1ab6250bf 100644 --- a/fs/hfsplus/hfsplus_fs.h +++ b/fs/hfsplus/hfsplus_fs.h @@ -143,9 +143,6 @@ struct hfsplus_sb_info { unsigned long flags; - atomic_t inode_cnt; - u32 last_inode_cnt; - struct hlist_head rsrc_inodes...
6ed80991a2dce4afc113be35089c564d62fa1f11
Analyze and fix the following issue in the Linux kernel code: [PATCH] tty-layer-buffering-revamp: jsm is broken
Problem Details: Looks like JSM will be uncompilable after the TTY layer rework is merged into Linus's post-2.6.15 tree. It was complex to fix - the maintainers were notified in September. Cc: Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> Signed-off-by: Andrew Morton <akpm@osdl....
```diff diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 1bae26a8a503..698cb76819d9 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@ -860,7 +860,7 @@ config SERIAL_VR41XX_CONSOLE config SERIAL_JSM tristate "Digi International NEO PCI Support" - depends on PCI + depends o...