id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
3af13763d696468d31f71a798155b33f681f221f
Analyze and fix the following issue in the Linux kernel code: [PATCH] fs/ext3/: small cleanups
Problem Details: This patch contains the following cleanups: - there's no need for ext3_count_free() #ifndef EXT3FS_DEBUG - having prototypes for ext3_count_free() in two different headers is nonsense Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torval...
```diff diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index ae1148c24c53..c6393fb4c35a 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c @@ -20,8 +20,6 @@ #include <linux/quotaops.h> #include <linux/buffer_head.h> -#include "bitmap.h" - /* * balloc.c contains the blocks allocation and deallocation routines...
4610a6bea7742ab34e40dcb776bd3feb52da10d6
Analyze and fix the following issue in the Linux kernel code: [PATCH] fs/ext2/bitmap.c: ext2_count_free() is only required #ifdef EXT2FS_DEBUG
Problem Details: There's no need for ext2_count_free() #ifndef EXT2FS_DEBUG. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/fs/ext2/bitmap.c b/fs/ext2/bitmap.c index 20145b74623f..e9983a0dd396 100644 --- a/fs/ext2/bitmap.c +++ b/fs/ext2/bitmap.c @@ -7,8 +7,12 @@ * Universite Pierre et Marie Curie (Paris VI) */ +#ifdef EXT2FS_DEBUG + #include <linux/buffer_head.h> +#include "ext2.h" + static int nibblemap[] = {...
e48e99093c9bbb67f95e903d37aef30a969a0153
Analyze and fix the following issue in the Linux kernel code: [PATCH] Docs update: small fixes to stable_kernel_rules.txt
Problem Details: Small spelling, formating & similar fixes to stable_kernel_rules.txt Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/Documentation/stable_kernel_rules.txt b/Documentation/stable_kernel_rules.txt index 2c81305090df..e409e5d07486 100644 --- a/Documentation/stable_kernel_rules.txt +++ b/Documentation/stable_kernel_rules.txt @@ -1,58 +1,56 @@ Everything you ever wanted to know about Linux 2.6 -stable releases. -Ru...
c63ca3c8b01e8cad4fe8874366e598bcbbdd048e
Analyze and fix the following issue in the Linux kernel code: [PATCH] Docs update: small spelling, formating etc fixes for filesystems/ext3.txt
Problem Details: Spelling fixes, formating changes and corrections for Documentation/filesystems/ext3.txt Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/Documentation/filesystems/ext3.txt b/Documentation/filesystems/ext3.txt index 22e4040564d5..f4d0de6bac63 100644 --- a/Documentation/filesystems/ext3.txt +++ b/Documentation/filesystems/ext3.txt @@ -2,11 +2,11 @@ Ext3 Filesystem =============== -ext3 was originally released in September 1999. Wr...
c594a50db4cbe8b839a70fca0cff524d392531ca
Analyze and fix the following issue in the Linux kernel code: [PATCH] Docs update: typos, corrections and additions to applying-patches.txt
Problem Details: Typos/corrections. A few extra additions on top of Randy's fixes. Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/Documentation/applying-patches.txt b/Documentation/applying-patches.txt index 05a08c2c1889..a083ba35d1ad 100644 --- a/Documentation/applying-patches.txt +++ b/Documentation/applying-patches.txt @@ -3,8 +3,7 @@ ------------------------------------ Original by: Jesper Juhl, August 2005 - Last u...
0863afb32b77fc89c7110b3d10fb048cb56bb1b5
Analyze and fix the following issue in the Linux kernel code: [PATCH] DocBook: fix kernel-doc comments
Problem Details: Fix typos in comments to remove kernel-doc warnings. Signed-off-by: Martin Waitz <tali@admingilde.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/base/core.c b/drivers/base/core.c index fd8059920dbf..6b355bd7816d 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -161,8 +161,8 @@ static ssize_t store_uevent(struct device *dev, struct device_attribute *attr, return count; } -/** - * device_subsys - structure to be regi...
d060a3218f6a046509fa31939ce1a671b0359086
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix console blanking
Problem Details: Current console blanking code is broken. It will first do a normal blank, then start the VESA blank timer if vesa_off_interval != 0, and then proceed to do the VESA blanking directly. After the timer expires it will do the VESA blanking a second time. Also the vesa_powerdown() function doesn't allow...
```diff diff --git a/drivers/char/vt.c b/drivers/char/vt.c index e91268e86833..f1d9cb7feae6 100644 --- a/drivers/char/vt.c +++ b/drivers/char/vt.c @@ -2758,29 +2758,6 @@ static void set_vesa_blanking(char __user *p) vesa_blank_mode = (mode < 4) ? mode : 0; } -/* - * This is called by a timer handler - */ -stati...
c5eec03f314e1406829d9683284673203b91b9b8
Analyze and fix the following issue in the Linux kernel code: [PATCH] i810fb: Fix suspend and resume hooks
Problem Details: The i810fb suspend and resume hooks have suffered bitrot over time. Update to current framework, but functionality still not guaranteed to work. Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/i810/i810_main.c b/drivers/video/i810/i810_main.c index 692337dc5a40..d27cd19b7f70 100644 --- a/drivers/video/i810/i810_main.c +++ b/drivers/video/i810/i810_main.c @@ -42,6 +42,7 @@ #include <linux/pci_ids.h> #include <linux/resource.h> #include <linux/unistd.h> +#include <linux/co...
740f14ba5335d1e25b9f3e80643be801f653cd32
Analyze and fix the following issue in the Linux kernel code: [PATCH] s3c2410fb: cleanup and fix
Problem Details: Here are some cleanups for the s3c2410fb drivers. It : * Removes a buggy call to s3c2410fb_init_registers. There was two calls to this function but the first was done without all initialisations done. No oops but it may confuse some LCDs. * Makes two functions static. Signed-Off-By: Arnaud Patard ...
```diff diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c index fe99d17a21d7..d574dd3c9c8a 100644 --- a/drivers/video/s3c2410fb.c +++ b/drivers/video/s3c2410fb.c @@ -552,7 +552,7 @@ static inline void modify_gpio(void __iomem *reg, * s3c2410fb_init_registers - Initialise all LCD-related registers *...
af5d0f7e2b5e9ef369de2aefe51e14ca1e6928f5
Analyze and fix the following issue in the Linux kernel code: [PATCH] fbdev: Reduce stack usage
Problem Details: calc_mode_timings() and fb_get_mode() are using more than 500 bytes off the stack. Fix. Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c index fc7965b66775..0ef75a9f84af 100644 --- a/drivers/video/fbmon.c +++ b/drivers/video/fbmon.c @@ -317,26 +317,29 @@ static int edid_is_monitor_block(unsigned char *block) static void calc_mode_timings(int xres, int yres, int refresh, struct...
0a484a3af905a256cbdd7079defceac62b39e8fa
Analyze and fix the following issue in the Linux kernel code: [PATCH] fbdev: Fix return code of fb_read and fb_write
Problem Details: Make fb_read() and fb_write() return 0 (EOF) instead of -ENOSPC if reading at or past the end of the framebuffer. This fixes user space apps hanging if info->fix.smem_len == 0. Whitespace changes. Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-of...
```diff diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c index 10dfdf035264..83e259413115 100644 --- a/drivers/video/fbmem.c +++ b/drivers/video/fbmem.c @@ -589,17 +589,19 @@ fb_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) return info->fbops->fb_read(file, buf, count, ppos); t...
244ab72d84a04d40bd270da604161e02af73fb11
Analyze and fix the following issue in the Linux kernel code: [PATCH] fbcon: disable ywrap if not supported by fbcon scrolling code
Problem Details: updatescrollmode() must not select ywrap scrolling if divides(vc->vc_font.height, yres) is not true as this is not supported by the actual ywrap scrolling code. The bug is triggered with e.g. mode 800x600, vxres 1024, vyres 8192, bpp 8, font dimensions 8x16, 8Mb video ram and FBINFO_HWACCEL_YWRAP set...
```diff diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index f05afc02de2a..4f6fc785e95f 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -1965,7 +1965,8 @@ static __inline__ void updatescrollmode(struct display *p, divides(ypan, vc->vc_font.height) && vyre...
a87d7fddbd7f46475842431d153d35bd03cf4f63
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix interlaced modes
Problem Details: Fix interlaced display modes. Signed-off-by: Ville Syrjälä <syrjala@sci.fi> Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index 5d46171fa64c..845da14f56d3 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -967,16 +967,6 @@ static int aty_var_to_crtc(const struct fb_info *info, vdisplay = yres; if(vmode & FB_VMODE_DO...
50c839c7b5e7d7cc3443176f5d5458e134b0b189
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix CRTC_FIFO_LWM mask
Problem Details: CRTC_FIFO_LWM was incorrectly masked. Signed-off-by: Ville Syrjälä <syrjala@sci.fi> Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index 4c46706188fe..5d46171fa64c 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -1077,9 +1077,8 @@ static int aty_var_to_crtc(const struct fb_info *info, #endif /* CONFIG_FB_ATY_GENERIC_LCD */ ...
cd4617bef436a3342a959fe7ca870bb10d59d509
Analyze and fix the following issue in the Linux kernel code: [PATCH] atyfb: Fix spelling
Problem Details: Fix some spelling mistakes. Signed-off-by: Ville Syrjälä <syrjala@sci.fi> Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c index 5a80ac01032f..80600da29137 100644 --- a/drivers/video/aty/atyfb_base.c +++ b/drivers/video/aty/atyfb_base.c @@ -692,7 +692,7 @@ static void aty_set_crtc(const struct atyfb_par *par, const struct crtc *crtc) aty_st_lcd(LCD_GEN_...
e53f87a02a0d77c519fb93c7aa0912956294050c
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix vesafb display panning regression
Problem Details: Fix vesafb hang when scroll mode is REDRAW. Signed-off-by: Antonino Daplas <adaplas@pol.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/video/vesafb.c b/drivers/video/vesafb.c index e6e56b8df2db..8982e540214c 100644 --- a/drivers/video/vesafb.c +++ b/drivers/video/vesafb.c @@ -417,6 +417,9 @@ static int __init vesafb_probe(struct platform_device *dev) info->flags = FBINFO_FLAG_DEFAULT | (ypan) ? FBINFO_HWACCEL_YPAN : 0...
2b4f2f4b0132afa9f441171285cca354377bf5d0
Analyze and fix the following issue in the Linux kernel code: [PATCH] vesafb: Drop blank hook
Problem Details: From: Bugzilla Bug 5351 "After resuming from S3 (suspended while in X), the LCD panel stays black . However, the laptop is up again, and I can SSH into it from another machine. I can get the panel working again, when I first direct video output to the CRT output of the laptop, and then back to LCD (...
```diff diff --git a/arch/i386/boot/video.S b/arch/i386/boot/video.S index 92f669470142..2ac40c8244c4 100644 --- a/arch/i386/boot/video.S +++ b/arch/i386/boot/video.S @@ -97,7 +97,6 @@ #define PARAM_VESAPM_OFF 0x30 #define PARAM_LFB_PAGES 0x32 #define PARAM_VESA_ATTRIB 0x34 -#define PARAM_CAPABILITIES 0x36 ...
0498b63504f818e5ab39c818cd6f7b41319a1187
Analyze and fix the following issue in the Linux kernel code: [PATCH] kprobes: fix build breakage
Problem Details: The following patch (against 2.6.15-rc5-mm3) fixes a kprobes build break due to changes introduced in the kprobe locking in 2.6.15-rc5-mm3. In addition, the patch reverts back the open-coding of kprobe_mutex. Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Acked-by: Anil S Keshavamurthy...
```diff diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index 93444e32fccd..27b0c40601fb 100644 --- a/arch/powerpc/kernel/kprobes.c +++ b/arch/powerpc/kernel/kprobes.c @@ -80,11 +80,11 @@ void __kprobes arch_disarm_kprobe(struct kprobe *p) (unsigned long) p->addr + sizeof(kprobe_opcode...
f709b122343fb9a010b6cf2d5559641f1820f7c9
Analyze and fix the following issue in the Linux kernel code: [PATCH] kprobes-changed-from-using-spinlock-to-mutex fix
Problem Details: Based on some feedback from Oleg Nesterov, I have made few changes to previously posted patch. Signed-off-by: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index 331e169e8629..2cd32dd6898b 100644 --- a/arch/powerpc/kernel/kprobes.c +++ b/arch/powerpc/kernel/kprobes.c @@ -35,7 +35,6 @@ #include <asm/kdebug.h> #include <asm/sstep.h> -static DECLARE_MUTEX(kprobe_mutex); DEFINE_PER_CPU(str...
49a2a1b83ba6fa40c41968d6a28ba16e7ed0c3f7
Analyze and fix the following issue in the Linux kernel code: [PATCH] kprobes: changed from using spinlock to mutex
Problem Details: Since Kprobes runtime exception handlers is now lock free as this code path is now using RCU to walk through the list, there is no need for the register/unregister{_kprobe} to use spin_{lock/unlock}_isr{save/restore}. The serialization during registration/unregistration is now possible using just a mu...
```diff diff --git a/arch/i386/kernel/kprobes.c b/arch/i386/kernel/kprobes.c index 19edcd526ba4..68fe10250486 100644 --- a/arch/i386/kernel/kprobes.c +++ b/arch/i386/kernel/kprobes.c @@ -57,14 +57,10 @@ static inline int is_IF_modifier(kprobe_opcode_t opcode) } int __kprobes arch_prepare_kprobe(struct kprobe *p) -{...
753be6222728996974e9e12c185108fcabbb7c6e
Analyze and fix the following issue in the Linux kernel code: [PATCH] hrtimer: deinline mktime and set_normalized_timespec
Problem Details: mktime() and set_normalized_timespec() are large inline functions used in many places: deinline them. From: George Anzinger, off-by-1 bugfix Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Ingo Molnar <mingo@elte.hu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus...
```diff diff --git a/include/linux/time.h b/include/linux/time.h index 797ccd813bb0..9c444d9c4aa0 100644 --- a/include/linux/time.h +++ b/include/linux/time.h @@ -38,38 +38,9 @@ static __inline__ int timespec_equal(struct timespec *a, struct timespec *b) return (a->tv_sec == b->tv_sec) && (a->tv_nsec == b->tv_nsec); ...
bf2083050d7879390ddedbd64e431cf167854a34
Analyze and fix the following issue in the Linux kernel code: [PATCH] Kdump: powerpc and s390 build failure fix
Problem Details: ) From: Vivek Goyal <vgoyal@in.ibm.com> crash_setup_regs() is an architecture dependent function which is called in architecture independent section. So every architecture supporting kexec should at least provide a dummy definition of crash_setup_regs() even if crash dumping is not implemented yet, ...
```diff diff --git a/include/asm-powerpc/kexec.h b/include/asm-powerpc/kexec.h index e363752276ef..fffdf690b840 100644 --- a/include/asm-powerpc/kexec.h +++ b/include/asm-powerpc/kexec.h @@ -55,6 +55,12 @@ extern void default_machine_crash_shutdown(struct pt_regs *regs); #endif /* !CONFIG_KEXEC */ +/* + * Provide ...
f05b690248bc928b85cc19ea85a5c6268bb3acaf
Analyze and fix the following issue in the Linux kernel code: [PATCH] Kdump: i386 compiler warning fix
Problem Details: Fixes a compilation warning message in i386 Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-i386/kexec.h b/include/asm-i386/kexec.h index 8fb1defd98c6..53f0e06672dc 100644 --- a/include/asm-i386/kexec.h +++ b/include/asm-i386/kexec.h @@ -3,6 +3,7 @@ #include <asm/fixmap.h> #include <asm/ptrace.h> +#include <asm/string.h> /* * KEXEC_SOURCE_MEMORY_LIMIT maximum page get...
e996e58133c475bcf3a229f716b9457267cbaa0a
Analyze and fix the following issue in the Linux kernel code: [PATCH] kdump: save registers early (inline functions)
Problem Details: - If system panics then cpu register states are captured through funciton crash_get_current_regs(). This is not a inline function hence a stack frame is pushed on to the stack and then cpu register state is captured. Later this frame is popped and new frames are pushed (machine_kexec). - In th...
```diff diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c index f1e65c2ead6e..d49dbe8dc96b 100644 --- a/arch/i386/kernel/crash.c +++ b/arch/i386/kernel/crash.c @@ -82,53 +82,12 @@ static void crash_save_this_cpu(struct pt_regs *regs, int cpu) final_note(buf); } -static void crash_get_current_regs(st...
35ed319a36cdfd88fc3debe6ce24e756bc474cce
Analyze and fix the following issue in the Linux kernel code: [PATCH] kdump: export per cpu crash notes pointer through sysfs (fix)
Problem Details: Removes the call to get_cpu() and put_cpu() as it is not required. Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c index 982e6583cd63..07a7f97e1de9 100644 --- a/drivers/base/cpu.c +++ b/drivers/base/cpu.c @@ -101,10 +101,8 @@ static ssize_t show_crash_notes(struct sys_device *dev, char *buf) * boot up and this data does not change there after. Hence this * operation...
82409411571ad89d271dc46f7fa26149fad9efdf
Analyze and fix the following issue in the Linux kernel code: [PATCH] kdump: i386 save ss esp bug fix
Problem Details: ) From: Vivek Goyal <vgoyal@in.ibm.com> This patch fixes a minor bug based on Andi Kleen's suggestion. asm's can't be broken in this particular case, hence merging them. Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torval...
```diff diff --git a/arch/i386/kernel/crash.c b/arch/i386/kernel/crash.c index 0248e084017c..10fe6569751e 100644 --- a/arch/i386/kernel/crash.c +++ b/arch/i386/kernel/crash.c @@ -108,8 +108,10 @@ static void crash_setup_regs(struct pt_regs *newregs, struct pt_regs *oldregs) { memcpy(newregs, oldregs, sizeof(*newregs...
be4f1bb2627c2d963d09be1cd69f8820995a9112
Analyze and fix the following issue in the Linux kernel code: [PATCH] ipmi: fix compile errors with PROC_FS=n
Problem Details: ... CC [M] drivers/char/ipmi/ipmi_msghandler.o drivers/char/ipmi/ipmi_msghandler.c:3301: `proc_ipmi_root' undeclared here (not in a function) drivers/char/ipmi/ipmi_msghandler.c:3301: initializer element is not constant drivers/char/ipmi/ipmi_msghandler.c:3301: (near initialization for `__ksymtab_pr...
```diff diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index 561430ed94af..0097f06fa67b 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -57,6 +57,7 @@ static int initialized = 0; #ifdef CONFIG_PROC_FS struct proc_dir_entry *proc_i...
9c107805aba774667debc01704718960339c24b9
Analyze and fix the following issue in the Linux kernel code: [PATCH] printk levels for i386 oops code.
Problem Details: Especially useful when users have booted with 'quiet'. In the regular 'oops' path, we set the console_loglevel before we start spewing debug info, but we can call the backtrace code from other places now too, such as the spinlock debugging code. Signed-off-by: Dave Jones <davej@redhat.com> Signed-off...
```diff diff --git a/arch/i386/kernel/traps.c b/arch/i386/kernel/traps.c index 53ad954e3ba4..b9f0030a2ebb 100644 --- a/arch/i386/kernel/traps.c +++ b/arch/i386/kernel/traps.c @@ -120,7 +120,7 @@ static inline unsigned long print_context_stack(struct thread_info *tinfo, #ifdef CONFIG_FRAME_POINTER while (valid_stack_...
51989b9ffeea58999054fe3f21bd0cd0bd207e5a
Analyze and fix the following issue in the Linux kernel code: [PATCH] printk levels for spinlock debug
Problem Details: Signed-off-by: Dave Jones <davej@redhat.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/lib/spinlock_debug.c b/lib/spinlock_debug.c index dcd4be9bd4e5..c8bb8cc899d7 100644 --- a/lib/spinlock_debug.c +++ b/lib/spinlock_debug.c @@ -19,10 +19,11 @@ static void spin_bug(spinlock_t *lock, const char *msg) if (xchg(&print_once, 0)) { if (lock->owner && lock->owner != SPINLOCK_OWNER_INI...
0ad42352c01788e41a33336577fdd270d8de55bb
Analyze and fix the following issue in the Linux kernel code: [PATCH] Add list_for_each_entry_safe_reverse()
Problem Details: Add list_for_each_entry_safe_reverse() to linux/list.h This is needed by unmerged cachefs and be an as-yet-unreviewed device_shutdown() fix. Signed-off-by: David Howells <dhowells@redhat.com> Cc: Patrick Mochel <mochel@digitalimplant.org> Cc: Greg KH <greg@kroah.com> Signed-off-by: Andrew Morton <akp...
```diff diff --git a/include/linux/list.h b/include/linux/list.h index 8e3388284530..945daa1f13dd 100644 --- a/include/linux/list.h +++ b/include/linux/list.h @@ -435,6 +435,20 @@ static inline void list_splice_init(struct list_head *list, &pos->member != (head); \ pos = n, n = list_entry(n->member.n...
6dd214b554f675e7e66cbce87e594a36f4a57298
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix /sys/class/net/<if>/wireless without dev->get_wireless_stats
Problem Details: dev->get_wireless_stats is deprecated but removing it also removes wireless subdirectory in sysfs. This patch puts it back. akpm: I don't know what's happening here. This might be appropriate as a 2.6.15.x compatibility backport. Waiting to hear from Jeff. Signed-off-by: Andrey Borzenkov <arvidjaar...
```diff diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index e1da81d261d1..58adaf208dd6 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -16,6 +16,7 @@ #include <net/sock.h> #include <linux/rtnetlink.h> #include <linux/wireless.h> +#include <net/iw_handler.h> #define to_class_dev(obj) con...
0137ecfdc3453f58a9beee95152ff61e8bad97b1
Analyze and fix the following issue in the Linux kernel code: [PATCH] nvidiafb: Fixes for new G5
Problem Details: Recent X "nv" driver was fixed for various issues with modern 6xxx and 7xxx cards. This patch ports those fixes to nvidiafb. This makes it work fine on the 6600 bundled with the newest G5 macs. I've verified it still works on the 5200FX of the iMacG5. Signed-off-by: Benjamin Herrenschmidt <benh@ker...
```diff diff --git a/drivers/video/nvidia/nv_hw.c b/drivers/video/nvidia/nv_hw.c index b989358437b3..454283f9bdac 100644 --- a/drivers/video/nvidia/nv_hw.c +++ b/drivers/video/nvidia/nv_hw.c @@ -848,7 +848,7 @@ void NVCalcStateExt(struct nvidia_par *par, int width, int hDisplaySize, int height, int dotClo...
2308acca656c3625c46b671b348fb04b6b006cad
Analyze and fix the following issue in the Linux kernel code: [PATCH] "tiny-make-id16-support-optional" fixes
Problem Details: It seems the "make UID16 support optional" patch was checked when it edited the -tiny tree some time ago, but it wasn't checked whether it still matches the current situation when it was submitted for inclusion in -mm. This patch fixes the following bugs: - ARCH_S390X does no longer exist, nowadays thi...
```diff diff --git a/arch/frv/Kconfig b/arch/frv/Kconfig index 61261b78ced7..60a617aff8ba 100644 --- a/arch/frv/Kconfig +++ b/arch/frv/Kconfig @@ -6,10 +6,6 @@ config FRV bool default y -config UID16 - bool - default y - config RWSEM_GENERIC_SPINLOCK bool default y diff --git a/arch/m32r/Kconfig b/arch/m32r/...
c3a9aea7aacb26881f3488b879750edb4a578c50
Analyze and fix the following issue in the Linux kernel code: [PATCH] spufs: fix for recent "shrink dentry_struct" patch
Problem Details: Cc: Eric Dumazet <dada1@cosmosbay.com> Cc: Paul Mackerras <paulus@samba.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c index d2ba358c6e38..b3962c3a0348 100644 --- a/arch/powerpc/platforms/cell/spufs/inode.c +++ b/arch/powerpc/platforms/cell/spufs/inode.c @@ -138,7 +138,7 @@ static void spufs_prune_dir(struct dentry *dir) { stru...
97460df37ea3335ca11562568932c9f9facfecdb
Analyze and fix the following issue in the Linux kernel code: IPoIB: Fix address handle refcounting for multicast groups
Problem Details: Multiple ipoib_neigh structures on mcast->neigh_list may point to the same ah. This means that ipoib_mcast_free() can't just make a list of ah structs to free, since this might end up trying to add the same ah to the list more than once. Handle this in ipoib_multicast.c in the same way as it is handl...
```diff diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index 6c6db759e79e..03b2ca64a40c 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -97,8 +97,6 @@ static void ipoib_mcast_free(struct ipo...
70b4c8cdc168bb5d18e23fd205c4ede1b756a8b2
Analyze and fix the following issue in the Linux kernel code: IPoIB: Fix error path in ipoib_mcast_dev_flush()
Problem Details: Don't leak memory on allocation failure for broadcast mcast group. Also, print a warning to match handling for other mcast groups. Signed-off-by: Eli Cohen <eli@mellanox.co.il> Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il> Signed-off-by: Roland Dreier <rolandd@cisco.com>
```diff diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c index ed0c2ead8bc1..6c6db759e79e 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c @@ -780,9 +780,11 @@ void ipoib_mcast_dev_flush(struct ne...
15265251c5c68fbabdf561cf704e3e305349715a
Analyze and fix the following issue in the Linux kernel code: MIPS: R2: Fix local_irq_save()
Problem Details: local_irq_restore uses di which saves the whole status content, not just the IE bit resulting in local_irq_restore() to fail. This only happens if both CONFIG_CPU_MIPSR2 and CONFIG_IRQ_CPU are enabled. Signed-off-by: Maxime Bizon <mbizon@freebox.fr> Signed-off-by: Ralf Baechle <ralf@linux-mips.o...
```diff diff --git a/include/asm-mips/interrupt.h b/include/asm-mips/interrupt.h index a5735761f5e5..abdf54ee64cf 100644 --- a/include/asm-mips/interrupt.h +++ b/include/asm-mips/interrupt.h @@ -93,6 +93,7 @@ __asm__ ( " .set noat \n" #ifdef CONFIG_CPU_MIPSR2 " di \\result \n" + " andi \\result, 1 \n"...
c5c64e22834c9f43f246072b4dcb293c9cea0ebe
Analyze and fix the following issue in the Linux kernel code: MIPS: Au1550: Fix OHCI memory map size
Problem Details: USB OpenHCI host controller on Au1550 only decodes memory addresses from 0x14020000 to 0x1407FFFF according to the databook, which gives 0x60000 (on the prior Au1x00 chips the map size was 1MB). Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Acked-by: Jordan Crouse <jordan.crouse@amd.com...
```diff diff --git a/include/asm-mips/mach-au1x00/au1000.h b/include/asm-mips/mach-au1x00/au1000.h index 8327ec341c18..8e1d7ed7d8e3 100644 --- a/include/asm-mips/mach-au1x00/au1000.h +++ b/include/asm-mips/mach-au1x00/au1000.h @@ -838,6 +838,7 @@ extern au1xxx_irq_map_t au1xxx_irq_map[]; #define UART3_ADDR ...
571e0bed85470882cedfb100e847902911c3f4d2
Analyze and fix the following issue in the Linux kernel code: MIPS: MT: Fix 32-bit dependencies.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c index 9c89eebc356f..ae83b755cf4a 100644 --- a/arch/mips/kernel/vpe.c +++ b/arch/mips/kernel/vpe.c @@ -99,9 +99,9 @@ struct vpe { /* elfloader stuff */ void *load_addr; - u32 len; + unsigned long len; char *pbuffer; - u32 plen; + unsigned long ...
f12555d24ca636569b51c6f104aab41b2bba8c32
Analyze and fix the following issue in the Linux kernel code: MIPS: Fix mdelay(1) for 64bit kernel with HZ == 1000
Problem Details: mdelay(1) (i.e. udelay(1000)) does not work correctly due to overflow. 1000 * 0x004189374BC6A7f0 = 0x10000000000000180 (>= 2**64) 0x004189374BC6A7ef (0x004189374BC6A7f0 - 1) is OK and it is exactly same as catchall case (0x8000000000000000UL / (500000 / HZ)). Signed-off-by: Atsushi Nemot...
```diff diff --git a/include/asm-mips/delay.h b/include/asm-mips/delay.h index 48d00cccdafa..64dd45150f64 100644 --- a/include/asm-mips/delay.h +++ b/include/asm-mips/delay.h @@ -52,13 +52,11 @@ static inline void __udelay(unsigned long usecs, unsigned long lpj) unsigned long lo; /* - * The common rates of 1000 ...
f8e0f2905bf0a7cb5ef2baaf009f0c26f80c3056
Analyze and fix the following issue in the Linux kernel code: drm: fix radeon warnings on 64-bit
Problem Details: From: Andrew Morton <akpm@osdl.org> drivers/char/drm/radeon_state.c: In function `radeon_cp_dispatch_texture': drivers/char/drm/radeon_state.c:1653: warning: int format, different type arg (arg 3) drivers/char/drm/radeon_state.c:1661: warning: int format, different type arg (arg 3) drivers/char/drm/ra...
```diff diff --git a/drivers/char/drm/radeon_state.c b/drivers/char/drm/radeon_state.c index e9d8ec3a0994..7bc27516d425 100644 --- a/drivers/char/drm/radeon_state.c +++ b/drivers/char/drm/radeon_state.c @@ -1651,7 +1651,7 @@ static int radeon_cp_dispatch_texture(DRMFILE filp, if (tex->height == 1) { if (tex_wi...
2185200cd2a910ca7f4e3fa0370c6ed8a2bdc49c
Analyze and fix the following issue in the Linux kernel code: drm: fix warning on alpha
Problem Details: From: Andrew Morton <akpm@osdl.org> On alpha: drivers/char/drm/via_dmablit.h:44: error: field `direction' has incomplete type Cc: Dave Airlie <airlied@linux.ie> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Dave Airlie <airlied@linux.ie>
```diff diff --git a/drivers/char/drm/via_dmablit.h b/drivers/char/drm/via_dmablit.h index 6486391746b1..f4036cd5d0e0 100644 --- a/drivers/char/drm/via_dmablit.h +++ b/drivers/char/drm/via_dmablit.h @@ -30,6 +30,8 @@ #ifndef _VIA_DMABLIT_H #define _VIA_DMABLIT_H +#include <linux/dma-mapping.h> + #define VIA_NUM_BL...
5fc4e6e197c7e377f1c8ebec727d40df983aceed
Analyze and fix the following issue in the Linux kernel code: Input: ibmasm - fix input initialization error path
Problem Details: Do not try to free device that has already been unregistered, input_unregister_device() frees it automatically. Spotted by Vernon Mauery <vernux@us.ibm.com> Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
```diff diff --git a/drivers/misc/ibmasm/remote.c b/drivers/misc/ibmasm/remote.c index 1abd0c58ae27..0f9e3aa34d07 100644 --- a/drivers/misc/ibmasm/remote.c +++ b/drivers/misc/ibmasm/remote.c @@ -270,6 +270,7 @@ int ibmasm_init_remote_input_dev(struct service_processor *sp) err_unregister_mouse_dev: input_unregist...
3b212db9217d02e623eaa12f41c9b5f8c6a99535
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: Some ppc compile fixes...
Problem Details: This gets most of the Fedora rawhide RPM building again, as long as I disable CHRP. Signed-off-by: Paul Mackerras <paulus@samba.org>
```diff diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 17c1b6aa44bc..935d96571515 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -412,7 +412,7 @@ config PPC_MPC106 config GENERIC_TBSYNC bool - default y if CONFIG_PPC32 && CONFIG_SMP + default y if PPC32 && SMP default n source...
8b4ad5e3ff94409973e824716c65568f0d97364c
Analyze and fix the following issue in the Linux kernel code: [MUTEX]: linux/mutex-debug.h needs linux/linkage.h
Problem Details: For FASTCALL() define. Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/include/linux/mutex-debug.h b/include/linux/mutex-debug.h index 0ccd8f983b50..8138d9eb58ec 100644 --- a/include/linux/mutex-debug.h +++ b/include/linux/mutex-debug.h @@ -1,6 +1,8 @@ #ifndef __LINUX_MUTEX_DEBUG_H #define __LINUX_MUTEX_DEBUG_H +#include <linux/linkage.h> + /* * Mutexes - debug...
13b8a272297b29870d5bf5f8db7a381dd9e82382
Analyze and fix the following issue in the Linux kernel code: powerpc: Introduce a new config symbol to control 16550 early debug code
Problem Details: The previous change by Kumar Gala in this area led to legacy_serial.c and udbg_16550.c being built as modules when CONFIG_SERIAL_8250=m. Fix this by introducing a new symbol, CONFIG_PPC_UDBG_16550, to control whether these files get built, and arrange for it to be selected for those platforms that need...
```diff diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 28004f002ec9..17c1b6aa44bc 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -275,6 +275,7 @@ config PPC_PSERIES select PPC_I8259 select PPC_RTAS select RTAS_ERROR_LOGGING + select PPC_UDBG_16550 default y config PPC_CHRP @@...
cdade109d36b5f958fdc93f31ae8b472afeab6ef
Analyze and fix the following issue in the Linux kernel code: [SPARC64]: Fix sys_fstat64() entry in 64-bit syscall table.
Problem Details: Noticed by Jakub Jelinek. Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/arch/sparc64/kernel/systbls.S b/arch/sparc64/kernel/systbls.S index 53eaf2345fe9..4821ef1ea07a 100644 --- a/arch/sparc64/kernel/systbls.S +++ b/arch/sparc64/kernel/systbls.S @@ -98,7 +98,7 @@ sys_call_table: .word sys_umount, sys_setgid, sys_getgid, sys_signal, sys_geteuid /*50*/ .word sys_geteg...
0f17574a651884c721e1a33051719e59deb13c18
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc/pseries: dlpar-add crash on null pointer deref
Problem Details: This fixes a crash on null-pointer deref during dlpar slot addition. Signed-off-by: Linas Vepstas <linas@austin.ibm.com> Signed-off-by: Paul Mackerras <paulus@samba.org> (cherry picked from 1c87c0f84943fbbc91826967ff4fea1b059a526f commit)
```diff diff --git a/arch/powerpc/platforms/pseries/eeh.c b/arch/powerpc/platforms/pseries/eeh.c index 136365c1f8e1..17cea7f2afd3 100644 --- a/arch/powerpc/platforms/pseries/eeh.c +++ b/arch/powerpc/platforms/pseries/eeh.c @@ -698,7 +698,7 @@ static void *early_enable_eeh(struct device_node *dn, void *data) int enabl...
18eb3b398d92028e6f09f0423aa4e2a7b1096db3
Analyze and fix the following issue in the Linux kernel code: powerpc: Fix up some compile errors in the PCI error recovery code
Problem Details: <asm/systemcfg.h> is gone now, and the PCI error recovery constants in include/linux/pci.h changed their names in the process of getting accepted. Signed-off-by: Paul Mackerras <paulus@samba.org> (cherry picked from 5a2516156c591fc3d2059fbd93f97e15eb6010d6 commit)
```diff diff --git a/arch/powerpc/platforms/pseries/eeh_cache.c b/arch/powerpc/platforms/pseries/eeh_cache.c index 71b2187581a3..d4a402c5866c 100644 --- a/arch/powerpc/platforms/pseries/eeh_cache.c +++ b/arch/powerpc/platforms/pseries/eeh_cache.c @@ -26,7 +26,6 @@ #include <asm/atomic.h> #include <asm/pci-bridge.h> ...
d177c207ba16b1db31283e2d1fee7ad4a863584b
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: IOMMU: don't ioremap null addresses
Problem Details: 240-ioremap-null-ptr-test.patch Under highly unusual circumstances, a buggy driver will ask a null ptr to be ioremapped, an operation that curently succeeds but leads to later trouble. Instead, refuse to remap the null pointer. Signed-off-by: Linas Vepstas <linas@austin.ibm.com> Signed-off-by: Paul ...
```diff diff --git a/arch/powerpc/mm/pgtable_64.c b/arch/powerpc/mm/pgtable_64.c index 2ffca63602c5..7b278d83739e 100644 --- a/arch/powerpc/mm/pgtable_64.c +++ b/arch/powerpc/mm/pgtable_64.c @@ -174,7 +174,7 @@ void __iomem * __ioremap(unsigned long addr, unsigned long size, pa = addr & PAGE_MASK; size = PAGE_ALIGN...
821b537fd7bf9018f1df4b882cea199613147f65
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: bugfix: fill in uninitialized field
Problem Details: 235-eeh-set-pcidev-bugfix.patch The pci device field of the pci_dn struct should be initialized to a valid value. Signed-off-by: Linas Vepstas <linas@austin.ibm.com> Signed-off-by: Paul Mackerras <paulus@samba.org> (cherry picked from beb45c93d494a11c36e5b24f638e610db8428b54 commit)
```diff diff --git a/arch/powerpc/platforms/pseries/eeh_cache.c b/arch/powerpc/platforms/pseries/eeh_cache.c index 9fe2a7de04c0..ff6c938f424b 100644 --- a/arch/powerpc/platforms/pseries/eeh_cache.c +++ b/arch/powerpc/platforms/pseries/eeh_cache.c @@ -307,6 +307,9 @@ void __init pci_addr_cache_build(void) /* Save the...
f751f84164bec4f38037b221a194c54d96c73d06
Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: remove bogus printk
Problem Details: 233-eeh-buid-fix.patch Remove un-desired warning print from EEH code. Signed-off-by: Linas Vepstas <linas@austin.ibm.com> Signed-off-by: Paul Mackerras <paulus@samba.org> (cherry picked from 241239e6aff69788a177d97c5d06fe9995c74cca commit)
```diff diff --git a/arch/powerpc/platforms/pseries/eeh.c b/arch/powerpc/platforms/pseries/eeh.c index 46ea4acd9906..be9814075254 100644 --- a/arch/powerpc/platforms/pseries/eeh.c +++ b/arch/powerpc/platforms/pseries/eeh.c @@ -824,12 +824,10 @@ void eeh_add_device_early(struct device_node *dn) if (!dn || !PCI_DN(dn))...
e82443c092fc37a907c117d36f44b6fe143567ae
Analyze and fix the following issue in the Linux kernel code: Documentation/filesystems/proc.txt: indentation fix
Problem Details: Signed-off-by: Adrian Bunk <bunk@stusta.de>
```diff diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt index a4dcf42c2fd9..944cf109a6f5 100644 --- a/Documentation/filesystems/proc.txt +++ b/Documentation/filesystems/proc.txt @@ -418,7 +418,7 @@ VmallocChunk: 111088 kB Dirty: Memory which is waiting to get written back ...
695ca07bf1036091eff2f11d2fe5f1585c2ac8c8
Analyze and fix the following issue in the Linux kernel code: [SPARC64]: Fix ptrace/strace
Problem Details: Don't clobber register %l0 while checking TI_SYS_NOERROR value in syscall return path. This bug was introduced by: db7d9a4eb700be766cc9f29241483dbb1e748832 Problem narrowed down by Luis F. Ortiz and Richard Mortimer. I tried using %l2 as suggested by Luis and that works for me. Looking at the code...
```diff diff --git a/arch/sparc64/kernel/entry.S b/arch/sparc64/kernel/entry.S index 11a848402fb1..710002991888 100644 --- a/arch/sparc64/kernel/entry.S +++ b/arch/sparc64/kernel/entry.S @@ -1657,13 +1657,10 @@ ret_sys_call: /* Check if force_successful_syscall_return() * was invoked. */ - ldub [%curptr + TI_S...
cfacb0577e319b02ed42685a0a8e0f1657ac461b
Analyze and fix the following issue in the Linux kernel code: [IPV4]: ip_output.c needs xfrm.h
Problem Details: This patch fixes a warning from my IPsec patches: CC net/ipv4/ip_output.o net/ipv4/ip_output.c: In function 'ip_finish_output': net/ipv4/ip_output.c:208: warning: implicit declaration of function 'xfrm4_output_finish' Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Mi...
```diff diff --git a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c index c2169b47ddfd..3324fbfe528a 100644 --- a/net/ipv4/ip_output.c +++ b/net/ipv4/ip_output.c @@ -69,6 +69,7 @@ #include <net/ip.h> #include <net/protocol.h> #include <net/route.h> +#include <net/xfrm.h> #include <linux/skbuff.h> #include <net/sock.h...
29f1df6cc1c3ee3530939f0e38d80a9b50645ba5
Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED]: Fix qdisc return code.
Problem Details: The mapping between TC_ACTION_SHOT and the qdisc return codes is better suited to NET_XMIT_BYPASS so as not to confuse TCP Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/sched/sch_cbq.c b/net/sched/sch_cbq.c index 09453f997d8c..6cd81708bf71 100644 --- a/net/sched/sch_cbq.c +++ b/net/sched/sch_cbq.c @@ -257,7 +257,7 @@ cbq_classify(struct sk_buff *skb, struct Qdisc *sch, int *qerr) (cl = cbq_class_lookup(q, prio)) != NULL) return cl; - *qerr = NET_XMI...
c1854ebc7f13b23c3d6a6e641a1a1db1116ca998
Analyze and fix the following issue in the Linux kernel code: [AX25] mkiss: Drop spinlock before sleeping call.
Problem Details: With the previous missing-unlock fix the spinlock is dropped only after the tty->driver->write() call which might sleep. Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c index 41b3d83c2ab8..f4424cf886c5 100644 --- a/drivers/net/hamradio/mkiss.c +++ b/drivers/net/hamradio/mkiss.c @@ -515,6 +515,7 @@ static void ax_encaps(struct net_device *dev, unsigned char *icp, int len) count = kiss_esc(p, (unsigned ...
09a626600b437d91f6b13ade5c7c4b374893c54e
Analyze and fix the following issue in the Linux kernel code: [NET]: Change some "if (x) BUG();" to "BUG_ON(x);"
Problem Details: This changes some simple "if (x) BUG();" statements to "BUG_ON(x);" Signed-off-by: Kris Katterjohn <kjak@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/core/dev.c b/net/core/dev.c index 5081287923d5..bf66b114d3c2 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1092,15 +1092,12 @@ int skb_checksum_help(struct sk_buff *skb, int inward) goto out; } - if (offset > (int)skb->len) - BUG(); + BUG_ON(offset > (int)skb->len); csum = skb...
4bba3925924148c24fb0c7636a04ad69a6a56b84
Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED]: Prefix tc actions with act_
Problem Details: Clean up the net/sched directory a bit by prefix all actions with act_. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/sched/Makefile b/net/sched/Makefile index e48d0d456b3e..0f06aec66094 100644 --- a/net/sched/Makefile +++ b/net/sched/Makefile @@ -7,13 +7,13 @@ obj-y := sch_generic.o obj-$(CONFIG_NET_SCHED) += sch_api.o sch_fifo.o sch_blackhole.o obj-$(CONFIG_NET_CLS) += cls_api.o obj-$(CONFIG_NET_CLS_ACT...
541673c859c0d71dedaaea1c148dfe3ccccc9422
Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED]: Fix memory leak when dumping in pedit action
Problem Details: Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
```diff diff --git a/net/sched/pedit.c b/net/sched/pedit.c index b5167afec2dc..1742a68e0122 100644 --- a/net/sched/pedit.c +++ b/net/sched/pedit.c @@ -245,10 +245,12 @@ tcf_pedit_dump(struct sk_buff *skb, struct tc_action *a,int bind, int ref) t.lastuse = jiffies_to_clock_t(jiffies - p->tm.lastuse); t.expires = jif...
bcb0ad2b34daade529ce1f38eede0ea8b7309535
Analyze and fix the following issue in the Linux kernel code: [CRYPTO] sha1: Fixed off-by-64 bug in sha1_update
Problem Details: After a partial update, the done pointer is off to the right by 64 bytes. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
```diff diff --git a/crypto/sha1.c b/crypto/sha1.c index 8048e2dd3c14..21571ed35b7e 100644 --- a/crypto/sha1.c +++ b/crypto/sha1.c @@ -61,8 +61,8 @@ static void sha1_update(void *ctx, const u8 *data, unsigned int len) u32 temp[SHA_WORKSPACE_WORDS]; if (partial) { - done = 64 - partial; - memcpy(sctx->buffer...
827c3911d8551842900f44c9a139382bcae68e6e
Analyze and fix the following issue in the Linux kernel code: [CRYPTO] cipher: Align temporary buffer in cbc_process_decrypt
Problem Details: Since the temporary buffer is used as an argument to cia_decrypt, it must be aligned by cra_alignmask. This bug was found by linux@horizon.com. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
```diff diff --git a/crypto/cipher.c b/crypto/cipher.c index dfd4bcfc5975..65bcea0cd17c 100644 --- a/crypto/cipher.c +++ b/crypto/cipher.c @@ -212,9 +212,10 @@ static unsigned int cbc_process_decrypt(const struct cipher_desc *desc, struct crypto_tfm *tfm = desc->tfm; void (*xor)(u8 *, const u8 *) = tfm->crt_u.ciphe...
2df15fffc612b53b2c8e4ff3c981a82441bc00ae
Analyze and fix the following issue in the Linux kernel code: [PADLOCK] Fix sparse warning about 1-bit signed bit-field
Problem Details: Change the bit-field in struct cword to unsigned to shut sparse up. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
```diff diff --git a/drivers/crypto/padlock.h b/drivers/crypto/padlock.h index 3cf2b7a12348..b78489bc298a 100644 --- a/drivers/crypto/padlock.h +++ b/drivers/crypto/padlock.h @@ -17,7 +17,7 @@ /* Control word. */ struct cword { - int __attribute__ ((__packed__)) + unsigned int __attribute__ ((__packed__)) rounds...
92898522e3ee1a0ba54140aad1974d9e868f74ae
Analyze and fix the following issue in the Linux kernel code: IB/mthca: prevent event queue overrun
Problem Details: I am seeing EQ overruns in SDP stress tests: if the CQ completion handler arms a CQ, this could generate more EQEs, so that EQ will never get empty and consumer index will never get updated. This is similiar to what we have with command interface: /* * cmd_event() may add more commands. * The ...
```diff diff --git a/drivers/infiniband/hw/mthca/mthca_eq.c b/drivers/infiniband/hw/mthca/mthca_eq.c index e8a948f087c0..2eabb27804cd 100644 --- a/drivers/infiniband/hw/mthca/mthca_eq.c +++ b/drivers/infiniband/hw/mthca/mthca_eq.c @@ -45,6 +45,7 @@ enum { MTHCA_NUM_ASYNC_EQE = 0x80, MTHCA_NUM_CMD_EQE = 0x80, + M...
6627fa662e86c400284b64c13661fdf6bff05983
Analyze and fix the following issue in the Linux kernel code: IB/mthca: fix page shift calculation in mthca_reg_phys_mr()
Problem Details: For all pages except possibly the last one, the byte beyond the buffer end must be page aligned. Therefore, when computing the page shift to use, OR the end addresses of the buffers as well as the start addresses into the mask we check. Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il> Signed-of...
```diff diff --git a/drivers/infiniband/hw/mthca/mthca_provider.c b/drivers/infiniband/hw/mthca/mthca_provider.c index 4cc7e2846df1..30b67c200267 100644 --- a/drivers/infiniband/hw/mthca/mthca_provider.c +++ b/drivers/infiniband/hw/mthca/mthca_provider.c @@ -783,24 +783,20 @@ static struct ib_mr *mthca_reg_phys_mr(stru...
fe38ea5623d262afc0b92ea47b8a7d8c988521d2
Analyze and fix the following issue in the Linux kernel code: [ARM] 3246/1: S3C24XX - retab clock list in arch/arm/mach-s3c2410/clock.c
Problem Details: Patch from Ben Dooks Properly tabulate the clock table in arch/arm/mach-s3c2410/clock.c and put the requisite commas on the end of the structs. Fix the comment about clock enable and disable in the setup code Signed-off-by: Ben Dooks <ben-linux@fluff.org> Signed-off-by: Russell King <rmk+kernel@arm....
```diff diff --git a/arch/arm/mach-s3c2410/clock.c b/arch/arm/mach-s3c2410/clock.c index 5830ae3ddd19..fc09ba92d66a 100644 --- a/arch/arm/mach-s3c2410/clock.c +++ b/arch/arm/mach-s3c2410/clock.c @@ -253,100 +253,101 @@ struct clk s3c24xx_uclk = { /* clock definitions */ static struct clk init_clocks[] = { - { .name...
682e852e2638ed0aff84aa51181c9e5d2f939562
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix more "if ((err = foo() < 0))" typos
Problem Details: Another reason to use: ret = foo(); if (ret < 0) goto out; Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/Documentation/kprobes.txt b/Documentation/kprobes.txt index 0541fe1de704..0ea5a0c6e827 100644 --- a/Documentation/kprobes.txt +++ b/Documentation/kprobes.txt @@ -411,7 +411,8 @@ int init_module(void) printk("Couldn't find %s to plant kprobe\n", "do_fork"); return -1; } - if ((ret = register...
41ed16fa47350661da01443b8241bf6ca8080fd7
Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix sg_page_malloc() memset
Problem Details: sg_page_malloc should clear the data buffer, not that extent of mem_map. This fixes Jesper's sg_page_free "Bad page states" Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c index 221e96e2620a..78aad9582bcf 100644 --- a/drivers/scsi/sg.c +++ b/drivers/scsi/sg.c @@ -2493,7 +2493,7 @@ sg_page_malloc(int rqSz, int lowDma, int *retSzp) } if (resp) { if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO)) - memset(resp, 0, resS...
5af0c8f6a09534ebc6c56b4e5d79d0d521364750
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3326): Fix stereo and standard reporting of msp3400 (esp. for radio)
Problem Details: - Add VIDIOC_LOG_STATUS to the radio device ioctl list. - Reduce the confusion between modes and standards - Fix stereo reporting for radio. - Don't set i2c configuration if the chip doesn't support it. - Fix reporting of current standard for radio. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Sig...
```diff diff --git a/drivers/media/video/bttv-driver.c b/drivers/media/video/bttv-driver.c index f3de85251719..0e6970346788 100644 --- a/drivers/media/video/bttv-driver.c +++ b/drivers/media/video/bttv-driver.c @@ -3220,6 +3220,7 @@ static int radio_do_ioctl(struct inode *inode, struct file *file, case VIDIOCSFREQ: ...
d312a46e5340be6a89c662ac483230c0737148c9
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3324): msp3400 audio handling bug fixes.
Problem Details: - Check capabilities for audio settings (volume, balance, bass, treble, loudness, mute) - added loudness support - added missing VIDEO_AUDIO_BALANCE flags for v4l1 compatibility - do not call msp_any_detect_stereo for non-autoselect chips to retrieve the current stereo setting: that will temporarily mu...
```diff diff --git a/drivers/media/video/msp3400-driver.c b/drivers/media/video/msp3400-driver.c index 0c2ab7e9d1cc..04a05d7dd470 100644 --- a/drivers/media/video/msp3400-driver.c +++ b/drivers/media/video/msp3400-driver.c @@ -283,33 +283,57 @@ void msp_set_scart(struct i2c_client *client, int in, int out) void msp_...
f2a333148c12f9e8f0be9df052398147614f5cb8
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3318): Fixes warning: variable "ret" is used before its value is set
Problem Details: - Fixes compiling warning on kernel 2.6.15 with the Intel C compiler. - It said drivers/media/dvb/frontends/bcm3510.c(258): warning #592: variable "ret" is used before its value is set Signed-off-by: Patrick Boettcher <pb@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/dvb/frontends/bcm3510.c b/drivers/media/dvb/frontends/bcm3510.c index e9b363625c50..3b132bafd4de 100644 --- a/drivers/media/dvb/frontends/bcm3510.c +++ b/drivers/media/dvb/frontends/bcm3510.c @@ -255,7 +255,7 @@ static int bcm3510_bert_reset(struct bcm3510_state *st) bcm3510_registe...
0602fbb2c84ffea1b06ae8e677662074620f01d7
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3309): SAA7134: GPIO IRQ improvements
Problem Details: - Saa7134-core.c saa7134_irq(): Separate GPIO16 and GPIO18 handling. Call IR-remote-GPIO handler only if the GPIO IRQ is "owned" by it. Added infrastructure to branch out to a future I2C-IR IRQ handler. saa7134-core.c saa7134_hwinit2(): Enable only the one GPIO pin and edge to trigger an IRQ that is wi...
```diff diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c index d4be1fd20a36..accbc32725cf 100644 --- a/drivers/media/video/saa7134/saa7134-core.c +++ b/drivers/media/video/saa7134/saa7134-core.c @@ -539,11 +539,38 @@ static irqreturn_t saa7134_irq(int irq, void *dev_i...
19272684b8e2fff39941e4c044d26ad349dd1a69
Analyze and fix the following issue in the Linux kernel code: [PATCH] PCI: update Toshiba ohci quirk DMI table
Problem Details: I upgraded my Toshiba Satellite BIOS recently to see if it would fix an ACPI related problem I have (http://bugzilla.kernel.org/show_bug.cgi?id=5727). Unfortunately, it didn't, and moreover, Toshiba chose to change the system version in the DMI table with the update, causing the OHCI1394 related quirk...
```diff diff --git a/arch/i386/pci/fixup.c b/arch/i386/pci/fixup.c index eeb1b1f2d548..65f67070db64 100644 --- a/arch/i386/pci/fixup.c +++ b/arch/i386/pci/fixup.c @@ -413,6 +413,13 @@ static struct dmi_system_id __devinitdata toshiba_ohci1394_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_VERSION, "PSM4"), }, }, + { + ...
9f3f4681291fc88864bb27f8f3832b95bb53aae5
Analyze and fix the following issue in the Linux kernel code: [PATCH] PCI Hotplug: fix up the sysfs file in the compaq pci hotplug driver
Problem Details: The Compaq PCI Hotplug driver was creating 2 sysfs files that contained nothing but debug information, and had way more than "one value" in them. This patch converts the code to use debugfs for these files instead. Compile tested only. Cc: Kay Sievers <kay.sievers@vrfy.org> Signed-off-by: Greg Kroah...
```diff diff --git a/drivers/pci/hotplug/cpqphp.h b/drivers/pci/hotplug/cpqphp.h index 092491e25ef2..cb88404c89fe 100644 --- a/drivers/pci/hotplug/cpqphp.h +++ b/drivers/pci/hotplug/cpqphp.h @@ -317,6 +317,7 @@ struct controller { u16 vendor_id; struct work_struct int_task_event; wait_queue_head_t queue; /* sleep...
498879417756effe6dc385ee04645a83d724fdef
Analyze and fix the following issue in the Linux kernel code: [PATCH] PCI: use bus numbers sparsely, if necessary
Problem Details: Add a warning if a child bus may be inaccessible because the parent bridge has wrong secondary or subordinate bus numbers. Note that this may or may not happen on "transparent" bridges, as can be seen in bug #5557. Also, if we do not fix up the assignment of bus numbers, try to make use of the bus num...
```diff diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index 00ba6a03dca5..3c9834d80850 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -433,7 +433,7 @@ int __devinit pci_scan_bridge(struct pci_bus *bus, struct pci_dev * dev, int max { struct pci_bus *child; int is_cardbus = (dev->hdr_type ==...
0eb3bcfd088e3234f7af29e189a7900ccfdd278a
Analyze and fix the following issue in the Linux kernel code: [PATCH] pciehp: allow bridged card hotplug
Problem Details: This patch fixes bugs in the pciehp driver that prevent hot-add of a card with PCI bridges on it. Signed-off-by: Rajesh Shah <rajesh.shah@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```diff diff --git a/drivers/pci/hotplug/pciehp_pci.c b/drivers/pci/hotplug/pciehp_pci.c index 647673a7d224..4017fb03a0b8 100644 --- a/drivers/pci/hotplug/pciehp_pci.c +++ b/drivers/pci/hotplug/pciehp_pci.c @@ -34,6 +34,31 @@ #include "../pci.h" #include "pciehp.h" +static int pciehp_add_bridge(struct pci_dev *dev)...
bd62e271401c5ebf33a0dd24d89baf706f213251
Analyze and fix the following issue in the Linux kernel code: [PATCH] shpchp: fix improper wait for command completion
Problem Details: Current SHPCHP driver uses msleep_interruptible() function to wait for a command completion event. But I think this would cause an unnecessary long wait until timeout, if command completion interrupt came before task state was changed to TASK_INTERRUPTIBLE. This patch fixes this issue. With this patch,...
```diff diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h index 55b0cd15f348..ce0e9b6ce833 100644 --- a/drivers/pci/hotplug/shpchp.h +++ b/drivers/pci/hotplug/shpchp.h @@ -101,6 +101,7 @@ struct controller { u32 cap_offset; unsigned long mmio_base; unsigned long mmio_size; + volatile int cm...
f467f6187fc60c954a9509b3a3e17ef89a4f6f22
Analyze and fix the following issue in the Linux kernel code: [PATCH] shpchp: fix improper write to Command Completion Detect bit
Problem Details: Current SHPCHP driver writes a '0' to the Command Completion Detect bit to clear the Command Complete Interrupt Pending. But according to the SHPC spec (See 4.7.3.1 System Interrupts), SHPCHP driver must write '1'. This patch fixes this bug. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.c...
```diff diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index d82987f075b2..f25e11645071 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c @@ -1058,11 +1058,11 @@ static irqreturn_t shpc_isr(int IRQ, void *dev_id, struct pt_regs *regs) if (intr_loc &...
0455986cce45d28511f59a29d6cecc17d6b65720
Analyze and fix the following issue in the Linux kernel code: [PATCH] shpchp: fix improper mmio mapping
Problem Details: Current SHPCHP driver seems not to map MMIO region properly. This patch fixes this bug. This patch also cleanup the code. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```diff diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h index 08ad26a0cae7..55b0cd15f348 100644 --- a/drivers/pci/hotplug/shpchp.h +++ b/drivers/pci/hotplug/shpchp.h @@ -98,6 +98,9 @@ struct controller { enum pci_bus_speed speed; u32 first_slot; /* First physical slot number */ u8 slot_b...
87d6c5593111844f308af7d5106b3fd259b36514
Analyze and fix the following issue in the Linux kernel code: [PATCH] shpchp: fix improper reference to Mode 1 ECC Capability" bit
Problem Details: The hpc_get_mode1_ECC_cap() function of SHPCHP driver seems to refer the wrong bit for refering the "Mode 1 ECC Capability" bit. This bug seems not to cause any problem so far. But I think this should be fixed. This patch fixes this bug. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> ...
```diff diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index 3c1d3b4b0408..f5a8bf374634 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c @@ -604,7 +604,7 @@ static int hpc_get_mode1_ECC_cap(struct slot *slot, u8 *mode) sec_bus_status = readw(php_ct...
6558b6ab145ceead45632e4214cd5ef14f48f412
Analyze and fix the following issue in the Linux kernel code: [PATCH] shpchp: fix improper reference to Slot Avail Regsister
Problem Details: The hpc_get_max_bus_speed() function of the SHPCHP driver seems to refer wrong bits in the "Slot Avail Register I" and "Slot Avail Register II". This patch fixes this bug. And this also cleanup the code. Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> Signed-off-by: Greg Kroah-Hartman ...
```diff diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c index 9987a6fd65b8..3c1d3b4b0408 100644 --- a/drivers/pci/hotplug/shpchp_hpc.c +++ b/drivers/pci/hotplug/shpchp_hpc.c @@ -1121,7 +1121,6 @@ static int hpc_get_max_bus_speed (struct slot *slot, enum pci_bus_speed *value) int retva...
88d69a1dff4014889782ebad24ed3e964a8844bc
Analyze and fix the following issue in the Linux kernel code: [PATCH] PCI Hotplug: ibmphp_pci.c copy-n-paste fix
Problem Details: I noticed what appears to be a cut/paste error in drivers/pci/hotplug/ibmphp_pci.c: Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
```diff diff --git a/drivers/pci/hotplug/ibmphp_pci.c b/drivers/pci/hotplug/ibmphp_pci.c index b1ba429e0a2d..155133fe5c12 100644 --- a/drivers/pci/hotplug/ibmphp_pci.c +++ b/drivers/pci/hotplug/ibmphp_pci.c @@ -969,7 +969,7 @@ static int configure_bridge (struct pci_func **func_passed, u8 slotno) debug ("io 32\n");...
14591de147f7c9656fa2b9c05680d2b46e286c40
Analyze and fix the following issue in the Linux kernel code: [PATCH] netlink oops fix due to incorrect error code
Problem Details: Fixed oops after failed netlink socket creation. Wrong parathenses in if() statement caused err to be 1, instead of negative value. Trivial fix, not trivial to find though. Signed-Off-By: Dmitry Mishin <dim@sw.ru> Signed-Off-By: Kirill Korotaev <dev@openvz.org> Signed-Off-By: Linus Torvalds <torvald...
```diff diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 7849cac14d3a..a67f1b44c9a3 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -402,7 +402,7 @@ static int netlink_create(struct socket *sock, int protocol) groups = nl_table[protocol].groups; netlink_unlock_table(); ...
0680481c8e6260e1780a0900990531f0193b0dd4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3305): Replaces old debug msgs to newer ones
Problem Details: - Replaces old debug msgs from bt832, tda743d and tda9875 to newer ones as defined under v4l2-common.h. Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/bt832.c b/drivers/media/video/bt832.c index d2cb5ccff56b..dda4aa6bef27 100644 --- a/drivers/media/video/bt832.c +++ b/drivers/media/video/bt832.c @@ -30,8 +30,9 @@ #include <linux/init.h> #include <linux/errno.h> #include <linux/slab.h> - #include <media/audiochip.h> +#inclu...
009494effc129094a5dcbbf2bf0345307ffe4f9b
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3296): Fixes a bug at compat_ioctl32 kernel module
Problem Details: - There is a bug in the ioctl translations from 32bit userspace to 64bit kernelspace in do_set_window(). - The video window (vw) should be passed to native_ioctl() instead of the video clip. Signed-off-by: Guy Martin <gmsoft@tuxicoman.be> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/compat_ioctl32.c b/drivers/media/video/compat_ioctl32.c index 27945e082195..6194b0125576 100644 --- a/drivers/media/video/compat_ioctl32.c +++ b/drivers/media/video/compat_ioctl32.c @@ -489,7 +489,7 @@ static int do_set_window(struct file *file, unsigned int cmd, unsigned long a...
b7f355d23c34399ccfd54fd613c306ab4a788234
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3293): Added digital support for cx88 (cx88-alsa)
Problem Details: - This module is co-authored by Ricardo Cerqueira <v4l@cerqueira.org>. - Added digital audio support for cx88-based boards that have function 01 enabled. These boards can be identified by having PCI id 1471:8801 or 1471:8811. - Increased DMA buffer from 512 to 4096 seems to fix audio distortion....
```diff diff --git a/drivers/media/video/cx88/Kconfig b/drivers/media/video/cx88/Kconfig index ec6201a32aca..76fcb4e995c9 100644 --- a/drivers/media/video/cx88/Kconfig +++ b/drivers/media/video/cx88/Kconfig @@ -29,6 +29,21 @@ config VIDEO_CX88_DVB You must also select one or more DVB/ATSC demodulators. If you a...
0de71224d17f43101fa20696a8d7a78fb599557e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3292): Fix signed/unsigned bug in brightness handling of cx25840
Problem Details: - Fix signed/unsigned bug in brightness handling (set to 0 and 128 was returned). Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c index b93495b2a1fb..29b378b6097d 100644 --- a/drivers/media/video/cx25840/cx25840-core.c +++ b/drivers/media/video/cx25840/cx25840-core.c @@ -457,7 +457,7 @@ static int get_v4lctrl(struct i2c_client *client, str...
c5099a6481d2d0f9455abd15c91f73c2ced57a40
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3291): Fix signed/unsigned bug in hue handling
Problem Details: - Fix signed/unsigned bug in hue handling (set to -127 and 129 was returned). Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c index d7ece6eecb5c..b93495b2a1fb 100644 --- a/drivers/media/video/cx25840/cx25840-core.c +++ b/drivers/media/video/cx25840/cx25840-core.c @@ -466,7 +466,7 @@ static int get_v4lctrl(struct i2c_client *client, str...
82a1c359e8cc15d836c139626d747bfdfc408450
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3195): Fix for 64-bit compile warning
Problem Details: - Add the fix for the saa7146 64-bit compile warning (again). This time with comments and checked by Johannes Stezenbach. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/common/saa7146_hlp.c b/drivers/media/common/saa7146_hlp.c index ec52dff8cb69..33bec8a6843b 100644 --- a/drivers/media/common/saa7146_hlp.c +++ b/drivers/media/common/saa7146_hlp.c @@ -562,19 +562,26 @@ static void saa7146_set_position(struct saa7146_dev *dev, int w_x, int w_y, int ...
400b7083fbcc8e7a1157a82aa126977179873268
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3194): Revert one 64-bit fix and improved other 64-bit fixes
Problem Details: - Reverted objectionable fix in saa7146_hlp.c - Merged in improved dvb 64-bit fixes from Peter Beutner. Signed-off-by: Peter Beutner <p.beutner@gmx.net> Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/common/saa7146_hlp.c b/drivers/media/common/saa7146_hlp.c index be34ec430470..ec52dff8cb69 100644 --- a/drivers/media/common/saa7146_hlp.c +++ b/drivers/media/common/saa7146_hlp.c @@ -562,7 +562,7 @@ static void saa7146_set_position(struct saa7146_dev *dev, int w_x, int w_y, int i...
66190a275246c8c5be140a224e021f8f5eb85ab6
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3281): av7110 driver: improved recovery from ARM crash and crash detection
Problem Details: - Improved recovery from ARM crash and the way a crash is detected. Minor white space clean-up, debug output fixed. Signed-off-by: Oliver Endriss <o.endriss@gmx.de> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/dvb/ttpci/av7110.c b/drivers/media/dvb/ttpci/av7110.c index eabd4fcaf246..39b4bfa0ab7b 100644 --- a/drivers/media/dvb/ttpci/av7110.c +++ b/drivers/media/dvb/ttpci/av7110.c @@ -196,17 +196,15 @@ static void recover_arm(struct av7110 *av7110) av7110_bootarm(av7110); msleep(100); -...
0e7072ef6623c3dc58faf3f7310aba77b0a5845e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3277): Fix incorrect filename reference in top comments
Problem Details: - Fix incorrect filename reference in top comments Signed-off-by: Michael Krufky <mkrufky@m1k.net> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/em28xx/em28xx.h b/drivers/media/video/em28xx/em28xx.h index f99ee8eb5577..33de9d846af5 100644 --- a/drivers/media/video/em28xx/em28xx.h +++ b/drivers/media/video/em28xx/em28xx.h @@ -1,5 +1,5 @@ /* - em28xx-cards.c - driver for Empia EM2800/EM2820/2840 USB video capture device...
6ce17c57f84731d288107ce29ce468311edd87f4
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3260): Using new firmware for the WideView Stick
Problem Details: - A new firmware fixes VHF tuning issues. This changes the firmware file name in the driver. Signed-off-by: Patrick Boettcher <pb@linuxtv.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/dvb/dvb-usb/dtt200u.c b/drivers/media/dvb/dvb-usb/dtt200u.c index 54c436996512..130ea7f21f5e 100644 --- a/drivers/media/dvb/dvb-usb/dtt200u.c +++ b/drivers/media/dvb/dvb-usb/dtt200u.c @@ -160,7 +160,7 @@ static struct dvb_usb_properties wt220u_properties = { .pid_filter_count = 15, ...
8a854284d09dd3b3d8660762b43546058da5372f
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3253): Add V4L2 commands to tvaudio
Problem Details: - debug messages changed to be like the other modules - Add V4L2 commands VIDIOC_S_TUNER, VIDIOC_G_TUNER, VIDIOC_S_STD and VIDIOC_S_FREQUENCY. Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/tvaudio.c b/drivers/media/video/tvaudio.c index 19625e6410d1..2bdbb39bff0f 100644 --- a/drivers/media/video/tvaudio.c +++ b/drivers/media/video/tvaudio.c @@ -46,16 +46,18 @@ MODULE_LICENSE("GPL"); #define UNSET (-1U) -#define tvaudio_info(fmt, arg...) do {\ - printk(KERN...
21dcd8ccd76e80118f524b1a730c35ab1c46c09e
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3234): Included advanced debug option to tvp5150.c
Problem Details: - Included advanced debug option to tvp5150.c - Now, advanced debug info is the first item at V4L menu. Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index c89cc0a922ee..2fe260fff85d 100644 --- a/drivers/media/video/Kconfig +++ b/drivers/media/video/Kconfig @@ -7,6 +7,15 @@ menu "Video For Linux" comment "Video Adapters" +config VIDEO_ADV_DEBUG + bool "Enable advanced debug functiona...
e1bc80adaf801bf75ca176b9c1b60b3cceee1e03
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3232): Several improvements at tvp5150 driver
Problem Details: - Now reset do init tvp5150 registers to its default. - Debug messages improved. - Implemented video standard selection function. Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index d62b2302af49..9ed839d688eb 100644 --- a/drivers/media/video/tvp5150.c +++ b/drivers/media/video/tvp5150.c @@ -9,6 +9,7 @@ #include <linux/videodev.h> #include <linux/delay.h> #include <linux/video_decoder.h> +#include <media/v4l...
210e207c1d98348f5993e6f580cd20cf20086d7d
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3198): make cx25840 recover from some firmware load failures
Problem Details: - In the rare event that a 333MHz i2c firmware load fails after writing some data, this fix makes the driver reset the DL_ADDR registers to the proper values before continuing on with 100MHz transfers. Signed-off-by: Tyler Trafford <tatrafford@comcast.net> Signed-off-by: Mauro Carvalho Chehab <mchehab...
```diff diff --git a/drivers/media/video/cx25840/cx25840-firmware.c b/drivers/media/video/cx25840/cx25840-firmware.c index df9d50a75542..f43024f2aaef 100644 --- a/drivers/media/video/cx25840/cx25840-firmware.c +++ b/drivers/media/video/cx25840/cx25840-firmware.c @@ -15,7 +15,6 @@ * Foundation, Inc., 51 Franklin Stree...
889aee805a0c286e33965cc678ea16672d6c5666
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3192): Fix bttv sub-device unregister
Problem Details: - Fixes sub-device release for BTTV. Without this, DVB modules can't be reloaded Signed-off-by: Ricardo Cerqueira <v4l@cerqueira.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/video/bttv-driver.c b/drivers/media/video/bttv-driver.c index 4e25c92ac8c4..69a147b85f1a 100644 --- a/drivers/media/video/bttv-driver.c +++ b/drivers/media/video/bttv-driver.c @@ -4075,8 +4075,6 @@ static int __devinit bttv_probe(struct pci_dev *dev, } /* add subdevices */ - if ...
e18828e43a52fb9a792938840cc32cbb2a9e1a5c
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3179): Fix 64-bit compile warnings
Problem Details: - Fix 64-bit compile warnings Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
```diff diff --git a/drivers/media/common/saa7146_hlp.c b/drivers/media/common/saa7146_hlp.c index ec52dff8cb69..be34ec430470 100644 --- a/drivers/media/common/saa7146_hlp.c +++ b/drivers/media/common/saa7146_hlp.c @@ -562,7 +562,7 @@ static void saa7146_set_position(struct saa7146_dev *dev, int w_x, int w_y, int i...
67f1570a0659abba5efbf55cc986187af61bdd52
Analyze and fix the following issue in the Linux kernel code: V4L/DVB (3178): bttv VBI fixes
Problem Details: - V4L2_(G|S|TRY)_FMT returned incorrect VBI start lines for PAL-M, NTSC-JP, and PAL-60. They also returned an inaccurate VBI offset. - V4L2_(G|S)_FMT and V4L2_TRY_FMT disagreed about the start of VBI capturing in PAL and SECAM second field. Note the start line fixes may break applications using VIDIOCS...
```diff diff --git a/drivers/media/video/bttv-driver.c b/drivers/media/video/bttv-driver.c index 8bee7d5796dd..4e25c92ac8c4 100644 --- a/drivers/media/video/bttv-driver.c +++ b/drivers/media/video/bttv-driver.c @@ -210,6 +210,9 @@ const struct bttv_tvnorm bttv_tvnorms[] = { .vdelay = 0x20, .vbipack ...