id stringlengths 40 40 | instruction stringlengths 68 308 | input stringlengths 17 33.4k | output stringlengths 100 30k |
|---|---|---|---|
41aace4fe81e3da52fa80b8380e5d2d084f77691 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32: Dump error status for both PLB segments on 440SP | Problem Details:
The PowerPC 440SP SoC has two Processor Local Bus (PLB) segments (a
high-throughput segment and a low-latency segment). Fix our PLB register
definitions to cope with this, and add code to dump the status of both
segments when a machine check occurs.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
Cc... | ```diff
diff --git a/arch/ppc/syslib/ibm44x_common.c b/arch/ppc/syslib/ibm44x_common.c
index 5152c8e41340..ebae2e2fcea6 100644
--- a/arch/ppc/syslib/ibm44x_common.c
+++ b/arch/ppc/syslib/ibm44x_common.c
@@ -214,9 +214,20 @@ void __init ibm44x_platform_init(unsigned long r3, unsigned long r4, unsigned lo
/* Called from... |
46e5e4a897ade416beb0bd8447fb0ff0bc1bb329 | Analyze and fix the following issue in the Linux kernel code: [PATCH] 3c59x: fix some grammar in module parameter descriptions | Problem Details:
Correct several (apparently cut & paste) grammatical typos in module
parameter descriptions. They seem to have originated as copies of the
description for "global_options".
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torva... | ```diff
diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 0139d4b061ed..7dcc5545557b 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -939,11 +939,11 @@ MODULE_PARM_DESC(debug, "3c59x debug level (0-6)");
MODULE_PARM_DESC(options, "3c59x: Bits 0-3: media type, bit 4: bus mastering, bit 9: full ... |
4f12bb4f7715f418a9c80f89447948790f476958 | Analyze and fix the following issue in the Linux kernel code: [PATCH] slab: don't BUG on duplicated cache | Problem Details:
slab presently goes BUG if someone tries to register an already-registered
cache.
But this can happen if the user accidentally loads a module which is already
statically linked into the kernel. Nuking the kernel is rather a harsh
reaction.
Change it into a warning, and just fail the kmem_cache_alloc... | ```diff
diff --git a/mm/slab.c b/mm/slab.c
index 22bfb0b2ac8b..41e91794aa50 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1502,6 +1502,7 @@ kmem_cache_create (const char *name, size_t size, size_t align,
{
size_t left_over, slab_size, ralign;
kmem_cache_t *cachep = NULL;
+ struct list_head *p;
/*
* Sanity chec... |
863c84b97cb660dbb949398e196c0b1bbe4ed39f | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc: Fix ppc32 build after 64K pages | Problem Details:
Oops, some last minute changes caused the 64K pages patch to break ppc32
build, this fixes it.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index ca7acb0c79f0..55ce49570524 100644
--- a/arch/powerpc/Kconfig
+++ b/arch/powerpc/Kconfig
@@ -605,6 +605,7 @@ config NODES_SPAN_OTHER_NODES
config PPC_64K_PAGES
bool "64k page size"
+ depends on PPC64
help
This option changes the kernel log... |
c8e3c8b21bd7a317d071ab8cf478880e7a4f92d6 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: Fix zImage boot | Problem Details:
The zImage wrapper has a bug where it doesn't claim() the memory for the
kernel properly, it forgets to take into account the offset between the ELF
header and the kernel itself. This results on some machines, like G5s,
into a kernel that crashes at boot when clearing the BSS.
Signed-off-by: Benjamin... | ```diff
diff --git a/arch/ppc64/boot/main.c b/arch/ppc64/boot/main.c
index c1dc876bccab..e0dde24a72ce 100644
--- a/arch/ppc64/boot/main.c
+++ b/arch/ppc64/boot/main.c
@@ -203,8 +203,15 @@ void start(unsigned long a1, unsigned long a2, void *promptr, void *sp)
if (elf64ph->p_type == PT_LOAD && elf64ph->p_offset != 0)... |
732ee21f2894819781766a0cd88e32bdd630d11e | Analyze and fix the following issue in the Linux kernel code: [PATCH] POWERPC/PPC64: Fix CONFIG_SMP=n build for ppc64 | Problem Details:
Two CONFIG_SMP=n build fixes due to missing <asm/smp.h> includes.
Signed-off-by: Olof Johansson <olof@lixom.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index 6996a593dcb3..b1c89bc4bf90 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -69,6 +69,7 @@
#include <asm/iseries/it_lp_queue.h>
#include <asm/iseries/hv_call_xm.h>
#endif
+#include <asm/smp.h>
/* keep tra... |
4ecc65e423ef10bdbec12362609b15fa8e8627c8 | Analyze and fix the following issue in the Linux kernel code: [PATCH] typo correction for fix-build-on-nls-free-systems | Problem Details:
A typo fix for fix-build-on-nls-free-systems.patch that caused all systems
to be detected as not having NLS.
Signed-off-by: Yuri Vasilevski <yvasilev@duke.math.cinvestav.mx>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org> | ```diff
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 455aeabd95dd..c65c435c4923 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -118,7 +118,7 @@ clean-files := lkc_defs.h qconf.moc .tmp_qtcheck \
# Needed for systems without gettext
KBUILD_HAVE_NLS := $(shell \
- ... |
7d24f0b8a53261709938ffabe3e00f88f6498df9 | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc64: Fix bug in SLB miss handler for hugepages | Problem Details:
This patch, however, should be applied on top of the 64k-page-size patch to
fix some problems with hugepage (some pre-existing, another introduced by
this patch).
The patch fixes a bug in the SLB miss handler for hugepages on ppc64
introduced by the dynamic hugepage patch (commit id
c594adad5653491813... | ```diff
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c
index b2f3dbca6952..f15dfb92dec0 100644
--- a/arch/powerpc/mm/hash_utils_64.c
+++ b/arch/powerpc/mm/hash_utils_64.c
@@ -329,12 +329,14 @@ static void __init htab_init_page_sizes(void)
*/
if (mmu_psize_defs[MMU_PAGE_16M].shift)
... |
7945619794314414a5c44df11fca4d3f2a3389cf | Analyze and fix the following issue in the Linux kernel code: sbp2_command_orb_lock must be held when accessing the _orb_inuse list. | Problem Details:
Fixes an oops in sbp2util_find_command_for_SCpnt after sbp2scsi_abort:
https://bugzilla.novell.com/show_bug.cgi?id=113734
Signed-off-by: Jody McIntyre <scjody@steamballoon.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> | ```diff
diff --git a/drivers/ieee1394/sbp2.c b/drivers/ieee1394/sbp2.c
index 12cec7c4a342..f7e18ccc5c0a 100644
--- a/drivers/ieee1394/sbp2.c
+++ b/drivers/ieee1394/sbp2.c
@@ -2350,6 +2350,7 @@ static int sbp2_handle_status_write(struct hpsb_host *host, int nodeid, int dest
struct scsi_cmnd *SCpnt = NULL;
u32 scsi_s... |
63786d064ca7dd7ccaf29d2a46ad269ad2df8041 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ice1724 - Fix ADC mux put callback in aureon.c | Problem Details:
Modules: ICE1712 driver
Fix the return value of ADC mux put callback in aureon.c.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/ice1712/aureon.c b/sound/pci/ice1712/aureon.c
index 40b48186767e..db12b038286b 100644
--- a/sound/pci/ice1712/aureon.c
+++ b/sound/pci/ice1712/aureon.c
@@ -960,7 +960,7 @@ static int wm_adc_mux_put(snd_kcontrol_t * kcontrol, snd_ctl_elem_value_t *ucont
if (change)
wm_put(ice, WM_ADC_... |
c3348760aaffd268f7e91b2185999025fdc5607f | Analyze and fix the following issue in the Linux kernel code: [PATCH] Fix wrong irq enable via rtc_control() | Problem Details:
rtc_control() may be called in the interrupt context in ALSA rtc-timer
driver. The patch fixes the wrong irq enable in rtc.c, and also fixes
the possible race of bit flags.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index 63fff7c1244a..a7f099fb7dfe 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -149,8 +149,22 @@ static void get_rtc_alm_time (struct rtc_time *alm_tm);
#ifdef RTC_IRQ
static void rtc_dropped_irq(unsigned long data);
-static void set_rtc_irq... |
ea17629f3e6f64591a98a9049a0d725d2672509c | Analyze and fix the following issue in the Linux kernel code: [MTD] maps ixp2000: fix compile warnings in ixp2000 map driver | Problem Details:
Fix two compile warnings that occur because of treating two
'unsigned long's as 'void *'s.
Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/maps/ixp2000.c b/drivers/mtd/maps/ixp2000.c
index 00b9f67580f1..78c68f49be83 100644
--- a/drivers/mtd/maps/ixp2000.c
+++ b/drivers/mtd/maps/ixp2000.c
@@ -1,5 +1,5 @@
/*
- * $Id: ixp2000.c,v 1.6 2005/03/18 14:07:46 gleixner Exp $
+ * $Id: ixp2000.c,v 1.8 2005/11/07 08:09:02 gleixner Exp... |
2249ca9d60d3a8a1f6f223f0f0a0283fcb7ce33e | Analyze and fix the following issue in the Linux kernel code: powerpc: Various UP build fixes | Problem Details:
Mostly this involves adding #include <asm/smp.h>, since that defines
things like boot_cpuid[_phys] and [gs]et_hard_smp_processor_id, which
are SMP-related but still needed on UP. This incorporates fixes
posted by Olof Johansson and Heikki Lindholm.
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
index b7fc2d884950..751f5ddea913 100644
--- a/arch/powerpc/kernel/rtas.c
+++ b/arch/powerpc/kernel/rtas.c
@@ -608,7 +608,6 @@ asmlinkage int ppc_rtas(struct rtas_args __user *uargs)
return 0;
}
-#ifdef CONFIG_SMP
/* This version can't ta... |
dcad47fc423ac9f4934579af814fa2dad5c8081b | Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: Kill ppcdebug | Problem Details:
The ancient ppcdebug/PPCDBG mechanism is now only used in two places.
First, in the hash setup code, one of the bits allows the size of the
hash table to be reduced by a factor of 8 - which would be better
accomplished with a command line option for that purpose. The other
was a bunch of bus walking r... | ```diff
diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c
index 6b52cce872be..5f8154f95f96 100644
--- a/arch/powerpc/kernel/setup_64.c
+++ b/arch/powerpc/kernel/setup_64.c
@@ -41,7 +41,6 @@
#include <asm/elf.h>
#include <asm/machdep.h>
#include <asm/paca.h>
-#include <asm/ppcdebug.h>
#inc... |
c6d95044a2e124b606b78896a3a2d512e90ef65c | Analyze and fix the following issue in the Linux kernel code: [PATCH] ppc32 8xx: fix m8xx_wdt accessor macro update | Problem Details:
The following patch against m8xx_wdt.c adds <asm/io.h> (required for
out,in_be32/16) and fixes syntatic problems introduced with the IO
accessor macro update.
Signed-off-by: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Signed-off-by: Paul Mackerras <paulus@samba.org> | ```diff
diff --git a/arch/ppc/syslib/m8xx_wdt.c b/arch/ppc/syslib/m8xx_wdt.c
index c5ac5ce5d7d2..a21632d37e5a 100644
--- a/arch/ppc/syslib/m8xx_wdt.c
+++ b/arch/ppc/syslib/m8xx_wdt.c
@@ -14,6 +14,7 @@
#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/sched.h>
+#include <asm/io.h>
#include <asm/8xx_im... |
9d2ba6faa1c2e10546a4bdf0f9687436d7681b2f | Analyze and fix the following issue in the Linux kernel code: [PATCH] powerpc: Fix i8259 cascade IRQ | Problem Details:
setup_irq() aborts immediately if there's no handler for the IRQ in
question. So i8259_init() should set up its handlers before trying to
set up the cascade on IRQ 2.
With this and the patch I sent a few days ago to fix initrd on ppc32, my
Pegasos now runs the arch/powerpc kernel.
Signed-off-by: Davi... | ```diff
diff --git a/arch/powerpc/sysdev/i8259.c b/arch/powerpc/sysdev/i8259.c
index 90bce6e0c191..b7ac32fdd776 100644
--- a/arch/powerpc/sysdev/i8259.c
+++ b/arch/powerpc/sysdev/i8259.c
@@ -207,6 +207,9 @@ void __init i8259_init(unsigned long intack_addr, int offset)
spin_unlock_irqrestore(&i8259_lock, flags);
+... |
49196f3332e661ccc221734c3103115d8cd4ee49 | Analyze and fix the following issue in the Linux kernel code: [MTD] NAND nand_base: Fix shift for bad block check (16bit devices only) | Problem Details:
In case of an odd offset, the result was shifted by 1 instead of 8
Signed-off-by: Vitaly Wool <vwool@ru.mvista.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index 4e22317397e8..c7b1ce38c63c 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -433,7 +433,7 @@ static int nand_block_bad(struct mtd_info *mtd, loff_t ofs, int getchip)
this->cmdfunc (mtd, NAND_CMD_READ... |
46d0d0fb61ec6630dc2c844e3c5bf5ef44dedcbe | Analyze and fix the following issue in the Linux kernel code: [MTD] OneNAND/Kconfig: Fix dependencies | Problem Details:
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/onenand/Kconfig b/drivers/mtd/onenand/Kconfig
index 0b2b29320c02..126ff6bf63d5 100644
--- a/drivers/mtd/onenand/Kconfig
+++ b/drivers/mtd/onenand/Kconfig
@@ -24,11 +24,10 @@ config MTD_ONENAND_VERIFY_WRITE
flipped accidentaly due to device wear or something else.
config MTD_ONENA... |
8b37b94721533f2729c79bcb6fa0bb3e2bc2f400 | Analyze and fix the following issue in the Linux kernel code: [IB] umad: two small fixes | Problem Details:
Two small fixes for the umad module:
- set kobject name for issm device properly
- in ib_umad_add_one(), s is subtracted from the index i when
initializing ports, so s should be subtracted from the index when
freeing ports in the error path as well.
Signed-off-by: Michael S. Tsirkin <mst@mella... | ```diff
diff --git a/drivers/infiniband/core/user_mad.c b/drivers/infiniband/core/user_mad.c
index aed5ca23fb22..6aefeed42ab3 100644
--- a/drivers/infiniband/core/user_mad.c
+++ b/drivers/infiniband/core/user_mad.c
@@ -801,7 +801,7 @@ static int ib_umad_init_port(struct ib_device *device, int port_num,
goto err_clas... |
28f462308e0fcd30dcab4c50862881dfb68a627c | Analyze and fix the following issue in the Linux kernel code: [MTD] maps/ts5500: Fix partition support. Code cleanup | Problem Details:
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/maps/ts5500_flash.c b/drivers/mtd/maps/ts5500_flash.c
index 286dd82e8b83..2762da954318 100644
--- a/drivers/mtd/maps/ts5500_flash.c
+++ b/drivers/mtd/maps/ts5500_flash.c
@@ -23,20 +23,18 @@
* - If you have created your own jffs file system and the bios overwrites
* it during boot... |
6f6ed056d2d5de7af9f0c14cf5bc73707eeb0a88 | Analyze and fix the following issue in the Linux kernel code: [MTD] chips/cfi_cmdset_0001: fix for P30 cfi parsing | Problem Details:
Change to the extended cfi table parsing for Intel NOR flash that uses
the info in the extended table to 'walk' the table rather than using
hard coding for various primary extended query table version numbers.
From: Jared Hulbert <jaredeh@gmail.com>
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-o... | ```diff
diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c
index adaad7c8fd46..61a2ec9901e2 100644
--- a/drivers/mtd/chips/cfi_cmdset_0001.c
+++ b/drivers/mtd/chips/cfi_cmdset_0001.c
@@ -4,7 +4,7 @@
*
* (C) 2000 Red Hat. GPL'd
*
- * $Id: cfi_cmdset_0001.c,v 1.183 2005/08/06 04:... |
008531f4c30dce606094be8f78c766218edd6754 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Fix broken compile when debug level = 2 | Problem Details:
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.h b/fs/jffs2/debug.h
index da1417d38914..b47ba9f1d606 100644
--- a/fs/jffs2/debug.h
+++ b/fs/jffs2/debug.h
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.h,v 1.18 2005/09/21 10:26:26 dedekind Exp $
+ * $Id: debug.h,v 1.... |
cfd320fbfcf2ff0137d8e26f46ba4b66dae96083 | Analyze and fix the following issue in the Linux kernel code: [MTD] NAND s3c2410.c: Fix timing calculation bugs | Problem Details:
Spotted by basprog@mail.ru
Signed-off-by: Ben Dooks <ben-linux@fluff.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index 41f2078225a5..24f4199eaee8 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -17,8 +17,9 @@
* 02-May-2005 BJD Reduced hwcontrol decode
* 20-Jun-2005 BJD Updated s3c2440 support, fixed timing bug
* 08-J... |
d574504114753f52d8d2a8a0f186d2a5fcd80789 | Analyze and fix the following issue in the Linux kernel code: [MTD] NAND s3c2410.c: Fix missing dev parameter to dev_err | Problem Details:
Signed-off-by: Ben Dooks <ben@simtec.co.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
index a44458fd422f..41f2078225a5 100644
--- a/drivers/mtd/nand/s3c2410.c
+++ b/drivers/mtd/nand/s3c2410.c
@@ -18,7 +18,7 @@
* 20-Jun-2005 BJD Updated s3c2440 support, fixed timing bug
* 08-Jul-2005 BJD Fix OOPS when no platform data su... |
daba5cc4bcd025a9b4fd02a9117c71bfd400d811 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Fix dataflash support | Problem Details:
- assume wbuf may be of size which is not power of 2
- don't make strange assumption about not padding wbuf for DataFlash
- use wbuf = DataFlash page and eraseblock >= 8 Dataflash pages
From: Peter Menzebach <pm-mtd@mw-itcon.de>
Acked-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Tho... | ```diff
diff --git a/fs/jffs2/os-linux.h b/fs/jffs2/os-linux.h
index 48ad4202fbb1..04d4167ab252 100644
--- a/fs/jffs2/os-linux.h
+++ b/fs/jffs2/os-linux.h
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: os-linux.h,v 1.63 2005/09/21 11:55:21 dedekind Exp $
+ * $I... |
1555972231f3202f00e04f7c42d2db858e11b874 | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix /proc/cpuinfo format for ARM SMP | Problem Details:
glibc expects to count lines beginning with "processor" to determine
the number of processors, not lines beginning with "Processor". So,
give glibc the format it expects.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index a6d7fb81330e..85774165e9fd 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -839,7 +839,12 @@ static int c_show(struct seq_file *m, void *v)
#if defined(CONFIG_SMP)
for_each_online_cpu(i) {
- seq_printf(m, "Processor... |
81e39cf0297c7f32fb8869af9ae199130208ae6f | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Debug message format clean up | Problem Details:
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.c b/fs/jffs2/debug.c
index 9b776b5a7604..28983501bcef 100644
--- a/fs/jffs2/debug.c
+++ b/fs/jffs2/debug.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.c,v 1.9 2005/08/05 10:42:24 dedekind Exp $
+ * $Id: debug.c,v 1.1... |
d36d63d404b75ddf231da0dbd3640e6d1722b4ab | Analyze and fix the following issue in the Linux kernel code: [PATCH] OneNAND: Fix bug in write verify | Problem Details:
- Remove unused block, page parameters
- Add constant instead of runtime value
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/drivers/mtd/onenand/onenand_base.c b/drivers/mtd/onenand/onenand_base.c
index bdeac01e659f..75d757882697 100644
--- a/drivers/mtd/onenand/onenand_base.c
+++ b/drivers/mtd/onenand/onenand_base.c
@@ -719,13 +719,10 @@ out:
* onenand_verify_page - [GENERIC] verify the chip contents after a write
*... |
4fe15ba08fdb280536bd7019e8505969c4ac6852 | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix second missing declaration of cache_is_vivt() | Problem Details:
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index c445b0a848b2..dceb826bd216 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -41,7 +41,6 @@
#include <linux/device.h>
#include <linux/init.h>
-#include <asm/cacheflush.h>
#include <asm/dma.h>
#include <asm/ecard.h>
#... |
f0507530cbedf37515e0d803c332cdb81b34e71a | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Solve BUG caused by frag->node representing a hole in fragtree | Problem Details:
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/nodelist.c b/fs/jffs2/nodelist.c
index fd21f109fbd2..9abb5f4cfd75 100644
--- a/fs/jffs2/nodelist.c
+++ b/fs/jffs2/nodelist.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: nodelist.c,v 1.111 2005/08/17 14:57:39 dedekind Exp $
+ * $... |
3a69e0cd22cf34920508a4032d53e41251925f53 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Fix JFFS2 [mc]time handling | Problem Details:
From: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c
index 5738df223775..0fd15aaf2458 100644
--- a/fs/jffs2/dir.c
+++ b/fs/jffs2/dir.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: dir.c,v 1.87 2005/07/17 11:13:46 dedekind Exp $
+ * $Id: dir.c,v 1.88 2005/08/1... |
12baa4202d74d799f4f8a4bd0455b485e4f8e876 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ipr: Fix adapter microcode update DMA mapping leak | Problem Details:
If the write buffer command that is issued to the ipr adapter
to update its microcode fails for some reason, the DMA buffer
will never get unmapped. Move the pci_map/unmap out of the
IOA reset job so that the buffer is always clearly mapped
and unmapped.
Signed-off-by: Brian King <brking@us.ibm.com>
S... | ```diff
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index ad13ae11e2e6..72b588d65562 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -2351,31 +2351,24 @@ static int ipr_copy_ucode_buffer(struct ipr_sglist *sglist,
}
/**
- * ipr_map_ucode_buffer - Map a microcode download buffer
+ * ipr_build_uc... |
d0ad6f50399abc990adc4653c1eda5932b8adb52 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ipr: Include all disks in supported list | Problem Details:
Fix ipr to include all disks in the supported device list,
not just disks formatted to advanced function format.
Signed-off-by: Brian King <brking@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index b5a2669518ba..d47df3f9d226 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -4111,7 +4111,7 @@ static int ipr_set_supported_devs(struct ipr_cmnd *ipr_cmd)
ipr_cmd->job_step = ipr_ioa_reset_done;
list_for_each_entry_continue(res, &ioa_cf... |
11cd8f120173a707e9ed7b78f7af8cde5a1ebb90 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ipr: Disk array rescanning fix | Problem Details:
IPR RAID arrays show up on a virtual scsi bus, with a scsi bus number
of 255, which is generated by the adapter microcode. For the initial
scan of the host, we manually scan this bus since it does not obey
SAM in regards to sparse LUNs and the disk array devices do not have
a consistent product id to u... | ```diff
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index e0039dfae8e5..da61ce1998c3 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -6008,6 +6008,7 @@ static int __devinit ipr_probe(struct pci_dev *pdev,
ipr_scan_vsets(ioa_cfg);
scsi_add_device(ioa_cfg->host, IPR_IOA_BUS, IPR_IOA_TARGET, IPR_I... |
3072c4abdd8c239a28085733adf3aaae94ad8fbe | Analyze and fix the following issue in the Linux kernel code: [SCSI] megaraid_sas: fix EH locking | Problem Details:
recent kernels call the eh_ methods without the host lock held.
megaraid_sas doesn't need it but drops it before calling a sleeping
routine and reqcquires it afterwards. Just remove the
spin_unlock/spin_lock calls.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Bottomley <James.Bo... | ```diff
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index 4245d05e628b..2463f47adfda 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -767,17 +767,12 @@ static int megasas_generic_reset(struct scsi_cmnd *scmd)
return FAILED;
... |
3256534776203d4d86fea508e66cfde2b06d39a2 | Analyze and fix the following issue in the Linux kernel code: [SCSI] ide-scsi fails to call idescsi_check_condition for things like "Medium not present" | Problem Details:
This patch started life as a response to fedora specific ide subsystem changes
that made error handling of my ATAPI tape drive fail; the specifics are in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=160868
The insertion of the statement rq->errors = err; near the end of
ide_end_drive_cmd() in... | ```diff
diff --git a/drivers/scsi/ide-scsi.c b/drivers/scsi/ide-scsi.c
index f04f3289938d..50d0cec54777 100644
--- a/drivers/scsi/ide-scsi.c
+++ b/drivers/scsi/ide-scsi.c
@@ -395,6 +395,7 @@ static int idescsi_end_request (ide_drive_t *drive, int uptodate, int nrsecs)
int log = test_bit(IDESCSI_LOG_CMD, &scsi->log);
... |
df133c212ef82b9c7e80fca7b1f87dad8a05de3c | Analyze and fix the following issue in the Linux kernel code: [SCSI] Fix transport class oops | Problem Details:
There's an oops that sometimes shows up with SCSI transport classes in
sysfs_hash_and_remove. The problem is that now, because of the class to
device and vice versa symlinks, all classes have to be removed from
visibility *before* the device is removed from visibility.
The transport class trigger poi... | ```diff
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index 72a6550a056c..46349293de08 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -691,16 +691,19 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
void __scsi_remove_device(struct scsi_device *sdev)
{
+ struct de... |
45ca1b509ea156e87c99e529821fb3b548e14fe3 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Debug code clean up - step 7 | Problem Details:
Remove more noisy debugs. Add current->pid to debug messages.
Remove bogus includes.
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.c b/fs/jffs2/debug.c
index 80ac9b6514bf..9b776b5a7604 100644
--- a/fs/jffs2/debug.c
+++ b/fs/jffs2/debug.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.c,v 1.8 2005/07/30 15:27:05 lunn Exp $
+ * $Id: debug.c,v 1.9 200... |
392435081e8cc6e02bdc4fa998050abb11d331b4 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Debug code clean up - step 6 | Problem Details:
Remove extra noisy debugs
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.h b/fs/jffs2/debug.h
index 2112bab514c3..11ee75922a5e 100644
--- a/fs/jffs2/debug.h
+++ b/fs/jffs2/debug.h
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.h,v 1.8 2005/07/31 09:08:38 dedekind Exp $
+ * $Id: debug.h,v 1.1... |
e0e3006f79a6d995c9a7de7556f11a9b97536423 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Refine fragtree debug macros | Problem Details:
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.h b/fs/jffs2/debug.h
index 4d7859712013..2112bab514c3 100644
--- a/fs/jffs2/debug.h
+++ b/fs/jffs2/debug.h
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.h,v 1.7 2005/07/27 13:06:56 dedekind Exp $
+ * $Id: debug.h,v 1.8... |
737b7661e059680a68afb3df0a088fd976f666b7 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Fix up new debug code for eCos build | Problem Details:
The debug code cleanup broke the eCos build.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/build.c b/fs/jffs2/build.c
index f08984a64a5a..8e2f1f4e8aa3 100644
--- a/fs/jffs2/build.c
+++ b/fs/jffs2/build.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: build.c,v 1.75 2005/07/22 10:32:07 dedekind Exp $
+ * $Id: build.c,v 1.... |
f538c96ba2a3fdf7744ecf9fdffac14b1ec4be32 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Debug code clean up - step 4 | Problem Details:
Small comment cleanups. Remove a unused macro
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.h b/fs/jffs2/debug.h
index 3c3c2940f272..4d7859712013 100644
--- a/fs/jffs2/debug.h
+++ b/fs/jffs2/debug.h
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.h,v 1.6 2005/07/24 15:18:26 dedekind Exp $
+ * $Id: debug.h,v 1.7... |
f302cd028c90ddbca20cb5388458ae0f0dd03d9b | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Namespace clean up | Problem Details:
Rename functions to a name matching the functionality.
Remove stall debug code
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/debug.h b/fs/jffs2/debug.h
index 51ff099a6502..3c3c2940f272 100644
--- a/fs/jffs2/debug.h
+++ b/fs/jffs2/debug.h
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: debug.h,v 1.5 2005/07/24 15:14:14 dedekind Exp $
+ * $Id: debug.h,v 1.6... |
4299051ebe89ab1eeadeaf4cf06ce63421412232 | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix missing declaration of cache_is_vivt() | Problem Details:
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/arch/arm/kernel/ecard.c b/arch/arm/kernel/ecard.c
index dceb826bd216..c445b0a848b2 100644
--- a/arch/arm/kernel/ecard.c
+++ b/arch/arm/kernel/ecard.c
@@ -41,6 +41,7 @@
#include <linux/device.h>
#include <linux/init.h>
+#include <asm/cacheflush.h>
#include <asm/dma.h>
#include <asm/ecard.h>
#... |
d3997abf699655d2ec012e944fb34668cc3ec6d7 | Analyze and fix the following issue in the Linux kernel code: [ARM] Fix another use of // as a comment | Problem Details:
// disagrees with ld's script parsing ability. Don't use it.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/include/asm-arm/arch-iop3xx/iop331.h b/include/asm-arm/arch-iop3xx/iop331.h
index 96adffd8bad2..fbf0cc11bdd9 100644
--- a/include/asm-arm/arch-iop3xx/iop331.h
+++ b/include/asm-arm/arch-iop3xx/iop331.h
@@ -42,7 +42,7 @@
/* this can be 128M if OMWTVR1 is set */
#define IOP331_PCI_MEM_WINDOW_SIZE... |
6dac02a5e1bba0bb88ece50160fc4a64cccf30d1 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Fix slab panic | Problem Details:
When JFFS22 is unable to read the root inode, the bad root inode object is not
freed and remains sticked in the jffs2_i slab cache. When we further try to
free the slab cache (e.g., on rmmod jffs2), slab allocator subsystem panics.
Fix this bug.
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.o... | ```diff
diff --git a/fs/jffs2/fs.c b/fs/jffs2/fs.c
index 934c9f5090c8..a6661e8be25a 100644
--- a/fs/jffs2/fs.c
+++ b/fs/jffs2/fs.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: fs.c,v 1.58 2005/07/17 12:01:42 dedekind Exp $
+ * $Id: fs.c,v 1.59 2005/07/18 11:2... |
61a39b694137cef6059a0714c3b1847aabe53b90 | Analyze and fix the following issue in the Linux kernel code: [JFFS2] Debug code clean up - step 2 | Problem Details:
If debugging is disabled, define debugging functions as empty macros, instead
of using Dx() explicitly.
Signed-off-by: Artem B. Bityutskiy <dedekind@infradead.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> | ```diff
diff --git a/fs/jffs2/build.c b/fs/jffs2/build.c
index 3a0b003d73a1..b87d4010d36f 100644
--- a/fs/jffs2/build.c
+++ b/fs/jffs2/build.c
@@ -7,7 +7,7 @@
*
* For licensing information, see the file 'LICENCE' in this directory.
*
- * $Id: build.c,v 1.72 2005/07/17 06:56:20 dedekind Exp $
+ * $Id: build.c,v 1.... |
84613387cb60bc760a4588822cd61fb88e1d7fad | Analyze and fix the following issue in the Linux kernel code: [ARM] 3089/1: ixp4xx AHB/PCI endianness fix | Problem Details:
Patch from Alessandro Zummo
This patch fixes AHB/PCI endianness problems when the
processor is in little-endian mode.
The patch configures the CSR register closely following the directives
in [1], paragraph 4.1, page 19.
According to the considerations in [1], page 11, while the AHB bus
suppo... | ```diff
diff --git a/arch/arm/mach-ixp4xx/common-pci.c b/arch/arm/mach-ixp4xx/common-pci.c
index 2b544363c078..9795da270e3a 100644
--- a/arch/arm/mach-ixp4xx/common-pci.c
+++ b/arch/arm/mach-ixp4xx/common-pci.c
@@ -427,7 +427,7 @@ void __init ixp4xx_pci_preinit(void)
#ifdef __ARMEB__
*PCI_CSR = PCI_CSR_IC | PCI_CSR_... |
ab919c06144cfb11c05b5b5cd291daa96ac2e423 | Analyze and fix the following issue in the Linux kernel code: kconfig: fix xconfig on fedora 2 & 3 (x86_64) | Problem Details:
From: Than Ngo <than@redhat.com>
qt as installed on fedora core (2 and 3) does not work with vanilla
kernel. The linker fails to locate the qt lib:
Actual Results: # make xconfig
HOSTLD scripts/kconfig/qconf
/usr/bin/ld: cannot find -lqt
collect2: ld returned 1 exit status
Than Ngo has provid... | ```diff
diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
index 0dd96919de3e..455aeabd95dd 100644
--- a/scripts/kconfig/Makefile
+++ b/scripts/kconfig/Makefile
@@ -129,7 +129,7 @@ endif
HOSTCFLAGS_lex.zconf.o := -I$(src)
HOSTCFLAGS_zconf.tab.o := -I$(src)
-HOSTLOADLIBES_qconf = -L$(QTLIBPATH) -Wl,-rp... |
2dd34b488a99135ad2a529e33087ddd6a09e992a | Analyze and fix the following issue in the Linux kernel code: [PATCH] kbuild: permanently fix kernel configuration include mess | Problem Details:
Include autoconf.h into every kernel compilation via the gcc command line
using -imacros. This ensures that we have the kernel configuration
included from the start, rather than relying on each file having #include
<linux/config.h> as appropriate. History has shown that this is something
which is dif... | ```diff
diff --git a/Makefile b/Makefile
index 79601320ac3e..2dac8010c142 100644
--- a/Makefile
+++ b/Makefile
@@ -346,7 +346,8 @@ AFLAGS_KERNEL =
# Use LINUXINCLUDE when you must reference the include/ directory.
# Needed to be compatible with the O= option
LINUXINCLUDE := -Iinclude \
- $(if $(... |
50eb80068001871339d04b749fb9b198428b56d2 | Analyze and fix the following issue in the Linux kernel code: [netdrvr s2io] warning fixes | Problem Details:
From Andrew Morton. | ```diff
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c
index 9c4935407f26..0745dd9d01f3 100644
--- a/drivers/net/s2io.c
+++ b/drivers/net/s2io.c
@@ -2110,7 +2110,7 @@ int fill_rxd_3buf(nic_t *nic, RxD_t *rxdp, struct sk_buff *skb)
{
struct net_device *dev = nic->dev;
struct sk_buff *frag_list;
- u64 tmp;
+ v... |
ecf8b596cf636c14896841625d552e148585ad07 | Analyze and fix the following issue in the Linux kernel code: [netdrvr] fac_8xx build fix | Problem Details:
| ```diff
diff --git a/drivers/net/fec_8xx/Kconfig b/drivers/net/fec_8xx/Kconfig
index 4560026ed419..94e7a9af8705 100644
--- a/drivers/net/fec_8xx/Kconfig
+++ b/drivers/net/fec_8xx/Kconfig
@@ -1,6 +1,6 @@
config FEC_8XX
tristate "Motorola 8xx FEC driver"
- depends on NET_ETHERNET
+ depends on NET_ETHERNET && FEC
sel... |
0a1cc0b6a4abaed5f891d1be3e3d0d7b9b719287 | Analyze and fix the following issue in the Linux kernel code: [AGPGART] Fix up warning in efficeon driver. | Problem Details:
efficeon-agp.c:222: warning: passing arg 1 of `virt_to_phys' makes pointer from integer without a cast
Signed-off-by: Dave Jones <davej@redhat.com> | ```diff
diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index b64028abc1ff..d41e0a62e32e 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -219,7 +219,7 @@ static int efficeon_create_gatt_table(struct agp_bridge_data *bridge)
efficeon_private.l1_ta... |
05d0f1cf69fd589634b38b6f6e4b8cfdaace9ca0 | Analyze and fix the following issue in the Linux kernel code: [PATCH] bnx2: update version and minor fixes | Problem Details:
Some book keeping and a style fix.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com> | ```diff
diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index aa6d30e0d829..8f464271664d 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -14,8 +14,8 @@
#define DRV_MODULE_NAME "bnx2"
#define PFX DRV_MODULE_NAME ": "
-#define DRV_MODULE_VERSION "1.2.21"
-#define DRV_MODULE_RELDATE "September 7, 200... |
f912696ab330bf539231d1f8032320f2a08b850f | Analyze and fix the following issue in the Linux kernel code: [PATCH] reset tss->io_bitmap_owner in sys_ioperm() | Problem Details:
my patch "x86: initialise tss->io_bitmap_owner to something" (commit ID
d5cd4aadd3d220afac8e3e6d922e333592551f7d) introduced a problem with a
program (DOSEMU) that called ioperm after already doing some port i/o.
The problem is that a process switch return causes tss->io_bitmap_base
to be set to IO_BI... | ```diff
diff --git a/arch/i386/kernel/ioport.c b/arch/i386/kernel/ioport.c
index f2b37654777f..b59a34dbe262 100644
--- a/arch/i386/kernel/ioport.c
+++ b/arch/i386/kernel/ioport.c
@@ -108,8 +108,11 @@ asmlinkage long sys_ioperm(unsigned long from, unsigned long num, int turn_on)
/*
* Sets the lazy trigger so that t... |
6151b31c9616d71f714fc7ef8e2306f67f3b94c3 | Analyze and fix the following issue in the Linux kernel code: [NET]: Fix race condition in sk_stream_wait_connect | Problem Details:
When sk_stream_wait_connect detects a state transition to ESTABLISHED
or CLOSE_WAIT prior to it going to sleep, it will return without
calling finish_wait and decrementing sk_write_pending.
This may result in crashes and other unintended behaviour.
The fix is to always call finish_wait and update sk_... | ```diff
diff --git a/net/core/stream.c b/net/core/stream.c
index ac9edfdf8742..15bfd03e8024 100644
--- a/net/core/stream.c
+++ b/net/core/stream.c
@@ -52,8 +52,9 @@ int sk_stream_wait_connect(struct sock *sk, long *timeo_p)
{
struct task_struct *tsk = current;
DEFINE_WAIT(wait);
+ int done;
- while (1) {
+ do {
... |
2c119aa8091a15a87920f09aa0f17e05960fe11b | Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Fix sgivwfb | Problem Details:
Statically allocated devices in module data is a potential cause
of oopsen. The device may be in use by a userspace process, which
will keep a reference to the device. If the module is unloaded,
the module data will be freed. Subsequent use of the platform
device will cause a kernel oops.
Use gener... | ```diff
diff --git a/drivers/video/sgivwfb.c b/drivers/video/sgivwfb.c
index cf5106eab2d5..5ce81f44c769 100644
--- a/drivers/video/sgivwfb.c
+++ b/drivers/video/sgivwfb.c
@@ -751,10 +751,6 @@ int __init sgivwfb_setup(char *options)
/*
* Initialisation
*/
-static void sgivwfb_release(struct device *device)
-{
-}
-... |
abbf268ae8f51e19779cdf3f5fbb8144f1a5fbc3 | Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Fix gbefb | Problem Details:
Statically allocated devices in module data is a potential cause
of oopsen. The device may be in use by a userspace process, which
will keep a reference to the device. If the module is unloaded,
the module data will be freed. Subsequent use of the platform
device will cause a kernel oops.
Use gener... | ```diff
diff --git a/drivers/video/gbefb.c b/drivers/video/gbefb.c
index 316bfe994811..ed853bef19e9 100644
--- a/drivers/video/gbefb.c
+++ b/drivers/video/gbefb.c
@@ -1260,24 +1260,30 @@ static struct device_driver gbefb_driver = {
.remove = __devexit_p(gbefb_remove),
};
-static struct platform_device gbefb_device... |
8d972a962177a261fc894f767fa3014f63d661e9 | Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Fix arcfb | Problem Details:
Release code in driver modules is a potential cause of oopsen.
The device may be in use by a userspace process, which will keep
a reference to the device. If the module is unloaded, the module
text will be freed. Subsequently, when the last reference is
dropped, the release code will be called, which... | ```diff
diff --git a/drivers/video/arcfb.c b/drivers/video/arcfb.c
index 126daff1c848..6aa9f824c185 100644
--- a/drivers/video/arcfb.c
+++ b/drivers/video/arcfb.c
@@ -502,10 +502,6 @@ static ssize_t arcfb_write(struct file *file, const char *buf, size_t count,
return err;
}
-static void arcfb_platform_release(stru... |
09c6518ca0de24549a923891b2d335e8496d79a9 | Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Fix macsonic | Problem Details:
Release code in driver modules is a potential cause of oopsen.
The device may be in use by a userspace process, which will keep
a reference to the device. If the module is unloaded, the module
text will be freed. Subsequently, when the last reference is
dropped, the release code will be called, which... | ```diff
diff --git a/drivers/net/macsonic.c b/drivers/net/macsonic.c
index e9c999d7eb39..9ef4592aca03 100644
--- a/drivers/net/macsonic.c
+++ b/drivers/net/macsonic.c
@@ -599,18 +599,8 @@ static struct device_driver mac_sonic_driver = {
.remove = __devexit_p(mac_sonic_device_remove),
};
-static void mac_sonic_plat... |
95cb5d954ee656a0b048ea2298188569e0759336 | Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Fix jazzsonic | Problem Details:
Release code in driver modules is a potential cause of oopsen.
The device may be in use by a userspace process, which will keep
a reference to the device. If the module is unloaded, the module
text will be freed. Subsequently, when the last reference is
dropped, the release code will be called, which... | ```diff
diff --git a/drivers/net/jazzsonic.c b/drivers/net/jazzsonic.c
index a74a5cfaf5bc..2fb3101cb33e 100644
--- a/drivers/net/jazzsonic.c
+++ b/drivers/net/jazzsonic.c
@@ -285,18 +285,8 @@ static struct device_driver jazz_sonic_driver = {
.remove = __devexit_p(jazz_sonic_device_remove),
};
-static void jazz_son... |
5d994b7f5d1c77acaa0b9b4c1b9f0f278605c309 | Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Fix depca | Problem Details:
Release code in driver modules is a potential cause of oopsen.
The device may be in use by a userspace process, which will keep
a reference to the device. If the module is unloaded, the module
text will be freed. Subsequently, when the last reference is
dropped, the release code will be called, which... | ```diff
diff --git a/drivers/net/depca.c b/drivers/net/depca.c
index 4d26e5e7d18b..0d33a93df96b 100644
--- a/drivers/net/depca.c
+++ b/drivers/net/depca.c
@@ -1470,15 +1470,6 @@ static int __init depca_mca_probe(struct device *device)
** ISA bus I/O device probe
*/
-static void depca_platform_release (struct device... |
d8f64e19605d6ce40bc560e7bc919e2e02a79c1b | Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED]: GRED: Fix restart of idle period in WRED mode upon dequeue and drop | Problem Details:
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
index 1fb34be32f7c..69f0fd45d4c3 100644
--- a/net/sched/sch_gred.c
+++ b/net/sched/sch_gred.c
@@ -267,7 +267,7 @@ static struct sk_buff *gred_dequeue(struct Qdisc* sch)
return skb;
}
- if (gred_wred_mode(t))
+ if (gred_wred_mode(t) && !red_is_idlin... |
7051703b990ec40bdf192ec7c87ffafd7011c640 | Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED]: GRED: Dont abuse default VQ for equalizing | Problem Details:
Introduces a new red parameter set for use in equalize mode,
although only the qavg variable and the idle period marker are
being used for now this makes it possible to allow a separate
parameter set to be used for equalize later on.
The use of this separate parameter set fixes a bogus start of
an idl... | ```diff
diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
index 29869a077480..a545532be2c4 100644
--- a/net/sched/sch_gred.c
+++ b/net/sched/sch_gred.c
@@ -89,6 +89,7 @@ struct gred_sched
unsigned long flags;
u32 DPs;
u32 def;
+ struct red_parms wred_set;
};
static inline int gred_wred_mode(str... |
f62d6b936df500247474c13360eb23e1b602bad0 | Analyze and fix the following issue in the Linux kernel code: [PKT_SCHED]: GRED: Use central VQ change procedure | Problem Details:
Introduces a function gred_change_vq() acting as a central point
to change VQ parameters. Fixes priority inheritance in rio mode
when the default DP equals 0. Adds proper locking during changes.
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/net/sched/sch_gred.c b/net/sched/sch_gred.c
index b04b07fcc2cf..ca6cb271493b 100644
--- a/net/sched/sch_gred.c
+++ b/net/sched/sch_gred.c
@@ -58,6 +58,8 @@
#define D2PRINTK(format,args...)
#endif
+#define GRED_DEF_PRIO (MAX_DPs / 2)
+
struct gred_sched_data;
struct gred_sched;
@@ -432,77 +4... |
2964bbd7048ac0c1405cc119604e29987dd165df | Analyze and fix the following issue in the Linux kernel code: [PATCH] pcnet32: AT2700/2701 and Bugzilla 2699 & 4551 | Problem Details:
This patch is a better fix for Allied Telesyn 2700/2701 FX boards than
the change made in early January this year. It allows the user to
select the speed/duplex via module_param, but if no selection is made,
forces the speed to 100 FD. It fixes both Bugzilla bugs 2669 and 4551.
Tested ia32 and ppc64 ... | ```diff
diff --git a/drivers/net/pcnet32.c b/drivers/net/pcnet32.c
index 31e6dd049859..549a07385884 100644
--- a/drivers/net/pcnet32.c
+++ b/drivers/net/pcnet32.c
@@ -22,8 +22,8 @@
*************************************************************************/
#define DRV_NAME "pcnet32"
-#define DRV_VERSION "1.31b"
-#d... |
1758ee0ea26561943813c5f5a7b27272f2cbc4cf | Analyze and fix the following issue in the Linux kernel code: [NETFILTER] nf_queue: Fix Ooops when no queue handler registered | Problem Details:
With the new nf_queue generalization in 2.6.14, we've introduced a bug
that causes an oops as soon as a packet is queued but no queue handler
registered. This patch fixes it.
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c
index d10d552d9c40..d3a4f30a7f22 100644
--- a/net/netfilter/nf_queue.c
+++ b/net/netfilter/nf_queue.c
@@ -117,7 +117,7 @@ int nf_queue(struct sk_buff **skb,
/* QUEUE == DROP if noone is waiting, to be safe. */
read_lock(&queue_handler_lock);... |
39b7f1e25a412b0ef31e516cfc2fa4f40235f263 | Analyze and fix the following issue in the Linux kernel code: [SCSI] sd: Fix refcounting | Problem Details:
Currently the driver takes a reference only for requests coming by way
of the gendisk, not for requests coming by way of the struct device or
struct scsi_device. Such requests can arrive in the rescan, flush,
and shutdown pathways.
The patch also makes the scsi_disk keep a reference to the underlying... | ```diff
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 9de8e186cb69..bb5b242ac6b4 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -177,24 +177,38 @@ static inline struct scsi_disk *scsi_disk(struct gendisk *disk)
return container_of(disk->private_data, struct scsi_disk, driver);
}
-static struc... |
25cc5e5bd20e9274dddb9d1e55b83798363528dc | Analyze and fix the following issue in the Linux kernel code: [MMC] Fix chip config in wbsd | Problem Details:
There is a broken if clause in the wbsd driver that can cause the
driver to try and configure the chip even though none is found. This
results in i/o on invalid ports.
Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> | ```diff
diff --git a/drivers/mmc/wbsd.c b/drivers/mmc/wbsd.c
index 942668e93a74..ea0c4b3361bf 100644
--- a/drivers/mmc/wbsd.c
+++ b/drivers/mmc/wbsd.c
@@ -1852,9 +1852,9 @@ static int __devinit wbsd_init(struct device* dev, int base, int irq, int dma,
/*
* See if chip needs to be configured.
*/
- if (pnp && (ho... |
0f81eb4db4f1cc560318b6e7762a7a1d7d8c7095 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER]: Fix double free after netlink_unicast() in ctnetlink | Problem Details:
It's not necessary to free skb if netlink_unicast() failed.
Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/net/ipv4/netfilter/ip_conntrack_netlink.c b/net/ipv4/netfilter/ip_conntrack_netlink.c
index 166e6069f121..82a65043a8ef 100644
--- a/net/ipv4/netfilter/ip_conntrack_netlink.c
+++ b/net/ipv4/netfilter/ip_conntrack_netlink.c
@@ -815,7 +815,7 @@ ctnetlink_get_conntrack(struct sock *ctnl, struct sk_buff... |
0ee957cb7a8f6e4fb8c6f943dbc451957bc0c6bc | Analyze and fix the following issue in the Linux kernel code: Fix ips.c compile | Problem Details:
It looks like one of the ips patches was missing a closing brace in a
function
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> | ```diff
diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c
index 749c95bb7df7..68e5b2ab27c4 100644
--- a/drivers/scsi/ips.c
+++ b/drivers/scsi/ips.c
@@ -4934,6 +4934,7 @@ ips_poll_for_flush_complete(ips_ha_t * ha)
}
return 0;
+}
/****************************************************************************/... |
d2a7bb7141a1fac7b11523538b2d2407e928baeb | Analyze and fix the following issue in the Linux kernel code: [NETFILTER] NAT: Fix module refcount dropping too far | Problem Details:
The unknown protocol is used as a fallback when a protocol isn't known.
Hence we cannot handle it failing, so don't set ".me". It's OK, since we
only grab a reference from within the same module (iptable_nat.ko), so we
never take the module refcount from 0 to 1.
Also, remove the "protocol is NULL" te... | ```diff
diff --git a/net/ipv4/netfilter/ip_nat_core.c b/net/ipv4/netfilter/ip_nat_core.c
index c5e3abd24672..762f4d93936b 100644
--- a/net/ipv4/netfilter/ip_nat_core.c
+++ b/net/ipv4/netfilter/ip_nat_core.c
@@ -66,10 +66,8 @@ ip_nat_proto_find_get(u_int8_t protonum)
* removed until we've grabbed the reference */
p... |
6037d6bbdff65eb5a84fe35e140f4da4f7cc103a | Analyze and fix the following issue in the Linux kernel code: [libata] ATAPI pad allocation fixes/cleanup | Problem Details:
Use ata_pad_{alloc,free} in two drivers, to factor out common code.
Add ata_pad_{alloc,free} to two other drivers, which needed the padding
but had not been updated. | ```diff
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index 8420204c2eaa..4612312c0c2d 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -307,21 +307,22 @@ static int ahci_port_start(struct ata_port *ap)
void __iomem *port_mmio = ahci_port_base(mmio, ap->port_no);
void *mem;
dma_addr_t mem_dm... |
d811552eda2476215d69d485e437d2dcae1ab0b4 | Analyze and fix the following issue in the Linux kernel code: [NETFILTER] PPTP helper: Fix endianness bug in GRE key / CallID NAT | Problem Details:
This endianness bug slipped through while changing the 'gre.key' field in the
conntrack tuple from 32bit to 16bit.
None of my tests caught the problem, since the linux pptp client always has
'0' as call id / gre key. Only windows clients actually trigger the bug.
Signed-off-by: Harald Welte <laforge... | ```diff
diff --git a/net/ipv4/netfilter/ip_nat_proto_gre.c b/net/ipv4/netfilter/ip_nat_proto_gre.c
index 7c1285401672..f7cad7cf1aec 100644
--- a/net/ipv4/netfilter/ip_nat_proto_gre.c
+++ b/net/ipv4/netfilter/ip_nat_proto_gre.c
@@ -139,8 +139,8 @@ gre_manip_pkt(struct sk_buff **pskb,
break;
case GRE_VERSION_PPTP:... |
3428c209c6820bbbb7dfb323caef8d402b3deb4c | Analyze and fix the following issue in the Linux kernel code: [NETFILTER] PPTP helper: Fix compilation of conntrack helper without NAT | Problem Details:
This patch fixes compilation of the PPTP conntrack helper when NAT is
configured off.
Signed-off-by: Yasuyuki Kozakai <yasuyuki.kozakai@toshiba.co.jp>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com> | ```diff
diff --git a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
index 926a6684643d..4108a5e12b3c 100644
--- a/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
+++ b/net/ipv4/netfilter/ip_conntrack_helper_pptp.c
@@ -270,14 +270,10 @@ exp_gre(struct ip_conntrack *master,
... |
c51e3a417bb0f295e13a5bad86302b5212eafdf3 | Analyze and fix the following issue in the Linux kernel code: powerpc: Fix vmlinux.lds.S for 32-bit | Problem Details:
We can't currently use asm-ppc/page.h in vmlinux.lds.S, so until
we have a merged page.h, define PAGE_SIZE and KERNELBASE locally.
Also gets rid of some dynamic executable cruft that we had for
32-bit. With -Ttext=$(KERNELBASE) this didn't cause any problem,
but when we changed to putting . = KERNELBA... | ```diff
diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
index 9ceaa7a7bd00..7fa7b15fd8e6 100644
--- a/arch/powerpc/kernel/vmlinux.lds.S
+++ b/arch/powerpc/kernel/vmlinux.lds.S
@@ -1,5 +1,10 @@
#include <linux/config.h>
+#ifdef CONFIG_PPC64
#include <asm/page.h>
+#else
+#define PAGE_... |
146a209967886e57eb34b4cdb85ca52078a4f8cc | Analyze and fix the following issue in the Linux kernel code: [AGPGART] Fix up sgi-agp bug with no devices on bus. | Problem Details:
Signed-off-by: Eric Kunze <ekunze@sgi.com>
Signed-off-by: Dave Jones <davej@redhat.com> | ```diff
diff --git a/drivers/char/agp/sgi-agp.c b/drivers/char/agp/sgi-agp.c
index d3aa159c9dec..53eeb293d174 100644
--- a/drivers/char/agp/sgi-agp.c
+++ b/drivers/char/agp/sgi-agp.c
@@ -288,6 +288,8 @@ static int __devinit agp_sgi_init(void)
j = 0;
list_for_each_entry(info, &tioca_list, ca_list) {
struct list_h... |
0bbacc402e67abca8794a8401c1621dc0c0202e9 | Analyze and fix the following issue in the Linux kernel code: NFS,SUNRPC,NLM: fix unused variable warnings when CONFIG_SYSCTL is disabled | Problem Details:
Fix some dprintk's so that NLM, NFS client, and RPC client compile
cleanly if CONFIG_SYSCTL is disabled.
Test plan:
Compile kernel with CONFIG_NFS enabled and CONFIG_SYSCTL disabled.
Signed-off-by: Chuck Lever <cel@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/lockd/svcsubs.c b/fs/lockd/svcsubs.c
index de7536358c7c..62f4a385177f 100644
--- a/fs/lockd/svcsubs.c
+++ b/fs/lockd/svcsubs.c
@@ -30,6 +30,36 @@
static struct nlm_file * nlm_files[FILE_NRHASH];
static DECLARE_MUTEX(nlm_file_sema);
+#ifdef NFSD_DEBUG
+static inline void nlm_debug_print_fh(ch... |
43b2a33aa868054bd477ab2c1cd20f1ba1af2c3e | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix recovery of flock() locks. | Problem Details:
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index 81d964bfd8a7..52a26baa114c 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -784,7 +784,7 @@ static int nfs4_reclaim_locks(struct nfs4_state_recovery_ops *ops, struct nfs4_s
int status = 0;
for (fl = inode->i_flock; fl != 0; fl = fl->fl... |
2c56617d76fa7b2a709d58abd7ed68889cc88b90 | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix the handling of the error NFS4ERR_OLD_STATEID | Problem Details:
Ensure that we retry the failed operation...
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 9e492c2261c0..54ff465cf7cf 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -2595,12 +2595,10 @@ int nfs4_handle_exception(const struct nfs_server *server, int errorcode, struct
case -NFS4ERR_GRACE:
case -NFS4ERR_DELAY:
ret = nfs4_delay... |
d530838bfa507d67b40d13b00d9cbd7a46a47e78 | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix problem with OPEN_DOWNGRADE | Problem Details:
RFC 3530 states that for OPEN_DOWNGRADE "The share_access and share_deny
bits specified must be exactly equal to the union of the share_access and
share_deny bits specified for some subset of the OPENs in effect for
current openowner on the current file.
Setattr is currently violating the NFSv4 ru... | ```diff
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index fc0f12ba89cc..24d2fbf549bd 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -1009,13 +1009,18 @@ void nfs_file_set_open_context(struct file *filp, struct nfs_open_context *ctx)
spin_unlock(&inode->i_lock);
}
-struct nfs_open_context *nfs_find_open_conte... |
4cecb76ff86db46d2823550256c828b6597f418e | Analyze and fix the following issue in the Linux kernel code: NFSv4: Fix a race between open() and close() | Problem Details:
We must not remove the nfs4_state structure from the inode open lists
before we are in sequence lock.
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> | ```diff
diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
index 78a53f5a9f18..53969022d239 100644
--- a/fs/nfs/nfs4_fs.h
+++ b/fs/nfs/nfs4_fs.h
@@ -214,7 +214,7 @@ extern int nfs4_proc_setclientid(struct nfs4_client *, u32, unsigned short);
extern int nfs4_proc_setclientid_confirm(struct nfs4_client *);
extern int nfs... |
30c2f90b68b9bcdba83d386d56533d3e884be021 | Analyze and fix the following issue in the Linux kernel code: [ARM] 3097/1: change library link ordering | Problem Details:
Patch from Nicolas Pitre
We have an optimized sha1 routine (arch/arm/lib/sha1.S) meant to
override the generic one in lib/sha1.c.
Unfortunately lib/lib.a is listed _before_ arch/arm/lib/lib.a in the
link argument list and therefore the architecture specific lib functions
are not picked up before the ... | ```diff
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index c422759438d5..114cda7f1b73 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -144,7 +144,7 @@ drivers-$(CONFIG_OPROFILE) += arch/arm/oprofile/
drivers-$(CONFIG_ARCH_CLPS7500) += drivers/acorn/char/
drivers-$(CONFIG_ARCH_L7200) += drivers/ac... |
091e95ee7febf894603475c44d51f8ec4fab4328 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ac97 - Fix confliction of DRA and surround slots | Problem Details:
Modules: AC97 Codec
Fixed the confliction of DRA and surround slots 7/8.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/ac97/ac97_codec.c b/sound/pci/ac97/ac97_codec.c
index 3b589104510b..9bde76c4c6a2 100644
--- a/sound/pci/ac97/ac97_codec.c
+++ b/sound/pci/ac97/ac97_codec.c
@@ -2046,6 +2046,8 @@ int snd_ac97_mixer(ac97_bus_t *bus, ac97_template_t *template, ac97_t **rac97)
snd_ac97_update_bits(ac97, AC... |
beef08a54524e4a657bfb66b6b9758f8bc54fd17 | Analyze and fix the following issue in the Linux kernel code: [ALSA] intel8x0 - Fix irq handler registration | Problem Details:
Modules: Intel8x0 driver
- Request irq handler after proper initialization
- Don't override always buggy_irq option for Nvidia
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index 8eb966505d2d..0801083f32dd 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -69,7 +69,7 @@ static char *id = SNDRV_DEFAULT_STR1; /* ID for this card */
static int ac97_clock = 0;
static char *ac97_quirk;
static int buggy_semaphore;... |
fc20773329c993ec7d1b2c65618351f057d9d679 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix emu10k1 synth problems. | Problem Details:
Modules: EMU10K1/EMU10K2 driver,Common EMU synth
This patch fixes problems with voices cutting off or not
sounding at all.
Signed-off-by: Tim <tedon@rogers.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/emu10k1/emu10k1_callback.c b/sound/pci/emu10k1/emu10k1_callback.c
index 7cf2f908eed9..6589bf24abcd 100644
--- a/sound/pci/emu10k1/emu10k1_callback.c
+++ b/sound/pci/emu10k1/emu10k1_callback.c
@@ -241,7 +241,7 @@ lookup_voices(snd_emux_t *emu, emu10k1_t *hw, best_voice_t *best, int active_... |
aa92c4af15224d8a96343286cdcf7c73b2ad3809 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix a typo in the last fix | Problem Details:
Modules: ALSA Core
Fix a typo (bogus check) in the last patch to fix Oops with suspend/resume.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/init.c b/sound/core/init.c
index b98f7c6310c5..d9ee27ae9a51 100644
--- a/sound/core/init.c
+++ b/sound/core/init.c
@@ -841,7 +841,7 @@ static int snd_generic_resume(struct device *dev)
card = get_snd_generic_card(dev);
if (card->power_state == SNDRV_CTL_POWER_D0)
return 0;
- if (c... |
f1902860161ff212c515e7ea629e880fec856a37 | Analyze and fix the following issue in the Linux kernel code: [ALSA] fix improper CONFIG_SND_MAJOR usage | Problem Details:
Modules: HWDEP Midlevel,PCM Midlevel,RawMidi Midlevel,ALSA Core
Replace usage of CONFIG_SND_MAJOR with snd_major, where appropriate.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de> | ```diff
diff --git a/include/sound/core.h b/include/sound/core.h
index 642ddfbc6325..2be65ad2fd83 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -255,6 +255,7 @@ typedef struct _snd_minor snd_minor_t;
/* sound.c */
+extern int snd_major;
extern int snd_ecards_limit;
void snd_request_card(int c... |
8433a509c0eb6bb1f33ce39c82c580b8901619ee | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix schedule_timeout usage | Problem Details:
Use schedule_timeout_{,un}interruptible() instead of
set_current_state()/schedule_timeout() to reduce kernel size. Also use
human-time conversion functions instead of hard-coded division to avoid
rounding issues.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@... | ```diff
diff --git a/sound/core/seq/seq_instr.c b/sound/core/seq/seq_instr.c
index 019d43a462d7..1d525b13ebb6 100644
--- a/sound/core/seq/seq_instr.c
+++ b/sound/core/seq/seq_instr.c
@@ -109,8 +109,7 @@ void snd_seq_instr_list_free(snd_seq_kinstr_list_t **list_ptr)
spin_lock_irqsave(&list->lock, flags);
while (... |
d78bec210f07b06f406b877b9179e0cc281ae8e6 | Analyze and fix the following issue in the Linux kernel code: [ALSA] intel8x0 - fix capture for M1563 | Problem Details:
Modules: Intel8x0 driver
1.In intel8x0_measure_ac97_clock routine, when stop DMA, there is not stop
DMA corectly, but start another PCM In2 DMA engine.
2.In do_ali_reset routine, there is only need to enable PCM IN and PCM OUT.
Signed-off-by: Jaroslav Kysela <perex@suse.cz> | ```diff
diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index d71f5d1e7169..383a3ac5ecba 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -2138,7 +2138,7 @@ static void do_ali_reset(intel8x0_t *chip)
iputdword(chip, ICHREG(ALI_FIFOCR2), 0x83838383);
iputdword(chip, ICHREG(ALI_FIFOCR3), 0x838... |
7b4260f2cc8a0da74a7842106cc87ab54bf17ec5 | Analyze and fix the following issue in the Linux kernel code: [ALSA] ca0106: Added copyright messages. | Problem Details:
Modules: CA0106 driver
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk> | ```diff
diff --git a/sound/pci/ca0106/ca_midi.c b/sound/pci/ca0106/ca_midi.c
index 9cc0c67ace99..2e08b27b8349 100644
--- a/sound/pci/ca0106/ca_midi.c
+++ b/sound/pci/ca0106/ca_midi.c
@@ -6,6 +6,8 @@
* Changelog:
* Implementation is based on mpu401 and emu10k1x and
* tested with ca0106.
+ * mpu401: Copyr... |
7cf4783b31607ad13b84bed14ea2ca446364985a | Analyze and fix the following issue in the Linux kernel code: [ALSA] ca0106: Cosmetic changes. | Problem Details:
Modules: CA0106 driver
Just tidying up the code. Making more functions static.
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk> | ```diff
diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
index aaaef9e66af6..ee58d16002e5 100644
--- a/sound/pci/ca0106/ca0106_main.c
+++ b/sound/pci/ca0106/ca0106_main.c
@@ -1331,27 +1331,33 @@ static int __devinit snd_ca0106_create(snd_card_t *card,
}
-void ca0106_midi_interrupt_enabl... |
d3d579f84ebf701dedd22ba696d1738ed6759ef7 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Add missing KERN_* prefix | Problem Details:
Modules: ALSA<-OSS emulation,USB generic driver,USB USX2Y
Added missing KERN_* prefix to printk.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/core/oss/mixer_oss.c b/sound/core/oss/mixer_oss.c
index b2497cec2079..214933cf5d49 100644
--- a/sound/core/oss/mixer_oss.c
+++ b/sound/core/oss/mixer_oss.c
@@ -1294,7 +1294,8 @@ static int snd_mixer_oss_notify_handler(snd_card_t * card, int cmd)
card, 0,
&snd_mixer_oss_reg... |
8a5afd29dc16a9e687f63195cb635ecd611482d0 | Analyze and fix the following issue in the Linux kernel code: [ALSA] snd-ca0106: Add midi support. | Problem Details:
Modules: PCI drivers,CA0106 driver
Author: Tilman Kranz <tilde@tk-sls.de>
Signed-off-by: James Courtier-Dutton <James@superbug.co.uk> | ```diff
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index d140e93d37b6..0fb16cf335ea 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -184,6 +184,7 @@ config SND_CA0106
tristate "SB Audigy LS / Live 24bit"
depends on SND
select SND_AC97_CODEC
+ select SND_RAWMIDI
help
Say Y here to include s... |
698444f31788bd9992f7c31bcc4862d82f985890 | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix the type of enable module option | Problem Details:
Fix the type of enable module option to bool.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/atiixp.c b/sound/pci/atiixp.c
index 14f912ae40da..a9314363abd8 100644
--- a/sound/pci/atiixp.c
+++ b/sound/pci/atiixp.c
@@ -58,7 +58,7 @@ MODULE_PARM_DESC(spdif_aclink, "S/PDIF over AC-link.");
/* just for backward compatibility */
static int enable;
-module_param(enable, int, 0444);
... |
051b51653309db976c9665f8d4b1774fa1f8124a | Analyze and fix the following issue in the Linux kernel code: [ALSA] Fix maestro3 hang after cold boot | Problem Details:
Modules: Maestro3 driver
This patch fixes the maestro3 driver to call the snd_m3_assp_init
function to write the DSP firmware into the ASSP chip before sending the
RUN_ASSP command, thereby solving the hang after a cold boot.
Signed-off-by: Charles R. Anderson <cra@alum.wpi.edu>
Signed-off-by: Takash... | ```diff
diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c
index 2693b6f731f3..7b1b82521cf4 100644
--- a/sound/pci/maestro3.c
+++ b/sound/pci/maestro3.c
@@ -2476,6 +2476,7 @@ snd_m3_chip_init(m3_t *chip)
t |= ASSP_0_WS_ENABLE;
outb(t, chip->iobase + ASSP_CONTROL_A);
+ snd_m3_assp_init(chip); /* download DS... |
c829b052de189b3ca4fb76d2f61917b67e12b83d | Analyze and fix the following issue in the Linux kernel code: [ALSA] intel8x0 - Fix handling of module parameters | Problem Details:
Modules: Intel8x0 driver
- Set buggy_irq parameter before registration of irq handler.
- Clean up module parameter handling.
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/intel8x0.c b/sound/pci/intel8x0.c
index fc2fba8129e2..d16ef527716d 100644
--- a/sound/pci/intel8x0.c
+++ b/sound/pci/intel8x0.c
@@ -2563,7 +2563,6 @@ struct ich_reg_info {
static int __devinit snd_intel8x0_create(snd_card_t * card,
struct pci_dev *pci,
unsigned long device_... |
2fd43d1159d22395aae01836c4b13ee5265a9b6b | Analyze and fix the following issue in the Linux kernel code: [ALSA] timer: fix timer instance memory allocation checks | Problem Details:
Modules: Timer Midlevel
Add checks to return -ENOMEM in case snd_timer_instance_new() fails.
Signed-off-by: Clemens Ladisch <clemens@ladisch.de> | ```diff
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 8ecec9134acd..b02681eaea75 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -251,6 +251,10 @@ int snd_timer_open(snd_timer_instance_t **ti,
}
down(®ister_mutex);
timeri = snd_timer_instance_new(owner, NULL);
+ if (!timeri) {
+ ... |
93b9f426374a07d46f582fdf284e4e26d8fe9756 | Analyze and fix the following issue in the Linux kernel code: [ALSA] es1938 - Clean up and fix trigger in PM | Problem Details:
Modules: ES1938 driver
- Clean up the last PM fix
- Add TRIGGER_SUSPEND/RESUME to disable/enable DMA properly during PM
Signed-off-by: Takashi Iwai <tiwai@suse.de> | ```diff
diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c
index e8b8ebf99635..7bfbdfc2f8bc 100644
--- a/sound/pci/es1938.c
+++ b/sound/pci/es1938.c
@@ -543,10 +543,12 @@ static int snd_es1938_capture_trigger(snd_pcm_substream_t * substream,
int val;
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
+ case SNDRV_PCM... |
c913f69b0d1b9f3f3aa39f49a240cb0fb9d7c6dd | Analyze and fix the following issue in the Linux kernel code: [ALSA] es1938 - Fix resume | Problem Details:
Modules: ES1938 driver
This patch fixes the suspend/resume issue I'm having with ESS-Solo1
soundcard. Without this patch I might get after resume message
that kernel is disabling the IRQ5 (soundcard). If there was something
playing it wont continue after resume without this patch.
Signed-off-by: Rudo... | ```diff
diff --git a/sound/pci/es1938.c b/sound/pci/es1938.c
index 17fa80c23870..e8b8ebf99635 100644
--- a/sound/pci/es1938.c
+++ b/sound/pci/es1938.c
@@ -1390,7 +1390,8 @@ static int es1938_suspend(snd_card_t *card, pm_message_t state)
*d = snd_es1938_reg_read(chip, *s);
outb(0x00, SLIO_REG(chip, IRQCONTROL)); ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.