id
stringlengths
40
40
instruction
stringlengths
68
308
input
stringlengths
17
33.4k
output
stringlengths
100
30k
52303e8b5f8aa234865d40d76ea16b0ff4b27022
Analyze and fix the following issue in the Linux kernel code: [PATCH] modules: fix sparse warning for every MODULE_PARM
Problem Details: sparse complains about every MODULE_PARM used in a module: warning: symbol '__parm_foo' was not declared. Should it be static? The fix is to split declaration and initialization. While MODULE_PARM is obsolete, it's not something sparse should report. Signed-off-by: Pavel Roskin <proski@gnu.org> Sig...
```diff diff --git a/include/linux/module.h b/include/linux/module.h index f05372b7fe77..84d75f3a8aca 100644 --- a/include/linux/module.h +++ b/include/linux/module.h @@ -554,7 +554,9 @@ static inline void MODULE_PARM_(void) { } #ifdef MODULE /* DEPRECATED: Do not use. */ #define MODULE_PARM(var,type) \ -st...
eb8e317998e55dc1f9e6288564052b577327b766
Analyze and fix the following issue in the Linux kernel code: [PATCH] firmware: fix all kernel-doc warnings
Problem Details: Convert existing function docs to kernel-doc format. Eliminate all kernel-doc warnings. Fix some doc typos and a little whitespace cleanup. Signed-off-by: Randy Dunlap <rdunlap@xenotime.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index 4acb2c5733c3..98f6c02d6790 100644 --- a/drivers/base/firmware_class.c +++ b/drivers/base/firmware_class.c @@ -62,14 +62,16 @@ firmware_timeout_show(struct class *class, char *buf) } /** - * firmware_timeout_store: - * Descripti...
381be25458524f9bcec5bf1e40c82d1ebb408475
Analyze and fix the following issue in the Linux kernel code: [PATCH] ext3: sparse fixes
Problem Details: Fix warnings from sparse due to un-declared functions that should either have a header file or have been declared static fs/ext2/bitmap.c:14:15: warning: symbol 'ext2_count_free' was not declared. Should it be static? fs/ext2/namei.c:92:15: warning: symbol 'ext2_get_parent' was not declared. Should ...
```diff diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 032c7ba1b13f..7992d21e0e09 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c @@ -20,6 +20,8 @@ #include <linux/quotaops.h> #include <linux/buffer_head.h> +#include "bitmap.h" + /* * balloc.c contains the blocks allocation and deallocation routines...
1291cf4163d21f1b4999d697cbf68d38e7151c28
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix de_thread() vs do_coredump() deadlock
Problem Details: de_thread() sends SIGKILL to all sub-threads and waits them to die in 'D' state. It is possible that one of the threads already dequeued coredump signal. When de_thread() unlocks ->sighand->lock that thread can enter do_coredump()->coredump_wait() and cause a deadlock. Signed-off-by: Oleg Nesterov <...
```diff diff --git a/fs/exec.c b/fs/exec.c index 6d9521636aaa..10d493fea7ce 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1460,11 +1460,21 @@ int do_coredump(long signr, int exit_code, struct pt_regs * regs) current->fsuid = 0; /* Dump root private */ } mm->dumpable = 0; - init_completion(&mm->core_done); + + retva...
f7232056bff5fe2d3bfeab35252a66ebaeb5bbde
Analyze and fix the following issue in the Linux kernel code: [PATCH] Added a Receive_Abort to the Marvell serial driver
Problem Details: Added a Receive_Abort to the Marvell serial driver Fix occasional input overrun errors on Marvell serial driver - If the Marvell serial driver is repeatedly started and then stopped it will occasionally report an input overrun error when started. - Added a Receive_Abort to the Marvell serial drive...
```diff diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index efe79b1fd431..aec83f577ce6 100644 --- a/drivers/serial/mpsc.c +++ b/drivers/serial/mpsc.c @@ -1100,6 +1100,8 @@ mpsc_start_rx(struct mpsc_port_info *pi) { pr_debug("mpsc_start_rx[%d]: Starting...\n", pi->port.line); + /* Issue a Receive Abort...
1779381dea3bada407396742c56bee31ffa8544e
Analyze and fix the following issue in the Linux kernel code: [PATCH] fuse: spelling fixes
Problem Details: Correct some typos and inconsistent use of "initialise" vs "initialize" in comments. Reported by Ioannis Barkas. Signed-off-by: Miklos Szeredi <miklos@szeredi.hu> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c index d4c869c6d01b..a6f90a6c754a 100644 --- a/fs/fuse/dev.c +++ b/fs/fuse/dev.c @@ -151,9 +151,9 @@ void fuse_release_background(struct fuse_req *req) /* * This function is called when a request is finished. Either a reply * has arrived or it was interrupted (and...
2a38bccd0c63a4954ea4e1357cbff404aa321afb
Analyze and fix the following issue in the Linux kernel code: [PATCH] Kconfig help text correction for CONFIG_FRAME_POINTER
Problem Details: Fix-up the CONFIG_FRAME_POINTER help text language a bit. Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 807535e7a1e7..f9306b14d2a6 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -174,7 +174,7 @@ config FRAME_POINTER default y if DEBUG_INFO && UML help If you say Y here the resulting kernel image will be slightly larger - and slower, but...
7f2a52555998c699a7e89f24636c909d6fc08a60
Analyze and fix the following issue in the Linux kernel code: [PATCH] wait4 PTRACE_ATTACH race fix
Problem Details: Back about a year ago when I last fiddled heavily with the do_wait code, I was thinking too hard about the wrong thing and I now think I introduced a bug whose inverse thought I was fixing. Apparently noone was looking too hard over much shoulder, so as to cite my bogus reasoning at the time. In the ...
```diff diff --git a/kernel/exit.c b/kernel/exit.c index 6ef8f7356a74..2d39ccc367e6 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1383,6 +1383,15 @@ repeat: switch (p->state) { case TASK_TRACED: + /* + * When we hit the race with PTRACE_ATTACH, + * we will not report this child. But the + ...
5b11687924e40790deb0d5f959247ade82196665
Analyze and fix the following issue in the Linux kernel code: [PATCH] Locking problems while EXT3FS_DEBUG on
Problem Details: I noticed some problems while running ext3 with the debug flag set on. More precisely, I was unable to umount the filesystem. Some investigation took me to the patch that follows. At a first glance , the lock/unlock I've taken out seems really not necessary, as the main code (outside debug) does not ...
```diff diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c index 0213db4911a2..032c7ba1b13f 100644 --- a/fs/ext3/balloc.c +++ b/fs/ext3/balloc.c @@ -1010,7 +1010,7 @@ retry: * allocation within the reservation window. * * This will avoid keeping on searching the reservation list again and - * again when someboday i...
39e88ca2c9d0f6d1e9f34ea2a6e86a652bb69a7a
Analyze and fix the following issue in the Linux kernel code: [PATCH] fs: error case fix in __generic_file_aio_read
Problem Details: When __generic_file_aio_read() hits an error during reading, it reports the error iff nothing has successfully been read yet. This is condition - when an error occurs, if nothing has been read/written, report the error code; otherwise, report the amount of bytes successfully transferred upto that poin...
```diff diff --git a/mm/filemap.c b/mm/filemap.c index 768687f1d46b..5d6e4c2000dc 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1030,8 +1030,8 @@ __generic_file_aio_read(struct kiocb *iocb, const struct iovec *iov, desc.error = 0; do_generic_file_read(filp,ppos,&desc,file_read_actor); retval += desc.writ...
30e0fca6c1d7d26f3f2daa4dd2b12c51dadc778a
Analyze and fix the following issue in the Linux kernel code: [PATCH] ptrace/coredump/exit_group deadlock
Problem Details: I could seldom reproduce a deadlock with a task not killable in T state (TASK_STOPPED, not TASK_TRACED) by attaching a NPTL threaded program to gdb, by segfaulting the task and triggering a core dump while some other task is executing exit_group and while one task is in ptrace_attached TASK_STOPPED sta...
```diff diff --git a/kernel/ptrace.c b/kernel/ptrace.c index 019e04ec065a..863eee8bff47 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -56,6 +56,10 @@ void ptrace_untrace(task_t *child) signal_wake_up(child, 1); } } + if (child->signal->flags & SIGNAL_GROUP_EXIT) { + sigaddset(&child->pending.signal, S...
5aa15b5f27fc2c404530c6c8eabdb8437deb3163
Analyze and fix the following issue in the Linux kernel code: [PATCH] cpusets: remove depth counted locking hack
Problem Details: Remove a rather hackish depth counter on cpuset locking. The depth counter was avoiding a possible double trip on the global cpuset_sem semaphore. It worked, but now an improved version of cpuset locking is available, to come in the next patch, using two global semaphores. This patch reverses "cpuse...
```diff diff --git a/kernel/cpuset.c b/kernel/cpuset.c index b9342f90d28f..cd54dba2be18 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -180,42 +180,6 @@ static struct super_block *cpuset_sb = NULL; */ static DECLARE_MUTEX(cpuset_sem); -static struct task_struct *cpuset_sem_owner; -static int cpuset_sem_dept...
e9543659715602e3180f00a227bb6db34141ac41
Analyze and fix the following issue in the Linux kernel code: [PATCH] proc: fix of error path in proc_get_inode()
Problem Details: This patch fixes incorrect error path in proc_get_inode(), when module can't be get due to being unloaded. When try_module_get() fails, this function puts de(!) and still returns inode with non-getted de. There are still unresolved known bugs in proc yet to be fixed: - proc_dir_entry tree is managed ...
```diff diff --git a/fs/proc/inode.c b/fs/proc/inode.c index effa6c0c467a..e6a818a93f3d 100644 --- a/fs/proc/inode.c +++ b/fs/proc/inode.c @@ -156,10 +156,13 @@ struct inode *proc_get_inode(struct super_block *sb, unsigned int ino, WARN_ON(de && de->deleted); + if (de != NULL && !try_module_get(de->owner)) + got...
f12ec44070f6b4d1a3911fcf9917cf8f872a4daf
Analyze and fix the following issue in the Linux kernel code: [PATCH] fuse: clean up dead code related to nfs exporting
Problem Details: Remove last remains of NFS exportability support. The code is actually buggy (as reported by Akshat Aranya), since 'alias' will be leaked if it's non-null and alias->d_flags has DCACHE_DISCONNECTED. This is not an active bug, since there will never be any disconnected dentries. But it's better to ge...
```diff diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 29f1e9f6e85c..70dba721acab 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -741,13 +741,14 @@ static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, if (inode && S_ISDIR(inode->i_mode)) { /* Don't allow creating an alias to a directory ...
2ca7d93bb27876e5fd4ebfcb3b00627107bdad4d
Analyze and fix the following issue in the Linux kernel code: [PATCH] block cleanups: Fix iosched module refcount leak
Problem Details: If the requested I/O scheduler is already in place, elevator_switch simply leaves the queue alone, and returns. However, it forgets to call elevator_put, so 'echo [current_sched] > /sys/block/[dev]/queue/scheduler' will leak a reference, causing the current_sched module to be permanently pinned in m...
```diff diff --git a/drivers/block/elevator.c b/drivers/block/elevator.c index 3b652eba2d20..36f1057084b0 100644 --- a/drivers/block/elevator.c +++ b/drivers/block/elevator.c @@ -753,8 +753,10 @@ ssize_t elv_iosched_store(request_queue_t *q, const char *name, size_t count) return -EINVAL; } - if (!strcmp(elevato...
3fa63c7d82ab9a12a5d0a299069f8df9f35aa011
Analyze and fix the following issue in the Linux kernel code: [PATCH] Typo fix: dot after newline in printk strings
Problem Details: Typo fix: dots appearing after a newline in printk strings. Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/char/ser_a2232.c b/drivers/char/ser_a2232.c index 6b4e9d155f50..dda30e42ec79 100644 --- a/drivers/char/ser_a2232.c +++ b/drivers/char/ser_a2232.c @@ -790,7 +790,7 @@ static int __init a2232board_init(void) } - printk("Total: %d A2232 boards initialized.\n.", nr_a2232); /* Some status...
33430dc593f866f5d67ff6a6213b6dd6d7ea3ce1
Analyze and fix the following issue in the Linux kernel code: [PATCH] Typo fix: explictly -> explicitly
Problem Details: (akpm: I don't do typo patches, but one of these is in a printk string) Signed-off-by: Jean Delvare <khali@linux-fr.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/Documentation/cpusets.txt b/Documentation/cpusets.txt index d17b7d2dd771..a09a8eb80665 100644 --- a/Documentation/cpusets.txt +++ b/Documentation/cpusets.txt @@ -94,7 +94,7 @@ the available CPU and Memory resources amongst the requesting tasks. But larger systems, which benefit more from careful p...
932aeafbe8521a9a9d790152d66020e0fef2029b
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix de_thread vs it_real_fn() deadlock
Problem Details: de_thread() calls del_timer_sync(->real_timer) under ->sighand->siglock. This is deadlockable, it_real_fn sends a signal and needs this lock too. Also, delete unneeded ->real_timer.data assignment. Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Cc: Roland McGrath <roland@redhat.com> Signed-off-by: An...
```diff diff --git a/fs/exec.c b/fs/exec.c index 1de69cdc0e6c..fc02dadc604a 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -641,8 +641,10 @@ static inline int de_thread(struct task_struct *tsk) * before we can safely let the old group leader die. */ sig->real_timer.data = (unsigned long)current; + spin_unlock_ir...
d97b321425e237e3e6c6bbe2c40dc0e09d0e3264
Analyze and fix the following issue in the Linux kernel code: [PATCH] protect ide_cdrom_capacity by ifdef
Problem Details: The only call to ide_cdrom_capacity is in code protected by CONFIG_PROC_FS, so when that is not enabled, the compiler complains: drivers/ide/ide-cd.c:3259: warning: `ide_cdrom_capacity' defined but not used Here is a patch that fixes that. It provides some space savings for embedded systems that ar...
```diff diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 74af7e074868..7130939c7f91 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -3254,6 +3254,7 @@ int ide_cdrom_setup (ide_drive_t *drive) return 0; } +#ifdef CONFIG_PROC_FS static sector_t ide_cdrom_capacity (ide_drive_t *drive) ...
dfc4f94d2ff95fc92127d3e512c1df7cab274fb8
Analyze and fix the following issue in the Linux kernel code: [PATCH] remove timer debug field
Problem Details: Remove timer_list.magic and associated debugging code. I originally added this when a spinlock was added to timer_list - this meant that an all-zeroes timer became illegal and init_timer() was required. That spinlock isn't even there any more, although timer.base must now be initialised. I'll keep t...
```diff diff --git a/arch/s390/kernel/vtime.c b/arch/s390/kernel/vtime.c index fa0726507b3d..22a895ecb7a4 100644 --- a/arch/s390/kernel/vtime.c +++ b/arch/s390/kernel/vtime.c @@ -24,7 +24,6 @@ #include <asm/s390_ext.h> #include <asm/timer.h> -#define VTIMER_MAGIC (TIMER_MAGIC + 1) static ext_int_info_t ext_int_inf...
a5a0d52c7305cb3629ef0cc9e2e0e106869e1907
Analyze and fix the following issue in the Linux kernel code: [PATCH] ntp whitespace cleanup
Problem Details: Fix bizarre 4-space coding style in the NTP code. Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/timer.c b/kernel/timer.c index 6b94adb45b03..cc18857601e2 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -632,77 +632,74 @@ long time_next_adjust; */ static void second_overflow(void) { - long ltemp; - - /* Bump the maxerror field */ - time_maxerror += time_tolerance >> SHI...
aaa4059bc2dca7fa816624a28db1958c3a22df9b
Analyze and fix the following issue in the Linux kernel code: [PATCH] ext3: Fix unmapped buffers in transaction's lists
Problem Details: Fix the problem (BUG 4964) with unmapped buffers in transaction's t_sync_data list. The problem is we need to call filesystem's own invalidatepage() from block_write_full_page(). block_write_full_page() must call filesystem's invalidatepage(). Otherwise following nasty race can happen: proc 1 ...
```diff diff --git a/fs/buffer.c b/fs/buffer.c index 2066e4cb700c..75cac9ada026 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -1637,6 +1637,15 @@ out: } EXPORT_SYMBOL(block_invalidatepage); +int do_invalidatepage(struct page *page, unsigned long offset) +{ + int (*invalidatepage)(struct page *, unsigned long); + in...
ed3cb6f039bb296457bfd2877cba6ad0287d8d54
Analyze and fix the following issue in the Linux kernel code: [PATCH] s390: 3270 fullscreen view
Problem Details: Martin Schwidefsky <schwidefsky@de.ibm.com> Fix fullscreen view of the 3270 device driver. Signed-off-by: Richard Hitt <rbh00@utsglobal.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/s390/kernel/compat_ioctl.c b/arch/s390/kernel/compat_ioctl.c index 24a1e9f069a7..6504c4e69986 100644 --- a/arch/s390/kernel/compat_ioctl.c +++ b/arch/s390/kernel/compat_ioctl.c @@ -18,6 +18,8 @@ #include <asm/dasd.h> #include <asm/cmb.h> #include <asm/tape390.h> +#include <asm/ccwdev.h> +#i...
b365157be3250a6b5948422ba65e05e5f964e150
Analyze and fix the following issue in the Linux kernel code: [PATCH] uml: fix "reuse i386 cpu optimizations"
Problem Details: Remove RWSEM_GENERIC_SPINLOCK, it's now defined (only if needed) by the underlying arch/i386/Kconfig.cpu. Leave it only for x86_64. Even there, it's totally wrong, as they even have the code to support XCHG_ADD. Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: And...
```diff diff --git a/arch/um/Kconfig b/arch/um/Kconfig index ceaf6e4d2855..cd06ed7d842d 100644 --- a/arch/um/Kconfig +++ b/arch/um/Kconfig @@ -27,10 +27,6 @@ config UID16 bool default y -config RWSEM_GENERIC_SPINLOCK - bool - default y - config GENERIC_CALIBRATE_DELAY bool default y diff --git a/arch/um/Kcon...
f3ac9fbf7a0b9493377ee88d9b5b2933ff3f7ade
Analyze and fix the following issue in the Linux kernel code: [PATCH] m32r: SMC91x driver update
Problem Details: Update SMC91x driver for m32r. - Remove needless NONCACHE_OFFSET adjustment. > [PATCH 2.6.14-rc4] m32r: NONCACHE_OFFSET in _port2addr > Change _port2addr() not to add NONCACHE_OFFSET. > Adding NONCACHE_OFFSET requires needless address adjusting by a driver > using ioremap() like a SMC91x drive...
```diff diff --git a/arch/m32r/kernel/io_m32700ut.c b/arch/m32r/kernel/io_m32700ut.c index e545b065f7e9..eda9f963c1eb 100644 --- a/arch/m32r/kernel/io_m32700ut.c +++ b/arch/m32r/kernel/io_m32700ut.c @@ -64,11 +64,11 @@ static inline void *__port2addr_ata(unsigned long port) * from 0x10000000 to 0x13ffffff on physical...
c978b0179b31600394d5ebdb0940b492ec05500f
Analyze and fix the following issue in the Linux kernel code: [PATCH] m32r: fix #if warnings
Problem Details: Fix warnings for #if directives. Signed-off-by: Hirokazu Takata <takata@linux-m32r.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/arch/m32r/kernel/setup.c b/arch/m32r/kernel/setup.c index ec5674727e7f..f722ec8eb021 100644 --- a/arch/m32r/kernel/setup.c +++ b/arch/m32r/kernel/setup.c @@ -305,19 +305,19 @@ static int show_cpuinfo(struct seq_file *m, void *v) seq_printf(m, "processor\t: %ld\n", cpu); -#ifdef CONFIG_CHIP_VD...
de491861e1457c31aed6d44d96afb549365ff790
Analyze and fix the following issue in the Linux kernel code: [PATCH] swsusp: cleanups
Problem Details: Reduce number of ifdefs somehow, and fix whitespace a bit. No real code changes. Signed-off-by: Pavel Machek <pavel@suse.cz> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c index b4a923e59bc5..72787f925630 100644 --- a/kernel/power/snapshot.c +++ b/kernel/power/snapshot.c @@ -33,7 +33,6 @@ #include "power.h" - #ifdef CONFIG_HIGHMEM struct highmem_page { char *data; @@ -88,12 +87,10 @@ static int save_highmem_z...
5d35704028d09a183448daceab5dcb94f21a3645
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386: srat on non-acpi hw fix
Problem Details: This patch adds a check for the return value of acpi_find_root_pointer(). Without this patch systems without ACPI support such as QEMU crashes when booting a NUMA kernel with CONFIG_ACPI_SRAT=y. Signed-off-by: Magnus Damm <magnus@valinux.co.jp> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-b...
```diff diff --git a/arch/i386/kernel/srat.c b/arch/i386/kernel/srat.c index 516bf5653b02..8de658db8146 100644 --- a/arch/i386/kernel/srat.c +++ b/arch/i386/kernel/srat.c @@ -327,7 +327,12 @@ int __init get_memcfg_from_srat(void) int tables = 0; int i = 0; - acpi_find_root_pointer(ACPI_PHYSICAL_ADDRESSING, rsdp_a...
009b29d90f575a83eba185950a7182ab05e7741a
Analyze and fix the following issue in the Linux kernel code: [PATCH] kdump/i386: apic verification failure fix
Problem Details: o Removes the unnecessary call to local_irq_disable(). o Kdump was failing while second kernel was coming up. Check for presence of boot cpu apic id was failing in (apic_id_registered), hence hitting BUG(). o This should not have failed because before calling setup_local_APIC(), it is ensured t...
```diff diff --git a/arch/i386/kernel/apic.c b/arch/i386/kernel/apic.c index 8d81b7bf7ad2..9204be6eedb3 100644 --- a/arch/i386/kernel/apic.c +++ b/arch/i386/kernel/apic.c @@ -1055,7 +1055,6 @@ void __init setup_boot_APIC_clock(void) using_apic_timer = 1; local_irq_save(flags); - local_irq_disable(); calibrati...
29b70081f7cb094513d5189e82d3478b50777a28
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386 nmi_watchdog: Merge check_nmi_watchdog fixes from x86_64
Problem Details: The per cpu nmi watchdog timer is based on an event counter. idle cpus don't generate events so the NMI watchdog doesn't fire and the test to see if the watchdog is working fails. - Add nmi_cpu_busy so idle cpus don't mess up the test. - kmalloc prev_nmi_count to keep kernel stack usage bounded. - Im...
```diff diff --git a/arch/i386/kernel/nmi.c b/arch/i386/kernel/nmi.c index 72515b8a1b12..d661703ac1cb 100644 --- a/arch/i386/kernel/nmi.c +++ b/arch/i386/kernel/nmi.c @@ -100,16 +100,44 @@ int nmi_active; (P4_CCCR_OVF_PMI0|P4_CCCR_THRESHOLD(15)|P4_CCCR_COMPLEMENT| \ P4_CCCR_COMPARE|P4_CCCR_REQUIRED|P4_CCCR_ESCR_SE...
f014a556e714dfb02502e3be6146a39ca625f33c
Analyze and fix the following issue in the Linux kernel code: [PATCH] fixup bogus e820 entry with mem=
Problem Details: This was reported because someone was getting oopses reading /proc/iomem. It was tracked down to a zero-sized 'struct resource' entry which was located right at 4GB. You need two conditions to hit this bug: a BIOS E820_RAM area starting at exactly the boundary where you specify mem= (to get a zero-siz...
```diff diff --git a/arch/i386/kernel/setup.c b/arch/i386/kernel/setup.c index 9b8c8a19824d..b48ac635f3c1 100644 --- a/arch/i386/kernel/setup.c +++ b/arch/i386/kernel/setup.c @@ -389,14 +389,24 @@ static void __init limit_regions(unsigned long long size) } } for (i = 0; i < e820.nr_map; i++) { - if (e820.map[i]...
750deaa4021da1cf9fdb1e20861a10c76fd7f2bc
Analyze and fix the following issue in the Linux kernel code: [PATCH] asus vt8235 router buggy bios workaround
Problem Details: Hopefully fix http://bugzilla.kernel.org/show_bug.cgi?id=5235 Similar problem has been reported before here: http://groups.google.com/group/linux.kernel/browse_thread/thread/def4ca19dbc3cd4/5cffbf349f2c87a4?tvc=2&q=Aleksey+Gorelov&hl=en#5cffbf349f2c87a4 and was related to bug in BIOS reporting 82C686 ...
```diff diff --git a/arch/i386/pci/irq.c b/arch/i386/pci/irq.c index cddafe33ff7c..19e6f4871d1e 100644 --- a/arch/i386/pci/irq.c +++ b/arch/i386/pci/irq.c @@ -547,31 +547,48 @@ static __init int intel_router_probe(struct irq_router *r, struct pci_dev *route return 0; } -static __init int via_router_probe(struct ir...
434440a2804639f11858d9d384c9505927feb186
Analyze and fix the following issue in the Linux kernel code: [PATCH] x86: bug fix in P6 Machine check initialization
Problem Details: Make P6 MCA initialization code complaint with guidelines in IA-32 SDM Vol3. Bank 0 control register should not be set by OS and clear status registers on all banks on reset. This will prevent false MCE alarms on the systems that has some non-MCE information left-over in MC0_STATUS on reboot. Signed...
```diff diff --git a/arch/i386/kernel/cpu/mcheck/p6.c b/arch/i386/kernel/cpu/mcheck/p6.c index 3c035b8fa3d9..979b18bc95c1 100644 --- a/arch/i386/kernel/cpu/mcheck/p6.c +++ b/arch/i386/kernel/cpu/mcheck/p6.c @@ -102,11 +102,16 @@ void __devinit intel_p6_mcheck_init(struct cpuinfo_x86 *c) wrmsr(MSR_IA32_MCG_CTL, 0xfff...
08967f941ad897b2f7c2f99e886c75d6319e5087
Analyze and fix the following issue in the Linux kernel code: [PATCH] FPU context corrupted after resume
Problem Details: mxcsr_feature_mask_init isn't needed in suspend/resume time (we can use boot time mask). And actually it's harmful, as it clear task's saved fxsave in resume. This bug is widely seen by users using zsh. (akpm: my eyes. Fixed some surrounding whitespace mess) Signed-off-by: Shaohua Li<shaohua.li@in...
```diff diff --git a/arch/i386/power/cpu.c b/arch/i386/power/cpu.c index b27c5acc79d0..1f1572692e0b 100644 --- a/arch/i386/power/cpu.c +++ b/arch/i386/power/cpu.c @@ -51,16 +51,14 @@ void save_processor_state(void) __save_processor_state(&saved_context); } -static void -do_fpu_end(void) +static void do_fpu_end(voi...
dacb16b1a034fa7a0b868ee30758119fbfd90bc1
Analyze and fix the following issue in the Linux kernel code: [PATCH] i386 and x86_64 TSC set_cyc2ns_scale imprecision
Problem Details: I just found out that some precision is unnecessarily lost in the arch/i386/kernel/timers/timer_tsc.c:set_cyc2ns_scale function. It uses a cpu_mhz parameter when it could use a cpu_khz. In the specific case of an Intel P4 running at 3001.171 Mhz, the truncation to 3001 Mhz leads to an imprecision of ...
```diff diff --git a/arch/i386/kernel/timers/timer_hpet.c b/arch/i386/kernel/timers/timer_hpet.c index d973a8b681fd..be242723c339 100644 --- a/arch/i386/kernel/timers/timer_hpet.c +++ b/arch/i386/kernel/timers/timer_hpet.c @@ -30,23 +30,28 @@ static seqlock_t monotonic_lock = SEQLOCK_UNLOCKED; * basic equation: * ...
ce4c2bd1a9dfebaefadc2d34b17c6f12101751be
Analyze and fix the following issue in the Linux kernel code: [PATCH] selinux-canonicalize-getxattr-fix
Problem Details: security/selinux/hooks.c: In function `selinux_inode_getxattr': security/selinux/hooks.c:2193: warning: unused variable `sbsec' Cc: James Morris <jmorris@namei.org> Cc: Stephen Smalley <sds@tycho.nsa.gov> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index d9ec85292e1c..d50d7a782cf5 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -2205,9 +2205,6 @@ static void selinux_inode_post_setxattr(struct dentry *dentry, char *name, static int selinux_inode_getxattr (struct den...
46595ffbfc8ba79f27cdf8a029ee068b3b34c69f
Analyze and fix the following issue in the Linux kernel code: [ARM] arch-ixp4xx/io.h: make const args const to remove compiler warning
Problem Details: Compiler warning fix; the inline callers of these APIs were changed to have const vaddr parameters. Signed-off-by: John Bowler <jbowler@acm.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/include/asm-arm/arch-ixp4xx/io.h b/include/asm-arm/arch-ixp4xx/io.h index e350dcb544e8..80d05ecad2f0 100644 --- a/include/asm-arm/arch-ixp4xx/io.h +++ b/include/asm-arm/arch-ixp4xx/io.h @@ -113,7 +113,7 @@ __ixp4xx_writeb(u8 value, u32 addr) } static inline void -__ixp4xx_writesb(u32 bus_addr, ...
5ecdb02c9d8b7f76108da6fcb2a66fdf5eed3116
Analyze and fix the following issue in the Linux kernel code: [ARM] fix ixp2x00 defconfig NR_UARTS options
Problem Details: IXDP2[48]00 have only 1 UART on the board. Signed-off-by: Deepak Saxena <dsaxena@plexity.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/arch/arm/configs/ixdp2400_defconfig b/arch/arm/configs/ixdp2400_defconfig index 678720fa2e2e..ddeb9f99d662 100644 --- a/arch/arm/configs/ixdp2400_defconfig +++ b/arch/arm/configs/ixdp2400_defconfig @@ -559,7 +559,7 @@ CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768 # CONFIG_SERIAL_8250=y CONFIG_SERIAL_8250_C...
7012f9084e3ef27028b4f2ab37428662766a743a
Analyze and fix the following issue in the Linux kernel code: [ARM] fix bogus cast in IXP2000 I/O macro
Problem Details: Physical addresses are not valid pointers of any sort and should not be cast to such. Signed-off-by: Deepak Saxena <dsaxena@plexity.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/include/asm-arm/arch-ixp2000/ixdp2x01.h b/include/asm-arm/arch-ixp2000/ixdp2x01.h index b768009c3a51..c6d51426e98f 100644 --- a/include/asm-arm/arch-ixp2000/ixdp2x01.h +++ b/include/asm-arm/arch-ixp2000/ixdp2x01.h @@ -22,7 +22,7 @@ #define IXDP2X01_CPLD_REGION_SIZE 0x00100000 #define IXDP2X01_C...
a2436b22deac7834e0f87897b207a2dc1407dc40
Analyze and fix the following issue in the Linux kernel code: [SERIAL] remove unneeded code from serial_core.c
Problem Details: This patch fixes an issue reported by Coverity in serial/serial_core.c Error reported: Variable "&((info)->tty)->flags" tracked as NULL was passed to a function that dereferences it. The later statements in the function assumes 'info->tty != NULL', so this check is not necessary. Probably a 'BUG_ON(...
```diff diff --git a/drivers/serial/serial_core.c b/drivers/serial/serial_core.c index 2d8622eef701..401d94a7fe2e 100644 --- a/drivers/serial/serial_core.c +++ b/drivers/serial/serial_core.c @@ -147,8 +147,7 @@ static int uart_startup(struct uart_state *state, int init_hw) * once we have successfully opened the port...
08db2a701bd63d0e36f06a29137bf016a907cf71
Analyze and fix the following issue in the Linux kernel code: Fix PIIX4 SMB region size
Problem Details: Petr Vandrovec correctly points out that the SMB region of the PIIX4 is just 16 bytes, not 32. Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index bbd9c2323d8c..5627ce1d2b32 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -356,7 +356,7 @@ static void piix4_mem_quirk(struct pci_dev *dev, const char *name, unsigned int /* * PIIX4 ACPI: Two IO regions pointed to by longwords at...
8576762ff5d109b841fcf4e7d3883e0cf794f3cf
Analyze and fix the following issue in the Linux kernel code: [DRIVER MODEL] Add missing driver_unregister to IMX serial driver
Problem Details: Fix the IMX serial driver to unregister its driver structure when it is unloaded. Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
```diff diff --git a/drivers/serial/imx.c b/drivers/serial/imx.c index b9a1f523c9a8..4a54ff584700 100644 --- a/drivers/serial/imx.c +++ b/drivers/serial/imx.c @@ -995,6 +995,7 @@ static int __init imx_serial_init(void) static void __exit imx_serial_exit(void) { uart_unregister_driver(&imx_reg); + driver_unregister(...
91e1a512291f258746611c18ec4970a81c9f311b
Analyze and fix the following issue in the Linux kernel code: [ARM] 3066/1: Fix PXA irda driver suspend/resume functions
Problem Details: Patch from Richard Purdie Update the PXA irda driver to match the recent platform device suspend/resume level changes. Signed-off-by: Richard Purdie <rpurdie@rpsys.net> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
```diff diff --git a/drivers/net/irda/pxaficp_ir.c b/drivers/net/irda/pxaficp_ir.c index aef80f5e7c9c..b886b07412a6 100644 --- a/drivers/net/irda/pxaficp_ir.c +++ b/drivers/net/irda/pxaficp_ir.c @@ -704,15 +704,12 @@ static int pxa_irda_stop(struct net_device *dev) return 0; } -static int pxa_irda_suspend(struct d...
fbf30fbaa61595e9026f628f3913888b0df2b288
Analyze and fix the following issue in the Linux kernel code: [libata ata_piix] fix native mode probe, after recent updates
Problem Details:
```diff diff --git a/drivers/scsi/ata_piix.c b/drivers/scsi/ata_piix.c index b7fbf11f3fae..7f8aa1b552ce 100644 --- a/drivers/scsi/ata_piix.c +++ b/drivers/scsi/ata_piix.c @@ -622,7 +622,7 @@ static int piix_init_one (struct pci_dev *pdev, const struct pci_device_id *ent) { static int printed_version; struct ata_po...
5f6b5b973a125de0dbe236ce659a495787c81ff0
Analyze and fix the following issue in the Linux kernel code: powerpc: Fix time setting bug on 32-bit
Problem Details: This fixes a bug where settimeofday would set the wrong parameters in do_gtod, resulting in gettimeofday returning a value about 4 hours after the correct time. The bug was that we divided a negative 64-bit value with do_div, which treated it as unsigned and gave us a result that was approximately 1.8...
```diff diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c index 9f264c2f02c3..ed5c38fb146c 100644 --- a/arch/powerpc/kernel/time.c +++ b/arch/powerpc/kernel/time.c @@ -518,7 +518,7 @@ int do_settimeofday(struct timespec *tv) long wtm_nsec, new_nsec = tv->tv_nsec; unsigned long flags; long int t...
0f0d5192696eeb3072944a4a813809cc2c85891a
Analyze and fix the following issue in the Linux kernel code: [libata] fix legacy IDE probing
Problem Details: ata_pci_init_one() receives an array of struct ata_port_info. Recent updates to the code had always obtained port information from array element 0, rather than array element N. Change to avoid hardcoding port_info[0], thereby restoring proper hardware information to secondary legacy ports.
```diff diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c index cc089f1fb114..8be7dc0b47b8 100644 --- a/drivers/scsi/libata-core.c +++ b/drivers/scsi/libata-core.c @@ -4527,11 +4527,11 @@ ata_pci_init_native_mode(struct pci_dev *pdev, struct ata_port_info **port, int return probe_ent; } -static ...
94ec1ef1cf29e137e5c79372e432b040c6604be6
Analyze and fix the following issue in the Linux kernel code: [libata pdc_adma] fix for new irq-driven PIO code
Problem Details:
```diff diff --git a/drivers/scsi/pdc_adma.c b/drivers/scsi/pdc_adma.c index 309b205820a4..6a9d0dc085c1 100644 --- a/drivers/scsi/pdc_adma.c +++ b/drivers/scsi/pdc_adma.c @@ -457,13 +457,13 @@ static inline unsigned int adma_intr_pkt(struct ata_host_set *host_set) continue; handled = 1; adma_enter_reg_mode(ap...
3947be1969a9ce455ec30f60ef51efb10e4323d1
Analyze and fix the following issue in the Linux kernel code: [PATCH] memory hotplug: sysfs and add/remove functions
Problem Details: This adds generic memory add/remove and supporting functions for memory hotplug into a new file as well as a memory hotplug kernel config option. Individual architecture patches will follow. For now, disable memory hotplug when swsusp is enabled. There's a lot of churn there right now. We'll fix it...
```diff diff --git a/drivers/base/Makefile b/drivers/base/Makefile index 66d9c4643fc1..f12898d53078 100644 --- a/drivers/base/Makefile +++ b/drivers/base/Makefile @@ -7,6 +7,7 @@ obj-y := core.o sys.o bus.o dd.o \ obj-y += power/ obj-$(CONFIG_FW_LOADER) += firmware_class.o obj-$(CONFIG_NUMA) += node.o +obj-$(CON...
96527980d4cb8f65fe49efdbc4ab92c0837d42f6
Analyze and fix the following issue in the Linux kernel code: [PATCH] hugetlbfs: move free_inodes accounting
Problem Details: Move hugetlbfs accounting into ->alloc_inode / ->destroy_inode. This keeps the code simpler, fixes a loeak where a failing inode allocation wouldn't decrement the counter and moves hugetlbfs_delete_inode and hugetlbfs_forget_inode closer to their generic counterparts. Signed-off-by: Christoph Hellwig...
```diff diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c index a826a8add5e3..8e9d43633365 100644 --- a/fs/hugetlbfs/inode.c +++ b/fs/hugetlbfs/inode.c @@ -224,8 +224,6 @@ static void truncate_hugepages(struct address_space *mapping, loff_t lstart) static void hugetlbfs_delete_inode(struct inode *inode) { - ...
f412ac08c9861b4791af0145934c22f1458686da
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: fix rss and mmlist locking
Problem Details: A couple of oddities were guarded by page_table_lock, no longer properly guarded when that is split. The mm_counters of file_rss and anon_rss: make those an atomic_t, or an atomic64_t if the architecture supports it, in such a case. Definitions by courtesy of Christoph Lameter: who spent considerable...
```diff diff --git a/include/linux/sched.h b/include/linux/sched.h index 292cb57ce38f..1c30bc308ef1 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -249,13 +249,47 @@ arch_get_unmapped_area_topdown(struct file *filp, unsigned long addr, extern void arch_unmap_area(struct mm_struct *, unsigned long); ...
4c21e2f2441dc5fbb957b030333f5a3f2d02dea7
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: split page table lock
Problem Details: Christoph Lameter demonstrated very poor scalability on the SGI 512-way, with a many-threaded application which concurrently initializes different parts of a large anonymous area. This patch corrects that, by using a separate spinlock per page table page, to guard the page table entries in that page, ...
```diff diff --git a/arch/arm/mm/mm-armv.c b/arch/arm/mm/mm-armv.c index 60f3e039bac2..1221fdde1769 100644 --- a/arch/arm/mm/mm-armv.c +++ b/arch/arm/mm/mm-armv.c @@ -229,6 +229,7 @@ void free_pgd_slow(pgd_t *pgd) pte = pmd_page(*pmd); pmd_clear(pmd); dec_page_state(nr_page_table_pages); + pte_lock_deinit(pte); ...
92dc6fcc845d99e87d8168e0786796525832d130
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: parisc pte atomicity
Problem Details: There's a worrying function translation_exists in parisc cacheflush.h, unaffected by split ptlock since flush_dcache_page is using it on some other mm, without any relevant lock. Oh well, make it a slightly more robust by factoring the pfn check within it. And it looked liable to confuse a camouflage...
```diff diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c index e15f09eaed12..a065349aee37 100644 --- a/arch/parisc/kernel/cache.c +++ b/arch/parisc/kernel/cache.c @@ -270,7 +270,6 @@ void flush_dcache_page(struct page *page) unsigned long offset; unsigned long addr; pgoff_t pgoff; - pte_t *pte...
deceb6cd17e6dfafe4c4f81b1b4153bc41b2cb70
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: follow_page with inner ptlock
Problem Details: Final step in pushing down common core's page_table_lock. follow_page no longer wants caller to hold page_table_lock, uses pte_offset_map_lock itself; and so no page_table_lock is taken in get_user_pages itself. But get_user_pages (and get_futex_key) do then need follow_page to pin the page for them:...
```diff diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c index 7e5e7ec2e36d..d2fa42006d8f 100644 --- a/fs/proc/task_mmu.c +++ b/fs/proc/task_mmu.c @@ -419,7 +419,6 @@ static struct numa_maps *get_numa_maps(const struct vm_area_struct *vma) for_each_node(i) md->node[i] =0; - spin_lock(&mm->page_table_lock); ...
67b02f119df50ffad5a4e9e53ea4c896535862cd
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: xip_unmap ZERO_PAGE fix
Problem Details: Small fix to the PageReserved patch: the mips ZERO_PAGE(address) depends on address, so __xip_unmap is wrong to initialize page with that before address is initialized; and in fact must re-evaluate it each iteration. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osd...
```diff diff --git a/mm/filemap_xip.c b/mm/filemap_xip.c index 9354ee279b13..4e74ad60339a 100644 --- a/mm/filemap_xip.c +++ b/mm/filemap_xip.c @@ -174,7 +174,7 @@ __xip_unmap (struct address_space * mapping, unsigned long address; pte_t *pte; pte_t pteval; - struct page *page = ZERO_PAGE(address); + struct page *...
fc2acab31be8e869b2d5f6de12f557f6f054f19c
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: tlb_finish_mmu forget rss
Problem Details: zap_pte_range has been counting the pages it frees in tlb->freed, then tlb_finish_mmu has used that to update the mm's rss. That got stranger when I added anon_rss, yet updated it by a different route; and stranger when rss and anon_rss became mm_counters with special access macros. And it would no l...
```diff diff --git a/arch/sparc64/mm/tlb.c b/arch/sparc64/mm/tlb.c index 6a43f7cd090e..8b104be4662b 100644 --- a/arch/sparc64/mm/tlb.c +++ b/arch/sparc64/mm/tlb.c @@ -18,8 +18,7 @@ /* Heavily inspired by the ppc64 code. */ -DEFINE_PER_CPU(struct mmu_gather, mmu_gathers) = - { NULL, 0, 0, 0, 0, 0, { 0 }, { NULL },...
e040f218bb49a6965a5b77edce05fe47a62dda39
Analyze and fix the following issue in the Linux kernel code: [PATCH] mm: copy_pte_range progress fix
Problem Details: My latency breaking in copy_pte_range didn't work as intended: instead of checking at regularish intervals, after the first interval it checked every time around the loop, too impatient to be preempted. Fix that. Signed-off-by: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.o...
```diff diff --git a/mm/memory.c b/mm/memory.c index 1db40e935e55..222c13e46130 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -410,7 +410,7 @@ static int copy_pte_range(struct mm_struct *dst_mm, struct mm_struct *src_mm, { pte_t *src_pte, *dst_pte; unsigned long vm_flags = vma->vm_flags; - int progress; + int prog...
63f324cf0792ed69089b79d6921ba3aaea97af50
Analyze and fix the following issue in the Linux kernel code: [PATCH] fix alpha breakage
Problem Details: barrier.h uses barrier() in non-SMP case. And doesn't include compiler.h. Cc: Al Viro <viro@ftp.linux.org.uk> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/include/asm-alpha/barrier.h b/include/asm-alpha/barrier.h index 229c83fe77cb..681ff581afa5 100644 --- a/include/asm-alpha/barrier.h +++ b/include/asm-alpha/barrier.h @@ -1,6 +1,8 @@ #ifndef __BARRIER_H #define __BARRIER_H +#include <asm/compiler.h> + #define mb() \ __asm__ __volatile__("mb": ...
4b8f573b5db02a3017afbba49026a6aef480174f
Analyze and fix the following issue in the Linux kernel code: [PATCH] TIMERS: add missing compensation for HZ == 250
Problem Details: Add missing compensation for (HZ == 250) != (1 << SHIFT_HZ) in second_overflow(). Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org> Cc: "David S. Miller" <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
```diff diff --git a/kernel/timer.c b/kernel/timer.c index 3ba10fa35b60..6a2e5f8dc725 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -752,6 +752,15 @@ static void second_overflow(void) else time_adj += (time_adj >> 2) + (time_adj >> 5); #endif +#if HZ == 250 + /* Compensate for (HZ==250) != (1 << SHIFT_...
34e30d612f54e959a9953a62143f9f8402207b35
Analyze and fix the following issue in the Linux kernel code: [PATCH] fs_enet: Fix dma_unmap_single calls
Problem Details: The following patches fixes a bug with erroneous calling of dma_unmap_single. It never triggered because on normal ppc32 the calls is a NOP. Out of tree drivers need this fix however. Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
```diff diff --git a/drivers/net/fs_enet/fs_enet-main.c b/drivers/net/fs_enet/fs_enet-main.c index 44fac7373289..9342d5bc7bb4 100644 --- a/drivers/net/fs_enet/fs_enet-main.c +++ b/drivers/net/fs_enet/fs_enet-main.c @@ -130,7 +130,7 @@ static int fs_enet_rx_napi(struct net_device *dev, int *budget) skb = fep->rx_s...
86e7fe705d1b894df0cbb785991c92fa298af8fb
Analyze and fix the following issue in the Linux kernel code: [PATCH] PPC 4xx EMAC driver: fix VSC8201 PHY initialization
Problem Details: * MII registers must override strap pins * disable "echo" mode to make 10/HDX work (Franz Sirl) Signed-off-by: Eugene Surovegin <ebs@ebshome.net> Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
```diff diff --git a/drivers/net/ibm_emac/ibm_emac_phy.c b/drivers/net/ibm_emac/ibm_emac_phy.c index a27e49cfe43b..67935dd33a65 100644 --- a/drivers/net/ibm_emac/ibm_emac_phy.c +++ b/drivers/net/ibm_emac/ibm_emac_phy.c @@ -236,12 +236,16 @@ static struct mii_phy_def genmii_phy_def = { }; /* CIS8201 */ +#define MII_...
5ef66935c1f6d412b37cf4f68281bd4fc7fca7e5
Analyze and fix the following issue in the Linux kernel code: prom_free_prom_memory() returns unsigned long
Problem Details: Some boards declare prom_free_prom_memory as a void function but the caller free_initmem() expects a return value. Fix those up and return 0 instead, just like everyone else does. Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch> Signed-off-by: Ralf Baechle <ralf@linux-mips...
```diff diff --git a/arch/mips/momentum/jaguar_atx/prom.c b/arch/mips/momentum/jaguar_atx/prom.c index 14ae2e713585..aae7a802767a 100644 --- a/arch/mips/momentum/jaguar_atx/prom.c +++ b/arch/mips/momentum/jaguar_atx/prom.c @@ -236,8 +236,9 @@ void __init prom_init(void) #endif } -void __init prom_free_prom_memory(v...
3fccc0150e720ff344b5f9c5f8dd23778139018e
Analyze and fix the following issue in the Linux kernel code: Fix all the get_user / put_user related sparse warnings.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c index 99ffaa3d52b6..c4a7853c5714 100644 --- a/arch/mips/math-emu/cp1emu.c +++ b/arch/mips/math-emu/cp1emu.c @@ -209,7 +209,7 @@ static int cop1Emulate(struct pt_regs *xcp, struct mips_fpu_soft_struct *ctx) void * emulpc, *contpc; unsigne...
4f19f990475dc4465ca6906ba03a55805d4c1402
Analyze and fix the following issue in the Linux kernel code: Sibyte header cleanup
Problem Details: Update sibyte headers to match Broadcom internal copies: - comment cleanup and updates - fix LittleSur part number to match the board silkscreen Signed-Off-By: Andy Isaacson <adi@broadcom.com> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/sibyte/sb1250_defs.h b/include/asm-mips/sibyte/sb1250_defs.h index f67f5a3381a3..335dbaf1d831 100644 --- a/include/asm-mips/sibyte/sb1250_defs.h +++ b/include/asm-mips/sibyte/sb1250_defs.h @@ -8,8 +8,6 @@ * * SB1250 specification level: User's manual 1/02/02 * - ...
d121ced21d79eab7726bfe6b1e33da4ae86072c0
Analyze and fix the following issue in the Linux kernel code: Sibyte fixes
Problem Details: Fix typo in cpu_probe_sibyte. Signed-Off-By: Andy Isaacson <adi@broadcom.com> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c index 72c580d94e24..f7a841573b84 100644 --- a/arch/mips/kernel/cpu-probe.c +++ b/arch/mips/kernel/cpu-probe.c @@ -612,7 +612,7 @@ static inline void cpu_probe_sibyte(struct cpuinfo_mips *c) * cache code which eventually will be folded i...
750ccf687ff9adbf2a16066a3a2757d0f761384c
Analyze and fix the following issue in the Linux kernel code: Fix zero length sys_cacheflush
Problem Details: Cacheflush(0, 0, 0) was crashing the system. This is because flush_icache_range(start, end) tries to flushing whole address space (0 - ~0UL) if both start and end are zero. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c index 611b48dde737..314701a66b13 100644 --- a/arch/mips/mm/cache.c +++ b/arch/mips/mm/cache.c @@ -56,6 +56,8 @@ EXPORT_SYMBOL(_dma_cache_inv); asmlinkage int sys_cacheflush(unsigned long __user addr, unsigned long bytes, unsigned int cache) { + if (by...
beb3ca82fc0c2ec938b7446b006c8f34abb301b2
Analyze and fix the following issue in the Linux kernel code: More configcheck fixes.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/mach-au1x00/au1xxx_psc.h b/include/asm-mips/mach-au1x00/au1xxx_psc.h index 283519dfdec4..8e5fb3c7da4d 100644 --- a/include/asm-mips/mach-au1x00/au1xxx_psc.h +++ b/include/asm-mips/mach-au1x00/au1xxx_psc.h @@ -33,6 +33,8 @@ #ifndef _AU1000_PSC_H_ #define _AU1000_PSC_H_ +#include...
8592d4c00eeb92495eaab6374baaad79b30866ed
Analyze and fix the following issue in the Linux kernel code: Fix weirdness in <asm/bug.h>
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/bug.h b/include/asm-mips/bug.h index 8e1144f4a0b0..87d49a5bdc63 100644 --- a/include/asm-mips/bug.h +++ b/include/asm-mips/bug.h @@ -7,13 +7,12 @@ #include <asm/break.h> -#ifdef CONFIG_BUG -#define HAVE_ARCH_BUG #define BUG() \ do { \ __asm__ __volatile__("b...
dbc571690ec4123e4e9fd6e731d8bdfa77b0d90e
Analyze and fix the following issue in the Linux kernel code: Fix wrong comment.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c index 5e1967f14255..f75ab748e8cd 100644 --- a/arch/mips/mm/init.c +++ b/arch/mips/mm/init.c @@ -131,7 +131,7 @@ void __init fixrange_init(unsigned long start, unsigned long end, j = 0; } } -#endif /* CONFIG_64BIT */ +#endif /* CONFIG_32BIT */ #endif ...
6aaf7786ed02da7797432708fbcdd242f9c0764e
Analyze and fix the following issue in the Linux kernel code: No need to explicitly call __read_64bit_c0_split; __read_64bit_c0_register
Problem Details: will do that itself iff needed. Fix format string. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/sibyte/swarm/setup.c b/arch/mips/sibyte/swarm/setup.c index b8be07f061ee..f8963de1bbf4 100644 --- a/arch/mips/sibyte/swarm/setup.c +++ b/arch/mips/sibyte/swarm/setup.c @@ -73,13 +73,8 @@ int swarm_be_handler(struct pt_regs *regs, int is_fixup) { if (!is_fixup && (regs->cp0_cause & 4)) ...
46dc3a4a098c65551d5f364e1c56331961400314
Analyze and fix the following issue in the Linux kernel code: Fix stale comment in c-sb1.c.
Problem Details: Signed-Off-By: Andrew Isaacson <adi@broadcom.com> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/c-sb1.c b/arch/mips/mm/c-sb1.c index 70d1ab30f7af..b21585980a15 100644 --- a/arch/mips/mm/c-sb1.c +++ b/arch/mips/mm/c-sb1.c @@ -492,7 +492,7 @@ static __init void probe_cache_sizes(void) } /* - * This is called from loadmmu.c. We have to set up all the + * This is called from cac...
c5c96e13790122095fdf2ea74a8131e5f6b60c03
Analyze and fix the following issue in the Linux kernel code: Fix build error caused by missmatching duplicate declaration.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c index e793ffd39db5..762c7a593141 100644 --- a/drivers/video/console/newport_con.c +++ b/drivers/video/console/newport_con.c @@ -32,7 +32,6 @@ #include <linux/font.h> -extern struct font_desc font_vga_8x16; extern unsign...
0015365cc68a5b6ad22dfdac19580aa9530731c3
Analyze and fix the following issue in the Linux kernel code: Fix ARCH_KMALLOC_MINALIGN values on MIPS
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/cache.h b/include/asm-mips/cache.h index 4517bdf20953..1a5d1a669db3 100644 --- a/include/asm-mips/cache.h +++ b/include/asm-mips/cache.h @@ -10,6 +10,7 @@ #define _ASM_CACHE_H #include <linux/config.h> +#include <kmalloc.h> #define L1_CACHE_SHIFT CONFIG_MIPS_L1_CACHE_SHIFT ...
9d58f302ca370c720fa47cb419f0b33eaa1a1132
Analyze and fix the following issue in the Linux kernel code: Glue again after removal of BUILD_BUG().
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/io.h b/include/asm-mips/io.h index 42f80782acd2..3061870b7f6c 100644 --- a/include/asm-mips/io.h +++ b/include/asm-mips/io.h @@ -387,11 +387,11 @@ static inline void pfx##out##bwlq##p(type val, unsigned long port) \ \ __val = pfx##ioswab##bwlq(val); \ \ - ...
13bb199f98d179664cc24ab2e4762ef8ab059acc
Analyze and fix the following issue in the Linux kernel code: Fix a cache snooping issue.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/au1000/common/dbdma.c b/arch/mips/au1000/common/dbdma.c index eb5803aed91b..80d241b9c6f4 100644 --- a/arch/mips/au1000/common/dbdma.c +++ b/arch/mips/au1000/common/dbdma.c @@ -141,12 +141,12 @@ static dbdev_tab_t dbdev_tab[] = { { DSCR_CMD0_AES_RX, DEV_FLAGS_IN , 4, 32, 0x10300008, 0, 0...
0bf0e3e279661c42ad43014d62ddd87d42da12e7
Analyze and fix the following issue in the Linux kernel code: Fix excessive signal latencies.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/entry.S b/arch/mips/kernel/entry.S index 6e01b0dd031f..83c87fe4ee4f 100644 --- a/arch/mips/kernel/entry.S +++ b/arch/mips/kernel/entry.S @@ -105,7 +105,7 @@ work_notifysig: # deal with pending signals and move a0, sp li a1, 0 jal do_notify_resume # a2 already loaded - j re...
10a3dabddd79473130c6ded7f7cef1d55fccc115
Analyze and fix the following issue in the Linux kernel code: Add/Fix missing bit of R4600 hit cacheop workaround.
Problem Details: Signed-off-by: Thiemo Seufer <ths@networkno.de> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c index 586baf29fe88..aa87ae552170 100644 --- a/arch/mips/mm/c-r4k.c +++ b/arch/mips/mm/c-r4k.c @@ -481,6 +481,7 @@ static inline void local_r4k_flush_icache_range(void *args) if (end - start > dcache_size) { r4k_blast_dcache(); } else { + R4600...
aaa49075c6a75332dac6fb401518c0a72b103443
Analyze and fix the following issue in the Linux kernel code: Typo fix.
Problem Details: Signed-off-by: Thiemo Seufer <ths@networkno.de> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/mach-generic/cpu-feature-overrides.h b/include/asm-mips/mach-generic/cpu-feature-overrides.h index 0aecfd08e39a..7c185bb06f13 100644 --- a/include/asm-mips/mach-generic/cpu-feature-overrides.h +++ b/include/asm-mips/mach-generic/cpu-feature-overrides.h @@ -8,6 +8,6 @@ #ifndef __AS...
f8670e66dc3f08512b57cb7872932fb0710de589
Analyze and fix the following issue in the Linux kernel code: Fix MAP_BASE for 64bit ip22.
Problem Details: Signed-off-by: Thiemo Seufer <ths@networkno.de> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/mach-ip22/spaces.h b/include/asm-mips/mach-ip22/spaces.h index e96166f27c49..8385f716798d 100644 --- a/include/asm-mips/mach-ip22/spaces.h +++ b/include/asm-mips/mach-ip22/spaces.h @@ -44,7 +44,7 @@ #define CAC_BASE 0xffffffff80000000 #define IO_BASE 0xffffffffa0000000 #defin...
e607d6c8b8dd684936fda4b2cc37ad9f9104bed4
Analyze and fix the following issue in the Linux kernel code: Get rid of a bunch of debug serial routines. Use prom_printf instead.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/au1000/common/puts.c b/arch/mips/au1000/common/puts.c index c2ae4624b77b..2705829cd466 100644 --- a/arch/mips/au1000/common/puts.c +++ b/arch/mips/au1000/common/puts.c @@ -39,7 +39,6 @@ #define TIMEOUT 0xffffff #define SLOW_DOWN -static const char digits[16] = "0123456789abcdef"...
fabffc13ed720eea986f80f432cedb4550f464ed
Analyze and fix the following issue in the Linux kernel code: Remove workaround for binutils 2.15 assembler bug; this version is not
Problem Details: suitable to reliably build kernels anymore anyway and 2.16 has this fixed. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/system.h b/include/asm-mips/system.h index 0f8caf384249..b1ac3f5bfc3b 100644 --- a/include/asm-mips/system.h +++ b/include/asm-mips/system.h @@ -164,10 +164,6 @@ do { \ __restore_dsp(current); \ } while(0) -#define ROT_IN_PIECES \ - " .set noreorder \n" \...
27c7c1657df54352838d176b39e119b799bf7855
Analyze and fix the following issue in the Linux kernel code: Drop might_sleep() calls from get_user() & co. This should fix the issue
Problem Details: in http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=200508171321.20094.Joshua.Wise%40sicortex.com and it's the right thing to do anyway because it was inflating those functions way too much. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/uaccess.h b/include/asm-mips/uaccess.h index b41901db69b8..41bb96bb2120 100644 --- a/include/asm-mips/uaccess.h +++ b/include/asm-mips/uaccess.h @@ -213,7 +213,6 @@ struct __large_struct { unsigned long buf[100]; }; __typeof(*(ptr)) __gu_val = (__typeof(*(ptr))) 0; \ long __g...
0952e2905c6bc2e12a43910c7eb898b6481a57b5
Analyze and fix the following issue in the Linux kernel code: Fix parenthesis in macros.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/mipsregs.h b/include/asm-mips/mipsregs.h index 08aa231b4dea..50dea25b9dd8 100644 --- a/include/asm-mips/mipsregs.h +++ b/include/asm-mips/mipsregs.h @@ -693,13 +693,13 @@ do { \ if (sel == 0) \ __asm__ __volatile__( \ "mtc0\t%z0, " #register "\n\t" \ - ...
28a7879d8ca6afafbd1583dd777587e441d0f90e
Analyze and fix the following issue in the Linux kernel code: Spelling fix.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/i8259.c b/arch/mips/kernel/i8259.c index a7d2aac46eea..911537413b63 100644 --- a/arch/mips/kernel/i8259.c +++ b/arch/mips/kernel/i8259.c @@ -307,7 +307,7 @@ static struct resource pic2_io_resource = { /* * On systems with i8259-style interrupt controllers we assume for - * dri...
d3ffd085536c1801da74c098e25fd3985671e15d
Analyze and fix the following issue in the Linux kernel code: Use pr_debug instead of homegrown debug print macros.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/sgi-ip27/ip27-irq.c b/arch/mips/sgi-ip27/ip27-irq.c index d3b64f7c1d52..73e5e52781d8 100644 --- a/arch/mips/sgi-ip27/ip27-irq.c +++ b/arch/mips/sgi-ip27/ip27-irq.c @@ -5,6 +5,9 @@ * Copyright (C) 1999, 2000 Silicon Graphics, Inc. * Copyright (C) 1999 - 2001 Kanoj Sarcar */ + +#undef...
3ce86ee14ba7c4b0f8ddae6030df9d0dee15b236
Analyze and fix the following issue in the Linux kernel code: Au1x PM fixes.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/au1000/common/irq.c b/arch/mips/au1000/common/irq.c index 6a25677bf3cb..112beb7fe001 100644 --- a/arch/mips/au1000/common/irq.c +++ b/arch/mips/au1000/common/irq.c @@ -83,7 +83,7 @@ inline void local_disable_irq(unsigned int irq_nr); void (*board_init_irq)(void); #ifdef CONFIG_PM -ext...
7ab1261f5fe421602fadeda1d89662303b08830b
Analyze and fix the following issue in the Linux kernel code: Drop IP27 support for Qlogic ISP. This driver is buggy and has been
Problem Details: obsoleted by the qla1280 after the recent fixes. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig index f6b25ae1861b..338c21f3efd3 100644 --- a/arch/mips/Kconfig +++ b/arch/mips/Kconfig @@ -1071,11 +1071,6 @@ config BOOT_ELF64 # depends on SGI_IP27 # default y -config QL_ISP_A64 - bool - depends on SGI_IP27 - default y - config TOSHIBA_BOARDS bool ...
f10fae02403fb8af141b0a440074a944ccd63504
Analyze and fix the following issue in the Linux kernel code: Fix the fixup_bigphys_addr compile problem.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/mach-au1x00/ioremap.h b/include/asm-mips/mach-au1x00/ioremap.h index f1c8c1087115..d3ec6274575a 100644 --- a/include/asm-mips/mach-au1x00/ioremap.h +++ b/include/asm-mips/mach-au1x00/ioremap.h @@ -12,7 +12,9 @@ #include <linux/config.h> #include <linux/types.h> -#ifndef CONFIG_...
569f75bd02d20043c4baf9fc38d937f37e7572b0
Analyze and fix the following issue in the Linux kernel code: Use an irq_enable_hazard hazard barrier in unmask_mips_irq. This
Problem Details: hasn't been an actual bug, so it's more a change to be 100% compliant with the requirements of the architecture spec. Similar fix to mask_mips_irq where there was a slightly less theoretical chance of getting hit. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/irq_cpu.c b/arch/mips/kernel/irq_cpu.c index 905ff843a68f..060722e42c53 100644 --- a/arch/mips/kernel/irq_cpu.c +++ b/arch/mips/kernel/irq_cpu.c @@ -40,11 +40,13 @@ static int mips_cpu_irq_base; static inline void unmask_mips_irq(unsigned int irq) { set_c0_status(0x100 << (irq ...
c0ec406c80a65590dbdb60ed0d0c8e73e6c3884f
Analyze and fix the following issue in the Linux kernel code: Fix endianess bugs.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/vga.h b/include/asm-mips/vga.h index 6b35cf054c79..ca5cec97e167 100644 --- a/include/asm-mips/vga.h +++ b/include/asm-mips/vga.h @@ -6,6 +6,8 @@ #ifndef _ASM_VGA_H #define _ASM_VGA_H +#include <asm/byteorder.h> + /* * On the PC, we can just recalculate addresses and then *...
9556ac2fa1b16ec702e200fc558636a09a50f0e0
Analyze and fix the following issue in the Linux kernel code: Fix get_saved_sp for 64bit address space. Simplify set_save_sp.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Thiemo Seufer <ths@networkno.de>
```diff diff --git a/include/asm-mips/stackframe.h b/include/asm-mips/stackframe.h index de303e96260e..a8919dcc93c8 100644 --- a/include/asm-mips/stackframe.h +++ b/include/asm-mips/stackframe.h @@ -90,24 +90,28 @@ #ifdef CONFIG_32BIT mfc0 \temp, CP0_CONTEXT srl \temp, 23 - LONG_S \stackp, kernelsp(\temp) #end...
50bd2c72ca72c07d5640e3490845d4b0faf6c124
Analyze and fix the following issue in the Linux kernel code: Brian Murphy says:
Problem Details: this fixes Lasat pci to work with multi-function devices by assigning the correct values based on pin number (instead of ignoring them). Signed-off-by: Ralf Baechle <ralf@linux-mips.org> Signed-off-by: Thiemo Seufer <ths@networkno.de>
```diff diff --git a/arch/mips/pci/pci-lasat.c b/arch/mips/pci/pci-lasat.c index f20fde388083..88fb191ad2eb 100644 --- a/arch/mips/pci/pci-lasat.c +++ b/arch/mips/pci/pci-lasat.c @@ -68,11 +68,9 @@ int __init pcibios_map_irq(struct pci_dev *dev, u8 slot, u8 pin) { switch (slot) { case 1: - return LASATINT_PCIA; ...
4c0a2d4275b6993066810c42c4c6b0729d3b67a9
Analyze and fix the following issue in the Linux kernel code: Fix the diagnostic dump for the XTLB refill handler.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c index c7b3bf22bf3f..19bf0cc40917 100644 --- a/arch/mips/mm/tlbex.c +++ b/arch/mips/mm/tlbex.c @@ -1238,8 +1238,15 @@ static void __init build_r4000_tlb_refill_handler(void) { int i; + f = final_handler; +#ifdef CONFIG_64BIT + if (final_len > 32) ...
41986a6e7ea3b3acb452d00d56acda7c63761736
Analyze and fix the following issue in the Linux kernel code: Fix a diagnostic message.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c index 48546d18a5a3..c7b3bf22bf3f 100644 --- a/arch/mips/mm/tlbex.c +++ b/arch/mips/mm/tlbex.c @@ -731,7 +731,7 @@ static void __init build_r3000_tlb_refill_handler(void) if (p > tlb_handler + 32) panic("TLB refill handler space exceeded"); - printk...
64dac503e8265007ea5c53b4d6bf42488a8a8d7a
Analyze and fix the following issue in the Linux kernel code: System-specific handling of bus errors for DECstation variations
Problem Details: supporting parity errors only for memory (Pmax/3min/Maxine). Fixes for resources decoded by the KN04/KN05 MB ASIC. Additional clean-ups for the ECC handler. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/dec/Makefile b/arch/mips/dec/Makefile index 688757a97cb8..ed181fdc3ac9 100644 --- a/arch/mips/dec/Makefile +++ b/arch/mips/dec/Makefile @@ -2,8 +2,8 @@ # Makefile for the DECstation family specific parts of the kernel # -obj-y := ecc-berr.o int-handler.o ioasic-irq.o kn02-irq.o reset...
8a185d14b665d454bde84c6ae067beade452e7f8
Analyze and fix the following issue in the Linux kernel code: Fix types for firmware arguments. Don't define unneeded messages.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/dec/prom/init.c b/arch/mips/dec/prom/init.c index 60f74256e689..32a7cc7e4c65 100644 --- a/arch/mips/dec/prom/init.c +++ b/arch/mips/dec/prom/init.c @@ -6,6 +6,8 @@ */ #include <linux/config.h> #include <linux/init.h> +#include <linux/kernel.h> +#include <linux/linkage.h> #include <li...
778220f7c4a3357f7464a45044fd4937126ba6c5
Analyze and fix the following issue in the Linux kernel code: Fix function types to ones appropriate for initcalls.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/drivers/tc/tc.c b/drivers/tc/tc.c index 2613c5135c09..d742c3a90b23 100644 --- a/drivers/tc/tc.c +++ b/drivers/tc/tc.c @@ -8,7 +8,7 @@ * for more details. * * Copyright (c) Harald Koerfgen, 1998 - * Copyright (c) 2001, 2003 Maciej W. Rozycki + * Copyright (c) 2001, 2003, 2005 Maciej W. Rozyc...
aac8aa7717a23a9bf8740dbfb59755b1d62f04bf
Analyze and fix the following issue in the Linux kernel code: Enable a suitable ISA for the assembler around ll/sc so that code
Problem Details: builds even for processors that don't support the instructions. Plus minor formatting fixes. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/semaphore.c b/arch/mips/kernel/semaphore.c index 9c40fe5a8e8d..dbb145ee00a7 100644 --- a/arch/mips/kernel/semaphore.c +++ b/arch/mips/kernel/semaphore.c @@ -42,24 +42,28 @@ static inline int __sem_update_count(struct semaphore *sem, int incr) if (cpu_has_llsc && R10000_LLSC_WAR...
a93500037e6cf1d08ce112444386f408a047b548
Analyze and fix the following issue in the Linux kernel code: Fix dependencies for DECstation framebuffers.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 1cd942abb580..7e297947a2b2 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -1376,7 +1376,7 @@ config FB_HIT config FB_PMAG_AA bool "PMAG-AA TURBOchannel framebuffer support" - depends on (FB = y) && MACH_DECSTATION && TC + d...
ac130ac494522cf71782117b8dd4b6b57e31e5ea
Analyze and fix the following issue in the Linux kernel code: Fix build with CONFIG_PRINTK disabled.
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/include/asm-mips/asm.h b/include/asm-mips/asm.h index f53237772985..4b090f3142e0 100644 --- a/include/asm-mips/asm.h +++ b/include/asm-mips/asm.h @@ -107,6 +107,7 @@ symbol = value /* * Print formatted string */ +#ifdef CONFIG_PRINTK #define PRINT(string) \ ...
10f650db1bcc193ea07d4f8c2f07315da38ea0c4
Analyze and fix the following issue in the Linux kernel code: 64-bit fixes for Alchemy code ;)
Problem Details: Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
```diff diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c index cde88285a52f..552d2b6c191e 100644 --- a/arch/mips/kernel/cpu-probe.c +++ b/arch/mips/kernel/cpu-probe.c @@ -53,14 +53,13 @@ static void r4k_wait(void) /* The Au1xxx wait is available only if using 32khz counter or * external timer...