text
stringlengths
0
2.35k
**Jingle:** \[50:42\] to \[50:59\]
**Natalie Pistunovich:** For anybody who's not joining the live stream, Inbal was dancing to all the tunes like she's heard them forever... So either you've been listening secretly to this podcast, or I can understand why you make friends in the supermarket. You're are super-friendly.
**Inbal Cohen:** Yay!
**Natalie Pistunovich:** \[laughs\]
**Inbal Cohen:** I love the tunes.
**Natalie Pistunovich:** Thank you, thank you. Okay, so what is your unpopular opinion today, Inbal?
**Inbal Cohen:** My unpopular opinion has to do with roadmaps. Roadmaps are a very, very dangerous tool, that a lot of times is used against development teams, instead of by development teams for the business.
**Natalie Pistunovich:** Interesting...
**Inbal Cohen:** And my unpopular opinion would be - and this is funny, because it's an unpopular opinion in many companies that I've been in, but it's actually how they're supposed to be done... Which is roadmaps should be a combination of two directions meeting in the middle. From the top, we have the Why; the busine...
And roadmaps are supposed to take those two edges of the Why and the How, and bring them in the middle, which also is the house of When. So when we're trying to drop on development teams when things are done, we're limiting how things are done. There's all sorts of different types of metrics that we can look at that ha...
**Natalie Pistunovich:** I'm like that meme with all the numbers... I know you two understand each other, because you both are product, but I was lost in here... Can you say that in one line for me? I'm like that meme where you see all the math formulas... Like, I understand, it makes all sense... It does need to meet ...
**Inbal Cohen:** \[53:59\] That roadmaps need to come from development up, and not from business down. So roadmaps aren't something that you are given as a development team. It's something that you build.
**Natalie Pistunovich:** I agree with you. I think you have my voice. \[laughs\]
**Angelica Hill:** I want to be clear, is the proposition that software engineers work on the roadmap and bring it to product managers? I want to be very like logistical here. And are they then accountable for saying why they think that it's the correct course of action? In the same way, if you do it the other way arou...
**Inbal Cohen:** So how it would work in like in a really nice setup... Business comes in and says "We have an X amount of new clients that we have to onboard. We have a deadline. It's a hard deadline. We have to have this by the end of 2023, or the company goes belly up." Right? So these are the types of deadlines tha...
And what happens a lot of times is that companies kind of forget that it's a sprint at scale. They forget that, and that's one of the issues that we have a lot of times with companies that think that they're doing agile, is that a lot of times when you have stress, any stress - it could be stress on the system, it coul...
**Angelica Hill:** So can you even use roadmaps effectively in agile? Or is there an argument that any roadmap you create today will be different tomorrow, so what's the point?
**Inbal Cohen:** There is a point. And the reason that there is a point is, one, I don't really like roadmaps; I like more the idea of goal maps. I have goals I would like to achieve. It's not about having a specific amount of lines of code, it's about an increment of values that I want to achieve in a certain amount o...
But on the other hand, it is very important for me to have, one, a Northern Star. Where am I aiming? What is the direction that I'm aiming my ship? And then having these milestones on the way as these buoys to make sure that I'm still on course to get to that direction that I want to arrive to. If I don't put any of th...
**Natalie Pistunovich:** \[58:16\] Yeah, that makes a lot of sense. It also connects to a conversation we had a couple episodes ago about velocity. It makes a lot of sense, everything, so thank you for clarifying everything and sharing all that. I'll use the last minute to share my unpopular opinion that I've been plan...
The interesting thing is that we will be asking our Twitter followers for how unpopular is this unpopular opinion, and I think, at least in the field, in this little crowd of developers, Inbal, what you say, you might end up in the wall of popular unpopular opinions, because it does make sense for developers to give th...
**Angelica Hill:** But the developers want to be accountable for that cognitive extra load...
**Natalie Pistunovich:** This was not part of the unpopular opinion...
**Angelica Hill:** Do they want to? \[laughs\]
**Natalie Pistunovich:** I can't hear you... The connection breaks... \[laughs\]
**Angelica Hill:** Do developers want to take on that extra cognitive load? Do you want to be accountable for putting together the roadmap?
**Natalie Pistunovich:** Yeah, that is a good point. I'm thinking whether this is a popular or an unpopular opinion. That's a fair one.
**Angelica Hill:** I mean, it's probably two sides of the same coin, and part of me is like, I really want to continue doing it. I really enjoy doing it. But also, another part of me is like, developers already have so much they need to do in their lives. We put so much accountability on them. I feel like this is somet...
**Natalie Pistunovich:** So here's a question for you to think about, just kind of going forward, nothing related to this specific episode... So you mentioned developers have a lot of responsibility, and a way to go about let's say respecting this responsibility while writing code is actually writing a lot of tests to ...
**Angelica Hill:** Oh, I love that... That was a brilliant question, that we could have a whole other episode on.
**Natalie Pistunovich:** Absolutely. We will.
**Inbal Cohen:** I should have used that as my unpopular opinion, talking about testing... \[laughs\]
**Angelica Hill:** Next time.
**Natalie Pistunovich:** Well, we have many more episodes, and we hope you'll join us again.
**Inbal Cohen:** Thank you for having me. I had fun!
**Natalie Pistunovich:** Thanks a lot for joining, and thanks everyone who listened.
• What is a PR (pull request) and its purpose
• Why PRs are useful for getting feedback on code changes
• How to assess when a PR is ready to be reviewed by peers
• The difference between "PR" and "CR" (code review)
• The origin of the term "pull request"
• Alternative terms used in different contexts or ticketing systems
• Discussion of various terms for submitting code changes, including "changelog", "pull request", and "merge request".
• Debate about the ideal size of a pull request (PR), with some arguing it's too long or too short.
• Strategies for determining PR size, including reviewing ability, number of files changed, and commit count.
• Discussion of team conventions for reviewing PRs, including one or multiple reviewers and norms around PR length.
• Baking a cake analogy for understanding PRs and feedback
• Importance of breaking down complex changes into individual components for review
• Role of empathy in code reviews, including giving constructive feedback and acknowledging effort put into the change
• Unspoken rules of PR review, such as leading with empathy and avoiding condescending language
• Benefits of approaching code reviews as a collaborative process rather than a one-sided evaluation
• The importance of empathy in code reviews
• Balancing functionality and style considerations in code review
• Automating code style checks using tools like linters and formatters
• Establishing team norms for code style and structure
• Providing interpersonal feedback based on shared expectations
• Reviewing PRs from new engineers differently than those from experienced engineers
• The value of a fresh perspective in code reviews, including challenging assumptions and bringing new ideas
• Balancing seniority and expertise in code review, with less experienced reviewers bringing valuable insights
• Difficulty in providing and receiving constructive feedback across cultures
• Challenges with non-native English speakers in code reviews
• Importance of empathy and understanding tone in written communication
• Cultural differences in relationships with feedback and criticism
• Ideas for improving communication, including adding voice notes or emojis to PRs
• Use of emojis in code reviews for categorizing comments as blocking or non-blocking