text stringlengths 0 2.35k |
|---|
[3199.74 --> 3202.82] I think there is an art to it. |
[3203.00 --> 3203.96] You're kind of balancing |
[3203.96 --> 3205.52] the empathy |
[3205.52 --> 3207.62] of giving this person feedback |
[3207.62 --> 3209.24] and acknowledging |
[3209.24 --> 3209.90] how much work |
[3209.90 --> 3211.00] they've put into it |
[3211.00 --> 3211.92] but at the same time |
[3211.92 --> 3212.50] you have to, |
[3212.74 --> 3212.90] you know, |
[3212.94 --> 3213.50] you kind of, |
[3213.94 --> 3214.50] if you're like, |
[3215.12 --> 3216.30] if this is like a critical service, |
[3216.42 --> 3217.42] you're going to be the one |
[3217.42 --> 3217.80] that's, |
[3218.28 --> 3219.04] that might be paged |
[3219.04 --> 3219.94] during the middle of the night |
[3219.94 --> 3221.06] if something goes wrong |
[3221.06 --> 3221.88] and all you see that, |
[3222.10 --> 3222.52] this commit |
[3222.52 --> 3224.66] is what's causing the issue. |
[3225.18 --> 3226.20] But also you, |
[3226.26 --> 3227.86] you kind of have to balance |
[3227.86 --> 3229.60] that with the time, |
[3229.72 --> 3229.90] you know, |
[3229.94 --> 3231.56] you still have to get things done. |
[3232.00 --> 3233.20] It's a big balancing act |
[3233.20 --> 3234.12] of how much, |
[3234.46 --> 3234.68] like, |
[3235.12 --> 3235.98] is something like, |
[3236.16 --> 3236.86] is this critical |
[3236.86 --> 3238.20] that this needs to get changed |
[3238.20 --> 3238.86] even though it's like |
[3238.86 --> 3239.82] a stylistic thing |
[3239.82 --> 3241.02] that goes against |
[3241.02 --> 3242.70] like our team norms |
[3242.70 --> 3244.32] but it's imperative |
[3244.32 --> 3245.70] that this gets through |
[3245.70 --> 3247.34] or maybe they've already |
[3247.34 --> 3248.34] spent a lot of time on it. |
[3248.66 --> 3249.68] So it's definitely like |
[3249.68 --> 3251.80] the art of like juggling |
[3251.80 --> 3252.94] or balancing, |
[3253.16 --> 3253.30] so. |
[3253.90 --> 3255.22] I think just experience |
[3255.22 --> 3256.32] goes a long way. |
[3256.62 --> 3257.60] Like learn by doing. |
[3257.84 --> 3258.66] You can kind of |
[3258.66 --> 3260.32] experience a lot of things |
[3260.32 --> 3261.12] that you want to emulate |
[3261.12 --> 3262.64] or things that you're like, |
[3262.70 --> 3262.82] wow, |
[3262.88 --> 3263.46] that didn't make, |
[3263.84 --> 3264.54] leave me feeling |
[3264.54 --> 3265.76] really good about myself |
[3265.76 --> 3267.36] so I know not to do this |
[3267.36 --> 3268.02] in the future. |
[3268.28 --> 3269.56] But also like |
[3269.56 --> 3271.46] just getting more experienced |
[3271.46 --> 3273.34] in whatever language |
[3273.34 --> 3274.54] that you're working on |
[3274.54 --> 3276.36] to then make those |
[3276.36 --> 3277.34] suggestions |
[3277.34 --> 3278.98] that can make the code |
[3278.98 --> 3279.58] better |
[3279.58 --> 3281.08] and more performant. |
[3281.18 --> 3282.18] That's like another layer |
[3282.18 --> 3283.88] of doing a PR review |
[3283.88 --> 3285.30] but still something |
[3285.30 --> 3286.58] that comes with more time. |
[3287.12 --> 3287.22] Yeah, |
[3287.30 --> 3287.76] and I think |
[3287.76 --> 3288.60] from the perspective |
[3288.60 --> 3289.96] like authoring a PR |
[3289.96 --> 3291.08] and asking for a review |
[3291.08 --> 3291.78] that's also |
[3291.78 --> 3293.46] something that |
[3293.46 --> 3294.52] is like a skill |
[3294.52 --> 3295.90] that can be honed |
[3295.90 --> 3296.38] and taught |
[3296.38 --> 3297.62] and improved |
[3297.62 --> 3298.50] at any level |
[3298.50 --> 3299.06] because |
[3299.06 --> 3300.58] figuring out like |
[3300.58 --> 3302.12] when a PR is done, |
[3302.26 --> 3303.26] how big it is, |
[3303.62 --> 3305.20] but also in some situations |
[3305.20 --> 3306.96] maybe you're introducing |
[3306.96 --> 3307.94] a change |
[3307.94 --> 3309.80] and maybe you have |
[3309.80 --> 3310.44] to like write up |
[3310.44 --> 3311.10] like why |
[3311.10 --> 3312.48] you think that change |
[3312.48 --> 3313.18] is the right path |
[3313.18 --> 3313.80] to move forward |
[3313.80 --> 3314.56] and there's always |
[3314.56 --> 3316.16] room to improve on |
[3316.16 --> 3317.10] like making |
[3317.10 --> 3318.86] a concise argument. |
[3318.86 --> 3319.86] I think that's |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.