text stringlengths 0 2.35k |
|---|
[1596.76 --> 1598.12] It's not the pull request so much, right? |
[1598.58 --> 1599.14] What's happening? |
[1599.80 --> 1601.72] You have to comment on it, right? |
[1601.76 --> 1603.64] So it's really hard to comment on it. |
[1604.02 --> 1605.64] At least for the tools that I use. |
[1605.72 --> 1607.44] That's GitHub and the IDE. |
[1608.10 --> 1609.62] It's hard to comment on the code. |
[1609.62 --> 1612.98] If it's something that for some reason. |
[1613.54 --> 1620.14] You know, when you do either a Greenfield project or the pull request is a huge refactor. |
[1620.46 --> 1621.70] You know, everything changed. |
[1621.76 --> 1623.20] So pretty much new code. |
[1623.20 --> 1629.02] So on that rare occasions, I might open the code itself, right? |
[1629.38 --> 1632.94] Because then I can read in like an execution order, let's say. |
[1633.68 --> 1637.54] And then my comments, they are probably going to be comments on the code itself. |
[1638.22 --> 1641.40] And then I've done it, I don't know, once or twice. |
[1641.40 --> 1644.90] And then I create my branch out of this branch. |
[1645.12 --> 1647.62] And then I open a pull request for this branch. |
[1647.76 --> 1651.96] So the person can see my comments in the code without having to look for it. |
[1652.34 --> 1657.68] But this is pretty much in either Greenfield projects, you know, when you start something new. |
[1658.20 --> 1661.70] Or when you're just adding so much new code. |
[1662.64 --> 1666.16] That the pull request itself, it's hard because it's completely out of road and everything. |
[1666.34 --> 1667.44] And there's a lot to comment on. |
[1667.80 --> 1669.10] Yeah, that's the hardest ones, right? |
[1669.10 --> 1671.64] When there's so much to handle there. |
[1672.22 --> 1672.46] Yeah. |
[1672.96 --> 1678.14] Do you sometimes find yourself rereading the whole thing to kind of once to read it and second time to make sense? |
[1678.94 --> 1679.24] Oh, yeah. |
[1679.30 --> 1680.00] No, yeah, definitely. |
[1680.18 --> 1680.42] Definitely. |
[1680.52 --> 1686.26] I think, yeah, going back to like old goal time when they talk about documentation and reading documentation. |
[1686.56 --> 1687.76] I have the perseverance. |
[1688.14 --> 1692.06] If I'm not understanding, I'm going to read it over and over and over again. |
[1692.06 --> 1694.08] And I'm going to do my best to understand. |
[1694.40 --> 1696.64] If I don't, I'm going to ask, right? |
[1696.64 --> 1703.36] But I think if someone thinks puzzling me, then I'm probably going to blog say, look, I think this is important. |
[1703.48 --> 1704.06] I don't get it. |
[1704.12 --> 1704.88] Please explain. |
[1705.34 --> 1705.48] Yeah. |
[1705.82 --> 1707.14] Do you comment as you go? |
[1707.24 --> 1712.86] Or do you read through fully, digest and then go through and do all your comments? |
[1713.62 --> 1714.06] No, no. |
[1714.18 --> 1716.36] I comment as I go, like as I stream. |
[1716.48 --> 1716.68] Okay. |
[1716.68 --> 1720.98] And then when I get down there, I was like, oh, yeah, that's the why. |
[1721.10 --> 1722.40] So I go back and delete the comments. |
[1722.54 --> 1722.96] Oh, okay. |
[1723.16 --> 1725.12] You know, it's like, dude, does it make sense? |
[1725.24 --> 1726.52] You know, something like that. |
[1727.00 --> 1727.36] Why? |
[1727.48 --> 1728.32] How does it work? |
[1728.38 --> 1729.08] And then you read it. |
[1729.56 --> 1729.64] Oh. |
[1730.84 --> 1732.98] And then I go back, delete and edit the comments. |
[1733.18 --> 1733.60] Go back. |
[1733.66 --> 1734.34] Oh, I'm so sorry. |
[1734.42 --> 1734.92] Never mind. |
[1735.84 --> 1738.30] I mean, on GitHub, you don't submit the review, right? |
[1738.48 --> 1738.70] Yeah. |
[1739.02 --> 1740.44] So I just delete. |
[1740.58 --> 1741.84] But the feeling is exactly that. |
[1741.92 --> 1743.90] I'm apologizing for asking something stupid. |
[1743.90 --> 1752.16] When you're going over a PR, do you feel like, or any reviewer should test the changes? |
[1753.06 --> 1758.40] And to what extent should you test the changes if you think that they should be tested by the reviewer? |
[1758.86 --> 1760.90] I think that's the $1 million question. |
[1761.24 --> 1762.06] Give us the answer. |
[1762.20 --> 1762.66] We're ready. |
[1762.94 --> 1764.32] Maybe another popular opinion. |
[1764.32 --> 1768.14] No, I think the answer is it depends, right? |
[1768.26 --> 1768.38] Right. |
[1768.72 --> 1770.44] We say a lot of that at the last take. |
[1770.44 --> 1774.30] But I think it depends on your role on this pull request, right? |
[1774.38 --> 1783.40] So if imagine that I maintain an open source and I'm taking something from a person that's not from the repo, I would be extra careful. |
[1783.64 --> 1786.42] So perhaps I would try to run the code. |
[1786.84 --> 1790.78] Usually I don't really test the code, right? |
[1790.78 --> 1798.74] But again, if it's something that I feel that's really critical and I want to be sure that's 100% working, I might test it. |
[1799.38 --> 1800.42] But it's rare cases. |
[1801.12 --> 1801.26] Okay. |
[1801.70 --> 1806.50] And does the length of the PR or the scope of the change change that opinion? |
[1807.06 --> 1807.34] Yeah. |
[1807.66 --> 1807.92] Okay. |
[1808.10 --> 1809.84] I think the length, not so much. |
[1810.26 --> 1810.88] Let's be honest. |
[1811.12 --> 1815.28] The longer the PR, the less detailed is the review. |
[1816.04 --> 1816.62] We are humans. |
[1816.70 --> 1817.18] We get tired. |
[1817.44 --> 1817.62] Yeah. |
[1817.90 --> 1818.24] Come on. |
[1818.28 --> 1823.22] Like, if you're reviewing like 15, 20 files, the last one, you're tired. |
[1823.34 --> 1824.98] Like, it's just a human thing, right? |
[1825.76 --> 1827.82] And then it's something that I've done a few times. |
[1828.10 --> 1829.74] I don't like it, but it happens. |
[1829.88 --> 1832.56] Like, the longest PRs, I review and then I submit. |
[1833.04 --> 1835.48] And then when I'm doing the re-review, I find new things. |
[1835.52 --> 1837.86] I'm like, I can't let it pass. |
[1837.86 --> 1844.16] I'm going to have to put a comment where there wasn't a comment and it was not changed because now I saw it, right? |
[1844.98 --> 1845.74] That's the thing. |
[1846.20 --> 1850.94] So, given that, what is a reasonable time to expect a PR review? |
[1851.36 --> 1857.40] If you, like, put in a PR today, is it the next hour, like, by end of day, the next day, a week? |
[1857.92 --> 1858.78] Does it depend? |
[1859.44 --> 1861.04] The real answer is it depends. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.