text stringlengths 0 2.29k |
|---|
[3224.86 --> 3225.86] I can't get embarrassed. |
[3225.86 --> 3226.86] I can't. |
[3226.86 --> 3229.00] I can't. |
[3230.06 --> 3233.04] Because I'm going to learn something new out of this. |
[3233.40 --> 3233.78] There you go. |
[3233.84 --> 3238.80] So tell me the commit where this was introduced so that I can understand my mistake. |
[3239.28 --> 3239.76] Seriously. |
[3239.76 --> 3252.06] So the code that fixes it is in commit F19C9CF, where I basically change the application file to basically turn the logger back on. |
[3252.06 --> 3254.24] So I think you were overly aggressive. |
[3254.62 --> 3256.66] You were removing a few things. |
[3256.80 --> 3259.72] We removed Promax because we're not really using Grafana anymore. |
[3259.72 --> 3263.48] And you just deleted too much code. |
[3264.16 --> 3270.14] And the code that you deleted would, if we're not in IEX, turn on the default logger. |
[3270.22 --> 3272.20] But you deleted it, so there was no default logger. |
[3272.32 --> 3274.94] And so it wouldn't log anything in prod at all. |
[3275.18 --> 3275.74] I see. |
[3275.88 --> 3276.78] And you didn't notice. |
[3276.96 --> 3277.60] Yeah, that's right. |
[3277.64 --> 3280.56] And I didn't notice until I thought, well, I'll just go and see what's going on in production. |
[3280.78 --> 3282.30] And there was no logs there. |
[3282.60 --> 3286.22] So I actually just put that code back in that you had deleted is all. |
[3286.36 --> 3286.72] Right. |
[3287.24 --> 3288.00] So hang on. |
[3288.02 --> 3289.22] Let me try and understand this code. |
[3289.22 --> 3290.46] That's what's happening right now. |
[3290.52 --> 3293.34] I'm trying to understand similar code live as we are recording this. |
[3293.90 --> 3299.60] I'm looking at the application EX line 32, unless code ensure loaded and IEX started, do. |
[3300.12 --> 3303.40] Which of those two lines disables logging? |
[3304.52 --> 3306.46] The 33 or the 35 one? |
[3306.96 --> 3308.82] O-band telemetry attached default logger? |
[3308.88 --> 3310.08] No, that's not the line. |
[3310.18 --> 3312.48] Look at endpoint.ex line 60. |
[3312.66 --> 3314.24] Plug, plug.telemetry. |
[3314.38 --> 3315.08] That's the line. |
[3315.26 --> 3315.76] Okay, okay. |
[3315.78 --> 3317.38] Where you basically remove the telemetry. |
[3317.76 --> 3318.16] Plug. |
[3318.16 --> 3318.66] I see. |
[3318.66 --> 3320.48] So the telemetry plug logs. |
[3320.90 --> 3321.18] Yes. |
[3321.66 --> 3322.20] I see. |
[3322.32 --> 3322.54] Okay. |
[3322.72 --> 3324.42] The logger uses the telemetry plug. |
[3324.56 --> 3325.48] Right, right, right. |
[3325.58 --> 3326.30] To do its thing. |
[3326.44 --> 3328.54] It would have been plug log. |
[3329.54 --> 3331.34] I don't think I would have made that mistake. |
[3331.38 --> 3331.68] Right. |
[3331.80 --> 3332.04] Yeah. |
[3332.36 --> 3332.60] Yeah. |
[3332.78 --> 3332.96] Cool. |
[3333.04 --> 3333.24] Okay. |
[3333.44 --> 3333.98] That's good to know. |
[3333.98 --> 3335.38] So yeah, it was an easy mistake to make. |
[3335.38 --> 3337.12] And I know how it is when you're removing stuff. |
[3337.12 --> 3338.98] You're like, oh, this we don't need, this we don't need. |
[3339.04 --> 3340.36] And I think it was just that one line. |
[3340.48 --> 3340.80] That's it. |
[3340.88 --> 3342.26] Just turn that off. |
[3342.42 --> 3344.44] And we didn't notice because we weren't really looking at production. |
[3344.58 --> 3351.92] Now, had we been sending it over to Honeycomb and observing it, we probably would have seen the drop off immediately because telemetry would have been turned off there. |
[3351.92 --> 3352.52] Yeah, that's right. |
[3352.54 --> 3357.84] So I think the Honeycomb integration will use this open telemetry plug as well when we do it. |
[3358.02 --> 3359.54] So that was the line that did it. |
[3359.58 --> 3360.22] It wasn't the other one. |
[3360.26 --> 3362.06] There was a few other things that you also removed. |
[3362.16 --> 3364.26] I put them back in, but that was like Obon stuff. |
[3364.90 --> 3365.74] Not a big deal. |
[3366.52 --> 3371.56] It was just, you know, overaggressive deletion, which is totally normal when we're like, let's. |
[3371.58 --> 3372.46] I deleted too much. |
[3372.60 --> 3372.82] Yeah. |
[3373.02 --> 3374.68] When you're in like, let's delete stuff mode. |
[3374.92 --> 3376.54] I know how it is because it feels so good. |
[3376.64 --> 3376.80] Okay. |
[3376.84 --> 3377.08] Okay. |
[3377.42 --> 3377.70] Okay. |
[3377.78 --> 3377.98] Okay. |
[3378.02 --> 3378.52] So there you go. |
[3378.62 --> 3378.80] Cool. |
[3379.02 --> 3379.70] That's good to know. |
[3379.92 --> 3381.30] So who reviewed my PR? |
[3381.92 --> 3382.84] Uh-oh. |
[3383.42 --> 3384.62] Do you see where this is going? |
[3391.44 --> 3391.76] Cool. |
[3391.98 --> 3392.20] Great. |
[3392.28 --> 3393.60] Well, it wasn't me, clearly. |
[3393.96 --> 3394.40] I know. |
[3395.10 --> 3397.10] I merged it, but I didn't review it. |
[3397.10 --> 3398.80] I think I waited for a while and said, you know what? |
[3398.80 --> 3401.40] I'm just going to push this through because that's how we roll. |
[3401.96 --> 3402.64] There you go. |
[3402.78 --> 3403.28] No, that's fine. |
[3403.32 --> 3403.64] That's fine. |
[3403.72 --> 3406.26] No, even if I reviewed it, I must have not reviewed it very well. |
[3406.52 --> 3407.62] So, you know. |
[3408.04 --> 3408.50] That's okay. |
[3409.64 --> 3409.96] Yeah. |
[3410.02 --> 3411.06] It was an honest mistake. |
[3411.06 --> 3411.64] Well, yeah. |
[3411.92 --> 3412.44] Totally. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.