author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 25.03.2018 20:06:55 | 14,400 | 2a6d0bfcc00cc83d5ea16cb18345a18aa62a490f | Prevent duplicate navigate actions on native | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -17,7 +17,6 @@ import {\n} from 'react-native';\nimport Icon from 'react-native-vector-icons/FontAwesome';\nimport IonIcon from 'react-native-vector-icons/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Prevent duplicate navigate actions on native |
129,187 | 25.03.2018 20:49:03 | 14,400 | 3bc8ead98621de313b4922485b3a931045c17254 | Call onDismiss in Tooltip when it gets closed programmatically | [
{
"change_type": "MODIFY",
"old_path": "native/components/tooltip.react.js",
"new_path": "native/components/tooltip.react.js",
"diff": "@@ -134,6 +134,9 @@ class Tooltip extends React.PureComponent<Props, State> {\n}\ntoggleModal = () => {\n+ if (this.state.isModalOpen) {\n+ this.onDismiss();\n+ }\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Call onDismiss in Tooltip when it gets closed programmatically |
129,187 | 26.03.2018 11:24:07 | 14,400 | c25f9d6638e368fb5e2ceeba8c1247b1a4ea7d36 | Backoff notif permission alerts | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -21,6 +21,11 @@ import type {\nimport type { RawThreadInfo } from 'lib/types/thread-types';\nimport { rawThreadInfoPropType } from 'lib/types/thread-types';\nimport type { DeviceType } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Backoff notif permission alerts |
129,187 | 26.03.2018 11:37:46 | 14,400 | 143bd07202fdbf90c43a3ad860e5fc4c31d7c1ee | codeVersion -> 4, stateVersion -> 1
Also added a state migrator for `notifPermissionAlertInfo` | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 3\n- versionName \"0.0.3\"\n+ versionCode 4\n+ version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 4, stateVersion -> 1
Also added a state migrator for `notifPermissionAlertInfo` |
129,187 | 26.03.2018 13:34:08 | 14,400 | 752b913b6c70a4b044e2aaaf3971c80dfbe28725 | Don't crash when no message indices for a given thread are specified
Pertaining to `deeaa859ff87cbc7ebba0383ec55542af8611458` | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -339,7 +339,9 @@ async function sendPushNotifsForNewMessages(\n};\nfor (let threadID of preUserPushInfo.threadIDs) {\nconst messageIndices = threadsToMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't crash when no message indices for a given thread are specified
Pertaining to `deeaa859ff87cbc7ebba0383ec55542af8611458` |
129,187 | 26.03.2018 14:44:19 | 14,400 | 1f338c72ed7d75822ddd6b7a07cd9224822d965e | Filter out threadInfos without notifiable messages at an earlier point | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -236,6 +236,9 @@ async function sendPushNotifsForNewMessages(\nconst threadConditionClauses = [];\nfor (let pair of threadRestrictions) {\nconst [ thread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Filter out threadInfos without notifiable messages at an earlier point |
129,187 | 26.03.2018 15:30:38 | 14,400 | 174ab01a6d412c13e7141c7b1536e57c1b70cbd0 | Avoid querying for valid notifs if there's no notifs to send | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -245,6 +245,9 @@ async function sendPushNotifsForNewMessages(\n);\nthreadConditionClauses.push(mergeAndConditions(conditions));\n}\n+ if (threadCondition... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Avoid querying for valid notifs if there's no notifs to send |
129,187 | 27.03.2018 10:26:41 | 14,400 | ced9d65e4cfc8cf43c2de4cd9bf9ab6282bb03f1 | Don't clear reset password verification codes upon success
(Will later add a cronjob to clean up the expired ones) | [
{
"change_type": "MODIFY",
"old_path": "server/src/models/verification.js",
"new_path": "server/src/models/verification.js",
"diff": "@@ -92,10 +92,7 @@ async function handleCodeVerificationRequest(\nconst { userID, field } = result;\nif (field === verifyField.EMAIL) {\nconst query = SQL`UPDATE user... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't clear reset password verification codes upon success
(Will later add a cronjob to clean up the expired ones) |
129,187 | 27.03.2018 10:27:14 | 14,400 | 2c0c382660fa205b84b5ee8a9411aea6c2cb5abc | If a keyboard event occurs right before the app is foregrounded, trigger it
We'll accept a 500ms delay | [
{
"change_type": "MODIFY",
"old_path": "native/keyboard.js",
"new_path": "native/keyboard.js",
"diff": "@@ -12,10 +12,32 @@ export type KeyboardEvent = {\n},\n};\ntype KeyboardCallback = (event: KeyboardEvent) => void;\n+type IgnoredKeyboardEvent = {|\n+ callback: KeyboardCallback,\n+ event: Keyboar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | If a keyboard event occurs right before the app is foregrounded, trigger it
We'll accept a 500ms delay |
129,187 | 27.03.2018 10:54:50 | 14,400 | 942c342d9e580e74d8a4ca8f8aa2c409ad2768e7 | Handle iOS simulator disabled keyboard in LoggedOutModal and VerificationModal | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -136,6 +136,7 @@ class InnerLoggedOutModal extends React.PureComponent<Props, State> {\nkeyboardShowListener: ?Object;\nkeyboardHideListener: ?Object... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Handle iOS simulator disabled keyboard in LoggedOutModal and VerificationModal |
129,187 | 27.03.2018 11:20:48 | 14,400 | 994ecef1c8f507e6d2894769df5d8924bcf3f36c | Simplify KeyboardAvoidingView and factor out some logic | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -62,7 +62,6 @@ import ListLoadingIndicator from '../list-loading-indicator.react';\nimport SectionFooter from './section-footer.react';\nimport ThreadPicker from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Simplify KeyboardAvoidingView and factor out some logic |
129,187 | 27.03.2018 14:04:33 | 14,400 | 1b711d40c4e0713bf840f8ccf849d1e32123d1bb | Scroll panels in logged out view for tiny phones
Also, don't count keyboard events that don't represent any actual changes | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -14,7 +14,7 @@ import type { AppState } from '../redux-setup';\nimport type { Action } from '../navigation-setup';\nimport type { PingStartingPayload... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Scroll panels in logged out view for tiny phones
Also, don't count keyboard events that don't represent any actual changes |
129,187 | 27.03.2018 14:36:15 | 14,400 | f4b79f5d0a3c251005fa8bd9fb8a00163d6890c2 | setActiveAlert(false) on email errors in RegisterPanel | [
{
"change_type": "MODIFY",
"old_path": "native/account/register-panel.react.js",
"new_path": "native/account/register-panel.react.js",
"diff": "@@ -291,6 +291,7 @@ class RegisterPanel extends React.PureComponent<Props, State> {\n}\nonEmailAlertAcknowledged = () => {\n+ this.props.setActiveAlert(fals... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | setActiveAlert(false) on email errors in RegisterPanel |
129,187 | 27.03.2018 17:58:11 | 14,400 | 39966345cc1a2f487d0cb2e97b5d688aa343496c | Lift log in and register state into LoggedOutModal
This way the fields save state if you switch between log-in and register | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "// @flow\nimport type { InnerLogInPanel } from './log-in-panel.react';\n+import {\n+ type StateContainer,\n+ stateContainerPropType,\n+} fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Lift log in and register state into LoggedOutModal
This way the fields save state if you switch between log-in and register |
129,187 | 27.03.2018 18:54:33 | 14,400 | c48da60a98feaa71648e861286cc24b514854418 | Don't crash when encountering a message referencing a thread client doesn't recognize | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -192,6 +192,13 @@ function createMessageInfo(\n} else if (rawMessageInfo.type === messageType.CREATE_THREAD) {\nconst initialParentThreadID =\nrawMessageInfo.initialThreadStat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't crash when encountering a message referencing a thread client doesn't recognize |
129,187 | 27.03.2018 21:00:31 | 14,400 | aef6afa6d47f125efbcd1f24b8adfccfcdb6443f | Don't use Modal's onDismiss prop on Android
It only works on iOS apparently. I tried to fix this in but that just introduced a regression on iOS.
Also apparently Flow can handle `setCookieActionType` in the same conditional branch as the rest for `reduceUserInfos`. | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -87,7 +87,8 @@ function reduceUserInfos(\naction.type === fetchEntriesActionTypes.success ||\naction.type === searchUsersActionTypes.success ||\naction.type === logOutAction... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't use Modal's onDismiss prop on Android
It only works on iOS apparently. I tried to fix this in 3bc8ead98621de313b4922485b3a931045c17254, but that just introduced a regression on iOS.
Also apparently Flow can handle `setCookieActionType` in the same conditional branch as the rest for `reduceUserInfos`. |
129,187 | 28.03.2018 11:45:59 | 14,400 | aca40b0709a197d5fc87dbaf0b5164bb9be69d0d | codeVersion -> 5 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 4\n- versionName \"0.0.4\"\n+ versionCode 5\n+ version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 5 |
129,187 | 28.03.2018 15:53:45 | 14,400 | 3083efb45e4e4c96a88fbe8c7f4c2dfcbb691f52 | Use multiple threads on server | [
{
"change_type": "MODIFY",
"old_path": "server/src/server.js",
"new_path": "server/src/server.js",
"diff": "@@ -5,6 +5,8 @@ import type { Endpoint } from 'lib/types/endpoints';\nimport express from 'express';\nimport cookieParser from 'cookie-parser';\n+import cluster from 'cluster';\n+import os fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use multiple threads on server |
129,187 | 29.03.2018 10:23:48 | 14,400 | 1a94d52708d06ca2bb8cb51ce5d0c05fefd7349b | Restart a cluster worker on crash | [
{
"change_type": "MODIFY",
"old_path": "server/src/server.js",
"new_path": "server/src/server.js",
"diff": "@@ -101,6 +101,7 @@ if (cluster.isMaster) {\nfor (let i = 0; i < cpuCount; i++) {\ncluster.fork();\n}\n+ cluster.on('exit', worker => cluster.fork());\n} else {\nconst server = express();\nser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Restart a cluster worker on crash |
129,187 | 29.03.2018 11:09:02 | 14,400 | 6dd81dea9453cbd5e734022df59b7822a81cc031 | [native] Badge the Chat icon on the tab bar | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/chat-icon.react.js",
"diff": "+// @flow\n+\n+import type { AppState } from '../redux-setup';\n+\n+import React from 'react';\n+import { View, Text, StyleSheet } from 'react-native';\n+import Icon from 'react-native-vector-icons/FontA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Badge the Chat icon on the tab bar |
129,187 | 29.03.2018 11:59:31 | 14,400 | a6d718672772d839996eadf04ee596448547fc0e | [native] Disable scrollsToTop on iOS for Calendar and MessageList | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -679,6 +679,7 @@ class InnerCalendar extends React.PureComponent<Props, State> {\nkeyboardDismissMode={keyboardDismissMode}\nonMomentumScrollEnd={this.onMomentumSc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Disable scrollsToTop on iOS for Calendar and MessageList |
129,187 | 29.03.2018 15:12:39 | 14,400 | 64a566d8ee854556cff80def4e4d2f41704881dc | Don't show exit buttons on crash report until report is sent
Or until the user has waited 10s | [
{
"change_type": "MODIFY",
"old_path": "native/crash.react.js",
"new_path": "native/crash.react.js",
"diff": "@@ -29,6 +29,7 @@ import {\nsendErrorReportActionTypes,\nsendErrorReport,\n} from 'lib/actions/report-actions';\n+import sleep from 'lib/utils/sleep';\nimport Button from './components/butto... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't show exit buttons on crash report until report is sent
Or until the user has waited 10s |
129,187 | 29.03.2018 21:36:58 | 14,400 | 9752fa1cad1f2b68994c254e366bc2d4c3e418c7 | Some additional configuration from Android FCM that may or may not help | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -150,6 +150,7 @@ dependencies {\ncompile project(':react-native-exit-app')\ncompile project(':react-native-fcm')\ncompile 'com.google.firebase:firebase-core:10.0.1'\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Some additional configuration from Android FCM that may or may not help |
129,187 | 29.03.2018 21:37:22 | 14,400 | 05595ee9cac7c6081e7ee10564869577a62bbdc9 | An attempt to fix the endCoordinates crash on Android | [
{
"change_type": "MODIFY",
"old_path": "native/account/panel-components.react.js",
"new_path": "native/account/panel-components.react.js",
"diff": "@@ -117,11 +117,17 @@ class Panel extends React.PureComponent<PanelProps, PanelState> {\n}\n}\n- keyboardHandler = (event: KeyboardEvent) => {\n- const ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | An attempt to fix the endCoordinates crash on Android |
129,187 | 29.03.2018 21:58:22 | 14,400 | 92b88be90365035a51d2312e1989210f39911e37 | Try custom_notification..... | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -370,16 +370,26 @@ function prepareAndroidNotification(\nunreadCount: number,\ndbID: string,\n): Object {\n- const data = {};\n- if (!badgeOnly) {\n- const notifText = notifTextForMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Try custom_notification..... |
129,187 | 29.03.2018 22:06:30 | 14,400 | ae480dd7a8a79d68fa0196e510e0b304a5d2dfe9 | [server] custom_notification has to be within data | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -371,15 +371,15 @@ function prepareAndroidNotification(\ndbID: string,\n): Object {\nconst notifID = collapseKey ? collapseKey : dbID;\n- const data = {\n+ if (badgeOnly) {\n+ return ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] custom_notification has to be within data |
129,187 | 30.03.2018 12:43:02 | 14,400 | 9e6c8ac277816f25a2100c0d60aa95bf3e824b57 | Fix Android notifs when app is closed | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -247,14 +247,20 @@ class InnerLoggedOutModal extends React.PureComponent<Props, State> {\n}\ncomponentDidMount() {\n+ this.mounted = true;\nif (this.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix Android notifs when app is closed |
129,187 | 30.03.2018 12:50:48 | 14,400 | 9a055e5048ee25bf7a06cc77eb8738af195722cf | [server] Don't return unknown error if a user is missing a hash | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -196,7 +196,7 @@ async function logInResponder(\nthrow new ServerError('invalid_parameters');\n}\nconst userRow = userResult[0];\n- if (!bcrypt.compa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't return unknown error if a user is missing a hash |
129,187 | 30.03.2018 15:48:15 | 14,400 | df31677cf41693cbcbe0854ffc939ec5668ad4f1 | [native] Refine navigation on notif press and new thread | [
{
"change_type": "MODIFY",
"old_path": "native/navigation-setup.js",
"new_path": "native/navigation-setup.js",
"diff": "@@ -80,6 +80,7 @@ import {\ngetThreadIDFromParams,\n} from './utils/navigation-utils';\nimport { DeleteThreadRouteName } from './chat/settings/delete-thread.react';\n+import { Comp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Refine navigation on notif press and new thread |
129,187 | 30.03.2018 22:14:05 | 14,400 | 147a82ab58345eb10373b4e4f3c36e96d1e7e64a | [server] Put everything in custom_notification payload on Android | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -386,10 +386,9 @@ function prepareAndroidNotification(\npriority: \"high\",\nsound: \"default\",\nicon: \"notif_icon\",\n+ badgeCount: unreadCount,\n+ threadID: threadInfo.id,\n}),\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Put everything in custom_notification payload on Android |
129,187 | 30.03.2018 22:42:55 | 14,400 | cea239d045f14211070cc3a8bdfe0089058c75b5 | [native] Finally get Android notifs fully working | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -449,7 +449,7 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nthis.initialAndroidNotifHandled = true;\nconst initialNotif = await FCM.getInitialNotification();\nif (init... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Finally get Android notifs fully working |
129,187 | 30.03.2018 23:33:23 | 14,400 | 3d4c1c3a844521c98c903fac3ac27d7a56262cd7 | [server] Include new RawMessageInfos in notification payloads | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -95,9 +95,6 @@ async function sendPushNotifs(pushInfo: PushInfo) {\nconst existingMessageInfos = notifInfo.existingMessageInfos.map(\nhydrateMessageInfo,\n).filter(Boolean);\n- const ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include new RawMessageInfos in notification payloads |
129,187 | 30.03.2018 23:43:31 | 14,400 | b53909533e284cd5d9ac790aca6f6369e0c436c5 | [server] Always JSON.stringify notification messageInfos | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -396,7 +396,7 @@ function prepareAndroidNotification(\nicon: \"notif_icon\",\nbadgeCount: unreadCount,\nthreadID: threadInfo.id,\n- messageInfos: newMessageInfos,\n+ messageInfos: JSO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Always JSON.stringify notification messageInfos |
129,187 | 30.03.2018 23:59:18 | 14,400 | 846d222aa4f8dc772e1fa0af63fcb7a8adca62dc | [server] Include RawMessageInfo (not MessageInfo) in notification payloads | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -86,15 +86,24 @@ async function sendPushNotifs(pushInfo: PushInfo) {\nuserInfos,\nthreadInfos,\n);\n- const newMessageInfos = notifInfo.newMessageInfos.map(\n- hydrateMessageInfo,\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Include RawMessageInfo (not MessageInfo) in notification payloads |
129,187 | 31.03.2018 00:07:53 | 14,400 | cccf17ae2d74b6ecdea595f97d2f6ed54ce1aaa4 | [server] Pass iOS messageInfos in notification payload | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -365,7 +365,7 @@ function prepareIOSNotification(\nnotification.id = uniqueID;\nnotification.payload.id = uniqueID;\nnotification.payload.threadID = threadInfo.id;\n- notification.mes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Pass iOS messageInfos in notification payload |
129,187 | 31.03.2018 15:03:03 | 14,400 | 9ad1ad243795eb7691619a2bda055902cc77f83b | [native] Clear path to get to a thread once user intent established
When the user searches for a thread and finds it, or when they try to create a new thread but realize it already exists, try to clear out the path they took to get there from the nav state. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -130,7 +130,7 @@ class InnerChatThreadList extends React.PureComponent<Props, State> {\nif (this.state.searchText) {\nclearSearchInputIcon = (\n<TouchableO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clear path to get to a thread once user intent established
When the user searches for a thread and finds it, or when they try to create a new thread but realize it already exists, try to clear out the path they took to get there from the nav state. |
129,187 | 31.03.2018 17:34:01 | 14,400 | 3c1acab5cd06f83d0218aaf652f0f96afbac5150 | [native] Add search bar to ThreadPicker | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/thread-picker.react.js",
"new_path": "native/calendar/thread-picker.react.js",
"diff": "@@ -19,8 +19,11 @@ import {\ncreateLocalEntryActionType,\n} from 'lib/actions/entry-actions';\nimport { includeDispatchActionProps } from 'lib/utils/action-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add search bar to ThreadPicker |
129,187 | 31.03.2018 17:38:41 | 14,400 | f3d50777bd78ddc3020c5471f83692599d36319d | codeVersion -> 6, stateVersion -> 2
Also added a state migrator for `messageSentFromRoute` | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 5\n- versionName \"0.0.5\"\n+ versionCode 6\n+ version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | codeVersion -> 6, stateVersion -> 2
Also added a state migrator for `messageSentFromRoute` |
129,187 | 31.03.2018 20:18:51 | 14,400 | 226e75c9d5584d3dd99263b7d448dd722bab3202 | [native] Delay creation of local entry so keyboard can respond to modal closing
PS this is actually in version 6 | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/thread-picker.react.js",
"new_path": "native/calendar/thread-picker.react.js",
"diff": "@@ -7,7 +7,7 @@ import type { DispatchActionPayload } from 'lib/utils/action-utils';\nimport React from 'react';\nimport PropTypes from 'prop-types';\n-impo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delay creation of local entry so keyboard can respond to modal closing
PS this is actually in version 6 |
129,187 | 01.04.2018 12:53:21 | 14,400 | 396388ca7a361223e5108dd6b6e1e9c3603908e7 | [server] Avoid passing React render result to HTML tag
It's stripping newlines from the textarea contents. | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -163,7 +163,7 @@ async function websiteResponder(viewer: Viewer, url: string): Promise<string> {\ntype=\"text/css\"\nhref=\"compiled/prod.build... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Avoid passing React render result to HTML tag
It's stripping newlines from the textarea contents. |
129,187 | 01.04.2018 20:07:17 | 14,400 | 58da8e37505a2c50b4190f3793ffc8fd7e1cd303 | [native] Blur thread list search input on thread select | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -78,6 +78,7 @@ class InnerChatThreadList extends React.PureComponent<Props, State> {\n: null,\nheaderBackTitle: \"Back\",\n});\n+ searchInput: ?TextInput;\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Blur thread list search input on thread select |
129,187 | 01.04.2018 22:49:45 | 14,400 | 9469d0d9ce655ed101787fb79b8dde0fd1f799dd | [server] Add cronjobs to clear expired cookies and verifications | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/express_v4.16.x.js",
"new_path": "server/flow-typed/npm/express_v4.16.x.js",
"diff": "-// flow-typed signature: 41a220e96fcef89a09244ac3797039e8\n-// flow-typed version: 9f7cf2ab0c/express_v4.16.x/flow_>=v0.32.x\n+// flow-typed signature:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add cronjobs to clear expired cookies and verifications |
129,187 | 02.04.2018 00:04:58 | 14,400 | c73281bd8892d3f2ac9b913bbe79247cedd69dff | [server] Try refining email style | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/reset-password.js",
"new_path": "server/src/emails/reset-password.js",
"diff": "@@ -8,8 +8,9 @@ import { verifyField } from 'lib/types/verify-types';\nimport urlFacts from '../../facts/url';\nimport { createVerificationCode } from '../models/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Try refining email style |
129,187 | 02.04.2018 00:11:39 | 14,400 | 8e9127e886188f0008114c89bd44534fccb3a10c | [server] Minor change to React imports to work with Node.js | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/reset-password.js",
"new_path": "server/src/emails/reset-password.js",
"diff": "// @flow\n-import React from 'react'\n+import React from 'react';\nimport ReactHTML from 'react-html-email';\nimport { verifyField } from 'lib/types/verify-types'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Minor change to React imports to work with Node.js |
129,187 | 02.04.2018 00:16:25 | 14,400 | f883a929ffbba4dbc28eaa2805e15ab317d9cffb | [server] Continue iterating on email style | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/reset-password.js",
"new_path": "server/src/emails/reset-password.js",
"diff": "@@ -10,7 +10,7 @@ import { createVerificationCode } from '../models/verification';\nimport sendmail from './sendmail';\nimport Template from './template.react';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Continue iterating on email style |
129,187 | 02.04.2018 00:24:15 | 14,400 | e4123fafd36c6484759bc34692ad50f71d8877f5 | [server] Left-align all emails | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/reset-password.js",
"new_path": "server/src/emails/reset-password.js",
"diff": "@@ -30,7 +30,7 @@ async function sendPasswordResetEmail(\n\"your password: \";\nconst email = (\n<Template title={title}>\n- <Item>\n+ <Item align=\"left\">\n<Spa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Left-align all emails |
129,187 | 02.04.2018 00:33:44 | 14,400 | da37237cbcc6c5e59a04aec1824f29a00145794d | [server] Once again try left-aligning all emails | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/template.react.js",
"new_path": "server/src/emails/template.react.js",
"diff": "@@ -17,8 +17,8 @@ type Props = {|\n|};\nfunction Template(props: Props) {\nreturn (\n- <Email title={props.title} headCSS={css}>\n- <Box>\n+ <Email title={props.t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Once again try left-aligning all emails |
129,187 | 02.04.2018 00:40:30 | 14,400 | 41a5d8c1c6097e139b8a08b08709094d73287601 | [server] Continue trying to left-align all emails | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/template.react.js",
"new_path": "server/src/emails/template.react.js",
"diff": "@@ -17,7 +17,7 @@ type Props = {|\n|};\nfunction Template(props: Props) {\nreturn (\n- <Email title={props.title} headCSS={css} align=\"left\">\n+ <Email title={p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Continue trying to left-align all emails |
129,187 | 02.04.2018 00:44:47 | 14,400 | b9ea8315e2f74a02acebf6ebf4be3cd1fe597701 | [server] Try to add some padding to emails | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/template.react.js",
"new_path": "server/src/emails/template.react.js",
"diff": "@@ -18,7 +18,7 @@ type Props = {|\nfunction Template(props: Props) {\nreturn (\n<Email title={props.title} headCSS={css} align=\"left\" width=\"100%\">\n- <Box al... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Try to add some padding to emails |
129,187 | 02.04.2018 00:48:39 | 14,400 | 956a6bfc5d253aa6d22d95085cf8e2d562aa926c | [server] Try a more moderate padding on emails | [
{
"change_type": "MODIFY",
"old_path": "server/src/emails/template.react.js",
"new_path": "server/src/emails/template.react.js",
"diff": "@@ -18,7 +18,7 @@ type Props = {|\nfunction Template(props: Props) {\nreturn (\n<Email title={props.title} headCSS={css} align=\"left\" width=\"100%\">\n- <Box al... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Try a more moderate padding on emails |
129,187 | 02.04.2018 13:48:17 | 14,400 | 0e05a6eae330e835095e76d7a7e4a5dc343bfd6f | [native] Don't show CalendarInputBar while ThreadPicker is open | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar-input-bar.react.js",
"new_path": "native/calendar/calendar-input-bar.react.js",
"diff": "import React from 'react';\nimport { View, StyleSheet, Text } from 'react-native';\n+import PropTypes from 'prop-types';\nimport Button from '../c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't show CalendarInputBar while ThreadPicker is open |
129,187 | 02.04.2018 14:17:15 | 14,400 | c084be227436b98f9ed1af87b57f2991e4822100 | [server] Add deleteInaccessibleThreads to cron
Deletes threads with no membership rows, which indicates that nobody can ever actually see them again. Actually, legacy thread types can always be seen, but they are soon to be deprecated, so that's not particularly relevant. Plus all of them have at least one membership r... | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -5,13 +5,16 @@ import cluster from 'cluster';\nimport { deleteExpiredCookies } from './deleters/cookie-deleters';\nimport { deleteExpiredVerifications } from './models/verification';\n+import {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add deleteInaccessibleThreads to cron
Deletes threads with no membership rows, which indicates that nobody can ever actually see them again. Actually, legacy thread types can always be seen, but they are soon to be deprecated, so that's not particularly relevant. Plus all of them have at least one membership ... |
129,187 | 02.04.2018 14:55:58 | 14,400 | 6a35f83edf536bcd53cc9ae8624ef99f2fe5e64a | [server] Delete a bunch of orphaned rows from DB in cronjob | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -6,15 +6,32 @@ import cluster from 'cluster';\nimport { deleteExpiredCookies } from './deleters/cookie-deleters';\nimport { deleteExpiredVerifications } from './models/verification';\nimport { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete a bunch of orphaned rows from DB in cronjob |
129,187 | 02.04.2018 15:52:26 | 14,400 | 496b5a6d78b135bdbfa2aa6f77d3b957dbbefa6d | [server] Rescind all notifs when thread is deleted | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/thread-deleters.js",
"new_path": "server/src/deleters/thread-deleters.js",
"diff": "@@ -16,6 +16,7 @@ import {\ncheckThreadPermission,\nfetchThreadInfos,\n} from '../fetchers/thread-fetchers';\n+import { rescindPushNotifs } from '../push/re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rescind all notifs when thread is deleted |
129,187 | 03.04.2018 11:19:01 | 14,400 | ed81ebbd931e4136a1880363d0cb021c2044cb4c | [lib] Reduce unnecessary renders by avoiding changes in reducers | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -94,13 +94,13 @@ function mergeNewEntryInfos(\nconst serverID = rawEntryInfo.id;\ninvariant(serverID, \"new entryInfos should have serverID\");\nconst currentEntryInfo = c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Reduce unnecessary renders by avoiding changes in reducers |
129,187 | 03.04.2018 13:32:57 | 14,400 | 1819a6673d854f8bfe089f218274f81df921c5b4 | [lib] Undo change that got rid of nav reducer! | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/master-reducer.js",
"new_path": "lib/reducers/master-reducer.js",
"diff": "@@ -26,10 +26,9 @@ export default function baseReducer<N: BaseNavInfo, T: BaseAppState<N>>(\n// NavInfo has to be handled differently because of the covariance\n// (see com... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Undo change that got rid of nav reducer! |
129,187 | 03.04.2018 13:49:41 | 14,400 | c57d8c8f54fe2c9c0aa24dcdb7e17ccc4e945b32 | [server] Add temporary logging statements in updateUnreadStatus | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -200,6 +200,8 @@ async function updateUnreadStatus(\nthreadConditionClauses.push(mergeAndConditions(conditions));\n}\nconst conditionClause = mergeOrCond... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add temporary logging statements in updateUnreadStatus |
129,187 | 03.04.2018 13:59:36 | 14,400 | 8d260be127e81e9b690c730ab25ea0515ea92a30 | [server] Add temporary logging statements in possiblyResetThreadsToUnread | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -200,8 +200,6 @@ async function updateUnreadStatus(\nthreadConditionClauses.push(mergeAndConditions(conditions));\n}\nconst conditionClause = mergeOrCond... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add temporary logging statements in possiblyResetThreadsToUnread |
129,187 | 03.04.2018 14:03:37 | 14,400 | d23234ac09e8b1b6d35810ae0a96ec4882337660 | [server] Don't reset thread to unread if latest message is local
When navigating away from a thread, don't assume the client missed a message when their most recent message is local. | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -147,8 +147,10 @@ async function possiblyResetThreadsToUnread(\nconst threadID = row.thread.toString();\nconst serverLatestMessage = row.latest_messa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't reset thread to unread if latest message is local
When navigating away from a thread, don't assume the client missed a message when their most recent message is local. |
129,187 | 05.04.2018 11:06:01 | 14,400 | a5ac1e3d03ccbf50f2571d5a262fea577d28e3ac | [server] Clean up expired updates in cronjob | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron.js",
"new_path": "server/src/cron.js",
"diff": "@@ -14,6 +14,7 @@ import { deleteOrphanedRoles } from './deleters/role-deleters';\nimport { deleteOrphanedMessages } from './deleters/message-deleters';\nimport { deleteOrphanedFocused } from './d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Clean up expired updates in cronjob |
129,187 | 05.04.2018 11:11:46 | 14,400 | 6536f0de3fd150e1bf0800c503430060ff9f1e0a | [lib] Invalidate all existing userInfos when cookie changes | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -86,9 +86,6 @@ function reduceUserInfos(\naction: BaseAction,\n) {\nif (\n- action.type === logInActionTypes.success ||\n- action.type === registerActionTypes.success ||\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Invalidate all existing userInfos when cookie changes |
129,187 | 05.04.2018 11:33:36 | 14,400 | e864cb90714e53df5511eb692fb334c31b9c53c9 | [server] Create updates for all users when a user deletes their account | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/update-utils.js",
"new_path": "lib/shared/update-utils.js",
"diff": "// @flow\n-import type { UpdateInfo } from '../types/update-types';\n+import {\n+ type UpdateInfo,\n+ type UpdateData,\n+ updateType,\n+} from '../types/update-types';\nimport _max... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create updates for all users when a user deletes their account |
129,187 | 05.04.2018 11:53:24 | 14,400 | a893c901c545bf07b31fc54e50603cce48caf31e | [lib] Add logic to reduceUserInfos to handle updateType.DELETE_ACCOUNT | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "import type { BaseAction } from '../types/redux-types';\nimport type { CurrentUserInfo, UserInfo } from '../types/user-types';\n+import { updateType } from '../types/update-typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add logic to reduceUserInfos to handle updateType.DELETE_ACCOUNT |
129,187 | 05.04.2018 14:07:13 | 14,400 | 523779a2d5e14b25288476caa695261866c0ce9d | [server] Still return `serverTime` from ping responder for older clients | [
{
"change_type": "MODIFY",
"old_path": "lib/types/ping-types.js",
"new_path": "lib/types/ping-types.js",
"diff": "@@ -28,6 +28,7 @@ export type PingResponse = {|\nrawMessageInfos: RawMessageInfo[],\ntruncationStatuses: MessageTruncationStatuses,\nmessagesCurrentAsOf: number,\n+ serverTime: number,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Still return `serverTime` from ping responder for older clients |
129,187 | 05.04.2018 20:22:34 | 14,400 | ab90d225e4bdb8e45206c5f8aeb5d508f438e001 | [seerver] Call rescindPushNotifs after deleting thread
So that the `unread_count` is correct. We also don't need to `await` for it. | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/notif-utils.js",
"new_path": "lib/shared/notif-utils.js",
"diff": "@@ -312,10 +312,10 @@ function strippedRobotextForMessageInfo(\nreturn robotextToRawString(threadMadeExplicit);\n}\n+const joinResult = (...keys: (string | number)[]) => keys.join(\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [seerver] Call rescindPushNotifs after deleting thread
So that the `unread_count` is correct. We also don't need to `await` for it. |
129,187 | 05.04.2018 22:16:38 | 14,400 | 90b55a48879347148a9ce3b768822d94f21f8a0c | [server] Call rescindPushNotifs *before* deleting thread
But make sure the unread count is correct. | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/thread-deleters.js",
"new_path": "server/src/deleters/thread-deleters.js",
"diff": "@@ -45,6 +45,11 @@ async function deleteThread(\nthrow new ServerError('invalid_credentials');\n}\n+ await rescindPushNotifs(\n+ SQL`n.thread = ${threadDele... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Call rescindPushNotifs *before* deleting thread
But make sure the unread count is correct. |
129,187 | 05.04.2018 22:21:04 | 14,400 | c9986c81f9d4fc17e94e6f35f191a73726f4dca7 | [server] Fix typo in last commit! | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/rescind.js",
"new_path": "server/src/push/rescind.js",
"diff": "@@ -18,7 +18,7 @@ async function rescindPushNotifs(\nFROM notifications n\nLEFT JOIN memberships m ON m.user = n.user AND m.unread = 1 AND m.role != 0\nWHERE n.rescinded = 0 AND\n-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix typo in last commit! |
129,187 | 05.04.2018 23:34:02 | 14,400 | bb3bde4c6a5c8ef9f492a530b6cce2f88a629510 | [server] Update Android notification rescind format | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/rescind.js",
"new_path": "server/src/push/rescind.js",
"diff": "@@ -46,8 +46,11 @@ async function rescindPushNotifs(\nif (row.delivery.androidID) {\nconst notification = {\ndata: {\n+ badge: row.unread_count.toString(),\n+ custom_notification: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update Android notification rescind format |
129,187 | 05.04.2018 23:48:04 | 14,400 | 4da0023b96e15b72f0085f5c9e1ccd31d9853d0e | [native] Use my forked version of react-native-fcm
Enables rescinding notifs while app is closed. | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react\": \"^16.2.0\",\n\"react-native\": \"^0.52.0\",\n\"react-native-exit-app\": \"^1.0.0\",\n- \"react-native-fcm\": \"^11.2.0\",\n+ \"react-native-fcm\": \"git+https://git@github.com/ashoat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use my forked version of react-native-fcm
Enables rescinding notifs while app is closed. |
129,187 | 05.04.2018 23:49:55 | 14,400 | 9b364ba9f98672df30d53dbf5ad598209fa6db44 | [native] codeVersion -> 7 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 6\n- versionName \"0.0.6\"\n+ versionCode 7\n+ version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 7 |
129,187 | 06.04.2018 00:20:19 | 14,400 | bd3bcf9ff9b1eccb8f724a943db7598a582167d3 | [server] Explicitly list default exports in react-redux libdef | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/react-redux_v5.x.x.js",
"new_path": "server/flow-typed/npm/react-redux_v5.x.x.js",
"diff": "-// flow-typed signature: a2c406bd25fca4586c361574e555202d\n-// flow-typed version: dcd1531faf/react-redux_v5.x.x/flow_>=v0.62.0\n-\nimport type {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Explicitly list default exports in react-redux libdef |
129,187 | 06.04.2018 10:28:25 | 14,400 | 9008b35982066af416e2611d5aa130010a9bbf5b | [server] Don't treat 0 timestamp the same as null in ping responder | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -37,9 +37,12 @@ async function pingResponder(\nvalidateInput(pingRequestInputValidator, request);\nlet clientMessagesCurrentAsOf;\n- if (request.mess... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't treat 0 timestamp the same as null in ping responder |
129,187 | 06.04.2018 10:35:53 | 14,400 | e5301a26385e839d2c420fb4cf51c9050f16d6c9 | [server] Consider 0 timestamp valid in ping responder | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -45,7 +45,10 @@ async function pingResponder(\n} else if (request.lastPing !== null && request.lastPing !== undefined) {\nclientMessagesCurrentAsOf =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Consider 0 timestamp valid in ping responder |
129,187 | 06.04.2018 16:14:37 | 14,400 | 052db9166e9e7f26ca06584bbcdfa928f7d32465 | Further refinements to Android notifications | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -591,40 +591,33 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nnotification,\nappOpenedFromNotif = false,\n) => {\n- const badgeCount = notification.badgeCount;\n- if (... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Further refinements to Android notifications |
129,187 | 07.04.2018 22:43:50 | 14,400 | d1f945d21aad6745c418dec4fa1c79e98d6ea216 | [server] Catch duplicate row error in activityUpdater | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -63,17 +63,7 @@ async function activityUpdater(\nconst promises = [];\nif (focusedThreadIDs.length > 0) {\n- const time = Date.now();\n- const focuse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Catch duplicate row error in activityUpdater |
129,187 | 07.04.2018 22:49:15 | 14,400 | 145081bb552aac585435b474277c134b991f3f4e | [native] codeVersion -> 8
This one will be an Android-only release. | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 7\n- versionName \"0.0.7\"\n+ versionCode 8\n+ version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 8
This one will be an Android-only release. |
129,187 | 09.04.2018 10:34:08 | 14,400 | 4342002e049e64b08bce2a64d358065bd8f5de39 | [native] Reintroduce rescinding notifs locally on Android
When the user navigates to a thread, we rescind all notifs corresponding to that thread. | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -587,19 +587,35 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nnotification.finish(NotificationsIOS.FetchResult.NewData);\n}\n+ // This function gets called when:\n+ //... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reintroduce rescinding notifs locally on Android
When the user navigates to a thread, we rescind all notifs corresponding to that thread. |
129,187 | 09.04.2018 10:46:57 | 14,400 | c42ec600bfe7f233bdfd2f7fac77c5a7702ed110 | [server] Use weak comparison to check APNs error code | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/utils.js",
"new_path": "server/src/push/utils.js",
"diff": "@@ -28,7 +28,7 @@ async function apnPush(\nconst invalidTokens = [];\nfor (let error of result.failed) {\nerrors.push(error);\n- if (error.status === apnTokenInvalidationErrorCode) {\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use weak comparison to check APNs error code |
129,187 | 09.04.2018 11:56:15 | 14,400 | 0e15303e6ce748547491e75a29fee7fbc781a70f | [server] visibility_rules -> type | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -194,7 +194,7 @@ async function updateUnreadStatus(\ncondition.append(SQL`.permissions, ${knowOfExtractString}) IS TRUE `);\ncondition.append(SQL`OR st`)... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] visibility_rules -> type |
129,187 | 09.04.2018 15:07:17 | 14,400 | 57d8c29d90a754b52934d6cde29ffe222f74f0f5 | [native] Don't update badge count until first ping results comes in
We end up updating the badge count with stale data otherwise. This also avoids an issue on iOS where notifs get preemptively rescinded. (On iOS, setting badge count to 0 clears all notifs.) | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -127,6 +127,7 @@ type Props = {\nunreadCount: number,\nrawThreadInfos: {[id: string]: RawThreadInfo},\nnotifPermissionAlertInfo: NotifPermissionAlertInfo,\n+ lastPingTime: number,\n// Redux d... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't update badge count until first ping results comes in
We end up updating the badge count with stale data otherwise. This also avoids an issue on iOS where notifs get preemptively rescinded. (On iOS, setting badge count to 0 clears all notifs.) |
129,187 | 09.04.2018 22:56:30 | 14,400 | 29e06e3eb771bbb3e1628674ad0b1d7de762fa68 | [server] Don't crash when getting visibilityRules in NewThreadRequest | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/thread-responders.js",
"new_path": "server/src/responders/thread-responders.js",
"diff": "@@ -18,6 +18,8 @@ import type { Viewer } from '../session/viewer';\nimport t from 'tcomb';\n+import { ServerError } from 'lib/utils/errors';\n+\nimp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't crash when getting visibilityRules in NewThreadRequest |
129,187 | 09.04.2018 23:34:02 | 14,400 | c1941d702d751c8f744e5aba978734bad4d9a2b8 | [server] Attempt to bring back visibilityRules for older clients | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -153,6 +153,7 @@ function rawThreadInfoFromServerThreadInfo(\nreturn {\nid: serverThreadInfo.id,\ntype: serverThreadInfo.type,\n+ visibilityRules: serverThreadInfo.type,\nname: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Attempt to bring back visibilityRules for older clients |
129,187 | 10.04.2018 15:24:20 | 14,400 | 9c297a32ba00a735795de47ffdf78811541104f2 | [web] Move Modal into header to avoid having distinct stacking contexts | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -274,12 +274,12 @@ class App extends React.PureComponent<Props, State> {\n</Link>\n</h2>\n</div>\n+ {this.state.currentModal}\n</header>\n<Calendar\nsetModal={this.setModal}\nclearModal={this.clear... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Move Modal into header to avoid having distinct stacking contexts |
129,187 | 12.04.2018 11:04:43 | 14,400 | b4d18ce81f1864a1598b2339db62ee5d7c2bd6de | Move platform awareness to lib | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -22,6 +22,7 @@ import type {\nimport type { UserSearchResult } from '../types/search-types';\nimport threadWatcher from '../shared/thread-watcher';\n+import { getConfig } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move platform awareness to lib |
129,187 | 12.04.2018 22:10:13 | 14,400 | b3e1e5278a224dfd72e88dd345ad95f98c5b682a | [server] ios_device_token, android_device_token -> device_token | [
{
"change_type": "MODIFY",
"old_path": "lib/types/device-types.js",
"new_path": "lib/types/device-types.js",
"diff": "@@ -7,8 +7,3 @@ export type DeviceTokenUpdateRequest = {|\ndeviceType: DeviceType,\ndeviceToken: string,\n|};\n-\n-export type DeviceTokens = {|\n- ios?: ?string,\n- android?: ?strin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] ios_device_token, android_device_token -> device_token |
129,187 | 19.04.2018 16:42:42 | 25,200 | e20fafe4b7bb7cea044efb5e608d13d36b361e20 | [web] Fix splash screen for mobile browsers | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -1191,25 +1191,29 @@ div.splash-container {\ndiv.splash-header-container {\nposition: fixed;\ntop: 0;\n- width: 100%;\n+ left: 0;\n+ right: 0;\nheight: 790px;\nheight: 61px;\nz-index: 3;\nbackground-imag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix splash screen for mobile browsers |
129,187 | 23.04.2018 16:38:13 | 25,200 | b66a2aa127a8a16823758a1a60429a592369c80e | [server] Bring back support for clients sending `closing` ActivityUpdate
This does nothing, but old clients are still sending it and causing crashes. | [
{
"change_type": "MODIFY",
"old_path": "lib/types/activity-types.js",
"new_path": "lib/types/activity-types.js",
"diff": "export type ActivityUpdate =\n| {| focus: true, threadID: string |}\n- | {| focus: false, threadID: string, latestMessage: ?string |};\n+ | {| focus: false, threadID: string, lat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Bring back support for clients sending `closing` ActivityUpdate
This does nothing, but old clients are still sending it and causing crashes. |
129,187 | 23.04.2018 16:58:34 | 25,200 | 86c973c3aa4ea2002dbb60fed5aa182979debd62 | [server] Wipe APNs device token on BadDeviceToken | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/utils.js",
"new_path": "server/src/push/utils.js",
"diff": "@@ -17,6 +17,8 @@ const fcmTokenInvalidationErrors = new Set([\n\"messaging/invalid-registration-token\",\n]);\nconst apnTokenInvalidationErrorCode = 410;\n+const apnBadRequestErrorCod... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Wipe APNs device token on BadDeviceToken |
129,187 | 23.04.2018 19:14:14 | 25,200 | e25339cb808774b6965bd2833d78c09c04dac123 | ServerRequest and ClientResponse for when server is missing device token | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/ping-selectors.js",
"new_path": "lib/selectors/ping-selectors.js",
"diff": "@@ -45,6 +45,7 @@ const pingActionInput = createSelector(\n(state: BaseAppState<*>) => state.messageStore.currentAsOf,\n(state: BaseAppState<*>) => state.updatesCurrentAs... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | ServerRequest and ClientResponse for when server is missing device token |
129,187 | 24.04.2018 01:06:33 | 14,400 | e5a896dd7bbf24a07f03a63d57fdbd7f9440d596 | [server] Forgot to add new DEVICE_TOKEN server request to input validator | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -38,6 +38,13 @@ const pingRequestInputValidator = tShape({\n),\nplatform: tPlatform,\n}),\n+ tShape({\n+ type: t.irreducible(\n+ 'serverRequestTypes.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Forgot to add new DEVICE_TOKEN server request to input validator |
129,187 | 24.04.2018 01:12:13 | 14,400 | 8cb7d137cd9f4d6be6cb3defbfd95cafe1acf016 | [server] Forgot the t.union operator in the last commit | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/responders/ping-responders.js",
"diff": "@@ -30,7 +30,7 @@ const pingRequestInputValidator = tShape({\nmessagesCurrentAsOf: t.maybe(t.Number),\nupdatesCurrentAsOf: t.maybe(t.Number),\nwatchedID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Forgot the t.union operator in the last commit |
129,187 | 25.04.2018 01:33:26 | 14,400 | f5c43d77c2bc2d1ac73e8d610690d640e6ea81ab | [native] codeVersion -> 9 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 8\n- versionName \"0.0.8\"\n+ versionCode 9\n+ version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 9 |
129,187 | 25.04.2018 10:52:27 | 14,400 | 36bdea9cac5121e1a5746e569d1786dc5d4ffe6e | [native] Hyperlink in RobotextMessage | [
{
"change_type": "MODIFY",
"old_path": "native/chat/robotext-message.react.js",
"new_path": "native/chat/robotext-message.react.js",
"diff": "@@ -11,11 +11,12 @@ import React from 'react';\nimport {\nText,\nStyleSheet,\n- View,\n+ TouchableWithoutFeedback,\n} from 'react-native';\nimport invariant f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Hyperlink in RobotextMessage |
129,187 | 25.04.2018 11:19:52 | 14,400 | 5eccadd0367b6381202a9be8a44f9cd35c62d16f | [native] Fix up calendar session reset logic | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -183,6 +183,8 @@ class InnerCalendar extends React.PureComponent<Props, State> {\nflatList: ?FlatList<CalendarItemWithHeight> = null;\ntextHeights: ?Map<string, nu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up calendar session reset logic |
129,187 | 25.04.2018 11:58:58 | 14,400 | 9411b02b0dc98b00b059fc1c14abd2f8ffef128c | [native] Make emoji-only messages have a larger font | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/shared/emojis.js",
"diff": "+// @flow\n+\n+const onlyEmojiRegex = /^(\\uD83C\\uDFF4\\uDB40\\uDC67\\uDB40\\uDC62(?:\\uDB40\\uDC65\\uDB40\\uDC6E\\uDB40\\uDC67|\\uDB40\\uDC77\\uDB40\\uDC6C\\uDB40\\uDC73|\\uDB40\\uDC73\\uDB40\\uDC63\\uDB40\\uDC7... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make emoji-only messages have a larger font |
129,187 | 25.04.2018 14:34:29 | 14,400 | 2b7fc09cd18b853fcc65e095788e374734271a33 | [server] Display old thread name in thread name change notif | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -29,6 +29,7 @@ import {\nrawThreadInfoFromServerThreadInfo,\nthreadInfoFromRawThreadInfo,\n} from 'lib/shared/thread-utils';\n+import { promiseAll } from 'lib/utils/promises';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Display old thread name in thread name change notif |
129,187 | 25.04.2018 14:43:05 | 14,400 | 9cf9009575158c4d0dbedd5905285abdd7ec703c | [server] When collapsing two name change notifs, use the original name | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -243,7 +243,8 @@ async function fetchInfos(pushInfo: PushInfo) {\nconst threadIDs = new Set();\nconst threadWithChangedNamesToMessages = new Map();\nconst addThreadIDsFromMessageInfos... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] When collapsing two name change notifs, use the original name |
129,187 | 26.04.2018 11:21:02 | 14,400 | a6ef225395f9d2fae00c3a43f1f1d6d3e08c788b | [native] Account for potential lag between setTimeout in pingNow and PING_STARTED | [
{
"change_type": "MODIFY",
"old_path": "native/app.react.js",
"new_path": "native/app.react.js",
"diff": "@@ -341,10 +341,13 @@ class AppWithNavigationState extends React.PureComponent<Props> {\nreturn false;\n}\nconst lastPingStart = props.pingTimestamps.lastStarted;\n- const timeUntilNextPing = la... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Account for potential lag between setTimeout in pingNow and PING_STARTED |
129,187 | 26.04.2018 11:57:18 | 14,400 | 7e94dbb8cc408841ee566cc3a2020058cc813ffe | [native] codeVersion -> 10 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 9\n- versionName \"0.0.9\"\n+ versionCode 10\n+ versio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 10 |
129,187 | 26.04.2018 12:13:27 | 14,400 | 9119e7d2a15e70e69d45163f3786ce93922e667e | [native] codeVersion -> 11
Something is going wrong with Apple's upload process and they think I need some sort of permissions. I'm going to try again without any changes, and then probably add the weird permission things and increment `codeVersion` to 12 sadly. | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -109,8 +109,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion 16\ntargetSdkVersion 22\n- versionCode 10\n- versionName \"0.0.10\"\n+ versionCode 11\n+ vers... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 11
Something is going wrong with Apple's upload process and they think I need some sort of permissions. I'm going to try again without any changes, and then probably add the weird permission things and increment `codeVersion` to 12 sadly. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.