author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 13.07.2020 13:27:13 | 14,400 | 91bac959029a5f341b8a958b9ae0f069fb05b6b3 | [native] Always default to light-content StatusBar
We only use the default on the initial load, and since we're showing the splash screen there, `light-content` makes the most sense. | [
{
"change_type": "MODIFY",
"old_path": "native/connected-status-bar.react.js",
"new_path": "native/connected-status-bar.react.js",
"diff": "@@ -35,13 +35,15 @@ class ConnectedStatusBar extends React.PureComponent<Props> {\n} = this.props;\nlet barStyle = inBarStyle;\n- const fetchingSomething = this... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Always default to light-content StatusBar
We only use the default on the initial load, and since we're showing the splash screen there, `light-content` makes the most sense. |
129,187 | 13.07.2020 14:36:28 | 14,400 | 998187094d25e4094cdba529efe1c8428f7c8263 | [native] Prevent border/shadow between Chat header and top tabs | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -56,8 +56,10 @@ const unboundStyles = {\nflex: 1,\nbackgroundColor: 'listBackground',\n},\n- headerStyle: {\n+ threadListHeaderStyle: {\nelevation: 0,\n+ shadowOffset: { width: 0,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prevent border/shadow between Chat header and top tabs |
129,187 | 13.07.2020 14:20:52 | 14,400 | d5c38afee9272fcbeeafca7727a047470b500653 | [native] Don't wait for mount to render React Navigation in release builds | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -10,13 +10,6 @@ import { PersistGate } from 'redux-persist/integration/react';\nimport * as SplashScreen from 'expo-splash-screen';\nimport Icon from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't wait for mount to render React Navigation in release builds |
129,187 | 13.07.2020 15:26:24 | 14,400 | d4e56d5360ae6b11ff9aa824345d7a44425ececf | [native] Convert DimensionsUpdater into hook | [
{
"change_type": "MODIFY",
"old_path": "native/redux/dimensions-updater.react.js",
"new_path": "native/redux/dimensions-updater.react.js",
"diff": "// @flow\n-import { type Dimensions, dimensionsPropType } from 'lib/types/media-types';\n-import type { DispatchActionPayload } from 'lib/utils/action-u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert DimensionsUpdater into hook |
129,187 | 13.07.2020 15:58:41 | 14,400 | bc7894016a33ab7cf63ac3d4657f2af770016809 | [native] Refactor DimensionsUpdater based on react-native-safe-area-context | [
{
"change_type": "MODIFY",
"old_path": "native/redux/dimensions-updater.react.js",
"new_path": "native/redux/dimensions-updater.react.js",
"diff": "import type { Dimensions } from 'lib/types/media-types';\nimport * as React from 'react';\n-import { Dimensions as NativeDimensions } from 'react-native... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Refactor DimensionsUpdater based on react-native-safe-area-context |
129,187 | 13.07.2020 16:12:04 | 14,400 | 76213d50136b9f710b571f5447138a058ac22648 | [native] Get rid of contentVerticalOffset in favor of topInset | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -39,10 +39,7 @@ import {\nimport { connect } from 'lib/utils/redux-utils';\nimport { isLoggedIn } from 'lib/selectors/user-selectors';\n-import {\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of contentVerticalOffset in favor of topInset |
129,187 | 13.07.2020 16:25:13 | 14,400 | b609bad754ab19ccfd331d1802834635755b0498 | [native] Get rid of contentBottomOffset in favor of bottomInset | [
{
"change_type": "MODIFY",
"old_path": "native/media/camera-modal.react.js",
"new_path": "native/media/camera-modal.react.js",
"diff": "@@ -52,10 +52,7 @@ import filesystem from 'react-native-fs';\nimport { connect } from 'lib/utils/redux-utils';\nimport { pathFromURI, filenameFromPathOrURI } from '... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of contentBottomOffset in favor of bottomInset |
129,187 | 13.07.2020 16:39:32 | 14,400 | 13fa8e6df3531b9a471196fc641c2fbf7ee08dc8 | [native] Fix up inset handling in MediaGalleryKeyboard
Was ignoring it in some places because it's so small on iOS. Also, `react-native-keyboard-input` doesn't include it on iOS, but does on Android. | [
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -17,6 +17,7 @@ import {\nActivityIndicator,\nAnimated,\nEasing,\n+ Platform,\n} from 'react-native';\nimport { KeyboardRegistry } from 'react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix up inset handling in MediaGalleryKeyboard
Was ignoring it in some places because it's so small on iOS. Also, `react-native-keyboard-input` doesn't include it on iOS, but does on Android. |
129,187 | 13.07.2020 16:47:16 | 14,400 | 21ade5a79e966ef8a6d9ef66b523720ff6dd4ec7 | [native] androidOpaqueStatus -> androidKeyboardResizesFrame | [
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -18,7 +18,7 @@ import {\n} from 'react-native';\nimport invariant from 'invariant';\n-import { androidOpaqueStatus } from '../selec... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] androidOpaqueStatus -> androidKeyboardResizesFrame |
129,187 | 13.07.2020 23:45:14 | 14,400 | e3303c01e7a3b21679c0f0b0915a47e90b28ba93 | [native] Center splash header within Safe Area bounds on iOS | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -25,7 +25,6 @@ import {\nPlatform,\nBackHandler,\nActivityIndicator,\n- DeviceInfo,\n} from 'react-native';\nimport invariant from 'invariant';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Center splash header within Safe Area bounds on iOS |
129,187 | 13.07.2020 23:46:29 | 14,400 | 91fc804830023cfba901ec4c808b4f2f8e656fb2 | [native] Standardize positioning of VerificationModal close button | [
{
"change_type": "MODIFY",
"old_path": "native/account/verification-modal.react.js",
"new_path": "native/account/verification-modal.react.js",
"diff": "@@ -28,7 +28,6 @@ import {\nKeyboard,\nTouchableHighlight,\nEasing,\n- DeviceInfo,\n} from 'react-native';\nimport Icon from 'react-native-vector-ic... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Standardize positioning of VerificationModal close button |
129,187 | 13.07.2020 23:53:53 | 14,400 | b1f94749613a3844a148a8d7cfb2ed120bc1441d | [native] Keep Calendar DisconnectedBar within SafeAreaView | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -746,13 +746,13 @@ class Calendar extends React.PureComponent<Props, State> {\nconst disableInputBar = this.state.currentlyEditing.length === 0;\nreturn (\n<>\n- <... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Keep Calendar DisconnectedBar within SafeAreaView |
129,187 | 14.07.2020 15:02:07 | 14,400 | e77bf0b9488c35ab203a693c844cfbd62fd71034 | [native] Dismiss media gallery when ChatList background pressed | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -9,6 +9,10 @@ import type { TabNavigationProp } from '../navigation/app-navigator.react';\nimport type { ChatMessageItemWithHeight } from './message-list-container.react... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Dismiss media gallery when ChatList background pressed |
129,187 | 15.07.2020 00:32:56 | 14,400 | 9fd32aef2fc2e5468717d6be6b3d79bd165582ee | [native] react-native-safe-area-context@^3.1.1 | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -297,7 +297,7 @@ PODS:\n- React\n- react-native-orientation-locker (1.1.6):\n- React\n- - react-native-safe-area-context (3.0.6):\n+ - react-native-safe-area-context (3.1.1):\n- React... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-native-safe-area-context@^3.1.1 |
129,187 | 15.07.2020 00:33:22 | 14,400 | e752603c9663582d810292626daa76604ce244c5 | [native] Fix DimensionsUpdater for androidKeyboardResizesFrame | [
{
"change_type": "MODIFY",
"old_path": "native/redux/dimensions-updater.react.js",
"new_path": "native/redux/dimensions-updater.react.js",
"diff": "@@ -10,6 +10,12 @@ import {\nuseSafeAreaInsets,\n} from 'react-native-safe-area-context';\nimport PropTypes from 'prop-types';\n+import {\n+ addKeyboard... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix DimensionsUpdater for androidKeyboardResizesFrame |
129,187 | 15.07.2020 01:09:39 | 14,400 | c1918733bf31fd75a1b5fd71cbe5f56660fe9b91 | [native] Block goBack nav actions by returning null instead of lastState
This fixes `canGoBack()`, which lets the back button correctly background the app when React Nav can't handle it | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/root-router.js",
"new_path": "native/navigation/root-router.js",
"diff": "@@ -193,7 +193,7 @@ function RootRouter(\naccountModals.includes(lastRouteName) &&\n!accountModals.includes(newRouteName)\n) {\n- return lastState;\n+ return null;\n}\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Block goBack nav actions by returning null instead of lastState
This fixes `canGoBack()`, which lets the back button correctly background the app when React Nav can't handle it |
129,187 | 15.07.2020 01:14:09 | 14,400 | 508ac9f92a361233f02a2a932e9ba788a30cc794 | [native] codeVersion -> 57 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 57 |
129,187 | 15.07.2020 12:53:02 | 14,400 | 7c257ab6b4a08cff02716ddd73d06d85dff3556f | [server] Dedup membership changeset in commitMembershipChangeset | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -99,12 +99,7 @@ async function createThread(\nconst initialMemberAndCreatorIDs = initialMemberIDs\n? [...initialMemberIDs, viewer.userID]\n: [viewer.userID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Dedup membership changeset in commitMembershipChangeset |
129,187 | 15.07.2020 15:12:18 | 14,400 | 3a2eee3a9c3889207c2b5f32d68622c0099915ff | [server] setJoinsToUnread | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -21,6 +21,7 @@ import {\nchangeRole,\nrecalculateAllPermissions,\ncommitMembershipChangeset,\n+ setJoinsToUnread,\n} from '../updaters/thread-permission-up... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] setJoinsToUnread |
129,187 | 15.07.2020 17:23:27 | 14,400 | 0f8fc31521dac5c7705cf9d5de89e2f03caa4a0e | [server] One update per pairString in commitMembershipChangeset | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -492,43 +492,33 @@ async function commitMembershipChangeset(\nthrow new ServerError('not_logged_in');\n}\n- const threadMembershipC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] One update per pairString in commitMembershipChangeset |
129,187 | 15.07.2020 18:04:26 | 14,400 | 42cd4ff8ac055fdcdec02250ab3f415c0a6f71e7 | [native] Fix pointerEvents for behavior="position" KeyboardAvoidingView | [
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -171,9 +171,12 @@ class InnerKeyboardAvoidingView extends React.PureComponent<Props, State> {\nconst composedStyle = StyleSheet.com... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix pointerEvents for behavior="position" KeyboardAvoidingView |
129,187 | 15.07.2020 22:27:54 | 14,400 | 654af201bf37baf4e622cae899017f348aa93eca | [native] Fix MultimediaModal frame parameters | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -995,8 +995,8 @@ class MultimediaModal extends React.PureComponent<Props, State> {\n}\nget frame(): Dimensions {\n- const { height, width, topInset, bott... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix MultimediaModal frame parameters |
129,187 | 15.07.2020 22:32:04 | 14,400 | 59b5b2a98ae628944aa65e6a2cb88f82e117987e | [native] codeVersion -> 58 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 58 |
129,187 | 16.07.2020 13:01:16 | 14,400 | 980dc596642f08d239ed4f728c8632176d00914c | [native] Disable android:windowTranslucentNavigation in dev mode
Error messages end up drawing below the navigation bar, which makes the buttons hard to press.
My PR should fix this. We can revert this commit once we upgrade to a version of React Native that has merged that PR | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/debug/res/values-v21/styles.xml",
"diff": "+<resources>\n+ <style name=\"AppTheme\" parent=\"AppThemeBase\">\n+ <item name=\"android:windowTranslucentStatus\">true</item>\n+ <item name=\"android:windowTranslucentNavigation... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Disable android:windowTranslucentNavigation in dev mode
Error messages end up drawing below the navigation bar, which makes the buttons hard to press.
My PR https://github.com/facebook/react-native/pull/29399 should fix this. We can revert this commit once we upgrade to a version of React Native that has mer... |
129,187 | 16.07.2020 18:21:39 | 14,400 | 98341cf203c4e047557193b292b268d8f3558115 | Don't add know_of rows in changeRole if membership row already exists | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -103,6 +103,7 @@ async function changeRole(\nfor (let userID of userIDs) {\nlet oldPermissionsForChildren = null;\nlet permissionsF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't add know_of rows in changeRole if membership row already exists |
129,187 | 18.07.2020 06:47:06 | 14,400 | 878f88023f3df5887a8ef2651249e3562d686481 | [server] Fix accidental duplicate chokidar-cli | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"@babel/plugin-syntax-dynamic-import\": \"^7.2.0\",\n\"@babel/preset-flow\": \"^7.0.0\",\n\"@babel/preset-react\": \"^7.0.0\",\n- \"chokidar-cli\": \"^2.0.0\",\n+ \"chokidar-cli\": \"^2.1.0\",\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix accidental duplicate chokidar-cli |
129,187 | 19.07.2020 13:47:46 | 14,400 | d8c86d3a5b11b9483f700e5c51f9070598eafe55 | [lib] normalizeURL | [
{
"change_type": "MODIFY",
"old_path": "lib/package.json",
"new_path": "lib/package.json",
"diff": "\"string-hash\": \"^1.1.3\",\n\"tinycolor2\": \"^1.4.1\",\n\"tokenize-text\": \"^1.1.3\",\n+ \"url-parse-lax\": \"^3.0.0\",\n\"util-inspect\": \"^0.1.8\"\n}\n}\n"
},
{
"change_type": "MODIFY",... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] normalizeURL |
129,187 | 19.07.2020 21:56:22 | 14,400 | b3148f2d70f6ac0d786d45cf71e4a442a9ba74ff | [native] TextHeightMeasurer -> NodeHeightMeasurer
Now can handle measuring any node, in preparation for having to measure `<Markdown>` | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -16,7 +16,7 @@ import type {\nimport type { ViewToken } from '../types/react-native';\nimport type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] TextHeightMeasurer -> NodeHeightMeasurer
Now can handle measuring any node, in preparation for having to measure `<Markdown>` |
129,187 | 20.07.2020 17:27:41 | 14,400 | 9eecf158e27ff5908a529567caffeb4306cdab2d | [server] Script to backup Phabricator | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/bash/backup_phabricator.sh",
"diff": "+#!/bin/bash\n+\n+# run as: ssh user on root wheel\n+# run from: wherever\n+\n+# The path to Phabricator on our server\n+PHABRICATOR_PATH=/var/www/phabricator/phabricator\n+\n+# The path to the backup... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Script to backup Phabricator |
129,187 | 20.07.2020 20:19:27 | 14,400 | 3d14fbc40ba3de9c47f5604f55999958aedff3af | [server] Delete failed server backup attempts | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron/backups.js",
"new_path": "server/src/cron/backups.js",
"diff": "@@ -52,7 +52,11 @@ async function backupDB() {\nconst dateString = dateFormat('yyyy-mm-dd-HH:MM');\nconst filename = `${backupConfig.directory}/squadcal.${dateString}.sql.gz`;\n+ t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Delete failed server backup attempts |
129,187 | 20.07.2020 20:41:48 | 14,400 | ed97628620152dee79334d9a451190864ec36af8 | [native] Specify indicatorStyle on all FlatLists | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -95,6 +95,9 @@ import {\ncolorsPropType,\ncolorsSelector,\nstyleSelector,\n+ type IndicatorStyle,\n+ indicatorStylePropType,\n+ indicatorStyleSelector,\n} from '..... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Specify indicatorStyle on all FlatLists |
129,187 | 20.07.2020 21:49:22 | 14,400 | 6c03db7a6eba7dc1330f811674dc8ce32ff0a8a5 | [native] Complain when NodeHeightMeasurer is wrong | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -195,6 +195,24 @@ class InternalEntry extends React.Component<Props, State> {\nthis.currentlySaving = null;\n}\n+ if (\n+ !this.props.active &&\n+ this.state.text === pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Complain when NodeHeightMeasurer is wrong |
129,187 | 20.07.2020 22:08:58 | 14,400 | d0d20704ecd6a345dcca986b82df85d49eda0387 | [server] Fix server bug that wipes out thread list | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -603,9 +603,10 @@ async function commitMembershipChangeset(\nupdateUndirectedRelationships(_uniqWith(_isEqual)(relationshipRows)),\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix server bug that wipes out thread list |
129,187 | 20.07.2020 22:30:43 | 14,400 | bb7eae5c5382bb0d31972e46198a81ca47a0e638 | [native] Call sendMessage in iOS ClearableTextInput onBlur | [
{
"change_type": "MODIFY",
"old_path": "native/components/clearable-text-input.react.ios.js",
"new_path": "native/components/clearable-text-input.react.ios.js",
"diff": "@@ -132,6 +132,14 @@ class ClearableTextInput extends React.PureComponent<\nonBlur = () => {\nthis.focused = false;\n+ if (this.pe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Call sendMessage in iOS ClearableTextInput onBlur |
129,187 | 21.07.2020 09:44:24 | 14,400 | 27a0a6eedac14d4ca5a618aa56a6054fa051eb28 | [server] Update backup_phabricator.sh to look at phacility/phabricator directory
Instead of `phabricator/phabricator` directory, which feels repetitive | [
{
"change_type": "MODIFY",
"old_path": "server/bash/backup_phabricator.sh",
"new_path": "server/bash/backup_phabricator.sh",
"diff": "# run from: wherever\n# The path to Phabricator on our server\n-PHABRICATOR_PATH=/var/www/phabricator/phabricator\n+PHABRICATOR_PATH=/var/www/phacility/phabricator\n#... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update backup_phabricator.sh to look at phacility/phabricator directory
Instead of `phabricator/phabricator` directory, which feels repetitive |
129,187 | 21.07.2020 09:48:20 | 14,400 | ba6a90d7db41a22d93e3c6de1c1fd4ac07a93224 | [server] Silence Phabricator backup command | [
{
"change_type": "MODIFY",
"old_path": "server/bash/backup_phabricator.sh",
"new_path": "server/bash/backup_phabricator.sh",
"diff": "@@ -21,7 +21,7 @@ OUTPUT_FILE=\"$BACKUP_PATH/phabricator.$(date +'%Y-%m-%d-%R').sql.gz\"\nRETRIES=2\nwhile [[ $RETRIES -ge 0 ]]; do\n- if ./bin/storage dump --compres... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Silence Phabricator backup command |
129,187 | 22.07.2020 08:27:16 | 14,400 | 8403759af5644f442c1ab0446230804a71b5600c | [native] react-native-floating-action@^1.21.0 | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react-native-fast-image\": \"^7.0.2\",\n\"react-native-ffmpeg\": \"^0.4.4\",\n\"react-native-firebase\": \"^5.6.0\",\n- \"react-native-floating-action\": \"^1.19.1\",\n+ \"react-native-floatin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-native-floating-action@^1.21.0 |
129,186 | 21.07.2020 12:09:42 | -7,200 | 020cf71d97c3bcb0895d7efc6527c321e0b84cfa | Add userInfo state check
Reviewers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -196,19 +196,26 @@ function reduceUserInfos(\nconst checkStateRequest = action.payload.serverRequests.find(\ncandidate => candidate.type === serverRequestTypes.CHECK_STATE,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add userInfo state check
Reviewers: ashoat
Reviewed By: ashoat
Differential Revision: https://phabricator.ashoat.com/D2 |
129,187 | 23.07.2020 22:33:56 | 14,400 | 9bd45e0aeb45c87ffe6e5c2c55a81f2de55391b1 | [native] Fix Android crashes in background tasks
I introduced these issues in and which both shipped in 57 | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -369,7 +369,7 @@ PODS:\n- React\n- ReactNativeDarkMode (0.2.0-rc.1):\n- React\n- - ReactNativeKeyboardInput (6.0.0):\n+ - ReactNativeKeyboardInput (6.0.1):\n- React\n- ReactNativeKeyb... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Android crashes in background tasks
I introduced these issues in f4e846975d7a610038fd1f21b79a39305ce293bc and bc7894016a33ab7cf63ac3d4657f2af770016809, which both shipped in 57 |
129,187 | 24.07.2020 00:48:24 | 14,400 | 9a86944810f9283a1c7d3d940cf01328547ac9a9 | [native] Don't disable SplashScreen autohide until Root mounts
Otherwise if the app boots from a background task it never shows the `MainActivity` splash screen | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -44,11 +44,6 @@ import { waitForInteractions } from '../utils/interactions';\nimport ChatIcon from '../chat/chat-icon.react';\nlet splashScreenHasHid... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't disable SplashScreen autohide until Root mounts
Otherwise if the app boots from a background task it never shows the `MainActivity` splash screen |
129,187 | 24.07.2020 00:58:59 | 14,400 | b9ea65696a21d985a3bdcc26319d9f524413ee1d | [native] Display in-app notifs below top inset | [
{
"change_type": "MODIFY",
"old_path": "native/push/in-app-notif.react.js",
"new_path": "native/push/in-app-notif.react.js",
"diff": "@@ -4,6 +4,9 @@ import type { GlobalTheme } from '../types/themes';\nimport * as React from 'react';\nimport { View, Text, StyleSheet, Platform } from 'react-native';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display in-app notifs below top inset |
129,187 | 23.07.2020 23:04:45 | 14,400 | de427d2e9e5e4db4e37bc301dae19215b7edc0a2 | [native] codeVersion -> 59 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 59 |
129,187 | 24.07.2020 02:05:33 | 14,400 | d8ce9ac576a790f2db123eefcd35648e1fa49c02 | [server] Fix typo in relationships_undirected key ALTER TABLE in create-db.js | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-db.js",
"new_path": "server/src/scripts/create-db.js",
"diff": "@@ -286,7 +286,7 @@ async function createTables() {\nALTER TABLE relationships_undirected\nADD UNIQUE KEY user1_user2 (user1,user2),\n- ADD UNIQUE KEY user2_user1 (user2,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix typo in relationships_undirected key ALTER TABLE in create-db.js |
129,183 | 20.07.2020 13:10:38 | -7,200 | 02f65383b43581229da59a798a13319dd8999b29 | [web] Add more rules for markdown
Summary:
[web] After review changes
Fix fence regex
[web] Handle empty line in fence
[web] Add useDarkStyle props to markdown
Reviewers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "// @flow\nconst urlRegex = /^(https?:\\/\\/[^\\s<]+[^<.,:;\"')\\]\\s])/i;\n+const paragraphRegex = /^((?:[^\\n]*)(?:\\n|$))/;\n+const blockQuoteRegex = /^( *>[^\\n]+(?:\\n[^\\n]+)*)/;\n+co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add more rules for markdown
Summary:
[web] After review changes
Fix fence regex
[web] Handle empty line in fence
[web] Add useDarkStyle props to markdown
Reviewers: ashoat
Reviewed By: ashoat
Differential Revision: https://phabricator.ashoat.com/D4 |
129,187 | 24.07.2020 11:04:21 | 14,400 | 4351fcf2ea6704afb2e8a7c5542d66b525440373 | Fix up .arcconfig to make arc land and arc diff easier | [
{
"change_type": "MODIFY",
"old_path": ".arcconfig",
"new_path": ".arcconfig",
"diff": "{\n\"phabricator.uri\": \"https://phabricator.ashoat.com/\",\n- \"repository.callsign\": \"SQUADCAL\"\n+ \"repository.callsign\": \"SQUADCAL\",\n+ \"arc.land.onto.default\": \"master\",\n+ \"base\": \"git:merge-b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix up .arcconfig to make arc land and arc diff easier |
129,187 | 24.07.2020 11:41:14 | 14,400 | 7904fac4c08175012efe988a55ba161b4205ffe3 | [native] Don't render PushHandler until splash screen is hidden
Otherwise `PushHandler` can trigger an `Alert` that prevents the splash screen from hiding for some reason | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -125,8 +125,13 @@ function AppNavigator(props: AppNavigatorProps) {\nsetNavStateInitialized && setNavStateInitialized();\n}, [setNavStateInitialized]... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't render PushHandler until splash screen is hidden
Otherwise `PushHandler` can trigger an `Alert` that prevents the splash screen from hiding for some reason |
129,187 | 24.07.2020 15:48:40 | 14,400 | 4515d05db305f86aada4f8c9ce089b4f2eb79b73 | [native] Fix Entry height calculation | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -70,7 +70,7 @@ import {\nimport { connect } from 'lib/utils/redux-utils';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\n-import ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix Entry height calculation |
129,187 | 24.07.2020 16:14:35 | 14,400 | c535ee0620d1c0cc12d28d739f497066bdfeefc0 | [native] Delay ThreadList Search autoFocus until KeyboardAvoidingView can mount | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-list.react.js",
"new_path": "native/components/thread-list.react.js",
"diff": "@@ -6,12 +6,13 @@ import type { AppState } from '../redux/redux-setup';\nimport * as React from 'react';\nimport PropTypes from 'prop-types';\n-import { Fla... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Delay ThreadList Search autoFocus until KeyboardAvoidingView can mount |
129,187 | 24.07.2020 16:16:02 | 14,400 | 7a83fa311020631de079cc8bf5835953289d611a | [server] Don't overwrite friendships in create-relationships.js | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-relationships.js",
"new_path": "server/src/scripts/create-relationships.js",
"diff": "@@ -45,7 +45,7 @@ async function createKnowOfRelationships() {\n})),\n])(result);\n- await updateUndirectedRelationships(changeset, false);\n+ await... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't overwrite friendships in create-relationships.js |
129,187 | 24.07.2020 16:53:35 | 14,400 | e1666218af64b15495531a07208d1b6dd5c7bb94 | [server] Fix userStore state check deletion of extraneous user | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/user-fetchers.js",
"new_path": "server/src/fetchers/user-fetchers.js",
"diff": "@@ -9,7 +9,7 @@ import type { Viewer } from '../session/viewer';\nimport { ServerError } from 'lib/utils/errors';\n-import { dbQuery, SQL } from '../database';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix userStore state check deletion of extraneous user |
129,187 | 24.07.2020 17:17:35 | 14,400 | be378bd287af6e0ccff00ea9e84c62fd36cbb2c4 | [native] codeVersion -> 60 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 60 |
129,187 | 24.07.2020 18:25:05 | 14,400 | c69654252860c7cfffae2023fcd45b9cb6f33fed | [server] Waste less space on Phabricator backups | [
{
"change_type": "MODIFY",
"old_path": "server/bash/backup_phabricator.sh",
"new_path": "server/bash/backup_phabricator.sh",
"diff": "@@ -12,13 +12,25 @@ BACKUP_PATH=/mnt/backup\n# The user that will be owning the backup files\nBACKUP_USER=squadcal\n+# The maximum amount of space to spend on Phabric... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Waste less space on Phabricator backups |
129,187 | 24.07.2020 19:05:21 | 14,400 | 63c61c23f668a860c5844baa050b0a43797c83db | [web] Style changes for code Markdown | [
{
"change_type": "MODIFY",
"old_path": "web/markdown/markdown.css",
"new_path": "web/markdown/markdown.css",
"diff": "@@ -27,14 +27,23 @@ div.lightBackground blockquote {\n}\ndiv.markdown code {\n- width: 100%;\n- display: inline-block;\n- padding: .5em 10px;\n- box-sizing: border-box;\n+ padding: 0... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Style changes for code Markdown |
129,187 | 25.07.2020 23:07:27 | 14,400 | d19ad476d6095c35a67ff13e4f8e24eb019e531d | [native] Add react-native-safe-area-view package
Need it because | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"react-native-progress\": \"^4.0.3\",\n\"react-native-reanimated\": \"^1.9.0\",\n\"react-native-safe-area-context\": \"^3.1.1\",\n+ \"react-native-safe-area-view\": \"^2.0.0\",\n\"react-native-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add react-native-safe-area-view package
Need it because https://github.com/th3rdwave/react-native-safe-area-context/issues/114#issuecomment-663928390 |
129,187 | 25.07.2020 23:11:37 | 14,400 | 8c4ab14082590635e23180bdc24358df1d65c3cd | [native] Truly center Calendar after mount if it's off-screen | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -59,7 +59,7 @@ import _sum from 'lodash/fp/sum';\nimport _pickBy from 'lodash/fp/pickBy';\nimport _size from 'lodash/fp/size';\nimport _throttle from 'lodash/throt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Truly center Calendar after mount if it's off-screen |
129,187 | 26.07.2020 00:26:49 | 14,400 | 9d6b00d9166420fbd3295d4d4a3f53940fa67766 | [native] Define dummyNodeForEntryHeightMeasurement in Entry
Instead of defining node inline in `Calendar` based on `entryStyles` exported from `Entry` | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -71,7 +71,11 @@ import { connect } from 'lib/utils/redux-utils';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport sleep from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Define dummyNodeForEntryHeightMeasurement in Entry
Instead of defining node inline in `Calendar` based on `entryStyles` exported from `Entry` |
129,187 | 26.07.2020 00:54:12 | 14,400 | 2739065ff9445795a6e1df0f4a5e90db3c5fcdd0 | [native] Define dummyNodeForRobotextMessageHeightMeasurement in RobotextMessage
Now that we have `NodeTextMeasurer` instead of `TextHeightMeasurer`, we don't need to hardcode 17 in `robotextMessageItemHeight`. Instead we can measure the height of the container `View` directly. | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -14,7 +14,7 @@ import type { NavigationRoute } from '../navigation/route-names';\nimport * as React from 'react';\nimport PropTypes from 'prop-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Define dummyNodeForRobotextMessageHeightMeasurement in RobotextMessage
Now that we have `NodeTextMeasurer` instead of `TextHeightMeasurer`, we don't need to hardcode 17 in `robotextMessageItemHeight`. Instead we can measure the height of the container `View` directly. |
129,187 | 26.07.2020 13:23:42 | 14,400 | 91a0f5ee3e9e5b73a13ad1f7ac45bc776be3581d | [native] Measure and compare full Message height | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -20,6 +20,7 @@ import { type Colors, colorsPropType, colorsSelector } from '../themes/colors';\nconst clusterEndHeight = 7;\ntype Props = {|\n+ ...React.El... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Measure and compare full Message height |
129,187 | 26.07.2020 13:47:19 | 14,400 | e867552be57a5f5798eef70b9ca950c31d1a3e3c | [native] Reduce false complaints about Message height | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -22,7 +22,11 @@ import type { NavigationRoute } from '../navigation/route-names';\nimport type { LayoutEvent } from '../types/react-native';\nimport * as React from 'react';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reduce false complaints about Message height |
129,187 | 26.07.2020 13:47:49 | 14,400 | 65ee8aeb79b6c35a65d25a53fdf7f426a8a1458d | [native] Fix TextMessage height measurement to consider composedMessageMaxWidth | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inner-text-message.react.js",
"new_path": "native/chat/inner-text-message.react.js",
"diff": "@@ -8,6 +8,7 @@ import type { AppState } from '../redux/redux-setup';\nimport * as React from 'react';\nimport { View, StyleSheet, TouchableOpacity } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix TextMessage height measurement to consider composedMessageMaxWidth |
129,187 | 27.07.2020 10:12:30 | 14,400 | 6ad3f02345342608767362c3abb66fdc5937310b | Add container prop to native Markdown | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "// @flow\n-const urlRegex = /^(https?:\\/\\/[^\\s<]+[^<.,:;\"')\\]\\s])/i;\nconst paragraphRegex = /^((?:[^\\n]*)(?:\\n|$))/;\n+const paragraphStripTrailingNewlineRegex = /^([^\\n]*)(?:\\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add container prop to native Markdown |
129,187 | 27.07.2020 10:22:50 | 14,400 | 6f8644b0836e5b2d74ed451e8e0f5532fbd01837 | [native] Move Markdown container prop to MarkdownRuleSpec | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -428,7 +428,6 @@ class InternalEntry extends React.Component<Props, State> {\nstyle={textStyle}\nuseDarkStyle={darkColor}\nrules={inlineMarkdownRules}\n- container=\"Tex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move Markdown container prop to MarkdownRuleSpec |
129,187 | 28.07.2020 17:05:54 | 14,400 | df5e626ccf98c7a3fd10fc8766a29a6f8e50532c | unreadHomeCount -> unreadCount
Get rid of the old `unreadCount` | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/thread-selectors.js",
"new_path": "lib/selectors/thread-selectors.js",
"diff": "@@ -19,7 +19,6 @@ import _map from 'lodash/fp/map';\nimport _compact from 'lodash/fp/compact';\nimport _filter from 'lodash/fp/filter';\nimport _sortBy from 'lodash/f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | unreadHomeCount -> unreadCount
Get rid of the old `unreadCount` |
129,187 | 28.07.2020 17:18:48 | 14,400 | cbacdcea94610411c6a88c6ae789e048f104314e | [lib] Extract getLastUpdatedTime | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -33,10 +33,10 @@ import { threadInfoSelector } from './thread-selectors';\nimport { threadInChatList } from '../shared/thread-utils';\nexport type ChatThreadItem = {|\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Extract getLastUpdatedTime |
129,187 | 28.07.2020 17:36:45 | 14,400 | 6717bf6532dbc521c8e1404e8751b0875079ac20 | Include sidebar info in ChatThreadItem | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "// @flow\nimport type { BaseAppState } from '../types/redux-types';\n-import { type ThreadInfo, threadInfoPropType } from '../types/thread-types';\n+import {\n+ type Thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include sidebar info in ChatThreadItem |
129,187 | 28.07.2020 18:00:43 | 14,400 | 5a68506ff5419dc8cdc9ebd378c0a7880446fa4e | [native] List sidebars inline in thread view | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -166,6 +166,34 @@ const chatListData: (\n)(threadInfos),\n);\n+// Requires UI that supports displaying sidebars inline\n+const chatListDataWithNestedSidebars: (\n+ sta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] List sidebars inline in thread view |
129,187 | 28.07.2020 18:02:41 | 14,400 | 220c0831f33dfb0b45209a0e134654ea53f95e1f | [lib] Don't include sidebars in filter list | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -56,6 +56,7 @@ function threadIsInHome(threadInfo: ?(ThreadInfo | RawThreadInfo)): boolean {\nreturn !!(threadInfo && threadInfo.currentUser.subscription.home);\n}\n+// Can have... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Don't include sidebars in filter list |
129,187 | 28.07.2020 18:01:52 | 14,400 | 6931603a48aec03a3357f941a4059b421f584f3f | [native] Don't include sidebars in list of existing threads in ComposeThread | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread.react.js",
"new_path": "native/chat/compose-thread.react.js",
"diff": "@@ -42,7 +42,7 @@ import {\n} from 'lib/selectors/user-selectors';\nimport SearchIndex from 'lib/shared/search-index';\nimport {\n- threadInChatList,\n+ threadInF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't include sidebars in list of existing threads in ComposeThread |
129,183 | 27.07.2020 14:10:13 | -7,200 | 371b207756467847370e66090f43951882eb622e | [native] Add more rules
Summary: [native] Fix some problems with new lines in native markdown and style components properly
Reviewers: ashoat
Subscribers: zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "const paragraphRegex = /^((?:[^\\n]*)(?:\\n|$))/;\nconst paragraphStripTrailingNewlineRegex = /^([^\\n]*)(?:\\n|$)/;\n-const urlRegex = /^(https?:\\/\\/[^\\s<]+[^<.,:;\"')\\]\\s])/i;\n-con... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add more rules
Summary: [native] Fix some problems with new lines in native markdown and style components properly
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411
Differential Revision: https://phabricator.ashoat.com/D8 |
129,187 | 29.07.2020 10:16:56 | 14,400 | 39aa544c0dfec29c10faf8d5a8687fa8ed71b8c3 | Specify bottom margin for codeBlock/fence | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/styles.js",
"new_path": "native/markdown/styles.js",
"diff": "@@ -70,6 +70,7 @@ const unboundStyles = {\nbackgroundColor: 'codeBackground',\npadding: 10,\nborderRadius: 5,\n+ marginBottom: 6,\n},\ncodeBlockText: {\nfontFamily: Platform.select({... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Specify bottom margin for codeBlock/fence |
129,183 | 30.07.2020 10:05:53 | -7,200 | 9820ea45895894b154feb02f86ee6a5df3084239 | Add trimming function to preserve spaces for code block
Reviewers: ashoat
Subscribers: zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -32,6 +32,7 @@ import { prettyDate } from '../utils/date-utils';\nimport { userIDsToRelativeUserInfos } from '../selectors/user-selectors';\nimport { shimUploadURI, multimedia... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add trimming function to preserve spaces for code block
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411
Differential Revision: https://phabricator.ashoat.com/D9 |
129,187 | 02.08.2020 17:49:59 | 14,400 | 7abb6231948da0038efa05a320933ec22e1098a5 | [server] getParentThreadMembershipRowsForNewUsers -> getParentThreadRelationshipRowsForNewUsers
Minor naming fix | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -22,7 +22,7 @@ import {\nrecalculateAllPermissions,\ncommitMembershipChangeset,\nsetJoinsToUnread,\n- getParentThreadMembershipRowsForNewUsers,\n+ getParen... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] getParentThreadMembershipRowsForNewUsers -> getParentThreadRelationshipRowsForNewUsers
Minor naming fix |
129,187 | 02.08.2020 18:23:54 | 14,400 | 4658e0d0fe5cbfdc8ea81c47b1622b24aa78964f | [lib] Move userIDs in SharedRelationshipRow to numbers | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/relationship-utils.js",
"new_path": "lib/shared/relationship-utils.js",
"diff": "// @flow\n-function sortIDs(firstId: string, secondId: string): number[] {\n- return [Number(firstId), Number(secondId)].sort((a, b) => a - b);\n+function sortIDs(first... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move userIDs in SharedRelationshipRow to numbers |
129,187 | 02.08.2020 18:25:15 | 14,400 | 28bb013cb161a2e090f0145461594cc0bb3fe134 | [server] Extract updateDatasForUserPairs and call it from commitMembershipChangeset | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/relationship-updaters.js",
"new_path": "server/src/updaters/relationship-updaters.js",
"diff": "@@ -9,12 +9,13 @@ import {\nundirectedStatus,\ndirectedStatus,\n} from 'lib/types/relationship-types';\n-import { updateTypes } from 'lib/types/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Extract updateDatasForUserPairs and call it from commitMembershipChangeset |
129,187 | 02.08.2020 18:48:01 | 14,400 | 03c926e915d62169bea54038e4879661a0c69612 | [server] Check for know_of rows in createThread | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -9,14 +9,17 @@ import {\nimport { messageTypes } from 'lib/types/message-types';\nimport type { Viewer } from '../session/viewer';\n+import invariant from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Check for know_of rows in createThread |
129,187 | 02.08.2020 22:47:50 | 14,400 | 2e96bace4e3525469c25ba3e72ddf13839020407 | [server] Add createRelationships param to createThread | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/array.js",
"new_path": "lib/utils/array.js",
"diff": "// @flow\n-function getAllTuples<T>([head, ...tail]: Array<T>): Array<[T, T]> {\n+function getAllTuples<T>([head, ...tail]: $ReadOnlyArray<T>): Array<[T, T]> {\nif (tail.length > 0) {\nreturn [...... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add createRelationships param to createThread |
129,187 | 02.08.2020 22:58:36 | 14,400 | 5b00ac224b0bc20a1408c53e62ea7a581eb71139 | [server] Check for know_of rows in updateThread | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -18,6 +18,7 @@ import { messageTypes, defaultNumberPerThread } from 'lib/types/message-types';\nimport bcrypt from 'twin-bcrypt';\nimport _find from 'lod... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Check for know_of rows in updateThread |
129,187 | 02.08.2020 23:03:09 | 14,400 | afc3de947726316b67b1d57d2f0381bbda5efadb | [server] Update fetchKnownUserInfos to take array of userIDs instead of SQLStatement | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -61,10 +61,7 @@ async function createThread(\nif (initialMemberIDs) {\ncheckPromises.fetchInitialMembers = fetchKnownUserInfos(\nviewer,\n- SQL`\n- ((r.use... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update fetchKnownUserInfos to take array of userIDs instead of SQLStatement |
129,187 | 02.08.2020 23:08:15 | 14,400 | 0d37866a000e4320ce7dfe0ff564057fe5eeb236 | [server] Create know_of relationship between ashoat and squadbot in create-db.js | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-db.js",
"new_path": "server/src/scripts/create-db.js",
"diff": "// @flow\n+import { threadTypes } from 'lib/types/thread-types';\n+import { undirectedStatus } from 'lib/types/relationship-types';\n+\nimport ashoat from 'lib/facts/asho... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create know_of relationship between ashoat and squadbot in create-db.js |
129,187 | 04.08.2020 10:27:11 | 14,400 | 8957123c597015bac5b269ce30cb9c2a05de7b51 | [native] Export chatMessageItemKey from chat-list.react.js | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -13,6 +13,7 @@ import {\ntype KeyboardState,\nwithKeyboardState,\n} from '../keyboard/keyboard-state';\n+import type { ChatMessageItem } from 'lib/selectors/chat-selecto... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Export chatMessageItemKey from chat-list.react.js |
129,187 | 04.08.2020 16:28:56 | 14,400 | f226fa63962135ac8643adb8fb73aa1ead5c45ef | [server] Update to Node 14.7 | [
{
"change_type": "MODIFY",
"old_path": "server/.nvmrc",
"new_path": "server/.nvmrc",
"diff": "-13.13\n+14.7\n"
},
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"rsync\": \"rsync -rLpmuv --exclude '*/package.json' --excl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update to Node 14.7 |
129,187 | 04.08.2020 16:32:41 | 14,400 | 57d9d2d79e059f34fcabfb21db685a2abd700974 | [native] sleep(0) before changing scrollPos on first scroll on iOS
Was doing this on Android before but it started to be an issue on iOS too. I can't figure out when/why... tried builds from almost a year ago and they have the issue. Maybe something about my phone changed? Repros on simulator though. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -214,8 +214,8 @@ class Calendar extends React.PureComponent<Props, State> {\n// cache the most recent value as a member here\nlatestExtraData: ExtraData;\n// For s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] sleep(0) before changing scrollPos on first scroll on iOS
Was doing this on Android before but it started to be an issue on iOS too. I can't figure out when/why... tried builds from almost a year ago and they have the issue. Maybe something about my phone changed? Repros on simulator though. |
129,187 | 05.08.2020 13:55:53 | 14,400 | 9ca55df82830f5dfbc5b8e36e4aaaba78efa5b44 | [native] SingleLine
`Text`'s `numberOfLines` prop on iOS only considers the first line, whereas on Android it ignores newlines.
This commit introduces a `SingleLine` component whose behavior is consistent across platforms. It only considers the first line, ie. iOS's behavior. | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/entry.react.js",
"new_path": "native/calendar/entry.react.js",
"diff": "@@ -76,6 +76,7 @@ import {\nimport { waitForInteractions } from '../utils/interactions';\nimport Markdown from '../markdown/markdown.react';\nimport { inlineMarkdownRules }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] SingleLine
`Text`'s `numberOfLines` prop on iOS only considers the first line, whereas on Android it ignores newlines.
This commit introduces a `SingleLine` component whose behavior is consistent across platforms. It only considers the first line, ie. iOS's behavior. |
129,187 | 05.08.2020 14:49:15 | 14,400 | 955c8f63418555afd1bedbeddda827bb9a815dcb | [native] Track whether device is rotated in DimensionsInfo
`deviceOrientation` should track this, but it lags a little bit compared to `dimensionsInfo`, which causes issues | [
{
"change_type": "MODIFY",
"old_path": "native/redux/dimensions-updater.react.js",
"new_path": "native/redux/dimensions-updater.react.js",
"diff": "@@ -24,6 +24,7 @@ export type DimensionsInfo = {|\ntopInset: number,\nbottomInset: number,\ntabBarHeight: number,\n+ rotated: boolean,\n|};\nconst dimen... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Track whether device is rotated in DimensionsInfo
`deviceOrientation` should track this, but it lags a little bit compared to `dimensionsInfo`, which causes issues |
129,187 | 05.08.2020 14:51:47 | 14,400 | 90611a250c5a2a03b3ad59d9c79b7de7ad4d47db | [native] Ignore device orientation in composedMessageMaxWidthSelector | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message-width.js",
"new_path": "native/chat/composed-message-width.js",
"diff": "// @flow\nimport type { AppState } from '../redux/redux-setup';\n+import type { DimensionsInfo } from '../redux/dimensions-updater.react';\nimport { createSel... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Ignore device orientation in composedMessageMaxWidthSelector |
129,187 | 05.08.2020 15:20:26 | 14,400 | 16301f73752b1aff842db7b7015bb56e1381cf0e | [native] Don't measure heights while device is rotated | [
{
"change_type": "MODIFY",
"old_path": "native/components/node-height-measurer.react.js",
"new_path": "native/components/node-height-measurer.react.js",
"diff": "@@ -404,8 +404,13 @@ class NodeHeightMeasurer<Item, MergedItem> extends React.PureComponent<\n}\n}\n- onContainerLayout(event: LayoutEvent... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't measure heights while device is rotated |
129,187 | 05.08.2020 15:23:43 | 14,400 | 27b334e2037dc296129e1e64131ac5ce006ed89e | [native] codeVersion -> 61 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 61 |
129,187 | 05.08.2020 21:11:11 | 14,400 | bdc6076f9d519b794a2f56223354870ad0bfc718 | [server] Deprecate codeVersion < 24
These clients will now get automatically logged off and prompted to update | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/version.js",
"new_path": "server/src/session/version.js",
"diff": "@@ -17,10 +17,14 @@ async function verifyClientSupported(\nthrow error;\n}\n-// eslint-disable-next-line no-unused-vars\nfunction clientSupported(platformDetails: ?PlatformDe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate codeVersion < 24
These clients will now get automatically logged off and prompted to update |
129,187 | 05.08.2020 21:24:52 | 14,400 | 0ccd9f9a5831c33bd0191b4f55a45db18debfdb4 | [server] Deprecate ping endpoint | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -68,7 +68,6 @@ const socketPreferredEndpoints = Object.freeze({\nCREATE_THREAD: 'create_thread',\nFETCH_MESSAGES: 'fetch_messages',\nJOIN_THREAD: 'join_thread',\n- PING: 'ping',\nCREATE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate ping endpoint |
129,187 | 05.08.2020 21:29:35 | 14,400 | 5575f375720115c46f52ef3473e7abfe10ad35e2 | [server] ping-responders.js -> session-utils.js | [
{
"change_type": "RENAME",
"old_path": "server/src/responders/ping-responders.js",
"new_path": "server/src/socket/session-utils.js",
"diff": "@@ -56,12 +56,12 @@ import {\nimport { deviceTokenUpdater } from '../updaters/device-token-updaters';\nimport createReport from '../creators/report-creator';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] ping-responders.js -> session-utils.js |
129,187 | 05.08.2020 21:40:07 | 14,400 | 2b96124b5215e8c4b36b18b73a35469da758a600 | [server] Require platformDetails when creating new user cookie | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -49,7 +49,7 @@ export type RegisterRequest = {|\npassword: string,\ncalendarQuery?: ?CalendarQuery,\ndeviceTokenUpdateRequest?: ?DeviceTokenUpdateRequest,\n- platformDetails?: P... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Require platformDetails when creating new user cookie |
129,187 | 05.08.2020 21:52:44 | 14,400 | d9ec7ed150262dc4eb1936d117ddc592e6409097 | [server] Clean up processClientResponses
Now that it's not called from deprecated ping code we can simplify a bit | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/session-utils.js",
"new_path": "server/src/socket/session-utils.js",
"diff": "@@ -133,7 +133,7 @@ type ProcessClientResponsesResult = {|\n|};\nasync function processClientResponses(\nviewer: Viewer,\n- clientResponses: ?$ReadOnlyArray<ClientR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Clean up processClientResponses
Now that it's not called from deprecated ping code we can simplify a bit |
129,187 | 05.08.2020 21:56:51 | 14,400 | 95d2327518e4bc6a2cf8efd9caadd1ca7ded2102 | [server] Deprecate serverRequestTypes.DEVICE_TOKEN | [
{
"change_type": "MODIFY",
"old_path": "lib/types/request-types.js",
"new_path": "lib/types/request-types.js",
"diff": "@@ -18,7 +18,7 @@ import invariant from 'invariant';\n// clients. Clients then respond to those requests with a \"client response\".\nexport const serverRequestTypes = Object.freez... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate serverRequestTypes.DEVICE_TOKEN |
129,187 | 05.08.2020 22:02:49 | 14,400 | d005a4e82c8cbfef8731a2c56a5c6ed2e8a49e9f | [server] Deprecate serverRequestTypes.INITIAL_ACTIVITY_UPDATE | [
{
"change_type": "MODIFY",
"old_path": "lib/types/request-types.js",
"new_path": "lib/types/request-types.js",
"diff": "@@ -21,7 +21,7 @@ export const serverRequestTypes = Object.freeze({\n//DEVICE_TOKEN: 1, (DEPRECATED)\nTHREAD_INCONSISTENCY: 2,\nPLATFORM_DETAILS: 3,\n- INITIAL_ACTIVITY_UPDATE: 4,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Deprecate serverRequestTypes.INITIAL_ACTIVITY_UPDATE |
129,187 | 06.08.2020 11:13:05 | 14,400 | 8e04cd7e0489b75eb8c69a0915d62672df16b900 | Add JSON Markdown rule
This isn't really Markdown, but I want to pretty-print JSON in a `codeBlock` since `squadbot` occasionally sends me JSON blobs (for `MediaMissionReport`s, for instance). | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "@@ -17,6 +17,49 @@ const blockQuoteStripFollowingNewlineRegex = /^( *>[^\\n]+(?:\\n[^\\n]+)*)(?:\\n|$){\nconst urlRegex = /^(https?:\\/\\/[^\\s<]+[^<.,:;\"')\\]\\s])/i;\n+function jsonMatc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add JSON Markdown rule
This isn't really Markdown, but I want to pretty-print JSON in a `codeBlock` since `squadbot` occasionally sends me JSON blobs (for `MediaMissionReport`s, for instance). |
129,187 | 06.08.2020 15:58:10 | 14,400 | 209be2fb483e21cf7913b82a71ec914f27654206 | [lib] Only issue inconsistency reports due to state check
We can now rely on the "new" method (ie. `UpdateInfo`s) in reducers instead of the old method (returning updated data structures directly). | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -103,10 +103,12 @@ function filterExistingDaysToEntriesWithNewEntryInfos(\nfunction mergeNewEntryInfos(\ncurrentEntryInfos: { [id: string]: RawEntryInfo },\n+ currentDaysT... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Only issue inconsistency reports due to state check
We can now rely on the "new" method (ie. `UpdateInfo`s) in reducers instead of the old method (returning updated data structures directly). |
129,187 | 06.08.2020 16:30:04 | 14,400 | 14788d4e8d38be3df43073d419c3f9c755b7250d | [lib] Clean up pre-UpdateInfo params from thread actions | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "// @flow\nimport type {\n- ChangeThreadSettingsResult,\n+ ChangeThreadSettingsPayload,\nLeaveThreadPayload,\nUpdateThreadRequest,\nNewThreadRequest,\n@@ -30,8 +30,6 @@ async ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Clean up pre-UpdateInfo params from thread actions |
129,187 | 06.08.2020 16:54:46 | 14,400 | b70cfd0998ace2e0702f475ef606f79461de8d9f | [lib] Clean up pre-UpdateInfo params from entry actions | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -4,13 +4,13 @@ import type {\nRawEntryInfo,\nCalendarQuery,\nSaveEntryInfo,\n- SaveEntryResult,\n+ SaveEntryResponse,\nCreateEntryInfo,\nCreateEntryPayload,\nDeleteEntryInfo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Clean up pre-UpdateInfo params from entry actions |
129,187 | 06.08.2020 17:33:12 | 14,400 | 4da0afe856b6ac9123fe54c223149baad1527765 | [server] Don't return entryInfo from restore_entry
Only web ever calls `restoreEntry`, and we just updated it so it doesn't need the `entryInfo` | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -10,7 +10,7 @@ import type {\nDeleteEntryInfo,\nDeleteEntryResponse,\nRestoreEntryInfo,\n- RestoreEntryResult,\n+ RestoreEntryResponse,\nFetchEntryInfosResult,\nCalendarQuer... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't return entryInfo from restore_entry
Only web ever calls `restoreEntry`, and we just updated it so it doesn't need the `entryInfo` |
129,187 | 06.08.2020 17:44:01 | 14,400 | 4a4f339b51fd259d5dbed056933a9a6d8fbcf80e | [lib] hasMinCodeVersion | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -33,6 +33,7 @@ import { userIDsToRelativeUserInfos } from '../selectors/user-selectors';\nimport { shimUploadURI, multimediaMessagePreview } from '../media/media-utils';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] hasMinCodeVersion |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.