author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 15.09.2020 16:13:51 | 14,400 | eadf6984766f558d35ba2756b41e2f32f16e5174 | [native] Get rid of hoistNonReactStatics
Summary: We used to need this because React Navigation relied on statics on React components to specify navigation options. React Nav 5 did away with this, but at the time I forgot to remove this.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -15,7 +15,6 @@ import * as React from 'react';\nimport PropTypes from 'prop-types';\nimport { View } from 'react-native';\nimport invariant fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of hoistNonReactStatics
Summary: We used to need this because React Navigation relied on statics on React components to specify navigation options. React Nav 5 did away with this, but at the time I forgot to remove this.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adr... |
129,187 | 15.09.2020 16:20:50 | 14,400 | fb7f68872f12119b5d492768eadbd7cdaea353d0 | [native] Use hook instead of connect functions and HOC in MessageListContainer
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport { messageTypes } from 'lib/types/message-types';\nimport { type ThreadInf... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in MessageListContainer
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D122 |
129,187 | 15.09.2020 16:34:04 | 14,400 | 78476fbbe120c49f7b37bb1f13053dd741926e01 | [native] Use hook instead of connect functions and HOC in MultimediaTooltipButton
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-tooltip-button.react.js",
"new_path": "native/chat/multimedia-tooltip-button.react.js",
"diff": "@@ -5,7 +5,6 @@ import {\nverticalBoundsPropType,\nlayoutCoordinatesPropType,\n} from '../types/layout-types';\n-import type { AppState } fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in MultimediaTooltipButton
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D123 |
129,187 | 15.09.2020 23:38:42 | 14,400 | c175e0ee532d916d1a9463805c628a7e11fc2ef7 | [native] Use hook instead of connect functions and HOC in Tooltip
Summary: `connect` and friends were hiding a whole lot of type errors here. I had to refactor things to make it work.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/action-utils.js",
"new_path": "lib/utils/action-utils.js",
"diff": "@@ -142,12 +142,19 @@ function createDispatchActionPromise(dispatch: Dispatch) {\nreturn dispatchActionPromise;\n}\n-export type DispatchFunctions = {\n+export type DispatchFunctions... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in Tooltip
Summary: `connect` and friends were hiding a whole lot of type errors here. I had to refactor things to make it work.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat... |
129,187 | 16.09.2020 00:33:54 | 14,400 | 9022f75f6b5ecaf9037007b736b37f5e5d2ad8d9 | [native] Use hook instead of connect functions and HOC in KeyboardInputHost
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard-input-host.react.js",
"new_path": "native/keyboard/keyboard-input-host.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport {\ntype InputState,\ninputStatePropType,\n- withInputState,\n+ InputSta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in KeyboardInputHost
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D125 |
129,187 | 16.09.2020 03:27:38 | 14,400 | c95eb9796339a9b3881c7e2b1f664c4c68e597dc | [native] Use hook instead of connect functions and HOC in CameraModal
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/camera-modal.react.js",
"new_path": "native/media/camera-modal.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport type { PhotoCapture } from 'lib/types/media-types';\nimport {\ntype DimensionsInfo,\ndimens... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in CameraModal
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D126 |
129,187 | 16.09.2020 03:31:00 | 14,400 | a26cfb5d4aa3b5129bde9a39037fb8cd85a8f2aa | [native] Use hook instead of connect functions and HOC in Multimedia
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia.react.js",
"new_path": "native/media/multimedia.react.js",
"diff": "@@ -11,18 +11,21 @@ import RemoteImage from './remote-image.react';\nimport {\ntype InputState,\ninputStatePropType,\n- withInputState,\n+ InputStateContext,\n} from '.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in Multimedia
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D127 |
129,187 | 16.09.2020 03:32:02 | 14,400 | 9f294c7b2448a7a77b4dcf2bd6140a54aef43784 | [native] Get rid of withInputState
Summary: It's no longer used. Going forward, let's use hooks for data binding
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state.js",
"new_path": "native/input/input-state.js",
"diff": "@@ -65,32 +65,9 @@ const inputStatePropType = PropTypes.shape({\nconst InputStateContext = React.createContext<?InputState>(null);\n-function withInputState<\n- AllProps: {},\n- ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of withInputState
Summary: It's no longer used. Going forward, let's use hooks for data binding
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D128 |
129,187 | 16.09.2020 23:55:29 | 14,400 | fdd9bd64f8ac7495298abbdd56841a5f875b0739 | [native] codeVersion -> 66 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 66 |
129,187 | 17.09.2020 16:34:20 | 14,400 | d33931b6e305031b022c6cbe086f263dc439ac8f | [native] Fix local Image rendering for iOS 14
Summary: See [here](https://github.com/facebook/react-native/issues/29279) for more info about the issue.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "patches/react-native+0.62.2.patch",
"new_path": "patches/react-native+0.62.2.patch",
"diff": "@@ -16,3 +16,16 @@ index 624c622..bc67109 100644\n}\n/**\n+diff --git a/node_modules/react-native/Libraries/Image/RCTUIImageViewAnimated.m b/node_modules/react-native... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix local Image rendering for iOS 14
Summary: See [here](https://github.com/facebook/react-native/issues/29279) for more info about the issue.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D136 |
129,187 | 17.09.2020 17:44:30 | 14,400 | c00381a609ef93c1feac7274d816bf345a8e20db | [native] Fix crash if keyboard shows after locally-created event is deleted
Summary: Oops... made a mistake here around three years ago. `_findIndex` returns -1 if it doesn't find the element in question
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -796,11 +796,11 @@ class Calendar extends React.PureComponent<Props, State> {\nscrollToKey(lastEntryKeyActive: string, keyboardHeight: number) {\nconst data = this... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix crash if keyboard shows after locally-created event is deleted
Summary: Oops... made a mistake here around three years ago. `_findIndex` returns -1 if it doesn't find the element in question
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https:... |
129,187 | 18.09.2020 02:09:23 | 14,400 | e8aa7847407fab0178db157bc5b8728947552672 | [native] Fix release build for Xcode 12
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"new_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"diff": ");\nINFOPLIST_FILE = SquadCal/Info.release.plist;\nLD_RUNPATH_SEARCH_PATHS = \"$(inherited) @executable_path/Frameworks\";\n+ ONLY_ACTIVE_ARCH... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix release build for Xcode 12
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D138 |
129,191 | 17.09.2020 14:41:10 | -7,200 | 777d5a5ab328030415efc25ac5c1b7fbef2c96fa | Add babel presets for optional chaining and nullish coalescing
Summary: Add babel presets for optional chaining and nullish coalescing
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/babel.config.cjs",
"new_path": "lib/babel.config.cjs",
"diff": "@@ -3,5 +3,7 @@ module.exports = {\nplugins: [\n'@babel/plugin-proposal-class-properties',\n'@babel/plugin-proposal-object-rest-spread',\n+ '@babel/plugin-proposal-optional-chaining',\n+ '@bab... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add babel presets for optional chaining and nullish coalescing
Summary: Add babel presets for optional chaining and nullish coalescing
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D133 |
129,191 | 17.09.2020 15:24:02 | -7,200 | 55e795bf95e7ca371ff9d6037c92f78bf5932d68 | [server] Move thread permission fetchers to a new file
Summary: Move thread permission fetchers to a new file
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/entry-creator.js",
"new_path": "server/src/creators/entry-creator.js",
"diff": "@@ -18,7 +18,7 @@ import { dbQuery, SQL } from '../database';\nimport fetchOrCreateDayID from '../creators/day-creator';\nimport createIDs from '../creators/id-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move thread permission fetchers to a new file
Summary: Move thread permission fetchers to a new file
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D134 |
129,187 | 18.09.2020 14:06:54 | 14,400 | e1142691ee049afae4e7825037b4678e6df98dc6 | [web] css-loader@^4.3.0, mini-css-extract-plugin@^0.11.2, style-loader@^1.2.1
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"babel-plugin-transform-remove-console\": \"^6.8.4\",\n\"clean-webpack-plugin\": \"^3.0.0\",\n\"concurrently\": \"^5.3.0\",\n- \"css-loader\": \"^3.2.0\",\n+ \"css-loader\": \"^4.3.0\",\n\"flow-bin\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] css-loader@^4.3.0, mini-css-extract-plugin@^0.11.2, style-loader@^1.2.1
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D143 |
129,187 | 18.09.2020 14:10:34 | 14,400 | d74f36121e8708ed90bac694389cfd0205186524 | [web] Move from to core-js@^3.6.5
Summary: Context [here](https://babeljs.io/blog/2019/03/19/7.4.0#core-js-3-7646httpsgithubcombabelbabelpull7646) and [here](https://github.com/zloirock/core-js#babel). I had to add `core-js` to the root `package.json` so that it would get resolved correctly during Webpack builds.
Revie... | [
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "},\n\"devDependencies\": {\n\"babel-eslint\": \"^10.1.0\",\n+ \"core-js\": \"^3.6.5\",\n\"eslint\": \"^6.8.0\",\n\"eslint-config-prettier\": \"^6.10.0\",\n\"eslint-plugin-flowtype\": \"^4.6.0\",\n"
},
{
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Move from @babel/polyfill to core-js@^3.6.5
Summary: Context [here](https://babeljs.io/blog/2019/03/19/7.4.0#core-js-3-7646httpsgithubcombabelbabelpull7646) and [here](https://github.com/zloirock/core-js#babel). I had to add `core-js` to the root `package.json` so that it would get resolved correctly during Webp... |
129,187 | 18.09.2020 14:24:40 | 14,400 | 98a1b42d0b9c0eb1e93322583844a1db40bf49e0 | Use ESModules for Webpack/Babel
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/babel.config.cjs",
"new_path": "lib/babel.config.cjs",
"diff": "@@ -5,6 +5,6 @@ module.exports = {\n'@babel/plugin-proposal-object-rest-spread',\n'@babel/plugin-proposal-optional-chaining',\n'@babel/plugin-proposal-nullish-coalescing-operator',\n- '@babel/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use ESModules for Webpack/Babel
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D145 |
129,187 | 18.09.2020 14:40:00 | 14,400 | 15134b6c7c1f77cb822d889b029712d014b29312 | [native] Update SDWebImage so react-native-fast-image works on iOS 14
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -393,9 +393,9 @@ PODS:\n- React\n- RNVectorIcons (6.6.0):\n- React\n- - SDWebImage (5.7.2):\n- - SDWebImage/Core (= 5.7.2)\n- - SDWebImage/Core (5.7.2)\n+ - SDWebImage (5.9.1):\n+ - S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update SDWebImage so react-native-fast-image works on iOS 14
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D146 |
129,187 | 18.09.2020 15:17:32 | 14,400 | f8d585f6065dc1bcac54c3c3d724a84f55a77142 | [lib] Only list sidebars that pass threadInChatList
Summary: For a sidebar to appear in the `ChatThreadList`, the viewer must be a member and has the `VISIBLE` permission
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -112,7 +112,10 @@ function createChatThreadItem(\nlet lastUpdatedTimeIncludingSidebars = lastUpdatedTime;\nif (childThreads) {\nfor (const childThreadInfo of childThre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Only list sidebars that pass threadInChatList
Summary: For a sidebar to appear in the `ChatThreadList`, the viewer must be a member and has the `VISIBLE` permission
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D147 |
129,187 | 21.09.2020 13:10:18 | 14,400 | be5b55381bae081aefb29746bb1decb142d591bb | [server] Make sure -1 role gets overwritten by 0 role in updateDescendantPermissions
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -296,7 +296,8 @@ async function updateDescendantPermissions(\npermissionsFromParent,\n] of usersToPermissionsFromParent) {\nconst u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Make sure -1 role gets overwritten by 0 role in updateDescendantPermissions
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D148 |
129,187 | 23.09.2020 03:54:52 | 14,400 | ec88456c1848d0021b3bdbd045bd6054ced36aa2 | [server] Move to
Summary:
The `apn` package isn't being maintained anymore:
This is necessary to fix this security vulnerability:
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "DELETE",
"old_path": "server/flow-typed/npm/apn_vx.x.x.js",
"new_path": null,
"diff": "-// flow-typed signature: 6d909c0b9769ca9165add464ead2d40e\n-// flow-typed version: <<STUB>>/apn_v^2.2.0/flow_v0.98.0\n-\n-/**\n- * This is an autogenerated libdef stub for:\n- *\n- * 'apn'\n- *\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move to @parse/node-apn
Summary:
The `apn` package isn't being maintained anymore: https://github.com/node-apn/node-apn/issues/664
This is necessary to fix this security vulnerability: https://github.com/advisories/GHSA-92xj-mqp7-vmcj
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, ... |
129,187 | 24.09.2020 23:12:05 | 14,400 | 6f8dcdc912b1dbb175182a3d210829127e3df45b | [native] Use hook instead of connect functions and HOC in ChatList
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -8,10 +8,9 @@ import type { ChatNavigationProp } from './chat.react';\nimport type { TabNavigationProp } from '../navigation/app-navigator.react';\nimport type { ChatMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ChatList
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D150 |
129,187 | 24.09.2020 23:13:10 | 14,400 | c523c01d028d5a27a982912d5a56e4118707dec8 | [native] Use hook instead of connect functions and HOC in MessageList
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list.react.js",
"new_path": "native/chat/message-list.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\nimport { chatMessageI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in MessageList
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D151 |
129,187 | 24.09.2020 23:14:04 | 14,400 | 6dd7572195900807f423c07141e82673f9d63295 | [native] Use hook instead of connect functions and HOC in Message
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message.react.js",
"new_path": "native/chat/message.react.js",
"diff": "@@ -15,7 +15,7 @@ import {\nimport {\ntype KeyboardState,\nkeyboardStatePropType,\n- withKeyboardState,\n+ KeyboardContext,\n} from '../keyboard/keyboard-state';\nimport type {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in Message
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D152 |
129,187 | 24.09.2020 23:15:02 | 14,400 | 11ba485b9c492cb16cdab3278bc80dea57ee9a2a | [native] Move KeyboardContext data-binding to hook in KeyboardAvoidingView
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -5,7 +5,7 @@ import type { ScreenRect, KeyboardEvent } from '../keyboard/keyboard';\nimport type { ViewStyle } from '../types/style... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move KeyboardContext data-binding to hook in KeyboardAvoidingView
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D153 |
129,187 | 24.09.2020 23:23:14 | 14,400 | 5c8e9a609de2df88c5d99a698af68fe198d67d12 | [native] Use hook instead of connect functions and HOC in TextMessage
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message.react.js",
"new_path": "native/chat/text-message.react.js",
"diff": "@@ -34,10 +34,10 @@ import textMessageSendFailed from './text-message-send-failed';\nimport {\ntype KeyboardState,\nkeyboardStatePropType,\n- withKeyboardState,\n+ Ke... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in TextMessage
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D154 |
129,187 | 24.09.2020 23:28:42 | 14,400 | 7d80ae4d8b5cf31f49bbfc1aeaf71192df84031e | [native] Use hook instead of connect functions and HOC in MultimediaMessageMultimedia
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/multimedia-message-multimedia.react.js",
"new_path": "native/chat/multimedia-message-multimedia.react.js",
"diff": "@@ -19,7 +19,6 @@ import {\nmessageListRoutePropType,\nmessageListNavPropType,\n} from './message-list-types';\n-import type { AppSt... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in MultimediaMessageMultimedia
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D155 |
129,187 | 24.09.2020 23:37:35 | 14,400 | af8e6fa6c2a7e254fdbb25ca92f4710be2381e66 | [native] Use hook instead of connect functions and HOC in ThreadSettingsMember
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-member.react.js",
"new_path": "native/chat/settings/thread-settings-member.react.js",
"diff": "@@ -7,7 +7,6 @@ import {\nthreadPermissions,\nrelativeMemberInfoPropType,\n} from 'lib/types/thread-types';\n-import type { AppS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ThreadSettingsMember
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D156 |
129,187 | 25.09.2020 00:01:08 | 14,400 | 0bca83d30f37c47a0a851b2dca1f3760560be079 | [native] Convert RobotextMessage to hook
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/robotext-message.react.js",
"new_path": "native/chat/robotext-message.react.js",
"diff": "// @flow\n-import { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n-import { chatMessageItemPropType } from 'lib/selectors/chat-selecto... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert RobotextMessage to hook
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D157 |
129,187 | 25.09.2020 00:02:42 | 14,400 | 85cb25555a8d8eafdcd2e69be1110cc1ddae6427 | [native] Get rid of withKeyboardState
Summary: It's no longer used. Going forward, let's use hooks for data binding.
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard-state.js",
"new_path": "native/keyboard/keyboard-state.js",
"diff": "@@ -27,29 +27,4 @@ const keyboardStatePropType = PropTypes.shape({\nconst KeyboardContext = React.createContext<?KeyboardState>(null);\n-function withKeyboardState<\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of withKeyboardState
Summary: It's no longer used. Going forward, let's use hooks for data binding.
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D158 |
129,187 | 28.09.2020 12:13:42 | 14,400 | 479419e297b3b10f0e33bb13e5430973bec476be | [native] Don't dismiss keyboard during RobotextMessage render
Summary: Oops, made a mistake in D157...
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/robotext-message.react.js",
"new_path": "native/chat/robotext-message.react.js",
"diff": "@@ -122,13 +122,14 @@ function RobotextMessage(props: Props) {\n}\nconst keyboardState = React.useContext(KeyboardContext);\n- const didDismiss = keyboardStat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't dismiss keyboard during RobotextMessage render
Summary: Oops, made a mistake in D157...
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D160 |
129,187 | 28.09.2020 12:24:44 | 14,400 | 30da831fb942a47ac1afd9b84909b04633f93e46 | [web] Use flex-direction column-reverse on Firefox 81
Summary: This [bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1042151) is finally fixed in Firefox 81!
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -17,11 +17,11 @@ div.messageContainer {\ndisplay: flex;\nflex-direction: column-reverse;\n}\n-div.firefoxMessageContainer {\n+div.mirroredMessageContainer {\nflex-direct... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use flex-direction column-reverse on Firefox 81
Summary: This [bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1042151) is finally fixed in Firefox 81!
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D161 |
129,183 | 15.09.2020 13:35:09 | -7,200 | c9e9bfa4c4c168b887e752881c91ecef27237a8d | [native] Add swipeable component for message
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "import type { ChatMessageInfoItemWithHeight } from './message.react';\nimport { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport { asser... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add swipeable component for message
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D109 |
129,183 | 15.09.2020 14:19:58 | -7,200 | c24cf64fd1012705afb35b9027b504303c16d5ea | [native] Reply by swiping on message
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/composed-message.react.js",
"new_path": "native/chat/composed-message.react.js",
"diff": "@@ -8,13 +8,21 @@ import * as React from 'react';\nimport PropTypes from 'prop-types';\nimport { StyleSheet, View, Platform } from 'react-native';\nimport Ico... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Reply by swiping on message
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D110 |
129,183 | 28.09.2020 13:44:31 | -7,200 | 1eae4459100afa0754cd81ac27b19c7b1724fcdb | [native] Prepend reply if not done earlier
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -491,7 +491,11 @@ class ChatInputBar extends React.PureComponent<Props, State> {\n}, 400);\nfocusAndUpdateText = (text: string) => {\n- this.updateText(text);\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prepend reply if not done earlier
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D159 |
129,183 | 29.09.2020 09:08:35 | -7,200 | acc131543460bd6231d89e291a3e8794ad6997fb | [web] Prepend text on reply
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -287,12 +287,17 @@ class ChatInputBar extends React.PureComponent<Props> {\n};\nfocusAndUpdateText = (text: string) => {\n- invariant(this.textarea, 'textarea should... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Prepend text on reply
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D162 |
129,187 | 29.09.2020 15:55:42 | 14,400 | 37a2cdc739c8b7d5fed9a2650e86bc744e1efa07 | [native] Immediately update ChatInputBar when making reply
Summary: This makes the animation look cleaner, and makes sure that the `TextInput` is scrolled to the very bottom when it's focused.
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -182,6 +182,10 @@ class ChatInputBar extends React.PureComponent<Props, State> {\nreturn ChatInputBar.systemKeyboardShowing(this.props);\n}\n+ immediatelyShowS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Immediately update ChatInputBar when making reply
Summary: This makes the animation look cleaner, and makes sure that the `TextInput` is scrolled to the very bottom when it's focused.
Reviewers: KatPo, palys-swm
Reviewed By: KatPo, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://ph... |
129,187 | 29.09.2020 16:52:09 | 14,400 | 135695541826283d3666a5bcfc6ffb5a79ce6964 | [native] Use hooks for data-binding in RelationshipUpdateModal
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-update-modal.react.js",
"new_path": "native/more/relationship-update-modal.react.js",
"diff": "import type { GlobalAccountUserInfo, UserInfo } from 'lib/types/user-types';\nimport type { UserSearchResult } from 'lib/types/search-types'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hooks for data-binding in RelationshipUpdateModal
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D168 |
129,187 | 29.09.2020 16:20:43 | 14,400 | 8a44ed28d3df20a79ec090fe4bec785731c2a6a2 | [web] Scroll to bottom of textarea when setting up a reply
Summary: This is important for replying to larger messages
Reviewers: KatPo, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -287,17 +287,27 @@ class ChatInputBar extends React.PureComponent<Props> {\n};\nfocusAndUpdateText = (text: string) => {\n+ // We need to call focus() first on Safar... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Scroll to bottom of textarea when setting up a reply
Summary: This is important for replying to larger messages
Reviewers: KatPo, palys-swm
Reviewed By: KatPo
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D166 |
129,187 | 30.09.2020 19:18:21 | 14,400 | 31701dbf8447690b0d4c4a8402376a2368d1a2a4 | Add optional_chaining and nullish_coalescing to all .flowconfig
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/.flowconfig",
"new_path": "lib/.flowconfig",
"diff": "[libs]\n[options]\n+esproposal.optional_chaining=enable\n+esproposal.nullish_coalescing=enable\n[lints]\nsketchy-null-number=warn\n"
},
{
"change_type": "MODIFY",
"old_path": "server/.flowco... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add optional_chaining and nullish_coalescing to all .flowconfig
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D171 |
129,191 | 30.09.2020 17:00:33 | -7,200 | fe5dfdf360205fbc6b27e7e102af6641a0de3996 | [server] Remove unused activity update type
Reviewers: ashoat
Subscribers: zrebcu411, KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/activity-types.js",
"new_path": "lib/types/activity-types.js",
"diff": "@@ -4,8 +4,7 @@ import PropTypes from 'prop-types';\nexport type ActivityUpdate =\n| {| focus: true, threadID: string |}\n- | {| focus: false, threadID: string, latestMessage: ?s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Remove unused activity update type
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411, KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D170 |
129,191 | 09.09.2020 16:36:15 | -7,200 | ba2653199f847fe47a57dc8cc21f659e1763d7c3 | [native] Send thread status update to server
Summary: Send a request after clicking a button. Close swipeable after click. Handling the response will be implemented in another diff
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -8,6 +8,7 @@ import type {\nNewThreadResult,\nClientThreadJoinRequest,\nThreadJoinPayload,\n+ SetThreadUnreadStatusResult,\n} from '../types/thread-types';\nimport type { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Send thread status update to server
Summary: Send a request after clicking a button. Close swipeable after click. Handling the response will be implemented in another diff
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D75 |
129,191 | 09.09.2020 16:44:35 | -7,200 | 1c3687c0b824734b27f539270c7b166a181c35e9 | [server] Create new endpoint and update unread status
Summary: Create a new endpoint. Update unread status in db. Sending the response will be implemented in another diff
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/endpoints.js",
"new_path": "server/src/endpoints.js",
"diff": "@@ -42,6 +42,7 @@ import {\nthreadUpdateResponder,\nthreadCreationResponder,\nthreadJoinResponder,\n+ threadSetUnreadStatusResponder,\n} from './responders/thread-responders';\nimport {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create new endpoint and update unread status
Summary: Create a new endpoint. Update unread status in db. Sending the response will be implemented in another diff
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D76 |
129,191 | 10.09.2020 14:11:44 | -7,200 | 914437e860f91363fbef0a5e3bc3b448536f7bce | [server] Send thread status updates response
Summary: Create and return an update
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -27,6 +27,7 @@ import { promiseAll } from 'lib/utils/promises';\nimport { permissionLookup } from 'lib/permissions/thread-permissions';\nimport { filtere... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Send thread status updates response
Summary: Create and return an update
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D80 |
129,191 | 11.09.2020 12:07:00 | -7,200 | 32c8a7578d4e050ca12b987372130299c9b199d4 | [web] Display three dots button
Summary: Add a three dots button to each thread on the threads list
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -14,6 +14,8 @@ import type { DispatchActionPayload } from 'lib/utils/action-utils';\nimport * as React from 'react';\nimport classNames from 'classname... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display three dots button
Summary: Add a three dots button to each thread on the threads list
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D81 |
129,191 | 14.09.2020 12:14:36 | -7,200 | 0c70480eec06d2e2fe8d7972771a9a7309ce6d5d | [web] Show the menu after clicking on button
Summary: Show a menu with temporary buttons. Hide the menu after mouse leaves it
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -29,7 +29,10 @@ type Props = {|\ntimeZone: ?string,\ndispatchActionPayload: DispatchActionPayload,\n|};\n-class ChatThreadListItem extends React.PureCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Show the menu after clicking on button
Summary: Show a menu with temporary buttons. Hide the menu after mouse leaves it
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D94 |
129,191 | 15.09.2020 14:33:29 | -7,200 | 10a3dbd76cd7c743565c28cd09e7d74f0afdfe08 | [server] Check if the latest message has changed
Summary: Before updating the unread status, check if the latest message from the request matches the one from the sever
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -9,6 +9,7 @@ import type {\nClientThreadJoinRequest,\nThreadJoinPayload,\nSetThreadUnreadStatusResult,\n+ SetThreadUnreadStatusRequest,\n} from '../types/thread-types';\ni... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Check if the latest message has changed
Summary: Before updating the unread status, check if the latest message from the request matches the one from the sever
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D129 |
129,191 | 16.09.2020 15:11:37 | -7,200 | 19dc3bb3ea552cf5918fc7f22c6d49cb3f1298db | [native] Update state after click and after successful response
Summary: Update unread status just after clicking the button and when the response from the server arrives
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -8,8 +8,9 @@ import type {\nNewThreadResult,\nClientThreadJoinRequest,\nThreadJoinPayload,\n- SetThreadUnreadStatusResult,\nSetThreadUnreadStatusRequest,\n+ SetThreadUnrea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update state after click and after successful response
Summary: Update unread status just after clicking the button and when the response from the server arrives
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D130 |
129,191 | 18.09.2020 17:54:43 | -7,200 | b31dd9318ab222c078248466ff062326cb81cf33 | [server] Create a function which checks thread permission and membership
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/thread-permission-fetchers.js",
"new_path": "server/src/fetchers/thread-permission-fetchers.js",
"diff": "@@ -29,66 +29,73 @@ async function fetchThreadPermissionsBlob(\nreturn row.permissions;\n}\n-async function checkThreadPermission(\n+f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create a function which checks thread permission and membership
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D139 |
129,191 | 18.09.2020 18:10:29 | -7,200 | 56c3d22b8ab0be7c5c39b82ea79a43c85abddfbe | [web] Display only one button with correct message and fix icon style
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -74,7 +74,7 @@ class ChatThreadListItem extends React.PureComponent<Props, State> {\n</a>\n<div className={css.menu} onMouseLeave={this.hideMenu}>\n<bu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display only one button with correct message and fix icon style
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D140 |
129,191 | 18.09.2020 18:42:04 | -7,200 | d88891ff15fffe7a82de24f5bbb28ea0a13ca5ba | [web] Dispatch thread unread status update
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -4,12 +4,18 @@ import {\ntype ChatThreadItem,\nchatThreadItemPropType,\n} from 'lib/selectors/chat-selectors';\n+import type { Dispatch } from 'lib/typ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Dispatch thread unread status update
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D141 |
129,191 | 30.09.2020 16:36:40 | -7,200 | 1cf189f43757c81af65cab2e6cc9f3cf778a80e2 | [server] Use existing determineUnfocusedThreadsReadStatus function
Summary: Instead of creating a new function, it's possible to use the existing one
Reviewers: ashoat
Subscribers: zrebcu411, KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -190,7 +190,7 @@ async function updateFocusedRows(\n// is no longer the latest message ID.\n// Returns the set of unfocused threads that should be se... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Use existing determineUnfocusedThreadsReadStatus function
Summary: Instead of creating a new function, it's possible to use the existing one
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411, KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D169 |
129,187 | 01.10.2020 22:29:02 | 14,400 | 0ae85889a67e1d4845537d459a5af876d699dcaf | [native] Use hooks for data-binding in ThreadSettingsHomeNotifs
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-home-notifs.react.js",
"new_path": "native/chat/settings/thread-settings-home-notifs.react.js",
"diff": "// @flow\nimport { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n-import type { AppState } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hooks for data-binding in ThreadSettingsHomeNotifs
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D174 |
129,191 | 01.10.2020 15:23:59 | -7,200 | 1707d140ac196a4005815abc0c5f5ea8b82077b5 | [server] Move shouldResetThreadToUnread to activity-updaters
Reviewers: ashoat
Subscribers: zrebcu411, KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/endpoints.js",
"new_path": "server/src/endpoints.js",
"diff": "@@ -8,7 +8,10 @@ import {\nmessageFetchResponder,\nmultimediaMessageCreationResponder,\n} from './responders/message-responders';\n-import { updateActivityResponder } from './responders/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Move shouldResetThreadToUnread to activity-updaters
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411, KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D173 |
129,187 | 02.10.2020 06:46:51 | 14,400 | bff96bbdee8077179a6dc4caa5b94e6fa34023b5 | [native] Use hooks for data-binding in ThreadSettingsPushNotifs
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-push-notifs.react.js",
"new_path": "native/chat/settings/thread-settings-push-notifs.react.js",
"diff": "// @flow\nimport { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n-import type { AppState } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hooks for data-binding in ThreadSettingsPushNotifs
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D175 |
129,187 | 04.10.2020 22:38:52 | 14,400 | 91ad6a478da5e054de3d0be2b54776172c094a15 | [native] Use hooks for data-binding in ThreadSettingsColor
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-color.react.js",
"new_path": "native/chat/settings/thread-settings-color.react.js",
"diff": "import { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\nimport type { LoadingStatus } from 'lib/types/loadi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hooks for data-binding in ThreadSettingsColor
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D177 |
129,187 | 05.10.2020 10:37:52 | 14,400 | c8572bc89315b5fc4d408a70799ba33d5c9b2bc9 | [lib] Ignore errors about failed pings when closing socket
Summary: When you close a socket right now we sometimes get errors about failed ping requests. This diff silences those errors since they don't really matter.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -424,15 +424,27 @@ class Socket extends React.PureComponent<Props, State> {\nif (!message) {\nreturn;\n}\n+\n+ const { inflightRequests } = this.state;\n+ if (!inflightRequests)... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Ignore errors about failed pings when closing socket
Summary: When you close a socket right now we sometimes get errors about failed ping requests. This diff silences those errors since they don't really matter.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Re... |
129,187 | 05.10.2020 14:00:46 | 14,400 | a33889ae4b12ffeedf38bedf320c7608c583aebe | [native] Socket active prop should be false if !dataLoaded
Summary: This makes sure that the socket immediately closes on `LOG_OUT_STARTED`, and that it doesn't try to reopen if the session changes between then and `LOG_OUT_SUCCESS`.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/socket.react.js",
"new_path": "native/socket.react.js",
"diff": "@@ -10,6 +10,7 @@ import {\nuseServerCall,\nuseDispatchActionPromise,\n} from 'lib/utils/action-utils';\n+import { isLoggedIn } from 'lib/selectors/user-selectors';\nimport {\nopenSocketSe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Socket active prop should be false if !dataLoaded
Summary: This makes sure that the socket immediately closes on `LOG_OUT_STARTED`, and that it doesn't try to reopen if the session changes between then and `LOG_OUT_SUCCESS`.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
... |
129,187 | 05.10.2020 23:32:11 | 14,400 | f4482716c552a0ab5c320d64168a6e65cb35ad08 | [native] Don't resize KeyboardAvoidingView when keyboard height changes on Android
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -94,6 +94,17 @@ class InnerKeyboardAvoidingView extends React.PureComponent<Props, State> {\n}\nconst { duration, easing, endCoordi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't resize KeyboardAvoidingView when keyboard height changes on Android
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D186 |
129,187 | 05.10.2020 10:40:50 | 14,400 | dbc4b7da04be99574b3239b0c5c4882c9d6f5882 | [native] Fix expo-splash-screen issue where Android emulator crashes on refrresh
Summary: This fixes an issue where the Android emulator crashes when you refresh while using a debugger.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "patches/expo-splash-screen+0.3.1.patch",
"diff": "+diff --git a/node_modules/expo-splash-screen/android/src/main/java/expo/modules/splashscreen/SplashScreenController.kt b/node_modules/expo-splash-screen/android/src/main/java/expo/modules/splash... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix expo-splash-screen issue where Android emulator crashes on refrresh
Summary: This fixes an issue where the Android emulator crashes when you refresh while using a debugger.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.asho... |
129,187 | 07.10.2020 21:34:35 | 14,400 | a5e66f29b7e2753dff1c610b80dcf2cc93c51fe3 | [lib] Move firstLine from native to lib
Summary: Want to use it on web
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/utils/string-utils.js",
"diff": "+// @flow\n+\n+const newlineRegex = /[\\r\\n]/;\n+function firstLine(text: ?string): string {\n+ if (!text) {\n+ return '';\n+ }\n+ return text.split(newlineRegex, 1)[0];\n+}\n+\n+export { firstLine };\n"
}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Move firstLine from native to lib
Summary: Want to use it on web
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D192 |
129,187 | 07.10.2020 21:40:06 | 14,400 | 371e224f652b5f0bfaec73a46004b043d96bb37b | [web] Only display first line of message in ChatThreadListItem MessagePreview
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-preview.react.js",
"new_path": "web/chat/message-preview.react.js",
"diff": "@@ -16,6 +16,7 @@ import {\nthreadIsTwoPersonChat,\n} from 'lib/shared/thread-utils';\nimport { stringForUser } from 'lib/shared/user-utils';\n+import { firstLine } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Only display first line of message in ChatThreadListItem MessagePreview
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D193 |
129,191 | 06.10.2020 12:57:56 | -7,200 | 8ede7a686509ab42a7e3c73bdb3d3eb9dabb1488 | [server] Do not send local id while updating the focus
Reviewers: ashoat
Subscribers: Adrian, KatPo, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -35,9 +35,9 @@ function ActivityHandler(props: Props) {\nconst prevConnectionStatus = prevConnectionStatusRef.current;\nconst activeThreadLatestMessage = use... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Do not send local id while updating the focus
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, KatPo, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D188 |
129,191 | 08.10.2020 10:49:01 | -7,200 | 3c3162b5acb6cb3fa63cacf8e57d27feb2b4628b | Move unread status related code to activity
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/activity-actions.js",
"new_path": "lib/actions/activity-actions.js",
"diff": "@@ -4,6 +4,9 @@ import type { FetchJSON } from '../utils/fetch-json';\nimport type {\nActivityUpdate,\nActivityUpdateSuccessPayload,\n+ SetThreadUnreadStatusPayload,\n+ S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move unread status related code to activity
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D194 |
129,191 | 08.10.2020 11:59:24 | -7,200 | 5b6b7773914d49e5718f1cd593fd5f0576b4f01a | Always include latest message in requests
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/activity-types.js",
"new_path": "lib/types/activity-types.js",
"diff": "@@ -35,9 +35,11 @@ export type QueueActivityUpdatesPayload = {|\nactivityUpdates: $ReadOnlyArray<ActivityUpdate>,\n|};\n-export type SetThreadUnreadStatusRequest =\n- | {| +unrea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Always include latest message in requests
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D195 |
129,187 | 07.10.2020 22:56:01 | 14,400 | d9f9bd62c88300007064c3113740918bc466d524 | [native] Only render LongPressGestureHandler in GestureTouchableOpacity when we need it
Summary: `LongPressGestureHandler` can interfere with `TapGestureHandler`. Also setting `maxDurationMs` here because on Android it defaults to 500ms. (We weren't noticing because the `LongPressGestureHandler` was set to active after... | [
{
"change_type": "MODIFY",
"old_path": "native/components/gesture-touchable-opacity.react.js",
"new_path": "native/components/gesture-touchable-opacity.react.js",
"diff": "import type { ViewStyle } from '../types/styles';\nimport * as React from 'react';\n+import { StyleSheet } from 'react-native';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only render LongPressGestureHandler in GestureTouchableOpacity when we need it
Summary: `LongPressGestureHandler` can interfere with `TapGestureHandler`. Also setting `maxDurationMs` here because on Android it defaults to 500ms. (We weren't noticing because the `LongPressGestureHandler` was set to active afte... |
129,191 | 09.10.2020 12:21:10 | -7,200 | dc70e8fd62bb86ea4bdf49f9c0a5eba70ffb0ef9 | [lib] Send the most recent non local message
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -40,6 +40,7 @@ export type ChatThreadItem = {|\n+type: 'chatThreadItem',\n+threadInfo: ThreadInfo,\n+mostRecentMessageInfo: ?MessageInfo,\n+ +mostRecentNonLocalMessage... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Send the most recent non local message
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D206 |
129,183 | 08.10.2020 12:32:00 | -7,200 | 71abf82aa6e56416ae95e8e0ec686455670cf2a2 | Handle createSquadbotThread throwing exception
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/bots/app-version-update.js",
"new_path": "server/src/bots/app-version-update.js",
"diff": "@@ -15,6 +15,14 @@ import { createBotViewer } from '../session/bots';\nconst thirtyDays = 30 * 24 * 60 * 60 * 1000;\nconst { squadbot } = bots;\n+async functi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Handle createSquadbotThread throwing exception
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D196 |
129,183 | 06.10.2020 15:01:36 | -7,200 | dcaedc28c913238000a495a3f563ed730afc740c | [native] Display friend and blocked list
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/more-screen.react.js",
"new_path": "native/more/more-screen.react.js",
"diff": "@@ -229,7 +229,7 @@ class MoreScreen extends React.PureComponent<Props> {\n/>\n</View>\n</View>\n- {/* <View style={this.props.styles.slightlyPaddedSection}>\n+ <View s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Display friend and blocked list
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D190 |
129,183 | 09.10.2020 09:27:04 | -7,200 | 60b701582bf2d04393515fbfbf8d011e305438a2 | [server] Create friend relationships between thread members
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/creators/relationship-creators.js",
"diff": "+// @flow\n+\n+import _flow from 'lodash/fp/flow';\n+import _groupBy from 'lodash/fp/groupBy';\n+import _mapValues from 'lodash/fp/mapValues';\n+import _map from 'lodash/fp/map';\n+import _... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Create friend relationships between thread members
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D205 |
129,183 | 01.10.2020 13:17:35 | -7,200 | 93d889b872594ded025594beecd5910457de1995 | [native] Stop listing non-friends and blocked users as option to join thread
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/user-selectors.js",
"new_path": "lib/selectors/user-selectors.js",
"diff": "@@ -12,10 +12,10 @@ import {\ntype RelativeMemberInfo,\nthreadPermissions,\n} from '../types/thread-types';\n+import { userRelationshipStatus } from '../types/relationshi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Stop listing non-friends and blocked users as option to join thread
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D172 |
129,183 | 06.10.2020 14:56:57 | -7,200 | 420c7d625619ec920f7aa7c3cf37f2918da56598 | [server] Don't allow to create/add to thread non friends and blocked users from parent thread
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -7,6 +7,7 @@ import {\nthreadPermissions,\n} from 'lib/types/thread-types';\nimport { messageTypes } from 'lib/types/message-types';\n+import { userRelatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't allow to create/add to thread non friends and blocked users from parent thread
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D189 |
129,187 | 09.10.2020 12:13:04 | 14,400 | 8be98c4deb18bc99e5b83da80da9fb991238f124 | [server] Generate updates for friendship migration
Summary: We need to generate updates to make sure that the `userStore` on clients has our new friendship rows.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/relationship-creators.js",
"new_path": "server/src/creators/relationship-creators.js",
"diff": "// @flow\n+import {\n+ type UndirectedStatus,\n+ undirectedStatus,\n+} from 'lib/types/relationship-types';\n+\nimport _flow from 'lodash/fp/flo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Generate updates for friendship migration
Summary: We need to generate updates to make sure that the `userStore` on clients has our new friendship rows.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D209 |
129,187 | 09.10.2020 12:40:28 | 14,400 | 4d1a2cfb7323dd69d78cb335dad514fcc631898c | [server] Fix return type of updateRelationshipsResponder
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/relationship-responders.js",
"new_path": "server/src/responders/relationship-responders.js",
"diff": "// @flow\n-import type { RelationshipRequest } from 'lib/types/relationship-types';\n-import { relationshipActionsList } from 'lib/types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix return type of updateRelationshipsResponder
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D211 |
129,187 | 09.10.2020 12:40:44 | 14,400 | 0c45ef47e1f53d18dd5723e81ed24a82008e37d9 | [server] Don't add anonymous users to the friend list
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-friend-relationships.js",
"new_path": "server/src/scripts/create-friend-relationships.js",
"diff": "@@ -18,10 +18,11 @@ async function main() {\nasync function createFriendRelationshipsForThreadMembers() {\nconst [result] = await dbQu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't add anonymous users to the friend list
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D212 |
129,187 | 09.10.2020 11:47:41 | 14,400 | 687716be7be2e290d124149344a93ae24012b6c1 | [native] codeVersion -> 68
Had to throw away 67 after uploading an Android build to test if the `targetSdkVersion` would work and then realizing I had a couple bugs I still had to fix. | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 68
Had to throw away 67 after uploading an Android build to test if the `targetSdkVersion` would work and then realizing I had a couple bugs I still had to fix. |
129,187 | 11.10.2020 19:42:16 | 14,400 | c963b3bab4879b5ee2c46de977ac8b1aab6ea32a | [native] Convert ThreadSettings data-binding to hook
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -19,6 +19,7 @@ import PropTypes from 'prop-types';\nimport { View, FlatList } from 'react-native';\nimport invariant from 'invariant';\nimp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert ThreadSettings data-binding to hook
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D221 |
129,187 | 11.10.2020 19:45:53 | 14,400 | 402384fe27f766c62374dfadd2ff7a9020cecb15 | [native] Convert MultimediaModal data-binding to hook
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -5,7 +5,6 @@ import {\nmediaInfoPropType,\ntype Dimensions,\n} from 'lib/types/media-types';\n-import type { AppState } from '../redux/redux-setup';\nimp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert MultimediaModal data-binding to hook
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D215 |
129,187 | 11.10.2020 19:52:20 | 14,400 | 963ded8662788f2ad0444cab06aa48d336c76609 | [native] Convert RelationshipList data-binding to hook
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-list.react.js",
"new_path": "native/more/relationship-list.react.js",
"diff": "@@ -4,25 +4,24 @@ import type { UserInfo } from 'lib/types/user-types';\nimport type { UserRelationships } from 'lib/types/relationship-types';\nimport type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert RelationshipList data-binding to hook
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D216 |
129,187 | 11.10.2020 20:01:03 | 14,400 | 3990e700055011a6209c1f2a5029d9f034e3662e | [native] Convert RelationshipListItem data-binding to hook
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-list-item.react.js",
"new_path": "native/more/relationship-list-item.react.js",
"diff": "// @flow\nimport type { LoadingStatus } from 'lib/types/loading-types';\n-import type { DispatchActionPromise } from 'lib/utils/action-utils';\nim... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert RelationshipListItem data-binding to hook
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D217 |
129,187 | 11.10.2020 20:02:29 | 14,400 | 36320d10a79d61aed635142039dd3bd324c3da33 | [native] Get rid of withOverlayContext
Summary: It's no longer used. Going forward, let's use hooks for data binding.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/overlay-context.js",
"new_path": "native/navigation/overlay-context.js",
"diff": "@@ -41,32 +41,4 @@ const overlayContextPropType = PropTypes.shape({\nsetScrollBlockingModalStatus: PropTypes.func.isRequired,\n});\n-function withOverlayContext... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of withOverlayContext
Summary: It's no longer used. Going forward, let's use hooks for data binding.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D218 |
129,187 | 11.10.2020 21:40:59 | 14,400 | 6c9f2251d1c7c13c9848a0b3b89cfcdf16ac6a12 | [native] Convert PushHandler data-binding to hook
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/push/push-handler.react.js",
"new_path": "native/push/push-handler.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport type { DeviceType } from 'lib/types/device-types';\n-import type {\n- DispatchActionPayload,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Convert PushHandler data-binding to hook
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D219 |
129,187 | 11.10.2020 21:42:47 | 14,400 | 31cbafa97bcabdf9387d025f1fa3206c17449011 | [native] Get rid of withRootContext
Summary: It's no longer used. Going forward, let's use hooks for data binding.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/root-context.js",
"new_path": "native/root-context.js",
"diff": "@@ -10,34 +10,9 @@ export type RootContextType = {|\nconst RootContext = React.createContext<?RootContextType>(null);\n-function withRootContext<\n- AllProps: {},\n- ComponentType: React.C... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Get rid of withRootContext
Summary: It's no longer used. Going forward, let's use hooks for data binding.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D220 |
129,187 | 12.10.2020 12:28:10 | 14,400 | 678adc13e3c7736bada509cdf38bd94d4148051b | [server] Enable --trace-warnings on prod
Summary: I'm seeing a lot of `MaxListenersExceededWarning` in the logs, and would like to understand a bit more about where they're coming from.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"rsync\": \"rsync -rLpmuv --exclude '*/package.json' --exclude '*/node_modules/*' --include '*.json' --include '*.cjs' --exclude '*.*' src/ dist/\",\n\"prod-build\": \"yarn babel-build && yarn ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Enable --trace-warnings on prod
Summary: I'm seeing a lot of `MaxListenersExceededWarning` in the logs, and would like to understand a bit more about where they're coming from.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.asho... |
129,187 | 12.10.2020 20:56:13 | 14,400 | f5e3e52b1b9051af16cc872d4265ff26fb15817a | [server] Get rid of SSR hack for visibilityjs
Summary:
Setting `window = {}` on the server breaks `react-dnd`'s `useIsomorphicLayoutEffect` [hack](https://github.com/react-dnd/react-dnd/blob/64c4060f00c0dd9858a4911086245f1887b5b6f8/packages/core/react-dnd/src/hooks/internal/useIsomorphicLayoutEffect.ts).
Replaced with ... | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -27,7 +27,6 @@ import { mostRecentReadThread } from 'lib/selectors/thread-selectors';\nimport { threadHasPermission } from 'lib/shared/thread-u... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Get rid of SSR hack for visibilityjs
Summary:
Setting `window = {}` on the server breaks `react-dnd`'s `useIsomorphicLayoutEffect` [hack](https://github.com/react-dnd/react-dnd/blob/64c4060f00c0dd9858a4911086245f1887b5b6f8/packages/core/react-dnd/src/hooks/internal/useIsomorphicLayoutEffect.ts).
Replaced wit... |
129,187 | 12.10.2020 21:01:46 | 14,400 | 4e41ca65aed17972e210f2a297986432aed61e2b | [web] Shim visibilityjs on server side
Summary: This lets us avoid setting `window = {}` on the server, which breaks `react-dnd`'s `useIsomorphicLayoutEffect` [hack](https://github.com/react-dnd/react-dnd/blob/64c4060f00c0dd9858a4911086245f1887b5b6f8/packages/core/react-dnd/src/hooks/internal/useIsomorphicLayoutEffect.... | [
{
"change_type": "MODIFY",
"old_path": "web/redux/redux-setup.js",
"new_path": "web/redux/redux-setup.js",
"diff": "@@ -15,7 +15,6 @@ import type { ClientReportCreationRequest } from 'lib/types/report-types';\nimport PropTypes from 'prop-types';\nimport invariant from 'invariant';\n-import Visibilit... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Shim visibilityjs on server side
Summary: This lets us avoid setting `window = {}` on the server, which breaks `react-dnd`'s `useIsomorphicLayoutEffect` [hack](https://github.com/react-dnd/react-dnd/blob/64c4060f00c0dd9858a4911086245f1887b5b6f8/packages/core/react-dnd/src/hooks/internal/useIsomorphicLayoutEffect... |
129,187 | 12.10.2020 20:19:40 | 14,400 | 33000e82671ed5ea8ed806c4115b8e0db6a77abb | [server] Introduce DatabaseMonitor
Summary: This adds some logging for database performance issues
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/database/database.js",
"new_path": "server/src/database/database.js",
"diff": "@@ -6,11 +6,14 @@ import SQL from 'sql-template-strings';\nimport dbConfig from '../../secrets/db_config';\nimport { getScriptContext } from '../scripts/script-context';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Introduce DatabaseMonitor
Summary: This adds some logging for database performance issues
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D229 |
129,187 | 12.10.2020 22:43:21 | 14,400 | 46421050a541a1f4b054de1e6dc6461518390ced | [server] QueryMonitor.reportLaggingQuery
Summary: Add some logging for MySQL queries that take a while to complete
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/database/consts.js",
"diff": "+// @flow\n+\n+export const connectionLimit = 10;\n+export const queryWarnTime = 3000; // in ms\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/database/database.js",
"new_path": ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] QueryMonitor.reportLaggingQuery
Summary: Add some logging for MySQL queries that take a while to complete
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D230 |
129,187 | 13.10.2020 09:00:21 | 14,400 | c1e3bfbb222549517e9edb6303bb631eb9d9bf1e | [server] Update to Node 14.13.1
Summary: Node 14.13 [introduces support](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2020-09-29-version-14130-current-mylesborins) for named exports from CJS! This lets us remove a whole bunch of hacks.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Ad... | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "import { queueActivityUpdatesActionType } from '../types/activity-types';\nimport * as React from 'react';\n-import * as ReactRedux from 'react-redux';\n+import... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update to Node 14.13.1
Summary: Node 14.13 [introduces support](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V14.md#2020-09-29-version-14130-current-mylesborins) for named exports from CJS! This lets us remove a whole bunch of hacks.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscr... |
129,187 | 13.10.2020 09:29:34 | 14,400 | eff0a2f570c6f8c700b701228b72fbb6220a417c | [web] Fix entry names in webpack.config.js
Summary: I broke this in D227. These names matter specifically for the `assets.json` file which is only used on prod. (That's why I didn't notice it while testing initially.)
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/webpack.config.cjs",
"new_path": "web/webpack.config.cjs",
"diff": "@@ -61,7 +61,9 @@ const imageRule = {\nconst baseBrowserConfig = {\nname: 'browser',\n- entry: [ './script.js' ],\n+ entry: {\n+ browser: [ './script.js' ],\n+ },\noutput: {\nfilename: 'pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix entry names in webpack.config.js
Summary: I broke this in D227. These names matter specifically for the `assets.json` file which is only used on prod. (That's why I didn't notice it while testing initially.)
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Re... |
129,191 | 07.10.2020 11:50:10 | -7,200 | 6f94285cb4c07523a03c955c52a53c72b6e4ecec | [server] Save last read message
Summary:
Save the last message from activity update. The idea was to make the change insignificant for older clients.
Initialy, I had couple of commits, but decided to squash them together info one diff.
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/activity-handler.react.js",
"new_path": "lib/socket/activity-handler.react.js",
"diff": "@@ -69,6 +69,7 @@ function ActivityHandler(props: Props) {\nactivityUpdates.push({\nfocus: true,\nthreadID: activeThread,\n+ latestMessage: activeThreadLatestMe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Save last read message
Summary:
Save the last message from activity update. The idea was to make the change insignificant for older clients.
Initialy, I had couple of commits, but decided to squash them together info one diff.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Dif... |
129,191 | 09.10.2020 13:13:54 | -7,200 | 70c4a8129e4e89496700da8aa9738d602278e0df | [server] Improve SQL queries formatting
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -277,10 +277,12 @@ async function updateLastReadMessage(\nconst query = SQL`\nUPDATE memberships\n- SET last_read_message = GREATEST(last_read_messag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Improve SQL queries formatting
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D207 |
129,191 | 09.10.2020 13:37:36 | -7,200 | e31c847ec42bae08b1f70908ca66c2902e974956 | [server] Update last read message during updating unread status
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -346,13 +346,19 @@ async function setThreadUnreadStatus(\n}\nconst resetThreadToUnread = await shouldResetThreadToUnread(viewer, request);\n-\nif (!r... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update last read message during updating unread status
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D208 |
129,191 | 14.10.2020 15:31:46 | -7,200 | 2ce47ecd2082d31474023f904a26c3cbceb91201 | [server] Update last message and last read message when creating a new message
Reviewers: ashoat
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -37,6 +37,39 @@ import { publisher } from '../socket/redis';\nimport { fetchMessageInfoForLocalID } from '../fetchers/message-fetchers';\nimport { creati... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update last message and last read message when creating a new message
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D238 |
129,187 | 16.10.2020 11:28:43 | 14,400 | fade2581aa3d9020f54f88aa12782579733159c6 | [web] Style modal form footer using flexbox
Summary: This handles overflow and vertical positioning much better.
Test Plan: I made sure the modals looked good on the website
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/forgot-password-modal.react.js",
"new_path": "web/modals/account/forgot-password-modal.react.js",
"diff": "@@ -70,17 +70,15 @@ class ForgotPasswordModal extends React.PureComponent<Props, State> {\n</div>\n</div>\n<div className={css['form-f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Style modal form footer using flexbox
Summary: This handles overflow and vertical positioning much better.
Test Plan: I made sure the modals looked good on the website
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D250 |
129,187 | 15.10.2020 19:51:39 | 14,400 | fe73077c7ac88f1213cb80f3968913bb710323ba | [lib] Restrict valid usernames
Summary: They must now be at least six characters long, and cannot begin with a special character.
Test Plan: I tested the RegEx in a JavaScript REPL
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/account-utils.js",
"new_path": "lib/shared/account-utils.js",
"diff": "@@ -10,7 +10,8 @@ import {\nsocketAuthErrorResolutionAttempt,\n} from '../actions/user-actions';\n-const validUsernameRegex = /^[a-zA-Z0-9-_]+$/;\n+const validUsernameRegex = /^[... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Restrict valid usernames
Summary: They must now be at least six characters long, and cannot begin with a special character.
Test Plan: I tested the RegEx in a JavaScript REPL
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.c... |
129,187 | 15.10.2020 20:44:40 | 14,400 | b340c0bf60c3a930c89aded7ffeced803061258b | [server] Ignore notif settings if a user is
Summary: This way somebody can make sure somebody else gets a notif.
Test Plan: I tested the RegEx logic extensively in a JavaScript REPL
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -28,6 +28,7 @@ import {\nthreadInfoFromRawThreadInfo,\n} from 'lib/shared/thread-utils';\nimport { promiseAll } from 'lib/utils/promises';\n+import { oldValidUsernameRegex } from 'lib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Ignore notif settings if a user is @mentioned
Summary: This way somebody can make sure somebody else gets a notif.
Test Plan: I tested the RegEx logic extensively in a JavaScript REPL
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabrica... |
129,183 | 19.10.2020 14:40:21 | -7,200 | 739eb7cb0ce3f7e006aed5d31e5acec17f399e95 | [native] Sort friend list
Summary: Display friend list items in this order: not accepted yet, request sent, friends
Test Plan: Opened friend list and checked if order is correct
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/relationship-selectors.js",
"new_path": "lib/selectors/relationship-selectors.js",
"diff": "@@ -8,31 +8,37 @@ import {\n} from '../types/relationship-types';\nimport { createSelector } from 'reselect';\n+import _orderBy from 'lodash/fp/orderBy';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Sort friend list
Summary: Display friend list items in this order: not accepted yet, request sent, friends
Test Plan: Opened friend list and checked if order is correct
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D2... |
129,191 | 12.10.2020 13:39:03 | -7,200 | 5caa46ba8e0a3b6d6fe7241373e36c115b1c0af3 | [server] Compute unread status based on last read message
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/thread-fetchers.js",
"new_path": "server/src/fetchers/thread-fetchers.js",
"diff": "@@ -21,7 +21,8 @@ async function fetchServerThreadInfos(\nSELECT t.id, t.name, t.parent_thread_id, t.color, t.description,\nt.type, t.creation_time, t.defau... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Compute unread status based on last read message
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D222 |
129,191 | 15.10.2020 12:54:24 | -7,200 | 2458e0ed63aea2680194a2a2a063e0f592c4475d | [server] Do not update unread column
Summary: Remove updating of unread column. Send updates based on latestMessages.
Reviewers: ashoat
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/message-creator.js",
"new_path": "server/src/creators/message-creator.js",
"diff": "@@ -298,37 +298,26 @@ async function postMessageSend(\n}\nconst pushInfo = {};\n- const setUnreadPairs = [];\nconst messageInfosPerUser = {};\nconst latestM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Do not update unread column
Summary: Remove updating of unread column. Send updates based on latestMessages.
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D239 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.