author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 06.08.2020 17:57:58 | 14,400 | 56edfcf6be7384d94c64fe8307d73a5a8efe5ae8 | [server] Don't return threadInfo[s] from thread responders | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -262,8 +262,8 @@ export type RoleChangeRequest = {|\n|};\nexport type ChangeThreadSettingsResult = {|\n- threadInfo: RawThreadInfo,\n- threadInfos: { [id: string]: RawThreadInfo }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't return threadInfo[s] from thread responders |
129,187 | 06.08.2020 18:15:25 | 14,400 | 661f681ba859dd35069da5a7fc5e06a2e27a7bf6 | Only return newThreadID instead of newThreadInfo on create_thread | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/thread-actions.js",
"new_path": "lib/actions/thread-actions.js",
"diff": "@@ -110,7 +110,7 @@ async function newThread(\n): Promise<NewThreadResult> {\nconst response = await fetchJSON('create_thread', request);\nreturn {\n- newThreadInfo: response... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Only return newThreadID instead of newThreadInfo on create_thread |
129,187 | 06.08.2020 18:17:04 | 14,400 | 1b524322c50c6b1a0edaf1474d1322d934bf4e00 | [native] codeVersion -> 62
Probably won't actually release this one. I'm just bumping the `codeVersion` so the previous commit works as intended. Otherwise the server will think the client is an old v61 client and not return `newThreadID`, which will confuse the new client. | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 62
Probably won't actually release this one. I'm just bumping the `codeVersion` so the previous commit works as intended. Otherwise the server will think the client is an old v61 client and not return `newThreadID`, which will confuse the new client. |
129,187 | 07.08.2020 12:27:30 | 14,400 | d4fd188c7732ed22caaab09f1e32d72444c3e51b | [lib] Pass whole capture object to SharedMarkdown.jsonPrint | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "@@ -17,7 +17,11 @@ const blockQuoteStripFollowingNewlineRegex = /^( *>[^\\n]+(?:\\n[^\\n]+)*)(?:\\n|$){\nconst urlRegex = /^(https?:\\/\\/[^\\s<]+[^<.,:;\"')\\]\\s])/i;\n-function jsonMatc... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Pass whole capture object to SharedMarkdown.jsonPrint |
129,187 | 07.08.2020 12:33:07 | 14,400 | b3d1c20b730885938c5d786fe982a95107ed7c91 | Adjust margin for Markdown blockQuote and codeBlock | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/styles.js",
"new_path": "native/markdown/styles.js",
"diff": "@@ -65,12 +65,13 @@ const unboundStyles = {\nborderLeftWidth: 5,\npadding: 10,\nmarginBottom: 6,\n+ marginVertical: 6,\n},\ncodeBlock: {\nbackgroundColor: 'codeBackground',\npadding:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Adjust margin for Markdown blockQuote and codeBlock |
129,187 | 07.08.2020 15:32:06 | 14,400 | 908634e92b1035cf477e1d2c9631e262a220f593 | [native] Introduce and fix wipeAndExit | [
{
"change_type": "MODIFY",
"old_path": "native/crash.react.js",
"new_path": "native/crash.react.js",
"diff": "@@ -39,7 +39,8 @@ import { sanitizeAction, sanitizeState } from 'lib/utils/sanitization';\nimport { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\nimport Button from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce and fix wipeAndExit |
129,187 | 07.08.2020 15:38:50 | 14,400 | 2f71e3bd45b95f53ea4ce1481af80e984df92648 | [native] codeVersion -> 63 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 63 |
129,187 | 10.08.2020 10:38:45 | 14,400 | 30a850d7bc9e00782213720cf33cb276ecbcab52 | [native] Move DisconnectedBar back to react-native-reanimated
Reanimated let us drive the animation from the native thread, increasing frame rate.
We previously couldn't use it because of
But that's fixed now! | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar.react.js",
"new_path": "native/navigation/disconnected-bar.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, StyleSheet, Platform, Animated, Easing } from 'react-native';\n+import { Text, StyleShe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move DisconnectedBar back to react-native-reanimated
Reanimated let us drive the animation from the native thread, increasing frame rate.
We previously couldn't use it because of https://github.com/software-mansion/react-native-reanimated/issues/857
But that's fixed now! |
129,187 | 11.08.2020 15:25:45 | 14,400 | c286c698c7cc889c1d0d4a9102009b67e8f6bf5b | Don't double-report beforeAction in inconsistency reports | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/entry-reducer.js",
"new_path": "lib/reducers/entry-reducer.js",
"diff": "@@ -605,7 +605,6 @@ function reduceEntryInfos(\n}\nconst newInconsistencies = findInconsistencies(\n- entryInfos,\naction,\nentryInfos,\nupdatedEntryInfos,\n@@ -650,42 +649,3... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Don't double-report beforeAction in inconsistency reports |
129,187 | 11.08.2020 15:29:32 | 14,400 | 4220f2cd370620319a6c9f5f817b45affbffd230 | [native] Clear Search input on log out | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "@@ -9,6 +9,7 @@ import { View, ViewPropTypes, TouchableOpacity, TextInput } from 'react-native';\nimport Icon from 'react-native-vector-icons/FontAwesome';\nimport { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clear Search input on log out |
129,187 | 11.08.2020 15:51:24 | 14,400 | d78c46659c2b0a8bc719d0a1a61fd821f277e7c9 | [native] Use updated threadInfo ASAP | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-container.react.js",
"new_path": "native/chat/message-list-container.react.js",
"diff": "@@ -82,6 +82,10 @@ class MessageListContainer extends React.PureComponent<Props, State> {\n};\nstatic getThreadInfo(props: Props): ThreadInfo {\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use updated threadInfo ASAP |
129,187 | 12.08.2020 23:05:40 | 14,400 | 102cc15a721cb55da4c6d448be8ebafc3ffa7d47 | [server] Don't UPDATE threadType in recalculateAllPermissions
We already set this correctly at both callsites | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -355,16 +355,10 @@ async function updateDescendantPermissions(\nreturn { membershipRows, relationshipRows };\n}\n-// Unlike changeR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Don't UPDATE threadType in recalculateAllPermissions
We already set this correctly at both callsites |
129,187 | 12.08.2020 23:10:51 | 14,400 | 9e1a3be7093281235c5126d25ca065ee36c709ca | [server] Set different role permissions for threadTypes.SIDEBAR | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/role-creator.js",
"new_path": "server/src/creators/role-creator.js",
"diff": "@@ -5,6 +5,8 @@ import {\nthreadPermissions,\nthreadPermissionPrefixes,\ntype ThreadRolePermissionsBlob,\n+ type ThreadType,\n+ threadTypes,\n} from 'lib/types/th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set different role permissions for threadTypes.SIDEBAR |
129,187 | 12.08.2020 23:27:01 | 14,400 | 3997317ce75af64d23cbb680af91921fcc034e0e | [server] Key RolePermissionBlobs by role name | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/role-creator.js",
"new_path": "server/src/creators/role-creator.js",
"diff": "@@ -20,34 +20,19 @@ async function createInitialRolesForNewThread(\nthreadID: string,\nthreadType: ThreadType,\n): Promise<InitialRoles> {\n- const {\n- defaultPe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Key RolePermissionBlobs by role name |
129,187 | 13.08.2020 00:18:02 | 14,400 | 05d4a4e7e76f6aafe8894aa6b641eb73b08b31c8 | [server] updateRoles | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "server/src/fetchers/role-fetchers.js",
"diff": "+// @flow\n+\n+import type { RoleInfo } from 'lib/types/thread-types';\n+\n+import { dbQuery, SQL } from '../database';\n+\n+async function fetchRoles(threadID: string): Promise<RoleInfo[]> {\n+ co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] updateRoles |
129,187 | 13.08.2020 10:37:16 | 14,400 | 1ccad9998dba6b0113e696417d8b0c0c074a7897 | [server] Fix permission recalculation in updateThread | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -453,8 +453,10 @@ async function updateThread(\nnextParentThreadID !== oldParentThreadID\n) {\nintermediatePromises.recalculatePermissionsChangeset = (as... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix permission recalculation in updateThread |
129,187 | 15.08.2020 19:27:33 | 14,400 | 24047d7e0a27358c6a4787a244b4ecdb19d79ad2 | [server] Fix case where empty array passed to fetchKnownUserInfos throws exception
It results in a SQL error around `IN ()` | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/user-fetchers.js",
"new_path": "server/src/fetchers/user-fetchers.js",
"diff": "@@ -48,6 +48,9 @@ async function fetchKnownUserInfos(\nif (!viewer.loggedIn) {\nthrow new ServerError('not_logged_in');\n}\n+ if (userIDs && userIDs.length === ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fix case where empty array passed to fetchKnownUserInfos throws exception
It results in a SQL error around `IN ()` |
129,187 | 15.08.2020 19:33:20 | 14,400 | 7a9207f73c8db056ffc0ba380c18a00450b6d40a | [server] Still include newThreadInfo for create_thread
Forgot to remove one callsite | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -206,7 +206,7 @@ async function createThread(\n]);\nconst { threadInfos, viewerUpdates } = commitResult;\n- if (hasMinCodeVersion(viewer.platformDetails, 6... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Still include newThreadInfo for create_thread
Forgot to remove one callsite |
129,187 | 15.08.2020 19:39:21 | 14,400 | 2612dc72c26039301ce262aae3d6590874729c7e | [native] Don't expect RawThreadInfo in result from create_thread | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-thread.react.js",
"new_path": "native/chat/compose-thread.react.js",
"diff": "@@ -15,8 +15,6 @@ import {\nimport {\ntype AccountUserInfo,\naccountUserInfoPropType,\n- type UserInfo,\n- userInfoPropType,\n} from 'lib/types/user-types';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Don't expect RawThreadInfo in result from create_thread |
129,187 | 16.08.2020 11:10:20 | 14,400 | 13a1789a3b1914269aa73561f4a5d4503e79fa4b | [native] codeVersion -> 64 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 64 |
129,187 | 17.08.2020 10:33:21 | 14,400 | f91b9ce1eac575a2cfb536fcc34d9edab70a493a | [native] Set dark-content StatusBar in Crash component | [
{
"change_type": "MODIFY",
"old_path": "native/crash.react.js",
"new_path": "native/crash.react.js",
"diff": "@@ -41,6 +41,7 @@ import { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\nimport Button from './components/button.react';\nimport { persistConfig, codeVersion } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set dark-content StatusBar in Crash component |
129,187 | 18.08.2020 17:44:02 | 14,400 | ae2bc5fa8503f5bf550b695140035a82f6e5a0c6 | [web] Introduce FocusHandler
Makes sure to only consider a browser window to be in foreground if it's both focused according to `window.onfocus` and visible according to the Visibility API | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -12,7 +12,6 @@ import * as React from 'react';\nimport invariant from 'invariant';\nimport _isEqual from 'lodash/fp/isEqual';\nimport PropTypes from 'prop-types';\n-import Visibility from 'visibili... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce FocusHandler
Makes sure to only consider a browser window to be in foreground if it's both focused according to `window.onfocus` and visible according to the Visibility API |
129,187 | 18.08.2020 17:59:33 | 14,400 | 70422c57e74896e8193739c4695265d731859dab | [web] Wait 2 seconds before confirming foreground event | [
{
"change_type": "MODIFY",
"old_path": "web/focus-handler.react.js",
"new_path": "web/focus-handler.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { useDispatch } from 'react-redux';\n+import { useDispatch, useSelector } from 'react-redux';\nimport Visibility from 'visibility... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Wait 2 seconds before confirming foreground event |
129,187 | 19.08.2020 09:04:49 | 14,400 | e40a678d07481b43f8babc0a6c4f382ce52d9842 | [lib] Get rid of FETCH_ENTRIES_AND_APPEND_RANGE actions
Forgot to remove this in | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -16,7 +16,6 @@ import type {\nDeleteEntryResponse,\nRestoreEntryPayload,\nFetchEntryInfosResult,\n- CalendarResult,\nCalendarQueryUpdateResult,\nCalendarQueryUpdateStartingPayload,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Get rid of FETCH_ENTRIES_AND_APPEND_RANGE actions
Forgot to remove this in 005768511daeb30f4750ccd4f8a2dd52bd1bdafc |
129,187 | 19.08.2020 13:20:52 | 14,400 | 9494675541b2e6a8ac91635c1683f7489cb67464 | [server] Return void from sendPushNotifs | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/send.js",
"new_path": "server/src/push/send.js",
"diff": "@@ -60,7 +60,7 @@ export type PushInfo = { [userID: string]: PushUserInfo };\nasync function sendPushNotifs(pushInfo: PushInfo) {\nif (Object.keys(pushInfo).length === 0) {\n- return [];... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Return void from sendPushNotifs |
129,187 | 19.08.2020 13:49:58 | 14,400 | 8a930f24c2be8ce4855b72148c04f153b2abbfda | [web] Separate visibility and focus logic
We'll start the socket if the window is visible, but we'll only consider a thread active if the window is focused as well | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -291,6 +291,7 @@ async function websiteResponder(\ncookie: undefined,\ndeviceToken: undefined,\ndataLoaded: viewer.loggedIn,\n+ windowActive: t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Separate visibility and focus logic
We'll start the socket if the window is visible, but we'll only consider a thread active if the window is focused as well |
129,187 | 19.08.2020 14:33:59 | 14,400 | e432acfb559ad3b77d4f50705e6ff3075442b918 | [web] Limit image size | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -233,7 +233,7 @@ div.messageBox {\ndisplay: flex;\nflex-wrap: wrap;\njustify-content: space-between;\n- max-width: 68%;\n+ max-width: calc(min(68%, 1000px));\n}\ndiv.fix... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Limit image size |
129,187 | 19.08.2020 15:58:13 | 14,400 | 26396a19b726b1110d2f35d5cf978e8428a337c3 | [native] Clean up legacy custom_notification code | [
{
"change_type": "MODIFY",
"old_path": "native/push/android.js",
"new_path": "native/push/android.js",
"diff": "@@ -32,25 +32,12 @@ function handleAndroidMessage(\nfirebase.notifications().setBadge(parseInt(badge, 10));\n}\n- const customNotification = data.custom_notification\n- ? JSON.parse(data.c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clean up legacy custom_notification code |
129,187 | 19.08.2020 17:58:40 | 14,400 | a8ab8071e139f99e3618187af085b3737774c6d5 | [server] Rescind push notifs when somebody leaves a thread | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-permission-updaters.js",
"new_path": "server/src/updaters/thread-permission-updaters.js",
"diff": "@@ -37,6 +37,7 @@ import {\nupdateDatasForUserPairs,\nupdateUndirectedRelationships,\n} from '../updaters/relationship-updaters';\n+im... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rescind push notifs when somebody leaves a thread |
129,187 | 19.08.2020 18:00:35 | 14,400 | 1950ecef3b9fc8953b5325e9294c6933a94a4e74 | [server] Rescind all notifs when somebody deletes their account | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/account-deleters.js",
"new_path": "server/src/deleters/account-deleters.js",
"diff": "@@ -17,6 +17,7 @@ import { createNewAnonymousCookie } from '../session/cookies';\nimport { fetchAllUserIDs } from '../fetchers/user-fetchers';\nimport { c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Rescind all notifs when somebody deletes their account |
129,187 | 19.08.2020 18:28:41 | 14,400 | 46201365f388fc221a3ecd3ad865a42e1359dd25 | [server] Log notifs rescinds to notifications table | [
{
"change_type": "MODIFY",
"old_path": "server/src/push/rescind.js",
"new_path": "server/src/push/rescind.js",
"diff": "@@ -4,9 +4,13 @@ import { threadPermissions } from 'lib/types/thread-types';\nimport { threadSubscriptions } from 'lib/types/subscription-types';\nimport apn from 'apn';\n+import i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Log notifs rescinds to notifications table |
129,187 | 19.08.2020 18:43:07 | 14,400 | 3f2bfe1db921e6305860dd9d85ad9d5f870992b5 | [native] Clear all notifs on log out | [
{
"change_type": "MODIFY",
"old_path": "native/push/push-handler.react.js",
"new_path": "native/push/push-handler.react.js",
"diff": "@@ -281,6 +281,10 @@ class PushHandler extends React.PureComponent<Props, State> {\nthis.ensurePushNotifsEnabled();\n}\n+ if (!this.props.loggedIn && prevProps.logged... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Clear all notifs on log out |
129,183 | 24.08.2020 14:33:36 | -7,200 | 0c68f9e056b644d574ef148d2a731e3f8233145b | [web] Add list to markdown in web
Reviewers: ashoat
Subscribers: zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.js",
"new_path": "lib/shared/markdown.js",
"diff": "// @flow\n+// simple-markdown types\n+type State = {|\n+ key?: string | number | void,\n+ inline?: ?boolean,\n+ [string]: any,\n+|};\n+\n+type Parser = (source: string, state?: ?State) => ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add list to markdown in web
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411
Differential Revision: https://phabricator.ashoat.com/D10 |
129,183 | 24.08.2020 14:36:20 | -7,200 | 8b9a34c5959ce9939d37bbe8d3dfe54158d7cef2 | [native] Add list to markdown in native
Reviewers: ashoat
Subscribers: zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/rules.react.js",
"new_path": "native/markdown/rules.react.js",
"diff": "@@ -305,6 +305,32 @@ function fullMarkdownRules(\ncontent: SharedMarkdown.jsonPrint(capture),\n}),\n},\n+ list: {\n+ ...SimpleMarkdown.defaultRules.list,\n+ match: SharedMa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add list to markdown in native
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411
Differential Revision: https://phabricator.ashoat.com/D11 |
129,187 | 24.08.2020 12:32:46 | 14,400 | d3385e8640d4bbcf2222b6e484103e609e40316f | [server] Only update memberships with role > 0 when creating/deleting roles
Reviewers: zrebcu411
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/role-updaters.js",
"new_path": "server/src/updaters/role-updaters.js",
"diff": "@@ -43,7 +43,7 @@ async function updateRoles(\nconst setAdminQuery = SQL`\nUPDATE memberships\nSET role = ${id}\n- WHERE thread = ${threadID} AND user = ${viewe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Only update memberships with role > 0 when creating/deleting roles
Reviewers: zrebcu411
Reviewed By: zrebcu411
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D22 |
129,186 | 11.08.2020 16:27:52 | -7,200 | c7e164f6e88f1ee3cacb2c15d87d06ad8ecafeeb | [server] Handle users who have left a thread
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/thread-deleters.js",
"new_path": "server/src/deleters/thread-deleters.js",
"diff": "@@ -140,10 +140,11 @@ async function deleteInaccessibleThreads(): Promise<void> {\n// that membership rows exist whenever a user can see a thread, even if t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Handle users who have left a thread
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D12 |
129,186 | 11.08.2020 16:36:07 | -7,200 | 2edc85c852f6128d09b188a7b50081d9724cf6ec | [server] Update state sync
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -66,7 +66,10 @@ import {\n} from '../fetchers/message-fetchers';\nimport { fetchThreadInfos } from '../fetchers/thread-fetchers';\nimport { fetchEntryInfos } from '../fetchers... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update state sync
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D13 |
129,186 | 11.08.2020 16:44:10 | -7,200 | ac284eb442c7fb64c8a63e8d637b859e8e4af7b7 | [server] Update updateInfosFromRawUpdateInfos
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -31,9 +31,6 @@ import _uniq from 'lodash/fp/uniq';\nimport _intersection from 'lodash/fp/intersection';\nimport { promiseAll } from 'lib/utils/promises';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update updateInfosFromRawUpdateInfos
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D14 |
129,186 | 12.08.2020 09:39:28 | -7,200 | 52be307702650e38580febdcae010e0c7fb8b6ad | [server] Update MessagesServerSocketMessage
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -777,9 +777,8 @@ export type SaveMessagesPayload = {|\nupdatesCurrentAsOf: number,\n|};\n-export type MessagesResultWithUserInfos = {|\n+export type NewMessagesPayload = {|\nmes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update MessagesServerSocketMessage
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D15 |
129,186 | 13.08.2020 12:48:30 | -7,200 | fc1607a2691a0c48272e53960f77bb48191f6c07 | Clean up actions/responders that currently deliver userInfos
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/entry-actions.js",
"new_path": "lib/actions/entry-actions.js",
"diff": "@@ -18,7 +18,6 @@ import type { FetchJSON } from '../utils/fetch-json';\nimport type { HistoryRevisionInfo } from '../types/history-types';\nimport { dateFromString } from '../... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clean up actions/responders that currently deliver userInfos
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D16 |
129,186 | 13.08.2020 12:56:12 | -7,200 | 570063e4533af478845e064b68c5d412c3aded12 | Clean up entry logic that currently delivers userInfos
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/user-reducer.js",
"new_path": "lib/reducers/user-reducer.js",
"diff": "@@ -21,12 +21,6 @@ import _keyBy from 'lodash/fp/keyBy';\nimport _isEqual from 'lodash/fp/isEqual';\nimport { setNewSessionActionType } from '../utils/action-utils';\n-import {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Clean up entry logic that currently delivers userInfos
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D17 |
129,186 | 13.08.2020 13:12:41 | -7,200 | cde17ce0ace0e502d12dba8ee4bd53a78a269bc5 | [server] Update createAccountDeletionUpdates
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/deleters/account-deleters.js",
"new_path": "server/src/deleters/account-deleters.js",
"diff": "@@ -5,16 +5,18 @@ import type {\nDeleteAccountRequest,\n} from 'lib/types/account-types';\nimport type { Viewer } from '../session/viewer';\n+import type ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Update createAccountDeletionUpdates
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D18 |
129,186 | 24.08.2020 16:19:04 | -7,200 | be068a050759c46397f3adbc8213e393c5cf46ae | Handle -1 roles in queries, update create relationships script
Reviewers: ashoat
Subscribers: KatPo | [
{
"change_type": "MODIFY",
"old_path": "server/src/bots/app-version-update.js",
"new_path": "server/src/bots/app-version-update.js",
"diff": "@@ -40,11 +40,11 @@ async function botherMonthlyActivesToUpdateAppVersion(): Promise<void> {\nSELECT t.id, m1.user, COUNT(m3.user) AS user_count\nFROM threads... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Handle -1 roles in queries, update create relationships script
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: KatPo
Differential Revision: https://phabricator.ashoat.com/D21 |
129,183 | 28.08.2020 09:09:39 | -7,200 | 8dece4da73f81f7987ab4ce8142d12023e6ae0d4 | [native] Fix nested blockQuotes on native
Reviewers: ashoat
Subscribers: zrebcu411, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/markdown/rules.react.js",
"new_path": "native/markdown/rules.react.js",
"diff": "@@ -245,7 +245,7 @@ function fullMarkdownRules(\n) {\nconst content = capture[1].replace(/^ *> ?/gm, '');\nreturn {\n- content: SimpleMarkdown.parseInline(parse, content, s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix nested blockQuotes on native
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D26 |
129,187 | 28.08.2020 13:11:21 | 14,400 | d715ce938c46be349651a41660a54f77c37e0b6a | [native] codeVersion -> 65 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -133,8 +133,8 @@ android {\napplicationId \"org.squadcal\"\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 65 |
129,187 | 30.08.2020 08:18:54 | 14,400 | 7b83c53e4341cbab2e4a1f34fe6ad6483ae48f50 | [native] Disable bitcode on iOS debug build
Summary:
Otherwise `react-native@0.62` + `react-native-firebase@5` can't deploy a debug build to a physical device
Context here:
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"new_path": "native/ios/SquadCal.xcodeproj/project.pbxproj",
"diff": "CURRENT_PROJECT_VERSION = 1;\nDEAD_CODE_STRIPPING = NO;\nDEVELOPMENT_TEAM = 6BF4H9TU5U;\n+ ENABLE_BITCODE = NO;\nHEADER_SEARCH_PATHS = (\n\"$(... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Disable bitcode on iOS debug build
Summary:
Otherwise `react-native@0.62` + `react-native-firebase@5` can't deploy a debug build to a physical device
Context here: https://github.com/invertase/react-native-firebase/issues/3384#issuecomment-607831629
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: zrebc... |
129,187 | 29.08.2020 19:37:51 | 14,400 | 15ebf1eeb2ebfb0291fb8a2f6eabff7cc64ecbc3 | [native] Set textContentType on username/password TextInputs
Summary: This lets us integrate better with iOS's native password manager integration
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -128,6 +128,7 @@ class LogInPanel extends React.PureComponent<Props> {\nautoCorrect={false}\nautoCapitalize=\"none\"\nkeyboardType=\"ascii-capable\"\n+ textC... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set textContentType on username/password TextInputs
Summary: This lets us integrate better with iOS's native password manager integration
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D29 |
129,187 | 31.08.2020 11:15:12 | 14,400 | 8726e7c3d10d2ccf2adf116fef21ab6933a484e7 | [native] Move LoggedOutModal buttonOpacity to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -32,6 +32,9 @@ import OnePassword from 'react-native-onepassword';\nimport PropTypes from 'prop-types';\nimport _isEqual from 'lodash/fp/isEqual';\ni... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move LoggedOutModal buttonOpacity to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D31 |
129,187 | 31.08.2020 16:00:15 | 14,400 | 44c1b78ba741415fea8786489c30a86b06d4438c | [native] Extract runTiming
Summary: I also made the animation config an optional parameter
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/media/multimedia-modal.react.js",
"new_path": "native/media/multimedia-modal.react.js",
"diff": "@@ -38,7 +38,7 @@ import {\nState as GestureState,\n} from 'react-native-gesture-handler';\nimport Orientation from 'react-native-orientation-locker';\n-imp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract runTiming
Summary: I also made the animation config an optional parameter
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D32 |
129,187 | 31.08.2020 16:07:51 | 14,400 | 6aa8c7f8768300ace9e6b90049d3aef5e282ca94 | [native] Move LoggedOutModal panelPaddingTop to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -67,6 +67,7 @@ import {\ntype NavContextType,\nnavContextPropType,\n} from '../navigation/navigation-context';\n+import { runTiming } from '../utils/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move LoggedOutModal panelPaddingTop to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D33 |
129,187 | 31.08.2020 18:51:46 | 14,400 | 65ca8a644aa0e08e3134b18ac54f095a5efe4f98 | [native] Move LoggedOutModal footerPaddingTop to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -116,7 +116,6 @@ type Props = {\n};\ntype State = {\nmode: LoggedOutMode,\n- footerPaddingTop: Animated.Value,\npanelOpacity: Animated.Value,\nforgot... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move LoggedOutModal footerPaddingTop to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D35 |
129,187 | 31.08.2020 21:15:59 | 14,400 | 78f7fbf4581939f8ac9ea8e0f4d486e9f4c6d916 | [native] Move LoggedOutModal panelOpacity to Reanimated
Summary: This one had some dependencies. For now I am having the `Panel` component support both animation libraries, but will simplify once `VerificationModal` is refactored
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/forgot-password-panel.react.js",
"new_path": "native/account/forgot-password-panel.react.js",
"diff": "@@ -5,10 +5,11 @@ import type { LoadingStatus } from 'lib/types/loading-types';\nimport type { DispatchActionPromise } from 'lib/utils/action-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move LoggedOutModal panelOpacity to Reanimated
Summary: This one had some dependencies. For now I am having the `Panel` component support both animation libraries, but will simplify once `VerificationModal` is refactored
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Dif... |
129,187 | 31.08.2020 21:41:44 | 14,400 | f1ca329350180f13d5dc3994c81f56c33fb56395 | [native] Move LoggedOutModal forgotPasswordLinkOpacity to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "@@ -32,7 +32,7 @@ type Props = {|\nonePasswordSupported: boolean,\nsetActiveAlert: (activeAlert: boolean) => void,\nopacityValue: Reanimated... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move LoggedOutModal forgotPasswordLinkOpacity to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D37 |
129,187 | 31.08.2020 23:42:12 | 14,400 | d1c29f31e326939432fbb640d09fa4b751c331c8 | [native] Move VerificationModal paddingTop to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/verification-modal.react.js",
"new_path": "native/account/verification-modal.react.js",
"diff": "@@ -34,6 +34,7 @@ import invariant from 'invariant';\nimport OnePassword from 'react-native-onepassword';\nimport PropTypes from 'prop-types';\nimpo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move VerificationModal paddingTop to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D38 |
129,187 | 31.08.2020 23:55:41 | 14,400 | 3d296b1df24cf22f2a7b64dbd67fa8497bd62a9a | [native] Move VerificationModal resetPasswordPanelOpacity to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/panel-components.react.js",
"new_path": "native/account/panel-components.react.js",
"diff": "@@ -16,14 +16,13 @@ import {\nActivityIndicator,\nText,\nStyleSheet,\n- Animated,\nScrollView,\nLayoutAnimation,\nViewPropTypes,\n} from 'react-native';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move VerificationModal resetPasswordPanelOpacity to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D39 |
129,187 | 01.09.2020 00:25:32 | 14,400 | c6c80dc59ffaa522722a0c8a365b5dea08d14b64 | [native] Move LogInPanelContainer panelTransition to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "@@ -8,38 +8,49 @@ import {\nimport type { AppState } from '../redux/redux-setup';\nimport * as React from 'react';\n-import { View, Animated... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move LogInPanelContainer panelTransition to Reanimated
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D40 |
129,187 | 01.09.2020 01:09:21 | 14,400 | 136d05722c27abbd4ceb2d8c81341ed36bcc019f | [native] Move to
Summary: `Clipboard` has been extracted out of React Native core due to the Lean Core effort
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message-tooltip-modal.react.js",
"new_path": "native/chat/text-message-tooltip-modal.react.js",
"diff": "import type { ChatTextMessageInfoItemWithHeight } from './text-message.react';\n-import { Clipboard } from 'react-native';\n+import Clipbo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move to @react-native-community/clipboard
Summary: `Clipboard` has been extracted out of React Native core due to the Lean Core effort
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian
Differential Revision: https://phabricator.ashoat.com/D42 |
129,187 | 01.09.2020 01:46:57 | 14,400 | 2f30f2233be0742f73be843402fcbc47e2d7ca53 | [native] Only use LayoutAnimation in Panel when rendering ScrollView
Summary: This only happens on small screens, and is the only context in which `LayoutAnimation` is useful here. It can cause weird effects on iOS so let's only use it when necessary
Reviewers: zrebcu411, KatPo, palys-swm
Subscribers: Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/panel-components.react.js",
"new_path": "native/account/panel-components.react.js",
"diff": "@@ -77,6 +77,8 @@ class PanelButton extends React.PureComponent<ButtonProps> {\n}\n}\n+const scrollViewBelow = 568;\n+\ntype PanelProps = {|\nopacityVal... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Only use LayoutAnimation in Panel when rendering ScrollView
Summary: This only happens on small screens, and is the only context in which `LayoutAnimation` is useful here. It can cause weird effects on iOS so let's only use it when necessary
Reviewers: zrebcu411, KatPo, palys-swm
Reviewed By: palys-swm
Sub... |
129,187 | 02.09.2020 11:18:54 | 14,400 | 6144777b18b8ea522fb47527fb3dcec020644060 | [server] Handle logged-out viewer in fetchKnownUserInfos
Summary: This is to fix the web splash screen
Subscribers: KatPo, zrebcu411, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/user-fetchers.js",
"new_path": "server/src/fetchers/user-fetchers.js",
"diff": "@@ -46,7 +46,7 @@ async function fetchKnownUserInfos(\nuserIDs?: $ReadOnlyArray<string>,\n): Promise<UserInfos> {\nif (!viewer.loggedIn) {\n- throw new ServerEr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Handle logged-out viewer in fetchKnownUserInfos
Summary: This is to fix the web splash screen
Subscribers: KatPo, zrebcu411, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D48 |
129,187 | 02.09.2020 12:05:41 | 14,400 | 7cbacbe6f0a0a7343613a6799fbcdb2e8cca2d16 | [native] Use object literals for mapping mode strings to numbers
Summary: See context [here](https://phabricator.ashoat.com/D33?id=118#inline-351)
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel-container.react.js",
"new_path": "native/account/log-in-panel-container.react.js",
"diff": "@@ -22,6 +22,11 @@ import ForgotPasswordPanel from './forgot-password-panel.react';\nimport { runTiming } from '../utils/animation-utils';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use object literals for mapping mode strings to numbers
Summary: See context [here](https://phabricator.ashoat.com/D33?id=118#inline-351)
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D49 |
129,187 | 02.09.2020 14:06:35 | 14,400 | 613439e13237409da4f3c250ce16314046510965 | [native] Start forgotPasswordLinkOpacity at 0
Summary: This Reanimated node only gets processed for the first time when `LogInPanel` displays, at which point the `targetForgotPasswordLinkOpacity` is already 1. We want it to start at 0 and animate to 1
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -493,17 +493,10 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\nnot(this.hideForgotPasswordLink),\n);\n- const forgotPasswordLin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Start forgotPasswordLinkOpacity at 0
Summary: This Reanimated node only gets processed for the first time when `LogInPanel` displays, at which point the `targetForgotPasswordLinkOpacity` is already 1. We want it to start at 0 and animate to 1
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, ... |
129,187 | 02.09.2020 14:15:55 | 14,400 | b1be0953fee3ad16726b515d2d180e5294a3d6d8 | [native] Fix iOS password management flow for login
Summary: The code comment in this diff should explain what's going on here
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -103,7 +103,7 @@ class LogInPanel extends React.PureComponent<Props> {\nvalue={this.props.state.state.usernameOrEmailInputText}\nonChangeText={this.onChangeU... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix iOS password management flow for login
Summary: The code comment in this diff should explain what's going on here
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D52 |
129,187 | 02.09.2020 14:31:01 | 14,400 | ccb9903b99e92729f16c9cd08cb259fc139c2985 | [native] Make sure ratchetAlongWithKeyboardHeight resets when keyboard hides
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/utils/animation-utils.js",
"new_path": "native/utils/animation-utils.js",
"diff": "@@ -12,6 +12,7 @@ const {\ncond,\nnot,\nand,\n+ or,\ngreaterThan,\nlessThan,\neq,\n@@ -115,12 +116,16 @@ function ratchetAlongWithKeyboardHeight(\n// cases it can get qui... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make sure ratchetAlongWithKeyboardHeight resets when keyboard hides
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D53 |
129,183 | 01.09.2020 15:07:28 | -7,200 | 4ec81b0c8d2fbdf14084f1254737562a6391e1ba | [native] Add click to reply option
Reviewers: ashoat
Subscribers: zrebcu411, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "@@ -59,7 +59,10 @@ import { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport { trimMessage } from 'lib/shared/message-utils';\nimport... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add click to reply option
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D46 |
129,187 | 03.09.2020 08:44:08 | 14,400 | 80cce0248d5807996472304af9b6e57827f35759 | Address security advisory in bl package
Summary: See
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -3651,9 +3651,9 @@ binary@~0.3.0:\nchainsaw \"~0.1.0\"\nbl@^3.0.0:\n- version \"3.0.0\"\n- resolved \"https://registry.yarnpkg.com/bl/-/bl-3.0.0.tgz#3611ec00579fd18561754360b21e9f784500ff88\"\n- integrity sha512... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Address security advisory in bl package
Summary: See https://github.com/advisories/GHSA-pp7h-53gx-mx7r
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D58 |
129,186 | 26.08.2020 16:27:36 | -7,200 | 54c01931d7effbd60064073de23b0c238b4698b7 | [server] Add relationshipStatus to userInfo
Reviewers: ashoat
Subscribers: Adrian, KatPo, palys-swm | [
{
"change_type": "MODIFY",
"old_path": "lib/types/relationship-types.js",
"new_path": "lib/types/relationship-types.js",
"diff": "@@ -14,6 +14,16 @@ export const directedStatus = Object.freeze({\n});\nexport type DirectedStatus = $Values<typeof directedStatus>;\n+export const userRelationshipStatus ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add relationshipStatus to userInfo
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: Adrian, KatPo, palys-swm
Differential Revision: https://phabricator.ashoat.com/D24 |
129,186 | 04.09.2020 14:16:21 | -7,200 | bf382d2913b857333a450ed1f3449fc77970ab34 | [native] Rename scrollBlockingChatModals to scrollBlockingModals
Reviewers: ashoat, palys-swm
Subscribers: KatPo, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/nav-selectors.js",
"new_path": "native/navigation/nav-selectors.js",
"diff": "@@ -23,7 +23,7 @@ import {\nThreadPickerModalRouteName,\nActionResultModalRouteName,\naccountModals,\n- scrollBlockingChatModals,\n+ scrollBlockingModals,\nchatRoot... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename scrollBlockingChatModals to scrollBlockingModals
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: KatPo, Adrian
Differential Revision: https://phabricator.ashoat.com/D61 |
129,187 | 04.09.2020 13:29:06 | 14,400 | 982244e9262d6340bde039954dbdb976095ca8c9 | [native] Fix TooltipItem.onPress type error on RelationshipListItemTooltipModal
Summary: The change in [D46](https://phabricator.ashoat.com/D46#change-pgdfH5OkaDaJ) caused an issue when [D45](https://phabricator.ashoat.com/D45#change-fhAu2faz5ErC) was rebased on top of it.
Reviewers: KatPo, palys-swm
Subscribers: zrebc... | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-list-item-tooltip-modal.react.js",
"new_path": "native/more/relationship-list-item-tooltip-modal.react.js",
"diff": "@@ -69,14 +69,22 @@ const spec = {\n{\nid: 'unfriend',\ntext: 'Unfriend',\n- onPress: (props, ...rest) =>\n- onRemoveU... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix TooltipItem.onPress type error on RelationshipListItemTooltipModal
Summary: The change in [D46](https://phabricator.ashoat.com/D46#change-pgdfH5OkaDaJ) caused an issue when [D45](https://phabricator.ashoat.com/D45#change-fhAu2faz5ErC) was rebased on top of it.
Reviewers: KatPo, palys-swm
Reviewed By: pa... |
129,187 | 04.09.2020 14:42:25 | 14,400 | 9d8e3c386b271e55b3b22b3fa53d6b22cd694e03 | [lib] Fix type of promiseAll
Summary: I noticed that this was not typing the results correctly. It should be fixed now
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/filter-types.js",
"new_path": "lib/types/filter-types.js",
"diff": "@@ -28,7 +28,7 @@ export const calendarFilterPropType = PropTypes.oneOfType([\n}),\n]);\n-export const defaultCalendarFilters = [\n+export const defaultCalendarFilters: $ReadOnlyArra... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix type of promiseAll
Summary: I noticed that this was not typing the results correctly. It should be fixed now
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D65 |
129,186 | 04.09.2020 12:27:35 | 14,400 | 6cf84ca051f1450b69e539fa18cf3d105320e68c | Add GlobalUserInfo type
Reviewers: zrebcu411, palys-swm
Subscribers: KatPo, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/types/search-types.js",
"new_path": "lib/types/search-types.js",
"diff": "// @flow\n-import type { AccountUserInfo } from './user-types';\n+import type { GlobalAccountUserInfo } from './user-types';\nexport type UserSearchRequest = {|\nprefix?: string,\n|}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Add GlobalUserInfo type
Reviewers: zrebcu411, palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D60 |
129,187 | 04.09.2020 15:09:23 | 14,400 | deda7324c9a698975f4b1ed90b8331aaa3b4c6dc | [native] Fix onUserSelect in RelationshipUpdateModal
Summary: In D45 I asked to include search results from the `userStore`, but he neglected to update `onUserSelect` to handle selecting these results
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/relationship-update-modal.react.js",
"new_path": "native/more/relationship-update-modal.react.js",
"diff": "@@ -224,7 +224,12 @@ class RelationshipUpdateModal extends React.PureComponent<Props, State> {\nreturn;\n}\n- const selectedUserInfo = this.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix onUserSelect in RelationshipUpdateModal
Summary: In D45 I asked @zrebcu411 to include search results from the `userStore`, but he neglected to update `onUserSelect` to handle selecting these results
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision... |
129,187 | 09.09.2020 15:37:14 | 14,400 | 8288be5ca887254486cae6b4cf744121c5b2ed02 | [web] Remove translateZ(0) no-op in MessageList
Summary: I initially introduced this because of a ["weird glitch"](https://github.com/Ashoat/squadcal/commit/81ba46dd20646df2bc8e74950ae92c84733a7384), but I can't reproduce it anymore. I'm guessing the browser bug has been fixed
Reviewers: KatPo, palys-swm
Subscribers: z... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -21,11 +21,8 @@ div.firefoxMessageContainer {\nflex-direction: column !important;\ntransform: scaleY(-1);\n}\n-div.messageContainer > div {\n- transform: translateZ(0);\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove translateZ(0) no-op in MessageList
Summary: I initially introduced this because of a ["weird glitch"](https://github.com/Ashoat/squadcal/commit/81ba46dd20646df2bc8e74950ae92c84733a7384), but I can't reproduce it anymore. I'm guessing the browser bug has been fixed
Reviewers: KatPo, palys-swm
Reviewed By... |
129,183 | 03.09.2020 15:18:05 | -7,200 | 5ea4e156834e47907c0e394908a6a78c82b5e07e | [web] Add option to click on message
Reviewers: ashoat
Subscribers: zrebcu411, palys-swm, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -165,6 +165,22 @@ div.messageTimestampBottomRightTooltip:after {\nborder-color: transparent transparent black transparent;\n}\n+div.messageReplyTooltip {\n+ position: re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add option to click on message
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: zrebcu411, palys-swm, Adrian
Differential Revision: https://phabricator.ashoat.com/D59 |
129,183 | 04.09.2020 15:15:15 | -7,200 | 39bcdbf0e069e192c039e095d120ee23843ca43e | Move createReply function
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -881,6 +881,12 @@ function trimMessage(message: string) {\nreturn codeBlockRegex.exec(message) ? message.trimEnd() : message.trim();\n}\n+function createMessageReply(message: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Move createReply function
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D62 |
129,183 | 04.09.2020 15:17:57 | -7,200 | 705107688af075086ac343ac42518d101b6f080d | [web] Add reply to message on web
Reviewers: ashoat, palys-swm
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -50,6 +50,7 @@ type Props = {|\njoinThreadLoadingStatus: LoadingStatus,\ncalendarQuery: () => CalendarQuery,\nnextLocalID: number,\n+ isThreadActive: boolean,\n// Re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add reply to message on web
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D63 |
129,187 | 12.09.2020 17:57:27 | 14,400 | 703fabbd37e6e95edb163376906841433008cb00 | [native] Prevent multiple subsequent logouts
Summary: This diff prevents the user from hitting the log out button multiple times in a row.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/more/more-screen.react.js",
"new_path": "native/more/more-screen.react.js",
"diff": "import type { DispatchActionPromise } from 'lib/utils/action-utils';\nimport type { AppState } from '../redux/redux-setup';\nimport type { LogOutResult } from 'lib/type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Prevent multiple subsequent logouts
Summary: This diff prevents the user from hitting the log out button multiple times in a row.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D86 |
129,187 | 12.09.2020 20:58:02 | 14,400 | 81080f696dec8a508bc241b176e0ee743370a95d | [native][Android] Lock orientation to portrait when app boots
Summary: This is the Android equivalent of D83.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/AndroidManifest.xml",
"new_path": "native/android/app/src/main/AndroidManifest.xml",
"diff": "android:configChanges=\"keyboard|keyboardHidden|orientation|screenSize|uiMode\"\nandroid:windowSoftInputMode=\"adjustResize\"\nandroid:exp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][Android] Lock orientation to portrait when app boots
Summary: This is the Android equivalent of D83.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D90 |
129,187 | 12.09.2020 22:00:16 | 14,400 | 411d975a3275a6e83d14f399eb1fde45d7330c13 | [native] Set autoCompleteType for integration with Android password managers
Summary: See [documentation](https://reactnative.dev/docs/textinput#autocompletetype)
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -108,6 +108,7 @@ class LogInPanel extends React.PureComponent<Props> {\nautoCapitalize=\"none\"\nkeyboardType=\"ascii-capable\"\ntextContentType=\"username\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set autoCompleteType for integration with Android password managers
Summary: See [documentation](https://reactnative.dev/docs/textinput#autocompletetype)
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D91 |
129,187 | 12.09.2020 22:28:36 | 14,400 | 0cf98a0a6e47d174f05d162ecec85e828e727117 | [native] Fix ratchetAlongWithKeyboardHeight on Android
Summary: I noticed an animation bug where if `keyboardShow` triggered after `keyboardTimeoutClock`, `ratchetAlongWithKeyboardHeight` failed to correct the `panelPaddingTop` value. After some testing realized it was just a silly typo...
Reviewers: palys-swm
Subscrib... | [
{
"change_type": "MODIFY",
"old_path": "native/utils/animation-utils.js",
"new_path": "native/utils/animation-utils.js",
"diff": "@@ -114,7 +114,10 @@ function ratchetAlongWithKeyboardHeight(\nios: greaterThan(keyboardHeight, max(prevKeyboardHeightValue, 0)),\n// Android's keyboard can resize due to... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix ratchetAlongWithKeyboardHeight on Android
Summary: I noticed an animation bug where if `keyboardShow` triggered after `keyboardTimeoutClock`, `ratchetAlongWithKeyboardHeight` failed to correct the `panelPaddingTop` value. After some testing realized it was just a silly typo...
Reviewers: palys-swm
Revie... |
129,187 | 13.09.2020 00:35:05 | 14,400 | 9c26e2cce54c919577e45d64eb4d1ccb882b1dac | [native] Focus password field after autofilling username field
Summary: For some reason, iOS doesn't fill the password field here at the same time as the username. This diff reduces once click for the user
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -165,6 +165,12 @@ class LogInPanel extends React.PureComponent<Props> {\nonChangeUsernameOrEmailInputText = (text: string) => {\nthis.props.state.setState({ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Focus password field after autofilling username field
Summary: For some reason, iOS doesn't fill the password field here at the same time as the username. This diff reduces once click for the user
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: http... |
129,187 | 14.09.2020 12:04:48 | 14,400 | c6f52c0e1feca496ec1d6b58aaeea0cc3f4df355 | [web] Maintain scroll position when scrolled up on ChatMessageList
Summary: Chrome and Firefox do this automatically, but Safari does not
Reviewers: palys-swm, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "@@ -80,7 +80,8 @@ type State = {|\n+mouseOverMessagePosition: ?OnMessagePositionInfo,\n|};\ntype Snapshot = {|\n- +scrolledToBottom: boolean,\n+ +scrollTop: numbe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Maintain scroll position when scrolled up on ChatMessageList
Summary: Chrome and Firefox do this automatically, but Safari does not
Reviewers: palys-swm, KatPo
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D96 |
129,187 | 14.09.2020 15:37:21 | 14,400 | d6978f40468135dc2fad46cc3d58a14d9f533528 | [server] Set SameSite option on cookie
Summary: Context on this new option [here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite). Firefox was complaining when I was testing my local instance that non-https cookies will soon not work unless they have `SameSite` set.
Reviewers: palys-swm
S... | [
{
"change_type": "MODIFY",
"old_path": "server/src/session/cookies.js",
"new_path": "server/src/session/cookies.js",
"diff": "@@ -740,6 +740,7 @@ const cookieOptions = {\nhttpOnly: true,\nsecure: https,\nmaxAge: cookieLifetime,\n+ sameSite: 'Strict',\n};\nfunction addActualHTTPCookie(viewer: Viewer,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Set SameSite option on cookie
Summary: Context on this new option [here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie/SameSite). Firefox was complaining when I was testing my local instance that non-https cookies will soon not work unless they have `SameSite` set.
Reviewers: palys-swm... |
129,187 | 14.09.2020 19:05:56 | 14,400 | 32b3f5b812fd30448ad7bf3fd48400c7d7342d1b | [native] Focus password field after autofilling username field (actually)
Summary: I screwed up in D93. This now matches [the logic](https://github.com/Ashoat/squadcal/blob/master/native/account/register-panel.react.js#L245-L257) in `RegisterPanel`.
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/account/log-in-panel.react.js",
"new_path": "native/account/log-in-panel.react.js",
"diff": "@@ -102,6 +102,7 @@ class LogInPanel extends React.PureComponent<Props> {\nstyle={styles.input}\nvalue={this.props.state.state.usernameOrEmailInputText}\nonChan... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Focus password field after autofilling username field (actually)
Summary: I screwed up in D93. This now matches [the logic](https://github.com/Ashoat/squadcal/blob/master/native/account/register-panel.react.js#L245-L257) in `RegisterPanel`.
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zr... |
129,187 | 14.09.2020 22:43:43 | 14,400 | 95bfb4341c284b08b60204d52ee4ca7f0730240b | [native] Extract ChatThreadListSidebar component
Summary:
Extracts `ChatThreadListSidebar` component from `ChatThreadListItem`
Introduces `useColors` hook
Makes button press on sidebar lead to that sidebar instead of to its parent thread
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -10,7 +10,6 @@ import type { AppState } from '../redux/redux-setup';\nimport * as React from 'react';\nimport { View, Text } from 'react-native';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Extract ChatThreadListSidebar component
Summary:
- Extracts `ChatThreadListSidebar` component from `ChatThreadListItem`
- Introduces `useColors` hook
- Makes button press on sidebar lead to that sidebar instead of to its parent thread
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu41... |
129,187 | 14.09.2020 23:08:21 | 14,400 | 2f7e08544554ac106e6c971d661633bd082c6265 | [lib] Order sidebars in chatListDataWithNestedSidebars
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/selectors/chat-selectors.js",
"new_path": "lib/selectors/chat-selectors.js",
"diff": "@@ -108,7 +108,7 @@ function createChatThreadItem(\n);\nconst lastUpdatedTime = getLastUpdatedTime(threadInfo, mostRecentMessageInfo);\n- const sidebars = [];\n+ const un... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Order sidebars in chatListDataWithNestedSidebars
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D107 |
129,187 | 14.09.2020 23:22:12 | 14,400 | 1c10ac4f73b73ec8b5311f8be69e75f91e5abc07 | [native]
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -293,7 +293,7 @@ PODS:\n- React\n- react-native-orientation-locker (1.1.6):\n- React\n- - react-native-safe-area-context (3.1.1):\n+ - react-native-safe-area-context (3.1.7):\n- React... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] react-native-safe-area-context@3.1.7
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D108 |
129,191 | 28.08.2020 15:23:15 | -7,200 | b86f3060e5e6305c7d06975a84e8cc2cc861df77 | [native] Make thread list item a swipeable component
Summary: Wrap thread list item with Swipeable. There are two temporary actions added to allow testing the implementation.
Reviewers: ashoat, KatPo
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": ".*/node_modules/redux-persist/lib/index.js\n.*/node_modules/react-native-fast-image/src/index.js.flow\n.*/node_modules/react-native-fs/FS.common.js\n+.*/node_modules/react-native-gesture-handler/S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Make thread list item a swipeable component
Summary: Wrap thread list item with Swipeable. There are two temporary actions added to allow testing the implementation.
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D27 |
129,191 | 03.09.2020 14:41:52 | -7,200 | 7f87599c1ab416c0583540a1cf092cb3fa22fd89 | [native] Close swipeables on blur
Summary: Change ChatThreadListItem to functional component, use navigation hook, set navigation blur listener and close swipeable using ref
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411, KatPo | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -8,9 +8,10 @@ import type { ThreadInfo } from 'lib/types/thread-types';\nimport type { AppState } from '../redux/redux-setup';\nimport * as React... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Close swipeables on blur
Summary: Change ChatThreadListItem to functional component, use navigation hook, set navigation blur listener and close swipeable using ref
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411, KatPo
Differential Revision: https://phabricator.ashoat.com/D47 |
129,191 | 07.09.2020 14:27:18 | -7,200 | 324ae98c8a4360dcabcf1f85f0e9666d510e937e | [native] Close currently opened swipeable when another is being opened
Summary: When swipeable is opened, thread's id is saved in list state. Then, it's passed to all the items and if it doesn't match item's id, the swipeable will be closed.
Reviewers: ashoat, KatPo
Subscribers: zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -31,11 +31,20 @@ import ChatThreadListSidebar from './chat-thread-list-sidebar.react';\ntype Props = {\ndata: ChatThreadItem,\nonPressItem: (thre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Close currently opened swipeable when another is being opened
Summary: When swipeable is opened, thread's id is saved in list state. Then, it's passed to all the items and if it doesn't match item's id, the swipeable will be closed.
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: zrebcu411, Adria... |
129,191 | 08.09.2020 10:29:09 | -7,200 | ad69606a760573ab41d3a655efd35a93bc170e6e | [native] Use hooks in chat thread list item
Summary: Use hooks in chat thread list item
Reviewers: ashoat, KatPo
Subscribers: Adrian, zrebcu411 | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -5,7 +5,6 @@ import {\nchatThreadItemPropType,\n} from 'lib/selectors/chat-selectors';\nimport type { ThreadInfo } from 'lib/types/thread-types';... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hooks in chat thread list item
Summary: Use hooks in chat thread list item
Reviewers: ashoat, KatPo
Reviewed By: ashoat
Subscribers: Adrian, zrebcu411
Differential Revision: https://phabricator.ashoat.com/D72 |
129,187 | 15.09.2020 11:55:17 | 14,400 | 01ebc846bcd995fab9727075852ced82278fd2cf | [native] Use hook instead of connect functions and HOC in ChatInputBar
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-input-bar.react.js",
"new_path": "native/chat/chat-input-bar.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\n-import type {\n- DispatchActionPayload,\n- DispatchActionPromise,\n-} from 'lib/utils/action-ut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in ChatInputBar
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D111 |
129,187 | 15.09.2020 14:05:17 | 14,400 | 41184d171ffe5e7a1edac71ae7dbb90085ee867f | [lib] Use hook instead of connect functions and HOC in Socket
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "lib/socket/socket.react.js",
"new_path": "lib/socket/socket.react.js",
"diff": "@@ -34,10 +34,7 @@ import {\nsetLateResponseActionType,\n} from '../types/socket-types';\nimport type { Dispatch } from '../types/redux-types';\n-import type {\n- DispatchActionPay... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use hook instead of connect functions and HOC in Socket
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D112 |
129,187 | 15.09.2020 14:10:56 | 14,400 | 2dd32dde29ad842b80ff4c3005d6ed666802b0f2 | [web] Use hook instead of connect functions and HOC in ChatInputBar
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\n-import type {\n- DispatchActionPromise,\n- DispatchActionPayload,\n-} from 'lib/utils/action-utils';\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect functions and HOC in ChatInputBar
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D113 |
129,187 | 15.09.2020 14:48:11 | 14,400 | f7f82380ca88cd40f3b85e921db42bfedfe78c70 | [web]
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -16,7 +16,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport { faCalendar, faComments } from '@fortawesome/free-solid-svg-icons';\nimport { config as faConfig } from '@f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] react-dnd@11.1.3
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D114 |
129,187 | 15.09.2020 15:05:38 | 14,400 | 148a59e4d9643226c1f4c2811c3c371d9bad6862 | [web] Use hook instead of connect functions and HOC in ChatMessageList
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "// @flow\n-import type { AppState } from '../redux/redux-setup';\nimport {\ntype ChatMessageItem,\nchatMessageItemPropType,\n} from 'lib/selectors/chat-selectors'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect functions and HOC in ChatMessageList
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D115 |
129,187 | 15.09.2020 15:10:49 | 14,400 | bd708118cd947d206a9bdda019781ddb045cf143 | [web] Use hook instead of withInputState in ComposedMessage
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -20,6 +20,7 @@ import {\nCheckCircle as CheckCircleIcon,\nXCircle as XCircleIcon,\n} from 'react-feather';\n+import invariant from 'invariant';\nimport { stringF... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of withInputState in ComposedMessage
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D116 |
129,187 | 15.09.2020 15:15:45 | 14,400 | 020a39c0b38e92c84dc41d61dff752729b468bbf | [web] Use hook instead of connect functions and HOC in FailedSend
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/failed-send.react.js",
"new_path": "web/chat/failed-send.react.js",
"diff": "@@ -10,14 +10,13 @@ import {\nassertComposableMessageType,\n} from 'lib/types/message-types';\nimport { type ThreadInfo, threadInfoPropType } from 'lib/types/thread-types';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of connect functions and HOC in FailedSend
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D117 |
129,187 | 15.09.2020 15:19:23 | 14,400 | 5d1f49411a70e0bf1c047e47c6942c3cdaf6aad4 | [web] Use hook instead of withInputState in MultimediaMessage
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/chat/multimedia-message.react.js",
"new_path": "web/chat/multimedia-message.react.js",
"diff": "@@ -19,18 +19,21 @@ import sendFailed from './multimedia-message-send-failed';\nimport {\ninputStatePropType,\ntype InputState,\n- withInputState,\n+ InputState... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use hook instead of withInputState in MultimediaMessage
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D118 |
129,187 | 15.09.2020 15:20:17 | 14,400 | 5a113e274e4fa0c2ea31a26d600ba1112e5a6589 | [web] Get rid of withInputState
Summary: It's no longer used. Going forward, let's use hooks for data binding
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "web/input/input-state.js",
"new_path": "web/input/input-state.js",
"diff": "@@ -92,31 +92,8 @@ const inputStatePropType = PropTypes.shape({\nconst InputStateContext = React.createContext<?InputState>(null);\n-function withInputState<\n- AllProps: {},\n- Compon... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of withInputState
Summary: It's no longer used. Going forward, let's use hooks for data binding
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D119 |
129,187 | 15.09.2020 15:52:02 | 14,400 | 3d85835e9a899e759f3122b0137811137b12ee91 | [native] Use hook instead of connect functions and HOC in FailedSend
Reviewers: palys-swm
Subscribers: KatPo, zrebcu411, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/chat/failed-send.react.js",
"new_path": "native/chat/failed-send.react.js",
"diff": "import type { ChatMessageInfoItemWithHeight } from './message.react';\nimport { chatMessageItemPropType } from 'lib/selectors/chat-selectors';\nimport { messageTypes, t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use hook instead of connect functions and HOC in FailedSend
Reviewers: palys-swm
Reviewed By: palys-swm
Subscribers: KatPo, zrebcu411, Adrian
Differential Revision: https://phabricator.ashoat.com/D120 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.