author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,181 | 05.01.2023 13:28:50 | -3,600 | e1af827cf64f4f1d1ebc1cbe6c1e7032981414ab | [desktop] Enable flow in the desktop workspace
Summary:
[ENG-2219](https://linear.app/comm/issue/ENG-2219)
Adds flow support in the desktop workspace.
Test Plan:
Run `flow` in `desktop`
Check if `lint-staged` fails when trying to commit file with type errors
Reviewers: tomek, atul, ashoat
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/eslint_flow_jest.yml",
"new_path": ".buildkite/eslint_flow_jest.yml",
"diff": "@@ -5,7 +5,7 @@ steps:\n- 'curl --proto \"=https\" --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y'\n- '. /root/.cargo/env'\n- 'yarn cleaninstall --frozen-lockfile --sk... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [desktop] Enable flow in the desktop workspace
Summary:
[ENG-2219](https://linear.app/comm/issue/ENG-2219)
Adds flow support in the desktop workspace.
Test Plan:
- Run `flow` in `desktop`
- Check if `lint-staged` fails when trying to commit file with type errors
Reviewers: tomek, atul, ashoat
Reviewed By: ashoat
S... |
129,197 | 06.01.2023 09:15:04 | 21,600 | 3e7b49ecbe4fe44eefdcb5e5c10bd5ef7eace826 | [image-picker] install expo package
Summary: Doing the installation again. Installed package by modifying `package.json` and running `yarn cleaninstall`.
Test Plan: Build succeeds. Run succeeds.
Reviewers: atul, ashoat
Subscribers: tomek, ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -98,6 +98,8 @@ PODS:\n- ExpoImageManipulator (11.0.0):\n- EXImageLoader\n- ExpoModulesCore\n+ - ExpoImagePicker (14.0.2):\n+ - ExpoModulesCore\n- ExpoKeepAwake (11.0.1):\n- ExpoModule... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [image-picker] install expo package
Summary: Doing the installation again. Installed package by modifying `package.json` and running `yarn cleaninstall`.
Test Plan: Build succeeds. Run succeeds.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: tomek, ashoat
Differential Revision: https://phab.comm.dev/D61... |
129,184 | 11.01.2023 16:07:08 | 18,000 | ee86b784e39807d818821ddcd6d448b2472f7a4f | [web] Introduce `LoginFormWrapper` component
Summary:
Basically wrap `LoginForm` with `RainbowKitProvider` and `WagmiConfig`.
Inspired heavily by (read: copied from) `landing/siwe.react.js`.
Test Plan: Tested implicitly by subsequent diffs.
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.react.js",
"new_path": "web/account/log-in-form.react.js",
"diff": "// @flow\n+import '@rainbow-me/rainbowkit/dist/index.css';\n+\n+import {\n+ darkTheme,\n+ getDefaultWallets,\n+ RainbowKitProvider,\n+} from '@rainbow-me/rainbowkit';\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `LoginFormWrapper` component
Summary:
Basically wrap `LoginForm` with `RainbowKitProvider` and `WagmiConfig`.
Inspired heavily by (read: copied from) `landing/siwe.react.js`.
Test Plan: Tested implicitly by subsequent diffs.
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https... |
129,184 | 11.01.2023 16:47:59 | 18,000 | fa7a753bbe74ff767dff14648d2c271d05e6b145 | [web] Add `siweButton` to `LogInForm` component
Summary:
Doesn't do anything at the moment.
Depends on D6217
Test Plan:
Here's how it looks:
{F325054}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "@@ -40,3 +40,10 @@ div.modal_form_error {\npadding-left: 6px;\nalign-self: center;\n}\n+\n+div.ethereum_logo_container {\n+ display: flex;\n+ justify-content: center;\n+ align-co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add `siweButton` to `LogInForm` component
Summary:
Doesn't do anything at the moment.
---
Depends on D6217
Test Plan:
Here's how it looks:
{F325054}
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6218 |
129,184 | 11.01.2023 17:59:23 | 18,000 | 6649fafa888adb170e66a989b7f45e1459eb51a0 | [web] Display `ConnectButton` after `ConnectModal` flow completes successfully
Summary:
Display `ConnectButton` with wallet info once `ConnectModal` flow completes successfully and `signer` (via `useSigner()` hook) exists.
Depends on D6220
Test Plan:
Here's what it looks like:
{F325150}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "@@ -65,3 +65,10 @@ hr:after {\ncontent: 'or';\nbackground-color: #1f1f1fff;\n}\n+\n+div.connectButtonContainer {\n+ width: 100%;\n+ display: flex;\n+ justify-content: center;\n+ ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Display `ConnectButton` after `ConnectModal` flow completes successfully
Summary:
Display `ConnectButton` with wallet info once `ConnectModal` flow completes successfully and `signer` (via `useSigner()` hook) exists.
---
Depends on D6220
Test Plan:
Here's what it looks like:
{F325150}
Reviewers: ashoat, tom... |
129,184 | 11.01.2023 19:06:11 | 18,000 | 51f87ca168df00287d516046a91a8855b4c92fc6 | [native] `codeVersion` -> 173 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 173 |
129,184 | 11.01.2023 19:09:02 | 18,000 | 2b3b850ef56718847e70d98ca35d942a00ac5480 | [native] `codeVersion` -> 174 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 174 |
129,180 | 22.12.2022 14:42:39 | -3,600 | 9c267823c49bbbcb7bc9c77625729976dc6c7ab6 | [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js
Summary: Moved utility functions to web/utils.
Test Plan:
Typeahead without keyboard support works.
Final tests performed in last diffs.
Reviewers: inka, kamil, ginsu, tomek
Subscribers: ashoat, atul, tomek, ginsu, kamil, inka | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -51,9 +51,9 @@ import Multimedia from '../media/multimedia.react';\nimport { useSelector } from '../redux/redux-utils';\nimport { nonThreadCalendarQuery } from '../s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Keyboard support for typeahead [2/13] - Moved typeahead-utils.js
Summary: Moved utility functions to web/utils.
Test Plan:
Typeahead without keyboard support works.
Final tests performed in last diffs.
Reviewers: inka, kamil, ginsu, tomek
Reviewed By: ginsu, tomek
Subscribers: ashoat, atul, tomek, ginsu, kam... |
129,180 | 22.12.2022 16:04:11 | -3,600 | 84aef4c58dca6baa016b4814da2c52ad3d46175c | [web] Keyboard support for typeahead [9/13] - Refactor getTypeaheadTooltipButtons as a function
Summary: Moved creating buttons in overlay to utility function.
Test Plan:
Typeahead without keyboard support works.
Final tests performed in last diffs.
Reviewers: inka, kamil, ginsu, tomek
Subscribers: ashoat, atul, tomek,... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/typeahead-tooltip.react.js",
"new_path": "web/chat/typeahead-tooltip.react.js",
"diff": "@@ -5,10 +5,10 @@ import * as React from 'react';\nimport type { RelativeMemberInfo } from 'lib/types/thread-types';\n-import Button from '../components/button.re... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Keyboard support for typeahead [9/13] - Refactor getTypeaheadTooltipButtons as a function
Summary: Moved creating buttons in overlay to utility function.
Test Plan:
Typeahead without keyboard support works.
Final tests performed in last diffs.
Reviewers: inka, kamil, ginsu, tomek
Reviewed By: inka, tomek
Sub... |
129,180 | 22.12.2022 16:29:32 | -3,600 | fb601172deb063dcd4eba1db9781bceff09c4d9a | [web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as user interacts with it
Summary: Overlay scrolls automatically when users moves through users suggested to mention.
Test Plan:
Tested on video below:
{F306054}
Reviewers: inka, kamil, ginsu, tomek
Subscribers: ashoat, atul, tomek, ginsu, kamil, ... | [
{
"change_type": "MODIFY",
"old_path": "web/chat/typeahead-tooltip.react.js",
"new_path": "web/chat/typeahead-tooltip.react.js",
"diff": "@@ -8,6 +8,7 @@ import { leastPositiveResidue } from 'lib/utils/math-utils';\nimport type { InputState } from '../input/input-state';\nimport {\n+ getTypeaheadOve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Keyboard support for typeahead [12/13] - Scrolling thourgh overlay as user interacts with it
Summary: Overlay scrolls automatically when users moves through users suggested to mention.
Test Plan:
Tested on video below:
{F306054}
Reviewers: inka, kamil, ginsu, tomek
Reviewed By: tomek
Subscribers: ashoat, atu... |
129,180 | 05.01.2023 14:52:13 | -3,600 | 520eeeaba4cbb1854bd578d635dbe9ddd331f49b | [web] Empty password caused "Unknown error" during login
Summary: Solving this: https://linear.app/comm/issue/ENG-2655/[web]-unknown-error-when-password-is-empty-during-login
Test Plan:
Tested correct and incorrect passwords.
{F319250}
Reviewers: tomek, inka, ashoat
Subscribers: ashoat, atul, inka, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.react.js",
"new_path": "web/account/log-in-form.react.js",
"diff": "@@ -171,6 +171,10 @@ function LoginForm(): React.Node {\nsetErrorMessage('alphanumeric usernames only');\nusernameInputRef.current?.focus();\nreturn;\n+ } else if (pass... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Empty password caused "Unknown error" during login
Summary: Solving this: https://linear.app/comm/issue/ENG-2655/[web]-unknown-error-when-password-is-empty-during-login
Test Plan:
Tested correct and incorrect passwords.
{F319250}
Reviewers: tomek, inka, ashoat
Reviewed By: tomek, ashoat
Subscribers: ashoat, ... |
129,205 | 05.01.2023 13:48:27 | -3,600 | 04a0815b1ec777a0d25e373fe951c9727132c7f8 | [services][backup] Add BackupItem database methods
Summary:
Implemented methods for managing `BackupItem`s and the `backup-service-backup` table.
Depends on D6179
Test Plan: Called these locally and ensured that entities are properly inserted/read/removed from database.
Reviewers: varun, tomek, jon, max
Subscribers: as... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/database.rs",
"new_path": "services/backup/src/database.rs",
"diff": "-use aws_sdk_dynamodb::{model::AttributeValue, Error as DynamoDBError};\n+use aws_sdk_dynamodb::{\n+ model::AttributeValue, output::GetItemOutput, Error as DynamoDBError,... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][backup] Add BackupItem database methods
Summary:
Implemented methods for managing `BackupItem`s and the `backup-service-backup` table.
Depends on D6179
Test Plan: Called these locally and ensured that entities are properly inserted/read/removed from database.
Reviewers: varun, tomek, jon, max
Reviewed B... |
129,205 | 05.01.2023 13:55:09 | -3,600 | e47f94c6b4069b260fbf73ccb9636e4b24514b70 | [services][backup] Add LogItem database methods
Summary:
Implemented methods for managing `LogItem`s and the `backup-service-log` table.
Depends on D6180
Test Plan: Called these locally and ensured that entities are properly inserted/read/removed from database.
Reviewers: varun, tomek, jon, max
Subscribers: ashoat, atu... | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/database.rs",
"new_path": "services/backup/src/database.rs",
"diff": "@@ -14,6 +14,9 @@ use crate::constants::{\nBACKUP_TABLE_FIELD_COMPACTION_HOLDER, BACKUP_TABLE_FIELD_CREATED,\nBACKUP_TABLE_FIELD_RECOVERY_DATA, BACKUP_TABLE_FIELD_USER_ID... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][backup] Add LogItem database methods
Summary:
Implemented methods for managing `LogItem`s and the `backup-service-log` table.
Depends on D6180
Test Plan: Called these locally and ensured that entities are properly inserted/read/removed from database.
Reviewers: varun, tomek, jon, max
Reviewed By: varun
... |
129,187 | 13.01.2023 09:52:47 | 25,200 | b294723065af4ad110135310d7967564e06f7c59 | [native] `codeVersion` -> 175 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 175 |
129,187 | 13.01.2023 10:17:08 | 25,200 | ac6379585c8699a3d6ab0c63a561983434579605 | [native] `codeVersion` -> 176 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 176 |
129,182 | 16.01.2023 11:26:09 | -3,600 | ac72e5c0db35bc5a7e429a181c69c92a9dab06aa | [native] Fix typo in native/navigation/community-drawer-content.react.js
Summary: Fixing a typo
Test Plan: run `flow check` in native/
Reviewers: michal
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/community-drawer-content.react.js",
"new_path": "native/navigation/community-drawer-content.react.js",
"diff": "@@ -37,7 +37,7 @@ function CommunityDrawerContent(): React.Node {\nconst navigateToThread = useNavigateToThread();\nconst childThr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix typo in native/navigation/community-drawer-content.react.js
Summary: Fixing a typo
Test Plan: run `flow check` in native/
Reviewers: michal
Reviewed By: michal
Subscribers: ashoat, tomek, atul
Differential Revision: https://phab.comm.dev/D6200 |
129,187 | 13.01.2023 13:39:10 | 25,200 | 52d0d63f631f2ed2328a3c576165853e47059336 | [native] Create native/facts/alchemy.json file in release GitHub Actions
Summary: Context in [ENG-2589](https://linear.app/comm/issue/ENG-2589/get-alchemy-api-key-into-react-native-app). We need the Alchemy key in the mobile app so we can do ENS lookups.
Test Plan: Test plan described here:
Reviewers: atul
Subscribers:... | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/android_release.yml",
"new_path": ".github/workflows/android_release.yml",
"diff": "@@ -29,6 +29,12 @@ jobs:\n- name: yarn --frozen-lockfile --network-timeout 180000\nrun: yarn --frozen-lockfile --network-timeout 180000\n+ - name: Save ALCHEM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Create native/facts/alchemy.json file in release GitHub Actions
Summary: Context in [ENG-2589](https://linear.app/comm/issue/ENG-2589/get-alchemy-api-key-into-react-native-app). We need the Alchemy key in the mobile app so we can do ENS lookups.
Test Plan: Test plan described here: https://linear.app/comm/is... |
129,187 | 13.01.2023 13:32:46 | 25,200 | 70e41be68bb0033a2747fc1f7fa59f7cf0eb5e0d | [landing][web] Update to
Summary: `keyserver` had a newer version for some reason.
Test Plan: We're only updating from 5.7.0 to 5.7.2. Confirmed in [release notes](https://github.com/ethers-io/ethers.js/releases) that should be no breaking changes
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"@rainbow-me/rainbowkit\": \"^0.5.0\",\n\"classnames\": \"^2.2.5\",\n\"core-js\": \"^3.6.5\",\n- \"ethers\": \"^5.7.0\",\n+ \"ethers\": \"^5.7.2\",\n\"invariant\": \"^2.2.4\",\n\"isomorphic-f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing][web] Update to ethers@5.7.2
Summary: `keyserver` had a newer version for some reason.
Test Plan: We're only updating from 5.7.0 to 5.7.2. Confirmed in [release notes](https://github.com/ethers-io/ethers.js/releases) that should be no breaking changes
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
... |
129,184 | 17.01.2023 10:21:16 | 18,000 | 33c47ab36ebe7ed915954e3c84f6bf2791e55bf2 | Temporary changes for release | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -465,9 +465,8 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\nlet panel = null;\nlet buttons = null;\n- let siweButton = null;\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Temporary changes for release |
129,184 | 17.01.2023 10:24:08 | 18,000 | 61d86b31d1d0d52d441da3479632181eaf1a152c | [native] `codeVersion` -> 177 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 177 |
129,184 | 19.01.2023 02:02:49 | 18,000 | fdb5cad7fd47dc87091520e062c4ae18bcaf3c55 | [web] Rename `siweConnectButton` to `siweLoginForm`
Summary: Simple rename. In addition to the `ConnectButton`, we'll also be including some copy and a "Sign in" button.
Test Plan: NA
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/siwe.react.js",
"new_path": "web/account/siwe.react.js",
"diff": "@@ -90,9 +90,9 @@ function SIWE(): React.Node {\n[],\n);\n- let siweConnectButton;\n+ let siweLoginForm;\nif (signer && !siweNonce) {\n- siweConnectButton = (\n+ siweLoginForm = (\n<... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename `siweConnectButton` to `siweLoginForm`
Summary: Simple rename. In addition to the `ConnectButton`, we'll also be including some copy and a "Sign in" button.
Test Plan: NA
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6303 |
129,205 | 09.01.2023 15:39:52 | -3,600 | 93b265f7635e2fc8e66f750fc2644f9d07f7e7a2 | [services][backup] AddAttachments 1/4 - create handler module
Summary:
Created module for AddAttachments endpoint and added its invocation in the grpc handler.
Depends on D6203
Test Plan: Service builds and starts. This code has no logic yet.
Reviewers: varun, tomek, jon, max
Subscribers: ashoat, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/src/service/handlers/add_attachments.rs",
"diff": "+use tonic::Status;\n+\n+use super::proto;\n+use crate::database::DatabaseClient;\n+\n+pub async fn handle_add_attachments(\n+ db: &DatabaseClient,\n+ request: proto::AddAttachme... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][backup] AddAttachments 1/4 - create handler module
Summary:
Created module for AddAttachments endpoint and added its invocation in the grpc handler.
Depends on D6203
Test Plan: Service builds and starts. This code has no logic yet.
Reviewers: varun, tomek, jon, max
Reviewed By: tomek
Subscribers: ashoa... |
129,205 | 10.01.2023 16:30:02 | -3,600 | 4d3018f173365924d3b4b1fbae7efb70913542ea | [services][backup] SendLog 1/4 - create handler module
Summary:
Created module for SendLog endpoint and added its its invocation in the grpc handler.
Depends on D6207
Test Plan: Service builds and starts. This code has no logic yet.
Reviewers: varun, tomek, jon, max, michal
Subscribers: ashoat, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/src/service/handlers/send_log.rs",
"diff": "+use tonic::Status;\n+use uuid::Uuid;\n+\n+use crate::{\n+ blob::PutClient, constants::ID_SEPARATOR, database::DatabaseClient,\n+ service::proto::SendLogResponse,\n+};\n+\n+enum LogPers... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][backup] SendLog 1/4 - create handler module
Summary:
Created module for SendLog endpoint and added its its invocation in the grpc handler.
Depends on D6207
Test Plan: Service builds and starts. This code has no logic yet.
Reviewers: varun, tomek, jon, max, michal
Reviewed By: tomek
Subscribers: ashoat,... |
129,184 | 19.01.2023 19:41:04 | 18,000 | 586bc22f6431a60198edecbe59be4cf49661422e | [web] Add SIWE copy to `siweLoginForm`
Summary: Same copy we use on landing. Includes some styling tweaks to ensure that things look reasonable.
Test Plan:
Here's what it looks like:
{F334195}
Reviewers: tomek, ashoat | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.css",
"new_path": "landing/siwe.css",
"diff": "@@ -10,8 +10,6 @@ body {\njustify-content: center;\nalign-items: center;\nalign-content: center;\n- padding-top: 20px;\n- padding-bottom: 50px;\ncolor: white;\nfont-family: sans-serif;\npadding: 20px;... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add SIWE copy to `siweLoginForm`
Summary: Same copy we use on landing. Includes some styling tweaks to ensure that things look reasonable.
Test Plan:
Here's what it looks like:
{F334195}
Reviewers: tomek, ashoat
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6304 |
129,184 | 20.01.2023 00:38:19 | 18,000 | 9da7cea9f7044d7edb238b778e930eb58ee71326 | [web] Add "Sign in" button to `siweLoginContainer`
Summary: Just include "Sign in" button and make sure styling/layout is correct. The button is completely nonfunctional for now.
Test Plan:
Here's what it looks like:
{F334197}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/siwe.css",
"new_path": "web/account/siwe.css",
"diff": "@@ -27,15 +27,21 @@ div.siweLoginFormContainer p {\ncolor: white;\nfont-family: sans-serif;\ntext-align: center;\n- padding-top: 14px;\n+ padding-bottom: 20px;\nfont-size: 14px;\n}\n+div.siweL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add "Sign in" button to `siweLoginContainer`
Summary: Just include "Sign in" button and make sure styling/layout is correct. The button is completely nonfunctional for now.
Test Plan:
Here's what it looks like:
{F334197}
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.de... |
129,187 | 20.01.2023 10:01:51 | 18,000 | 9cc88331d4c30d3c825cccd72b07595b1f90eaab | [lib] Add getAddressForName to ENSCache
Summary:
This is the second step to this Linear task: [ENG-2588](https://linear.app/comm/issue/ENG-2588/vanilla-js-object-for-querying-caching-ens-names)
Depends on D6264
Test Plan:
```
ALCHEMY_API_KEY=alchemykeygoeshere yarn test utils/ens-cache.test.js
```
Reviewers: atul
Subsc... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/ens-cache.js",
"new_path": "lib/utils/ens-cache.js",
"diff": "@@ -6,6 +6,7 @@ const cacheTimeout = 24 * 60 * 60 * 1000; // one day\ntype EthersProvider = {\n+lookupAddress: (address: string) => Promise<?string>,\n+ +resolveName: (name: string) => Pro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add getAddressForName to ENSCache
Summary:
This is the second step to this Linear task: [ENG-2588](https://linear.app/comm/issue/ENG-2588/vanilla-js-object-for-querying-caching-ens-names)
Depends on D6264
Test Plan:
```
ALCHEMY_API_KEY=alchemykeygoeshere yarn test utils/ens-cache.test.js
```
Reviewers: atul
... |
129,187 | 21.01.2023 16:59:54 | 18,000 | 412c2a1ab302e9a38997ce38848a599e8b8b74ef | [web] Factor out prettyDateWithoutDay
Summary: I'll use this in the next diff.
Test Plan: Flow
Reviewers: atul, ginsu
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/date-utils.js",
"new_path": "lib/utils/date-utils.js",
"diff": "@@ -69,6 +69,10 @@ function prettyDate(dayString: string): string {\nreturn dateFormat(dateFromString(dayString), 'dddd, mmmm dS, yyyy');\n}\n+function prettyDateWithoutDay(dayString: st... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Factor out prettyDateWithoutDay
Summary: I'll use this in the next diff.
Test Plan: Flow
Reviewers: atul, ginsu
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6333 |
129,184 | 23.01.2023 15:20:52 | 18,000 | c21d834bd1cf22ecd80948d53d7116ae4bfaaa38 | [web] Proactively fetch `siweNonce` once user has indicated they intend to SIWE
Summary: Context: https://linear.app/comm/issue/ENG-2741/[web]-proactively-fetch-nonce-once-user-has-indicated-they-intend-to
Test Plan: Works as expected:
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/siwe.react.js",
"new_path": "web/account/siwe.react.js",
"diff": "@@ -84,10 +84,18 @@ function SIWE(): React.Node {\nconst logInExtraInfo = useSelector(webLogInExtraInfoSelector);\nconst [siweNonce, setSIWENonce] = React.useState<?string>(null);\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Proactively fetch `siweNonce` once user has indicated they intend to SIWE
Summary: Context: https://linear.app/comm/issue/ENG-2741/[web]-proactively-fetch-nonce-once-user-has-indicated-they-intend-to
Test Plan: Works as expected:
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://pha... |
129,187 | 21.01.2023 14:55:52 | 18,000 | 9d065d8cdf770e235cd22eaa56250e59e165a9b4 | [native] Fix typo in CommunityDrawerItemCommunity
Test Plan: Flow
Reviewers: inka
Subscribers: tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/community-drawer-content.react.js",
"new_path": "native/navigation/community-drawer-content.react.js",
"diff": "@@ -15,7 +15,7 @@ import { type ThreadInfo, communitySubthreads } from 'lib/types/thread-types';\nimport { useNavigateToThread } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix typo in CommunityDrawerItemCommunity
Test Plan: Flow
Reviewers: inka
Reviewed By: inka
Subscribers: tomek, atul
Differential Revision: https://phab.comm.dev/D6329 |
129,184 | 24.01.2023 12:51:06 | 18,000 | cb1fb3254d8740b3b3f5161092594c65ed0b6386 | [web] Allow account deletion for SIWE accounts
Summary:
Context:
Basically D6099, but for `web` instead of `native`.
Test Plan:
1. Able to successfully delete SIWE account:
{F340077}
{F340265}
{F340075}
2. "Traditional" account deletion continues to work as expected:
Reviewers: ashoat, tomek, marcin | [
{
"change_type": "MODIFY",
"old_path": "web/settings/account-delete-modal.react.js",
"new_path": "web/settings/account-delete-modal.react.js",
"diff": "@@ -10,6 +10,7 @@ import {\nimport { useModalContext } from 'lib/components/modal-provider.react';\nimport { preRequestUserStateSelector } from 'lib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Allow account deletion for SIWE accounts
Summary:
Context: https://linear.app/comm/issue/ENG-2586/do-not-require-password-when-deleting-siwe-account-on-web
Basically D6099, but for `web` instead of `native`.
Test Plan:
1. Able to successfully delete SIWE account:
{F340077}
{F340265}
{F340075}
2. "Traditional... |
129,205 | 30.11.2022 12:01:48 | -3,600 | 78858e96cb8d88c05c2668ffcffe9e7f59f64b34 | [services][blob] Add derive_more dependency
Summary:
Add new dependency to make further error handling much easier.
This dependency is used the same way in identity and backup services.
Test Plan: Cargo project builds.
Reviewers: ashoat, varun, jon
Subscribers: tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "services/blob/Cargo.lock",
"new_path": "services/blob/Cargo.lock",
"diff": "@@ -481,6 +481,7 @@ dependencies = [\n\"aws-sdk-s3\",\n\"aws-types\",\n\"chrono\",\n+ \"derive_more\",\n\"prost\",\n\"tokio\",\n\"tokio-stream\",\n@@ -558,6 +559,12 @@ dependencies = [... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][blob] Add derive_more dependency
Summary:
Add new dependency to make further error handling much easier.
This dependency is used the same way in identity and backup services.
Test Plan: Cargo project builds.
Reviewers: ashoat, varun, jon
Reviewed By: ashoat
Subscribers: tomek, atul
Differential Revisio... |
129,205 | 30.11.2022 12:22:00 | -3,600 | ad69b4faf480b233d47e2427b88fd296b3bbd720 | [services][blob] Define database error types
Summary:
Defined error enums and structures to be used in `DatabaseClient`.
This code is very similar to the identity and backup service approach.
Depends on D5855
Test Plan: Cargo check doesn't complain.
Reviewers: varun, jon, tomek, michal
Subscribers: ashoat, atul | [
{
"change_type": "MODIFY",
"old_path": "services/blob/src/database.rs",
"new_path": "services/blob/src/database.rs",
"diff": "use anyhow::{anyhow, Context, Result};\n-use aws_sdk_dynamodb::{model::AttributeValue, output::GetItemOutput};\n+use aws_sdk_dynamodb::{\n+ model::AttributeValue, output::Get... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][blob] Define database error types
Summary:
Defined error enums and structures to be used in `DatabaseClient`.
This code is very similar to the identity and backup service approach.
Depends on D5855
Test Plan: Cargo check doesn't complain.
Reviewers: varun, jon, tomek, michal
Reviewed By: varun, jon, tom... |
129,184 | 24.01.2023 15:22:39 | 18,000 | 8c7b9c52690849387427e3e5b2947a28308b7d25 | [web] Don't show option to change password for SIWE accounts
Summary: Pretty straightforward, we just hide this setting for accounts that have signed in with Ethereum (based solely on `accountHasPassword` check).
Test Plan:
SIWE Account:
{F342071}
"Traditional" account:
{F342072}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/settings/account-settings.react.js",
"new_path": "web/settings/account-settings.react.js",
"diff": "@@ -5,6 +5,7 @@ import * as React from 'react';\nimport { logOut, logOutActionTypes } from 'lib/actions/user-actions';\nimport { useModalContext } from 'lib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Don't show option to change password for SIWE accounts
Summary: Pretty straightforward, we just hide this setting for accounts that have signed in with Ethereum (based solely on `accountHasPassword` check).
Test Plan:
SIWE Account:
{F342071}
"Traditional" account:
{F342072}
Reviewers: ashoat, tomek
Reviewe... |
129,187 | 16.01.2023 20:35:40 | 25,200 | c92105f7272c5402b8eca75103b0072a207f488a | [lib] Introduce ENSCacheProvider
Summary: Depends on D6371
Test Plan: Tested together with following diffs
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/components/ens-cache-provider.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import { ENSCache, type EthersProvider } from '../utils/ens-cache';\n+\n+type ENSCacheContextType = {\n+ +ensCache: ?ENSCache,\n+};\n+const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce ENSCacheProvider
Summary: Depends on D6371
Test Plan: Tested together with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6372 |
129,187 | 23.01.2023 22:07:31 | 18,000 | 46391562f7fd3a08fa5312088e62e4d5c17b5823 | [native] Configure ENSCacheProvider
Summary: Depends on D6372
Test Plan: Tested together with following diffs
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/.gitignore",
"new_path": "native/.gitignore",
"diff": "@@ -59,6 +59,7 @@ android/app/.cxx/\ncodegen/dist\nfacts/network.json\n+facts/alchemy.json\n# Expo\n.expo\n"
},
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_pat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Configure ENSCacheProvider
Summary: Depends on D6372
Test Plan: Tested together with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6373 |
129,187 | 23.01.2023 22:09:32 | 18,000 | d46caaa12dc9edc1d22c653b36dd5aedad868c34 | [web] Configure ENSCacheProvider
Summary: Depends on D6373
Test Plan: Tested together with following diffs
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/siwe.react.js",
"new_path": "web/account/siwe.react.js",
"diff": "@@ -5,7 +5,6 @@ import '@rainbow-me/rainbowkit/dist/index.css';\nimport {\nConnectButton,\ndarkTheme,\n- getDefaultWallets,\nRainbowKitProvider,\nuseConnectModal,\n} from '@rainbow-m... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Configure ENSCacheProvider
Summary: Depends on D6373
Test Plan: Tested together with following diffs
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6374 |
129,178 | 24.01.2023 16:35:43 | 18,000 | 6fff0861a75ec5778e0cc285bbc26fbd81eae126 | [web] add emoji-mart dependency
Summary:
Add `emoji-mart` dependency.
Linear Task: [[ | ]]
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "},\n\"dependencies\": {\n\"@babel/runtime\": \"^7.13.10\",\n+ \"@emoji-mart/data\": \"^1.1.2\",\n+ \"@emoji-mart/react\": \"^1.1.1\",\n\"@fortawesome/fontawesome-svg-core\": \"1.2.25\",\n\"@fortawesom... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add emoji-mart dependency
Summary:
Add `emoji-mart` dependency. https://github.com/missive/emoji-mart#-data
---
Linear Task: [[ https://linear.app/comm/issue/ENG-2776/implement-web-emoji-keyboard-library | ENG-2776 ]]
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, tom... |
129,196 | 02.01.2023 15:41:00 | -3,600 | c3a74431925b77c3bf0da37923e604898de62ad5 | Remove all react-native-notifications usages on iOS
Summary: This differential replaces all remaining usages of NotificationsIOS with CommIOSNotifications.
Test Plan: Ensure that updating badge count, removing and getting all delivered notifications work in JavaScript.
Reviewers: tomek, atul
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/push/push-handler.react.js",
"new_path": "native/push/push-handler.react.js",
"diff": "@@ -5,7 +5,6 @@ import * as React from 'react';\nimport { AppRegistry, Platform, Alert, LogBox } from 'react-native';\nimport type { RemoteMessage, NotificationOpen }... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove all react-native-notifications usages on iOS
Summary: This differential replaces all remaining usages of NotificationsIOS with CommIOSNotifications.
Test Plan: Ensure that updating badge count, removing and getting all delivered notifications work in JavaScript.
Reviewers: tomek, atul
Reviewed By: tomek
Sub... |
129,178 | 27.01.2023 13:46:58 | 18,000 | 1e4d2f13f1389fae9df58cfe1415010d5e70d179 | [native] add rn-emoji-keyboard dependency
Summary:
Add `rn-emoji-keyboard` dependency.
Test Plan: N/A
Reviewers: atul, tomek, ashoat
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"redux-persist\": \"^6.0.0\",\n\"redux-thunk\": \"^2.2.0\",\n\"reselect\": \"^4.0.0\",\n+ \"rn-emoji-keyboard\": \"^1.2.0\",\n\"shallowequal\": \"^1.0.2\",\n\"simple-markdown\": \"^0.7.2\",\n\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add rn-emoji-keyboard dependency
Summary:
Add `rn-emoji-keyboard` dependency.
https://github.com/TheWidlarzGroup/rn-emoji-keyboard
Test Plan: N/A
Reviewers: atul, tomek, ashoat
Reviewed By: ashoat
Subscribers: ashoat, tomek, atul
Differential Revision: https://phab.comm.dev/D6413 |
129,184 | 27.01.2023 15:33:54 | 18,000 | 7ec720ec655e5f1ff1d75104d62294284ee29988 | [web][landing] Add legal acknowledgements to SIWE flow
Summary:
Context:
Add Terms of Use and Privacy Policy acknowledment to SIWE flow.
Test Plan:
Looks as expected:
{F346323}
{F346324}
Reviewers: ashoat, tomek, kamil | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -136,6 +136,11 @@ function SIWE(): React.Node {\n</div>\n<p>{siweMessageSigningExplanationStatements[0]}</p>\n<p>{siweMessageSigningExplanationStatements[1]}</p>\n+ <p>\n+ By signing up, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web][landing] Add legal acknowledgements to SIWE flow
Summary:
Context: https://linear.app/comm/issue/ENG-2835/disable-auto-accepting-policies-after-siwe
Add Terms of Use and Privacy Policy acknowledment to SIWE flow.
Test Plan:
Looks as expected:
{F346323}
{F346324}
Reviewers: ashoat, tomek, kamil
Reviewed By: ... |
129,187 | 27.01.2023 15:15:27 | 18,000 | 1518d021a5522f637f48b2415176ecf992fd298c | [native] Show your ENS name in ProfileScreen
Summary: Depends on D6420
Test Plan: {F348006}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -4,6 +4,7 @@ import * as React from 'react';\nimport { View, Text, Alert, Platform, ScrollView } from 'react-native';\nimport { logOutActionTypes, logOut... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show your ENS name in ProfileScreen
Summary: Depends on D6420
Test Plan: {F348006}
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6421 |
129,187 | 27.01.2023 15:29:53 | 18,000 | 61873cfc55a481c535951af9a0c262afe45d5794 | [web] Show your ENS name in AccountSettings
Summary: Depends on D6421
Test Plan: {F348035}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/settings/account-settings.react.js",
"new_path": "web/settings/account-settings.react.js",
"diff": "@@ -4,6 +4,7 @@ import * as React from 'react';\nimport { logOut, logOutActionTypes } from 'lib/actions/user-actions';\nimport { useModalContext } from 'lib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Show your ENS name in AccountSettings
Summary: Depends on D6421
Test Plan: {F348035}
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6422 |
129,187 | 27.01.2023 17:39:18 | 18,000 | c78db73720dacdf15b0a5247efa08c052a83ec7d | [lib] Introduce useENSNames to fetch more than one ENS name at a time
Summary: Also rewrite `useStringForUser` to call into `useENSNames`.
Test Plan: Tested existing calls of `useStringForUser`, both when logged in as an ENS user and when not
Reviewers: atul, tomek
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/ens-cache.js",
"new_path": "lib/hooks/ens-cache.js",
"diff": "// @flow\n+import invariant from 'invariant';\nimport * as React from 'react';\nimport { ENSCacheContext } from '../components/ens-cache-provider.react';\nimport { userIdentifiedByETHAddre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce useENSNames to fetch more than one ENS name at a time
Summary: Also rewrite `useStringForUser` to call into `useENSNames`.
Test Plan: Tested existing calls of `useStringForUser`, both when logged in as an ENS user and when not
Reviewers: atul, tomek
Reviewed By: atul
Subscribers: tomek
Differentia... |
129,187 | 27.01.2023 21:15:36 | 18,000 | 7c1472dcc4293a66ec05a466059794b6e18166a0 | [lib] createMessageReactionsList -> useMessageReactionsList for ENS fetching
Summary: Depends on D6423
Test Plan:
| `native` | `web` |
| {F348467} | {F348468} |
Reviewers: atul, ginsu
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/reaction-utils.js",
"new_path": "lib/shared/reaction-utils.js",
"diff": "import invariant from 'invariant';\nimport _sortBy from 'lodash/fp/sortBy';\n+import * as React from 'react';\n+import { useENSNames } from '../hooks/ens-cache';\nimport type {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] createMessageReactionsList -> useMessageReactionsList for ENS fetching
Summary: Depends on D6423
Test Plan:
| `native` | `web` |
| {F348467} | {F348468} |
Reviewers: atul, ginsu
Reviewed By: ginsu
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6424 |
129,187 | 28.01.2023 07:21:06 | 18,000 | 85afa94f1918f4bce56a7a4929f9d6cbbb1018e9 | [native][web] Show ENS name for message author
Test Plan:
| `web` | `native` |
| {F348672} | {F348673} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-header.react.js",
"new_path": "native/chat/message-header.react.js",
"diff": "import * as React from 'react';\nimport { View } from 'react-native';\n-import { stringForUser } from 'lib/shared/user-utils';\n+import { useStringForUser } from ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][web] Show ENS name for message author
Test Plan:
| `web` | `native` |
| {F348672} | {F348673} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6425 |
129,187 | 28.01.2023 09:43:58 | 18,000 | 6cecac813123478d004b2b610e4a5dd347cbaeb2 | [lib] Factor out normalization functions in ENSCache
Summary: They're already used three times each, and I'm about to introduce new usages. I think it's better for this logic to be in one place.
Test Plan: `cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js`
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/ens-cache.js",
"new_path": "lib/utils/ens-cache.js",
"diff": "@@ -22,6 +22,17 @@ type ENSAddressQueryCacheEntry = {\n+normalizedETHAddress: ?string,\n};\n+const normalizeETHAddress = (ethAddress: string) => ethAddress.toLowerCase();\n+\n+// Note: thi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Factor out normalization functions in ENSCache
Summary: They're already used three times each, and I'm about to introduce new usages. I think it's better for this logic to be in one place.
Test Plan: `cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js`
Reviewers: atul
Reviewed By: atul
Subscribe... |
129,187 | 28.01.2023 10:00:25 | 18,000 | 161b292056677fbc58e8550897a0f745b1b7b09c | [lib] Factor out constants in ENSCache tests
Summary: Depends on D6426
Test Plan: `cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js`
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/ens-cache.test.js",
"new_path": "lib/utils/ens-cache.test.js",
"diff": "@@ -32,43 +32,38 @@ if (!process.env.ALCHEMY_API_KEY) {\n);\n}\n+const ashoatDotEth = 'ashoat.eth';\n+const ashoatAddr = '0x911413ef4127910d79303483f7470d095f399ca9';\n+\ndescrib... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Factor out constants in ENSCache tests
Summary: Depends on D6426
Test Plan: `cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js`
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6427 |
129,187 | 28.01.2023 10:04:15 | 18,000 | aa4d57b3bdc7def604f9cee60ac1bb9b32397098 | [lib] Modify ENSCache test so ETH address normalization is checked
Summary: Depends on D6427
Test Plan: `cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js`
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/ens-cache.test.js",
"new_path": "lib/utils/ens-cache.test.js",
"diff": "@@ -62,7 +62,9 @@ describe('getNameForAddress', () => {\nreturn;\n}\nconst timesLookupAddressCalledBefore = timesLookupAddressCalled;\n- const ashoatEthResult = await ensCache.ge... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify ENSCache test so ETH address normalization is checked
Summary: Depends on D6427
Test Plan: `cd lib && ALCHEMY_API_KEY=... yarn test utils/ens-cache.test.js`
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6428 |
129,187 | 28.01.2023 11:39:58 | 18,000 | d2035f3047a6a0c640853aca1a4bba0f89fa2b06 | [native] Use ENS names inside ThreadSettings
Summary: Note that I'll handle the title of the `ThreadSettings` ReactNav screen in a separate diff, as that will require a new component.
Test Plan: | {F349050} | {F349049} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-edit-relationship.react.js",
"new_path": "native/chat/settings/thread-settings-edit-relationship.react.js",
"diff": "@@ -8,6 +8,7 @@ import {\nupdateRelationships as serverUpdateRelationships,\nupdateRelationshipsActionType... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use ENS names inside ThreadSettings
Summary: Note that I'll handle the title of the `ThreadSettings` ReactNav screen in a separate diff, as that will require a new component.
Test Plan: | {F349050} | {F349049} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm... |
129,196 | 11.01.2023 14:23:32 | -3,600 | fff47cdc03bc002efda8aff81b06d99c2676cf96 | Remove threadID to notifID mapping from redux and all related usages
Summary: This differential removes threadID to NotifID mapping from redux on native.
Test Plan: Test plan for previous differential + ensure flow does not complain.
Reviewers: tomek, atul, ashoat
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/push/android.js",
"new_path": "native/push/android.js",
"diff": "@@ -6,11 +6,7 @@ import type { RemoteMessage } from 'react-native-firebase';\nimport { mergePrefixIntoBody } from 'lib/shared/notif-utils';\n-import {\n- recordAndroidNotificationActionTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove threadID to notifID mapping from redux and all related usages
Summary: This differential removes threadID to NotifID mapping from redux on native.
Test Plan: Test plan for previous differential + ensure flow does not complain.
Reviewers: tomek, atul, ashoat
Reviewed By: tomek, ashoat
Subscribers: ashoat
Di... |
129,187 | 28.01.2023 20:53:37 | 18,000 | f48a3d5afa1187f40191b2d37e3d3d05533bd898 | [web] Fetch ENS names in SubchannelMembersList
Test Plan: | {F349437} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/create/steps/subchannel-members-list.react.js",
"new_path": "web/modals/threads/create/steps/subchannel-members-list.react.js",
"diff": "import * as React from 'react';\nimport { useSelector } from 'react-redux';\n+import { useENSNames } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fetch ENS names in SubchannelMembersList
Test Plan: | {F349437} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6437 |
129,187 | 29.01.2023 11:12:31 | 18,000 | 98bd8e9cd0c47e022382341716572fb3bd1351ff | [web] Fetch ENS names in MembersList
Test Plan: | {F349808} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/members/members-list.react.js",
"new_path": "web/modals/threads/members/members-list.react.js",
"diff": "@@ -5,6 +5,7 @@ import _groupBy from 'lodash/fp/groupBy';\nimport _toPairs from 'lodash/fp/toPairs';\nimport * as React from 'react';\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fetch ENS names in MembersList
Test Plan: | {F349808} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6438 |
129,187 | 29.01.2023 12:35:39 | 18,000 | 38fbf5bf57adb712957a4432a20b90b95b7f6b3f | [native] Show ENS names in ComposeSubchannel
Summary: Depends on D6439
Test Plan: | {F349896} | {F349897} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/compose-subchannel.react.js",
"new_path": "native/chat/compose-subchannel.react.js",
"diff": "@@ -8,6 +8,7 @@ import * as React from 'react';\nimport { View, Text, Alert } from 'react-native';\nimport { newThreadActionTypes, newThread } from 'lib/a... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show ENS names in ComposeSubchannel
Summary: Depends on D6439
Test Plan: | {F349896} | {F349897} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6440 |
129,187 | 29.01.2023 17:10:47 | 18,000 | 6d88dac34ec7903f88eeaa1d0a5dd358ac2f0618 | [native] Show ENS names in AddUsersModal
Summary: Depends on D6441
Test Plan: | {F350110} | {F350111} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/add-users-modal.react.js",
"new_path": "native/chat/settings/add-users-modal.react.js",
"diff": "@@ -8,6 +8,7 @@ import {\nchangeThreadSettingsActionTypes,\nchangeThreadSettings,\n} from 'lib/actions/thread-actions';\n+import { useENSNames... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show ENS names in AddUsersModal
Summary: Depends on D6441
Test Plan: | {F350110} | {F350111} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6442 |
129,187 | 29.01.2023 17:22:06 | 18,000 | 65b1df0644e213bc2c8be6fe89ac7e2ec8ab13d3 | [native] Show ENS names in MessageListThreadSearch
Summary: Thank God this one was already a hook...
Test Plan: | {F350149} | {F350150} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/message-list-thread-search.react.js",
"new_path": "native/chat/message-list-thread-search.react.js",
"diff": "import * as React from 'react';\nimport { Text, View } from 'react-native';\n+import { useENSNames } from 'lib/hooks/ens-cache';\nimport {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Show ENS names in MessageListThreadSearch
Summary: Thank God this one was already a hook...
Test Plan: | {F350149} | {F350150} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6443 |
129,187 | 29.01.2023 18:24:14 | 18,000 | e2f102581b9eb37633e774508ddf4a027f4d1e20 | [web] Fetch ENS names in ChatThreadComposer
Test Plan: | {F350487} | {F350488} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-composer.react.js",
"new_path": "web/chat/chat-thread-composer.react.js",
"diff": "@@ -3,6 +3,7 @@ import classNames from 'classnames';\nimport * as React from 'react';\nimport { useDispatch } from 'react-redux';\n+import { useENSNames } f... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fetch ENS names in ChatThreadComposer
Test Plan: | {F350487} | {F350488} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6449 |
129,187 | 29.01.2023 18:32:46 | 18,000 | ffcd7a1632183d336ddf2a1573cd7a1753a55c72 | [web] Fetch ENS names in AddMembersModal
Test Plan: | {F350514} | {F350515} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/members/add-members-modal.react.js",
"new_path": "web/modals/threads/members/add-members-modal.react.js",
"diff": "@@ -6,6 +6,7 @@ import {\nchangeThreadSettingsActionTypes,\nchangeThreadSettings,\n} from 'lib/actions/thread-actions';\n+impo... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fetch ENS names in AddMembersModal
Test Plan: | {F350514} | {F350515} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6450 |
129,184 | 30.01.2023 13:37:17 | 18,000 | 932d057e9d68a583e6baa26808a398d5eba42d54 | [lib] Introduce `reducePrimaryIdentityPublicKey` reducer
Summary:
Introduce `setPrimaryIdentityPublicKey` action type and `reducePrimaryIdentityPublicKey` reducer.
`setPrimaryIdentityPublicKey` action will be dispatched in subsequent diffs to properly set the `primaryIdentityPublicKey`.
Depends on D6433
Test Plan: Will... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/redux/primary-identity-public-key-reducer.js",
"diff": "+// @flow\n+\n+import {\n+ logOutActionTypes,\n+ deleteAccountActionTypes,\n+} from 'lib/actions/user-actions';\n+import { setNewSessionActionType } from 'lib/utils/action-utils.js';\n+... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `reducePrimaryIdentityPublicKey` reducer
Summary:
Introduce `setPrimaryIdentityPublicKey` action type and `reducePrimaryIdentityPublicKey` reducer.
`setPrimaryIdentityPublicKey` action will be dispatched in subsequent diffs to properly set the `primaryIdentityPublicKey`.
---
Depends on D6433
Test P... |
129,184 | 30.01.2023 16:17:38 | 18,000 | b18d7b64905348d084584b2d58f44986934dd784 | [native] `codeVersion` -> 179 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 179 |
129,184 | 30.01.2023 16:20:53 | 18,000 | 7bad24d6d5ad678c53570a301987b109543a5634 | [native] `codeVersion` -> 180 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 180 |
129,205 | 25.01.2023 09:59:56 | -3,600 | a7374be8b830c89e1dad63426c88520d5fb55803 | [backup-service] Add blob client init function
Summary:
Part of
Created a function that initializes a blob client instance. The connection is lazy-initialized so it won't be established until first use.
Depends on D6383
Test Plan: Backup service compiles.
Reviewers: varun, jon, michal, tomek
Subscribers: ashoat, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/blob/mod.rs",
"new_path": "services/backup/src/blob/mod.rs",
"diff": "mod proto {\ntonic::include_proto!(\"blob\");\n}\n+use proto::blob_service_client::BlobServiceClient;\npub use proto::put_request::Data as PutRequestData;\npub use proto:... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [backup-service] Add blob client init function
Summary:
Part of https://linear.app/comm/issue/ENG-2688/backup-service-reuse-single-blob-client-instance
Created a function that initializes a blob client instance. The connection is lazy-initialized so it won't be established until first use.
Depends on D6383
Test Pla... |
129,187 | 30.01.2023 16:04:29 | 18,000 | 4c635a2108bdd040376cd6aa7b3dd6cb39f8873c | [web] Show ENS names in ThreadSettingsRelationshipTab
Test Plan:
I used [this patch](https://gist.github.com/Ashoat/d53bd37b7273370a81e0428bbb0e34ef) to get ENS to work in my dev environment
| {F352785} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/settings/thread-settings-relationship-tab.react.js",
"new_path": "web/modals/threads/settings/thread-settings-relationship-tab.react.js",
"diff": "import * as React from 'react';\n+import { useENSNames } from 'lib/hooks/ens-cache';\nimport {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Show ENS names in ThreadSettingsRelationshipTab
Test Plan:
I used [this patch](https://gist.github.com/Ashoat/d53bd37b7273370a81e0428bbb0e34ef) to get ENS to work in my dev environment
| {F352785} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6472 |
129,187 | 30.01.2023 16:28:59 | 18,000 | 7d07bbbff04d3ca6873e1ff5092906975a69b9db | [web] Show ENS names for HistoryEntry
Summary: I went ahead and changed `EntryInfo.creator` for this diff. It's a client-only type that's only touched in `web`.
Test Plan:
I used [this patch](https://gist.github.com/Ashoat/d53bd37b7273370a81e0428bbb0e34ef) to get ENS to work in my dev environment
| {F352835} |
Reviewer... | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/entry-utils.js",
"new_path": "lib/shared/entry-utils.js",
"diff": "@@ -48,7 +48,7 @@ function createEntryInfo(\nmonth: rawEntryInfo.month,\nday: rawEntryInfo.day,\ncreationTime: rawEntryInfo.creationTime,\n- creator: creatorInfo && creatorInfo.usern... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Show ENS names for HistoryEntry
Summary: I went ahead and changed `EntryInfo.creator` for this diff. It's a client-only type that's only touched in `web`.
Test Plan:
I used [this patch](https://gist.github.com/Ashoat/d53bd37b7273370a81e0428bbb0e34ef) to get ENS to work in my dev environment
| {F352835} |
Revi... |
129,184 | 31.01.2023 12:05:35 | 18,000 | b542be5d4b3bf082bd6b2dcbc0d64da5e3853dfc | [native] `codeVersion` -> 181 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 181 |
129,184 | 31.01.2023 12:28:35 | 18,000 | 6470d810047cec2dc70c23409158ded6eeabdc68 | [native] `codeVersion` -> 182 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 182 |
129,187 | 30.01.2023 17:47:05 | 18,000 | 472a155c66203ed4552a2ce515ba5b52b8d2923a | [lib] Introduce useThreadSearchIndex hook
Summary:
Converting this to a hook will make it easier to swap in ENS names.
Depends on D6476
Test Plan:
Tested the two surfaces that currently use `useSearchThreads`: `SidebarListModal` and `SubchannelsListModal` on `native`
| {F353504} | {F353505} |
Reviewers: atul, inka
Subs... | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/search-threads.js",
"new_path": "lib/hooks/search-threads.js",
"diff": "@@ -6,9 +6,9 @@ import {\ntype ChatThreadItem,\nuseFilteredChatListData,\n} from '../selectors/chat-selectors';\n+import { useThreadSearchIndex } from '../selectors/nav-selectors... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce useThreadSearchIndex hook
Summary:
Converting this to a hook will make it easier to swap in ENS names.
Depends on D6476
Test Plan:
Tested the two surfaces that currently use `useSearchThreads`: `SidebarListModal` and `SubchannelsListModal` on `native`
| {F353504} | {F353505} |
Reviewers: atul, inka... |
129,184 | 31.01.2023 15:04:43 | 18,000 | 7f30e26bce4ca9d645898edb0d6abd17e61b8b9a | [lib] Add `emote-smile-filled` to `CommIcons`
Summary: Context:
Test Plan:
Here's what it looks like:
{F354084}
{F354085}
Reviewers: ashoat, tomek, ginsu, rohan | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/comm-icon-config.json",
"new_path": "lib/shared/comm-icon-config.json",
"diff": "{\n\"icon\": {\n\"paths\": [\n- \"M658.286 0c-201.947 0-365.714 163.767-365.714 365.714v73.143c-161.573 0-292.571 130.999-292.571 292.571s130.999 292.571 292.571 292.57... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `emote-smile-filled` to `CommIcons`
Summary: Context: https://linear.app/comm/issue/ENG-2886/implement-new-react-icon-for-web-tooltip
Test Plan:
Here's what it looks like:
{F354084}
{F354085}
Reviewers: ashoat, tomek, ginsu, rohan
Reviewed By: ginsu
Differential Revision: https://phab.comm.dev/D6486 |
129,188 | 21.12.2022 12:13:14 | -3,600 | e7245b91cfae54814ee046d6ef9b92ed26cf3410 | [native] add function to set database status after successful structure creation
Summary: Setting Secure Store flag that database structure is properly created
Test Plan: After successful migration process `DatabaseManagerStatus` should equals `WORKABLE`
Reviewers: marcin, tomek
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp",
"diff": "namespace comm {\n-typedef std::string DatabaseManagerStatus;\n-const DatabaseManagerStatus DB_MANAGER_WORKABLE = \"WO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add function to set database status after successful structure creation
Summary: Setting Secure Store flag that database structure is properly created
Test Plan: After successful migration process `DatabaseManagerStatus` should equals `WORKABLE`
Reviewers: marcin, tomek
Reviewed By: marcin, tomek
Subscrib... |
129,188 | 21.12.2022 12:28:03 | -3,600 | 78591724e16f3d6f9aaf8041e07724d652c37dee | [native] throw exception when migration process will fail
Summary: Context in [ENG-2068](https://linear.app/comm/issue/ENG-2068/update-migration-code-to-throw-an-error-on-failure)
Test Plan: Force migration and creating new db process to fail and check if exception is thrown
Reviewers: marcin, tomek
Subscribers: ashoat... | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -694,7 +694,12 @@ void SQLiteQueryExecutor::migrate() {\nLogger::log(version_msg.str());\nif (db_version ==... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] throw exception when migration process will fail
Summary: Context in [ENG-2068](https://linear.app/comm/issue/ENG-2068/update-migration-code-to-throw-an-error-on-failure)
Test Plan: Force migration and creating new db process to fail and check if exception is thrown
Reviewers: marcin, tomek
Reviewed By: ma... |
129,184 | 01.02.2023 14:03:10 | 18,000 | c8787e79d2e37139986003c2d375766a3d5122fd | [CI] Add automatic retries to Buildkite workflows
Summary:
Context:
Should hopefully reduce the number of times that developers will need to manually restart workflows.
Test Plan: NA, see what happens
Reviewers: tomek, marcin, jon, ashoat, ginsu, rohan, varun | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/android.yml",
"new_path": ".buildkite/android.yml",
"diff": "@@ -9,6 +9,8 @@ steps:\n- 'yarn cleaninstall --frozen-lockfile --skip-optional'\n- 'cd native/android'\n- './gradlew clean && ./gradlew bundleRelease --no-daemon \"-Dorg.gradle.jvmargs=-Xm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Add automatic retries to Buildkite workflows
Summary:
Context: https://buildkite.com/docs/pipelines/command-step#retry-attributes-automatic-retry-attributes
Should hopefully reduce the number of times that developers will need to manually restart workflows.
Test Plan: NA, see what happens
Reviewers: tomek, mar... |
129,181 | 19.01.2023 23:30:22 | -3,600 | 4db32ecb9f2badbea89d1d3525a344444c226465 | [services] [electron update server] Add a Dockerfile
Summary: For easy distribution we need to package the update server into a container like the rest of the services.
Test Plan: Check if the update server correctly runs inside docker
Reviewers: atul, jon, varun, ashoat
Subscribers: ashoat, tomek | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/electron-update-server/Dockerfile",
"diff": "+FROM node:16.18.0-bullseye\n+\n+WORKDIR /home/comm/\n+\n+COPY package.json yarn.lock postinstall.sh ./\n+COPY patches patches/\n+\n+COPY package.json yarn.lock postinstall.sh ./\n+COPY lib/p... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] [electron update server] Add a Dockerfile
Summary: For easy distribution we need to package the update server into a container like the rest of the services.
Test Plan: Check if the update server correctly runs inside docker
Reviewers: atul, jon, varun, ashoat
Reviewed By: ashoat
Subscribers: ashoat, to... |
129,188 | 01.02.2023 16:00:33 | -3,600 | 99ec0f13fd0473dac1748522d3ddc34fd8a199d5 | [keyserver] enable accepting policies feature
Summary: Updating code version because feature is released. Setting date to run script properly.
Test Plan:
1. Test if `yarn script dist/scripts/force-policy-acknowledgment.js` works properly.
2. Test if accepting policy works on native
Reviewers: atul, tomek, inka
Subscrib... | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/user-responders.js",
"new_path": "keyserver/src/responders/user-responders.js",
"diff": "@@ -230,7 +230,7 @@ async function processSuccessfulLogin(\nif (\nnotAcknowledgedPolicies.length &&\n- hasMinCodeVersion(viewer.platformDetails, 1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] enable accepting policies feature
Summary: Updating code version because feature is released. Setting date to run script properly.
Test Plan:
1. Test if `yarn script dist/scripts/force-policy-acknowledgment.js` works properly.
2. Test if accepting policy works on native
Reviewers: atul, tomek, inka
Revi... |
129,200 | 02.02.2023 11:30:05 | 18,000 | 132c2ddb011132ab7ca2870008407c4d8314facd | [scripts] make install_protobuf script work on macos
Summary: nproc isn't a command on macos, so we need to use sysctl if it's not available
Test Plan: CI passes
Reviewers: jon
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "scripts/install_protobuf.sh",
"new_path": "scripts/install_protobuf.sh",
"diff": "@@ -18,7 +18,7 @@ cmake ../cmake \\\n-Dprotobuf_ABSL_PROVIDER=package \\\n-Dprotobuf_BUILD_TESTS=OFF\n-make install -j \"$(nproc)\" -l \"$(nproc)\"\n+make install -j \"$(nproc ||... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [scripts] make install_protobuf script work on macos
Summary: nproc isn't a command on macos, so we need to use sysctl if it's not available
Test Plan: CI passes
Reviewers: jon
Reviewed By: jon
Subscribers: ashoat, tomek, atul
Differential Revision: https://phab.comm.dev/D6525 |
129,187 | 01.02.2023 14:43:56 | 18,000 | 9bf4b234aafb0c65b48a0bd2507d521694c1b436 | [lib] Add helpers for EntityText
Summary:
These helpers will be used by code that composes `EntityText`s.
Depends on D6508
Test Plan: Tested in combination with the following diffs
Reviewers: atul, tomek, ginsu | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/entity-text.js",
"new_path": "lib/utils/entity-text.js",
"diff": "@@ -5,7 +5,12 @@ import * as React from 'react';\nimport { threadNoun } from '../shared/thread-utils';\nimport { stringForUser } from '../shared/user-utils';\n-import { threadTypes, ty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add helpers for EntityText
Summary:
These helpers will be used by code that composes `EntityText`s.
Depends on D6508
Test Plan: Tested in combination with the following diffs
Reviewers: atul, tomek, ginsu
Reviewed By: tomek
Differential Revision: https://phab.comm.dev/D6509 |
129,187 | 01.02.2023 08:35:39 | 18,000 | 216451b11dd9da5b4cc1433f4b1c480db60092e9 | [lib] Use pluralize in robotextForUsers
Summary: Seems like this code is just duplicated. I checked the unit tests for `pluralize` and they seem to do exactly what we want here.
Test Plan: Played around with robotext messages and they all look right
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/message-utils.js",
"new_path": "lib/shared/message-utils.js",
"diff": "@@ -32,6 +32,7 @@ import type {\nimport { type ThreadInfo } from '../types/thread-types';\nimport type { RelativeUserInfo, UserInfos } from '../types/user-types';\nimport { type ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Use pluralize in robotextForUsers
Summary: Seems like this code is just duplicated. I checked the unit tests for `pluralize` and they seem to do exactly what we want here.
Test Plan: Played around with robotext messages and they all look right
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differentia... |
129,187 | 01.02.2023 16:49:57 | 18,000 | a95f14bef0930cda8dc1bd1155668c5927278e27 | [lib] Introduce basePluralize
Summary:
In the next diff, I introduce a function that pluralizes `EntityText`. This diff factors out the shared functionality.
Depends on D6510
Test Plan: The test cases in `lib/utils/text-utils.test.js` are extremely thorough
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/text-utils.js",
"new_path": "lib/utils/text-utils.js",
"diff": "// @flow\n-function pluralize(\n- nouns: $ReadOnlyArray<string>,\n+function basePluralize<T>(\n+ nouns: $ReadOnlyArray<T>,\nmaxNumberOfNouns: number = 3,\n-): string {\n+ composeFunc: (T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce basePluralize
Summary:
In the next diff, I introduce a function that pluralizes `EntityText`. This diff factors out the shared functionality.
Depends on D6510
Test Plan: The test cases in `lib/utils/text-utils.test.js` are extremely thorough
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Di... |
129,187 | 01.02.2023 16:54:20 | 18,000 | 691ad069529f09ea7c780712c8c00232a66791d0 | [lib] Convert AddMembers/RemoveMembers robotext to use EntityText
Summary: Depends on D6511
Test Plan: Looked at an `AddMembers` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "@@ -15,6 +15,11 @@ import type {\nimport type { NotifTexts } from '../../types/notif-types';\nimport type { ThreadInfo } from '../../types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert AddMembers/RemoveMembers robotext to use EntityText
Summary: Depends on D6511
Test Plan: Looked at an `AddMembers` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.de... |
129,187 | 01.02.2023 16:55:15 | 18,000 | 3e3b36eb26bb053ec8b5046a0b06f1c8de927bfa | [lib] Convert ChangeSettings robotext to use EntityText
Summary: Depends on D6512
Test Plan: Looked at a `ChangeSettings` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-settings-message-spec.js",
"new_path": "lib/shared/messages/change-settings-message-spec.js",
"diff": "@@ -16,6 +16,7 @@ import type { NotifTexts } from '../../types/notif-types';\nimport { assertThreadType } from '../../types/thread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert ChangeSettings robotext to use EntityText
Summary: Depends on D6512
Test Plan: Looked at a `ChangeSettings` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6513 |
129,187 | 01.02.2023 18:36:41 | 18,000 | 950fbd9cd274e012229b29201786cf095bf047ee | [lib] Convert ChangeRole robotext to use EntityText
Summary: Depends on D6513
Test Plan: Looked at a `ChangeRole` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-role-message-spec.js",
"new_path": "lib/shared/messages/change-role-message-spec.js",
"diff": "@@ -15,6 +15,11 @@ import type {\nimport type { NotifTexts } from '../../types/notif-types';\nimport type { ThreadInfo } from '../../types... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert ChangeRole robotext to use EntityText
Summary: Depends on D6513
Test Plan: Looked at a `ChangeRole` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6514 |
129,187 | 01.02.2023 18:47:25 | 18,000 | 6372f7462204bd3d70e56f3c1681833104a1bc53 | [lib] Convert JoinThread/LeaveThread robotext to use EntityText
Test Plan: Looked at a `JoinThread` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/join-thread-message-spec.js",
"new_path": "lib/shared/messages/join-thread-message-spec.js",
"diff": "@@ -15,6 +15,7 @@ import type {\nimport type { NotifTexts } from '../../types/notif-types';\nimport type { ThreadInfo } from '../../types/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert JoinThread/LeaveThread robotext to use EntityText
Test Plan: Looked at a `JoinThread` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6515 |
129,187 | 01.02.2023 19:15:24 | 18,000 | d9dfc704a93362afff4ce31f7c54280a41939ff9 | [lib] Convert entry robotexts to use EntityText
Summary: Depends on D6515
Test Plan: Looked at a `CreateEntry` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-entry-message-spec.js",
"new_path": "lib/shared/messages/create-entry-message-spec.js",
"diff": "@@ -16,6 +16,7 @@ import type { NotifTexts } from '../../types/notif-types';\nimport type { ThreadInfo } from '../../types/thread-types'... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert entry robotexts to use EntityText
Summary: Depends on D6515
Test Plan: Looked at a `CreateEntry` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6516 |
129,187 | 01.02.2023 20:54:45 | 18,000 | 5fd8fb36ef7880a56c3d1717e615ea976dd954a3 | [lib] Convert CreateSidebar/CreateThread robotext to use EntityText
Summary: Depends on D6517
Test Plan: Looked at a `CreateSidebar` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "@@ -17,6 +17,11 @@ import type { RawUnsupportedMessageInfo } from '../../types/messages/unsupported\nimport type { NotifTexts } from... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert CreateSidebar/CreateThread robotext to use EntityText
Summary: Depends on D6517
Test Plan: Looked at a `CreateSidebar` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.com... |
129,187 | 01.02.2023 21:07:34 | 18,000 | adccdeb5dec21a1d1f8d65187aa6b852bf49558b | [lib] Convert UpdateRelationship robotext to use EntityText
Summary: Depends on D6519
Test Plan: Looked at an `UpdateRelationship` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/update-relationship-message-spec.js",
"new_path": "lib/shared/messages/update-relationship-message-spec.js",
"diff": "@@ -17,6 +17,7 @@ import type {\nimport type { NotifTexts } from '../../types/notif-types';\nimport type { ThreadInfo } fr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert UpdateRelationship robotext to use EntityText
Summary: Depends on D6519
Test Plan: Looked at an `UpdateRelationship` robotext on web and native, both from the perspective of the viewer and of somebody else
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.... |
129,187 | 01.02.2023 21:09:27 | 18,000 | ebdd947d7d78d0c968873bef5c01e20fffdb01ab | [lib] Convert Unsupported robotext to use EntityText
Summary: Depends on D6520
Test Plan: Flow
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/unsupported-message-spec.js",
"new_path": "lib/shared/messages/unsupported-message-spec.js",
"diff": "@@ -11,6 +11,7 @@ import type {\nUnsupportedMessageInfo,\n} from '../../types/messages/unsupported';\nimport type { RelativeUserInfo } fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Convert Unsupported robotext to use EntityText
Summary: Depends on D6520
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6521 |
129,187 | 02.02.2023 09:30:38 | 18,000 | dbde4a826a66f0b1e5f93eea09084537527825d6 | [web] Convert RobotextMessage to hook
Summary:
This will make it a little easier to call `useENSNames`, and the component is better suited as a hook anyways.
Depends on D6526
Test Plan: Make sure that robotext messages still render on web. Also Flow
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "web/chat/robotext-message.react.js",
"new_path": "web/chat/robotext-message.react.js",
"diff": "@@ -26,60 +26,62 @@ const availableTooltipPositionsForRobotext = [\ntooltipPositions.RIGHT_BOTTOM,\n];\n-type BaseProps = {\n+type Props = {\n+item: RobotextChatMes... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Convert RobotextMessage to hook
Summary:
This will make it a little easier to call `useENSNames`, and the component is better suited as a hook anyways.
Depends on D6526
Test Plan: Make sure that robotext messages still render on web. Also Flow
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differenti... |
129,187 | 02.02.2023 09:31:43 | 18,000 | 6f9d494a4ad01107a1a2f8aeff0b8e401acdfcba | [lib][native][web] Fetch ENS names for robotext messages
Summary:
Woohoo!!
Depends on D6527
Test Plan:
| `web` | `native` |
| {F358142} | {F358143} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/entity-text.js",
"new_path": "lib/utils/entity-text.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\n+import { useENSNames } from '../hooks/ens-cache';\nimport { threadNoun } from '../shared/thread-utils';\nimport { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][native][web] Fetch ENS names for robotext messages
Summary:
Woohoo!!
Depends on D6527
Test Plan:
| `web` | `native` |
| {F358142} | {F358143} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6528 |
129,184 | 02.02.2023 15:42:17 | 18,000 | aa8960579695bb6059c1a268fbe46a7e11336133 | [web] Change `modal_body` colors in `log-in-form.css`
Summary: Modify `modal_body` colors and replace outer glow with outline to match the SIWE web designs (https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=7646%3A134916&t=6T70eVfC0cqPSbXJ-1)
Test Plan:
Before:
{F353927}
After:
{F353928}
Re... | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "@@ -6,8 +6,8 @@ div.modal_body {\nmin-width: 320px;\npadding: 20px 40px;\nborder-radius: 16px;\n- background-color: var(--modal-bg);\n- box-shadow: 0 0 40px rgba(126, 87, 194, 0.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Change `modal_body` colors in `log-in-form.css`
Summary: Modify `modal_body` colors and replace outer glow with outline to match the SIWE web designs (https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=7646%3A134916&t=6T70eVfC0cqPSbXJ-1)
Test Plan:
Before:
{F353927}
After:
{F35392... |
129,184 | 02.02.2023 15:11:34 | 18,000 | 875a654c9d7a63a2f28ced6484e65384db8ade6e | [web] Fix "Go back" button copy
Summary: Should be "Back to sing in with username" with left chevron icon instead of just "Go back"
Test Plan: NA, looks as expected
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/siwe-login-form.react.js",
"new_path": "web/account/siwe-login-form.react.js",
"diff": "@@ -33,6 +33,7 @@ import LoadingIndicator from '../loading-indicator.react';\nimport { setPrimaryIdentityPublicKey } from '../redux/primary-identity-public-key-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix "Go back" button copy
Summary: Should be "Back to sing in with username" with left chevron icon instead of just "Go back"
Test Plan: NA, looks as expected
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6536 |
129,184 | 02.02.2023 15:20:31 | 18,000 | 95f6cea97c5102151dee93966d1960b4d7fb22e5 | [web] Add "Sign in with Ethereum" header to `SIWELoginForm`
Summary: Add header to label `SIWELoginForm` and match designs.
Test Plan:
Looks as expected:
{F358585}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/siwe-login-form.react.js",
"new_path": "web/account/siwe-login-form.react.js",
"diff": "@@ -137,6 +137,10 @@ function SIWELoginForm(props: SIWELoginFormProps): React.Node {\nreturn (\n<div className={css.siweLoginFormContainer}>\n+ <h4>Sign in with... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add "Sign in with Ethereum" header to `SIWELoginForm`
Summary: Add header to label `SIWELoginForm` and match designs.
Test Plan:
Looks as expected:
{F358585}
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6537 |
129,184 | 02.02.2023 16:07:14 | 18,000 | 6ec89efb0267f16ec92fcd96cd08eb0e7190bb91 | [web] Merge `siweMessageSigningExplanationStatements` into `string` and left-align
Summary: Personally think this looks better than before. Got signoff from design team: Can revert if there's any disagreement with this change.
Test Plan:
Before:
{F358786}
After:
{F358787}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -134,8 +134,7 @@ function SIWE(): React.Node {\n<span className={css.walletDisplayText}>Wallet Connected:</span>\n<ConnectButton />\n</div>\n- <p>{siweMessageSigningExplanationStatements[... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Merge `siweMessageSigningExplanationStatements` into `string` and left-align
Summary: Personally think this looks better than before. Got signoff from design team: https://blob.sh/5e90d1.png. Can revert if there's any disagreement with this change.
Test Plan:
Before:
{F358786}
After:
{F358787}
Reviewers: as... |
129,184 | 02.02.2023 16:24:20 | 18,000 | 206b25506a8b037125972d7aa5fff8b873c35403 | [web] Change "Log in" to "Sign in" in `TraditionalLoginForm`
Summary: To match the designs (I realize that similar changes will need to be made on `native` and whatnot... will sequence that later)
Test Plan: NA
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/traditional-login-form.react.js",
"new_path": "web/account/traditional-login-form.react.js",
"diff": "@@ -120,7 +120,7 @@ function TraditionalLoginForm(): React.Node {\nif (inputDisabled) {\nreturn <LoadingIndicator status=\"loading\" />;\n}\n- ret... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Change "Log in" to "Sign in" in `TraditionalLoginForm`
Summary: To match the designs (I realize that similar changes will need to be made on `native` and whatnot... will sequence that later)
Test Plan: NA
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6542 |
129,184 | 02.02.2023 16:31:03 | 18,000 | b57aa8841915fd37b120727441ef89b87f3ab046 | [web] Introduce `HeaderSeparator`
Summary: Same as with `OrBreak` (which I'll rename to `OrSeparator`), want to use this on both `TraditionalLoginForm` and `SIWELoginForm`.
Test Plan: NA, the `hr` in `SIWELoginForm` continues to look as expected.
Reviewers: ashoat, tomek | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/account/header-separator.css",
"diff": "+div.headerSeparator hr {\n+ margin: 8px 0;\n+ border: none;\n+ border-top: #282537 solid 1px;\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/account/header-separa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `HeaderSeparator`
Summary: Same as with `OrBreak` (which I'll rename to `OrSeparator`), want to use this on both `TraditionalLoginForm` and `SIWELoginForm`.
Test Plan: NA, the `hr` in `SIWELoginForm` continues to look as expected.
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: ... |
129,184 | 02.02.2023 16:36:53 | 18,000 | 3a2230af635f5cfad8e5fa2f9b61459d7ef069ab | [web] Add "Sign in to Comm" header to `TraditionalLoginForm`
Summary: To match what's in designs.
Test Plan:
Here's what it looks like:
{F358923}
(vertical spacing/padding/margin/whatever will be addressed in a later diff)
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "@@ -10,6 +10,11 @@ div.modal_body {\noutline: #282537 solid 1px;\n}\n+div.modal_body h4 {\n+ color: white;\n+ font-family: sans-serif;\n+}\n+\ndiv.form_title {\npadding: 6px 6px ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add "Sign in to Comm" header to `TraditionalLoginForm`
Summary: To match what's in designs.
Test Plan:
Here's what it looks like:
{F358923}
(vertical spacing/padding/margin/whatever will be addressed in a later diff)
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/... |
129,184 | 02.02.2023 17:19:07 | 18,000 | badc90a39f78352d78d1479ea9c537aefcd91b6c | [web] Restyle `LoginForm` inputs to match designs
Summary: Restyle the text/password inputs in `LoginForm` to match the designs.
Test Plan:
Before:
{F358979}
After:
{F359026}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "@@ -47,3 +47,23 @@ div.modal_form_error {\npadding-left: 6px;\nalign-self: center;\n}\n+\n+div.modal_body .input[type='text'],\n+div.modal_body .input[type='password'] {\n+ backg... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Restyle `LoginForm` inputs to match designs
Summary: Restyle the text/password inputs in `LoginForm` to match the designs.
Test Plan:
Before:
{F358979}
After:
{F359026}
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6545 |
129,184 | 02.02.2023 17:44:57 | 18,000 | 6f890fbc35631d715b0dd810ac618f2d6937b956 | [web] Equalize `modal_body` vertical/horizontal padding
Summary: Makes things look more symmetrical.
Test Plan:
Before:
{F359071}
After:
{F359072}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "@@ -3,8 +3,8 @@ div.modal_body {\nflex-direction: column;\njustify-content: center;\nmin-height: 324px;\n- min-width: 320px;\n- padding: 20px 40px;\n+ min-width: 360px;\n+ paddin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Equalize `modal_body` vertical/horizontal padding
Summary: Makes things look more symmetrical.
Test Plan:
Before:
{F359071}
After:
{F359072}
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6547 |
129,184 | 04.02.2023 18:09:13 | 18,000 | bd5cf541b539459ffb8d07adc283022381153e5b | [native] `codeVersion` -> 183 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 183 |
129,184 | 04.02.2023 18:12:17 | 18,000 | 349a77a091680b0f2e661300196495ae554c08e9 | [native] `codeVersion` -> 184 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 184 |
129,187 | 03.02.2023 14:29:24 | 18,000 | 6572bd9e76635b35c21c30534bd792d9330aeabb | [lib] Pass object of props into createPendingSidebar
Summary:
I'm about to add some more props, so I figured it would be good to convert this to take an object now.
Depends on D6563
Test Plan: Flow
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -421,12 +421,19 @@ function createPendingThreadItem(\n};\n}\n-function createPendingSidebar(\n- sourceMessageInfo: ComposableMessageInfo | RobotextMessageInfo,\n- parentThreadIn... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Pass object of props into createPendingSidebar
Summary:
I'm about to add some more props, so I figured it would be good to convert this to take an object now.
Depends on D6563
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6564 |
129,187 | 03.02.2023 21:13:56 | 18,000 | 90cb990c058f9839753944365a48923f51430033 | [keyserver] Base setup of ethers.js and ENSCache
Summary: Most callsites in `keyserver` will probably interact with `getENSNames` directly, but exposing the others doesn't hurt.
Test Plan: Tested in combination with later notif diffs
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "keyserver/src/utils/ens-cache.js",
"diff": "+// @flow\n+\n+import { ethers } from 'ethers';\n+\n+import { ENSCache, type EthersProvider } from 'lib/utils/ens-cache';\n+import {\n+ getENSNames as baseGetENSNames,\n+ type GetENSNames,\n+} from 'li... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Base setup of ethers.js and ENSCache
Summary: Most callsites in `keyserver` will probably interact with `getENSNames` directly, but exposing the others doesn't hurt.
Test Plan: Tested in combination with later notif diffs
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: http... |
129,187 | 03.02.2023 21:15:24 | 18,000 | 99ef1cfaa4ebdfebdc7b42a6d9f7efec884bdd14 | [lib] Extend EntityText to support rendering thread names for notifs
Summary: Depends on D6572
Test Plan: Tested in combination with later notif diffs
Reviewers: atul, tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/entity-text.js",
"new_path": "lib/utils/entity-text.js",
"diff": "@@ -212,6 +212,7 @@ function makePossessive(input: MakePossessiveInput) {\nfunction getNameForThreadEntity(\nentity: ThreadEntity,\nthreadID: ?string,\n+ params?: EntityTextToRawString... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Extend EntityText to support rendering thread names for notifs
Summary: Depends on D6572
Test Plan: Tested in combination with later notif diffs
Reviewers: atul, tomek
Reviewed By: atul
Differential Revision: https://phab.comm.dev/D6573 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.