author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,203 | 26.08.2022 16:38:56 | 14,400 | 08dfbbfd79e7bb0a8714296e7d99c40e11e3af5d | [native] Use `values(...)` in `InputStateContainer`
Summary: Saw [[ | comment ]] on D4892.
Test Plan: Flow, close reading.
Reviewers: atul, tomek
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -77,6 +77,7 @@ import type {\nFetchJSONOptions,\nFetchJSONServerResponse,\n} from 'lib/utils/fetch-json';\n+import { values } from 'lib/utils/o... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `values(...)` in `InputStateContainer`
Summary: Saw @ashoat's [[ https://phab.comm.dev/D4892?id=15798#inline-31980 | comment ]] on D4892.
Test Plan: Flow, close reading.
Reviewers: atul, tomek
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D4961 |
129,184 | 22.08.2022 18:25:05 | 14,400 | 6a02276242fdb9971428676e0ef51971705a3d70 | [native] Rename callbacks in `InputStateContainer:uploadFile` for clarity
Summary:
The `fail(...)` and `finish(...)` naming was confusing both when defined and at callsites.
I think switching the naming to `onUpload[Finished/Failed]` makes things clearer.
Test Plan: This is a noop, no functional change.
Reviewers: abos... | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -596,7 +596,7 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nlet errorMessage;\nlet reportPromise;\n- const finish =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename callbacks in `InputStateContainer:uploadFile` for clarity
Summary:
The `fail(...)` and `finish(...)` naming was confusing both when defined and at callsites.
I think switching the naming to `onUpload[Finished/Failed]` makes things clearer.
Test Plan: This is a noop, no functional change.
Reviewers: ... |
129,184 | 29.08.2022 18:20:59 | 14,400 | 16897bd6ff2de6cf9e5c456f6ca4356519fec38e | [native] Rename `promises` to `cleanupPromises` at end of uploadFile(...)
Summary:
There are a lot of promises in `uploadFile(...)`... figured giving this "section" of them a more descriptive name.
Depends on D4980
Test Plan: NA, simple rename
Reviewers: abosh, jacek, tomek, ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -721,14 +721,14 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nhasWiFi,\n});\n- const promises = [];\n+ const cleanu... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename `promises` to `cleanupPromises` at end of uploadFile(...)
Summary:
There are a lot of promises in `uploadFile(...)`... figured giving this "section" of them a more descriptive name.
---
Depends on D4980
Test Plan: NA, simple rename
Reviewers: abosh, jacek, tomek, ashoat
Reviewed By: abosh
Differ... |
129,196 | 31.08.2022 11:02:50 | -7,200 | db29683e6497726600de9257143df78b29bb8890 | [native] codeVersion -> 143 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 143 |
129,185 | 05.09.2022 09:48:34 | -7,200 | 952451feac8e473358f0139ca9721eaeeee41f5c | [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`
Summary: Intrroducing mause actions callbacks on tooltip component, to correctly handle clearing the tooltip.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-provider.js",
"new_path": "web/chat/tooltip-provider.js",
"diff": "@@ -6,6 +6,7 @@ import * as React from 'react';\nimport type { TooltipPositionStyle } from './tooltip-utils';\nconst onMouseLeaveSourceDisappearTimeoutMs = 200;\n+const onMouse... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `onMouse` calbacks for tooltip component in `TooltipContext`
Summary: Intrroducing mause actions callbacks on tooltip component, to correctly handle clearing the tooltip.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek, atul
Subscribers: ashoat... |
129,185 | 05.09.2022 09:48:34 | -7,200 | 411deb4acee0b95aa3d953a5d688428c29d0062e | [web] Introduce tooltip container with positioning in `TooltipContext`
Summary: Introduce tooltip container that displays tooltip in correct position depending on provided tooltip style object
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-provider.js",
"new_path": "web/chat/tooltip-provider.js",
"diff": "// @flow\n+import classNames from 'classnames';\nimport invariant from 'invariant';\nimport * as React from 'react';\nimport type { TooltipPositionStyle } from './tooltip-utils... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce tooltip container with positioning in `TooltipContext`
Summary: Introduce tooltip container that displays tooltip in correct position depending on provided tooltip style object
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek, atul
Subscribers: ... |
129,185 | 05.09.2022 09:48:34 | -7,200 | 36b1f6c71dcbcd90f21c8fef757aed8fb26d5291 | [web] Refactor `MessageTooltip` component
Summary:
Major refactor of MessageTooltip that simplifies the component leaving only necessary properties and removing positioning logic out of the component
The new component:
{F146979}
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscri... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/chat/chat-constants.js",
"diff": "+// @flow\n+\n+export const tooltipStyle = {\n+ paddingLeft: 5,\n+ paddingRight: 5,\n+ rowGap: 3,\n+};\n+\n+export const tooltipLabelStyle = {\n+ padding: 6,\n+ height: 20,\n+};\n+export const tooltipButtonS... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Refactor `MessageTooltip` component
Summary:
Major refactor of MessageTooltip that simplifies the component leaving only necessary properties and removing positioning logic out of the component
The new component:
{F146979}
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Re... |
129,185 | 05.09.2022 09:48:34 | -7,200 | 7b34eea1a23176cf7dd1bda722b9f03b09aee088 | [web] Introduce `calculateTooltipSize` util function
Summary:
Introduce calculation of tooltip size basing on labels size and number of actions inside.
Some parts of this logic was in `findTooltipPosition` before
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-utils.js",
"new_path": "web/chat/tooltip-utils.js",
"diff": "import * as React from 'react';\n+import { calculateMaxTextWidth } from '../utils/text-utils';\n+import {\n+ tooltipButtonStyle,\n+ tooltipLabelStyle,\n+ tooltipStyle,\n+} from './ch... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `calculateTooltipSize` util function
Summary:
Introduce calculation of tooltip size basing on labels size and number of actions inside.
Some parts of this logic was in `findTooltipPosition` before
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
... |
129,185 | 05.09.2022 09:48:34 | -7,200 | be81697106d2b995f04943c545d83a1909312ce5 | [web] Introduce `getMessageActionTooltipStyle` util function
Summary: Introduce `getMessageActionTooltipStyle` to calculate style object for tooltip
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-utils.js",
"new_path": "web/chat/tooltip-utils.js",
"diff": "// @flow\n+import invariant from 'invariant';\nimport * as React from 'react';\nimport { calculateMaxTextWidth } from '../utils/text-utils';\n@@ -178,6 +179,98 @@ function findToolti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `getMessageActionTooltipStyle` util function
Summary: Introduce `getMessageActionTooltipStyle` to calculate style object for tooltip
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.d... |
129,185 | 05.09.2022 09:48:34 | -7,200 | 928a05031726662a0ed630f61b34fe316cf3a308 | [web] Introduce `useMessageTooltipSidebarAction` hook
Summary: Introduce tooltip action for "go to thread"/"create thread".
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-utils.js",
"new_path": "web/chat/tooltip-utils.js",
"diff": "import invariant from 'invariant';\nimport * as React from 'react';\n+import type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';\n+import { useSidebarExistsOrCanBeCreat... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `useMessageTooltipSidebarAction` hook
Summary: Introduce tooltip action for "go to thread"/"create thread".
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D4916 |
129,185 | 05.09.2022 09:48:34 | -7,200 | d1eb10a1786702189cd70d04900d5f47a2fd0f4a | [web] Introduce `useMessageTooltipReplyAction` hook
Summary:
Introduce tooltip action for "reply".
Parts of logic has been moved from `message-reply-button`
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-utils.js",
"new_path": "web/chat/tooltip-utils.js",
"diff": "@@ -4,10 +4,17 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport type { ChatMessageInfoItem } from 'lib/selectors/chat-selectors';\n-import { useSidebarE... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `useMessageTooltipReplyAction` hook
Summary:
Introduce tooltip action for "reply".
Parts of logic has been moved from `message-reply-button`
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://pha... |
129,185 | 05.09.2022 09:48:34 | -7,200 | 44d4262ea03ea9d6a28995f80ebfd8cbdc4424e6 | [web] Introduce `useMessageTooltipActions` hooks
Summary: Introduce hooks return tooltip actions for robotext and composed message.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-utils.js",
"new_path": "web/chat/tooltip-utils.js",
"diff": "@@ -388,11 +388,25 @@ function useMessageTooltipReplyAction(\n};\n}, [addReply, item.messageInfo.type, messageInfo, threadInfo]);\n}\n+\n+function useMessageTooltipActions(\n+ item: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce `useMessageTooltipActions` hooks
Summary: Introduce hooks return tooltip actions for robotext and composed message.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D4918 |
129,185 | 05.09.2022 09:48:34 | -7,200 | c12778cdcedd62a314db83b15c880fdd9c89b4c1 | [web] Wrap app content with `TooltipProvider`
Summary: Use `TooltipProvider` in main app component.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -26,6 +26,7 @@ import { registerConfig } from 'lib/utils/config';\nimport AppsDirectory from './apps/apps-directory.react';\nimport Calendar from './calendar/calendar.react';\nimport Chat from './c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Wrap app content with `TooltipProvider`
Summary: Use `TooltipProvider` in main app component.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek, atul
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D4919 |
129,185 | 05.09.2022 09:48:34 | -7,200 | a7c1314455db294ddb4dbcfe723428ae19f56d04 | [web] Use new tooltip in composed message
Summary: Use new tooltip API in composed message.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -9,7 +9,6 @@ import {\n} from 'react-feather';\nimport { type ChatMessageInfoItem } from 'lib/selectors/chat-selectors';\n-import { useSidebarExistsOrCanBeCreate... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use new tooltip in composed message
Summary: Use new tooltip API in composed message.
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D4920 |
129,185 | 05.09.2022 09:48:34 | -7,200 | 6f5610db9d1c415309b5c5d0b87b8f3fc44c4421 | [web] Use new tooltip in robotext message
Summary: Use new tooltip API in robotext message
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message.react.js",
"new_path": "web/chat/message.react.js",
"diff": "@@ -47,14 +47,7 @@ function Message(props: Props): React.Node {\nmessage = <MultimediaMessage item={item} threadInfo={props.threadInfo} />;\n} else {\ninvariant(item.robotext, \"Flow... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use new tooltip in robotext message
Summary: Use new tooltip API in robotext message
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D4921 |
129,185 | 05.09.2022 09:48:34 | -7,200 | c8b753e4f9b76ef4a6ed67bf07b9bfadd2c5cee5 | [web] Remove timestamp tooltip from `ChatMessageList`
Summary: Remove tooltip related logic from `chat-message-list` as it's no longer needed
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "@@ -32,13 +32,9 @@ import { useTextMessageRulesFunc } from '../markdown/rules.react';\nimport { useSelector } from '../redux/redux-utils';\nimport css from './cha... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove timestamp tooltip from `ChatMessageList`
Summary: Remove tooltip related logic from `chat-message-list` as it's no longer needed
Test Plan: Flow; Tested with the rest of diffs stack.
Reviewers: tomek, atul, abosh
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D492... |
129,185 | 05.09.2022 09:48:34 | -7,200 | f59b2df0c809b979930e28cdee22680d7eb7b8a6 | [web] Move `tooltip-utils` into `web/utils`
Summary: The diff moved `tooltip-utils` into `utils` folder on web. The test already has been in that folder.
Test Plan: Flow, checked manually if everything related to tooltip still works on web.
Reviewers: tomek, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -14,10 +14,10 @@ import { assertComposableMessageType } from 'lib/types/message-types';\nimport { type ThreadInfo } from 'lib/types/thread-types';\nimport { type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Move `tooltip-utils` into `web/utils`
Summary: The diff moved `tooltip-utils` into `utils` folder on web. The test already has been in that folder.
Test Plan: Flow, checked manually if everything related to tooltip still works on web.
Reviewers: tomek, atul
Reviewed By: tomek, atul
Subscribers: ashoat, abosh... |
129,185 | 05.09.2022 09:48:34 | -7,200 | d89c8f499c0c50aa9725aabbcee9553027c8f767 | [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`
Summary: Follow up:
Test Plan: Run web app, confirm that the rename doesn't break tooltip behavior
Reviewers: tomek, atul
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-provider.js",
"new_path": "web/chat/tooltip-provider.js",
"diff": "@@ -120,8 +120,8 @@ function TooltipProvider(props: Props): React.Node {\n}\nconst tooltipContainerStyle = {\nposition: 'absolute',\n- top: tooltipPosition.yCoord,\n- left: too... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename `x/yCoord` to `AnchorPoint` in `TooltipPositionStyle`
Summary: Follow up: https://phab.comm.dev/D4915#inline-32530
Test Plan: Run web app, confirm that the rename doesn't break tooltip behavior
Reviewers: tomek, atul
Reviewed By: tomek
Subscribers: ashoat, abosh
Differential Revision: https://phab.co... |
129,190 | 01.09.2022 12:38:11 | -7,200 | d7a9a55923a448e99d0fab671add55853f4118e4 | [services] Backup - Tests - Pull Backup - Improve logging
Summary: Making logs clearer in the pull backup test utility
Test Plan:
```
cd services
yarn run-integration-tests backup
```
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/tests/backup/pull_backup.rs",
"new_path": "services/commtest/tests/backup/pull_backup.rs",
"diff": "@@ -113,18 +113,18 @@ pub async fn run(\nif holder.len() == 0 {\ncontinue;\n}\n- println!(\"attachments for the backup: {}\", holders);\n+ pri... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Tests - Pull Backup - Improve logging
Summary: Making logs clearer in the pull backup test utility
Test Plan:
```
cd services
yarn run-integration-tests backup
```
Reviewers: jon, tomek, varun, max
Reviewed By: jon, tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://p... |
129,190 | 01.09.2022 12:44:42 | -7,200 | 5e99a40b03797ab371d498611a27f47545f95517 | [services] Backup - Add tools for blob client
Summary:
Depends on D5002
These tools will be helpful for communication between rust and c++
Test Plan: backup builds
Reviewers: jon, tomek, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Tools.cpp",
"new_path": "services/backup/src/Tools.cpp",
"diff": "@@ -52,6 +52,20 @@ std::string validateAttachmentHolders(const std::string &holders) {\nreturn result;\n}\n+int charPtrToInt(const char *str) {\n+ unsigned int intValue;\n+ s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Add tools for blob client
Summary:
Depends on D5002
These tools will be helpful for communication between rust and c++
Test Plan: backup builds
Reviewers: jon, tomek, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5003 |
129,190 | 01.09.2022 12:48:33 | -7,200 | 0e63f2b49414bf5782d4ef607548e5c051c44ef6 | [services] Backup - Blob Put Client - Update put API
Summary:
Depends on D5003
We want to use rust's `Result`s so we can catch errors in c++.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/lib.rs",
"new_path": "services/backup/blob_client/src/lib.rs",
"diff": "@@ -10,9 +10,12 @@ use put_client::{\n#[cxx::bridge]\nmod ffi {\nextern \"Rust\" {\n- fn put_client_initialize_cxx() -> ();\n- fn put_client_blocking_read_c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Update put API
Summary:
Depends on D5003
We want to use rust's `Result`s so we can catch errors in c++.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5004 |
129,190 | 01.09.2022 12:51:45 | -7,200 | fe23b01565548e6ead29b142c8c336896c5409c7 | [services] Backup - Blob Put Client - Add essential objects
Summary:
Depends on D5004
Adding necessary imports and objects that we're going to use in the put client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/put_client.rs",
"new_path": "services/backup/blob_client/src/put_client.rs",
"diff": "+mod proto {\n+ tonic::include_proto!(\"blob\");\n+}\n+\n+use lazy_static::lazy_static;\n+use libc;\nuse libc::c_char;\n+use std::sync::{Arc, ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Add essential objects
Summary:
Depends on D5004
Adding necessary imports and objects that we're going to use in the put client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: jon
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://... |
129,190 | 01.09.2022 12:51:59 | -7,200 | a20c5f2821306d91d194edc4db0573c562a7e73a | [services] Backup - Blob Put Client - Add helper functions
Summary:
Depends on D5005
Adding some helper function that will be used by the put client
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/put_client.rs",
"new_path": "services/backup/blob_client/src/put_client.rs",
"diff": "@@ -32,6 +32,35 @@ lazy_static! {\nArc::new(Mutex::new(Vec::new()));\n}\n+fn is_initialized() -> bool {\n+ match CLIENT.lock() {\n+ Ok(client)... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Add helper functions
Summary:
Depends on D5005
Adding some helper function that will be used by the put client
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: jon, tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.... |
129,190 | 01.09.2022 12:59:03 | -7,200 | 4a1b95c4374fc97c6bd29a5926ec9507f8d8fedd | [services] Backup - Blob Put Client - Install async stream
Summary:
Depends on D5006
Installing async stream to handle grpc properly.
Test Plan: backup builds
Reviewers: jon, ashoat, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/Cargo.lock",
"new_path": "services/backup/blob_client/Cargo.lock",
"diff": "@@ -114,6 +114,7 @@ checksum = \"bef38d45163c2f1dde094a7dfd33ccf595c92905c8f8f4fdc18d06fb1037718a\"\nname = \"blob_client\"\nversion = \"0.1.0\"\ndependenci... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Install async stream
Summary:
Depends on D5006
Installing async stream to handle grpc properly.
Test Plan: backup builds
Reviewers: jon, ashoat, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5007 |
129,190 | 01.09.2022 12:53:04 | -7,200 | 4b6b03909f82af5ea1f9705744a6e745710ff64f | [services] Backup - Blob Put Client - Add initialize
Summary:
Depends on D5008
Adding initialize function to the blob put client.
Test Plan: backup builds
Reviewers: jon, max, varun, tomek
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/put_client.rs",
"new_path": "services/backup/blob_client/src/put_client.rs",
"diff": "@@ -2,9 +2,16 @@ mod proto {\ntonic::include_proto!(\"blob\");\n}\n+use proto::blob_service_client::BlobServiceClient;\n+use proto::put_reques... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Add initialize
Summary:
Depends on D5008
Adding initialize function to the blob put client.
Test Plan: backup builds
Reviewers: jon, max, varun, tomek
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5009 |
129,190 | 01.09.2022 12:53:34 | -7,200 | c915b14cca4a96c1cf485b7d08a8115027d710d4 | [services] Backup - Blob Put Client - Add blocking read
Summary:
Depends on D5009
Adding blocking read function to the blob put client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/put_client.rs",
"new_path": "services/backup/blob_client/src/put_client.rs",
"diff": "@@ -176,7 +176,28 @@ pub fn put_client_initialize_cxx() -> Result<(), String> {\n}\npub fn put_client_blocking_read_cxx() -> Result<String, St... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Add blocking read
Summary:
Depends on D5009
Adding blocking read function to the blob put client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5010 |
129,190 | 01.09.2022 12:53:49 | -7,200 | 6689f947442ff822a434a61e745e48e1dfb85a42 | [services] Backup - Blob Put Client - Add write
Summary:
Depends on D5010
Adding write function to the blob put client.
Test Plan: backup builds
Reviewers: jon, tomek, max, varun
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/put_client.rs",
"new_path": "services/backup/blob_client/src/put_client.rs",
"diff": "@@ -210,7 +210,36 @@ pub fn put_client_write_cxx(\nfield_index: usize,\ndata: *const c_char,\n) -> Result<(), String> {\n- unimplemented!();\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Add write
Summary:
Depends on D5010
Adding write function to the blob put client.
Test Plan: backup builds
Reviewers: jon, tomek, max, varun
Reviewed By: jon, tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5011 |
129,190 | 01.09.2022 12:54:05 | -7,200 | 6cbd2d4384fa23440166de031781e9e2e257c3a2 | [services] Backup - Blob Put Client - Add terminate
Summary:
Depends on D5011
Adding terminate function to the blob put client.
Test Plan: backup builds
Reviewers: jon, max, varun, tomek
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/put_client.rs",
"new_path": "services/backup/blob_client/src/put_client.rs",
"diff": "@@ -243,5 +243,31 @@ pub fn put_client_write_cxx(\n}\npub fn put_client_terminate_cxx() -> Result<(), String> {\n- unimplemented!();\n+ check_... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Put Client - Add terminate
Summary:
Depends on D5011
Adding terminate function to the blob put client.
Test Plan: backup builds
Reviewers: jon, max, varun, tomek
Reviewed By: jon
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5012 |
129,190 | 01.09.2022 12:55:52 | -7,200 | 77d843164f0be77cb16c9f39ab300b225da95371 | [services] Backup - Blob Get Client - Add base structure
Summary:
Depends on D5012
Adding base structure to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/get_client.rs",
"new_path": "services/backup/blob_client/src/get_client.rs",
"diff": "+mod proto {\n+ tonic::include_proto!(\"blob\");\n+}\n+use proto::blob_service_client::BlobServiceClient;\n+use proto::GetRequest;\n+\n+use cr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Get Client - Add base structure
Summary:
Depends on D5012
Adding base structure to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5013 |
129,190 | 01.09.2022 12:56:19 | -7,200 | 8949d823fda97d9f05c97bd1fada142f5ab9e51d | [services] Backup - Blob Get Client - Add initialize
Summary:
Depends on D5013
Adding initialize function to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/get_client.rs",
"new_path": "services/backup/blob_client/src/get_client.rs",
"diff": "@@ -61,7 +61,64 @@ fn check_error() -> Result<(), String> {\npub fn get_client_initialize_cxx(\nholder_char: *const c_char,\n) -> Result<(), S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Get Client - Add initialize
Summary:
Depends on D5013
Adding initialize function to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5014 |
129,190 | 01.09.2022 12:56:35 | -7,200 | 0edcf73c41afc697f8d08407db7c0b56ca6786b3 | [services] Backup - Blob Get Client - Add blocking read
Summary:
Depends on D5014
Adding blocking read function to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/get_client.rs",
"new_path": "services/backup/blob_client/src/get_client.rs",
"diff": "@@ -122,7 +122,24 @@ pub fn get_client_initialize_cxx(\n}\npub fn get_client_blocking_read_cxx() -> Result<Vec<u8>, String> {\n- unimplemented... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Get Client - Add blocking read
Summary:
Depends on D5014
Adding blocking read function to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: jon, tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5015 |
129,190 | 01.09.2022 12:56:49 | -7,200 | 440114cd315c9fbcef82c5d1a75cf827dd3d7b05 | [services] Backup - Blob Get Client - Add terminate
Summary:
Depends on D5015
Adding terminate function to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/get_client.rs",
"new_path": "services/backup/blob_client/src/get_client.rs",
"diff": "@@ -143,5 +143,29 @@ pub fn get_client_blocking_read_cxx() -> Result<Vec<u8>, String> {\n}\npub fn get_client_terminate_cxx() -> Result<(), St... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Blob Get Client - Add terminate
Summary:
Depends on D5015
Adding terminate function to the blob get client.
Test Plan: backup builds
Reviewers: jon, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5016 |
129,190 | 01.09.2022 13:03:08 | -7,200 | 0b822963c7ec7c5ab5d16469a455a190860c33c0 | [services] Backup - Use Blob client in c++ - Implement add attachment
Summary:
Depends on D5017
Adding c++ implementation for using the blob client in the backup reactor for adding attachments.
Test Plan: backup builds
Reviewers: jon, tomek, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Reactors/server/AddAttachmentsUtility.cpp",
"new_path": "services/backup/src/Reactors/server/AddAttachmentsUtility.cpp",
"diff": "#include \"AddAttachmentsUtility.h\"\n+#include \"blob_client/src/lib.rs.h\"\n+\n#include <glog/logging.h>\n#i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Use Blob client in c++ - Implement add attachment
Summary:
Depends on D5017
Adding c++ implementation for using the blob client in the backup reactor for adding attachments.
Test Plan: backup builds
Reviewers: jon, tomek, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differen... |
129,190 | 01.09.2022 13:03:24 | -7,200 | d92ff5a3dcfd616ab312d0592c8c5bdb09d13c1e | [services] Backup - Use Blob client in c++ - Implement send log
Summary:
Depends on D5018
Adding c++ implementation for using the blob client in the backup reactor for sending logs.
Test Plan: backup builds
Reviewers: jon, tomek, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Reactors/server/SendLogReactor.cpp",
"new_path": "services/backup/src/Reactors/server/SendLogReactor.cpp",
"diff": "#include \"SendLogReactor.h\"\n+#include \"blob_client/src/lib.rs.h\"\n+\n#include \"Constants.h\"\n#include \"DatabaseManag... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Use Blob client in c++ - Implement send log
Summary:
Depends on D5018
Adding c++ implementation for using the blob client in the backup reactor for sending logs.
Test Plan: backup builds
Reviewers: jon, tomek, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abosh
Differential Revisio... |
129,190 | 01.09.2022 13:03:39 | -7,200 | 965866378b2f343f3f512758841e82bc6a9d5804 | [services] Backup - Use Blob client in c++ - Implement pull backup
Summary:
Depends on D5019
Adding c++ implementation for using the blob client in the backup reactor for pulling backups.
Test Plan: backup builds
Reviewers: jon, tomek, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/src/Reactors/server/PullBackupReactor.cpp",
"new_path": "services/backup/src/Reactors/server/PullBackupReactor.cpp",
"diff": "#include \"PullBackupReactor.h\"\n+#include \"blob_client/src/lib.rs.h\"\n+\n#include \"DatabaseManager.h\"\nnamespace... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Use Blob client in c++ - Implement pull backup
Summary:
Depends on D5019
Adding c++ implementation for using the blob client in the backup reactor for pulling backups.
Test Plan: backup builds
Reviewers: jon, tomek, max
Reviewed By: jon, tomek
Subscribers: ashoat, tomek, atul, abosh
Different... |
129,190 | 02.09.2022 12:49:42 | -7,200 | 396b990da3e4762b736761785d16772311a92d96 | [services] Rust Integration - Backup - Rust - Add converting functions
Summary:
Depends on D5031
Adding helper functions to convert between rust's `String` and c++'s `char*` both ways.
Test Plan: backup builds successfully
Reviewers: jon, tomek, varun, max
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/backup/blob_client/src/tools.rs",
"new_path": "services/backup/blob_client/src/tools.rs",
"diff": "+use libc::c_char;\n+use std::ffi::{CStr, CString};\nuse std::sync::{Arc, Mutex};\nuse tracing::error;\n@@ -17,7 +19,9 @@ pub fn report_error(\nerror!(\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Rust Integration - Backup - Rust - Add converting functions
Summary:
Depends on D5031
Adding helper functions to convert between rust's `String` and c++'s `char*` both ways.
Test Plan: backup builds successfully
Reviewers: jon, tomek, varun, max
Reviewed By: tomek
Subscribers: ashoat, tomek, atul, abos... |
129,184 | 08.09.2022 16:55:59 | 14,400 | 7ed99628ce2f1f3b28671d672ac019b796fbbe82 | [native] Update `thumbnailID` upon successful thumbnail upload
Summary:
Need to include the `thumbnailID` in addition to the `thumbnailURL` in the `updateMediaPayload`.
Depends on D5059
Test Plan:
`sendMultimediaMessage` in subsequent diff gets correctly constructed `mediaMessageContents` with expected values.
{F160047... | [
{
"change_type": "MODIFY",
"old_path": "native/input/input-state-container.react.js",
"new_path": "native/input/input-state-container.react.js",
"diff": "@@ -734,12 +734,13 @@ class InputStateContainer extends React.PureComponent<Props, State> {\nif (processedMedia.mediaType === 'video') {\ninvarian... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update `thumbnailID` upon successful thumbnail upload
Summary:
Need to include the `thumbnailID` in addition to the `thumbnailURL` in the `updateMediaPayload`.
Depends on D5059
Test Plan:
`sendMultimediaMessage` in subsequent diff gets correctly constructed `mediaMessageContents` with expected values.
{F16... |
129,184 | 08.09.2022 16:59:28 | 14,400 | dbb173686a65914bb788ff6f4d9fd40d7d59c6d1 | [lib] Update `SendMultimediaMessageRequest` type
Summary:
Update `SendMultimediaMessageRequest` to handle "new" payload option which takes list of `MediaMessageServerDBContent` instead of a list of `string`s.
Depends on D5060
Test Plan: NA, no functional changes but addresses a flow issue in subsequent diff
Reviewers: ... | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/message-responders.js",
"new_path": "keyserver/src/responders/message-responders.js",
"diff": "@@ -118,6 +118,7 @@ async function legacyMultimediaMessageCreationResponder(\nviewer: Viewer,\nrequest: SendMultimediaMessageRequest,\n): Pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update `SendMultimediaMessageRequest` type
Summary:
Update `SendMultimediaMessageRequest` to handle "new" payload option which takes list of `MediaMessageServerDBContent` instead of a list of `string`s.
Depends on D5060
Test Plan: NA, no functional changes but addresses a flow issue in subsequent diff
Reviewe... |
129,184 | 09.09.2022 05:31:11 | 14,400 | f5be8adfb1172ae2e5d4a73b4b01d03dbc0045c2 | [lib] Update `SendMultimediaMessageRequest` type
Summary:
Update `SendMultimediaMessageRequest` to handle "new" payload option which takes list of `MediaMessageServerDBContent` instead of a list of `string`s.
Depends on D5060
Test Plan: NA, no functional changes but addresses a flow issue in subsequent diff
Reviewers: ... | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/message-responders.js",
"new_path": "keyserver/src/responders/message-responders.js",
"diff": "@@ -118,6 +118,7 @@ async function legacyMultimediaMessageCreationResponder(\nviewer: Viewer,\nrequest: SendMultimediaMessageRequest,\n): Pr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update `SendMultimediaMessageRequest` type
Summary:
Update `SendMultimediaMessageRequest` to handle "new" payload option which takes list of `MediaMessageServerDBContent` instead of a list of `string`s.
Depends on D5060
Test Plan: NA, no functional changes but addresses a flow issue in subsequent diff
Reviewe... |
129,196 | 12.09.2022 18:11:09 | -7,200 | e46d3e9b0f80a0f82ac5a1b2d6cc71217ec76b59 | [native] codeVersion -> 144 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 144 |
129,196 | 12.09.2022 18:32:49 | -7,200 | 7d391a02ffff854072407b8e0b9899ebf88b99c4 | [native] codeVersion -> 145 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] codeVersion -> 145 |
129,184 | 13.09.2022 11:17:28 | 14,400 | 5e11f71e498b6a6d069d61653699a17e56fc270e | [native] `codeVersion` -> 146 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 146 |
129,184 | 15.09.2022 15:26:09 | 14,400 | 7780003a3872bec9c1f57d08eb3cc12ca5ad8167 | [native] Bump `codeVersion` to 147 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Bump `codeVersion` to 147 |
129,189 | 16.09.2022 11:25:46 | 14,400 | afc567e66d62c67694679b988cc5da03956a7612 | [landing] updated which wagmi parameter is the actual address
Summary: wagmi's latest useAccount() has a more sane api surface for exposing the address
Test Plan: run `landing`, console.log the address and find that it exists
Reviewers: atul, varun, abosh, ashoat
Subscribers: tomek, varun, abosh, atul, ashoat | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -60,8 +60,7 @@ async function signInWithEthereum(address, signer) {\n}\nfunction SIWE(): React.Node {\n- const { data } = useAccount();\n- const { address } = data || {};\n+ const { addre... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] updated which wagmi parameter is the actual address
Summary: wagmi's latest useAccount() has a more sane api surface for exposing the address
Test Plan: run `landing`, console.log the address and find that it exists
Reviewers: atul, varun, abosh, ashoat
Reviewed By: ashoat
Subscribers: tomek, varun, abos... |
129,178 | 12.09.2022 00:36:59 | -32,400 | 2d6e43c7739e60964acb9f0f63e73bdcff1ac95a | [web] Added `react-icons` dependency to `web`
Summary: add `react-icons` dependency so we can use `Ionicons` icon pack
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"react-feather\": \"^2.0.3\",\n\"react-hot-loader\": \"^4.12.14\",\n\"react-icomoon\": \"^2.4.1\",\n+ \"react-icons\": \"^4.4.0\",\n\"react-redux\": \"^7.1.1\",\n\"react-router\": \"^5.2.0\",\n\"reac... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Added `react-icons` dependency to `web`
Summary: add `react-icons` dependency so we can use `Ionicons` icon pack
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5108 |
129,200 | 22.09.2022 15:17:05 | 14,400 | d6285ed30cad730c059df94589f8f4d2c9775d4f | [services][identity] address some nits
Summary: changed `into()`s to `to_string()`s for clarity
Test Plan: `cargo build`
Reviewers: jon, tomek
Subscribers: ashoat, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/database.rs",
"new_path": "services/identity/src/database.rs",
"diff": "@@ -91,20 +91,22 @@ impl DatabaseClient {\nif let Some(reg) = registration {\nupdate_expression_parts\n.push(format!(\"{} = :r\", USERS_TABLE_REGISTRATION_ATTRIBUTE))... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] address some nits
Summary: changed `into()`s to `to_string()`s for clarity
Test Plan: `cargo build`
Reviewers: jon, tomek
Reviewed By: jon, tomek
Subscribers: ashoat, atul, abosh
Differential Revision: https://phab.comm.dev/D5217 |
129,181 | 29.09.2022 14:06:46 | -7,200 | a8a7d9c7e94f8ab4c5cdd53deaf5d88f90983f7a | [services] Move constants to a separate file in commtest
Summary:
[ENG-1322](https://linear.app/comm/issue/ENG-1322/move-constants-to-a-separate-file)
Moves constants from `tools.rs` to `constants.rs`.
Test Plan:
Check if it builds
```
cd services/commtest
cargo test --no-run
```
Reviewers: varun, jon, marcin, tomek
Su... | [
{
"change_type": "MODIFY",
"old_path": "services/commtest/src/backup/add_attachments.rs",
"new_path": "services/commtest/src/backup/add_attachments.rs",
"diff": "use crate::backup::backup_utils::{\nproto::AddAttachmentsRequest, BackupData, BackupServiceClient,\n};\n-use crate::tools::{Error, ATTACHM... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Move constants to a separate file in commtest
Summary:
[ENG-1322](https://linear.app/comm/issue/ENG-1322/move-constants-to-a-separate-file)
Moves constants from `tools.rs` to `constants.rs`.
Test Plan:
Check if it builds
```
cd services/commtest
cargo test --no-run
```
Reviewers: varun, jon, marcin, tomek... |
129,178 | 28.09.2022 15:06:46 | 14,400 | 013cf5a51ca823409699ad22dc7e9b8914d59dab | [native] memoized textStyle and styles.text
Summary: memoized `textStyle` and `styles.text` into `markdownStyles` for improved performance
Test Plan: Open a chat with any markdown components (blockquote, codeblock, etc) and everything should be the same
Reviewers: atul, abosh, rohan, kamil
Subscribers: ashoat, tomek, a... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inner-text-message.react.js",
"new_path": "native/chat/inner-text-message.react.js",
"diff": "@@ -70,7 +70,6 @@ function InnerTextMessage(props: Props): React.Node {\nconst boundColors = useColors();\nconst messageStyle = {};\n- const textStyle = {... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] memoized textStyle and styles.text
Summary: memoized `textStyle` and `styles.text` into `markdownStyles` for improved performance
Test Plan: Open a chat with any markdown components (blockquote, codeblock, etc) and everything should be the same
Reviewers: atul, abosh, rohan, kamil
Reviewed By: atul, rohan
... |
129,187 | 01.10.2022 15:32:14 | 14,400 | 67c26f2cfad6006e6a52770708aaed1c2046ddcb | [native] Bump SDWebImage on iOS
Summary: iOS part of `react-native-fast-image`. Noticed it was out of date, might as well bump.
Test Plan: Haven't tested, minor version bump seems fine
Reviewers: atul
Subscribers: tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -901,9 +901,9 @@ PODS:\n- React-Core\n- RNVectorIcons (6.6.0):\n- React\n- - SDWebImage (5.12.3):\n- - SDWebImage/Core (= 5.12.3)\n- - SDWebImage/Core (5.12.3)\n+ - SDWebImage (5.12.5... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Bump SDWebImage on iOS
Summary: iOS part of `react-native-fast-image`. Noticed it was out of date, might as well bump.
Test Plan: Haven't tested, minor version bump seems fine
Reviewers: atul
Reviewed By: atul
Subscribers: tomek, abosh
Differential Revision: https://phab.comm.dev/D5278 |
129,181 | 30.09.2022 16:24:40 | -7,200 | 4fda171b4a664634e214144377a959ba59df01c7 | [web] Notifications dialog - change name
Summary:
[ENG-1729](https://linear.app/comm/issue/ENG-1729/update-notifications-dialog-to-handle-threads-correctly)
Changes notifications dialog title for sidebars from "Channel notifications" to "Thread notifications".
Test Plan: Test if the title is correct for sidebars and no... | [
{
"change_type": "MODIFY",
"old_path": "web/modals/threads/notifications/notifications-modal.react.js",
"new_path": "web/modals/threads/notifications/notifications-modal.react.js",
"diff": "@@ -7,6 +7,7 @@ import {\nupdateSubscriptionActionTypes,\n} from 'lib/actions/user-actions';\nimport { threadI... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Notifications dialog - change name
Summary:
[ENG-1729](https://linear.app/comm/issue/ENG-1729/update-notifications-dialog-to-handle-threads-correctly)
Changes notifications dialog title for sidebars from "Channel notifications" to "Thread notifications".
Test Plan: Test if the title is correct for sidebars and ... |
129,184 | 05.10.2022 10:43:53 | 14,400 | 2e9ead6b523e8ff86c787a4097c3c3a986c3c4a0 | [CommCoreModule] Cut extraneous `include`s
Summary: Noticed these while working on the "C++ side" of `native`.
Test Plan: CI
Reviewers: tomek, marcin, abosh, rohan, ginsu, jon
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "#include \"Logger.h\"\n#include \"sqlite_orm.h\"\n-#include \"entities/Media.h\"\n#include \"entities/Metadata... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Cut extraneous `include`s
Summary: Noticed these while working on the "C++ side" of `native`.
Test Plan: CI
Reviewers: tomek, marcin, abosh, rohan, ginsu, jon
Reviewed By: tomek, marcin, rohan
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D5297 |
129,196 | 05.10.2022 11:38:25 | -7,200 | c53645b2695019a3788c4e4e9efc35b548f28e63 | Use GlobalDBSingleton when touching database from the native iOS code.
Summary: This differential replaces any direct database access in iOS native code with GlobalDBSingleton API
Test Plan: Creating test release with those changes would remove iOS 137 crash
Reviewers: tomek, atul, jon
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/AppDelegate.mm",
"new_path": "native/ios/Comm/AppDelegate.mm",
"diff": "#import <reacthermes/HermesExecutorFactory.h>\n#import \"CommCoreModule.h\"\n+#import \"GlobalDBSingleton.h\"\n#import \"GlobalNetworkSingleton.h\"\n#import \"Logger.h\"\n#... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use GlobalDBSingleton when touching database from the native iOS code.
Summary: This differential replaces any direct database access in iOS native code with GlobalDBSingleton API
Test Plan: Creating test release with those changes would remove iOS 137 crash
Reviewers: tomek, atul, jon
Reviewed By: tomek, jon
Subs... |
129,184 | 12.10.2022 16:46:04 | 14,400 | a8cd33e220756bc0a4c00fa4c6bbf8abe6cd8de6 | [native] `codeVersion` -> 148 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 148 |
129,184 | 14.10.2022 11:08:46 | 14,400 | 8942adfb59f71f27b7ffb835b69d2874a086a5fc | [native] `codeVersion` -> 149 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -434,8 +434,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 149 |
129,178 | 14.10.2022 17:35:06 | 14,400 | d5c68d0516645aee0bcc2bf4dc8f9bfc9f244182 | [landing] added classnames dependency
Summary: added `classnames` dependency. This is so that we can use add conditional logic to Investor Profile Card Modal classes. We use this in the `web` codebase
Test Plan: N/A
Reviewers: ashoat, atul
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"@lottiefiles/lottie-interactivity\": \"^0.1.4\",\n\"@lottiefiles/lottie-player\": \"^1.0.3\",\n\"@rainbow-me/rainbowkit\": \"^0.5.0\",\n+ \"classnames\": \"^2.2.5\",\n\"core-js\": \"^3.6.5\"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] added classnames dependency
Summary: added `classnames` dependency. This is so that we can use add conditional logic to Investor Profile Card Modal classes. We use this in the `web` codebase
Test Plan: N/A
Reviewers: ashoat, atul
Reviewed By: ashoat, atul
Subscribers: ashoat, tomek, atul, abosh
Differen... |
129,181 | 04.10.2022 14:49:34 | -7,200 | 9b70699e472d331cb13f348a15d14a6acf51cc8e | [web] Use Button in join chat button
Summary:
[[ | Part of ]]
Uses `Button` in join chat button instead of a plain `<button>`.
Test Plan: Check if the button looks the same and works correctly.
Reviewers: tomek, atul, abosh, ginsu
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -37,28 +37,8 @@ div.joinButtonContainer {\nwidth: 100%;\njustify-content: center;\n}\n-button.joinButton {\n- display: flex;\n- align-items: center;\n- border: none;\n- paddin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use Button in join chat button
Summary:
[[ https://linear.app/comm/issue/ENG-843 | Part of ENG-843 ]]
Uses `Button` in join chat button instead of a plain `<button>`.
Test Plan: Check if the button looks the same and works correctly.
Reviewers: tomek, atul, abosh, ginsu
Reviewed By: tomek, atul, ginsu
Subscr... |
129,181 | 05.10.2022 19:44:30 | -7,200 | 890a351a31e720145b8bac1f58d8dc71da9115ba | [web] Use Button for relationship buttons
Summary:
[Part of ENG-843](https://linear.app/comm/issue/ENG-843)
Uses `Button` for the relationship buttons instead of plain `<button>`
Test Plan: Test if the buttons look the same.
Reviewers: tomek, atul, abosh, ginsu
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "web/chat/relationship-prompt/relationship-prompt-button.js",
"new_path": "web/chat/relationship-prompt/relationship-prompt-button.js",
"diff": "@@ -4,30 +4,28 @@ import { type IconDefinition } from '@fortawesome/fontawesome-common-types';\nimport { FontAwesome... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Use Button for relationship buttons
Summary:
[Part of ENG-843](https://linear.app/comm/issue/ENG-843)
Uses `Button` for the relationship buttons instead of plain `<button>`
Test Plan: Test if the buttons look the same.
Reviewers: tomek, atul, abosh, ginsu
Reviewed By: atul, ginsu
Subscribers: ashoat
Differe... |
129,178 | 20.10.2022 11:18:09 | 14,400 | f7fdc72ea2969a2e49e40608ca7d795b48cbeb5d | [landing] added derek to the team page
Summary: added derek's profile to the team page
Test Plan:
please review the screenshots to see the before and after
Before:
{F204631}
After:
{F204632}
Reviewers: atul, rohan
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "landing/team.react.js",
"new_path": "landing/team.react.js",
"diff": "@@ -56,6 +56,13 @@ function Team(): React.Node {\ntwitterHandle=\"GeekMaks\"\nimageURL={`${assetsCacheURLPrefix}/max.jpeg`}\n/>\n+ <TeamProfile\n+ name=\"Derek Nelson\"\n+ role=\"Software En... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] added derek to the team page
Summary: added derek's profile to the team page
Test Plan:
please review the screenshots to see the before and after
Before:
{F204631}
After:
{F204632}
Reviewers: atul, rohan
Reviewed By: atul, rohan
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://ph... |
129,200 | 10.10.2022 13:24:45 | 14,400 | 1913390844bca461d77497ec41b34ea7812c4420 | CMakeLists.txt changes to compile native rust library on android
Summary: This differential introduces changes necessary to compile native rust library on Android
Test Plan: Build android app
Reviewers: marcin, jon
Subscribers: ashoat, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/CMakeLists.txt",
"new_path": "native/android/app/CMakeLists.txt",
"diff": "@@ -40,6 +40,19 @@ set(gRPC_SSL_PROVIDER \"package\" CACHE STRING \"SSL library provider\")\n# gRPC client\ninclude(FetchContent)\n+if(CMAKE_ANDROID_ARCH_ABI STREQUAL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | CMakeLists.txt changes to compile native rust library on android
Summary: This differential introduces changes necessary to compile native rust library on Android
Test Plan: Build android app
Reviewers: marcin, jon
Reviewed By: marcin, jon
Subscribers: ashoat, atul, abosh
Differential Revision: https://phab.comm.... |
129,187 | 04.10.2022 16:24:11 | 14,400 | 572a4a4d0290fbefc106d447b3fbdc236040106d | [native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#dropped-dangerously-from-dangerouslygetparent-and-dangerouslygetstate).
Depends on D5393
Test Plan: Flow + ran the app on my phone and played around with it
Re... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -75,7 +75,7 @@ class ChatList extends React.PureComponent<Props, State> {\ncomponentDidMount() {\nconst tabNavigation: ?TabNavigationProp<\n'Chat',\n- > = this.props.nav... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [1/34] ReactNav6: Drop "dangerously" from getParent and getState
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#dropped-dangerously-from-dangerouslygetparent-and-dangerouslygetstate).
Depends on D5393
Test Plan: Flow + ran the app on my phone and played around with it... |
129,187 | 07.10.2022 10:47:05 | 14,400 | 58c70a5008cfbc8a46244233c501cb85b9e02c80 | [native] [3/34] ReactNav6: drop useLinking hook
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#dropped-uselinking-hook).
Depends on D5395
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subscribers: abosh | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/native_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/native_v5.x.x.js",
"diff": "@@ -2236,11 +2236,6 @@ declare module '@react-navigation/native' {\n...\n}>;\n- declare export function useLinking(\n- c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [3/34] ReactNav6: drop useLinking hook
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#dropped-uselinking-hook).
Depends on D5395
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Reviewed By: atul
Subscribers: abosh
... |
129,187 | 07.10.2022 10:59:53 | 14,400 | 921a800c6ac64c06b2303b0560a08c287af30acf | [native] [4/34] ReactNav6: update LinkTo to accept screen name
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#link-and-uselinkprops-can-now-accept-screen-names).
Depends on D5396
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Su... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/native_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/native_v5.x.x.js",
"diff": "@@ -2228,21 +2228,32 @@ declare module '@react-navigation/native' {\n* Linking\n*/\n+ declare export type LinkTo<\n+ Par... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [4/34] ReactNav6: update LinkTo to accept screen name
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#link-and-uselinkprops-can-now-accept-screen-names).
Depends on D5396
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, barte... |
129,187 | 07.10.2022 13:39:11 | 14,400 | fe6624bec8cd5ab5ea963ac1f1d3a0b2aa59836a | [native] [7/34] ReactNav6: add Group component
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#new-group-component).
Depends on D5399
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subscribers: abosh | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1078,6 +1078,11 @@ declare module '@react-navigation/bottom-tabs' {\n...$Exact<ExtraNavigatorProps>,\n...S... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [7/34] ReactNav6: add Group component
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#new-group-component).
Depends on D5399
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Reviewed By: atul
Subscribers: abosh
Diff... |
129,187 | 07.10.2022 13:49:14 | 14,400 | ef25360c08f643e3461adb11c8fbfc8b9ef14ae0 | [native] [8/34] ReactNav6: type new screenListeners prop on Navigator
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#new-screenlisteners-prop-for-navigators-similar-to-screenoptions).
Depends on D5400
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: ... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -919,7 +919,7 @@ declare module '@react-navigation/bottom-tabs' {\ndeclare export type RouteProp<\nParamLis... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [8/34] ReactNav6: type new screenListeners prop on Navigator
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#new-screenlisteners-prop-for-navigators-similar-to-screenoptions).
Depends on D5400
Test Plan: Flow + ran the app on my phone and played around with it
Reviewe... |
129,187 | 18.10.2022 09:00:56 | 14,400 | 4f73988bb3629ee5e70fc7f86877caefaf46951c | [native] [15/34] ReactNav6: add navigator ID
Summary:
See info about navigator IDs in the [ReactNav API reference](https://reactnavigation.org/docs/navigation-prop/#getparent)
Depends on D5407
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subscribers: abosh | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -144,9 +144,11 @@ function ChatNavigator({\ninitialRouteName,\nchildren,\nscreenOptions,\n+ id,\n...rest\n}: ChatNavigatorProps) {\nconst { state, descriptors, navigation } = useN... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [15/34] ReactNav6: add navigator ID
Summary:
See info about navigator IDs in the [ReactNav API reference](https://reactnavigation.org/docs/navigation-prop/#getparent)
Depends on D5407
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Reviewed By: atul
Subs... |
129,187 | 18.10.2022 16:39:50 | 14,400 | 005e4b524513c5a42f4c466cd6a0810ccedc4349 | [native] [21/34] ReactNav6: Add new NavigationContainerRef functions
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#new-hook-and-helper-for-creating-container-ref).
Depends on D5413
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -2158,6 +2158,11 @@ declare module '@react-navigation/bottom-tabs' {\n+isReady: () => boolean,\n|};\n+ decl... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [21/34] ReactNav6: Add new NavigationContainerRef functions
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#new-hook-and-helper-for-creating-container-ref).
Depends on D5413
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, ba... |
129,187 | 18.10.2022 17:24:08 | 14,400 | db12d5c662dde442fceedc916e14fde4353b8d57 | [native] [22/34] ReactNav6: Move keyboardHandlingEnabled to StackOptions
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#keyboardhandlingenabled-is-moved-to-options).
Depends on D5414
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, barte... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1381,6 +1381,7 @@ declare module '@react-navigation/bottom-tabs' {\n+gestureResponseDistance: {| vertical?... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [22/34] ReactNav6: Move keyboardHandlingEnabled to StackOptions
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#keyboardhandlingenabled-is-moved-to-options).
Depends on D5414
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, b... |
129,187 | 18.10.2022 17:30:23 | 14,400 | 8988b420447ffc3ca50e005a076522e5b8ee16ba | [native] [23/34] ReactNav6: Replace mode="modal" with presentation: 'modal'
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#modemodal-is-removed-in-favor-of-presentation-modal).
Depends on D5415
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, t... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1382,6 +1382,7 @@ declare module '@react-navigation/bottom-tabs' {\n+gestureVelocityImpact: number,\n+safe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [23/34] ReactNav6: Replace mode="modal" with presentation: 'modal'
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#modemodal-is-removed-in-favor-of-presentation-modal).
Depends on D5415
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atu... |
129,187 | 19.10.2022 15:43:47 | 14,400 | e3fac0ea48a7bdb3ebc28960bead6b34b0a6b820 | [native] [25/34] ReactNav6: Update StackHeaderProps type
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#props-passed-to-custom-header-are-streamlined).
Depends on D5417
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subscribers:... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1330,12 +1330,12 @@ declare module '@react-navigation/bottom-tabs' {\n|};\ndeclare export type StackHeader... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [25/34] ReactNav6: Update StackHeaderProps type
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#props-passed-to-custom-header-are-streamlined).
Depends on D5417
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Reviewe... |
129,187 | 19.10.2022 15:48:15 | 14,400 | 3c1b1648bdce925c92e0df7855a1251b210124de | [native] [26/34] ReactNav6: Make gestureResponseDistance a number
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-gestureresponsedistance-option-is-now-a-number-instead-of-an-object).
Depends on D5418
Test Plan: Flow + ran the app on my phone and played around with it
Reviewer... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1376,7 +1376,7 @@ declare module '@react-navigation/bottom-tabs' {\n+animationEnabled: boolean,\n+animatio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [26/34] ReactNav6: Make gestureResponseDistance a number
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-gestureresponsedistance-option-is-now-a-number-instead-of-an-object).
Depends on D5418
Test Plan: Flow + ran the app on my phone and played around with it
Revi... |
129,187 | 19.10.2022 16:06:47 | 14,400 | 57e0dd20325f8341e6affe04cdb4dc6e95fadba4 | [native] [28/34] ReactNav6: Specify headerShown: false for tab bar
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#a-header-is-shown-by-default-in-tab-screens).
Depends on D5420
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subs... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1542,6 +1542,7 @@ declare module '@react-navigation/bottom-tabs' {\n|}>,\n+tabBarButton: BottomTabBarButto... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [28/34] ReactNav6: Specify headerShown: false for tab bar
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#a-header-is-shown-by-default-in-tab-screens).
Depends on D5420
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
... |
129,187 | 19.10.2022 16:16:01 | 14,400 | 3924e11a95575582fe4ffd0795d06db7bb5685fd | [native] [29/34] ReactNav6: Merge tabBarOptions into options
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-tabbaroptions-prop-is-removed-in-favor-of-more-flexible-options-for-bottom-tabs).
Depends on D5421
Test Plan: Flow + ran the app on my phone and played around with it
R... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1541,6 +1541,18 @@ declare module '@react-navigation/bottom-tabs' {\n+hide: TabBarVisibilityAnimationConfi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [29/34] ReactNav6: Merge tabBarOptions into options
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-tabbaroptions-prop-is-removed-in-favor-of-more-flexible-options-for-bottom-tabs).
Depends on D5421
Test Plan: Flow + ran the app on my phone and played around with i... |
129,187 | 19.10.2022 16:18:16 | 14,400 | 7c9726eccf762c2e9694e60859349d9d60b63e6c | [native] [30/34] ReactNav6: Remove tabBarVisible option
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-tabbarvisible-option-is-no-longer-present).
Depends on D5422
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subscribers: ... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1535,7 +1535,6 @@ declare module '@react-navigation/bottom-tabs' {\n+tabBarBadgeStyle: TextStyleProp,\n+ta... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [30/34] ReactNav6: Remove tabBarVisible option
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-tabbarvisible-option-is-no-longer-present).
Depends on D5422
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Reviewed... |
129,187 | 19.10.2022 16:21:18 | 14,400 | e57d27959985d8c7d44dc93f3b310eaa54d2fc3d | [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-lazy-prop-is-moved-to-lazy-option-for-per-screen-configuration-for-bottom-tabs).
Depends on D5423
Test Plan: Flow + ran the app on my phone and played... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"diff": "@@ -1554,6 +1554,7 @@ declare module '@react-navigation/bottom-tabs' {\n+tabBarStyle: ViewStyleProp,\n+unmount... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [31/34] ReactNav6: Move lazy prop of BottomTabBarNavigator to options
Summary:
Context on change [here](https://reactnavigation.org/docs/upgrading-from-5.x/#the-lazy-prop-is-moved-to-lazy-option-for-per-screen-configuration-for-bottom-tabs).
Depends on D5423
Test Plan: Flow + ran the app on my phone and pla... |
129,187 | 19.10.2022 16:35:53 | 14,400 | dfb194a3df9303a7f645f31f04ca1410ecbe323c | [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator
Summary:
Context on changes [in this section](https://reactnavigation.org/docs/upgrading-from-5.x/#material-top-tab-navigator).
Depends on D5424
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Subscribers: abo... | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -102,16 +102,16 @@ const ChatThreadsTopTab = createMaterialTopTabNavigator();\nfunction ChatThreadsComponent(): React.Node {\nconst colors = useColors();\nconst { tabBarBackground... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [32/34] ReactNav6: Update MaterialTopTabsNavigator
Summary:
Context on changes [in this section](https://reactnavigation.org/docs/upgrading-from-5.x/#material-top-tab-navigator).
Depends on D5424
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek
Reviewed By... |
129,187 | 19.10.2022 16:41:09 | 14,400 | 8760eb9609f35d674eb61871d6cd3c587c6f1c1d | [native] [34/34] ReactNav6: Update package versions
Summary:
Exciting!!
Depends on D5426
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek, derek
Subscribers: derek, abosh | [
{
"change_type": "RENAME",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v5.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v6.x.x.js",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "native/flow-typed/npm/@react-navigation/devtools_v5.x... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [34/34] ReactNav6: Update package versions
Summary:
Exciting!!
Depends on D5426
Test Plan: Flow + ran the app on my phone and played around with it
Reviewers: atul, tomek, bartek, derek
Reviewed By: derek
Subscribers: derek, abosh
Differential Revision: https://phab.comm.dev/D5427 |
129,206 | 12.10.2022 20:41:41 | 14,400 | d15b292342ee3fd8b2d94c86fba28e4fe006fe2f | Added tests for spoiler regex
Summary:
Added tests for spoiler regex, will test positive and negative
examples.
Test Plan: Tested results using
Reviewers: rohan, atul, ginsu
Subscribers: tomek, abosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/shared/markdown.test.js",
"diff": "+// @flow\n+\n+import { spoilerRegex } from './markdown.js';\n+\n+// Each of the below tests is subject to the following RegEx pattern:\n+// Spoiler RegEx: /^\\|\\|([^\\n]+?)\\|\\|/g\n+\n+describe('spoilerR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Added tests for spoiler regex
Summary:
Added tests for spoiler regex, will test positive and negative
examples.
Test Plan: Tested results using https://regexr.com/
Reviewers: rohan, atul, ginsu
Reviewed By: atul
Subscribers: tomek, abosh
Differential Revision: https://phab.comm.dev/D5358 |
129,189 | 20.10.2022 11:34:39 | 14,400 | 6df5a6495bc9ef37188c1ff0604d740deea7752a | [keyserver/sql] add SIWE columns
Summary: columns necessary for SIWE [[ | linear task ]]
Test Plan: run keyserver, verify columns are in table with tableplus
Reviewers: atul, varun, tomek
Subscribers: abosh, ginsu, ashoat, tomek, varun, atul | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/database/migration-config.js",
"new_path": "keyserver/src/database/migration-config.js",
"diff": "@@ -36,6 +36,17 @@ const migrations: $ReadOnlyMap<number, () => Promise<void>> = new Map([\nawait dbQuery(SQL`ALTER TABLE uploads ADD INDEX containe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver/sql] add SIWE columns
Summary: columns necessary for SIWE [[ https://linear.app/comm/issue/ENG-1966/add-siwe-columns-to-cookies-table | linear task ]]
Test Plan: run keyserver, verify columns are in table with tableplus
Reviewers: atul, varun, tomek
Reviewed By: tomek
Subscribers: abosh, ginsu, ashoat, ... |
129,184 | 21.10.2022 13:47:32 | 14,400 | 339e83a168bbe1215bd0e83c821a1e827ee6e19a | [GH Actions] Add `arm-linux-androideabi` target via `rustup` for Android CI
Summary: Fix Android CI for GitHub Actions
Test Plan: See if CI passes
Reviewers: ashoat, varun
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/android_ci.yml",
"new_path": ".github/workflows/android_ci.yml",
"diff": "@@ -24,6 +24,9 @@ jobs:\njava-version: '11'\ndistribution: 'adopt'\n+ - name: rustup target add aarch64-linux-android arm-linux-androideabi i686-linux-android x86_64-li... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [GH Actions] Add `arm-linux-androideabi` target via `rustup` for Android CI
Summary: Fix Android CI for GitHub Actions
Test Plan: See if CI passes
Reviewers: ashoat, varun
Reviewed By: ashoat, varun
Subscribers: ashoat, tomek, abosh
Differential Revision: https://phab.comm.dev/D5450 |
129,184 | 21.10.2022 14:34:55 | 14,400 | 89fb3fb5aa32d606e762944e7578cceb8bc25c97 | [GH Actions] Add `apt install protobuf-compiler` to Android CI
Summary: Attempt to fix GH Actions CI to unblock release.
Test Plan: CI
Reviewers: varun
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/android_ci.yml",
"new_path": ".github/workflows/android_ci.yml",
"diff": "@@ -27,6 +27,9 @@ jobs:\n- name: rustup target add aarch64-linux-android arm-linux-androideabi i686-linux-android x86_64-linux-android\nrun: rustup target add aarch64-l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [GH Actions] Add `apt install protobuf-compiler` to Android CI
Summary: Attempt to fix GH Actions CI to unblock release.
Test Plan: CI
Reviewers: varun
Reviewed By: varun
Subscribers: ashoat, tomek, abosh
Differential Revision: https://phab.comm.dev/D5456 |
129,184 | 21.10.2022 14:36:31 | 14,400 | b1f7ecdc14c708a1e435d4704fc4ba3280ca8609 | [yarn] Rename `yarn patch` to `yarn arcpatch`
Summary: Addresses point made by here:
Test Plan: Continues to work as expected... straightforward rename
Reviewers: varun, tomek, ginsu
Subscribers: ashoat, abosh, tomek | [
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"rust-pre-commit\": \"./scripts/rust_pre_commit.sh\",\n\"terraform-pre-commit\": \"./scripts/terraform_pre_commit.sh\",\n\"prepare\": \"husky install\",\n- \"patch\": \"git pull --all --tags && arc patch\"\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [yarn] Rename `yarn patch` to `yarn arcpatch`
Summary: Addresses point made by @tomek here: https://phab.comm.dev/D5445#inline-35863
Test Plan: Continues to work as expected... straightforward rename
Reviewers: varun, tomek, ginsu
Reviewed By: varun
Subscribers: ashoat, abosh, tomek
Differential Revision: https:/... |
129,184 | 21.10.2022 14:47:05 | 14,400 | a85b85a55f851add5e8614e6bf42e30d55cf5dd5 | [GH Actions] Attempt to fix `protobuf-compiler` installation for Android CI
Summary: There was a permissions issue so we have to use `sudo`. Also modified command to match what we have in `.github/workflows/shellcheck.yml`
Test Plan: CI
Reviewers: varun
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/android_ci.yml",
"new_path": ".github/workflows/android_ci.yml",
"diff": "@@ -27,8 +27,8 @@ jobs:\n- name: rustup target add aarch64-linux-android arm-linux-androideabi i686-linux-android x86_64-linux-android\nrun: rustup target add aarch64-l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [GH Actions] Attempt to fix `protobuf-compiler` installation for Android CI
Summary: There was a permissions issue so we have to use `sudo`. Also modified command to match what we have in `.github/workflows/shellcheck.yml`
Test Plan: CI
Reviewers: varun
Reviewed By: varun
Subscribers: ashoat, tomek, abosh
Differe... |
129,184 | 24.10.2022 09:11:30 | 14,400 | ded8df036dc0859178b9af16d03b92ee9e3a0553 | [native] `codeVersion` -> 150 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -444,8 +444,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 150 |
129,184 | 24.10.2022 11:16:16 | 14,400 | bc520a2fba9e40bb09c2b5ee357658e7f578deea | [native] `codeVersion` -> 151 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -444,8 +444,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 151 |
129,184 | 24.10.2022 16:27:21 | 14,400 | f858ee10b0007c30be68c4b9055d15710798e79f | [ios] Update `Podfile.lock`
Summary: Corresponding changes to `Podfile.lock` after landing the reanimated bump:
Test Plan: NA, ran `yarn cleaninstall` on `master`.
Reviewers: varun, marcin, tomek
Subscribers: tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -868,7 +868,7 @@ PODS:\n- React-Core\n- RNKeychain (8.0.0):\n- React-Core\n- - RNReanimated (2.4.1):\n+ - RNReanimated (2.10.0):\n- DoubleConversion\n- FBLazyVector\n- FBReactNativeSp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [ios] Update `Podfile.lock`
Summary: Corresponding changes to `Podfile.lock` after landing the reanimated bump: https://github.com/CommE2E/comm/commit/34eb8d4b830e9bd535f06bdc7f544bdafa5b6e15
Test Plan: NA, ran `yarn cleaninstall` on `master`.
Reviewers: varun, marcin, tomek
Reviewed By: varun
Subscribers: tomek, ... |
129,187 | 27.10.2022 10:08:49 | 14,400 | 4ab9b07c828f3a44d67ef72127aa3942b35e78c5 | [keyserver] Allow for larger crash reports to be uploaded
Summary: See details in "Attempt to submit crash report" section of [ENG-1821](https://linear.app/comm/issue/ENG-1821#comment-70811db9).
Test Plan: Tested this live in production :)
Reviewers: atul
Subscribers: tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/docker-compose.yml",
"new_path": "keyserver/docker-compose.yml",
"diff": "@@ -30,7 +30,7 @@ services:\nexpose:\n- \"3306\"\ncommand: >\n- --max-allowed-packet=64M\n+ --max-allowed-packet=256M\n--local-infile=0\n--sql-mode=STRICT_ALL_TABLES\n--innodb-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Allow for larger crash reports to be uploaded
Summary: See details in "Attempt to submit crash report" section of [ENG-1821](https://linear.app/comm/issue/ENG-1821#comment-70811db9).
Test Plan: Tested this live in production :)
Reviewers: atul
Reviewed By: atul
Subscribers: tomek, abosh
Differential R... |
129,184 | 27.10.2022 15:57:37 | 14,400 | 29284e1e5fa3e8c8cae73615468f3b605d55e726 | [native] `codeVersion` -> 152 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -444,8 +444,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 152 |
129,182 | 30.10.2022 21:38:01 | -3,600 | ac8f8e05eee51d33e05773272918f7b6146234a5 | [native] Generate device ID using Rust
Summary: Generate unique device ID on native using rust's crates, as suggested in D4616.
Test Plan: Run `cargo test` in native/native_rust_library
Reviewers: tomek, varun, max, ashoat, marcin
Subscribers: jon, ashoat, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/native_rust_library/Cargo.lock",
"new_path": "native/native_rust_library/Cargo.lock",
"diff": "# It is not intended for manual editing.\nversion = 3\n+[[package]]\n+name = \"aho-corasick\"\n+version = \"0.7.19\"\n+source = \"registry+https://github.com/... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Generate device ID using Rust
Summary: Generate unique device ID on native using rust's crates, as suggested in D4616.
Test Plan: Run `cargo test` in native/native_rust_library
Reviewers: tomek, varun, max, ashoat, marcin
Reviewed By: tomek, varun, ashoat, marcin
Subscribers: jon, ashoat, atul, abosh
Dif... |
129,206 | 25.10.2022 22:08:38 | 14,400 | c23876e01ba4ee6ad4fed018d8be23d82b6d6766 | added tests to check spoiler regex extracted values
Summary:
added a few tests to make sure the spoiler regex is actually
extracting the correct spoiler text.
Test Plan: tested manually by hand
Reviewers: ginsu, atul, rohan
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/markdown.test.js",
"new_path": "lib/shared/markdown.test.js",
"diff": "@@ -51,4 +51,34 @@ describe('spoilerRegex', () => {\nexpect('|| \\n\\\n||').not.toMatch(spoilerRegex);\n});\n+\n+ it(\"We expect to extract 'hello' from the following spoiler: ||... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | added tests to check spoiler regex extracted values
Summary:
added a few tests to make sure the spoiler regex is actually
extracting the correct spoiler text.
Test Plan: tested manually by hand
Reviewers: ginsu, atul, rohan
Reviewed By: ginsu, rohan
Subscribers: ashoat, tomek, abosh
Differential Revision: https:/... |
129,187 | 31.10.2022 12:33:20 | 14,400 | 764a3e16a557fca99b6dc0f9da65492fe99f66b8 | [landing] Fix typo in investor data
Test Plan: I haven't tested this
Reviewers: ginsu
Subscribers: tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "landing/investor-data.js",
"new_path": "landing/investor-data.js",
"diff": "@@ -543,7 +543,7 @@ const investorsData: $ReadOnlyArray<Investors> = [\n{\nid: 'david_rodriguez',\nname: 'David Rodriguez',\n- description: 'Co-Founder and Managing Partner at Draft Ve... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix typo in investor data
Test Plan: I haven't tested this
Reviewers: ginsu
Reviewed By: ginsu
Subscribers: tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5511 |
129,184 | 31.10.2022 16:20:38 | 14,400 | 5f0effca47439f508052c71241fa8cbe3132a6e2 | [native] Introduce `StaffContext`
Summary:
Context:
This diff is essentially copy/paste of `native/root-context.js` (which is why I made it a separate diff)
Depends on D5498
Test Plan: NA
Reviewers: marcin, tomek, varun, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/staff/staff-context.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+export type StaffContextType = {\n+ +staffUserHasBeenLoggedIn: boolean,\n+};\n+\n+const StaffContext: React.Context<StaffContextType> = React.createCont... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce `StaffContext`
Summary:
Context: https://linear.app/comm/issue/ENG-2134/have-a-flag-that-indicates-whether-the-build-is-a-staff-release
This diff is essentially copy/paste of `native/root-context.js` (which is why I made it a separate diff)
---
Depends on D5498
Test Plan: NA
Reviewers: marcin, ... |
129,189 | 31.10.2022 16:14:36 | 14,400 | e4e42e88c56c876173fa611b3cae6602d83fc614 | [keyserver] added siwe packages
Test Plan: run keyserver, investigate licensing etc.
Reviewers: ashoat, atul, varun
Subscribers: abosh, tomek, ginsu, varun, atul, ashoat | [
{
"change_type": "MODIFY",
"old_path": "keyserver/package.json",
"new_path": "keyserver/package.json",
"diff": "\"common-tags\": \"^1.7.2\",\n\"cookie-parser\": \"^1.4.3\",\n\"dateformat\": \"^3.0.3\",\n+ \"ethers\": \"^5.7.2\",\n\"express\": \"^4.17.1\",\n\"express-ws\": \"^4.0.0\",\n\"firebase-adm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] added siwe packages
Test Plan: run keyserver, investigate licensing etc.
Reviewers: ashoat, atul, varun
Reviewed By: ashoat
Subscribers: abosh, tomek, ginsu, varun, atul, ashoat
Differential Revision: https://phab.comm.dev/D5512 |
129,206 | 01.11.2022 14:17:04 | 14,400 | fc0d37a56c5b721fe2d872fe2ae1dd4ec62d4093 | added no-var rule to root level eslint
Summary: added no-var rule to root level eslint
Test Plan:
Went to a few files before committing eslint change, and I was
able to see that var cannot be used.
Reviewers: atul, rohan, ginsu
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": ".eslintrc.json",
"new_path": ".eslintrc.json",
"diff": "\"no-unused-vars\": [\"error\", { \"ignoreRestSiblings\": true }],\n\"react/prop-types\": [\"error\", { \"skipUndeclared\": true }],\n\"no-shadow\": 1,\n+ \"no-var\": \"error\",\n\"import/order\": [\n\"wa... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | added no-var rule to root level eslint
Summary: added no-var rule to root level eslint
Test Plan:
Went to a few files before committing eslint change, and I was
able to see that var cannot be used.
Reviewers: atul, rohan, ginsu
Reviewed By: atul, rohan, ginsu
Subscribers: ashoat, tomek, abosh
Differential Revisio... |
129,187 | 07.11.2022 09:48:42 | 18,000 | 565ebe619583ac03be37e252efe51c5d12ebc949 | [native] Update to
Summary: This resolves Android CI issue](https://linear.app/comm/issue/ENG-2181/android-ci-issue). More context [here](https://github.com/facebook/react-native/issues/35210).
Test Plan: Confirm Android builds are fixed
Reviewers: tomek, bartek, atul
Subscribers: abosh | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -386,14 +386,14 @@ PODS:\n- EXSplashScreen (0.13.5):\n- ExpoModulesCore\n- React-Core\n- - FBLazyVector (0.66.4)\n- - FBReactNativeSpec (0.66.4):\n+ - FBLazyVector (0.66.5)\n+ - FBRea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update to react-native@0.66.5
Summary: This resolves [ENG-2181: Android CI issue](https://linear.app/comm/issue/ENG-2181/android-ci-issue). More context [here](https://github.com/facebook/react-native/issues/35210).
Test Plan: Confirm Android builds are fixed
Reviewers: tomek, bartek, atul
Reviewed By: tom... |
129,187 | 04.11.2022 13:18:50 | 14,400 | 7a442aeae8b8321b16fb5ce226195567b30e2cc3 | [native] Update libdef for React Nav 6
Summary:
See D5537 and [ENG-2175](https://linear.app/comm/issue/ENG-2175/add-and-update-react-navigation-libdef-for-react-navigationdrawer) for context. Will describe changes and where they came from inline.
Depends on D5537
Test Plan: Flow
Reviewers: atul, inka, tomek
Subscribers... | [
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v6.x.x.js",
"new_path": "native/flow-typed/npm/@react-navigation/bottom-tabs_v6.x.x.js",
"diff": "@@ -742,7 +742,7 @@ declare module '@react-navigation/bottom-tabs' {\ndeclare export type DrawerRouterOptions ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update @react-navigation/drawer libdef for React Nav 6
Summary:
See D5537 and [ENG-2175](https://linear.app/comm/issue/ENG-2175/add-and-update-react-navigation-libdef-for-react-navigationdrawer) for context. Will describe changes and where they came from inline.
Depends on D5537
Test Plan: Flow
Reviewers: ... |
129,182 | 08.11.2022 09:41:20 | -3,600 | 8082920bcab09a88ecbadb7954119a33c155e666 | [native] Refactor app-navigator.js
Summary:
tab navigator and overlay navigator should be in separate files.
Linear issue:
Test Plan: run ios simulator
Reviewers: tomek, atul, ginsu, bartek
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -53,7 +53,6 @@ import {\naddKeyboardDismissListener,\nremoveKeyboardListener,\n} from '../keyboard/keyboard';\n-import type { TabNavigationProp } from '../navigati... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Refactor app-navigator.js
Summary:
tab navigator and overlay navigator should be in separate files.
Linear issue: https://linear.app/comm/issue/ENG-1883/refactor-app-navigatorjs-so-each-navigator-has-its-own-file
Test Plan: run ios simulator
Reviewers: tomek, atul, ginsu, bartek
Reviewed By: tomek, ginsu, ... |
129,184 | 08.11.2022 10:24:09 | 18,000 | 5b72c8d08824c512a39d222ed9b04ce7b972f005 | Temporary changes for staff release
Includes:
Previous changes for release (https://github.com/CommE2E/comm/commit/ca20b607a2ca7126d16896d6e806aa923006a726)
D5377: Refactor code to perform migration inside one transaction
D5378: Introduce function to create database
D5379: Introduce function to set up database | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -308,6 +308,88 @@ bool add_not_null_constraint_to_metadata(sqlite3 *db) {\nreturn false;\n}\n+bool create_s... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Temporary changes for staff release
Includes:
- Previous changes for release (https://github.com/CommE2E/comm/commit/ca20b607a2ca7126d16896d6e806aa923006a726)
- D5377: Refactor code to perform migration inside one transaction
- D5378: Introduce function to create database
- D5379: Introduce function to set up database |
129,184 | 08.11.2022 10:26:30 | 18,000 | 06cadf6e8b30dfabdbe83e6473370a5f3a37b757 | [native] `codeVersion` -> 153 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -444,8 +444,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 153 |
129,200 | 08.11.2022 15:50:03 | 18,000 | e3931957ac95583bd2d42e68f41769c79a97eaf5 | [services][identity] new constant
Summary: this is really just for clean error handling.
Test Plan: this is dead code so nothing really to test. you can run `cargo build` in the identity cargo project root to confirm this.
Reviewers: atul, jon
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "services/identity/src/constants.rs",
"new_path": "services/identity/src/constants.rs",
"diff": "@@ -11,6 +11,7 @@ pub const USERS_TABLE_PARTITION_KEY: &str = \"userID\";\npub const USERS_TABLE_REGISTRATION_ATTRIBUTE: &str = \"pakeRegistrationData\";\npub const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][identity] new constant
Summary: this is really just for clean error handling.
Test Plan: this is dead code so nothing really to test. you can run `cargo build` in the identity cargo project root to confirm this.
Reviewers: atul, jon
Reviewed By: atul
Subscribers: ashoat, tomek, abosh
Differential Revis... |
129,196 | 07.11.2022 17:25:48 | -3,600 | 47d92cee06af46d634a0e7306688a40ec0ccb739 | Run SQLite queries in parallel in SQLiteContextProvider
Summary: This differential enables SQLite queries to run in parallel.
Test Plan: Build app and launch it.
Reviewers: atul, tomek, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/data/sqlite-context-provider.js",
"new_path": "native/data/sqlite-context-provider.js",
"diff": "@@ -38,7 +38,10 @@ function SQLiteContextProvider(props: Props): React.Node {\n}\n(async () => {\ntry {\n- const threads = await commCoreModule.getAllThread... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Run SQLite queries in parallel in SQLiteContextProvider
Summary: This differential enables SQLite queries to run in parallel.
Test Plan: Build app and launch it.
Reviewers: atul, tomek, ashoat
Reviewed By: ashoat
Subscribers: ashoat, abosh
Differential Revision: https://phab.comm.dev/D5543 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.