author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,206 | 09.11.2022 16:44:09 | 18,000 | 626fb77c224ab76400d08606a5818a84190268ec | added glow effect behind modals
Summary: glow effect adds contrast between modals and background.
Test Plan: Checked different modals in app, all seem to show a glow.
Reviewers: ginsu, atul, jon
Subscribers: ashoat, tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/color-selector-modal.react.js",
"new_path": "native/chat/settings/color-selector-modal.react.js",
"diff": "@@ -151,9 +151,7 @@ const unboundStyles = {\n},\ncolorSelectorContainer: {\nbackgroundColor: 'modalBackground',\n- borderColor: 'mod... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | added glow effect behind modals
Summary: glow effect adds contrast between modals and background.
Test Plan: Checked different modals in app, all seem to show a glow.
Reviewers: ginsu, atul, jon
Reviewed By: atul
Subscribers: ashoat, tomek, abosh
Differential Revision: https://phab.comm.dev/D5588 |
129,184 | 10.11.2022 12:33:04 | 18,000 | d8ff5dff60401ecd0a272a06011d2a80b936480c | [native] Pull `useIsCurrentUserStaff()` out of `useStaffCanSee()`
Summary: Pull `useIsCurrentUserStaff()` out from `useStaffCanSee()` and consume in `BuildInfo` and `StaffContextProvider`.
Test Plan: `BuildInfo` + `StaffContextProvider` continue to look/work as expected.
Reviewers: tomek, marcin, varun, ginsu, rohan, O... | [
{
"change_type": "MODIFY",
"old_path": "native/profile/build-info.react.js",
"new_path": "native/profile/build-info.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, ScrollView } from 'react-native';\n-import { useSelector } from 'react-redux';\n-\n-import { isStaff } from 'l... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pull `useIsCurrentUserStaff()` out of `useStaffCanSee()`
Summary: Pull `useIsCurrentUserStaff()` out from `useStaffCanSee()` and consume in `BuildInfo` and `StaffContextProvider`.
Test Plan: `BuildInfo` + `StaffContextProvider` continue to look/work as expected.
Reviewers: tomek, marcin, varun, ginsu, rohan... |
129,184 | 10.11.2022 21:03:31 | 18,000 | aabfb68826c2f7b900c96ed54f87712b2bacfc76 | [native] Update `listChatBubble` for light mode
Summary: Context:
Test Plan:
Before:
{F232490}
After:
{F232491}
Things look as expected.
Reviewers: tomek, marcin, ginsu, rohan, abosh, varun, O2 Blocking Reviewers, ashoat
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/themes/colors.js",
"new_path": "native/themes/colors.js",
"diff": "@@ -29,7 +29,7 @@ const light = Object.freeze({\nlistBackgroundLabel: 'black',\nlistBackgroundSecondaryLabel: '#444444',\nlistBackgroundTernaryLabel: '#999999',\n- listChatBubble: '#DDDD... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update `listChatBubble` for light mode
Summary: Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native
Test Plan:
Before:
{F232490}
After:
{F232491}
Things look as expected.
Reviewers: tomek, marcin, ginsu, rohan, abosh, varun, O2 Blocking Reviewers, ashoat
Reviewed By: ginsu,... |
129,184 | 10.11.2022 22:16:57 | 18,000 | eaa421707f81123e05571c624c830d8b97b5434e | [native] Fix appearance of `Calendar` in light mode
Summary: Context:
Test Plan:
Before:
{F232574}
After:
{F232573}
Things looks as expected (on dark mode as well).
Reviewers: tomek, marcin, ginsu, rohan, abosh, varun, O2 Blocking Reviewers, ashoat
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -1031,7 +1031,7 @@ const unboundStyles = {\nbottom: 0,\n},\nsectionHeader: {\n- backgroundColor: 'panelForeground',\n+ backgroundColor: 'panelSecondaryForeground',... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix appearance of `Calendar` in light mode
Summary: Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native
Test Plan:
Before:
{F232574}
After:
{F232573}
Things looks as expected (on dark mode as well).
Reviewers: tomek, marcin, ginsu, rohan, abosh, varun, O2 Blocking Reviewers, a... |
129,187 | 13.11.2022 13:07:10 | 18,000 | 192b1b7cf7ac6338e9e47ecf765db4a50e8f4b33 | [docs] Copy JDK docs into Nix
Summary: This is the copy-paste part of D5544, separating based on ["Moving code around" doc](https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314)
Test Plan: N/A
Reviewers: jon!, varun, atul
Subscribers: tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "docs/nix_dev_env.md",
"new_path": "docs/nix_dev_env.md",
"diff": "@@ -50,6 +50,7 @@ On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for\n- [Xcode](./nix_mobile_setup.md#xcode)\n- [Xcode settings](./nix_mobile_setup.md#xcode-settings... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] Copy JDK docs into Nix
Summary: This is the copy-paste part of D5544, separating based on ["Moving code around" doc](https://www.notion.so/commapp/Moving-code-around-bbb551c4350b4d5cb553c6751be44314)
Test Plan: N/A
Reviewers: jon!, varun, atul
Subscribers: tomek, atul, abosh
Differential Revision: https://p... |
129,187 | 13.11.2022 15:13:27 | 18,000 | 27d586bba3870d0f318145676b302f4c527e51b2 | Fix typo in D5625 | [
{
"change_type": "MODIFY",
"old_path": "docs/nix_dev_env.md",
"new_path": "docs/nix_dev_env.md",
"diff": "@@ -49,7 +49,7 @@ On macOS, [installing Xcode](./nix_mobile_setup.md#xcode) is a prerequisite for\n- [iOS development](./nix_mobile_setup.md#ios-development)\n- [Xcode](./nix_mobile_setup.md#xco... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Fix typo in D5625 |
129,184 | 11.11.2022 17:18:24 | 18,000 | 38f16638f790f829f01bc1dc894f902d89b01438 | [native] Fix appearance of `ColorSelectorModal` in light mode
Summary: Context:
Test Plan:
Before:
{F233540}
After:
{F233541}
Things look as expected (on dark mode as well).
Reviewers: tomek, marcin, ginsu, rohan, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/components/color-selector-button.react.js",
"new_path": "native/components/color-selector-button.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { StyleSheet, TouchableOpacity, View } from 'react-native';\n+import { TouchableOpaci... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix appearance of `ColorSelectorModal` in light mode
Summary: Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native
Test Plan:
Before:
{F233540}
After:
{F233541}
Things look as expected (on dark mode as well).
Reviewers: tomek, marcin, ginsu, rohan, ashoat
Reviewed By: ashoa... |
129,184 | 11.11.2022 17:35:25 | 18,000 | fa236b17b5f701c2f4f388eed6d5032ec8eb7ae7 | [native] Fix appearance of `Tooltip` in light mode
Summary: Context:
Test Plan:
Before:
{F233569}
After:
{F233570}
Things look as expected (on dark mode as well).
Reviewers: tomek, marcin, rohan, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/tooltip.react.js",
"new_path": "native/navigation/tooltip.react.js",
"diff": "@@ -10,7 +10,6 @@ import invariant from 'invariant';\nimport * as React from 'react';\nimport {\nView,\n- StyleSheet,\nTouchableWithoutFeedback,\nPlatform,\nTouchab... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix appearance of `Tooltip` in light mode
Summary: Context: https://linear.app/comm/issue/ENG-2052/re-introduce-light-mode-in-native
Test Plan:
Before:
{F233569}
After:
{F233570}
Things look as expected (on dark mode as well).
Reviewers: tomek, marcin, rohan, ashoat
Reviewed By: ashoat
Subscribers: as... |
129,188 | 07.11.2022 17:59:23 | -3,600 | 24dec60ecf51d9cb4bd34974c0da263f24fbe9ca | [native] fix `getDeviceID` return type
Summary:
context: [eng-2184](https://linear.app/comm/issue/ENG-2184/fix-setdeviceid-operation)
Fix the typo in type definition.
Test Plan:
1. Build app
2. Check if `deviceID` value is properly returned
Reviewers: marcin, inka, tomek
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "@@ -51,7 +51,7 @@ export interface Spec extends TurboModule {\n+setCurrentUserID: (userID: string) => Promise<void>;\n+getCurrentUserID: () => Promise<string>... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] fix `getDeviceID` return type
Summary:
context: [eng-2184](https://linear.app/comm/issue/ENG-2184/fix-setdeviceid-operation)
Fix the typo in type definition.
Test Plan:
1. Build app
2. Check if `deviceID` value is properly returned
Reviewers: marcin, inka, tomek
Reviewed By: marcin, inka, tomek
Subscriber... |
129,184 | 16.11.2022 09:54:12 | 18,000 | 69293f1edd61ed0c8213176f4a06545a721b8735 | [lib] Fix typo `assetMediaMessageType` => `assertMediaMessageType`
Summary: Super minor fix.
Test Plan: This function isn't used anywhere in the codebase. I'm about to use it though.
Reviewers: tomek, ginsu, rohan, marcin, kamil, O2 Blocking Reviewers
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -199,7 +199,7 @@ const mediaMessageTypes = new Set([\nexport function isMediaMessageType(ourMessageType: MessageType): boolean {\nreturn mediaMessageTypes.has(ourMessageType);\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix typo `assetMediaMessageType` => `assertMediaMessageType`
Summary: Super minor fix.
Test Plan: This function isn't used anywhere in the codebase. I'm about to use it though.
Reviewers: tomek, ginsu, rohan, marcin, kamil, O2 Blocking Reviewers
Reviewed By: tomek, rohan, O2 Blocking Reviewers
Subscribers: a... |
129,178 | 16.11.2022 12:36:34 | 18,000 | d9d0fc787f6dd6b21741e531c6958a14f02f16db | [landing] added Steven to team page
Summary: added Steven
Test Plan:
Please see screenshots of changes I made
Before:
{F247736}
After:
{F247737}
Reviewers: atul, rohan
Subscribers: ashoat, tomek, atul, abosh | [
{
"change_type": "MODIFY",
"old_path": "landing/team.react.js",
"new_path": "landing/team.react.js",
"diff": "@@ -92,6 +92,11 @@ function Team(): React.Node {\ntwitterHandle=\"ginsueddy\"\nimageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}\n/>\n+ <TeamProfile\n+ name=\"Steven Cherucheril\"\n+ role=\"Chi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] added Steven to team page
Summary: added Steven
Test Plan:
Please see screenshots of changes I made
Before:
{F247736}
After:
{F247737}
Reviewers: atul, rohan
Reviewed By: atul, rohan
Subscribers: ashoat, tomek, atul, abosh
Differential Revision: https://phab.comm.dev/D5653 |
129,187 | 16.11.2022 23:17:47 | 18,000 | 03e8e711df58ac3eb0c678b16c2c13f17765190b | [lib] Clear MessageStore on freshMessageStore
Summary: We don't seem to use `remove_all` on the messages side, but we do on the threads side. Was this an oversight?
Test Plan: Haven't tested yet, mostly just asking posing this as a question
Reviewers: atul
Subscribers: tomek, abosh | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -140,10 +140,16 @@ function freshMessageStore(\nconst orderedMessageInfos = sortMessageInfoList(unshimmed);\nconst messages = _keyBy(messageID)(orderedMessageInfos);\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Clear MessageStore on freshMessageStore
Summary: We don't seem to use `remove_all` on the messages side, but we do on the threads side. Was this an oversight?
Test Plan: Haven't tested yet, mostly just asking posing this as a question
Reviewers: atul
Reviewed By: atul
Subscribers: tomek, abosh
Differential ... |
129,184 | 18.11.2022 15:59:58 | 18,000 | 0cb917cd53d10eee1b56af7dfcd76b97398c4d51 | [native] `codeVersion` -> 154 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -444,8 +444,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 154 |
129,178 | 18.11.2022 18:20:34 | 18,000 | 1132715d25311186b8ee340937632d73eb143ec2 | [lib] introduced ReactionMessageInfo
Summary:
introduced `ReactionMessageInfo` to message types. This type will be needed in our Reaction Message Spec
Linear Task: [[ | ]]
Test Plan: `Flow` and this will be further tested in subsequent diffs
Reviewers: atul, rohan
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -335,6 +335,16 @@ export type SidebarSourceMessageInfo = {\n+sourceMessage: ComposableMessageInfo | RobotextMessageInfo,\n};\n+export type ReactionMessageInfo = {\n+ +type: 19,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] introduced ReactionMessageInfo
Summary:
introduced `ReactionMessageInfo` to message types. This type will be needed in our Reaction Message Spec
---
Linear Task: [[ https://linear.app/comm/issue/ENG-2243/message-likes | ENG-2243 ]]
Test Plan: `Flow` and this will be further tested in subsequent diffs
Reviewe... |
129,187 | 18.11.2022 09:12:53 | 18,000 | 10dae0d8774fca12bc561d78f2daabb7473e27f3 | [lib] Introduce newThread helper to message-reducer.js
Summary: This should be a no-op. The only change is that we will have slightly different pruning times, but that should not be significant.
Test Plan: Flow, and also the other testing I've done for the stack
Reviewers: atul, tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -126,6 +126,13 @@ function isThreadWatched(\n);\n}\n+const newThread = () => ({\n+ messageIDs: [],\n+ startReached: false,\n+ lastNavigatedTo: 0,\n+ lastPruned: Date.n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce newThread helper to message-reducer.js
Summary: This should be a no-op. The only change is that we will have slightly different pruning times, but that should not be significant.
Test Plan: Flow, and also the other testing I've done for the stack
Reviewers: atul, tomek
Reviewed By: atul
Differentia... |
129,184 | 22.11.2022 18:30:23 | 18,000 | 00d1519a8405631f2fa2ec370c62cc80d6325a75 | [native] `codeVersion` -> 155 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -444,8 +444,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 155 |
129,196 | 16.11.2022 13:28:36 | -3,600 | 22edb962ced2ab759e5357e89d03f5d07f8c7cb9 | Bring drafts and related actions to redux
Summary: This differential creates a place for drafts in redux, and makes actions to handle them visible for reducers.
Test Plan: Make sure eslint and flow do not point errors.
Reviewers: tomek, atul, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/website-responders.js",
"new_path": "keyserver/src/responders/website-responders.js",
"diff": "@@ -310,6 +310,7 @@ async function websiteResponder(\nnavInfo: navInfoPromise,\ndeviceID: null,\ncurrentUserInfo: ((currentUserInfoPromise: ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Bring drafts and related actions to redux
Summary: This differential creates a place for drafts in redux, and makes actions to handle them visible for reducers.
Test Plan: Make sure eslint and flow do not point errors.
Reviewers: tomek, atul, ashoat
Reviewed By: tomek, atul
Subscribers: ashoat, abosh
Differential... |
129,196 | 16.11.2022 14:03:09 | -3,600 | 03c2c2e930cde7b020f86625468bfc2954aaf31d | Implement draft reducer and use it in master reducer
Summary: This differential implements draft reducer and uses it in master reducer
Test Plan: Make sure eslint and flow do not point errors.
Reviewers: tomek, atul, ashoat
Subscribers: ashoat, abosh | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/reducers/draft-reducer.js",
"diff": "+// @flow\n+\n+import {\n+ moveDraftActionType,\n+ setDraftStoreDrafts,\n+ updateDraftActionType,\n+} from '../actions/draft-actions';\n+import {\n+ deleteAccountActionTypes,\n+ logOutActionTypes,\n+} fro... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement draft reducer and use it in master reducer
Summary: This differential implements draft reducer and uses it in master reducer
Test Plan: Make sure eslint and flow do not point errors.
Reviewers: tomek, atul, ashoat
Reviewed By: tomek, atul, ashoat
Subscribers: ashoat, abosh
Differential Revision: https:/... |
129,196 | 16.11.2022 14:09:00 | -3,600 | ee8553ccdb3d5c2fd94d1bb6d7d7489d344633d9 | Implement DraftStoreOperations C++ utility
Summary: This differential implements DraftStoreOperations C++ utility to convert drafts related redux actions payloads to DatabaseQueryExecutor calls.
Test Plan: This differential only introduces C++ header file, so it is not possible to create test plan.
Reviewers: tomek, at... | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/NativeModules/DraftStoreOperations.h",
"diff": "+#pragma once\n+\n+namespace comm {\n+class DraftStoreOperationBase {\n+public:\n+ virtual void execute() = 0;\n+ virtual ~DraftStoreOperationBase(){};\n+};\n+\n+class UpdateDr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement DraftStoreOperations C++ utility
Summary: This differential implements DraftStoreOperations C++ utility to convert drafts related redux actions payloads to DatabaseQueryExecutor calls.
Test Plan: This differential only introduces C++ header file, so it is not possible to create test plan.
Reviewers: tomek,... |
129,196 | 16.11.2022 14:15:24 | -3,600 | 15cd91b15b5f0ac7d90b7d5a2f3b956df9b15058 | Implement draft store operations processing in CommCoreModule
Summary: This differential implements draft store processing functionality in CommCoreModule to enable bulk drafts dump to SQLite.
Test Plan: Make sure eslint and flow do not point errors.
Reviewers: tomek, atul, jon
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "#include \"CommCoreModule.h\"\n#include \"../CryptoTools/DeviceID.h\"\n#include \"DatabaseManager.h\"\n+#include \"DraftStoreO... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Implement draft store operations processing in CommCoreModule
Summary: This differential implements draft store processing functionality in CommCoreModule to enable bulk drafts dump to SQLite.
Test Plan: Make sure eslint and flow do not point errors.
Reviewers: tomek, atul, jon
Reviewed By: tomek, atul
Subscribers... |
129,196 | 16.11.2022 14:19:20 | -3,600 | ee59fc68892d78faca08c8a096646f930e4f263f | Persist drafts in SQLite
Summary: This differential uses new CommCoreModule functionality to persist drafts in SQLite database.
Test Plan: At this point a potential test would involve dispatching appriproate redux action and examine flipper and SQLite.
Reviewers: atul, tomek
Subscribers: ashoat, abosh | [
{
"change_type": "MODIFY",
"old_path": "native/redux/redux-setup.js",
"new_path": "native/redux/redux-setup.js",
"diff": "@@ -349,7 +349,11 @@ function reducer(state: AppState = defaultState, action: Action) {\nstate = baseReducerResult.state;\nconst { storeOperations } = baseReducerResult;\n- const... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Persist drafts in SQLite
Summary: This differential uses new CommCoreModule functionality to persist drafts in SQLite database.
Test Plan: At this point a potential test would involve dispatching appriproate redux action and examine flipper and SQLite.
Reviewers: atul, tomek
Reviewed By: atul, tomek
Subscribers: a... |
129,196 | 23.11.2022 15:08:36 | -3,600 | 755db82cfb9b3d5347aee744c08ada4c37318e86 | Introduce bulk db store redux action
Summary: This differential defines types for new bulk db store redux action
Test Plan: Make sure eslint and flow do not complain
Reviewers: atul, tomek
Subscribers: ashoat | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/actions/client-db-store-actions.js",
"diff": "+// @flow\n+\n+const setClientDBStoreActionType = 'SET_CLIENT_DB_STORE';\n+\n+export { setClientDBStoreActionType };\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/draft-type... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Introduce bulk db store redux action
Summary: This differential defines types for new bulk db store redux action
Test Plan: Make sure eslint and flow do not complain
Reviewers: atul, tomek
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D5708 |
129,196 | 23.11.2022 15:40:36 | -3,600 | bef6581335f201505892ba37f57d43ecb5261dff | Remove old redux actions
Summary: This differential removes old unnecessary redux actions
Test Plan: Make sure eslint and flow do not complain
Reviewers: atul, tomek
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/draft-actions.js",
"new_path": "lib/actions/draft-actions.js",
"diff": "const updateDraftActionType = 'UPDATE_DRAFT';\nconst moveDraftActionType = 'MOVE_DRAFT';\n-const setDraftStoreDrafts = 'SET_DRAFT_STORE_DRAFTS';\n-export { updateDraftActionTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove old redux actions
Summary: This differential removes old unnecessary redux actions
Test Plan: Make sure eslint and flow do not complain
Reviewers: atul, tomek
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D5712 |
129,180 | 25.11.2022 12:38:40 | -3,600 | fd77f5bcf28a7e058e004f03afeaa7958f085dee | [web] Added on enter animation for typeahead overlay.
Summary: As specified in the design, added 100ms ease-in animation.
Test Plan:
See video:
{F260966}
Reviewers: tomek, atul, kamil
Subscribers: ashoat, kamil, atul, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/chat/mention-suggestion-tooltip.css",
"new_path": "web/chat/mention-suggestion-tooltip.css",
"diff": ".suggestion:hover {\nbackground-color: var(--typeahead-overlay-light);\n}\n+\n+.notVisible {\n+ opacity: 0;\n+}\n+\n+.visible {\n+ opacity: 1;\n+ transiti... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Added on enter animation for typeahead overlay.
Summary: As specified in the design, added 100ms ease-in animation.
Test Plan:
See video:
{F260966}
Reviewers: tomek, atul, kamil
Reviewed By: tomek
Subscribers: ashoat, kamil, atul, tomek
Differential Revision: https://phab.comm.dev/D5726 |
129,184 | 29.11.2022 13:34:12 | 28,800 | d2ad76b2f49447f5ec002744f7668f446166c6af | [native] `codeVersion` -> 156 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 156 |
129,184 | 29.11.2022 13:37:23 | 28,800 | 1317473ae1be244ba890c438e82ed8883ca39cf7 | [native] `codeVersion` -> 157 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 157 |
129,184 | 29.11.2022 18:12:10 | 28,800 | 4c9e7ca31451ab1762974c140a12e98beb22ab1a | [native] `codeVersion` -> 158 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 158 |
129,184 | 30.11.2022 09:00:52 | 28,800 | c0e7c7b53b61484198b3e79dd8ddf3b4f5ca22bc | [native] `codeVersion` -> 159 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 159 |
129,184 | 30.11.2022 09:04:57 | 28,800 | 3bba43519de16bf90b7f91aa050589b4158b43d3 | [native] `codeVersion` -> 160 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 160 |
129,187 | 24.11.2022 11:05:03 | 18,000 | cad6ae6523f2b7696d7af0264dd9f71449a0eaa9 | [native] Introduce TextMessageMarkdownContext
Summary: We need the AST from inside `InnerTextMessage` in order to determine whether the Markdown has any "pressables" (link or spoiler for now, but in the future).
Test Plan: Flow, tested with following diff
Reviewers: rohan, atul, ginsu, michal
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/inner-text-message.react.js",
"new_path": "native/chat/inner-text-message.react.js",
"diff": "@@ -18,6 +18,10 @@ import {\nfilterCorners,\ngetRoundedContainerStyle,\n} from './rounded-corners';\n+import {\n+ TextMessageMarkdownContext,\n+ useTextMe... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Introduce TextMessageMarkdownContext
Summary: We need the AST from inside `InnerTextMessage` in order to determine whether the Markdown has any "pressables" (link or spoiler for now, but @mention in the future).
Test Plan: Flow, tested with following diff
Reviewers: rohan, atul, ginsu, michal
Reviewed By: ... |
129,187 | 29.11.2022 21:27:41 | 18,000 | b589a7bbd40be4b99be2eeb867f6b2ea01bf78d3 | [native] Pass TextMessage.onPress down via context
Summary: Descendants of this component will need to call `onPress`.
Test Plan: I tested this in combination with the next diff. See attached video in the next diff
Reviewers: rohan, atul, ginsu, michal
Subscribers: tomek | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/chat/message-press-responder-context.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+export type MessagePressResponderContextType = {\n+ +onPressMessage: () => void,\n+};\n+\n+const MessagePressResponderContext: React.Co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Pass TextMessage.onPress down via context
Summary: Descendants of this component will need to call `onPress`.
Test Plan: I tested this in combination with the next diff. See attached video in the next diff
Reviewers: rohan, atul, ginsu, michal
Reviewed By: rohan, atul
Subscribers: tomek
Differential Revi... |
129,187 | 29.11.2022 23:07:11 | 18,000 | 7988ebdc2edd981bc11339f8bb78efc0f1d26a18 | [native] Normalize Android MarkdownLink behavior to match iOS
Test Plan: I tested this on iOS and Android while pressing all over a message, before and after opening the modal. See attached video in previous diff
Reviewers: rohan, atul, ginsu, michal
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message.react.js",
"new_path": "native/chat/text-message.react.js",
"diff": "@@ -50,7 +50,6 @@ type Props = {\n// MarkdownLinkContext\n+chatContext: ?ChatContextType,\n+linkModalActive: boolean,\n- +linkIsBlockingPresses: boolean,\n};\nclass T... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Normalize Android MarkdownLink behavior to match iOS
Test Plan: I tested this on iOS and Android while pressing all over a message, before and after opening the modal. See attached video in previous diff
Reviewers: rohan, atul, ginsu, michal
Reviewed By: rohan
Subscribers: tomek
Differential Revision: htt... |
129,200 | 28.11.2022 07:26:47 | 28,800 | b97763fc10820c47ddc00f0af1e98fe7ab6e8071 | [keyserver] expose APIs to start PAKE registration on client side
Summary: using Neon to surface the Rust opaque-ke library to Node.js
Test Plan: called the new APIs from a Node module and confirmed the results
Reviewers: tomek, bartek, jon
Subscribers: ashoat, atul | [
{
"change_type": "MODIFY",
"old_path": "keyserver/addons/opaque-ke-node/src/lib.rs",
"new_path": "keyserver/addons/opaque-ke-node/src/lib.rs",
"diff": "+use argon2::Argon2;\n+use digest::generic_array::GenericArray;\n+use digest::Digest;\nuse neon::prelude::*;\n+use opaque_ke::ciphersuite::CipherSui... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] expose APIs to start PAKE registration on client side
Summary: using Neon to surface the Rust opaque-ke library to Node.js
Test Plan: called the new APIs from a Node module and confirmed the results
Reviewers: tomek, bartek, jon
Reviewed By: tomek, bartek, jon
Subscribers: ashoat, atul
Differential Re... |
129,195 | 30.11.2022 18:48:35 | 18,000 | 8134e800efff4dabf5c1dc08784ee701cb077a5d | [native] Add spoiler to pressableMarkdownTypes
Summary:
Following the stack from we now add `spoiler` to the `pressableMarkdownTypes` set.
Depends on D5539
Test Plan:
Check spoilers on both Android and iOS, will attach a video below.
{F267394}
Reviewers: ashoat, atul, ginsu
Subscribers: tomek, ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/chat/text-message-markdown-context.js",
"new_path": "native/chat/text-message-markdown-context.js",
"diff": "@@ -18,7 +18,7 @@ export type TextMessageMarkdownContextType = {\nconst TextMessageMarkdownContext: React.Context<?TextMessageMarkdownContextTyp... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add spoiler to pressableMarkdownTypes
Summary:
Following the stack from @ashoat, we now add `spoiler` to the `pressableMarkdownTypes` set.
Depends on D5539
Test Plan:
Check spoilers on both Android and iOS, will attach a video below.
{F267394}
Reviewers: ashoat, atul, ginsu
Reviewed By: ashoat
Subscribe... |
129,184 | 30.11.2022 19:38:40 | 28,800 | 2b87db1e23bd6512a3fc40ea30b33c8cccda77e0 | [native] `codeVersion` -> 161 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 161 |
129,184 | 30.11.2022 19:46:44 | 28,800 | 9c15aefa67f0576e92ba82873f36c2d585548934 | [native] `codeVersion` -> 162 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 162 |
129,196 | 30.11.2022 20:31:13 | -3,600 | 08033b5cdbdff48f13f60f7c5d466770b158b88b | Use new JSI call in SQLiteDataHandler
Summary: This differential replaces separate calls for each SQLite data with new bulk JSI call.
Test Plan: Ensure in flipper SET_CLIENT_DB_STORE action payload is correct
Reviewers: tomek, atul
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/data/sqlite-data-handler.js",
"new_path": "native/data/sqlite-data-handler.js",
"diff": "@@ -88,11 +88,11 @@ function SQLiteDataHandler(): React.Node {\n(async () => {\nawait sensitiveDataHandled;\ntry {\n- const [threads, messages, drafts] = await Prom... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use new JSI call in SQLiteDataHandler
Summary: This differential replaces separate calls for each SQLite data with new bulk JSI call.
Test Plan: Ensure in flipper SET_CLIENT_DB_STORE action payload is correct
Reviewers: tomek, atul
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.de... |
129,196 | 30.11.2022 20:42:34 | -3,600 | 14fe7b7a0c2ed19b2d6a9816b4df8fd08cac3676 | Remove unecessary JSI queries
Summary: This differential removes ol unecessary JSI queries to get all drafts, threads and messages.
Test Plan: Removed queries are not used anymore in the project, so the sufficient test plan is to build the app.
Reviewers: tomek, atul, jon
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -306,34 +306,6 @@ jsi::Value CommCoreModule::getClientDBStore(jsi::Runtime &rt) {\n});\n}\n-jsi::Value CommCoreModule::getA... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove unecessary JSI queries
Summary: This differential removes ol unecessary JSI queries to get all drafts, threads and messages.
Test Plan: Removed queries are not used anymore in the project, so the sufficient test plan is to build the app.
Reviewers: tomek, atul, jon
Reviewed By: tomek
Subscribers: ashoat
Di... |
129,180 | 02.12.2022 11:49:22 | -3,600 | 5f02014903916779ad8ddcb80aeb1107ddc0b17c | [web] Deleted unused file
Summary:
We don't use this file. We use color-selector instead.
Deleted it and related css.
Test Plan:
Tested if app runs.
Tested if color picking in thread works.
Reviewers: tomek, kamil, atul
Subscribers: ashoat, atul, kamil, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -193,43 +193,6 @@ span.page-error {\ncolor: red;\n}\n-div.color-picker-container {\n- outline: none;\n- position: relative;\n-}\n-div.color-picker-button {\n- margin: 6px 3px;\n- overflow: hidden;\n- cur... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Deleted unused file
Summary:
We don't use this file. We use color-selector instead.
Deleted it and related css.
Test Plan:
Tested if app runs.
Tested if color picking in thread works.
Reviewers: tomek, kamil, atul
Reviewed By: tomek
Subscribers: ashoat, atul, kamil, tomek
Differential Revision: https://phab... |
129,184 | 06.12.2022 12:00:41 | 18,000 | 60bf0fd49af84bac751f6be3e2fbf8a2af6136f3 | [native] `codeVersion` -> 163 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 163 |
129,184 | 06.12.2022 12:02:44 | 18,000 | 18c21e7ef7d164e7e9b33ec5490ee31d9938e35f | [native] `codeVersion` -> 164 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 164 |
129,178 | 07.12.2022 14:01:20 | 18,000 | 9eff6791baaf1a05c004ff841a2250112c7d7ffc | [lib] introduce SendReactionMessageRequest type to message types
Summary: introduce `SendReactionMessageRequest` type to message types. This type will be needed in the `reactionMessageCreationResponder`
Test Plan: `flow` and this will be further tested in subsequent diffs
Reviewers: atul, rohan, tomek, ashoat
Subscribe... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -545,6 +545,13 @@ export type SendMultimediaMessageRequest =\n+mediaMessageContents: $ReadOnlyArray<MediaMessageServerDBContent>,\n};\n+export type SendReactionMessageRequest = ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] introduce SendReactionMessageRequest type to message types
Summary: introduce `SendReactionMessageRequest` type to message types. This type will be needed in the `reactionMessageCreationResponder`
Test Plan: `flow` and this will be further tested in subsequent diffs
Reviewers: atul, rohan, tomek, ashoat
Revie... |
129,184 | 06.12.2022 13:29:28 | 18,000 | 1772c35ca17cfa2291dad3d78a6c99c4631985cb | [lib] Document why `ClientDBMessageInfo` uses strings everywhere
Summary: Context: Should close
Test Plan: NA
Reviewers: tomek, marcin, varun, O6 Docs, ashoat
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -399,6 +399,16 @@ export type RemoveAllMessagesOperation = {\n+type: 'remove_all',\n};\n+// We were initially using `number`s` for `thread`, `type`, `future_type`, etc.\n+// How... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Document why `ClientDBMessageInfo` uses strings everywhere
Summary: Context: Should close https://linear.app/comm/issue/ENG-237/document-why-clientdbmessageinfo-uses-strings-everywhere
Test Plan: NA
Reviewers: tomek, marcin, varun, O6 Docs, ashoat
Reviewed By: O6 Docs, ashoat
Subscribers: ashoat
Differentia... |
129,188 | 02.12.2022 12:50:52 | -3,600 | c389d36abeafe6c2b1ae2ed86646afa3468ea764 | [keyserver] add viewer acknowledgment fetcher
Summary: Function fetches viewer policies with `confirmed` value
Test Plan: Check if returns proper value for one/multiple policies
Reviewers: tomek, atul
Subscribers: ashoat | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "keyserver/src/fetchers/policy-acknowledgment-fetchers.js",
"diff": "+// @flow\n+\n+import type { PolicyType } from 'lib/facts/policies.js';\n+import { type UserPolicyConfirmationType } from 'lib/types/policy-types.js';\n+\n+import { dbQuery, SQL... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] add viewer acknowledgment fetcher
Summary: Function fetches viewer policies with `confirmed` value
Test Plan: Check if returns proper value for one/multiple policies
Reviewers: tomek, atul
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D5822 |
129,184 | 13.12.2022 11:21:14 | 18,000 | eae425b1d1959220fbe76be8fb5cd44225e19bdf | [landing] Update SIWE message to match whitepaper
Summary:
Context:
{F283435}
Test Plan:
Before:{F283429}
After:{F283430}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -52,7 +52,10 @@ function createSiweMessage(address, statement) {\n}\nasync function signInWithEthereum(address, signer) {\n- const message = createSiweMessage(address, 'Sign in to Comm wi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update SIWE message to match whitepaper
Summary:
Context: https://linear.app/comm/issue/ENG-2443/update-createsiwemessage-message-to-match-whitepaper
{F283435}
Test Plan:
Before:{F283429}
After:{F283430}
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D5862 |
129,184 | 15.12.2022 10:47:48 | 18,000 | fb8059109e9eef474ffc7b4f781dd5a0abc74fb5 | [native] `codeVersion` -> 165 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 165 |
129,184 | 15.12.2022 10:50:34 | 18,000 | cc7d14a919e41f3bb69d465d3bccea8daafc07bc | [native] `codeVersion` -> 166 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -407,8 +407,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 166 |
129,196 | 02.12.2022 10:56:38 | -3,600 | e6f0993ea3d654823c7655154f392ade6518b3be | Remove CommRelease.entitlements reference from project.pbxproj
Summary: This differential removes reference to non-existing CommRelease.entitlements file from project.pbxproj.
Test Plan: Build debug and release version of the app after deleting CommRelease through XCode GUI (initially it should be visibile highlited in... | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "B7906F6C27209091009BBBF5 /* Thread.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = Thread.h; sourceTree =... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove CommRelease.entitlements reference from project.pbxproj
Summary: This differential removes reference to non-existing CommRelease.entitlements file from project.pbxproj.
Test Plan: Build debug and release version of the app after deleting CommRelease through XCode GUI (initially it should be visibile highlited ... |
129,201 | 19.12.2022 17:52:50 | -3,600 | 4ddb4b60da6d1055d1ce0d658117b167c430c7c6 | [docs] Removing deprecated gRPC codegen from the documentation
Summary:
This diff removes the deprecated gRPC codegen from the documentation.
Linear task: [[ | ]]
Test Plan: No tests, just docs.
Reviewers: jon, tomek, ashoat
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "docs/nix_dev_env.md",
"new_path": "docs/nix_dev_env.md",
"diff": "@@ -100,7 +100,6 @@ Run `nix develop` to create a dev environment. Nix will handle the installation\n- [Inspect database with TablePlus](./nix_shared_workflows.md#inspect-database-with-tableplus... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] Removing deprecated gRPC codegen from the documentation
Summary:
This diff removes the deprecated gRPC codegen from the documentation.
Linear task: [[ https://linear.app/comm/issue/ENG-2394/delete-codegen-for-grpc-from-docs | ENG-2394 ]]
Test Plan: No tests, just docs.
Reviewers: jon, tomek, ashoat
Reviewed... |
129,184 | 19.12.2022 11:32:48 | 28,800 | 0dfb8181dfc6186d6f9b5544f84e3071c6a44b89 | [keyserver] Fix `siwe_nonces` table creation
Summary:
Very stupid issue I noticed when creating a new database. The stray comma at the end causes the following:
{F293066}
Test Plan:
1. Create a new DB
2. Run keyserver
3. Ensure that the script runs successfully.
{F293079}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/database/setup-db.js",
"new_path": "keyserver/src/database/setup-db.js",
"diff": "@@ -243,7 +243,7 @@ async function createTables() {\nCREATE TABLE siwe_nonces (\nnonce char(17) NOT NULL,\n- creation_time bigint(20) NOT NULL,\n+ creation_time big... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Fix `siwe_nonces` table creation
Summary:
Very stupid issue I noticed when creating a new database. The stray comma at the end causes the following:
{F293066}
Test Plan:
1. Create a new DB
2. Run keyserver
3. Ensure that the script runs successfully.
{F293079}
Reviewers: ashoat, tomek
Reviewed By: ash... |
129,187 | 08.11.2022 15:42:06 | 18,000 | 947d6dacdec93eab969833bd5c92a62c4495d4ca | [native] [8/40] RN 0.70: Ruby 2.7.5
Summary:
This came from [React Native Upgrade Helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.70.6)
Depends on D5901
Test Plan: Tested along with whole stack: [test plan](https://www.notion.so/commapp/Test-plan-for-React-Native-0-70-upgrade-718fa7e0f... | [
{
"change_type": "MODIFY",
"old_path": "native/Gemfile",
"new_path": "native/Gemfile",
"diff": "source 'https://rubygems.org'\n# You may use http://rbenv.org/ or https://rvm.io/ to install and use this version\n-ruby '~> 2.7.4'\n+ruby '~> 2.7.5'\ngem 'cocoapods', '~> 1.11', '>= 1.11.3'\n"
},
{
... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [8/40] RN 0.70: Ruby 2.7.5
Summary:
This came from [React Native Upgrade Helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.70.6)
Depends on D5901
Test Plan: Tested along with whole stack: [test plan](https://www.notion.so/commapp/Test-plan-for-React-Native-0-70-upgrade-718fa7... |
129,187 | 03.11.2022 22:36:09 | 14,400 | d28a0b1e4175a94601d4de38463ef333638c4cdd | [native] [9/40] RN 0.70: Update eslint to 7.32.0
Summary:
[React Native Upgrade Helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.70.6) suggested doing this.
Depends on D5902
Test Plan: Tested along with whole stack: [test plan](https://www.notion.so/commapp/Test-plan-for-React-Native-0-... | [
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"babel-eslint\": \"^10.1.0\",\n\"clang-format\": \"^1.8.0\",\n\"core-js\": \"^3.6.5\",\n- \"eslint\": \"^7.22.0\",\n+ \"eslint\": \"^7.32.0\",\n\"eslint-config-prettier\": \"^8.1.0\",\n\"eslint-plugin-flowty... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [9/40] RN 0.70: Update eslint to 7.32.0
Summary:
[React Native Upgrade Helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.70.6) suggested doing this.
Depends on D5902
Test Plan: Tested along with whole stack: [test plan](https://www.notion.so/commapp/Test-plan-for-React-Native... |
129,187 | 08.11.2022 15:40:45 | 18,000 | 7df23036ce3357aab898bcb293113b270ad2963c | [native] [12/40] RN 0.70: Update to
Summary:
Upgrade necessary due to [this issue](https://github.com/react-native-video/react-native-video/issues/2752) that occurs on React Native 0.69.
Depends on D5905
Test Plan: Tested along with whole stack: [test plan](https://www.notion.so/commapp/Test-plan-for-React-Native-0-70-... | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -315,9 +315,9 @@ PODS:\n- React-Core\n- react-native-safe-area-context (3.1.9):\n- React-Core\n- - react-native-video/Video (5.1.1):\n+ - react-native-video/Video (5.2.1):\n- React-Co... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [12/40] RN 0.70: Update to react-native-video@5.2.1
Summary:
Upgrade necessary due to [this issue](https://github.com/react-native-video/react-native-video/issues/2752) that occurs on React Native 0.69.
Depends on D5905
Test Plan: Tested along with whole stack: [test plan](https://www.notion.so/commapp/Test... |
129,187 | 20.12.2022 09:46:18 | 25,200 | 35e34f5439f3e26a1ba19742dbe15b3e177d46d4 | [native] Unify margin for LoggedOutModal
Summary: No point redefining this in a lot of places.
Test Plan: Visual inspection looked good
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -592,8 +592,6 @@ const styles = StyleSheet.create({\nbackgroundColor: '#FFFFFFAA',\nborderRadius: 6,\nmarginBottom: 10,\n- marginLeft: 40,\n- marginR... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Unify margin for LoggedOutModal
Summary: No point redefining this in a lot of places.
Test Plan: Visual inspection looked good
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D5954 |
129,187 | 20.12.2022 09:49:37 | 25,200 | 2ca00942d135bce285089d6884b91032da9a51a4 | [native] Add "or" horizontal rule between SIWE and existing login
Summary:
Designs:
Design task:
Eng task:
Test Plan: Visual inspection: {F295533}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -5,7 +5,6 @@ import _isEqual from 'lodash/fp/isEqual';\nimport * as React from 'react';\nimport {\nView,\n- StyleSheet,\nText,\nTouchableOpacity,\nIm... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add "or" horizontal rule between SIWE and existing login
Summary:
Designs: https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=3531%3A51068&t=jPxFWIKYapZrvgr4-0
Design task: https://linear.app/comm/issue/DES-7/designs-for-siwe
Eng task: https://linear.app/comm/issue/ENG-1815/ux-for-signing-a-... |
129,187 | 20.12.2022 10:36:09 | 25,200 | 0c53bd135ea41e01fd746deda00b051fdb44aba9 | [native] Style SIWE to match designs
Summary:
Designs:
Design task:
Eng task:
Test Plan: Visual inspection: {F295535}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -22,6 +22,7 @@ import { logInActionSources } from 'lib/types/account-types';\nimport type { Dispatch } from 'lib/types/redux-types';\nimport { fetchN... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Style SIWE to match designs
Summary:
Designs: https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=3531%3A51068&t=jPxFWIKYapZrvgr4-0
Design task: https://linear.app/comm/issue/DES-7/designs-for-siwe
Eng task: https://linear.app/comm/issue/ENG-1815/ux-for-signing-a-message-on-native
Test Plan:... |
129,184 | 21.12.2022 09:58:04 | 28,800 | 27305763347543a0fd430f91308f14bcc02a21b7 | [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED]` to `redux-types`
Summary: Should've added these when I introduced `lib/actions/siwe-actions.js:getSIWENonceActionTypes`. Ran into a flow issue when I was trying to use `createLoadingStatusSelector` which flagged that something was missing.
Test Plan: Able to use `crea... | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -877,6 +877,22 @@ export type BaseAction =\n+error: true,\n+payload: Error,\n+loadingInfo: LoadingInfo,\n+ }\n+ | {\n+ +type: 'GET_SIWE_NONCE_STARTED',\n+ +payload?: void,\n+ +loadi... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `GET_SIWE_NONCE_[STARTED/SUCCESS/FAILED]` to `redux-types`
Summary: Should've added these when I introduced `lib/actions/siwe-actions.js:getSIWENonceActionTypes`. Ran into a flow issue when I was trying to use `createLoadingStatusSelector` which flagged that something was missing.
Test Plan: Able to use `cr... |
129,200 | 15.12.2022 14:34:27 | 18,000 | 5b7551fb565d0037d820ff49930747c897e5ad88 | [keyserver] remove opaque-ke-node
Summary: We're no longer using this addon so we can remove it from the repo
Test Plan: Built keyserver successfully, checked that no references to this package remained
Reviewers: ashoat
Subscribers: ashoat, tomek | [
{
"change_type": "DELETE",
"old_path": "keyserver/addons/opaque-ke-node/.gitignore",
"new_path": null,
"diff": "-target\n-index.node\n-**/node_modules\n-**/.DS_Store\n-npm-debug.log*\n"
},
{
"change_type": "DELETE",
"old_path": "keyserver/addons/opaque-ke-node/Cargo.lock",
"new_path"... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] remove opaque-ke-node
Summary: We're no longer using this addon so we can remove it from the repo
Test Plan: Built keyserver successfully, checked that no references to this package remained
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, tomek
Differential Revision: https://phab.comm.dev/D... |
129,178 | 21.12.2022 19:25:15 | 18,000 | b8ff12417b3e151b8574a88427a4b70d261d3e62 | [lib] set min code version for message liking
Summary: set min code version for message liking to 167. Will rebase and adjust if a new build gets put out between now and landing this diff
Test Plan: N/A
Reviewers: atul, tomek
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/reaction-message-spec.js",
"new_path": "lib/shared/messages/reaction-message-spec.js",
"diff": "@@ -138,8 +138,7 @@ export const reactionMessageSpec: MessageSpec<\nrawMessageInfo: RawReactionMessageInfo,\nplatformDetails: ?PlatformDetails,\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] set min code version for message liking
Summary: set min code version for message liking to 167. Will rebase and adjust if a new build gets put out between now and landing this diff
Test Plan: N/A
Reviewers: atul, tomek
Reviewed By: atul
Subscribers: ashoat, tomek, atul
Differential Revision: https://phab.c... |
129,187 | 21.12.2022 21:50:57 | 25,200 | 26f04572c8ec7fdfbd79c556dcf7c6615d9fc472 | [native] Lowercase "in" in "Sign in with Ethereum" button
Summary: Context [here](https://phab.comm.dev/D5956#inline-40373); also reference the [official SIWE assets](https://github.com/spruceid/siwe/tree/main/assets).
Test Plan: I didn't test this at all actually
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -469,7 +469,7 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\n<EthereumLogo />\n</View>\n<Text style={[styles.buttonText, styles... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Lowercase "in" in "Sign in with Ethereum" button
Summary: Context [here](https://phab.comm.dev/D5956#inline-40373); also reference the [official SIWE assets](https://github.com/spruceid/siwe/tree/main/assets).
Test Plan: I didn't test this at all actually
Reviewers: atul
Reviewed By: atul
Subscribers: tom... |
129,187 | 21.12.2022 20:59:09 | 25,200 | bd7f7f93fda07cc30b802f47171474c088b40e40 | [keyserver] Fix JSONStream types
Summary: No need to talk explicitly about `Promise`s here... ultimately it's a `mixed` type.
Test Plan: Flow
Reviewers: ginsu, michal, atul, tomek | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/website-responders.js",
"new_path": "keyserver/src/responders/website-responders.js",
"diff": "@@ -24,7 +24,6 @@ import { defaultNumberPerThread } from 'lib/types/message-types';\nimport { defaultEnabledReports } from 'lib/types/report... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Fix JSONStream types
Summary: No need to talk explicitly about `Promise`s here... ultimately it's a `mixed` type.
Test Plan: Flow
Reviewers: ginsu, michal, atul, tomek
Reviewed By: ginsu, michal, tomek
Differential Revision: https://phab.comm.dev/D5982 |
129,187 | 22.12.2022 16:41:06 | 25,200 | 0199139921f83504c3d287917f1dde75b23284c9 | [landing] Fix up CSS for RainbowKit / WalletConnect
Summary: Hacky, but it works.
Test Plan:
| before | after |
| {F302003} | {F302004} |
| {F302005} | {F302006} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.css",
"new_path": "landing/siwe.css",
"diff": "@@ -24,9 +24,21 @@ body {\n}\n}\n+body > div > :global(div.iekbcc0) {\n+ word-break: initial;\n+}\nbody > div > :global(div.iekbcc0) > div {\nbottom: initial !important;\n}\nbody > div > :global(div.i... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix up CSS for RainbowKit / WalletConnect
Summary: Hacky, but it works.
Test Plan:
| before | after |
| {F302003} | {F302004} |
| {F302005} | {F302006} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6006 |
129,187 | 22.12.2022 16:56:47 | 25,200 | 98f40f9ff2244507f74b66272049b8eb9817f55c | [native] Wrap SIWEPanel WebView in BottomSheet
Summary: This is gonna improve the UX a lot. See video in Test Plan (has a few later diffs as well).
Test Plan: {F302078}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/siwe-panel.react.js",
"new_path": "native/account/siwe-panel.react.js",
"diff": "// @flow\n+import BottomSheet from '@gorhom/bottom-sheet';\nimport * as React from 'react';\n-import { ActivityIndicator, Text } from 'react-native';\n+import { Act... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Wrap SIWEPanel WebView in BottomSheet
Summary: This is gonna improve the UX a lot. See video in Test Plan (has a few later diffs as well).
Test Plan: {F302078}
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6007 |
129,187 | 22.12.2022 17:23:04 | 25,200 | 325524c5f4fe28cc53cf269f0439c54b51cb3b58 | [native] Let the user dismiss the SIWEPanel with a gesture
Summary: We need to make sure we trigger `goBackToPrompt` when the user dismisses the `BottomSheet`.
Test Plan: Dismiss the `BottomSheet` and make sure `LoggedOutModal` goes back to the prompt
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -556,7 +556,7 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\nlet siwePanel;\nif (this.state.mode === 'siwe') {\n- siwePanel = <... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Let the user dismiss the SIWEPanel with a gesture
Summary: We need to make sure we trigger `goBackToPrompt` when the user dismisses the `BottomSheet`.
Test Plan: Dismiss the `BottomSheet` and make sure `LoggedOutModal` goes back to the prompt
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Different... |
129,187 | 22.12.2022 17:47:18 | 25,200 | e385ad79f9f3c288286c5c7365bae7ffa660b142 | [landing] Disable RainbowKit slide-in animation
Summary: Our `BottomSheet` is already sliding in; we don't need to do it twice.
Test Plan: Load in desktop browser, Mobile Safari on Simulator, and within `WebView` in Comm app to verify slide-in effect is gone
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.css",
"new_path": "landing/siwe.css",
"diff": "@@ -27,6 +27,10 @@ body {\nbody > div > :global(div.iekbcc0) {\nword-break: initial;\n}\n+[data-rk] :global(._9pm4ki5) {\n+ animation: initial !important;\n+ -webkit-animation: initial !important;\n+}... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Disable RainbowKit slide-in animation
Summary: Our `BottomSheet` is already sliding in; we don't need to do it twice.
Test Plan: Load http://localhost:3000/commlanding/siwe in desktop browser, Mobile Safari on Simulator, and within `WebView` in Comm app to verify slide-in effect is gone
Reviewers: atul
Re... |
129,187 | 23.12.2022 07:38:06 | 25,200 | e7344f3c3969ce2bf8ba2928e73c0de4caedbbcc | [native][landing] Type SIWEWebViewMessage
Summary: Also added a `type` field in preparation for other types of messages which will need to be sent in future diffs.
Test Plan: Flow
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -21,6 +21,8 @@ import {\n} from 'wagmi';\nimport { publicProvider } from 'wagmi/providers/public';\n+import type { SIWEWebViewMessage } from 'lib/types/siwe-types';\n+\nimport { SIWENonce... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][landing] Type SIWEWebViewMessage
Summary: Also added a `type` field in preparation for other types of messages which will need to be sent in future diffs.
Test Plan: Flow
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6011 |
129,187 | 23.12.2022 08:00:27 | 25,200 | 3913531270aacb806dbf23398b28749e8ef5154e | [native][landing] Close SIWEPanel when close button in WebView pressed
Summary: We need to thread this event over to the `native` side.
Test Plan: {F302752}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -5,6 +5,7 @@ import {\ngetDefaultWallets,\nRainbowKitProvider,\ndarkTheme,\n+ useModalState,\n} from '@rainbow-me/rainbowkit';\nimport invariant from 'invariant';\nimport _merge from 'lod... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][landing] Close SIWEPanel when close button in WebView pressed
Summary: We need to thread this event over to the `native` side.
Test Plan: {F302752}
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6012 |
129,184 | 23.12.2022 13:21:11 | 28,800 | bc2de1f864a53d31e7ce07dffddf79912c63f9dd | [native] `codeVersion` -> 167 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 167 |
129,184 | 23.12.2022 15:51:58 | 28,800 | 95d07a7696ddec752a07d8a40d5dedb684e87bc9 | [native] `codeVersion` -> 168 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 168 |
129,187 | 23.12.2022 14:34:44 | 25,200 | 9234edae014b25a9e538d1a24cdad09470c5cbba | [native][landing] Resize BottomSheet when WalletConnect opened
Summary: WalletConnect needs more space. See video.
Test Plan: {F302863}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "landing/siwe.react.js",
"new_path": "landing/siwe.react.js",
"diff": "@@ -108,6 +108,42 @@ function SIWE(): React.Node {\nprevConnectModalOpen.current = connectModalOpen;\n}, [connectModalOpen]);\n+ const newModalAppeared = React.useCallback(mutationList => {\... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][landing] Resize BottomSheet when WalletConnect opened
Summary: WalletConnect needs more space. See video.
Test Plan: {F302863}
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6017 |
129,187 | 23.12.2022 15:56:49 | 25,200 | fc8274f8598152541ab2b9ba5ef33067ee240838 | [landing] Fix SIWE behavior when no wallet installed on Android
Summary: Pulled this from [here](https://github.com/rainbow-me/rainbowkit/issues/892). Our patch is a little different because we're using an old version of Rainbowkit.
Test Plan: Confirm links work when no wallet installed on Android emulator
Reviewers: a... | [
{
"change_type": "MODIFY",
"old_path": "patches/@rainbow-me+rainbowkit+0.5.3.patch",
"new_path": "patches/@rainbow-me+rainbowkit+0.5.3.patch",
"diff": "@@ -11,7 +11,7 @@ index 275c804..ca20931 100644\n+ useModalState,\n};\ndiff --git a/node_modules/@rainbow-me/rainbowkit/dist/index.js b/node_modules... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix SIWE behavior when no wallet installed on Android
Summary: Pulled this from [here](https://github.com/rainbow-me/rainbowkit/issues/892). Our patch is a little different because we're using an old version of Rainbowkit.
Test Plan: Confirm links work when no wallet installed on Android emulator
Reviewers... |
129,187 | 23.12.2022 16:30:01 | 25,200 | 4930cf509f385847cb12d6f635e756eb732ee323 | [native] Move Comm wordmark when SIWEPanel opened
Summary: Should be the last visual diff on SIWE!!
Test Plan:
| iOS | Android | iOS with WalletConnect modal open |
| {F303015} | {F303016} | {F303017} |
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -328,12 +328,14 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\nconst promptButtonsSize = Platform.OS === 'ios' ? 40 : 61;\ncons... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move Comm wordmark when SIWEPanel opened
Summary: Should be the last visual diff on SIWE!!
Test Plan:
| iOS | Android | iOS with WalletConnect modal open |
| {F303015} | {F303016} | {F303017} |
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6020 |
129,184 | 26.12.2022 17:30:44 | 28,800 | 69d5979cfe057a0996ba62705f3d7b547652caad | [keyserver] Introduce basic scaffolding for `siwe_auth` endpoint
Summary: Scaffolding to hit the `siwe_auth` endpoint from the `native` client. There's nothing interesting here.
Test Plan: Able to hit endpoint from `native` client.
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/endpoints.js",
"new_path": "keyserver/src/endpoints.js",
"diff": "@@ -52,6 +52,7 @@ import {\naccountDeletionResponder,\naccountCreationResponder,\nlogInResponder,\n+ siweAuthResponder,\noldPasswordUpdateResponder,\nupdateUserSettingsResponder,\n... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Introduce basic scaffolding for `siwe_auth` endpoint
Summary: Scaffolding to hit the `siwe_auth` endpoint from the `native` client. There's nothing interesting here.
Test Plan: Able to hit endpoint from `native` client.
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.co... |
129,184 | 27.12.2022 00:45:51 | 28,800 | b443a8224f540913f4ecec68ca33e21c8116ea7e | [lib] Introduce `SIWEMessage` type
Summary:
Effectively copied from the TypeScript types:
{F304013}
Will be helpful to type return value of `new SiweMessage(message)` in `siweAuthResponder` as `SIWEMessage`.
Depends on D6029
Test Plan: Careful reading
Reviewers: tomek, ashoat | [
{
"change_type": "MODIFY",
"old_path": "lib/types/siwe-types.js",
"new_path": "lib/types/siwe-types.js",
"diff": "@@ -43,3 +43,66 @@ export type SIWEWebViewMessage =\n+type: 'walletconnect_modal_update',\n+state: 'open' | 'closed',\n};\n+\n+export type SIWEMessage = {\n+ // RFC 4501 dns authority th... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `SIWEMessage` type
Summary:
Effectively copied from the TypeScript types:
{F304013}
Will be helpful to type return value of `new SiweMessage(message)` in `siweAuthResponder` as `SIWEMessage`.
---
Depends on D6029
Test Plan: Careful reading
Reviewers: tomek, ashoat
Reviewed By: ashoat
Differenti... |
129,184 | 27.12.2022 02:39:58 | 28,800 | af300d7ff131a6a46c9be0cbda8eb53605070e67 | [native] `codeVersion` -> 169 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 169 |
129,184 | 27.12.2022 02:42:49 | 28,800 | e81666dc452beae1137fa596608946d3d179ee97 | [native] `codeVersion` -> 170 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 170 |
129,187 | 25.12.2022 19:37:52 | 25,200 | 2bdf04e88ab40d26ab854fa37e15331a4c552a68 | [native] Set SIWE WebView background color
Summary:
This makes it so if the user overscrolls, they don't see white.
Depends on D6034
Test Plan: Make sure overscroll isn't white
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "MODIFY",
"old_path": "native/account/siwe-panel.react.js",
"new_path": "native/account/siwe-panel.react.js",
"diff": "@@ -148,7 +148,7 @@ function SIWEPanel(props: Props): React.Node {\nsetLoading(false);\n}, []);\n- const handleStyle = React.useMemo(\n+ const backgroundStyle = Rea... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Set SIWE WebView background color
Summary:
This makes it so if the user overscrolls, they don't see white.
Depends on D6034
Test Plan: Make sure overscroll isn't white
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6035 |
129,187 | 27.12.2022 18:49:42 | 25,200 | a145b691bcbf9df3d91c0c2ea8b54934c50f712a | [landing] Style SIWE message signing step
Summary: This addresses [ENG-2540](https://linear.app/comm/issue/ENG-2540/style-and-add-copy-for-second-step-of-siwe-on-native).
Test Plan: {F306794}
Reviewers: atul
Subscribers: tomek | [
{
"change_type": "DELETE",
"old_path": "keyserver/images/ethereum_icon.svg",
"new_path": null,
"diff": "-<!-- sourced from https://login.xyz/ -->\n-<svg class=\"w-6 mr-4\" width=\"35\" height=\"58\" xmlns=\"http://www.w3.org/2000/svg\" viewBox=\"0 0 35 58\" fill=\"none\">\n-<path d=\"M17.4954 0L17.1... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Style SIWE message signing step
Summary: This addresses [ENG-2540](https://linear.app/comm/issue/ENG-2540/style-and-add-copy-for-second-step-of-siwe-on-native).
Test Plan: {F306794}
Reviewers: atul
Reviewed By: atul
Subscribers: tomek
Differential Revision: https://phab.comm.dev/D6058 |
129,188 | 28.12.2022 15:09:02 | -3,600 | 4cc66894c62676640323452db1b48185b731b727 | [native] display alert if register via SIWE fail
Summary:
Context in [ENG-2543](https://linear.app/comm/issue/ENG-2543/show-loading-icon-while-comm-account-being-registered-via-siwe)
{F307601}
Test Plan: Make sure keyserver will throw any error, register via SIWE, check if alert is visible and after click will navigate... | [
{
"change_type": "MODIFY",
"old_path": "native/account/siwe-panel.react.js",
"new_path": "native/account/siwe-panel.react.js",
"diff": "import BottomSheet from '@gorhom/bottom-sheet';\nimport * as React from 'react';\n-import { ActivityIndicator, Text, View } from 'react-native';\n+import { Activity... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] display alert if register via SIWE fail
Summary:
Context in [ENG-2543](https://linear.app/comm/issue/ENG-2543/show-loading-icon-while-comm-account-being-registered-via-siwe)
{F307601}
Test Plan: Make sure keyserver will throw any error, register via SIWE, check if alert is visible and after click will navig... |
129,184 | 28.12.2022 15:19:14 | 28,800 | c4844d9fde08368b6b1ae84ffa6ee48b7979e1e3 | [keyserver] Remove payloads from `siweAuthResponder` `ServerError`s
Summary:
Context:
Basically looks like these `status` payloads are superfluous and aren't used anywhere... so cutting them.
Depends on D6060
Test Plan: Didn't really test... pretty confident this is a benign change.
Reviewers: tomek, ashoat | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/user-responders.js",
"new_path": "keyserver/src/responders/user-responders.js",
"diff": "@@ -347,15 +347,15 @@ async function siweAuthResponder(\n} catch (error) {\nif (error === ErrorTypes.EXPIRED_MESSAGE) {\n// Thrown when the `expir... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Remove payloads from `siweAuthResponder` `ServerError`s
Summary:
Context:
https://phab.comm.dev/D6033#181748
https://phab.comm.dev/D6033#181828
Basically looks like these `status` payloads are superfluous and aren't used anywhere... so cutting them.
---
Depends on D6060
Test Plan: Didn't really test...... |
129,182 | 29.12.2022 18:09:05 | -3,600 | dea7c1849ff09a734defe8b65b97e3e1573cf2f4 | [native] Add community drawer navigator
Summary:
Linear issue:
Add a navigator for community drawer.
Test Plan: Tested with subsequent diffs.
Reviewers: tomek, atul, ginsu, kamil, bartek, ashoat
Subscribers: ashoat | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/navigation/community-drawer-navigator.react.js",
"diff": "+// @flow\n+\n+import { createDrawerNavigator } from '@react-navigation/drawer';\n+import * as React from 'react';\n+import { Dimensions, View } from 'react-native';\n+\n+import { ... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add community drawer navigator
Summary:
Linear issue: https://linear.app/comm/issue/ENG-1881/community-navigation-drawer-on-native
Add a navigator for community drawer.
Test Plan: Tested with subsequent diffs.
Reviewers: tomek, atul, ginsu, kamil, bartek, ashoat
Reviewed By: tomek, ashoat
Subscribers: ash... |
129,184 | 29.12.2022 13:45:48 | 28,800 | 55ce736555876066bfa042024e6179245f0a3450 | [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`
Summary:
We construct `LogInResult` using the request payload (`SIWEAuthServerCall`) and the respond (`LogInResponse`). Code was effectively cut/paste from `lib/actions/user-actions:logIn`.
Depends on D6077
Test Plan: Will be tested implicit... | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/siwe-actions.js",
"new_path": "lib/actions/siwe-actions.js",
"diff": "// @flow\nimport threadWatcher from '../shared/thread-watcher.js';\n-import type { LogInResponse } from '../types/account-types.js';\n+import {\n+ type LogInResult,\n+ logInActio... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Modify `siweAuth(...)` return type from `LogInResponse` to `LogInResult`
Summary:
We construct `LogInResult` using the request payload (`SIWEAuthServerCall`) and the respond (`LogInResponse`). Code was effectively cut/paste from `lib/actions/user-actions:logIn`.
---
Depends on D6077
Test Plan: Will be tested ... |
129,196 | 29.12.2022 13:32:35 | -3,600 | 5d99214912bcbf7ce5a08e46304e06ef1d6ca4f6 | Soften requirement for password in account deletion request
Summary: This differential softens requirement as to whether user should provide a password in account deletion request
Test Plan: Launch the app.
Reviewers: tomek, atul
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/user-responders.js",
"new_path": "keyserver/src/responders/user-responders.js",
"diff": "@@ -157,7 +157,7 @@ async function logOutResponder(viewer: Viewer): Promise<LogOutResponse> {\n}\nconst deleteAccountRequestInputValidator = tShap... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Soften requirement for password in account deletion request
Summary: This differential softens requirement as to whether user should provide a password in account deletion request
Test Plan: Launch the app.
Reviewers: tomek, atul
Reviewed By: tomek
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/... |
129,196 | 29.12.2022 15:43:36 | -3,600 | dc9bcf0e32b1b63b2eee7bc2c3b07bd63b9aa6ba | Soften requirements for password when deleting thread
Summary: This differential makes account password an optional parameter of thread deletion request
Test Plan: Build and lanynch the app
Reviewers: tomek, atul
Subscribers: ashoat, tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/responders/thread-responders.js",
"new_path": "keyserver/src/responders/thread-responders.js",
"diff": "@@ -43,7 +43,7 @@ import {\nconst threadDeletionRequestInputValidator = tShape({\nthreadID: t.String,\n- accountPassword: tPassword,\n+ accoun... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Soften requirements for password when deleting thread
Summary: This differential makes account password an optional parameter of thread deletion request
Test Plan: Build and lanynch the app
Reviewers: tomek, atul
Reviewed By: tomek
Subscribers: ashoat, tomek, atul
Differential Revision: https://phab.comm.dev/D610... |
129,191 | 28.12.2022 21:34:42 | -3,600 | 273bd39da8a1f53b4b586fe6eff5fcc6e9841cb9 | [web] Delete comments disabling eslint checks
Summary:
These comments were introduced during development of the feature and should've been deleted.
Depends on D5852
Test Plan: Flow / eslint
Reviewers: kamil, inka, ginsu, przemek, ashoat
Subscribers: ashoat, atul | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip-provider.js",
"new_path": "web/chat/tooltip-provider.js",
"diff": "@@ -40,17 +40,12 @@ type Props = {\n};\nfunction TooltipProvider(props: Props): React.Node {\nconst { children } = props;\n- // eslint-disable-next-line no-unused-vars\nconst t... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Delete comments disabling eslint checks
Summary:
These comments were introduced during development of the feature and should've been deleted.
Depends on D5852
Test Plan: Flow / eslint
Reviewers: kamil, inka, ginsu, przemek, ashoat
Reviewed By: kamil, ashoat
Subscribers: ashoat, atul
Differential Revision: ... |
129,184 | 30.12.2022 14:09:14 | 28,800 | 5cb48d5ae04306dd569c1f02ffd10f879d268df7 | [native] `codeVersion` -> 171 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 171 |
129,184 | 30.12.2022 14:13:16 | 28,800 | 944eae83488700ca59b8790780a32c632bab2e7e | [native] `codeVersion` -> 172 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -471,8 +471,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- version... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 172 |
129,184 | 30.12.2022 18:00:48 | 28,800 | 423fcb8e9658b8ce0665e78d074ae87b7770b9c7 | [lib] Introduce `isValidPrimaryIdentityPublicKey`
Summary:
Going to use this in `landing-handler` to validate `siwe-primary-identity-public-key` header value before "injecting" into page.
Depends on D6124
Test Plan: unit tests
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/siwe-utils.js",
"new_path": "lib/utils/siwe-utils.js",
"diff": "@@ -13,6 +13,11 @@ function isValidEthereumAddress(candidate: string): boolean {\nreturn ethereumAddressRegex.test(candidate);\n}\n+const primaryIdentityPublicKeyRegex: RegExp = /^[a-zA-... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `isValidPrimaryIdentityPublicKey`
Summary:
Going to use this in `landing-handler` to validate `siwe-primary-identity-public-key` header value before "injecting" into page.
---
Depends on D6124
Test Plan: unit tests
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.c... |
129,184 | 03.01.2023 13:34:48 | 28,800 | 3142750b0b853ea49771b2c3fd5dbae99553fcb1 | [lib] Introduce `getSIWEStatementForPublicKey(...)`
Summary:
Given a public key, `getSIWEStatementForPublicKey(...)` generates a statement for SIWE message that conforms to what is described in the whitepaper:
Depends on D6128
Test Plan: included a unit test
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/siwe-utils.js",
"new_path": "lib/utils/siwe-utils.js",
"diff": "// @flow\n+import invariant from 'invariant';\n+\nimport type { SIWEMessage } from '../types/siwe-types.js';\nimport { isDev } from './dev-utils.js';\n@@ -37,10 +39,19 @@ function isVali... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `getSIWEStatementForPublicKey(...)`
Summary:
Given a public key, `getSIWEStatementForPublicKey(...)` generates a statement for SIWE message that conforms to what is described in the whitepaper:
https://blob.sh/a3d138.png
---
Depends on D6128
Test Plan: included a unit test
Reviewers: ashoat, tome... |
129,184 | 03.01.2023 13:44:05 | 28,800 | 7e3a7434220c96f289fb5ff84d1e92383065a08f | [lib] Introduce `isValidSIWEStatementWithPublicKey(...)`
Summary:
Introduce `isValidSIWEStatementWithPublicKey(...)` to check if SIWE statement is valid statement **that includes the `Device IdPubKey`** as described in the whitepaper:
Depends on D6129
Test Plan: included a unit test (will include more later)
Reviewers:... | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/siwe-utils.js",
"new_path": "lib/utils/siwe-utils.js",
"diff": "@@ -47,6 +47,11 @@ function getSIWEStatementForPublicKey(publicKey: string): string {\nreturn `Device IdPubKey: ${publicKey} ${siweStatement}`;\n}\n+const siweStatementWithPublicKeyRegex... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `isValidSIWEStatementWithPublicKey(...)`
Summary:
Introduce `isValidSIWEStatementWithPublicKey(...)` to check if SIWE statement is valid statement **that includes the `Device IdPubKey`** as described in the whitepaper: https://blob.sh/a3d138.png
---
Depends on D6129
Test Plan: included a unit test (... |
129,187 | 04.01.2023 19:14:09 | 25,200 | 7c75cd42f2f3cdf2de57bc0c7cede4806f8e0724 | [lib] Simplify InlineSidebarText and deprecate sendersText
Summary: We're not using `sendersText` anymore, so we should get rid of that code.
Test Plan: Flow
Reviewers: ginsu
Subscribers: tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "lib/hooks/inline-sidebar-text.react.js",
"new_path": "lib/hooks/inline-sidebar-text.react.js",
"diff": "// @flow\n-import * as React from 'react';\n-\n-import { relativeMemberInfoSelectorForMembersOfThread } from '../selectors/user-selectors';\n-import { strin... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Simplify InlineSidebarText and deprecate sendersText
Summary: We're not using `sendersText` anymore, so we should get rid of that code.
Test Plan: Flow
Reviewers: ginsu
Reviewed By: ginsu
Subscribers: tomek, atul
Differential Revision: https://phab.comm.dev/D6148 |
129,184 | 31.12.2022 05:38:00 | 28,800 | c13c35676480e82d7068526d69e0e1900cb3737b | [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
Summary:
Stringify the `SIWESocialProof` object and store in the `social_proof` column of the `cookies` table.
Depends on D6135
Test Plan:
`public_key` and `social_proof` columns populated as expected:
{F313110}
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/creators/account-creator.js",
"new_path": "keyserver/src/creators/account-creator.js",
"diff": "@@ -22,6 +22,7 @@ import type {\n} from 'lib/types/device-types.js';\nimport type { CalendarQuery } from 'lib/types/entry-types.js';\nimport { message... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Store `SIWESocialProof` in `social_proof` column of `cookies` table
Summary:
Stringify the `SIWESocialProof` object and store in the `social_proof` column of the `cookies` table.
---
Depends on D6135
Test Plan:
`public_key` and `social_proof` columns populated as expected:
{F313110}
Reviewers: ashoat, ... |
129,200 | 04.01.2023 10:05:06 | 18,000 | 33db22ea20eaac711726b9e631fd61f05388f7b7 | [keyserver] remove old gRPC client
Summary: we're using tonic instead, so we can remove this. it's not used anywhere
Test Plan: ran flow and `yarn dev` in keyserver folder
Reviewers: ashoat
Subscribers: ashoat | [
{
"change_type": "MODIFY",
"old_path": "keyserver/package.json",
"new_path": "keyserver/package.json",
"diff": "},\n\"dependencies\": {\n\"@babel/runtime\": \"^7.13.10\",\n- \"@grpc/grpc-js\": \"^1.7.1\",\n- \"@grpc/proto-loader\": \"^0.7.3\",\n\"@matrix-org/olm\": \"3.2.4\",\n\"@parse/node-apn\": \... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] remove old gRPC client
Summary: we're using tonic instead, so we can remove this. it's not used anywhere
Test Plan: ran flow and `yarn dev` in keyserver folder
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat
Differential Revision: https://phab.comm.dev/D6163 |
129,200 | 04.01.2023 14:51:21 | 18,000 | 80f5fbfa0321df68c8327cbbda0a69db9492809d | [keyserver] rename node addon
Summary: we plan to use this node addon for more than just exposing opaque-ke, so we should rename it to something more generic.
Test Plan: yarn cleaninstall
Reviewers: tomek, max
Subscribers: ashoat, atul | [
{
"change_type": "MODIFY",
"old_path": "keyserver/Dockerfile",
"new_path": "keyserver/Dockerfile",
"diff": "@@ -108,15 +108,15 @@ COPY --chown=comm web/package.json web/.flowconfig web/\nCOPY --chown=comm native/package.json native/.flowconfig native/postinstall.sh native/\nCOPY --chown=comm landing... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] rename node addon
Summary: we plan to use this node addon for more than just exposing opaque-ke, so we should rename it to something more generic.
Test Plan: yarn cleaninstall
Reviewers: tomek, max
Reviewed By: tomek, max
Subscribers: ashoat, atul
Differential Revision: https://phab.comm.dev/D6169 |
129,184 | 08.01.2023 19:19:45 | 18,000 | b264e6177b3faf31289ce3d59216868b95157f77 | [web] Add SIWE dependencies to `web/package.json`
Summary: Copy/pasting the SIWE dependencies from `landing` to `web`.
Test Plan: NA
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"@fortawesome/free-regular-svg-icons\": \"5.11.2\",\n\"@fortawesome/free-solid-svg-icons\": \"5.11.2\",\n\"@fortawesome/react-fontawesome\": \"0.1.5\",\n+ \"@rainbow-me/rainbowkit\": \"^0.5.0\",\n\"b... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Add SIWE dependencies to `web/package.json`
Summary: Copy/pasting the SIWE dependencies from `landing` to `web`.
Test Plan: NA
Reviewers: ashoat, tomek
Reviewed By: tomek
Differential Revision: https://phab.comm.dev/D6171 |
129,188 | 21.12.2022 11:20:40 | -3,600 | f72c1cd26d9ab61eeb53f2779b1cfc423b4d4730 | [native] add `.cpp` file for `DatabaseManager`
Summary: Adding `DatabaseManager.cpp`, because later in the stack there will be more methods in this class
Test Plan: Native app builds for both platforms
Reviewers: marcin, tomek
Subscribers: ashoat, tomek, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseManager.cpp",
"diff": "+#include \"DatabaseManager.h\"\n+#include \"SQLiteQueryExecutor.h\"\n+\n+namespace comm {\n+\n+const DatabaseQueryExecutor &DatabaseManager::getQueryExecutor() {\n+ // TODO: c... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] add `.cpp` file for `DatabaseManager`
Summary: Adding `DatabaseManager.cpp`, because later in the stack there will be more methods in this class
Test Plan: Native app builds for both platforms
Reviewers: marcin, tomek
Reviewed By: marcin, tomek
Subscribers: ashoat, tomek, atul
Differential Revision: http... |
129,184 | 09.01.2023 14:38:24 | 18,000 | 5a9d78ab5aa70a543dcdcac546a2136916d393e6 | [web] Replace dashes in `log-in-form.css` selector names with underscores
Summary: Super minor refactor. Makes things easier to work with in my editor.
Test Plan: Careful reading
Reviewers: ashoat, tomek | [
{
"change_type": "MODIFY",
"old_path": "web/account/log-in-form.css",
"new_path": "web/account/log-in-form.css",
"diff": "-div.modal-body {\n+div.modal_body {\ndisplay: flex;\nflex-direction: column;\npadding: 20px 40px;\n@@ -7,32 +7,32 @@ div.modal-body {\nbox-shadow: 0 0 40px rgba(126, 87, 194, 0.... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Replace dashes in `log-in-form.css` selector names with underscores
Summary: Super minor refactor. Makes things easier to work with in my editor.
Test Plan: Careful reading
Reviewers: ashoat, tomek
Reviewed By: ashoat
Differential Revision: https://phab.comm.dev/D6202 |
129,187 | 10.01.2023 16:28:08 | 18,000 | 5458013b9224ae708d5b3cdb29eb7a2d13ccf1d6 | [lib] Remove messageTypeGeneratesNotifs function
Summary: This can be removed following D646, as the function doesn't seem to be doing anything other than adding a layer of indirection now.
Test Plan: Flow
Reviewers: ginsu
Subscribers: tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/creators/message-creator.js",
"new_path": "keyserver/src/creators/message-creator.js",
"diff": "@@ -5,7 +5,6 @@ import invariant from 'invariant';\nimport { permissionLookup } from 'lib/permissions/thread-permissions';\nimport {\nrawMessageInfoFr... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Remove messageTypeGeneratesNotifs function
Summary: This can be removed following D646, as the function doesn't seem to be doing anything other than adding a layer of indirection now.
Test Plan: Flow
Reviewers: ginsu
Reviewed By: ginsu
Subscribers: tomek, atul
Differential Revision: https://phab.comm.dev/D6... |
129,187 | 10.01.2023 16:50:37 | 18,000 | 7407b0a6395ea55749fdc32d92cf5f99afcfd64a | [keyserver] Rename subthreadsCanNotify to userNotMemberOfSubthreads
Summary: Depends on D6216
Test Plan: Flow
Reviewers: ginsu
Subscribers: tomek, atul | [
{
"change_type": "MODIFY",
"old_path": "keyserver/src/creators/message-creator.js",
"new_path": "keyserver/src/creators/message-creator.js",
"diff": "@@ -49,7 +49,7 @@ type UserThreadInfo = {\n>,\n+threadIDs: Set<string>,\n+notFocusedThreadIDs: Set<string>,\n- +subthreadsCanNotify: Set<string>,\n+ +... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Rename subthreadsCanNotify to userNotMemberOfSubthreads
Summary: Depends on D6216
Test Plan: Flow
Reviewers: ginsu
Reviewed By: ginsu
Subscribers: tomek, atul
Differential Revision: https://phab.comm.dev/D6222 |
129,205 | 05.12.2022 16:42:03 | -3,600 | 174fffba3a1839f34e0417c31896070a938401e0 | [services][backup] Scaffold gRPC server
Summary:
Created gRPC handlers, added logging and server init code. Some copy-paste from blob service.
Depends on D5842
Test Plan: Service should respond with `UNIMPLEMENTED` to gRPC calls.
Reviewers: varun, tomek, jon
Subscribers: ashoat, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/src/constants.rs",
"diff": "+pub const DEFAULT_GRPC_SERVER_PORT: u64 = 50051;\n+pub const LOG_LEVEL_ENV_VAR: &str =\n+ tracing_subscriber::filter::EnvFilter::DEFAULT_ENV;\n"
},
{
"change_type": "MODIFY",
"old_path": "... | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services][backup] Scaffold gRPC server
Summary:
Created gRPC handlers, added logging and server init code. Some copy-paste from blob service.
Depends on D5842
Test Plan: Service should respond with `UNIMPLEMENTED` to gRPC calls.
Reviewers: varun, tomek, jon
Reviewed By: varun, tomek
Subscribers: ashoat, atul
Di... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.