author
int64
658
755k
date
stringdate
2012-06-12 08:34:29
2024-07-22 14:51:21
timezone
int64
-46,800
43.2k
hash
stringlengths
40
40
message
stringlengths
5
490
mods
listlengths
1
16
language
stringclasses
20 values
license
stringclasses
3 values
repo
stringlengths
5
68
original_message
stringlengths
12
491
748,234
01.06.2019 10:28:39
25,200
50352c139137980ddf165aa3835091056491f1bf
fix: Remove authorization from static files Closes
[ { "change_type": "MODIFY", "old_path": "nodes/config-server/config-server.js", "new_path": "nodes/config-server/config-server.js", "diff": "@@ -6,16 +6,12 @@ module.exports = function(RED) {\nconst HomeAssistant = require('../../lib/node-home-assistant');\n// Handle static files\n- RED.httpAdmin.get...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix: Remove authorization from static files Closes #125
748,234
01.06.2019 19:31:44
25,200
4231717fd4344b5b6c839f6aa73448ea3bd69585
fix(wait-until): removed leftover code that was breaking events
[ { "change_type": "MODIFY", "old_path": "nodes/wait-until/wait-until.js", "new_path": "nodes/wait-until/wait-until.js", "diff": "@@ -93,11 +93,6 @@ module.exports = function(RED) {\nreturn null;\n}\n- if (this.websocketClient) {\n- Object.entries(this.listeners).forEach(([event, handler]) => {\n- thi...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(wait-until): removed leftover code that was breaking events
748,234
04.06.2019 23:22:27
25,200
79fcf29e9c49b7f56e09fedc7dbc2b72a23c2446
fix(current-state): fix for none type for state and data location Closes
[ { "change_type": "MODIFY", "old_path": "nodes/current-state/current-state.js", "new_path": "nodes/current-state/current-state.js", "diff": "@@ -12,12 +12,20 @@ module.exports = function(RED) {\nstate_type: nodeDef => nodeDef.state_type || 'str',\nstate_location: nodeDef => nodeDef.state_location || ...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(current-state): fix for none type for state and data location Closes #126
748,234
04.06.2019 23:26:21
25,200
ea82e09d913370daff93f7ee4935699c6626ab25
style: Changed if state icon
[ { "change_type": "MODIFY", "old_path": "nodes/current-state/current-state.html", "new_path": "nodes/current-state/current-state.html", "diff": "</div>\n<div class=\"form-row\">\n- <label for=\"node-input-halt_if_compare\"><i class=\"fa fa-random\"></i> If State</label>\n+ <label for=\"node-input-hal...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
style: Changed if state icon
748,234
23.06.2019 06:05:29
25,200
c4d308196f4f34d369b451b376a507b30508cc75
feat(wait-until): Allow overriding of config value
[ { "change_type": "MODIFY", "old_path": "lib/events-node.js", "new_path": "lib/events-node.js", "diff": "@@ -40,7 +40,7 @@ class EventsNode extends BaseNode {\nthis.websocketClient.addListener(event, handler);\n}\n- onClose(nodeRemoved) {\n+ removeEventClientListeners() {\nif (this.websocketClient) {...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(wait-until): Allow overriding of config value
748,234
01.07.2019 16:52:41
25,200
4c37f61b9bd0a29423389cf47689de25b42d5247
refactor(wait-until): set default to block input overrides of config
[ { "change_type": "MODIFY", "old_path": "nodes/wait-until/wait-until.html", "new_path": "nodes/wait-until/wait-until.html", "diff": "entityLocation: { value: \"data\" },\nentityLocationType: { value: \"none\" },\ncheckCurrentState: { value: true },\n- blockInputOverrides: { value: false }\n+ blockInp...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor(wait-until): set default to block input overrides of config
748,234
01.07.2019 17:42:56
25,200
aed45795c4220866edfde84adf879dfcf9d1f5f4
feat(current-state): Templates are processed in the entity id field
[ { "change_type": "MODIFY", "old_path": "nodes/current-state/current-state.js", "new_path": "nodes/current-state/current-state.js", "diff": "+const RenderTemplate = require('../../lib/mustache-context');\nconst BaseNode = require('../../lib/base-node');\nconst Joi = require('@hapi/joi');\n@@ -48,10 +...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(current-state): Templates are processed in the entity id field
748,234
06.07.2019 15:10:00
25,200
e0f52e0b8722a3d9ce269f7abd3cf0283860fb6b
fix: Load external js,css for all nodes not only config Load external js and css files for all nodes just not server-config nodes. Fixes NodeVersion error when no config has been defined yet.
[ { "change_type": "MODIFY", "old_path": "nodes/api/api.html", "new_path": "nodes/api/api.html", "diff": "+<link rel=\"stylesheet\" type=\"text/css\" href=\"homeassistant/static/common.css\" />\n+<script src=\"homeassistant/static/common.js\"></script>\n<script type=\"text/javascript\">\nRED.nodes.reg...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix: Load external js,css for all nodes not only config Load external js and css files for all nodes just not server-config nodes. Fixes NodeVersion error when no config has been defined yet.
748,234
07.07.2019 20:10:14
25,200
5f437d4e4e055239d20e6cc4ba91e3fd396162da
docs: Info about docker on rpi needing node.js upgraded
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -12,9 +12,9 @@ Project is going through active development and as such will probably have a few\n## Getting Started\n-This assumes you have [Node-RED](https://nodered.org) already installed and working, if you n...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: Info about docker on rpi needing node.js upgraded
748,234
20.07.2019 05:48:58
25,200
a0fdb963b0a1ac598773dfc3e7ea8848ae054bef
feat(get-entities): Allow overriding of config values from payload Closes
[ { "change_type": "MODIFY", "old_path": "nodes/_static/common.css", "new_path": "nodes/_static/common.css", "diff": "-ms-user-select: none;\nuser-select: none;\n}\n+\n+li span.property-type {\n+ font-family: \"Helvetica Neue\", Arial, Helvetica, sans-serif;\n+ color: #666;\n+ font-style: italic;\n+ f...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(get-entities): Allow overriding of config values from payload Closes #133
748,234
21.07.2019 06:31:00
25,200
37b54ce910875e748e49427664d4235ca9891410
feat(api): Add option for data field to be a JSONata Expr
[ { "change_type": "MODIFY", "old_path": "nodes/api/api.html", "new_path": "nodes/api/api.html", "diff": "method: { value: \"get\" },\npath: { value: \"\" },\ndata: { value: \"\" },\n+ dataType: { value: \"json\" },\nlocation: { value: \"payload\" },\nlocationType: { value: \"msg\" },\nresponseType: {...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(api): Add option for data field to be a JSONata Expr
748,234
21.07.2019 07:52:12
25,200
526d0836ab8660c3369b37af97ca15cfeb668ad3
feat(fire-event): Add option for data field to be a JSONata Expr Add option for data field to be a JSONata Exprression. Removed merge context
[ { "change_type": "MODIFY", "old_path": "nodes/fire-event/fire-event.html", "new_path": "nodes/fire-event/fire-event.html", "diff": "name: { value: \"\" },\nserver: { value: \"\", type: \"server\", required: true },\nevent: { value: \"\" },\n- data: {\n- value: \"\",\n- validate: function(v) {\n- // ...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(fire-event): Add option for data field to be a JSONata Expr Add option for data field to be a JSONata Exprression. Removed merge context
748,234
23.07.2019 21:37:32
25,200
8e91f42d21b2f95391268fb0a9a4c7e943a5f3ea
feat(call-service): Add JSONata option to data field
[ { "change_type": "MODIFY", "old_path": "nodes/_static/common.js", "new_path": "nodes/_static/common.js", "diff": "@@ -7,6 +7,9 @@ var nodeVersion = (function($) {\ncase 'api-current-state':\nname = 'current-state';\nbreak;\n+ case 'api-call-service':\n+ name = 'call-service';\n+ break;\ncase 'poll-s...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(call-service): Add JSONata option to data field
748,234
23.07.2019 23:42:42
25,200
cb4771b3f5866d88395d961117d73dec546caf2f
refactor(call-service): check for valid data and entity_id before acting
[ { "change_type": "MODIFY", "old_path": "nodes/call-service/call-service.js", "new_path": "nodes/call-service/call-service.js", "diff": "@@ -73,7 +73,7 @@ module.exports = function(RED) {\nserverName\n);\nlet configData;\n- if (config.dataType === 'jsonata' && config.data.length) {\n+ if (config.data...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor(call-service): check for valid data and entity_id before acting
748,234
27.07.2019 17:23:08
25,200
b1180098b75e7f714667537d183153e1d04c3023
fix(call-service): homeassistant domain ids needing to be an array Moved the coverting of homeassistant domainids to an array to the backend Closes
[ { "change_type": "MODIFY", "old_path": "nodes/call-service/call-service.html", "new_path": "nodes/call-service/call-service.html", "diff": "this.service_domain = $(\"#service_domain\").val();\nthis.service = $(\"#service\").val();\n- // Insert entity id into data object\nif (entityId.length) {\n- co...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(call-service): homeassistant domain ids needing to be an array Moved the coverting of homeassistant domainids to an array to the backend Closes #136
748,234
27.07.2019 17:23:42
25,200
09021621855c6877d6a44658ac0405533abb0bc0
fix(call-service): fix for validation of data field
[ { "change_type": "MODIFY", "old_path": "nodes/call-service/call-service.html", "new_path": "nodes/call-service/call-service.html", "diff": "service_domain: { value: \"\" },\nservice: { value: \"\" },\nentityId: { value: \"\" },\n- data: {\n- value: \"\",\n- validate: function(v) {\n- // data isn't r...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(call-service): fix for validation of data field
748,234
01.08.2019 10:23:50
25,200
888935512ac7f9bf56c8f6611c28b90cb282b2ca
fix(call-service): render mustache templates for entity id field
[ { "change_type": "MODIFY", "old_path": "nodes/call-service/call-service.js", "new_path": "nodes/call-service/call-service.js", "diff": "@@ -121,14 +121,21 @@ module.exports = function(RED) {\nconfig.entityId &&\n!Object.prototype.hasOwnProperty.call(apiData, 'entity_id')\n) {\n+ const entityId = Ren...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(call-service): render mustache templates for entity id field
748,234
08.08.2019 19:52:55
25,200
34a268b3d12493e41d7796b15d7d2f6ff58055c8
ci: add linting to travis ci
[ { "change_type": "MODIFY", "old_path": ".travis.yml", "new_path": ".travis.yml", "diff": "language: node_js\nnode_js:\n- \"8\"\n-script: \"npm run-script test-travis\"\n+script:\n+ - npm run lint\n+ - npm run-script test-travis\n# Send coverage data to Coveralls\nafter_script: \"cat ./coverage/lcov....
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
ci: add linting to travis ci
748,234
13.08.2019 00:40:00
25,200
47727727dbfe6d63b19be61d3812ced4309e9702
ci: removed test-travis script
[ { "change_type": "MODIFY", "old_path": ".travis.yml", "new_path": ".travis.yml", "diff": "language: node_js\nnode_js:\n- - \"8\"\n+ - 8\n+ - 10\nscript:\n- npm run lint\n- - npm run-script test-travis\n+ - npm run test\nafter_success:\n# Send coverage data to Coveralls\n- nyc npm test && nyc report ...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
ci: removed test-travis script
748,234
14.08.2019 21:30:28
25,200
5125821b56cbb9e24f898e1c71eedcc886d46f47
fix(get-entities): error when property value was not set for jsonata
[ { "change_type": "MODIFY", "old_path": "nodes/get-entities/get-entities.js", "new_path": "nodes/get-entities/get-entities.js", "diff": "@@ -75,7 +75,11 @@ module.exports = function(RED) {\nschema: Joi.array()\n.items(\nJoi.object({\n- property: Joi.string(),\n+ property: Joi.when('logic', {\n+ is: '...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(get-entities): error when property value was not set for jsonata
748,234
17.08.2019 03:25:35
25,200
a45366f4fad7c9bc783a197f9497b079065d718b
fix(trigger-state): Attribute of other entity undefined in trigger Closes
[ { "change_type": "MODIFY", "old_path": "nodes/trigger-state/trigger-state.js", "new_path": "nodes/trigger-state/trigger-state.js", "diff": "@@ -324,14 +324,23 @@ module.exports = function(RED) {\n? this.nodeConfig.entityid\n: constraint.targetValue;\n- if (isTargetThisEntity) {\n- targetData.state =...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix(trigger-state): Attribute of other entity undefined in trigger Closes #148
748,234
17.08.2019 04:03:04
25,200
c7529a6c1099c241e7307ad74497cecc1adf866a
refactor(trigger-state): remove deprecation warning
[ { "change_type": "MODIFY", "old_path": "nodes/trigger-state/trigger-state.js", "new_path": "nodes/trigger-state/trigger-state.js", "diff": "@@ -217,10 +217,13 @@ module.exports = function(RED) {\nconstraint,\neventMessage.event\n);\n+\nconst actualValue = this.utils.selectn(\nconstraint.propertyValu...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor(trigger-state): remove deprecation warning
748,234
17.08.2019 11:03:04
25,200
545643c8556cf98e825ef94522f955848aed30f2
refactor(trigger-state): remove console.log
[ { "change_type": "MODIFY", "old_path": "nodes/trigger-state/trigger-state.js", "new_path": "nodes/trigger-state/trigger-state.js", "diff": "@@ -222,7 +222,6 @@ module.exports = function(RED) {\nconstraint.propertyValue,\nconstraintTarget.state\n);\n- console.log(constraint.propertyValue, actualValue...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor(trigger-state): remove console.log
748,234
17.08.2019 11:06:45
25,200
adfd0dc46fbd4285732d953893bba9c4dbfb4da3
feat(get-entities): timeSinceChangedMs is not a filterable property Closes
[ { "change_type": "MODIFY", "old_path": "nodes/get-entities/get-entities.js", "new_path": "nodes/get-entities/get-entities.js", "diff": "@@ -140,6 +140,9 @@ module.exports = function(RED) {\nentities = await filter(Object.values(states), async entity => {\nconst rules = parsedMessage.rules.value;\n+ ...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(get-entities): timeSinceChangedMs is not a filterable property Closes #147
748,234
22.08.2019 08:39:47
25,200
91203409707842454d330a45d6979a32933d2149
ci: Add npm release to master tagged pushes
[ { "change_type": "MODIFY", "old_path": ".travis.yml", "new_path": ".travis.yml", "diff": "@@ -2,9 +2,25 @@ language: node_js\nnode_js:\n- 8\n- 10\n+\n+stages:\n+ - name: test\n+ - name: release\n+ if: (branch = master AND type = push) OR (tag IS present)\n+\n+jobs:\n+ include:\n+ - stage: test\nscri...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
ci: Add npm release to master tagged pushes
748,234
22.08.2019 09:02:27
25,200
de1333bcb0076411674cc29b608946ab8eeaeaee
ci: fix travis-ci yaml
[ { "change_type": "MODIFY", "old_path": ".travis.yml", "new_path": ".travis.yml", "diff": "@@ -19,7 +19,8 @@ jobs:\n- nyc npm test && nyc report --reporter=text-lcov | coveralls\n- stage: release\nnode_js: 10\n- deploy: npm\n+ deploy:\n+ provider: npm\nemail: \"$NPM_EMAIL\"\napi_key: \"$NPM_TOKEN\"\n...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
ci: fix travis-ci yaml
748,234
30.09.2019 18:49:50
25,200
2990dcb8ed8300d7d312aef0c0ac23ee033dc94b
docs: Removed docker info as no longer needed for NR 1.0
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -30,8 +30,6 @@ $ npm install node-red-contrib-home-assistant-websocket\n# then restart node-red\n```\n-**Docker users on Rpi** will need to upgrade Node.js inside the [official Node-RED container](https://hub.do...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: Removed docker info as no longer needed for NR 1.0
748,234
10.10.2019 18:31:06
25,200
989dfb5b03f2fc626012b55f3b99ada731152414
refactor: Only subscribe to needed events not all No longer subscribe to all events from HA and only subscribe to state_changed and events define in events: all nodes. All events can still be subscribed to but doing so may overload the send queue in HA. Closes
[ { "change_type": "MODIFY", "old_path": "lib/ha-websocket.js", "new_path": "lib/ha-websocket.js", "diff": "@@ -18,6 +18,9 @@ class HaWebsocket extends EventEmitter {\nthis.states = {};\nthis.services = {};\nthis.statesLoaded = false;\n+ this.client = null;\n+ this.subscribedEvents = new Set();\n+ thi...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor: Only subscribe to needed events not all No longer subscribe to all events from HA and only subscribe to state_changed and events define in events: all nodes. All events can still be subscribed to but doing so may overload the send queue in HA. Closes #153
748,234
10.10.2019 19:08:02
25,200
321561d324c8f460fc81b1093f3a1859013d9d04
fix: Remove event type from sub list when unsubscribing
[ { "change_type": "MODIFY", "old_path": "lib/ha-websocket.js", "new_path": "lib/ha-websocket.js", "diff": "@@ -97,6 +97,7 @@ class HaWebsocket extends EventEmitter {\nif (e !== '__ALL__') {\nthis.unsubEvents[e]();\ndelete this.unsubEvents[e];\n+ this.subscribedEvents.delete(e);\n}\n});\n@@ -105,7 +10...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix: Remove event type from sub list when unsubscribing
748,234
10.10.2019 19:18:49
25,200
93615712339822b91b0c973e3657e9b028cd2863
refactor: eslint fixes/changes
[ { "change_type": "MODIFY", "old_path": "lib/base-node.js", "new_path": "lib/base-node.js", "diff": "@@ -23,12 +23,18 @@ const DEFAULT_OPTIONS = {\nconfig: {\ndebugenabled: {},\nname: {},\n- server: { isNode: true },\n+ server: {\n+ isNode: true\n+ },\nversion: nodeDef => nodeDef.version || 0\n},\nin...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor: eslint fixes/changes
748,234
14.10.2019 16:57:07
25,200
d7d1b8c4b45efe3050009e75e70305468e35408f
refactor: Cleaned up event subscribing
[ { "change_type": "MODIFY", "old_path": "lib/ha-websocket.js", "new_path": "lib/ha-websocket.js", "diff": "@@ -20,7 +20,7 @@ class HaWebsocket extends EventEmitter {\nthis.statesLoaded = false;\nthis.client = null;\nthis.subscribedEvents = new Set();\n- this.unsubEvents = {};\n+ this.unsubCallback = ...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor: Cleaned up event subscribing
748,234
14.10.2019 22:12:40
25,200
41539d7df918f8e7356fa6e6a248ffe255137a46
fix: css changed for NR v1.0
[ { "change_type": "MODIFY", "old_path": "nodes/_static/common.css", "new_path": "nodes/_static/common.css", "diff": "margin-top: 5px;\n}\n-.checkboxOption input {\n+.form-row.checkboxOption input {\nmargin-left: 105px;\ndisplay: inline-block;\nwidth: auto;\nvertical-align: baseline;\n}\n-.checkboxOpt...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix: css changed for NR v1.0
748,234
15.10.2019 03:22:15
25,200
6b687bb96c1c173433f5e3e66637c8fc015b0c79
refactor: Changed prefix of client event to 'ha_client'
[ { "change_type": "MODIFY", "old_path": "lib/events-node.js", "new_path": "lib/events-node.js", "diff": "@@ -5,7 +5,9 @@ const DEFAULT_NODE_OPTIONS = {\ndebug: false,\nconfig: {\nname: {},\n- server: { isNode: true }\n+ server: {\n+ isNode: true\n+ }\n}\n};\n@@ -16,19 +18,19 @@ class EventsNode exten...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
refactor: Changed prefix of client event to 'ha_client'
748,234
17.10.2019 04:20:21
25,200
873603b29778c824bd3f8b2c72b80964efd440bf
feat(call-service): Add debug flag for more information
[ { "change_type": "MODIFY", "old_path": "nodes/call-service/call-service.html", "new_path": "nodes/call-service/call-service.html", "diff": "},\nlabelStyle: nodeVersion.labelStyle,\ndefaults: {\n- name: { value: \"\" },\n- server: { value: \"\", type: \"server\", required: true },\n- version: { value...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
feat(call-service): Add debug flag for more information
748,261
21.11.2019 23:22:10
18,000
a5a5e62e1e2caf7603cd4da473f76ece8159421c
docs: Update events-state-changed.html Previous help included "Output Initially" which is no longer available. This update reflect current options. I also removed the language "on each interval" which does not seem applicable, but please check. Cheers, Richard
[ { "change_type": "MODIFY", "old_path": "nodes/events-state-changed/events-state-changed.html", "new_path": "nodes/events-state-changed/events-state-changed.html", "diff": "<dt>State Type<span class=\"property-type\">string</span></dt>\n<dd>Convert the state of the entity to the selected type. Boolea...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: Update events-state-changed.html (#166) Previous help included "Output Initially" which is no longer available. This update reflect current options. I also removed the language "on each interval" which does not seem applicable, but please check. Cheers, Richard
748,242
02.01.2020 02:44:19
0
b7047192703de707e8b5c2f4782abcd872059697
docs: [Auto Commit] Convert markdown docs to Node-RED help files
[ { "change_type": "MODIFY", "old_path": "nodes/config-server/config-server.html", "new_path": "nodes/config-server/config-server.html", "diff": "<p>Home Assistant connection configuration</p>\n<h3>Config</h3>\n<dl class=\"message-properties\">\n- <dt>Name<span class=\"property-type\"></span></dt>\n+ ...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: [Auto Commit] Convert markdown docs to Node-RED help files
748,233
02.04.2020 16:42:40
21,600
5aa5b71e945ba6e3fd16063511d47e2fcbc31b7e
fix: "NaN" for events-state-changed
[ { "change_type": "MODIFY", "old_path": "nodes/events-state-changed/events-state-changed.js", "new_path": "nodes/events-state-changed/events-state-changed.js", "diff": "@@ -49,7 +49,7 @@ module.exports = function (RED) {\nif (this.isEnabled === false) {\nreturn;\n}\n- const { entity_id, event } = { ....
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix: "NaN" for events-state-changed
748,249
17.10.2020 12:49:20
18,000
cf9d858ed0e4fd8ecb895d579e4c7b0fdf82a100
docs: Correct REST and Websocket API links
[ { "change_type": "MODIFY", "old_path": "docs/node/API.md", "new_path": "docs/node/API.md", "diff": "@@ -94,5 +94,5 @@ Will output the results received from the API call to the location defined in th\n## References\n-- [http api](https://developers.home-assistant.io/docs/en/external_api_rest.html)\n-...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: Correct REST and Websocket API links (#280)
748,236
04.01.2021 11:42:32
25,200
9fe6023e4babd2f7d5761b3df3178604f62f28c8
docs: Update README.md Fixed minor spelling error
[ { "change_type": "MODIFY", "old_path": "docs/cookbook/README.md", "new_path": "docs/cookbook/README.md", "diff": "@@ -13,7 +13,7 @@ further educate yourself in the world of Home Automation with Node-RED.\n- [Expiration Date Monitor](./expiration-date-monitor.md)\n- [Using date and time entities to t...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: Update README.md (#325) Fixed minor spelling error
748,237
21.09.2022 22:34:46
-3,600
7e22233b01dfed5c35ed6008f4711754752ab4a7
fix: Trigger Node Custom Output Comparators * fix: Trigger Node Custom Output Comparators Updates the select_option values to match the labels, aligns the lists with 'Conditions' options * formatting
[ { "change_type": "MODIFY", "old_path": "src/nodes/trigger-state/editor.html", "new_path": "src/nodes/trigger-state/editor.html", "diff": "<option\nvalue=\">\"\n- data-i18n=\"home-assistant.label.select_option.less_than\"\n+ data-i18n=\"home-assistant.label.select_option.greater_than\"\n></option>\n<...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
fix: Trigger Node Custom Output Comparators #580 (#665) * fix: Trigger Node Custom Output Comparators #580 Updates the select_option values to match the labels, aligns the lists with 'Conditions' options * formatting Co-authored-by: Jason <37859597+zachowj@users.noreply.github.com>
748,252
11.10.2022 03:48:22
-7,200
60a9bb9d6862b58f7c73b8cf296ad18dc22092a7
docs: change url for device-config.md
[ { "change_type": "MODIFY", "old_path": "docs/node/entity-config.md", "new_path": "docs/node/entity-config.md", "diff": "@@ -13,7 +13,7 @@ The name of the entity that will show in Node-RED\n### Device\n- Type: `string`\n-- [device config documentation](./device-config.md)\n+- [device config documenta...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: change url for device-config.md (#697)
748,254
12.10.2022 06:25:41
-7,200
46ee50fd16de171247d8ca69dd44d696365d0269
docs: Fix JSONata Example links * Removal of Example links Example links point to not existing sites * fix links
[ { "change_type": "MODIFY", "old_path": "docs/guide/jsonata.md", "new_path": "docs/guide/jsonata.md", "diff": "@@ -25,11 +25,9 @@ When it is chosen with a conditional, not JSONata it will return a value of the\n![screenshot](./images/jsonata_2.png)\n-## Examples\n-\n-- [Increase lights brightness wit...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
docs: Fix JSONata Example links (#666) * Removal of Example links Example links point to not existing sites * fix links Co-authored-by: Jason <37859597+zachowj@users.noreply.github.com>
748,253
25.01.2023 07:24:25
-36,000
3e5a25d55566b58b217d82102aa9b61ffd354e9e
Push nodered json/jsonata params to Http Api as an object instead of a string.
[ { "change_type": "MODIFY", "old_path": "src/nodes/api/controller.js", "new_path": "src/nodes/api/controller.js", "diff": "@@ -109,22 +109,24 @@ class Api extends BaseNode {\nlet data;\nif (parsedMessage.dataType.value === 'jsonata') {\ntry {\n- data = JSON.stringify(\n- this.evaluateJSONata(parsedMe...
TypeScript
MIT License
zachowj/node-red-contrib-home-assistant-websocket
Push nodered json/jsonata params to Http Api as an object instead of a string. (#828)
259,992
28.04.2018 11:12:01
25,200
54a20025b15795bf3d6bd2435b8e83dbbca55a64
Fix center alignment github markdown doesn't like {style} tags. Also moved the image after their respective section.
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -35,9 +35,6 @@ made available to a container.\nTwo other approaches are commonly taken to provide stronger isolation than\nnative containers.\n-![Machine-level virtualization](g3doc/Machine-Virtualization.png \"...
Go
Apache License 2.0
google/gvisor
Fix center alignment github markdown doesn't like {style} tags. Also moved the image after their respective section. PiperOrigin-RevId: 194663070 Change-Id: I7a7b97c1bc6f2b368837a3aa936f8bd3c00469fd
259,858
28.04.2018 18:05:12
25,200
913aa0a24dc3ed6cb71971e56c6ae363e8d0113d
Restore markdown images that work universally
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -45,7 +45,7 @@ performance (though nested virtualization may bring challenges in this area),\nbut for containers it often requires additional proxies and agents, and may\nrequire a larger resource footprint and ...
Go
Apache License 2.0
google/gvisor
Restore markdown images that work universally PiperOrigin-RevId: 194676199 Change-Id: Ibb9257a5504b10c4469a57ba27cd866f2d660fd8
259,858
01.05.2018 07:47:48
25,200
8a17bd183e0f7528c03c5445de4d74bf72e068f1
Make images consistent.
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -65,8 +65,6 @@ defense-in-depth.\n**gVisor** provides a third isolation mechanism, distinct from those mentioned\nabove.\n-![gVisor](g3doc/Layers.png \"gVisor\")\n-\ngVisor intercepts application system calls an...
Go
Apache License 2.0
google/gvisor
Make images consistent. PiperOrigin-RevId: 194936276 Change-Id: I01f840f573c206e865de8e5e2dd4304dcb5e3621
259,854
01.05.2018 08:06:11
25,200
b701ee221434572881b9b3b0164d5a5b54714fa9
Fix SO_RCVTIMEOUT for recvmsg
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/syscalls/linux/sys_socket.go", "new_path": "pkg/sentry/syscalls/linux/sys_socket.go", "diff": "@@ -610,7 +610,14 @@ func RecvMsg(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysca\nflags |= linux.MSG_DONTWAIT\n}\n- n, err := recvSin...
Go
Apache License 2.0
google/gvisor
Fix SO_RCVTIMEOUT for recvmsg PiperOrigin-RevId: 194938091 Change-Id: Id17f26df13a915ec0c388aad3198207ea1c28d53
259,962
01.05.2018 19:11:10
25,200
43256efb080915d92a17549d86ef4eaff9ab8ef8
Write either packet logs or pcap file. But not both.
[ { "change_type": "MODIFY", "old_path": "pkg/tcpip/link/sniffer/sniffer.go", "new_path": "pkg/tcpip/link/sniffer/sniffer.go", "diff": "@@ -86,8 +86,9 @@ func writePCAPHeader(w io.Writer, maxLen uint32) error {\n// NewWithFile creates a new sniffer link-layer endpoint. It wraps around\n// another endp...
Go
Apache License 2.0
google/gvisor
Write either packet logs or pcap file. But not both. PiperOrigin-RevId: 195035056 Change-Id: Ib32188b62188ddc2059debd52610e7904e1438c6
259,881
01.05.2018 21:14:24
25,200
185233427b3834086a9050336113f9e22176fa3b
Note that the KVM platform is experimental
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -142,12 +142,13 @@ mapping functionality. Today, gVisor supports two platforms:\nexecuting host system calls. This platform can run anywhere that `ptrace`\nworks (even VMs without nested virtualization).\n-* The...
Go
Apache License 2.0
google/gvisor
Note that the KVM platform is experimental PiperOrigin-RevId: 195043285 Change-Id: Ie76112eff61062e1a54894b3707201fd284be377
259,881
01.05.2018 22:17:13
25,200
65df95516898f077cda44ace15e45e4c777fdaf3
Set LMA in EFER As of Linux 4.15 (f29810335965ac1f7bcb501ee2af5f039f792416 KVM/x86: Check input paging mode when cs.l is set), KVM validates that LMA is set along with LME.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/ring0/kernel_amd64.go", "new_path": "pkg/sentry/platform/ring0/kernel_amd64.go", "diff": "@@ -149,7 +149,7 @@ func (c *CPU) CR4() uint64 {\n//\n//go:nosplit\nfunc (c *CPU) EFER() uint64 {\n- return _EFER_LME | _EFER_SCE | _EFER_NX\n+ return...
Go
Apache License 2.0
google/gvisor
Set LMA in EFER As of Linux 4.15 (f29810335965ac1f7bcb501ee2af5f039f792416 KVM/x86: Check input paging mode when cs.l is set), KVM validates that LMA is set along with LME. PiperOrigin-RevId: 195047401 Change-Id: I8b43d8f758a85b1f58ccbd747dcacd4056ef3f66
259,926
02.05.2018 03:42:54
25,200
2264ce7f62994fa0476f8e1eb9fe497d60547bda
Use png for the run states diagram
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/kernel/README.md", "new_path": "pkg/sentry/kernel/README.md", "diff": "@@ -87,7 +87,7 @@ kept separate from the main \"app\" state to reduce the size of the latter.\n4. `SyscallReinvoke`, which does not correspond to anything in Linux, and exists\ns...
Go
Apache License 2.0
google/gvisor
Use png for the run states diagram PiperOrigin-RevId: 195071508 Change-Id: I63314bf7529560e4c779ef07cc9399ad8d53f0a2
259,881
02.05.2018 11:20:43
25,200
6c061ad913fce6fbfe9a98c0fc1f5b67fad1b9b0
Note that build requires Python 2.7 Updates
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -168,6 +168,8 @@ and Docker.\n* [git][git]\n* [Bazel][bazel]\n+* [Python 2.7][python] (See [bug #8](https://github.com/google/gvisor/issues/8)\n+ for Python 3 support updates)\n* [Docker version 17.09.0 or great...
Go
Apache License 2.0
google/gvisor
Note that build requires Python 2.7 Updates #8 PiperOrigin-RevId: 195122103 Change-Id: Iff190283961b8ab99ad4f3e47ffeb9ab491d0eb3
259,992
02.05.2018 17:39:12
25,200
a61def1b368a9042e346787008e12770e4e67b35
Remove detach for exec options Detachable exec commands are handled in the client entirely and the detach option is not used anymore.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/control/proc.go", "new_path": "pkg/sentry/control/proc.go", "diff": "@@ -72,9 +72,6 @@ type ExecArgs struct {\n// Capabilities is the list of capabilities to give to the process.\nCapabilities *auth.TaskCapabilities\n- // Detach indicates whether Ex...
Go
Apache License 2.0
google/gvisor
Remove detach for exec options Detachable exec commands are handled in the client entirely and the detach option is not used anymore. PiperOrigin-RevId: 195181272 Change-Id: I6e82a2876d2c173709c099be59670f71702e5bf0
259,956
03.05.2018 09:59:32
25,200
9739b8c21cd1716c4c1c81a27121c50e63fcf906
Don't prematurely remove MountSource from parent's children. Otherwise, mounts that fail to be unmounted (EBUSY) will be removed from the children list anyway. At this point, this just affects /proc/pid/mounts and /proc/pid/mountinfo.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/mounts.go", "new_path": "pkg/sentry/fs/mounts.go", "diff": "@@ -272,8 +272,25 @@ func (mns *MountNamespace) Unmount(ctx context.Context, node *Dirent, detachOnly\npanic(\"cannot unmount initial dirent\")\n}\n- if !detachOnly {\nm := node.Inode.Mo...
Go
Apache License 2.0
google/gvisor
Don't prematurely remove MountSource from parent's children. Otherwise, mounts that fail to be unmounted (EBUSY) will be removed from the children list anyway. At this point, this just affects /proc/pid/mounts and /proc/pid/mountinfo. PiperOrigin-RevId: 195267588 Change-Id: I79114483d73b90f9a7d764a7d513b5b2f251182e
259,956
03.05.2018 13:43:20
25,200
18ebda3476f2e28101656d93a88107d587e0f1ca
Include Gold linker in requirements. Updates
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -171,6 +171,7 @@ and Docker.\n* [Python 2.7][python] (See [bug #8](https://github.com/google/gvisor/issues/8)\nfor Python 3 support updates)\n* [Docker version 17.09.0 or greater][docker]\n+* Gold linker (e.g. `...
Go
Apache License 2.0
google/gvisor
Include Gold linker in requirements. Updates #26. PiperOrigin-RevId: 195303940 Change-Id: I833cee55b5df6196ed90c1f8987c3c9c07204678
259,854
03.05.2018 16:25:39
25,200
58235b1840db01aa2ede311efa782eac60767722
Clean up control message strace logging
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/strace/socket.go", "new_path": "pkg/sentry/strace/socket.go", "diff": "@@ -463,7 +463,6 @@ func cmsghdr(t *kernel.Task, addr usermem.Addr, length uint64, maxBytes uint64)\nvar h linux.ControlMessageHeader\nbinary.Unmarshal(buf[i:i+linux.SizeOfContro...
Go
Apache License 2.0
google/gvisor
Clean up control message strace logging PiperOrigin-RevId: 195329972 Change-Id: I42f7d8800e6692c45ffa9683741f8de89f9a69bb
259,992
03.05.2018 21:08:38
25,200
c186ebb62a6005288d83feed0e43cca9f0577383
Return error when child exits early
[ { "change_type": "MODIFY", "old_path": "runsc/cmd/exec.go", "new_path": "runsc/cmd/exec.go", "diff": "@@ -123,6 +123,34 @@ func (ex *Exec) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\n// write the child's PID to the pid file. So when the container returns, the\n// child process ...
Go
Apache License 2.0
google/gvisor
Return error when child exits early PiperOrigin-RevId: 195365050 Change-Id: I8754dc7a3fc2975d422cae453762a455478a8e6a
259,992
04.05.2018 01:23:43
25,200
7e82550bf7a383d0aa3b3c4c8107bc32816ca5d5
Add github bug template
[ { "change_type": "ADD", "old_path": null, "new_path": ".github/issue_template.md", "diff": "+Before filling an issue, please consult our [FAQ](https://github.com/google/gvisor#faq--known-issues)\n+and check that the issue hasn't been [reported before](https://github.com/google/gvisor/issues).\n+\n+E...
Go
Apache License 2.0
google/gvisor
Add github bug template PiperOrigin-RevId: 195382309 Change-Id: I3e50206d137bb15c0532282ffbc3508aa5ddeb28
259,992
04.05.2018 09:38:35
25,200
c90fefc1161c58af34856aff7b7012f19f5d1f1b
Fix runsc capabilities There was a typo and one new capability missing from the list
[ { "change_type": "MODIFY", "old_path": "pkg/abi/linux/capability.go", "new_path": "pkg/abi/linux/capability.go", "diff": "@@ -32,7 +32,7 @@ const (\nCAP_SETPCAP = Capability(8)\nCAP_LINUX_IMMUTABLE = Capability(9)\nCAP_NET_BIND_SERVICE = Capability(10)\n- CAP_NET_BROAD_CAST = Capability(11)\n+ CAP_N...
Go
Apache License 2.0
google/gvisor
Fix runsc capabilities There was a typo and one new capability missing from the list PiperOrigin-RevId: 195427713 Change-Id: I6d9e1c6e77b48fe85ef10d9f54c70c8a7271f6e7
259,854
04.05.2018 11:25:36
25,200
f94d90073f3b54a219c687894e9d7ce7f5c4efc4
Add to the github issue template
[ { "change_type": "MODIFY", "old_path": ".github/issue_template.md", "new_path": ".github/issue_template.md", "diff": "Before filling an issue, please consult our [FAQ](https://github.com/google/gvisor#faq--known-issues)\nand check that the issue hasn't been [reported before](https://github.com/googl...
Go
Apache License 2.0
google/gvisor
Add to the github issue template PiperOrigin-RevId: 195444658 Change-Id: I62d12405324f9c80ec572c65d76c5f320a9b549e
259,881
04.05.2018 13:14:59
25,200
7bb10dc7a0499e20a37291d6f5fd105e6ae6fdbf
Disable stack protector in VDSO build The VDSO has no hooks to handle stack protector failures. Fixes
[ { "change_type": "MODIFY", "old_path": "vdso/BUILD", "new_path": "vdso/BUILD", "diff": "@@ -26,6 +26,9 @@ genrule(\n\"-O2 \" +\n\"-std=c++11 \" +\n\"-fPIC \" +\n+ # Some toolchains enable stack protector by default. Disable it, the\n+ # VDSO has no hooks to handle failures.\n+ \"-fno-stack-protector...
Go
Apache License 2.0
google/gvisor
Disable stack protector in VDSO build The VDSO has no hooks to handle stack protector failures. Fixes #9 PiperOrigin-RevId: 195460989 Change-Id: Idf1d55bfee1126e551d7274b7f484e03bf440427
259,948
04.05.2018 13:55:06
25,200
0ce9c81b416494e3c3da793c278dfc767341fa6d
sentry: capture CPU usage metadata for save.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/state/BUILD", "new_path": "pkg/sentry/state/BUILD", "diff": "@@ -7,10 +7,12 @@ go_library(\nsrcs = [\n\"state.go\",\n\"state_metadata.go\",\n+ \"state_unsafe.go\",\n],\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/sentry/state\",\nvisibility = ...
Go
Apache License 2.0
google/gvisor
sentry: capture CPU usage metadata for save. PiperOrigin-RevId: 195466647 Change-Id: Ib5ca815f7b64a4881441e58567adedf344b206f1
259,891
04.05.2018 16:21:38
25,200
d70787d340b3967fd691fbbd079dece329f7a65c
sentry: Adds the SIOCGIFNETMASK ioctl to epsocket.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/socket/epsocket/epsocket.go", "new_path": "pkg/sentry/socket/epsocket/epsocket.go", "diff": "@@ -1109,7 +1109,20 @@ func (s *SocketOperations) interfaceIoctl(ctx context.Context, io usermem.IO, ar\ncase syscall.SIOCGIFNETMASK:\n// Gets the network m...
Go
Apache License 2.0
google/gvisor
sentry: Adds the SIOCGIFNETMASK ioctl to epsocket. PiperOrigin-RevId: 195489319 Change-Id: I0841d41d042c6f91aa8d7f62c127213aa7953eac
259,854
04.05.2018 23:19:13
25,200
268edf0e6230c9455972c3343125d416a71a8759
Remove ineffectual code in sentry ELF loader
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/loader/elf.go", "new_path": "pkg/sentry/loader/elf.go", "diff": "@@ -408,11 +408,8 @@ func loadParsedELF(ctx context.Context, m *mm.MemoryManager, f *fs.File, info el\npath := make([]byte, phdr.Filesz)\n_, err := readFull(ctx, f, usermem.BytesIOSequ...
Go
Apache License 2.0
google/gvisor
Remove ineffectual code in sentry ELF loader PiperOrigin-RevId: 195517702 Change-Id: Id90309a6365cac06e68e8774aa79dc76ce1b11c7
259,881
05.05.2018 00:26:55
25,200
ebae2191622122a9d2fb321be65089bbb228a1e6
Note architecture and Linux version requirements
[ { "change_type": "MODIFY", "old_path": "README.md", "new_path": "README.md", "diff": "@@ -166,8 +166,11 @@ and Docker.\n### Requirements\n-gVisor currently can only build and run on Linux. In addition, the following\n-dependencies must be installed.\n+gVisor currently can only build and run on x86\\...
Go
Apache License 2.0
google/gvisor
Note architecture and Linux version requirements PiperOrigin-RevId: 195522238 Change-Id: I0107f856bea72ea6af8b196c1c13bafbc293ce95
259,854
05.05.2018 01:21:46
25,200
f0a17bf9103be7127588ce016ff5b0ab367ce5e7
Remove dead code in urpc
[ { "change_type": "MODIFY", "old_path": "pkg/urpc/urpc.go", "new_path": "pkg/urpc/urpc.go", "diff": "@@ -332,9 +332,6 @@ func (s *Server) clientBeginRequest(client *unet.Socket) bool {\n// Should not happen.\npanic(fmt.Sprintf(\"expected idle or closed, got %d\", state))\n}\n-\n- // Unreachable.\n- r...
Go
Apache License 2.0
google/gvisor
Remove dead code in urpc PiperOrigin-RevId: 195525267 Change-Id: I7a5ef31365cb0c55c462deb9bdbec092473ebc6b
259,992
07.05.2018 11:49:47
25,200
2c21e4c32c1746d1c6353fdd7dd98bb333f03ae2
Make bug template more readable in edit mode When editing the bug, the rendered view of the tags don't show up. This format is easier to read.
[ { "change_type": "MODIFY", "old_path": ".github/issue_template.md", "new_path": ".github/issue_template.md", "diff": "-Before filling an issue, please consult our [FAQ](https://github.com/google/gvisor#faq--known-issues)\n-and check that the issue hasn't been [reported before](https://github.com/goo...
Go
Apache License 2.0
google/gvisor
Make bug template more readable in edit mode When editing the bug, the rendered view of the tags don't show up. This format is easier to read. PiperOrigin-RevId: 195697019 Change-Id: If9bb818b7ecd28bb87608a52b3343d488144ebfd
259,854
07.05.2018 15:52:00
25,200
5666e35c43cadf834845359d009322e67f1e6a0d
Improve consistency of github templates
[ { "change_type": "MODIFY", "old_path": ".github/issue_template.md", "new_path": ".github/issue_template.md", "diff": "Before filling an issue, please consult our FAQ: https://github.com/google/gvisor#faq--known-issues\nAlso check that the issue hasn't been reported before.\n-If you have a question, ...
Go
Apache License 2.0
google/gvisor
Improve consistency of github templates PiperOrigin-RevId: 195735915 Change-Id: If4dcd836c3cf9da7c314b95101b23f95ff0eb234
259,854
07.05.2018 16:08:03
25,200
d5104a56e56ece50d3ec562edc31493516960c0c
Improve consistency in go_stateify file generation This also fixes the go_vet warning: error: Fprintln call ends with newline (vet)
[ { "change_type": "MODIFY", "old_path": "tools/go_stateify/main.go", "new_path": "tools/go_stateify/main.go", "diff": "@@ -222,9 +222,9 @@ func main() {\n}\n// Emit the package name.\n- fmt.Fprintf(outputFile, \"// automatically generated by stateify.\\n\\n\")\n+ fmt.Fprint(outputFile, \"// automatic...
Go
Apache License 2.0
google/gvisor
Improve consistency in go_stateify file generation This also fixes the go_vet warning: error: Fprintln call ends with newline (vet) PiperOrigin-RevId: 195738471 Change-Id: Ic7a9df40eec1457ef03e6ee70872c497a676b53c
260,011
07.05.2018 16:36:14
25,200
a445b17933d38ee6f9cea9138c6197a07387b462
tools/go_generics: fix typo in documentation of the type flag
[ { "change_type": "MODIFY", "old_path": "tools/go_generics/generics.go", "new_path": "tools/go_generics/generics.go", "diff": "//\n// would be renamed to:\n//\n-// fun f(arg *B)\n+// func f(arg *B)\n//\n// 2. Global type definitions and their method sets will be removed when they're\n// being renamed...
Go
Apache License 2.0
google/gvisor
tools/go_generics: fix typo in documentation of the type flag PiperOrigin-RevId: 195742471 Change-Id: I114657f9238675da23461817ca542bdcb81312c2
259,854
08.05.2018 09:38:55
25,200
d0d01a18963ed7cfc29e5b8334e30b1234b6048b
Fix format string type in test
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/kernel/fd_map_test.go", "new_path": "pkg/sentry/kernel/fd_map_test.go", "diff": "@@ -119,16 +119,18 @@ func TestDescriptorFlags(t *testing.T) {\nlimitSet := limits.NewLimitSet()\nlimitSet.Set(limits.NumberOfFiles, limits.Limit{maxFD, maxFD})\n- if e...
Go
Apache License 2.0
google/gvisor
Fix format string type in test PiperOrigin-RevId: 195831778 Change-Id: I413dc909cedc18fbf5320a4f75d876f1be133c6c
259,854
08.05.2018 09:51:07
25,200
b4765f782d91443ab0415dc00e727d783632e2ad
Fix warning: redundant if ...; err != nil check, just return error instead. This warning is produced by golint.
[ { "change_type": "MODIFY", "old_path": "pkg/bpf/decoder.go", "new_path": "pkg/bpf/decoder.go", "diff": "@@ -161,10 +161,7 @@ func decodeAlu(inst linux.BPFInstruction, w *bytes.Buffer) error {\ndefault:\nreturn fmt.Errorf(\"invalid BPF ALU instruction: %v\", inst)\n}\n- if err := decodeSource(inst, w...
Go
Apache License 2.0
google/gvisor
Fix warning: redundant if ...; err != nil check, just return error instead. This warning is produced by golint. PiperOrigin-RevId: 195833381 Change-Id: Idd6a7e57e3cfdf00819f2374b19fc113585dc1e1
259,854
08.05.2018 09:58:09
25,200
09c323910d7f28fec9e4c92e5faaa92bb63bd431
Reword misleading log line
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/loader/loader.go", "new_path": "pkg/sentry/loader/loader.go", "diff": "@@ -85,7 +85,7 @@ func openPath(ctx context.Context, mm *fs.MountNamespace, root, wd *fs.Dirent, m\n// No exec-ing directories, pipes, etc!\nif !fs.IsRegular(d.Inode.StableAttr) ...
Go
Apache License 2.0
google/gvisor
Reword misleading log line PiperOrigin-RevId: 195834310 Change-Id: I8af748f75ab87ad1cd29c4c8904d07fd729ba6c9
259,948
08.05.2018 10:06:14
25,200
fea624b37a90c0e1efc0c1e7ae7dda7b2d1a0050
Sentry: always use "best speed" compression for save and remove the option.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/state/state.go", "new_path": "pkg/sentry/state/state.go", "diff": "@@ -50,11 +50,6 @@ type SaveOpts struct {\n// Metadata is save metadata.\nMetadata map[string]string\n- // CompressionLevel is the compression level to use.\n- //\n- // See statefile...
Go
Apache License 2.0
google/gvisor
Sentry: always use "best speed" compression for save and remove the option. PiperOrigin-RevId: 195835861 Change-Id: Ib696b1b571a6b061725a33c535cd7215fe518b97
259,992
08.05.2018 10:33:20
25,200
e1b412d6609c848ff09356ead133b51cd0589731
Error if container requires AppArmor, SELinux or seccomp Closes
[ { "change_type": "MODIFY", "old_path": "runsc/sandbox/sandbox.go", "new_path": "runsc/sandbox/sandbox.go", "diff": "@@ -53,6 +53,22 @@ func validateID(id string) error {\nreturn nil\n}\n+func validateSpec(spec *specs.Spec) error {\n+ if spec.Process.SelinuxLabel != \"\" {\n+ return fmt.Errorf(\"SELi...
Go
Apache License 2.0
google/gvisor
Error if container requires AppArmor, SELinux or seccomp Closes #35 PiperOrigin-RevId: 195840128 Change-Id: I31c1ad9b51ec53abb6f0b485d35622d4e9764b29
259,885
08.05.2018 11:25:40
25,200
3ac3ea1d6afea0b128112e6a46b8bf47b4b0e02a
Correct definition of SysV IPC structures.
[ { "change_type": "MODIFY", "old_path": "pkg/abi/linux/ipc.go", "new_path": "pkg/abi/linux/ipc.go", "diff": "package linux\n-// Control commands used with semctl. Source: //include/uapi/linux/ipc.h.\n+// Control commands used with semctl, shmctl, and msgctl. Source:\n+// include/uapi/linux/ipc.h.\nco...
Go
Apache License 2.0
google/gvisor
Correct definition of SysV IPC structures. PiperOrigin-RevId: 195849066 Change-Id: If2146c7ce649522f86e661c5e52a9983345d6967
259,948
08.05.2018 11:36:11
25,200
174161013de22be6a42b02ee06611a9de9e20b18
Capture restore file system corruption errors in exit error.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/fdpipe/pipe_state.go", "new_path": "pkg/sentry/fs/fdpipe/pipe_state.go", "diff": "@@ -63,7 +63,7 @@ func (p *pipeOperations) loadFlags(flags fs.FileFlags) {\n// afterLoad is invoked by stateify.\nfunc (p *pipeOperations) afterLoad() {\n- load := ...
Go
Apache License 2.0
google/gvisor
Capture restore file system corruption errors in exit error. PiperOrigin-RevId: 195850822 Change-Id: I4d7bdd8fe129c5ed461b73e1d7458be2cf5680c2
259,885
08.05.2018 16:14:00
25,200
10a2cfc6a9216cb32e3a930016178d3c15ccc383
Implement /proc/[pid]/statm.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/proc/task.go", "new_path": "pkg/sentry/fs/proc/task.go", "diff": "@@ -81,6 +81,7 @@ func newTaskDir(t *kernel.Task, msrc *fs.MountSource, pidns *kernel.PIDNamespace\n\"mounts\": seqfile.NewSeqFileInode(t, &mountsFile{t: t}, msrc),\n\"ns\": newNam...
Go
Apache License 2.0
google/gvisor
Implement /proc/[pid]/statm. PiperOrigin-RevId: 195893391 Change-Id: I645b7042d7f4f9dd54723afde3e5df0986e43160
259,948
08.05.2018 17:23:06
25,200
ad278d69447ddca9c6923e5e830c12f1329438b9
state: serialize string as bytes instead of protobuf string. Protobuf strings have to be encoded or 7-bit ASCII.
[ { "change_type": "MODIFY", "old_path": "pkg/state/decode.go", "new_path": "pkg/state/decode.go", "diff": "@@ -335,7 +335,7 @@ func (ds *decodeState) decodeObject(os *objectState, obj reflect.Value, object *\ncase *pb.Object_BoolValue:\nobj.SetBool(x.BoolValue)\ncase *pb.Object_StringValue:\n- obj.Se...
Go
Apache License 2.0
google/gvisor
state: serialize string as bytes instead of protobuf string. Protobuf strings have to be UTF-8 encoded or 7-bit ASCII. PiperOrigin-RevId: 195902557 Change-Id: I9800afd47ecfa6615e28a2cce7f2532f04f10763
259,992
09.05.2018 15:43:47
25,200
4453b56bd92c4ab9c0480dd99e80c65994711d33
Increment link count in CreateHardlink Closes
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/gofer/path.go", "new_path": "pkg/sentry/fs/gofer/path.go", "diff": "@@ -150,8 +150,10 @@ func (i *inodeOperations) CreateHardLink(ctx context.Context, _ *fs.Inode, targe\nif err := i.fileState.file.link(ctx, &targetOpts.fileState.file, newName); ...
Go
Apache License 2.0
google/gvisor
Increment link count in CreateHardlink Closes #28 PiperOrigin-RevId: 196041391 Change-Id: I5d79f1735b9d72744e8bebc6897002b27df9aa7a
259,992
10.05.2018 12:37:46
25,200
5a509c47a20e0b81b95bb4932e8b19dfc6a402e2
Open file as read-write when mount points to a file This is to allow files mapped directly, like /etc/hosts, to be writable. Closes
[ { "change_type": "MODIFY", "old_path": "runsc/fsgofer/fsgofer.go", "new_path": "runsc/fsgofer/fsgofer.go", "diff": "@@ -98,7 +98,17 @@ func (a *attachPoint) Attach(appPath string) (p9.File, error) {\n}\nroot := filepath.Join(a.prefix, appPath)\n- f, err := os.OpenFile(root, openFlags|syscall.O_RDONL...
Go
Apache License 2.0
google/gvisor
Open file as read-write when mount points to a file This is to allow files mapped directly, like /etc/hosts, to be writable. Closes #40 PiperOrigin-RevId: 196155920 Change-Id: Id2027e421cef5f94a0951c3e18b398a77c285bbd
259,992
10.05.2018 12:46:27
25,200
31a4fefbe0a44377f75888284c9be0a3bec2a017
Make cachePolicy int to avoid string comparison
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/gofer/fs.go", "new_path": "pkg/sentry/fs/gofer/fs.go", "diff": "@@ -57,20 +57,26 @@ const (\n)\n// cachePolicy is a 9p cache policy.\n-type cachePolicy string\n+type cachePolicy int\nconst (\n- // Use virtual file system cache.\n- cacheAll cacheP...
Go
Apache License 2.0
google/gvisor
Make cachePolicy int to avoid string comparison PiperOrigin-RevId: 196157086 Change-Id: Ia7f7ffe1bf486b21ef8091e2e8ef9a9faf733dfc
259,992
10.05.2018 17:12:21
25,200
7cff8489de2254cf355ec81cebc2338e0035f2df
Fix failure to rename directory os.Rename validates that the target doesn't exist, which is different from syscall.Rename which replace the target if both are directories. fsgofer needs the syscall behavior.
[ { "change_type": "MODIFY", "old_path": "runsc/fsgofer/fsgofer.go", "new_path": "runsc/fsgofer/fsgofer.go", "diff": "@@ -708,7 +708,7 @@ func (l *localFile) Rename(directory p9.File, name string) error {\n// TODO: change to renameat(2)\nparent := directory.(*localFile)\nnewPath := path.Join(parent.ho...
Go
Apache License 2.0
google/gvisor
Fix failure to rename directory os.Rename validates that the target doesn't exist, which is different from syscall.Rename which replace the target if both are directories. fsgofer needs the syscall behavior. PiperOrigin-RevId: 196194630 Change-Id: I87d08cad88b5ef310b245cd91647c4f5194159d8
259,885
11.05.2018 11:16:57
25,200
12c161f27865d0e389cd593c669bd740d7f24692
Implement MAP_32BIT.
[ { "change_type": "MODIFY", "old_path": "pkg/abi/linux/mm.go", "new_path": "pkg/abi/linux/mm.go", "diff": "@@ -31,6 +31,7 @@ const (\nMAP_PRIVATE = 1 << 1\nMAP_FIXED = 1 << 4\nMAP_ANONYMOUS = 1 << 5\n+ MAP_32BIT = 1 << 6 // arch/x86/include/uapi/asm/mman.h\nMAP_GROWSDOWN = 1 << 8\nMAP_DENYWRITE = 1 <...
Go
Apache License 2.0
google/gvisor
Implement MAP_32BIT. PiperOrigin-RevId: 196281052 Change-Id: Ie620a0f983a1bf2570d0003d4754611879335c1c
259,881
11.05.2018 12:23:25
25,200
8deabbaae1fc45b042d551891080deef866dc0f8
Remove error return from AddressSpace.Release()
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/kernel/task_usermem.go", "new_path": "pkg/sentry/kernel/task_usermem.go", "diff": "@@ -39,9 +39,7 @@ func (t *Task) Activate() {\n// Deactivate relinquishes the task's active address space.\nfunc (t *Task) Deactivate() {\nif mm := t.MemoryManager();...
Go
Apache License 2.0
google/gvisor
Remove error return from AddressSpace.Release() PiperOrigin-RevId: 196291289 Change-Id: Ie3487be029850b0b410b82416750853a6c4a2b00
259,948
11.05.2018 16:20:01
25,200
85fd5d40ff78f7b7fd473e5215daba84a28977f3
netstack: release rcv lock after ping socket save is done.
[ { "change_type": "MODIFY", "old_path": "pkg/tcpip/transport/ping/endpoint.go", "new_path": "pkg/tcpip/transport/ping/endpoint.go", "diff": "@@ -52,7 +52,7 @@ type endpoint struct {\nrcvMu sync.Mutex `state:\"nosave\"`\nrcvReady bool\nrcvList pingPacketList\n- rcvBufSizeMax int\n+ rcvBufSizeMax int `...
Go
Apache License 2.0
google/gvisor
netstack: release rcv lock after ping socket save is done. PiperOrigin-RevId: 196324694 Change-Id: Ia3a48976433f21622eacb4a38fefe7143ca5e31b
259,948
11.05.2018 16:27:50
25,200
987f7841a6ad8b77fe6a41cb70323517a5d2ccd1
netstack: TCP connecting state endpoint save / restore support.
[ { "change_type": "MODIFY", "old_path": "pkg/tcpip/tcpip.go", "new_path": "pkg/tcpip/tcpip.go", "diff": "@@ -31,6 +31,9 @@ import (\n// Error represents an error in the netstack error space. Using a special type\n// ensures that errors outside of this space are not accidentally introduced.\n+//\n+// ...
Go
Apache License 2.0
google/gvisor
netstack: TCP connecting state endpoint save / restore support. PiperOrigin-RevId: 196325647 Change-Id: I850eb4a29b9c679da4db10eb164bbdf967690663
259,891
11.05.2018 17:18:56
25,200
08879266fef3a67fac1a77f1ea133c3ac75759dd
sentry: Adds canonical mode support.
[ { "change_type": "MODIFY", "old_path": "pkg/abi/linux/tty.go", "new_path": "pkg/abi/linux/tty.go", "diff": "package linux\n+import (\n+ \"unicode/utf8\"\n+)\n+\nconst (\n// NumControlCharacters is the number of control characters in Termios.\nNumControlCharacters = 19\n+ // disabledChar is used to i...
Go
Apache License 2.0
google/gvisor
sentry: Adds canonical mode support. PiperOrigin-RevId: 196331627 Change-Id: Ifef4485f8202c52481af317cedd52d2ef48cea6a
259,858
14.05.2018 20:26:35
25,200
17a0fa3af05dbb147cdd3d5ec898d31812a0ea66
Ignore spurious KVM emulation failures.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go", "new_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go", "diff": "@@ -105,7 +105,11 @@ func bluepillHandler(context unsafe.Pointer) {\ncase _KVM_EXIT_IO:\nthrow(\"I/O\")\ncase _KVM_EXIT_INTERNAL_ERROR:\n- throw(\"i...
Go
Apache License 2.0
google/gvisor
Ignore spurious KVM emulation failures. PiperOrigin-RevId: 196609789 Change-Id: Ie261eea3b7fa05b6c348ca93e229de26cbd4dc7d
259,858
14.05.2018 20:44:56
25,200
825e9ea8098d91e9770d27124717c08d1f5d2952
Simplify KVM host map handling.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/address_space.go", "new_path": "pkg/sentry/platform/kvm/address_space.go", "diff": "@@ -46,6 +46,8 @@ type addressSpace struct {\ndirtySet sync.Map\n// files contains files mapped in the host address space.\n+ //\n+ // See host_map.go f...
Go
Apache License 2.0
google/gvisor
Simplify KVM host map handling. PiperOrigin-RevId: 196611084 Change-Id: I6afa6b01e1dcd2aa9776dfc0f910874cc6b8d72c
259,858
14.05.2018 21:13:28
25,200
2ab754cff7b2d45e1d59798562e47317aa480ecf
Make KVM system call first check.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/machine_amd64.go", "new_path": "pkg/sentry/platform/kvm/machine_amd64.go", "diff": "@@ -111,8 +111,11 @@ func (c *vCPU) SwitchToUser(regs *syscall.PtraceRegs, fpState *byte, pt *pagetab\nvector = c.CPU.SwitchToUser(regs, fpState, pt, fl...
Go
Apache License 2.0
google/gvisor
Make KVM system call first check. PiperOrigin-RevId: 196613447 Change-Id: Ib76902896798f072c3031b0c5cf7b433718928b7
259,858
14.05.2018 21:39:31
25,200
ed02ac4f668ec41063cd51cbbd451baba9e9a6e7
Disable INVPCID check; it's not used.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/kvm_amd64_unsafe.go", "new_path": "pkg/sentry/platform/kvm/kvm_amd64_unsafe.go", "diff": "@@ -27,7 +27,6 @@ import (\nvar (\nrunDataSize int\nhasGuestPCID bool\n- hasGuestINVPCID bool\npagetablesOpts pagetables.Opts\ncpuidSupported = cp...
Go
Apache License 2.0
google/gvisor
Disable INVPCID check; it's not used. PiperOrigin-RevId: 196615029 Change-Id: Idfa383a9aee6a9397167a4231ce99d0b0e5b9912
259,992
15.05.2018 14:38:32
25,200
9889c29d6d26ba86b5e3590eac85bfb8393dd54e
Fix problem with sendfile(2) writing less data When the amount of data read is more than the amount written, sendfile would not adjust 'in file' position and would resume from the wrong location. Closes
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/syscalls/linux/sys_file.go", "new_path": "pkg/sentry/syscalls/linux/sys_file.go", "diff": "@@ -1929,8 +1929,16 @@ func Sendfile(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysc\n// If we don't have a provided offset.\n} else {\n// ...
Go
Apache License 2.0
google/gvisor
Fix problem with sendfile(2) writing less data When the amount of data read is more than the amount written, sendfile would not adjust 'in file' position and would resume from the wrong location. Closes #33 PiperOrigin-RevId: 196731287 Change-Id: Ia219895dd765016ed9e571fd5b366963c99afb27
259,858
15.05.2018 18:33:19
25,200
310a99228b9254ad3c09ecdaa66e5747be4f46c5
Simplify KVM state handling. This also removes the dependency on tmutex.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/BUILD", "new_path": "pkg/sentry/platform/kvm/BUILD", "diff": "@@ -51,6 +51,7 @@ go_library(\nvisibility = [\"//pkg/sentry:internal\"],\ndeps = [\n\"//pkg/abi/linux\",\n+ \"//pkg/atomicbitops\",\n\"//pkg/cpuid\",\n\"//pkg/log\",\n\"//pkg...
Go
Apache License 2.0
google/gvisor
Simplify KVM state handling. This also removes the dependency on tmutex. PiperOrigin-RevId: 196764317 Change-Id: I523fb67454318e1a2ca9da3a08e63bfa3c1eeed3
259,858
15.05.2018 22:20:36
25,200
00adea3a3f0f3501809901bdac1a01c543d5e116
Simplify KVM invalidation logic.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/BUILD", "new_path": "pkg/sentry/platform/kvm/BUILD", "diff": "@@ -27,6 +27,7 @@ go_library(\nname = \"kvm\",\nsrcs = [\n\"address_space.go\",\n+ \"address_space_unsafe.go\",\n\"bluepill.go\",\n\"bluepill_amd64.go\",\n\"bluepill_amd64.s\...
Go
Apache License 2.0
google/gvisor
Simplify KVM invalidation logic. PiperOrigin-RevId: 196780209 Change-Id: I89f39eec914ce54a7c6c4f28e1b6d5ff5a7dd38d
259,858
15.05.2018 22:43:52
25,200
4b7e4f3d3612dde08a37a040d5be92c37cd0ee57
Fix KVM EFAULT handling.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go", "new_path": "pkg/sentry/platform/kvm/bluepill_unsafe.go", "diff": "@@ -61,8 +61,9 @@ func bluepillHandler(context unsafe.Pointer) {\n}\nfor {\n- _, _, errno := syscall.RawSyscall(syscall.SYS_IOCTL, uintptr(c.fd), _K...
Go
Apache License 2.0
google/gvisor
Fix KVM EFAULT handling. PiperOrigin-RevId: 196781718 Change-Id: I889766eed871929cdc247c6b9aa634398adea9c9
260,013
16.05.2018 13:06:23
25,200
f295e26b8abe395eaf1d4bee9a792a79b34d156f
Release mutex in BidirectionalConnect to avoid deadlock. When doing a BidirectionalConnect we don't need to continue holding the ConnectingEndpoint's mutex when creating the NewConnectedEndpoint as it was held during the Connect. Additionally, we're not holding the baseEndpoint mutex while Unregistering an event.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/gofer/socket.go", "new_path": "pkg/sentry/fs/gofer/socket.go", "diff": "@@ -79,26 +79,33 @@ func (e *endpoint) BidirectionalConnect(ce unix.ConnectingEndpoint, returnConnec\n// No lock ordering required as only the ConnectingEndpoint has a mutex....
Go
Apache License 2.0
google/gvisor
Release mutex in BidirectionalConnect to avoid deadlock. When doing a BidirectionalConnect we don't need to continue holding the ConnectingEndpoint's mutex when creating the NewConnectedEndpoint as it was held during the Connect. Additionally, we're not holding the baseEndpoint mutex while Unregistering an event. PiperOrigin-RevId: 196875557 Change-Id: Ied4ceed89de883121c6cba81bc62aa3a8549b1e9
259,956
16.05.2018 14:53:57
25,200
8e1deb2ab8fb67da9a1f6521e31c5635ac587e71
Fix another socket Dirent refcount.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/socket/rpcinet/socket.go", "new_path": "pkg/sentry/socket/rpcinet/socket.go", "diff": "@@ -71,6 +71,7 @@ func newSocketFile(ctx context.Context, stack *Stack, family int, skType int, pr\nstack.notifier.AddFD(fd, &wq)\ndirent := socket.NewDirent(ctx,...
Go
Apache License 2.0
google/gvisor
Fix another socket Dirent refcount. PiperOrigin-RevId: 196893452 Change-Id: I5ea0f851fcabc5eac5859e61f15213323d996337
259,985
17.05.2018 15:37:19
25,200
b904250b862c5c14da84e08b6a5400c7bf2458b0
Fix capability check for sysv semaphores. Capabilities for sysv sem operations were being checked against the current task's user namespace. They should be checked against the user namespace owning the ipc namespace for the sems instead, per ipc/util.c:ipcperms().
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/kernel/ipc_namespace.go", "new_path": "pkg/sentry/kernel/ipc_namespace.go", "diff": "@@ -33,7 +33,7 @@ type IPCNamespace struct {\nfunc NewIPCNamespace(userNS *auth.UserNamespace) *IPCNamespace {\nreturn &IPCNamespace{\nuserNS: userNS,\n- semaphores...
Go
Apache License 2.0
google/gvisor
Fix capability check for sysv semaphores. Capabilities for sysv sem operations were being checked against the current task's user namespace. They should be checked against the user namespace owning the ipc namespace for the sems instead, per ipc/util.c:ipcperms(). PiperOrigin-RevId: 197063111 Change-Id: Iba29486b316f2e01ee331dda4e48a6ab7960d589
259,881
17.05.2018 16:25:51
25,200
b960559fdb9a22c986af11ba4e886ffb316a3574
Cleanup docs This brings the proc document more up-to-date.
[ { "change_type": "MODIFY", "old_path": "pkg/sentry/fs/proc/README.md", "new_path": "pkg/sentry/fs/proc/README.md", "diff": "@@ -11,15 +11,14 @@ inconsistency, please file a bug.\nThe following files are implemented:\n| File /proc/ | Content |\n-| :------------------------ | :------------------------...
Go
Apache License 2.0
google/gvisor
Cleanup docs This brings the proc document more up-to-date. PiperOrigin-RevId: 197070161 Change-Id: Iae2cf9dc44e3e748a33f497bb95bd3c10d0c094a