author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,992 | 02.07.2018 12:50:37 | 25,200 | fa64c2a1517d20c08447bb2230f2903ec3baade9 | Make default limits the same as with runc
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/limits.go",
"new_path": "runsc/boot/limits.go",
"diff": "@@ -23,29 +23,50 @@ import (\n// Mapping from linux resource names to limits.LimitType.\nvar fromLinuxResource = map[string]limits.LimitType{\n+ \"RLIMIT_AS\": limits.AS,\n+ \"RLIMIT_CORE\": l... | Go | Apache License 2.0 | google/gvisor | Make default limits the same as with runc
Closes #2
PiperOrigin-RevId: 202997196
Change-Id: I0c9f6f5a8a1abe1ae427bca5f590bdf9f82a6675 |
259,881 | 02.07.2018 17:38:01 | 25,200 | 2821dfe6ce95ad32bb0084cb3b2335bf7b31de7a | Hold d.parent.mu when reading d.name | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -1342,7 +1342,15 @@ func (d *Dirent) InotifyEvent(events, cookie uint32) {\n// The ordering below is important, Linux always notifies the parent first.\nif d.parent != nil {\n- d.pare... | Go | Apache License 2.0 | google/gvisor | Hold d.parent.mu when reading d.name
PiperOrigin-RevId: 203041657
Change-Id: I120783d91712818e600505454c9276f8d9877f37 |
259,881 | 03.07.2018 11:27:29 | 25,200 | 062a6f6ec5f4bf2ce46790a22d8e7278d51e6836 | Handle NUL-only paths in exec
The path in execve(2), interpreter script, and ELF interpreter may all
be no more than a NUL-byte. Handle each of those cases. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -405,6 +405,10 @@ func loadParsedELF(ctx context.Context, m *mm.MemoryManager, f *fs.File, info el\n}\ncase elf.PT_INTERP:\n+ if phdr.Filesz < 2 {\n+ ctx.Infof(\"PT_INTERP path too ... | Go | Apache License 2.0 | google/gvisor | Handle NUL-only paths in exec
The path in execve(2), interpreter script, and ELF interpreter may all
be no more than a NUL-byte. Handle each of those cases.
PiperOrigin-RevId: 203155745
Change-Id: I1c8b1b387924b23b2cf942341dfc76c9003da959 |
259,992 | 03.07.2018 11:33:20 | 25,200 | c1b4c1ffee850aea2880f5f91a1e48e840933c71 | Fix flaky image_test
Some failures were being ignored in run_tests.sh
Give more time for mysql to setup
Fix typo with network=host tests
Change httpd test to wait on http server being available, not only output | [
{
"change_type": "MODIFY",
"old_path": "kokoro/gcp_ubuntu/run_tests.sh",
"new_path": "kokoro/gcp_ubuntu/run_tests.sh",
"diff": "@@ -44,12 +44,15 @@ bazel test --test_output=errors //...\nexit_code=${?}\nif [[ ${exit_code} -eq 0 ]]; then\n+ declare -a variations=(\"\" \"-kvm\" \"-hostnet\" \"-overlay... | Go | Apache License 2.0 | google/gvisor | Fix flaky image_test
- Some failures were being ignored in run_tests.sh
- Give more time for mysql to setup
- Fix typo with network=host tests
- Change httpd test to wait on http server being available, not only output
PiperOrigin-RevId: 203156896
Change-Id: Ie1801dcd76e9b5fe4722c4d8695c76e40988dd74 |
259,992 | 03.07.2018 12:00:09 | 25,200 | 52ddb8571c466577843d8eb1c5e270dd54f1ade6 | Skip overlay on root when its readonly | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -207,7 +207,7 @@ func createRootMount(ctx context.Context, spec *specs.Spec, conf *Config, fds *f\nreturn nil, fmt.Errorf(\"error adding submount overlay: %v\", err)\n}\n- if conf.Overlay {\n+ if c... | Go | Apache License 2.0 | google/gvisor | Skip overlay on root when its readonly
PiperOrigin-RevId: 203161098
Change-Id: Ia1904420cb3ee830899d24a4fe418bba6533be64 |
259,881 | 03.07.2018 12:52:39 | 25,200 | 660f1203ff1949a7b7869b801f4aa2133d30b91f | Fix runsc VDSO mapping
accidentally moved vdso into an
inner scope, never assigning the vdso variable passed to the Kernel and
thus skipping VDSO mappings.
Fix this and remove the ability for loadVDSO to skip VDSO mappings,
since tests that do so are gone. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/vdso.go",
"new_path": "pkg/sentry/loader/vdso.go",
"diff": "@@ -278,12 +278,6 @@ func PrepareVDSO(p platform.Platform) (*VDSO, error) {\n//\n// loadVDSO takes a reference on the VDSO and parameter page FrameRegions.\nfunc loadVDSO(ctx context... | Go | Apache License 2.0 | google/gvisor | Fix runsc VDSO mapping
80bdf8a4068de3ac4a73b6b61a0cdcfe3e3571af accidentally moved vdso into an
inner scope, never assigning the vdso variable passed to the Kernel and
thus skipping VDSO mappings.
Fix this and remove the ability for loadVDSO to skip VDSO mappings,
since tests that do so are gone.
PiperOrigin-RevId: ... |
259,985 | 03.07.2018 14:07:43 | 25,200 | 34af9a61741f26be403231ec302b4e0795147906 | Fix data race on inotify.Watch.mask. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/inotify.go",
"new_path": "pkg/sentry/fs/inotify.go",
"diff": "@@ -16,6 +16,7 @@ package fs\nimport (\n\"sync\"\n+ \"sync/atomic\"\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n\"gvisor.googlesource.com/gvisor/pkg/ilist\"\n@@ -279,13 +280,13 ... | Go | Apache License 2.0 | google/gvisor | Fix data race on inotify.Watch.mask.
PiperOrigin-RevId: 203180463
Change-Id: Ief50988c1c028f81ec07a26e704d893e86985bf0 |
259,991 | 06.07.2018 09:37:32 | 25,200 | f107a5b1a0e264d518617c57f0cf310b63e8b59c | Tests pause and resume functionality on a Python container. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/BUILD",
"new_path": "runsc/test/image/BUILD",
"diff": "@@ -5,7 +5,10 @@ load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\")\ngo_test(\nname = \"image_test\",\nsize = \"large\",\n- srcs = [\"image_test.go\"],\n+ srcs = [\n+ \"... | Go | Apache License 2.0 | google/gvisor | Tests pause and resume functionality on a Python container.
PiperOrigin-RevId: 203488336
Change-Id: I55e1b646f1fae73c27a49e064875d55f5605b200 |
259,854 | 06.07.2018 10:57:37 | 25,200 | 5c88e6a15d46bba6237a44d98c4e172237c9aea3 | Add non-AMD64 support to rawfile | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/rawfile/BUILD",
"new_path": "pkg/tcpip/link/rawfile/BUILD",
"diff": "@@ -6,6 +6,8 @@ go_library(\nname = \"rawfile\",\nsrcs = [\n\"blockingpoll_amd64.s\",\n+ \"blockingpoll_unsafe.go\",\n+ \"blockingpoll_unsafe_amd64.go\",\n\"errors.go\",\n\"raw... | Go | Apache License 2.0 | google/gvisor | Add non-AMD64 support to rawfile
PiperOrigin-RevId: 203499064
Change-Id: I2cd5189638e94ce926f1e82c1264a8d3ece9dfa5 |
259,881 | 09.07.2018 11:43:06 | 25,200 | 0dedac637ff9f6f7a0556d42d90787584a4051da | Trim all whitespace between interpreter and arg
Multiple whitespace characters are allowed. This fixes Ubuntu's
/usr/sbin/invoke-rc.d, which has trailing whitespace after the
interpreter which we were treating as an arg. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/interpreter.go",
"new_path": "pkg/sentry/loader/interpreter.go",
"diff": "@@ -66,7 +66,7 @@ func parseInterpreterScript(ctx context.Context, filename string, f *fs.File, ar\n// Skip any whitespace before the interpeter.\nline = bytes.TrimLeft... | Go | Apache License 2.0 | google/gvisor | Trim all whitespace between interpreter and arg
Multiple whitespace characters are allowed. This fixes Ubuntu's
/usr/sbin/invoke-rc.d, which has trailing whitespace after the
interpreter which we were treating as an arg.
PiperOrigin-RevId: 203802278
Change-Id: I0a6cdb0af4b139cf8abb22fa70351fe3697a5c6b |
259,885 | 09.07.2018 16:15:14 | 25,200 | 41aeb680b1882c9416e25e100b5ff5eebead36de | Inherit parent in clone(CLONE_THREAD) under TaskSet.mu. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_clone.go",
"new_path": "pkg/sentry/kernel/task_clone.go",
"diff": "@@ -220,18 +220,15 @@ func (t *Task) Clone(opts *CloneOptions) (ThreadID, *SyscallControl, error) {\npidns = pidns.NewChild(userns)\n}\ntg := t.tg\n- parent := t.parent\n... | Go | Apache License 2.0 | google/gvisor | Inherit parent in clone(CLONE_THREAD) under TaskSet.mu.
PiperOrigin-RevId: 203849534
Change-Id: I4d81513bfd32e0b7fc40c8a4c194eba7abc35a83 |
260,013 | 09.07.2018 20:47:32 | 25,200 | da9b5153f2fafab1597b34336f8a95c1b861f0ac | Fix two race conditions in tcp stack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -949,9 +949,10 @@ func (e *endpoint) protocolMainLoop(passive bool) *tcpip.Error {\n}\nif n¬ifyReset != 0 {\n+ e.mu.Lock()\ne.resetConnectionLocked(tcpip.ErrC... | Go | Apache License 2.0 | google/gvisor | Fix two race conditions in tcp stack.
PiperOrigin-RevId: 203880278
Change-Id: I66b790a616de59142859cc12db4781b57ea626d3 |
259,854 | 09.07.2018 21:19:58 | 25,200 | afd655a5d8b9d9bc747ee99b1ec2475cc526c996 | Notify UDP and Ping endpoints on close | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/ping/endpoint.go",
"new_path": "pkg/tcpip/transport/ping/endpoint.go",
"diff": "@@ -92,7 +92,6 @@ func newEndpoint(stack *stack.Stack, netProto tcpip.NetworkProtocolNumber, waite\n// associated with it.\nfunc (e *endpoint) Close() {\ne.mu.L... | Go | Apache License 2.0 | google/gvisor | Notify UDP and Ping endpoints on close
PiperOrigin-RevId: 203883138
Change-Id: I7500c0a70f5d71c3fb37e2477f7fc466fa92fd3e |
259,948 | 10.07.2018 13:53:39 | 25,200 | bf580cf64dbea1c70a3269914fad6490f7a4968d | netstack: only do connected TCP S/R for loopback connections. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/loopback/loopback.go",
"new_path": "pkg/tcpip/link/loopback/loopback.go",
"diff": "@@ -56,7 +56,7 @@ func (*endpoint) MTU() uint32 {\n// Capabilities implements stack.LinkEndpoint.Capabilities. Loopback advertises\n// itself as supporting checks... | Go | Apache License 2.0 | google/gvisor | netstack: only do connected TCP S/R for loopback connections.
PiperOrigin-RevId: 204006237
Change-Id: Ica8402ab54d9dd7d11cc41c6d74aacef51d140b7 |
259,885 | 10.07.2018 13:58:00 | 25,200 | 06920b3d1bb6346a20aa0e154b14e68116919dbc | Exit tmpfs.fileInodeOperations.Translate early if required.Start >= EOF.
Otherwise required and optional can be empty or have negative length. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tmpfs/inode_file.go",
"new_path": "pkg/sentry/fs/tmpfs/inode_file.go",
"diff": "@@ -451,9 +451,12 @@ func (f *fileInodeOperations) Translate(ctx context.Context, required, optional\n// Constrain translations to f.attr.Unstable.Size (rounded up) t... | Go | Apache License 2.0 | google/gvisor | Exit tmpfs.fileInodeOperations.Translate early if required.Start >= EOF.
Otherwise required and optional can be empty or have negative length.
PiperOrigin-RevId: 204007079
Change-Id: I59e472a87a8caac11ffb9a914b8d79bf0cd70995 |
259,991 | 11.07.2018 09:36:20 | 25,200 | 81ae5f3df533d5e5990baaa105392f59e28d5730 | Created runsc and docker integration tests.
Moved some of the docker image functions to testutil.go.
Test runsc commands create, start, stop, pause, and resume. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/image_test.go",
"new_path": "runsc/test/image/image_test.go",
"diff": "// Package image provides end-to-end image tests for runsc. These tests require\n// docker and runsc to be installed on the machine. To set it up, run:\n//\n-// ./runsc/tes... | Go | Apache License 2.0 | google/gvisor | Created runsc and docker integration tests.
Moved some of the docker image functions to testutil.go.
Test runsc commands create, start, stop, pause, and resume.
PiperOrigin-RevId: 204138452
Change-Id: Id00bc58d2ad230db5e9e905eed942187e68e7c7b |
259,885 | 11.07.2018 11:51:05 | 25,200 | ee0ef506d4060eaf0736997a56fd8490e2434495 | Add MemoryManager.Pin. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/pma.go",
"new_path": "pkg/sentry/mm/pma.go",
"diff": "@@ -578,6 +578,96 @@ func (mm *MemoryManager) invalidateLocked(ar usermem.AddrRange, invalidatePrivat\n}\n}\n+// Pin returns the platform.File ranges currently mapped by addresses in ar in\n+/... | Go | Apache License 2.0 | google/gvisor | Add MemoryManager.Pin.
PiperOrigin-RevId: 204162313
Change-Id: Ib0593dde88ac33e222c12d0dca6733ef1f1035dc |
259,885 | 11.07.2018 14:23:17 | 25,200 | b9c469f37282129031a6036cfe43028faaeb1a96 | Move ptrace constants to abi/linux. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -48,6 +48,7 @@ go_library(\n\"netlink_route.go\",\n\"poll.go\",\n\"prctl.go\",\n+ \"ptrace.go\",\n\"rusage.go\",\n\"sched.go\",\n\"seccomp.go\",\n"
},
{
"change_type": "ADD",
"old... | Go | Apache License 2.0 | google/gvisor | Move ptrace constants to abi/linux.
PiperOrigin-RevId: 204188763
Change-Id: I5596ab7abb3ec9e210a7f57b3fc420e836fa43f3 |
259,948 | 12.07.2018 13:38:26 | 25,200 | cc34a90fb46348fd4588d4191ddba0a1d27c1132 | netstack: do not defer panicable logic in tcp main loop. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -828,7 +828,7 @@ func (e *endpoint) protocolMainLoop(handshake bool) *tcpip.Error {\nvar closeTimer *time.Timer\nvar closeWaker sleep.Waker\n- defer func() {\n+ ... | Go | Apache License 2.0 | google/gvisor | netstack: do not defer panicable logic in tcp main loop.
PiperOrigin-RevId: 204355026
Change-Id: I1a8229879ea3b58aa861a4eb4456fd7aff99863d |
259,948 | 12.07.2018 13:48:18 | 25,200 | 45c50eb12436bcc477a0fbc2616bfd664a07c43f | netstack: save tcp endpoint accepted channel directly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/endpoint.go",
"new_path": "pkg/tcpip/transport/tcp/endpoint.go",
"diff": "@@ -206,11 +206,7 @@ type endpoint struct {\n// acceptedChan is used by a listening endpoint protocol goroutine to\n// send newly accepted connections to the endp... | Go | Apache License 2.0 | google/gvisor | netstack: save tcp endpoint accepted channel directly.
PiperOrigin-RevId: 204356873
Change-Id: I5e2f885f58678e693aae1a69e8bf8084a685af28 |
259,948 | 12.07.2018 14:18:11 | 25,200 | bb41ad808a75b8a945d82df51f0e322d98edf951 | sentry: save inet stacks in proc files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -55,7 +55,7 @@ func (p *proc) newNetDir(ctx context.Context, msrc *fs.MountSource) *fs.Inode {\n// ifinet6 implements seqfile.SeqSource for /proc/net/if_inet6.\ntype ifinet6 struc... | Go | Apache License 2.0 | google/gvisor | sentry: save inet stacks in proc files.
PiperOrigin-RevId: 204362791
Change-Id: If85ea7442741e299f0d7cddbc3d6b415e285da81 |
259,948 | 12.07.2018 15:07:59 | 25,200 | 1cd46c8dd1a92dd0ad3eeb60a763278f2e98d0b4 | sentry: wait for restore clock instead of panicing in Timekeeper. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/timekeeper.go",
"new_path": "pkg/sentry/kernel/timekeeper.go",
"diff": "@@ -44,14 +44,14 @@ type Timekeeper struct {\n// It is set only once, by SetClocks.\nmonotonicOffset int64 `state:\"nosave\"`\n- // restored indicates that this Timekeepe... | Go | Apache License 2.0 | google/gvisor | sentry: wait for restore clock instead of panicing in Timekeeper.
PiperOrigin-RevId: 204372296
Change-Id: If1ed9843b93039806e0c65521f30177dc8036979 |
259,881 | 12.07.2018 17:13:41 | 25,200 | a28b274abb3ac0ce652ee395d5a48e7b7fdfb3ad | Fix aio eventfd lookup
We're failing to set eventFile in the outer scope. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_aio.go",
"new_path": "pkg/sentry/syscalls/linux/sys_aio.go",
"diff": "@@ -300,7 +300,7 @@ func submitCallback(t *kernel.Task, id uint64, cb *ioCallback, cbAddr usermem.Ad\n// Was there an eventFD? Extract it.\nvar eventFile *fs.Fi... | Go | Apache License 2.0 | google/gvisor | Fix aio eventfd lookup
We're failing to set eventFile in the outer scope.
PiperOrigin-RevId: 204392995
Change-Id: Ib9b04f839599ef552d7b5951d08223e2b1d5f6ad |
259,881 | 13.07.2018 10:23:16 | 25,200 | f09ebd9c71eecdfb79f64b6abb26db3b66b8156b | Note that Mount errors do not require translations | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/filesystems.go",
"new_path": "pkg/sentry/fs/filesystems.go",
"diff": "@@ -48,6 +48,8 @@ type Filesystem interface {\n// Mount generates a mountable Inode backed by device and configured\n// using file system independent flags and file system depe... | Go | Apache License 2.0 | google/gvisor | Note that Mount errors do not require translations
PiperOrigin-RevId: 204490639
Change-Id: I0fe26306bae9320c6aa4f854fe0ef25eebd93233 |
260,008 | 13.07.2018 12:10:01 | 25,200 | 5b09ec3b890141959aa6a6a73b1ee4e26490c5cc | Allow a filesystem to control its visibility in /proc/filesystems. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dev/fs.go",
"new_path": "pkg/sentry/fs/dev/fs.go",
"diff": "@@ -49,6 +49,11 @@ func (*filesystem) AllowUserMount() bool {\nreturn true\n}\n+// AllowUserList allows this filesystem to be listed in /proc/filesystems.\n+func (*filesystem) AllowUserL... | Go | Apache License 2.0 | google/gvisor | Allow a filesystem to control its visibility in /proc/filesystems.
PiperOrigin-RevId: 204508520
Change-Id: I09e5f8b6e69413370e1a0d39dbb7dc1ee0b6192d |
260,008 | 16.07.2018 12:19:02 | 25,200 | 8f21c0bb2807888d812318def43c2405c9b13f5a | Add EventOperations.HostFD()
This method allows an eventfd inside the Sentry to be registered with with
the host kernel.
Update comment about memory mapping host fds via CachingInodeOperations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -30,6 +30,7 @@ go_library(\n\"dev.go\",\n\"elf.go\",\n\"errors.go\",\n+ \"eventfd.go\",\n\"exec.go\",\n\"fcntl.go\",\n\"file.go\",\n"
},
{
"change_type": "ADD",
"old_path": null,
... | Go | Apache License 2.0 | google/gvisor | Add EventOperations.HostFD()
This method allows an eventfd inside the Sentry to be registered with with
the host kernel.
Update comment about memory mapping host fds via CachingInodeOperations.
PiperOrigin-RevId: 204784859
Change-Id: I55823321e2d84c17ae0f7efaabc6b55b852ae257 |
259,858 | 16.07.2018 22:02:03 | 25,200 | 29e00c943a61dfcfd4ac8d3f6f526eab641c44a6 | Add CPUID faulting for ptrace and KVM. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/prctl.go",
"new_path": "pkg/abi/linux/prctl.go",
"diff": "@@ -69,4 +69,5 @@ const (\nARCH_SET_FS = 0x1002\nARCH_GET_FS = 0x1003\nARCH_GET_GS = 0x1004\n+ ARCH_SET_CPUID = 0x1012\n)\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/sent... | Go | Apache License 2.0 | google/gvisor | Add CPUID faulting for ptrace and KVM.
PiperOrigin-RevId: 204858314
Change-Id: I8252bf8de3232a7a27af51076139b585e73276d4 |
259,948 | 17.07.2018 10:13:57 | 25,200 | beb89bb75749620969b0e1dea65240bf5d4324b2 | netstack: update goroutine save / restore safety comments. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -108,7 +108,10 @@ func New(opts *Options) tcpip.LinkEndpointID {\n// dispatches them via the provided dispatcher.\nfunc (e *endpoint) Attach(dispatcher stack.Net... | Go | Apache License 2.0 | google/gvisor | netstack: update goroutine save / restore safety comments.
PiperOrigin-RevId: 204930314
Change-Id: Ifc4c41ed28616cd57fafbf7c92e87141a945c41f |
260,008 | 17.07.2018 10:50:02 | 25,200 | ed2e03d3780b8d96b189c1311c92b9db2fbcb35a | Add API to decode 'stat.st_rdev' into major and minor numbers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/dev.go",
"new_path": "pkg/abi/linux/dev.go",
"diff": "@@ -25,6 +25,13 @@ func MakeDeviceID(major uint16, minor uint32) uint32 {\nreturn (minor & 0xff) | ((uint32(major) & 0xfff) << 8) | ((minor >> 8) << 20)\n}\n+// DecodeDeviceID decodes a device... | Go | Apache License 2.0 | google/gvisor | Add API to decode 'stat.st_rdev' into major and minor numbers.
PiperOrigin-RevId: 204936533
Change-Id: Ib060920077fc914f97c4a0548a176d1368510c7b |
259,948 | 19.07.2018 09:36:34 | 25,200 | a95640b1e9fb8c3751c54c80f6c04f0dff233aed | sentry: save stack in proc net dev. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/net.go",
"new_path": "pkg/sentry/fs/proc/net.go",
"diff": "@@ -109,7 +109,7 @@ func (n *ifinet6) ReadSeqFileData(ctx context.Context, h seqfile.SeqHandle) ([]s\n// netDev implements seqfile.SeqSource for /proc/net/dev.\ntype netDev struct {\... | Go | Apache License 2.0 | google/gvisor | sentry: save stack in proc net dev.
PiperOrigin-RevId: 205253858
Change-Id: Iccdc493b66d1b4d39de44afb1184952183b1283f |
260,013 | 19.07.2018 12:41:00 | 25,200 | df5a5d388e1fc3349ee70c3476fdffb195fbce9c | Add AT_UID, AT_EUID, AT_GID, AT_EGID to aux vector.
With musl libc when these entries are missing from the aux vector
it's forcing libc.secure (effectively AT_SECURE). This mode prevents
RPATH and LD_LIBRARY_PATH from working.
As the first entry is a mask of all the aux fields set: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/BUILD",
"new_path": "pkg/sentry/loader/BUILD",
"diff": "@@ -46,6 +46,7 @@ go_library(\n\"//pkg/sentry/fs\",\n\"//pkg/sentry/fs/anon\",\n\"//pkg/sentry/fs/fsutil\",\n+ \"//pkg/sentry/kernel/auth\",\n\"//pkg/sentry/limits\",\n\"//pkg/sentry/mem... | Go | Apache License 2.0 | google/gvisor | Add AT_UID, AT_EUID, AT_GID, AT_EGID to aux vector.
With musl libc when these entries are missing from the aux vector
it's forcing libc.secure (effectively AT_SECURE). This mode prevents
RPATH and LD_LIBRARY_PATH from working.
https://git.musl-libc.org/cgit/musl/tree/ldso/dynlink.c#n1488
As the first entry is a mask ... |
259,858 | 19.07.2018 15:48:08 | 25,200 | 8b8aad91d581ee5f600f5ec0b7fb407b36d07db1 | kernel: mutations on creds now require a copy. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fasync/fasync.go",
"new_path": "pkg/sentry/kernel/fasync/fasync.go",
"diff": "@@ -35,7 +35,7 @@ func New() fs.FileAsync {\ntype FileAsync struct {\nmu sync.Mutex\ne waiter.Entry\n- requester auth.Credentials\n+ requester *auth.Credentials\n//... | Go | Apache License 2.0 | google/gvisor | kernel: mutations on creds now require a copy.
PiperOrigin-RevId: 205315612
Change-Id: I9a0a1e32c8abfb7467a38743b82449cc92830316 |
259,881 | 20.07.2018 12:58:59 | 25,200 | 5f134b3c0a08c0e170aa50ad3342df59832b4356 | Format getcwd path | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64.go",
"new_path": "pkg/sentry/strace/linux64.go",
"diff": "@@ -96,7 +96,7 @@ var linuxAMD64 = SyscallMap{\n76: makeSyscallInfo(\"truncate\", Path, Hex),\n77: makeSyscallInfo(\"ftruncate\", Hex, Hex),\n78: makeSyscallInfo(\"getdents\", ... | Go | Apache License 2.0 | google/gvisor | Format getcwd path
PiperOrigin-RevId: 205440332
Change-Id: I2a838f363e079164c83da88e1b0b8769844fe79b |
259,991 | 20.07.2018 16:17:00 | 25,200 | f543ada15005e6e2d31a63148a74fbdc43d070de | Removed a now incorrect reference to restoreFile. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -54,8 +54,6 @@ type Sandbox struct {\n}\n// Create creates the sandbox process.\n-//\n-// If restoreFile is not empty, the sandbox will be restored from file.\nfunc Create(id string... | Go | Apache License 2.0 | google/gvisor | Removed a now incorrect reference to restoreFile.
PiperOrigin-RevId: 205470108
Change-Id: I226878a887fe1133561005357a9e3b09428b06b6 |
259,992 | 23.07.2018 13:30:29 | 25,200 | d7a34790a0cc3cfdef9d9e54f17c4bc0a6819900 | Add KVM and overlay dimensions to container_test | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/kvm.go",
"new_path": "pkg/sentry/platform/kvm/kvm.go",
"diff": "@@ -66,7 +66,7 @@ func New() (*KVM, error) {\nring0.Init(cpuid.HostFeatureSet())\n})\nif globalErr != nil {\n- return nil, err\n+ return nil, globalErr\n}\n// Create a new ... | Go | Apache License 2.0 | google/gvisor | Add KVM and overlay dimensions to container_test
PiperOrigin-RevId: 205714667
Change-Id: I317a2ca98ac3bdad97c4790fcc61b004757d99ef |
259,991 | 23.07.2018 13:54:33 | 25,200 | b5113574feb79b2266d603aa760a9df468725d87 | Created a docker integration test for a tomcat image. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/BUILD",
"new_path": "runsc/test/image/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_test(\nsrcs = [\n\"image_test.go\",\n\"python_test.go\",\n+ \"tomcat_test.go\",\n],\ndata = [\n\"latin10k.txt\",\n"
},
{
"change_type": "ADD",
"old_path": nu... | Go | Apache License 2.0 | google/gvisor | Created a docker integration test for a tomcat image.
PiperOrigin-RevId: 205718733
Change-Id: I200b23af064d256f157baf9da5005ab16cc55928 |
259,962 | 23.07.2018 15:14:19 | 25,200 | da48c04d0df4bb044624cc3e7003ab3e973336de | Refactor new reno congestion control logic out of sender.
This CL also puts the congestion control logic behind an
interface so that we can easily swap it out for say CUBIC
in the future. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/BUILD",
"new_path": "pkg/tcpip/transport/tcp/BUILD",
"diff": "@@ -10,6 +10,7 @@ go_stateify(\n\"endpoint.go\",\n\"endpoint_state.go\",\n\"rcv.go\",\n+ \"reno.go\",\n\"segment.go\",\n\"segment_heap.go\",\n\"segment_queue.go\",\n@@ -44,6 ... | Go | Apache License 2.0 | google/gvisor | Refactor new reno congestion control logic out of sender.
This CL also puts the congestion control logic behind an
interface so that we can easily swap it out for say CUBIC
in the future.
PiperOrigin-RevId: 205732848
Change-Id: I891cdfd17d4d126b658b5faa0c6bd6083187944b |
259,881 | 25.07.2018 11:05:59 | 25,200 | 7cd9405b9cc112ebe352af0e5f13b7b57628001b | Format openat flags | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/strace/linux64.go",
"new_path": "pkg/sentry/strace/linux64.go",
"diff": "@@ -274,7 +274,7 @@ var linuxAMD64 = SyscallMap{\n254: makeSyscallInfo(\"inotify_add_watch\", Hex, Hex, Hex),\n255: makeSyscallInfo(\"inotify_rm_watch\", Hex, Hex),\n256: makeS... | Go | Apache License 2.0 | google/gvisor | Format openat flags
PiperOrigin-RevId: 206021774
Change-Id: I447b6c751c28a8d8d4d78468b756b6ad8c61e169 |
259,992 | 25.07.2018 17:36:52 | 25,200 | e5adf42f66a3090f6124bceb5487238bf7526302 | Replace sleeps with waits in tests - part I | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -122,18 +122,24 @@ func createWriteableOutputFile(path string) (*os.File, error) {\nreturn outputFile, nil\n}\n-func readOutputNum(f *os.File, first bool) (int, er... | Go | Apache License 2.0 | google/gvisor | Replace sleeps with waits in tests - part I
PiperOrigin-RevId: 206084473
Change-Id: I44e1b64b9cdd2964357799dca27cc0cbc19ce07d |
259,992 | 27.07.2018 10:08:59 | 25,200 | b8f96a9d0b9868060025e7a89e99e1b30d17fa8b | Replace sleeps with waits in tests - part II | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -673,11 +673,26 @@ func TestCheckpointRestore(t *testing.T) {\n// It will then unpause and confirm that both processes are running. Then it will\n// wait until one... | Go | Apache License 2.0 | google/gvisor | Replace sleeps with waits in tests - part II
PiperOrigin-RevId: 206333130
Change-Id: Ic85874dbd53c5de2164a7bb75769d52d43666c2a |
259,991 | 27.07.2018 12:26:42 | 25,200 | 2793f7ac5f96b474decfff68cfde86bb5c2ed0a4 | Added the O_LARGEFILE flag.
This flag will always be true for gVisor files. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/fcntl.go",
"new_path": "pkg/abi/linux/fcntl.go",
"diff": "@@ -27,3 +27,8 @@ const (\nF_SETLKW = 7\nF_SETOWN = 8\n)\n+\n+// Flags for fcntl.\n+const (\n+ FD_CLOEXEC = 00000001\n+)\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/abi/l... | Go | Apache License 2.0 | google/gvisor | Added the O_LARGEFILE flag.
This flag will always be true for gVisor files.
PiperOrigin-RevId: 206355963
Change-Id: I2f03d2412e2609042df43b06d1318cba674574d0 |
259,858 | 27.07.2018 17:52:21 | 25,200 | 3c673659998ecf51a22025886c92cd2d161d85e9 | Simplify Kokoro configuration. | [
{
"change_type": "RENAME",
"old_path": "kokoro/gcp_ubuntu/continuous.cfg",
"new_path": "kokoro/continuous.cfg",
"diff": "# Location of bash script that runs the test. The first directory in the path\n# is the directory where Kokoro will check out the repo. The rest is the path\n# is the path to the ... | Go | Apache License 2.0 | google/gvisor | Simplify Kokoro configuration.
PiperOrigin-RevId: 206401009
Change-Id: I26644d1fe637b5a40db013fedf9fc063cc87ce6a |
259,948 | 30.07.2018 15:42:01 | 25,200 | 0a55f8c1c11dc6d2dfb1bed02489f92bab437ea1 | netstack: support disconnect-on-save option per fdbased link. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -69,6 +69,8 @@ type Options struct {\nChecksumOffload bool\nClosedFunc func(*tcpip.Error)\nAddress tcpip.LinkAddress\n+ SaveRestore bool\n+ DisconnectOk bool\n}\... | Go | Apache License 2.0 | google/gvisor | netstack: support disconnect-on-save option per fdbased link.
PiperOrigin-RevId: 206659972
Change-Id: I5e0e035f97743b6525ad36bed2c802791609beaf |
259,881 | 31.07.2018 11:37:51 | 25,200 | 6cad96f38a6de187d2aa3640c492bdfbdbdc589b | Drop dup2 filter
It is unused. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -30,7 +30,6 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_CLONE: {},\nsyscall.SYS_CLOSE: {},\nsyscall.SYS_DUP: {},\n- syscall.SYS_DUP2: {},\nsyscall.SYS_EPOLL_CR... | Go | Apache License 2.0 | google/gvisor | Drop dup2 filter
It is unused.
PiperOrigin-RevId: 206798328
Change-Id: I2d7d27c0e4a0ef51264b900f14f1b3fdad17f2c4 |
259,992 | 31.07.2018 15:06:36 | 25,200 | 413bfb39a940455cb116c7d0ca715b2ced78a11c | Use backoff package for retry logic | [
{
"change_type": "MODIFY",
"old_path": "runsc/specutils/BUILD",
"new_path": "runsc/specutils/BUILD",
"diff": "@@ -13,6 +13,7 @@ go_library(\n\"//pkg/abi/linux\",\n\"//pkg/log\",\n\"//pkg/sentry/kernel/auth\",\n+ \"@com_github_cenkalti_backoff//:go_default_library\",\n\"@com_github_opencontainers_run... | Go | Apache License 2.0 | google/gvisor | Use backoff package for retry logic
PiperOrigin-RevId: 206834838
Change-Id: I9a44c6fa5f4766a01f86e90810f025cefecdf2d4 |
259,854 | 01.08.2018 20:21:00 | 25,200 | 3cd7824410302da00d1c8c8323db8959a124814a | Move stack clock to options struct | [
{
"change_type": "MODIFY",
"old_path": "pkg/dhcp/dhcp_test.go",
"new_path": "pkg/dhcp/dhcp_test.go",
"diff": "@@ -46,7 +46,7 @@ func TestDHCP(t *testing.T) {\n}\n}()\n- s := stack.New(&tcpip.StdClock{}, []string{ipv4.ProtocolName}, []string{udp.ProtocolName})\n+ s := stack.New([]string{ipv4.Protocol... | Go | Apache License 2.0 | google/gvisor | Move stack clock to options struct
PiperOrigin-RevId: 207039273
Change-Id: Ib8f55a6dc302052ab4a10ccd70b07f0d73b373df |
260,013 | 02.08.2018 08:09:03 | 25,200 | cf44aff6e08b0e19935d5cd98455b4af98fd8794 | Add seccomp(2) support.
Add support for the seccomp syscall and the flag SECCOMP_FILTER_FLAG_TSYNC. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -47,6 +47,7 @@ go_stateify(\n],\nout = \"kernel_autogen_state.go\",\nimports = [\n+ \"gvisor.googlesource.com/gvisor/pkg/bpf\",\n\"gvisor.googlesource.com/gvisor/pkg/sentry/arch\",\n\... | Go | Apache License 2.0 | google/gvisor | Add seccomp(2) support.
Add support for the seccomp syscall and the flag SECCOMP_FILTER_FLAG_TSYNC.
PiperOrigin-RevId: 207101507
Change-Id: I5eb8ba9d5ef71b0e683930a6429182726dc23175 |
259,992 | 02.08.2018 12:40:29 | 25,200 | 4c1167de4ee2aa7b71729ff8b1c742b4183168d1 | Isolate image pulling time from container startup
mysql image test is timing out sporadically and it's hard to tell
where the slow down in coming from. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/image/image_test.go",
"new_path": "runsc/test/image/image_test.go",
"diff": "@@ -82,6 +82,9 @@ func testHTTPServer(port int) error {\n}\nfunc TestHttpd(t *testing.T) {\n+ if out, err := testutil.Pull(\"httpd\"); err != nil {\n+ t.Fatalf(\"docker pul... | Go | Apache License 2.0 | google/gvisor | Isolate image pulling time from container startup
mysql image test is timing out sporadically and it's hard to tell
where the slow down in coming from.
PiperOrigin-RevId: 207147237
Change-Id: I05a4d2c116292695d63cf861f3b89cd1c54b6106 |
259,881 | 02.08.2018 15:55:19 | 25,200 | b6a37ab9d96b382e26e3836a42ea485c48a521a8 | Update comment reference | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_prctl.go",
"new_path": "pkg/sentry/syscalls/linux/sys_prctl.go",
"diff": "@@ -113,7 +113,7 @@ func Prctl(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\nreturn 0, nil, syscall.EINVAL\n}\n// no_new_privs is a... | Go | Apache License 2.0 | google/gvisor | Update comment reference
PiperOrigin-RevId: 207180809
Change-Id: I08c264812919e81b2c56fdd4a9ef06924de8b52f |
259,881 | 02.08.2018 16:00:29 | 25,200 | a3927157c56cc022cefebc30c8a9b6014f5d0412 | Copy creds in access | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -453,7 +453,7 @@ func accessAt(t *kernel.Task, dirFD kdefs.FD, addr usermem.Addr, resolve bool, m\n// uid/gid. We do this by temporarily clearing all FS-re... | Go | Apache License 2.0 | google/gvisor | Copy creds in access
PiperOrigin-RevId: 207181631
Change-Id: Ic6205278715a9260fb970efb414fc758ea72c4c6 |
259,948 | 03.08.2018 12:07:57 | 25,200 | 25178ebdf5e881eae8e81eaf2f69d96de42d2250 | stateify: make explicit mode no longer optional. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/host/socket.go",
"new_path": "pkg/sentry/fs/host/socket.go",
"diff": "@@ -37,7 +37,7 @@ import (\n//\n// +stateify savable\ntype endpoint struct {\n- queue waiter.Queue `state:\"nosave\"`\n+ queue waiter.Queue `state:\"zerovalue\"`\n// stype is t... | Go | Apache License 2.0 | google/gvisor | stateify: make explicit mode no longer optional.
PiperOrigin-RevId: 207303405
Change-Id: I17b6433963d78e3631a862b7ac80f566c8e7d106 |
259,962 | 03.08.2018 17:53:24 | 25,200 | 56fa562dda18260440726a37ea467f6eb6aa6c12 | Cubic implementation for Netstack.
This CL implements CUBIC as described in | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/BUILD",
"new_path": "pkg/tcpip/transport/tcp/BUILD",
"diff": "@@ -19,6 +19,7 @@ go_library(\nsrcs = [\n\"accept.go\",\n\"connect.go\",\n+ \"cubic.go\",\n\"endpoint.go\",\n\"endpoint_state.go\",\n\"forwarder.go\",\n"
},
{
"change... | Go | Apache License 2.0 | google/gvisor | Cubic implementation for Netstack.
This CL implements CUBIC as described in https://tools.ietf.org/html/rfc8312.
PiperOrigin-RevId: 207353142
Change-Id: I329cbf3277f91127e99e488f07d906f6779c6603 |
259,989 | 06.08.2018 10:10:25 | 25,200 | 3ec074897f9d0aba21bc9f41be18f52bfbeb599e | Fix a bug in PCIDs.Assign
Store the new assigned pcid in p.cache[pt]. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/pagetables/pcids_x86.go",
"new_path": "pkg/sentry/platform/ring0/pagetables/pcids_x86.go",
"diff": "@@ -64,6 +64,7 @@ func (p *PCIDs) Assign(pt *PageTables) (uint16, bool) {\nif len(p.avail) > 0 {\npcid := p.avail[len(p.avail)-1]\np.a... | Go | Apache License 2.0 | google/gvisor | Fix a bug in PCIDs.Assign
Store the new assigned pcid in p.cache[pt].
Signed-off-by: ShiruRen <renshiru2000@gmail.com>
Change-Id: I4aee4e06559e429fb5e90cb9fe28b36139e3b4b6
PiperOrigin-RevId: 207563833 |
259,992 | 06.08.2018 11:47:07 | 25,200 | bc9a1fca23870b21e16e024220e0c87e236c6cf5 | Tiny reordering to network code | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/network.go",
"new_path": "runsc/sandbox/network.go",
"diff": "@@ -221,12 +221,6 @@ func createInterfacesAndRoutesFromNS(conn *urpc.Client, nsPath string) error {\ncontinue\n}\n- // Get the link for the interface.\n- ifaceLink, err := netlink.Link... | Go | Apache License 2.0 | google/gvisor | Tiny reordering to network code
PiperOrigin-RevId: 207581723
Change-Id: I6e4eb1227b5ed302de5e6c891040b670955f1eea |
259,992 | 06.08.2018 18:07:15 | 25,200 | 9752174a7f211328c0ff59f8ed6c51325a6fc23d | Disable KVM dimension because it's making the test flaky | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -212,12 +212,13 @@ func configs(opts configOptions) []*boot.Config {\ncs = append(cs, c)\n}\n- // TODO: KVM doesn't work with --race.\n- if !testutil.RaceEnabled &... | Go | Apache License 2.0 | google/gvisor | Disable KVM dimension because it's making the test flaky
PiperOrigin-RevId: 207642348
Change-Id: Iacec9f097ab93b91c0c8eea61b1347e864f57a8b |
260,013 | 07.08.2018 07:56:08 | 25,200 | d839dc13c689f853fd87c495c26208048a540919 | Netstack doesn't handle sending after SHUT_WR correctly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/ping/endpoint.go",
"new_path": "pkg/tcpip/transport/ping/endpoint.go",
"diff": "@@ -71,6 +71,8 @@ type endpoint struct {\n// The following fields are protected by the mu mutex.\nmu sync.RWMutex `state:\"nosave\"`\nsndBufSize int\n+ // shutd... | Go | Apache License 2.0 | google/gvisor | Netstack doesn't handle sending after SHUT_WR correctly.
PiperOrigin-RevId: 207715032
Change-Id: I7b6690074c5be283145192895d706a92e921b22c |
259,948 | 07.08.2018 10:26:17 | 25,200 | c348d0786388ded1a4bad3c98000b4653724c764 | sentry: make epoll.pollEntry wait for the file operation in restore. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/file.go",
"new_path": "pkg/sentry/fs/file.go",
"diff": "@@ -91,7 +91,7 @@ type File struct {\nmu amutex.AbortableMutex `state:\"nosave\"`\n// FileOperations implements file system specific behavior for this File.\n- FileOperations FileOperations\... | Go | Apache License 2.0 | google/gvisor | sentry: make epoll.pollEntry wait for the file operation in restore.
PiperOrigin-RevId: 207737935
Change-Id: I3a301ece1f1d30909715f36562474e3248b6a0d5 |
259,962 | 07.08.2018 11:48:37 | 25,200 | 7d3684aadf71255d3d8442ae1ed0b0f0048f95a3 | Adds support to dump out cubic internal state. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -56,6 +56,20 @@ type transportProtocolState struct {\n// passed to stack.AddTCPProbe.\ntype TCPProbeFunc func(s TCPEndpointState)\n+// TCPCubicState is used to hold a copy of the in... | Go | Apache License 2.0 | google/gvisor | Adds support to dump out cubic internal state.
PiperOrigin-RevId: 207754087
Change-Id: I83abce64348ea93f8692da81a881b364dae2158b |
259,885 | 07.08.2018 13:08:37 | 25,200 | c036da5dffdf6cad912abe2723e69c04b59430b7 | Hold TaskSet.mu in Task.Parent. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/threads.go",
"new_path": "pkg/sentry/kernel/threads.go",
"diff": "@@ -441,6 +441,8 @@ func (t *Task) Timekeeper() *Timekeeper {\n// Parent returns t's parent.\nfunc (t *Task) Parent() *Task {\n+ t.tg.pidns.owner.mu.RLock()\n+ defer t.tg.pidns... | Go | Apache License 2.0 | google/gvisor | Hold TaskSet.mu in Task.Parent.
PiperOrigin-RevId: 207766238
Change-Id: Id3b66d8fe1f44c3570f67fa5ae7ba16021e35be1 |
259,992 | 07.08.2018 13:47:16 | 25,200 | cb23232c37c092b60d7e3ee91cb8dd8bed855028 | Fix build break in test
integration_test runs manually and breakage wasn't detected. Added test to
kokoro to ensure breakages are detected in the future. | [
{
"change_type": "MODIFY",
"old_path": "kokoro/run_tests.sh",
"new_path": "kokoro/run_tests.sh",
"diff": "@@ -44,10 +44,14 @@ bazel test --test_output=errors //...\nexit_code=${?}\nif [[ ${exit_code} -eq 0 ]]; then\n+ # These names are used to exclude tests not supported in certain\n+ # configuratio... | Go | Apache License 2.0 | google/gvisor | Fix build break in test
integration_test runs manually and breakage wasn't detected. Added test to
kokoro to ensure breakages are detected in the future.
PiperOrigin-RevId: 207772835
Change-Id: Iada81b579b558477d4db3516b38366ef6a2e933d |
259,992 | 08.08.2018 10:24:53 | 25,200 | 0d350aac7f70487bc28bae0d0f457155a4e19081 | Enable SACK in runsc
SACK is disabled by default and needs to be manually enabled. It not only
improves performance, but also fixes hangs downloading files from certain
websites. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/stack.go",
"new_path": "pkg/sentry/socket/hostinet/stack.go",
"diff": "@@ -84,11 +84,13 @@ func (s *Stack) Configure() error {\nlog.Warningf(\"Failed to read TCP send buffer size, using default values\")\n}\n- s.tcpSACKEnabled = fals... | Go | Apache License 2.0 | google/gvisor | Enable SACK in runsc
SACK is disabled by default and needs to be manually enabled. It not only
improves performance, but also fixes hangs downloading files from certain
websites.
PiperOrigin-RevId: 207906742
Change-Id: I4fb7277b67bfdf83ac8195f1b9c38265a0d51e8b |
259,881 | 08.08.2018 18:06:18 | 25,200 | 9144ddda09c0a370bfc7391b0d7382836e296b5d | Bump rules_go and gazelle to 0.14.0 | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "# Load go bazel rules and gazelle.\nhttp_archive(\nname = \"io_bazel_rules_go\",\n- url = \"https://github.com/bazelbuild/rules_go/releases/download/0.13.0/rules_go-0.13.0.tar.gz\",\n- sha256 = \"ba79c532ac400cefd1... | Go | Apache License 2.0 | google/gvisor | Bump rules_go and gazelle to 0.14.0
PiperOrigin-RevId: 207977844
Change-Id: I980c1ad76339e9e4e8ea6d58c1caf5245befa18a |
259,858 | 08.08.2018 21:27:58 | 25,200 | dbbe9ec91541dba387f8044cbf73fd29f604f902 | Protect PCIDs with a mutex.
Because the Drop method may be called across vCPUs, it is necessary to protect
the PCID database with a mutex to prevent concurrent modification. The PCID is
assigned prior to entersyscall, so it's safe to block. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/ring0/pagetables/pcids_x86.go",
"new_path": "pkg/sentry/platform/ring0/pagetables/pcids_x86.go",
"diff": "package pagetables\n+import (\n+ \"sync\"\n+)\n+\n// limitPCID is the number of valid PCIDs.\nconst limitPCID = 4096\n@@ -24,6 +28,9 @... | Go | Apache License 2.0 | google/gvisor | Protect PCIDs with a mutex.
Because the Drop method may be called across vCPUs, it is necessary to protect
the PCID database with a mutex to prevent concurrent modification. The PCID is
assigned prior to entersyscall, so it's safe to block.
PiperOrigin-RevId: 207992864
Change-Id: I8b36d55106981f51e30dcf03e12886330bb7... |
259,992 | 08.08.2018 22:38:41 | 25,200 | 4e171f7590284c1f4cedf90c92204873961b2e97 | Basic support for ip link/addr and ifconfig
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/netlink_route.go",
"new_path": "pkg/abi/linux/netlink_route.go",
"diff": "@@ -184,3 +184,8 @@ const (\nIFA_MULTICAST = 7\nIFA_FLAGS = 8\n)\n+\n+// Device types, from uapi/linux/if_arp.h.\n+const (\n+ ARPHRD_LOOPBACK = 772\n+)\n"
},
{
"cha... | Go | Apache License 2.0 | google/gvisor | Basic support for ip link/addr and ifconfig
Closes #94
PiperOrigin-RevId: 207997580
Change-Id: I19b426f1586b5ec12f8b0cd5884d5b401d334924 |
259,881 | 09.08.2018 16:49:23 | 25,200 | 2e06b23aa61216fcdbefcd6b11a24bca7a456b16 | Fix missing O_LARGEFILE from O_CREAT files
Cleanup some more syscall.O_* references while we're here. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/file.go",
"new_path": "pkg/abi/linux/file.go",
"diff": "@@ -27,6 +27,10 @@ const (\nO_RDONLY = 00000000\nO_WRONLY = 00000001\nO_RDWR = 00000002\n+ O_CREAT = 00000100\n+ O_EXCL = 00000200\n+ O_NOCTTY = 00000400\n+ O_TRUNC = 00001000\nO_APPEND = 00... | Go | Apache License 2.0 | google/gvisor | Fix missing O_LARGEFILE from O_CREAT files
Cleanup some more syscall.O_* references while we're here.
PiperOrigin-RevId: 208133460
Change-Id: I48db71a38f817e4f4673977eafcc0e3874eb9a25 |
259,992 | 09.08.2018 17:04:18 | 25,200 | 0ac912f99e44e8e89985dd83ec946deadbfd8797 | Fix runsc integration_test when using --network=host
inethost doesn't support netlink and 'ifconfig' call to retrieve IP address
fails. Look up IP address in /etc/hosts instead. | [
{
"change_type": "MODIFY",
"old_path": "runsc/test/integration/integration_test.go",
"new_path": "runsc/test/integration/integration_test.go",
"diff": "@@ -162,8 +162,8 @@ func TestConnectToSelf(t *testing.T) {\n}\ndefer d.CleanUp()\n- // Finds IP address for eth0.\n- ip, err := d.Exec(\"/bin/sh\", ... | Go | Apache License 2.0 | google/gvisor | Fix runsc integration_test when using --network=host
inethost doesn't support netlink and 'ifconfig' call to retrieve IP address
fails. Look up IP address in /etc/hosts instead.
PiperOrigin-RevId: 208135641
Change-Id: I3c2ce15db6fc7c3306a45e4bfb9cc5d4423ffad3 |
260,008 | 10.08.2018 10:25:37 | 25,200 | d5b702b64f05a200ed94f0cd977d3f84dae01162 | Validate FS.base before establishing it in the task's register set. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_tls.go",
"new_path": "pkg/sentry/syscalls/linux/sys_tls.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/arch\"\n\"gvisor.googlesource.com/gvis... | Go | Apache License 2.0 | google/gvisor | Validate FS.base before establishing it in the task's register set.
PiperOrigin-RevId: 208229341
Change-Id: I5d84bc52bbafa073446ef497e56958d0d7955aa8 |
259,991 | 10.08.2018 15:39:02 | 25,200 | 3c60a192ca96838e895bd3607f8a85845245f81e | Added a reference to the checkpoint/restore readme.
In the main readme, checkpoint and restore is listed as an
advanced feature, and a link to its readme is provided. | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -360,6 +360,13 @@ configuration (`/etc/docker/daemon.json`):\nThen restart the Docker daemon.\n+### Checkpoint/Restore\n+\n+gVisor has the ability to checkpoint a process, save its current state in a\n+state fil... | Go | Apache License 2.0 | google/gvisor | Added a reference to the checkpoint/restore readme.
In the main readme, checkpoint and restore is listed as an
advanced feature, and a link to its readme is provided.
PiperOrigin-RevId: 208279833
Change-Id: Ib3db28a8df8ec93cf8d98d5dfd2ee2f75a61e664 |
259,991 | 10.08.2018 16:09:52 | 25,200 | ae6f092fe117a738df34e072ef5ba01a41c89222 | Implemented the splice(2) syscall.
Currently the implementation matches the behavior of moving data
between two file descriptors. However, it does not implement this
through zero-copy movement. Thus, this code is a starting point
to build the more complex implementation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -43,6 +43,7 @@ go_library(\n\"shm.go\",\n\"signal.go\",\n\"socket.go\",\n+ \"splice.go\",\n\"time.go\",\n\"tty.go\",\n\"uio.go\",\n"
},
{
"change_type": "ADD",
"old_path": null,
... | Go | Apache License 2.0 | google/gvisor | Implemented the splice(2) syscall.
Currently the implementation matches the behavior of moving data
between two file descriptors. However, it does not implement this
through zero-copy movement. Thus, this code is a starting point
to build the more complex implementation.
PiperOrigin-RevId: 208284483
Change-Id: Ibde79... |
259,858 | 13.08.2018 12:49:18 | 25,200 | 85235ac212713942cb4c0ab2947964711a342a64 | Add path sanity checks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/p9/handlers.go",
"new_path": "pkg/p9/handlers.go",
"diff": "@@ -17,6 +17,7 @@ package p9\nimport (\n\"io\"\n\"os\"\n+ \"strings\"\n\"sync/atomic\"\n\"syscall\"\n@@ -83,8 +84,24 @@ func (t *Tflush) handle(cs *connState) message {\nreturn &Rflush{}\n}\n+// i... | Go | Apache License 2.0 | google/gvisor | Add path sanity checks.
PiperOrigin-RevId: 208527333
Change-Id: I55291bc6b8bc6b88fdd75baf899a71854c39c1a7 |
259,858 | 13.08.2018 13:29:54 | 25,200 | dde836a91858ceee25dbe023263752b39ae21274 | Prevent renames across walk fast path. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -533,14 +533,18 @@ func (d *Dirent) walk(ctx context.Context, root *Dirent, name string, walkMayUnl\nreturn nil, syscall.ENOENT\n}\n- // Slow path: load the InodeOperations into memor... | Go | Apache License 2.0 | google/gvisor | Prevent renames across walk fast path.
PiperOrigin-RevId: 208533436
Change-Id: Ifc1a4e2d6438a424650bee831c301b1ac0d670a3 |
259,854 | 14.08.2018 15:05:44 | 25,200 | e97717e29a1bb3e373b130086c4182c598a8121c | Enforce Unix socket address length limit | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -150,6 +150,9 @@ func GetAddress(sfamily int, addr []byte) (tcpip.FullAddress, *syserr.Error) {\nswitch family {\ncase linux.AF_UNIX:\npath := addr[2:]\n... | Go | Apache License 2.0 | google/gvisor | Enforce Unix socket address length limit
PiperOrigin-RevId: 208720936
Change-Id: Ic943a88b6efeff49574306d4d4e1f113116ae32e |
259,891 | 14.08.2018 16:21:38 | 25,200 | d4939f6dc22e5607cf2ff8d2a9eb1178e47b0a22 | TTY: Fix data race where calls into tty.queue's waiter were not synchronized.
Now, there's a waiter for each end (master and slave) of the TTY, and each
waiter.Entry is only enqueued in one of the waiters. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tty/line_discipline.go",
"new_path": "pkg/sentry/fs/tty/line_discipline.go",
"diff": "@@ -23,6 +23,7 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/sentry/arch\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/context\"\n\"gvisor.googlesource.com... | Go | Apache License 2.0 | google/gvisor | TTY: Fix data race where calls into tty.queue's waiter were not synchronized.
Now, there's a waiter for each end (master and slave) of the TTY, and each
waiter.Entry is only enqueued in one of the waiters.
PiperOrigin-RevId: 208734483
Change-Id: I06996148f123075f8dd48cde5a553e2be74c6dce |
259,854 | 14.08.2018 19:02:36 | 25,200 | a620bea045b018b717fbba3193975e6d97c09bf9 | Reduce map lookups in syserr | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -473,7 +473,7 @@ func GetSockOpt(t *kernel.Task, s socket.Socket, ep commonEndpoint, family int,\nif err == nil {\nreturn int32(0), nil\n}\n- return int3... | Go | Apache License 2.0 | google/gvisor | Reduce map lookups in syserr
PiperOrigin-RevId: 208755352
Change-Id: Ia24630f452a4a42940ab73a8113a2fd5ea2cfca2 |
259,854 | 15.08.2018 17:00:54 | 25,200 | eacbe6a678ec08751543868ef19f9197c167fe60 | Remove obsolete comment about panicking | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/buffer/view.go",
"new_path": "pkg/tcpip/buffer/view.go",
"diff": "@@ -121,7 +121,6 @@ func (vv *VectorisedView) Clone(buffer []View) VectorisedView {\n}\n// First returns the first view of the vectorised view.\n-// It panics if the vectorised view is... | Go | Apache License 2.0 | google/gvisor | Remove obsolete comment about panicking
PiperOrigin-RevId: 208908702
Change-Id: I6be9c765c257a9ddb1a965a03942ab3fc3a34a43 |
259,992 | 16.08.2018 10:54:21 | 25,200 | da087e66cc0eb1616437e5b729576801671d3696 | Combine functions to search for file under one common function
Bazel adds the build type in front of directories making it hard to
refer to binaries in code. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -206,27 +206,6 @@ func run(spec *specs.Spec, conf *boot.Config) error {\nreturn nil\n}\n-// findUDSApp finds the uds_test_app binary to be used in the UnixDomainSo... | Go | Apache License 2.0 | google/gvisor | Combine functions to search for file under one common function
Bazel adds the build type in front of directories making it hard to
refer to binaries in code.
PiperOrigin-RevId: 209010854
Change-Id: I6c9da1ac3bbe79766868a3b14222dd42d03b4ec5 |
260,028 | 16.08.2018 16:27:14 | 25,200 | aeec7a4c007ac53401e05bf72894a3b998eead95 | fs: Support possible and online knobs for cpu
Some linux commands depend on /sys/devices/system/cpu/possible, such
as 'lscpu'.
Add 2 knobs for cpu:
/sys/devices/system/cpu/possible
/sys/devices/system/cpu/online
Both the values are '0 - Kernel.ApplicationCores()-1'. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/sys/BUILD",
"new_path": "pkg/sentry/fs/sys/BUILD",
"diff": "@@ -6,6 +6,7 @@ go_library(\nname = \"sys\",\nsrcs = [\n\"device.go\",\n+ \"devices.go\",\n\"fs.go\",\n\"sys.go\",\n],\n@@ -16,6 +17,8 @@ go_library(\n\"//pkg/sentry/device\",\n\"//pkg/s... | Go | Apache License 2.0 | google/gvisor | fs: Support possible and online knobs for cpu
Some linux commands depend on /sys/devices/system/cpu/possible, such
as 'lscpu'.
Add 2 knobs for cpu:
/sys/devices/system/cpu/possible
/sys/devices/system/cpu/online
Both the values are '0 - Kernel.ApplicationCores()-1'.
Change-Id: Iabd8a4e559cbb630ed249686b92c22b4e71206... |
259,992 | 17.08.2018 13:05:59 | 25,200 | 11800311a537bf1286f71ab419fa251a1e81e54f | Add nonExclusiveFS dimension to more tests
The ones using 'kvm' actually mean that they don't want overlay. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -215,6 +215,7 @@ const (\n)\nvar all = []configOption{overlay, kvm, nonExclusiveFS}\n+var noOverlay = []configOption{kvm, nonExclusiveFS}\n// configs generates dif... | Go | Apache License 2.0 | google/gvisor | Add nonExclusiveFS dimension to more tests
The ones using 'kvm' actually mean that they don't want overlay.
PiperOrigin-RevId: 209194318
Change-Id: I941a443cb6d783e2c80cf66eb8d8630bcacdb574 |
259,992 | 20.08.2018 11:25:42 | 25,200 | 0fc7b306959e83ebf14792206c9a626490b02c2d | Standardize mounts in tests
Tests get a readonly rootfs mapped to / (which was the case before)
and writable TEST_TMPDIR. This makes it easier to setup containers to
write to files and to share state between test and containers. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -558,17 +558,19 @@ func TestExec(t *testing.T) {\n// be the next consecutive number after the last number from the checkpointed container.\nfunc TestCheckpointRest... | Go | Apache License 2.0 | google/gvisor | Standardize mounts in tests
Tests get a readonly rootfs mapped to / (which was the case before)
and writable TEST_TMPDIR. This makes it easier to setup containers to
write to files and to share state between test and containers.
PiperOrigin-RevId: 209453224
Change-Id: I4d988e45dc0909a0450a3bb882fe280cf9c24334 |
259,854 | 21.08.2018 11:15:15 | 25,200 | 9c407382b031f16160f83383ef8b0d419457829a | Fix races in kernel.(*Task).Value() | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task.go",
"new_path": "pkg/sentry/kernel/task.go",
"diff": "@@ -568,12 +568,18 @@ func (t *Task) Value(key interface{}) interface{} {\ncase CtxPIDNamespace:\nreturn t.tg.pidns\ncase CtxUTSNamespace:\n+ t.mu.Lock()\n+ defer t.mu.Unlock()\nretu... | Go | Apache License 2.0 | google/gvisor | Fix races in kernel.(*Task).Value()
PiperOrigin-RevId: 209627180
Change-Id: Idc84afd38003427e411df6e75abfabd9174174e1 |
259,992 | 21.08.2018 13:13:34 | 25,200 | d6d165cb0b8147461388287ffd4cfee221940123 | Initial change for multi-gofer support | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/debug.go",
"new_path": "runsc/cmd/debug.go",
"diff": "@@ -92,7 +92,7 @@ func (d *Debug) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})\n}\nlog.Infof(\"Found sandbox %q, PID: %d\", c.Sandbox.ID, c.Sandbox.Pid)\n- if !c.Sandbox.IsRunn... | Go | Apache License 2.0 | google/gvisor | Initial change for multi-gofer support
PiperOrigin-RevId: 209647293
Change-Id: I980fca1257ea3fcce796388a049c353b0303a8a5 |
259,992 | 21.08.2018 14:01:14 | 25,200 | a854678bc36065379ca0b988410b4a8318747a3d | Move container_test to the container package | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "@@ -39,6 +39,7 @@ go_test(\n\":uds_test_app\",\n\"//runsc\",\n],\n+ embed = [\":container\"],\ntags = [\n\"requires-kvm\",\n],\n@@ -49,7 +50,6 @@ go_test(\n\"//pkg/sentry/kernel/auth\",\n\"/... | Go | Apache License 2.0 | google/gvisor | Move container_test to the container package
PiperOrigin-RevId: 209655274
Change-Id: Id381114bdb3197c73e14f74b3f6cf1afd87d60cb |
259,992 | 21.08.2018 14:34:00 | 25,200 | 19ef2ad1fe82093548edbb00de536d4bcf328f2b | nonExclusiveFS is causing timeout with --race
Not sure why, just removed for now to unblock the tests. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -213,8 +213,10 @@ const (\nnonExclusiveFS\n)\n-var all = []configOption{overlay, kvm, nonExclusiveFS}\n-var noOverlay = []configOption{kvm, nonExclusiveFS}\n+// TO... | Go | Apache License 2.0 | google/gvisor | nonExclusiveFS is causing timeout with --race
Not sure why, just removed for now to unblock the tests.
PiperOrigin-RevId: 209661403
Change-Id: I72785c071687d54e22bda9073d36b447d52a7018 |
259,891 | 21.08.2018 16:19:59 | 25,200 | ae68e9e7513083411875110bd31bd89ac3a58cb7 | Temporarily skip multi-container tests in container_test until deflaked. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -1366,6 +1366,7 @@ func TestAbbreviatedIDs(t *testing.T) {\n// TestMultiContainerSanity checks that it is possible to run 2 dead-simple\n// containers in the same ... | Go | Apache License 2.0 | google/gvisor | Temporarily skip multi-container tests in container_test until deflaked.
PiperOrigin-RevId: 209679235
Change-Id: I527e779eeb113d0c162f5e27a2841b9486f0e39f |
259,948 | 21.08.2018 16:51:08 | 25,200 | 8bb50dab790d575a83a935cf3361099cdb1a6aac | sentry: do not release gofer inode file state loading lock upon error.
When an inode file state failed to load asynchronuously, we want to report
the error instead of potentially panicing in another async loading goroutine
incorrectly unblocked. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/inode_state.go",
"new_path": "pkg/sentry/fs/gofer/inode_state.go",
"diff": "@@ -108,9 +108,13 @@ func (i *inodeFileState) loadLoading(_ struct{}) {\n// afterLoad is invoked by stateify.\nfunc (i *inodeFileState) afterLoad() {\n- load := fun... | Go | Apache License 2.0 | google/gvisor | sentry: do not release gofer inode file state loading lock upon error.
When an inode file state failed to load asynchronuously, we want to report
the error instead of potentially panicing in another async loading goroutine
incorrectly unblocked.
PiperOrigin-RevId: 209683977
Change-Id: I591cde97710bbe3cdc53717ee58f1d2... |
259,992 | 21.08.2018 23:06:11 | 25,200 | e2ab7ec39e500627126fe8be8e37400711410cde | Fix TestUnixDomainSockets failure when path is too large
UDS has a lower size limit than regular files. When running under bazel
this limit is exceeded. Test was changed to always mount /tmp and use
it for the test. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -704,22 +704,20 @@ func TestCheckpointRestore(t *testing.T) {\n// TestUnixDomainSockets checks that Checkpoint/Restore works in cases\n// with filesystem Unix Doma... | Go | Apache License 2.0 | google/gvisor | Fix TestUnixDomainSockets failure when path is too large
UDS has a lower size limit than regular files. When running under bazel
this limit is exceeded. Test was changed to always mount /tmp and use
it for the test.
PiperOrigin-RevId: 209717830
Change-Id: I1dbe19fe2051ffdddbaa32b188a9167f446ed193 |
260,013 | 22.08.2018 12:35:40 | 25,200 | 545ea7ab3fa3e976120b74da3271dc7724c05f5e | Always add AT_BASE even if there is no interpreter.
Linux will ALWAYS add AT_BASE even for a static binary, expect it
will be set to 0 [1].
1. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -655,6 +655,9 @@ func loadELF(ctx context.Context, m *mm.MemoryManager, mounts *fs.MountNamespace\n// Start in the interpreter.\n// N.B. AT_ENTRY above contains the *original* entry... | Go | Apache License 2.0 | google/gvisor | Always add AT_BASE even if there is no interpreter.
Linux will ALWAYS add AT_BASE even for a static binary, expect it
will be set to 0 [1].
1. https://github.com/torvalds/linux/blob/master/fs/binfmt_elf.c#L253
PiperOrigin-RevId: 209811129
Change-Id: I92cc66532f23d40f24414a921c030bd3481e12a0 |
259,948 | 22.08.2018 13:18:21 | 25,200 | 6b9133ba96863e3653fa6f3949710203bb077c50 | sentry: mark S/R stating errors as save rejections / fs corruptions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/gofer/inode_state.go",
"new_path": "pkg/sentry/fs/gofer/inode_state.go",
"diff": "@@ -67,7 +67,7 @@ func (i *inodeFileState) beforeSave() {\nif i.sattr.Type == fs.RegularFile {\nuattr, err := i.unstableAttr(&dummyClockContext{context.Background()... | Go | Apache License 2.0 | google/gvisor | sentry: mark S/R stating errors as save rejections / fs corruptions.
PiperOrigin-RevId: 209817767
Change-Id: Iddf2b8441bc44f31f9a8cf6f2bd8e7a5b824b487 |
259,858 | 22.08.2018 14:14:32 | 25,200 | a7a8d07d7d6bd551d96621ee841b1b0e0f217ca3 | Add separate Recycle method for allocator.
This improves debugging for pagetable-related issues. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/address_space.go",
"new_path": "pkg/sentry/platform/kvm/address_space.go",
"diff": "@@ -273,6 +273,9 @@ func (as *addressSpace) Unmap(addr usermem.Addr, length uint64) {\nStart: addr,\nEnd: addr + usermem.Addr(length),\n})\n+\n+ // Recy... | Go | Apache License 2.0 | google/gvisor | Add separate Recycle method for allocator.
This improves debugging for pagetable-related issues.
PiperOrigin-RevId: 209827795
Change-Id: I4cfa11664b0b52f26f6bc90a14c5bb106f01e038 |
259,854 | 23.08.2018 08:54:09 | 25,200 | abe7764928bb18fe417c53c8ea8aa9fb970114b7 | Encapsulate netstack metrics | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/nic.go",
"new_path": "pkg/tcpip/stack/nic.go",
"diff": "@@ -282,12 +282,12 @@ func (n *NIC) RemoveAddress(addr tcpip.Address) *tcpip.Error {\nfunc (n *NIC) DeliverNetworkPacket(linkEP LinkEndpoint, remoteLinkAddr tcpip.LinkAddress, protocol tcp... | Go | Apache License 2.0 | google/gvisor | Encapsulate netstack metrics
PiperOrigin-RevId: 209943212
Change-Id: I96dcbc7c2ab2426e510b94a564436505256c5c79 |
259,992 | 23.08.2018 11:14:02 | 25,200 | 001a4c2493b13a43d62c7511fb509a959ae4abc2 | Clean up syscall filters
Removed syscalls that are only used by whitelistfs
which has its own set of filters. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -38,7 +38,6 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_EXIT: {},\nsyscall.SYS_EXIT_GROUP: {},\nsyscall.SYS_FALLOCATE: {},\n- syscall.SYS_FCHMOD: {},\nsyscall.... | Go | Apache License 2.0 | google/gvisor | Clean up syscall filters
Removed syscalls that are only used by whitelistfs
which has its own set of filters.
PiperOrigin-RevId: 209967259
Change-Id: Idb2e1b9d0201043d7cd25d96894f354729dbd089 |
259,948 | 23.08.2018 13:57:30 | 25,200 | ba8f6ba8c899d2e900fa7e9ee5aede31cba1de9c | sentry: mark idMapSeqHandle as savable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/uid_gid_map.go",
"new_path": "pkg/sentry/fs/proc/uid_gid_map.go",
"diff": "@@ -68,6 +68,8 @@ func (imss *idMapSeqSource) ReadSeqFileData(ctx context.Context, handle seqfile.\n}\n// TODO: Fix issue requiring idMapSeqHandle wrapping an int.\n+... | Go | Apache License 2.0 | google/gvisor | sentry: mark idMapSeqHandle as savable.
PiperOrigin-RevId: 209994384
Change-Id: I16186cf79cb4760a134f3968db30c168a5f4340e |
259,948 | 23.08.2018 16:13:22 | 25,200 | e855e9cebc45f5fd7a9583f476c8965fc395a15e | netstack: make listening tcp socket close state setting and cleanup atomic.
Otherwise the socket saving logic might find workers still running for closed
sockets unexpectedly. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/accept.go",
"new_path": "pkg/tcpip/transport/tcp/accept.go",
"diff": "@@ -363,11 +363,6 @@ func (e *endpoint) protocolListenLoop(rcvWnd seqnum.Size) *tcpip.Error {\ne.mu.Lock()\ne.state = stateClosed\n- // Notify waiters that the endpoi... | Go | Apache License 2.0 | google/gvisor | netstack: make listening tcp socket close state setting and cleanup atomic.
Otherwise the socket saving logic might find workers still running for closed
sockets unexpectedly.
PiperOrigin-RevId: 210018905
Change-Id: I443a04d355613f5f9983252cc6863bff6e0eda3a |
259,992 | 24.08.2018 10:16:38 | 25,200 | a81a4402a265aec6715172cd3502ee7eebbf64aa | Add option to panic gofer if writes are attempted over RO mounts
This is used when '--overlay=true' to guarantee writes are not sent to gofer. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -38,6 +38,8 @@ type Gofer struct {\n// controllerFD is the file descriptor of a stream socket for the\n// control server that is donated to this process.\ncontrollerFD int\n+\n+ panicOnWrite bo... | Go | Apache License 2.0 | google/gvisor | Add option to panic gofer if writes are attempted over RO mounts
This is used when '--overlay=true' to guarantee writes are not sent to gofer.
PiperOrigin-RevId: 210116288
Change-Id: I7616008c4c0e8d3668e07a205207f46e2144bf30 |
259,992 | 24.08.2018 11:38:12 | 25,200 | 7b0dfb0cdbdcb402c000d30399dbfd2eeebe1266 | SyscallRules merge and add were dropping AllowAny rules | [
{
"change_type": "MODIFY",
"old_path": "pkg/seccomp/seccomp_rules.go",
"new_path": "pkg/seccomp/seccomp_rules.go",
"diff": "@@ -34,7 +34,7 @@ func seccompDataOffsetArgLow(i int) uint32 {\n}\nfunc seccompDataOffsetArgHigh(i int) uint32 {\n- return uint32(seccompDataOffsetArgs + i*8 + 4)\n+ return sec... | Go | Apache License 2.0 | google/gvisor | SyscallRules merge and add were dropping AllowAny rules
PiperOrigin-RevId: 210131001
Change-Id: I285707c5143b3e4c9a6948c1d1a452b6f16e65b7 |
259,891 | 27.08.2018 10:48:02 | 25,200 | 2524111fc63343fd7372f5ea0266130adea778a5 | runsc: Terminal resizing support.
Implements the TIOCGWINSZ and TIOCSWINSZ ioctls, which allow processes to resize
the terminal. This allows, for example, sshd to properly set the window size for
ssh sessions. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/tty.go",
"new_path": "pkg/abi/linux/tty.go",
"diff": "@@ -328,3 +328,13 @@ var DefaultSlaveTermios = KernelTermios{\nInputSpeed: 38400,\nOutputSpeed: 38400,\n}\n+\n+// WindowSize corresponds to struct winsize defined in\n+// include/uapi/asm-gene... | Go | Apache License 2.0 | google/gvisor | runsc: Terminal resizing support.
Implements the TIOCGWINSZ and TIOCSWINSZ ioctls, which allow processes to resize
the terminal. This allows, for example, sshd to properly set the window size for
ssh sessions.
PiperOrigin-RevId: 210392504
Change-Id: I0d4789154d6d22f02509b31d71392e13ee4a50ba |
259,948 | 27.08.2018 11:54:15 | 25,200 | bd01816c872672b74998694bb6e759df2a336735 | sentry: mark fsutil.DirFileOperations as savable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/fsutil/file.go",
"new_path": "pkg/sentry/fs/fsutil/file.go",
"diff": "@@ -214,6 +214,8 @@ func (NoIoctl) Ioctl(ctx context.Context, io usermem.IO, args arch.SyscallArgume\n}\n// DirFileOperations implements FileOperations for directories.\n+//\n+... | Go | Apache License 2.0 | google/gvisor | sentry: mark fsutil.DirFileOperations as savable.
PiperOrigin-RevId: 210405166
Change-Id: I252766015885c418e914007baf2fc058fec39b3e |
259,858 | 27.08.2018 13:35:50 | 25,200 | b9ded9bf399422d09f2f2bd32cd4960d24b424bf | Add runsc-race target. | [
{
"change_type": "MODIFY",
"old_path": "runsc/BUILD",
"new_path": "runsc/BUILD",
"diff": "@@ -19,3 +19,32 @@ go_binary(\n\"@com_github_google_subcommands//:go_default_library\",\n],\n)\n+\n+# The runsc-race target is a race-compatible BUILD target. This must be built\n+# via \"bazel build --features... | Go | Apache License 2.0 | google/gvisor | Add runsc-race target.
PiperOrigin-RevId: 210422178
Change-Id: I984dd348d467908bc3180a20fc79b8387fcca05e |
260,013 | 27.08.2018 17:20:36 | 25,200 | f0492d45aa31e32f8a04b13b7bf53e0161e1afb6 | Add /proc/sys/kernel/shm[all,max,mni]. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/shm.go",
"new_path": "pkg/abi/linux/shm.go",
"diff": "package linux\n+import \"math\"\n+\n// shmat(2) flags. Source: include/uapi/linux/shm.h\nconst (\nSHM_RDONLY = 010000 // Read-only access.\n@@ -38,6 +40,15 @@ const (\nSHM_INFO = 14\n)\n+// SH... | Go | Apache License 2.0 | google/gvisor | Add /proc/sys/kernel/shm[all,max,mni].
PiperOrigin-RevId: 210459956
Change-Id: I51859b90fa967631e0a54a390abc3b5541fbee66 |
259,891 | 27.08.2018 20:33:38 | 25,200 | a4529c1b5b485f6283367bfdc0e4228bbbd3e51f | runsc: Fix readonly filesystem causing failure to create containers.
For readonly filesystems specified via relative path, we were forgetting to
mount relative to the container's bundle directory. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/BUILD",
"new_path": "runsc/container/BUILD",
"diff": "@@ -29,7 +29,6 @@ go_library(\n\"//runsc/specutils\",\n\"@com_github_cenkalti_backoff//:go_default_library\",\n\"@com_github_opencontainers_runtime-spec//specs-go:go_default_library\",\n- \"... | Go | Apache License 2.0 | google/gvisor | runsc: Fix readonly filesystem causing failure to create containers.
For readonly filesystems specified via relative path, we were forgetting to
mount relative to the container's bundle directory.
PiperOrigin-RevId: 210483388
Change-Id: I84809fce4b1f2056d0e225547cb611add5f74177 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.