author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20
values | license stringclasses 3
values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,992 | 17.05.2018 23:21:47 | 25,200 | a1e5862f3c7b0a3baabee2311d3d519d322a0168 | Move postgres to list of supported images | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -370,6 +370,7 @@ The following applications/images have been tested:\n* mysql\n* node\n* php\n+* postgres\n* prometheus\n* python\n* redis\n@@ -385,8 +386,6 @@ The following applications have been tested and may... | Go | Apache License 2.0 | google/gvisor | Move postgres to list of supported images
PiperOrigin-RevId: 197104043
Change-Id: I377c0727ebf0c44361ed221e1b197787825bfb7b |
259,858 | 21.05.2018 16:48:41 | 25,200 | 61b0b19497e9ac417de5a600e6ff06d52db4268f | Dramatically improve handling of KVM vCPU pool.
Especially in situations with small numbers of vCPUs, the existing
system resulted in excessive thrashing. Now, execution contexts
co-ordinate as smoothly as they can to share a small number of cores. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/context.go",
"new_path": "pkg/sentry/platform/kvm/context.go",
"diff": "@@ -41,10 +41,7 @@ func (c *context) Switch(as platform.AddressSpace, ac arch.Context, _ int32) (*a\nfp := (*byte)(ac.FloatingPointData())\n// Grab a vCPU.\n- cpu, ... | Go | Apache License 2.0 | google/gvisor | Dramatically improve handling of KVM vCPU pool.
Especially in situations with small numbers of vCPUs, the existing
system resulted in excessive thrashing. Now, execution contexts
co-ordinate as smoothly as they can to share a small number of cores.
PiperOrigin-RevId: 197483323
Change-Id: I0afc0c5363ea9386994355baf3904bf5fe08c56c |
259,992 | 21.05.2018 17:47:13 | 25,200 | ed2b86a54942dfd245e9f872e6da52d9bde0da6d | Fix test failure when user can't mount temp dir | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -434,6 +434,17 @@ func TestCapabilities(t *testing.T) {\nType: \"bind\",\n})\n+ // Capability below is needed to mount TempDir above in case the user doesn't\n+ //... | Go | Apache License 2.0 | google/gvisor | Fix test failure when user can't mount temp dir
PiperOrigin-RevId: 197491098
Change-Id: Ifb75bd4e4f41b84256b6d7afc4b157f6ce3839f3 |
259,854 | 22.05.2018 11:53:42 | 25,200 | 3a6070dc9882d43b00bd66b23492daa422435c7c | Clarify that syserr.New must only be called during init | [
{
"change_type": "MODIFY",
"old_path": "pkg/syserr/syserr.go",
"new_path": "pkg/syserr/syserr.go",
"diff": "@@ -31,6 +31,8 @@ type Error struct {\n}\n// New creates a new Error and adds a translation for it.\n+//\n+// New must only be called at init.\nfunc New(message string, linuxTranslation *linux... | Go | Apache License 2.0 | google/gvisor | Clarify that syserr.New must only be called during init
PiperOrigin-RevId: 197599402
Change-Id: I23eb0336195ab0d3e5fb49c0c57fc9e0715a9b75 |
259,891 | 22.05.2018 13:46:37 | 25,200 | 705605f9011cfbd58f407ca84bc4c2d8cf39d80b | sentry: Add simple SIOCGIFFLAGS support (IFF_RUNNING and IFF_PROMIS).
Establishes a way of communicating interface flags between netstack and
epsocket. More flags can be added over time. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -48,12 +48,15 @@ import (\n\"gvisor.googlesource.com/gvisor/pkg/syserror\"\n\"gvisor.googlesource.com/gvisor/pkg/tcpip\"\n\"gvisor.googlesource.com/gviso... | Go | Apache License 2.0 | google/gvisor | sentry: Add simple SIOCGIFFLAGS support (IFF_RUNNING and IFF_PROMIS).
Establishes a way of communicating interface flags between netstack and
epsocket. More flags can be added over time.
PiperOrigin-RevId: 197616669
Change-Id: I230448c5fb5b7d2e8d69b41a451eb4e1096a0e30 |
260,013 | 22.05.2018 15:51:55 | 25,200 | 257ab8de93312295d475638498c57e4de77a4b02 | When sending a RST the acceptable ACK window shouldn't change.
Today when we transmit a RST it's happening during the time-wait
flow. Because a FIN is allowed to advance the acceptable ACK window
we're incorrectly doing that for a RST. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/snd.go",
"new_path": "pkg/tcpip/transport/tcp/snd.go",
"diff": "@@ -342,15 +342,17 @@ func (s *sender) sendData() {\ns.ep.mu.Lock()\n// We're sending a FIN by default\nfl := flagFin\n+ segEnd = seg.sequenceNumber\nif (s.ep.shutdownFlags... | Go | Apache License 2.0 | google/gvisor | When sending a RST the acceptable ACK window shouldn't change.
Today when we transmit a RST it's happening during the time-wait
flow. Because a FIN is allowed to advance the acceptable ACK window
we're incorrectly doing that for a RST.
PiperOrigin-RevId: 197637565
Change-Id: I080190b06bd0225326cd68c1fbf37bd3fdbd414e |
259,992 | 22.05.2018 16:35:58 | 25,200 | 51c95c270be3e0c3867c1bc93cc454b32b276721 | Remove offset check to match with Linux implementation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -870,11 +870,11 @@ const (\n// This implementation currently ignores the provided advice.\nfunc Fadvise64(t *kernel.Task, args arch.SyscallArguments) (uint... | Go | Apache License 2.0 | google/gvisor | Remove offset check to match with Linux implementation.
PiperOrigin-RevId: 197644246
Change-Id: I63eb0a58889e69fbc4af2af8232f6fa1c399d43f |
259,854 | 23.05.2018 14:27:52 | 25,200 | 02ad0dc3d9909fb93dd41d7f8976be4fc54a99d5 | Fix typo in TCP transport | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -818,7 +818,7 @@ func (e *endpoint) protocolMainLoop(passive bool) *tcpip.Error {\nvar closeWaker sleep.Waker\ndefer func() {\n- // e.mu is expected to be hold u... | Go | Apache License 2.0 | google/gvisor | Fix typo in TCP transport
PiperOrigin-RevId: 197789418
Change-Id: I86b1574c8d3b8b321348d9b101ffaef7aa15f722 |
260,013 | 23.05.2018 15:00:59 | 25,200 | 7996ae7ccf284718fc98f5ba34c94b044b858ec2 | Adding test case for RST acceptable ack panic | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/tcp_test.go",
"diff": "@@ -400,7 +400,20 @@ func TestRstOnCloseWithUnreadData(t *testing.T) {\nchecker.TCP(\nchecker.DstPort(context.TestPort),\nchecker.TCPFlags(header.TCPFlagAck|heade... | Go | Apache License 2.0 | google/gvisor | Adding test case for RST acceptable ack panic
PiperOrigin-RevId: 197795613
Change-Id: I759dd04995d900cba6b984649fa48bbc880946d6 |
259,992 | 24.05.2018 14:27:05 | 25,200 | e48f7078761b00552ac74068c184ee4fb90fe9aa | Configure sandbox as superuser
Container user might not have enough priviledge to walk directories and
mount filesystems. Instead, create superuser to perform these steps of
the configuration. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -51,21 +51,30 @@ func (f *fdDispenser) empty() bool {\nreturn len(f.fds) == 0\n}\n-// createMountNamespace creates a mount manager containing the root filesystem\n-// and all mounts.\n-func createM... | Go | Apache License 2.0 | google/gvisor | Configure sandbox as superuser
Container user might not have enough priviledge to walk directories and
mount filesystems. Instead, create superuser to perform these steps of
the configuration.
PiperOrigin-RevId: 197953667
Change-Id: I643650ab654e665408e2af1b8e2f2aa12d58d4fb |
260,013 | 24.05.2018 15:17:42 | 25,200 | 7f62e9c32ea6af19ccd92107252fd869e6ef1005 | rpcinet connect doesn't handle all errnos correctly.
These were causing non-blocking related errnos to be returned to
the sentry when they were created as blocking FDs internally. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -213,10 +213,10 @@ func (s *socketOperations) Connect(t *kernel.Task, sockaddr []byte, blocking boo\n// Register for notification when the endpoint becomes wri... | Go | Apache License 2.0 | google/gvisor | rpcinet connect doesn't handle all errnos correctly.
These were causing non-blocking related errnos to be returned to
the sentry when they were created as blocking FDs internally.
PiperOrigin-RevId: 197962932
Change-Id: I3f843535ff87ebf4cb5827e9f3d26abfb79461b0 |
260,013 | 24.05.2018 15:45:55 | 25,200 | a8b90a7158d4197428639c912d97f3bdbaf63f5a | Poll should wake up on ECONNREFUSED with no mask.
Today poll will not wake up on a ECONNREFUSED if no poll mask
is specified, which is equivalent to POLLHUP | POLLERR which are
implicitly added during the poll syscall. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -819,7 +819,8 @@ func (e *endpoint) protocolMainLoop(passive bool) *tcpip.Error {\ndefer func() {\n// e.mu is expected to be held upon entering this section.\n- ... | Go | Apache License 2.0 | google/gvisor | Poll should wake up on ECONNREFUSED with no mask.
Today poll will not wake up on a ECONNREFUSED if no poll mask
is specified, which is equivalent to POLLHUP | POLLERR which are
implicitly added during the poll syscall.
PiperOrigin-RevId: 197967183
Change-Id: I668d0730c33701228913f2d0843b48491b642efb |
259,992 | 29.05.2018 17:57:26 | 25,200 | 812e83d3bbb99d4fa1ece4712a1ac85e84fe6ec3 | Supress error when deleting non-existing container with --force
This addresses the first issue reported in CRI-O expects runsc to
return success to delete when --force is used with a non-existing container. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/BUILD",
"new_path": "runsc/cmd/BUILD",
"diff": "@@ -44,13 +44,17 @@ go_library(\ngo_test(\nname = \"cmd_test\",\nsize = \"small\",\n- srcs = [\"exec_test.go\"],\n+ srcs = [\n+ \"delete_test.go\",\n+ \"exec_test.go\",\n+ ],\nembed = [\":cmd\"],\ndeps ... | Go | Apache License 2.0 | google/gvisor | Supress error when deleting non-existing container with --force
This addresses the first issue reported in #59. CRI-O expects runsc to
return success to delete when --force is used with a non-existing container.
PiperOrigin-RevId: 198487418
Change-Id: If7660e8fdab1eb29549d0a7a45ea82e20a1d4f4a |
259,992 | 31.05.2018 10:53:08 | 25,200 | 3547c4886773acec0ac562104f055528ed490b75 | Add SHA512 file to nightly build | [
{
"change_type": "MODIFY",
"old_path": "kokoro/gcp_ubuntu/release-nightly.cfg",
"new_path": "kokoro/gcp_ubuntu/release-nightly.cfg",
"diff": "build_file: \"repo/kokoro/gcp_ubuntu/run_build.sh\"\naction {\n- # Upload only the runsc binary. It may be in multiple paths, so we must use\n- # the wildcard... | Go | Apache License 2.0 | google/gvisor | Add SHA512 file to nightly build
PiperOrigin-RevId: 198745666
Change-Id: I38d4163cd65f1236b09ce4f6481197a9a9fd29f2 |
259,992 | 01.06.2018 10:08:40 | 25,200 | 65dadc00297d946e86b2e95b0279fb6dc94542dd | Ignores IPv6 addresses when configuring network
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/network.go",
"new_path": "runsc/sandbox/network.go",
"diff": "@@ -188,14 +188,14 @@ func createInterfacesAndRoutesFromNS(conn *urpc.Client, nsPath string) error {\ncontinue\n}\n- ifaddrs, err := iface.Addrs()\n+ allAddrs, err := iface.Addrs()\nif... | Go | Apache License 2.0 | google/gvisor | Ignores IPv6 addresses when configuring network
Closes #60
PiperOrigin-RevId: 198887885
Change-Id: I9bf990ee3fde9259836e57d67257bef5b85c6008 |
260,013 | 01.06.2018 14:58:46 | 25,200 | 0212f222c74b9f88c5c74d920127e47e942dc376 | Fix refcount bug in rpcinet socketOperations.Accept. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -277,8 +277,10 @@ func (s *socketOperations) Accept(t *kernel.Task, peerRequested bool, flags int,\nfile := fs.NewFile(t, dirent, fs.FileFlags{Read: true, Writ... | Go | Apache License 2.0 | google/gvisor | Fix refcount bug in rpcinet socketOperations.Accept.
PiperOrigin-RevId: 198931222
Change-Id: I69ee12318e87b9a6a4a94b18a9bf0ae4e39d7eaf |
259,992 | 02.06.2018 15:21:42 | 25,200 | 43dd424f424832415486ba354a2b8d2343ea2d4a | Add SHA512 pointer to README | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -170,8 +170,9 @@ binaries).\n### Download a Nightly Build\n-The easiest way to get `runsc` is from a the latest nightly build.\n-[here][runsc-nightly].\n+The easiest way to get `runsc` is from the\n+[latest nigh... | Go | Apache License 2.0 | google/gvisor | Add SHA512 pointer to README
PiperOrigin-RevId: 199008198
Change-Id: I6d1a0107ae1b11f160b42a2cabaf1fb8ce419edf |
259,992 | 04.06.2018 10:27:33 | 25,200 | 0929bdee3450aa6bc2393227127fe72405b82e4a | Fix checksum file for today's build | [
{
"change_type": "MODIFY",
"old_path": "kokoro/gcp_ubuntu/run_build.sh",
"new_path": "kokoro/gcp_ubuntu/run_build.sh",
"diff": "@@ -39,4 +39,4 @@ mkdir -p \"${latest_dir}\" \"${today_dir}\"\ncp bazel-bin/runsc/linux_amd64_pure_stripped/runsc \"${latest_dir}\"\nsha512sum \"${latest_dir}\"/runsc | awk... | Go | Apache License 2.0 | google/gvisor | Fix checksum file for today's build
PiperOrigin-RevId: 199153448
Change-Id: Ic1f0456191080117a8586f77dd2fb44dc53754ca |
259,992 | 04.06.2018 11:51:27 | 25,200 | 55a37ceef1e33cc72236db6e95f159963ddf40bd | Fix leaky FD
9P socket was being created without CLOEXEC and was being inherited
by the children. This would prevent the gofer from detecting that the
sandbox had exited, because the socket would not be closed. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/BUILD",
"new_path": "runsc/sandbox/BUILD",
"diff": "package(licenses = [\"notice\"]) # Apache 2.0\n-load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\")\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\")\ngo_library(\nnam... | Go | Apache License 2.0 | google/gvisor | Fix leaky FD
9P socket was being created without CLOEXEC and was being inherited
by the children. This would prevent the gofer from detecting that the
sandbox had exited, because the socket would not be closed.
PiperOrigin-RevId: 199168959
Change-Id: I3ee1a07cbe7331b0aeb1cf2b697e728ce24f85a7 |
259,992 | 04.06.2018 12:13:33 | 25,200 | 78ccd1298e1386d9c5e0eb10d328ecb16b28ea02 | Return 'running' if gofer is still alive
Containerd will start deleting container and rootfs after container
is stopped. However, if gofer is still running, rootfs cleanup will
fail because of device busy.
This CL makes sure that gofer is not running when container state is
stopped.
Change from: | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -186,6 +186,8 @@ func TestLifecycle(t *testing.T) {\n// ourselves.\np, _ := os.FindProcess(s.Sandbox.Pid)\np.Wait()\n+ g, _ := os.FindProcess(s.Sandbox.GoferPid)\n... | Go | Apache License 2.0 | google/gvisor | Return 'running' if gofer is still alive
Containerd will start deleting container and rootfs after container
is stopped. However, if gofer is still running, rootfs cleanup will
fail because of device busy.
This CL makes sure that gofer is not running when container state is
stopped.
Change from: lantaol@google.com
PiperOrigin-RevId: 199172668
Change-Id: I9d874eec3ecf74fd9c8edd7f62d9f998edef66fe |
259,992 | 04.06.2018 12:30:47 | 25,200 | 6c585b8eb69362db9af5ed150763096874832b86 | Create destination mount dir if it doesn't exist | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/fs.go",
"new_path": "runsc/boot/fs.go",
"diff": "@@ -288,11 +288,21 @@ func mountSubmount(ctx context.Context, spec *specs.Spec, conf *Config, mns *fs.\nif useOverlay {\nlog.Debugf(\"Adding overlay on top of mount %q\", m.Destination)\n- if inode, e... | Go | Apache License 2.0 | google/gvisor | Create destination mount dir if it doesn't exist
PiperOrigin-RevId: 199175296
Change-Id: I694ad1cfa65572c92f77f22421fdcac818f44630 |
259,992 | 04.06.2018 18:04:05 | 25,200 | 19a0e83b50fbcfd89927baedbb1f1fd14dc448ca | Make fsgofer attach more strict
Refuse to mount paths with "." and ".." in the path to prevent
a compromised Sentry to mount "../../secrets". Only allow
Attach to be called once per mount point. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -26,7 +26,6 @@ import (\n\"math\"\n\"os\"\n\"path\"\n- \"path/filepath\"\n\"strings\"\n\"sync\"\n\"syscall\"\n@@ -83,6 +82,9 @@ type Config struct {\ntype attachPoint struct {\npref... | Go | Apache License 2.0 | google/gvisor | Make fsgofer attach more strict
Refuse to mount paths with "." and ".." in the path to prevent
a compromised Sentry to mount "../../secrets". Only allow
Attach to be called once per mount point.
PiperOrigin-RevId: 199225929
Change-Id: I2a3eb7ea0b23f22eb8dde2e383e32563ec003bd5 |
260,013 | 05.06.2018 15:43:55 | 25,200 | ff7b4a156f95a587b5df4de89a22c200fceabb96 | Add support for rpcinet owned procfs files.
This change will add support for /proc/sys/net and /proc/net which will
be managed and owned by rpcinet. This will allow these inodes to be forward
as rpcs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/BUILD",
"new_path": "pkg/sentry/fs/proc/BUILD",
"diff": "@@ -44,6 +44,7 @@ go_library(\n\"net.go\",\n\"proc.go\",\n\"proc_state.go\",\n+ \"rpcinet_proc.go\",\n\"stat.go\",\n\"sys.go\",\n\"sys_net.go\",\n@@ -70,6 +71,7 @@ go_library(\n\"//pkg... | Go | Apache License 2.0 | google/gvisor | Add support for rpcinet owned procfs files.
This change will add support for /proc/sys/net and /proc/net which will
be managed and owned by rpcinet. This will allow these inodes to be forward
as rpcs.
PiperOrigin-RevId: 199370799
Change-Id: I2c876005d98fe55dd126145163bee5a645458ce4 |
260,013 | 06.06.2018 15:52:29 | 25,200 | 79fef54eb1b9e941e2c910f90b65f3cfe94e18c4 | Add support for rpcinet ioctl(2).
This change will add support for ioctls that have previously
been supported by netstack.
LINE_LENGTH_IGNORE | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -56,6 +56,10 @@ type socketOperations struct {\n// Verify that we actually implement socket.Socket.\nvar _ = socket.Socket(&socketOperations{})\n+const (\n+ si... | Go | Apache License 2.0 | google/gvisor | Add support for rpcinet ioctl(2).
This change will add support for ioctls that have previously
been supported by netstack.
LINE_LENGTH_IGNORE
PiperOrigin-RevId: 199544114
Change-Id: I3769202c19502c3b7d05e06ea9552acfd9255893 |
259,891 | 06.06.2018 16:12:58 | 25,200 | 206e90d057211f2ac53174907b2ff04801f9a481 | runsc: Support abbreviated container IDs.
Just a UI/usability addition. It's a lot easier to type "60" than
"60185c721d7e10c00489f1fa210ee0d35c594873d6376b457fb1815e4fdbfc2c". | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/delete_test.go",
"new_path": "runsc/cmd/delete_test.go",
"diff": "@@ -31,11 +31,11 @@ func TestNotFound(t *testing.T) {\nd := Delete{}\nif err := d.execute(ids, conf); err == nil {\n- t.Error(\"Deleting non-existend container should have failed\")\n+... | Go | Apache License 2.0 | google/gvisor | runsc: Support abbreviated container IDs.
Just a UI/usability addition. It's a lot easier to type "60" than
"60185c721d7e10c00489f1fa210ee0d35c594873d6376b457fb1815e4fdbfc2c".
PiperOrigin-RevId: 199547932
Change-Id: I19011b5061a88aba48a9ad7f8cf954a6782de854 |
260,013 | 07.06.2018 11:36:26 | 25,200 | 7e9893eeb500ab56dcab80471300df50c12288ae | Add missing rpcinet ioctls. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -417,10 +417,22 @@ func (s *socketOperations) Ioctl(ctx context.Context, io usermem.IO, args arch.S\nvar buf []byte\nswitch cmd {\n// The following ioctls take... | Go | Apache License 2.0 | google/gvisor | Add missing rpcinet ioctls.
PiperOrigin-RevId: 199669120
Change-Id: I0be88cdbba29760f967e9a5bb4144ca62c1ed7aa |
260,013 | 07.06.2018 15:09:27 | 25,200 | 5c37097e34a513845d77bb8b7240f0074aa1c1e9 | rpcinet should not block in read(2) rpcs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -145,31 +145,10 @@ func (s *socketOperations) Read(ctx context.Context, _ *fs.File, dst usermem.IOS\nn, e := dst.CopyOut(ctx, res.Data)\nreturn int64(n), e\n}\... | Go | Apache License 2.0 | google/gvisor | rpcinet should not block in read(2) rpcs.
PiperOrigin-RevId: 199703609
Change-Id: I8153b0396b22a230a68d4b69c46652a5545f7630 |
259,992 | 08.06.2018 09:58:29 | 25,200 | 5c51bc51e43a0f1d1f06ae490b0d352d1b483766 | Drop capabilities not needed by Gofer | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -5,7 +5,6 @@ load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\")\ngo_library(\nname = \"boot\",\nsrcs = [\n- \"capability.go\",\n\"config.go\",\n\"controller.go\",\n\"events.go\",... | Go | Apache License 2.0 | google/gvisor | Drop capabilities not needed by Gofer
PiperOrigin-RevId: 199808391
Change-Id: Ib37a4fb6193dc85c1f93bc16769d6aa41854b9d4 |
259,962 | 08.06.2018 11:45:30 | 25,200 | de8dba205f66a07c793619a3896f2376b41a4b55 | Add a protocol option to set congestion control algorithm.
Also adds support to query available congestion control algorithms. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/protocol.go",
"new_path": "pkg/tcpip/transport/tcp/protocol.go",
"diff": "package tcp\nimport (\n+ \"strings\"\n\"sync\"\n\"gvisor.googlesource.com/gvisor/pkg/tcpip\"\n@@ -58,11 +59,21 @@ type ReceiveBufferSizeOption struct {\nMax int\n... | Go | Apache License 2.0 | google/gvisor | Add a protocol option to set congestion control algorithm.
Also adds support to query available congestion control algorithms.
PiperOrigin-RevId: 199826897
Change-Id: I2b338b709820ee9cf58bb56d83aa7b1a39f4eab2 |
259,858 | 08.06.2018 15:00:29 | 25,200 | 6728f09910bd9f7633f277fafe6945cfaa2abf42 | Fix sigaltstack semantics.
Walking off the bottom of the sigaltstack, for example with recursive faults,
results in forced signal delivery, not resetting the stack or pushing signal
stack to whatever happens to lie below the signal stack. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/arch/arch.go",
"new_path": "pkg/sentry/arch/arch.go",
"diff": "@@ -158,7 +158,7 @@ type Context interface {\n// rt is true if SignalRestore is being entered from rt_sigreturn and\n// false if SignalRestore is being entered from sigreturn.\n// Signal... | Go | Apache License 2.0 | google/gvisor | Fix sigaltstack semantics.
Walking off the bottom of the sigaltstack, for example with recursive faults,
results in forced signal delivery, not resetting the stack or pushing signal
stack to whatever happens to lie below the signal stack.
PiperOrigin-RevId: 199856085
Change-Id: I0004d2523f0df35d18714de2685b3eaa147837e0 |
260,013 | 08.06.2018 15:57:33 | 25,200 | 2fbd1cf57cb06c5f0165a2d0e9225eed242a41f5 | Add checks for short CopyOut in rpcinet | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -465,7 +465,10 @@ func (s *socketOperations) RecvMsg(t *kernel.Task, dst usermem.IOSequence, flags\nres, err := rpcRecvMsg(t, req)\nif err == nil {\n- _, e := ... | Go | Apache License 2.0 | google/gvisor | Add checks for short CopyOut in rpcinet
PiperOrigin-RevId: 199864753
Change-Id: Ibace6a1fdf99ee6ce368ac12c390aa8a02dbdfb7 |
259,858 | 08.06.2018 17:50:55 | 25,200 | c0ab059e7b904197f52ade879711d7fb02ffa8c0 | Fix kernel flags handling and add missing vectors. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -150,13 +150,20 @@ func (c *vCPU) fault(signal int32) (*arch.SignalInfo, usermem.AccessType, error)\n// the code provided here. We need to re-execute... | Go | Apache License 2.0 | google/gvisor | Fix kernel flags handling and add missing vectors.
PiperOrigin-RevId: 199877174
Change-Id: I9d19ea301608c2b989df0a6123abb1e779427853 |
259,891 | 11.06.2018 11:08:51 | 25,200 | 032b0398a5a664c345c4868d5527846a1b6848db | Sentry: split tty.queue into its own file.
Minor refactor. line_discipline.go was home to 2 large structs (lineDiscipline
and queue), and queue is now large enough IMO to get its own file.
Also moves queue locks into the queue struct, making locking simpler. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/tty/BUILD",
"new_path": "pkg/sentry/fs/tty/BUILD",
"diff": "@@ -11,6 +11,7 @@ go_stateify(\n\"inode.go\",\n\"line_discipline.go\",\n\"master.go\",\n+ \"queue.go\",\n\"slave.go\",\n\"terminal.go\",\n],\n@@ -26,6 +27,7 @@ go_library(\n\"inode.go\",... | Go | Apache License 2.0 | google/gvisor | Sentry: split tty.queue into its own file.
Minor refactor. line_discipline.go was home to 2 large structs (lineDiscipline
and queue), and queue is now large enough IMO to get its own file.
Also moves queue locks into the queue struct, making locking simpler.
PiperOrigin-RevId: 200080301
Change-Id: Ia75a0e9b3d9ac8d7e5a0f0099a54e1f5b8bdea34 |
259,992 | 11.06.2018 13:34:27 | 25,200 | 7260363751915d21538c13b08b5bb6a48d0f4f8e | Add O_TRUNC handling in openat | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_file.go",
"new_path": "pkg/sentry/syscalls/linux/sys_file.go",
"diff": "@@ -147,21 +147,25 @@ func openAt(t *kernel.Task, dirFD kdefs.FD, addr usermem.Addr, flags uint) (fd u\n}\nfileFlags := linuxToFlags(flags)\n- isDir := fs.IsD... | Go | Apache License 2.0 | google/gvisor | Add O_TRUNC handling in openat
PiperOrigin-RevId: 200103677
Change-Id: I3efb565c30c64d35f8fd7b5c05ed78dcc2990c51 |
260,013 | 11.06.2018 15:33:07 | 25,200 | 0412f17e06670fb1f1d1d85ddd73bbadde40c087 | rpcinet is treating EAGAIN and EWOULDBLOCK as different errnos. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -228,7 +228,7 @@ func (s *socketOperations) Accept(t *kernel.Task, peerRequested bool, flags int,\npayload, se := rpcAccept(t, s.fd, peerRequested)\n// Check i... | Go | Apache License 2.0 | google/gvisor | rpcinet is treating EAGAIN and EWOULDBLOCK as different errnos.
PiperOrigin-RevId: 200124614
Change-Id: I38a7b083f1464a2a586fe24db648e624c455fec5 |
259,992 | 11.06.2018 16:44:56 | 25,200 | ea4a468fbaacd55597ce89e3eabd2bb42746427b | Set CLOEXEC option to sockets
hostinet/socket.go: the Sentry doesn't spawn new processes, but it doesn't hurt to protect the socket from leaking.
unet/unet.go: should be setting closing on exec. The FD is explicitly donated to children when needed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -193,7 +193,7 @@ func (s *socketOperations) Accept(t *kernel.Task, peerRequested bool, flags int,\n// Conservatively ignore all flags specified by the applic... | Go | Apache License 2.0 | google/gvisor | Set CLOEXEC option to sockets
hostinet/socket.go: the Sentry doesn't spawn new processes, but it doesn't hurt to protect the socket from leaking.
unet/unet.go: should be setting closing on exec. The FD is explicitly donated to children when needed.
PiperOrigin-RevId: 200135682
Change-Id: Ia8a45ced1e00a19420c8611b12e7a8ee770f89cb |
259,858 | 11.06.2018 17:56:18 | 25,200 | 09b0a9c320bd777bc52384bd0ec91ecfc61e481d | Handle all exception vectors. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -137,6 +137,18 @@ func (c *vCPU) initArchState() error {\nreturn c.setSystemTime()\n}\n+// nonCanonical generates a canonical address return.\n+//\n+... | Go | Apache License 2.0 | google/gvisor | Handle all exception vectors.
PiperOrigin-RevId: 200144655
Change-Id: I5a753c74b75007b7714d6fe34aa0d2e845dc5c41 |
259,858 | 11.06.2018 18:16:13 | 25,200 | 41f766893ab804cd2d3ccfd782d97c022e987f79 | Minor ring0 interface cleanup.
Remove unused methods.
Provide declaration for asm function. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -40,7 +40,7 @@ type machine struct {\nnextSlot uint32\n// kernel is the set of global structures.\n- kernel *ring0.Kernel\n+ kernel ring0.Kernel\n// mappingCache... | Go | Apache License 2.0 | google/gvisor | Minor ring0 interface cleanup.
- Remove unused methods.
- Provide declaration for asm function.
PiperOrigin-RevId: 200146850
Change-Id: Ic455c96ffe0d2e78ef15f824eb65d7de705b054a |
259,992 | 12.06.2018 10:24:56 | 25,200 | 48335318a23f4f536c395e602c0cd338c4c4e890 | Enable debug logging in tests
Unit tests call runsc directly now, so all command line arguments
are valid. On the other hand, enabling debug in the test binary
doesn't affect runsc. It needs to be set in the config. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -176,18 +176,10 @@ type Config struct {\n// DisableSeccomp indicates whether seccomp syscall filters should be\n// disabled. Pardon the double negation, but default to enabled is important.... | Go | Apache License 2.0 | google/gvisor | Enable debug logging in tests
Unit tests call runsc directly now, so all command line arguments
are valid. On the other hand, enabling debug in the test binary
doesn't affect runsc. It needs to be set in the config.
PiperOrigin-RevId: 200237706
Change-Id: I0b5922db17f887f58192dbc2f8dd2fd058b76ec7 |
259,891 | 12.06.2018 11:02:35 | 25,200 | 2dc9cd7bf73d971a37fa22b52a70961f27f6c970 | runsc: enable terminals in the sandbox.
runsc now mounts the devpts filesystem, so you get a real terminal using
ssh+sshd. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -35,6 +35,7 @@ go_library(\n\"//pkg/sentry/fs/ramfs\",\n\"//pkg/sentry/fs/sys\",\n\"//pkg/sentry/fs/tmpfs\",\n+ \"//pkg/sentry/fs/tty\",\n\"//pkg/sentry/inet\",\n\"//pkg/sentry/kernel\",\n\"//pkg/s... | Go | Apache License 2.0 | google/gvisor | runsc: enable terminals in the sandbox.
runsc now mounts the devpts filesystem, so you get a real terminal using
ssh+sshd.
PiperOrigin-RevId: 200244830
Change-Id: If577c805ad0138fda13103210fa47178d8ac6605 |
259,885 | 12.06.2018 12:37:06 | 25,200 | 7a10df454b1c12b207f479cdda7338fff2875d5f | Drop MMapOpts.MappingIdentity reference in loader.mapSegment. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/elf.go",
"new_path": "pkg/sentry/loader/elf.go",
"diff": "@@ -271,6 +271,11 @@ func mapSegment(ctx context.Context, m *mm.MemoryManager, f *fs.File, phdr *elf.\nPerms: prot,\nMaxPerms: usermem.AnyAccess,\n}\n+ defer func() {\n+ if mopts.Mappi... | Go | Apache License 2.0 | google/gvisor | Drop MMapOpts.MappingIdentity reference in loader.mapSegment.
PiperOrigin-RevId: 200261995
Change-Id: I7e460b18ceab2c23096bdeb7416159d6e774aaf7 |
260,013 | 12.06.2018 16:15:21 | 25,200 | c2b3f04d1c7b5d376a3fa305fc5e309e9ec81d99 | Rpcinet doensn't handle SO_RCVTIMEO properly.
Rpcinet already inherits socket.ReceiveTimeout; however, it's
never set on setsockopt(2). The value is currently forwarded
as an RPC and ignored as all sockets will be non-blocking
on the RPC side. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"syscall\"\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n+ \"gvisor.googlesource.com/gvisor/pkg/binary\"\n\"gvisor.googlesource.... | Go | Apache License 2.0 | google/gvisor | Rpcinet doensn't handle SO_RCVTIMEO properly.
Rpcinet already inherits socket.ReceiveTimeout; however, it's
never set on setsockopt(2). The value is currently forwarded
as an RPC and ignored as all sockets will be non-blocking
on the RPC side.
PiperOrigin-RevId: 200299260
Change-Id: I6c610ea22c808ff6420c63759dccfaeab17959dd |
259,854 | 12.06.2018 17:03:31 | 25,200 | ba426f7782d35f971820a0193cfda58485b92cad | Fix reference leak for negative dirents | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -1257,6 +1257,15 @@ func (d *Dirent) destroy() {\n// Drop all weak references.\nfor _, w := range d.children {\n+ if c := w.Get(); c != nil {\n+ if c.(*Dirent).IsNegative() {\n+ // Th... | Go | Apache License 2.0 | google/gvisor | Fix reference leak for negative dirents
PiperOrigin-RevId: 200306715
Change-Id: I7c80059c77ebd3d9a5d7d48b05c8e7a597f10850 |
259,885 | 13.06.2018 10:03:06 | 25,200 | 55b905845650efc9a0a23066f8ffd25ce2565bbc | Log filemem state when panicing due to invalid refcount. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/filemem/filemem.go",
"new_path": "pkg/sentry/platform/filemem/filemem.go",
"diff": "@@ -156,17 +156,6 @@ type usageInfo struct {\nrefs uint64\n}\n-func (u *usageInfo) incRef() {\n- u.refs++\n-}\n-\n-func (u *usageInfo) decRef() {\n- if u.re... | Go | Apache License 2.0 | google/gvisor | Log filemem state when panicing due to invalid refcount.
PiperOrigin-RevId: 200408305
Change-Id: I676ee49ec77697105723577928c7f82088cd378e |
259,948 | 13.06.2018 10:13:23 | 25,200 | 686093669eb094eb585009b08175a70928849134 | sentry: do not treat all save errors as state file errors. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/state/state.go",
"new_path": "pkg/sentry/state/state.go",
"diff": "@@ -78,10 +78,7 @@ func (opts SaveOpts) Save(k *kernel.Kernel, w *watchdog.Watchdog) error {\n// Save the kernel.\nerr = k.SaveTo(wc)\nif closeErr := wc.Close(); err == nil && closeE... | Go | Apache License 2.0 | google/gvisor | sentry: do not treat all save errors as state file errors.
PiperOrigin-RevId: 200410220
Change-Id: I6a8745e33be949e335719083501f18b24f6ba471 |
259,858 | 13.06.2018 13:04:36 | 25,200 | 7b7b199ed0e282c42a753b1dc2ee16fe15aaa6d3 | Deflake kvm_test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/BUILD",
"new_path": "pkg/sentry/platform/kvm/BUILD",
"diff": "@@ -71,7 +71,6 @@ go_library(\ngo_test(\nname = \"kvm_test\",\n- size = \"small\",\nsrcs = [\n\"kvm_test.go\",\n\"virtual_map_test.go\",\n"
},
{
"change_type": "MODIF... | Go | Apache License 2.0 | google/gvisor | Deflake kvm_test.
PiperOrigin-RevId: 200439846
Change-Id: I9970fe0716cb02f0f41b754891d55db7e0729f56 |
260,013 | 13.06.2018 16:20:30 | 25,200 | 1170039e788db368615451a0a1f5cfccb1d28d41 | Fix missing returns in rpcinet. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -288,7 +288,7 @@ func (s *socketOperations) Bind(t *kernel.Task, sockaddr []byte) *syserr.Error {\n<-c\nif e := stack.rpcConn.Request(id).Result.(*pb.SyscallRe... | Go | Apache License 2.0 | google/gvisor | Fix missing returns in rpcinet.
PiperOrigin-RevId: 200472634
Change-Id: I3f0fb9e3b2f8616e6aa1569188258f330bf1ed31 |
259,854 | 13.06.2018 20:00:00 | 25,200 | f5d0c59f5c736f5f7fceb566e134f41b03229c22 | Fix reference leak in VDSO validation | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -213,7 +213,12 @@ func NewDirent(inode *Inode, name string) *Dirent {\n// NewTransientDirent creates a transient Dirent that shouldn't actually be\n// visible to users.\n+//\n+// An I... | Go | Apache License 2.0 | google/gvisor | Fix reference leak in VDSO validation
PiperOrigin-RevId: 200496070
Change-Id: I33adb717c44e5b4bcadece882be3ab1ee3920556 |
259,881 | 14.06.2018 10:10:09 | 25,200 | d71f5ef6885b9c241018308944e4b2e4b4857029 | Add nanosleep filter for Go 1.11 support
golang.org/cl/108538 replaces pselect6 with nanosleep in runtime.usleep. Update
the filters accordingly. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/BUILD",
"new_path": "runsc/boot/filter/BUILD",
"diff": "@@ -6,6 +6,8 @@ go_library(\nname = \"filter\",\nsrcs = [\n\"config.go\",\n+ \"config_go110.go\",\n+ \"config_go111.go\",\n\"extra_filters.go\",\n\"extra_filters_msan.go\",\n\"extra_filt... | Go | Apache License 2.0 | google/gvisor | Add nanosleep filter for Go 1.11 support
golang.org/cl/108538 replaces pselect6 with nanosleep in runtime.usleep. Update
the filters accordingly.
PiperOrigin-RevId: 200574612
Change-Id: Ifb2296fcb3781518fc047aabbbffedb9ae488cd7 |
259,885 | 14.06.2018 11:34:15 | 25,200 | 657db692b2241d89a324acc246b3c5230d8bd6ac | Ignore expiration count in kernelCPUClockListener.Notify. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -960,7 +960,13 @@ type kernelCPUClockListener struct {\n// Notify implements ktime.TimerListener.Notify.\nfunc (l kernelCPUClockListener) Notify(exp uint64) {\n- atomic.AddUin... | Go | Apache License 2.0 | google/gvisor | Ignore expiration count in kernelCPUClockListener.Notify.
PiperOrigin-RevId: 200590832
Change-Id: I35b817ecccc9414a742dee4815dfc67d0c7d0496 |
259,858 | 15.06.2018 01:21:08 | 25,200 | 1eb1bf8670e85bccd8df04ee8452d327b9891518 | Update contributing guidelines with an example.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -56,17 +56,55 @@ Rules:\n### Code reviews\n-All changes must be submitted via [Gerrit](https://gvisor-review.googlesource.com).\n+All changes must be submitted via [Gerrit][gerrit].\nAll submissions,... | Go | Apache License 2.0 | google/gvisor | Update contributing guidelines with an example.
Fixes #69
PiperOrigin-RevId: 200683809
Change-Id: I1312ebb3775d5f9088e9108359c19e2dedbb7b70 |
259,992 | 15.06.2018 09:17:08 | 25,200 | 119a302ceb070243cc2d3d3b4dcf5f4d57809479 | Implement /proc/thread-self
Closes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/proc.go",
"new_path": "pkg/sentry/fs/proc/proc.go",
"diff": "@@ -111,6 +111,13 @@ func (p *proc) newSelf(ctx context.Context, msrc *fs.MountSource) *fs.Inode {\nreturn newFile(s, msrc, fs.Symlink, nil)\n}\n+// newThreadSelf returns a new \"t... | Go | Apache License 2.0 | google/gvisor | Implement /proc/thread-self
Closes #68
PiperOrigin-RevId: 200725401
Change-Id: I4827009b8aee89d22887c3af67291ccf7058d420 |
259,992 | 15.06.2018 09:17:40 | 25,200 | ef5dd4df9b65fb98d952b83baa736c14b2627fe7 | Set kernel.applicationCores to the number of processor on the host
The right number to use is the number of processors assigned to the cgroup. But until
we make the sandbox join the respective cgroup, just use the number of processors on
the host.
Closes closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -18,6 +18,7 @@ package boot\nimport (\n\"fmt\"\n\"math/rand\"\n+ \"runtime\"\n\"sync/atomic\"\n\"syscall\"\ngtime \"time\"\n@@ -171,7 +172,8 @@ func New(spec *specs.Spec, conf *Config, cont... | Go | Apache License 2.0 | google/gvisor | Set kernel.applicationCores to the number of processor on the host
The right number to use is the number of processors assigned to the cgroup. But until
we make the sandbox join the respective cgroup, just use the number of processors on
the host.
Closes #65, closes #66
PiperOrigin-RevId: 200725483
Change-Id: I34a566b1a872e26c66f56fa6e3100f42aaf802b1 |
259,858 | 15.06.2018 09:29:19 | 25,200 | b31ac4e1dfc0eef688e2d8e85df965292690726e | Use notify explicitly on unlock path.
There are circumstances under which the redpill call will not generate
the appropriate action and notification. Replace this call with an
explicit notification, which is guaranteed to transition as well as
perform the futex wake. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -397,7 +397,7 @@ func (c *vCPU) unlock() {\ncase vCPUUser | vCPUGuest | vCPUWaiter:\n// Force a transition: this must trigger a notification when we\n// return f... | Go | Apache License 2.0 | google/gvisor | Use notify explicitly on unlock path.
There are circumstances under which the redpill call will not generate
the appropriate action and notification. Replace this call with an
explicit notification, which is guaranteed to transition as well as
perform the futex wake.
PiperOrigin-RevId: 200726934
Change-Id: Ie19e008a6007692dd7335a31a8b59f0af6e54aaa |
260,013 | 15.06.2018 12:54:38 | 25,200 | fa6db05e0ce828f2500651ca1226babbbf5edc80 | FIFOs should support O_TRUNC as a no-op. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/pipe/node.go",
"new_path": "pkg/sentry/kernel/pipe/node.go",
"diff": "@@ -162,6 +162,18 @@ func (i *inodeOperations) waitFor(wakeupChan *chan struct{}, sleeper amutex.Slee\n}\n}\n+// Truncate implements fs.InodeOperations.Truncate\n+//\n+// T... | Go | Apache License 2.0 | google/gvisor | FIFOs should support O_TRUNC as a no-op.
PiperOrigin-RevId: 200759323
Change-Id: I683b2edcc2188304c4ca563e46af457e23625905 |
259,948 | 15.06.2018 13:37:21 | 25,200 | fc8ca72a32bb4cb348ece3033c84696ea3502068 | sentry: do not start delivering external signal immediately. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling.go",
"new_path": "pkg/sentry/sighandling/sighandling.go",
"diff": "@@ -29,23 +29,31 @@ import (\n// numSignals is the number of normal (non-realtime) signals on Linux.\nconst numSignals = 32\n-// forwardSignals listens for in... | Go | Apache License 2.0 | google/gvisor | sentry: do not start delivering external signal immediately.
PiperOrigin-RevId: 200765756
Change-Id: Ie4266f32e4e977df3925eb29f3fbb756e0337606 |
259,891 | 15.06.2018 14:07:00 | 25,200 | 437890dc4b6987a64ac98766c752ce64091757dc | runsc: Make gofer logs show up in test output. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -209,6 +209,8 @@ func (s *Sandbox) createGoferProcess(spec *specs.Spec, conf *boot.Config, bundle\n}\ncmd := exec.Command(binPath, args...)\n+ cmd.Stdout = os.Stdout\n+ cmd.Stderr =... | Go | Apache License 2.0 | google/gvisor | runsc: Make gofer logs show up in test output.
PiperOrigin-RevId: 200770591
Change-Id: Ifc096d88615b63135210d93c2b4cee2eaecf1eee |
259,881 | 15.06.2018 15:35:09 | 25,200 | bd2d1aaa16474202b1a2c1edbf62e6782fa2dc36 | Replace crypto/rand with internal rand package | [
{
"change_type": "MODIFY",
"old_path": "pkg/dhcp/BUILD",
"new_path": "pkg/dhcp/BUILD",
"diff": "@@ -11,6 +11,7 @@ go_library(\n],\nimportpath = \"gvisor.googlesource.com/gvisor/pkg/dhcp\",\ndeps = [\n+ \"//pkg/rand\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/network/ipv4\",\n\"//pkg/tcpip/stack\",\n"
},
... | Go | Apache License 2.0 | google/gvisor | Replace crypto/rand with internal rand package
PiperOrigin-RevId: 200784607
Change-Id: I39aa6ee632936dcbb00fc298adccffa606e9f4c0 |
259,991 | 15.06.2018 16:08:20 | 25,200 | 0786707cd94b8feffaeb083077eccaf10873e682 | Added code for a pause command for a container process.
Like runc, the pause command will pause the processes of the given container.
It will set that container's status to "paused."
A resume command will be be added to unpause and continue running the process. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -37,6 +37,9 @@ const (\n// container..\nContainerExecute = \"containerManager.Execute\"\n+ // ContainerPause pauses the container.\n+ ContainerPause = \"containerManager.Pause\"\n+\... | Go | Apache License 2.0 | google/gvisor | Added code for a pause command for a container process.
Like runc, the pause command will pause the processes of the given container.
It will set that container's status to "paused."
A resume command will be be added to unpause and continue running the process.
PiperOrigin-RevId: 200789624
Change-Id: I72a5d7813d90ecfc4d01cc252d6018855016b1ea |
260,013 | 17.06.2018 17:05:36 | 25,200 | 563a71ef243360bc20db0e481b3adbfb07cd8702 | Add rpcinet support for control messages.
Add support for control messages, but at this time the only
control message that the sentry will support here is SO_TIMESTAMP. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -477,6 +477,37 @@ func rpcRecvMsg(t *kernel.Task, req *pb.SyscallRequest_Recvmsg) (*pb.RecvmsgResp\nreturn res.(*pb.RecvmsgResponse_Payload).Payload, nil\n}\n+... | Go | Apache License 2.0 | google/gvisor | Add rpcinet support for control messages.
Add support for control messages, but at this time the only
control message that the sentry will support here is SO_TIMESTAMP.
PiperOrigin-RevId: 200922230
Change-Id: I63a852d9305255625d9df1d989bd46a66e93c446 |
259,992 | 18.06.2018 15:17:49 | 25,200 | 7eaca1074bf1a6c0e260727b2d9cbd3c878d2b77 | Add pointer to dated builds in README | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -168,17 +168,19 @@ Note that gVisor can only run on x86\\_64 Linux 3.17+. In addition, gVisor only\nsupports x86\\_64 binaries inside the sandbox (i.e., it cannot run 32-bit\nbinaries).\n-### Download a Nightly ... | Go | Apache License 2.0 | google/gvisor | Add pointer to dated builds in README
PiperOrigin-RevId: 201068427
Change-Id: If03c8c22907e6ef623f39c8ae5316fdd76cf80cb |
259,991 | 18.06.2018 15:19:36 | 25,200 | 873ec0c414973e829c1570f21d0d2e2a0df681f4 | Modified boot.go to allow for restores.
A file descriptor was added as a flag to boot so a state file can restore a
container that was checkpointed. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -51,6 +51,7 @@ go_library(\n\"//pkg/sentry/socket/netlink\",\n\"//pkg/sentry/socket/netlink/route\",\n\"//pkg/sentry/socket/unix\",\n+ \"//pkg/sentry/state\",\n\"//pkg/sentry/strace\",\n\"//pkg/sen... | Go | Apache License 2.0 | google/gvisor | Modified boot.go to allow for restores.
A file descriptor was added as a flag to boot so a state file can restore a
container that was checkpointed.
PiperOrigin-RevId: 201068699
Change-Id: I18e96069488ffa3add468861397f3877725544aa |
259,948 | 19.06.2018 11:04:05 | 25,200 | 5581256f879f4249de5ebffddaf0626fcb39eebd | state: include I/O and protobuf time in kernel S/R timing stats. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/decode.go",
"new_path": "pkg/state/decode.go",
"diff": "@@ -78,12 +78,11 @@ func (os *objectState) checkComplete(stats *Stats) {\nif os.blockedBy > 0 {\nreturn\n}\n+ stats.Start(os.obj)\n// Fire all callbacks.\nfor _, fn := range os.callbacks {\n- st... | Go | Apache License 2.0 | google/gvisor | state: include I/O and protobuf time in kernel S/R timing stats.
PiperOrigin-RevId: 201205733
Change-Id: I300307b0668989ba7776ab9e3faee71efdd33f46 |
260,013 | 19.06.2018 14:11:58 | 25,200 | bda2a1ed3503699b8cb814bb3cc7ad0b9694155b | Rpcinet is racy around shutdown flags.
Correct a data race in rpcinet where a shutdown and recvmsg can
race around shutown flags. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "package rpcinet\nimport (\n+ \"sync/atomic\"\n\"syscall\"\n\"gvisor.googlesource.com/gvisor/pkg/abi/linux\"\n@@ -57,7 +58,7 @@ type socketOperations struct {\n// ... | Go | Apache License 2.0 | google/gvisor | Rpcinet is racy around shutdown flags.
Correct a data race in rpcinet where a shutdown and recvmsg can
race around shutown flags.
PiperOrigin-RevId: 201238366
Change-Id: I5eb06df4a2b4eba331eeb5de19076213081d581f |
259,991 | 19.06.2018 15:22:23 | 25,200 | a6dbef045ff684e92f472280eb6f7f688b9bc87a | Added a resume command to unpause a paused container.
Resume checks the status of the container and unpauses the kernel
if its status is paused. Otherwise nothing happens.
Tests were added to ensure that the process is in the correct state
after various commands. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/proc.go",
"new_path": "pkg/sentry/control/proc.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"bytes\"\n\"encoding/json\"\n\"fmt\"\n+ \"sort\"\n\"syscall\"\n\"text/tabwriter\"\n\"time\"\n@@ -245,6 +246,7 @@ func Processes(k *kernel.Kernel, out *... | Go | Apache License 2.0 | google/gvisor | Added a resume command to unpause a paused container.
Resume checks the status of the container and unpauses the kernel
if its status is paused. Otherwise nothing happens.
Tests were added to ensure that the process is in the correct state
after various commands.
PiperOrigin-RevId: 201251234
Change-Id: Ifd11b336c33b654fea6238738f864fcf2bf81e19 |
259,948 | 19.06.2018 16:07:08 | 25,200 | aa14a2c1be7f705927e9558f0e46ceca159e23e6 | sentry: futex S/R optimization.
No need to save thousands of zerovalue buckets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/futex/futex.go",
"new_path": "pkg/sentry/kernel/futex/futex.go",
"diff": "@@ -197,7 +197,7 @@ func bucketIndexForAddr(addr uintptr) uintptr {\n// Manager holds futex state for a single virtual address space.\ntype Manager struct {\n- buckets ... | Go | Apache License 2.0 | google/gvisor | sentry: futex S/R optimization.
No need to save thousands of zerovalue buckets.
PiperOrigin-RevId: 201258598
Change-Id: I5d3ea7b6a5345117ab4f610332d5288ca550be33 |
259,891 | 19.06.2018 17:03:55 | 25,200 | 33f29c730f46aacb56cb7710c31d19dbe0d5ff3f | runsc: Fix flakey container_test.
Verified that this is no longer flakey over 10K repetitions. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -164,6 +164,7 @@ func TestLifecycle(t *testing.T) {\nif _, err := container.Create(id, spec, conf, bundleDir, \"\", \"\"); err != nil {\nt.Fatalf(\"error creating ... | Go | Apache License 2.0 | google/gvisor | runsc: Fix flakey container_test.
Verified that this is no longer flakey over 10K repetitions.
PiperOrigin-RevId: 201267499
Change-Id: I793c916fe725412aec25953f764cb4f52c9fbed3 |
259,948 | 19.06.2018 17:12:48 | 25,200 | 18d899245329daf472c322c81af356958b3e2613 | state: pretty-print primitive type arrays. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/printer.go",
"new_path": "pkg/state/printer.go",
"diff": "@@ -18,13 +18,15 @@ import (\n\"fmt\"\n\"io\"\n\"io/ioutil\"\n+ \"reflect\"\n\"strings\"\n\"github.com/golang/protobuf/proto\"\npb \"gvisor.googlesource.com/gvisor/pkg/state/object_go_proto\"\... | Go | Apache License 2.0 | google/gvisor | state: pretty-print primitive type arrays.
PiperOrigin-RevId: 201269072
Change-Id: Ia542c5a42b5b5d21c1104a003ddff5279644d309 |
259,891 | 19.06.2018 17:16:39 | 25,200 | 3ebd0e35f43d9ca282886aabce52fbb7fc7e1fc5 | runsc: Whitelist lstat, as it is now used in specutils.
When running multi-container, child containers are added after the filters have
been installed. Thus, lstat must be in the set of allowed syscalls. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/filter/config.go",
"new_path": "runsc/boot/filter/config.go",
"diff": "@@ -53,6 +53,9 @@ var allowedSyscalls = seccomp.SyscallRules{\nsyscall.SYS_GETTIMEOFDAY: {},\nsyscall.SYS_LISTEN: {},\nsyscall.SYS_LSEEK: {},\n+ // TODO: Remove SYS_LSTAT when ex... | Go | Apache License 2.0 | google/gvisor | runsc: Whitelist lstat, as it is now used in specutils.
When running multi-container, child containers are added after the filters have
been installed. Thus, lstat must be in the set of allowed syscalls.
PiperOrigin-RevId: 201269550
Change-Id: I03f2e6675a53d462ed12a0f651c10049b76d4c52 |
260,013 | 19.06.2018 17:28:19 | 25,200 | db66e383c33228c43efbe16ad3b14ae9833879dc | Epsocket has incorrect recv(2) behavior after SHUT_RD.
After shutdown(SHUT_RD) calls to recv /w MSG_DONTWAIT or with
O_NONBLOCK should result in a EAGAIN and not 0. Blocking sockets
should return 0 as they would have otherwise blocked indefinitely. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -952,6 +952,12 @@ func (s *SocketOperations) RecvMsg(t *kernel.Task, dst usermem.IOSequence, flags\nsenderRequested = false\n}\nn, senderAddr, senderAddr... | Go | Apache License 2.0 | google/gvisor | Epsocket has incorrect recv(2) behavior after SHUT_RD.
After shutdown(SHUT_RD) calls to recv /w MSG_DONTWAIT or with
O_NONBLOCK should result in a EAGAIN and not 0. Blocking sockets
should return 0 as they would have otherwise blocked indefinitely.
PiperOrigin-RevId: 201271123
Change-Id: If589b69c17fa5b9ff05bcf9e44024da9588c8876 |
259,948 | 20.06.2018 11:01:32 | 25,200 | 4e9f0e91d724b547e1ecaeeb210017f4c0b3fd0d | sentry: pending signals S/R optimization.
Almost all of the hundreds of pending signal queues are empty upon save. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -13,7 +13,7 @@ go_stateify(\n\"ipc_namespace.go\",\n\"kernel.go\",\n\"pending_signals.go\",\n- \"pending_signals_list.go\",\n+ \"pending_signals_state.go\",\n\"process_group_list.go\"... | Go | Apache License 2.0 | google/gvisor | sentry: pending signals S/R optimization.
Almost all of the hundreds of pending signal queues are empty upon save.
PiperOrigin-RevId: 201380318
Change-Id: I40747072435299de681d646e0862efac0637e172 |
259,992 | 20.06.2018 13:00:21 | 25,200 | af6f9f56f80027a89ee517b79502ca6183094a39 | Add tool to configure runtime settings in docker
This will be used with the upcoming e2e image tests. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "runsc/tools/dockercfg/BUILD",
"diff": "+package(licenses = [\"notice\"]) # Apache 2.0\n+\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_binary\")\n+\n+go_binary(\n+ name = \"dockercfg\",\n+ srcs = [\"dockercfg.go\"],\n+ visibility = [\n+ \"//ru... | Go | Apache License 2.0 | google/gvisor | Add tool to configure runtime settings in docker
This will be used with the upcoming e2e image tests.
PiperOrigin-RevId: 201400832
Change-Id: I49509314e16ea54655ea8060dbf511a04a7a8f79 |
259,992 | 20.06.2018 13:30:39 | 25,200 | 4ad7315b6759afa81f492ec119080deb9a224101 | Add 'runsc debug' command
It prints sandbox stacks to the log to help debug stuckness. I expect
that many more options will be added in the future. | [
{
"change_type": "MODIFY",
"old_path": "pkg/log/log.go",
"new_path": "pkg/log/log.go",
"diff": "@@ -251,8 +251,8 @@ const defaultStackSize = 1 << 16 // 64KB\n// maxStackSize is the maximum buffer size to allocate for stack traces.\nconst maxStackSize = 1 << 26 // 64MB\n-// stacks returns goroutine s... | Go | Apache License 2.0 | google/gvisor | Add 'runsc debug' command
It prints sandbox stacks to the log to help debug stuckness. I expect
that many more options will be added in the future.
PiperOrigin-RevId: 201405931
Change-Id: I87e560800cd5a5a7b210dc25a5661363c8c3a16e |
259,992 | 20.06.2018 14:37:56 | 25,200 | 2b5bdb525e99fc1ef099b2ef083a09772241ea58 | Add end-to-end image tests | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "runsc/test/image/BUILD",
"diff": "+package(licenses = [\"notice\"]) # Apache 2.0\n+\n+load(\"@io_bazel_rules_go//go:def.bzl\", \"go_library\", \"go_test\")\n+\n+go_test(\n+ name = \"image_test\",\n+ size = \"small\",\n+ srcs = [\"image_test.go\"... | Go | Apache License 2.0 | google/gvisor | Add end-to-end image tests
PiperOrigin-RevId: 201418619
Change-Id: I7961b027394d98422642f829bc54745838c138bd |
259,992 | 20.06.2018 15:27:06 | 25,200 | 2f59ba0e2d2169cf429b73a39a920f8d615f8eca | Include image test as part of kokoro tests | [
{
"change_type": "MODIFY",
"old_path": "kokoro/gcp_ubuntu/run_tests.sh",
"new_path": "kokoro/gcp_ubuntu/run_tests.sh",
"diff": "@@ -31,6 +31,10 @@ cd git/repo\n# Build everything.\nbazel build //...\n+# Test use this variable to determine what runtime to use.\n+runtime=runsc_test_$((RANDOM))\n+sudo ... | Go | Apache License 2.0 | google/gvisor | Include image test as part of kokoro tests
PiperOrigin-RevId: 201427731
Change-Id: I5cbee383ec51c02b7892ec7812cbbdc426be8991 |
259,992 | 20.06.2018 15:31:12 | 25,200 | 95cb01e0a9517f7119e3d848728500692a4f5cba | Reduce test sleep time | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container_test.go",
"new_path": "runsc/container/container_test.go",
"diff": "@@ -205,7 +205,9 @@ func TestLifecycle(t *testing.T) {\n// Wait on the container.\nvar wg sync.WaitGroup\nwg.Add(1)\n+ ch := make(chan struct{})\ngo func() {\n+ ch <-... | Go | Apache License 2.0 | google/gvisor | Reduce test sleep time
PiperOrigin-RevId: 201428433
Change-Id: I72de1e46788ec84f61513416bb690956e515907e |
259,854 | 21.06.2018 08:33:46 | 25,200 | ef4f239c793a1a202d3249c6a8139e0602d94d94 | Fix typo in runsc gofer flag description | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/gofer.go",
"new_path": "runsc/cmd/gofer.go",
"diff": "@@ -44,7 +44,7 @@ func (*Gofer) Name() string {\n// Synopsis implements subcommands.Command.\nfunc (*Gofer) Synopsis() string {\n- return \"launch a gofer process that server files over 9P protoco... | Go | Apache License 2.0 | google/gvisor | Fix typo in runsc gofer flag description
PiperOrigin-RevId: 201529295
Change-Id: I55eb516ec6d14fbcd48593a3d61f724adc253a23 |
259,854 | 21.06.2018 10:52:33 | 25,200 | d571a4359cebbcf8a9b201bb125f1cdc9fb126e4 | Implement ioctl(FIOASYNC)
FIOASYNC and friends are used to send signals when a file is ready for IO.
This may or may not be needed by Nginx. While Nginx does use it, it is unclear
if the code that uses it has any effect. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -31,6 +31,7 @@ go_library(\n\"elf.go\",\n\"errors.go\",\n\"exec.go\",\n+ \"fcntl.go\",\n\"file.go\",\n\"fs.go\",\n\"futex.go\",\n"
},
{
"change_type": "ADD",
"old_path": null,
... | Go | Apache License 2.0 | google/gvisor | Implement ioctl(FIOASYNC)
FIOASYNC and friends are used to send signals when a file is ready for IO.
This may or may not be needed by Nginx. While Nginx does use it, it is unclear
if the code that uses it has any effect.
PiperOrigin-RevId: 201550828
Change-Id: I7ba05a7db4eb2dfffde11e9bd9a35b65b98d7f50 |
259,992 | 21.06.2018 13:21:25 | 25,200 | f6be5fe6193163ad46722bc36209572da4a15ad0 | Forward SIGUSR2 to the sandbox too
SIGUSR2 was being masked out to be used as a way to dump sentry
stacks. This could cause compatibility problems in cases anyone
uses SIGUSR2 to communicate with the container init process. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/sighandling/sighandling.go",
"new_path": "pkg/sentry/sighandling/sighandling.go",
"diff": "@@ -95,7 +95,7 @@ func forwardSignals(k *kernel.Kernel, sigchans []chan os.Signal, start, stop cha\n// PrepareForwarding ensures that synchronous signals are ... | Go | Apache License 2.0 | google/gvisor | Forward SIGUSR2 to the sandbox too
SIGUSR2 was being masked out to be used as a way to dump sentry
stacks. This could cause compatibility problems in cases anyone
uses SIGUSR2 to communicate with the container init process.
PiperOrigin-RevId: 201575374
Change-Id: I312246e828f38ad059139bb45b8addc2ed055d74 |
259,881 | 21.06.2018 14:53:05 | 25,200 | 2dedbc7211fb6b7f8b86148e6627054e781eaa87 | Drop return from SendExternalSignal
SendExternalSignal is no longer called before CreateProcess, so it can
enforce this simplified precondition.
StartForwarding, and after Kernel.Start. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -760,12 +760,11 @@ func (k *Kernel) Unpause() {\n//\n// context is used only for debugging to describe how the signal was received.\n//\n-// Returns false if signal could not ... | Go | Apache License 2.0 | google/gvisor | Drop return from SendExternalSignal
SendExternalSignal is no longer called before CreateProcess, so it can
enforce this simplified precondition.
StartForwarding, and after Kernel.Start.
PiperOrigin-RevId: 201591170
Change-Id: Ib7022ef7895612d7d82a00942ab59fa433c4d6e9 |
259,948 | 21.06.2018 15:18:47 | 25,200 | 0e434b66a625b937d90e4ebe632de4546101be5a | netstack: tcp socket connected state S/R support. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -12,6 +12,7 @@ go_stateify(\n\"fs_context.go\",\n\"ipc_namespace.go\",\n\"kernel.go\",\n+ \"kernel_state.go\",\n\"pending_signals.go\",\n\"pending_signals_state.go\",\n\"process_group... | Go | Apache License 2.0 | google/gvisor | netstack: tcp socket connected state S/R support.
PiperOrigin-RevId: 201596247
Change-Id: Id22f47b2cdcbe14aa0d930f7807ba75f91a56724 |
260,013 | 22.06.2018 10:18:19 | 25,200 | 5d45f88f2c2840123e2f5ec2e45ac6d5b5a5729f | Netstack should return EOF on closed read.
The shutdown behavior where we return EAGAIN for sockets
which are non-blocking is only correct for packet based sockets.
SOCK_STREAM sockets should return EOF. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/epsocket/epsocket.go",
"new_path": "pkg/sentry/socket/epsocket/epsocket.go",
"diff": "@@ -945,7 +945,6 @@ func (s *SocketOperations) nonBlockingRead(ctx context.Context, dst usermem.IOSe\n// tcpip.Endpoint.\nfunc (s *SocketOperations) RecvMsg... | Go | Apache License 2.0 | google/gvisor | Netstack should return EOF on closed read.
The shutdown behavior where we return EAGAIN for sockets
which are non-blocking is only correct for packet based sockets.
SOCK_STREAM sockets should return EOF.
PiperOrigin-RevId: 201703055
Change-Id: I20b25ceca7286c37766936475855959706fc5397 |
259,885 | 22.06.2018 13:07:21 | 25,200 | fe3fc44da3ca47fa27d55294e6c31d51b6b5dc14 | Handle mremap(old_size=0). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/memmap/memmap.go",
"new_path": "pkg/sentry/memmap/memmap.go",
"diff": "@@ -49,13 +49,14 @@ type Mappable interface {\n// CopyMapping notifies the Mappable of an attempt to copy a mapping in ms\n// from srcAR to dstAR. For most Mappables, this is equ... | Go | Apache License 2.0 | google/gvisor | Handle mremap(old_size=0).
PiperOrigin-RevId: 201729703
Change-Id: I486900b0c6ec59533b88da225a5829c474e35a70 |
259,891 | 22.06.2018 14:30:33 | 25,200 | 04bdcc7b65ac03eeca9b14608a12067e1205081b | runsc: Enable waiting on individual containers within a sandbox. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -145,10 +145,11 @@ type containerManager struct {\n}\n// StartRoot will start the root container process.\n-func (cm *containerManager) StartRoot(_, _ *struct{}) error {\n+func (cm ... | Go | Apache License 2.0 | google/gvisor | runsc: Enable waiting on individual containers within a sandbox.
PiperOrigin-RevId: 201742160
Change-Id: Ia9fa1442287c5f9e1196fb117c41536a80f6bb31 |
260,013 | 22.06.2018 14:47:15 | 25,200 | 7c645ac27355a9d7016e0d5c74ce70eed2add600 | Add rpcinet support for SIOCGIFCONF.
The interfaces and their addresses are already available via
the stack Intefaces and InterfaceAddrs.
Also add some tests as we had no tests around SIOCGIFCONF. I also added the socket_netgofer lifecycle for IOCTL tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/rpcinet/socket.go",
"new_path": "pkg/sentry/socket/rpcinet/socket.go",
"diff": "@@ -64,10 +64,6 @@ type socketOperations struct {\n// Verify that we actually implement socket.Socket.\nvar _ = socket.Socket(&socketOperations{})\n-const (\n- si... | Go | Apache License 2.0 | google/gvisor | Add rpcinet support for SIOCGIFCONF.
The interfaces and their addresses are already available via
the stack Intefaces and InterfaceAddrs.
Also add some tests as we had no tests around SIOCGIFCONF. I also added the socket_netgofer lifecycle for IOCTL tests.
PiperOrigin-RevId: 201744863
Change-Id: Ie0a285a2a2f859fa0cafada13201d5941b95499a |
259,881 | 22.06.2018 16:36:36 | 25,200 | 9c0c4fd8d05cca4905a0f8e4f391045566e4d401 | Remove nginx failure note now that it works
Updates | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -373,6 +373,7 @@ The following applications/images have been tested:\n* memcached\n* mongo\n* mysql\n+* nginx\n* node\n* php\n* postgres\n@@ -389,8 +390,6 @@ The following applications have been tested and may n... | Go | Apache License 2.0 | google/gvisor | Remove nginx failure note now that it works
Updates #1
PiperOrigin-RevId: 201760129
Change-Id: Ifd8ce9e0f93c6771083dc9bf8d35a2800c13481a |
259,881 | 25.06.2018 15:22:04 | 25,200 | 478f0ac0038afda267814fa154bcd32feb07c3b3 | Don't read FSContext.root without holding FSContext.mu
IsChrooted still has the opportunity to race with another thread
entering the FSContext into a chroot, but that is unchanged (and
fine, AFAIK). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_resources.go",
"new_path": "pkg/sentry/kernel/task_resources.go",
"diff": "@@ -122,5 +122,7 @@ func (t *Task) AbstractSockets() *AbstractSocketNamespace {\nfunc (t *Task) IsChrooted() bool {\nrealRoot := t.k.mounts.Root()\ndefer realRoot... | Go | Apache License 2.0 | google/gvisor | Don't read FSContext.root without holding FSContext.mu
IsChrooted still has the opportunity to race with another thread
entering the FSContext into a chroot, but that is unchanged (and
fine, AFAIK).
PiperOrigin-RevId: 202029117
Change-Id: I38bce763b3a7715fa6ae98aa200a19d51a0235f1 |
259,881 | 25.06.2018 16:45:31 | 25,200 | 4ac79312b093f2831079d0d71846747a4996d9ad | Don't read cwd or root without holding mu | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/fs_context.go",
"new_path": "pkg/sentry/kernel/fs_context.go",
"diff": "@@ -114,11 +114,14 @@ func (f *FSContext) SetWorkingDirectory(d *fs.Dirent) {\nif d == nil {\npanic(\"FSContext.SetWorkingDirectory called with nil dirent\")\n}\n+\n+ f.m... | Go | Apache License 2.0 | google/gvisor | Don't read cwd or root without holding mu
PiperOrigin-RevId: 202043090
Change-Id: I3c47fb3413ca8615d50d8a0503d72fcce9b09421 |
259,885 | 25.06.2018 16:49:47 | 25,200 | 16882484f96f9d75348904bd5a4e2a53acb67378 | Check for empty applicationAddrRange in MM.DecUsers. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/lifecycle.go",
"new_path": "pkg/sentry/mm/lifecycle.go",
"diff": "@@ -214,5 +214,9 @@ func (mm *MemoryManager) DecUsers(ctx context.Context) {\nmm.mappingMu.Lock()\ndefer mm.mappingMu.Unlock()\n- mm.unmapLocked(ctx, mm.applicationAddrRange())\n+ ... | Go | Apache License 2.0 | google/gvisor | Check for empty applicationAddrRange in MM.DecUsers.
PiperOrigin-RevId: 202043776
Change-Id: I4373abbcf735dc1cf4bebbbbb0c7124df36e9e78 |
259,881 | 25.06.2018 18:16:20 | 25,200 | db94befb634b05aab0255214cd8c5eab0f5daaf2 | Fix panic message
The arguments are backwards from the message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/dirent.go",
"new_path": "pkg/sentry/fs/dirent.go",
"diff": "@@ -964,7 +964,7 @@ func direntReaddir(ctx context.Context, d *Dirent, it DirIterator, root *Dirent,\noffset -= 2\nnewOffset, err := it.IterateDir(ctx, dirCtx, int(offset))\nif int64(new... | Go | Apache License 2.0 | google/gvisor | Fix panic message
The arguments are backwards from the message.
PiperOrigin-RevId: 202054887
Change-Id: Id5750a84ca091f8b8fbe15be8c648d4fa3e31eb2 |
259,885 | 26.06.2018 11:34:16 | 25,200 | 33041b36cb7e8e9795545837355e4576ff2be4da | Add Context to seqfile.SeqSource.ReadSeqFileData. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/filesystems.go",
"new_path": "pkg/sentry/fs/proc/filesystems.go",
"diff": "@@ -18,6 +18,7 @@ import (\n\"bytes\"\n\"fmt\"\n+ \"gvisor.googlesource.com/gvisor/pkg/sentry/context\"\n\"gvisor.googlesource.com/gvisor/pkg/sentry/fs\"\n\"gvisor.go... | Go | Apache License 2.0 | google/gvisor | Add Context to seqfile.SeqSource.ReadSeqFileData.
PiperOrigin-RevId: 202163895
Change-Id: Ib9942fcff80c0834216f4f10780662bef5b52270 |
259,854 | 26.06.2018 12:40:23 | 25,200 | 5f7f78c1d7ee19b6a193d17c48f78edb220412aa | Fix data races in Unix sockets | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/queue/queue.go",
"new_path": "pkg/tcpip/transport/queue/queue.go",
"diff": "@@ -157,6 +157,8 @@ func (q *Queue) Peek() (Entry, *tcpip.Error) {\n// QueuedSize returns the number of bytes currently in the queue, that is, the\n// number of rea... | Go | Apache License 2.0 | google/gvisor | Fix data races in Unix sockets
PiperOrigin-RevId: 202175558
Change-Id: I0113cb9a90d7a0cd7964bf43eef67f70c92d9589 |
259,885 | 26.06.2018 13:09:02 | 25,200 | ea10949a0036cdef95a1397ccad8fcc138ce3c0d | Use the correct Context for /proc/[pid]/maps. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -306,7 +306,7 @@ func (md *mapsData) NeedsUpdate(generation int64) bool {\n// ReadSeqFileData implements seqfile.SeqSource.ReadSeqFileData.\nfunc (md *mapsData) ReadSeqFileData(... | Go | Apache License 2.0 | google/gvisor | Use the correct Context for /proc/[pid]/maps.
PiperOrigin-RevId: 202180487
Change-Id: I95cce41a4842ab731a4821b387b32008bfbdcb08 |
259,992 | 26.06.2018 19:04:51 | 25,200 | c186e408cc61cbefd6d72c2ff3e9d629572570db | Add KVM, overlay and host network to image tests | [
{
"change_type": "MODIFY",
"old_path": "kokoro/gcp_ubuntu/run_tests.sh",
"new_path": "kokoro/gcp_ubuntu/run_tests.sh",
"diff": "@@ -46,6 +46,9 @@ exit_code=${?}\nif [[ ${exit_code} -eq 0 ]]; then\n# image_test is tagged manual\nbazel test --test_output=errors --test_env=RUNSC_RUNTIME=${runtime} //ru... | Go | Apache License 2.0 | google/gvisor | Add KVM, overlay and host network to image tests
PiperOrigin-RevId: 202236006
Change-Id: I4ea964a70fc49e8b51c9da27d77301c4eadaae71 |
259,885 | 27.06.2018 13:41:50 | 25,200 | 4215e059e24c5ed6298060769444b0eeaa03da8a | Ignore MADV_DONTDUMP and MADV_DODUMP. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_mmap.go",
"new_path": "pkg/sentry/syscalls/linux/sys_mmap.go",
"diff": "@@ -181,6 +181,10 @@ func Madvise(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Sysca\nfallthrough\ncase linux.MADV_MERGEABLE, linux.MADV_UNME... | Go | Apache License 2.0 | google/gvisor | Ignore MADV_DONTDUMP and MADV_DODUMP.
PiperOrigin-RevId: 202361912
Change-Id: I1d0ee529073954d467b870872f494cebbf8ea61a |
259,992 | 27.06.2018 14:40:37 | 25,200 | 6b6852bceb12900f27a541682ddfe47893911c6e | Fix semaphore data races | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"new_path": "pkg/sentry/kernel/semaphore/semaphore.go",
"diff": "@@ -118,6 +118,9 @@ func (r *Registry) FindOrCreate(ctx context.Context, key, nsems int32, mode linu\nif !private {\n// Look up an existing semaphore.\n... | Go | Apache License 2.0 | google/gvisor | Fix semaphore data races
PiperOrigin-RevId: 202371908
Change-Id: I72603b1d321878cae6404987c49e64732b676331 |
259,992 | 28.06.2018 09:45:52 | 25,200 | 1f207de315430fb178b7025a5afd419afdc31449 | Add option to configure watchdog action | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/config.go",
"new_path": "runsc/boot/config.go",
"diff": "@@ -18,6 +18,8 @@ import (\n\"fmt\"\n\"strconv\"\n\"strings\"\n+\n+ \"gvisor.googlesource.com/gvisor/pkg/sentry/watchdog\"\n)\n// PlatformType tells which platform to use.\n@@ -130,6 +132,18 @... | Go | Apache License 2.0 | google/gvisor | Add option to configure watchdog action
PiperOrigin-RevId: 202494747
Change-Id: I4d4a18e71468690b785060e580a5f83c616bd90f |
259,992 | 28.06.2018 09:56:23 | 25,200 | 8459390cdd81ef1c8180948566e893b06233923c | Error out if spec is invalid
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/loader.go",
"new_path": "runsc/boot/loader.go",
"diff": "@@ -267,7 +267,7 @@ func newProcess(spec *specs.Spec, conf *Config, ioFDs []int, console bool, creds\nFilename: exec,\nArgv: spec.Process.Args,\nEnvv: spec.Process.Env,\n- WorkingDirectory: sp... | Go | Apache License 2.0 | google/gvisor | Error out if spec is invalid
Closes #66
PiperOrigin-RevId: 202496258
Change-Id: Ib9287c5bf1279ffba1db21ebd9e6b59305cddf34 |
259,992 | 28.06.2018 13:22:12 | 25,200 | bb31a119035dd5266737b41456d967789693cf20 | Wait for sandbox process when waiting for root container
Closes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -449,7 +449,7 @@ func (c *Container) Destroy() error {\n// If we are the first container in the sandbox, take the sandbox down\n// as well.\n- if c.Sandbox != nil && c.Sandb... | Go | Apache License 2.0 | google/gvisor | Wait for sandbox process when waiting for root container
Closes #71
PiperOrigin-RevId: 202532762
Change-Id: I80a446ff638672ff08e6fd853cd77e28dd05d540 |
260,013 | 29.06.2018 12:39:22 | 25,200 | 23f49097c77213175e9b11755c28c3ff5ccc1118 | Panic in netstack during cleanup where a FIN becomes a RST.
There is a subtle bug where during cleanup with unread data a FIN can
be converted to a RST, at that point the entire connection should be
aborted as we're not expecting any ACKs to the RST. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/connect.go",
"new_path": "pkg/tcpip/transport/tcp/connect.go",
"diff": "@@ -938,6 +938,10 @@ func (e *endpoint) protocolMainLoop(passive bool) *tcpip.Error {\ne.snd.updateMaxPayloadSize(mtu, count)\n}\n+ if n¬ifyReset != 0 {\n+ e.res... | Go | Apache License 2.0 | google/gvisor | Panic in netstack during cleanup where a FIN becomes a RST.
There is a subtle bug where during cleanup with unread data a FIN can
be converted to a RST, at that point the entire connection should be
aborted as we're not expecting any ACKs to the RST.
PiperOrigin-RevId: 202691271
Change-Id: Idae70800208ca26e07a379bc6b2b8090805d0a22 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.