author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,992 | 22.11.2022 13:37:55 | 28,800 | 03e92949e540d686d96300f5ee3a61dbdaebc338 | Force sendfile(2) to copy data in test | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/sendfile.cc",
"new_path": "test/syscalls/linux/sendfile.cc",
"diff": "@@ -471,7 +471,7 @@ TEST(SendFileTest, SendToNotARegularFile) {\nASSERT_NO_ERRNO_AND_VALUE(Open(out_file.path(), O_WRONLY));\n// Receive an error since a directory is not... | Go | Apache License 2.0 | google/gvisor | Force sendfile(2) to copy data in test
PiperOrigin-RevId: 490324920 |
259,891 | 22.11.2022 16:17:29 | 28,800 | 5b7274a1fc081f038613583e82d17fdb68af6dc3 | gro: use packet size to infer MSS
Linux GRO simply uses the size of the first packet in a flow as the MSS. So
identically sized packets are coalesced until an oddly-sized one comes along.
See net/core/gro.c:dev_gro_receive and net/ipv4/tcp_offload.c:tcp_gro_receive.
Also fixed clobbering of the groPacket.idx field, which caused memory
corruption. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/gro.go",
"new_path": "pkg/tcpip/stack/gro.go",
"diff": "@@ -85,6 +85,8 @@ func (gb *groBucket) insert(pkt PacketBufferPtr, ipHdr header.IPv4, tcpHdr heade\nep: ep,\nipHdr: ipHdr,\ntcpHdr: tcpHdr,\n+ initialLength: ipHdr.TotalLength(),\n+ idx: g... | Go | Apache License 2.0 | google/gvisor | gro: use packet size to infer MSS
Linux GRO simply uses the size of the first packet in a flow as the MSS. So
identically sized packets are coalesced until an oddly-sized one comes along.
See net/core/gro.c:dev_gro_receive and net/ipv4/tcp_offload.c:tcp_gro_receive.
Also fixed clobbering of the groPacket.idx field, which caused memory
corruption.
PiperOrigin-RevId: 490361840 |
259,975 | 28.11.2022 16:12:10 | 28,800 | ae731e0394f571af8eba6eaacf89a7930755d329 | Don't use other process's scratch buffer.
If we use the remote process's scratch buffer in process_vm_readv|writev
calls, we will get data races. Use the local task's scratch buffer always. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_process_vm.go",
"new_path": "pkg/sentry/syscalls/linux/sys_process_vm.go",
"diff": "@@ -26,10 +26,9 @@ import (\ntype vmReadWriteOp int\nconst (\n- localReader vmReadWriteOp = iota\n- localWriter\n- remoteReader\n- remoteWriter\n+... | Go | Apache License 2.0 | google/gvisor | Don't use other process's scratch buffer.
If we use the remote process's scratch buffer in process_vm_readv|writev
calls, we will get data races. Use the local task's scratch buffer always.
PiperOrigin-RevId: 491468904 |
259,891 | 29.11.2022 12:50:18 | 28,800 | b112db0675d7b40fafdb28cbd6ef83472590a1c1 | conntrack: don't nest conntrack locks | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -548,10 +548,8 @@ func (ct *ConnTrack) getConnAndUpdate(pkt PacketBufferPtr, skipChecksumValidatio\n}\n}\n- bktID := ct.bucket(tid)\n-\nct.mu.RLock()\n- bkt := &ct.buckets[b... | Go | Apache License 2.0 | google/gvisor | conntrack: don't nest conntrack locks
PiperOrigin-RevId: 491713226 |
259,868 | 29.11.2022 13:03:52 | 28,800 | 1ceee8c31071beacf7d28757ffa43da302dc570e | connectioned: Change nested lock name to only have a single nested lock.
Now there's the unnamed one, and "higherID" which is the lock for the
endpoint that has a higher ID.
The lock dependency should consistently be "lower ID" -> "higher ID". | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/unix/transport/BUILD",
"new_path": "pkg/sentry/socket/unix/transport/BUILD",
"diff": "@@ -22,8 +22,7 @@ declare_mutex(\nname = \"endpoint_mutex\",\nout = \"endpoint_mutex.go\",\nnested_lock_names = [\n- \"e\",\n- \"ce\",\n+ \"higherID\",\n],\... | Go | Apache License 2.0 | google/gvisor | connectioned: Change nested lock name to only have a single nested lock.
Now there's the unnamed one, and "higherID" which is the lock for the
endpoint that has a higher ID.
The lock dependency should consistently be "lower ID" -> "higher ID".
PiperOrigin-RevId: 491716600 |
259,975 | 29.11.2022 13:04:39 | 28,800 | bfbb9fa4cce0c4ce599dd218927d40d25394f4ed | Disable process_vm_(read|write)v.
Syzkaller has found several issues with the two syscalls and a rework is
required. Disable tests and the syscall until issues can be fixed. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -362,8 +362,8 @@ var AMD64 = &kernel.SyscallTable{\n307: syscalls.Supported(\"sendmmsg\", SendMMsg),\n308: syscalls.ErrorWithEvent(\"setns\", linuxerr.EOPNOT... | Go | Apache License 2.0 | google/gvisor | Disable process_vm_(read|write)v.
Syzkaller has found several issues with the two syscalls and a rework is
required. Disable tests and the syscall until issues can be fixed.
PiperOrigin-RevId: 491716795 |
259,909 | 29.11.2022 15:09:37 | 28,800 | ece02b45b5b4f3c67a98f684cede3bbdd18344dd | Add a maximum to the total number of mounts allowed in a namespace.
The limit is the same as a the default for /proc/sys/fs/mount-max.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/BUILD",
"new_path": "pkg/sentry/vfs/BUILD",
"diff": "@@ -151,6 +151,7 @@ go_library(\n\"//pkg/abi/linux\",\n\"//pkg/atomicbitops\",\n\"//pkg/bitmap\",\n+ \"//pkg/cleanup\",\n\"//pkg/context\",\n\"//pkg/errors/linuxerr\",\n\"//pkg/fd\",\n"
},
... | Go | Apache License 2.0 | google/gvisor | Add a maximum to the total number of mounts allowed in a namespace.
The limit is the same as a the default for /proc/sys/fs/mount-max.
Reported-by: syzbot+ae4591a5d362a6701e40@syzkaller.appspotmail.com
PiperOrigin-RevId: 491748452 |
259,982 | 29.11.2022 17:23:05 | 28,800 | 50f04e5aac0dce17f67dfd92a5d0b34e230cfa81 | Adding a LogEmit in event.go.
This creates a single function that logs
a warning in case of an error. | [
{
"change_type": "MODIFY",
"old_path": "pkg/eventchannel/event.go",
"new_path": "pkg/eventchannel/event.go",
"diff": "@@ -54,6 +54,16 @@ func Emit(msg proto.Message) error {\nreturn err\n}\n+// LogEmit is a helper method that calls DefaultEmitter.Emit.\n+// It also logs a warning message when an err... | Go | Apache License 2.0 | google/gvisor | Adding a LogEmit in event.go.
This creates a single function that logs
a warning in case of an error.
PiperOrigin-RevId: 491777874 |
259,985 | 30.11.2022 08:11:32 | 28,800 | 62ddad611979724c11372a5f49e2a986349279f2 | cgroupfs: Fix several races with task migration.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/pids.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/pids.go",
"diff": "@@ -161,14 +161,23 @@ func (c *pidsController) Leave(t *kernel.Task) {\n// PrepareMigrate implements controller.PrepareMigrate.\nfunc (c *pidsController) PrepareMig... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Fix several races with task migration.
Reported-by: syzbot+0be09ce607731f085f73@syzkaller.appspotmail.com
PiperOrigin-RevId: 491920581 |
259,909 | 30.11.2022 10:25:01 | 28,800 | 3dca16ed354fe0dd88fbb42bdaa894c569fb4b8e | Separate propagation methods/constants into their own file.
mount.go is becoming bloated, we should break it into smaller files
where it makes sense. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/BUILD",
"new_path": "pkg/sentry/vfs/BUILD",
"diff": "@@ -140,6 +140,7 @@ go_library(\n\"options.go\",\n\"pathname.go\",\n\"permissions.go\",\n+ \"propagation.go\",\n\"resolving_path.go\",\n\"save_restore.go\",\n\"shared_list.go\",\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Separate propagation methods/constants into their own file.
mount.go is becoming bloated, we should break it into smaller files
where it makes sense.
PiperOrigin-RevId: 491955373 |
259,909 | 30.11.2022 13:54:09 | 28,800 | 1823b16fccf7df2b77af8c53ca0f631096484447 | Clean up DecRefs in mount methods.
connectMountAt consumes the references held by the VirtualDentries.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -275,6 +275,7 @@ func (vfs *VirtualFilesystem) ConnectMountAt(ctx context.Context, creds *auth.Cr\ndefer cleanup.Clean()\n// Check if the new mount + all the propagation mounts puts u... | Go | Apache License 2.0 | google/gvisor | Clean up DecRefs in mount methods.
connectMountAt consumes the references held by the VirtualDentries.
Reported-by: syzbot+b415395b0b7186903700@syzkaller.appspotmail.com
PiperOrigin-RevId: 492009947 |
259,868 | 30.11.2022 13:59:00 | 28,800 | ba73788f2ce73fcb79376a7795f20d03a3829bca | gvisor: Explicitly register C++ toolchains for cross-compilation.
Bazel >= 5 seems to no longer implicitly recognize coral_crosstool's
C++ toolchains when looking through the possible set of toolchains to use for
compiling C++ (`@bazel_tools//tools/cpp:toolchain_type`).
This change explicitly registers these toolchains within `WORKSPACE`. | [
{
"change_type": "MODIFY",
"old_path": "BUILD",
"new_path": "BUILD",
"diff": "@@ -145,6 +145,28 @@ go_path(\n],\n)\n+# CC toolchain targets for cross-compilation.\n+# Required to be explicitly specified in bazel >= 5.\n+toolchain(\n+ name = \"cc_toolchain_k8\",\n+ target_compatible_with = [\n+ \"@pl... | Go | Apache License 2.0 | google/gvisor | gvisor: Explicitly register C++ toolchains for cross-compilation.
Bazel >= 5 seems to no longer implicitly recognize coral_crosstool's
C++ toolchains when looking through the possible set of toolchains to use for
compiling C++ (`@bazel_tools//tools/cpp:toolchain_type`).
This change explicitly registers these toolchains within `WORKSPACE`.
PiperOrigin-RevId: 492011138 |
259,992 | 30.11.2022 15:14:37 | 28,800 | 4f2479ae58f18c25c83c58d7a83d5203cdd37142 | Add K8s to Falco+gVisor tutorial | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/falco.md",
"new_path": "g3doc/user_guide/tutorials/falco.md",
"diff": "## Installation\n+This section explains the steps required to install Falco+gVisor integration\n+depending your environment.\n+\n+### Docker\n+\nFirst, install [g... | Go | Apache License 2.0 | google/gvisor | Add K8s to Falco+gVisor tutorial
PiperOrigin-RevId: 492030619 |
259,853 | 01.12.2022 12:53:29 | 28,800 | f59f942d4ff6efa22e6c7ffa7fea07d6ec43ab4c | buildkite: install docker runtimes only when it is required | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "@@ -80,6 +80,7 @@ done\nset -euo pipefail\n+if [[ \"${BUILDKITE_PIPELINE_INSTALL_RUNTIME:-}\" == \"true\" ]]; then\n# Remove all Docker runtimes that may be installed.\nnum_d... | Go | Apache License 2.0 | google/gvisor | buildkite: install docker runtimes only when it is required
PiperOrigin-RevId: 492275948 |
259,907 | 01.12.2022 13:59:27 | 28,800 | 9c444c44e012d600b167f5ce77cf8e39f4082aec | Cleanup remaining comments for
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/lock/lock.go",
"new_path": "pkg/sentry/fsimpl/lock/lock.go",
"diff": "@@ -164,14 +164,6 @@ func (l *Locks) LockRegion(ctx context.Context, uid UniqueID, ownerPID int32, t\n}\n}\n-// LockRegionVFS1 is a wrapper around LockRegion for VFS1, whic... | Go | Apache License 2.0 | google/gvisor | Cleanup remaining comments for #1624.
Fixes #1624
PiperOrigin-RevId: 492292937 |
259,982 | 01.12.2022 14:17:12 | 28,800 | 4e11daccf0be7328128e2c97b6cc77cfdd989020 | Adding more trace point integration tests for the following syscalls:
- signalfd
- signalfd4
- fcntl
- pipe
- pipe2
- timerfd_create
- timerfd_settime
- timerfd_gettime
- fork
- vfork
- inotify_init
- inotify_init1
- inotify_add_watch
- inotify_rm_watch
- clone
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/trace/BUILD",
"new_path": "test/trace/BUILD",
"diff": "@@ -4,8 +4,11 @@ package(licenses = [\"notice\"])\ngo_test(\nname = \"trace_test\",\n- size = \"small\",\n- srcs = [\"trace_test.go\"],\n+ srcs = [\n+ \"trace_amd64_test.go\",\n+ \"trace_arm64_test.go... | Go | Apache License 2.0 | google/gvisor | Adding more trace point integration tests for the following syscalls:
- signalfd
- signalfd4
- fcntl
- pipe
- pipe2
- timerfd_create
- timerfd_settime
- timerfd_gettime
- fork
- vfork
- inotify_init
- inotify_init1
- inotify_add_watch
- inotify_rm_watch
- clone
Updates #4805
PiperOrigin-RevId: 492297673 |
259,858 | 01.12.2022 15:36:40 | 28,800 | 175be3501193699bed06ab703832863802757650 | Fix lock violations.
The locks should not be rewritten. This is especially confusing with locking
seemingly respected in the first part of this function. Instead, just update
the relevant fields while holding appropriate locks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/internal/network/endpoint.go",
"new_path": "pkg/tcpip/transport/internal/network/endpoint.go",
"diff": "@@ -118,10 +118,9 @@ type multicastMembership struct {\n// Init initializes the endpoint.\nfunc (e *Endpoint) Init(s *stack.Stack, netPr... | Go | Apache License 2.0 | google/gvisor | Fix lock violations.
The locks should not be rewritten. This is especially confusing with locking
seemingly respected in the first part of this function. Instead, just update
the relevant fields while holding appropriate locks.
PiperOrigin-RevId: 492317437 |
259,909 | 01.12.2022 16:03:04 | 28,800 | 99cc6c2dea59ca51f7672359ed4321041fae02a4 | Display the proper root path in mountinfo. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -920,7 +920,7 @@ func (fs *filesystem) PrependPath(ctx context.Context, vfsroot, vd vfs.VirtualDe\nif mnt == vfsroot.Mount() && &d.vfsd == vfsroot.Dentry()... | Go | Apache License 2.0 | google/gvisor | Display the proper root path in mountinfo.
PiperOrigin-RevId: 492323370 |
259,985 | 02.12.2022 16:43:44 | 28,800 | d0ae59368d8a6c4e668301f0229d6329db52be18 | cgroupfs: Fix lock ordering between kernfs.Filesystem.mu and TaskSet.mu.
We can't DecRef a cgroup with TaskSet.mu held as it leads to circular
locking. Restructure task creation to drop cgroup refs outside the
TaskSet.mu critical section.
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_start.go",
"new_path": "pkg/sentry/kernel/task_start.go",
"diff": "@@ -19,7 +19,6 @@ import (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/atomicbitops\"\n- \"gvisor.dev/gvisor/pkg/cleanup\"\n\"gvisor.dev/gvisor/pkg/cont... | Go | Apache License 2.0 | google/gvisor | cgroupfs: Fix lock ordering between kernfs.Filesystem.mu and TaskSet.mu.
We can't DecRef a cgroup with TaskSet.mu held as it leads to circular
locking. Restructure task creation to drop cgroup refs outside the
TaskSet.mu critical section.
Reported-by: syzbot+16a334ab1d6873db18f2@syzkaller.appspotmail.com
Reported-by: syzbot+fe1b962d430d1170e671@syzkaller.appspotmail.com
PiperOrigin-RevId: 492589548 |
259,909 | 06.12.2022 14:19:00 | 28,800 | 6fb2a265a109554224f4f9d0708877521558a349 | Remove FUSE feature flag and enable by default. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -162,7 +162,6 @@ dev: $(RUNTIME_BIN) ## Installs a set of local runtimes. Requires sudo.\n@$(call configure_noreload,$(RUNTIME),--net-raw)\n@$(call configure_noreload,$(RUNTIME)-d,--net-raw --debug --strace --log-... | Go | Apache License 2.0 | google/gvisor | Remove FUSE feature flag and enable by default.
PiperOrigin-RevId: 493410677 |
259,909 | 07.12.2022 10:30:50 | 28,800 | f4fb010ef487086e733fb116dd98e4e87208b544 | Join subcontainer cgroup in cgroupfs instead of parent if it exists.
This is a no-op for most workloads; limits set on the parent affect
the child, and resource accounting of a child shows up in the parent.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -244,7 +244,7 @@ func New(conf *config.Config, args Args) (*Container, error) {\nif args.Spec.Linux.CgroupsPath == \"\" && !conf.TestOnlyAllowRunAsCurrentUserWithoutChroot {... | Go | Apache License 2.0 | google/gvisor | Join subcontainer cgroup in cgroupfs instead of parent if it exists.
This is a no-op for most workloads; limits set on the parent affect
the child, and resource accounting of a child shows up in the parent.
Fixes #8269
PiperOrigin-RevId: 493643530 |
259,982 | 07.12.2022 11:08:39 | 28,800 | 4a1a26f9666786f269a56f0dda986c3d3f3c6f66 | Adding metrics for start container in multi-container mode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/control.proto",
"new_path": "pkg/sentry/control/control.proto",
"diff": "@@ -40,6 +40,12 @@ message ControlConfig {\nrepeated Endpoint allowed_controls = 1;\n}\n+// ContainerStartedEvent is emitted when a container starts.\n+message Containe... | Go | Apache License 2.0 | google/gvisor | Adding metrics for start container in multi-container mode.
PiperOrigin-RevId: 493655449 |
259,982 | 07.12.2022 12:08:18 | 28,800 | a35ca06260a337280618da523919b1fd021ca749 | Adding metrics for exit_status of container in multi-container mode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/lifecycle.go",
"new_path": "pkg/sentry/control/lifecycle.go",
"diff": "@@ -336,7 +336,7 @@ func (l *Lifecycle) reap(containerID string, tg *kernel.ThreadGroup) {\nif err := l.updateContainerState(containerID, stateStopped); err != nil {\npan... | Go | Apache License 2.0 | google/gvisor | Adding metrics for exit_status of container in multi-container mode.
PiperOrigin-RevId: 493671987 |
260,004 | 07.12.2022 14:47:42 | 28,800 | b314d966ccb2d052f3d5e9c4c949b7c1834813c4 | Wait for GRO loop to stop
...before returning from groDispatcher.close.
This is to make sure that when we return from cleanup functions, the
caller can safely assume that resources have been released. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/gro.go",
"new_path": "pkg/tcpip/stack/gro.go",
"diff": "@@ -223,6 +223,7 @@ type groDispatcher struct {\nstop chan struct{}\nbuckets [groNBuckets]groBucket\n+ wg sync.WaitGroup\n}\nfunc (gd *groDispatcher) init(interval time.Duration) {\n@@ -24... | Go | Apache License 2.0 | google/gvisor | Wait for GRO loop to stop
...before returning from groDispatcher.close.
This is to make sure that when we return from cleanup functions, the
caller can safely assume that resources have been released.
PiperOrigin-RevId: 493714729 |
259,907 | 07.12.2022 15:55:25 | 28,800 | c6faaea7dc28b481123a141efd8dd83ae573f2c3 | Make tmpfs size accounting lock-free by using atomics.
This is likely to be a speed-up in the common case when contention between
threads is low. In such situations, generally atomic operations are faster. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -971,21 +971,22 @@ func (fs *filesystem) accountPagesPartial(pagesInc uint64) uint64 {\nreturn pagesInc\n}\n- // Need to acquire fs.pagesUsedMu for fs.page... | Go | Apache License 2.0 | google/gvisor | Make tmpfs size accounting lock-free by using atomics.
This is likely to be a speed-up in the common case when contention between
threads is low. In such situations, generally atomic operations are faster.
PiperOrigin-RevId: 493731992 |
259,853 | 07.12.2022 17:10:49 | 28,800 | 2e0cc62d827d8fa72c1abe3e0fc6615720753ce0 | tcpip/stack: use lockdep mutexes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "@@ -64,6 +64,7 @@ deps_test(\n\"//pkg/state\",\n\"//pkg/state/wire\",\n\"//pkg/sync\",\n+ \"//pkg/sync/locking\",\n\"//pkg/waiter\",\n\"//pkg/xdp\",\n"
},
{
"change_type": "MODIFY",
"old_pat... | Go | Apache License 2.0 | google/gvisor | tcpip/stack: use lockdep mutexes
PiperOrigin-RevId: 493749454 |
259,907 | 08.12.2022 11:01:50 | 28,800 | d17af25336d3cd33f9a9406e557f4e4e521347c8 | Add ENAMETOOLONG checks in overlayfs.
Linux overlayfs uses the max of all layers' filename length limit. Do the same
in gVisor.
This is needed to get PHP runtime test ext/standard/tests/strings/007.phpt to
pass with overlayfs. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -270,6 +270,7 @@ docker-tests: load-basic $(RUNTIME_BIN)\n@$(call install_runtime,$(RUNTIME)-fdlimit,--fdlimit=2000) # Used by TestRlimitNoFile.\n@$(call install_runtime,$(RUNTIME)-dcache,--fdlimit=2000 --dcache=1... | Go | Apache License 2.0 | google/gvisor | Add ENAMETOOLONG checks in overlayfs.
Linux overlayfs uses the max of all layers' filename length limit. Do the same
in gVisor.
This is needed to get PHP runtime test ext/standard/tests/strings/007.phpt to
pass with overlayfs.
PiperOrigin-RevId: 493942515 |
259,909 | 08.12.2022 14:13:36 | 28,800 | 2ff7a2750a771c24e87249e4c7bf8111bc00b7a0 | Only run sandbox in child cgroup if using cgroupv2
Joining a non-leaf node cgroup is only illegal in hierarchical
cgroup accounting. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -255,8 +255,8 @@ func New(conf *config.Config, args Args) (*Container, error) {\nreturn nil, fmt.Errorf(\"cannot set up cgroup for root: %w\", err)\n}\n// Join the child cgr... | Go | Apache License 2.0 | google/gvisor | Only run sandbox in child cgroup if using cgroupv2
Joining a non-leaf node cgroup is only illegal in hierarchical
cgroup accounting.
PiperOrigin-RevId: 493992577 |
260,004 | 08.12.2022 14:14:05 | 28,800 | d947422655f16bae014d411a40f9519fafd48b29 | Don't prevent removing loopback in core netstack
Implement this check in netstack integration (in sentry) so that the
core netstack does not prevent an integrator from removing loopback. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/stack.go",
"new_path": "pkg/sentry/socket/netstack/stack.go",
"diff": "@@ -80,6 +80,17 @@ func (s *Stack) Interfaces() map[int32]inet.Interface {\n// RemoveInterface implements inet.Stack.RemoveInterface.\nfunc (s *Stack) RemoveInter... | Go | Apache License 2.0 | google/gvisor | Don't prevent removing loopback in core netstack
Implement this check in netstack integration (in sentry) so that the
core netstack does not prevent an integrator from removing loopback.
PiperOrigin-RevId: 493992707 |
259,907 | 08.12.2022 14:35:23 | 28,800 | 110c3d76e4a60070be4e38204b23ce206bace87d | Remove remaining references to vfs2. | [
{
"change_type": "MODIFY",
"old_path": "images/syzkaller/default-gvisor-config.cfg",
"new_path": "images/syzkaller/default-gvisor-config.cfg",
"diff": "\"type\": \"gvisor\",\n\"vm\": {\n\"count\": 1,\n- \"runsc_args\": \"--debug --network none --platform ptrace --vfs2 -net-raw -watchdog-action=panic... | Go | Apache License 2.0 | google/gvisor | Remove remaining references to vfs2.
PiperOrigin-RevId: 493998299 |
259,985 | 08.12.2022 15:19:16 | 28,800 | a005752d88d1f5a5b629071e423e957e7a679ac9 | iouringfs: Pet the watchdog during ProcessSubmissions.
This loop can take a long time. Since we're blocking on IO outside
Task.Block, we need to periodically check for interrupts and update
pet the watchdog.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"new_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"diff": "@@ -337,6 +337,12 @@ func (fd *FileDescription) ProcessSubmissions(t *kernel.Task, toSubmit uint32, m\nsubmitted := uint32(0)\nfor toSubmit > submitted ... | Go | Apache License 2.0 | google/gvisor | iouringfs: Pet the watchdog during ProcessSubmissions.
This loop can take a long time. Since we're blocking on IO outside
Task.Block, we need to periodically check for interrupts and update
pet the watchdog.
Reported-by: syzbot+3fd282d7e4e5c83fc196@syzkaller.appspotmail.com
PiperOrigin-RevId: 494009269 |
259,978 | 09.12.2022 11:23:10 | 28,800 | 1cbabd822597466845c815811dd4a98f22a7581d | Fix not setting AddressDispatcher on promotion
AddressDispatcher was being set when adding an address only for new
addresses, resulting in cases such as when an expired addresses is
re-added to lose the AddressDispatcher that is passed.
Added a regression test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/addressable_endpoint_state.go",
"new_path": "pkg/tcpip/stack/addressable_endpoint_state.go",
"diff": "@@ -271,7 +271,6 @@ func (a *AddressableEndpointState) addAndAcquireAddressLocked(addr tcpip.Address\n// We never promote an address to tempor... | Go | Apache License 2.0 | google/gvisor | Fix not setting AddressDispatcher on promotion
AddressDispatcher was being set when adding an address only for new
addresses, resulting in cases such as when an expired addresses is
re-added to lose the AddressDispatcher that is passed.
Added a regression test.
PiperOrigin-RevId: 494220872 |
259,907 | 09.12.2022 14:49:12 | 28,800 | 368e8541469752b08312d25c56b654c626624410 | overlay2: Do not use O_TMPFILE to create unnamed temporary file.
Not all filesystems support O_TMPFILE. Instead manually create an unnamed
file by immediately unlinking the file after creation but keeping an FD on it.
Reported-by:
Proposed-by: Andrei Vagin | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -786,15 +786,19 @@ func createOverlayFilestore(overlay2 config.Overlay2) (*os.File, error) {\nif !fileInfo.IsDir() {\nreturn nil, fmt.Errorf(\"overlay2 flag should specify a... | Go | Apache License 2.0 | google/gvisor | overlay2: Do not use O_TMPFILE to create unnamed temporary file.
Not all filesystems support O_TMPFILE. Instead manually create an unnamed
file by immediately unlinking the file after creation but keeping an FD on it.
Reported-by: syzbot+3bf76e1ba1acde65c675@syzkaller.appspotmail.com
Proposed-by: Andrei Vagin <avagin@gmail.com>
PiperOrigin-RevId: 494269186 |
260,002 | 18.07.2022 14:07:45 | 25,200 | b4a05ce65b2257786b2e48300cdb07f425194196 | Add support for /proc/[pid]/limits | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task.go",
"new_path": "pkg/sentry/fsimpl/proc/task.go",
"diff": "@@ -64,6 +64,7 @@ func (fs *filesystem) newTaskInode(ctx context.Context, task *kernel.Task, pidns\n\"fdinfo\": fs.newFDInfoDirInode(ctx, task),\n\"gid_map\": fs.newTaskOwn... | Go | Apache License 2.0 | google/gvisor | Add support for /proc/[pid]/limits |
260,002 | 12.12.2022 17:13:27 | 28,800 | db0dfd6a3f9da26154ade878ceb265080b34af24 | Get limits only once instead of each loop iteration | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/proc/task_files.go",
"new_path": "pkg/sentry/fsimpl/proc/task_files.go",
"diff": "@@ -539,12 +539,13 @@ type limitsData struct {\n}\nfunc (d *limitsData) Generate(ctx context.Context, buf *bytes.Buffer) error {\n+ taskLimits := d.task.Limits(... | Go | Apache License 2.0 | google/gvisor | Get limits only once instead of each loop iteration |
259,909 | 13.12.2022 14:39:48 | 28,800 | 70be2fc8a77217eb98c723b2d491d6e2ceff4579 | Remove unsetting route's cached neighbor entry in link res callback.
This does not change behavior, since expired or invalid entries
are ignored anyways. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/route.go",
"new_path": "pkg/tcpip/stack/route.go",
"diff": "@@ -406,9 +406,6 @@ func (r *Route) resolvedFields(afterResolve func(ResolvedFieldsResult)) (RouteIn\n}\nafterResolveFields := fields\nentry, ch, err := r.linkRes.neigh.entry(r.nextHop... | Go | Apache License 2.0 | google/gvisor | Remove unsetting route's cached neighbor entry in link res callback.
This does not change behavior, since expired or invalid entries
are ignored anyways.
PiperOrigin-RevId: 495130325 |
259,950 | 02.12.2022 10:44:34 | -28,800 | 95ef37391962b608cdfca9d95d32be56095e0e12 | limit numbers of negative children to avoid infinitely increment of memory. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/BUILD",
"new_path": "pkg/sentry/fsimpl/gofer/BUILD",
"diff": "@@ -3,6 +3,18 @@ load(\"//tools/go_generics:defs.bzl\", \"go_template_instance\")\nlicenses([\"notice\"])\n+go_template_instance(\n+ name = \"string_list\",\n+ out = \"string... | Go | Apache License 2.0 | google/gvisor | limit numbers of negative children to avoid infinitely increment of memory.
Signed-off-by: Tan Yifeng <yiftan@tencent.com> |
259,975 | 13.12.2022 20:23:39 | 28,800 | 2deb308638ae09906c67ee6a33c062158b6f6dd3 | Add initial portforward fileDescriptionReadWriter methods and tests.
fileDescriptionReadWriter implements io.ReadWriter for use in port
forwarding. Add initial implementation and tests. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "runsc/boot/portforward/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_library(\n+ name = \"portforward\",\n+ srcs = [\n+ \"portforward.go\",\n+ \"portforward_fd_rw.go\",\n+... | Go | Apache License 2.0 | google/gvisor | Add initial portforward fileDescriptionReadWriter methods and tests.
fileDescriptionReadWriter implements io.ReadWriter for use in port
forwarding. Add initial implementation and tests.
PiperOrigin-RevId: 495196971 |
259,907 | 14.12.2022 09:57:37 | 28,800 | e3f77dddd7881dd8d00cd27d8c09001effea6aa9 | Deprecate 9P gofer protocol in runsc.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -75,12 +75,6 @@ import (\n\"gvisor.dev/gvisor/pkg/tcpip\"\n)\n-// LISAFSEnabled is set to true when lisafs protocol is enabled. Added as a\n-// global to allow easy access eve... | Go | Apache License 2.0 | google/gvisor | Deprecate 9P gofer protocol in runsc.
Updates #7911
PiperOrigin-RevId: 495343206 |
259,982 | 14.12.2022 12:44:07 | 28,800 | 1f8c4cb6bae3c45e3ec28449147e92689eeb2e86 | Adding container_start_duration metric for container multi-container mode.
Including the time when a container start request is
received and the time it is completed in the
ContainerStartedEvent proto message. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/BUILD",
"new_path": "pkg/sentry/control/BUILD",
"diff": "@@ -6,6 +6,9 @@ proto_library(\nname = \"control\",\nsrcs = [\"control.proto\"],\nvisibility = [\"//visibility:public\"],\n+ deps = [\n+ \"@com_google_protobuf//:timestamp_proto\",\n+ ... | Go | Apache License 2.0 | google/gvisor | Adding container_start_duration metric for container multi-container mode.
Including the time when a container start request is
received and the time it is completed in the
ContainerStartedEvent proto message.
PiperOrigin-RevId: 495390114 |
259,853 | 15.12.2022 10:13:44 | 28,800 | 14b5ff5a2f323dbb30c850d548cb3b1f6bbc8e41 | overlayfs: don't call SetStat and StatAt under dentry.mapsMu
This allows to avoid lock order inversions with inodeMutex and
filesystemRWMutex. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"new_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"diff": "@@ -144,8 +144,6 @@ func (d *dentry) copyUpMaybeSyntheticMountpointLocked(ctx context.Context, forSy\ncleanupUndoCopyUp()\nreturn err\n}\n- d.mapsMu.Lock()\n- d... | Go | Apache License 2.0 | google/gvisor | overlayfs: don't call SetStat and StatAt under dentry.mapsMu
This allows to avoid lock order inversions with inodeMutex and
filesystemRWMutex.
PiperOrigin-RevId: 495629138 |
260,004 | 16.12.2022 11:16:05 | 28,800 | a2ff07e535231f1f73a59830926b767ae65bac7d | Use struct to check mockMulticastGroupProtocol fields
Instead of passing each of the values as arguments to a function.
This prepares for a followup change which introduces a new field
to mockMulticastGroupProtocol that is unused in some places
(improving readability by not having to explicitly pass in a
function argument). | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol_test.go",
"new_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol_test.go",
"diff": "@@ -172,17 +172,22 @@ func (m *mockMulticastGroupProtocol) ShouldPerformProtocol(groupAddress tcpip.Ad\n... | Go | Apache License 2.0 | google/gvisor | Use struct to check mockMulticastGroupProtocol fields
Instead of passing each of the values as arguments to a function.
This prepares for a followup change which introduces a new field
to mockMulticastGroupProtocol that is unused in some places
(improving readability by not having to explicitly pass in a
function argument).
PiperOrigin-RevId: 495918528 |
259,853 | 16.12.2022 14:56:56 | 28,800 | 41009e886e100ac2272dd20df83e16d398961fa9 | stack/conntrack: suppress the nested locking warning
reapEverything intentionally takes the second bucket lock. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -112,6 +112,7 @@ declare_rwmutex(\ndeclare_rwmutex(\nname = \"bucket_mutex\",\nout = \"bucket_mutex.go\",\n+ nested_lock_names = [\"otherTuple\"],\npackage = \"stack\",\nprefix = \"bucket... | Go | Apache License 2.0 | google/gvisor | stack/conntrack: suppress the nested locking warning
reapEverything intentionally takes the second bucket lock.
PiperOrigin-RevId: 495967790 |
259,909 | 29.12.2022 13:52:11 | 28,800 | 85f261dd1eb299be5b82ce7808069c379275b87d | Pass the containerCgroup to the sandbox object instead of parent.
This is a bug reported by It affects sandboxes where
containerCgroup != parentCgroup. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/container.go",
"new_path": "runsc/container/container.go",
"diff": "@@ -283,7 +283,7 @@ func New(conf *config.Config, args Args) (*Container, error) {\nUserLog: args.UserLog,\nIOFiles: ioFiles,\nMountsFile: specFile,\n- Cgroup: parentCgroup,\n+... | Go | Apache License 2.0 | google/gvisor | Pass the containerCgroup to the sandbox object instead of parent.
This is a bug reported by #8311. It affects sandboxes where
containerCgroup != parentCgroup.
PiperOrigin-RevId: 498443910 |
259,858 | 04.01.2023 18:33:44 | 28,800 | 078109563976738c9ebe8d6e2b45a160fb3d5981 | Use arch_genrule for arch-specific VDSO data.
Note that the select_arch macro changed in order to allow for its use within
a rule below arch_genrule. The command line settings were being manipulated in
a way that did not correctly propagate the select_arch select constraints. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/loader/vdsodata/BUILD",
"new_path": "pkg/sentry/loader/vdsodata/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_add_tags\", \"go_embed_data\", \"go_library\")\n+load(\"//tools:defs.bzl\", \"arch_genrule\", \"go_embed_data\", \"go_library\")\npacka... | Go | Apache License 2.0 | google/gvisor | Use arch_genrule for arch-specific VDSO data.
Note that the select_arch macro changed in order to allow for its use within
a rule below arch_genrule. The command line settings were being manipulated in
a way that did not correctly propagate the select_arch select constraints.
PiperOrigin-RevId: 499651425 |
260,004 | 05.01.2023 11:13:51 | 28,800 | 8ebc4d767a432c7a4a97e25e048a1380b2a2e442 | Accept no buffer space errors when forwarding
The outgoing device queue may be full when forwarding packets and those
errors should not result in a panic. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/errors.go",
"new_path": "pkg/tcpip/network/internal/ip/errors.go",
"diff": "@@ -34,6 +34,14 @@ func (*ErrTTLExceeded) isForwardingError() {}\nfunc (*ErrTTLExceeded) String() string { return \"ttl exceeded\" }\n+// ErrOutgoingDevic... | Go | Apache License 2.0 | google/gvisor | Accept no buffer space errors when forwarding
The outgoing device queue may be full when forwarding packets and those
errors should not result in a panic.
PiperOrigin-RevId: 499946528 |
259,907 | 06.01.2023 11:16:39 | 28,800 | 3cbd2127f0828d45308d21d9382be7b99a4738fa | Add test to make sure overlay2 flag works for submounts with host filestore. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/shared_volume_test.go",
"new_path": "runsc/container/shared_volume_test.go",
"diff": "@@ -16,6 +16,7 @@ package container\nimport (\n\"bytes\"\n+ \"errors\"\n\"fmt\"\n\"io/ioutil\"\n\"os\"\n@@ -263,3 +264,53 @@ func TestSharedVolumeFile(t *test... | Go | Apache License 2.0 | google/gvisor | Add test to make sure overlay2 flag works for submounts with host filestore.
PiperOrigin-RevId: 500218219 |
260,004 | 06.01.2023 12:51:55 | 28,800 | 3d4743d96059f009bff7fa7900b48b7a40a1343e | Implement null timer
NullClock.AfterFunc should not return nil as that violates the API
expectations. Instead, return a timer that never fires. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/faketime/faketime.go",
"new_path": "pkg/tcpip/faketime/faketime.go",
"diff": "@@ -39,9 +39,22 @@ func (*NullClock) NowMonotonic() tcpip.MonotonicTime {\nreturn tcpip.MonotonicTime{}\n}\n+// nullTimer implements a timer that never fires.\n+type nullTi... | Go | Apache License 2.0 | google/gvisor | Implement null timer
NullClock.AfterFunc should not return nil as that violates the API
expectations. Instead, return a timer that never fires.
PiperOrigin-RevId: 500240130 |
259,985 | 06.01.2023 15:07:11 | 28,800 | a17ad261d6d08ab4a6702cbf8b917b6fba9e8ca0 | stateify: Handle multi-name fields in struct declarations. | [
{
"change_type": "MODIFY",
"old_path": "pkg/state/tests/struct.go",
"new_path": "pkg/state/tests/struct.go",
"diff": "@@ -98,3 +98,10 @@ type system3 struct {\nv2 any\nv3 any\n}\n+\n+// +stateify savable\n+type multiName struct {\n+ _, b, c string\n+ x, y int64\n+ z int32\n+}\n"
},
{
"change... | Go | Apache License 2.0 | google/gvisor | stateify: Handle multi-name fields in struct declarations.
PiperOrigin-RevId: 500268939 |
259,909 | 09.01.2023 10:22:37 | 28,800 | a248c63cd5df307b32bb2a7526bb2648249c4cfb | Fix circular lock between filesystemRWMutex and taskSetRWMutex. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/seccheck.go",
"new_path": "pkg/sentry/kernel/seccheck.go",
"diff": "@@ -19,17 +19,44 @@ import (\npb \"gvisor.dev/gvisor/pkg/sentry/seccheck/points/points_go_proto\"\n)\n+func getTaskCurrentWorkingDirectory(t *Task) string {\n+ // Grab the fi... | Go | Apache License 2.0 | google/gvisor | Fix circular lock between filesystemRWMutex and taskSetRWMutex.
PiperOrigin-RevId: 500747195 |
259,985 | 09.01.2023 11:09:37 | 28,800 | ef96e9328ea5bf92aa24875a3c3537b8edf04d81 | Disable io_uring syscalls by default.
The current io_uring support is very limited and experimental. Disable
it by default, and add a flag to enable it for testing. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/iouring.go",
"new_path": "pkg/abi/linux/iouring.go",
"diff": "@@ -126,6 +126,7 @@ type IOUringParams struct {\n// See struct io_uring_cqe in include/uapi/linux/io_uring.h.\n//\n// +marshal\n+// +stateify savable\ntype IOUringCqe struct {\nUserDat... | Go | Apache License 2.0 | google/gvisor | Disable io_uring syscalls by default.
The current io_uring support is very limited and experimental. Disable
it by default, and add a flag to enable it for testing.
PiperOrigin-RevId: 500760451 |
259,975 | 10.01.2023 11:10:13 | 28,800 | 2db971f5266d473cba5bbfa9bc17c9f1aacc6869 | Reduce number of Tensorflow test cases for dashboard.
A full run of all tensorflow test cases can take upwards of an hour
with very little benefit gained for most workloads. Reduce the number
of cases for dashboard runs. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -509,7 +509,7 @@ steps:\ncommand: make -i benchmark-platforms BENCHMARKS_SUITE=sysbench BENCHMARKS_TARGETS=test/benchmarks/base:sysbench_test\n- <<: *benchmarks\nlabel: \":tensorflo... | Go | Apache License 2.0 | google/gvisor | Reduce number of Tensorflow test cases for dashboard.
A full run of all tensorflow test cases can take upwards of an hour
with very little benefit gained for most workloads. Reduce the number
of cases for dashboard runs.
PiperOrigin-RevId: 501043752 |
259,977 | 10.01.2023 12:02:36 | 28,800 | c4976f7d8164e8cb08a2bce445bbf7ed2e82dc91 | [packetimpact] Fix typo in comment | [
{
"change_type": "MODIFY",
"old_path": "test/packetimpact/runner/main.go",
"new_path": "test/packetimpact/runner/main.go",
"diff": "@@ -503,7 +503,7 @@ func withSavedNetNS(f func() error) error {\nreturn err\n}\ndefer func() {\n- // Resotre the namespace when we return from f.\n+ // Restore the name... | Go | Apache License 2.0 | google/gvisor | [packetimpact] Fix typo in comment
PiperOrigin-RevId: 501057728 |
259,907 | 10.01.2023 17:34:27 | 28,800 | 5bb418ecdb695e47cb1a86dba4422ca7670ccbb1 | Unmount procfs from sandbox process, irrespective of apply-caps flag.
Earlier, we were only unmounting procfs mount if apply-caps flag was not set.
Directfs and hostinet set this flag to true. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/boot.go",
"new_path": "runsc/cmd/boot.go",
"diff": "@@ -137,7 +137,7 @@ func (b *Boot) SetFlags(f *flag.FlagSet) {\nf.BoolVar(&b.setUpRoot, \"setup-root\", false, \"if true, set up an empty root for the process\")\nf.BoolVar(&b.pidns, \"pidns\", fals... | Go | Apache License 2.0 | google/gvisor | Unmount procfs from sandbox process, irrespective of apply-caps flag.
Earlier, we were only unmounting procfs mount if apply-caps flag was not set.
Directfs and hostinet set this flag to true.
PiperOrigin-RevId: 501136480 |
259,853 | 11.01.2023 13:21:11 | 28,800 | ff8aa35e1c2c9e3ad33dc991f605baa2b551e2db | Dynamically determine the address space size | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -56,6 +56,8 @@ go_library(\n\"linux.go\",\n\"membarrier.go\",\n\"mm.go\",\n+ \"mm_amd64.go\",\n+ \"mm_arm64.go\",\n\"mqueue.go\",\n\"msgqueue.go\",\n\"netdevice.go\",\n@@ -99,6 +101,7 @@ go_l... | Go | Apache License 2.0 | google/gvisor | Dynamically determine the address space size
PiperOrigin-RevId: 501362170 |
259,907 | 11.01.2023 13:30:01 | 28,800 | 69859a21f82c61762906465340795c484f3927d1 | Add a stress test for multicontainers to check for memory leak.
The test runs 50 subcontainers that do a lot of filesystem work and checks that
after the containers exit, there is no increase in sandbox memory usage. | [
{
"change_type": "MODIFY",
"old_path": "runsc/container/multi_container_test.go",
"new_path": "runsc/container/multi_container_test.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"os\"\n\"path\"\n\"path/filepath\"\n+ \"reflect\"\n\"strings\"\n\"testing\"\n\"time\"\n@@ -2291,3 +2292,117 @@ func TestMulti... | Go | Apache License 2.0 | google/gvisor | Add a stress test for multicontainers to check for memory leak.
The test runs 50 subcontainers that do a lot of filesystem work and checks that
after the containers exit, there is no increase in sandbox memory usage.
PiperOrigin-RevId: 501364377 |
260,004 | 11.01.2023 17:22:35 | 28,800 | 4560252d1693c65b9e9106cfdb93208a40b90c6e | Coalesce records for reports on MGP disable
This change sends multiple records into a single IGMPv3/MLDv2 report
instead of a single record per report when disabling IGMPv3/MLDv2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"diff": "@@ -343,20 +343,17 @@ func (g *GenericMulticastProtocolState) MakeAllNonMemberLocked() {\n}\ng.cancelV2ReportTimer... | Go | Apache License 2.0 | google/gvisor | Coalesce records for reports on MGP disable
This change sends multiple records into a single IGMPv3/MLDv2 report
instead of a single record per report when disabling IGMPv3/MLDv2.
Updates #8346
PiperOrigin-RevId: 501419672 |
260,004 | 11.01.2023 17:56:15 | 28,800 | e49f78af9e55ed12a06a06d9bc23421e53e57a99 | Extract IGMPv3/MLDv2 report validation helpers
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/testutil/BUILD",
"new_path": "pkg/tcpip/network/internal/testutil/BUILD",
"diff": "@@ -4,6 +4,7 @@ package(licenses = [\"notice\"])\ngo_library(\nname = \"testutil\",\n+ testonly = True,\nsrcs = [\"testutil.go\"],\nvisibility = [\n\"... | Go | Apache License 2.0 | google/gvisor | Extract IGMPv3/MLDv2 report validation helpers
Updates #8346
PiperOrigin-RevId: 501425348 |
259,927 | 12.01.2023 07:40:05 | 28,800 | 2b208ac832f9be1c1e5ebc01d9075b1b4dc3fecf | Set PktType for all Ethernet Packets
In preparation for improving ARP handling of gratuitous ARPs, set PktType in
regular inbound flow instead of only when handling packet sockets. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/ethernet/BUILD",
"new_path": "pkg/tcpip/link/ethernet/BUILD",
"diff": "@@ -26,5 +26,6 @@ go_test(\n\"//pkg/tcpip/header\",\n\"//pkg/tcpip/link/channel\",\n\"//pkg/tcpip/stack\",\n+ \"@com_github_google_go_cmp//cmp:go_default_library\",\n],\n)\n"... | Go | Apache License 2.0 | google/gvisor | Set PktType for all Ethernet Packets
In preparation for improving ARP handling of gratuitous ARPs, set PktType in
regular inbound flow instead of only when handling packet sockets.
PiperOrigin-RevId: 501562322 |
259,853 | 12.01.2023 12:30:25 | 28,800 | aade3a56b5a5b7ce2adf1c7035a6d10bc538ec9d | Don't register async handlers for signalfd descriptors
This is a missing part of cl/483861398. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/file_description.go",
"new_path": "pkg/sentry/vfs/file_description.go",
"diff": "@@ -276,6 +276,7 @@ func (fd *FileDescription) SetStatusFlags(ctx context.Context, creds *auth.Crede\n// TODO(gvisor.dev/issue/1035): FileDescriptionImpl.SetOAsync(... | Go | Apache License 2.0 | google/gvisor | Don't register async handlers for signalfd descriptors
This is a missing part of cl/483861398.
PiperOrigin-RevId: 501636729 |
259,927 | 12.01.2023 13:05:02 | 28,800 | a6fe4d1d8f82c444722aac6d3ef6e317f3f1459c | Handle gratuitous ARP as unsolicited reply
A gratuitous ARP does not infer two-way connectivity and must not move neighbor
state to reachable. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/arp/arp.go",
"new_path": "pkg/tcpip/network/arp/arp.go",
"diff": "@@ -230,12 +230,11 @@ func (e *endpoint) HandlePacket(pkt stack.PacketBufferPtr) {\ne.dad.StopLocked(addr, &stack.DADDupAddrDetected{HolderLinkAddress: linkAddr})\ne.mu.Unlock(... | Go | Apache License 2.0 | google/gvisor | Handle gratuitous ARP as unsolicited reply
A gratuitous ARP does not infer two-way connectivity and must not move neighbor
state to reachable.
PiperOrigin-RevId: 501645481 |
260,004 | 13.01.2023 12:55:48 | 28,800 | 12e13426bec35d05b29d6b0cd136dab3e0ea821a | Test sending multiple queued IGMP reports
This change updates TestSendQueuedIGMPReports to join multiple groups
when performing the test.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/igmp_test.go",
"new_path": "pkg/tcpip/network/ipv4/igmp_test.go",
"diff": "@@ -41,8 +41,9 @@ const (\nvar (\nstackAddr = testutil.MustParse4(\"10.0.0.1\")\nremoteAddr = testutil.MustParse4(\"10.0.0.2\")\n- multicastAddr = testutil.MustPa... | Go | Apache License 2.0 | google/gvisor | Test sending multiple queued IGMP reports
This change updates TestSendQueuedIGMPReports to join multiple groups
when performing the test.
Updates #8346
PiperOrigin-RevId: 501918703 |
260,004 | 13.01.2023 13:58:05 | 28,800 | c76b03723e614707d105c3f3be8fcfe8250e2e74 | Coalesce records sent by the state changed timer
When the state changed timer fires, instead of sending a single record
per report, send as many records as possible per report message.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"diff": "@@ -520,6 +520,7 @@ func (g *GenericMulticastProtocolState) sendV2ReportAndMaybeScheduleChangedTimer\ng.protocolMU... | Go | Apache License 2.0 | google/gvisor | Coalesce records sent by the state changed timer
When the state changed timer fires, instead of sending a single record
per report, send as many records as possible per report message.
Updates #8346
PiperOrigin-RevId: 501932735 |
260,004 | 13.01.2023 14:36:00 | 28,800 | a8900d549bbc3ea0d4002204f2cd5c372ba467b6 | Coalesce records for reports on MGP enable
This change sends multiple records into a single IGMPv3/MLDv2 report
instead of a single record per report when enabling IGMPv3/MLDv2.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"new_path": "pkg/tcpip/network/internal/ip/generic_multicast_protocol.go",
"diff": "@@ -195,6 +195,8 @@ type MulticastGroupProtocolV2ReportBuilder interface {\n// Send sends the report.\n//\n+ // Do... | Go | Apache License 2.0 | google/gvisor | Coalesce records for reports on MGP enable
This change sends multiple records into a single IGMPv3/MLDv2 report
instead of a single record per report when enabling IGMPv3/MLDv2.
Updates #8346
PiperOrigin-RevId: 501941751 |
260,004 | 13.01.2023 16:54:06 | 28,800 | d3894e4481012ea83ee7d1c9b87cca2c1425fdf0 | Populate IGMPv3 report checksum
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/checker/checker.go",
"new_path": "pkg/tcpip/checker/checker.go",
"diff": "@@ -1650,6 +1650,9 @@ func IGMPv3Report(expectedRecords map[tcpip.Address]header.IGMPv3ReportRecordTyp\n}\nreport := header.IGMPv3Report(igmp)\n+ if got, want := report.Checksu... | Go | Apache License 2.0 | google/gvisor | Populate IGMPv3 report checksum
Updates #8346
PiperOrigin-RevId: 501969927 |
259,975 | 17.01.2023 14:40:48 | 28,800 | 1ae11b17a9d7eb8124971f147aeb3c916ab7cf9d | Implement hostinet port forward
Implement support sandboxes using hostinet for their network stack. Included
is an implmentation of a connection servering a sandboxed process forwarding
to a socket on a local port. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/portforward/BUILD",
"new_path": "runsc/boot/portforward/BUILD",
"diff": "@@ -7,13 +7,19 @@ go_library(\nsrcs = [\n\"portforward.go\",\n\"portforward_fd_rw.go\",\n+ \"portforward_hostinet.go\",\n],\ndeps = [\n+ \"//pkg/cleanup\",\n\"//pkg/context\",\... | Go | Apache License 2.0 | google/gvisor | Implement hostinet port forward
Implement support sandboxes using hostinet for their network stack. Included
is an implmentation of a connection servering a sandboxed process forwarding
to a socket on a local port.
PiperOrigin-RevId: 502692640 |
259,909 | 17.01.2023 15:05:17 | 28,800 | d3c86781abdff20e4d6675d93268f9befca028a4 | Fix flaky link resolution test.
mointorableEndpoint was flaking because of a race between the
pending packet from the failed write and the new write. We don't
actually need the new write to show that link resolution worked. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/integration/link_resolution_test.go",
"new_path": "pkg/tcpip/tests/integration/link_resolution_test.go",
"diff": "@@ -1828,7 +1828,7 @@ func TestUpdateCachedNeighborEntry(t *testing.T) {\n// Send packet to neighbor (start link resolution & reso... | Go | Apache License 2.0 | google/gvisor | Fix flaky link resolution test.
mointorableEndpoint was flaking because of a race between the
pending packet from the failed write and the new write. We don't
actually need the new write to show that link resolution worked.
PiperOrigin-RevId: 502699348 |
259,909 | 17.01.2023 15:59:04 | 28,800 | 3c93bb10405f2d2e42ccfe8e65ae63c9857879ee | Defer kernfs openflag handling to inode implementations.
Some implementations handle more flags than others, so it doesn't
make sense to have one set of rules for all.
This change should functionally be a no-op. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"new_path": "pkg/sentry/fsimpl/cgroupfs/cgroupfs.go",
"diff": "@@ -523,6 +523,8 @@ func (d *dir) SetStat(ctx context.Context, fs *vfs.Filesystem, creds *auth.Crede\n// Open implements kernfs.Inode.Open.\nfunc (d *dir) O... | Go | Apache License 2.0 | google/gvisor | Defer kernfs openflag handling to inode implementations.
Some implementations handle more flags than others, so it doesn't
make sense to have one set of rules for all.
This change should functionally be a no-op.
PiperOrigin-RevId: 502712415 |
259,853 | 18.01.2023 07:32:42 | 28,800 | 2a56495dfaef6add3fa81e9cccd5623bb4c40d80 | test: check that we can change registers via ptrace | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/ptrace.go",
"new_path": "pkg/sentry/kernel/ptrace.go",
"diff": "@@ -1160,8 +1160,6 @@ func (t *Task) Ptrace(req int64, pid ThreadID, addr, data hostarch.Addr) error {\nreturn err\n}\n- t.p.PullFullState(t.MemoryManager().AddressSpace(), t.Arc... | Go | Apache License 2.0 | google/gvisor | test: check that we can change registers via ptrace
PiperOrigin-RevId: 502871694 |
259,985 | 19.01.2023 14:06:31 | 28,800 | 7d68beb26149dde9038c1bc727cca80dddb10810 | Allow construction of mount namespace from existing filesystem. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -207,13 +207,20 @@ func (vfs *VirtualFilesystem) NewMountNamespace(ctx context.Context, creds *auth\nif err != nil {\nreturn nil, err\n}\n+ return vfs.NewMountNamespaceFrom(ctx, creds... | Go | Apache License 2.0 | google/gvisor | Allow construction of mount namespace from existing filesystem.
PiperOrigin-RevId: 503260418 |
259,868 | 19.01.2023 14:38:04 | 28,800 | 5a6a36d22230d6fc8cbe27fc2cc93173319d3c9d | `runsc` metric server: Periodically add sandboxes that failed registration.
The metric server periodically scans the root directory and picks up all
the containers that requested instrumentation.
This change is part of a series of changes to support Prometheus-style metrics
in `runsc`. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/metric_server.go",
"new_path": "runsc/cmd/metric_server.go",
"diff": "@@ -69,6 +69,7 @@ const (\ntype servedSandbox struct {\nrootContainerID container.FullID\nrootDir string\n+ metricServerAddr string\nextraLabels map[string]string\n// mu protects t... | Go | Apache License 2.0 | google/gvisor | `runsc` metric server: Periodically add sandboxes that failed registration.
The metric server periodically scans the root directory and picks up all
the containers that requested instrumentation.
This change is part of a series of changes to support Prometheus-style metrics
in `runsc`.
PiperOrigin-RevId: 503268994 |
259,868 | 19.01.2023 14:38:22 | 28,800 | fa72d6e37df3c1c9e36fc297d735210f33c4280d | `runsc/sandbox`: Make `OverlayFileUsage` follow convention for urpc methods. | [
{
"change_type": "MODIFY",
"old_path": "runsc/sandbox/sandbox.go",
"new_path": "runsc/sandbox/sandbox.go",
"diff": "@@ -1240,14 +1240,12 @@ func (s *Sandbox) ChangeLogging(args control.LoggingArgs) error {\n// OverlayFileUsage returns the current usage (bytes) of the overlay filestore.\nfunc (s *San... | Go | Apache License 2.0 | google/gvisor | `runsc/sandbox`: Make `OverlayFileUsage` follow convention for urpc methods.
PiperOrigin-RevId: 503269077 |
259,992 | 19.01.2023 16:35:59 | 28,800 | 0e5d0cc13abce38832634d508cbd620b89364ac0 | Rename pselect to pselect6
The actual syscall name is pselect6. This name is used in Docker's
default seccomp profile. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/linux64.go",
"new_path": "pkg/sentry/syscalls/linux/linux64.go",
"diff": "@@ -322,7 +322,7 @@ var AMD64 = &kernel.SyscallTable{\n267: syscalls.Supported(\"readlinkat\", Readlinkat),\n268: syscalls.Supported(\"fchmodat\", Fchmodat),\n2... | Go | Apache License 2.0 | google/gvisor | Rename pselect to pselect6
The actual syscall name is pselect6. This name is used in Docker's
default seccomp profile.
PiperOrigin-RevId: 503297316 |
259,909 | 20.01.2023 14:02:59 | 28,800 | 492d7a98116b79127bf2fb5e6becbe6376b78854 | Decref target VirtualDentry outside the vfs mount lock during mount ops.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -273,28 +273,32 @@ func (vfs *VirtualFilesystem) ConnectMountAt(ctx context.Context, creds *auth.Cr\nreturn err\n}\nvfs.mountMu.Lock()\n- defer vfs.mountMu.Unlock()\ntree := vfs.prepa... | Go | Apache License 2.0 | google/gvisor | Decref target VirtualDentry outside the vfs mount lock during mount ops.
Reported-by: syzbot+ad021a61205c51a59627@syzkaller.appspotmail.com
PiperOrigin-RevId: 503518033 |
259,907 | 20.01.2023 14:20:03 | 28,800 | a58df80df31b27d448ca430bdb31b456d51e2609 | Make directory open flags checks consistent in tmpfs and kernfs.
Overlayfs and goferfs seem to be up to date.
Updated syscall tests. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -618,6 +618,19 @@ afterTrailingSymlink:\nif err := child.inode.CheckPermissions(ctx, rp.Credentials(), ats); err != nil {\nreturn nil, err\n}\n+ if child... | Go | Apache License 2.0 | google/gvisor | Make directory open flags checks consistent in tmpfs and kernfs.
Overlayfs and goferfs seem to be up to date.
Updated syscall tests.
PiperOrigin-RevId: 503521750 |
259,891 | 20.01.2023 14:44:11 | 28,800 | 226daf3879074a25c88dbbd972362e783b6e20cc | github: add quotes around shell variable | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -23,9 +23,9 @@ jobs:\n- id: setup\nrun: |\nif ! [[ -z \"${{ secrets.GO_TOKEN }}\" ]]; then\n- echo has_token=true >> $GITHUB_OUTPUT\n+ echo has_token=true >> \"$GITHUB_OUTPUT\"\nels... | Go | Apache License 2.0 | google/gvisor | github: add quotes around shell variable
PiperOrigin-RevId: 503526899 |
259,853 | 20.01.2023 17:08:27 | 28,800 | e08f204299dfcd6a93fde73375933cfa5f017740 | inet: each socket has to hold a reference to its network namespace
Otherwise a network namespace can be destroyed before sockets.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/netstack/netstack.go",
"new_path": "pkg/sentry/socket/netstack/netstack.go",
"diff": "@@ -342,11 +342,11 @@ type commonEndpoint interface {\nSocketOptions() *tcpip.SocketOptions\n}\n-// Socket encapsulates all the state needed to represent a ... | Go | Apache License 2.0 | google/gvisor | inet: each socket has to hold a reference to its network namespace
Otherwise a network namespace can be destroyed before sockets.
Reported-by: syzbot+78dcf6a117cd41dcb84e@syzkaller.appspotmail.com
PiperOrigin-RevId: 503552997 |
259,907 | 22.01.2023 18:57:15 | 28,800 | fe562179fea178b4044a4a30fe60264e2a6fa869 | Handle absolute symlink target '/' correctly in VFS layer.
vfs.ResolvingPath.relpathPrepend() has a precondition which was being violated
when handling resolveAbsSymlinkError. This was only happening when
`rp.absSymlinkTarget = "/"` because it has no path components. Added check for
that and also added regression test.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/dentry_impl.go",
"new_path": "pkg/sentry/fsimpl/gofer/dentry_impl.go",
"diff": "@@ -201,7 +201,7 @@ func (d *dentry) getRemoteChild(ctx context.Context, name string) (*dentry, erro\n// - fs.renameMu must be locked.\n// - parent.dirMu mu... | Go | Apache License 2.0 | google/gvisor | Handle absolute symlink target '/' correctly in VFS layer.
vfs.ResolvingPath.relpathPrepend() has a precondition which was being violated
when handling resolveAbsSymlinkError. This was only happening when
`rp.absSymlinkTarget = "/"` because it has no path components. Added check for
that and also added regression test.
Reported-by: syzbot+48846f91b6252b56382f@syzkaller.appspotmail.com
PiperOrigin-RevId: 503862090 |
259,881 | 23.01.2023 11:28:20 | 28,800 | f8375fac104532e6a1d8a8c7600cfa8ae4faf2f9 | Remove useless use of fmt.Sprint | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/test/e2e/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/test/e2e/tcp_test.go",
"diff": "@@ -3604,7 +3604,7 @@ func TestDefaultTTL(t *testing.T) {\n{\"ipv4\", ipv4.ProtocolNumber, context.TestAddr},\n{\"ipv6\", ipv6.ProtocolNumber, c... | Go | Apache License 2.0 | google/gvisor | Remove useless use of fmt.Sprint
PiperOrigin-RevId: 504037414 |
259,858 | 23.01.2023 13:27:23 | 28,800 | 12a930a63e132d310bcb0db4c6490b8f7f156f3d | Move goid to dynamic facts render.
This removes the need for ongoing tags.
This change requires some minor updates to remove dependency cycles, since
the goid package is a base library used by many internals (log, sync, etc.). | [
{
"change_type": "MODIFY",
"old_path": "pkg/goid/BUILD",
"new_path": "pkg/goid/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+load(\"//tools:defs.bzl\", \"arch_genrule\", \"go_library\", \"go_test\", \"select_arch\")\n+load(\"//tools/nogo:defs.bzl\", \"nogo_facts\")\npac... | Go | Apache License 2.0 | google/gvisor | Move goid to dynamic facts render.
This removes the need for ongoing tags.
This change requires some minor updates to remove dependency cycles, since
the goid package is a base library used by many internals (log, sync, etc.).
PiperOrigin-RevId: 504066914 |
259,907 | 24.01.2023 11:14:25 | 28,800 | 22961a9e41a141b70d1ffa0fc02c00efe93801be | Make kernfs.walkParentDirLocked() start path traversal from passed dentry.
This is analogous to all other filesystem implementations and their
walkParentDirLocked() implementations. This is required because sometimes
walkParentDirLocked() is called after symlinks are followed. And the
traversal should continue from the parent of the symlink file. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/kernfs/filesystem.go",
"diff": "@@ -180,8 +180,7 @@ func (fs *Filesystem) walkExistingLocked(ctx context.Context, rp *vfs.ResolvingP\n// - !rp.Done().\n//\n// Postconditions: Caller must c... | Go | Apache License 2.0 | google/gvisor | Make kernfs.walkParentDirLocked() start path traversal from passed dentry.
This is analogous to all other filesystem implementations and their
walkParentDirLocked() implementations. This is required because sometimes
walkParentDirLocked() is called after symlinks are followed. And the
traversal should continue from the parent of the symlink file.
PiperOrigin-RevId: 504326573 |
259,881 | 24.01.2023 14:54:23 | 28,800 | 2e68fa3c15d47ef9e54f81e368e6189fcfd2e257 | Enable analysis of packages using type parameters
Upstream analyzers support type parameters now, so we no longer need to skip
analysis. | [
{
"change_type": "MODIFY",
"old_path": "tools/checkinfo/checkinfo.go",
"new_path": "tools/checkinfo/checkinfo.go",
"diff": "@@ -74,12 +74,16 @@ func walkObject(pass *analysis.Pass, obj types.Object) {\npass.ExportObjectFact(obj, &a)\npass.ExportObjectFact(obj, &s)\ncase *types.TypeName:\n- // Skip i... | Go | Apache License 2.0 | google/gvisor | Enable analysis of packages using type parameters
Upstream analyzers support type parameters now, so we no longer need to skip
analysis.
PiperOrigin-RevId: 504383378 |
260,002 | 14.12.2022 11:39:47 | 28,800 | 90873a990380be6c1d64498dde1020f01fb69971 | Add simple unit test checking limits | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -2139,6 +2139,7 @@ cc_binary(\nlinkstatic = 1,\ndeps = [\n\"//test/util:capability_util\",\n+ \"//test/util:proc_util\",\n\"//test/util:test_main\",\n\"//test/util:test_util\",\n\... | Go | Apache License 2.0 | google/gvisor | Add simple unit test checking limits |
259,853 | 24.01.2023 17:12:43 | 28,800 | aeabb7852781e764655feeca8f67c46be14b0bc0 | Allow to return an error from PullFullState. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_clone.go",
"new_path": "pkg/sentry/kernel/task_clone.go",
"diff": "@@ -65,7 +65,12 @@ func (t *Task) Clone(args *linux.CloneArgs) (ThreadID, *SyscallControl, error) {\n// Pull task registers and FPU state, a cloned task will inherit the\... | Go | Apache License 2.0 | google/gvisor | Allow to return an error from PullFullState.
PiperOrigin-RevId: 504415294 |
259,992 | 25.01.2023 13:03:13 | 28,800 | b4c64d11f166496a11717f035ff51b8dc7dca6a0 | Log seccomp from spec
Only log if OCI seccomp flag is enabled, otherwise the seccomp field
is ignored. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/controller.go",
"new_path": "runsc/boot/controller.go",
"diff": "@@ -293,7 +293,7 @@ func (cm *containerManager) StartSubcontainer(args *StartArgs, _ *struct{}) erro\n}\n// All validation passed, logs the spec for debugging.\n- specutils.LogSpec(arg... | Go | Apache License 2.0 | google/gvisor | Log seccomp from spec
Only log if OCI seccomp flag is enabled, otherwise the seccomp field
is ignored.
PiperOrigin-RevId: 504640124 |
259,891 | 25.01.2023 14:27:59 | 28,800 | cef82030f6e5af29daeac1a09efd176bbf4e9db8 | github: update actions/setup-go to newest version | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -43,7 +43,7 @@ jobs:\nif: github.event_name == 'pull_request' || steps.setup.outputs.has_token != 'true'\nwith:\nfetch-depth: 0\n- - uses: actions/setup-go@v2\n+ - uses: actions/set... | Go | Apache License 2.0 | google/gvisor | github: update actions/setup-go to newest version
PiperOrigin-RevId: 504662268 |
259,891 | 25.01.2023 16:35:09 | 28,800 | 2b5f0e1b8ed24c05b12297a3e9be9b5d83c65147 | github: update actions/checkout to newest version | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/go.yml",
"new_path": ".github/workflows/go.yml",
"diff": "@@ -34,12 +34,12 @@ jobs:\n-H \"Authorization: token ${{ secrets.GITHUB_TOKEN }}\" \\\n\"${{ github.event.pull_request.statuses_url }}\"\nif: github.event_name == 'pull_request'\n- - u... | Go | Apache License 2.0 | google/gvisor | github: update actions/checkout to newest version
PiperOrigin-RevId: 504693188 |
259,881 | 26.01.2023 13:25:06 | 28,800 | 0c38f72156b0a74be293579c165477ced9fe60d5 | Move procid to dynamic facts render
Based on cl/504066914, this generates the proper procid offsets at build time.
Package facts needs an update to properly skip underscore imports, which don't
have facts for some reason (because they are unnamed?).
Drop use of runtime.getprocid given that these generated code is pretty solid. | [
{
"change_type": "MODIFY",
"old_path": "pkg/procid/BUILD",
"new_path": "pkg/procid/BUILD",
"diff": "-load(\"//tools:defs.bzl\", \"go_library\", \"go_test\")\n+load(\"//tools:defs.bzl\", \"arch_genrule\", \"go_library\", \"go_test\", \"select_arch\")\n+load(\"//tools/nogo:defs.bzl\", \"nogo_facts\")\... | Go | Apache License 2.0 | google/gvisor | Move procid to dynamic facts render
Based on cl/504066914, this generates the proper procid offsets at build time.
Package facts needs an update to properly skip underscore imports, which don't
have facts for some reason (because they are unnamed?).
Drop use of runtime.getprocid given that these generated code is pretty solid.
PiperOrigin-RevId: 504926257 |
259,909 | 26.01.2023 13:29:01 | 28,800 | f0d5892907c89ed28444c4ea9c06beaff14792f8 | Fix flaky creat_test. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"new_path": "pkg/sentry/fsimpl/fuse/fusefs.go",
"diff": "@@ -524,8 +524,7 @@ func (*inode) IterDirents(ctx context.Context, mnt *vfs.Mount, callback vfs.Iter\n// NewFile implements kernfs.Inode.NewFile.\nfunc (i *inode) NewFi... | Go | Apache License 2.0 | google/gvisor | Fix flaky creat_test.
PiperOrigin-RevId: 504927279 |
259,907 | 26.01.2023 22:54:18 | 28,800 | c4fe64c5ef18c99854abe262fbfb2a7100fd408d | Add dir= prefix in overlay2 flag's medium.
This is to make it clear that the host file will be created inside this
directory. This also makes it look cleaner when other medium options are added
later. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -270,7 +270,7 @@ docker-tests: load-basic $(RUNTIME_BIN)\n@$(call install_runtime,$(RUNTIME)-fdlimit,--fdlimit=2000) # Used by TestRlimitNoFile.\n@$(call install_runtime,$(RUNTIME)-dcache,--fdlimit=2000 --dcache=1... | Go | Apache License 2.0 | google/gvisor | Add dir= prefix in overlay2 flag's medium.
This is to make it clear that the host file will be created inside this
directory. This also makes it look cleaner when other medium options are added
later.
PiperOrigin-RevId: 505033408 |
259,881 | 27.01.2023 10:25:36 | 28,800 | 16c24b1cec398512458022db8758ade9ebfdfbc1 | Use unsafe.String/StringData to implement string functions
unsafe.String and unsafe.StringData provide compatibility guarantees that don't
require us to verify compatibility in each release.
For | [
{
"change_type": "MODIFY",
"old_path": "pkg/gohacks/BUILD",
"new_path": "pkg/gohacks/BUILD",
"diff": "@@ -8,6 +8,8 @@ go_library(\n\"gohacks_unsafe.go\",\n\"slice_go113_unsafe.go\",\n\"slice_go120_unsafe.go\",\n+ \"string_go113_unsafe.go\",\n+ \"string_go120_unsafe.go\",\n],\nstateify = False,\nvisi... | Go | Apache License 2.0 | google/gvisor | Use unsafe.String/StringData to implement string functions
unsafe.String and unsafe.StringData provide compatibility guarantees that don't
require us to verify compatibility in each release.
For #8422.
PiperOrigin-RevId: 505150667 |
259,881 | 27.01.2023 11:49:28 | 28,800 | ee3a8735b5682878543019cdeae459e850c01bf7 | Move runtime constants to dynamic facts render | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/BUILD",
"new_path": "pkg/sync/BUILD",
"diff": "@@ -28,6 +28,14 @@ arch_genrule(\ntemplate = \"runtime_spinning_impl_%s.s\",\n)\n+# Architecture-independent constants.\n+nogo_facts(\n+ name = \"runtime_constants_impl\",\n+ srcs = [\"runtime.go\"],\n+ o... | Go | Apache License 2.0 | google/gvisor | Move runtime constants to dynamic facts render
PiperOrigin-RevId: 505172527 |
259,868 | 27.01.2023 15:54:28 | 28,800 | 4e75dc46503d679c7c5c0f1327e4b5c6df8f6b93 | `runsc metric-server`: Add per-sandbox start timestamp metric.
This synthetic metric contains the Unix timestamp that each sandbox was
started at.
This is useful for counter metrics, such that rates of change over time can
be properly on a per-sandbox basis. | [
{
"change_type": "MODIFY",
"old_path": "pkg/prometheus/prometheus.go",
"new_path": "pkg/prometheus/prometheus.go",
"diff": "@@ -222,7 +222,7 @@ type Data struct {\n// NewIntData returns a new Data struct with the given metric and value.\nfunc NewIntData(metric *Metric, val int64) *Data {\n- return &... | Go | Apache License 2.0 | google/gvisor | `runsc metric-server`: Add per-sandbox start timestamp metric.
This synthetic metric contains the Unix timestamp that each sandbox was
started at.
This is useful for counter metrics, such that rates of change over time can
be properly on a per-sandbox basis.
PiperOrigin-RevId: 505228878 |
259,881 | 31.01.2023 01:00:42 | 28,800 | bcac7fc9adeaf5899edabafb7b947fe202cb1506 | Bump sync build tag
cl/504661697 removes this build tag once and for all, but it is blocked on
additional work needed to get it working with OSS bazel builds.
Until that is ready, bump the build tag to unblock testing Go tip (1.21). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sync/runtime_unsafe.go",
"new_path": "pkg/sync/runtime_unsafe.go",
"diff": "// Use of this source code is governed by a BSD-style\n// license that can be found in the LICENSE file.\n-//go:build go1.13 && !go1.21\n-// +build go1.13,!go1.21\n+//go:build go1.... | Go | Apache License 2.0 | google/gvisor | Bump sync build tag
cl/504661697 removes this build tag once and for all, but it is blocked on
additional work needed to get it working with OSS bazel builds.
Until that is ready, bump the build tag to unblock testing Go tip (1.21).
PiperOrigin-RevId: 505923005 |
259,909 | 31.01.2023 12:38:08 | 28,800 | 7058ea8d3067b109e1e7fe4e04f17b667252539f | Fix flakiness in FUSE syscall tests. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/fuse/BUILD",
"new_path": "test/runner/fuse/BUILD",
"diff": "@@ -8,6 +8,7 @@ go_binary(\nvisibility = [\"//test/runner:__subpackages__\"],\ndeps = [\n\"//pkg/log\",\n+ \"//runsc/specutils\",\n\"@com_github_hanwen_go_fuse_v2//fs:go_default_library\",... | Go | Apache License 2.0 | google/gvisor | Fix flakiness in FUSE syscall tests.
PiperOrigin-RevId: 506082577 |
259,891 | 31.01.2023 22:24:59 | 0 | dae3aa6eee9efcfa547f59e40232181dd24e1053 | netstack: fix UDP forwarding refcount bug
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/udp/forwarder.go",
"new_path": "pkg/tcpip/transport/udp/forwarder.go",
"diff": "@@ -47,7 +47,7 @@ func (f *Forwarder) HandlePacket(id stack.TransportEndpointID, pkt stack.PacketB\nf.handler(&ForwarderRequest{\nstack: f.stack,\nid: id,\n- pk... | Go | Apache License 2.0 | google/gvisor | netstack: fix UDP forwarding refcount bug
Fixes #8448. |
259,907 | 01.02.2023 14:31:31 | 28,800 | 6ca309ca15cbc2c3b1c6e891d8db9bf2a5a0616e | Consistently initialize IOUringParams in io_uring syscall tests.
Earlier we were using uninitialized param for io_uring which could
contain garbage flag values, which would trigger unexpected io_uring
behavior when test runs. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/io_uring.cc",
"new_path": "test/syscalls/linux/io_uring.cc",
"diff": "@@ -95,7 +95,7 @@ MATCHER_P(IOVecContainsString, str, \"\") {\nTEST(IOUringTest, ValidFD) {\nSKIP_IF(!IOUringAvailable());\n- IOUringParams params;\n+ IOUringParams param... | Go | Apache License 2.0 | google/gvisor | Consistently initialize IOUringParams in io_uring syscall tests.
Earlier we were using uninitialized param for io_uring which could
contain garbage flag values, which would trigger unexpected io_uring
behavior when test runs.
PiperOrigin-RevId: 506424543 |
259,909 | 01.02.2023 15:53:47 | 28,800 | 9f8cbc08921359a47b28dc0e3c68d31db504a99e | Add more internal logging to fuse syscall tests | [
{
"change_type": "MODIFY",
"old_path": "test/runner/fuse/fuse.go",
"new_path": "test/runner/fuse/fuse.go",
"diff": "package main\nimport (\n+ golog \"log\"\n\"os\"\n\"os/exec\"\n@@ -32,8 +33,8 @@ func main() {\nlog.Warningf(\"could not create loopback root: %v\", err)\nos.Exit(1)\n}\n- opts := &fuse... | Go | Apache License 2.0 | google/gvisor | Add more internal logging to fuse syscall tests
PiperOrigin-RevId: 506445741 |
259,868 | 01.02.2023 17:55:08 | 28,800 | b932fb1fb6661d5b916fbf43c0c99c47703a2fdf | Add documentation on how to use the gVisor Prometheus metric server. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/BUILD",
"new_path": "g3doc/user_guide/BUILD",
"diff": "@@ -64,6 +64,14 @@ doc(\nweight = \"55\",\n)\n+doc(\n+ name = \"observability\",\n+ src = \"observability.md\",\n+ category = \"User Guide\",\n+ permalink = \"/docs/user_guide/observabilit... | Go | Apache License 2.0 | google/gvisor | Add documentation on how to use the gVisor Prometheus metric server.
PiperOrigin-RevId: 506472933 |
259,909 | 02.02.2023 12:25:22 | 28,800 | fc69a401df98e5e6e90e337e2407c9662edb98bc | Enable more FUSE syscall tests.
Several syscall tests are working after refactoring inode operations.
This change also renames the use_fusefs test attribute to add_fusefs,
since that more accurately describes what the attribute does. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -72,7 +72,7 @@ def _syscall_test(\niouring = False,\ncontainer = None,\none_sandbox = True,\n- use_fusefs = False,\n+ fusefs = False,\n**kwargs):\n# Prepend \"runsc\" to non-native platform... | Go | Apache License 2.0 | google/gvisor | Enable more FUSE syscall tests.
Several syscall tests are working after refactoring inode operations.
This change also renames the use_fusefs test attribute to add_fusefs,
since that more accurately describes what the attribute does.
PiperOrigin-RevId: 506692314 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.