author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,891 | 13.07.2022 10:17:57 | 25,200 | d67ff8ac9b5156f81f9efa7f6bd8d16c163b1661 | use PACKET_MMAP for rx when supported
This was fixed in 5.6-rc7, so we enable PACKET_MMAP for all kernels >= 5.6.
Downloads in iperf go from ~90MB/s to ~102MB/s. | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -119,6 +119,7 @@ go_library(\n\"//runsc/specutils/seccomp\",\n\"@com_github_opencontainers_runtime_spec//specs-go:go_default_library\",\n\"@org_golang_google_protobuf//proto:go_default_library\",\n... | Go | Apache License 2.0 | google/gvisor | use PACKET_MMAP for rx when supported
This was fixed in 5.6-rc7, so we enable PACKET_MMAP for all kernels >= 5.6.
Downloads in iperf go from ~90MB/s to ~102MB/s.
PiperOrigin-RevId: 460746326 |
259,891 | 13.07.2022 15:12:53 | 25,200 | 63bb6e7e6900e0ca474787966b00ccfb7a775ae9 | typo: mismatched variable and comment | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"new_path": "pkg/tcpip/header/ipv6_extension_headers.go",
"diff": "@@ -248,7 +248,7 @@ const (\n// provides 1 byte padding, as outlined in RFC 8200 section 4.2.\nipv6Pad1ExtHdrOptionIdentifier IPv6ExtHdrOptionIdenti... | Go | Apache License 2.0 | google/gvisor | typo: mismatched variable and comment
PiperOrigin-RevId: 460814306 |
259,891 | 13.07.2022 21:26:41 | 25,200 | 2ceb6bb1f89d82105ab30d4b8ae280a7273cf91c | Use hostos.KernelVersion everywhere, and have it return semver strings | [
{
"change_type": "MODIFY",
"old_path": "pkg/coretag/coretag_test.go",
"new_path": "pkg/coretag/coretag_test.go",
"diff": "@@ -22,14 +22,14 @@ import (\n)\nfunc TestEnable(t *testing.T) {\n- major, minor, err := hostos.KernelVersion()\n+ version, err := hostos.KernelVersion()\nif err != nil {\nt.Fata... | Go | Apache License 2.0 | google/gvisor | Use hostos.KernelVersion everywhere, and have it return semver strings
PiperOrigin-RevId: 460872657 |
260,000 | 11.07.2022 13:44:58 | 25,200 | 48daa2225f4c1d1269b58d6dc4a54a4bb40b9241 | context: initialize and use bgContext once
bgContext is set during package initialization. However, the global
logger's SetTarget() method doesn't apply to instances of
context.Background() loaded after the first one.
See | [
{
"change_type": "MODIFY",
"old_path": "pkg/context/context.go",
"new_path": "pkg/context/context.go",
"diff": "@@ -24,6 +24,7 @@ package context\nimport (\n\"context\"\n+ \"sync\"\n\"time\"\n\"gvisor.dev/gvisor/pkg/log\"\n@@ -162,10 +163,8 @@ type logContext struct {\n}\n// bgContext is the context... | Go | Apache License 2.0 | google/gvisor | context: initialize and use bgContext once
bgContext is set during package initialization. However, the global
logger's SetTarget() method doesn't apply to instances of
context.Background() loaded after the first one.
See https://github.com/google/gvisor/issues/7795 |
259,868 | 18.07.2022 15:12:38 | 25,200 | cb935d751201154d46f9c4e27e902648d4ce0cdf | gVisor benchmarks: Add "Ruby CI/CD experience" benchmarks.
This adds two benchmarks:
A no-op Ruby unit test, based off the Stripe benchmark:
A more serious unit test suite from Fastlane, a large Ruby
project: | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -402,6 +402,9 @@ steps:\n- <<: *benchmarks\nlabel: \":cd: FIO benchmarks (randread/randwrite)\"\ncommand: make -i benchmark-platforms BENCHMARKS_SUITE=fio BENCHMARKS_TARGETS=test/be... | Go | Apache License 2.0 | google/gvisor | gVisor benchmarks: Add "Ruby CI/CD experience" benchmarks.
This adds two benchmarks:
- A no-op Ruby unit test, based off the Stripe benchmark:
https://stripe.com/blog/fast-secure-builds-choose-two
- A more serious unit test suite from Fastlane, a large Ruby
project: https://github.com/fastlane/fastlane
PiperOrigin-RevId: 461726240 |
259,896 | 18.07.2022 18:01:57 | 25,200 | 4bc44eac9bcbf4ee402add71d5c26763a9f612d5 | Multi Container: Add IsRunning() control message for the container.
Adds IsRunning() control message which returns true if the container is
running.
Adds a test to verify the result of IsRunning(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/lifecycle.go",
"new_path": "pkg/sentry/control/lifecycle.go",
"diff": "@@ -46,9 +46,35 @@ type Lifecycle struct {\n// namespaces.\nMountNamespacesMap map[string]*vfs.MountNamespace\n- // containerInitProcessMap is a map of container ID and t... | Go | Apache License 2.0 | google/gvisor | Multi Container: Add IsRunning() control message for the container.
- Adds IsRunning() control message which returns true if the container is
running.
- Adds a test to verify the result of IsRunning().
PiperOrigin-RevId: 461759652 |
259,878 | 19.07.2022 11:40:07 | 25,200 | 1ba318d72a302cf73f1712be375fb3831fa6f11e | Add security platform benefits to gvisor.dev index page.
Update header title and jumbotron with security platform info.
Add new benefits to index page reflecting use case value and adjust footer
logo to remove blur when scaled. | [
{
"change_type": "MODIFY",
"old_path": "website/_includes/footer-links.html",
"new_path": "website/_includes/footer-links.html",
"diff": "<div class=\"col-sm-3 col-md-3\"></div>\n<div class=\"hidden-xs hidden-sm col-md-3\">\n<a href=\"https://cloud.google.com/run\">\n- <img style=\"float: right;\" s... | Go | Apache License 2.0 | google/gvisor | Add security platform benefits to gvisor.dev index page.
Update header title and jumbotron with security platform info.
Add new benefits to index page reflecting use case value and adjust footer
logo to remove blur when scaled.
PiperOrigin-RevId: 461935696 |
259,891 | 19.07.2022 11:58:59 | 25,200 | dc7675bd6ce7e8ad1183bd336e9a4defcf8ac63b | use buffered channel with signal.Notify() | [
{
"change_type": "MODIFY",
"old_path": "tools/tracereplay/main/main.go",
"new_path": "tools/tracereplay/main/main.go",
"diff": "@@ -86,7 +86,7 @@ func (c *saveCmd) Execute(_ context.Context, f *flag.FlagSet, args ...interface{\nreturn subcommands.ExitFailure\n}\n- ch := make(chan os.Signal)\n+ ch :=... | Go | Apache License 2.0 | google/gvisor | use buffered channel with signal.Notify()
PiperOrigin-RevId: 461939747 |
259,853 | 19.07.2022 17:18:00 | 25,200 | d9c66eb76971ea54849c6a2166e1aad91d6f6050 | cpuid: cache host cpuid features
HostFeatureSet() returns a fixed set that is initialized at startup.
Here results fro the signal_benchmark on the kvm platform:
Before:
BM_FaultSignalFixup/real_time 8353 ns 8383 ns 94234
After:
BM_FaultSignalFixup/real_time 6127 ns 6087 ns 111708 | [
{
"change_type": "MODIFY",
"old_path": "pkg/cpuid/native_amd64.go",
"new_path": "pkg/cpuid/native_amd64.go",
"diff": "@@ -162,13 +162,13 @@ func (fs FeatureSet) query(fn cpuidFunction) (uint32, uint32, uint32, uint32) {\nreturn out.Eax, out.Ebx, out.Ecx, out.Edx\n}\n+var hostFeatureSet FeatureSet\n+... | Go | Apache License 2.0 | google/gvisor | cpuid: cache host cpuid features
HostFeatureSet() returns a fixed set that is initialized at startup.
Here results fro the signal_benchmark on the kvm platform:
Before:
BM_FaultSignalFixup/real_time 8353 ns 8383 ns 94234
After:
BM_FaultSignalFixup/real_time 6127 ns 6087 ns 111708
PiperOrigin-RevId: 462012597 |
259,907 | 20.07.2022 14:00:21 | 25,200 | 567444310c9a2947e2827954a4455bf5864a99fc | Handle IN_DONT_FOLLOW correctly in VFS2 inotify.
Added a syscall test for IN_DONT_FOLLOW as well. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/inotify.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/inotify.go",
"diff": "@@ -88,7 +88,7 @@ func InotifyAddWatch(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kern\n// \"IN_DONT_FOLLOW: Don't dereference pathname if... | Go | Apache License 2.0 | google/gvisor | Handle IN_DONT_FOLLOW correctly in VFS2 inotify.
Added a syscall test for IN_DONT_FOLLOW as well.
PiperOrigin-RevId: 462224328 |
259,907 | 20.07.2022 14:17:06 | 25,200 | be38a15c16136d69ab4ac4b42811e0821bf28522 | Build everything and run unit tests on ARM in Buildkite. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -61,11 +61,19 @@ steps:\n# Build everything.\n- <<: *common\n- label: \":world_map: Build everything\"\n+ label: \":world_map: Build everything (AMD64)\"\ncommand: \"make build OPTI... | Go | Apache License 2.0 | google/gvisor | Build everything and run unit tests on ARM in Buildkite.
PiperOrigin-RevId: 462228233 |
259,853 | 21.07.2022 13:18:11 | 25,200 | 796050f1dac9349a4acbf776c0f5dcb763dab274 | kvm: limit number of vCPU-s
We see a regression of the startup benchmark. The main reason is that the
maximum number of vCPUs in the kernel has been increased from 256 to 1024. In
most cases, we don't need so many vCPU-s. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -21,6 +21,7 @@ import (\n\"fmt\"\n\"math/big\"\n\"reflect\"\n+ \"runtime\"\n\"runtime/debug\"\n\"golang.org/x/sys/unix\"\n@@ -478,6 +479,16 @@ func (... | Go | Apache License 2.0 | google/gvisor | kvm: limit number of vCPU-s
We see a regression of the startup benchmark. The main reason is that the
maximum number of vCPUs in the kernel has been increased from 256 to 1024. In
most cases, we don't need so many vCPU-s.
PiperOrigin-RevId: 462455491 |
259,891 | 21.07.2022 18:51:04 | 25,200 | c8f981f9b21e591f1057a68a3a613ce2485bea12 | benchmarks: add --disable-linux-gro | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"new_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -42,6 +42,7 @@ duration=30 # 30s is enough time to consistent results (experimental\nhelper_dir=$(dirname $0)\nnetstack_opts=\ndisable_linux_gso=\n+disable_l... | Go | Apache License 2.0 | google/gvisor | benchmarks: add --disable-linux-gro
PiperOrigin-RevId: 462516480 |
259,891 | 22.07.2022 16:32:11 | 25,200 | 64299b5b226f20cffd8afaa3f3d0b8fc2a070476 | remove references to nonexistent directory | [
{
"change_type": "MODIFY",
"old_path": "test/runner/gtest/gtest.go",
"new_path": "test/runner/gtest/gtest.go",
"diff": "@@ -141,7 +141,7 @@ func ParseTestCases(testBin string, benchmarks bool, extraArgs ...string) ([]Tes\nreturn t, nil\n}\n-// ParseBenchmarks returns each benchmark in a third_party/... | Go | Apache License 2.0 | google/gvisor | remove references to nonexistent directory
PiperOrigin-RevId: 462728462 |
259,907 | 25.07.2022 11:32:00 | 25,200 | 49d88e92ed25cc1996ce504d6f2b7de4da08da0d | Do not debug log read/write buffers in lisafs.
These logs are not helpful and just make logs very noisy. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/message.go",
"new_path": "pkg/lisafs/message.go",
"diff": "@@ -857,7 +857,7 @@ type PReadResp struct {\n// String implements fmt.Stringer.String.\nfunc (r *PReadResp) String() string {\n- return fmt.Sprintf(\"PReadResp{NumBytes: %d, Buf: %v}\", r.Nu... | Go | Apache License 2.0 | google/gvisor | Do not debug log read/write buffers in lisafs.
These logs are not helpful and just make logs very noisy.
PiperOrigin-RevId: 463136631 |
259,909 | 25.07.2022 13:19:30 | 25,200 | d542d45a28e3d759b20e33c36f0f577ed01cee74 | Adjust batch size in fifo qdisc to match the fdbased batch size.
These two are frequently used together, so this change slightly optimizes
the number of write syscalls. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "@@ -66,6 +66,11 @@ type linkDispatcher interface {\ntype PacketDispatchMode int\nconst (\n+ // BatchSize is the number of packets to write in each syscall. It is 47... | Go | Apache License 2.0 | google/gvisor | Adjust batch size in fifo qdisc to match the fdbased batch size.
These two are frequently used together, so this change slightly optimizes
the number of write syscalls.
PiperOrigin-RevId: 463161851 |
259,891 | 26.07.2022 11:50:34 | 25,200 | d894c1d09b9cbcf9723be5bb76710cd071db367a | add clang to default image
clang will be used to compile BPF. | [
{
"change_type": "MODIFY",
"old_path": "images/default/Dockerfile",
"new_path": "images/default/Dockerfile",
"diff": "@@ -7,7 +7,11 @@ RUN apt-get update && apt-get install -y curl gnupg2 git \\\nopenjdk-11-jdk-headless zip unzip \\\napt-transport-https ca-certificates gnupg-agent \\\nsoftware-prope... | Go | Apache License 2.0 | google/gvisor | add clang to default image
clang will be used to compile BPF.
PiperOrigin-RevId: 463392266 |
259,975 | 26.07.2022 11:56:30 | 25,200 | b18db49e9dbd96edc04beb5338d8af99341d3d4e | [benchmarks] Remove broken runsc benchmark.
This has been replaced by the gRPC build benchmark
which is below the removed BuildRunsc benchmark. | [
{
"change_type": "DELETE",
"old_path": "images/benchmarks/runsc/Dockerfile.x86_64",
"new_path": null,
"diff": "-FROM ubuntu:18.04\n-\n-RUN set -x \\\n- && apt-get update \\\n- && apt-get install -y \\\n- wget \\\n- git \\\n- pkg-config \\\n- zip \\\n- g++ \\\n- zlib1g-dev \\\n- unzip \\\n- python-mi... | Go | Apache License 2.0 | google/gvisor | [benchmarks] Remove broken runsc benchmark.
This has been replaced by the gRPC build benchmark
which is below the removed BuildRunsc benchmark.
PiperOrigin-RevId: 463393704 |
259,909 | 26.07.2022 14:57:53 | 25,200 | c689b5513cb7f831dfd126c8920d2b87fa331d99 | Change buffer pooling to be false by default for runsc. | [
{
"change_type": "MODIFY",
"old_path": "runsc/config/flags.go",
"new_path": "runsc/config/flags.go",
"diff": "@@ -96,7 +96,7 @@ func RegisterFlags(flagSet *flag.FlagSet) {\nflagSet.Bool(\"rx-checksum-offload\", true, \"enable RX checksum offload.\")\nflagSet.Var(queueingDisciplinePtr(QDiscFIFO), \"q... | Go | Apache License 2.0 | google/gvisor | Change buffer pooling to be false by default for runsc.
PiperOrigin-RevId: 463434661 |
259,853 | 26.07.2022 15:42:32 | 25,200 | 8e4cb261486ad84bc5657b1cee0288018f693d01 | Add support of rootless containers
* support podmand rootless containers
* support docker rootless containers
Fixes | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -280,6 +280,12 @@ steps:\nagents:\ncgroup: \"v2\"\nos: \"ubuntu\"\n+ - <<: *common\n+ label: \":podman: Podman\"\n+ command: sudo ./test/podman/run.sh\n+ agents:\n+ cgroup: \"v2\"\n... | Go | Apache License 2.0 | google/gvisor | Add support of rootless containers
* support podmand rootless containers
* support docker rootless containers
Fixes #311
PiperOrigin-RevId: 463444736 |
259,909 | 27.07.2022 16:14:07 | 25,200 | 502cc29f872edf3524486d40ebca149b30c85d30 | Add a method that returns an owned copy of the data in a View. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bufferv2/view.go",
"new_path": "pkg/bufferv2/view.go",
"diff": "@@ -161,6 +161,16 @@ func (v *View) AsSlice() []byte {\nreturn v.chunk.data[v.read:v.write]\n}\n+// ToSlice returns an owned copy of the data in this view.\n+func (v *View) ToSlice() []byte {\... | Go | Apache License 2.0 | google/gvisor | Add a method that returns an owned copy of the data in a View.
PiperOrigin-RevId: 463703416 |
259,975 | 29.07.2022 13:33:35 | 25,200 | 8a7a35e9d6257acec554304d4fe3d4abc86dbde4 | [gke-perf] Add "latest" tag to gcr.io images. | [
{
"change_type": "MODIFY",
"old_path": "tools/images.mk",
"new_path": "tools/images.mk",
"diff": "@@ -135,6 +135,7 @@ rebuild = \\\ndocker build $(DOCKER_PLATFORM_ARGS) \\\n-f \"$$T/$(call dockerfile,$(1))\" \\\n-t \"$(call remote_image,$(1)):$(call tag,$(1))\" \\\n+ -t \"$(call remote_image,$(1))\"... | Go | Apache License 2.0 | google/gvisor | [gke-perf] Add "latest" tag to gcr.io images.
PiperOrigin-RevId: 464147312 |
259,907 | 31.07.2022 17:59:28 | 25,200 | d91c459a7860b85e82dacb18cde6ba50bfe6f209 | Always initialize a/m/c times and nlink in VFS2 gofer client.
When the server does not provide these values, they should be
initialized to something sensible. This is consistent with VFS1. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/BUILD",
"new_path": "pkg/sentry/fsimpl/gofer/BUILD",
"diff": "@@ -97,6 +97,7 @@ go_test(\ndeps = [\n\"//pkg/p9\",\n\"//pkg/sentry/contexttest\",\n+ \"//pkg/sentry/kernel/time\",\n\"//pkg/sentry/pgalloc\",\n],\n)\n"
},
{
"change_... | Go | Apache License 2.0 | google/gvisor | Always initialize a/m/c times and nlink in VFS2 gofer client.
When the server does not provide these values, they should be
initialized to something sensible. This is consistent with VFS1.
PiperOrigin-RevId: 464433106 |
260,009 | 01.08.2022 09:52:36 | 25,200 | 1d3b90268d374c25e9f7f5b6b63c1024060e42f8 | Replace "Register" nomenclature for timer metrics init functions.
In the context set by Uint64Metrics, the "Register..." functions are used for
custom metric types defined outside of the metric pkg, where as the "New..."
and "MustCreateNew..." are used for those types belonging to the metric pkg. | [
{
"change_type": "MODIFY",
"old_path": "pkg/metric/metric.go",
"new_path": "pkg/metric/metric.go",
"diff": "@@ -395,8 +395,8 @@ func NewUint64Metric(name string, sync bool, units pb.MetricMetadata_Units, desc\nreturn &m, RegisterCustomUint64Metric(name, true /* cumulative */, sync, units, descriptio... | Go | Apache License 2.0 | google/gvisor | Replace "Register" nomenclature for timer metrics init functions.
In the context set by Uint64Metrics, the "Register..." functions are used for
custom metric types defined outside of the metric pkg, where as the "New..."
and "MustCreateNew..." are used for those types belonging to the metric pkg.
PiperOrigin-RevId: 464558365 |
259,891 | 01.08.2022 10:09:28 | 25,200 | 03b682624382fb7a8913101686f5751b3180becb | xdp: tooling and dependencies
Setup gVisor so that an AF_XDP dispatcher can be implemented.
Specifically:
xdp_loader: a binary for testing XDP programs
Two basic XDP programs
Update the cilium/ebpf dep
Genrule for building BPF programs
Install clang on buildkite to support building BPF programs | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -15,11 +15,11 @@ http_file(\n# Bazel/starlark utilities.\nhttp_archive(\nname = \"bazel_skylib\",\n+ sha256 = \"f7be3474d42aae265405a592bb7da8e171919d74c16f082a5457840f06054728\",\nurls = [\n\"https://mirror.baz... | Go | Apache License 2.0 | google/gvisor | xdp: tooling and dependencies
Setup gVisor so that an AF_XDP dispatcher can be implemented.
Specifically:
- xdp_loader: a binary for testing XDP programs
- Two basic XDP programs
- Update the cilium/ebpf dep
- Genrule for building BPF programs
- Install clang on buildkite to support building BPF programs
PiperOrigin-RevId: 464562411 |
259,975 | 01.08.2022 12:01:41 | 25,200 | 991841786a92a40a0514a1236a6c4362a1850271 | [sst] Cleanup TODOs for SecurityMessages | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_exec.go",
"new_path": "pkg/sentry/kernel/task_exec.go",
"diff": "@@ -329,8 +329,6 @@ func getExecveSeccheckInfo(t *Task, argv, env []string, executable fsbridge.File\n}\n}\n}\n- // TODO(b/202293325): Decide if we actually want to offer b... | Go | Apache License 2.0 | google/gvisor | [sst] Cleanup TODOs for SecurityMessages
PiperOrigin-RevId: 464589591 |
259,992 | 02.08.2022 16:04:05 | 25,200 | 49a3911d53d37d411d1261a589d302510c4ce016 | Reorder Quick Start to put easier stuff on the top | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/quick_start/BUILD",
"new_path": "g3doc/user_guide/quick_start/BUILD",
"diff": "@@ -15,19 +15,19 @@ doc(\n)\ndoc(\n- name = \"oci\",\n- src = \"oci.md\",\n+ name = \"kubernetes\",\n+ src = \"kubernetes.md\",\ncategory = \"User Guide\",\n- perma... | Go | Apache License 2.0 | google/gvisor | Reorder Quick Start to put easier stuff on the top
PiperOrigin-RevId: 464909911 |
259,992 | 02.08.2022 16:35:38 | 25,200 | 87f4e4a18810b6bf478e171801132537de7aeda5 | Update Wordpress Kubernetes instructions
They were still referencing the gcloud beta commands. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/add-node-pool.png",
"new_path": "g3doc/user_guide/tutorials/add-node-pool.png",
"diff": "Binary files a/g3doc/user_guide/tutorials/add-node-pool.png and b/g3doc/user_guide/tutorials/add-node-pool.png differ\n"
},
{
"change_ty... | Go | Apache License 2.0 | google/gvisor | Update Wordpress Kubernetes instructions
They were still referencing the gcloud beta commands.
PiperOrigin-RevId: 464916524 |
259,881 | 03.08.2022 08:28:37 | 25,200 | 974792ae18cf19f555a35d3bf7b23a8ed9e9385c | Bump negative build tag constraints to go1.21 | [
{
"change_type": "MODIFY",
"old_path": "pkg/gohacks/gohacks_unsafe.go",
"new_path": "pkg/gohacks/gohacks_unsafe.go",
"diff": "// See the License for the specific language governing permissions and\n// limitations under the License.\n-//go:build go1.13 && !go1.20\n-// +build go1.13,!go1.20\n+//go:bui... | Go | Apache License 2.0 | google/gvisor | Bump negative build tag constraints to go1.21
PiperOrigin-RevId: 465062413 |
259,909 | 03.08.2022 12:22:02 | 25,200 | 1c220bf2a4a0a6c8cdaf3c092b1a3d22391b6e42 | Fix refsvfs2 bug that counted uninitialized leak checking as enabled. | [
{
"change_type": "MODIFY",
"old_path": "pkg/refsvfs2/refs_map.go",
"new_path": "pkg/refsvfs2/refs_map.go",
"diff": "@@ -50,7 +50,8 @@ func init() {\n// LeakCheckEnabled returns whether leak checking is enabled. The following\n// functions should only be called if it returns true.\nfunc LeakCheckEnab... | Go | Apache License 2.0 | google/gvisor | Fix refsvfs2 bug that counted uninitialized leak checking as enabled.
PiperOrigin-RevId: 465118656 |
259,992 | 03.08.2022 14:30:26 | 25,200 | dc4cd669fcf90e758927d5ebbc79d3fb1547c597 | Add sinks to `runsc trace metadata` output
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/config.go",
"new_path": "pkg/sentry/seccheck/config.go",
"diff": "@@ -225,7 +225,7 @@ func setFields(names []string, fields []FieldDesc) (FieldMask, error) {\n}\nfunc findSinkDesc(name string) (SinkDesc, error) {\n- if desc, ok := sinks[nam... | Go | Apache License 2.0 | google/gvisor | Add sinks to `runsc trace metadata` output
Updates #4805
PiperOrigin-RevId: 465150097 |
259,868 | 03.08.2022 14:52:22 | 25,200 | adc4b6b316869fcddcd4c771c5297cb749b134fb | BuildKite: Refactor Pipeline YAML.
This adds templates that can be used to distinguish tests that rely on
the checked-out source tree vs using STAGED_BINARIES instead. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -7,6 +7,11 @@ _templates:\nlimit: 10\n- exit_status: \"*\"\nlimit: 2\n+ source_test: &source_test\n+ if: build.env(\"STAGED_BINARIES\") == null\n+ platform_specific_agents: &platfor... | Go | Apache License 2.0 | google/gvisor | BuildKite: Refactor Pipeline YAML.
This adds templates that can be used to distinguish tests that rely on
the checked-out source tree vs using STAGED_BINARIES instead.
PiperOrigin-RevId: 465155335 |
259,992 | 03.08.2022 15:26:45 | 25,200 | e8c45a17cf34b130af3bc50da5cc0d9ab8b9b021 | Enable test/trace:trace_test
It was mistakenly marked as manual.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/trace/BUILD",
"new_path": "test/trace/BUILD",
"diff": "@@ -13,7 +13,6 @@ go_test(\nlibrary = \":trace\",\ntags = [\n\"local\",\n- \"manual\",\n],\ndeps = [\n\"//pkg/sentry/seccheck\",\n"
},
{
"change_type": "MODIFY",
"old_path": "test/trace/tr... | Go | Apache License 2.0 | google/gvisor | Enable test/trace:trace_test
It was mistakenly marked as manual.
Updates #4805
PiperOrigin-RevId: 465163546 |
259,909 | 04.08.2022 14:26:09 | 25,200 | 2f34113ec1cdceafb6b6480633539f68b376446d | Add a flag to tcp_benchmarks that runs the workload over ipv6. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/BUILD",
"new_path": "test/benchmarks/tcp/BUILD",
"diff": "@@ -13,7 +13,9 @@ go_binary(\n\"//pkg/tcpip/link/qdisc/fifo\",\n\"//pkg/tcpip/network/arp\",\n\"//pkg/tcpip/network/ipv4\",\n+ \"//pkg/tcpip/network/ipv6\",\n\"//pkg/tcpip/stack\",\n... | Go | Apache License 2.0 | google/gvisor | Add a flag to tcp_benchmarks that runs the workload over ipv6.
PiperOrigin-RevId: 465404721 |
259,868 | 05.08.2022 12:38:08 | 25,200 | 86059124df31971e07da40395a2c4225f004dc40 | `gvisor.dev`: Update documentation around platforms.
Explain the consequences of using KVM in a nested virtualization
environment.
Mention GKE Sandbox proprietary platform.
Fix command to check if the user is part of the `kvm` group.
Small fixes here and there. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/architecture_guide/platforms.md",
"new_path": "g3doc/architecture_guide/platforms.md",
"diff": "gVisor requires a platform to implement interception of syscalls, basic context\nswitching, and memory mapping functionality. Internally, gVisor uses an\n-abs... | Go | Apache License 2.0 | google/gvisor | `gvisor.dev`: Update documentation around platforms.
- Explain the consequences of using KVM in a nested virtualization
environment.
- Mention GKE Sandbox proprietary platform.
- Fix command to check if the user is part of the `kvm` group.
- Small fixes here and there.
PiperOrigin-RevId: 465625190 |
259,868 | 05.08.2022 14:55:22 | 25,200 | a91c5c4b4ceb3fa4216c86d560665f21a6ec6eaf | `gvisor.dev`: Update WordPress example to recommend not sandboxing the database. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/docker-compose.md",
"new_path": "g3doc/user_guide/tutorials/docker-compose.md",
"diff": "@@ -16,7 +16,14 @@ We will specify two services, a `wordpress` service for the Wordpress Apache\nserver, and a `db` service for MySQL. We will c... | Go | Apache License 2.0 | google/gvisor | `gvisor.dev`: Update WordPress example to recommend not sandboxing the database.
PiperOrigin-RevId: 465654131 |
259,868 | 05.08.2022 19:06:59 | 25,200 | 919910ce670a680ec9b9438c8087884b16385b03 | Fix d3-based performance graphs in Firefox.
Reported by Thomas Gleixner in | [
{
"change_type": "MODIFY",
"old_path": "website/_includes/footer.html",
"new_path": "website/_includes/footer.html",
"diff": "{% include footer-links.html %}\n</footer>\n-<script src=\"https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.min.js\" integrity=\"sha256-FgpCb/KJQlLNfOu91ta32o/NMZxl... | Go | Apache License 2.0 | google/gvisor | Fix d3-based performance graphs in Firefox.
Reported by Thomas Gleixner in
https://lore.kernel.org/lkml/87a68vtvhf.ffs@tglx/
PiperOrigin-RevId: 465692826 |
259,907 | 06.08.2022 19:58:54 | 25,200 | 0d7a1d07110f54a7f9740150d873f9bd28c2d43d | Lower layer files that can not be copied up are not writable.
Make access(W_OK) return EACCES in overlayfs if file exists only
on lower layer and can not be copied up. Earlier, access(W_OK)
was succeeding but operations that cause copy-up (like
open(WR_ONLY)) were failing. This is likely to confuse
applications. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"new_path": "pkg/sentry/fsimpl/overlay/copy_up.go",
"diff": "@@ -31,6 +31,18 @@ func (d *dentry) isCopiedUp() bool {\nreturn d.copiedUp.Load() != 0\n}\n+func (d *dentry) canBeCopiedUp() bool {\n+ ftype := d.mode.Load() & ... | Go | Apache License 2.0 | google/gvisor | Lower layer files that can not be copied up are not writable.
Make access(W_OK) return EACCES in overlayfs if file exists only
on lower layer and can not be copied up. Earlier, access(W_OK)
was succeeding but operations that cause copy-up (like
open(WR_ONLY)) were failing. This is likely to confuse
applications.
PiperOrigin-RevId: 465818314 |
259,982 | 08.08.2022 00:52:53 | 25,200 | e003828a6bcce828f90f500e42af3923926b0b50 | Add SignalContainer() to GvisorContainer for multi-containers.
SignalContainer() sends control message to signal
the container in multi-container mode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/lifecycle.go",
"new_path": "pkg/sentry/control/lifecycle.go",
"diff": "@@ -290,6 +290,8 @@ func (l *Lifecycle) getInitContainerProcess(containerID string) (*kernel.ThreadG\ntype ContainerArgs struct {\n// ContainerID.\nContainerID string `js... | Go | Apache License 2.0 | google/gvisor | Add SignalContainer() to GvisorContainer for multi-containers.
SignalContainer() sends control message to signal
the container in multi-container mode.
PiperOrigin-RevId: 465975679 |
259,975 | 08.08.2022 12:54:28 | 25,200 | a963196f43de72f411291837d453ebf1b7801fb8 | Support process_vm_read for same user only. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_usermem.go",
"new_path": "pkg/sentry/kernel/task_usermem.go",
"diff": "@@ -21,10 +21,13 @@ import (\n\"gvisor.dev/gvisor/pkg/context\"\n\"gvisor.dev/gvisor/pkg/errors/linuxerr\"\n\"gvisor.dev/gvisor/pkg/hostarch\"\n+ \"gvisor.dev/gvisor/... | Go | Apache License 2.0 | google/gvisor | Support process_vm_read for same user only.
PiperOrigin-RevId: 466123035 |
259,853 | 10.08.2022 11:42:17 | 25,200 | 778db1d8bc5b8e967bd18133462fb78a48756305 | Deflake 32bit_test_linux | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/32bit.cc",
"new_path": "test/syscalls/linux/32bit.cc",
"diff": "@@ -131,6 +131,20 @@ TEST(Syscall32Bit, Sysenter) {\n}\n}\n+class KilledByOneOfSignals {\n+ public:\n+ KilledByOneOfSignals(int signum1, int signum2)\n+ : signum1_(signum1), si... | Go | Apache License 2.0 | google/gvisor | Deflake 32bit_test_linux
PiperOrigin-RevId: 466747499 |
260,009 | 10.08.2022 13:23:19 | 25,200 | a4fb3b200fdc05ac14aedcfc3d5b1b0c89a8a372 | Fix panic on nil map in Fragmentation.
A rare bug occurs when assigning a value to the reassemblers map causes a panic
due to the map being nil. The only way this is possible is if
Fragmentation.Release() is called before Process() is able to finish. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/fragmentation/fragmentation.go",
"new_path": "pkg/tcpip/network/internal/fragmentation/fragmentation.go",
"diff": "@@ -175,6 +175,10 @@ func (f *Fragmentation) Process(\n}\nf.mu.Lock()\n+ if f.reassemblers == nil {\n+ return nil, 0, ... | Go | Apache License 2.0 | google/gvisor | Fix panic on nil map in Fragmentation.
A rare bug occurs when assigning a value to the reassemblers map causes a panic
due to the map being nil. The only way this is possible is if
Fragmentation.Release() is called before Process() is able to finish.
PiperOrigin-RevId: 466771159 |
259,891 | 10.08.2022 14:01:04 | 25,200 | fefc03e1514f8de5f638d26bb7d3bce0d9a5fcb1 | conntrack: remove unnecessary mutex
tuple.mu protects only tupleID, which is only ever set at initialization. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/conntrack.go",
"new_path": "pkg/tcpip/stack/conntrack.go",
"diff": "@@ -60,17 +60,10 @@ type tuple struct {\n// packet seen on the connection.\nreply bool\n- mu sync.RWMutex `state:\"nosave\"`\n- // +checklocks:mu\n+ // tupleID is set at initia... | Go | Apache License 2.0 | google/gvisor | conntrack: remove unnecessary mutex
tuple.mu protects only tupleID, which is only ever set at initialization.
PiperOrigin-RevId: 466779629 |
260,009 | 10.08.2022 14:28:57 | 25,200 | 1faac756ee6daff574c3e371e503c14385ee4dd8 | Add shim support for calling runsc create with --panic-log.
Making the panic log directory be inside of the normal user-log directory makes
it possible to simply reuse the same spec annotation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/shim/proc/init.go",
"new_path": "pkg/shim/proc/init.go",
"diff": "@@ -73,6 +73,7 @@ type Init struct {\nIoGID int\nSandbox bool\nUserLog string\n+ PanicLog string\nMonitor ProcessMonitor\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "pkg/shim... | Go | Apache License 2.0 | google/gvisor | Add shim support for calling runsc create with --panic-log.
Making the panic log directory be inside of the normal user-log directory makes
it possible to simply reuse the same spec annotation.
PiperOrigin-RevId: 466785655 |
259,992 | 11.08.2022 10:09:55 | 25,200 | 5852220509c8c27324a7006b45c9835c7ba814fa | Add tutorial for using Falco with gVisor | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/tutorials/BUILD",
"new_path": "g3doc/user_guide/tutorials/BUILD",
"diff": "@@ -36,6 +36,15 @@ doc(\nweight = \"30\",\n)\n+doc(\n+ name = \"falco\",\n+ src = \"falco.md\",\n+ category = \"User Guide\",\n+ permalink = \"/docs/tutorials/falco/\",... | Go | Apache License 2.0 | google/gvisor | Add tutorial for using Falco with gVisor
PiperOrigin-RevId: 466984819 |
259,975 | 11.08.2022 17:07:51 | 25,200 | 004b4e727b308773087a18f4e63dd96560e2863d | Disable process_vm_read/writev and add a test.
ProcessVM readv/writev needs some work due to lock ordering issues
with locking MM between tasks. So disable the call until it
can be fixed.
Also add a test from one of the identified bugs from syzcaller. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/vfs2.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/vfs2.go",
"diff": "@@ -156,8 +156,7 @@ func Override() {\ns.Table[299] = syscalls.Supported(\"recvmmsg\", RecvMMsg)\ns.Table[306] = syscalls.Supported(\"syncfs\", Syncfs)\ns.T... | Go | Apache License 2.0 | google/gvisor | Disable process_vm_read/writev and add a test.
ProcessVM readv/writev needs some work due to lock ordering issues
with locking MM between tasks. So disable the call until it
can be fixed.
Also add a test from one of the identified bugs from syzcaller.
PiperOrigin-RevId: 467085160 |
259,909 | 15.08.2022 16:19:27 | 25,200 | 2dbd37fd74397994db21efb34eede3f3c9d31acd | Fix IP_ADD_MEMBERSHIP address checking to match linux.
When handling a call to setsockopt for IP_ADD_MEMBERSHIP with an ip_mreqn
struct with a non-zero interface IP address and interface index, Linux
checks the interface index first and, if it matches a device, ignores the
address.
Linux:
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/stack.go",
"new_path": "pkg/tcpip/stack/stack.go",
"diff": "@@ -1437,17 +1437,21 @@ func (s *Stack) CheckLocalAddress(nicID tcpip.NICID, protocol tcpip.NetworkProto\ns.mu.RLock()\ndefer s.mu.RUnlock()\n- // If a NIC is specified, we try to find... | Go | Apache License 2.0 | google/gvisor | Fix IP_ADD_MEMBERSHIP address checking to match linux.
When handling a call to setsockopt for IP_ADD_MEMBERSHIP with an ip_mreqn
struct with a non-zero interface IP address and interface index, Linux
checks the interface index first and, if it matches a device, ignores the
address.
Linux: https://github.com/torvalds/linux/blob/15205c2829ca2cbb5ece5ceaafe1171a8470e62b/net/ipv4/igmp.c#L1829-L1837
Fixes #7880
PiperOrigin-RevId: 467787302 |
259,992 | 15.08.2022 18:11:20 | 25,200 | 2bb73c7bd7dcf0b36e774d8e82e464d04bc81f4b | Add output to `runsc trace` commands
Otherwise it's hard to tell if the command succeeded or not.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/trace/create.go",
"new_path": "runsc/cmd/trace/create.go",
"diff": "@@ -90,6 +90,7 @@ func (l *create) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}\nutil.Fatalf(\"creating session: %v\", err)\n}\n+ fmt.Printf(\"Trace session %q cre... | Go | Apache License 2.0 | google/gvisor | Add output to `runsc trace` commands
Otherwise it's hard to tell if the command succeeded or not.
Updates #4805
PiperOrigin-RevId: 467807571 |
259,909 | 16.08.2022 11:16:35 | 25,200 | b195ca54f311b5635cb8f7ea32600f10eb57f103 | Netstack: Check that the multicast address matches the endpoint protocol.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tcpip.go",
"new_path": "pkg/tcpip/tcpip.go",
"diff": "@@ -45,8 +45,13 @@ import (\n\"gvisor.dev/gvisor/pkg/waiter\"\n)\n-// Using header.IPv4AddressSize would cause an import cycle.\n-const ipv4AddressSize = 4\n+// Using the header package here would... | Go | Apache License 2.0 | google/gvisor | Netstack: Check that the multicast address matches the endpoint protocol.
Reported-by: syzbot+a72cb94d1b5a6f5f0e11@syzkaller.appspotmail.com
PiperOrigin-RevId: 467975743 |
259,992 | 16.08.2022 12:26:06 | 25,200 | 919a20f17913de17355ddccd5eb8d117b7ddbb8b | Add documentation and tutorials for Runtime Monitoring
Updates | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "examples/seccheck/README.md",
"diff": "+This directory provides an example of a monitoring process that receives\n+connections from gVisor sandboxes and prints the traces to `stdout`. The example\n+contains two main files:\n+\n+* server.cc: this... | Go | Apache License 2.0 | google/gvisor | Add documentation and tutorials for Runtime Monitoring
Updates #4805
PiperOrigin-RevId: 467993824 |
259,868 | 16.08.2022 16:06:43 | 25,200 | 4b7922fa0bbeb90426ec4f2886d4edbbabd6751d | `iperf` benchmark: Use container networking links rather than default bridge.
This fixes `iperf` getting stuck on some versions of Docker, and mirrors the
way other multi-container tests do networking. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/network/iperf_test.go",
"new_path": "test/benchmarks/network/iperf_test.go",
"diff": "@@ -15,8 +15,10 @@ package network\nimport (\n\"context\"\n+ \"fmt\"\n\"os\"\n\"testing\"\n+ \"time\"\n\"gvisor.dev/gvisor/pkg/test/dockerutil\"\n\"gvisor.dev... | Go | Apache License 2.0 | google/gvisor | `iperf` benchmark: Use container networking links rather than default bridge.
This fixes `iperf` getting stuck on some versions of Docker, and mirrors the
way other multi-container tests do networking.
PiperOrigin-RevId: 468049041 |
259,868 | 16.08.2022 17:03:48 | 25,200 | 5d08a59813201143d3efe103c2265c56ff6270c8 | Makefile: Add option to not benchmark `runc`.
This is useful when wanting to run benchmarks in a way where the output can
be captured to a file, such that this file only contains one platform's
specific performance data. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -366,6 +366,7 @@ containerd-tests: containerd-test-1.6.0\n## BENCHMARKS_OFFICIAL - marks the data as official.\n## BENCHMARKS_PLATFORMS - if set, only run the benchmarks for this\n## space-separated list of platfo... | Go | Apache License 2.0 | google/gvisor | Makefile: Add option to not benchmark `runc`.
This is useful when wanting to run benchmarks in a way where the output can
be captured to a file, such that this file only contains one platform's
specific performance data.
PiperOrigin-RevId: 468061772 |
259,919 | 17.08.2022 17:28:08 | 25,200 | 5f471ac269c224299e3fbe873a2e214136bc74fa | Fix minor typo in production.md | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/production.md",
"new_path": "g3doc/user_guide/production.md",
"diff": "@@ -32,7 +32,7 @@ used to sandbox **every** application.\n## Attack surface reduction {#attack-surface}\n-Because sandboxing comes woth some performance overhead, you shoul... | Go | Apache License 2.0 | google/gvisor | Fix minor typo in production.md |
259,854 | 13.08.2022 14:56:37 | 25,200 | ec66002f34b7783e3487fe852d607df17a43f430 | Fix double gonet.(*TCPListener).Shutdown panic.
* Fix a panic that would occur when calling gonet.(*TCPListener).Shutdown twice.
* Add test for gonet.(*TCPListener).Shutdown and gonet.(*TCPListener).Close
unblocking gonet.(*TCPListener).Accept. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/adapters/gonet/gonet.go",
"new_path": "pkg/tcpip/adapters/gonet/gonet.go",
"diff": "@@ -50,6 +50,7 @@ type TCPListener struct {\nstack *stack.Stack\nep tcpip.Endpoint\nwq *waiter.Queue\n+ cancelOnce sync.Once\ncancel chan struct{}\n}\n@@ -112,7 +113,... | Go | Apache License 2.0 | google/gvisor | Fix double gonet.(*TCPListener).Shutdown panic.
* Fix a panic that would occur when calling gonet.(*TCPListener).Shutdown twice.
* Add test for gonet.(*TCPListener).Shutdown and gonet.(*TCPListener).Close
unblocking gonet.(*TCPListener).Accept. |
259,985 | 23.08.2022 23:59:21 | 25,200 | 00e0718041e44ea4cb51f1710f1170ab4980a972 | Allow creation of new FS objects from outside the vfs package. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -174,6 +174,22 @@ func (vfs *VirtualFilesystem) NewMountNamespace(ctx context.Context, creds *auth\nreturn mntns, nil\n}\n+// NewFilesystem creates a new filesystem object not yet ass... | Go | Apache License 2.0 | google/gvisor | Allow creation of new FS objects from outside the vfs package.
PiperOrigin-RevId: 469649194 |
259,907 | 24.08.2022 09:46:34 | 25,200 | 51c48824f0a86b59c5c26a1cfda45cfdd618aee2 | Fix TODO comment for issue 6319.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -88,7 +88,7 @@ var VFS2Enabled = false\n// LISAFSEnabled is set to true when lisafs protocol is enabled. Added as a\n// global to allow easy access everywhere.\n//\n-// TODO(g... | Go | Apache License 2.0 | google/gvisor | Fix TODO comment for issue 6319.
Fixes #6319
PiperOrigin-RevId: 469752297 |
259,907 | 24.08.2022 10:53:39 | 25,200 | 2ee98e784b080498983bc907075f1dccf768d2cc | Change test targets to use _p9 if p9 is enabled.
lisafs is default. So we should not have all targets be generated
with _lisafs. Also if nothing is specified, then lisafs should run.
Which is not the case right now. | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -84,8 +84,8 @@ def _syscall_test(\nname += \"_overlay\"\nif fuse:\nname += \"_fuse\"\n- if lisafs:\n- name += \"_lisafs\"\n+ if not lisafs:\n+ name += \"_p9\"\nif network != \"none\":\nname... | Go | Apache License 2.0 | google/gvisor | Change test targets to use _p9 if p9 is enabled.
lisafs is default. So we should not have all targets be generated
with _lisafs. Also if nothing is specified, then lisafs should run.
Which is not the case right now.
PiperOrigin-RevId: 469770835 |
259,992 | 25.08.2022 11:37:38 | 25,200 | df5374fcfa9c46ea52478b7cc3112f125d87d500 | Add `runsc usage` to list of commands
Also make `runsc debug` write to stdout and log file to make it
easier to see the output when running the command manually. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cli/main.go",
"new_path": "runsc/cli/main.go",
"diff": "@@ -94,6 +94,7 @@ func Main(version string) {\nsubcommands.Register(new(cmd.Debug), debugGroup)\nsubcommands.Register(new(cmd.Statefile), debugGroup)\nsubcommands.Register(new(cmd.Symbolize), debugG... | Go | Apache License 2.0 | google/gvisor | Add `runsc usage` to list of commands
Also make `runsc debug` write to stdout and log file to make it
easier to see the output when running the command manually.
PiperOrigin-RevId: 470042053 |
259,992 | 25.08.2022 14:13:03 | 25,200 | 385afe9f2cc43c740221543b739ec6d32c925039 | Remove unused runsc flags | [
{
"change_type": "MODIFY",
"old_path": "runsc/boot/BUILD",
"new_path": "runsc/boot/BUILD",
"diff": "@@ -48,7 +48,6 @@ go_library(\n\"//pkg/sentry/arch\",\n\"//pkg/sentry/arch:registers_go_proto\",\n\"//pkg/sentry/control\",\n- \"//pkg/sentry/control:control_go_proto\",\n\"//pkg/sentry/devices/memdev... | Go | Apache License 2.0 | google/gvisor | Remove unused runsc flags
PiperOrigin-RevId: 470080145 |
259,891 | 25.08.2022 16:21:15 | 25,200 | 540c79c8cf7ddbf265052c67d1f4f74ed199bb71 | netstack: add --EXPERIMENTAL-afxdp flag
Setting the flag creates an AF_XDP socket that will be consumed by the XDP
dispatcher. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/fdbased/endpoint.go",
"new_path": "pkg/tcpip/link/fdbased/endpoint.go",
"diff": "package fdbased\nimport (\n+ \"errors\"\n\"fmt\"\n\"golang.org/x/sys/unix\"\n@@ -88,6 +89,9 @@ const (\n// primary use-case for this is runsc which uses an AF_PACKE... | Go | Apache License 2.0 | google/gvisor | netstack: add --EXPERIMENTAL-afxdp flag
Setting the flag creates an AF_XDP socket that will be consumed by the XDP
dispatcher.
PiperOrigin-RevId: 470109694 |
259,909 | 26.08.2022 16:28:59 | 25,200 | 23b21af6d631c6574901628ea12ec1e7f7e2324d | Fix JSON marshaling of runsc cgroup configuration. | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/cgroup.go",
"new_path": "runsc/cgroup/cgroup.go",
"diff": "@@ -41,9 +41,7 @@ import (\nconst (\ncgroupv1FsName = \"cgroup\"\ncgroupv2FsName = \"cgroup2\"\n-)\n-const (\n// procRoot is the procfs root this module uses.\nprocRoot = \"/proc\"\n@@ -41... | Go | Apache License 2.0 | google/gvisor | Fix JSON marshaling of runsc cgroup configuration.
PiperOrigin-RevId: 470357748 |
259,927 | 29.08.2022 15:40:05 | 25,200 | 4fc63e59f0b70ab84d40d9cde3a877708bb18ca2 | Use monotonic time for neighbor entries | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache_test.go",
"new_path": "pkg/tcpip/stack/neighbor_cache_test.go",
"diff": "@@ -61,6 +61,7 @@ func unorderedEventsDiffOpts() []cmp.Option {\ncmpopts.SortSlices(func(a, b testEntryEventInfo) bool {\nreturn strings.Compare(string(a.En... | Go | Apache License 2.0 | google/gvisor | Use monotonic time for neighbor entries
PiperOrigin-RevId: 470832047 |
259,907 | 29.08.2022 21:15:18 | 25,200 | 0982a5e81db47c16b504f9c0891e77df923ea77c | Change FIXME to NOTE for b/241819530.
The comment is not actionable. We might keep seeing old kernels and keep seeing
SIGSEGVs. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/32bit.cc",
"new_path": "test/syscalls/linux/32bit.cc",
"diff": "@@ -165,7 +165,7 @@ TEST(Syscall32Bit, Syscall) {\nbreak;\ncase PlatformSupport::Ignored:\n- // FIXME(b/241819530): SIGSEGV was returned due to a kernel bug that has\n+ // NOTE... | Go | Apache License 2.0 | google/gvisor | Change FIXME to NOTE for b/241819530.
The comment is not actionable. We might keep seeing old kernels and keep seeing
SIGSEGVs.
PiperOrigin-RevId: 470890652 |
259,992 | 30.08.2022 10:46:45 | 25,200 | 1aad72663a81205722c4102cfdb62bc789cb1936 | Add landing page for Runtime Monitoring | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/BUILD",
"new_path": "g3doc/user_guide/BUILD",
"diff": "@@ -14,27 +14,30 @@ doc(\n)\ndoc(\n- name = \"checkpoint_restore\",\n- src = \"checkpoint_restore.md\",\n+ name = \"install\",\n+ src = \"install.md\",\ncategory = \"User Guide\",\n- perma... | Go | Apache License 2.0 | google/gvisor | Add landing page for Runtime Monitoring
PiperOrigin-RevId: 471033778 |
259,909 | 30.08.2022 15:51:26 | 25,200 | e0aa478022f4c3fde1b9619a11421c803e0c0791 | Ignore systemd "scope already exists" errors.
This copies the behavior of runc. See | [
{
"change_type": "MODIFY",
"old_path": "runsc/cgroup/systemd.go",
"new_path": "runsc/cgroup/systemd.go",
"diff": "@@ -181,6 +181,8 @@ func (c *cgroupSystemd) Join() (func(), error) {\nc.dbusConn.ResetFailedUnitContext(ctx, unitName)\nreturn nil, fmt.Errorf(\"unknown job completion status %q\", s)\n}... | Go | Apache License 2.0 | google/gvisor | Ignore systemd "scope already exists" errors.
This copies the behavior of runc. See https://github.com/opencontainers/runc/blob/4a51b047036cf16d4f124548c2a7ff24b5640bad/libcontainer/cgroups/systemd/common.go#L150
PiperOrigin-RevId: 471110557 |
259,909 | 30.08.2022 18:38:31 | 25,200 | 3404bfa49a386009469d36209884fca93d37a8e3 | Refactor sharedmem tx.transmit to use bufferv2.
This reduces the amount of garbage produced by the methods. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bufferv2/buffer.go",
"new_path": "pkg/bufferv2/buffer.go",
"diff": "@@ -571,6 +571,11 @@ func (br *BufferReader) Close() {\nbr.b.Release()\n}\n+// Len returns the number of bytes in the unread portion of the buffer.\n+func (br *BufferReader) Len() int {\n+... | Go | Apache License 2.0 | google/gvisor | Refactor sharedmem tx.transmit to use bufferv2.
This reduces the amount of garbage produced by the methods.
PiperOrigin-RevId: 471141815 |
259,975 | 31.08.2022 10:54:02 | 25,200 | 7c6d90e28f39a57e93fc89bb2d59957ee6bd5ff4 | Fix make-push% rule for presubmit images. | [
{
"change_type": "MODIFY",
"old_path": "tools/images.mk",
"new_path": "tools/images.mk",
"diff": "@@ -154,6 +154,7 @@ load-%: register-cross ## Pull or build an image locally.\n# the fully-expanded remote image tag.\npush-%: load-% ## Push a given image.\n@docker image push $(call remote_image,$*):$... | Go | Apache License 2.0 | google/gvisor | Fix make-push% rule for presubmit images.
PiperOrigin-RevId: 471296093 |
259,977 | 31.08.2022 13:02:23 | 25,200 | 7203e8aceed1d4d619c4855a25513644a0c49f18 | Fix logs in loopback test
udp.ProtocolNumber ==> tcp.ProtocolNumber | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/integration/loopback_test.go",
"new_path": "pkg/tcpip/tests/integration/loopback_test.go",
"diff": "@@ -452,7 +452,7 @@ func TestLoopbackAcceptAllInSubnetTCP(t *testing.T) {\ndefer wq.EventUnregister(&we)\nlisteningEndpoint, err := s.NewEndpoin... | Go | Apache License 2.0 | google/gvisor | Fix logs in loopback test
udp.ProtocolNumber ==> tcp.ProtocolNumber
PiperOrigin-RevId: 471329935 |
259,909 | 31.08.2022 13:37:01 | 25,200 | b9f04e4000a9668f3528af2e590c5b23254a7125 | Refactor TestHandshakeTimeoutConnectCount to use a fake clock.
This makes the test take 2 seconds instead of 2+ minutes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/test/e2e/tcp_test.go",
"new_path": "pkg/tcpip/transport/tcp/test/e2e/tcp_test.go",
"diff": "@@ -293,7 +293,13 @@ func TestCloseWithoutConnect(t *testing.T) {\n}\nfunc TestHandshakeTimeoutConnectedCount(t *testing.T) {\n- c := context.Ne... | Go | Apache License 2.0 | google/gvisor | Refactor TestHandshakeTimeoutConnectCount to use a fake clock.
This makes the test take 2 seconds instead of 2+ minutes.
PiperOrigin-RevId: 471341662 |
259,853 | 31.08.2022 15:39:21 | 25,200 | 479fd558e12f2985878d9634c6ec93304cdc2e4b | ring0: fix off-by-one bug in IsCanonical | [
{
"change_type": "MODIFY",
"old_path": "pkg/ring0/kernel_amd64.go",
"new_path": "pkg/ring0/kernel_amd64.go",
"diff": "@@ -215,7 +215,7 @@ func (c *CPU) EFER() uint64 {\n//\n//go:nosplit\nfunc IsCanonical(addr uint64) bool {\n- return addr <= 0x00007fffffffffff || addr > 0xffff800000000000\n+ return ... | Go | Apache License 2.0 | google/gvisor | ring0: fix off-by-one bug in IsCanonical
PiperOrigin-RevId: 471373714 |
259,975 | 01.09.2022 12:18:26 | 25,200 | be5faaf19ba692569256ba9d906edada3377480a | Remove latest tag from Makefile
Remove the call to tag images with the "latest"
tag. This is unnecessary for CI builds and it is
currently breaking the release pipeline. | [
{
"change_type": "MODIFY",
"old_path": "tools/images.mk",
"new_path": "tools/images.mk",
"diff": "@@ -154,8 +154,6 @@ load-%: register-cross ## Pull or build an image locally.\n# the fully-expanded remote image tag.\npush-%: load-% ## Push a given image.\n@docker image push $(call remote_image,$*):$... | Go | Apache License 2.0 | google/gvisor | Remove latest tag from Makefile
Remove the call to tag images with the "latest"
tag. This is unnecessary for CI builds and it is
currently breaking the release pipeline.
PiperOrigin-RevId: 471600547 |
259,909 | 01.09.2022 16:42:13 | 25,200 | dade50095a41bdf3ea2bec8085dc1e87709bbe89 | Use a pool for segments.
This will improve the performance of newIncomingSegment, newOutgoingSegment,
and clone. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/transport/tcp/segment.go",
"new_path": "pkg/tcpip/transport/tcp/segment.go",
"diff": "@@ -19,6 +19,7 @@ import (\n\"io\"\n\"gvisor.dev/gvisor/pkg/bufferv2\"\n+ \"gvisor.dev/gvisor/pkg/sync\"\n\"gvisor.dev/gvisor/pkg/tcpip\"\n\"gvisor.dev/gvisor/pkg/t... | Go | Apache License 2.0 | google/gvisor | Use a pool for segments.
This will improve the performance of newIncomingSegment, newOutgoingSegment,
and clone.
PiperOrigin-RevId: 471666528 |
259,950 | 02.09.2022 11:13:41 | -28,800 | 29793cb7f8f7e6234c09c4156c720b30aaebae1c | images.mk: make sort result stable to generate the same image tag at diffrent machines | [
{
"change_type": "MODIFY",
"old_path": "tools/images.mk",
"new_path": "tools/images.mk",
"diff": "@@ -76,7 +76,7 @@ dockerfile = $$(if [ -f \"$(call path,$(1))/Dockerfile.$(ARCH)\" ]; then echo Dock\n# The tag construct is used to memoize the image generated (see README.md).\n# This scheme is used t... | Go | Apache License 2.0 | google/gvisor | images.mk: make sort result stable to generate the same image tag at diffrent machines
Signed-off-by: Tan Yifeng <yiftan@163.com> |
259,932 | 02.09.2022 13:34:07 | 25,200 | a3a57724912c54d4c464c329452ff789471b408f | Fixes to TTOU handling in TIOCSPGRP
Fixes two issues in TTOU handling while handling TIOCSPGRP on a tty
device.
fixes see that issue for details of the bugs.
Updates the tests to test the fixed behavior; both tests are verified
to fail without the `thread_group.go` fixes. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/thread_group.go",
"new_path": "pkg/sentry/kernel/thread_group.go",
"diff": "@@ -514,9 +514,10 @@ func (tg *ThreadGroup) SetForegroundProcessGroup(tty *TTY, pgid ProcessGroupID)\n// signal is sent to all members of this background process grou... | Go | Apache License 2.0 | google/gvisor | Fixes to TTOU handling in TIOCSPGRP
Fixes two issues in TTOU handling while handling TIOCSPGRP on a tty
device.
fixes #7941; see that issue for details of the bugs.
Updates the tests to test the fixed behavior; both tests are verified
to fail without the `thread_group.go` fixes. |
259,891 | 06.09.2022 11:14:41 | 25,200 | 6840864b0e3edcf2688ba705676144e91c0679b5 | experimental xdp dispatcher | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/BUILD",
"new_path": "pkg/tcpip/BUILD",
"diff": "@@ -66,6 +66,7 @@ deps_test(\n\"//pkg/state/wire\",\n\"//pkg/sync\",\n\"//pkg/waiter\",\n+ \"//pkg/xdp\",\n# Other deps.\n\"@com_github_google_btree//:go_default_library\",\n"
},
{
"change_type"... | Go | Apache License 2.0 | google/gvisor | experimental xdp dispatcher
PiperOrigin-RevId: 472509327 |
259,891 | 06.09.2022 17:31:22 | 25,200 | ad7b1121d4b81b52c39e4f2ea041144edc1d1067 | xdp: use needs-wakeup flag
This is recommended in the kernel docs: | [
{
"change_type": "MODIFY",
"old_path": "pkg/xdp/xdp.go",
"new_path": "pkg/xdp/xdp.go",
"diff": "@@ -202,11 +202,15 @@ func ReadOnlyFromSocket(sockfd int, ifaceIdx, queueID uint32, opts ReadOnlySocke\nrxQueue.init(off, opts)\naddr := unix.SockaddrXDP{\n+ // XDP_USE_NEED_WAKEUP lets the driver sleep i... | Go | Apache License 2.0 | google/gvisor | xdp: use needs-wakeup flag
This is recommended in the kernel docs:
https://www.kernel.org/doc/html/latest/networking/af_xdp.html#xdp-use-need-wakeup-bind-flag
PiperOrigin-RevId: 472596449 |
259,950 | 25.08.2022 10:35:27 | -28,800 | 39e2e5b968fef9ddb786ae74a1ca4a2b105f416e | support set or get tcpsockopt TCP_MAXSEG, TCP_CONGESTION for hostnetwork. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -406,10 +406,12 @@ func (s *socketOpsCommon) GetSockOpt(t *kernel.Task, level int, name int, optVal\n}\ncase linux.SOL_TCP:\nswitch name {\n- case linux.TCP_... | Go | Apache License 2.0 | google/gvisor | support set or get tcpsockopt TCP_MAXSEG, TCP_CONGESTION for hostnetwork.
Signed-off-by: Tan Yifeng <yiftan@163.com> |
259,907 | 06.09.2022 20:17:10 | 25,200 | 658ee7f7cf103f89751b70ec357e0c9a85c58d54 | Allow dcache=0 in runsc to completely disable dentry caching in gofer. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -113,13 +113,18 @@ type dentryCache struct {\n// SetDentryCacheSize sets the size of the global gofer dentry cache.\nfunc SetDentryCacheSize(size int) {\n- globalDen... | Go | Apache License 2.0 | google/gvisor | Allow dcache=0 in runsc to completely disable dentry caching in gofer.
PiperOrigin-RevId: 472621428 |
259,891 | 07.09.2022 14:26:18 | 25,200 | 3fb884c2b8104dd3c6f75a620a25dd3f4321658f | runsc: add PCAP logging flag
Also: PCAP logging was broken, fixed that.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/link/sniffer/pcap.go",
"new_path": "pkg/tcpip/link/sniffer/pcap.go",
"diff": "@@ -55,18 +55,20 @@ type pcapPacket struct {\n}\nfunc (p *pcapPacket) MarshalBinary() ([]byte, error) {\n- packetSize := p.packet.Size()\n+ pkt := trimmedClone(p.packet)\n+... | Go | Apache License 2.0 | google/gvisor | runsc: add PCAP logging flag
Also: PCAP logging was broken, fixed that.
Fixes #5968.
PiperOrigin-RevId: 472812978 |
259,891 | 07.09.2022 14:52:35 | 25,200 | 7c8624e575d7bf8d24b13530b8d62698c821c9ea | xdp_loader: refactor to use subcommands
No change to behavior, just a refactor.
Another program (tunnel) is coming, and the code is becoming unwieldy. Impose
some structure. | [
{
"change_type": "MODIFY",
"old_path": "tools/xdp/BUILD",
"new_path": "tools/xdp/BUILD",
"diff": "@@ -5,7 +5,10 @@ package(licenses = [\"notice\"])\ngo_binary(\nname = \"xdp_loader\",\nsrcs = [\n+ \"drop.go\",\n\"main.go\",\n+ \"pass.go\",\n+ \"tcpdump.go\",\n],\nembedsrcs = [\n\"//tools/xdp/bpf:dro... | Go | Apache License 2.0 | google/gvisor | xdp_loader: refactor to use subcommands
No change to behavior, just a refactor.
Another program (tunnel) is coming, and the code is becoming unwieldy. Impose
some structure.
PiperOrigin-RevId: 472818768 |
259,853 | 07.09.2022 15:26:00 | 25,200 | d9556a543f570e21260c4d516d325c4c7bc7e933 | kvm: handle a case when a bounce interrupt is triggred in gr0
We disable interrupts in gr0, but go-runtime can resume a routine that has been
suspend in hr3. In this case, it restores eflags with the IF flag. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/bluepill_amd64.go",
"new_path": "pkg/sentry/platform/kvm/bluepill_amd64.go",
"diff": "@@ -128,10 +128,11 @@ func (c *vCPU) KernelSyscall() {\nfunc (c *vCPU) KernelException(vector ring0.Vector) {\nregs := c.Registers()\nif vector == rin... | Go | Apache License 2.0 | google/gvisor | kvm: handle a case when a bounce interrupt is triggred in gr0
We disable interrupts in gr0, but go-runtime can resume a routine that has been
suspend in hr3. In this case, it restores eflags with the IF flag.
PiperOrigin-RevId: 472826101 |
259,950 | 03.09.2022 09:38:20 | -28,800 | c844c84a71eff9af18b494c73542b5a231070cd6 | Truncate the output buffer to outLen size when getsockopt with TCP_INFO. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -410,6 +410,10 @@ func (s *socketOpsCommon) GetSockOpt(t *kernel.Task, level int, name int, optVal\noptlen = sizeofInt32\ncase linux.TCP_INFO:\noptlen = linu... | Go | Apache License 2.0 | google/gvisor | Truncate the output buffer to outLen size when getsockopt with TCP_INFO.
Signed-off-by: Tan Yifeng <yiftan@163.com> |
259,907 | 08.09.2022 10:45:11 | 25,200 | d8b11367560a67c404fc0d3fe67c468c7f339338 | Disable process_vm_read_write tests on Linux.
These tests are flaky and are blocking submits. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/BUILD",
"new_path": "test/syscalls/BUILD",
"diff": "@@ -1066,5 +1066,7 @@ syscall_test(\nsyscall_test(\nsize = \"small\",\n+ # TODO(b/245647342): These tests are flaky on native.\n+ allow_native = False,\ntest = \"//test/syscalls/linux:process_vm... | Go | Apache License 2.0 | google/gvisor | Disable process_vm_read_write tests on Linux.
These tests are flaky and are blocking submits.
PiperOrigin-RevId: 473029748 |
259,853 | 08.09.2022 14:35:37 | 25,200 | f7855b28f0aa976b7b80778eac6b2b07510e8126 | kvm: don't call panic from signal handlers
throw has to be used in such cases. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -380,13 +380,13 @@ func (m *machine) mapPhysical(physical, length uintptr, phyRegions []physicalReg\n_, physicalStart, length, pr := calculateBluepillFault(physi... | Go | Apache License 2.0 | google/gvisor | kvm: don't call panic from signal handlers
throw has to be used in such cases.
PiperOrigin-RevId: 473087177 |
259,907 | 09.09.2022 08:51:36 | 25,200 | 5819462d8f03850f786fb879e70fa7802cad5da1 | Add support for O_SYNC and O_DSYNC in gofer client specialFileFD. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"new_path": "pkg/sentry/fsimpl/gofer/special_file.go",
"diff": "@@ -341,6 +341,16 @@ func (fd *specialFileFD) pwrite(ctx context.Context, src usermem.IOSequence, off\nrw := getHandleReadWriter(ctx, &fd.handle, offset)\... | Go | Apache License 2.0 | google/gvisor | Add support for O_SYNC and O_DSYNC in gofer client specialFileFD.
PiperOrigin-RevId: 473263144 |
259,907 | 09.09.2022 11:04:26 | 25,200 | ecda533559da3651c3d2746b34bcef53422147f5 | Cleanup socket in lisafs gofer's BindAt handler on error paths.
Otherwise, we leak will leak the un-closed FD. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/lisafs.go",
"new_path": "runsc/fsgofer/lisafs.go",
"diff": "@@ -690,12 +690,14 @@ func (fd *controlFDLisa) BindAt(name string, sockType uint32) (*lisafs.ControlFD\nreturn nil, linux.Statx{}, nil, -1, err\n}\nif err := unix.Bind(sockFD, &unix.Sock... | Go | Apache License 2.0 | google/gvisor | Cleanup socket in lisafs gofer's BindAt handler on error paths.
Otherwise, we leak will leak the un-closed FD.
PiperOrigin-RevId: 473294586 |
259,848 | 09.09.2022 18:07:00 | 25,200 | 31d8668e5178c34343f26020748050a0434419dc | Pseudo-filesystem iouringfs for IO_URING.
Similar to Linux, we should add pseudo-filesystem iouringfs in gVisor to back
IO_URING's file descriptors. We start with stubbing `io_uring_setup(2)` so it
provides a file descriptor backed by anonfs. | [
{
"change_type": "MODIFY",
"old_path": "pkg/abi/linux/BUILD",
"new_path": "pkg/abi/linux/BUILD",
"diff": "@@ -35,6 +35,7 @@ go_library(\n\"inotify.go\",\n\"ioctl.go\",\n\"ioctl_tun.go\",\n+ \"iouring.go\",\n\"ip.go\",\n\"ipc.go\",\n\"limits.go\",\n"
},
{
"change_type": "ADD",
"old_path":... | Go | Apache License 2.0 | google/gvisor | Pseudo-filesystem iouringfs for IO_URING.
Similar to Linux, we should add pseudo-filesystem iouringfs in gVisor to back
IO_URING's file descriptors. We start with stubbing `io_uring_setup(2)` so it
provides a file descriptor backed by anonfs.
PiperOrigin-RevId: 473384042 |
259,891 | 13.09.2022 10:59:03 | 25,200 | d2827e5a92426db6a61e2c8c4f464b1d2a96bc0b | Don't require gcc-multilib to be installed to build BPF | [
{
"change_type": "MODIFY",
"old_path": "tools/bazeldefs/defs.bzl",
"new_path": "tools/bazeldefs/defs.bzl",
"diff": "@@ -91,5 +91,5 @@ def bpf_program(name, src, bpf_object, visibility, hdrs):\nsrcs = [src],\nvisibility = visibility,\nouts = [bpf_object],\n- cmd = \"clang -O2 -Wall -Werror -target bp... | Go | Apache License 2.0 | google/gvisor | Don't require gcc-multilib to be installed to build BPF
PiperOrigin-RevId: 474067220 |
259,852 | 14.09.2022 02:04:05 | -28,800 | 7cc16b41dfa64b2b387466280a8df096abde8f70 | Replace bitset with stdlib math/big
Sync changes in runc | [
{
"change_type": "MODIFY",
"old_path": "WORKSPACE",
"new_path": "WORKSPACE",
"diff": "@@ -1896,10 +1896,3 @@ go_repository(\nsum = \"h1:LhYJRs+L4fBtjZUfuSZIKGeVu0QRy8e5Xi7D17UxZ74=\",\nversion = \"v1.2.0\",\n)\n-\n-go_repository(\n- name = \"com_github_bits_and_blooms_bitset\",\n- importpath = \"git... | Go | Apache License 2.0 | google/gvisor | Replace bitset with stdlib math/big
Sync changes in runc https://github.com/opencontainers/runc/pull/3219 |
259,891 | 14.09.2022 10:46:40 | 25,200 | f32046a7cdf175892218ac3e26e1853a7b381022 | remove unnecessary dockerfile step
After cl/473873880 this is no longer necessary. | [
{
"change_type": "MODIFY",
"old_path": "images/default/Dockerfile",
"new_path": "images/default/Dockerfile",
"diff": "@@ -10,9 +10,6 @@ RUN apt-get update && apt-get install -y curl gnupg2 git \\\npkg-config libffi-dev patch diffutils libssl-dev iptables kmod \\\nclang\n-# For compiling BPF with cla... | Go | Apache License 2.0 | google/gvisor | remove unnecessary dockerfile step
After cl/473873880 this is no longer necessary.
PiperOrigin-RevId: 474334039 |
259,856 | 15.09.2022 08:27:33 | 14,400 | e3774819db8bbff32ee5651c261085c89d2d703e | Adjust typos, grammar, and minor formatting | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/README.md",
"new_path": "pkg/sentry/seccheck/README.md",
"diff": "@@ -72,7 +72,7 @@ message Open {\n}\n```\n-As you can see, come fields are in both raw and schemitized points, like `fd`\n+As you can see, some fields are in both raw and sch... | Go | Apache License 2.0 | google/gvisor | Adjust typos, grammar, and minor formatting |
259,939 | 14.09.2022 15:15:50 | -28,800 | 479784577dae05ca16bcdd8092caed52d85d732c | procfs: support /proc/[pid]/root file | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/proc/task.go",
"new_path": "pkg/sentry/fs/proc/task.go",
"diff": "@@ -114,6 +114,7 @@ func (p *proc) newTaskDir(ctx context.Context, t *kernel.Task, msrc *fs.MountSou\n\"ns\": newNamespaceDir(ctx, t, msrc),\n\"oom_score\": newOOMScore(ctx, msrc),... | Go | Apache License 2.0 | google/gvisor | procfs: support /proc/[pid]/root file
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
259,962 | 16.09.2022 15:18:37 | 25,200 | cfc29d3b5dacc8b18acf69b39919afc1756820c5 | Add support for block/mutex/trace profiles. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"new_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -138,6 +138,18 @@ while [ $# -gt 0 ]; do\nshift\nnetstack_opts=\"${netstack_opts} -memprofile=$1\"\n;;\n+ --blockprofile)\n+ shift\n+ netstack_opts=\"${netst... | Go | Apache License 2.0 | google/gvisor | Add support for block/mutex/trace profiles.
PiperOrigin-RevId: 474912515 |
259,907 | 19.09.2022 10:34:40 | 25,200 | 72e8fabaecee4bdc08cae623ca52a00c077be944 | Add transport.BoundSocketFD interface.
This is beneficial for 2 reasons:
transport package should not depend on lisafs, which is a user of that
package.
This allows users other than lisafs client to use transport.HostBoundEndpoint. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/client_file.go",
"new_path": "pkg/lisafs/client_file.go",
"diff": "@@ -573,7 +573,8 @@ func (f *ClientFD) RemoveXattr(ctx context.Context, name string) error {\nreturn err\n}\n-// ClientBoundSocketFD corresponds to a bound socket on the server.\n+//... | Go | Apache License 2.0 | google/gvisor | Add transport.BoundSocketFD interface.
This is beneficial for 2 reasons:
- transport package should not depend on lisafs, which is a user of that
package.
- This allows users other than lisafs client to use transport.HostBoundEndpoint.
PiperOrigin-RevId: 475326947 |
259,891 | 19.09.2022 11:42:24 | 25,200 | 48e2252b3bacc60b87f7ca36cc6f0d8729b3cb4c | fix panic caused by too-large buffer allocations
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/header/BUILD",
"new_path": "pkg/tcpip/header/BUILD",
"diff": "@@ -7,6 +7,7 @@ go_library(\nsrcs = [\n\"arp.go\",\n\"checksum.go\",\n+ \"datagram.go\",\n\"eth.go\",\n\"gue.go\",\n\"icmpv4.go\",\n"
},
{
"change_type": "ADD",
"old_path": nul... | Go | Apache License 2.0 | google/gvisor | fix panic caused by too-large buffer allocations
Reported-by: syzbot+954128c9aa37e285d23c@syzkaller.appspotmail.com
PiperOrigin-RevId: 475345594 |
259,939 | 13.09.2022 18:26:53 | -28,800 | b448cdbed7d92059857930384d4c89324751f501 | benchmarks: add syscallbench benchmark for syscall performance | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/syscallbench/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ gcc \\\n+ && rm -rf /var/lib/apt/lists/*\n+\n+COPY ./syscallbench.c /\n+RUN gcc /syscallbench.c -o ... | Go | Apache License 2.0 | google/gvisor | benchmarks: add syscallbench benchmark for syscall performance
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
259,858 | 22.09.2022 10:59:13 | 25,200 | 4bb25e196d6982f057d06edddedaf71b298ac5b0 | Unmap (prev.End, next.Start) during pma invalidation.
This should allow lower-layers to clean-up intermediate structures more
effectively, without additional heavy-lifting. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/mm/pma.go",
"new_path": "pkg/sentry/mm/pma.go",
"diff": "@@ -626,7 +626,27 @@ func (mm *MemoryManager) invalidateLocked(ar hostarch.AddrRange, invalidatePriva\n// Unmap all of ar, not just pseg.Range(), to minimize host\n// syscalls. AddressSpace ma... | Go | Apache License 2.0 | google/gvisor | Unmap (prev.End, next.Start) during pma invalidation.
This should allow lower-layers to clean-up intermediate structures more
effectively, without additional heavy-lifting.
PiperOrigin-RevId: 476144809 |
259,868 | 22.09.2022 18:53:30 | 25,200 | c895fa244150ab549d67b1d96eb4eb78e322b6f3 | Update `machine.mapPhysical`'s docstring for `panic` -> `throw`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine.go",
"new_path": "pkg/sentry/platform/kvm/machine.go",
"diff": "@@ -372,7 +372,7 @@ func (m *machine) hasSlot(physical uintptr) bool {\n// mapPhysical checks for the mapping of a physical range, and installs one if\n// not avail... | Go | Apache License 2.0 | google/gvisor | Update `machine.mapPhysical`'s docstring for `panic` -> `throw`.
PiperOrigin-RevId: 476249730 |
259,939 | 14.09.2022 10:21:28 | -28,800 | b63b4d6f366e06b15986ee31cd8c3c329ecdf4c1 | benchmarks: add hackbench benchmark for scheduler performance | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/hackbench/Dockerfile",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y rt-tests \\\n+ && rm -rf /var/lib/apt/lists/*\n"
},
{
"change_type": "MODIFY",
"old_path": "test... | Go | Apache License 2.0 | google/gvisor | benchmarks: add hackbench benchmark for scheduler performance
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
259,939 | 14.09.2022 10:44:22 | -28,800 | ac982d4a93871b69f0089c176e36d4a7413585a8 | benchmarks: add more threads arguments for sysbench benchmark | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/base/sysbench_test.go",
"new_path": "test/benchmarks/base/sysbench_test.go",
"diff": "@@ -16,6 +16,7 @@ package sysbench_test\nimport (\n\"context\"\n+ \"fmt\"\n\"testing\"\n\"gvisor.dev/gvisor/pkg/test/dockerutil\"\n@@ -25,6 +26,7 @@ import (\... | Go | Apache License 2.0 | google/gvisor | benchmarks: add more threads arguments for sysbench benchmark
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.