author int64 658 755k | date stringdate 2012-06-12 08:34:29 2024-07-22 14:51:21 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods listlengths 1 16 | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
259,939 | 14.09.2022 10:44:37 | -28,800 | 18657459acbf0645d879eb49f061c071bdef8388 | benchmarks: fix wrong file size for fio read
According to MakeCmd function of fio, the unit of --size option is MB. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/fs/fio_test.go",
"new_path": "test/benchmarks/fs/fio_test.go",
"diff": "@@ -126,7 +126,7 @@ func BenchmarkFio(b *testing.B) {\n// For reads, we need a file to read so make one inside the container.\nif strings.Contains(tc.Test, \"read\") {\n- f... | Go | Apache License 2.0 | google/gvisor | benchmarks: fix wrong file size for fio read
According to MakeCmd function of fio, the unit of --size option is MB.
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
259,939 | 14.09.2022 11:16:53 | -28,800 | 5faa4646d99211c5dc783a7273dfae5f0e85a27b | benchmarks: add more blocksize arguments for fio benchmark | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/fs/fio_test.go",
"new_path": "test/benchmarks/fs/fio_test.go",
"diff": "@@ -37,6 +37,11 @@ func BenchmarkFio(b *testing.B) {\nBlockSize: 4,\nIODepth: 4,\n},\n+ {\n+ Test: \"write\",\n+ BlockSize: 64,\n+ IODepth: 4,\n+ },\n{\nTest: \"write\",\nB... | Go | Apache License 2.0 | google/gvisor | benchmarks: add more blocksize arguments for fio benchmark
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
259,939 | 19.09.2022 16:09:25 | -28,800 | bef569af0d9605d9e11c1aaf5cc622811b43a6b6 | benchmarks: add BenchmarkIperfParameterized testcase for iperf benchmark | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/network/iperf_test.go",
"new_path": "test/benchmarks/network/iperf_test.go",
"diff": "@@ -106,6 +106,170 @@ func BenchmarkIperf(b *testing.B) {\n}\n}\n+func BenchmarkIperfParameterized(b *testing.B) {\n+ clientMachine, err := harness.GetMachine... | Go | Apache License 2.0 | google/gvisor | benchmarks: add BenchmarkIperfParameterized testcase for iperf benchmark
Signed-off-by: Chen Hui <cedriccchen@tencent.com> |
259,907 | 23.09.2022 10:43:46 | 25,200 | de7c2164d7907aff59aa0b40b309ed30057d632f | Allow O_DIRECT with gofer.specialFileFD that represent regular files.
gofer.specialFileFD can sometimes represent regular files. O_DIRECT
is expected to be supported there. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1255,7 +1255,7 @@ func (d *dentry) openSocketByConnecting(ctx context.Context, opts *vfs.OpenOptio\nfunc (d *dentry) openSpecialFile(ctx context.Context, ... | Go | Apache License 2.0 | google/gvisor | Allow O_DIRECT with gofer.specialFileFD that represent regular files.
gofer.specialFileFD can sometimes represent regular files. O_DIRECT
is expected to be supported there.
PiperOrigin-RevId: 476408649 |
259,907 | 23.09.2022 23:52:37 | 25,200 | 0ec88b757254fd383b66247cad32730fa7adb52e | Add SOCK_DGRAM socket type support in lisafs BindAt. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/fsgofer.go",
"new_path": "runsc/fsgofer/fsgofer.go",
"diff": "@@ -1130,9 +1130,7 @@ func (l *localFile) Bind(sockType uint32, sockName string, uid p9.UID, gid p9.GI\n}\n// Create socket only for supported types.\n- switch sockType {\n- case unix.... | Go | Apache License 2.0 | google/gvisor | Add SOCK_DGRAM socket type support in lisafs BindAt.
PiperOrigin-RevId: 476542032 |
259,907 | 24.09.2022 17:25:32 | 25,200 | f841b2511ecf947be341979a8b9165c3277258a0 | Use fchmodat(2) to change mode for bound sockets in lisafs gofer. | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/filter/config.go",
"new_path": "runsc/fsgofer/filter/config.go",
"diff": "@@ -53,6 +53,7 @@ var allowedSyscalls = seccomp.SyscallRules{\n},\n},\nunix.SYS_FCHMOD: {},\n+ unix.SYS_FCHMODAT: {},\nunix.SYS_FCHOWNAT: {},\nunix.SYS_FCNTL: []seccomp.Rul... | Go | Apache License 2.0 | google/gvisor | Use fchmodat(2) to change mode for bound sockets in lisafs gofer.
PiperOrigin-RevId: 476642321 |
259,907 | 26.09.2022 16:46:43 | 25,200 | 68fd6aba43eeb776b45d74c52525d2e7da5532d8 | Update BindAt RPC to include other creation options.
BindAt should also be setting the socket file mode and owners.
All file creation RPCs do this. This is required for correct behavior. | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/client_file.go",
"new_path": "pkg/lisafs/client_file.go",
"diff": "@@ -421,16 +421,18 @@ func (f *ClientFD) Flush(ctx context.Context) error {\n}\n// BindAt makes the BindAt RPC.\n-func (f *ClientFD) BindAt(ctx context.Context, sockType linux.SockTy... | Go | Apache License 2.0 | google/gvisor | Update BindAt RPC to include other creation options.
BindAt should also be setting the socket file mode and owners.
All file creation RPCs do this. This is required for correct behavior.
PiperOrigin-RevId: 477023055 |
259,868 | 26.09.2022 20:02:45 | 25,200 | 77d8b6cd77d876ef2e8fce492d9207693021fe3e | Add custom error type for `ResolveExecutablePath`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/user/path.go",
"new_path": "pkg/sentry/fs/user/path.go",
"diff": "@@ -30,8 +30,13 @@ import (\n\"gvisor.dev/gvisor/pkg/sentry/vfs\"\n)\n+// ExecutableResolveError represents a failure to resolve the executable\n+// in ResolveExecutablePath.\n+typ... | Go | Apache License 2.0 | google/gvisor | Add custom error type for `ResolveExecutablePath`.
PiperOrigin-RevId: 477058661 |
259,868 | 29.09.2022 17:04:07 | 25,200 | 3e2e74279a92b372d6f271272c4a3d421a6b42f7 | User pointer error type for `path.ExecutableResolveError`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fs/user/path.go",
"new_path": "pkg/sentry/fs/user/path.go",
"diff": "@@ -32,11 +32,11 @@ import (\n// ExecutableResolveError represents a failure to resolve the executable\n// in ResolveExecutablePath.\n-type ExecutableResolveError error\n+type Exec... | Go | Apache License 2.0 | google/gvisor | User pointer error type for `path.ExecutableResolveError`.
PiperOrigin-RevId: 477857846 |
259,977 | 30.09.2022 08:12:51 | 25,200 | 61e742b38912c1a54f3d1d3b46c7d837db1ea9de | Align stack variables in RebindProtocol test
Previously, this test read packets directly into the stack memory of a packed
struct. Since the ethernet header is not 8-byte aligned, this can cause UB on
CPUs requiring 8-byte alignment. Resolve this issue by copying each segment of
the packet into separate stack variables. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/packet_socket.cc",
"new_path": "test/syscalls/linux/packet_socket.cc",
"diff": "@@ -200,23 +200,31 @@ TEST_P(PacketSocketTest, RebindProtocol) {\n};\nauto test_recv = [&, this](const uint64_t v) {\n- struct {\n+ // Declare each section of t... | Go | Apache License 2.0 | google/gvisor | Align stack variables in RebindProtocol test
Previously, this test read packets directly into the stack memory of a packed
struct. Since the ethernet header is not 8-byte aligned, this can cause UB on
CPUs requiring 8-byte alignment. Resolve this issue by copying each segment of
the packet into separate stack variables.
PiperOrigin-RevId: 477996715 |
259,909 | 30.09.2022 10:48:46 | 25,200 | f53c349d519a01cf603bf845a4b2a382e30b1715 | Add support for bind mounting.
This change adds limited support for the MS_BIND flag. MS_REC is not yet
implemented. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/mount.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/mount.go",
"diff": "@@ -17,6 +17,7 @@ package vfs2\nimport (\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n\"gvisor.dev/gvisor/pkg/errors/linuxerr\"\n+ \"gvisor.dev/gvisor/pkg/fspath... | Go | Apache License 2.0 | google/gvisor | Add support for bind mounting.
This change adds limited support for the MS_BIND flag. MS_REC is not yet
implemented.
PiperOrigin-RevId: 478030021 |
259,909 | 03.10.2022 11:04:25 | 25,200 | 4cff09161e8707607f1a4cc6e86f9e043d987a7e | Cache neighbor entries in route struct.
This will avoid allocating closures and having to retrieve the entry from
the table every time. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -122,9 +122,7 @@ func (n *neighborCache) getOrCreateEntry(remoteAddr tcpip.Address) *neighborEntr\n// If specified, the local address must be an address local to t... | Go | Apache License 2.0 | google/gvisor | Cache neighbor entries in route struct.
This will avoid allocating closures and having to retrieve the entry from
the table every time.
PiperOrigin-RevId: 478551631 |
259,977 | 03.10.2022 18:18:05 | 25,200 | 8f110cbdaa88bdeecef9b4c09fd2a3cdcd1b13e8 | Reduce poll timeouts
The 10s timeout eats up significant time when tests are expected to fail. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -40,6 +40,8 @@ namespace testing {\nnamespace {\n+constexpr int kTimeoutMillis = 10000;\n+\nPosixErrorOr<sockaddr_storage> InetLoopbackAddr(int family) {\nstruct s... | Go | Apache License 2.0 | google/gvisor | Reduce poll timeouts
The 10s timeout eats up significant time when tests are expected to fail.
PiperOrigin-RevId: 478655369 |
259,977 | 04.10.2022 11:46:56 | 25,200 | 631477c7b87ae43ab0d55f07e131918064a33c82 | Store threads with unique_ptr in ListenConnectParallel
The existing implementation uses raw pointers, which means:
Threads are joined at the end of each loop, and the test therefore doesn't
actually exercise the syscalls in parallel.
The later call to `Join` is undefined behavior. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/tcp_socket.cc",
"new_path": "test/syscalls/linux/tcp_socket.cc",
"diff": "@@ -1111,9 +1111,11 @@ TEST_P(SimpleTcpSocketTest, ListenConnectParallel) {\n});\n// Initiate connects in a separate thread.\n- std::vector<ScopedThread*> threads;\n+... | Go | Apache License 2.0 | google/gvisor | Store threads with unique_ptr in ListenConnectParallel
The existing implementation uses raw pointers, which means:
- Threads are joined at the end of each loop, and the test therefore doesn't
actually exercise the syscalls in parallel.
- The later call to `Join` is undefined behavior.
PiperOrigin-RevId: 478845631 |
259,982 | 04.10.2022 15:55:04 | 25,200 | 30182dc10f7b9f47698ec50441a910c90cd328dd | Add /proc/[pid]/maps to runsc trace procfs
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/hostarch/access_type.go",
"new_path": "pkg/hostarch/access_type.go",
"diff": "@@ -122,5 +122,6 @@ var (\nWrite = AccessType{Write: true}\nExecute = AccessType{Execute: true}\nReadWrite = AccessType{Read: true, Write: true}\n+ ReadExecute = AccessType{Read:... | Go | Apache License 2.0 | google/gvisor | Add /proc/[pid]/maps to runsc trace procfs
Updates #7897
PiperOrigin-RevId: 478903608 |
259,907 | 04.10.2022 16:49:41 | 25,200 | 0842a94cd00aa8ffcb0e61b7f0191bd56f5754d2 | Lisafs gofer should not allow walk/mount on pipes.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/fsgofer/lisafs.go",
"new_path": "runsc/fsgofer/lisafs.go",
"diff": "@@ -60,12 +60,22 @@ func (s *LisafsServer) Mount(c *lisafs.Connection, mountNode *lisafs.Node) (*lis\nif err != nil {\nreturn nil, linux.Statx{}, err\n}\n+ cu := cleanup.Make(func() {\n+... | Go | Apache License 2.0 | google/gvisor | Lisafs gofer should not allow walk/mount on pipes.
Fixes #8045
PiperOrigin-RevId: 478915103 |
259,885 | 06.10.2022 10:01:06 | 25,200 | 718e3b5812de92f29796416ea12bfa46a24887e9 | Don't use libc mremap within InForkedProcess() in mremap test. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/mremap.cc",
"new_path": "test/syscalls/linux/mremap.cc",
"diff": "#include <errno.h>\n#include <string.h>\n#include <sys/mman.h>\n+#ifdef __linux__\n+#include <sys/syscall.h>\n+#endif\n+#include <unistd.h>\n#include <string>\n@@ -35,6 +39,1... | Go | Apache License 2.0 | google/gvisor | Don't use libc mremap within InForkedProcess() in mremap test.
PiperOrigin-RevId: 479341121 |
259,985 | 06.10.2022 13:01:57 | 25,200 | c174470a2d7ae3940c07aa803923299a228c94d4 | Clarify that auth.NewRootUserNamespace creates a distinct ns on each call. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/auth/user_namespace.go",
"new_path": "pkg/sentry/kernel/auth/user_namespace.go",
"diff": "@@ -52,7 +52,10 @@ type UserNamespace struct {\n}\n// NewRootUserNamespace returns a UserNamespace that is appropriate for a\n-// system's root user nam... | Go | Apache License 2.0 | google/gvisor | Clarify that auth.NewRootUserNamespace creates a distinct ns on each call.
PiperOrigin-RevId: 479392054 |
260,004 | 07.10.2022 10:21:55 | 25,200 | 76d800d41013a1f9aad073a4323117c2bac95438 | Limit the number of discovered SLAAC prefixes
...to prevent address explosion.
Fuchsia bug: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/ndp.go",
"new_path": "pkg/tcpip/network/ipv6/ndp.go",
"diff": "@@ -97,6 +97,11 @@ const (\n// prefixes.\nMaxDiscoveredOnLinkPrefixes = 10\n+ // MaxDiscoveredSLAACPrefixes is the maximum number of discovered\n+ // SLAAC prefixes. The stac... | Go | Apache License 2.0 | google/gvisor | Limit the number of discovered SLAAC prefixes
...to prevent address explosion.
Fuchsia bug: https://fxbug.dev/110896
PiperOrigin-RevId: 479613489 |
259,885 | 07.10.2022 11:00:57 | 25,200 | 543e8a22565bd8c926350292736a2780982ea021 | Fix flakes in tests that use munmap() to create deliberate MM holes. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/BUILD",
"new_path": "test/syscalls/linux/BUILD",
"diff": "@@ -1057,6 +1057,8 @@ cc_binary(\n\"@com_google_absl//absl/time\",\ngtest,\n\"//test/util:io_uring_util\",\n+ \"//test/util:memory_util\",\n+ \"//test/util:multiprocess_util\",\n\"//... | Go | Apache License 2.0 | google/gvisor | Fix flakes in tests that use munmap() to create deliberate MM holes.
PiperOrigin-RevId: 479623755 |
259,985 | 07.10.2022 13:07:33 | 25,200 | 10a1cadd736abfc3490ec855089551e673ce4aee | Add container exit event. | [
{
"change_type": "MODIFY",
"old_path": "pkg/eventchannel/event.go",
"new_path": "pkg/eventchannel/event.go",
"diff": "@@ -59,6 +59,15 @@ func AddEmitter(e Emitter) {\nDefaultEmitter.AddEmitter(e)\n}\n+// HaveEmitters indicates if any emitters have been registered to the\n+// default emitter.\n+func ... | Go | Apache License 2.0 | google/gvisor | Add container exit event.
PiperOrigin-RevId: 479651998 |
260,004 | 07.10.2022 13:42:07 | 25,200 | 39ac7df1b78c4853b054fa43e5eb14106511b6b7 | ConfirmReachable with the cached neighbor entry
This avoids a map lookup (RLock) in the TCP data path. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_cache.go",
"new_path": "pkg/tcpip/stack/neighbor_cache.go",
"diff": "@@ -294,19 +294,6 @@ func (n *neighborCache) handleConfirmation(addr tcpip.Address, linkAddr tcpip.Li\n}\n}\n-// handleUpperLevelConfirmation processes a confirmation... | Go | Apache License 2.0 | google/gvisor | ConfirmReachable with the cached neighbor entry
This avoids a map lookup (RLock) in the TCP data path.
PiperOrigin-RevId: 479659280 |
259,868 | 07.10.2022 15:14:03 | 25,200 | 66aa0427cda4e820ca37f2f6df797db7672d70bf | Make BuildKite's docker runtime reload logic robust against empty runtime dict | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "@@ -77,8 +77,11 @@ done\nset -euo pipefail\n# Remove all Docker runtimes that may be installed.\n-if grep -qE runtimes /etc/docker/daemon.json; then\n- cat /etc/docker/daemon... | Go | Apache License 2.0 | google/gvisor | Make BuildKite's docker runtime reload logic robust against empty runtime dict
PiperOrigin-RevId: 479678511 |
260,004 | 07.10.2022 15:58:22 | 25,200 | 3f60372ea355b2125735bdcdb0519352511639fa | Avoid write lock when handling upper layer confirmation
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/neighbor_entry.go",
"new_path": "pkg/tcpip/stack/neighbor_entry.go",
"diff": "@@ -592,26 +592,45 @@ func (e *neighborEntry) handleConfirmationLocked(linkAddr tcpip.LinkAddress, fla\n// handleUpperLevelConfirmation processes an incoming upper-le... | Go | Apache License 2.0 | google/gvisor | Avoid write lock when handling upper layer confirmation
Fixes #8051
PiperOrigin-RevId: 479686806 |
259,853 | 10.10.2022 12:31:13 | 25,200 | 6e5aadd36f7d20a939a75a70e471e4fc7fe04706 | Don't run each test case in a separate sandbox
This change was inspired by the Fabricio's change:
("Run shards in a single sandbox") | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -72,6 +72,7 @@ def _syscall_test(\nlisafs = True,\nfuse = False,\ncontainer = None,\n+ one_sandbox = True,\n**kwargs):\n# Prepend \"runsc\" to non-native platform names.\nfull_platform = pl... | Go | Apache License 2.0 | google/gvisor | Don't run each test case in a separate sandbox
This change was inspired by the Fabricio's change:
1b9d45dbe875 ("Run shards in a single sandbox")
PiperOrigin-RevId: 480151140 |
259,868 | 10.10.2022 17:18:26 | 25,200 | 7de3c5af4a2e355088d2320bf19c4c72ac00fcd0 | Add small tool to print distribution metric bucket sizes conveniently.
Useful to search for decent bucket sizes interactively. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "pkg/metric/buckettool/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_binary\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_binary(\n+ name = \"buckettool\",\n+ srcs = [\"buckettool.go\"],\n+ deps = [\n+ \"//pkg/log\",\n+ \"//pkg/metric\",\n... | Go | Apache License 2.0 | google/gvisor | Add small tool to print distribution metric bucket sizes conveniently.
Useful to search for decent bucket sizes interactively.
PiperOrigin-RevId: 480214658 |
259,868 | 11.10.2022 12:11:54 | 25,200 | 0e9ef844eb455fc60114e0eb5ce0c46404461c7b | Separate Containerd 1.4.3 tests in cgroupv1/cgroupv2 variants. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -289,7 +289,7 @@ steps:\n<<: *ubuntu_agents\narch: \"amd64\"\n- <<: *common\n- label: \":docker: Containerd 1.3.9 tests\"\n+ label: \":docker: Containerd 1.3.9 tests (cgroupv1)\"\nc... | Go | Apache License 2.0 | google/gvisor | Separate Containerd 1.4.3 tests in cgroupv1/cgroupv2 variants.
PiperOrigin-RevId: 480421275 |
259,885 | 11.10.2022 12:27:24 | 25,200 | 2e844f74fcdd01d94e7d74c96b4ae8fd1137cd1d | Do not use ktime.Timer for CPU clock ticks. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -4,6 +4,13 @@ load(\"//pkg/sync/locking:locking.bzl\", \"declare_mutex\", \"declare_rwmutex\")\npackage(licenses = [\"notice\"])\n+declare_mutex(\n+ name = \"cpu_clock_mutex\",\n+ out... | Go | Apache License 2.0 | google/gvisor | Do not use ktime.Timer for CPU clock ticks.
PiperOrigin-RevId: 480424573 |
259,992 | 11.10.2022 16:07:47 | 25,200 | 7bb273341ee026d49e144b987b22ef561448bee3 | Add flag to filter debug logs
This allows for only a subset of commands to be logged to reduce the
amount of logging generated.
Updates | [
{
"change_type": "MODIFY",
"old_path": "runsc/cli/main.go",
"new_path": "runsc/cli/main.go",
"diff": "@@ -147,8 +147,10 @@ func Main(version string) {\n// propagate it to child processes.\nrefs.SetLeakMode(conf.ReferenceLeak)\n+ subcommand := flag.CommandLine.Arg(0)\n+\n// Set up logging.\n- if conf... | Go | Apache License 2.0 | google/gvisor | Add flag to filter debug logs
This allows for only a subset of commands to be logged to reduce the
amount of logging generated.
Updates #7999
PiperOrigin-RevId: 480476369 |
259,891 | 11.10.2022 20:24:48 | 25,200 | 607fdc536d9a1c9373484fbe663dce99d369bf8a | DecRef ptr niling | [
{
"change_type": "MODIFY",
"old_path": "nogo.yaml",
"new_path": "nogo.yaml",
"diff": "@@ -218,7 +218,3 @@ analyzers:\nsuppress:\n- \"comment on exported type Translation\" # Intentional.\n- \"comment on exported type PinnedRange\" # Intentional.\n- ST1016: # CheckReceiverNamesIdentical\n- internal:\... | Go | Apache License 2.0 | google/gvisor | DecRef ptr niling
PiperOrigin-RevId: 480518221 |
259,977 | 12.10.2022 14:23:50 | 25,200 | 49874d2cff79a7cafadc0c88f28199c454e981ab | Avoid UB when bit shifting
The 0 literal is a signed integer; bitshifting its (negative) complement is
undefined behavior. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_ip_unbound.cc",
"new_path": "test/syscalls/linux/socket_ip_unbound.cc",
"diff": "@@ -284,7 +284,7 @@ TEST_P(IPUnboundSocketTest, SmallTOSOptionSize) {\nEXPECT_EQ(get_sz, expect_sz);\n// Account for partial copies by getsockopt, retri... | Go | Apache License 2.0 | google/gvisor | Avoid UB when bit shifting
The 0 literal is a signed integer; bitshifting its (negative) complement is
undefined behavior.
PiperOrigin-RevId: 480717288 |
259,885 | 13.10.2022 22:12:29 | 25,200 | 2f57fc1f17a4ee84015def47970e9cee99cd31aa | Handle pending CPU clock tick in incRunningTasks(). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/kernel.go",
"new_path": "pkg/sentry/kernel/kernel.go",
"diff": "@@ -213,6 +213,9 @@ type Kernel struct {\n// cpuClock is mutable, and is accessed using atomic memory operations.\ncpuClock atomicbitops.Uint64\n+ // cpuClockTickTimer drives inc... | Go | Apache License 2.0 | google/gvisor | Handle pending CPU clock tick in incRunningTasks().
PiperOrigin-RevId: 481060107 |
259,907 | 14.10.2022 10:30:57 | 25,200 | 94600be1b8203327c0a19e64f012d7ad79e94245 | Fix the runs to 1GB for rand write/read for the FIO benchmark. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -450,7 +450,7 @@ steps:\n# For rand(read|write) fio benchmarks, running 15s does not overwhelm the system for tmpfs mounts.\n- <<: *benchmarks\nlabel: \":cd: FIO benchmarks (randrea... | Go | Apache License 2.0 | google/gvisor | Fix the runs to 1GB for rand write/read for the FIO benchmark.
PiperOrigin-RevId: 481178578 |
259,907 | 14.10.2022 11:24:22 | 25,200 | 0444ca8c9f0b5cda80f480df8ae57f9004712d0d | Make tensorflow benchmark order deterministic.
Makes it easier to compare output from different runs. Consistent
with what other benchmarks do. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/ml/tensorflow_test.go",
"new_path": "test/benchmarks/ml/tensorflow_test.go",
"diff": "@@ -26,15 +26,17 @@ import (\n// BenchmarkTensorflow runs workloads from a TensorFlow tutorial.\n// See: https://github.com/aymericdamien/TensorFlow-Examples\... | Go | Apache License 2.0 | google/gvisor | Make tensorflow benchmark order deterministic.
Makes it easier to compare output from different runs. Consistent
with what other benchmarks do.
PiperOrigin-RevId: 481192191 |
259,992 | 18.10.2022 14:44:57 | 25,200 | c6c38d5c4b35b5604e79d5b3da674d3e7ebb3b12 | Fix panic in lisafs
When mount fails, `filesystem.Release()` attempts to dereference a nil
`filesystem.clientLisa`. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"new_path": "pkg/sentry/fsimpl/gofer/gofer.go",
"diff": "@@ -743,11 +743,15 @@ func (fs *filesystem) Release(ctx context.Context) {\nif !fs.iopts.LeakConnection {\n// Close the connection to the server. This implicitly clunks... | Go | Apache License 2.0 | google/gvisor | Fix panic in lisafs
When mount fails, `filesystem.Release()` attempts to dereference a nil
`filesystem.clientLisa`.
PiperOrigin-RevId: 482027422 |
259,909 | 19.10.2022 09:45:20 | 25,200 | 5e2506ce0b281b05590ded6c34036043c203ad8b | Make buffer pooling true by default in runsc. | [
{
"change_type": "MODIFY",
"old_path": "runsc/config/flags.go",
"new_path": "runsc/config/flags.go",
"diff": "@@ -97,7 +97,7 @@ func RegisterFlags(flagSet *flag.FlagSet) {\nflagSet.Bool(\"rx-checksum-offload\", true, \"enable RX checksum offload.\")\nflagSet.Var(queueingDisciplinePtr(QDiscFIFO), \"q... | Go | Apache License 2.0 | google/gvisor | Make buffer pooling true by default in runsc.
PiperOrigin-RevId: 482229293 |
259,909 | 21.10.2022 12:53:23 | 25,200 | d4a7318c6be8dd907d1de50b0100f61b4a8ce778 | Fix tun reference counting.
The tun code does not properly abide by reference counting rules. Change it
so the ownership is more clear and to prevent potential use-after-free. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/devices/tundev/tundev.go",
"new_path": "pkg/sentry/devices/tundev/tundev.go",
"diff": "@@ -157,6 +157,7 @@ func (fd *tunFD) Write(ctx context.Context, src usermem.IOSequence, opts vfs.Wri\nreturn 0, unix.EMSGSIZE\n}\ndata := bufferv2.NewView(int(src... | Go | Apache License 2.0 | google/gvisor | Fix tun reference counting.
The tun code does not properly abide by reference counting rules. Change it
so the ownership is more clear and to prevent potential use-after-free.
PiperOrigin-RevId: 482865862 |
259,909 | 24.10.2022 16:58:12 | 25,200 | 2ec925ee25c59ffcce138c424bb540b55683486d | Create buffer pooling blog. | [
{
"change_type": "MODIFY",
"old_path": "website/_config.yml",
"new_path": "website/_config.yml",
"diff": "@@ -25,6 +25,10 @@ defaults:\nlayout: default\nanalytics: \"UA-150193582-1\"\nauthors:\n+ lucasmanning:\n+ name: Lucas Manning\n+ email: lucasmanning@google.com\n+ url: https://twitter.com/lucas... | Go | Apache License 2.0 | google/gvisor | Create buffer pooling blog.
PiperOrigin-RevId: 483522945 |
259,909 | 25.10.2022 11:19:45 | 25,200 | 84767a8f2388dde73c7e7be04e6f5ece91d183ab | Fix title in buffer pooling blog. | [
{
"change_type": "MODIFY",
"old_path": "website/blog/2022-10-24-buffer-pooling.md",
"new_path": "website/blog/2022-10-24-buffer-pooling.md",
"diff": "-\\# How we Eliminated 99% of gVisor Networking Memory Allocations with Enhanced\n-Buffer Pooling\n+# How we Eliminated 99% of gVisor Networking Memor... | Go | Apache License 2.0 | google/gvisor | Fix title in buffer pooling blog.
PiperOrigin-RevId: 483728986 |
259,992 | 25.10.2022 11:33:21 | 25,200 | 7e3bd4db0f6b9c70cb3f70471db3f6ff4cf20a9a | Add rudimentary UDS test to lisafs | [
{
"change_type": "MODIFY",
"old_path": "pkg/lisafs/testsuite/testsuite.go",
"new_path": "pkg/lisafs/testsuite/testsuite.go",
"diff": "@@ -77,6 +77,7 @@ var localFSTests = map[string]TestFunc{\n\"Walk\": testWalk,\n\"Rename\": testRename,\n\"Mknod\": testMknod,\n+ \"UDS\": testUDS,\n\"Getdents\": tes... | Go | Apache License 2.0 | google/gvisor | Add rudimentary UDS test to lisafs
PiperOrigin-RevId: 483732841 |
259,909 | 25.10.2022 14:30:33 | 25,200 | db4a71af39abddf01d6a7ff6f00314e0b88c8717 | Fix mount_util mountinfo parsing to account for multiple optional tags.
Before this change, the parsing fails with a PosixError saying the line
has too many entries. | [
{
"change_type": "MODIFY",
"old_path": "test/util/BUILD",
"new_path": "test/util/BUILD",
"diff": "@@ -164,6 +164,7 @@ cc_library(\n\"@com_google_absl//absl/container:flat_hash_map\",\n\"@com_google_absl//absl/strings\",\ngtest,\n+ \"@com_google_absl//absl/types:span\",\n],\n)\n"
},
{
"change... | Go | Apache License 2.0 | google/gvisor | Fix mount_util mountinfo parsing to account for multiple optional tags.
Before this change, the parsing fails with a PosixError saying the line
has too many entries.
PiperOrigin-RevId: 483777338 |
259,909 | 25.10.2022 17:38:31 | 25,200 | 2ee38d5b6d5672b5b52843d4d879fb7e61f98fe3 | Allow external packages to clone and set the propagation type of mounts. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/vfs2/mount.go",
"new_path": "pkg/sentry/syscalls/linux/vfs2/mount.go",
"diff": "@@ -91,7 +91,7 @@ func Mount(t *kernel.Task, args arch.SyscallArguments) (uintptr, *kernel.Syscall\nreturn 0, nil, linuxerr.EINVAL\n}\npropType := vfs.Pro... | Go | Apache License 2.0 | google/gvisor | Allow external packages to clone and set the propagation type of mounts.
PiperOrigin-RevId: 483821346 |
259,853 | 25.10.2022 21:42:58 | 25,200 | c1427a04dfba87bd2ebce767086b5351c725db25 | Disable fasync for signalfd descriptors
In Linux, signalfd doesn't support fasync events.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/signalfd/signalfd.go",
"new_path": "pkg/sentry/fsimpl/signalfd/signalfd.go",
"diff": "@@ -34,6 +34,7 @@ type SignalFileDescription struct {\nvfs.FileDescriptionDefaultImpl\nvfs.DentryMetadataFileDescriptionImpl\nvfs.NoLockFD\n+ vfs.NoAsyncEve... | Go | Apache License 2.0 | google/gvisor | Disable fasync for signalfd descriptors
In Linux, signalfd doesn't support fasync events.
Reported-by: syzbot+eeb463868529314bd733@syzkaller.appspotmail.com
PiperOrigin-RevId: 483861398 |
259,907 | 27.10.2022 10:43:31 | 25,200 | 32e4a28deaafa64209d54ec67984dc727194059e | Update docs to reference LISAFS instead of 9P. | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/filesystem.md",
"new_path": "g3doc/user_guide/filesystem.md",
"diff": "gVisor accesses the filesystem through a file proxy, called the Gofer. The gofer\nruns as a separate process, that is isolated from the sandbox. Gofer instances\n-communica... | Go | Apache License 2.0 | google/gvisor | Update docs to reference LISAFS instead of 9P.
PiperOrigin-RevId: 484293317 |
259,985 | 27.10.2022 14:55:21 | 25,200 | a1468b7a6240a1a99d448b557c64a47e49e4f45a | Let caller specify mount flags and the root dentry on CloneMount. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -371,7 +371,7 @@ func (vfs *VirtualFilesystem) preparePropagationTree(mnt *Mount, vd VirtualDentr\ndentry: vd.dentry,\n}\npeerVd.IncRef()\n- clone := vfs.cloneMount(mnt, mnt.root)\n+ ... | Go | Apache License 2.0 | google/gvisor | Let caller specify mount flags and the root dentry on CloneMount.
PiperOrigin-RevId: 484356760 |
259,909 | 28.10.2022 14:57:55 | 25,200 | 6b3b5493d0ea8eebcbe707ec1c3aac9374892d7a | Fix ipv6 header view ownership.
During ipv6 header processing, the packet can be released and
switched to a different fragment, but we still hold
the same ipv6 header bytes from the released packet.
This causes a use-after-free. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv6/BUILD",
"new_path": "pkg/tcpip/network/ipv6/BUILD",
"diff": "@@ -42,6 +42,7 @@ go_test(\n\"//pkg/bufferv2\",\n\"//pkg/refs\",\n\"//pkg/refsvfs2\",\n+ \"//pkg/sync\",\n\"//pkg/tcpip\",\n\"//pkg/tcpip/checker\",\n\"//pkg/tcpip/checksum\",\... | Go | Apache License 2.0 | google/gvisor | Fix ipv6 header view ownership.
During ipv6 header processing, the packet can be released and
switched to a different fragment, but we still hold
the same ipv6 header bytes from the released packet.
This causes a use-after-free.
PiperOrigin-RevId: 484627475 |
259,909 | 31.10.2022 14:51:31 | 25,200 | 20ef2127a1028363df8d056a7143c4d263544763 | Lock around optional tag generation.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -179,6 +179,17 @@ func (mnt *Mount) Options() MountOptions {\n}\n}\n+func (mnt *Mount) generateOptionalTags() string {\n+ mnt.vfs.mountMu.Lock()\n+ defer mnt.vfs.mountMu.Unlock()\n+ /... | Go | Apache License 2.0 | google/gvisor | Lock around optional tag generation.
Reported-by: syzbot+339e76d7c2c84cbd70c9@syzkaller.appspotmail.com
PiperOrigin-RevId: 485155018 |
259,985 | 31.10.2022 22:32:10 | 25,200 | d4b159ae93b57be0e9f296b8f0030005175de774 | iouring: Disallow zero, or less CQ entries than SQ entries
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"new_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"diff": "@@ -92,10 +92,11 @@ func New(ctx context.Context, vfsObj *vfs.VirtualFilesystem, entries uint32, par\n}\nvar numCqEntries uint32\nif params.Flags&linux.... | Go | Apache License 2.0 | google/gvisor | iouring: Disallow zero, or less CQ entries than SQ entries
Reported-by: syzbot+ad039a9d567cc9ba5ea8@syzkaller.appspotmail.com
PiperOrigin-RevId: 485230763 |
259,985 | 02.11.2022 09:41:49 | 25,200 | 254fedb1d69c02162b19c65219243098eeac0b1b | tmpfs: Handle symlink resolution at root
Previously we weren't resolving any links when walking a single
component path (i.e. the root of the FS was a symlink). | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/filesystem.go",
"diff": "@@ -133,6 +133,18 @@ func walkParentDirLocked(ctx context.Context, rp *vfs.ResolvingPath, d *dentry)\n// Preconditions: filesystem.mu must be locked.\nfunc re... | Go | Apache License 2.0 | google/gvisor | tmpfs: Handle symlink resolution at root
Previously we weren't resolving any links when walking a single
component path (i.e. the root of the FS was a symlink).
PiperOrigin-RevId: 485618692 |
259,975 | 02.11.2022 16:53:19 | 25,200 | af8fcbe7cdd2af71967d5f06c85f16620af528f3 | Add ARM64 image for grpc-build benchmark. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "images/benchmarks/build-grpc/Dockerfile.aarch64",
"diff": "+FROM ubuntu:18.04\n+\n+RUN set -x \\\n+ && apt-get update \\\n+ && apt-get install -y \\\n+ autoconf \\\n+ build-essential \\\n+ clang \\\n+ curl \\\n+ libtool \\\n+ pkg-config \\\n+ gi... | Go | Apache License 2.0 | google/gvisor | Add ARM64 image for grpc-build benchmark.
PiperOrigin-RevId: 485730449 |
259,992 | 03.11.2022 13:37:12 | 25,200 | b322d1cc5bde68711e2c8e69fbf0ded7a6a5c898 | Fix EPERM with OCI quick start
Fixes | [
{
"change_type": "MODIFY",
"old_path": "g3doc/user_guide/quick_start/oci.md",
"new_path": "g3doc/user_guide/quick_start/oci.md",
"diff": "@@ -19,8 +19,8 @@ Create a root file system for the container. We will use the Docker\n`hello-world` image as the basis for our container.\n```bash\n-mkdir rootfs... | Go | Apache License 2.0 | google/gvisor | Fix EPERM with OCI quick start
Fixes #8106
PiperOrigin-RevId: 485960462 |
259,853 | 03.11.2022 13:48:25 | 25,200 | 1497cdffce1fb35179c7da064ba654029ce6f859 | Add the context.PrepareSleep platform callback.
It is called only when a task switches to the interruptible sleep, because it
is the only state where the task can sleep for a long time. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_block.go",
"new_path": "pkg/sentry/kernel/task_block.go",
"diff": "@@ -189,6 +189,7 @@ func (t *Task) block(C <-chan struct{}, timerChan <-chan struct{}) error {\n// prepareSleep prepares to sleep.\nfunc (t *Task) prepareSleep() {\nt.ass... | Go | Apache License 2.0 | google/gvisor | Add the context.PrepareSleep platform callback.
It is called only when a task switches to the interruptible sleep, because it
is the only state where the task can sleep for a long time.
PiperOrigin-RevId: 485963460 |
259,992 | 03.11.2022 16:09:25 | 25,200 | 943eb50b0aecb8e0315449a537ce5962bb82a4af | Allow trace tests to run remotely | [
{
"change_type": "MODIFY",
"old_path": "test/trace/BUILD",
"new_path": "test/trace/BUILD",
"diff": "@@ -11,9 +11,6 @@ go_test(\n\"//test/trace/workload\",\n],\nlibrary = \":trace\",\n- tags = [\n- \"local\",\n- ],\ndeps = [\n\"//pkg/sentry/seccheck\",\n\"//pkg/sentry/seccheck/points:points_go_proto\... | Go | Apache License 2.0 | google/gvisor | Allow trace tests to run remotely
PiperOrigin-RevId: 485999272 |
259,992 | 03.11.2022 16:50:16 | 25,200 | 22a0b4acb20e40174ce4ff38cb3666a43ae72781 | Allow fsgofer to open character files
Closes | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -276,7 +276,7 @@ docker-tests: load-basic $(RUNTIME_BIN)\noverlay-tests: load-basic $(RUNTIME_BIN)\n@$(call install_runtime,$(RUNTIME),--overlay)\n- @$(call test_runtime,$(RUNTIME),$(INTEGRATION_TARGETS))\n+ @$(ca... | Go | Apache License 2.0 | google/gvisor | Allow fsgofer to open character files
Closes #7007
PiperOrigin-RevId: 486008125 |
259,986 | 04.11.2022 08:01:51 | 25,200 | b9b96522ef2b1376add5721bb6345042d9e335c5 | Increase SO_RCVTIMEO for RecvTimeoutWaitAll syscall test
The timeout is currently 200ms and causes occasionally flakes in Fuchsia infra
(https://fxbug.dev/112974). Increase it to 1s.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/socket_generic_test_cases.cc",
"new_path": "test/syscalls/linux/socket_generic_test_cases.cc",
"diff": "@@ -823,7 +823,7 @@ TEST_P(AllSocketPairTest, RecvTimeoutWaitAll) {\nauto sockets = ASSERT_NO_ERRNO_AND_VALUE(NewSocketPair());\nstruct ... | Go | Apache License 2.0 | google/gvisor | Increase SO_RCVTIMEO for RecvTimeoutWaitAll syscall test
The timeout is currently 200ms and causes occasionally flakes in Fuchsia infra
(https://fxbug.dev/112974). Increase it to 1s.
Fixes #8140
PiperOrigin-RevId: 486141423 |
259,868 | 04.11.2022 12:32:56 | 25,200 | 5b3d8659a0401bcea0453c17b34db7f1e29d6de6 | Use `runc` as default runtime for unsandboxed containers.
Without this, attempting to build or test gVisor on machines where the default
runtime isn't `runc` may fail, as that runtime may not support what we need. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -385,6 +385,7 @@ run_benchmark = \\\n($(call header,BENCHMARK $(1)); \\\nset -euo pipefail; \\\nexport T=$$(mktemp --tmpdir logs.$(1).XXXXXX); \\\n+ export UNSANDBOXED_RUNTIME; \\\nif test \"$(1)\" = \"runc\"; the... | Go | Apache License 2.0 | google/gvisor | Use `runc` as default runtime for unsandboxed containers.
Without this, attempting to build or test gVisor on machines where the default
runtime isn't `runc` may fail, as that runtime may not support what we need.
PiperOrigin-RevId: 486205081 |
259,868 | 04.11.2022 13:07:25 | 25,200 | 8400a3d40d064deeef347cc5df47af9101cdb44a | Label all benchmarks with tag `gvisor_benchmark`.
This makes it easy to list all the available benchmark targets with `bazel`. | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -347,8 +347,10 @@ containerd-tests: containerd-test-1.6.2\n## Benchmarks.\n##\n## Targets to run benchmarks. See //test/benchmarks for details.\n+## You can list all available benchmarks using:\n+## $ bazel query ... | Go | Apache License 2.0 | google/gvisor | Label all benchmarks with tag `gvisor_benchmark`.
This makes it easy to list all the available benchmark targets with `bazel`.
PiperOrigin-RevId: 486212679 |
259,868 | 04.11.2022 13:48:49 | 25,200 | 5e2f66189c1031c0f4abc08a462aabe9675a5ebf | Make all network benchmarks use container links.
This CL uses container links rather than going over the host network stack.
This avoids relying on that network stack, making the benchmarks more reliable,
and simplifies benchmark setup code.
#codehealth | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/base/base.go",
"new_path": "test/benchmarks/base/base.go",
"diff": "@@ -17,7 +17,6 @@ package base\nimport (\n\"context\"\n- \"net\"\n\"testing\"\n\"time\"\n@@ -48,15 +47,8 @@ func StartServers(ctx context.Context, b *testing.B, args ServerArgs... | Go | Apache License 2.0 | google/gvisor | Make all network benchmarks use container links.
This CL uses container links rather than going over the host network stack.
This avoids relying on that network stack, making the benchmarks more reliable,
and simplifies benchmark setup code.
#codehealth
PiperOrigin-RevId: 486221868 |
259,909 | 04.11.2022 15:38:35 | 25,200 | 1fc476d7feccff981d4c04e23df982149e47f356 | Return a new packet from fragment reassembly instead of an old one. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/internal/fragmentation/reassembler.go",
"new_path": "pkg/tcpip/network/internal/fragmentation/reassembler.go",
"diff": "@@ -167,7 +167,7 @@ func (r *reassembler) process(first, last uint16, more bool, proto uint8, pkt st\nreturn r.holes[i].fi... | Go | Apache License 2.0 | google/gvisor | Return a new packet from fragment reassembly instead of an old one.
PiperOrigin-RevId: 486246464 |
259,909 | 05.11.2022 14:06:55 | 25,200 | 7520b7f833a44a986edeb7ba916ff0309a8dcc67 | Modify pivot_root to return errors in cases of shared mounts.
This is in line with linux as described here | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -1121,11 +1121,20 @@ retry:\nif rootVd.mount.ns != ns || newRootVd.mount.ns != ns {\nreturn linuxerr.EINVAL\n}\n- // TODO(gvisor.dev/issues/221): Update this function to disallow\n- /... | Go | Apache License 2.0 | google/gvisor | Modify pivot_root to return errors in cases of shared mounts.
This is in line with linux as described here
https://man7.org/linux/man-pages/man2/pivot_root.2.html
PiperOrigin-RevId: 486388848 |
259,907 | 08.11.2022 08:56:13 | 28,800 | 7b169a1640dda2b4e5fcdc7f3dd286f4fdfa989f | Exclude failing java runtime tests.
I believe these tests rely on some certs which have now expired. | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/java17.csv",
"new_path": "test/runtimes/exclude/java17.csv",
"diff": "@@ -43,6 +43,8 @@ java/nio/channels/etc/PrintSupportedOptions.java,,\njava/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java,,Broken test\nja... | Go | Apache License 2.0 | google/gvisor | Exclude failing java runtime tests.
I believe these tests rely on some certs which have now expired.
PiperOrigin-RevId: 486964895 |
259,891 | 08.11.2022 11:54:48 | 28,800 | aaf5129c05ecdf1d013fbb51fc0edd0c0415ed39 | netstack: don't verify IPv4 checksum when offload is enabled
There's no reason to check it. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -835,7 +835,7 @@ func (e *endpoint) handleLocalPacket(pkt stack.PacketBufferPtr, canSkipRXChecksu\npkt = pkt.CloneToInbound()\ndefer pkt.DecRef()\n- pkt.RXTransportCheck... | Go | Apache License 2.0 | google/gvisor | netstack: don't verify IPv4 checksum when offload is enabled
There's no reason to check it.
PiperOrigin-RevId: 487012436 |
259,977 | 08.11.2022 13:21:43 | 28,800 | 21b9d59950cd78bbed15efa33ad0c425eee08747 | Increase timeout when polling for ICMP errors
We're seeing occasional flakes in CQ in which the ICMP error isn't received in
time. Double the timeout from 1s to 2s. | [
{
"change_type": "MODIFY",
"old_path": "test/syscalls/linux/udp_socket.cc",
"new_path": "test/syscalls/linux/udp_socket.cc",
"diff": "@@ -53,6 +53,8 @@ namespace testing {\nnamespace {\n+constexpr size_t kIcmpTimeout = 2000;\n+\n// Fixture for tests parameterized by the address family to use (AF_INE... | Go | Apache License 2.0 | google/gvisor | Increase timeout when polling for ICMP errors
We're seeing occasional flakes in CQ in which the ICMP error isn't received in
time. Double the timeout from 1s to 2s.
PiperOrigin-RevId: 487035507 |
259,848 | 08.11.2022 14:00:59 | 28,800 | a1476ce4f5ee04d40bdff4fad516022862a7d9c5 | io_uring_setup: fixing cqentries setup bug.
We should compare against maximum number of allowed cq entries instead of
comparing against the flag that allows to set that number. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"new_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"diff": "@@ -94,7 +94,7 @@ func New(ctx context.Context, vfsObj *vfs.VirtualFilesystem, entries uint32, par\nif params.Flags&linux.IORING_SETUP_CQSIZE != 0 {\nva... | Go | Apache License 2.0 | google/gvisor | io_uring_setup: fixing cqentries setup bug.
We should compare against maximum number of allowed cq entries instead of
comparing against the flag that allows to set that number.
PiperOrigin-RevId: 487045476 |
259,891 | 08.11.2022 14:40:40 | 28,800 | 70d7f5033f32338d99c94662c398338e375eb0dc | netstack: setup basic structure for GRO | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/BUILD",
"new_path": "pkg/tcpip/stack/BUILD",
"diff": "@@ -43,6 +43,7 @@ go_library(\nsrcs = [\n\"addressable_endpoint_state.go\",\n\"conntrack.go\",\n+ \"gro.go\",\n\"headertype_string.go\",\n\"hook_string.go\",\n\"icmp_rate_limit.go\",\n"
},... | Go | Apache License 2.0 | google/gvisor | netstack: setup basic structure for GRO
PiperOrigin-RevId: 487055867 |
259,909 | 08.11.2022 15:14:27 | 28,800 | 28bbe008214497e0e3f3c051e9c463bd0d7c8502 | Remove internal PoolingEnabled flag.
Pooling is known to be safe at this point. Removing the flags
will happen later to avoid breakage in experiments still using
them. | [
{
"change_type": "MODIFY",
"old_path": "pkg/bufferv2/chunk.go",
"new_path": "pkg/bufferv2/chunk.go",
"diff": "@@ -21,12 +21,6 @@ import (\n\"gvisor.dev/gvisor/pkg/sync\"\n)\n-// PoolingEnabled is set to true when pooling is enabled. Added as a\n-// global to allow easy access.\n-//\n-// TODO(b/23699... | Go | Apache License 2.0 | google/gvisor | Remove internal PoolingEnabled flag.
Pooling is known to be safe at this point. Removing the flags
will happen later to avoid breakage in experiments still using
them.
PiperOrigin-RevId: 487064491 |
259,891 | 08.11.2022 16:31:37 | 28,800 | 901d9a75d3163f630f1d0c45f9de7aa95f59252f | netstack: add gro_flush_timeout
Makes a per-interface file available to configure the GRO timeout, e.g.
/sys/class/net/eth0/gro_flush_timeout | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/sys/BUILD",
"new_path": "pkg/sentry/fsimpl/sys/BUILD",
"diff": "@@ -19,6 +19,7 @@ go_library(\nsrcs = [\n\"dir_refs.go\",\n\"kcov.go\",\n+ \"net.go\",\n\"sys.go\",\n],\nvisibility = [\"//pkg/sentry:internal\"],\n@@ -33,6 +34,7 @@ go_library(\... | Go | Apache License 2.0 | google/gvisor | netstack: add gro_flush_timeout
Makes a per-interface file available to configure the GRO timeout, e.g.
/sys/class/net/eth0/gro_flush_timeout
PiperOrigin-RevId: 487082821 |
259,891 | 08.11.2022 16:42:37 | 28,800 | 6db3ed9186aa5375b9b53b74af92285774e8833c | fix lint warnings in tcp_benchmark.sh | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"new_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -43,7 +43,7 @@ latency_variation=1 # +/- 1ms is a relatively low amount of jitter.\nloss=0.1 # 0.1% loss is non-zero, but not extremely high.\nduplicate=0.1 ... | Go | Apache License 2.0 | google/gvisor | fix lint warnings in tcp_benchmark.sh
PiperOrigin-RevId: 487085546 |
259,992 | 08.11.2022 17:10:12 | 28,800 | c57f7a79ebb4b703a90640c05745e936272bcacf | Add trace session option to ignore errors
This allows a configuration file with newer trace points and fields
to be used with an older runsc without failing (just skips the new
trace points and fields).
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/BUILD",
"new_path": "pkg/sentry/seccheck/BUILD",
"diff": "@@ -45,12 +45,14 @@ go_test(\nname = \"seccheck_test\",\nsize = \"small\",\nsrcs = [\n+ \"config_test.go\",\n\"metadata_test.go\",\n\"seccheck_test.go\",\n],\nlibrary = \":seccheck\"... | Go | Apache License 2.0 | google/gvisor | Add trace session option to ignore errors
This allows a configuration file with newer trace points and fields
to be used with an older runsc without failing (just skips the new
trace points and fields).
Updates #4805
PiperOrigin-RevId: 487091892 |
259,891 | 08.11.2022 17:34:01 | 28,800 | 434cdd398d291646ff7a85bcba20e3304a82b329 | netstack: add GRO flag
This allows for configuration of the GRO interval without modifying
gro_flush_timeout. In some setups, e.g. docker, sysfs is mounted as RO and thus
a flag is easier to work with. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/gro.go",
"new_path": "pkg/tcpip/stack/gro.go",
"diff": "@@ -30,10 +30,11 @@ type groDispatcher struct {\nstop chan struct{}\n}\n-func (gd *groDispatcher) init() {\n+func (gd *groDispatcher) init(interval time.Duration) {\n+ gd.intervalNS.Store(... | Go | Apache License 2.0 | google/gvisor | netstack: add GRO flag
This allows for configuration of the GRO interval without modifying
gro_flush_timeout. In some setups, e.g. docker, sysfs is mounted as RO and thus
a flag is easier to work with.
PiperOrigin-RevId: 487096047 |
259,891 | 09.11.2022 14:24:06 | 28,800 | 935f29ce6e42731d1cc8beaa7257d67debdf6451 | netstack: make GRO timeout configurable in tcp_benchmark
Also: don't turn of GRO when --disable-linux-gso is set. | [
{
"change_type": "MODIFY",
"old_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"new_path": "test/benchmarks/tcp/tcp_benchmark.sh",
"diff": "@@ -47,6 +47,7 @@ helper_dir=\"$(dirname \"$0\")\"\nnetstack_opts=\ndisable_linux_gso=\ndisable_linux_gro=\n+gro=0\nnum_client_threads=1\n# Check for netem supp... | Go | Apache License 2.0 | google/gvisor | netstack: make GRO timeout configurable in tcp_benchmark
Also: don't turn of GRO when --disable-linux-gso is set.
PiperOrigin-RevId: 487346882 |
259,909 | 09.11.2022 15:54:35 | 28,800 | e038ca2a1cbd8f15fa3fd30e3d8e9875500f390a | Fix ipv4 header ownership. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/network/ipv4/ipv4.go",
"new_path": "pkg/tcpip/network/ipv4/ipv4.go",
"diff": "@@ -22,6 +22,7 @@ import (\n\"time\"\n\"gvisor.dev/gvisor/pkg/atomicbitops\"\n+ \"gvisor.dev/gvisor/pkg/bufferv2\"\n\"gvisor.dev/gvisor/pkg/sync\"\n\"gvisor.dev/gvisor/pkg/... | Go | Apache License 2.0 | google/gvisor | Fix ipv4 header ownership.
PiperOrigin-RevId: 487369872 |
259,982 | 09.11.2022 16:11:22 | 28,800 | 68c47a2f88945da9eaaaea3aa573c09e013fa522 | Fixing checkSentryExec to account for symlinks as the test runs locally.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/trace/trace_test.go",
"new_path": "test/trace/trace_test.go",
"diff": "@@ -324,13 +324,15 @@ func checkSentryExec(msg test.Message) error {\nif err := checkContextData(p.ContextData); err != nil {\nreturn err\n}\n- if want := \"/bin/true\"; want != p.Bina... | Go | Apache License 2.0 | google/gvisor | Fixing checkSentryExec to account for symlinks as the test runs locally.
Updates #4805
PiperOrigin-RevId: 487374028 |
259,853 | 09.11.2022 20:38:22 | 28,800 | edc16b49e3b4302620231460f6155c3636ab9e51 | Set TSC offset directly.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/BUILD",
"new_path": "pkg/sentry/platform/kvm/BUILD",
"diff": "@@ -71,6 +71,7 @@ go_library(\n\"kvm_arm64.go\",\n\"kvm_arm64_unsafe.go\",\n\"kvm_const.go\",\n+ \"kvm_const_amd64.go\",\n\"kvm_const_arm64.go\",\n\"machine.go\",\n\"machine_... | Go | Apache License 2.0 | google/gvisor | Set TSC offset directly.
Fixes #8118
PiperOrigin-RevId: 487422035 |
259,907 | 10.11.2022 03:56:38 | 28,800 | 93b37dad70ea37c4b873fffa546de286c459df14 | Update gofer mount options to only show version for 9P. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"new_path": "pkg/sentry/fsimpl/gofer/filesystem.go",
"diff": "@@ -1898,7 +1898,6 @@ func (fs *filesystem) MountOptions() string {\n{moptDfltUID, fs.opts.dfltuid},\n{moptDfltGID, fs.opts.dfltgid},\n{moptMsize, fs.opts.msi... | Go | Apache License 2.0 | google/gvisor | Update gofer mount options to only show version for 9P.
PiperOrigin-RevId: 487493605 |
259,907 | 10.11.2022 10:59:50 | 28,800 | ae136df84998ea98f184f9136c71784d37cf4d09 | Add nil-check for parent mount in umount(2) while handling mount propagation. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/vfs/mount.go",
"new_path": "pkg/sentry/vfs/mount.go",
"diff": "@@ -654,7 +654,7 @@ func (vfs *VirtualFilesystem) UmountAt(ctx context.Context, creds *auth.Credenti\numountTree := []*Mount{vd.mount}\nparent, mountpoint := vd.mount.parent(), vd.mount.... | Go | Apache License 2.0 | google/gvisor | Add nil-check for parent mount in umount(2) while handling mount propagation.
PiperOrigin-RevId: 487585583 |
259,853 | 11.11.2022 00:33:51 | 28,800 | 5a0803c66ec4e080bbd72d1383a1ee5cc2a5d7ff | builtkite: collect runtime logs | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/hooks/post-command",
"new_path": ".buildkite/hooks/post-command",
"diff": "@@ -54,8 +54,12 @@ rm -rf \"${profile_output}\"\n# Clean the bazel cache, if there's failure.\nif test \"${BUILDKITE_COMMAND_EXIT_STATUS}\" -ne \"0\"; then\nset -x\n- if [ -d... | Go | Apache License 2.0 | google/gvisor | builtkite: collect runtime logs
PiperOrigin-RevId: 487748622 |
260,009 | 11.11.2022 09:17:30 | 28,800 | 8756ebc3b406e2f8ea43360902d8a6dfff391236 | Netstack: Check address matches the endpoint protocol for IP_DROP_MEMBERSHIP
According to syzkaller report, the setsockopt option used was 0x24, which
matches with IP_DROP_MEMBERSHIP for which we did not have the equivalent check
that we had for IP_ADD_MEMBERSHIP.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/tests/integration/multicast_broadcast_test.go",
"new_path": "pkg/tcpip/tests/integration/multicast_broadcast_test.go",
"diff": "@@ -817,11 +817,16 @@ func TestMismatchedMulticastAddressAndProtocol(t *testing.T) {\nInterfaceAddr: utils.Ipv4Addr.Addres... | Go | Apache License 2.0 | google/gvisor | Netstack: Check address matches the endpoint protocol for IP_DROP_MEMBERSHIP
According to syzkaller report, the setsockopt option used was 0x24, which
matches with IP_DROP_MEMBERSHIP for which we did not have the equivalent check
that we had for IP_ADD_MEMBERSHIP.
Reported-by: syzbot+923097b958e5b74950d1@syzkaller.appspotmail.com
PiperOrigin-RevId: 487840922 |
259,853 | 11.11.2022 09:36:43 | 28,800 | 4b63ff222d437f70369f08e486e59d7dec10b4d4 | kvm: handle errors of applyVirtualRegions | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"new_path": "pkg/sentry/platform/kvm/machine_amd64.go",
"diff": "@@ -445,7 +445,7 @@ func (c *vCPU) SwitchToUser(switchOpts ring0.SwitchOpts, info *linux.SignalInfo)\nfunc (m *machine) mapUpperHalf(pageTable *pagetabl... | Go | Apache License 2.0 | google/gvisor | kvm: handle errors of applyVirtualRegions
PiperOrigin-RevId: 487845220 |
259,907 | 14.11.2022 09:55:33 | 28,800 | c97edad873c3edeb16dc68a226007be48b512395 | Exclude broken java script DNS runtime tests.
These tests fail with runc too. Error:
```
Error: querySrv ENOTFOUND _jabber._tcp.google.com
at QueryReqWrap.onresolve [as oncomplete] (node:internal/dns/promises:173:17) {
errno: undefined,
code: 'ENOTFOUND',
syscall: 'querySrv',
hostname: '_jabber._tcp.google.com'
}
``` | [
{
"change_type": "MODIFY",
"old_path": "test/runtimes/exclude/nodejs16.13.2.csv",
"new_path": "test/runtimes/exclude/nodejs16.13.2.csv",
"diff": "@@ -2,6 +2,8 @@ test name,bug id,comment\nbenchmark/test-benchmark-napi.js,,Broken test\ninternet/test-dgram-multicast-ssm-multi-process.js,,\ninternet/te... | Go | Apache License 2.0 | google/gvisor | Exclude broken java script DNS runtime tests.
These tests fail with runc too. Error:
```
Error: querySrv ENOTFOUND _jabber._tcp.google.com
at QueryReqWrap.onresolve [as oncomplete] (node:internal/dns/promises:173:17) {
errno: undefined,
code: 'ENOTFOUND',
syscall: 'querySrv',
hostname: '_jabber._tcp.google.com'
}
```
PiperOrigin-RevId: 488394772 |
259,907 | 14.11.2022 12:05:46 | 28,800 | bd5e1d8f58991203725327c54f40bbf1fad9ab18 | Preserve environment when running sudo commands in make_apt.sh.
This is so that `DEBIAN_FRONTEND=noninteractive` env var which has been set
is in effect while running apt-get commands. | [
{
"change_type": "MODIFY",
"old_path": "tools/make_apt.sh",
"new_path": "tools/make_apt.sh",
"diff": "@@ -33,8 +33,8 @@ shift; shift; shift # For \"$@\" below.\nexport DEBIAN_FRONTEND=noninteractive\nfunction apt_install() {\nwhile true; do\n- sudo apt-get update &&\n- sudo apt-get install -y \"$@\"... | Go | Apache License 2.0 | google/gvisor | Preserve environment when running sudo commands in make_apt.sh.
This is so that `DEBIAN_FRONTEND=noninteractive` env var which has been set
is in effect while running apt-get commands.
PiperOrigin-RevId: 488432544 |
259,907 | 14.11.2022 12:46:17 | 28,800 | 3eff27293fbada75248111af4bcce75f86b1f6e9 | Remove testing for 9P.
LISAFS is now default.
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/runner/defs.bzl",
"new_path": "test/runner/defs.bzl",
"diff": "@@ -69,7 +69,6 @@ def _syscall_test(\nfile_access = \"exclusive\",\noverlay = False,\nadd_host_communication = False,\n- lisafs = True,\nfuse = False,\ncontainer = None,\none_sandbox = True,\n... | Go | Apache License 2.0 | google/gvisor | Remove testing for 9P.
LISAFS is now default.
Updates #7911
PiperOrigin-RevId: 488442569 |
259,975 | 14.11.2022 12:53:53 | 28,800 | cf13339a6ebe3854e27b149de40f46987967802f | Fix name in buildkite pipeline. | [
{
"change_type": "MODIFY",
"old_path": ".buildkite/pipeline.yaml",
"new_path": ".buildkite/pipeline.yaml",
"diff": "@@ -488,5 +488,5 @@ steps:\nlabel: \":gear: Syscall benchmarks\"\ncommand: make -i benchmark-platforms BENCHMARKS_SUITE=syscall BENCHMARKS_TARGETS=test/benchmarks/base:syscallbench_tes... | Go | Apache License 2.0 | google/gvisor | Fix name in buildkite pipeline.
PiperOrigin-RevId: 488444365 |
259,992 | 15.11.2022 11:51:50 | 28,800 | e6f019594e80e0987a12f103a03bca6a4e7138dd | Add read/write syscalls to trace points
Closes | [
{
"change_type": "MODIFY",
"old_path": "examples/seccheck/server.cc",
"new_path": "examples/seccheck/server.cc",
"diff": "@@ -113,6 +113,7 @@ std::vector<Callback> dispatchers = {\nunpackSyscall<::gvisor::syscall::InotifyAddWatch>,\nunpackSyscall<::gvisor::syscall::InotifyRmWatch>,\nunpackSyscall<::... | Go | Apache License 2.0 | google/gvisor | Add read/write syscalls to trace points
Closes #8092
PiperOrigin-RevId: 488719448 |
259,992 | 15.11.2022 11:55:37 | 28,800 | 258f27eedae2fd7ba7c1b2b0c2d829c4a6fef41e | Add tool to analyze stuck task dumps
It creates a histogram of all unique stacks in the dump.
Then prints them in order, marking the ones that were stuck. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "tools/stucktasks/BUILD",
"diff": "+load(\"//tools:defs.bzl\", \"go_binary\")\n+\n+package(licenses = [\"notice\"])\n+\n+go_binary(\n+ name = \"stucktasks\",\n+ srcs = [\"stucktasks.go\"],\n+ deps = [\n+ \"//runsc/flag\",\n+ ],\n+)\n"
},
{
... | Go | Apache License 2.0 | google/gvisor | Add tool to analyze stuck task dumps
It creates a histogram of all unique stacks in the dump.
Then prints them in order, marking the ones that were stuck.
PiperOrigin-RevId: 488720415 |
259,907 | 15.11.2022 13:13:20 | 28,800 | 7c3ff55fab59c13929442089fdcf96cbc98d2bb5 | Update fd_table_test to use VFS2.
This unit test had been using VFS1.
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/BUILD",
"new_path": "pkg/sentry/kernel/BUILD",
"diff": "@@ -387,13 +387,12 @@ go_test(\n\"//pkg/hostarch\",\n\"//pkg/sentry/arch\",\n\"//pkg/sentry/contexttest\",\n- \"//pkg/sentry/fs\",\n- \"//pkg/sentry/fs/filetest\",\n\"//pkg/sentry/kernel... | Go | Apache License 2.0 | google/gvisor | Update fd_table_test to use VFS2.
This unit test had been using VFS1.
Updates #1624
PiperOrigin-RevId: 488740255 |
259,985 | 15.11.2022 13:48:33 | 28,800 | 58c71d54fc063439fe6fdf1125d3b4a46cd31041 | Disable S/R while rapidly polling control files in cgroups tests.
This resulted in too many S/Rs and prevents tasks from being scheduled
and accumulating CPU time. | [
{
"change_type": "MODIFY",
"old_path": "test/util/cgroup_util.cc",
"new_path": "test/util/cgroup_util.cc",
"diff": "@@ -102,6 +102,11 @@ PosixError Cgroup::PollControlFileForChangeAfter(\nbody();\n+ // The loop below iterates quickly and results in too many save-restore\n+ // cycles. This can preven... | Go | Apache License 2.0 | google/gvisor | Disable S/R while rapidly polling control files in cgroups tests.
This resulted in too many S/Rs and prevents tasks from being scheduled
and accumulating CPU time.
PiperOrigin-RevId: 488748888 |
259,992 | 15.11.2022 14:25:04 | 28,800 | b4e810c944d8c8dc2a55484fb6f82d1ef26cbdb3 | Sort syscall trace points | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/metadata_amd64.go",
"new_path": "pkg/sentry/seccheck/metadata_amd64.go",
"diff": "package seccheck\n+// init registers syscall trace points metadata.\n+// Keep them sorted by syscall number.\nfunc init() {\naddSyscallPoint(0, \"read\", []Fi... | Go | Apache License 2.0 | google/gvisor | Sort syscall trace points
PiperOrigin-RevId: 488758795 |
259,853 | 15.11.2022 14:46:27 | 28,800 | 374e716c7ce29304b05b59adcb0360b3942bb4c7 | AddSeals has to take the write lock to modify seals
Reported-by:
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"new_path": "pkg/sentry/fsimpl/tmpfs/regular_file.go",
"diff": "@@ -778,8 +778,8 @@ func AddSeals(fd *vfs.FileDescription, val uint32) error {\nrf := f.inode().impl.(*regularFile)\nrf.mapsMu.Lock()\ndefer rf.mapsMu.Unl... | Go | Apache License 2.0 | google/gvisor | AddSeals has to take the write lock to modify seals
Reported-by: syzbot+355993d42d99b011ea73@syzkaller.appspotmail.com
Reported-by: syzbot+f758f7983773e0a60c7b@syzkaller.appspotmail.com
PiperOrigin-RevId: 488764524 |
259,885 | 15.11.2022 14:58:19 | 28,800 | 9f351c68ca1dd8a184c9508d6cd849fd173119f0 | Allow SO_BROADCAST through hostinet.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/socket/hostinet/socket.go",
"new_path": "pkg/sentry/socket/hostinet/socket.go",
"diff": "@@ -383,7 +383,7 @@ func (s *socketOpsCommon) GetSockOpt(t *kernel.Task, level int, name int, optVal\n}\ncase linux.SOL_SOCKET:\nswitch name {\n- case linux.SO_... | Go | Apache License 2.0 | google/gvisor | Allow SO_BROADCAST through hostinet.
Fixes #8090
PiperOrigin-RevId: 488767693 |
259,907 | 16.11.2022 08:23:17 | 28,800 | 681c7ddd5a811a5eb687b8f7d646c89cd6b62a8d | Add docker test for external UDS connect.
Serves as a regression test for
Our unit tests didn't catch the issue because they run runsc with the flag
TESTONLY-unsafe-nonroot. Docker tests are more e2e, they run tests in Docker
containers.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "Makefile",
"new_path": "Makefile",
"diff": "@@ -268,9 +268,9 @@ INTEGRATION_TARGETS := //test/image:image_test //test/e2e:integration_test\ndocker-tests: load-basic $(RUNTIME_BIN)\n@$(call install_runtime,$(RUNTIME),) # Clear flags.\n- # Used by TestRlimitNoFi... | Go | Apache License 2.0 | google/gvisor | Add docker test for external UDS connect.
Serves as a regression test for #8126.
Our unit tests didn't catch the issue because they run runsc with the flag
-TESTONLY-unsafe-nonroot. Docker tests are more e2e, they run tests in Docker
containers.
Fixes #8126
PiperOrigin-RevId: 488945922 |
259,982 | 16.11.2022 16:47:26 | 28,800 | 84548b78935a8ad39e76a219d8be0fd552770180 | Adding check to ensure containerIDs are unique in multi-container mode. | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/control/lifecycle.go",
"new_path": "pkg/sentry/control/lifecycle.go",
"diff": "@@ -303,6 +303,11 @@ func (l *Lifecycle) StartContainer(args *StartContainerArgs, _ *uint32) error {\nif l.containerMap == nil {\nl.containerMap = make(map[string]*Contai... | Go | Apache License 2.0 | google/gvisor | Adding check to ensure containerIDs are unique in multi-container mode.
PiperOrigin-RevId: 489073573 |
259,982 | 16.11.2022 17:03:32 | 28,800 | dec1aed1435fc0ed8a844d2fd0c0890f1e9315fd | Adding more trace point integration tests for the following syscalls:
Chdir
Fchdir
Setgid
Setuid
Setsid
Setresuid
Setresgid
Updates | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/seccheck/points/syscall.proto",
"new_path": "pkg/sentry/seccheck/points/syscall.proto",
"diff": "@@ -121,9 +121,9 @@ message Setresid {\ngvisor.common.ContextData context_data = 1;\nExit exit = 2;\nuint64 sysno = 3;\n- uint32 rgid = 4;\n- uint32 egi... | Go | Apache License 2.0 | google/gvisor | Adding more trace point integration tests for the following syscalls:
- Chdir
- Fchdir
- Setgid
- Setuid
- Setsid
- Setresuid
- Setresgid
Updates #4805
PiperOrigin-RevId: 489076929 |
259,985 | 17.11.2022 10:15:15 | 28,800 | f3aaf4326636caf934e811cb7e41e7873fe945b9 | io_ring: Handle EOF on IORING_OP_READV
EOFs shouldn't be raised as an errno as error translation will
fail. Short reads aren't failures on a readv syscall.
Reported-by: | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"new_path": "pkg/sentry/fsimpl/iouringfs/iouringfs.go",
"diff": "@@ -24,6 +24,7 @@ package iouringfs\nimport (\n\"fmt\"\n+ \"io\"\n\"sync\"\n\"gvisor.dev/gvisor/pkg/abi/linux\"\n@@ -382,6 +383,11 @@ func (fd *FileDesc... | Go | Apache License 2.0 | google/gvisor | io_ring: Handle EOF on IORING_OP_READV
EOFs shouldn't be raised as an errno as error translation will
fail. Short reads aren't failures on a readv syscall.
Reported-by: syzbot+37fc0fc0df42740a5cea@syzkaller.appspotmail.com
PiperOrigin-RevId: 489242631 |
259,992 | 17.11.2022 12:27:22 | 28,800 | 5ce359a6ebf838773131e1e81618add32b2adaa1 | Add option to list only sandboxes
This is required for setting up trace sessions on running sandboxes.
Currently, `runsc list` lists all containers and there is no way to
find out the sandbox ID for them.
Fixes | [
{
"change_type": "MODIFY",
"old_path": "runsc/cmd/BUILD",
"new_path": "runsc/cmd/BUILD",
"diff": "@@ -87,6 +87,7 @@ go_test(\n\"exec_test.go\",\n\"gofer_test.go\",\n\"install_test.go\",\n+ \"list_test.go\",\n\"mitigate_test.go\",\n],\ndata = [\n"
},
{
"change_type": "MODIFY",
"old_path":... | Go | Apache License 2.0 | google/gvisor | Add option to list only sandboxes
This is required for setting up trace sessions on running sandboxes.
Currently, `runsc list` lists all containers and there is no way to
find out the sandbox ID for them.
Fixes #8210
PiperOrigin-RevId: 489278285 |
259,975 | 17.11.2022 13:48:19 | 28,800 | 106f6ea967467ae195e03979dba4f82c9e3cdf30 | Re-enable process_vm_(read|write)v | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/kernel/task_usermem.go",
"new_path": "pkg/sentry/kernel/task_usermem.go",
"diff": "@@ -347,16 +347,28 @@ func (cc *taskCopyContext) CopyScratchBuffer(size int) []byte {\n}\nfunc (cc *taskCopyContext) getMemoryManager() (*mm.MemoryManager, error) {\n... | Go | Apache License 2.0 | google/gvisor | Re-enable process_vm_(read|write)v
PiperOrigin-RevId: 489298284 |
259,982 | 18.11.2022 11:45:57 | 28,800 | 536a924f1abc556a6f905855059cca7f7d511be5 | Adding more trace point integration tests for the following syscalls:
- chroot
- dup
- dup2
- dup3
- prlimit64
- eventfd
- eventfd2
- bind
- accept
- accept4
Updates | [
{
"change_type": "MODIFY",
"old_path": "test/trace/trace_test.go",
"new_path": "test/trace/trace_test.go",
"diff": "@@ -75,7 +75,7 @@ func TestAll(t *testing.T) {\ncutoffTime = time.Now()\ncmd := exec.Command(\nrunsc,\n- \"--debug\", \"--strace\", \"--alsologtostderr\", // Debug logging for troubles... | Go | Apache License 2.0 | google/gvisor | Adding more trace point integration tests for the following syscalls:
- chroot
- dup
- dup2
- dup3
- prlimit64
- eventfd
- eventfd2
- bind
- accept
- accept4
Updates #4805
PiperOrigin-RevId: 489526376 |
259,975 | 18.11.2022 16:08:19 | 28,800 | 38a0512f13faa7d013d85c9eb85bdd993b08c28a | Fix circular lock in process_vm_(read|write)v | [
{
"change_type": "MODIFY",
"old_path": "pkg/sentry/syscalls/linux/sys_process_vm.go",
"new_path": "pkg/sentry/syscalls/linux/sys_process_vm.go",
"diff": "@@ -23,6 +23,15 @@ import (\n\"gvisor.dev/gvisor/pkg/usermem\"\n)\n+type vmReadWriteOp int\n+\n+const (\n+ localReader vmReadWriteOp = iota\n+ loc... | Go | Apache License 2.0 | google/gvisor | Fix circular lock in process_vm_(read|write)v
PiperOrigin-RevId: 489582978 |
259,891 | 21.11.2022 13:54:57 | 28,800 | 9ff1c425909ed1de53cbfd2755e98110001a3ed1 | gro: actually decref packets
Also improves performance since we're not leaking memory and allocating as
much. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/gro.go",
"new_path": "pkg/tcpip/stack/gro.go",
"diff": "@@ -295,6 +295,7 @@ func (gd *groDispatcher) dispatch(pkt PacketBufferPtr, netProto tcpip.NetworkPro\nif flushGROPkt {\n// Flush the existing GRO packet.\nep.HandlePacket(groPkt.pkt)\n+ gr... | Go | Apache License 2.0 | google/gvisor | gro: actually decref packets
Also improves performance since we're not leaking memory and allocating as
much.
PiperOrigin-RevId: 490064348 |
259,891 | 21.11.2022 16:41:18 | 28,800 | 346aa6fef27da0689e84f5f4969328a705c5d56c | gro: change global lock to per-bucket
This will reduce contention with multiple TCP flows. | [
{
"change_type": "MODIFY",
"old_path": "pkg/tcpip/stack/gro.go",
"new_path": "pkg/tcpip/stack/gro.go",
"diff": "@@ -50,24 +50,33 @@ const (\n// A groBucket holds packets that are undergoing GRO.\ntype groBucket struct {\n+ // mu protects the fields of a bucket.\n+ mu sync.Mutex\n+\n// count is the n... | Go | Apache License 2.0 | google/gvisor | gro: change global lock to per-bucket
This will reduce contention with multiple TCP flows.
PiperOrigin-RevId: 490101814 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.