author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 28.09.2021 16:18:20 | 14,400 | db733f8e76dc7a2c9879fcccb53249aa1fae0959 | [landing] Make tiles "responsive"
Summary:
Stop hardcoding tile size and make them responsive
Snuck in a few related font size tweaks etc
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -18,23 +18,25 @@ function AppLanding(): React.Node {\n<img height={600} src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1>Comm Messenger</h1>\n- <p className={css.mono}>Web3 Messenger. E2E encrypted. Blah..</p>\n+ <h1 className={css.no_bottom_margin}>Comm Messenger</h1>\n+ <p className={css.app_landing_subheading}>\n+ Web3 Messenger. E2E encrypted. Blah..\n+ </p>\n<div className={css.tile_grid}>\n<div className={css.tile_tl}>\n- <FontAwesomeIcon color=\"#7e57c2\" icon={faLock} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#7e57c2\" icon={faLock} />\n<p>E2E Encryption</p>\n</div>\n<div className={css.tile_tr}>\n- <FontAwesomeIcon color=\"#7e57c2\" icon={faServer} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#7e57c2\" icon={faServer} />\n<p>Self-hosted</p>\n</div>\n<div className={css.tile_bl}>\n- <FontAwesomeIcon color=\"#7e57c2\" icon={faUsers} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#7e57c2\" icon={faUsers} />\n<p>Federated</p>\n</div>\n<div className={css.tile_br}>\n- <FontAwesomeIcon color=\"#7e57c2\" icon={faUserShield} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#7e57c2\" icon={faUserShield} />\n<p>Sovereign Identity</p>\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -23,6 +23,10 @@ a {\nfont-weight: 500;\n}\n+.no_bottom_margin {\n+ margin-bottom: 0;\n+}\n+\n/* ===== TEXT STYLES ===== */\nh1 {\nfont-size: 58px;\n@@ -45,6 +49,13 @@ li {\nline-height: 1.6em;\n}\n+p.app_landing_subheading {\n+ background-color: #7e57c2;\n+ margin-top: 0;\n+ font-family: 'IBM Plex Mono', monospace;\n+ font-weight: 500;\n+}\n+\nspan.purple_accent {\ncolor: #7e57c2;\n}\n@@ -182,9 +193,8 @@ div.tile_grid {\ndisplay: grid;\ngrid-template-columns: 1fr 1fr;\ngrid-template-rows: 1fr 1fr;\n- max-width: 17vw;\n- row-gap: 1vw;\n- column-gap: 1vw;\n+ row-gap: 1em;\n+ column-gap: 1em;\npadding-top: 40px;\npadding-bottom: 40px;\ngrid-template-areas:\n@@ -197,8 +207,7 @@ div.tile_tr,\ndiv.tile_bl,\ndiv.tile_br {\ndisplay: flex;\n- width: 8vw;\n- height: 8vw;\n+ padding: 24px;\nborder-radius: 36px;\nbackground-image: linear-gradient(120deg, #fdfbfb 0%, #ebedee 100%);\njustify-content: center;\n@@ -211,9 +220,11 @@ div.tile_tr p,\ndiv.tile_bl p,\ndiv.tile_br p {\nfont-weight: bold;\n- font-size: 12px;\n+ font-size: 20px;\ncolor: #485563;\ntext-align: center;\n+ margin-top: 10px;\n+ margin-bottom: 0;\n}\ndiv.tile_tl {\n@@ -393,6 +404,18 @@ div.body_grid > div + .starting_section {\ntext-align: center;\n}\n+ div.tile_tl p,\n+ div.tile_tr p,\n+ div.tile_bl p,\n+ div.tile_br p {\n+ font-weight: bold;\n+ font-size: 16px;\n+ color: #485563;\n+ text-align: center;\n+ margin-top: 8px;\n+ margin-bottom: 0;\n+ }\n+\n/* ===== LAYOUT HACKS ===== */\n.section {\npadding-top: 20px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make tiles "responsive"
Summary:
Stop hardcoding tile size and make them responsive
Snuck in a few related font size tweaks etc
Test Plan:
Before: https://blob.sh/atul/unresponsive_tiles.mov
After: https://blob.sh/atul/responsive_tiles.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2086 |
129,184 | 28.09.2021 17:10:52 | 14,400 | b6e8abb748fd54e8c8575315b0a5a4f698a0cc06 | [landing] Have tiles change color on "hover"
Summary: Invert colors on hover
Test Plan:
Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -209,12 +209,20 @@ div.tile_br {\ndisplay: flex;\npadding: 24px;\nborder-radius: 36px;\n- background-image: linear-gradient(120deg, #fdfbfb 0%, #ebedee 100%);\n+ background-color: #ebedee;\njustify-content: center;\nalign-items: center;\nflex-direction: column;\n}\n+div.tile_tl:hover,\n+div.tile_tr:hover,\n+div.tile_bl:hover,\n+div.tile_br:hover {\n+ background-color: #7e57c2;\n+ transition: 300ms;\n+}\n+\ndiv.tile_tl p,\ndiv.tile_tr p,\ndiv.tile_bl p,\n@@ -227,6 +235,18 @@ div.tile_br p {\nmargin-bottom: 0;\n}\n+div.tile_tl:hover p,\n+div.tile_tr:hover p,\n+div.tile_bl:hover p,\n+div.tile_br:hover p,\n+div.tile_tl:hover svg,\n+div.tile_tr:hover svg,\n+div.tile_bl:hover svg,\n+div.tile_br:hover svg {\n+ color: #ebedee;\n+ transition: 300ms;\n+}\n+\ndiv.tile_tl {\ngrid-area: tile_tl;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Have tiles change color on "hover"
Summary: Invert colors on hover
Test Plan:
Here's how it looks:
https://blob.sh/atul/hover.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2087 |
129,184 | 28.09.2021 18:33:58 | 14,400 | 7fcb6cac733d6cba5dd772d61bcc4ec7ac3d08f1 | [landing] Add Twitter/GitHub social tiles to `AppLandingPage`
Summary:
Add social FontAwesome icons to `package.json`
Add Twitter and GitHub icons to bottom row of "tiles"
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "// @flow\n+import { faTwitter, faGithub } from '@fortawesome/free-brands-svg-icons';\nimport {\nfaLock,\nfaUserShield,\n@@ -39,6 +40,16 @@ function AppLanding(): React.Node {\n<FontAwesomeIcon size=\"2x\" color=\"#7e57c2\" icon={faUserShield} />\n<p>Sovereign Identity</p>\n</div>\n+ <a href=\"https://twitter.com/commdotapp\">\n+ <div className={css.tile_twtr}>\n+ <FontAwesomeIcon size=\"2x\" color=\"#1d9bf0\" icon={faTwitter} />\n+ </div>\n+ </a>\n+ <a href=\"https://github.com/CommE2E/comm\">\n+ <div className={css.tile_gh}>\n+ <FontAwesomeIcon size=\"2x\" color=\"#151013\" icon={faGithub} />\n+ </div>\n+ </a>\n</div>\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -200,13 +200,16 @@ div.tile_grid {\npadding-bottom: 40px;\ngrid-template-areas:\n'tile_tl tile_tr'\n- 'tile_bl tile_br';\n+ 'tile_bl tile_br'\n+ 'tile_twtr tile_gh';\n}\ndiv.tile_tl,\ndiv.tile_tr,\ndiv.tile_bl,\n-div.tile_br {\n+div.tile_br,\n+div.tile_twtr,\n+div.tile_gh {\ndisplay: flex;\npadding: 24px;\nborder-radius: 36px;\n@@ -214,6 +217,22 @@ div.tile_br {\njustify-content: center;\nalign-items: center;\nflex-direction: column;\n+ transition: 300ms;\n+}\n+\n+div.tile_twtr,\n+div.tile_gh {\n+ padding: 16px;\n+}\n+\n+div.tile_twtr:hover {\n+ background-color: #1d9bf0;\n+ transition: 300ms;\n+}\n+\n+div.tile_gh:hover {\n+ background-color: #151013;\n+ transition: 300ms;\n}\ndiv.tile_tl:hover,\n@@ -234,6 +253,7 @@ div.tile_br p {\ntext-align: center;\nmargin-top: 10px;\nmargin-bottom: 0;\n+ transition: 300ms;\n}\ndiv.tile_tl:hover p,\n@@ -243,7 +263,9 @@ div.tile_br:hover p,\ndiv.tile_tl:hover svg,\ndiv.tile_tr:hover svg,\ndiv.tile_bl:hover svg,\n-div.tile_br:hover svg {\n+div.tile_br:hover svg,\n+div.tile_twtr:hover svg,\n+div.tile_gh:hover svg {\ncolor: #ebedee;\ntransition: 300ms;\n}\n@@ -260,6 +282,12 @@ div.tile_bl {\ndiv.tile_br {\ngrid-area: tile_br;\n}\n+div.tile_twtr {\n+ grid-area: tile_twtr;\n+}\n+div.tile_gh {\n+ grid-area: tile_gh;\n+}\n/* ===== LEGAL PAGE STYLING ===== */\ndiv.legal_container {\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"@fortawesome/fontawesome-svg-core\": \"^1.2.25\",\n\"@fortawesome/free-regular-svg-icons\": \"^5.11.2\",\n\"@fortawesome/free-solid-svg-icons\": \"^5.11.2\",\n+ \"@fortawesome/free-brands-svg-icons\": \"^5.15.4\",\n\"@fortawesome/react-fontawesome\": \"^0.1.5\",\n\"@lottiefiles/lottie-interactivity\": \"^0.1.4\",\n\"@lottiefiles/lottie-player\": \"^1.0.3\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "resolved \"https://registry.yarnpkg.com/@fortawesome/fontawesome-common-types/-/fontawesome-common-types-0.2.25.tgz#6df015905081f2762e5cfddeb7a20d2e9b16c786\"\nintegrity sha512-3RuZPDuuPELd7RXtUqTCfed14fcny9UiPOkdr2i+cYxBoTOfQgxcDoq77fHiiHcgWuo1LoBUpvGxFF1H/y7s3Q==\n+\"@fortawesome/fontawesome-common-types@^0.2.36\":\n+ version \"0.2.36\"\n+ resolved \"https://registry.yarnpkg.com/@fortawesome/fontawesome-common-types/-/fontawesome-common-types-0.2.36.tgz#b44e52db3b6b20523e0c57ef8c42d315532cb903\"\n+ integrity sha512-a/7BiSgobHAgBWeN7N0w+lAhInrGxksn13uK7231n2m8EDPE3BMCl9NZLTGrj9ZXfCmC6LM0QLqXidIizVQ6yg==\n+\n\"@fortawesome/fontawesome-svg-core@^1.2.25\":\nversion \"1.2.25\"\nresolved \"https://registry.yarnpkg.com/@fortawesome/fontawesome-svg-core/-/fontawesome-svg-core-1.2.25.tgz#24b03391d14f0c6171e8cad7057c687b74049790\"\ndependencies:\n\"@fortawesome/fontawesome-common-types\" \"^0.2.25\"\n+\"@fortawesome/free-brands-svg-icons@^5.15.4\":\n+ version \"5.15.4\"\n+ resolved \"https://registry.yarnpkg.com/@fortawesome/free-brands-svg-icons/-/free-brands-svg-icons-5.15.4.tgz#ec8a44dd383bcdd58aa7d1c96f38251e6fec9733\"\n+ integrity sha512-f1witbwycL9cTENJegcmcZRYyawAFbm8+c6IirLmwbbpqz46wyjbQYLuxOc7weXFXfB7QR8/Vd2u5R3q6JYD9g==\n+ dependencies:\n+ \"@fortawesome/fontawesome-common-types\" \"^0.2.36\"\n+\n\"@fortawesome/free-regular-svg-icons@^5.11.2\":\nversion \"5.11.2\"\nresolved \"https://registry.yarnpkg.com/@fortawesome/free-regular-svg-icons/-/free-regular-svg-icons-5.11.2.tgz#6edfc5c230094be3b9070fef048c01aa321a8428\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add Twitter/GitHub social tiles to `AppLandingPage`
Summary:
- Add social FontAwesome icons to `package.json`
- Add Twitter and GitHub icons to bottom row of "tiles"
Test Plan: Here's how it looks: https://blob.sh/atul/social_tiles.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2089 |
129,184 | 29.09.2021 09:00:44 | 14,400 | de236dedb1354ca97b71dd61ea171583ff3ef5d3 | [landing] Handle app screenshot dimensions/scaling in CSS
Summary: Instead of hard-coding dimensions, set in CSS and use `object-fit: scale-down`
Test Plan: Here's how the scaling looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -16,7 +16,7 @@ function AppLanding(): React.Node {\nreturn (\n<div className={css.app_landing_grid}>\n<div className={css.app_preview}>\n- <img height={600} src=\"images/comm-screenshot.png\" />\n+ <img src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n<h1 className={css.no_bottom_margin}>Comm Messenger</h1>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -183,6 +183,12 @@ div.app_preview {\njustify-self: right;\n}\n+div.app_preview img {\n+ width: 480px;\n+ max-width: 100%;\n+ object-fit: scale-down;\n+}\n+\ndiv.app_copy {\ngrid-area: app_copy;\nalign-self: center;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Handle app screenshot dimensions/scaling in CSS
Summary: Instead of hard-coding dimensions, set in CSS and use `object-fit: scale-down`
Test Plan: Here's how the scaling looks: https://blob.sh/atul/screenshot_object_fit.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2091 |
129,184 | 29.09.2021 13:11:45 | 14,400 | 12cdd4463f674dcb1ec0b987d5f6486d90197d02 | [landing] Replace `placeholder` in `Header` with Twitter/GitHub social buttons
Summary:
Remove `placeholder` (was an email icon that did nothing)
Add GitHub/Twitter Links
(Will remove Twitter/GitHub tiles in next diff)
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "// @flow\n-import { faEnvelope } from '@fortawesome/free-solid-svg-icons';\n+import { faTwitter, faGithub } from '@fortawesome/free-brands-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { Link } from 'react-router-dom';\n@@ -32,10 +32,17 @@ function Header(props: HeaderProps): React.Node {\n<h1>Keyservers</h1>\n</Link>\n</div>\n- <div className={css.placeholder}>\n- <Link to=\"/\">\n- <FontAwesomeIcon size=\"lg\" color=\"#7e57c2\" icon={faEnvelope} />\n- </Link>\n+ <div className={css.social_icons}>\n+ <a href=\"https://twitter.com/commdotapp\">\n+ <div className={css.twitter_icon}>\n+ <FontAwesomeIcon size=\"lg\" color=\"#1d9bf0\" icon={faTwitter} />\n+ </div>\n+ </a>\n+ <a href=\"https://github.com/CommE2E/comm\">\n+ <div className={css.github_icon}>\n+ <FontAwesomeIcon size=\"lg\" color=\"#151013\" icon={faGithub} />\n+ </div>\n+ </a>\n</div>\n</div>\n</>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -77,7 +77,7 @@ div.header_grid {\n/* ===== CSS HEADER GRID LAYOUT ===== */\ndiv.header_grid {\ngrid-template-columns: 1fr 1fr 1fr;\n- grid-template-areas: 'logo top_nav placeholder';\n+ grid-template-areas: 'logo top_nav social_icons';\n}\ndiv.header_legal {\n@@ -121,31 +121,41 @@ div.top_nav a:hover {\ntext-decoration-thickness: 2px;\n}\n-div.placeholder {\n- grid-area: placeholder;\n+div.social_icons {\n+ grid-area: social_icons;\nalign-self: center;\n-\ndisplay: flex;\n- flex-direction: column;\n+ flex-direction: row;\njustify-self: flex-end;\n+}\n+\n+div.twitter_icon:hover svg,\n+div.github_icon:hover svg {\n+ color: #ebedee;\n+}\n+\n+div.twitter_icon h1,\n+div.github_icon h1 {\n+ font-size: 32px;\n+}\n+div.twitter_icon,\n+div.github_icon {\n+ margin-inline: 8px;\npadding: 16px;\nborder-radius: 36px;\nbackground-color: #ebedee;\ntransition: 300ms;\n}\n-div.placeholder:hover {\n- background-color: #7e57c2;\n+div.twitter_icon:hover {\n+ background-color: #1d9bf0;\ntransition: 300ms;\n}\n-div.placeholder:hover svg {\n- color: #ebedee;\n-}\n-\n-div.placeholder h1 {\n- font-size: 32px;\n+div.github_icon:hover {\n+ background-color: #151013;\n+ transition: 300ms;\n}\n/* ===== CSS BODY GRID LAYOUT ===== */\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace `placeholder` in `Header` with Twitter/GitHub social buttons
Summary:
- Remove `placeholder` (was an email icon that did nothing)
- Add GitHub/Twitter Links
(Will remove Twitter/GitHub tiles in next diff)
Test Plan: Here's what it looks like: https://blob.sh/atul/844a.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2095 |
129,184 | 29.09.2021 13:38:33 | 14,400 | f186a81230790a678cf4e4d54720d6c15d8fecd7 | [landing] Change color of `Header` links on hover instead of underline
Summary: Instead of underline to indicate active page/hover, we'll go with white/gray like the sitemap
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -113,12 +113,11 @@ div.top_nav h1 {\nfont-size: 16px;\n}\ndiv.top_nav a {\n- color: white;\n+ color: #8a8f98;\n}\ndiv.top_nav a:hover {\n- text-decoration: underline;\n- text-decoration-thickness: 2px;\n+ color: white;\n}\ndiv.social_icons {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Change color of `Header` links on hover instead of underline
Summary: Instead of underline to indicate active page/hover, we'll go with white/gray like the sitemap
Test Plan: Here's what it looks like: https://blob.sh/atul/0ae4.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2097 |
129,184 | 29.09.2021 14:29:26 | 14,400 | 696a7a42bd01b95c5e178391bd49c7e741234a7a | [landing] Make `Header` "responsive"
Summary: CSS grid/etc changes to better layout `Header` on smaller devices
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -109,9 +109,11 @@ div.top_nav {\nflex-direction: row;\njustify-content: space-evenly;\n}\n+\ndiv.top_nav h1 {\nfont-size: 16px;\n}\n+\ndiv.top_nav a {\ncolor: #8a8f98;\n}\n@@ -460,7 +462,30 @@ div.body_grid > div + .starting_section {\n/* ===== CSS HEADER GRID LAYOUT ===== */\ndiv.header_grid {\n- grid-template-areas: 'logo';\n+ grid-template-columns: 1fr 1fr;\n+ grid-template-areas:\n+ 'logo social_icons'\n+ 'top_nav top_nav';\n+ }\n+\n+ div.top_nav {\n+ grid-area: top_nav;\n+ display: flex;\n+ flex-direction: row;\n+ justify-content: flex-start;\n+ align-self: flex-start;\n+ }\n+ div.top_nav h1 {\n+ margin-right: 16px;\n+ }\n+\n+ div.twitter_icon,\n+ div.github_icon {\n+ margin-inline: 4px;\n+ padding: 10px;\n+ border-radius: 36px;\n+ background-color: #ebedee;\n+ transition: 300ms;\n}\n/* ===== CSS BODY GRID LAYOUT ===== */\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make `Header` "responsive"
Summary: CSS grid/etc changes to better layout `Header` on smaller devices
Test Plan:
Before: https://blob.sh/atul/landing_header_before.png
After: https://blob.sh/atul/landing_header_after.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2098 |
129,184 | 29.09.2021 13:24:29 | 14,400 | bb9a85ea6f7a04dbee55f9e5e34b95302005eaf3 | [landing] Remove Twitter/GitHub "tiles"
Summary: Now that the Twitter/GitHub icons "live" in the `Header`, they can be removed from the grid of tiles.
Test Plan:
Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "// @flow\n-import { faTwitter, faGithub } from '@fortawesome/free-brands-svg-icons';\nimport {\nfaLock,\nfaUserShield,\n@@ -40,16 +39,6 @@ function AppLanding(): React.Node {\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faUserShield} />\n<p>Sovereign Identity</p>\n</div>\n- <a href=\"https://twitter.com/commdotapp\">\n- <div className={css.tile_twtr}>\n- <FontAwesomeIcon size=\"2x\" color=\"#1d9bf0\" icon={faTwitter} />\n- </div>\n- </a>\n- <a href=\"https://github.com/CommE2E/comm\">\n- <div className={css.tile_gh}>\n- <FontAwesomeIcon size=\"2x\" color=\"#151013\" icon={faGithub} />\n- </div>\n- </a>\n</div>\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -270,16 +270,13 @@ div.tile_grid {\npadding-bottom: 40px;\ngrid-template-areas:\n'tile_tl tile_tr'\n- 'tile_bl tile_br'\n- 'tile_twtr tile_gh';\n+ 'tile_bl tile_br';\n}\ndiv.tile_tl,\ndiv.tile_tr,\ndiv.tile_bl,\n-div.tile_br,\n-div.tile_twtr,\n-div.tile_gh {\n+div.tile_br {\ndisplay: flex;\npadding: 24px;\nborder-radius: 36px;\n@@ -290,21 +287,6 @@ div.tile_gh {\ntransition: 300ms;\n}\n-div.tile_twtr,\n-div.tile_gh {\n- padding: 16px;\n-}\n-\n-div.tile_twtr:hover {\n- background-color: #1d9bf0;\n- transition: 300ms;\n-}\n-\n-div.tile_gh:hover {\n- background-color: #151013;\n- transition: 300ms;\n-}\n-\ndiv.tile_tl:hover,\ndiv.tile_tr:hover,\ndiv.tile_bl:hover,\n@@ -333,9 +315,7 @@ div.tile_br:hover p,\ndiv.tile_tl:hover svg,\ndiv.tile_tr:hover svg,\ndiv.tile_bl:hover svg,\n-div.tile_br:hover svg,\n-div.tile_twtr:hover svg,\n-div.tile_gh:hover svg {\n+div.tile_br:hover svg {\ncolor: #ebedee;\ntransition: 300ms;\n}\n@@ -352,12 +332,6 @@ div.tile_bl {\ndiv.tile_br {\ngrid-area: tile_br;\n}\n-div.tile_twtr {\n- grid-area: tile_twtr;\n-}\n-div.tile_gh {\n- grid-area: tile_gh;\n-}\n/* ===== LEGAL PAGE STYLING ===== */\ndiv.legal_container {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Remove Twitter/GitHub "tiles"
Summary: Now that the Twitter/GitHub icons "live" in the `Header`, they can be removed from the grid of tiles.
Test Plan:
Here's what it looks like:
https://blob.sh/atul/18dc.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2104 |
129,184 | 29.09.2021 14:39:20 | 14,400 | 3dc40fedb0ff4dd24a9795e15404db9e217406eb | [landing] Make `app_landing_grid` vertical padding "responsive"
Summary: na
Test Plan: Ensured it looked as expected at each breakpoint
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -236,8 +236,8 @@ div.subscribe_updates {\ndiv.app_landing_grid {\ngrid-template-columns: 1fr 1fr;\ngrid-template-areas: 'app_preview app_copy';\n- padding-top: 80px;\n- padding-bottom: 240px;\n+ padding-top: 6vh;\n+ padding-bottom: 8vh;\n}\ndiv.app_preview {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make `app_landing_grid` vertical padding "responsive"
Summary: na
Test Plan: Ensured it looked as expected at each breakpoint
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2105 |
129,184 | 30.09.2021 14:45:17 | 14,400 | 1c4cb54c888c3cf5826d02db78ad183d9610095a | [landing] Rename "Comm Messenger" tab to "App" in `Header`
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -26,7 +26,7 @@ function Header(props: HeaderProps): React.Node {\n</div>\n<div className={css.top_nav}>\n<Link to=\"/\">\n- <h1>Comm Messenger</h1>\n+ <h1>App</h1>\n</Link>\n<Link to=\"/keyservers\">\n<h1>Keyservers</h1>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Rename "Comm Messenger" tab to "App" in `Header`
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2107 |
129,184 | 30.09.2021 15:25:04 | 14,400 | 429fec8e61acbdce023db399f51b404a24d1a094 | [landing] Indicate active tab in `Header`
Summary: Color the active tab white and inactive tab(s) gray.
Test Plan:
Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -6,12 +6,14 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport css from './landing.css';\n+import type { LandingPageName } from './landing.react';\n-export type HeaderProps = {\n+type HeaderProps = {\n+isLegalPage: boolean,\n+ +activePageName: LandingPageName,\n};\nfunction Header(props: HeaderProps): React.Node {\n- const { isLegalPage } = props;\n+ const { isLegalPage, activePageName } = props;\nconst headerStyle = isLegalPage\n? `${css.header_grid} ${css.header_legal}`\n@@ -25,13 +27,27 @@ function Header(props: HeaderProps): React.Node {\n</Link>\n</div>\n<div className={css.top_nav}>\n+ <div\n+ className={\n+ activePageName === 'app' ? css.active_tab : css.inactive_tab\n+ }\n+ >\n<Link to=\"/\">\n<h1>App</h1>\n</Link>\n+ </div>\n+ <div\n+ className={\n+ activePageName === 'keyservers'\n+ ? css.active_tab\n+ : css.inactive_tab\n+ }\n+ >\n<Link to=\"/keyservers\">\n<h1>Keyservers</h1>\n</Link>\n</div>\n+ </div>\n<div className={css.social_icons}>\n<a href=\"https://twitter.com/commdotapp\">\n<div className={css.twitter_icon}>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -114,8 +114,14 @@ div.top_nav h1 {\nfont-size: 16px;\n}\n-div.top_nav a {\n+div.active_tab a {\n+ color: white;\n+ transition: 300ms;\n+}\n+\n+div.inactive_tab a {\ncolor: #8a8f98;\n+ transition: 300ms;\n}\ndiv.top_nav a:hover {\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -11,6 +11,15 @@ import Privacy from './privacy.react';\nimport Support from './support.react';\nimport Terms from './terms.react';\n+export type LandingPageName =\n+ | 'app'\n+ | 'keyservers'\n+ | 'privacy'\n+ | 'terms'\n+ | 'support';\n+\n+type ActivePage = { name: LandingPageName, node: React.Node };\n+\nfunction Landing(): React.Node {\nconst { pathname } = useLocation();\nReact.useEffect(() => {\n@@ -26,24 +35,25 @@ function Landing(): React.Node {\n[onPrivacy, onSupport, onTerms],\n);\n- const activeNode = React.useMemo(() => {\n+ const activePage: ActivePage = React.useMemo(() => {\nif (onPrivacy) {\n- return <Privacy />;\n+ return { name: 'privacy', node: <Privacy /> };\n} else if (onTerms) {\n- return <Terms />;\n+ return { name: 'terms', node: <Terms /> };\n} else if (onSupport) {\n- return <Support />;\n+ return { name: 'support', node: <Support /> };\n} else if (onKeyservers) {\n- return <Keyservers />;\n+ return { name: 'keyservers', node: <Keyservers /> };\n+ } else {\n+ return { name: 'app', node: <AppLanding /> };\n}\n- return <AppLanding />;\n}, [onKeyservers, onPrivacy, onSupport, onTerms]);\nreturn (\n<>\n- <Header isLegalPage={isLegalPage} />\n+ <Header isLegalPage={isLegalPage} activePageName={activePage.name} />\n- {activeNode}\n+ {activePage.node}\n<Footer />\n</>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Indicate active tab in `Header`
Summary: Color the active tab white and inactive tab(s) gray.
Test Plan:
Here's what it looks like:
https://blob.sh/atul/header_active_tab.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2106 |
129,184 | 30.09.2021 16:35:00 | 14,400 | 92b0998288a6f105baf7a59e6ad88fd998a2aa1c | [landing] Indicate active tab in `Footer` sitemap
Summary: Make active page link white in `Footer` sitemap
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -4,9 +4,14 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport css from './landing.css';\n+import type { LandingPageName } from './landing.react';\nimport SubscriptionForm from './subscription-form.react';\n-function Footer(): React.Node {\n+type FooterProps = {\n+ +activePageName: LandingPageName,\n+};\n+function Footer(props: FooterProps): React.Node {\n+ const { activePageName } = props;\nreturn (\n<div className={css.footer_blur}>\n<div className={css.footer_grid}>\n@@ -14,14 +19,47 @@ function Footer(): React.Node {\n<div className={css.footer_logo}>\n<Link to=\"/\">Comm</Link>\n</div>\n+\n+ <div\n+ className={\n+ activePageName === 'keyservers'\n+ ? css.active_tab\n+ : css.inactive_tab\n+ }\n+ >\n<Link to=\"/keyservers\">Keyservers</Link>\n+ </div>\n+\n+ <div\n+ className={\n+ activePageName === 'support' ? css.active_tab : css.inactive_tab\n+ }\n+ >\n<Link to=\"/support\">Support</Link>\n+ </div>\n+\n+ <div\n+ className={\n+ activePageName === 'terms' ? css.active_tab : css.inactive_tab\n+ }\n+ >\n<Link to=\"/terms\">Terms of Use</Link>\n+ </div>\n+\n+ <div\n+ className={\n+ activePageName === 'privacy' ? css.active_tab : css.inactive_tab\n+ }\n+ >\n<Link to=\"/privacy\">Privacy Policy</Link>\n+ </div>\n+\n+ <div className={css.inactive_tab}>\n<a href=\"https://www.notion.so/How-Comm-works-d6217941db7c4237b9d08b427aef3234\">\nHow Comm works\n</a>\n</div>\n+ </div>\n<div className={css.subscribe_updates}>\n<SubscriptionForm />\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -213,14 +213,22 @@ div.footer_grid {\ndiv.sitemap {\ngrid-area: sitemap;\n}\n+\ndiv.sitemap a {\ndisplay: block;\npadding-bottom: 4px;\n- color: #8a8f98;\nwidth: max-content;\n}\n-div.sitemap > a:hover {\n+\n+div.sitemap a.active_tab,\n+div.sitemap a:hover {\ncolor: white;\n+ transition: 300ms;\n+}\n+\n+div.sitemap a.inactive_tab {\n+ color: #8a8f98;\n+ transition: 300ms;\n}\ndiv.footer_logo a {\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -55,7 +55,7 @@ function Landing(): React.Node {\n{activePage.node}\n- <Footer />\n+ <Footer activePageName={activePage.name} />\n</>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Indicate active tab in `Footer` sitemap
Summary: Make active page link white in `Footer` sitemap
Test Plan: Here's what it looks like: https://blob.sh/atul/5332.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2109 |
129,184 | 30.09.2021 18:36:51 | 14,400 | f2a656e75b2a519b6e657a41ca9df22f688de5d5 | [landing] Fix `Header` tab margin at smallest breakpoint
Summary:
Before:
After:
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -463,8 +463,10 @@ div.body_grid > div + .starting_section {\njustify-content: flex-start;\nalign-self: flex-start;\n}\n- div.top_nav h1 {\n- margin-right: 16px;\n+\n+ div.active_tab,\n+ div.inactive_tab {\n+ margin-right: 10px;\n}\ndiv.twitter_icon,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix `Header` tab margin at smallest breakpoint
Summary:
Before: https://blob.sh/atul/before_tab_margin_fix.png
After: https://blob.sh/atul/after_tab_margin_fix.png
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2111 |
129,190 | 04.10.2021 11:13:20 | -7,200 | f38f3643ed1638bf230f2ec42b9e41aeccb9b5ec | [services] Improve folder structure for grpc server
Summary: As discussed [here](https://www.notion.so/commapp/Directory-structure-for-the-grpc-docker-server-808e45ba87f8458c84c6f171d30d21a6) I improved the folder structure making it more clear and flat.
Test Plan: check that `cd services && yarn run-grpc-server` still works
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"private\": true,\n\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n- \"run-grpc-server\": \"cd .. && ./services/tunnelbroker/run.sh && ./services/tunnelbroker/grpc-server/run.sh --overwrite\"\n+ \"run-grpc-server\": \"cd .. && ./services/tunnelbroker/docker-base/run.sh && ./services/tunnelbroker/docker-server/run.sh --overwrite\"\n}\n}\n"
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/transferred/build_and_run_server.sh",
"new_path": "services/tunnelbroker/contents/build_and_run_server.sh",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/transferred/install_grpc.sh",
"new_path": "services/tunnelbroker/contents/install_grpc.sh",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/transferred/server/CMakeLists.txt",
"new_path": "services/tunnelbroker/contents/server/CMakeLists.txt",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/transferred/server/build.sh",
"new_path": "services/tunnelbroker/contents/server/build.sh",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/transferred/server/generate.sh",
"new_path": "services/tunnelbroker/contents/server/generate.sh",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/transferred/server/src/server.cpp",
"new_path": "services/tunnelbroker/contents/server/src/server.cpp",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/Dockerfile",
"new_path": "services/tunnelbroker/docker-base/Dockerfile",
"diff": "@@ -3,7 +3,7 @@ FROM ubuntu:20.04\nENV DEBIAN_FRONTEND=noninteractive\nENV SHELL=/bin/bash\n-COPY services/tunnelbroker/grpc-server/transferred /transferred\n+COPY services/tunnelbroker/contents /transferred\nRUN apt update -y &&\\\napt install -y cmake git build-essential autoconf libtool pkg-config libboost-all-dev libfmt-dev &&\\\n"
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/run.sh",
"new_path": "services/tunnelbroker/docker-base/run.sh",
"diff": "@@ -23,5 +23,5 @@ then\necho \"docker rmi $(echo $IMAGES_IDS)\"\nelse\necho \"Creating a new image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/Dockerfile .\n+ docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/docker-base/Dockerfile .\nfi\n"
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/Dockerfile",
"new_path": "services/tunnelbroker/docker-server/Dockerfile",
"diff": "@@ -3,7 +3,7 @@ FROM tunnelbroker-base:1.0\nENV DEBIAN_FRONTEND=noninteractive\nENV SHELL=/bin/bash\n-COPY services/tunnelbroker/grpc-server/transferred /transferred\n+COPY services/tunnelbroker/contents /transferred\nCOPY native/cpp/CommonCpp/grpc/protos /transferred/server/protos\nCMD /transferred/build_and_run_server.sh && /bin/bash\n"
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/grpc-server/run.sh",
"new_path": "services/tunnelbroker/docker-server/run.sh",
"diff": "@@ -24,7 +24,7 @@ then\ndocker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\ndocker rmi $IMAGE_NAME:$VERSION\n- docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/grpc-server/Dockerfile .\n+ docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/docker-server/Dockerfile .\ndocker run -it -p 50051:50051 $IMAGE_NAME:$VERSION\nelse\necho \"A new one will not be created, the current one will be used.\"\n@@ -36,6 +36,6 @@ then\nfi\nelse\necho \"Creating a new container for image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/grpc-server/Dockerfile .\n+ docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/docker-server/Dockerfile .\ndocker run -it -p 50051:50051 $IMAGE_NAME:$VERSION\nfi\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Improve folder structure for grpc server
Summary: As discussed [here](https://www.notion.so/commapp/Directory-structure-for-the-grpc-docker-server-808e45ba87f8458c84c6f171d30d21a6) I improved the folder structure making it more clear and flat.
Test Plan: check that `cd services && yarn run-grpc-server` still works
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2103 |
129,190 | 04.10.2021 12:53:35 | -7,200 | 1698a80c39a75796d5ebd313ba136bc5e35232b9 | [native] Move jsi generated code to the `_generated` directory
Summary: in response to
Test Plan: build
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "#include \"../CryptoTools/CryptoModule.h\"\n#include \"../Tools/CommSecureStore.h\"\n#include \"../Tools/WorkerThread.h\"\n+#include \"../_generated/NativeModules.h\"\n#include \"../grpc/Client.h\"\n-#include \"NativeModules.h\"\n#include <jsi/jsi.h>\n#include <memory>\n"
},
{
"change_type": "RENAME",
"old_path": "native/cpp/CommonCpp/NativeModules/NativeModules.cpp",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "native/cpp/CommonCpp/NativeModules/NativeModules.h",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "71BE84372636A944002849D2 /* CommonCpp */ = {\nisa = PBXGroup;\nchildren = (\n+ 71F971B4270726C000DDC5BF /* _generated */,\n718A3C0426F22BD100F04A8D /* grpc */,\n71BF5B6A26B3FCFF00EDE27D /* CryptoTools */,\n71BE84382636A944002849D2 /* Tools */,\n71BE843A2636A944002849D2 /* NativeModules */ = {\nisa = PBXGroup;\nchildren = (\n- 71BE843B2636A944002849D2 /* NativeModules.cpp */,\n71BE843C2636A944002849D2 /* CommCoreModule.cpp */,\n- 71BE843D2636A944002849D2 /* NativeModules.h */,\n71BE843E2636A944002849D2 /* CommCoreModule.h */,\nB7055C6B26E477CF00BE0548 /* MessageStoreOperations.h */,\n);\npath = CryptoTools;\nsourceTree = \"<group>\";\n};\n+ 71F971B4270726C000DDC5BF /* _generated */ = {\n+ isa = PBXGroup;\n+ children = (\n+ 71BE843D2636A944002849D2 /* NativeModules.h */,\n+ 71BE843B2636A944002849D2 /* NativeModules.cpp */,\n+ );\n+ path = _generated;\n+ sourceTree = \"<group>\";\n+ };\n7FF0870B1E833C3F000A1ACF /* Frameworks */ = {\nisa = PBXGroup;\nchildren = (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Move jsi generated code to the `_generated` directory
Summary: in response to https://www.notion.so/commapp/Move-files-generated-by-react-native-codegen-to-_generated-directory-3796e6403a3d4f418a8f22fd4293fd9e
Test Plan: build
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2113 |
129,184 | 04.10.2021 08:57:07 | 14,400 | e4f89c2e39601f3c0adbd0638cf603c31adeac12 | [CommCoreModule] `void virtual` -> `virtual void`
Summary: Super minor refactor, caught this inconsistency when reviewing
Test Plan: Builds successfully (Xcode)
Reviewers: ashoat, karol-bisztyga, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h",
"new_path": "native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h",
"diff": "@@ -11,7 +11,7 @@ public:\nMessageStoreOperationBase() = default;\nvirtual ~MessageStoreOperationBase() = default;\n- void virtual execute() = 0;\n+ virtual void execute() = 0;\n};\nclass RemoveMessagesOperation : public MessageStoreOperationBase {\n@@ -20,7 +20,7 @@ public:\n}\nvirtual ~RemoveMessagesOperation() = default;\n- void virtual execute() override {\n+ virtual void execute() override {\nDatabaseManager::getQueryExecutor().removeMessages(ids_);\n}\n@@ -34,7 +34,7 @@ public:\n}\nvirtual ~RemoveMessagesForThreadsOperation() = default;\n- void virtual execute() override {\n+ virtual void execute() override {\nDatabaseManager::getQueryExecutor().removeMessagesForThreads(ids_);\n}\n@@ -49,7 +49,7 @@ public:\n}\nvirtual ~ReplaceMessageOperation() = default;\n- void virtual execute() override {\n+ virtual void execute() override {\nfor (Media &media : media_vector_) {\nDatabaseManager::getQueryExecutor().replaceMedia(media);\n}\n@@ -68,7 +68,7 @@ public:\n}\nvirtual ~RekeyMessageOperation() = default;\n- void virtual execute() override {\n+ virtual void execute() override {\nDatabaseManager::getQueryExecutor().rekeyMessage(from_, to_);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] `void virtual` -> `virtual void`
Summary: Super minor refactor, @karol-bisztyga caught this inconsistency when reviewing https://phabricator.ashoat.com/D2078
Test Plan: Builds successfully (Xcode)
Reviewers: ashoat, karol-bisztyga, palys-swm
Reviewed By: ashoat, karol-bisztyga
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2121 |
129,184 | 04.10.2021 11:25:22 | 14,400 | 0661ce4de6dd8669fc4b3f714517df104c1645e6 | [landing] Make social icons more subtle
Summary: Change social icon styling based on feedback
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -51,12 +51,12 @@ function Header(props: HeaderProps): React.Node {\n<div className={css.social_icons}>\n<a href=\"https://twitter.com/commdotapp\">\n<div className={css.twitter_icon}>\n- <FontAwesomeIcon size=\"lg\" color=\"#1d9bf0\" icon={faTwitter} />\n+ <FontAwesomeIcon size=\"lg\" color=\"#ebedee\" icon={faTwitter} />\n</div>\n</a>\n<a href=\"https://github.com/CommE2E/comm\">\n<div className={css.github_icon}>\n- <FontAwesomeIcon size=\"lg\" color=\"#151013\" icon={faGithub} />\n+ <FontAwesomeIcon size=\"lg\" color=\"#ebedee\" icon={faGithub} />\n</div>\n</a>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -136,11 +136,6 @@ div.social_icons {\njustify-self: flex-end;\n}\n-div.twitter_icon:hover svg,\n-div.github_icon:hover svg {\n- color: #ebedee;\n-}\n-\ndiv.twitter_icon h1,\ndiv.github_icon h1 {\nfont-size: 32px;\n@@ -151,17 +146,24 @@ div.github_icon {\nmargin-inline: 8px;\npadding: 16px;\nborder-radius: 36px;\n+ transition: 300ms;\n+}\n+div.twitter_icon:hover,\n+div.github_icon:hover {\nbackground-color: #ebedee;\ntransition: 300ms;\n}\n-div.twitter_icon:hover {\n- background-color: #1d9bf0;\n+div.twitter_icon svg,\n+div.github_icon svg {\ntransition: 300ms;\n}\n-\n-div.github_icon:hover {\n- background-color: #151013;\n+div.twitter_icon:hover svg {\n+ color: #1d9bf0;\n+ transition: 300ms;\n+}\n+div.github_icon:hover svg {\n+ color: #151013;\ntransition: 300ms;\n}\n@@ -474,7 +476,6 @@ div.body_grid > div + .starting_section {\nmargin-inline: 4px;\npadding: 10px;\nborder-radius: 36px;\n- background-color: #ebedee;\ntransition: 300ms;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Make social icons more subtle
Summary: Change social icon styling based on feedback
Test Plan: Here's what it looks like: https://blob.sh/atul/subtle_social_icons.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2122 |
129,184 | 03.10.2021 19:17:35 | 14,400 | 2ffe6b670b5a8f9d7d0e7bda95d12c837a50792f | [CommCoreModule] Make `*MessageOperation` member variables `const`
Summary: Modify `*MessageOperation` classes to have `const` member variables
Test Plan: Successfully built in XCode
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -33,9 +33,9 @@ public:\nvirtual void removeMessages(std::vector<std::string> ids) const = 0;\nvirtual void\nremoveMessagesForThreads(std::vector<std::string> threadIDs) const = 0;\n- virtual void replaceMessage(Message &message) const = 0;\n+ virtual void replaceMessage(const Message &message) const = 0;\nvirtual void rekeyMessage(std::string from, std::string to) const = 0;\n- virtual void replaceMedia(Media &media) const = 0;\n+ virtual void replaceMedia(const Media &media) const = 0;\nvirtual void beginTransaction() const = 0;\nvirtual void commitTransaction() const = 0;\nvirtual void rollbackTransaction() const = 0;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -333,7 +333,7 @@ void SQLiteQueryExecutor::removeMessagesForThreads(\nwhere(in(&Media::thread, threadIDs)));\n}\n-void SQLiteQueryExecutor::replaceMessage(Message &message) const {\n+void SQLiteQueryExecutor::replaceMessage(const Message &message) const {\nSQLiteQueryExecutor::getStorage().replace(message);\n}\n@@ -344,7 +344,7 @@ void SQLiteQueryExecutor::rekeyMessage(std::string from, std::string to) const {\nSQLiteQueryExecutor::getStorage().remove<Message>(from);\n}\n-void SQLiteQueryExecutor::replaceMedia(Media &media) const {\n+void SQLiteQueryExecutor::replaceMedia(const Media &media) const {\nSQLiteQueryExecutor::getStorage().replace(media);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h",
"diff": "@@ -26,9 +26,9 @@ public:\nvoid removeMessages(std::vector<std::string> ids) const override;\nvoid\nremoveMessagesForThreads(std::vector<std::string> threadIDs) const override;\n- void replaceMessage(Message &message) const override;\n+ void replaceMessage(const Message &message) const override;\nvoid rekeyMessage(std::string from, std::string to) const override;\n- void replaceMedia(Media &media) const override;\n+ void replaceMedia(const Media &media) const override;\nvoid beginTransaction() const override;\nvoid commitTransaction() const override;\nvoid rollbackTransaction() const override;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h",
"new_path": "native/cpp/CommonCpp/NativeModules/MessageStoreOperations.h",
"diff": "@@ -25,7 +25,7 @@ public:\n}\nprivate:\n- std::vector<std::string> ids_;\n+ const std::vector<std::string> ids_;\n};\nclass RemoveMessagesForThreadsOperation : public MessageStoreOperationBase {\n@@ -39,7 +39,7 @@ public:\n}\nprivate:\n- std::vector<std::string> ids_;\n+ const std::vector<std::string> ids_;\n};\nclass ReplaceMessageOperation : public MessageStoreOperationBase {\n@@ -50,15 +50,15 @@ public:\nvirtual ~ReplaceMessageOperation() = default;\nvirtual void execute() override {\n- for (Media &media : media_vector_) {\n+ for (const Media &media : media_vector_) {\nDatabaseManager::getQueryExecutor().replaceMedia(media);\n}\nDatabaseManager::getQueryExecutor().replaceMessage(msg_);\n}\nprivate:\n- Message msg_;\n- std::vector<Media> media_vector_;\n+ const Message msg_;\n+ const std::vector<Media> media_vector_;\n};\nclass RekeyMessageOperation : public MessageStoreOperationBase {\n@@ -73,8 +73,8 @@ public:\n}\nprivate:\n- std::string from_;\n- std::string to_;\n+ const std::string from_;\n+ const std::string to_;\n};\n} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Make `*MessageOperation` member variables `const`
Summary: Modify `*MessageOperation` classes to have `const` member variables
Test Plan: Successfully built in XCode
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2117 |
129,184 | 04.10.2021 14:19:39 | 14,400 | 46f06f698ea6b88cd7084a126ca177717ed2c9c9 | [landing] Indicate that "How Comm works" entry in sitemap is external link
Summary: Add external link icon next to "How Comm works" entry in sitemap that links to Notion page
Test Plan: Looks as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "// @flow\n+import { faExternalLinkSquareAlt } from '@fortawesome/free-solid-svg-icons';\n+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { Link } from 'react-router-dom';\n@@ -56,7 +58,12 @@ function Footer(props: FooterProps): React.Node {\n<div className={css.inactive_tab}>\n<a href=\"https://www.notion.so/How-Comm-works-d6217941db7c4237b9d08b427aef3234\">\n- How Comm works\n+ How Comm works{' '}\n+ <FontAwesomeIcon\n+ size=\"sm\"\n+ color=\"#ffffff\"\n+ icon={faExternalLinkSquareAlt}\n+ />\n</a>\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -223,12 +223,14 @@ div.sitemap a {\n}\ndiv.sitemap a.active_tab,\n-div.sitemap a:hover {\n+div.sitemap a:hover,\n+div.sitemap a:hover svg {\ncolor: white;\ntransition: 300ms;\n}\n-div.sitemap a.inactive_tab {\n+div.sitemap .inactive_tab,\n+div.sitemap .inactive_tab svg {\ncolor: #8a8f98;\ntransition: 300ms;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Indicate that "How Comm works" entry in sitemap is external link
Summary: Add external link icon next to "How Comm works" entry in sitemap that links to Notion page
Test Plan: Looks as expected: https://blob.sh/atul/a1de.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2123 |
129,184 | 04.10.2021 16:26:50 | 14,400 | 493da15be9fb6d40685337f390827f0b04e60fc3 | [landing] Add "Request Access" button to `Header`
Summary: The button doesn't do anything yet.
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -49,6 +49,11 @@ function Header(props: HeaderProps): React.Node {\n</div>\n</div>\n<div className={css.social_icons}>\n+ <a href=\"\">\n+ <div className={css.request_access}>\n+ <p>Request Access</p>\n+ </div>\n+ </a>\n<a href=\"https://twitter.com/commdotapp\">\n<div className={css.twitter_icon}>\n<FontAwesomeIcon size=\"lg\" color=\"#ebedee\" icon={faTwitter} />\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -130,7 +130,7 @@ div.top_nav a:hover {\ndiv.social_icons {\ngrid-area: social_icons;\n- align-self: center;\n+ align-items: center;\ndisplay: flex;\nflex-direction: row;\njustify-self: flex-end;\n@@ -167,6 +167,26 @@ div.github_icon:hover svg {\ntransition: 300ms;\n}\n+div.request_access {\n+ border-radius: 4px;\n+ padding-inline: 12px;\n+ margin-right: 12px;\n+ background-color: #7e57c2;\n+ color: #ebedee;\n+ transition: 300ms;\n+}\n+div.request_access:hover {\n+ color: #7e57c2;\n+ background-color: #ebedee;\n+ transition: 300ms;\n+}\n+\n+div.request_access p {\n+ font-size: 16px;\n+ font-weight: bold;\n+ line-height: 2.5;\n+}\n+\n/* ===== CSS BODY GRID LAYOUT ===== */\ndiv.body_grid {\ngrid-template-columns: 1fr 1fr;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add "Request Access" button to `Header`
Summary: The button doesn't do anything yet.
Test Plan: Here's how it looks: https://blob.sh/atul/request_access_button.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2124 |
129,191 | 05.10.2021 13:58:45 | -7,200 | 27aadcdc873180e3ca1d41688bf4805311b55a79 | Update clang format path
Summary: Update the path
Test Plan: Modify server.cpp, run clang format and check if there's no error about no such file and if the formatting was fixed.
Reviewers: ashoat, karol-bisztyga
Subscribers: Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": ".lintstagedrc.js",
"new_path": ".lintstagedrc.js",
"diff": "@@ -27,7 +27,7 @@ module.exports = {\n'{landing,lib}/**/*.js': function landingFlow(files) {\nreturn 'yarn workspace landing flow --quiet';\n},\n- 'native/**/*.{h,cpp}': function clangFormat(files) {\n+ '{native,services}/**/*.{h,cpp,java}': function clangFormat(files) {\nreturn 'clang-format -i ' + files.join(' ');\n},\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"cleaninstall\": \"yarn clean && yarn\",\n\"eslint\": \"eslint .\",\n\"eslint:fix\": \"eslint --fix .\",\n- \"clang-format-all\": \"clang-format -i native/cpp/CommonCpp/**/*.cpp native/cpp/CommonCpp/**/*.h native/android/app/src/cpp/* services/tunnelbroker/grpc-server/transferred/server/src/*.cpp native/ios/Comm/*.mm native/ios/CommTests/*.mm native/ios/Comm/*.m native/ios/Comm/*.h native/android/app/src/main/java/app/comm/**/*.java\",\n+ \"clang-format-all\": \"clang-format -i native/cpp/CommonCpp/**/*.cpp native/cpp/CommonCpp/**/*.h native/android/app/src/cpp/* services/tunnelbroker/contents/server/src/*.cpp native/ios/Comm/*.mm native/ios/CommTests/*.mm native/ios/Comm/*.m native/ios/Comm/*.h native/android/app/src/main/java/app/comm/**/*.java\",\n\"prepare\": \"husky install\"\n},\n\"devDependencies\": {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Update clang format path
Summary: Update the path
Test Plan: Modify server.cpp, run clang format and check if there's no error about no such file and if the formatting was fixed.
Reviewers: ashoat, karol-bisztyga
Reviewed By: ashoat, karol-bisztyga
Subscribers: Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2129 |
129,190 | 08.10.2021 09:24:20 | -7,200 | aed8900ba76706d18fb1f1bed0424f6b99430e72 | [native] Fix codegen for jsi
Summary: I forgot to update the target path where generated files for jsi are put
Test Plan: `cd native && yarn codegen-jsi`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/codegen/src/index.js",
"new_path": "native/codegen/src/index.js",
"diff": "@@ -8,6 +8,6 @@ import codeGen from './CodeGen.js';\n('use strict');\nconst schemaInPath = path.resolve('./schema/CommCoreModuleSchema.js');\n-const outPath = path.resolve('./cpp/CommonCpp/NativeModules');\n+const outPath = path.resolve('./cpp/CommonCpp/_generated');\ncodeGen('comm', schemaInPath, ['cpp', 'h'], outPath);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix codegen for jsi
Summary: I forgot to update the target path where generated files for jsi are put
Test Plan: `cd native && yarn codegen-jsi`
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2156 |
129,190 | 08.10.2021 09:29:13 | -7,200 | 5a33d6bc621e4cceeb27ff3dd540bcfd4ce90a69 | [native] Secure random generator - iOS part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "71142A7726C2650B0039DCBD /* CommSecureStoreIOSWrapper.mm in Sources */ = {isa = PBXBuildFile; fileRef = 71142A7626C2650A0039DCBD /* CommSecureStoreIOSWrapper.mm */; };\n711B408425DA97F9005F8F06 /* dummy.swift in Sources */ = {isa = PBXBuildFile; fileRef = 7F26E81B24440D87004049C6 /* dummy.swift */; };\n713EE41126C66B80003D7C48 /* CryptoTest.mm in Sources */ = {isa = PBXBuildFile; fileRef = 713EE41026C66B80003D7C48 /* CryptoTest.mm */; };\n+ 71762A75270D8AAE00F565ED /* PlatformSpecificTools.mm in Sources */ = {isa = PBXBuildFile; fileRef = 71762A74270D8AAE00F565ED /* PlatformSpecificTools.mm */; };\n718DE99E2653D41C00365824 /* WorkerThread.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 718DE99C2653D41C00365824 /* WorkerThread.cpp */; };\n71BE84492636A944002849D2 /* NativeModules.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71BE843B2636A944002849D2 /* NativeModules.cpp */; };\n71BE844A2636A944002849D2 /* CommCoreModule.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71BE843C2636A944002849D2 /* CommCoreModule.cpp */; };\n713EE40626C6676B003D7C48 /* CommTests.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = CommTests.xctest; sourceTree = BUILT_PRODUCTS_DIR; };\n713EE40A26C6676B003D7C48 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = \"<group>\"; };\n713EE41026C66B80003D7C48 /* CryptoTest.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = CryptoTest.mm; sourceTree = \"<group>\"; };\n+ 71762A74270D8AAE00F565ED /* PlatformSpecificTools.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = PlatformSpecificTools.mm; path = Comm/PlatformSpecificTools.mm; sourceTree = \"<group>\"; };\n718DE99C2653D41C00365824 /* WorkerThread.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WorkerThread.cpp; sourceTree = \"<group>\"; };\n718DE99D2653D41C00365824 /* WorkerThread.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WorkerThread.h; sourceTree = \"<group>\"; };\n71B8CCBD26BD4DEB0040C0A2 /* CommSecureStore.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CommSecureStore.h; sourceTree = \"<group>\"; };\n71CA4AEA262F230A00835C89 /* Tools.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; name = Tools.h; path = Comm/Tools.h; sourceTree = \"<group>\"; };\n71CA4AEB262F236100835C89 /* Tools.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; name = Tools.mm; path = Comm/Tools.mm; sourceTree = \"<group>\"; };\n71D4D7CB26C50B1000FCDBCD /* CommSecureStore.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = CommSecureStore.mm; path = Comm/CommSecureStore.mm; sourceTree = \"<group>\"; };\n+ 71DC160C270C43D300822863 /* PlatformSpecificTools.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PlatformSpecificTools.h; sourceTree = \"<group>\"; };\n7F26E81B24440D87004049C6 /* dummy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dummy.swift; sourceTree = \"<group>\"; };\n7F554F822332D58B007CB9F7 /* Info.debug.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = Info.debug.plist; path = Comm/Info.debug.plist; sourceTree = \"<group>\"; };\n7F761E292201141E001B6FB7 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; };\n71B8CCB626BD30EC0040C0A2 /* CommCoreImplementations */ = {\nisa = PBXGroup;\nchildren = (\n+ 71762A74270D8AAE00F565ED /* PlatformSpecificTools.mm */,\n71D4D7CB26C50B1000FCDBCD /* CommSecureStore.mm */,\n71142A7526C2650A0039DCBD /* CommSecureStoreIOSWrapper.h */,\n71142A7626C2650A0039DCBD /* CommSecureStoreIOSWrapper.mm */,\n718DE99C2653D41C00365824 /* WorkerThread.cpp */,\n718DE99D2653D41C00365824 /* WorkerThread.h */,\n71BE84392636A944002849D2 /* Logger.h */,\n+ 71DC160C270C43D300822863 /* PlatformSpecificTools.h */,\n);\npath = Tools;\nsourceTree = \"<group>\";\n718DE99E2653D41C00365824 /* WorkerThread.cpp in Sources */,\n71CA4AEC262F236100835C89 /* Tools.mm in Sources */,\n71009A7B26FDCD72002C8453 /* Client.cpp in Sources */,\n+ 71762A75270D8AAE00F565ED /* PlatformSpecificTools.mm in Sources */,\n71BF5B7126B3FF0900EDE27D /* Session.cpp in Sources */,\n71009A7726FDCA67002C8453 /* tunnelbroker.pb.cc in Sources */,\n71BF5B7526B401D300EDE27D /* Tools.cpp in Sources */,\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/ios/Comm/PlatformSpecificTools.mm",
"diff": "+#import \"PlatformSpecificTools.h\"\n+#import <Foundation/Foundation.h>\n+#import <string>\n+\n+namespace comm {\n+\n+void PlatformSpecificTools::generateSecureRandomBytes(\n+ crypto::OlmBuffer &buffer,\n+ size_t size) {\n+ uint8_t randomBytes[size];\n+\n+ const int status = SecRandomCopyBytes(kSecRandomDefault, size, randomBytes);\n+ if (status == errSecSuccess) {\n+ buffer = crypto::OlmBuffer(randomBytes, randomBytes + size);\n+ } else {\n+ throw std::runtime_error(\n+ \"SecRandomCopyBytes failed for some reason, error code: \" +\n+ std::to_string(status));\n+ }\n+}\n+\n+};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Secure random generator - iOS part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2127 |
129,190 | 08.10.2021 09:31:07 | -7,200 | 054493cf72d2cf5374308ac2f9a3037963cbb651 | [native] Secure random generator - android part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/cpp/PlatformSpecificTools.cpp",
"diff": "+#include \"PlatformSpecificTools.h\"\n+#include \"Logger.h\"\n+#include <fbjni/fbjni.h>\n+\n+using namespace facebook::jni;\n+\n+class PlatformSpecificToolsJavaClass\n+ : public JavaClass<PlatformSpecificToolsJavaClass> {\n+public:\n+ static auto constexpr kJavaDescriptor =\n+ \"Lapp/comm/android/fbjni/PlatformSpecificTools;\";\n+\n+ static comm::crypto::OlmBuffer generateSecureRandomBytes(size_t size) {\n+ static const auto cls = javaClassStatic();\n+ static auto method =\n+ cls->getStaticMethod<JArrayByte(int)>(\"generateSecureRandomBytes\");\n+ auto methodResult = method(cls, (int)size);\n+ comm::crypto::OlmBuffer result(size);\n+ std::vector<jbyte> bytes(size);\n+ methodResult->getRegion(0, size, bytes.data());\n+ for (size_t i = 0; i < size; ++i) {\n+ result[i] = bytes[i];\n+ }\n+ return result;\n+ }\n+};\n+\n+namespace comm {\n+\n+void PlatformSpecificTools::generateSecureRandomBytes(\n+ crypto::OlmBuffer &buffer,\n+ size_t size) {\n+ buffer = PlatformSpecificToolsJavaClass::generateSecureRandomBytes(size);\n+}\n+\n+} // namespace comm\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java",
"diff": "+package app.comm.android.fbjni;\n+\n+import android.util.Log;\n+import java.nio.charset.StandardCharsets;\n+import java.security.NoSuchAlgorithmException;\n+import java.security.SecureRandom;\n+\n+public class PlatformSpecificTools {\n+ static SecureRandom secureRandom = new SecureRandom();\n+\n+ public static byte[] generateSecureRandomBytes(int size) {\n+ byte[] buffer = new byte[size];\n+ secureRandom.nextBytes(buffer);\n+ return buffer;\n+ }\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Secure random generator - android part
Summary: All the information's in D2126
Test Plan: All the information's in D2126
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2128 |
129,185 | 08.10.2021 12:59:36 | -7,200 | e8187fb53b459bb764dee4a65d4bea9ca171f021 | [CommCoreModule] Add `Thread.h` with c++ thread type
Summary: I introduced Thread type representing ThreadInfo in C++ layer.
Test Plan: The change doesn't modify app behavior.
Reviewers: palys-swm, atul, karol-bisztyga, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/DatabaseManagers/entities/Thread.h",
"diff": "+#pragma once\n+\n+#include <memory>\n+#include <string>\n+\n+namespace comm {\n+\n+struct Thread {\n+ std::string id;\n+ int type;\n+ std::unique_ptr<std::string> name;\n+ std::unique_ptr<std::string> description;\n+ std::string color;\n+ int64_t creation_time;\n+ std::unique_ptr<std::string> parent_thread_id;\n+ std::unique_ptr<std::string> containing_thread_id;\n+ std::unique_ptr<std::string> community;\n+ std::string members;\n+ std::string roles;\n+ std::string current_user;\n+ std::unique_ptr<std::string> source_message_id;\n+ int replies_count;\n+};\n+\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Add `Thread.h` with c++ thread type
Summary: I introduced Thread type representing ThreadInfo in C++ layer.
Test Plan: The change doesn't modify app behavior.
Reviewers: palys-swm, atul, karol-bisztyga, ashoat
Reviewed By: palys-swm, atul, karol-bisztyga, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2076 |
129,184 | 05.10.2021 12:08:24 | 14,400 | 69a6afd94c81894dfaceab9d62e1267572580c69 | [landing] Reduce space between "tabs" in `Header`
Summary: Reduce the horizontal spacing between these elements as discussed.
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -107,13 +107,18 @@ div.top_nav {\nalign-self: center;\ndisplay: flex;\nflex-direction: row;\n- justify-content: space-evenly;\n+ justify-content: center;\n}\ndiv.top_nav h1 {\nfont-size: 16px;\n}\n+div.top_nav div.active_tab,\n+div.top_nav div.inactive_tab {\n+ margin-right: 16px;\n+}\n+\ndiv.active_tab a {\ncolor: white;\ntransition: 300ms;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Reduce space between "tabs" in `Header`
Summary: Reduce the horizontal spacing between these elements as discussed.
Test Plan: Here's how it looks: https://blob.sh/atul/ef90.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2130 |
129,184 | 05.10.2021 14:27:34 | 14,400 | 4e10192ddf45488e2cddd1e6b1b9c4d9b1e7b69b | [landing] Update "cycling text" heading
Summary: Update "cycling text" styling and copy
Test Plan:
Figma:
How it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -19,18 +19,20 @@ function AppLanding(): React.Node {\n<img src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1 className={css.no_bottom_margin}>\n- Comm{' '}\n- <TextLoop interval={750}>\n- <span>Messenger</span>\n- <span>Calendar</span>\n- <span>Wiki</span>\n- <span>Wallet</span>\n- <span>Placeholder</span>\n+ <h1>\n+ Comm is crypto-native chat for{' '}\n+ <TextLoop\n+ interval={1000}\n+ springConfig={{ stiffness: 180, damping: 16 }}\n+ >\n+ <span className={css.app_landing_subheading}>DAOs</span>\n+ <span className={css.app_landing_subheading}>open source</span>\n+ <span className={css.app_landing_subheading}>gaming guilds</span>\n+ <span className={css.app_landing_subheading}>social clubs</span>\n</TextLoop>\n</h1>\n<p className={css.app_landing_subheading}>\n- Web3 Messenger. E2E encrypted. Blah..\n+ (think "Web3 Discord")\n</p>\n<div className={css.tile_grid}>\n<div className={css.tile_tl}>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -44,14 +44,19 @@ li {\nline-height: 1.6em;\n}\n-p.app_landing_subheading {\n- background-color: #7e57c2;\n- margin-top: 6px;\n- font-family: 'IBM Plex Mono', monospace;\n+.app_landing_subheading {\nfont-weight: 500;\npadding-inline: 4px;\n}\n+span.app_landing_subheading {\n+ background-color: #7e57c2;\n+}\n+\n+p.app_landing_subheading {\n+ font-family: 'IBM Plex Mono', monospace;\n+}\n+\nspan.purple_accent {\ncolor: #7e57c2;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update "cycling text" heading
Summary: Update "cycling text" styling and copy
Test Plan:
Figma: https://blob.sh/atul/695d.png
How it looks: https://blob.sh/atul/cycling_crypto_native.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2131 |
129,184 | 05.10.2021 15:50:16 | 14,400 | db999b839deb7cc13d36f4ba3094f4477f9d95d3 | [landing] Turn 2x2 grid of "tiles" into "cards"
Summary:
Figma:
Here's what it looks like:
Test Plan: CSS could def use some cleaning up
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -37,19 +37,47 @@ function AppLanding(): React.Node {\n<div className={css.tile_grid}>\n<div className={css.tile_tl}>\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faLock} />\n- <p>E2E Encryption</p>\n+ <p className={css.tile_title}>E2E Encryption</p>\n+ <p>\n+ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam\n+ porta, nisl eu pharetra malesuada, libero purus placerat mauris,\n+ sed ultricies neque enim sit amet metus. Morbi ac augue eget nunc\n+ vehicula interdum auctor ut ligula. Nulla sed risus in lorem\n+ posuere euismod. Ut et luctus leo.\n+ </p>\n</div>\n<div className={css.tile_tr}>\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faServer} />\n- <p>Self-hosted</p>\n+ <p className={css.tile_title}>Self-hosted</p>\n+ <p>\n+ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam\n+ porta, nisl eu pharetra malesuada, libero purus placerat mauris,\n+ sed ultricies neque enim sit amet metus. Morbi ac augue eget nunc\n+ vehicula interdum auctor ut ligula. Nulla sed risus in lorem\n+ posuere euismod. Ut et luctus leo.\n+ </p>\n</div>\n<div className={css.tile_bl}>\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faUsers} />\n- <p>Federated</p>\n+ <p className={css.tile_title}>Federated</p>\n+ <p>\n+ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam\n+ porta, nisl eu pharetra malesuada, libero purus placerat mauris,\n+ sed ultricies neque enim sit amet metus. Morbi ac augue eget nunc\n+ vehicula interdum auctor ut ligula. Nulla sed risus in lorem\n+ posuere euismod. Ut et luctus leo.\n+ </p>\n</div>\n<div className={css.tile_br}>\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faUserShield} />\n- <p>Sovereign Identity</p>\n+ <p className={css.tile_title}>Sovereign Identity</p>\n+ <p>\n+ Lorem ipsum dolor sit amet, consectetur adipiscing elit. Aliquam\n+ porta, nisl eu pharetra malesuada, libero purus placerat mauris,\n+ sed ultricies neque enim sit amet metus. Morbi ac augue eget nunc\n+ vehicula interdum auctor ut ligula. Nulla sed risus in lorem\n+ posuere euismod. Ut et luctus leo.\n+ </p>\n</div>\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -290,7 +290,6 @@ div.app_landing_grid {\ndiv.app_preview {\ngrid-area: app_preview;\n- align-self: center;\njustify-self: right;\n}\n@@ -310,15 +309,17 @@ div.app_copy {\n/* ===== TILE GRID STYLING ===== */\ndiv.tile_grid {\ndisplay: grid;\n- grid-template-columns: 1fr 1fr;\n- grid-template-rows: 1fr 1fr;\n- row-gap: 1em;\n- column-gap: 1em;\n+ margin-right: 16%;\n+ grid-template-columns: 1fr;\n+ grid-template-rows: 1fr 1fr 1fr 1fr;\n+ row-gap: 4em;\npadding-top: 40px;\npadding-bottom: 40px;\ngrid-template-areas:\n- 'tile_tl tile_tr'\n- 'tile_bl tile_br';\n+ 'tile_tl'\n+ 'tile_tr'\n+ 'tile_bl'\n+ 'tile_br';\n}\ndiv.tile_tl,\n@@ -327,7 +328,7 @@ div.tile_bl,\ndiv.tile_br {\ndisplay: flex;\npadding: 24px;\n- border-radius: 36px;\n+ border-radius: 8px;\nbackground-color: #ebedee;\njustify-content: center;\nalign-items: center;\n@@ -343,14 +344,26 @@ div.tile_br:hover {\ntransition: 300ms;\n}\n+div.tile_tl p.tile_title,\n+div.tile_tr p.tile_title,\n+div.tile_bl p.tile_title,\n+div.tile_br p.tile_title {\n+ font-weight: bold;\n+ font-size: 28px;\n+ color: #485563;\n+ text-align: center;\n+ margin-top: 10px;\n+ margin-bottom: 0;\n+ transition: 300ms;\n+}\n+\ndiv.tile_tl p,\ndiv.tile_tr p,\ndiv.tile_bl p,\ndiv.tile_br p {\n- font-weight: bold;\n- font-size: 20px;\n+ font-size: 16px;\ncolor: #485563;\n- text-align: center;\n+ text-align: left;\nmargin-top: 10px;\nmargin-bottom: 0;\ntransition: 300ms;\n@@ -575,21 +588,8 @@ div.body_grid > div + .starting_section {\njustify-self: center;\n}\n- div.app_copy h1,\n- div.app_copy p {\n- text-align: center;\n- }\n-\n- div.tile_tl p,\n- div.tile_tr p,\n- div.tile_bl p,\n- div.tile_br p {\n- font-weight: bold;\n- font-size: 16px;\n- color: #485563;\n- text-align: center;\n- margin-top: 8px;\n- margin-bottom: 0;\n+ div.app_copy div.tile_grid {\n+ margin: 0;\n}\n/* ===== LAYOUT HACKS ===== */\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Turn 2x2 grid of "tiles" into "cards"
Summary:
Figma: https://blob.sh/atul/8191.png
Here's what it looks like: https://blob.sh/atul/tiles_to_cards.mov
Test Plan: CSS could def use some cleaning up
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2132 |
129,184 | 05.10.2021 17:20:56 | 14,400 | bf8f7d245b07a10b176fefd78757bb9e91ea44ed | [landing] Move "request access"/twtr/gh styles to header.css
Summary: na
Test Plan: Continues to look as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/header.css",
"diff": "+/* ===== REQUEST ACCESS BUTTON ===== */\n+\n+div.request_access {\n+ border-radius: 4px;\n+ padding-inline: 12px;\n+ margin-right: 12px;\n+ background-color: #7e57c2;\n+ color: #ebedee;\n+ transition: 300ms;\n+}\n+\n+div.request_access:hover {\n+ color: #7e57c2;\n+ background-color: #ebedee;\n+ transition: 300ms;\n+}\n+\n+div.request_access p {\n+ font-size: 16px;\n+ font-weight: bold;\n+ line-height: 2.5;\n+}\n+\n+/* ===== TWITTER/GITHUB BUTTONS ===== */\n+\n+div.twitter_icon,\n+div.github_icon {\n+ margin-inline: 8px;\n+ padding: 16px;\n+ border-radius: 36px;\n+ transition: 300ms;\n+}\n+\n+div.twitter_icon:hover,\n+div.github_icon:hover {\n+ background-color: #ebedee;\n+ transition: 300ms;\n+}\n+\n+div.twitter_icon svg,\n+div.github_icon svg {\n+ transition: 300ms;\n+}\n+\n+div.twitter_icon:hover svg {\n+ color: #1d9bf0;\n+ transition: 300ms;\n+}\n+\n+div.github_icon:hover svg {\n+ color: #151013;\n+ transition: 300ms;\n+}\n+\n+div.twitter_icon h1,\n+div.github_icon h1 {\n+ font-size: 32px;\n+}\n+\n+/* ===== SMALLEST BREAKPOINT ===== */\n+@media (max-width: 1099px) {\n+ div.twitter_icon,\n+ div.github_icon {\n+ margin-inline: 4px;\n+ padding: 10px;\n+ border-radius: 36px;\n+ transition: 300ms;\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -5,7 +5,8 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { Link } from 'react-router-dom';\n-import css from './landing.css';\n+import headerStyles from './header.css';\n+import commonStyles from './landing.css';\nimport type { LandingPageName } from './landing.react';\ntype HeaderProps = {\n@@ -16,20 +17,22 @@ function Header(props: HeaderProps): React.Node {\nconst { isLegalPage, activePageName } = props;\nconst headerStyle = isLegalPage\n- ? `${css.header_grid} ${css.header_legal}`\n- : css.header_grid;\n+ ? `${commonStyles.header_grid} ${commonStyles.header_legal}`\n+ : commonStyles.header_grid;\nreturn (\n<>\n<div className={headerStyle}>\n- <div className={css.logo}>\n+ <div className={commonStyles.logo}>\n<Link to=\"/\">\n<h1>Comm</h1>\n</Link>\n</div>\n- <div className={css.top_nav}>\n+ <div className={commonStyles.top_nav}>\n<div\nclassName={\n- activePageName === 'app' ? css.active_tab : css.inactive_tab\n+ activePageName === 'app'\n+ ? commonStyles.active_tab\n+ : commonStyles.inactive_tab\n}\n>\n<Link to=\"/\">\n@@ -39,8 +42,8 @@ function Header(props: HeaderProps): React.Node {\n<div\nclassName={\nactivePageName === 'keyservers'\n- ? css.active_tab\n- : css.inactive_tab\n+ ? commonStyles.active_tab\n+ : commonStyles.inactive_tab\n}\n>\n<Link to=\"/keyservers\">\n@@ -48,19 +51,19 @@ function Header(props: HeaderProps): React.Node {\n</Link>\n</div>\n</div>\n- <div className={css.social_icons}>\n+ <div className={commonStyles.social_icons}>\n<a href=\"\">\n- <div className={css.request_access}>\n+ <div className={headerStyles.request_access}>\n<p>Request Access</p>\n</div>\n</a>\n<a href=\"https://twitter.com/commdotapp\">\n- <div className={css.twitter_icon}>\n+ <div className={headerStyles.twitter_icon}>\n<FontAwesomeIcon size=\"lg\" color=\"#ebedee\" icon={faTwitter} />\n</div>\n</a>\n<a href=\"https://github.com/CommE2E/comm\">\n- <div className={css.github_icon}>\n+ <div className={headerStyles.github_icon}>\n<FontAwesomeIcon size=\"lg\" color=\"#ebedee\" icon={faGithub} />\n</div>\n</a>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -146,57 +146,6 @@ div.social_icons {\njustify-self: flex-end;\n}\n-div.twitter_icon h1,\n-div.github_icon h1 {\n- font-size: 32px;\n-}\n-\n-div.twitter_icon,\n-div.github_icon {\n- margin-inline: 8px;\n- padding: 16px;\n- border-radius: 36px;\n- transition: 300ms;\n-}\n-div.twitter_icon:hover,\n-div.github_icon:hover {\n- background-color: #ebedee;\n- transition: 300ms;\n-}\n-\n-div.twitter_icon svg,\n-div.github_icon svg {\n- transition: 300ms;\n-}\n-div.twitter_icon:hover svg {\n- color: #1d9bf0;\n- transition: 300ms;\n-}\n-div.github_icon:hover svg {\n- color: #151013;\n- transition: 300ms;\n-}\n-\n-div.request_access {\n- border-radius: 4px;\n- padding-inline: 12px;\n- margin-right: 12px;\n- background-color: #7e57c2;\n- color: #ebedee;\n- transition: 300ms;\n-}\n-div.request_access:hover {\n- color: #7e57c2;\n- background-color: #ebedee;\n- transition: 300ms;\n-}\n-\n-div.request_access p {\n- font-size: 16px;\n- font-weight: bold;\n- line-height: 2.5;\n-}\n-\n/* ===== CSS BODY GRID LAYOUT ===== */\ndiv.body_grid {\ngrid-template-columns: 1fr 1fr;\n@@ -516,14 +465,6 @@ div.body_grid > div + .starting_section {\nmargin-right: 10px;\n}\n- div.twitter_icon,\n- div.github_icon {\n- margin-inline: 4px;\n- padding: 10px;\n- border-radius: 36px;\n- transition: 300ms;\n- }\n-\n/* ===== CSS BODY GRID LAYOUT ===== */\ndiv.body_grid {\ngrid-template-areas:\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move "request access"/twtr/gh styles to header.css
Summary: na
Test Plan: Continues to look as expected: https://blob.sh/atul/963e.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2133 |
129,184 | 05.10.2021 17:29:25 | 14,400 | 204e835628f841b88bc99e216868dfbe4897d5c4 | [landing] Move header grid to `header.css`
Summary: na, refactor
Test Plan: Continues to look as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "+/* ===== CSS HEADER GRID LAYOUT ===== */\n+div.header_grid {\n+ max-width: 1920px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ column-gap: 6em;\n+ padding-left: 60px;\n+ padding-right: 60px;\n+ padding-top: 20px;\n+ padding-bottom: 40px;\n+ transition-property: max-width;\n+ transition: 300ms;\n+ grid-template-columns: 1fr 1fr 1fr;\n+ grid-template-areas: 'logo top_nav social_icons';\n+}\n+\n+div.header_legal {\n+ max-width: 1080px;\n+ transition-property: max-width;\n+ transition: 300ms;\n+}\n+\n/* ===== REQUEST ACCESS BUTTON ===== */\ndiv.request_access {\n@@ -66,4 +89,15 @@ div.github_icon h1 {\nborder-radius: 36px;\ntransition: 300ms;\n}\n+\n+ div.header_grid {\n+ padding-left: 3%;\n+ padding-right: 3%;\n+ grid-template-columns: minmax(auto, 540px);\n+ justify-content: center;\n+ grid-template-columns: 1fr 1fr;\n+ grid-template-areas:\n+ 'logo social_icons'\n+ 'top_nav top_nav';\n+ }\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -17,8 +17,8 @@ function Header(props: HeaderProps): React.Node {\nconst { isLegalPage, activePageName } = props;\nconst headerStyle = isLegalPage\n- ? `${commonStyles.header_grid} ${commonStyles.header_legal}`\n- : commonStyles.header_grid;\n+ ? `${headerStyles.header_grid} ${headerStyles.header_legal}`\n+ : headerStyles.header_grid;\nreturn (\n<>\n<div className={headerStyle}>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -64,8 +64,7 @@ span.purple_accent {\n/* ===== COMMON CSS GRID LAYOUT ===== */\ndiv.body_grid,\ndiv.footer_grid,\n-div.app_landing_grid,\n-div.header_grid {\n+div.app_landing_grid {\nmax-width: 1920px;\nmargin-left: auto;\nmargin-right: auto;\n@@ -80,17 +79,6 @@ div.header_grid {\n}\n/* ===== CSS HEADER GRID LAYOUT ===== */\n-div.header_grid {\n- grid-template-columns: 1fr 1fr 1fr;\n- grid-template-areas: 'logo top_nav social_icons';\n-}\n-\n-div.header_legal {\n- max-width: 1080px;\n- transition-property: max-width;\n- transition: 300ms;\n-}\n-\ndiv.logo {\ngrid-area: logo;\n}\n@@ -436,7 +424,6 @@ div.body_grid > div + .starting_section {\n/* ===== COMMON CSS GRID LAYOUT ===== */\ndiv.body_grid,\ndiv.footer_grid,\n- div.header_grid,\ndiv.app_landing_grid {\npadding-left: 3%;\npadding-right: 3%;\n@@ -445,12 +432,6 @@ div.body_grid > div + .starting_section {\n}\n/* ===== CSS HEADER GRID LAYOUT ===== */\n- div.header_grid {\n- grid-template-columns: 1fr 1fr;\n- grid-template-areas:\n- 'logo social_icons'\n- 'top_nav top_nav';\n- }\ndiv.top_nav {\ngrid-area: top_nav;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move header grid to `header.css`
Summary: na, refactor
Test Plan: Continues to look as expected: https://blob.sh/atul/e87e.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2134 |
129,184 | 05.10.2021 17:44:04 | 14,400 | 4ffb58c5d8e9b462f001033bf7cd81baed56ab00 | [landing] Move top nav styles to header.css
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -21,8 +21,56 @@ div.header_legal {\ntransition: 300ms;\n}\n-/* ===== REQUEST ACCESS BUTTON ===== */\n+/* ===== LOGO ===== */\n+div.logo {\n+ grid-area: logo;\n+}\n+\n+div.logo h1 {\n+ font-size: 32px;\n+}\n+\n+div.logo a {\n+ color: white;\n+}\n+\n+div.logo a:hover {\n+ color: #7e57c2;\n+}\n+\n+/* ===== NAVIGATION ===== */\n+div.top_nav {\n+ grid-area: top_nav;\n+ align-self: center;\n+ display: flex;\n+ flex-direction: row;\n+ justify-content: center;\n+}\n+\n+div.top_nav h1 {\n+ font-size: 16px;\n+}\n+div.top_nav div.active_tab,\n+div.top_nav div.inactive_tab {\n+ margin-inline: 16px;\n+}\n+\n+div.active_tab a {\n+ color: white;\n+ transition: 300ms;\n+}\n+\n+div.inactive_tab a {\n+ color: #8a8f98;\n+ transition: 300ms;\n+}\n+\n+div.top_nav a:hover {\n+ color: white;\n+}\n+\n+/* ===== REQUEST ACCESS BUTTON ===== */\ndiv.request_access {\nborder-radius: 4px;\npadding-inline: 12px;\n@@ -45,6 +93,13 @@ div.request_access p {\n}\n/* ===== TWITTER/GITHUB BUTTONS ===== */\n+div.social_icons {\n+ grid-area: social_icons;\n+ align-items: center;\n+ display: flex;\n+ flex-direction: row;\n+ justify-self: flex-end;\n+}\ndiv.twitter_icon,\ndiv.github_icon {\n@@ -100,4 +155,17 @@ div.github_icon h1 {\n'logo social_icons'\n'top_nav top_nav';\n}\n+\n+ div.top_nav {\n+ grid-area: top_nav;\n+ display: flex;\n+ flex-direction: row;\n+ justify-content: flex-start;\n+ align-self: flex-start;\n+ }\n+\n+ div.active_tab,\n+ div.inactive_tab {\n+ margin-right: 10px;\n+ }\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -6,7 +6,6 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport headerStyles from './header.css';\n-import commonStyles from './landing.css';\nimport type { LandingPageName } from './landing.react';\ntype HeaderProps = {\n@@ -22,17 +21,17 @@ function Header(props: HeaderProps): React.Node {\nreturn (\n<>\n<div className={headerStyle}>\n- <div className={commonStyles.logo}>\n+ <div className={headerStyles.logo}>\n<Link to=\"/\">\n<h1>Comm</h1>\n</Link>\n</div>\n- <div className={commonStyles.top_nav}>\n+ <div className={headerStyles.top_nav}>\n<div\nclassName={\nactivePageName === 'app'\n- ? commonStyles.active_tab\n- : commonStyles.inactive_tab\n+ ? headerStyles.active_tab\n+ : headerStyles.inactive_tab\n}\n>\n<Link to=\"/\">\n@@ -42,8 +41,8 @@ function Header(props: HeaderProps): React.Node {\n<div\nclassName={\nactivePageName === 'keyservers'\n- ? commonStyles.active_tab\n- : commonStyles.inactive_tab\n+ ? headerStyles.active_tab\n+ : headerStyles.inactive_tab\n}\n>\n<Link to=\"/keyservers\">\n@@ -51,7 +50,7 @@ function Header(props: HeaderProps): React.Node {\n</Link>\n</div>\n</div>\n- <div className={commonStyles.social_icons}>\n+ <div className={headerStyles.social_icons}>\n<a href=\"\">\n<div className={headerStyles.request_access}>\n<p>Request Access</p>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -78,62 +78,6 @@ div.app_landing_grid {\ntransition: 300ms;\n}\n-/* ===== CSS HEADER GRID LAYOUT ===== */\n-div.logo {\n- grid-area: logo;\n-}\n-\n-div.logo h1 {\n- font-size: 32px;\n-}\n-\n-div.logo a {\n- color: white;\n-}\n-\n-div.logo a:hover {\n- color: #7e57c2;\n-}\n-\n-div.top_nav {\n- grid-area: top_nav;\n- align-self: center;\n- display: flex;\n- flex-direction: row;\n- justify-content: center;\n-}\n-\n-div.top_nav h1 {\n- font-size: 16px;\n-}\n-\n-div.top_nav div.active_tab,\n-div.top_nav div.inactive_tab {\n- margin-right: 16px;\n-}\n-\n-div.active_tab a {\n- color: white;\n- transition: 300ms;\n-}\n-\n-div.inactive_tab a {\n- color: #8a8f98;\n- transition: 300ms;\n-}\n-\n-div.top_nav a:hover {\n- color: white;\n-}\n-\n-div.social_icons {\n- grid-area: social_icons;\n- align-items: center;\n- display: flex;\n- flex-direction: row;\n- justify-self: flex-end;\n-}\n-\n/* ===== CSS BODY GRID LAYOUT ===== */\ndiv.body_grid {\ngrid-template-columns: 1fr 1fr;\n@@ -431,21 +375,6 @@ div.body_grid > div + .starting_section {\njustify-content: center;\n}\n- /* ===== CSS HEADER GRID LAYOUT ===== */\n-\n- div.top_nav {\n- grid-area: top_nav;\n- display: flex;\n- flex-direction: row;\n- justify-content: flex-start;\n- align-self: flex-start;\n- }\n-\n- div.active_tab,\n- div.inactive_tab {\n- margin-right: 10px;\n- }\n-\n/* ===== CSS BODY GRID LAYOUT ===== */\ndiv.body_grid {\ngrid-template-areas:\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move top nav styles to header.css
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2135 |
129,184 | 05.10.2021 18:16:02 | 14,400 | 5decf33dfdbd9ead2ce3cc94075f10df0ad454a9 | [landing] Move footer grid to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/footer.css",
"diff": "+/* ===== CSS FOOTER GRID LAYOUT ===== */\n+div.footer_grid {\n+ max-width: 1920px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ column-gap: 6em;\n+ padding-left: 60px;\n+ padding-right: 60px;\n+ padding-top: 20px;\n+ padding-bottom: 40px;\n+ transition-property: max-width;\n+ transition: 300ms;\n+ grid-template-columns: 1fr 1fr;\n+ grid-template-areas: 'sitemap subscribe_updates';\n+}\n+\n+/* ===== SMALLEST BREAKPOINT ===== */\n+@media (max-width: 1099px) {\n+ div.footer_grid {\n+ padding-left: 3%;\n+ padding-right: 3%;\n+ grid-template-columns: minmax(auto, 540px);\n+ justify-content: center;\n+ grid-template-areas:\n+ 'subscribe_updates'\n+ 'sitemap';\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -5,7 +5,8 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { Link } from 'react-router-dom';\n-import css from './landing.css';\n+import footerStyles from './footer.css';\n+import commonStyles from './landing.css';\nimport type { LandingPageName } from './landing.react';\nimport SubscriptionForm from './subscription-form.react';\n@@ -15,18 +16,18 @@ type FooterProps = {\nfunction Footer(props: FooterProps): React.Node {\nconst { activePageName } = props;\nreturn (\n- <div className={css.footer_blur}>\n- <div className={css.footer_grid}>\n- <div className={css.sitemap}>\n- <div className={css.footer_logo}>\n+ <div className={commonStyles.footer_blur}>\n+ <div className={footerStyles.footer_grid}>\n+ <div className={commonStyles.sitemap}>\n+ <div className={commonStyles.footer_logo}>\n<Link to=\"/\">Comm</Link>\n</div>\n<div\nclassName={\nactivePageName === 'keyservers'\n- ? css.active_tab\n- : css.inactive_tab\n+ ? commonStyles.active_tab\n+ : commonStyles.inactive_tab\n}\n>\n<Link to=\"/keyservers\">Keyservers</Link>\n@@ -34,7 +35,9 @@ function Footer(props: FooterProps): React.Node {\n<div\nclassName={\n- activePageName === 'support' ? css.active_tab : css.inactive_tab\n+ activePageName === 'support'\n+ ? commonStyles.active_tab\n+ : commonStyles.inactive_tab\n}\n>\n<Link to=\"/support\">Support</Link>\n@@ -42,7 +45,9 @@ function Footer(props: FooterProps): React.Node {\n<div\nclassName={\n- activePageName === 'terms' ? css.active_tab : css.inactive_tab\n+ activePageName === 'terms'\n+ ? commonStyles.active_tab\n+ : commonStyles.inactive_tab\n}\n>\n<Link to=\"/terms\">Terms of Use</Link>\n@@ -50,13 +55,15 @@ function Footer(props: FooterProps): React.Node {\n<div\nclassName={\n- activePageName === 'privacy' ? css.active_tab : css.inactive_tab\n+ activePageName === 'privacy'\n+ ? commonStyles.active_tab\n+ : commonStyles.inactive_tab\n}\n>\n<Link to=\"/privacy\">Privacy Policy</Link>\n</div>\n- <div className={css.inactive_tab}>\n+ <div className={commonStyles.inactive_tab}>\n<a href=\"https://www.notion.so/How-Comm-works-d6217941db7c4237b9d08b427aef3234\">\nHow Comm works{' '}\n<FontAwesomeIcon\n@@ -67,7 +74,7 @@ function Footer(props: FooterProps): React.Node {\n</a>\n</div>\n</div>\n- <div className={css.subscribe_updates}>\n+ <div className={commonStyles.subscribe_updates}>\n<SubscriptionForm />\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -63,7 +63,6 @@ span.purple_accent {\n/* ===== COMMON CSS GRID LAYOUT ===== */\ndiv.body_grid,\n-div.footer_grid,\ndiv.app_landing_grid {\nmax-width: 1920px;\nmargin-left: auto;\n@@ -118,10 +117,6 @@ div.read_the_docs {\n}\n/* ===== CSS FOOTER GRID LAYOUT ===== */\n-div.footer_grid {\n- grid-template-columns: 1fr 1fr;\n- grid-template-areas: 'sitemap subscribe_updates';\n-}\ndiv.sitemap {\ngrid-area: sitemap;\n@@ -367,7 +362,6 @@ div.body_grid > div + .starting_section {\n/* ===== COMMON CSS GRID LAYOUT ===== */\ndiv.body_grid,\n- div.footer_grid,\ndiv.app_landing_grid {\npadding-left: 3%;\npadding-right: 3%;\n@@ -403,11 +397,6 @@ div.body_grid > div + .starting_section {\n}\n/* ===== CSS FOOTER GRID LAYOUT ===== */\n- div.footer_grid {\n- grid-template-areas:\n- 'subscribe_updates'\n- 'sitemap';\n- }\ndiv.footer_container {\npadding-top: 5%;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move footer grid to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2136 |
129,184 | 05.10.2021 18:22:17 | 14,400 | 6637363064ac9ca4a2776034b8d9a08c4a2709dc | [landing] Move sitemap/subscription-form styles to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -15,6 +15,50 @@ div.footer_grid {\ngrid-template-areas: 'sitemap subscribe_updates';\n}\n+div.sitemap {\n+ grid-area: sitemap;\n+}\n+\n+div.sitemap a {\n+ display: block;\n+ padding-bottom: 4px;\n+ width: max-content;\n+}\n+\n+div.sitemap a.active_tab,\n+div.sitemap a:hover,\n+div.sitemap a:hover svg {\n+ color: white;\n+ transition: 300ms;\n+}\n+\n+div.sitemap .inactive_tab,\n+div.sitemap .inactive_tab svg {\n+ color: #8a8f98;\n+ transition: 300ms;\n+}\n+\n+div.footer_logo a {\n+ font-size: 24px;\n+ font-weight: 500;\n+ color: white;\n+ padding-bottom: 8px;\n+}\n+div.footer_logo a:hover {\n+ color: #7e57c2;\n+}\n+\n+div.subscribe_updates {\n+ grid-area: subscribe_updates;\n+ align-self: center;\n+}\n+\n+/* ===== VISUAL EFFECTS ===== */\n+div.footer_blur {\n+ background-color: rgba(255, 255, 255, 0.125);\n+ backdrop-filter: blur(3px);\n+}\n+\n/* ===== SMALLEST BREAKPOINT ===== */\n@media (max-width: 1099px) {\ndiv.footer_grid {\n@@ -26,4 +70,12 @@ div.footer_grid {\n'subscribe_updates'\n'sitemap';\n}\n+\n+ div.footer_container {\n+ padding-top: 5%;\n+ }\n+ div.sitemap {\n+ padding-top: 60px;\n+ grid-area: sitemap;\n+ }\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -6,7 +6,6 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport footerStyles from './footer.css';\n-import commonStyles from './landing.css';\nimport type { LandingPageName } from './landing.react';\nimport SubscriptionForm from './subscription-form.react';\n@@ -16,18 +15,18 @@ type FooterProps = {\nfunction Footer(props: FooterProps): React.Node {\nconst { activePageName } = props;\nreturn (\n- <div className={commonStyles.footer_blur}>\n+ <div className={footerStyles.footer_blur}>\n<div className={footerStyles.footer_grid}>\n- <div className={commonStyles.sitemap}>\n- <div className={commonStyles.footer_logo}>\n+ <div className={footerStyles.sitemap}>\n+ <div className={footerStyles.footer_logo}>\n<Link to=\"/\">Comm</Link>\n</div>\n<div\nclassName={\nactivePageName === 'keyservers'\n- ? commonStyles.active_tab\n- : commonStyles.inactive_tab\n+ ? footerStyles.active_tab\n+ : footerStyles.inactive_tab\n}\n>\n<Link to=\"/keyservers\">Keyservers</Link>\n@@ -36,8 +35,8 @@ function Footer(props: FooterProps): React.Node {\n<div\nclassName={\nactivePageName === 'support'\n- ? commonStyles.active_tab\n- : commonStyles.inactive_tab\n+ ? footerStyles.active_tab\n+ : footerStyles.inactive_tab\n}\n>\n<Link to=\"/support\">Support</Link>\n@@ -46,8 +45,8 @@ function Footer(props: FooterProps): React.Node {\n<div\nclassName={\nactivePageName === 'terms'\n- ? commonStyles.active_tab\n- : commonStyles.inactive_tab\n+ ? footerStyles.active_tab\n+ : footerStyles.inactive_tab\n}\n>\n<Link to=\"/terms\">Terms of Use</Link>\n@@ -56,14 +55,14 @@ function Footer(props: FooterProps): React.Node {\n<div\nclassName={\nactivePageName === 'privacy'\n- ? commonStyles.active_tab\n- : commonStyles.inactive_tab\n+ ? footerStyles.active_tab\n+ : footerStyles.inactive_tab\n}\n>\n<Link to=\"/privacy\">Privacy Policy</Link>\n</div>\n- <div className={commonStyles.inactive_tab}>\n+ <div className={footerStyles.inactive_tab}>\n<a href=\"https://www.notion.so/How-Comm-works-d6217941db7c4237b9d08b427aef3234\">\nHow Comm works{' '}\n<FontAwesomeIcon\n@@ -74,7 +73,7 @@ function Footer(props: FooterProps): React.Node {\n</a>\n</div>\n</div>\n- <div className={commonStyles.subscribe_updates}>\n+ <div className={footerStyles.subscribe_updates}>\n<SubscriptionForm />\n</div>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -116,46 +116,6 @@ div.read_the_docs {\npadding-bottom: 40px;\n}\n-/* ===== CSS FOOTER GRID LAYOUT ===== */\n-\n-div.sitemap {\n- grid-area: sitemap;\n-}\n-\n-div.sitemap a {\n- display: block;\n- padding-bottom: 4px;\n- width: max-content;\n-}\n-\n-div.sitemap a.active_tab,\n-div.sitemap a:hover,\n-div.sitemap a:hover svg {\n- color: white;\n- transition: 300ms;\n-}\n-\n-div.sitemap .inactive_tab,\n-div.sitemap .inactive_tab svg {\n- color: #8a8f98;\n- transition: 300ms;\n-}\n-\n-div.footer_logo a {\n- font-size: 24px;\n- font-weight: 500;\n- color: white;\n- padding-bottom: 8px;\n-}\n-div.footer_logo a:hover {\n- color: #7e57c2;\n-}\n-\n-div.subscribe_updates {\n- grid-area: subscribe_updates;\n- align-self: center;\n-}\n-\n/* ===== APP LANDING GRID ===== */\ndiv.app_landing_grid {\ngrid-template-columns: 1fr 1fr;\n@@ -295,12 +255,6 @@ div.legal_container a:hover {\ncolor: #8c69c9;\n}\n-/* ===== VISUAL EFFECTS ===== */\n-div.footer_blur {\n- background-color: rgba(255, 255, 255, 0.125);\n- backdrop-filter: blur(3px);\n-}\n-\n/* ===== LAYOUT HACKS ===== */\ndiv.body_grid > div + .starting_section {\npadding-top: 80px;\n@@ -396,15 +350,6 @@ div.body_grid > div + .starting_section {\npadding-bottom: 0;\n}\n- /* ===== CSS FOOTER GRID LAYOUT ===== */\n- div.footer_container {\n- padding-top: 5%;\n- }\n- div.sitemap {\n- padding-top: 60px;\n- grid-area: sitemap;\n- }\n-\n/* ===== APP LANDING GRID LAYOUT ===== */\ndiv.app_landing_grid {\ngrid-template-areas:\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Move sitemap/subscription-form styles to `footer.css`
Summary: na, refactor
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2137 |
129,184 | 06.10.2021 11:45:13 | 14,400 | 553b4269067f46baba24f184941278df44088e9c | [landing] Fix sitemap link colors
Summary: The active/inactive links in the footer depended on styles intended for the header. This issue became clear after refactoring out the header and footer styles.
Test Plan:
Before:
After:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -31,16 +31,20 @@ div.sitemap a {\nwidth: max-content;\n}\n-div.sitemap a.active_tab,\n-div.sitemap a:hover,\n-div.sitemap a:hover svg {\n+div.inactive_tab a,\n+div.inactive_tab svg {\n+ color: #8a8f98;\n+ transition: 300ms;\n+}\n+\n+div.inactive_tab:hover a,\n+div.inactive_tab:hover svg {\ncolor: white;\ntransition: 300ms;\n}\n-div.sitemap .inactive_tab,\n-div.sitemap .inactive_tab svg {\n- color: #8a8f98;\n+.active_tab a {\n+ color: white;\ntransition: 300ms;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix sitemap link colors
Summary: The active/inactive links in the footer depended on styles intended for the header. This issue became clear after refactoring out the header and footer styles.
Test Plan:
Before: https://blob.sh/atul/d988.png
After: https://blob.sh/atul/9b26.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2141 |
129,184 | 06.10.2021 14:44:33 | 14,400 | cedcecc6f12aa00f90dd6b16a02dc4015f6964b5 | [server] Add iA Writer Duo to `local-fonts.css`
Summary: Include iA Writer Duo in `local-fonts` so we can use it for local development.
Test Plan: will test once prod is figured out
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": "server/fonts/iAWriterDuoS-Bold.woff2",
"new_path": "server/fonts/iAWriterDuoS-Bold.woff2",
"diff": "Binary files /dev/null and b/server/fonts/iAWriterDuoS-Bold.woff2 differ\n"
},
{
"change_type": "ADD",
"old_path": "server/fonts/iAWriterDuoS-BoldItalic.woff2",
"new_path": "server/fonts/iAWriterDuoS-BoldItalic.woff2",
"diff": "Binary files /dev/null and b/server/fonts/iAWriterDuoS-BoldItalic.woff2 differ\n"
},
{
"change_type": "ADD",
"old_path": "server/fonts/iAWriterDuoS-Italic.woff2",
"new_path": "server/fonts/iAWriterDuoS-Italic.woff2",
"diff": "Binary files /dev/null and b/server/fonts/iAWriterDuoS-Italic.woff2 differ\n"
},
{
"change_type": "ADD",
"old_path": "server/fonts/iAWriterDuoS-Regular.woff2",
"new_path": "server/fonts/iAWriterDuoS-Regular.woff2",
"diff": "Binary files /dev/null and b/server/fonts/iAWriterDuoS-Regular.woff2 differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/fonts/local-fonts.css",
"new_path": "server/fonts/local-fonts.css",
"diff": "font-weight: 500;\nsrc: local('IBM Plex Sans Medium'), local('IBMPlexSans-Medium'), url(IBMPlexSans-Medium.woff2) format('woff2');\n}\n+@font-face {\n+ font-family: 'iA Writer Duo S';\n+ font-style: normal;\n+ font-weight: normal;\n+ src: local('iA Writer Duo S Regular'), local('iAWriterDuoS-Regular'), url(iAWriterDuoS-Regular.woff2) format('woff2');\n+}\n+@font-face {\n+ font-family: 'iA Writer Duo S';\n+ font-style: italic;\n+ font-weight: normal;\n+ src: local('iA Writer Duo S Italic'), local('iAWriterDuoS-Italic'), url(iAWriterDuoS-Italic.woff2) format('woff2');\n+}\n+@font-face {\n+ font-family: 'iA Writer Duo S';\n+ font-style: normal;\n+ font-weight: bold;\n+ src: local('iA Writer Duo S Bold'), local('iAWriterDuoS-Bold'), url(iAWriterDuoS-Bold.woff2) format('woff2');\n+}\n+@font-face {\n+ font-family: 'iA Writer Duo S';\n+ font-style: italic;\n+ font-weight: bold;\n+ src: local('iA Writer Duo S Bold Italic'), local('iAWriterDuoS-BoldItalic'), url(iAWriterDuoS-BoldItalic.woff2) format('woff2');\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Add iA Writer Duo to `local-fonts.css`
Summary: Include iA Writer Duo in `local-fonts` so we can use it for local development.
Test Plan: will test once prod is figured out
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2143 |
129,184 | 07.10.2021 12:47:53 | 14,400 | 9c027265418fe91185f97d46fa24e4ad5e2df72b | [landing] Replace lorem ipsum with working copy
Summary:
Not the final copy, but better to work with than lorem ipsum
(the tile CSS is gross, that'll get cleaned up in later diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -149,21 +149,25 @@ div.tile_grid {\ndisplay: grid;\nmargin-right: 16%;\ngrid-template-columns: 1fr;\n- grid-template-rows: 1fr 1fr 1fr 1fr;\n+ grid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\nrow-gap: 4em;\npadding-top: 40px;\npadding-bottom: 40px;\ngrid-template-areas:\n- 'tile_tl'\n- 'tile_tr'\n- 'tile_bl'\n- 'tile_br';\n-}\n-\n-div.tile_tl,\n-div.tile_tr,\n-div.tile_bl,\n-div.tile_br {\n+ 'tile_one'\n+ 'tile_two'\n+ 'tile_three'\n+ 'tile_four'\n+ 'tile_five'\n+ 'tile_six';\n+}\n+\n+div.tile_one,\n+div.tile_two,\n+div.tile_three,\n+div.tile_four,\n+div.tile_five,\n+div.tile_six {\ndisplay: flex;\npadding: 24px;\nborder-radius: 8px;\n@@ -174,18 +178,22 @@ div.tile_br {\ntransition: 300ms;\n}\n-div.tile_tl:hover,\n-div.tile_tr:hover,\n-div.tile_bl:hover,\n-div.tile_br:hover {\n+div.tile_one:hover,\n+div.tile_two:hover,\n+div.tile_three:hover,\n+div.tile_four:hover,\n+div.tile_five:hover,\n+div.tile_six:hover {\nbackground-color: #7e57c2;\ntransition: 300ms;\n}\n-div.tile_tl p.tile_title,\n-div.tile_tr p.tile_title,\n-div.tile_bl p.tile_title,\n-div.tile_br p.tile_title {\n+div.tile_one p.tile_title,\n+div.tile_two p.tile_title,\n+div.tile_three p.tile_title,\n+div.tile_four p.tile_title,\n+div.tile_five p.tile_title,\n+div.tile_six p.tile_title {\nfont-weight: bold;\nfont-size: 28px;\ncolor: #485563;\n@@ -195,41 +203,55 @@ div.tile_br p.tile_title {\ntransition: 300ms;\n}\n-div.tile_tl p,\n-div.tile_tr p,\n-div.tile_bl p,\n-div.tile_br p {\n- font-size: 16px;\n+div.tile_one p,\n+div.tile_two p,\n+div.tile_three p,\n+div.tile_four p,\n+div.tile_five p,\n+div.tile_six p {\n+ font-size: 24px;\ncolor: #485563;\ntext-align: left;\nmargin-top: 10px;\nmargin-bottom: 0;\n+ margin-left: 20px;\n+ margin-right: 20px;\ntransition: 300ms;\n}\n-div.tile_tl:hover p,\n-div.tile_tr:hover p,\n-div.tile_bl:hover p,\n-div.tile_br:hover p,\n-div.tile_tl:hover svg,\n-div.tile_tr:hover svg,\n-div.tile_bl:hover svg,\n-div.tile_br:hover svg {\n+div.tile_one:hover p,\n+div.tile_two:hover p,\n+div.tile_three:hover p,\n+div.tile_four:hover p,\n+div.tile_five:hover p,\n+div.tile_six:hover p,\n+div.tile_one:hover svg,\n+div.tile_two:hover svg,\n+div.tile_three:hover svg,\n+div.tile_four:hover svg,\n+div.tile_five:hover svg,\n+div.tile_six:hover svg {\ncolor: #ebedee;\ntransition: 300ms;\n}\n-div.tile_tl {\n- grid-area: tile_tl;\n+div.tile_one {\n+ grid-area: tile_one;\n+}\n+div.tile_two {\n+ grid-area: tile_two;\n+}\n+div.tile_three {\n+ grid-area: tile_three;\n}\n-div.tile_tr {\n- grid-area: tile_tr;\n+div.tile_four {\n+ grid-area: tile_four;\n}\n-div.tile_bl {\n- grid-area: tile_bl;\n+div.tile_five {\n+ grid-area: tile_five;\n}\n-div.tile_br {\n- grid-area: tile_br;\n+div.tile_six {\n+ grid-area: tile_six;\n}\n/* ===== LEGAL PAGE STYLING ===== */\n@@ -294,10 +316,12 @@ div.body_grid > div + .starting_section {\nfont-size: 16px;\n}\n/* ===== APP LANDING GRID STYLING ===== */\n- div.tile_tl p,\n- div.tile_tr p,\n- div.tile_bl p,\n- div.tile_br p {\n+ div.tile_one p,\n+ div.tile_two p,\n+ div.tile_three p,\n+ div.tile_four p,\n+ div.tile_five p,\n+ div.tile_six p {\nfont-size: 16px;\n}\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace lorem ipsum with working copy
Summary:
Not the final copy, but better to work with than lorem ipsum
(the tile CSS is gross, that'll get cleaned up in later diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2161 |
129,184 | 07.10.2021 15:49:29 | 14,400 | 3e4435a36c5d822f83e5806ac6d2d3538cc140fe | [landing] Update cycling header text
Summary: Update copy and interval.
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -22,10 +22,12 @@ function AppLanding(): React.Node {\n<h1 className={css.mono}>\nComm is crypto-native chat for{' '}\n<TextLoop\n- interval={1000}\n+ interval={1750}\nspringConfig={{ stiffness: 180, damping: 16 }}\n>\n<span className={css.app_landing_subheading}>DAOs</span>\n+ <span className={css.app_landing_subheading}>art collectives</span>\n+ <span className={css.app_landing_subheading}>venture funds</span>\n<span className={css.app_landing_subheading}>open source</span>\n<span className={css.app_landing_subheading}>gaming guilds</span>\n<span className={css.app_landing_subheading}>social clubs</span>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -117,7 +117,7 @@ div.read_the_docs {\n/* ===== APP LANDING GRID ===== */\ndiv.app_landing_grid {\n- grid-template-columns: 1fr 1fr;\n+ grid-template-columns: 2fr 3fr;\ngrid-template-areas: 'app_preview app_copy';\npadding-top: 6vh;\npadding-bottom: 8vh;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update cycling header text
Summary: Update copy and interval.
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2163 |
129,184 | 07.10.2021 15:59:31 | 14,400 | a01dbe399de9aa5ab615bc652d02cfcb6b04a3e4 | [landing] Update `.app_copy` styling
Summary: Misc layout changes that set stage for introducing scroll snapping.
Test Plan: Looks as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -19,7 +19,7 @@ function AppLanding(): React.Node {\n<img src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1 className={css.mono}>\n+ <h1 className={css.cycling_header}>\nComm is crypto-native chat for{' '}\n<TextLoop\ninterval={1750}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -134,7 +134,7 @@ div.app_preview img {\nmax-width: 30vw;\nobject-fit: scale-down;\nposition: sticky;\n- top: 20vh;\n+ top: 18vh;\nleft: 0;\n}\n@@ -144,15 +144,20 @@ div.app_copy {\njustify-self: left;\n}\n+h1.cycling_header {\n+ font-family: 'iA Writer Duo S', monospace;\n+ padding-top: 26vh;\n+}\n+\n/* ===== TILE GRID STYLING ===== */\ndiv.tile_grid {\ndisplay: grid;\nmargin-right: 16%;\ngrid-template-columns: 1fr;\ngrid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\n- row-gap: 4em;\n- padding-top: 40px;\n- padding-bottom: 40px;\n+ row-gap: 20vh;\n+ margin-top: 32vh;\n+ margin-bottom: 32vh;\ngrid-template-areas:\n'tile_one'\n'tile_two'\n@@ -185,7 +190,7 @@ div.tile_four p.tile_title,\ndiv.tile_five p.tile_title,\ndiv.tile_six p.tile_title {\nfont-weight: bold;\n- font-size: 28px;\n+ font-size: 36px;\ncolor: #485563;\ntext-align: center;\nmargin-top: 10px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Update `.app_copy` styling
Summary: Misc layout changes that set stage for introducing scroll snapping.
Test Plan: Looks as expected: https://blob.sh/atul/f94c.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2165 |
129,184 | 07.10.2021 17:16:57 | 14,400 | 1117b47d97cf692712c4d1aa4c00e72d7a9667e1 | [landing] Include `StarBackground` in `AppLanding` page
Summary: To keep consistent with "Keyservers" page
Test Plan: Looks as expected:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -11,9 +11,12 @@ import * as React from 'react';\nimport TextLoop from 'react-text-loop';\nimport css from './landing.css';\n+import StarBackground from './star-background.react';\nfunction AppLanding(): React.Node {\nreturn (\n+ <>\n+ <StarBackground />\n<div className={css.app_landing_grid}>\n<div className={css.app_preview}>\n<img src=\"images/comm-screenshot.png\" />\n@@ -26,7 +29,9 @@ function AppLanding(): React.Node {\nspringConfig={{ stiffness: 180, damping: 16 }}\n>\n<span className={css.app_landing_subheading}>DAOs</span>\n- <span className={css.app_landing_subheading}>art collectives</span>\n+ <span className={css.app_landing_subheading}>\n+ art collectives\n+ </span>\n<span className={css.app_landing_subheading}>venture funds</span>\n<span className={css.app_landing_subheading}>open source</span>\n<span className={css.app_landing_subheading}>gaming guilds</span>\n@@ -42,16 +47,16 @@ function AppLanding(): React.Node {\n<p className={css.tile_title}>Federated</p>\n<p>\nComm is a protocol paired with an app. Each community hosts its\n- own backend, which we call a keyserver. Our keyserver software is\n- built to be forked.\n+ own backend, which we call a keyserver. Our keyserver software\n+ is built to be forked.\n</p>\n</div>\n<div className={css.tile_two}>\n<FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faServer} />\n<p className={css.tile_title}>Customizable</p>\n<p>\n- Write mini-apps and custom modules in React. Skin your community.\n- Customize your tabs and your home page.\n+ Write mini-apps and custom modules in React. Skin your\n+ community. Customize your tabs and your home page.\n</p>\n</div>\n<div className={css.tile_three}>\n@@ -89,6 +94,7 @@ function AppLanding(): React.Node {\n</div>\n</div>\n</div>\n+ </>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Include `StarBackground` in `AppLanding` page
Summary: To keep consistent with "Keyservers" page
Test Plan: Looks as expected: https://blob.sh/atul/112f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2166 |
129,179 | 10.10.2021 15:46:12 | 14,400 | c0b6ce49e9c639bb674617c77d6963c52a6d1c19 | update project.pbxproj file
Summary:
Update open ssl in project.pbxproj file.
Notion Task:
Test Plan: run yarn cleaninstall with updated cocoapods `1.11.2`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "inputPaths = (\n\"${PODS_ROOT}/Target Support Files/Pods-Comm/Pods-Comm-frameworks.sh\",\n\"${PODS_ROOT}/hermes-engine/destroot/Library/Frameworks/iphoneos/hermes.framework\",\n- \"${PODS_XCFRAMEWORKS_BUILD_DIR}/OpenSSL/OpenSSL.framework/OpenSSL\",\n+ \"${PODS_XCFRAMEWORKS_BUILD_DIR}/OpenSSL-Universal/OpenSSL.framework/OpenSSL\",\n);\nname = \"[CP] Embed Pods Frameworks\";\noutputPaths = (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | update project.pbxproj file
Summary:
Update open ssl in project.pbxproj file.
Notion Task: https://www.notion.so/commapp/Confirm-Build-Settings-in-Xcode-fe5394291aea4b56b360bb12a524b666
Test Plan: run yarn cleaninstall with updated cocoapods `1.11.2`
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2172 |
129,184 | 11.10.2021 12:43:21 | 14,400 | 5163d888a15fb7134fa2e8e2edcde991fbe2c088 | [landing] Increase "card" row-gap
Summary: Based on feedback from Friday's design meeting
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -167,7 +167,7 @@ div.tile_grid {\nmargin-right: 16%;\ngrid-template-columns: 1fr;\ngrid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\n- row-gap: 20vh;\n+ row-gap: 26vh;\nmargin-top: 32vh;\nmargin-bottom: 32vh;\ngrid-template-areas:\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Increase "card" row-gap
Summary: Based on feedback from Friday's design meeting
Test Plan: Here's how it looks: https://blob.sh/atul/am23.mov
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2174 |
129,184 | 11.10.2021 14:04:21 | 14,400 | 9996f8deae3ef6ace493ed0921ed75422d6b8edf | [landing] Put "card" icon and title on same row
Summary: Put the icon and card "header" on the same row as discussed
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -190,7 +190,6 @@ div.tile_six {\nborder-radius: 8px;\nbackground-color: #ebedee;\njustify-content: center;\n- align-items: center;\nflex-direction: column;\ntransition: 300ms;\nscroll-snap-align: center;\n@@ -205,12 +204,19 @@ div.tile_six p.tile_title {\nfont-weight: bold;\nfont-size: 36px;\ncolor: #485563;\n- text-align: center;\n- margin-top: 10px;\n- margin-bottom: 0;\ntransition: 300ms;\n}\n+div.tile_title_row {\n+ display: flex;\n+ flex-direction: row;\n+ align-items: center;\n+ align-content: center;\n+ justify-content: flex-start;\n+ margin-left: 20px;\n+ margin-right: 20px;\n+}\n+\ndiv.tile_one p,\ndiv.tile_two p,\ndiv.tile_three p,\n@@ -220,8 +226,8 @@ div.tile_six p {\nfont-size: 24px;\ncolor: #485563;\ntext-align: left;\n- margin-top: 10px;\n- margin-bottom: 0;\n+ margin-top: 0px;\n+ margin-bottom: 0px;\nmargin-left: 20px;\nmargin-right: 20px;\ntransition: 300ms;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Put "card" icon and title on same row
Summary: Put the icon and card "header" on the same row as discussed
Test Plan: Here's how it looks: https://blob.sh/atul/71ea.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2176 |
129,184 | 11.10.2021 14:29:16 | 14,400 | db06fe265085068b702f37d2892936279f342f63 | [landing] Use monospace font for card "title"
Summary: na
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -201,6 +201,7 @@ div.tile_three p.tile_title,\ndiv.tile_four p.tile_title,\ndiv.tile_five p.tile_title,\ndiv.tile_six p.tile_title {\n+ font-family: 'iA Writer Duo S', monospace;\nfont-weight: bold;\nfont-size: 36px;\ncolor: #485563;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Use monospace font for card "title"
Summary: na
Test Plan: Here's how it looks: https://blob.sh/atul/2f50.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2178 |
129,184 | 11.10.2021 14:43:45 | 14,400 | 5ebdafa2ed20b1e7ab84f56abaa7ff8e928bb00e | [landing] Give cards transparent "tint" and blur effect
Summary: Adjust card design as discussed
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -46,7 +46,7 @@ function AppLanding(): React.Node {\n<div className={css.tile_grid}>\n<div className={css.tile_one}>\n<div className={css.tile_title_row}>\n- <FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faUsers} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={faUsers} />\n<p className={css.tile_title}>Federated</p>\n</div>\n<p>\n@@ -57,7 +57,7 @@ function AppLanding(): React.Node {\n</div>\n<div className={css.tile_two}>\n<div className={css.tile_title_row}>\n- <FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faTools} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={faTools} />\n<p className={css.tile_title}>Customizable</p>\n</div>\n<p>\n@@ -67,7 +67,7 @@ function AppLanding(): React.Node {\n</div>\n<div className={css.tile_three}>\n<div className={css.tile_title_row}>\n- <FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faLock} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={faLock} />\n<p className={css.tile_title}>E2E-encrypted</p>\n</div>\n<p>\n@@ -79,7 +79,7 @@ function AppLanding(): React.Node {\n<div className={css.tile_title_row}>\n<FontAwesomeIcon\nsize=\"2x\"\n- color=\"#485563\"\n+ color=\"#ffffff\"\nicon={faUserShield}\n/>\n<p className={css.tile_title}>Sovereign</p>\n@@ -93,7 +93,7 @@ function AppLanding(): React.Node {\n<div className={css.tile_title_row}>\n<FontAwesomeIcon\nsize=\"2x\"\n- color=\"#485563\"\n+ color=\"#ffffff\"\nicon={faCodeBranch}\n/>\n<p className={css.tile_title}>Open Source</p>\n@@ -105,7 +105,7 @@ function AppLanding(): React.Node {\n</div>\n<div className={css.tile_six}>\n<div className={css.tile_title_row}>\n- <FontAwesomeIcon size=\"2x\" color=\"#485563\" icon={faBellSlash} />\n+ <FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={faBellSlash} />\n<p className={css.tile_title}>Less Noisy</p>\n</div>\n<p>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -67,7 +67,8 @@ div.subscribe_updates {\n/* ===== VISUAL EFFECTS ===== */\ndiv.footer_blur {\nbackground-color: rgba(255, 255, 255, 0.125);\n- backdrop-filter: blur(3px);\n+ backdrop-filter: blur(2px);\n+ -webkit-backdrop-filter: blur(2px);\n}\n/* ===== SMALLEST BREAKPOINT ===== */\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -193,6 +193,10 @@ div.tile_six {\nflex-direction: column;\ntransition: 300ms;\nscroll-snap-align: center;\n+ background-color: rgba(0, 0, 0, 0.35);\n+ backdrop-filter: blur(2px);\n+ -webkit-backdrop-filter: blur(2px);\n+ transition: 300ms;\n}\ndiv.tile_one p.tile_title,\n@@ -204,7 +208,7 @@ div.tile_six p.tile_title {\nfont-family: 'iA Writer Duo S', monospace;\nfont-weight: bold;\nfont-size: 36px;\n- color: #485563;\n+ color: white;\ntransition: 300ms;\n}\n@@ -225,7 +229,7 @@ div.tile_four p,\ndiv.tile_five p,\ndiv.tile_six p {\nfont-size: 24px;\n- color: #485563;\n+ color: white;\ntext-align: left;\nmargin-top: 0px;\nmargin-bottom: 0px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Give cards transparent "tint" and blur effect
Summary: Adjust card design as discussed
Test Plan: Here's what it looks like: https://blob.sh/atul/f7c5.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2179 |
129,184 | 11.10.2021 15:49:27 | 14,400 | edb0a93e414e2a4cb62a101fed70886586651e28 | [landing] Adjust `request_access` responsiveness
Summary: Basically don't want the "Request Access" button to break into two lines right before smallest breakpoint.
Test Plan: Here's how it looks right before smallest breakpoint:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -88,7 +88,7 @@ div.request_access:hover {\n}\ndiv.request_access p {\n- font-size: 16px;\n+ font-size: 14px;\nfont-weight: bold;\nline-height: 2.5;\n}\n@@ -136,6 +136,16 @@ div.github_icon h1 {\nfont-size: 32px;\n}\n+@media (max-width: 1499px) {\n+ div.request_access p {\n+ font-size: 11px;\n+ }\n+ div.request_access {\n+ padding-inline: 10px;\n+ margin-right: 10px;\n+ }\n+}\n+\n/* ===== SMALLEST BREAKPOINT ===== */\n@media (max-width: 1099px) {\ndiv.twitter_icon,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Adjust `request_access` responsiveness
Summary: Basically don't want the "Request Access" button to break into two lines right before smallest breakpoint.
Test Plan: Here's how it looks right before smallest breakpoint: https://blob.sh/atul/1a23.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2180 |
129,184 | 11.10.2021 17:24:41 | 14,400 | 90eda1d72a7fd49db6390d9fe6a61f145ffae36a | [landing] Modify "think web3 discord" subheading to match design
Summary:
Make text purple as in design
Also adjusted font sizes so everything looked as expected on iphone 12 mini:
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -61,6 +61,8 @@ span.app_landing_subheading {\np.app_landing_subheading {\nfont-family: 'iA Writer Duo S', monospace;\n+ color: #7e57c2;\n+ font-size: 32px;\n}\nspan.purple_accent {\n@@ -414,7 +416,7 @@ div.body_grid > div + .starting_section {\nh1.cycling_header {\nfont-family: 'iA Writer Duo S', monospace;\nmargin-top: 4vh;\n- font-size: 24px;\n+ font-size: 22px;\ntext-align: center;\n}\n@@ -423,6 +425,10 @@ div.body_grid > div + .starting_section {\ntext-align: center;\n}\n+ p.app_landing_subheading {\n+ font-size: 18px;\n+ }\n+\ndiv.tile_grid {\nrow-gap: 4vh;\npadding-left: 3%;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Modify "think web3 discord" subheading to match design
Summary:
Make text purple as in design
Also adjusted font sizes so everything looked as expected on iphone 12 mini: https://blob.sh/atul/ae40.png
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2182 |
129,190 | 12.10.2021 11:36:06 | -7,200 | e7af587d5a8cb677f9f6c04a99d25798ddc8f6ae | [native] Fix random string signs for secure random
Summary: in response to now the length is 64.
Test Plan: -
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/CryptoTools/Tools.cpp",
"new_path": "native/cpp/CommonCpp/CryptoTools/Tools.cpp",
"diff": "@@ -8,7 +8,7 @@ namespace crypto {\nstd::string Tools::generateRandomString(size_t size) {\nstatic std::string availableSigns =\n- \" 0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ\";\n+ \" 0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ_\";\nstd::string result;\nOlmBuffer buff;\nPlatformSpecificTools::generateSecureRandomBytes(buff, size);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix random string signs for secure random
Summary: in response to https://phabricator.ashoat.com/D2126#49597 now the length is 64.
Test Plan: -
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2173 |
129,184 | 12.10.2021 15:47:13 | 14,400 | 04fea8d18fb59489b39c28be49bf4649ed206f18 | [landing] Include `react-waypoint` dependency
Summary:
GitHub:
After struggling with `react-scrollama`, `scrollama`, and `scrollmagic`... this worked great out of the box w/ SSR
Test Plan: Added "waypoints" to `AppLanding`, logged `onPositionChange`, and verified it worked as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"@fortawesome/free-brands-svg-icons\": \"^5.15.4\",\n\"@fortawesome/react-fontawesome\": \"^0.1.5\",\n\"react-text-loop\": \"^2.3.0\",\n+ \"react-waypoint\": \"^10.1.0\",\n\"@lottiefiles/lottie-interactivity\": \"^0.1.4\",\n\"@lottiefiles/lottie-player\": \"^1.0.3\",\n\"core-js\": \"^3.6.5\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "dependencies:\nregenerator-runtime \"^0.13.4\"\n+\"@babel/runtime@^7.12.5\":\n+ version \"7.15.4\"\n+ resolved \"https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.15.4.tgz#fd17d16bfdf878e6dd02d19753a39fa8a8d9c84a\"\n+ integrity sha512-99catp6bHCaxr4sJ/DbTGgHS4+Rs2RVd2g7iOap6SLGPDknRK9ztKNsE/Fg6QhSeh1FGE5f6gHGQmvvn3I3xhw==\n+ dependencies:\n+ regenerator-runtime \"^0.13.4\"\n+\n\"@babel/runtime@^7.13.10\":\nversion \"7.13.10\"\nresolved \"https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.13.10.tgz#47d42a57b6095f4468da440388fdbad8bebf0d7d\"\n@@ -5906,6 +5913,11 @@ console-control-strings@^1.0.0, console-control-strings@~1.1.0:\nresolved \"https://registry.yarnpkg.com/console-control-strings/-/console-control-strings-1.1.0.tgz#3d7cf4464db6446ea644bf4b39507f9851008e8e\"\nintegrity sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4=\n+\"consolidated-events@^1.1.0 || ^2.0.0\":\n+ version \"2.0.2\"\n+ resolved \"https://registry.yarnpkg.com/consolidated-events/-/consolidated-events-2.0.2.tgz#da8d8f8c2b232831413d9e190dc11669c79f4a91\"\n+ integrity sha512-2/uRVMdRypf5z/TW/ncD/66l75P5hH2vM/GR8Jf8HLc2xnfJtmina6F6du8+v4Z2vTrMo7jC+W1tmEEuuELgkQ==\n+\nconst-max-uint32@^1.0.2:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/const-max-uint32/-/const-max-uint32-1.0.2.tgz#f009bb6230e678ed874dd2d6a9cd9e3cbfabb676\"\n@@ -13718,7 +13730,7 @@ prompts@^2.4.0:\nkleur \"^3.0.3\"\nsisteransi \"^1.0.5\"\n-prop-types@^15.5.10, prop-types@^15.5.8, prop-types@^15.6.1, prop-types@^15.6.2, prop-types@^15.7.2:\n+prop-types@^15.0.0, prop-types@^15.5.10, prop-types@^15.5.8, prop-types@^15.6.1, prop-types@^15.6.2, prop-types@^15.7.2:\nversion \"15.7.2\"\nresolved \"https://registry.yarnpkg.com/prop-types/-/prop-types-15.7.2.tgz#52c41e75b8c87e72b9d9360e0206b99dcbffa6c5\"\nintegrity sha512-8QQikdH7//R2vurIJSutZ1smHYTcLpRWEOlHnzcWHmBYrOGUysKwSsrC89BCiFj3CbrfJ/nXFdJepOVrY1GCHQ==\n@@ -14454,6 +14466,16 @@ react-timeago@^5.2.0:\nresolved \"https://registry.yarnpkg.com/react-timeago/-/react-timeago-5.2.0.tgz#d655d40aa55e4fe08a92234481a6aea7f656ab5d\"\nintegrity sha512-wCEEDGQHMdFh/PLp+Hj5vk9ZoC4KjQ5u0u6+KrrY9rny5LqJ2gZvNNEAS4mhSZDV1i7JLgQI5VQTAux7f+vj2w==\n+react-waypoint@^10.1.0:\n+ version \"10.1.0\"\n+ resolved \"https://registry.yarnpkg.com/react-waypoint/-/react-waypoint-10.1.0.tgz#6ab522a61bd52946260e4a78b3182759a97b40ec\"\n+ integrity sha512-wiVF0lTslVm27xHbnvUUADUrcDjrQxAp9lEYGExvcoEBScYbXu3Kt++pLrfj6CqOeeRAL4HcX8aANVLSn6bK0Q==\n+ dependencies:\n+ \"@babel/runtime\" \"^7.12.5\"\n+ consolidated-events \"^1.1.0 || ^2.0.0\"\n+ prop-types \"^15.0.0\"\n+ react-is \"^17.0.1\"\n+\nreact@17.0.1:\nversion \"17.0.1\"\nresolved \"https://registry.yarnpkg.com/react/-/react-17.0.1.tgz#6e0600416bd57574e3f86d92edba3d9008726127\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Include `react-waypoint` dependency
Summary:
GitHub: https://github.com/civiccc/react-waypoint
After struggling with `react-scrollama`, `scrollama`, and `scrollmagic`... this worked great out of the box w/ SSR
Test Plan: Added "waypoints" to `AppLanding`, logged `onPositionChange`, and verified it worked as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2185 |
129,184 | 12.10.2021 16:05:18 | 14,400 | b8f7372ae3496c9a8b6aab2ef3b52d5b9a16de46 | [landing] Introduce `active_card` style
Summary:
Style for "active" info card
In next diff will use `react-waypoint` to conditionally apply style to "active" card
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -44,7 +44,7 @@ function AppLanding(): React.Node {\n(think "Web3 Discord")\n</p>\n<div className={css.tile_grid}>\n- <div className={css.tile_one}>\n+ <div className={`${css.tile_one} ${css.active_card}`}>\n<div className={css.tile_title_row}>\n<FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={faUsers} />\n<p className={css.tile_title}>Federated</p>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -203,6 +203,10 @@ div.tile_six {\ntransition: 300ms;\n}\n+.active_card {\n+ box-shadow: 0px 20px 50px rgba(126, 87, 194, 0.5);\n+}\n+\ndiv.tile_one p.tile_title,\ndiv.tile_two p.tile_title,\ndiv.tile_three p.tile_title,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Introduce `active_card` style
Summary:
Style for "active" info card
In next diff will use `react-waypoint` to conditionally apply style to "active" card
Test Plan: Here's how it looks: https://blob.sh/atul/ae35.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2186 |
129,184 | 13.10.2021 16:18:55 | 14,400 | 0422ad22c2f31c256317cb0043f72f7867b350fa | [landing] Absolutely position `StarBackground` and slow animation
Summary: NA
Test Plan: Here's how it looks:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/star-background.css",
"new_path": "landing/star-background.css",
"diff": "+div.star_container {\n+ position: absolute;\n+}\n+\n@keyframes parallax {\nfrom {\ntransform: translateY(0px);\n@@ -11,7 +15,7 @@ div.stars_small {\nwidth: 1px;\nheight: 1px;\nborder-radius: 1px;\n- animation: parallax 120s linear infinite;\n+ animation: parallax 240s linear infinite;\nbox-shadow: 469px 4282px #fff, 217px 1548px #fff, 3669px 4093px #fff,\n2939px 2328px #fff, 5674px 888px #fff, 595px 3862px #fff, 5444px 2204px #fff,\n2349px 1286px #fff, 4863px 4319px #fff, 1095px 5033px #fff,\n@@ -433,7 +437,7 @@ div.stars_medium {\nwidth: 2px;\nheight: 2px;\nborder-radius: 2px;\n- animation: parallax 90s linear infinite;\n+ animation: parallax 180s linear infinite;\nbox-shadow: 317px 5695px #fff, 1413px 5752px #fff, 858px 2611px #fff,\n3927px 1754px #fff, 3024px 4972px #fff, 3816px 1466px #fff,\n5168px 4275px #fff, 1536px 2975px #fff, 5132px 2366px #fff,\n@@ -620,7 +624,7 @@ div.stars_large {\nwidth: 3px;\nheight: 3px;\nborder-radius: 3px;\n- animation: parallax 60s linear infinite;\n+ animation: parallax 120s linear infinite;\nbox-shadow: 173px 936px #fff, 3525px 2100px #fff, 4399px 5277px #fff,\n2194px 3207px #fff, 4079px 440px #fff, 2478px 1461px #fff,\n3704px 1493px #fff, 2854px 4604px #fff, 5213px 2574px #fff,\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/star-background.react.js",
"new_path": "landing/star-background.react.js",
"diff": "@@ -6,7 +6,7 @@ import css from './star-background.css';\nfunction StarBackground(): React.Node {\nreturn (\n- <div>\n+ <div className={css.star_container}>\n<div className={css.stars_small} />\n<div className={css.stars_medium} />\n<div className={css.stars_large} />\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Absolutely position `StarBackground` and slow animation
Summary: NA
Test Plan: Here's how it looks: https://watch.videodelivery.net/f983e2bc2d327065faa984e547b763d0
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2204 |
129,184 | 13.10.2021 14:29:44 | 14,400 | 7d79131422a201064f1226aaa922fe8679564131 | [landing] Miscellaneous `InfoCard` styling tweaks
Summary:
More padding b/w header and description
Increased `row-gap`
Increased card padding
Test Plan: Here's what it looks like:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -63,6 +63,7 @@ p.app_landing_subheading {\nfont-family: 'iA Writer Duo S', monospace;\ncolor: #7e57c2;\nfont-size: 32px;\n+ padding-inline: 0px;\n}\nspan.purple_accent {\n@@ -171,9 +172,9 @@ div.tile_grid {\nmargin-right: 16%;\ngrid-template-columns: 1fr;\ngrid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\n- row-gap: 26vh;\n- margin-top: 32vh;\n- margin-bottom: 32vh;\n+ row-gap: 40vh;\n+ margin-top: 36vh;\n+ margin-bottom: 36vh;\ngrid-template-areas:\n'tile_one'\n'tile_two'\n@@ -190,7 +191,7 @@ div.tile_four,\ndiv.tile_five,\ndiv.tile_six {\ndisplay: flex;\n- padding: 24px;\n+ padding: 36px;\nborder-radius: 8px;\nbackground-color: #ebedee;\njustify-content: center;\n@@ -228,6 +229,7 @@ div.tile_title_row {\njustify-content: flex-start;\nmargin-left: 20px;\nmargin-right: 20px;\n+ padding-bottom: 20px;\n}\ndiv.tile_one p,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Miscellaneous `InfoCard` styling tweaks
Summary:
- More padding b/w header and description
- Increased `row-gap`
- Increased card padding
Test Plan: Here's what it looks like: https://blob.sh/atul/c925.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2202 |
129,184 | 13.10.2021 13:03:57 | 14,400 | 1ff11b66ae70385bda582e04bb3d0773541b61c7 | [landing] Introduce `InfoCard` component and use in `AppLanding`
Summary: Will help avoid the boilerplate in D2187
Test Plan: Continues to look as before
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/info-card.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from './landing.css';\n+\n+type InfoCardProps = {\n+ +label: string,\n+ +active: boolean,\n+ +icon: React.Node,\n+ +description: string,\n+ +baseStyle: string,\n+};\n+function InfoCard(props: InfoCardProps): React.Node {\n+ const { label, active, icon, description, baseStyle } = props;\n+ return (\n+ <div className={active ? `${baseStyle} ${css.active_card}` : baseStyle}>\n+ <div className={css.tile_title_row}>\n+ {icon}\n+ <p className={css.tile_title}>{label}</p>\n+ </div>\n+ <p>{description}</p>\n+ </div>\n+ );\n+}\n+\n+export default InfoCard;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Introduce `InfoCard` component and use in `AppLanding`
Summary: Will help avoid the boilerplate in D2187
Test Plan: Continues to look as before
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2198 |
129,184 | 13.10.2021 13:13:31 | 14,400 | f08977a7b73357b9438886d7ab020d1f754ee49b | [landing] Pull `CyclingHeader` component out of `AppLanding`
Summary: Simple refactor to clean things up a little
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -10,8 +10,8 @@ import {\n} from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\n-import TextLoop from 'react-text-loop';\n+import CyclingHeader from './cycling-header.react';\nimport InfoCard from './info-card.react';\nimport css from './landing.css';\nimport StarBackground from './star-background.react';\n@@ -25,22 +25,7 @@ function AppLanding(): React.Node {\n<img src=\"images/comm-screenshot.png\" />\n</div>\n<div className={css.app_copy}>\n- <h1 className={css.cycling_header}>\n- {'Comm is crypto-native\\nchat for '}\n- <TextLoop\n- interval={1750}\n- springConfig={{ stiffness: 180, damping: 16 }}\n- >\n- <span className={css.app_landing_subheading}>DAOs</span>\n- <span className={css.app_landing_subheading}>\n- art collectives\n- </span>\n- <span className={css.app_landing_subheading}>venture funds</span>\n- <span className={css.app_landing_subheading}>open source</span>\n- <span className={css.app_landing_subheading}>gaming guilds</span>\n- <span className={css.app_landing_subheading}>social clubs</span>\n- </TextLoop>\n- </h1>\n+ <CyclingHeader />\n<p className={css.app_landing_subheading}>\n(think "Web3 Discord")\n</p>\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/cycling-header.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import TextLoop from 'react-text-loop';\n+\n+import css from './landing.css';\n+\n+function CyclingHeader(): React.Node {\n+ return (\n+ <h1 className={css.cycling_header}>\n+ {'Comm is crypto-native\\nchat for '}\n+ <TextLoop interval={1750} springConfig={{ stiffness: 180, damping: 16 }}>\n+ <span className={css.app_landing_subheading}>DAOs</span>\n+ <span className={css.app_landing_subheading}>art collectives</span>\n+ <span className={css.app_landing_subheading}>venture funds</span>\n+ <span className={css.app_landing_subheading}>open source</span>\n+ <span className={css.app_landing_subheading}>gaming guilds</span>\n+ <span className={css.app_landing_subheading}>social clubs</span>\n+ </TextLoop>\n+ </h1>\n+ );\n+}\n+\n+export default CyclingHeader;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pull `CyclingHeader` component out of `AppLanding`
Summary: Simple refactor to clean things up a little
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2199 |
129,184 | 13.10.2021 14:08:19 | 14,400 | 4e89f36067dfb7d8ba2b6b3259ae4c2e29770462 | [landing] Style active `InfoCard` on scroll
Summary: Moved "waypoint" logic from `AppLanding` to `InfoCard`
Test Plan: Continues to work as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "// @flow\nimport * as React from 'react';\n+import { Waypoint } from 'react-waypoint';\nimport css from './landing.css';\ntype InfoCardProps = {\n+ +idx: number,\n+label: string,\n- +active: boolean,\n+icon: React.Node,\n+description: string,\n+baseStyle: string,\n+ +activeCardIdx: number,\n+ +setActiveCardIdx: number => void,\n};\nfunction InfoCard(props: InfoCardProps): React.Node {\n- const { label, active, icon, description, baseStyle } = props;\n+ const {\n+ idx,\n+ label,\n+ icon,\n+ description,\n+ baseStyle,\n+ activeCardIdx,\n+ setActiveCardIdx,\n+ } = props;\n+\n+ const onTopPositionChange = React.useCallback(\n+ obj => {\n+ if (\n+ obj.previousPosition === 'above' &&\n+ obj.currentPosition === 'inside'\n+ ) {\n+ setActiveCardIdx(idx);\n+ } else if (\n+ obj.previousPosition === 'inside' &&\n+ obj.currentPosition === 'above'\n+ ) {\n+ setActiveCardIdx(idx + 1);\n+ }\n+ },\n+ [idx, setActiveCardIdx],\n+ );\n+\n+ const onBottomPositionChange = React.useCallback(\n+ obj => {\n+ if (\n+ obj.previousPosition === 'below' &&\n+ obj.currentPosition === 'inside'\n+ ) {\n+ setActiveCardIdx(idx);\n+ } else if (\n+ obj.previousPosition === 'inside' &&\n+ obj.currentPosition === 'below'\n+ ) {\n+ setActiveCardIdx(idx - 1);\n+ }\n+ },\n+ [idx, setActiveCardIdx],\n+ );\n+\nreturn (\n- <div className={active ? `${baseStyle} ${css.active_card}` : baseStyle}>\n+ <div\n+ className={\n+ activeCardIdx === idx ? `${baseStyle} ${css.active_card}` : baseStyle\n+ }\n+ >\n+ <Waypoint onPositionChange={onTopPositionChange} />\n<div className={css.tile_title_row}>\n{icon}\n<p className={css.tile_title}>{label}</p>\n</div>\n<p>{description}</p>\n+ <Waypoint onPositionChange={onBottomPositionChange} />\n</div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Style active `InfoCard` on scroll
Summary: Moved "waypoint" logic from `AppLanding` to `InfoCard`
Test Plan: Continues to work as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2200 |
129,179 | 13.10.2021 18:35:44 | 14,400 | 81b3268d3727132d7609dd09d30945c0ff54a00d | clean up from D2120 -- remove unneed code
Summary: Remove repetitive functions
Test Plan: run the code, make sure it works
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/reactotron.js",
"new_path": "native/reactotron.js",
"diff": "import AsyncStorage from '@react-native-community/async-storage';\n-import { fetchDevServerHostnameSync } from './utils/url-utils';\n+import { getDevServerHostname } from './utils/url-utils';\nlet reactotron: any = null;\nif (__DEV__) {\nconst { default: Reactotron } = require('reactotron-react-native');\nconst { reactotronRedux } = require('reactotron-redux');\n- reactotron = Reactotron.configure({ host: fetchDevServerHostnameSync() })\n+ reactotron = Reactotron.configure({ host: getDevServerHostname() })\n.setAsyncStorageHandler(AsyncStorage)\n.useReactNative()\n.use(reactotronRedux())\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/dev-tools.js",
"new_path": "native/redux/dev-tools.js",
"diff": "// @flow\n-import { fetchDevServerHostname } from '../utils/url-utils';\n+import { getDevServerHostname } from '../utils/url-utils';\nconst remoteReduxDevServerConfig = {\nport: 8043,\n@@ -16,7 +16,7 @@ if (__DEV__ && global.HermesInternal && !global.__REDUX_DEVTOOLS_EXTENSION__) {\nconnect: ({ name }) =>\nconnect({\nname,\n- hostname: fetchDevServerHostname(),\n+ hostname: getDevServerHostname(),\n...remoteReduxDevServerConfig,\n}),\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/redux-setup.js",
"new_path": "native/redux/redux-setup.js",
"diff": "@@ -42,7 +42,7 @@ import {\ndefaultURLPrefix,\nnatNodeServer,\nsetCustomServer,\n- fetchDevServerHostname,\n+ getDevServerHostname,\n} from '../utils/url-utils';\nimport {\nresetUserStateActionType,\n@@ -380,7 +380,7 @@ if (__DEV__ && global.HermesInternal) {\nconst { composeWithDevTools } = require('remote-redux-devtools/src');\ncomposeFunc = composeWithDevTools({\nname: 'Redux',\n- hostname: fetchDevServerHostname(),\n+ hostname: getDevServerHostname(),\n...remoteReduxDevServerConfig,\n});\n} else if (global.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__) {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/utils/url-utils.js",
"new_path": "native/utils/url-utils.js",
"diff": "@@ -35,16 +35,6 @@ function getDevNodeServerURL(): string {\nreturn getDevNodeServerURLFromHostname(hostname);\n}\n-function fetchDevServerHostname(): string {\n- invariant(__DEV__, 'fetchDevServerHostname called from production');\n- return getDevServerHostname();\n-}\n-\n-function fetchDevServerHostnameSync(): string {\n- invariant(__DEV__, 'fetchDevServerHostnameSync called from production');\n- return getDevServerHostname();\n-}\n-\nconst nodeServerOptions = [productionNodeServerURL];\nif (Platform.OS === 'android') {\nnodeServerOptions.push(\n@@ -64,8 +54,7 @@ const setCustomServer = 'SET_CUSTOM_SERVER';\nexport {\ndefaultURLPrefix,\n- fetchDevServerHostname,\n- fetchDevServerHostnameSync,\n+ getDevServerHostname,\nnodeServerOptions,\nnatNodeServer,\nsetCustomServer,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | clean up from D2120 -- remove unneed code
Summary: Remove repetitive functions
Test Plan: run the code, make sure it works
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2205 |
129,184 | 14.10.2021 11:58:12 | 14,400 | ef0cf780729a77599ecd5fc66b36c84ea9f5fa03 | [landing] Pass icon to `InfoCard` as `IconDefinition` instead of `React.Node`
Summary: Addressed feedback from D2198
Test Plan: Continues to look as expected (after force restart)
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "// @flow\n+import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { Waypoint } from 'react-waypoint';\n@@ -9,7 +10,7 @@ type InfoCardProps = {\n+idx: number,\n+active: boolean,\n+label: string,\n- +icon: React.Node,\n+ +icon: mixed,\n+description: string,\n+baseStyle: string,\n+setActiveCardIdx: number => void,\n@@ -63,7 +64,7 @@ function InfoCard(props: InfoCardProps): React.Node {\n<div className={active ? `${baseStyle} ${css.active_card}` : baseStyle}>\n<Waypoint onPositionChange={onTopPositionChange} />\n<div className={css.tile_title_row}>\n- {icon}\n+ <FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={icon} />\n<p className={css.tile_title}>{label}</p>\n</div>\n<p>{description}</p>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Pass icon to `InfoCard` as `IconDefinition` instead of `React.Node`
Summary: Addressed feedback from D2198
Test Plan: Continues to look as expected (after force restart)
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac
Differential Revision: https://phabricator.ashoat.com/D2214 |
129,184 | 14.10.2021 16:27:39 | 14,400 | 862c9696c162ed452241f157b0878063e77713f3 | [native] Update `native/package.json` clean scripts
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n\"clean\": \"yarn clean-android && yarn clean-ios && rm -rf node_modules/\",\n- \"clean-android\": \"cd android && ./gradlew clean && rm -rf build app/build app/.cxx\",\n- \"clean-ios\": \"rm -rf ios/Pods/ ~/Library/Developer/Xcode/DerivedData/Comm-*\",\n+ \"clean-android\": \"cd android && rm -rf build app/build app/.cxx\",\n+ \"clean-ios\": \"rm -rf ios/Pods/\",\n+ \"clean-all\": \"yarn clean && rm -rf ~/Library/Developer/Xcode/DerivedData/Comm-*; (./gradlew clean || true)\",\n\"postinstall\": \"cd ../ && echo '{\\\"name\\\": \\\"olm\\\", \\\"version\\\": \\\"3.2.4\\\"}' > ./node_modules/olm/package.json && yarn patch-package && yarn flow-mono create-symlinks native && cd native && yarn jetify && npx pod-patch && cd ios && (pod install || true)\",\n\"start\": \"yarn react-native start\",\n\"dev\": \"yarn concurrently --names=\\\"REDUX,METRO\\\" -c \\\"bgGreen.bold,bgBlue.bold\\\" \\\"yarn remotedev\\\" \\\"yarn start\\\"\",\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Update `native/package.json` clean scripts
Summary: na
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2217 |
129,184 | 14.10.2021 18:01:38 | 14,400 | 6c91bb43a6ac8dfa05d47d29ed4d3d709a46cf90 | [landing] Replace prototype assets with higher resolution ones
Summary:
NA, swapping out PNGs
(will address blurry downscaled images in separate diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/images/customizable-prototype.png",
"new_path": "server/images/customizable-prototype.png",
"diff": "Binary files a/server/images/customizable-prototype.png and b/server/images/customizable-prototype.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/images/e2e-encrypted-prototype.png",
"new_path": "server/images/e2e-encrypted-prototype.png",
"diff": "Binary files a/server/images/e2e-encrypted-prototype.png and b/server/images/e2e-encrypted-prototype.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/images/federated-prototype.png",
"new_path": "server/images/federated-prototype.png",
"diff": "Binary files a/server/images/federated-prototype.png and b/server/images/federated-prototype.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/images/less-noisy-prototype.png",
"new_path": "server/images/less-noisy-prototype.png",
"diff": "Binary files a/server/images/less-noisy-prototype.png and b/server/images/less-noisy-prototype.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/images/open-source-prototype.png",
"new_path": "server/images/open-source-prototype.png",
"diff": "Binary files a/server/images/open-source-prototype.png and b/server/images/open-source-prototype.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/images/sovereign-prototype.png",
"new_path": "server/images/sovereign-prototype.png",
"diff": "Binary files a/server/images/sovereign-prototype.png and b/server/images/sovereign-prototype.png differ\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Replace prototype assets with higher resolution ones
Summary:
NA, swapping out PNGs
(will address blurry downscaled images in separate diff)
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2218 |
129,184 | 14.10.2021 18:14:26 | 14,400 | bd91b470e748c1877aa16a0e9e737e4d881c0896 | [landing] Fix issue with blurry downscaled images
Summary: Solution via GoojajiGreg on StackOverflow:
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -33,6 +33,20 @@ a {\nmargin-bottom: 0;\n}\n+@media screen and (-webkit-min-device-pixel-ratio: 0) and (min-resolution: 0.001dpcm) {\n+ img {\n+ image-rendering: -webkit-optimize-contrast !important;\n+ }\n+}\n+\n+@media not all and (min-resolution: 0.001dpcm) {\n+ @supports (-webkit-appearance: none) and (stroke-color: transparent) {\n+ img {\n+ image-rendering: unset !important;\n+ }\n+ }\n+}\n+\n/* ===== TEXT STYLES ===== */\nh1 {\nfont-size: 58px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Fix issue with blurry downscaled images
Summary: Solution via GoojajiGreg on StackOverflow: https://stackoverflow.com/questions/37906602/blurry-downscaled-images-in-chrome/69137897#69137897
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2220 |
129,190 | 14.10.2021 10:36:23 | -7,200 | 672fe9843eee90a6ad0485e190460b4a7a1857b4 | [services] Fix make -j
Summary: I noticed there are some errors using `-j` flag.
Test Plan: `cd services && yarn run-grpc-server`
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/contents/server/build.sh",
"new_path": "services/tunnelbroker/contents/server/build.sh",
"diff": "set -e\n-echo \"building the server...\"\n+NPROC=0\n+\n+NPROC=$(nproc 2> /dev/null || echo 1)\n+if [[ $NPROC -eq 1 ]]\n+then\n+ NPROC=$(sysctl -n hw.physicalcpu 2> /dev/null || echo 1)\n+fi\n+\n+echo \"building the server (nproc=$NPROC)...\"\npushd cmake/build\ncmake ../..\n-make -j 2> /dev/null || (echo \"failed to make with -j option, falling back to slower compilation\" && make)\n+make -j $NPROC\npopd\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Fix make -j
Summary: I noticed there are some errors using `-j` flag.
Test Plan: `cd services && yarn run-grpc-server`
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2189 |
129,187 | 14.10.2021 19:04:05 | 14,400 | b0da13ca1b42156aaeb7d571df348d19aee5ee6b | [native] cd android before ./gradlew clean in yarn clean-all
Test Plan: Run it
Reviewers: atul, geekbrother, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"clean\": \"yarn clean-android && yarn clean-ios && rm -rf node_modules/\",\n\"clean-android\": \"cd android && rm -rf build app/build app/.cxx\",\n\"clean-ios\": \"rm -rf ios/Pods/\",\n- \"clean-all\": \"yarn clean && rm -rf ~/Library/Developer/Xcode/DerivedData/Comm-*; (./gradlew clean || true)\",\n+ \"clean-all\": \"yarn clean && rm -rf ~/Library/Developer/Xcode/DerivedData/Comm-*; cd android && (./gradlew clean || true)\",\n\"postinstall\": \"cd ../ && echo '{\\\"name\\\": \\\"olm\\\", \\\"version\\\": \\\"3.2.4\\\"}' > ./node_modules/olm/package.json && yarn patch-package && yarn flow-mono create-symlinks native && cd native && yarn jetify && npx pod-patch && cd ios && (pod install || true)\",\n\"start\": \"yarn react-native start\",\n\"dev\": \"yarn concurrently --names=\\\"REDUX,METRO\\\" -c \\\"bgGreen.bold,bgBlue.bold\\\" \\\"yarn remotedev\\\" \\\"yarn start\\\"\",\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] cd android before ./gradlew clean in yarn clean-all
Test Plan: Run it
Reviewers: atul, geekbrother, palys-swm
Reviewed By: palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2221 |
129,187 | 14.10.2021 18:10:39 | 14,400 | 69d21088472f3074fab6a7cc6e05b955aaed78ac | [native] [expo-splash-screen-update] [2/4]
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"@react-navigation/stack\": \"^5.12.8\",\n\"base-64\": \"^0.1.0\",\n\"expo-haptics\": \"^10.1.0\",\n- \"expo-image-manipulator\": \"^8.4.0\",\n+ \"expo-image-manipulator\": \"^9.2.2\",\n\"expo-media-library\": \"^10.0.0\",\n\"expo-secure-store\": \"^10.2.0\",\n\"expo-splash-screen\": \"^0.3.1\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -8353,10 +8353,12 @@ expo-image-loader@~2.2.0:\nresolved \"https://registry.yarnpkg.com/expo-image-loader/-/expo-image-loader-2.2.0.tgz#b5d49ec65e576c033823050b223ef462c5ec5711\"\nintegrity sha512-kTs/lW8LUXYFQ5t8wkdJs0A41zd7dIB8uRRC0a9L0EurSGUvQWiVTbHQoLo/GYWL7nM85OaPAe2qkHfcz5KeyA==\n-expo-image-manipulator@^8.4.0:\n- version \"8.4.0\"\n- resolved \"https://registry.yarnpkg.com/expo-image-manipulator/-/expo-image-manipulator-8.4.0.tgz#1cc6187e6f582e3bc08b8e2139a33469bdb5a0e5\"\n- integrity sha512-9gje9wnFrNqMWGLK/fej3BmDnMPMjSmURJzCuVrHAkfQLGvhcW2dT8HIooQt+6/HDkiJ4pYI1X86mYTPiMV5Tw==\n+expo-image-manipulator@^9.2.2:\n+ version \"9.2.2\"\n+ resolved \"https://registry.yarnpkg.com/expo-image-manipulator/-/expo-image-manipulator-9.2.2.tgz#0fc7d2032972961c0a5fb49511d230fe0788fa6f\"\n+ integrity sha512-rnwUpLmySEhclES+632/vl4cBQyjWE16PdR003WxvN/YBynTlYIi7If2FZRFt5lktX0Rz988XVE89EavHPn2ug==\n+ dependencies:\n+ expo-modules-core \"~0.2.0\"\nexpo-media-library@^10.0.0:\nversion \"10.0.0\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [expo-splash-screen-update] [2/4] expo-image-manipulator@9.2.2
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2233 |
129,187 | 14.10.2021 18:15:44 | 14,400 | a30e4b3feaa10bbba96fc591392168f3a204ad1d | [native] [expo-splash-screen-update] [3/4]
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -356,6 +356,38 @@ PODS:\n- CocoaAsyncSocket (7.6.5)\n- DoubleConversion (1.1.6)\n- DVAssetLoaderDelegate (0.3.3)\n+ - EXConstants (11.0.2):\n+ - ExpoModulesCore\n+ - UMCore\n+ - EXFileSystem (11.1.3):\n+ - ExpoModulesCore\n+ - UMCore\n+ - EXHaptics (10.1.0):\n+ - UMCore\n+ - EXImageLoader (2.2.0):\n+ - ExpoModulesCore\n+ - React-Core\n+ - UMCore\n+ - EXImageManipulator (9.2.2):\n+ - ExpoModulesCore\n+ - UMCore\n+ - EXMediaLibrary (12.1.2):\n+ - ExpoModulesCore\n+ - React-Core\n+ - UMCore\n+ - ExpoModulesCore (0.2.0):\n+ - ExpoModulesCore/Core (= 0.2.0)\n+ - ExpoModulesCore/Interfaces (= 0.2.0)\n+ - UMCore\n+ - ExpoModulesCore/Core (0.2.0):\n+ - UMCore\n+ - ExpoModulesCore/Interfaces (0.2.0):\n+ - ExpoModulesCore/Core\n+ - UMCore\n+ - EXSecureStore (10.2.0):\n+ - UMCore\n+ - EXSplashScreen (0.3.1):\n+ - UMCore\n- FBLazyVector (0.64.2)\n- FBReactNativeSpec (0.64.2):\n- RCT-Folly (= 2021.04.26.00)\n@@ -880,12 +912,29 @@ PODS:\n- SQLCipher-Amalgamation/standard (4.4.3):\n- OpenSSL-Universal\n- SQLCipher-Amalgamation/common\n+ - UMAppLoader (2.2.0)\n+ - UMCore (7.1.2)\n+ - UMReactNativeAdapter (6.3.9):\n+ - ExpoModulesCore\n+ - React-Core\n+ - UMCore\n+ - UMTaskManagerInterface (6.2.0):\n+ - UMCore\n- Yoga (1.14.0)\n- YogaKit (1.18.1):\n- Yoga (~> 1.14)\nDEPENDENCIES:\n- DoubleConversion (from `../../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec`)\n+ - EXConstants (from `../../node_modules/expo-constants/ios`)\n+ - EXFileSystem (from `../../node_modules/expo-file-system/ios`)\n+ - EXHaptics (from `../../node_modules/expo-haptics/ios`)\n+ - EXImageLoader (from `../../node_modules/expo-image-loader/ios`)\n+ - EXImageManipulator (from `../../node_modules/expo-image-manipulator/ios`)\n+ - EXMediaLibrary (from `../../node_modules/expo-media-library/ios`)\n+ - ExpoModulesCore (from `../../node_modules/expo-modules-core/ios`)\n+ - EXSecureStore (from `../../node_modules/expo-secure-store/ios`)\n+ - EXSplashScreen (from `../../node_modules/expo-splash-screen/ios`)\n- FBLazyVector (from `../../node_modules/react-native/Libraries/FBLazyVector`)\n- FBReactNativeSpec (from `../../node_modules/react-native/React/FBReactNativeSpec`)\n- Flipper (= 0.98.0)\n@@ -971,6 +1020,10 @@ DEPENDENCIES:\n- RNSVG (from `../../node_modules/react-native-svg`)\n- RNVectorIcons (from `../../node_modules/react-native-vector-icons`)\n- \"SQLCipher-Amalgamation (from `../../node_modules/@commapp/sqlcipher-amalgamation`)\"\n+ - UMAppLoader (from `../../node_modules/unimodules-app-loader/ios`)\n+ - \"UMCore (from `../../node_modules/@unimodules/core/ios`)\"\n+ - \"UMReactNativeAdapter (from `../../node_modules/@unimodules/react-native-adapter/ios`)\"\n+ - UMTaskManagerInterface (from `../../node_modules/unimodules-task-manager-interface/ios`)\n- Yoga (from `../../node_modules/react-native/ReactCommon/yoga`)\nSPEC REPOS:\n@@ -1003,6 +1056,24 @@ SPEC REPOS:\nEXTERNAL SOURCES:\nDoubleConversion:\n:podspec: \"../../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec\"\n+ EXConstants:\n+ :path: \"../../node_modules/expo-constants/ios\"\n+ EXFileSystem:\n+ :path: \"../../node_modules/expo-file-system/ios\"\n+ EXHaptics:\n+ :path: \"../../node_modules/expo-haptics/ios\"\n+ EXImageLoader:\n+ :path: \"../../node_modules/expo-image-loader/ios\"\n+ EXImageManipulator:\n+ :path: \"../../node_modules/expo-image-manipulator/ios\"\n+ EXMediaLibrary:\n+ :path: \"../../node_modules/expo-media-library/ios\"\n+ ExpoModulesCore:\n+ :path: \"../../node_modules/expo-modules-core/ios\"\n+ EXSecureStore:\n+ :path: \"../../node_modules/expo-secure-store/ios\"\n+ EXSplashScreen:\n+ :path: \"../../node_modules/expo-splash-screen/ios\"\nFBLazyVector:\n:path: \"../../node_modules/react-native/Libraries/FBLazyVector\"\nFBReactNativeSpec:\n@@ -1123,6 +1194,14 @@ EXTERNAL SOURCES:\n:path: \"../../node_modules/react-native-vector-icons\"\nSQLCipher-Amalgamation:\n:path: \"../../node_modules/@commapp/sqlcipher-amalgamation\"\n+ UMAppLoader:\n+ :path: \"../../node_modules/unimodules-app-loader/ios\"\n+ UMCore:\n+ :path: \"../../node_modules/@unimodules/core/ios\"\n+ UMReactNativeAdapter:\n+ :path: \"../../node_modules/@unimodules/react-native-adapter/ios\"\n+ UMTaskManagerInterface:\n+ :path: \"../../node_modules/unimodules-task-manager-interface/ios\"\nYoga:\n:path: \"../../node_modules/react-native/ReactCommon/yoga\"\n@@ -1132,6 +1211,15 @@ SPEC CHECKSUMS:\nCocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99\nDoubleConversion: cf9b38bf0b2d048436d9a82ad2abe1404f11e7de\nDVAssetLoaderDelegate: 0caec20e4e08b8560b691131539e9180024d4bce\n+ EXConstants: 4cb52b6d8f636c767104a44bf7db3873e9c01a6f\n+ EXFileSystem: 0a04aba8da751b9ac954065911bcf166503f8267\n+ EXHaptics: 6dc4307ab0794fe7a87ec8d7d1c299cf103d6cb3\n+ EXImageLoader: d3531a3fe530b22925c19977cb53bb43e3821fe6\n+ EXImageManipulator: c9af8e8dc6543fdca23693eae280e388b2f93fb0\n+ EXMediaLibrary: c87254f83db976563e4ee54ee67eeb065570e92b\n+ ExpoModulesCore: 2734852616127a6c1fc23012197890a6f3763dc7\n+ EXSecureStore: 1aa80d49a3a101418bbd2675e2a0d32dceea10c2\n+ EXSplashScreen: c4ed5d39cd5dbc1329f8dec720e280276bafa28b\nFBLazyVector: e686045572151edef46010a6f819ade377dfeb4b\nFBReactNativeSpec: 00d3c44d268b294f240a43ff003e918ff9f510e2\nFlipper: 41c3f849a45fd5f57a30195d15becb8af7ed78ce\n@@ -1211,6 +1299,10 @@ SPEC CHECKSUMS:\nSDWebImageWebPCoder: d0dac55073088d24b2ac1b191a71a8f8d0adac21\nSPTPersistentCache: df36ea46762d7cf026502bbb86a8b79d0080dff4\nSQLCipher-Amalgamation: cbd36045fe7b458b8a442958a01aefdbc44c20f8\n+ UMAppLoader: 21af63390e55c82e037fb9752d93114a80ecf16e\n+ UMCore: ce3a4faa010239063b8343895b29a6d97b01069d\n+ UMReactNativeAdapter: d03cefd0e4e4179ab8c490408589f1c8a6c8b785\n+ UMTaskManagerInterface: 2be431101b73604e64fbfffcf759336f9d8fccbb\nYoga: 575c581c63e0d35c9a83f4b46d01d63abc1100ac\nYogaKit: f782866e155069a2cca2517aafea43200b01fd5a\n"
},
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"base-64\": \"^0.1.0\",\n\"expo-haptics\": \"^10.1.0\",\n\"expo-image-manipulator\": \"^9.2.2\",\n- \"expo-media-library\": \"^10.0.0\",\n+ \"expo-media-library\": \"^12.1.2\",\n\"expo-secure-store\": \"^10.2.0\",\n\"expo-splash-screen\": \"^0.3.1\",\n\"find-root\": \"^1.1.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -8360,10 +8360,13 @@ expo-image-manipulator@^9.2.2:\ndependencies:\nexpo-modules-core \"~0.2.0\"\n-expo-media-library@^10.0.0:\n- version \"10.0.0\"\n- resolved \"https://registry.yarnpkg.com/expo-media-library/-/expo-media-library-10.0.0.tgz#44ab985fa684a9cf5b23d50ac5874b61bfe779c7\"\n- integrity sha512-/edgaLU8ClYEgwmiMknpNbkouTNZlL/FNAxcSpPlTmXuRAqd2YmE5BpNOe1demDrR1VWTrZ8/ekS/RwQAWQU2g==\n+expo-media-library@^12.1.2:\n+ version \"12.1.2\"\n+ resolved \"https://registry.yarnpkg.com/expo-media-library/-/expo-media-library-12.1.2.tgz#7a152f5ddf9e5e55d07aa28c8a5bd04113c0ebd2\"\n+ integrity sha512-e2Wh3TD4N2JjmKFFiQ453QgWWARNqc1/vILkEVnxjs34uJmUoT4a89wromr6Xl2fZJUvJDmgmVmL+A9iBWFgaA==\n+ dependencies:\n+ \"@expo/config-plugins\" \"^3.0.0\"\n+ expo-modules-core \"~0.2.0\"\nexpo-modules-autolinking@^0.0.3:\nversion \"0.0.3\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [expo-splash-screen-update] [3/4] expo-media-library@12.1.2
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2234 |
129,187 | 15.10.2021 23:03:51 | 14,400 | a331f2dc16b22b9a84afeb84bf525cd408ed3ff4 | [native] [expo-splash-screen-update] [4/4]
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -490,6 +490,7 @@ android {\ndependencies {\nimplementation fileTree(dir: \"libs\", include: [\"*.jar\"])\n+ implementation \"org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.21\"\n//noinspection GradleDynamicVersion\nimplementation(\"com.facebook.react:react-native:+\")\n"
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/java/app/comm/android/MainActivity.java",
"new_path": "native/android/app/src/main/java/app/comm/android/MainActivity.java",
"diff": "@@ -7,8 +7,8 @@ import com.facebook.react.ReactActivityDelegate;\nimport com.facebook.react.ReactFragmentActivity;\nimport com.facebook.react.ReactRootView;\nimport com.swmansion.gesturehandler.react.RNGestureHandlerEnabledRootView;\n-import expo.modules.splashscreen.SplashScreen;\nimport expo.modules.splashscreen.SplashScreenImageResizeMode;\n+import expo.modules.splashscreen.singletons.SplashScreen;\npublic class MainActivity extends ReactFragmentActivity {\n@@ -25,7 +25,7 @@ public class MainActivity extends ReactFragmentActivity {\nprotected void onCreate(Bundle savedInstanceState) {\nsuper.onCreate(null);\nSplashScreen.show(\n- this, SplashScreenImageResizeMode.NATIVE, ReactRootView.class);\n+ this, SplashScreenImageResizeMode.NATIVE, ReactRootView.class, true);\n}\n@Override\n"
},
{
"change_type": "RENAME",
"old_path": "native/android/app/src/main/res/drawable/splashscreen_image.xml",
"new_path": "native/android/app/src/main/res/drawable/splashscreen.xml",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/main/res/values/styles.xml",
"new_path": "native/android/app/src/main/res/values/styles.xml",
"diff": "<style name=\"NoSplashTheme\" parent=\"SplashThemeBase\">\n</style>\n<style name=\"SplashTheme\" parent=\"NoSplashTheme\">\n- <item name=\"android:background\">@drawable/splashscreen_image</item>\n+ <item name=\"android:background\">@drawable/splashscreen</item>\n<item name=\"android:textColor\">#000000</item>\n</style>\n</resources>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -386,7 +386,8 @@ PODS:\n- UMCore\n- EXSecureStore (10.2.0):\n- UMCore\n- - EXSplashScreen (0.3.1):\n+ - EXSplashScreen (0.11.4):\n+ - React-Core\n- UMCore\n- FBLazyVector (0.64.2)\n- FBReactNativeSpec (0.64.2):\n@@ -1219,7 +1220,7 @@ SPEC CHECKSUMS:\nEXMediaLibrary: c87254f83db976563e4ee54ee67eeb065570e92b\nExpoModulesCore: 2734852616127a6c1fc23012197890a6f3763dc7\nEXSecureStore: 1aa80d49a3a101418bbd2675e2a0d32dceea10c2\n- EXSplashScreen: c4ed5d39cd5dbc1329f8dec720e280276bafa28b\n+ EXSplashScreen: 847e0d8026731c1090bf269ede3e15ac87d88958\nFBLazyVector: e686045572151edef46010a6f819ade377dfeb4b\nFBReactNativeSpec: 00d3c44d268b294f240a43ff003e918ff9f510e2\nFlipper: 41c3f849a45fd5f57a30195d15becb8af7ed78ce\n"
},
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"expo-image-manipulator\": \"^9.2.2\",\n\"expo-media-library\": \"^12.1.2\",\n\"expo-secure-store\": \"^10.2.0\",\n- \"expo-splash-screen\": \"^0.3.1\",\n+ \"expo-splash-screen\": \"^0.11.4\",\n\"find-root\": \"^1.1.0\",\n\"invariant\": \"^2.2.4\",\n\"lib\": \"0.0.1\",\n"
},
{
"change_type": "MODIFY",
"old_path": "native/root.react.js",
"new_path": "native/root.react.js",
"diff": "@@ -57,19 +57,13 @@ if (Platform.OS === 'android') {\nconst navInitAction = Object.freeze({ type: 'NAV/@@INIT' });\nconst navUnknownAction = Object.freeze({ type: 'NAV/@@UNKNOWN' });\n+SplashScreen.preventAutoHideAsync().catch(console.log);\n+\nfunction Root() {\nconst navStateRef = React.useRef();\nconst navDispatchRef = React.useRef();\nconst navStateInitializedRef = React.useRef(false);\n- React.useEffect(() => {\n- (async () => {\n- try {\n- await SplashScreen.preventAutoHideAsync();\n- } catch {}\n- })();\n- }, []);\n-\nconst [navContext, setNavContext] = React.useState(null);\nconst updateNavContext = React.useCallback(() => {\nif (\n"
},
{
"change_type": "DELETE",
"old_path": "patches/expo-splash-screen+0.3.1.patch",
"new_path": null,
"diff": "-diff --git a/node_modules/expo-splash-screen/android/src/main/java/expo/modules/splashscreen/SplashScreenController.kt b/node_modules/expo-splash-screen/android/src/main/java/expo/modules/splashscreen/SplashScreenController.kt\n-index 6496976..1e3550e 100644\n---- a/node_modules/expo-splash-screen/android/src/main/java/expo/modules/splashscreen/SplashScreenController.kt\n-+++ b/node_modules/expo-splash-screen/android/src/main/java/expo/modules/splashscreen/SplashScreenController.kt\n-@@ -30,6 +30,7 @@ class SplashScreenController(\n-\n- fun showSplashScreen(successCallback: () -> Unit = {}) {\n- weakActivity.get()?.runOnUiThread {\n-+ (splashScreenView.parent as? ViewGroup)?.removeView(splashScreenView)\n- contentView.addView(splashScreenView)\n- splashScreenShown = true\n- successCallback()\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "xcode \"^3.0.1\"\nxml2js \"^0.4.23\"\n-\"@expo/config-plugins@^3.0.0\":\n+\"@expo/config-plugins@3.1.0\", \"@expo/config-plugins@^3.0.0\":\nversion \"3.1.0\"\nresolved \"https://registry.yarnpkg.com/@expo/config-plugins/-/config-plugins-3.1.0.tgz#0752ff33c5eab21cf42034a44e79df97f0f867f8\"\nintegrity sha512-V5qxaxCAExBM0TXmbU1QKiZcAGP3ecu7KXede8vByT15cro5PkcWu2sSdJCYbHQ/gw6Vf/i8sr8gKlN8V8TSLg==\nresolved \"https://registry.yarnpkg.com/@expo/config-types/-/config-types-42.0.0.tgz#3e3e125ec092c0c34dbfaf19be5480402de3d677\"\nintegrity sha512-Rj02OMZke2MrGa/1Y/EScmR7VuWbDEHPJyvfFyyLbadUt+Yv6isCdeFzDt71I7gJlPR9T4fzixeYLrtXXOTq0w==\n+\"@expo/config@5.0.9\":\n+ version \"5.0.9\"\n+ resolved \"https://registry.yarnpkg.com/@expo/config/-/config-5.0.9.tgz#5221af5394599d861515ef8513731f21fbb322db\"\n+ integrity sha512-eZj+cf03wkQQdHSpYvrmiqAsn2dJV10uhHIwXyeFBaFvhds0NgThOldJZfOppQ4QUaGobB/vaJ7UqUa3B0PCMw==\n+ dependencies:\n+ \"@babel/code-frame\" \"~7.10.4\"\n+ \"@expo/config-plugins\" \"3.1.0\"\n+ \"@expo/config-types\" \"^42.0.0\"\n+ \"@expo/json-file\" \"8.2.33\"\n+ getenv \"^1.0.0\"\n+ glob \"7.1.6\"\n+ require-from-string \"^2.0.2\"\n+ resolve-from \"^5.0.0\"\n+ semver \"7.3.2\"\n+ slugify \"^1.3.4\"\n+ sucrase \"^3.20.0\"\n+\n\"@expo/config@^4.0.0\":\nversion \"4.0.4\"\nresolved \"https://registry.yarnpkg.com/@expo/config/-/config-4.0.4.tgz#48686c2b83bc00db469e01592e396e973e91e11d\"\nsemver \"7.3.2\"\nslugify \"^1.3.4\"\n-\"@expo/configure-splash-screen@~0.1.0\":\n- version \"0.1.19\"\n- resolved \"https://registry.yarnpkg.com/@expo/configure-splash-screen/-/configure-splash-screen-0.1.19.tgz#22257cd63e4e21036dda55851a28b6e9b02a9b1a\"\n- integrity sha512-9rVtF3BwHcNWom8crn6Rc09U3gnmUKroZL6ta04hUTpikMpGaZYdES2gj2ZryHvIACGHbxtM9MErSWH3B6iz5w==\n+\"@expo/configure-splash-screen@0.5.0\":\n+ version \"0.5.0\"\n+ resolved \"https://registry.yarnpkg.com/@expo/configure-splash-screen/-/configure-splash-screen-0.5.0.tgz#1e24d5086f8636070e092c3186a60f2926827259\"\n+ integrity sha512-wU84OsmACcQaY+cFNj1UOzqdUB+XNRP8hO5mwGN5LWRIDhd/5S1A/3hmWT96X4UQEee+XtCpwnmTw6SGIsTfIg==\ndependencies:\n- \"@react-native-community/cli-platform-android\" \"^4.10.0\"\n- \"@react-native-community/cli-platform-ios\" \"^4.10.0\"\ncolor-string \"^1.5.3\"\ncommander \"^5.1.0\"\n- core-js \"^3.6.5\"\n- deep-equal \"^2.0.3\"\nfs-extra \"^9.0.0\"\n+ glob \"^7.1.6\"\nlodash \"^4.17.15\"\npngjs \"^5.0.0\"\nxcode \"^3.0.0\"\nxml-js \"^1.6.11\"\n+\"@expo/image-utils@0.3.16\":\n+ version \"0.3.16\"\n+ resolved \"https://registry.yarnpkg.com/@expo/image-utils/-/image-utils-0.3.16.tgz#df4b38b728d29ae8bed686866dc264a2d64577e6\"\n+ integrity sha512-ZggQK5w7awqYdA/TE0DT02nYxWirQm2r7NNy043zVtzBCtjhLpFpluk1v9W0pH4+nT1ChGk1c67j0mYRKcBkjg==\n+ dependencies:\n+ \"@expo/spawn-async\" \"1.5.0\"\n+ chalk \"^4.0.0\"\n+ fs-extra \"9.0.0\"\n+ getenv \"^1.0.0\"\n+ jimp-compact \"0.16.1\"\n+ mime \"^2.4.4\"\n+ node-fetch \"^2.6.0\"\n+ parse-png \"^2.1.0\"\n+ resolve-from \"^5.0.0\"\n+ semver \"7.3.2\"\n+ tempy \"0.3.0\"\n+\n\"@expo/json-file@8.2.30\":\nversion \"8.2.30\"\nresolved \"https://registry.yarnpkg.com/@expo/json-file/-/json-file-8.2.30.tgz#bd855b6416b5c3af7e55b43f6761c1e7d2b755b0\"\nbase64-js \"^1.2.3\"\nxmlbuilder \"^14.0.0\"\n+\"@expo/prebuild-config@^2.0.0\":\n+ version \"2.1.0\"\n+ resolved \"https://registry.yarnpkg.com/@expo/prebuild-config/-/prebuild-config-2.1.0.tgz#d1dbead511b3959237e542e326a9db757e97fcab\"\n+ integrity sha512-obpbnV0+Otv7Dbx8kkbSd62xL9HYZRDPdmdcVWuML7lv7Zo4r+OyS6vYpUmln9htp0gtjuc6+X9FiC74bbGkVA==\n+ dependencies:\n+ \"@expo/config\" \"5.0.9\"\n+ \"@expo/config-plugins\" \"3.1.0\"\n+ \"@expo/config-types\" \"^42.0.0\"\n+ \"@expo/image-utils\" \"0.3.16\"\n+ \"@expo/json-file\" \"8.2.33\"\n+ debug \"^4.3.1\"\n+ fs-extra \"^9.0.0\"\n+ resolve-from \"^5.0.0\"\n+\n+\"@expo/spawn-async@1.5.0\":\n+ version \"1.5.0\"\n+ resolved \"https://registry.yarnpkg.com/@expo/spawn-async/-/spawn-async-1.5.0.tgz#799827edd8c10ef07eb1a2ff9dcfe081d596a395\"\n+ integrity sha512-LB7jWkqrHo+5fJHNrLAFdimuSXQ2MQ4lA7SQW5bf/HbsXuV2VrT/jN/M8f/KoWt0uJMGN4k/j7Opx4AvOOxSew==\n+ dependencies:\n+ cross-spawn \"^6.0.5\"\n+\n\"@firebase/app-types@0.6.1\":\nversion \"0.6.1\"\nresolved \"https://registry.yarnpkg.com/@firebase/app-types/-/app-types-0.6.1.tgz#dcbd23030a71c0c74fc95d4a3f75ba81653850e9\"\nhermes-profile-transformer \"^0.0.6\"\nip \"^1.1.5\"\n-\"@react-native-community/cli-platform-android@^4.10.0\":\n- version \"4.13.0\"\n- resolved \"https://registry.yarnpkg.com/@react-native-community/cli-platform-android/-/cli-platform-android-4.13.0.tgz#922681ec82ee1aadd993598b814df1152118be02\"\n- integrity sha512-3i8sX8GklEytUZwPnojuoFbCjIRzMugCdzDIdZ9UNmi/OhD4/8mLGO0dgXfT4sMWjZwu3qjy45sFfk2zOAgHbA==\n- dependencies:\n- \"@react-native-community/cli-tools\" \"^4.13.0\"\n- chalk \"^3.0.0\"\n- execa \"^1.0.0\"\n- fs-extra \"^8.1.0\"\n- glob \"^7.1.3\"\n- jetifier \"^1.6.2\"\n- lodash \"^4.17.15\"\n- logkitty \"^0.7.1\"\n- slash \"^3.0.0\"\n- xmldoc \"^1.1.2\"\n-\n\"@react-native-community/cli-platform-android@^5.0.1\", \"@react-native-community/cli-platform-android@^5.0.1-alpha.1\":\nversion \"5.0.1\"\nresolved \"https://registry.yarnpkg.com/@react-native-community/cli-platform-android/-/cli-platform-android-5.0.1.tgz#7f761e1818e5a099877ec59a1b739553fd6a6905\"\nslash \"^3.0.0\"\nxmldoc \"^1.1.2\"\n-\"@react-native-community/cli-platform-ios@^4.10.0\":\n- version \"4.13.0\"\n- resolved \"https://registry.yarnpkg.com/@react-native-community/cli-platform-ios/-/cli-platform-ios-4.13.0.tgz#a738915c68cac86df54e578b59a1311ea62b1aef\"\n- integrity sha512-6THlTu8zp62efkzimfGr3VIuQJ2514o+vScZERJCV1xgEi8XtV7mb/ZKt9o6Y9WGxKKkc0E0b/aVAtgy+L27CA==\n- dependencies:\n- \"@react-native-community/cli-tools\" \"^4.13.0\"\n- chalk \"^3.0.0\"\n- glob \"^7.1.3\"\n- js-yaml \"^3.13.1\"\n- lodash \"^4.17.15\"\n- plist \"^3.0.1\"\n- xcode \"^2.0.0\"\n-\n\"@react-native-community/cli-platform-ios@^5.0.1-alpha.1\":\nversion \"5.0.1\"\nresolved \"https://registry.yarnpkg.com/@react-native-community/cli-platform-ios/-/cli-platform-ios-5.0.1.tgz#efa9c9b3bba0978d0a26d6442eefeffb5006a196\"\nserve-static \"^1.13.1\"\nws \"^1.1.0\"\n-\"@react-native-community/cli-tools@^4.13.0\":\n- version \"4.13.0\"\n- resolved \"https://registry.yarnpkg.com/@react-native-community/cli-tools/-/cli-tools-4.13.0.tgz#b406463d33af16cedc4305a9a9257ed32845cf1b\"\n- integrity sha512-s4f489h5+EJksn4CfheLgv5PGOM0CDmK1UEBLw2t/ncWs3cW2VI7vXzndcd/WJHTv3GntJhXDcJMuL+Z2IAOgg==\n- dependencies:\n- chalk \"^3.0.0\"\n- lodash \"^4.17.15\"\n- mime \"^2.4.1\"\n- node-fetch \"^2.6.0\"\n- open \"^6.2.0\"\n- shell-quote \"1.6.1\"\n-\n\"@react-native-community/cli-tools@^5.0.1\":\nversion \"5.0.1\"\nresolved \"https://registry.yarnpkg.com/@react-native-community/cli-tools/-/cli-tools-5.0.1.tgz#9ee564dbe20448becd6bce9fbea1b59aa5797919\"\n@@ -4849,6 +4860,11 @@ any-observable@^0.3.0:\nresolved \"https://registry.yarnpkg.com/any-observable/-/any-observable-0.3.0.tgz#af933475e5806a67d0d7df090dd5e8bef65d119b\"\nintegrity sha512-/FQM1EDkTsf63Ub2C6O7GuYFDsSXUwsaZDurV0np41ocwq0jthUAYCmhBX9f+KwlaCgIuWyr/4WlUQUBfKfZog==\n+any-promise@^1.0.0:\n+ version \"1.3.0\"\n+ resolved \"https://registry.yarnpkg.com/any-promise/-/any-promise-1.3.0.tgz#abc6afeedcea52e809cdc0376aed3ce39635d17f\"\n+ integrity sha1-q8av7tzqUugJzcA3au0845Y10X8=\n+\nanymatch@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/anymatch/-/anymatch-2.0.0.tgz#bcb24b4f37934d9aa7ac17b4adaf89e7c76ef2eb\"\n@@ -6424,7 +6440,7 @@ commander@^2.19.0, commander@^2.20.0:\nresolved \"https://registry.yarnpkg.com/commander/-/commander-2.20.1.tgz#3863ce3ca92d0831dcf2a102f5fb4b5926afd0f9\"\nintegrity sha512-cCuLsMhJeWQ/ZpsFTbE765kvVfoeSddc4nU3up4fV+fDBcfUXnbITJ+JzhkdjzOqhURjZgujxaioam4RM9yGUg==\n-commander@^4.0.1:\n+commander@^4.0.0, commander@^4.0.1:\nversion \"4.1.1\"\nresolved \"https://registry.yarnpkg.com/commander/-/commander-4.1.1.tgz#9fd602bd936294e9e9ef46a3f4d6964044b18068\"\nintegrity sha512-NOKm8xhkzAjzFx8B2v5OAHT+u5pRQc2UCa2Vq9jYL/31o2wi9mxBA7LIFs3sV5VSC49z6pEhfbMULvShKj26WA==\n@@ -6833,6 +6849,11 @@ crypto-browserify@^3.11.0:\nrandombytes \"^2.0.0\"\nrandomfill \"^1.0.3\"\n+crypto-random-string@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/crypto-random-string/-/crypto-random-string-1.0.0.tgz#a230f64f568310e1498009940790ec99545bca7e\"\n+ integrity sha1-ojD2T1aDEOFJgAmUB5DsmVRbyn4=\n+\ncrypto-random-string@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/crypto-random-string/-/crypto-random-string-2.0.0.tgz#ef2a7a966ec11083388369baa02ebead229b30d5\"\n@@ -7213,26 +7234,6 @@ deep-equal@^1.0.1:\nobject-keys \"^1.1.1\"\nregexp.prototype.flags \"^1.2.0\"\n-deep-equal@^2.0.3:\n- version \"2.0.3\"\n- resolved \"https://registry.yarnpkg.com/deep-equal/-/deep-equal-2.0.3.tgz#cad1c15277ad78a5c01c49c2dee0f54de8a6a7b0\"\n- integrity sha512-Spqdl4H+ky45I9ByyJtXteOm9CaIrPmnIPmOhrkKGNYWeDgCvJ8jNYVCTjChxW4FqGuZnLHADc8EKRMX6+CgvA==\n- dependencies:\n- es-abstract \"^1.17.5\"\n- es-get-iterator \"^1.1.0\"\n- is-arguments \"^1.0.4\"\n- is-date-object \"^1.0.2\"\n- is-regex \"^1.0.5\"\n- isarray \"^2.0.5\"\n- object-is \"^1.1.2\"\n- object-keys \"^1.1.1\"\n- object.assign \"^4.1.0\"\n- regexp.prototype.flags \"^1.3.0\"\n- side-channel \"^1.0.2\"\n- which-boxed-primitive \"^1.0.1\"\n- which-collection \"^1.0.1\"\n- which-typed-array \"^1.1.2\"\n-\ndeep-equal@^2.0.4:\nversion \"2.0.4\"\nresolved \"https://registry.yarnpkg.com/deep-equal/-/deep-equal-2.0.4.tgz#6b0b407a074666033169df3acaf128e1c6f3eab6\"\n@@ -8389,12 +8390,13 @@ expo-secure-store@^10.2.0:\nresolved \"https://registry.yarnpkg.com/expo-secure-store/-/expo-secure-store-10.2.0.tgz#561dfea4d6b4d05a738643d80a15403ebe0e515d\"\nintegrity sha512-yNahMY3qzEotAYdsE02ps4yGfDay2twasHfsI/7gJB9SrwXYFx5bJuCDk8uTo8jsm6psvDjO+9VMM2DSPHik2A==\n-expo-splash-screen@^0.3.1:\n- version \"0.3.1\"\n- resolved \"https://registry.yarnpkg.com/expo-splash-screen/-/expo-splash-screen-0.3.1.tgz#4dd79d9d1ab8135281f7cc5889a68e3003223f37\"\n- integrity sha512-j87n6utSq8irvx9dA3YvFwHsqT9c/Cc/QnmpZHB0g3mPh3QBWReKgR3x41tHnkLMKHAi9Au9D4k/o615kUNeDg==\n+expo-splash-screen@^0.11.4:\n+ version \"0.11.4\"\n+ resolved \"https://registry.yarnpkg.com/expo-splash-screen/-/expo-splash-screen-0.11.4.tgz#fe474748c132ed2e45f477b882e2cf8735d9db98\"\n+ integrity sha512-WycJfWaBuj/W9KSgYTUHjm90VkwZ0Pv/EIqh2pW4/zw10AoSLHVgVA0CoC5R944iE42m6KWioax/0ydHU61qzA==\ndependencies:\n- \"@expo/configure-splash-screen\" \"~0.1.0\"\n+ \"@expo/configure-splash-screen\" \"0.5.0\"\n+ \"@expo/prebuild-config\" \"^2.0.0\"\nexpress-ws@^4.0.0:\nversion \"4.0.0\"\n@@ -11192,6 +11194,11 @@ jetifier@^1.6.2, jetifier@^1.6.4:\nresolved \"https://registry.yarnpkg.com/jetifier/-/jetifier-1.6.4.tgz#6159db8e275d97980d26162897a0648b6d4a3222\"\nintegrity sha512-+f/4OLeqY8RAmXnonI1ffeY1DR8kMNJPhv5WMFehchf7U71cjMQVKkOz1n6asz6kfVoAqKNWJz1A/18i18AcXA==\n+jimp-compact@0.16.1:\n+ version \"0.16.1\"\n+ resolved \"https://registry.yarnpkg.com/jimp-compact/-/jimp-compact-0.16.1.tgz#9582aea06548a2c1e04dd148d7c3ab92075aefa3\"\n+ integrity sha512-dZ6Ra7u1G8c4Letq/B5EzAxj4tLFHL+cGtdpR+PVm4yzPDj+lCk+AbivWt1eOM+ikzkowtyV7qSqX6qr3t71Ww==\n+\njoi@^17.2.1:\nversion \"17.4.0\"\nresolved \"https://registry.yarnpkg.com/joi/-/joi-17.4.0.tgz#b5c2277c8519e016316e49ababd41a1908d9ef20\"\n@@ -12809,6 +12816,15 @@ mysql2@^1.5.1:\nseq-queue \"^0.0.5\"\nsqlstring \"^2.3.1\"\n+mz@^2.7.0:\n+ version \"2.7.0\"\n+ resolved \"https://registry.yarnpkg.com/mz/-/mz-2.7.0.tgz#95008057a56cafadc2bc63dde7f9ff6955948e32\"\n+ integrity sha512-z81GNO7nnYMEhrGh9LeymoE4+Yr0Wn5McHIZMK5cfQCl+NDX08sCZgUc9/6MHni9IWuFLm1Z3HTCXu2z9fN62Q==\n+ dependencies:\n+ any-promise \"^1.0.0\"\n+ object-assign \"^4.0.1\"\n+ thenify-all \"^1.0.0\"\n+\nnamed-placeholders@^1.1.2:\nversion \"1.1.2\"\nresolved \"https://registry.yarnpkg.com/named-placeholders/-/named-placeholders-1.1.2.tgz#ceb1fbff50b6b33492b5cf214ccf5e39cef3d0e8\"\n@@ -13247,14 +13263,6 @@ object-is@^1.0.1:\nresolved \"https://registry.yarnpkg.com/object-is/-/object-is-1.0.1.tgz#0aa60ec9989a0b3ed795cf4d06f62cf1ad6539b6\"\nintegrity sha1-CqYOyZiaCz7Xlc9NBvYs8a1lObY=\n-object-is@^1.1.2:\n- version \"1.1.2\"\n- resolved \"https://registry.yarnpkg.com/object-is/-/object-is-1.1.2.tgz#c5d2e87ff9e119f78b7a088441519e2eec1573b6\"\n- integrity sha512-5lHCz+0uufF6wZ7CRFWJN3hp8Jqblpgve06U5CMQ3f//6iDjPr2PEo9MWCjEssDsa+UZEL4PkFpr+BMop6aKzQ==\n- dependencies:\n- define-properties \"^1.1.3\"\n- es-abstract \"^1.17.5\"\n-\nobject-is@^1.1.3:\nversion \"1.1.3\"\nresolved \"https://registry.yarnpkg.com/object-is/-/object-is-1.1.3.tgz#2e3b9e65560137455ee3bd62aec4d90a2ea1cc81\"\n@@ -13774,6 +13782,13 @@ parse-passwd@^1.0.0:\nresolved \"https://registry.yarnpkg.com/parse-passwd/-/parse-passwd-1.0.0.tgz#6d5b934a456993b23d37f40a382d6f1666a8e5c6\"\nintegrity sha1-bVuTSkVpk7I9N/QKOC1vFmao5cY=\n+parse-png@^2.1.0:\n+ version \"2.1.0\"\n+ resolved \"https://registry.yarnpkg.com/parse-png/-/parse-png-2.1.0.tgz#2a42ad719fedf90f81c59ebee7ae59b280d6b338\"\n+ integrity sha512-Nt/a5SfCLiTnQAjx3fHlqp8hRgTL3z7kTQZzvIMS9uCAepnCyjpdEc6M/sz69WqMBdaDBw9sF1F1UaHROYzGkQ==\n+ dependencies:\n+ pngjs \"^3.3.0\"\n+\nparse5@5.1.1:\nversion \"5.1.1\"\nresolved \"https://registry.yarnpkg.com/parse5/-/parse5-5.1.1.tgz#f68e4e5ba1852ac2cadc00f4555fff6c2abb6178\"\n@@ -14023,6 +14038,11 @@ plist@^3.0.1:\nxmlbuilder \"^9.0.7\"\nxmldom \"0.1.x\"\n+pngjs@^3.3.0:\n+ version \"3.4.0\"\n+ resolved \"https://registry.yarnpkg.com/pngjs/-/pngjs-3.4.0.tgz#99ca7d725965fb655814eaf65f38f12bbdbf555f\"\n+ integrity sha512-NCrCHhWmnQklfH4MtJMRjZ2a8c80qXeMlQMv2uVp9ISJMTt562SbGd6n2oq0PaPgKm7Z6pL9E2UlLIhC+SHL3w==\n+\npngjs@^5.0.0:\nversion \"5.0.0\"\nresolved \"https://registry.yarnpkg.com/pngjs/-/pngjs-5.0.0.tgz#e79dd2b215767fd9c04561c01236df960bce7fbb\"\n@@ -16433,14 +16453,6 @@ shellwords@^0.1.1:\nresolved \"https://registry.yarnpkg.com/shellwords/-/shellwords-0.1.1.tgz#d6b9181c1a48d397324c84871efbcfc73fc0654b\"\nintegrity sha512-vFwSUfQvqybiICwZY5+DAWIPLKsWO31Q91JSKl3UYv+K5c2QRPzn0qzec6QPu1Qc9eHYItiP3NdJqNVqetYAww==\n-side-channel@^1.0.2:\n- version \"1.0.2\"\n- resolved \"https://registry.yarnpkg.com/side-channel/-/side-channel-1.0.2.tgz#df5d1abadb4e4bf4af1cd8852bf132d2f7876947\"\n- integrity sha512-7rL9YlPHg7Ancea1S96Pa8/QWb4BtXL/TZvS6B8XFetGBeuhAsfmUspK6DokBeZ64+Kj9TCNRD/30pVz1BvQNA==\n- dependencies:\n- es-abstract \"^1.17.0-next.1\"\n- object-inspect \"^1.7.0\"\n-\nside-channel@^1.0.3:\nversion \"1.0.3\"\nresolved \"https://registry.yarnpkg.com/side-channel/-/side-channel-1.0.3.tgz#cdc46b057550bbab63706210838df5d4c19519c3\"\n@@ -17236,6 +17248,18 @@ stylehacks@^4.0.0:\npostcss \"^7.0.0\"\npostcss-selector-parser \"^3.0.0\"\n+sucrase@^3.20.0:\n+ version \"3.20.2\"\n+ resolved \"https://registry.yarnpkg.com/sucrase/-/sucrase-3.20.2.tgz#28a28dc58a55be0d6916d5c9b2440d203e9ffe62\"\n+ integrity sha512-EdJ5M6VEvToIZwIWiZ71cxe4CklDRG8PdSjUSst+BZCUGlaEhnrdQo/LOXsuq3MjWRbfepg1XTffClK0Tmo0HQ==\n+ dependencies:\n+ commander \"^4.0.0\"\n+ glob \"7.1.6\"\n+ lines-and-columns \"^1.1.6\"\n+ mz \"^2.7.0\"\n+ pirates \"^4.0.1\"\n+ ts-interface-checker \"^0.1.9\"\n+\nsudo-prompt@^9.0.0:\nversion \"9.1.1\"\nresolved \"https://registry.yarnpkg.com/sudo-prompt/-/sudo-prompt-9.1.1.tgz#73853d729770392caec029e2470db9c221754db0\"\n@@ -17403,6 +17427,11 @@ teeny-request@^7.0.0:\nstream-events \"^1.0.5\"\nuuid \"^8.0.0\"\n+temp-dir@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/temp-dir/-/temp-dir-1.0.0.tgz#0a7c0ea26d3a39afa7e0ebea9c1fc0bc4daa011d\"\n+ integrity sha1-CnwOom06Oa+n4OvqnB/AvE2qAR0=\n+\ntemp@0.8.3:\nversion \"0.8.3\"\nresolved \"https://registry.yarnpkg.com/temp/-/temp-0.8.3.tgz#e0c6bc4d26b903124410e4fed81103014dfc1f59\"\n@@ -17418,6 +17447,15 @@ temp@^0.8.1:\ndependencies:\nrimraf \"~2.6.2\"\n+tempy@0.3.0:\n+ version \"0.3.0\"\n+ resolved \"https://registry.yarnpkg.com/tempy/-/tempy-0.3.0.tgz#6f6c5b295695a16130996ad5ab01a8bd726e8bf8\"\n+ integrity sha512-WrH/pui8YCwmeiAoxV+lpRH9HpRtgBhSR2ViBPgpGb/wnYDzp21R4MN45fsCGvLROvY67o3byhJRYRONJyImVQ==\n+ dependencies:\n+ temp-dir \"^1.0.0\"\n+ type-fest \"^0.3.1\"\n+ unique-string \"^1.0.0\"\n+\nterm-size@^2.1.0:\nversion \"2.2.0\"\nresolved \"https://registry.yarnpkg.com/term-size/-/term-size-2.2.0.tgz#1f16adedfe9bdc18800e1776821734086fcc6753\"\n@@ -17483,6 +17521,20 @@ text-table@^0.2.0:\nresolved \"https://registry.yarnpkg.com/text-table/-/text-table-0.2.0.tgz#7f5ee823ae805207c00af2df4a84ec3fcfa570b4\"\nintegrity sha1-f17oI66AUgfACvLfSoTsP8+lcLQ=\n+thenify-all@^1.0.0:\n+ version \"1.6.0\"\n+ resolved \"https://registry.yarnpkg.com/thenify-all/-/thenify-all-1.6.0.tgz#1a1918d402d8fc3f98fbf234db0bcc8cc10e9726\"\n+ integrity sha1-GhkY1ALY/D+Y+/I02wvMjMEOlyY=\n+ dependencies:\n+ thenify \">= 3.1.0 < 4\"\n+\n+\"thenify@>= 3.1.0 < 4\":\n+ version \"3.3.1\"\n+ resolved \"https://registry.yarnpkg.com/thenify/-/thenify-3.3.1.tgz#8932e686a4066038a016dd9e2ca46add9838a95f\"\n+ integrity sha512-RVZSIV5IG10Hk3enotrhvz0T9em6cyHBLkH/YAZuKqd8hRkKhSfCGIcP2KUY0EPxndzANBmNllzWPwak+bheSw==\n+ dependencies:\n+ any-promise \"^1.0.0\"\n+\nthroat@^5.0.0:\nversion \"5.0.0\"\nresolved \"https://registry.yarnpkg.com/throat/-/throat-5.0.0.tgz#c5199235803aad18754a667d659b5e72ce16764b\"\n@@ -17669,6 +17721,11 @@ tree-kill@^1.2.2:\nresolved \"https://registry.yarnpkg.com/tree-kill/-/tree-kill-1.2.2.tgz#4ca09a9092c88b73a7cdc5e8a01b507b0790a0cc\"\nintegrity sha512-L0Orpi8qGpRG//Nd+H90vFB+3iHnue1zSSGmNOOCh1GLJ7rUKVwV2HvijphGQS2UmhUZewS9VgvxYIdgr+fG1A==\n+ts-interface-checker@^0.1.9:\n+ version \"0.1.13\"\n+ resolved \"https://registry.yarnpkg.com/ts-interface-checker/-/ts-interface-checker-0.1.13.tgz#784fd3d679722bc103b1b4b8030bcddb5db2a699\"\n+ integrity sha512-Y/arvbn+rrz3JCKl9C4kVNfTfSm2/mEp5FSz5EsZSANGPSlQrpRI5M4PKF+mJnE52jOO90PnPSc3Ur3bTQw0gA==\n+\nts-invariant@^0.4.0:\nversion \"0.4.4\"\nresolved \"https://registry.yarnpkg.com/ts-invariant/-/ts-invariant-0.4.4.tgz#97a523518688f93aafad01b0e80eb803eb2abd86\"\n@@ -17768,6 +17825,11 @@ type-fest@^0.20.2:\nresolved \"https://registry.yarnpkg.com/type-fest/-/type-fest-0.20.2.tgz#1bf207f4b28f91583666cb5fbd327887301cd5f4\"\nintegrity sha512-Ne+eE4r0/iWnpAxD852z3A+N0Bt5RN//NjJwRd2VFHEmrywxf5vsZlh4R6lixl6B+wz/8d+maTSAkN1FIkI3LQ==\n+type-fest@^0.3.1:\n+ version \"0.3.1\"\n+ resolved \"https://registry.yarnpkg.com/type-fest/-/type-fest-0.3.1.tgz#63d00d204e059474fe5e1b7c011112bbd1dc29e1\"\n+ integrity sha512-cUGJnCdr4STbePCgqNFbpVNCepa+kAVohJs1sLhxzdH+gnEoOd8VhbYa7pD3zZYGiURWM2xzEII3fQcRizDkYQ==\n+\ntype-fest@^0.6.0:\nversion \"0.6.0\"\nresolved \"https://registry.yarnpkg.com/type-fest/-/type-fest-0.6.0.tgz#8d2a2370d3df886eb5c90ada1c5bf6188acf838b\"\n@@ -17935,6 +17997,13 @@ unique-slug@^2.0.0:\ndependencies:\nimurmurhash \"^0.1.4\"\n+unique-string@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/unique-string/-/unique-string-1.0.0.tgz#9e1057cca851abb93398f8b33ae187b99caec11a\"\n+ integrity sha1-nhBXzKhRq7kzmPizOuGHuZyuwRo=\n+ dependencies:\n+ crypto-random-string \"^1.0.0\"\n+\nunique-string@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/unique-string/-/unique-string-2.0.0.tgz#39c6451f81afb2749de2b233e3f7c5e8843bd89d\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [expo-splash-screen-update] [4/4] expo-splash-screen@0.11.4
Test Plan: Compile and test with the whole stack on iOS and Android release builds to make sure splash screen looks good
Reviewers: atul, palys-swm, benschac
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2235 |
129,184 | 17.10.2021 12:00:37 | 14,400 | f9e92bb32e98f2e1f7bc03018635f519d8901b0a | [native] `codeVersion` -> 104 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -395,8 +395,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 103\n- versionName '1.0.103'\n+ versionCode 104\n+ versionName '1.0.104'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.103</string>\n+ <string>1.0.104</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>103</string>\n+ <string>104</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.103</string>\n+ <string>1.0.104</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>103</string>\n+ <string>104</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -334,12 +334,12 @@ const persistConfig = {\n'frozen',\n],\ndebug: __DEV__,\n- version: 28,\n+ version: 29,\nmigrate: (createMigrate(migrations, { debug: __DEV__ }): any),\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 103;\n+const codeVersion = 104;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 104 |
129,184 | 17.10.2021 13:21:50 | 14,400 | c81d5fb418075c5399797aa2f6b62bd4d79c9e51 | [native] `codeVersion` -> 105 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -395,8 +395,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 104\n- versionName '1.0.104'\n+ versionCode 105\n+ versionName '1.0.105'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.104</string>\n+ <string>1.0.105</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>104</string>\n+ <string>105</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.104</string>\n+ <string>1.0.105</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>104</string>\n+ <string>105</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -339,7 +339,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 104;\n+const codeVersion = 105;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 105 |
129,184 | 15.10.2021 15:27:18 | 14,400 | 7d87a11fc6c2c1ffd488a93300c03b4ab81cdd34 | [landing] Preload PNG or WEBP images based on WEBP browser support
Summary: Adapted from
Test Plan: Tested the WEBP supported case via console log
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -37,10 +37,22 @@ function AppLanding(): React.Node {\nconst [activeCardIdx, setActiveCardIdx] = React.useState(-1);\nReact.useEffect(() => {\n+ // Depending on WEBP browser support, preload either PNG or WEBP images.\n+ const testWEBP = 'UklGRiIAAABXRUJQVlA4IBYAAAAwAQCdASoBAAEADsD+JaQAA3AAAAAA';\n+ const testImg = new Image();\n+ testImg.onload = () => {\nfor (const imagePath of screenshotsWEBP) {\nconst image = new Image();\nimage.src = `images/${imagePath}`;\n}\n+ };\n+ testImg.onerror = () => {\n+ for (const imagePath of screenshotsPNG) {\n+ const image = new Image();\n+ image.src = `images/${imagePath}`;\n+ }\n+ };\n+ testImg.src = `data:image/webp;base64,${testWEBP}`;\n}, []);\nreturn (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Preload PNG or WEBP images based on WEBP browser support
Summary: Adapted from https://developers.google.com/speed/webp/faq#in_your_own_javascript
Test Plan: Tested the WEBP supported case via console log
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2226 |
129,184 | 15.10.2021 15:42:34 | 14,400 | 941706a62d95704e3d257ea675e6ac63caa43cc4 | [landing] Start with "home screen" prototype before "federated"
Summary: Addressed feedback from yesterday
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -55,6 +55,14 @@ function AppLanding(): React.Node {\ntestImg.src = `data:image/webp;base64,${testWEBP}`;\n}, []);\n+ const imageIdx =\n+ activeCardIdx === -1\n+ ? 1\n+ : Math.min(\n+ Math.max(0, activeCardIdx),\n+ Math.min(screenshotsWEBP.length, screenshotsPNG.length) - 1,\n+ );\n+\nreturn (\n<>\n<StarBackground />\n@@ -62,37 +70,14 @@ function AppLanding(): React.Node {\n<div className={css.app_preview}>\n<picture>\n<source\n- srcSet={`images/${\n- screenshotsWEBP[\n- Math.min(\n- Math.max(0, activeCardIdx),\n- screenshotsWEBP.length - 1,\n- )\n- ]\n- }`}\n+ srcSet={`images/${screenshotsWEBP[imageIdx]}`}\ntype=\"image/webp\"\n/>\n<source\n- srcSet={`images/${\n- screenshotsPNG[\n- Math.min(\n- Math.max(0, activeCardIdx),\n- screenshotsPNG.length - 1,\n- )\n- ]\n- }`}\n+ srcSet={`images/${screenshotsPNG[imageIdx]}`}\ntype=\"image/png\"\n/>\n- <img\n- src={`images/${\n- screenshotsPNG[\n- Math.min(\n- Math.max(0, activeCardIdx),\n- screenshotsPNG.length - 1,\n- )\n- ]\n- }`}\n- />\n+ <img src={`images/${screenshotsPNG[imageIdx]}`} />\n</picture>\n</div>\n<div className={css.app_copy}>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Start with "home screen" prototype before "federated"
Summary: Addressed feedback from yesterday
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2227 |
129,184 | 15.10.2021 16:20:24 | 14,400 | 75b6af3c6e5b3e06cfc55f5e7a375b22728d00d5 | [landing] Add purple radial gradient to top corner
Summary: na
Test Plan:
Here's what it looks like:
(Though, I prefer it in the top left corner:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -9,6 +9,11 @@ html {\n/* Override browser default to achieve edge-to-edge footer translucency effect */\nbody {\n+ background-image: radial-gradient(\n+ circle at top left,\n+ #2d008888 0%,\n+ #ffffff00 50%\n+ );\nmargin: 0;\npadding: 0;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add purple radial gradient to top corner
Summary: na
Test Plan:
Here's what it looks like: https://blob.sh/atul/8bd2.png
(Though, I prefer it in the top left corner: https://blob.sh/atul/b61f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2228 |
129,184 | 18.10.2021 14:44:45 | 14,400 | 9d82497a1e8fd52e2ba35c2c520ae9abb26eac44 | [landing] Refactor screenshot pre-loading
Summary: Less repetition, more readable
Test Plan: Looks the same to me
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -15,53 +15,45 @@ import InfoCard from './info-card.react';\nimport css from './landing.css';\nimport StarBackground from './star-background.react';\n-const screenshotsWEBP = [\n- 'federated-prototype.webp',\n- 'customizable-prototype.webp',\n- 'e2e-encrypted-prototype.webp',\n- 'sovereign-prototype.webp',\n- 'open-source-prototype.webp',\n- 'less-noisy-prototype.webp',\n-];\n-\n-const screenshotsPNG = [\n- 'federated-prototype.png',\n- 'customizable-prototype.png',\n- 'e2e-encrypted-prototype.png',\n- 'sovereign-prototype.png',\n- 'open-source-prototype.png',\n- 'less-noisy-prototype.png',\n+const screenshots = [\n+ 'federated-prototype',\n+ 'customizable-prototype',\n+ 'e2e-encrypted-prototype',\n+ 'sovereign-prototype',\n+ 'open-source-prototype',\n+ 'less-noisy-prototype',\n];\nfunction AppLanding(): React.Node {\nconst [activeCardIdx, setActiveCardIdx] = React.useState(-1);\nReact.useEffect(() => {\n- // Depending on WEBP browser support, preload either PNG or WEBP images.\nconst testWEBP = 'UklGRiIAAABXRUJQVlA4IBYAAAAwAQCdASoBAAEADsD+JaQAA3AAAAAA';\nconst testImg = new Image();\n+\n+ // preload webp if supported\ntestImg.onload = () => {\n- for (const imagePath of screenshotsWEBP) {\n+ for (const imageFileName of screenshots) {\nconst image = new Image();\n- image.src = `images/${imagePath}`;\n+ image.src = `images/${imageFileName}.webp`;\n}\n};\n+\n+ // preload png if webp not supported\ntestImg.onerror = () => {\n- for (const imagePath of screenshotsPNG) {\n+ for (const imageFileName of screenshots) {\nconst image = new Image();\n- image.src = `images/${imagePath}`;\n+ image.src = `images/${imageFileName}.png`;\n}\n};\n+\ntestImg.src = `data:image/webp;base64,${testWEBP}`;\n}, []);\nconst imageIdx =\nactiveCardIdx === -1\n? 1\n- : Math.min(\n- Math.max(0, activeCardIdx),\n- Math.min(screenshotsWEBP.length, screenshotsPNG.length) - 1,\n- );\n+ : Math.min(Math.max(0, activeCardIdx), screenshots.length - 1);\nreturn (\n<>\n@@ -70,14 +62,14 @@ function AppLanding(): React.Node {\n<div className={css.app_preview}>\n<picture>\n<source\n- srcSet={`images/${screenshotsWEBP[imageIdx]}`}\n+ srcSet={`images/${screenshots[imageIdx]}.webp`}\ntype=\"image/webp\"\n/>\n<source\n- srcSet={`images/${screenshotsPNG[imageIdx]}`}\n+ srcSet={`images/${screenshots[imageIdx]}.png`}\ntype=\"image/png\"\n/>\n- <img src={`images/${screenshotsPNG[imageIdx]}`} />\n+ <img src={`images/${screenshots[imageIdx]}.png`} />\n</picture>\n</div>\n<div className={css.app_copy}>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Refactor screenshot pre-loading
Summary: Less repetition, more readable
Test Plan: Looks the same to me
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2238 |
129,179 | 18.10.2021 16:43:53 | 14,400 | 671880ff04a142138f524655a43be0a457ce96f5 | sort endpoints file alphabetically
Summary: small refactor: sort file alphabetically for consistency. is the plugin I use.
Test Plan: make sure the file isn't broken.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/endpoints.js",
"new_path": "server/src/endpoints.js",
"diff": "@@ -55,45 +55,45 @@ import { codeVerificationResponder } from './responders/verification-responders'\nimport { uploadDeletionResponder } from './uploads/uploads';\nconst jsonEndpoints: { [id: Endpoint]: JSONResponder } = {\n- update_activity: updateActivityResponder,\n- update_user_subscription: userSubscriptionUpdateResponder,\n- update_device_token: deviceTokenUpdateResponder,\n- update_account: accountUpdateResponder,\n- send_verification_email: sendVerificationEmailResponder,\n- search_users: userSearchResponder,\n- send_password_reset_email: sendPasswordResetEmailResponder,\n+ create_account: accountCreationResponder,\n+ create_entry: entryCreationResponder,\n+ create_error_report: reportCreationResponder,\n+ create_multimedia_message: multimediaMessageCreationResponder,\n+ create_report: reportCreationResponder,\n+ create_reports: reportMultiCreationResponder,\ncreate_text_message: textMessageCreationResponder,\n+ create_thread: threadCreationResponder,\n+ delete_account: accountDeletionResponder,\n+ delete_entry: entryDeletionResponder,\n+ delete_thread: threadDeletionResponder,\n+ delete_upload: uploadDeletionResponder,\nfetch_entries: entryFetchResponder,\nfetch_entry_revisions: entryRevisionFetchResponder,\n- verify_code: codeVerificationResponder,\n- delete_thread: threadDeletionResponder,\n- create_entry: entryCreationResponder,\n- update_entry: entryUpdateResponder,\n- delete_entry: entryDeletionResponder,\n- restore_entry: entryRestorationResponder,\n- update_role: roleUpdateResponder,\n- remove_members: memberRemovalResponder,\n- leave_thread: threadLeaveResponder,\n- update_thread: threadUpdateResponder,\n- create_thread: threadCreationResponder,\n+ fetch_error_report_infos: errorReportFetchInfosResponder,\nfetch_messages: messageFetchResponder,\n+ get_user_public_keys: getUserPublicKeysResponder,\njoin_thread: threadJoinResponder,\n- set_thread_unread_status: threadSetUnreadStatusResponder,\n- log_out: logOutResponder,\n- delete_account: accountDeletionResponder,\n- create_account: accountCreationResponder,\n+ leave_thread: threadLeaveResponder,\nlog_in: logInResponder,\n- update_password: passwordUpdateResponder,\n- create_error_report: reportCreationResponder,\n- create_report: reportCreationResponder,\n- create_reports: reportMultiCreationResponder,\n- fetch_error_report_infos: errorReportFetchInfosResponder,\n+ log_out: logOutResponder,\n+ remove_members: memberRemovalResponder,\nrequest_access: requestAccessResponder,\n+ restore_entry: entryRestorationResponder,\n+ search_users: userSearchResponder,\n+ send_password_reset_email: sendPasswordResetEmailResponder,\n+ send_verification_email: sendVerificationEmailResponder,\n+ set_thread_unread_status: threadSetUnreadStatusResponder,\n+ update_account: accountUpdateResponder,\n+ update_activity: updateActivityResponder,\nupdate_calendar_query: calendarQueryUpdateResponder,\n- delete_upload: uploadDeletionResponder,\n- create_multimedia_message: multimediaMessageCreationResponder,\n+ update_device_token: deviceTokenUpdateResponder,\n+ update_entry: entryUpdateResponder,\n+ update_password: passwordUpdateResponder,\nupdate_relationships: updateRelationshipsResponder,\n- get_user_public_keys: getUserPublicKeysResponder,\n+ update_role: roleUpdateResponder,\n+ update_thread: threadUpdateResponder,\n+ update_user_subscription: userSubscriptionUpdateResponder,\n+ verify_code: codeVerificationResponder,\n};\nexport { jsonEndpoints };\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | sort endpoints file alphabetically
Summary: small refactor: sort file alphabetically for consistency. https://marketplace.visualstudio.com/items?itemName=richie5um2.vscode-sort-json is the plugin I use.
Test Plan: make sure the file isn't broken.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2240 |
129,184 | 18.10.2021 21:47:50 | 14,400 | a83c000e63c50b0272d942bee7b1712a47d3ab17 | [landing] Get landing assets from CloudFront (CDN)
Summary: Previously, we were fetching directly from S3. Instead, we'll now fetch from AWS CloudFront (CDN in front of S3)
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -24,8 +24,7 @@ const screenshots = [\n'less-noisy-prototype',\n];\n-const LandingAssetsS3URL =\n- 'https://comm-landing-assets.s3.us-east-2.amazonaws.com';\n+const LandingAssetsS3URL = 'https://dh9fld3hutpxf.cloudfront.net';\nfunction AppLanding(): React.Node {\nconst [activeCardIdx, setActiveCardIdx] = React.useState(-1);\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.react.js",
"new_path": "landing/keyservers.react.js",
"diff": "@@ -66,8 +66,7 @@ function Keyservers(): React.Node {\nreturn () => cloudNode.removeEventListener('load', onCloudIllustrationLoad);\n}, [cloudNode, onCloudIllustrationLoad]);\n- const LandingAssetsS3URL =\n- 'https://comm-landing-assets.s3.us-east-2.amazonaws.com';\n+ const LandingAssetsS3URL = 'https://dh9fld3hutpxf.cloudfront.net';\nreturn (\n<div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/read-docs-btn.react.js",
"new_path": "landing/read-docs-btn.react.js",
"diff": "@@ -13,7 +13,7 @@ function ReadDocsButton(): React.Node {\n<button className={css.button}>\n<span className={css.buttonText}>Read the documentation</span>\n<img\n- src=\"https://comm-landing-assets.s3.us-east-2.amazonaws.com/corner_arrow.svg\"\n+ src=\"https://dh9fld3hutpxf.cloudfront.net/corner_arrow.svg\"\nclassName={css.cornerIcon}\n/>\n</button>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get landing assets from CloudFront (CDN)
Summary: Previously, we were fetching directly from S3. Instead, we'll now fetch from AWS CloudFront (CDN in front of S3)
Test Plan: Continues to look as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2242 |
129,184 | 19.10.2021 11:47:19 | 14,400 | 248529fbf61fac491771c48edf0911f26a0b21ce | [landing] Misc styling changes
Summary:
1. cleaner CSS selectors
2. reduced row-gap
3. misc font size changes so things were more "proportional"
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -180,7 +180,7 @@ div.app_copy {\nh1.cycling_header {\nfont-family: 'iA Writer Duo S', monospace;\n- font-size: 52px;\n+ font-size: 50px;\nmargin-top: 26vh;\nwhite-space: pre-wrap;\n}\n@@ -191,8 +191,8 @@ div.tile_grid {\nmargin-right: 16%;\ngrid-template-columns: 1fr;\ngrid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\n- row-gap: 40vh;\n- margin-top: 36vh;\n+ row-gap: 36vh;\n+ margin-top: 32vh;\nmargin-bottom: 36vh;\ngrid-template-areas:\n'tile_one'\n@@ -203,12 +203,7 @@ div.tile_grid {\n'tile_six';\n}\n-div.tile_one,\n-div.tile_two,\n-div.tile_three,\n-div.tile_four,\n-div.tile_five,\n-div.tile_six {\n+div.tile_grid > div {\ndisplay: flex;\npadding: 36px;\nborder-radius: 8px;\n@@ -227,19 +222,6 @@ div.tile_six {\nbox-shadow: 0px 20px 50px rgba(126, 87, 194, 0.5);\n}\n-div.tile_one p.tile_title,\n-div.tile_two p.tile_title,\n-div.tile_three p.tile_title,\n-div.tile_four p.tile_title,\n-div.tile_five p.tile_title,\n-div.tile_six p.tile_title {\n- font-family: 'iA Writer Duo S', monospace;\n- font-weight: bold;\n- font-size: 36px;\n- color: white;\n- transition: 300ms;\n-}\n-\ndiv.tile_title_row {\ndisplay: flex;\nflex-direction: row;\n@@ -251,13 +233,15 @@ div.tile_title_row {\npadding-bottom: 20px;\n}\n-div.tile_one p,\n-div.tile_two p,\n-div.tile_three p,\n-div.tile_four p,\n-div.tile_five p,\n-div.tile_six p {\n- font-size: 24px;\n+div.tile_title_row > p.tile_title {\n+ font-family: 'iA Writer Duo S', monospace;\n+ font-weight: bold;\n+ font-size: 36px;\n+ transition: 300ms;\n+}\n+\n+div.tile_grid > div p {\n+ font-size: 22px;\ncolor: white;\ntext-align: left;\nmargin-top: 0px;\n@@ -348,17 +332,16 @@ div.body_grid > div + .starting_section {\nfont-size: 16px;\n}\n/* ===== APP LANDING GRID STYLING ===== */\n- div.tile_one p,\n- div.tile_two p,\n- div.tile_three p,\n- div.tile_four p,\n- div.tile_five p,\n- div.tile_six p {\n+ div.tile_grid > div p {\nfont-size: 16px;\n}\n+ div.tile_title_row > p.tile_title {\n+ font-size: 24px;\n+ }\n+\nh1.cycling_header {\n- font-size: 36px;\n+ font-size: 38px;\nmargin-top: 20vh;\n}\n}\n@@ -470,13 +453,8 @@ div.body_grid > div + .starting_section {\npadding-bottom: 4vh;\n}\n- div.tile_one p.tile_title,\n- div.tile_two p.tile_title,\n- div.tile_three p.tile_title,\n- div.tile_four p.tile_title,\n- div.tile_five p.tile_title,\n- div.tile_six p.tile_title {\n- font-size: 24px;\n+ div.tile_title_row > p.tile_title {\n+ font-size: 20px;\n}\n.active_card {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Misc styling changes
Summary:
1. cleaner CSS selectors
2. reduced row-gap
3. misc font size changes so things were more "proportional"
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2246 |
129,184 | 19.10.2021 11:53:11 | 14,400 | 3a79d65da519971ea4f3000699f67fea75a9754c | [landing] Get rid of `scroll-snap`
Summary: Decided to cut `scroll-snap` for now
Test Plan: Can scroll freely through page
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -13,7 +13,6 @@ div.footer_grid {\ntransition: 300ms;\ngrid-template-columns: 1fr 1fr;\ngrid-template-areas: 'sitemap subscribe_updates';\n- scroll-snap-align: center;\n}\ndiv.footer_legal {\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -13,7 +13,6 @@ div.header_grid {\ntransition: 300ms;\ngrid-template-columns: 1fr 1fr 1fr;\ngrid-template-areas: 'logo top_nav social_icons';\n- scroll-snap-align: center;\n}\ndiv.header_legal {\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -23,13 +23,6 @@ a {\ntext-decoration: none;\n}\n-.scroll_snap_container {\n- scroll-snap-type: y mandatory;\n- overflow-y: scroll;\n- margin: 0;\n- height: 100vh;\n-}\n-\n.mono {\nfont-family: 'iA Writer Duo S', monospace;\n}\n@@ -123,30 +116,25 @@ div.hero_image {\ngrid-area: hero_image;\nobject-fit: scale-down;\nalign-self: center;\n- scroll-snap-align: center;\n}\ndiv.server_image {\ngrid-area: server_image;\nobject-fit: scale-down;\nalign-self: center;\n- scroll-snap-align: center;\n}\ndiv.server_copy {\ngrid-area: server_copy;\nalign-self: center;\n- scroll-snap-align: center;\n}\ndiv.keyserver_company {\ngrid-area: keyserver_company;\ntext-align: center;\npadding-top: 80px;\n- scroll-snap-align: center;\n}\ndiv.read_the_docs {\ngrid-area: read_the_docs;\nalign-self: center;\npadding-bottom: 40px;\n- scroll-snap-align: center;\n}\n/* ===== APP LANDING GRID ===== */\n@@ -211,7 +199,6 @@ div.tile_grid > div {\njustify-content: center;\nflex-direction: column;\ntransition: 300ms;\n- scroll-snap-align: center;\nbackground-color: rgba(0, 0, 0, 0.35);\nbackdrop-filter: blur(2px);\n-webkit-backdrop-filter: blur(2px);\n@@ -472,8 +459,4 @@ div.body_grid > div + .starting_section {\npadding-left: 3%;\npadding-right: 3%;\n}\n-\n- .scroll_snap_container {\n- scroll-snap-type: none;\n- }\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -7,7 +7,6 @@ import AppLanding from './app-landing.react';\nimport Footer from './footer.react';\nimport Header from './header.react';\nimport Keyservers from './keyservers.react';\n-import css from './landing.css';\nimport Privacy from './privacy.react';\nimport Support from './support.react';\nimport Terms from './terms.react';\n@@ -51,9 +50,7 @@ function Landing(): React.Node {\n}, [onKeyservers, onPrivacy, onSupport, onTerms]);\nreturn (\n- <div\n- className={activePage.name === 'app' ? css.scroll_snap_container : null}\n- >\n+ <div>\n<Header isLegalPage={isLegalPage} activePageName={activePage.name} />\n{activePage.node}\n<Footer isLegalPage={isLegalPage} activePageName={activePage.name} />\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get rid of `scroll-snap`
Summary: Decided to cut `scroll-snap` for now
Test Plan: Can scroll freely through page
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2247 |
129,184 | 19.10.2021 11:55:54 | 14,400 | 6675d51e051fe9408a24c8044818d2af84e30ba9 | [landing] Get rid of `backdrop-filter`
Summary: Set `backdrop-filter` to none (except on Safari which seems to handle it okay?)
Test Plan: No more blur on Chrome
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -66,7 +66,7 @@ div.subscribe_updates {\n/* ===== VISUAL EFFECTS ===== */\ndiv.footer_blur {\nbackground-color: rgba(255, 255, 255, 0.125);\n- backdrop-filter: blur(2px);\n+ backdrop-filter: none;\n-webkit-backdrop-filter: blur(2px);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -200,7 +200,7 @@ div.tile_grid > div {\nflex-direction: column;\ntransition: 300ms;\nbackground-color: rgba(0, 0, 0, 0.35);\n- backdrop-filter: blur(2px);\n+ backdrop-filter: none;\n-webkit-backdrop-filter: blur(2px);\ntransition: 300ms;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Get rid of `backdrop-filter`
Summary: Set `backdrop-filter` to none (except on Safari which seems to handle it okay?)
Test Plan: No more blur on Chrome
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2248 |
129,184 | 19.10.2021 15:40:48 | 14,400 | 9f2ce19b702d9c69a417248d23664d63ef965b17 | Temporary changes for staff release
1. `expo-media-library`: don't include videos
2. `mediaConfig`: don't treat animated GIFs as videos
3. Enable `processedMessageStore` invariants for `release` build
4. Enable `processedThreadStore` invariants for `release` build
5. Patch to re-enable SplashScreen auto-hide | [
{
"change_type": "MODIFY",
"old_path": "lib/media/file-utils.js",
"new_path": "lib/media/file-utils.js",
"diff": "@@ -33,7 +33,7 @@ const mediaConfig: { [mime: string]: MediaConfig } = Object.freeze({\nserverTranscodesImage: true,\n},\n'image/gif': {\n- mediaType: 'photo_or_video',\n+ mediaType: 'photo',\nextension: 'gif',\nserverCanHandle: true,\nserverTranscodesImage: true,\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -90,10 +90,9 @@ import {\nprocessUpdatesActionType,\n} from '../types/update-types';\nimport { setNewSessionActionType } from '../utils/action-utils';\n-import { isDev } from '../utils/dev-utils';\nimport { assertObjectsAreEqual } from '../utils/objects';\n-const PROCESSED_MSG_STORE_INVARIANTS_DISABLED = !isDev;\n+const PROCESSED_MSG_STORE_INVARIANTS_DISABLED = false;\nconst _mapValuesWithKeys = _mapValues.convert({ cap: false });\n// Input must already be ordered!\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/reducers/thread-reducer.js",
"new_path": "lib/reducers/thread-reducer.js",
"diff": "@@ -49,11 +49,10 @@ import {\nimport { actionLogger } from '../utils/action-logger';\nimport { setNewSessionActionType } from '../utils/action-utils';\nimport { getConfig } from '../utils/config';\n-import { isDev } from '../utils/dev-utils';\nimport { assertObjectsAreEqual } from '../utils/objects';\nimport { sanitizeActionSecrets } from '../utils/sanitization';\n-const PROCESSED_THREAD_STORE_INVARIANTS_DISABLED = !isDev;\n+const PROCESSED_THREAD_STORE_INVARIANTS_DISABLED = false;\nfunction reduceThreadUpdates(\nthreadInfos: { +[id: string]: RawThreadInfo },\n"
},
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -188,7 +188,7 @@ class MediaGalleryKeyboard extends React.PureComponent<Props, State> {\n} = await MediaLibrary.getAssetsAsync({\nfirst: 20,\nafter,\n- mediaType: [MediaLibrary.MediaType.photo, MediaLibrary.MediaType.video],\n+ mediaType: [MediaLibrary.MediaType.photo],\nsortBy: [MediaLibrary.SortBy.modificationTime],\n});\n"
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "import type { BottomTabNavigationProp } from '@react-navigation/bottom-tabs';\nimport { createBottomTabNavigator } from '@react-navigation/bottom-tabs';\n-import * as SplashScreen from 'expo-splash-screen';\n+// import * as SplashScreen from 'expo-splash-screen';\nimport * as React from 'react';\nimport { PersistGate } from 'redux-persist/integration/react';\n@@ -180,7 +180,7 @@ function AppNavigator(props: AppNavigatorProps): React.Node {\n(async () => {\nawait waitForInteractions();\ntry {\n- await SplashScreen.hideAsync();\n+ // await SplashScreen.hideAsync();\nsetLocalSplashScreenHasHidden(true);\n} catch {}\n})();\n"
},
{
"change_type": "MODIFY",
"old_path": "native/root.react.js",
"new_path": "native/root.react.js",
"diff": "@@ -4,7 +4,7 @@ import AsyncStorage from '@react-native-community/async-storage';\nimport { useReduxDevToolsExtension } from '@react-navigation/devtools';\nimport { NavigationContainer } from '@react-navigation/native';\nimport type { PossiblyStaleNavigationState } from '@react-navigation/native';\n-import * as SplashScreen from 'expo-splash-screen';\n+// import * as SplashScreen from 'expo-splash-screen';\nimport invariant from 'invariant';\nimport * as React from 'react';\nimport { Platform, UIManager, View, StyleSheet, LogBox } from 'react-native';\n@@ -57,7 +57,7 @@ if (Platform.OS === 'android') {\nconst navInitAction = Object.freeze({ type: 'NAV/@@INIT' });\nconst navUnknownAction = Object.freeze({ type: 'NAV/@@UNKNOWN' });\n-SplashScreen.preventAutoHideAsync().catch(console.log);\n+// SplashScreen.preventAutoHideAsync().catch(console.log);\nfunction Root() {\nconst navStateRef = React.useRef();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Temporary changes for staff release
1. `expo-media-library`: don't include videos
2. `mediaConfig`: don't treat animated GIFs as videos
3. Enable `processedMessageStore` invariants for `release` build
4. Enable `processedThreadStore` invariants for `release` build
5. Patch to re-enable SplashScreen auto-hide |
129,184 | 19.10.2021 15:43:30 | 14,400 | 79ee30c6399860c33ff334b959323748bede3a3d | [native] `codeVersion` -> 106 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -395,8 +395,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 105\n- versionName '1.0.105'\n+ versionCode 106\n+ versionName '1.0.106'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.105</string>\n+ <string>1.0.106</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>105</string>\n+ <string>106</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.105</string>\n+ <string>1.0.106</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>105</string>\n+ <string>106</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -339,7 +339,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 105;\n+const codeVersion = 106;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 106 |
129,184 | 19.10.2021 13:48:15 | 14,400 | e1eebeeac94c667015a2ceb65b005c137ea55612 | [landing] Add two intermediate breakpoints for cycling_header/card_title
Summary: Add two new intermediate breakpoints on either side of the "medium" breakpoint to "buffer" the change in font-size to make it less jarring
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -291,6 +291,17 @@ div.body_grid > div + .starting_section {\npadding-top: 80px;\n}\n+/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n+@media (max-width: 1699px) {\n+ div.tile_title_row > p.tile_title {\n+ font-size: 30px;\n+ }\n+\n+ h1.cycling_header {\n+ font-size: 44px;\n+ }\n+}\n+\n/* ===== MEDIUM BREAKPOINT ===== */\n@media (max-width: 1499px) {\ndiv.body_grid {\n@@ -333,6 +344,17 @@ div.body_grid > div + .starting_section {\n}\n}\n+/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n+@media (max-width: 1299px) {\n+ div.tile_title_row > p.tile_title {\n+ font-size: 22px;\n+ }\n+\n+ h1.cycling_header {\n+ font-size: 30px;\n+ }\n+}\n+\n/* ===== SMALLEST BREAKPOINT ===== */\n@media (max-width: 1099px) {\n/* ===== TEXT STYLES ===== */\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] Add two intermediate breakpoints for cycling_header/card_title
Summary: Add two new intermediate breakpoints on either side of the "medium" breakpoint to "buffer" the change in font-size to make it less jarring
Test Plan: Looks as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2250 |
129,190 | 20.10.2021 10:05:26 | -7,200 | 74b4e13e59b5deca4422226f91abdd583205a41e | [services] Add backup server docker image
Summary:
The whole stack: D2207, D2208, D2209, D2210, D2211
Adding a new docker image for AWS built on the top of AWS base image from D2207
Test Plan: -
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Tags: #aws_init | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/Dockerfile",
"diff": "+FROM commapp/backup-base:1.0\n+\n+ENV SHELL=/bin/bash\n+\n+COPY services/backup/contents /transferred\n+COPY native/cpp/CommonCpp/grpc/protos/backup.proto /transferred/server/protos/backup.proto\n+\n+CMD /transferred/build_and_run_server.sh && /bin/bash\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/run.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+# this script should be run from the comm's root directory\n+\n+IMAGE_NAME=\"commapp/backup-server\"\n+VERSION=\"1.0\"\n+CONTAINERS_IDS=$(docker ps -aq -f ancestor=$IMAGE_NAME:$VERSION)\n+NCONTAINERS=$(docker ps -aq -f ancestor=$IMAGE_NAME:$VERSION | wc -l | sed 's/ //g')\n+\n+if [[ $NCONTAINERS -gt 1 ]]\n+then\n+ echo \"There's more than one container of '$IMAGE_NAME' image. Due to possible large sizes of containers creating a new one will be aborted now. Please remove containers manually and run this script again.\"\n+ echo \"You can run:\"\n+ echo \"docker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\"\n+ exit 0;\n+elif [[ $NCONTAINERS -eq 1 ]]\n+then\n+ echo \"A container of image $IMAGE_NAME already exists(container id: $CONTAINERS_IDS).\"\n+ if [[ $1 == \"--overwrite\" ]]\n+ then\n+ echo \"Overwriting an existing image\"\n+ docker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\n+ docker rmi $IMAGE_NAME:$VERSION\n+\n+ docker build -t $IMAGE_NAME:$VERSION -f services/backup/docker-server/Dockerfile .\n+ docker run -it -p 50051:50051 -v $HOME/.aws/credentials:/root/.aws/credentials:ro $IMAGE_NAME:$VERSION\n+ else\n+ echo \"A new one will not be created, the current one will be used.\"\n+ echo \"If you encounter errors, please remove this container manually and re-run this script.\"\n+ echo \"To remove this container, you can run:\"\n+ echo \"docker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\"\n+ docker start $CONTAINERS_IDS\n+ docker attach $CONTAINERS_IDS\n+ fi\n+else\n+ echo \"Creating a new container for image $IMAGE_NAME\"\n+ docker build -t $IMAGE_NAME:$VERSION -f services/backup/docker-server/Dockerfile .\n+ docker run -it -p 50051:50051 -v $HOME/.aws/credentials:/root/.aws/credentials:ro $IMAGE_NAME:$VERSION\n+fi\n"
},
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"private\": true,\n\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n- \"run-grpc-server-rebuild-base\": \"cd .. && ./services/tunnelbroker/docker-base/run.sh && ./services/tunnelbroker/docker-server/run.sh --overwrite && cd -\",\n- \"run-grpc-server\": \"cd .. && ./services/tunnelbroker/docker-server/run.sh --overwrite && cd -\"\n+ \"build-tunnelbroker-base\": \"cd .. && ./services/tunnelbroker/docker-base/run.sh && cd -\",\n+ \"run-tunnelbroker-server\": \"cd .. && ./services/tunnelbroker/docker-server/run.sh --overwrite && cd -\",\n+ \"build-backup-base\": \"cd .. && ./services/backup/docker-base/run.sh && cd -\",\n+ \"run-backup-server\": \"cd .. && ./services/backup/docker-server/run.sh --overwrite && cd -\"\n}\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add backup server docker image
Summary:
The whole stack: D2207, D2208, D2209, D2210, D2211
Adding a new docker image for AWS built on the top of AWS base image from D2207
Test Plan: -
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul
Tags: #aws_init
Differential Revision: https://phabricator.ashoat.com/D2208 |
129,184 | 20.10.2021 09:39:43 | 14,400 | 3cc3f115c9c83e22673019600df5348ca3619343 | Include link to landing page in README.md | [
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -9,7 +9,7 @@ The whole project is written in Flow-typed Javascript. The code is organized in\n- `native` contains the code for the React Native app, which supports both iOS and Android.\n- `server` contains the code for the Node/Express server.\n- `web` contains the code for the React desktop website.\n-- `landing` contains the code for the Comm landing page.\n+- `landing` contains the code for the [Comm landing page](https://comm.app).\n- `lib` contains code that is shared across multiple other workspaces, including most of the Redux stack that is shared across native/web.\n## Dev environment\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Include link to landing page in README.md |
129,184 | 20.10.2021 10:35:09 | 14,400 | 67877c4c4c4c52c567bcf727158ef53dd903ba9c | [lib] Introduce `RemoveAllMessagesOperation` type
Summary:
Create `remove_all` op that can be passed to `processMessageStoreOperations`
Previously there was a `removeAllMessages` function... which will be removed in subsequent diff
Test Plan: flow
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/message-types.js",
"new_path": "lib/types/message-types.js",
"diff": "@@ -352,6 +352,15 @@ export type ReplaceMessageOperation = {\n+payload: { +id: string, +messageInfo: RawMessageInfo },\n};\n+export type RekeyMessageOperation = {\n+ +type: 'rekey',\n+ +payload: { +from: string, +to: string },\n+};\n+\n+export type RemoveAllMessagesOperation = {\n+ +type: 'remove_all',\n+};\n+\nexport type ClientDBMessageInfo = {\n+id: string,\n+local_id: ?string,\n@@ -369,22 +378,19 @@ export type ClientDBReplaceMessageOperation = {\n+payload: ClientDBMessageInfo,\n};\n-export type RekeyMessageOperation = {\n- +type: 'rekey',\n- +payload: { +from: string, +to: string },\n-};\n-\nexport type MessageStoreOperation =\n| RemoveMessageOperation\n| ReplaceMessageOperation\n| RekeyMessageOperation\n- | RemoveMessagesForThreadsOperation;\n+ | RemoveMessagesForThreadsOperation\n+ | RemoveAllMessagesOperation;\nexport type ClientDBMessageStoreOperation =\n| RemoveMessageOperation\n| ClientDBReplaceMessageOperation\n| RekeyMessageOperation\n- | RemoveMessagesForThreadsOperation;\n+ | RemoveMessagesForThreadsOperation\n+ | RemoveAllMessagesOperation;\nexport const messageTruncationStatus = Object.freeze({\n// EXHAUSTIVE means we've reached the start of the thread. Either the result\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `RemoveAllMessagesOperation` type
Summary:
Create `remove_all` op that can be passed to `processMessageStoreOperations`
Previously there was a `removeAllMessages` function... which will be removed in subsequent diff
Test Plan: flow
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2255 |
129,201 | 20.10.2021 22:57:08 | -10,800 | 6b337224330990140a8b7532e0064e60014a2526 | [native] Removing unused gRPC plugins from the CMakeLists
Summary: Removing unused plugins from the gRPC building.
Test Plan: Build release for Android and IOS
Reviewers: ashoat, palys-swm, karol-bisztyga
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/CMakeLists.txt",
"new_path": "native/android/app/CMakeLists.txt",
"diff": "@@ -28,6 +28,11 @@ set(protobuf_BUILD_TESTS OFF)\n# gRPC building parameters\nset(gRPC_BUILD_CSHARP_EXT OFF)\nset(gRPC_SSL_PROVIDER \"package\" CACHE STRING \"SSL library provider\")\n+# Disable unused plugins\n+set(gRPC_BUILD_GRPC_PHP_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_RUBY_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_PYTHON_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_CSHARP_PLUGIN OFF)\n# We're updating parameters below for Cmake's find_OpenSSL() function\nset(OPENSSL_ROOT_DIR \"${CMAKE_CURRENT_SOURCE_DIR}/build/third-party-ndk/openssl/openssl-${OPENSSL_VERSION}/build/${CMAKE_ANDROID_ARCH_ABI}\")\nlist(APPEND CMAKE_FIND_ROOT_PATH \"${OPENSSL_ROOT_DIR}\")\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Removing unused gRPC plugins from the CMakeLists
Summary: Removing unused plugins from the gRPC building.
Test Plan: Build release for Android and IOS
Reviewers: ashoat, palys-swm, karol-bisztyga
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2230 |
129,190 | 21.10.2021 13:28:15 | -7,200 | bd273651a10b4efbf4f3809824bc7e17186be761 | [services] Use linux apline
Summary: Instead of using ubuntu we can use more lightweight linux alpine which is recommended for docker images
Test Plan: run all the scripts from `services` `package.json`
Reviewers: palys-swm, ashoat, geekbrother
Subscribers: geekbrother, ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_init | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/Dockerfile",
"new_path": "services/backup/docker-base/Dockerfile",
"diff": "@@ -4,8 +4,8 @@ ENV SHELL=/bin/bash\nCOPY services/backup/contents /transferred\n-RUN apt update -y &&\\\n- apt install -y libcurl4-openssl-dev libssl-dev uuid-dev zlib1g-dev libpulse-dev &&\\\n+RUN apk update &&\\\n+ apk add curl-dev openssl-dev libuuid zlib-dev &&\\\ncd / &&\\\n/transferred/install_aws_sdk.sh\n"
},
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/docker-base/Dockerfile",
"new_path": "services/tunnelbroker/docker-base/Dockerfile",
"diff": "-FROM ubuntu:20.04\n+FROM alpine:3.14\nENV DEBIAN_FRONTEND=noninteractive\nENV SHELL=/bin/bash\n+WORKDIR /\n+\nCOPY services/tunnelbroker/contents /transferred\n-RUN apt update -y &&\\\n- apt install -y cmake git build-essential autoconf libtool pkg-config libboost-all-dev libfmt-dev &&\\\n+RUN apk update &&\\\n+ apk add bash cmake git build-base autoconf libtool pkgconfig boost-dev fmt &&\\\ncd /usr/lib &&\\\ngit clone https://github.com/facebook/folly.git --branch v2020.01.13.00 --single-branch &&\\\ngit clone https://github.com/google/glog.git --branch v0.4.0 --single-branch &&\\\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Use linux apline
Summary: Instead of using ubuntu we can use more lightweight linux alpine which is recommended for docker images
Test Plan: run all the scripts from `services` `package.json`
Reviewers: palys-swm, ashoat, geekbrother
Reviewed By: palys-swm, ashoat
Subscribers: geekbrother, ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_init
Differential Revision: https://phabricator.ashoat.com/D2223 |
129,179 | 20.10.2021 10:57:13 | 14,400 | 14872279453b38d3aec1ff6cbcbd690702bfe1b4 | refactor register currentUserInfo in account-creator.js + refactor lib/actions register action
Summary: refactor currentUserInfo object server side so its getting its values from fetchLoggedInUserInfo, refactor lib/action to reflect server side change.
Test Plan: register a new user.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -79,10 +79,7 @@ const register = (\nplatformDetails: getConfig().platformDetails,\n});\nreturn {\n- currentUserInfo: {\n- id: response.id,\n- username: registerInfo.username,\n- },\n+ currentUserInfo: response.currentUserInfo,\nrawMessageInfos: response.rawMessageInfos,\nthreadInfos: response.cookieChange.threadInfos,\nuserInfos: response.cookieChange.userInfos,\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -54,6 +54,7 @@ export type RegisterRequest = {\nexport type RegisterResponse = {\nid: string,\nrawMessageInfos: $ReadOnlyArray<RawMessageInfo>,\n+ currentUserInfo: OldLoggedInUserInfo | LoggedInUserInfo,\ncookieChange: {\nthreadInfos: { +[id: string]: RawThreadInfo },\nuserInfos: $ReadOnlyArray<UserInfo>,\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/creators/account-creator.js",
"new_path": "server/src/creators/account-creator.js",
"diff": "@@ -23,7 +23,10 @@ import { values } from 'lib/utils/objects';\nimport { dbQuery, SQL } from '../database/database';\nimport { deleteCookie } from '../deleters/cookie-deleters';\nimport { fetchThreadInfos } from '../fetchers/thread-fetchers';\n-import { fetchKnownUserInfos } from '../fetchers/user-fetchers';\n+import {\n+ fetchLoggedInUserInfo,\n+ fetchKnownUserInfos,\n+} from '../fetchers/user-fetchers';\nimport { verifyCalendarQueryThreadIDs } from '../responders/entry-responders';\nimport { createNewUserCookie, setNewSession } from '../session/cookies';\nimport { createScriptViewer } from '../session/scripts';\n@@ -147,10 +150,16 @@ async function createAccount(\ntext: message,\n}));\nconst messageDatas = [...ashoatMessageDatas, ...privateMessageDatas];\n- const [messageInfos, threadsResult, userInfos] = await Promise.all([\n+ const [\n+ messageInfos,\n+ threadsResult,\n+ userInfos,\n+ currentUserInfo,\n+ ] = await Promise.all([\ncreateMessages(viewer, messageDatas),\nfetchThreadInfos(viewer),\nfetchKnownUserInfos(viewer),\n+ fetchLoggedInUserInfo(viewer),\n]);\nconst rawMessageInfos = [\n...ashoatThreadResult.newMessageInfos,\n@@ -161,6 +170,7 @@ async function createAccount(\nreturn {\nid,\nrawMessageInfos,\n+ currentUserInfo,\ncookieChange: {\nthreadInfos: threadsResult.threadInfos,\nuserInfos: values(userInfos),\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | refactor register currentUserInfo in account-creator.js + refactor lib/actions register action
Summary: refactor currentUserInfo object server side so its getting its values from fetchLoggedInUserInfo, refactor lib/action to reflect server side change.
Test Plan: register a new user.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2253 |
129,184 | 21.10.2021 19:07:11 | 14,400 | 1c78e1b549324d2283bd3e0d21f1b71aad8fa434 | [iOS] Remove `showSplashScreenFor:rootViewController` from `AppDelegate.mm`
Summary: It appears that removing this from `AppDelegate.mm` resolves the "stuck" splash screen issue
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/AppDelegate.mm",
"new_path": "native/ios/Comm/AppDelegate.mm",
"diff": "@@ -120,13 +120,6 @@ extern RCTBridge *_bridge_reanimated;\nrootView.loadingViewFadeDelay = 0;\nrootView.loadingViewFadeDuration = 0.001;\n- // This sets up the splash screen to display until the JS side is ready for it\n- // to clear\n- EXSplashScreenService *splashScreenService =\n- (EXSplashScreenService *)[UMModuleRegistryProvider\n- getSingletonModuleForClass:[EXSplashScreenService class]];\n- [splashScreenService showSplashScreenFor:rootViewController];\n-\nUMNativeModulesProxy *proxy =\n[bridge moduleForClass:[UMNativeModulesProxy class]];\nUMModuleRegistry *moduleRegistry = [proxy umModuleRegistry];\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [iOS] Remove `showSplashScreenFor:rootViewController` from `AppDelegate.mm`
Summary: It appears that removing this from `AppDelegate.mm` resolves the "stuck" splash screen issue
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2271 |
129,179 | 21.10.2021 15:21:57 | 14,400 | d948651849c13461eb474f0ea8a84937d761e308 | feat: add accessability labels to images
Summary: add alt tags to images
Test Plan: view source for alt tags
Reviewers: ashoat, atul, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -16,12 +16,30 @@ import css from './landing.css';\nimport StarBackground from './star-background.react';\nconst screenshots = [\n- 'federated-prototype',\n- 'customizable-prototype',\n- 'e2e-encrypted-prototype',\n- 'sovereign-prototype',\n- 'open-source-prototype',\n- 'less-noisy-prototype',\n+ {\n+ alt: 'a mobile phone conversation list screen',\n+ file: 'federated-prototype',\n+ },\n+ {\n+ alt: 'a mobile phone with customized dashboard screen',\n+ file: 'customizable-prototype',\n+ },\n+ {\n+ alt: 'a mobile phone chat conversation screen',\n+ file: 'e2e-encrypted-prototype',\n+ },\n+ {\n+ alt: 'a mobile phone user information screen',\n+ file: 'sovereign-prototype',\n+ },\n+ {\n+ alt: 'a mobile phone addon app selection screen',\n+ file: 'open-source-prototype',\n+ },\n+ {\n+ alt: 'a mobile phone notification options screen',\n+ file: 'less-noisy-prototype',\n+ },\n];\nconst LandingAssetsS3URL = 'https://dh9fld3hutpxf.cloudfront.net';\n@@ -37,7 +55,7 @@ function AppLanding(): React.Node {\ntestImg.onload = () => {\nfor (const imageFileName of screenshots) {\nconst image = new Image();\n- image.src = `${LandingAssetsS3URL}/${imageFileName}.webp`;\n+ image.src = `${LandingAssetsS3URL}/${imageFileName.file}.webp`;\n}\n};\n@@ -45,7 +63,7 @@ function AppLanding(): React.Node {\ntestImg.onerror = () => {\nfor (const imageFileName of screenshots) {\nconst image = new Image();\n- image.src = `${LandingAssetsS3URL}/${imageFileName}.png`;\n+ image.src = `${LandingAssetsS3URL}/${imageFileName.file}.png`;\n}\n};\n@@ -64,14 +82,17 @@ function AppLanding(): React.Node {\n<div className={css.app_preview}>\n<picture>\n<source\n- srcSet={`${LandingAssetsS3URL}/${screenshots[imageIdx]}.webp`}\n+ srcSet={`${LandingAssetsS3URL}/${screenshots[imageIdx].file}.webp`}\ntype=\"image/webp\"\n/>\n<source\n- srcSet={`${LandingAssetsS3URL}/${screenshots[imageIdx]}.png`}\n+ srcSet={`${LandingAssetsS3URL}/${screenshots[imageIdx].file}.png`}\ntype=\"image/png\"\n/>\n- <img src={`${LandingAssetsS3URL}/${screenshots[imageIdx]}.png`} />\n+ <img\n+ src={`${LandingAssetsS3URL}/${screenshots[imageIdx].file}.png`}\n+ alt={screenshots[imageIdx].alt}\n+ />\n</picture>\n</div>\n<div className={css.app_copy}>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | feat: add accessability labels to images
Summary: add alt tags to images
Test Plan: view source for alt tags
Reviewers: ashoat, atul, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2254 |
129,179 | 21.10.2021 17:51:38 | 14,400 | 2c77ac717e12c6b2b4f59aefb1948bc9ada1f3d5 | fix centering issue hero text
Summary: Center hero text with phone on resize
Test Plan:
resize the window
Before:
After:
Reviewers: palys-swm, ashoat, atul
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -96,10 +96,13 @@ function AppLanding(): React.Node {\n</picture>\n</div>\n<div className={css.app_copy}>\n+ <div className={css.app_copy_wrapper}>\n<CyclingHeader />\n<p className={css.app_landing_subheading}>\n(think "Web3 Discord")\n</p>\n+ </div>\n+\n<div className={css.tile_grid}>\n<InfoCard\nidx={0}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -166,10 +166,17 @@ div.app_copy {\njustify-self: left;\n}\n+.app_copy_wrapper {\n+ height: 70vh;\n+ display: flex;\n+ flex-direction: column;\n+ justify-content: center;\n+}\n+\nh1.cycling_header {\nfont-family: 'iA Writer Duo S', monospace;\nfont-size: 50px;\n- margin-top: 26vh;\n+ margin: 0;\nwhite-space: pre-wrap;\n}\n@@ -340,7 +347,6 @@ div.body_grid > div + .starting_section {\nh1.cycling_header {\nfont-size: 38px;\n- margin-top: 20vh;\n}\n}\n@@ -424,6 +430,10 @@ div.body_grid > div + .starting_section {\nmax-width: 96vw;\n}\n+ .app_copy_wrapper {\n+ height: 30vh;\n+ }\n+\ndiv.app_copy {\ngrid-area: app_copy;\nalign-self: center;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | fix centering issue hero text
Summary: Center hero text with phone on resize
Test Plan:
resize the window
Before: https://share.getcloudapp.com/Kou7e8D0
After: https://share.getcloudapp.com/04u5gnoG
Reviewers: palys-swm, ashoat, atul
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2269 |
129,179 | 27.10.2021 13:39:56 | 14,400 | 4dcc3c32fdc2f12a29a1cc610659fdf09fafa402 | [server] chore sort endpoints and add default user notifications to endpoints file
Summary: Sort endpoints file and add the default_user_settings type check for a responder
Test Plan: review
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/endpoints.js",
"new_path": "lib/types/endpoints.js",
"diff": "@@ -46,36 +46,37 @@ const socketOnlyEndpoints = Object.freeze({\ntype SocketOnlyEndpoint = $Values<typeof socketOnlyEndpoints>;\nconst socketPreferredEndpoints = Object.freeze({\n- UPDATE_USER_SUBSCRIPTION: 'update_user_subscription',\n- UPDATE_DEVICE_TOKEN: 'update_device_token',\n- UPDATE_ACCOUNT: 'update_account',\n- SEND_VERIFICATION_EMAIL: 'send_verification_email',\n- SEARCH_USERS: 'search_users',\n- SEND_PASSWORD_RESET_EMAIL: 'send_password_reset_email',\n+ CREATE_ENTRY: 'create_entry',\n+ CREATE_ERROR_REPORT: 'create_error_report',\n+ CREATE_MULTIMEDIA_MESSAGE: 'create_multimedia_message',\nCREATE_TEXT_MESSAGE: 'create_text_message',\n+ CREATE_THREAD: 'create_thread',\n+ DELETE_ENTRY: 'delete_entry',\n+ DELETE_THREAD: 'delete_thread',\n+ DELETE_UPLOAD: 'delete_upload',\nFETCH_ENTRIES: 'fetch_entries',\nFETCH_ENTRY_REVISIONS: 'fetch_entry_revisions',\n- VERIFY_CODE: 'verify_code',\n- DELETE_THREAD: 'delete_thread',\n- CREATE_ENTRY: 'create_entry',\n- UPDATE_ENTRY: 'update_entry',\n- DELETE_ENTRY: 'delete_entry',\n- RESTORE_ENTRY: 'restore_entry',\n- UPDATE_ROLE: 'update_role',\n- REMOVE_MEMBERS: 'remove_members',\n- LEAVE_THREAD: 'leave_thread',\n- UPDATE_THREAD: 'update_thread',\n- CREATE_THREAD: 'create_thread',\n+ FETCH_ERROR_REPORT_INFOS: 'fetch_error_report_infos',\nFETCH_MESSAGES: 'fetch_messages',\n+ GET_USER_PUBLIC_KEYS: 'get_user_public_keys',\nJOIN_THREAD: 'join_thread',\n- SET_THREAD_UNREAD_STATUS: 'set_thread_unread_status',\n- CREATE_ERROR_REPORT: 'create_error_report',\n- FETCH_ERROR_REPORT_INFOS: 'fetch_error_report_infos',\n+ LEAVE_THREAD: 'leave_thread',\n+ REMOVE_MEMBERS: 'remove_members',\nREQUEST_ACCESS: 'request_access',\n- CREATE_MULTIMEDIA_MESSAGE: 'create_multimedia_message',\n- DELETE_UPLOAD: 'delete_upload',\n+ RESTORE_ENTRY: 'restore_entry',\n+ SEARCH_USERS: 'search_users',\n+ SEND_PASSWORD_RESET_EMAIL: 'send_password_reset_email',\n+ SEND_VERIFICATION_EMAIL: 'send_verification_email',\n+ SET_THREAD_UNREAD_STATUS: 'set_thread_unread_status',\n+ UPDATE_ACCOUNT: 'update_account',\n+ UPDATE_DEFAULT_USER_SETTINGS: 'update_default_user_settings',\n+ UPDATE_DEVICE_TOKEN: 'update_device_token',\n+ UPDATE_ENTRY: 'update_entry',\nUPDATE_RELATIONSHIPS: 'update_relationships',\n- GET_USER_PUBLIC_KEYS: 'get_user_public_keys',\n+ UPDATE_ROLE: 'update_role',\n+ UPDATE_THREAD: 'update_thread',\n+ UPDATE_USER_SUBSCRIPTION: 'update_user_subscription',\n+ VERIFY_CODE: 'verify_code',\n});\ntype SocketPreferredEndpoint = $Values<typeof socketPreferredEndpoints>;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] chore sort endpoints and add default user notifications to endpoints file
Summary: Sort endpoints file and add the default_user_settings type check for a responder
Test Plan: review
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2275 |
129,184 | 27.10.2021 01:01:25 | 14,400 | 18cfce2968c58acfa798603185bacd20ee9812b7 | [CommCoreModule] Fix memory issue in `getAllMessages`
Summary: Described here:https://www.notion.so/commapp/Runtime-memory-issues-in-getAllMessages-b2bc7f334a094cabb4f92325adbcc4cc
Test Plan: Successfully builds, able to get expected response from `GetAllMessages`
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -170,15 +170,17 @@ jsi::Value CommCoreModule::getAllMessages(jsi::Runtime &rt) {\n} catch (std::system_error &e) {\nerror = e.what();\n}\n+ auto messagesVectorPtr =\n+ std::make_shared<std::vector<Message>>(std::move(messagesVector));\nthis->jsInvoker_->invokeAsync(\n- [&messagesVector, &innerRt, promise, error, numMessages]() {\n+ [messagesVectorPtr, &innerRt, promise, error, numMessages]() {\nif (error.size()) {\npromise->reject(error);\nreturn;\n}\njsi::Array jsiMessages = jsi::Array(innerRt, numMessages);\nsize_t writeIndex = 0;\n- for (const Message &message : messagesVector) {\n+ for (const Message &message : *messagesVectorPtr) {\nauto jsiMessage = jsi::Object(innerRt);\njsiMessage.setProperty(innerRt, \"id\", message.id);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Fix memory issue in `getAllMessages`
Summary: Described here:https://www.notion.so/commapp/Runtime-memory-issues-in-getAllMessages-b2bc7f334a094cabb4f92325adbcc4cc
Test Plan: Successfully builds, able to get expected response from `GetAllMessages`
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2282 |
129,179 | 27.10.2021 16:24:55 | 14,400 | 696c61f73b2dbcd36539e82d880023edb1da230f | [refactor][native] sort route names
Summary: sort routes alphabetically
Test Plan: make sure names are in order and no regression is introduced, build and run the app. Clicked through it a bit and make sure nothing is broken.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -23,49 +23,49 @@ import type { CustomServerModalParams } from '../profile/custom-server-modal.rea\nimport type { RelationshipListItemTooltipModalParams } from '../profile/relationship-list-item-tooltip-modal.react';\nimport type { ActionResultModalParams } from './action-result-modal.react';\n+export const ActionResultModalRouteName = 'ActionResultModal';\n+export const AddUsersModalRouteName = 'AddUsersModal';\n+export const AppearancePreferencesRouteName = 'AppearancePreferences';\nexport const AppRouteName = 'App';\n-export const TabNavigatorRouteName = 'TabNavigator';\n-export const ComposeThreadRouteName = 'ComposeThread';\n-export const DeleteThreadRouteName = 'DeleteThread';\n-export const ThreadSettingsRouteName = 'ThreadSettings';\n-export const MessageListRouteName = 'MessageList';\n-export const LoggedOutModalRouteName = 'LoggedOutModal';\n-export const ProfileRouteName = 'Profile';\nexport const AppsRouteName = 'Apps';\n-export const ProfileScreenRouteName = 'ProfileScreen';\n-export const RelationshipListItemTooltipModalRouteName =\n- 'RelationshipListItemTooltipModal';\n-export const ChatRouteName = 'Chat';\n-export const ChatThreadListRouteName = 'ChatThreadList';\n-export const HomeChatThreadListRouteName = 'HomeChatThreadList';\nexport const BackgroundChatThreadListRouteName = 'BackgroundChatThreadList';\n-export const CalendarRouteName = 'Calendar';\n+export const BlockListRouteName = 'BlockList';\nexport const BuildInfoRouteName = 'BuildInfo';\n+export const CalendarRouteName = 'Calendar';\n+export const CameraModalRouteName = 'CameraModal';\n+export const ChatRouteName = 'Chat';\n+export const ChatThreadListRouteName = 'ChatThreadList';\n+export const ColorPickerModalRouteName = 'ColorPickerModal';\n+export const ComposeSubthreadModalRouteName = 'ComposeSubthreadModal';\n+export const ComposeThreadRouteName = 'ComposeThread';\n+export const CustomServerModalRouteName = 'CustomServerModal';\nexport const DeleteAccountRouteName = 'DeleteAccount';\n+export const DeleteThreadRouteName = 'DeleteThread';\nexport const DevToolsRouteName = 'DevTools';\nexport const EditPasswordRouteName = 'EditPassword';\n-export const AppearancePreferencesRouteName = 'AppearancePreferences';\n-export const PrivacyPreferencesRouteName = 'PrivacyPreferences';\n-export const ThreadPickerModalRouteName = 'ThreadPickerModal';\n-export const AddUsersModalRouteName = 'AddUsersModal';\n-export const CustomServerModalRouteName = 'CustomServerModal';\n-export const ColorPickerModalRouteName = 'ColorPickerModal';\n-export const ComposeSubthreadModalRouteName = 'ComposeSubthreadModal';\n+export const FriendListRouteName = 'FriendList';\n+export const HomeChatThreadListRouteName = 'HomeChatThreadList';\nexport const ImageModalRouteName = 'ImageModal';\n+export const ImagePasteModalRouteName = 'ImagePasteModal';\n+export const LoggedOutModalRouteName = 'LoggedOutModal';\n+export const MessageListRouteName = 'MessageList';\nexport const MultimediaMessageTooltipModalRouteName =\n'MultimediaMessageTooltipModal';\n-export const ActionResultModalRouteName = 'ActionResultModal';\n+export const PrivacyPreferencesRouteName = 'PrivacyPreferences';\n+export const ProfileRouteName = 'Profile';\n+export const ProfileScreenRouteName = 'ProfileScreen';\n+export const RelationshipListItemTooltipModalRouteName =\n+ 'RelationshipListItemTooltipModal';\n+export const RobotextMessageTooltipModalRouteName =\n+ 'RobotextMessageTooltipModal';\n+export const SidebarListModalRouteName = 'SidebarListModal';\n+export const TabNavigatorRouteName = 'TabNavigator';\nexport const TextMessageTooltipModalRouteName = 'TextMessageTooltipModal';\n+export const ThreadPickerModalRouteName = 'ThreadPickerModal';\nexport const ThreadSettingsMemberTooltipModalRouteName =\n'ThreadSettingsMemberTooltipModal';\n-export const CameraModalRouteName = 'CameraModal';\n+export const ThreadSettingsRouteName = 'ThreadSettings';\nexport const VideoPlaybackModalRouteName = 'VideoPlaybackModal';\n-export const FriendListRouteName = 'FriendList';\n-export const BlockListRouteName = 'BlockList';\n-export const SidebarListModalRouteName = 'SidebarListModal';\n-export const ImagePasteModalRouteName = 'ImagePasteModal';\n-export const RobotextMessageTooltipModalRouteName =\n- 'RobotextMessageTooltipModal';\nexport type RootParamList = {\n+LoggedOutModal: void,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [refactor][native] sort route names
Summary: sort routes alphabetically
Test Plan: make sure names are in order and no regression is introduced, build and run the app. Clicked through it a bit and make sure nothing is broken.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2280 |
129,184 | 29.10.2021 15:02:06 | 14,400 | 316538446ac3d2027cf6719d81ee276ae026c20d | [CommCoreModule] Make `processMessageStoreOps:messageStoreOps` `vector<unique_ptr>`
Summary: Modify type of std::vector to be consistent
Test Plan: `processMessageStoreOps` continues to work as expected (cleared the message store, bulk loaded my prod message store, rekeyed some messages, etc)
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -228,7 +228,7 @@ jsi::Value CommCoreModule::processMessageStoreOperations(\njsi::Runtime &rt,\nconst jsi::Array &operations) {\n- std::vector<std::shared_ptr<MessageStoreOperationBase>> messageStoreOps;\n+ std::vector<std::unique_ptr<MessageStoreOperationBase>> messageStoreOps;\nfor (auto idx = 0; idx < operations.size(rt); idx++) {\nauto op = operations.getValueAtIndex(rt, idx).asObject(rt);\n@@ -267,13 +267,17 @@ jsi::Value CommCoreModule::processMessageStoreOperations(\n}\n}\n+ auto messageStoreOpsPtr =\n+ std::make_shared<std::vector<std::unique_ptr<MessageStoreOperationBase>>>(\n+ std::move(messageStoreOps));\n+\nreturn createPromiseAsJSIValue(\nrt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {\ntaskType job = [=, &innerRt]() {\nstd::string error;\ntry {\nDatabaseManager::getQueryExecutor().beginTransaction();\n- for (const auto &operation : messageStoreOps) {\n+ for (const auto &operation : *messageStoreOpsPtr) {\noperation->execute();\n}\nDatabaseManager::getQueryExecutor().commitTransaction();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Make `processMessageStoreOps:messageStoreOps` `vector<unique_ptr>`
Summary: Modify type of std::vector to be consistent
Test Plan: `processMessageStoreOps` continues to work as expected (cleared the message store, bulk loaded my prod message store, rekeyed some messages, etc)
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2297 |
129,179 | 30.10.2021 16:07:12 | 14,400 | ea5b80a83c011218c48251aee50596151ca3c72a | [refactor][native] profile screen add additional cases to action row
Summary: handle danger text, custom right items, custom text
Test Plan: got to profile page make sure everything still works
Reviewers: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/components/action-row.react.js",
"new_path": "native/components/action-row.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { View, Text } from 'react-native';\n-import Icon from 'react-native-vector-icons/Ionicons';\n+import { View, Text as RawText } from 'react-native';\n+import RawIcon, {\n+ type IoniconsGlyphs,\n+} from 'react-native-vector-icons/Ionicons';\nimport Button from '../components/button.react';\nimport { useColors, useStyles } from '../themes/colors';\n-type Props = {\n+type TextProps = {\n+content: string,\n- +onPress: () => void,\n+ +danger?: boolean,\n};\n-function ActionRow(props: Props): React.Node {\n- const { content, onPress } = props;\n+function Text(props: TextProps): React.Node {\n+ const { content, danger } = props;\n+ const styles = useStyles(actionRowStyles);\n+ return (\n+ <RawText style={danger ? styles.dangerText : styles.text}>\n+ {content}\n+ </RawText>\n+ );\n+}\n+\n+type IconProps = {\n+ +name: IoniconsGlyphs,\n+};\n+\n+function Icon(props: IconProps): React.Node {\n+ const { name } = props;\n+ const colors = useColors();\n+ return <RawIcon name={name} size={20} color={colors.navigationChevron} />;\n+}\n+\n+type RowProps = {\n+ +onPress?: () => void,\n+ +children: React.Node,\n+};\n+\n+function Row(props: RowProps): React.Node {\n+ const { onPress, children } = props;\nconst styles = useStyles(actionRowStyles);\nconst colors = useColors();\n+\n+ if (!onPress) {\n+ return <View style={styles.wrapper}>{children}</View>;\n+ }\n+\nreturn (\n- <View style={styles.section}>\n<Button\nonPress={onPress}\n- style={styles.submenuButton}\n+ style={styles.button}\niosFormat=\"highlight\"\niosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}\niosActiveOpacity={0.85}\n>\n- <Text style={styles.submenuText}>{content}</Text>\n- <Icon\n- name=\"ios-arrow-forward\"\n- size={20}\n- color={colors.navigationChevron}\n- />\n+ {children}\n</Button>\n- </View>\n);\n}\nconst actionRowStyles = {\n- section: {\n+ wrapper: {\nbackgroundColor: 'panelForeground',\n- },\n- submenuButton: {\nflexDirection: 'row',\npaddingHorizontal: 24,\npaddingVertical: 10,\n- alignItems: 'center',\n},\n- submenuText: {\n+ button: {\n+ paddingHorizontal: 24,\n+ paddingVertical: 10,\n+ flexDirection: 'row',\n+ },\n+ text: {\ncolor: 'panelForegroundLabel',\nflex: 1,\nfontSize: 16,\n},\n+ dangerText: {\n+ color: 'redText',\n+ flex: 1,\n+ fontSize: 16,\n+ },\n};\n-export default ActionRow;\n+export default { Row, Icon, Text };\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -17,7 +17,7 @@ import {\n} from 'lib/utils/action-utils';\nimport { deleteNativeCredentialsFor } from '../account/native-credentials';\n-import ActionRow from '../components/action-row.react';\n+import Action from '../components/action-row.react';\nimport Button from '../components/button.react';\nimport EditSettingButton from '../components/edit-setting-button.react';\nimport { SingleLine } from '../components/single-line.react';\n@@ -51,6 +51,22 @@ type Props = {\n+logOut: (preRequestUserState: PreRequestUserState) => Promise<LogOutResult>,\n};\n+type ProfileRowProps = {\n+ +content: string,\n+ +onPress: () => void,\n+ +danger?: boolean,\n+};\n+\n+function ProfileRow(props: ProfileRowProps): React.Node {\n+ const { content, onPress, danger } = props;\n+ return (\n+ <Action.Row onPress={onPress}>\n+ <Action.Text {...{ danger, content }} />\n+ <Action.Icon name=\"ios-arrow-forward\" />\n+ </Action.Row>\n+ );\n+}\n+\nclass ProfileScreen extends React.PureComponent<Props> {\nget username() {\nreturn this.props.currentUserInfo && !this.props.currentUserInfo.anonymous\n@@ -67,18 +83,16 @@ class ProfileScreen extends React.PureComponent<Props> {\n}\nrender() {\n- const { panelIosHighlightUnderlay: underlay } = this.props.colors;\n-\nlet appearancePreferences, developerTools;\nif (\n(this.props.currentUserInfo && isStaff(this.props.currentUserInfo.id)) ||\n__DEV__\n) {\nappearancePreferences = (\n- <ActionRow content=\"Appearance\" onPress={this.onPressAppearance} />\n+ <ProfileRow content=\"Appearance\" onPress={this.onPressAppearance} />\n);\ndeveloperTools = (\n- <ActionRow content=\"Developer tools\" onPress={this.onPressDevTools} />\n+ <ProfileRow content=\"Developer tools\" onPress={this.onPressDevTools} />\n);\n}\n@@ -90,10 +104,8 @@ class ProfileScreen extends React.PureComponent<Props> {\n>\n<Text style={this.props.styles.header}>ACCOUNT</Text>\n<View style={this.props.styles.section}>\n- <View style={this.props.styles.paddedRow}>\n- <Text style={this.props.styles.loggedInLabel}>\n- {'Logged in as '}\n- </Text>\n+ <Action.Row>\n+ <Text style={this.props.styles.loggedInLabel}>Logged in as </Text>\n<SingleLine\nstyle={[this.props.styles.label, this.props.styles.username]}\n>\n@@ -105,8 +117,8 @@ class ProfileScreen extends React.PureComponent<Props> {\n>\n<Text style={this.props.styles.logOutText}>Log out</Text>\n</Button>\n- </View>\n- <View style={this.props.styles.paddedRow}>\n+ </Action.Row>\n+ <Action.Row>\n<Text style={this.props.styles.label}>Password</Text>\n<Text\nstyle={[this.props.styles.content, this.props.styles.value]}\n@@ -119,35 +131,30 @@ class ProfileScreen extends React.PureComponent<Props> {\ncanChangeSettings={true}\nstyle={this.props.styles.editPasswordButton}\n/>\n- </View>\n+ </Action.Row>\n</View>\n<View style={this.props.styles.section}>\n- <ActionRow content=\"Friend list\" onPress={this.onPressFriendList} />\n- <ActionRow content=\"Block list\" onPress={this.onPressBlockList} />\n+ <ProfileRow\n+ content=\"Friend list\"\n+ onPress={this.onPressFriendList}\n+ />\n+ <ProfileRow content=\"Block list\" onPress={this.onPressBlockList} />\n</View>\n-\n<Text style={this.props.styles.header}>PREFERENCES</Text>\n<View style={this.props.styles.section}>\n{appearancePreferences}\n- <ActionRow content=\"Privacy\" onPress={this.onPressPrivacy} />\n+ <ProfileRow content=\"Privacy\" onPress={this.onPressPrivacy} />\n</View>\n-\n<View style={this.props.styles.section}>\n- <ActionRow content=\"Build info\" onPress={this.onPressBuildInfo} />\n+ <ProfileRow content=\"Build info\" onPress={this.onPressBuildInfo} />\n{developerTools}\n</View>\n<View style={this.props.styles.unpaddedSection}>\n- <Button\n+ <ProfileRow\n+ content=\"Delete account...\"\n+ danger\nonPress={this.onPressDeleteAccount}\n- style={this.props.styles.deleteAccountButton}\n- iosFormat=\"highlight\"\n- iosHighlightUnderlayColor={underlay}\n- iosActiveOpacity={0.85}\n- >\n- <Text style={this.props.styles.deleteAccountText}>\n- Delete account...\n- </Text>\n- </Button>\n+ />\n</View>\n</ScrollView>\n</View>\n@@ -253,11 +260,6 @@ const unboundStyles = {\npaddingHorizontal: 24,\npaddingVertical: 12,\n},\n- deleteAccountText: {\n- color: 'redText',\n- flex: 1,\n- fontSize: 16,\n- },\neditPasswordButton: {\npaddingTop: Platform.OS === 'android' ? 3 : 2,\n},\n@@ -308,17 +310,6 @@ const unboundStyles = {\nmarginBottom: 24,\npaddingVertical: 1,\n},\n- submenuButton: {\n- flexDirection: 'row',\n- paddingHorizontal: 24,\n- paddingVertical: 10,\n- alignItems: 'center',\n- },\n- submenuText: {\n- color: 'panelForegroundLabel',\n- flex: 1,\n- fontSize: 16,\n- },\nunpaddedSection: {\nbackgroundColor: 'panelForeground',\nborderBottomWidth: 1,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [refactor][native] profile screen add additional cases to action row
Summary: handle danger text, custom right items, custom text
Test Plan: got to profile page make sure everything still works
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2279 |
129,184 | 31.10.2021 14:25:47 | 14,400 | 0809df03dc169218559f47fa863e43b712dda4d5 | [CI] Introduce `exportOptions.plist`
Summary: This plist file gets passed as an argument to `xcodebuild -archive ...` for command-line builds to replace the export archive GUI wizard in Xcode
Test Plan: Tested locally, not yet on CI
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/ios/exportOptions.plist",
"diff": "+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<!DOCTYPE plist PUBLIC \"-//Apple//DTD PLIST 1.0//EN\" \"http://www.apple.com/DTDs/PropertyList-1.0.dtd\">\n+<plist version=\"1.0\">\n+<dict>\n+ <key>destination</key>\n+ <string>upload</string>\n+ <key>signingStyle</key>\n+ <string>automatic</string>\n+ <key>uploadBitcode</key>\n+ <true/>\n+ <key>uploadSymbols</key>\n+ <true/>\n+ <key>compileBitcode</key>\n+ <true/>\n+ <key>method</key>\n+ <string>app-store</string>\n+ <key>teamID</key>\n+ <string>H98Y8MH53M</string>\n+</dict>\n+</plist>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `exportOptions.plist`
Summary: This plist file gets passed as an argument to `xcodebuild -archive ...` for command-line builds to replace the export archive GUI wizard in Xcode
Test Plan: Tested locally, not yet on CI
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2299 |
129,179 | 01.11.2021 14:02:47 | 14,400 | 7f66bdea48ec139e2cbc08a51a947b84058c239d | [server] query user settings on login + registration using user-fetchers fetchLoggedInUserInfo
Summary: query settings table and return user selected settings
Test Plan: login or register an account. View settings in redux
Reviewers: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/user-types.js",
"new_path": "lib/types/user-types.js",
"diff": "@@ -47,6 +47,9 @@ export type OldLoggedInUserInfo = {\nexport type LoggedInUserInfo = {\n+id: string,\n+username: string,\n+ +settings?: {\n+ +defaultNotifications?: string,\n+ },\n};\nexport type LoggedOutUserInfo = {\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/fetchers/user-fetchers.js",
"new_path": "server/src/fetchers/user-fetchers.js",
"diff": "@@ -195,22 +195,36 @@ async function fetchCurrentUserInfo(\nasync function fetchLoggedInUserInfo(\nviewer: Viewer,\n): Promise<OldLoggedInUserInfo | LoggedInUserInfo> {\n- const query = SQL`\n+ const userQuery = SQL`\nSELECT id, username\nFROM users\n- WHERE id IN (${viewer.userID})\n+ WHERE id = ${viewer.userID}\n+ `;\n+\n+ const settingsQuery = SQL`\n+ SELECT name, data\n+ FROM settings\n+ WHERE user = ${viewer.userID}\n`;\n- const [response] = await dbQuery(query);\n- const [row] = response;\n+\n+ const [[userResult], [settingsResult]] = await Promise.all([\n+ dbQuery(userQuery),\n+ dbQuery(settingsQuery),\n+ ]);\n+\n+ const [userRow] = userResult;\n+\nconst stillExpectsEmailFields = !hasMinCodeVersion(\nviewer.platformDetails,\n87,\n);\n- if (!row) {\n+\n+ if (!userRow) {\nthrow new ServerError('unknown_error');\n}\n- const id = row.id.toString();\n- const { username } = row;\n+\n+ const id = userRow.id.toString();\n+ const { username } = userRow;\nif (stillExpectsEmailFields) {\nreturn {\n@@ -220,9 +234,21 @@ async function fetchLoggedInUserInfo(\nemailVerified: true,\n};\n}\n+\n+ const featureGateSettings = !hasMinCodeVersion(viewer.platformDetails, 1000);\n+\n+ if (featureGateSettings) {\nreturn { id, username };\n}\n+ const settings = settingsResult.reduce((prev, curr) => {\n+ prev[curr.name] = curr.data;\n+ return prev;\n+ }, {});\n+\n+ return { id, username, settings };\n+}\n+\nasync function fetchAllUserIDs(): Promise<string[]> {\nconst query = SQL`SELECT id FROM users`;\nconst [result] = await dbQuery(query);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] query user settings on login + registration using user-fetchers fetchLoggedInUserInfo
Summary: query settings table and return user selected settings
Test Plan: login or register an account. View settings in redux
Reviewers: ashoat, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2274 |
129,184 | 01.11.2021 19:43:50 | 14,400 | 5138a01c38ddf79d00fc819408f729876000de48 | [native] `codeVersion` -> 108 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -424,8 +424,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 106\n- versionName '1.0.106'\n+ versionCode 108\n+ versionName '1.0.108'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.106</string>\n+ <string>1.0.108</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>106</string>\n+ <string>108</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.106</string>\n+ <string>1.0.108</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>106</string>\n+ <string>108</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 106;\n+const codeVersion = 108;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 108 |
129,184 | 01.11.2021 19:51:18 | 14,400 | 43dc2cd611d8d7d35550f79a8800a501120f0472 | [native] `codeVersion` -> 109 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -424,8 +424,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 108\n- versionName '1.0.108'\n+ versionCode 109\n+ versionName '1.0.109'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.108</string>\n+ <string>1.0.109</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>108</string>\n+ <string>109</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.108</string>\n+ <string>1.0.109</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>108</string>\n+ <string>109</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 108;\n+const codeVersion = 109;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 109 |
129,190 | 02.11.2021 08:48:17 | -3,600 | c7906646dfb662f0e6f04a032dbabb6cd4103b01 | [services] Disable unused grpc plugins
Summary: Disable plugins/extensions of grpc that we will not use for services tunnelbroker and backup.
Test Plan: build back and tunnelbroker services.
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: geekbrother, ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/backup/contents/server/CMakeLists.txt",
"new_path": "services/backup/contents/server/CMakeLists.txt",
"diff": "@@ -18,6 +18,15 @@ message(STATUS \"Using protobuf ${Protobuf_VERSION}\")\nset(_PROTOBUF_LIBPROTOBUF protobuf::libprotobuf)\nset(_PROTOBUF_PROTOC $<TARGET_FILE:protobuf::protoc>)\n+# gRPC building parameters\n+set(gRPC_BUILD_CSHARP_EXT OFF)\n+set(gRPC_SSL_PROVIDER \"package\" CACHE STRING \"SSL library provider\")\n+# Disable unused plugins\n+set(gRPC_BUILD_GRPC_PHP_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_RUBY_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_PYTHON_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_CSHARP_PLUGIN OFF)\n+\n# Find gRPC installation\n# Looks for gRPCConfig.cmake file installed by gRPC's cmake installation.\nfind_package(gRPC CONFIG REQUIRED)\n"
},
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/contents/server/CMakeLists.txt",
"new_path": "services/tunnelbroker/contents/server/CMakeLists.txt",
"diff": "@@ -18,6 +18,15 @@ message(STATUS \"Using protobuf ${Protobuf_VERSION}\")\nset(_PROTOBUF_LIBPROTOBUF protobuf::libprotobuf)\nset(_PROTOBUF_PROTOC $<TARGET_FILE:protobuf::protoc>)\n+# gRPC building parameters\n+set(gRPC_BUILD_CSHARP_EXT OFF)\n+set(gRPC_SSL_PROVIDER \"package\" CACHE STRING \"SSL library provider\")\n+# Disable unused plugins\n+set(gRPC_BUILD_GRPC_PHP_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_RUBY_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_PYTHON_PLUGIN OFF)\n+set(gRPC_BUILD_GRPC_CSHARP_PLUGIN OFF)\n+\n# Find gRPC installation\n# Looks for gRPCConfig.cmake file installed by gRPC's cmake installation.\nfind_package(gRPC CONFIG REQUIRED)\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Disable unused grpc plugins
Summary: Disable plugins/extensions of grpc that we will not use for services tunnelbroker and backup.
Test Plan: build back and tunnelbroker services.
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, geekbrother, ashoat
Subscribers: geekbrother, ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2288 |
129,179 | 01.11.2021 16:31:59 | 14,400 | 33dc6cd99916c8c3630a8f5039556d5a26886dda | [native][feature] add default notifications screen navigation + screen
Summary: Add navigation and basic (non-functional) notifs screen to profile
Test Plan: Go to profile, click default nofiticatons
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -39,6 +39,7 @@ export const ColorPickerModalRouteName = 'ColorPickerModal';\nexport const ComposeSubthreadModalRouteName = 'ComposeSubthreadModal';\nexport const ComposeThreadRouteName = 'ComposeThread';\nexport const CustomServerModalRouteName = 'CustomServerModal';\n+export const DefaultNotificationsPreferencesRouteName = 'DefaultNotifications';\nexport const DeleteAccountRouteName = 'DeleteAccount';\nexport const DeleteThreadRouteName = 'DeleteThread';\nexport const DevToolsRouteName = 'DevTools';\n@@ -129,6 +130,7 @@ export type ProfileParamList = {\n+DevTools: void,\n+AppearancePreferences: void,\n+PrivacyPreferences: void,\n+ +DefaultNotifications: void,\n+FriendList: void,\n+BlockList: void,\n};\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { View, Text, ScrollView, Platform } from 'react-native';\n+\n+import SWMansionIcon from '../components/swmansion-icon.react';\n+import { useStyles } from '../themes/colors';\n+\n+const CheckIcon = () => (\n+ <SWMansionIcon\n+ name=\"check\"\n+ size={20}\n+ color=\"#888888\"\n+ style={unboundStyles.icon}\n+ />\n+);\n+\n+// eslint-disable-next-line no-unused-vars\n+function DefaultNotificationsPreferences(props: { ... }): React.Node {\n+ const styles = useStyles(unboundStyles);\n+\n+ return (\n+ <ScrollView\n+ contentContainerStyle={styles.scrollViewContentContainer}\n+ style={styles.scrollView}\n+ >\n+ <Text style={styles.header}>NOTIFICATIONS</Text>\n+ <View style={styles.section}>\n+ <View style={styles.submenuButton}>\n+ <Text style={styles.submenuText}>All</Text>\n+ <CheckIcon />\n+ </View>\n+\n+ <View style={styles.submenuButton}>\n+ <Text style={styles.submenuText}>Background</Text>\n+ </View>\n+\n+ <View style={styles.submenuButton}>\n+ <Text style={styles.submenuText}>None</Text>\n+ </View>\n+ </View>\n+ </ScrollView>\n+ );\n+}\n+\n+const unboundStyles = {\n+ scrollView: {\n+ backgroundColor: 'panelBackground',\n+ },\n+ scrollViewContentContainer: {\n+ paddingTop: 24,\n+ },\n+ section: {\n+ backgroundColor: 'panelForeground',\n+ borderBottomWidth: 1,\n+ borderColor: 'panelForegroundBorder',\n+ borderTopWidth: 1,\n+ marginBottom: 24,\n+ marginVertical: 2,\n+ },\n+ icon: {\n+ lineHeight: Platform.OS === 'ios' ? 18 : 20,\n+ },\n+ header: {\n+ color: 'panelBackgroundLabel',\n+ fontSize: 12,\n+ fontWeight: '400',\n+ paddingBottom: 3,\n+ paddingHorizontal: 24,\n+ },\n+ submenuButton: {\n+ flexDirection: 'row',\n+ paddingHorizontal: 24,\n+ paddingVertical: 10,\n+ alignItems: 'center',\n+ },\n+ submenuText: {\n+ color: 'panelForegroundLabel',\n+ flex: 1,\n+ fontSize: 16,\n+ },\n+};\n+\n+export default DefaultNotificationsPreferences;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -31,6 +31,7 @@ import {\nFriendListRouteName,\nBlockListRouteName,\nPrivacyPreferencesRouteName,\n+ DefaultNotificationsPreferencesRouteName,\n} from '../navigation/route-names';\nimport { useSelector } from '../redux/redux-utils';\nimport { type Colors, useColors, useStyles } from '../themes/colors';\n@@ -83,7 +84,7 @@ class ProfileScreen extends React.PureComponent<Props> {\n}\nrender() {\n- let appearancePreferences, developerTools;\n+ let appearancePreferences, developerTools, defaultNotifications;\nif (\n(this.props.currentUserInfo && isStaff(this.props.currentUserInfo.id)) ||\n__DEV__\n@@ -94,6 +95,13 @@ class ProfileScreen extends React.PureComponent<Props> {\ndeveloperTools = (\n<ProfileRow content=\"Developer tools\" onPress={this.onPressDevTools} />\n);\n+\n+ defaultNotifications = (\n+ <ProfileRow\n+ content=\"Default Notifications\"\n+ onPress={this.onPressDefaultNotifications}\n+ />\n+ );\n}\nreturn (\n@@ -144,6 +152,7 @@ class ProfileScreen extends React.PureComponent<Props> {\n<View style={this.props.styles.section}>\n{appearancePreferences}\n<ProfileRow content=\"Privacy\" onPress={this.onPressPrivacy} />\n+ {defaultNotifications}\n</View>\n<View style={this.props.styles.section}>\n<ProfileRow content=\"Build info\" onPress={this.onPressBuildInfo} />\n@@ -240,6 +249,10 @@ class ProfileScreen extends React.PureComponent<Props> {\nthis.navigateIfActive(PrivacyPreferencesRouteName);\n};\n+ onPressDefaultNotifications = () => {\n+ this.navigateIfActive(DefaultNotificationsPreferencesRouteName);\n+ };\n+\nonPressFriendList = () => {\nthis.navigateIfActive(FriendListRouteName);\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/profile.react.js",
"new_path": "native/profile/profile.react.js",
"diff": "@@ -19,6 +19,7 @@ import {\nAppearancePreferencesRouteName,\nPrivacyPreferencesRouteName,\nFriendListRouteName,\n+ DefaultNotificationsPreferencesRouteName,\nBlockListRouteName,\ntype ScreenParamList,\ntype ProfileParamList,\n@@ -26,6 +27,7 @@ import {\nimport { useStyles, useColors } from '../themes/colors';\nimport AppearancePreferences from './appearance-preferences.react';\nimport BuildInfo from './build-info.react';\n+import DefaultNotificationsPreferences from './default-notifications-preferences.react';\nimport DeleteAccount from './delete-account.react';\nimport DevTools from './dev-tools.react';\nimport EditPassword from './edit-password.react';\n@@ -45,6 +47,7 @@ const appearanceOptions = { headerTitle: 'Appearance' };\nconst privacyOptions = { headerTitle: 'Privacy' };\nconst friendListOptions = { headerTitle: 'Friend list' };\nconst blockListOptions = { headerTitle: 'Block list' };\n+const defaultNotificationsOptions = { headerTitle: 'Default Notifications' };\nexport type ProfileNavigationProp<\nRouteName: $Keys<ProfileParamList> = $Keys<ProfileParamList>,\n@@ -117,6 +120,11 @@ function ProfileComponent(props: { ... }): React.Node {\ncomponent={PrivacyPreferences}\noptions={privacyOptions}\n/>\n+ <Profile.Screen\n+ name={DefaultNotificationsPreferencesRouteName}\n+ component={DefaultNotificationsPreferences}\n+ options={defaultNotificationsOptions}\n+ />\n<Profile.Screen\nname={FriendListRouteName}\ncomponent={RelationshipList}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][feature] add default notifications screen navigation + screen
Summary: Add navigation and basic (non-functional) notifs screen to profile https://share.getcloudapp.com/v1ujNRRR https://linear.app/comm/issue/COM-20/default-notification-settings
Test Plan: Go to profile, click default nofiticatons
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2303 |
129,179 | 02.11.2021 12:08:25 | 14,400 | b0bd8a8fd639df2fbde4828c15e2c19ab3c34fcd | [native][refactor] use action row in default notification screen, remove styles
Summary: Remove repeated code, replaced with action rows
Test Plan: Click into default notifications, make sure rows are still rendering correctly
Reviewers: ashoat, atul
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "import * as React from 'react';\nimport { View, Text, ScrollView, Platform } from 'react-native';\n+import Action from '../components/action-row.react';\nimport SWMansionIcon from '../components/swmansion-icon.react';\nimport { useStyles } from '../themes/colors';\n@@ -15,6 +16,22 @@ const CheckIcon = () => (\n/>\n);\n+type ProfileRowProps = {\n+ +content: string,\n+ +onPress: () => void,\n+ +danger?: boolean,\n+};\n+\n+function NotificationRow(props: ProfileRowProps): React.Node {\n+ const { content, onPress, danger } = props;\n+ return (\n+ <Action.Row onPress={onPress}>\n+ <Action.Text {...{ danger, content }} />\n+ <CheckIcon />\n+ </Action.Row>\n+ );\n+}\n+\n// eslint-disable-next-line no-unused-vars\nfunction DefaultNotificationsPreferences(props: { ... }): React.Node {\nconst styles = useStyles(unboundStyles);\n@@ -26,18 +43,9 @@ function DefaultNotificationsPreferences(props: { ... }): React.Node {\n>\n<Text style={styles.header}>NOTIFICATIONS</Text>\n<View style={styles.section}>\n- <View style={styles.submenuButton}>\n- <Text style={styles.submenuText}>All</Text>\n- <CheckIcon />\n- </View>\n-\n- <View style={styles.submenuButton}>\n- <Text style={styles.submenuText}>Background</Text>\n- </View>\n-\n- <View style={styles.submenuButton}>\n- <Text style={styles.submenuText}>None</Text>\n- </View>\n+ <NotificationRow content=\"All\" onPress={() => {}} />\n+ <NotificationRow content=\"Background\" onPress={() => {}} />\n+ <NotificationRow content=\"None\" onPress={() => {}} />\n</View>\n</ScrollView>\n);\n@@ -68,17 +76,6 @@ const unboundStyles = {\npaddingBottom: 3,\npaddingHorizontal: 24,\n},\n- submenuButton: {\n- flexDirection: 'row',\n- paddingHorizontal: 24,\n- paddingVertical: 10,\n- alignItems: 'center',\n- },\n- submenuText: {\n- color: 'panelForegroundLabel',\n- flex: 1,\n- fontSize: 16,\n- },\n};\nexport default DefaultNotificationsPreferences;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native][refactor] use action row in default notification screen, remove styles
Summary: Remove repeated code, replaced with action rows https://share.getcloudapp.com/BluDYP2n
Test Plan: Click into default notifications, make sure rows are still rendering correctly
Reviewers: ashoat, atul
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2308 |
129,187 | 04.11.2021 22:27:30 | 14,400 | 973ccc76334ea4fb2ecbc471e2138f13fc79ff7a | [lib] Update staff.json
Summary: Usernames:
Test Plan: N/A
Reviewers: atul, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/facts/staff.json",
"new_path": "lib/facts/staff.json",
"diff": "-[\"256\", \"518252\", \"379341\", \"546465\", \"701071\", \"1073697\", \"1081630\", \"1074037\"]\n+[\n+ \"256\",\n+ \"518252\",\n+ \"379341\",\n+ \"546465\",\n+ \"701071\",\n+ \"1081630\",\n+ \"1137719\",\n+ \"1155073\",\n+ \"860633\",\n+ \"1205684\",\n+ \"1157418\"\n+]\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Update staff.json
Summary: Usernames: https://www.dropbox.com/s/y0l7977pvagl8hf/Screen%20Shot%202021-11-04%20at%2010.27.47%20PM.png?dl=0
Test Plan: N/A
Reviewers: atul, palys-swm
Reviewed By: palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2326 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.