author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,179 | 08.12.2021 14:20:11 | 18,000 | 238115466d0011624b022530769378478d45c19d | [34/n] [landing] add fluid typography to body font
Summary: text should change size with screen size
Test Plan: resize window, view on mobile device
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "--unselected: var(--grey);\n--btn-color: var(--white1);\n--logo-color: var(--white);\n+ --min-font-size: 12px;\n+ --max-font-size: 28px;\n}\n/* ===== GENERAL PAGE STYLES ===== */\n@@ -15,6 +17,14 @@ html {\nbackground-attachment: fixed;\nfont-family: 'IBM Plex Sans', sans-serif;\ncolor: white;\n+ /* Fallback styling if clamp isn't supported */\n+ font-size: 1rem;\n+ /* https://css-tricks.com/simplified-fluid-typography/ */\n+ font-size: clamp(\n+ var(--min-font-size),\n+ calc(0.75rem + 1vw),\n+ var(--max-font-size)\n+ );\nword-break: break-word;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [34/n] [landing] add fluid typography to body font
Summary: text should change size with screen size
Test Plan: resize window, view on mobile device
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2592 |
129,179 | 08.12.2021 16:04:24 | 18,000 | f43f5e6574d0303fde6f1cfdb8a8015a0f76a270 | [35/n] [landing] style info-block
Summary: Add fluid styling to info-block
Test Plan: styling matching figma info block, resize window
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "+@supports ((-webkit-backdrop-filter: none) or (backdrop-filter: none)) {\n+ .info_block {\n+ background: rgba(235, 235, 235, 0.05);\n+ -webkit-backdrop-filter: blur(12px);\n+ backdrop-filter: blur(12px);\n+ }\n+}\n+\n+.info_block {\n+ --border-radius: 8px;\n+ background: rgba(235, 235, 235, 0.05);\n+ border-radius: var(--border-radius);\n+ /* 36 / 28 = 1.28571429 */\n+ /* 36px is the max padding size, 28px is the max font-size */\n+ /* Padding scales down with text */\n+ padding: 1.28571429rem;\n+}\n+\n+.title {\n+ --smallest-font-size: 30px;\n+ --largest-font-size: 50px;\n+ --smallest-padding-size: 16px;\n+ --largest-padding-size: 48px;\n+ --scale: calc(0.75rem + 2vw);\n+\n+ font-family: 'iA Writer Duo S', monospace;\n+ font-style: normal;\n+ line-height: 1.35;\n+ letter-spacing: -0.01em;\n+\n+ padding-bottom: clamp(\n+ var(--smallest-padding-size),\n+ var(--scale),\n+ var(--largest-padding-size)\n+ );\n+ text-align: left;\n+\n+ font-size: clamp(\n+ var(--smallest-font-size),\n+ var(--scale),\n+ var(--largest-font-size)\n+ );\n+}\n+\n+.description {\n+ line-height: 1.5;\n+ font-weight: 400;\n+ font-family: 'IBM Plex Sans';\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [35/n] [landing] style info-block
Summary: Add fluid styling to info-block
Test Plan: styling matching figma info block, resize window
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2593 |
129,179 | 08.12.2021 17:50:49 | 18,000 | 83899c46ec4cc5fba2211f954031de3977d3cb7a | [36/n] [landing] fix cycling header styles
Summary: fix cycling header styling. Had to review art collective content, it was breaking the layout
Test Plan: resize the web page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "--unselected: var(--grey);\n--btn-color: var(--white1);\n--logo-color: var(--white);\n+ --sub-heading-color: var(--purple);\n--min-font-size: 12px;\n--max-font-size: 28px;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.css",
"new_path": "landing/hero-content.css",
"diff": "-h1.cycling_header {\n- font-family: 'iA Writer Duo S', monospace;\n- font-size: 50px;\n- margin: 0;\n- white-space: pre-wrap;\n-}\n-\n-.app_landing_subheading {\n+.cycling_header {\n+ --smallest-font-size: 30px;\n+ --largest-font-size: 72px;\n+ --font-scale: calc(1rem + 2vw);\nfont-weight: bold;\n- padding-inline: 4px;\n-}\n-\n-span.app_landing_subheading {\n- background-color: #7e57c2;\n-}\n-\n-p.app_landing_subheading {\nfont-family: 'iA Writer Duo S', monospace;\n- color: #7e57c2;\n- font-size: 32px;\n- padding-inline: 0px;\n+ padding-bottom: 16px;\n+ font-size: clamp(\n+ var(--smallest-font-size),\n+ var(--font-scale),\n+ var(--largest-font-size)\n+ );\n}\n-/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n-@media (max-width: 1699px) {\n- h1.cycling_header {\n- font-size: 44px;\n- }\n-}\n+.sub_heading {\n+ --smallest-font-size: 16px;\n+ --largest-font-size: 50px;\n+ --font-scale: calc(0.75rem + 1.25vw);\n-/* ===== MEDIUM BREAKPOINT ===== */\n-@media (max-width: 1499px) {\n- h1.cycling_header {\n- font-size: 38px;\n- }\n+ font-size: clamp(\n+ var(--smallest-font-size),\n+ var(--font-scale),\n+ var(--largest-font-size)\n+ );\n}\n-/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n-@media (max-width: 1299px) {\n- h1.cycling_header {\n- font-size: 30px;\n- }\n-}\n-\n-/* ===== SMALLEST BREAKPOINT ===== */\n-@media (max-width: 1099px) {\n- h1.cycling_header {\n+.cycling_content,\n+.sub_heading {\nfont-family: 'iA Writer Duo S', monospace;\n- margin-top: 4vh;\n- font-size: 22px;\n- text-align: center;\n+ text-align: left;\n+ line-height: 1.35;\n+ letter-spacing: -0.01em;\n}\n- .app_landing_subheading {\n- margin-bottom: 6vh;\n- text-align: center;\n+.cycling_content {\n+ background: var(--sub-heading-color);\n}\n- p.app_landing_subheading {\n- font-size: 18px;\n- }\n+.sub_heading {\n+ color: var(--sub-heading-color);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.react.js",
"new_path": "landing/hero-content.react.js",
"diff": "@@ -17,17 +17,14 @@ function HeroContent(): React.Node {\ninterval={1750}\nspringConfig={{ stiffness: 180, damping: 16 }}\n>\n- <span className={css.app_landing_subheading}>DAOs</span>\n- <span className={css.app_landing_subheading}>art collectives</span>\n- <span className={css.app_landing_subheading}>venture funds</span>\n- <span className={css.app_landing_subheading}>open source</span>\n- <span className={css.app_landing_subheading}>gaming guilds</span>\n- <span className={css.app_landing_subheading}>social clubs</span>\n+ <span className={css.cycling_content}>DAOs</span>\n+ <span className={css.cycling_content}>venture funds</span>\n+ <span className={css.cycling_content}>open source</span>\n+ <span className={css.cycling_content}>gaming guilds</span>\n+ <span className={css.cycling_content}>social clubs</span>\n</TextLoop>\n</h1>\n- <p className={css.app_landing_subheading}>\n- (think "Web3 Discord")\n- </p>\n+ <p className={css.sub_heading}>(think "Web3 Discord")</p>\n</section>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [36/n] [landing] fix cycling header styles
Summary: fix cycling header styling. Had to review art collective content, it was breaking the layout
Test Plan: resize the web page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2594 |
129,179 | 08.12.2021 20:08:47 | 18,000 | cff5b0a15a681d90dee4a730a2404be88d87c1f6 | [37/n] [landing] fix text rendering
Summary: Fix rendering issues on firefox and optimize for text rendering
Test Plan: load the page, text should be crisp.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "@@ -17,6 +17,8 @@ html {\nbackground: radial-gradient(ellipse at bottom, #1f252e, #111827);\nbackground-attachment: fixed;\nfont-family: 'IBM Plex Sans', sans-serif;\n+ -moz-osx-font-smoothing: grayscale;\n+ text-rendering: optimizeLegibility;\ncolor: white;\n/* Fallback styling if clamp isn't supported */\nfont-size: 1rem;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [37/n] [landing] fix text rendering
Summary: Fix rendering issues on firefox and optimize for text rendering
Test Plan: load the page, text should be crisp.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2596 |
129,179 | 10.12.2021 15:00:56 | 18,000 | 55d9bec52b2dc37c5a339f2c5dfe19989a3afe51 | [39/n] [landing] Remove activeName prop from landing
Summary: Removing activename diff in favor of using active styles / hooks from react-router DOM
Test Plan: active links should not work
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -6,15 +6,9 @@ import * as React from 'react';\nimport { Link } from 'react-router-dom';\nimport footerStyles from './footer.css';\n-import type { LandingPageName } from './landing.react';\nimport SubscriptionForm from './subscription-form.react';\n-type FooterProps = {\n- +activePageName: LandingPageName,\n-};\n-function Footer(props: FooterProps): React.Node {\n- const { activePageName } = props;\n-\n+function Footer(): React.Node {\nconst footerGridStyle = `${footerStyles.footer_grid}`;\nreturn (\n@@ -25,43 +19,19 @@ function Footer(props: FooterProps): React.Node {\n<Link to=\"/\">Comm</Link>\n</div>\n- <div\n- className={\n- activePageName === 'keyservers'\n- ? footerStyles.active_tab\n- : footerStyles.inactive_tab\n- }\n- >\n+ <div>\n<Link to=\"/keyservers\">Keyservers</Link>\n</div>\n- <div\n- className={\n- activePageName === 'support'\n- ? footerStyles.active_tab\n- : footerStyles.inactive_tab\n- }\n- >\n+ <div>\n<Link to=\"/support\">Support</Link>\n</div>\n- <div\n- className={\n- activePageName === 'terms'\n- ? footerStyles.active_tab\n- : footerStyles.inactive_tab\n- }\n- >\n+ <div>\n<Link to=\"/terms\">Terms of Use</Link>\n</div>\n- <div\n- className={\n- activePageName === 'privacy'\n- ? footerStyles.active_tab\n- : footerStyles.inactive_tab\n- }\n- >\n+ <div>\n<Link to=\"/privacy\">Privacy Policy</Link>\n</div>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -14,15 +14,6 @@ import useScrollToTopOnNavigate from './use-scroll-to-top-on-navigate.react';\nimport './reset.css';\nimport './global.css';\n-export type LandingPageName =\n- | '/'\n- | 'keyservers'\n- | 'privacy'\n- | 'terms'\n- | 'support';\n-\n-type ActivePage = { name: LandingPageName, node: React.Node };\n-\nfunction Landing(): React.Node {\nuseScrollToTopOnNavigate();\nconst onPrivacy = useRouteMatch({ path: '/privacy' });\n@@ -36,25 +27,25 @@ function Landing(): React.Node {\ndocument.getElementById('subscription-form')?.focus();\n}, []);\n- const activePage: ActivePage = React.useMemo(() => {\n+ const activePage = React.useMemo(() => {\nif (onPrivacy) {\n- return { name: 'privacy', node: <Privacy /> };\n+ return <Privacy />;\n} else if (onTerms) {\n- return { name: 'terms', node: <Terms /> };\n+ return <Terms />;\n} else if (onSupport) {\n- return { name: 'support', node: <Support /> };\n+ return <Support />;\n} else if (onKeyservers) {\n- return { name: 'keyservers', node: <Keyservers /> };\n+ return <Keyservers />;\n} else {\n- return { name: '/', node: <AppLanding /> };\n+ return <AppLanding />;\n}\n}, [onKeyservers, onPrivacy, onSupport, onTerms]);\nreturn (\n<>\n<Header onRequestAccess={scrollToSubscriptionForm} />\n- {activePage.node}\n- <Footer activePageName={activePage.name} />\n+ {activePage}\n+ <Footer />\n</>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [39/n] [landing] Remove activeName prop from landing
Summary: Removing activename diff in favor of using active styles / hooks from react-router DOM
Test Plan: active links should not work
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2605 |
129,179 | 10.12.2021 15:07:43 | 18,000 | e668fcecc12a4d8502774ea98c818850a958f8df | [40/n] [landing] re-add active links with react router dom props
Summary: Active tab functionality is reimplemented
Test Plan: click on footer links. They highlight correctly based on the page it's on.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -31,6 +31,7 @@ div.sitemap a {\nwidth: max-content;\n}\n+.inactive_tab,\ndiv.inactive_tab a,\ndiv.inactive_tab svg {\ncolor: #8a8f98;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "import { faExternalLinkSquareAlt } from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\n-import { Link } from 'react-router-dom';\n+import { NavLink } from 'react-router-dom';\nimport footerStyles from './footer.css';\nimport SubscriptionForm from './subscription-form.react';\n+const navLinkProps = {\n+ className: footerStyles.inactive_tab,\n+ activeStyle: {\n+ color: 'white',\n+ fontWeight: '500',\n+ },\n+};\n+\nfunction Footer(): React.Node {\nconst footerGridStyle = `${footerStyles.footer_grid}`;\n@@ -16,23 +24,31 @@ function Footer(): React.Node {\n<div className={footerGridStyle}>\n<div className={footerStyles.sitemap}>\n<div className={footerStyles.footer_logo}>\n- <Link to=\"/\">Comm</Link>\n+ <NavLink to=\"/\">Comm</NavLink>\n</div>\n<div>\n- <Link to=\"/keyservers\">Keyservers</Link>\n+ <NavLink to=\"/keyservers\" exact {...navLinkProps}>\n+ Keyservers\n+ </NavLink>\n</div>\n<div>\n- <Link to=\"/support\">Support</Link>\n+ <NavLink to=\"/support\" exact {...navLinkProps}>\n+ Support\n+ </NavLink>\n</div>\n<div>\n- <Link to=\"/terms\">Terms of Use</Link>\n+ <NavLink to=\"/terms\" exact {...navLinkProps}>\n+ Terms of Use\n+ </NavLink>\n</div>\n<div>\n- <Link to=\"/privacy\">Privacy Policy</Link>\n+ <NavLink to=\"/privacy\" exact {...navLinkProps}>\n+ Privacy Policy\n+ </NavLink>\n</div>\n<div className={footerStyles.inactive_tab}>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [40/n] [landing] re-add active links with react router dom props
Summary: Active tab functionality is reimplemented
Test Plan: click on footer links. They highlight correctly based on the page it's on.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2606 |
129,179 | 13.12.2021 10:42:21 | 18,000 | fb86cde764275c78543201ffd44bd62a7e6886f0 | [41/n] [landing] remove styles and html in footer
Summary: Remove footer styles
Test Plan: page should still render, footer styles should be broken
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "-/* ===== CSS FOOTER GRID LAYOUT ===== */\n-div.footer_grid {\n- max-width: 1920px;\n- margin-left: auto;\n- margin-right: auto;\n- display: grid;\n- column-gap: 6em;\n- padding-left: 60px;\n- padding-right: 60px;\n- padding-top: 20px;\n- padding-bottom: 40px;\n- transition-property: max-width;\n- transition: 300ms;\n- grid-template-columns: 1fr 1fr;\n- grid-template-areas: 'sitemap subscribe_updates';\n-}\n-\n-div.footer_legal {\n- max-width: 1080px;\n- transition-property: max-width;\n- transition: 300ms;\n-}\n-\n-div.sitemap {\n- grid-area: sitemap;\n-}\n-\n-div.sitemap a {\n- display: block;\n- padding-bottom: 4px;\n- width: max-content;\n-}\n-\n-.inactive_tab,\n-div.inactive_tab a,\n-div.inactive_tab svg {\n- color: #8a8f98;\n- transition: 300ms;\n-}\n-\n-div.inactive_tab:hover a,\n-div.inactive_tab:hover svg {\n- color: white;\n- transition: 300ms;\n-}\n-\n-.active_tab a {\n- color: white;\n- transition: 300ms;\n-}\n-\n-div.footer_logo a {\n- font-size: 24px;\n- font-weight: 500;\n- color: white;\n- padding-bottom: 8px;\n-}\n-div.footer_logo a:hover {\n- color: #7e57c2;\n-}\n-\n-div.subscribe_updates {\n- grid-area: subscribe_updates;\n- align-self: center;\n-}\n-\n-/* ===== VISUAL EFFECTS ===== */\n-div.footer_blur {\n- background-color: rgba(255, 255, 255, 0.125);\n- backdrop-filter: none;\n- position: sticky;\n- top: 100vh;\n- -webkit-backdrop-filter: blur(2px);\n-}\n-\n-/* ===== SMALLEST BREAKPOINT ===== */\n-@media (max-width: 1099px) {\n- div.footer_grid {\n- padding-left: 3%;\n- padding-right: 3%;\n- grid-template-columns: minmax(auto, 540px);\n- justify-content: center;\n- grid-template-areas:\n- 'subscribe_updates'\n- 'sitemap';\n- }\n-\n- div.footer_container {\n- padding-top: 5%;\n- }\n- div.sitemap {\n- padding-top: 60px;\n- grid-area: sitemap;\n- }\n-}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -5,11 +5,9 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { NavLink } from 'react-router-dom';\n-import footerStyles from './footer.css';\nimport SubscriptionForm from './subscription-form.react';\nconst navLinkProps = {\n- className: footerStyles.inactive_tab,\nactiveStyle: {\ncolor: 'white',\nfontWeight: '500',\n@@ -17,41 +15,21 @@ const navLinkProps = {\n};\nfunction Footer(): React.Node {\n- const footerGridStyle = `${footerStyles.footer_grid}`;\n-\nreturn (\n- <div className={footerStyles.footer_blur}>\n- <div className={footerGridStyle}>\n- <div className={footerStyles.sitemap}>\n- <div className={footerStyles.footer_logo}>\n- <NavLink to=\"/\">Comm</NavLink>\n- </div>\n-\n<div>\n+ <NavLink to=\"/\">Comm</NavLink>\n<NavLink to=\"/keyservers\" exact {...navLinkProps}>\nKeyservers\n</NavLink>\n- </div>\n-\n- <div>\n<NavLink to=\"/support\" exact {...navLinkProps}>\nSupport\n</NavLink>\n- </div>\n-\n- <div>\n<NavLink to=\"/terms\" exact {...navLinkProps}>\nTerms of Use\n</NavLink>\n- </div>\n-\n- <div>\n<NavLink to=\"/privacy\" exact {...navLinkProps}>\nPrivacy Policy\n</NavLink>\n- </div>\n-\n- <div className={footerStyles.inactive_tab}>\n<a href=\"https://www.notion.so/How-Comm-works-d6217941db7c4237b9d08b427aef3234\">\nHow Comm works{' '}\n<FontAwesomeIcon\n@@ -60,13 +38,8 @@ function Footer(): React.Node {\nicon={faExternalLinkSquareAlt}\n/>\n</a>\n- </div>\n- </div>\n- <div className={footerStyles.subscribe_updates}>\n<SubscriptionForm />\n</div>\n- </div>\n- </div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [41/n] [landing] remove styles and html in footer
Summary: Remove footer styles
Test Plan: page should still render, footer styles should be broken
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2609 |
129,179 | 13.12.2021 10:46:20 | 18,000 | 9418fb4e9c31f1df90764feb29f43b45f0ba1253 | [42/n] [landing] add footer tag
Summary: use:
Test Plan: page should render
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -16,7 +16,7 @@ const navLinkProps = {\nfunction Footer(): React.Node {\nreturn (\n- <div>\n+ <footer>\n<NavLink to=\"/\">Comm</NavLink>\n<NavLink to=\"/keyservers\" exact {...navLinkProps}>\nKeyservers\n@@ -39,7 +39,7 @@ function Footer(): React.Node {\n/>\n</a>\n<SubscriptionForm />\n- </div>\n+ </footer>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [42/n] [landing] add footer tag
Summary: use: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/footer
Test Plan: page should render
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2610 |
129,179 | 13.12.2021 14:45:59 | 18,000 | 2f84c6f515b2e4f26aaa100e392778f95d32e741 | [43/n] [landing] put footer on 12 column grid / re-implement
Summary: style footer, it should match figma
Test Plan: Test footer on desktop browsers and mobile browsers
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "+footer.wrapper {\n+ max-width: 1850px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ padding: 50px 0;\n+ grid-template-columns: 40px repeat(12, 1fr) 40px;\n+ column-gap: 1.5%;\n+ align-items: center;\n+ grid-template-areas: '. nav nav nav . . . sub sub sub sub sub sub .';\n+ background: rgba(235, 235, 235, 0.05);\n+ backdrop-filter: blur(12px);\n+ position: sticky;\n+ top: 100vh;\n+}\n+\n+@media screen and (max-width: 1099px) {\n+ footer.wrapper {\n+ grid-template-columns: 16px repeat(6, 1fr) 16px;\n+ grid-template-rows: 1fr 1fr;\n+ column-gap: 1.5%;\n+ grid-template-areas:\n+ '. sub sub sub sub sub sub . '\n+ '. nav nav nav nav nav nav . ';\n+ }\n+\n+ .submissionForm form {\n+ display: flex;\n+ flex-direction: column;\n+ }\n+\n+ .submissionForm form input {\n+ margin-bottom: 24px;\n+ }\n+}\n+\n+.navigation {\n+ grid-area: nav;\n+ display: flex;\n+ flex-direction: column;\n+}\n+\n+.navigation a {\n+ --smallest-font-size: 16px;\n+ --largest-font-size: 24px;\n+ --scale: calc(0.75rem + 2vw);\n+\n+ font-size: clamp(\n+ var(--smallest-font-size),\n+ var(--scale),\n+ var(--largest-font-size)\n+ );\n+ font-weight: 400;\n+ color: #cccccc;\n+}\n+\n+a.logo {\n+ font-family: 'IBM Plex Sans', sans-serif;\n+ font-weight: 500;\n+ color: var(--logo-color);\n+ font-size: 28px;\n+ padding-bottom: 16px;\n+}\n+\n+.submissionForm {\n+ grid-area: sub;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -5,6 +5,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { NavLink } from 'react-router-dom';\n+import css from './footer.css';\nimport SubscriptionForm from './subscription-form.react';\nconst navLinkProps = {\n@@ -16,8 +17,11 @@ const navLinkProps = {\nfunction Footer(): React.Node {\nreturn (\n- <footer>\n- <NavLink to=\"/\">Comm</NavLink>\n+ <footer className={css.wrapper}>\n+ <div className={css.navigation}>\n+ <NavLink className={css.logo} to=\"/\">\n+ Comm\n+ </NavLink>\n<NavLink to=\"/keyservers\" exact {...navLinkProps}>\nKeyservers\n</NavLink>\n@@ -38,7 +42,11 @@ function Footer(): React.Node {\nicon={faExternalLinkSquareAlt}\n/>\n</a>\n+ </div>\n+\n+ <div className={css.submissionForm}>\n<SubscriptionForm />\n+ </div>\n</footer>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [43/n] [landing] put footer on 12 column grid / re-implement
Summary: style footer, it should match figma
Test Plan: Test footer on desktop browsers and mobile browsers
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2611 |
129,190 | 17.12.2021 11:25:18 | -3,600 | 167674c0047a4a2578008177696f408e5817085c | [services] Fix building images
Summary:
Fix building images through yarn
This sources essential shell variables and makes building images work
Test Plan:
`cd services`
`yarn build-all`
`yarn build-base-image`
`yarn build-tunnelbroker-base`
`yarn build-backup-base`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/docker-compose.yml",
"new_path": "services/docker-compose.yml",
"diff": "@@ -3,6 +3,7 @@ services:\nbase:\nbuild: base-image\nimage: commapp/services-base:1.0\n+ # tunnelbroker\ntunnelbroker-base:\nbuild:\ndockerfile: services/tunnelbroker/docker-base/Dockerfile\n@@ -18,6 +19,7 @@ services:\ncontainer_name: tunnelbroker-server\nports:\n- \"${COMM_SERVICES_PORT_TUNNELBROKER}:50051\"\n+ # backup\nbackup-base:\nbuild:\ndockerfile: services/backup/docker-base/Dockerfile\n"
},
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"private\": true,\n\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n- \"build-all\": \"docker-compose build\",\n- \"build-base-image\": \"docker-compose build base\",\n- \"build-tunnelbroker-base\": \"docker-compose build tunnelbroker-base\",\n+ \"build-all\": \"./scripts/build_base_image.sh\",\n+ \"build-base-image\": \"./scripts/build_base_image.sh base\",\n+ \"build-tunnelbroker-base\": \"./scripts/build_base_image.sh tunnelbroker-base\",\n\"run-tunnelbroker-server\": \"./scripts/run_server_image.sh tunnelbroker\",\n\"test-tunnelbroker-server\": \"./scripts/test_service.sh tunnelbroker\",\n- \"build-backup-base\": \"docker-compose build backup-base\",\n+ \"build-backup-base\": \"./scripts/build_base_image.sh backup-base\",\n\"run-backup-server\": \"./scripts/run_server_image.sh backup\",\n\"test-backup-server\": \"./scripts/test_service.sh backup\",\n\"test-all-services\": \"./scripts/test_all_services.sh\",\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/scripts/build_base_image.sh",
"diff": "+#!/bin/bash\n+\n+set -e\n+\n+. ./scripts/services_config.sh\n+\n+docker-compose build $1\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Fix building images
Summary:
Fix building images through yarn
This sources essential shell variables and makes building images work
Test Plan:
`cd services`
`yarn build-all`
`yarn build-base-image`
`yarn build-tunnelbroker-base`
`yarn build-backup-base`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2620 |
129,179 | 16.12.2021 21:00:33 | 18,000 | 6baeb9bb0d2047fca9389a0308ef2a3f623dd650 | [landing] remove unneeded spaces
Summary: remove unneeded spaces
Test Plan: N/A just removing empty lines
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -32,7 +32,6 @@ function Header(props: HeaderProps): React.Node {\n<NavLink to=\"/\" className={css.logo}>\n<h1>Comm</h1>\n</NavLink>\n-\n<div className={css.page_nav}>\n<NavLink to=\"/\" exact {...navLinkProps}>\nApp\n@@ -41,13 +40,11 @@ function Header(props: HeaderProps): React.Node {\nKeyserver\n</NavLink>\n</div>\n-\n<div className={css.button_container}>\n<button className={css.request_access} onClick={onRequestAccess}>\nRequest Access\n</button>\n</div>\n-\n<div className={css.social_icons}>\n<a className={css.twitter_icon} href=\"https://twitter.com/commdotapp\">\n<FontAwesomeIcon icon={faTwitter} {...iconProps} />\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] remove unneeded spaces
Summary: remove unneeded spaces
Test Plan: N/A just removing empty lines
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2634 |
129,179 | 17.12.2021 08:29:12 | 18,000 | 82b1e33d8409fc8316ff2bbd6199f2b0c2f52bc4 | [2/2] [landing] style hero cta button per figma
Summary: style hero cta button per figma {F6057}
Test Plan: view the app on a mobile device and desktop
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.css",
"new_path": "landing/hero-content.css",
"diff": "color: var(--sub-heading-color);\n}\n+.contentWrapper {\n+ flex-basis: 300px;\n+}\n+\nbutton.request_access {\ndisplay: none;\n}\n@@ -50,12 +54,13 @@ button.request_access {\nall: unset;\nborder-radius: 4px;\nfont-size: 16px;\n+ font-weight: 500;\nbackground-color: var(--btn-bg);\ncolor: var(--btn-color);\njustify-content: center;\npadding: 12px 18px;\ntransition: 300ms;\n- flex-basis: 130px;\n+ flex-basis: 48px;\ntext-align: center;\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.react.js",
"new_path": "landing/hero-content.react.js",
"diff": "@@ -16,6 +16,7 @@ function HeroContent(props: HeroContentProps): React.Node {\nreturn (\n<section className={hero.infoStyle}>\n+ <div className={css.contentWrapper}>\n<h1 className={css.cycling_header}>\n{'Comm is crypto-native\\nchat for '}\n<TextLoop\n@@ -30,6 +31,7 @@ function HeroContent(props: HeroContentProps): React.Node {\n</TextLoop>\n</h1>\n<p className={css.sub_heading}>(think "Web3 Discord")</p>\n+ </div>\n<button className={css.request_access} onClick={onRequestAccess}>\nRequest Access\n</button>\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "display: none;\n}\n+ .heroInfo {\n+ display: flex;\n+ flex-direction: column;\n+ padding-bottom: 1.5rem;\n+ }\n+\n.federatedImage {\njustify-self: center;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/2] [landing] style hero cta button per figma
Summary: style hero cta button per figma {F6057}
Test Plan: view the app on a mobile device and desktop
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2637 |
129,179 | 17.12.2021 15:29:42 | 18,000 | 80bdf3f41631cfbf9d3fa1ad450997d367dc43b3 | [fix] [landing] address header media query sizes
Summary:
Add a tablet sized break point for the header
Mobile and Tablet
{F6073}
Desktop
{F6074}
Test Plan: re-size the browser, view on a mobile device
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -76,12 +76,16 @@ button.request_access {\n@media screen and (max-width: 1099px) {\nnav.wrapper {\n- grid-template-columns: 16px repeat(6, 1fr) 16px;\n- grid-template-rows: 1fr 1fr;\n- column-gap: 1.5%;\n- grid-template-areas:\n- '. logo logo . . sIcons sIcons .'\n- '. page_nav page_nav page_nav page_nav page_nav page_nav .';\n+ grid-template-columns: 16px repeat(12, 1fr) 16px;\n+ grid-template-areas: '. logo logo page_nav page_nav page_nav page_nav page_nav page_nav page_nav page_nav sIcons sIcons .';\n+ }\n+\n+ .logo {\n+ min-width: 85px;\n+ }\n+\n+ .page_nav {\n+ justify-content: center;\n}\n.request_access,\n@@ -95,3 +99,22 @@ button.request_access {\ndisplay: block;\n}\n}\n+\n+@media screen and (max-width: 480px) {\n+ nav.wrapper {\n+ grid-template-columns: 16px repeat(6, 1fr) 16px;\n+ grid-template-rows: 1fr 1fr;\n+ column-gap: 1.5%;\n+ row-gap: 25px;\n+ grid-template-areas:\n+ '. logo logo . . sIcons sIcons .'\n+ '. page_nav page_nav page_nav page_nav page_nav page_nav .';\n+ }\n+\n+ .page_nav {\n+ grid-area: page_nav;\n+ display: flex;\n+ justify-content: space-around;\n+ min-width: 225px;\n+ }\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] address header media query sizes
Summary:
Add a tablet sized break point for the header
Mobile and Tablet
{F6073}
Desktop
{F6074}
Test Plan: re-size the browser, view on a mobile device
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2656 |
129,199 | 18.12.2021 15:08:18 | 18,000 | a5f3b7159d9e417aaf063edb80dbbc97d042322e | [server] Fixing `create-metadata-table` migration
Summary: This should not have been landed with this error. No excuses!
Test Plan:
Delete table, run SQL query in TablePlus.
Delete table, run script from `server` dir, as on Notion
Reviewers: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/scripts/create-metadata-table.js",
"new_path": "server/src/scripts/create-metadata-table.js",
"diff": "@@ -7,7 +7,7 @@ async function createTable() {\nawait dbQuery(SQL`\nCREATE TABLE IF NOT EXISTS metadata (\nname varchar(255) NOT NULL,\n- data varchar(255),\n+ data varchar(255)\n) ENGINE=InnoDB DEFAULT CHARSET=utf8;\n`);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [server] Fixing `create-metadata-table` migration
Summary: This should not have been landed with this error. No excuses!
Test Plan:
Delete table, run SQL query in TablePlus.
Delete table, run script from `server` dir, as on Notion
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2657 |
129,184 | 15.12.2021 13:11:20 | 18,000 | dca88dd1598697cd8947fb7a40a361d4619aa6e7 | [CommCoreModule] Implement `getAllMessagesSync`
Summary: This will primarily be used for testing.
Test Plan: `messageStore` reconstructed from the messages retrieved from `getAllMessagesSync` consistently matches up with redux `messageStore`
Reviewers: palys-swm, def-au1t, karol-bisztyga, ashoat
Subscribers: ashoat, Adrian, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -159,6 +159,64 @@ jsi::Value CommCoreModule::removeAllDrafts(jsi::Runtime &rt) {\n});\n}\n+jsi::Array CommCoreModule::getAllMessagesSync(jsi::Runtime &rt) {\n+ std::promise<std::vector<std::pair<Message, std::vector<Media>>>>\n+ messagesResult;\n+ auto messagesResultFuture = messagesResult.get_future();\n+\n+ this->databaseThread->scheduleTask([&messagesResult]() {\n+ messagesResult.set_value(\n+ DatabaseManager::getQueryExecutor().getAllMessages());\n+ });\n+\n+ auto messagesVector = messagesResultFuture.get();\n+ size_t numMessages{messagesVector.size()};\n+ jsi::Array jsiMessages = jsi::Array(rt, numMessages);\n+\n+ size_t writeIndex = 0;\n+ for (const auto &[message, media] : messagesVector) {\n+ auto jsiMessage = jsi::Object(rt);\n+ jsiMessage.setProperty(rt, \"id\", message.id);\n+\n+ if (message.local_id) {\n+ auto local_id = message.local_id.get();\n+ jsiMessage.setProperty(rt, \"local_id\", *local_id);\n+ }\n+\n+ jsiMessage.setProperty(rt, \"thread\", message.thread);\n+ jsiMessage.setProperty(rt, \"user\", message.user);\n+ jsiMessage.setProperty(rt, \"type\", std::to_string(message.type));\n+\n+ if (message.future_type) {\n+ auto future_type = message.future_type.get();\n+ jsiMessage.setProperty(rt, \"future_type\", std::to_string(*future_type));\n+ }\n+\n+ if (message.content) {\n+ auto content = message.content.get();\n+ jsiMessage.setProperty(rt, \"content\", *content);\n+ }\n+ jsiMessage.setProperty(rt, \"time\", std::to_string(message.time));\n+\n+ size_t media_idx = 0;\n+ jsi::Array jsiMediaArray = jsi::Array(rt, media.size());\n+ for (const auto &media_info : media) {\n+ auto jsiMedia = jsi::Object(rt);\n+ jsiMedia.setProperty(rt, \"id\", media_info.id);\n+ jsiMedia.setProperty(rt, \"uri\", media_info.uri);\n+ jsiMedia.setProperty(rt, \"type\", media_info.type);\n+ jsiMedia.setProperty(rt, \"extras\", media_info.extras);\n+\n+ jsiMediaArray.setValueAtIndex(rt, media_idx++, jsiMedia);\n+ }\n+\n+ jsiMessage.setProperty(rt, \"media_infos\", jsiMediaArray);\n+ jsiMessages.setValueAtIndex(rt, writeIndex++, jsiMessage);\n+ }\n+\n+ return jsiMessages;\n+}\n+\njsi::Value CommCoreModule::getAllMessages(jsi::Runtime &rt) {\nreturn createPromiseAsJSIValue(\nrt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "@@ -31,6 +31,7 @@ class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {\njsi::Value getAllDrafts(jsi::Runtime &rt) override;\njsi::Value removeAllDrafts(jsi::Runtime &rt) override;\njsi::Value getAllMessages(jsi::Runtime &rt) override;\n+ jsi::Array getAllMessagesSync(jsi::Runtime &rt) override;\njsi::Value processMessageStoreOperations(\njsi::Runtime &rt,\nconst jsi::Array &operations) override;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"diff": "@@ -30,6 +30,9 @@ static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_removeAllDrafts(\nstatic jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllMessages(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\nreturn static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->getAllMessages(rt);\n}\n+static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllMessagesSync(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\n+ return static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->getAllMessagesSync(rt);\n+}\nstatic jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperations(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\nreturn static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->processMessageStoreOperations(rt, args[0].getObject(rt).getArray(rt));\n}\n@@ -63,6 +66,7 @@ CommCoreModuleSchemaCxxSpecJSI::CommCoreModuleSchemaCxxSpecJSI(std::shared_ptr<C\nmethodMap_[\"getAllDrafts\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllDrafts};\nmethodMap_[\"removeAllDrafts\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_removeAllDrafts};\nmethodMap_[\"getAllMessages\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllMessages};\n+ methodMap_[\"getAllMessagesSync\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllMessagesSync};\nmethodMap_[\"processMessageStoreOperations\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperations};\nmethodMap_[\"processMessageStoreOperationsSync\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperationsSync};\nmethodMap_[\"getAllThreads\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllThreads};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"diff": "@@ -24,6 +24,7 @@ virtual jsi::Value moveDraft(jsi::Runtime &rt, const jsi::String &oldKey, const\nvirtual jsi::Value getAllDrafts(jsi::Runtime &rt) = 0;\nvirtual jsi::Value removeAllDrafts(jsi::Runtime &rt) = 0;\nvirtual jsi::Value getAllMessages(jsi::Runtime &rt) = 0;\n+virtual jsi::Array getAllMessagesSync(jsi::Runtime &rt) = 0;\nvirtual jsi::Value processMessageStoreOperations(jsi::Runtime &rt, const jsi::Array &operations) = 0;\nvirtual bool processMessageStoreOperationsSync(jsi::Runtime &rt, const jsi::Array &operations) = 0;\nvirtual jsi::Value getAllThreads(jsi::Runtime &rt) = 0;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "@@ -26,6 +26,7 @@ export interface Spec extends TurboModule {\n+getAllDrafts: () => Promise<$ReadOnlyArray<ClientDBDraftInfo>>;\n+removeAllDrafts: () => Promise<void>;\n+getAllMessages: () => Promise<$ReadOnlyArray<ClientDBMessageInfo>>;\n+ +getAllMessagesSync: () => $ReadOnlyArray<ClientDBMessageInfo>;\n+processMessageStoreOperations: (\noperations: $ReadOnlyArray<ClientDBMessageStoreOperation>,\n) => Promise<void>;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Implement `getAllMessagesSync`
Summary: This will primarily be used for testing.
Test Plan: `messageStore` reconstructed from the messages retrieved from `getAllMessagesSync` consistently matches up with redux `messageStore`
Reviewers: palys-swm, def-au1t, karol-bisztyga, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2623 |
129,179 | 20.12.2021 09:37:01 | 18,000 | fdf023fe1da96ddc7d9a90a6573b0061fc076548 | [fix] [landing] header on tablet page nav spacing
Summary:
fix visual bug were page nav items are too far from each other
Before: {F6094}
After: {F6095}
Test Plan: resize window see the spacing difference.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -30,7 +30,7 @@ nav.wrapper {\ntransition: 300ms;\n}\n-div.page_nav {\n+.page_nav {\ngrid-area: page_nav;\ndisplay: flex;\njustify-content: space-evenly;\n@@ -86,6 +86,7 @@ button.request_access {\n.page_nav {\njustify-content: center;\n+ gap: 12px;\n}\n.request_access,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] header on tablet page nav spacing
Summary:
fix visual bug were page nav items are too far from each other
Before: {F6094}
After: {F6095}
Test Plan: resize window see the spacing difference.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2661 |
129,190 | 21.12.2021 11:37:43 | -3,600 | b173902ec3b7f5355c43558e44427903f9c6583b | [2/n] [services] Backup tests - add storage manager tests
Summary: Tests for `AwsStorageManager`/`AwsS3Bucket` classes
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "scripts/get_clang_paths.js",
"new_path": "scripts/get_clang_paths.js",
"diff": "@@ -14,6 +14,10 @@ const clangPaths = [\npath: 'services/backup/docker-server/contents/server/src',\nextensions: ['cpp', 'h'],\n},\n+ {\n+ path: 'services/backup/docker-server/contents/server/test',\n+ extensions: ['cpp', 'h'],\n+ },\n{\npath: 'native/android/app/src/cpp',\nextensions: ['cpp', 'h'],\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -87,7 +87,10 @@ if ($ENV{COMM_TEST_SERVICES} MATCHES 1)\nenable_testing()\nfind_package(GTest REQUIRED)\n- include_directories(${GTEST_INCLUDE_DIR})\n+ include_directories(\n+ ${GTEST_INCLUDE_DIR}\n+ ./test\n+ )\nadd_executable(\nrunTests\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/test/BackupTest.cpp",
"new_path": "services/backup/docker-server/contents/server/test/BackupTest.cpp",
"diff": "#include <gtest/gtest.h>\n-class BackupTest : public testing::Test\n-{\n+class BackupTest : public testing::Test {\nprotected:\nvirtual void SetUp() {\n//...\n@@ -12,10 +11,7 @@ protected:\n}\n};\n-TEST_F(BackupTest, passingTest)\n-{\n- EXPECT_TRUE(true);\n-}\n+TEST_F(BackupTest, passingTest) { EXPECT_TRUE(true); }\nTEST_F(BackupTest, failingTest) {\n// EXPECT_TRUE(false);\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/test/StorageManagerTest.cpp",
"diff": "+#include <gtest/gtest.h>\n+\n+#include \"AwsStorageManager.h\"\n+#include \"TestTools.h\"\n+\n+#include <aws/core/Aws.h>\n+\n+#include <chrono>\n+#include <iostream>\n+#include <memory>\n+#include <string>\n+\n+using namespace comm::network;\n+\n+class StorageManagerTest : public testing::Test {\n+public:\n+protected:\n+ std::unique_ptr<AwsStorageManager> storageManager;\n+ const std::string bucketName = \"commapp-test\";\n+ const std::string data = \"yiU3VaZlKfTteO10yrWmK1Q5BOvBQrdmj2aBlnoLuhxLfRZK1n8\"\n+ \"26FRXJAGhPswR1r8yxtwxyLkv3I4J4tlH4brDP10mrB99XpM6\";\n+\n+ virtual void SetUp() {\n+ Aws::InitAPI({});\n+ if (storageManager == nullptr) {\n+ storageManager = std::make_unique<AwsStorageManager>();\n+ }\n+ }\n+\n+ virtual void TearDown() { Aws::ShutdownAPI({}); }\n+};\n+\n+TEST_F(StorageManagerTest, ObjectOperationsTest) {\n+ EXPECT_TRUE(storageManager->getBucket(bucketName).isAvailable());\n+ std::string objectName = createObject(storageManager->getBucket(bucketName));\n+\n+ storageManager->getBucket(bucketName).writeObject(objectName, data);\n+\n+ EXPECT_EQ(storageManager->getBucket(bucketName).getObjectSize(objectName),\n+ data.size());\n+ EXPECT_TRUE(storageManager->getBucket(bucketName).getObjectData(objectName) ==\n+ data);\n+ std::string chunkedData;\n+ const size_t chunkSize = data.size() / 10;\n+ std::function<void(const std::string &)> callback =\n+ [&chunkedData](const std::string &chunk) { chunkedData += chunk; };\n+ storageManager->getBucket(bucketName)\n+ .getObjectDataChunks(objectName, callback, chunkSize);\n+ EXPECT_TRUE(data == chunkedData);\n+\n+ storageManager->getBucket(bucketName)\n+ .renameObject(objectName, objectName + \"c\");\n+ EXPECT_THROW(storageManager->getBucket(bucketName).getObjectData(objectName),\n+ std::runtime_error);\n+ EXPECT_TRUE(\n+ storageManager->getBucket(bucketName).getObjectData(objectName + \"c\") ==\n+ data);\n+ storageManager->getBucket(bucketName)\n+ .renameObject(objectName + \"c\", objectName);\n+\n+ storageManager->getBucket(bucketName).clearObject(objectName);\n+ EXPECT_EQ(storageManager->getBucket(bucketName).getObjectSize(objectName), 0);\n+\n+ storageManager->getBucket(bucketName).deleteObject(objectName);\n+ EXPECT_THROW(storageManager->getBucket(bucketName).getObjectData(objectName),\n+ std::runtime_error);\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/test/TestTools.cpp",
"diff": "+#include \"TestTools.h\"\n+#include \"AwsS3Bucket.h\"\n+\n+namespace comm {\n+namespace network {\n+\n+std::string generateObjectName() {\n+ std::chrono::milliseconds ms =\n+ std::chrono::duration_cast<std::chrono::milliseconds>(\n+ std::chrono::system_clock::now().time_since_epoch());\n+ return std::to_string(ms.count());\n+}\n+\n+std::string createObject(AwsS3Bucket bucket) {\n+ std::string objectName;\n+ std::vector<std::string> presentObjects;\n+ do {\n+ objectName = generateObjectName();\n+ presentObjects = bucket.listObjects();\n+ } while (std::find(presentObjects.begin(), presentObjects.end(),\n+ objectName) != presentObjects.end());\n+ return objectName;\n+}\n+\n+} // namespace network\n+} // namespace comm\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/test/TestTools.h",
"diff": "+#pragma once\n+\n+#include \"AwsS3Bucket.h\"\n+\n+#include <chrono>\n+#include <string>\n+\n+namespace comm {\n+namespace network {\n+\n+std::string generateObjectName();\n+std::string createObject(AwsS3Bucket bucket);\n+\n+} // namespace network\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [services] Backup tests - add storage manager tests
Summary: Tests for `AwsStorageManager`/`AwsS3Bucket` classes
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2618 |
129,190 | 21.12.2021 11:37:46 | -3,600 | 034ef7d4ec5d86e0384c6d5ec426b68153eeda15 | [3/n] [services] Backup tests - add mpu tests
Summary: Tests for `MultiPartUploader` class
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/test/MultiPartUploadTest.cpp",
"diff": "+#include <gtest/gtest.h>\n+\n+#include \"AwsS3Bucket.h\"\n+#include \"AwsStorageManager.h\"\n+#include \"MultiPartUploader.h\"\n+#include \"TestTools.h\"\n+#include \"Tools.h\"\n+\n+#include <aws/core/Aws.h>\n+#include <aws/s3/S3Client.h>\n+\n+#include <string>\n+\n+using namespace comm::network;\n+\n+class MultiPartUploadTest : public testing::Test {\n+protected:\n+ std::shared_ptr<Aws::S3::S3Client> s3Client;\n+ const std::string bucketName = \"commapp-test\";\n+ std::unique_ptr<AwsS3Bucket> bucket;\n+\n+ virtual void SetUp() {\n+ Aws::InitAPI({});\n+ Aws::Client::ClientConfiguration config;\n+ config.region = \"us-east-2\";\n+ s3Client = std::make_shared<Aws::S3::S3Client>(config);\n+ bucket = std::make_unique<AwsS3Bucket>(bucketName, s3Client);\n+ }\n+\n+ virtual void TearDown() { Aws::ShutdownAPI({}); }\n+};\n+\n+std::string generateNByes(const size_t n) {\n+ std::string result;\n+ result.resize(n);\n+ memset((char *)result.data(), 'A', n);\n+ return result;\n+}\n+\n+TEST_F(MultiPartUploadTest, ThrowingTooSmallPart) {\n+ std::string objectName = createObject(*bucket);\n+ MultiPartUploader mpu(s3Client, bucketName, objectName);\n+ mpu.addPart(\"xxx\");\n+ mpu.addPart(\"xxx\");\n+ EXPECT_THROW(mpu.finishUpload(), std::runtime_error);\n+}\n+\n+TEST_F(MultiPartUploadTest, ThrowingTooSmallPartOneByte) {\n+ std::string objectName = createObject(*bucket);\n+ MultiPartUploader mpu(s3Client, bucketName, objectName);\n+ mpu.addPart(generateNByes(AWS_MULTIPART_UPLOAD_MINIMUM_CHUNK_SIZE - 1));\n+ mpu.addPart(\"xxx\");\n+ EXPECT_THROW(mpu.finishUpload(), std::runtime_error);\n+}\n+\n+TEST_F(MultiPartUploadTest, SuccessfulWriteMultipleChunks) {\n+ std::string objectName = createObject(*bucket);\n+ MultiPartUploader mpu(s3Client, bucketName, objectName);\n+ mpu.addPart(generateNByes(AWS_MULTIPART_UPLOAD_MINIMUM_CHUNK_SIZE));\n+ mpu.addPart(\"xxx\");\n+ mpu.finishUpload();\n+ EXPECT_THROW(bucket->getObjectData(objectName), invalid_argument_error);\n+ EXPECT_EQ(bucket->getObjectSize(objectName),\n+ AWS_MULTIPART_UPLOAD_MINIMUM_CHUNK_SIZE + 3);\n+ bucket->deleteObject(objectName);\n+}\n+\n+TEST_F(MultiPartUploadTest, SuccessfulWriteOneChunk) {\n+ std::string objectName = createObject(*bucket);\n+ MultiPartUploader mpu(s3Client, bucketName, objectName);\n+ mpu.addPart(\"xxx\");\n+ mpu.finishUpload();\n+ EXPECT_EQ(bucket->getObjectSize(objectName), 3);\n+ bucket->deleteObject(objectName);\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] [services] Backup tests - add mpu tests
Summary: Tests for `MultiPartUploader` class
Test Plan: `cd services && yarn test-backup-server`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2619 |
129,179 | 27.12.2021 13:51:20 | 18,000 | 6f72ff39b8ad2a22c3224a15b56ada8a47212795 | [revert] [landing] object spread syntax
Summary: reverting spread syntax per: project wide.
Test Plan: make sure the app still works.
Reviewers: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -19,7 +19,7 @@ function InfoBlock(props: InfoBlockProps): React.Node {\nreturn (\n<>\n<div className={imageStyle}>\n- <Picture {...{ url, alt }} />\n+ <Picture alt={alt} url={url} />\n</div>\n<div className={`${css.info_block} ${infoStyle}`}>\n<p className={css.title}>{title}</p>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "@@ -48,7 +48,7 @@ function NotificationRow(props: ProfileRowProps): React.Node {\nconst { content, onPress, danger, selected } = props;\nreturn (\n<Action.Row onPress={onPress}>\n- <Action.Text {...{ danger, content }} />\n+ <Action.Text danger={danger} content={content} />\n{selected ? <CheckIcon /> : null}\n</Action.Row>\n);\n@@ -199,12 +199,10 @@ const ConnectedDefaultNotificationPreferences: React.ComponentType<BaseProps> =\nreturn (\n<DefaultNotificationsPreferences\n{...props}\n- {...{\n- styles,\n- dispatchActionPromise,\n- changeNotificationSettings,\n- selectedDefaultNotification,\n- }}\n+ styles={styles}\n+ dispatchActionPromise={dispatchActionPromise}\n+ changeNotificationSettings={changeNotificationSettings}\n+ selectedDefaultNotification={selectedDefaultNotification}\n/>\n);\n},\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/profile-screen.react.js",
"new_path": "native/profile/profile-screen.react.js",
"diff": "@@ -62,7 +62,7 @@ function ProfileRow(props: ProfileRowProps): React.Node {\nconst { content, onPress, danger } = props;\nreturn (\n<Action.Row onPress={onPress}>\n- <Action.Text {...{ danger, content }} />\n+ <Action.Text danger={danger} content={content} />\n<Action.Icon name=\"ios-arrow-forward\" />\n</Action.Row>\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [revert] [landing] object spread syntax
Summary: reverting spread syntax per: https://linear.app/comm/issue/ENG-313/revert-object-spread-syntax-for-react-props project wide.
Test Plan: make sure the app still works.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2732 |
129,179 | 28.12.2021 13:46:22 | 18,000 | 4ad2d5f351fceb247c1dc81d2a12437c24fc40a8 | [fix] [landing] footer renders full screen on large screens
Summary:
footer renders full screen on large screens
Before: {F6212}
After: {F6385}
Test Plan: resize window. make sure footer stretches
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "footer.wrapper {\n+ background: rgba(235, 235, 235, 0.05);\n+ backdrop-filter: blur(12px);\n+ position: sticky;\n+ top: 100vh;\n+}\n+\n+.contentWrapper {\nmax-width: 1850px;\nmargin-left: auto;\nmargin-right: auto;\n@@ -8,10 +15,6 @@ footer.wrapper {\ncolumn-gap: 1.5%;\nalign-items: center;\ngrid-template-areas: '. nav nav nav . . . sub sub sub sub sub sub .';\n- background: rgba(235, 235, 235, 0.05);\n- backdrop-filter: blur(12px);\n- position: sticky;\n- top: 100vh;\n}\n@media screen and (max-width: 1099px) {\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/footer.react.js",
"new_path": "landing/footer.react.js",
"diff": "@@ -18,6 +18,7 @@ const navLinkProps = {\nfunction Footer(): React.Node {\nreturn (\n<footer className={css.wrapper}>\n+ <div className={css.contentWrapper}>\n<div className={css.navigation}>\n<NavLink className={css.logo} to=\"/\">\nComm\n@@ -43,10 +44,10 @@ function Footer(): React.Node {\n/>\n</a>\n</div>\n-\n<div className={css.submissionForm}>\n<SubscriptionForm />\n</div>\n+ </div>\n</footer>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] footer renders full screen on large screens
Summary:
footer renders full screen on large screens
Before: {F6212}
After: {F6385}
Test Plan: resize window. make sure footer stretches
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2733 |
129,184 | 28.12.2021 18:33:30 | 18,000 | 85d402278455c0240edf21b2f7f576b5fb184be9 | [yarn] Bump `ws`
Summary:
Bumping `ws` from 5.2.2 -> 5.2.3 resolves a security issue.
Takes us from 30 to 29 vulnerabilities in `y audit`
Test Plan: Should be fine
Reviewers: varun, palys-swm, def-au1t, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -16287,9 +16287,9 @@ ws@^1.1.0, ws@^1.1.5:\nultron \"1.0.x\"\nws@^5.2.0:\n- version \"5.2.2\"\n- resolved \"https://registry.yarnpkg.com/ws/-/ws-5.2.2.tgz#dffef14866b8e8dc9133582514d1befaf96e980f\"\n- integrity sha512-jaHFD6PFv6UgoIVda6qZllptQsMlDEJkTQcybzzXDYM1XO9Y8em691FGMPmM46WGyLU4z9KMgQN+qrux/nhlHA==\n+ version \"5.2.3\"\n+ resolved \"https://registry.yarnpkg.com/ws/-/ws-5.2.3.tgz#05541053414921bc29c63bee14b8b0dd50b07b3d\"\n+ integrity sha512-jZArVERrMsKUatIdnLzqvcfydI85dvd/Fp1u/VOpfdDWQ4c9qWXe+VIeAbQ5FrDwciAkr+lzofXLz3Kuf26AOA==\ndependencies:\nasync-limiter \"~1.0.0\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [yarn] Bump `ws`
Summary:
Bumping `ws` from 5.2.2 -> 5.2.3 resolves a security issue.
Takes us from 30 to 29 vulnerabilities in `y audit`
Test Plan: Should be fine
Reviewers: varun, palys-swm, def-au1t, ashoat
Reviewed By: ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2718 |
129,184 | 28.12.2021 22:01:37 | 18,000 | 15e32315f65525a3cf0b24c71e9c0c296caa93b8 | [native] `codeVersion` -> 127 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 126\n- versionName '1.0.126'\n+ versionCode 127\n+ versionName '1.0.127'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.126</string>\n+ <string>1.0.127</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>126</string>\n+ <string>127</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.126</string>\n+ <string>1.0.127</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>126</string>\n+ <string>127</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -381,7 +381,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 126;\n+const codeVersion = 127;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 127 |
129,185 | 27.12.2021 15:31:22 | -3,600 | aedcb49a2890ca1eb1cf8c9b60f488ca89f49d48 | [1/n] [id-schemas] [server] Introduce `tID` type for IDs in server validators
Summary: Introduce `tID` as `tcomb` type (refinement) defined as non-empty string (like `tPassword`).
Test Plan: No changes in server behavior yet.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/utils/validation-utils.js",
"new_path": "server/src/utils/validation-utils.js",
"diff": "@@ -63,6 +63,7 @@ const tPassword: TRefinement<string> = t.refinement(\nconst tCookie: TRegex = tRegex(/^(user|anonymous)=[0-9]+:[0-9a-f]+$/);\nconst tEmail: TRegex = tRegex(validEmailRegex);\nconst tOldValidUsername: TRegex = tRegex(oldValidUsernameRegex);\n+const tID: TRefinement<string> = t.refinement(t.String, (id: string) => !!id);\nasync function validateInput(viewer: Viewer, inputValidator: *, input: *) {\nif (!viewer.isSocket) {\n@@ -221,6 +222,7 @@ export {\ntCookie,\ntEmail,\ntOldValidUsername,\n+ tID,\nvalidateInput,\ncheckInputValidator,\ncheckClientSupported,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] [id-schemas] [server] Introduce `tID` type for IDs in server validators
Summary: Introduce `tID` as `tcomb` type (refinement) defined as non-empty string (like `tPassword`).
Test Plan: No changes in server behavior yet.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2691 |
129,185 | 27.12.2021 15:31:22 | -3,600 | de04436dc5614da4c6f8c2acd9e769e221526519 | [2/n] [id-schemas] [server] Introduce `tNumber` as literal number for `tcomb` validation
Summary: Introducing util `tNumber` similar to existing `tBool` and `tString` for number values validation.
Test Plan: Tested with changes in future diffs.
Reviewers: palys-swm, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/utils/validation-utils.js",
"new_path": "server/src/utils/validation-utils.js",
"diff": "@@ -27,6 +27,10 @@ function tString(value: string): TIrreducible<string> {\nreturn t.irreducible('literal string', x => x === value);\n}\n+function tNumber(value: number): TIrreducible<number> {\n+ return t.irreducible('literal number', x => x === value);\n+}\n+\nfunction tShape(spec: TStructProps): TInterface {\nreturn t.interface(spec, { strict: true });\n}\n@@ -210,6 +214,7 @@ function findFirstInputMatchingValidator(\nexport {\ntBool,\ntString,\n+ tNumber,\ntShape,\ntRegex,\ntNumEnum,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [id-schemas] [server] Introduce `tNumber` as literal number for `tcomb` validation
Summary: Introducing util `tNumber` similar to existing `tBool` and `tString` for number values validation.
Test Plan: Tested with changes in future diffs.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2727 |
129,191 | 21.12.2021 18:03:42 | -3,600 | d967e73b8b825b9ed0678a123603f24cf7acd3a2 | [3/5][server] Delete earliestFocusedTimeConsideredCurrent method
Summary: We're no longer using it
Test Plan: Flow
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/shared/focused-times.js",
"new_path": "server/src/shared/focused-times.js",
"diff": "// @flow\n-import { pingFrequency } from 'lib/shared/timeouts';\n-\n-// If the time column for a given entry in the focused table has a time later\n-// than this, then that entry is considered current, and consequently the thread\n-// in question is considered in focus.\n-function earliestFocusedTimeConsideredCurrent(): number {\n- return Date.now() - pingFrequency - 1500;\n-}\n-\nconst fourHoursInMillis = 4 * 60 * 60 * 1000;\n// If the time column for a given entry in the focused table has a time earlier\n@@ -18,7 +9,4 @@ function earliestFocusedTimeConsideredExpired(): number {\nreturn Date.now() - fourHoursInMillis;\n}\n-export {\n- earliestFocusedTimeConsideredCurrent,\n- earliestFocusedTimeConsideredExpired,\n-};\n+export { earliestFocusedTimeConsideredExpired };\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/5][server] Delete earliestFocusedTimeConsideredCurrent method
Summary: We're no longer using it
Test Plan: Flow
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2695 |
129,191 | 21.12.2021 18:28:32 | -3,600 | 18a44626a16ca842b50a6feb139b8ac7214e6d04 | [4/5][server] Do not update focused time after ping
Summary: We no longer need to update the time
Test Plan: Add a console log to verify that pong was returned correctly
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -383,7 +383,7 @@ class Socket {\nthis.markActivityOccurred();\nreturn await this.handleResponsesClientSocketMessage(message);\n} else if (message.type === clientSocketMessageTypes.PING) {\n- return await this.handlePingClientSocketMessage(message);\n+ return this.handlePingClientSocketMessage(message);\n} else if (message.type === clientSocketMessageTypes.ACK_UPDATES) {\nthis.markActivityOccurred();\nreturn await this.handleAckUpdatesClientSocketMessage(message);\n@@ -592,10 +592,9 @@ class Socket {\n];\n}\n- async handlePingClientSocketMessage(\n+ handlePingClientSocketMessage(\nmessage: PingClientSocketMessage,\n- ): Promise<ServerServerSocketMessage[]> {\n- this.updateActivityTime();\n+ ): ServerServerSocketMessage[] {\nreturn [\n{\ntype: serverSocketMessageTypes.PONG,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [4/5][server] Do not update focused time after ping
Summary: We no longer need to update the time
Test Plan: Add a console log to verify that pong was returned correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2698 |
129,191 | 21.12.2021 18:37:12 | -3,600 | 3cd09546102518e54801097822a86a9fbaab634d | [5/5][server] Delete updateActivityTime function
Summary: We don't need that
Test Plan: Flow
Reviewers: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/socket/socket.js",
"new_path": "server/src/socket/socket.js",
"diff": "@@ -70,7 +70,6 @@ import {\ncreateNewAnonymousCookie,\n} from '../session/cookies';\nimport { Viewer } from '../session/viewer';\n-import { updateActivityTime } from '../updaters/activity-updaters';\nimport { commitSessionUpdate } from '../updaters/session-updaters';\nimport { assertSecureRequest } from '../utils/security-utils';\nimport {\n@@ -723,12 +722,6 @@ class Socket {\nthis.handleStateCheckConditionsUpdate();\n}\n- updateActivityTime() {\n- const { viewer } = this;\n- invariant(viewer, 'should be set');\n- handleAsyncPromise(updateActivityTime(viewer));\n- }\n-\n// The Socket will timeout by calling this.ws.terminate()\n// serverRequestSocketTimeout milliseconds after the last\n// time resetTimeout is called\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/activity-updaters.js",
"new_path": "server/src/updaters/activity-updaters.js",
"diff": "@@ -489,24 +489,6 @@ async function shouldResetThreadToUnread(\nreturn threadsWithNewerMessages.has(request.threadID);\n}\n-// The `focused` table tracks which chat threads are currently in view for a\n-// given cookie. We track this so that if a user is currently viewing a thread's\n-// messages, then notifications on that thread are not sent. This function does\n-// not add new rows to the `focused` table, but instead extends currently active\n-// rows for the current cookie.\n-async function updateActivityTime(viewer: Viewer): Promise<void> {\n- if (!viewer.loggedIn) {\n- return;\n- }\n- const time = Date.now();\n- const focusedQuery = SQL`\n- UPDATE focused\n- SET time = ${time}\n- WHERE user = ${viewer.userID} AND session = ${viewer.session}\n- `;\n- await dbQuery(focusedQuery);\n-}\n-\ntype LastMessageInfo = {\n+lastMessage: number,\n+lastReadMessage: number,\n@@ -532,4 +514,4 @@ async function fetchLastMessageInfo(\nreturn lastMessages;\n}\n-export { activityUpdater, updateActivityTime, setThreadUnreadStatus };\n+export { activityUpdater, setThreadUnreadStatus };\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [5/5][server] Delete updateActivityTime function
Summary: We don't need that
Test Plan: Flow
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2699 |
129,179 | 09.01.2022 19:30:47 | 18,000 | ae2083d4e50d8fe788b7b404248136db9646880c | [fix] [landing] copy change ETH wallet --> wallet
Summary:
copy change per:
{F7387}
Test Plan: go to landing and make sure copy is right
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/asset-meta-data.js",
"new_path": "landing/asset-meta-data.js",
"diff": "@@ -56,7 +56,7 @@ export const assetMetaData = [\nimageStyle: css.sovereignImage,\ninfoStyle: css.sovereignInfo,\ntitle: 'Sovereign',\n- description: `Log in with your ETH wallet. Use ENS as your username. On Comm,\n+ description: `Log in with your wallet. Use ENS as your username. On Comm,\nyour identity and data are yours to control.`,\n},\n{\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [fix] [landing] copy change ETH wallet --> wallet
Summary:
copy change per: https://linear.app/comm/issue/ENG-399/replace-eth-wallet-with-wallet-on-landing-page
{F7387}
Test Plan: go to landing and make sure copy is right
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2772 |
129,184 | 06.01.2022 17:11:01 | 18,000 | 1f7f8010972d9d16754648079dd87e438c63ef8e | [keyserver] Add `@grpc/grpc-js` to `package.json`
Summary: Don't have any code that's ready to commit.. still experimenting, but might as well get this in
Test Plan: NA
Reviewers: varun, palys-swm, geekbrother, benschac, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"tcomb\": \"^3.2.29\",\n\"twin-bcrypt\": \"^2.1.1\",\n\"uuid\": \"^3.3.3\",\n- \"web\": \"0.0.1\"\n+ \"web\": \"0.0.1\",\n+ \"@grpc/grpc-js\": \"^1.4.6\"\n},\n\"optionalDependencies\": {\n\"bufferutil\": \"^4.0.5\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "dependencies:\ntslib \"~2.3.0\"\n-\"@grpc/grpc-js@~1.4.0\":\n- version \"1.4.5\"\n- resolved \"https://registry.yarnpkg.com/@grpc/grpc-js/-/grpc-js-1.4.5.tgz#0cd840b47180624eeedf066f2cdc422d052401f8\"\n- integrity sha512-A6cOzSu7dqXZ7rzvh/9JZf+Jg/MOpLEMP0IdT8pT8hrWJZ6TB4ydN/MRuqOtAugInJe/VQ9F8BPricUpYZSaZA==\n+\"@grpc/grpc-js@^1.4.6\", \"@grpc/grpc-js@~1.4.0\":\n+ version \"1.4.6\"\n+ resolved \"https://registry.yarnpkg.com/@grpc/grpc-js/-/grpc-js-1.4.6.tgz#8108d7ab7c0c21b38c538c1a48583edbbf2c2412\"\n+ integrity sha512-Byau4xiXfIixb1PnW30V/P9mkrZ05lknyNqiK+cVY9J5hj3gecxd/anwaUbAM8j834zg1x78NvAbwGnMfWEu7A==\ndependencies:\n\"@grpc/proto-loader\" \"^0.6.4\"\n\"@types/node\" \">=12.12.47\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [keyserver] Add `@grpc/grpc-js` to `package.json`
Summary: Don't have any code that's ready to commit.. still experimenting, but might as well get this in
Test Plan: NA
Reviewers: varun, palys-swm, geekbrother, benschac, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2789 |
129,179 | 10.01.2022 09:09:33 | 18,000 | 317d6f5d468a392d922aa7b839afdcbf519c8a6d | [web] [4/n] [refactor] use font-stack css variable
Summary: use css variable for font stack
Test Plan: make sure fonts still render correctly on the page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -10,8 +10,7 @@ html {\nheight: 100%;\n}\nbody {\n- font-family: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n- 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ font-family: var(--font-stack-sans-serif);\nbackground-image: url(../images/background.png);\nbackground-size: 3000px 2000px;\nbackground-attachment: fixed;\n@@ -34,8 +33,7 @@ textarea {\n-webkit-border-radius: 0;\nborder: 1px solid #dddddd;\nborder-radius: 1px;\n- font-family: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n- 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ font-family: var(--font-stack-sans-serif);\n}\ninput[type='submit'] {\n-webkit-appearance: none;\n@@ -387,8 +385,7 @@ div.large-modal-container div.modal-body div.form-title {\n}\ndiv.modal-body div.form-content {\ndisplay: inline-block;\n- font-family: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n- 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ font-family: var(--font-stack-sans-serif);\nfont-size: 15px;\n}\ndiv.modal-body div.form-subtitle {\n@@ -418,8 +415,7 @@ div.form-enum-selector div.form-enum-option {\n}\ndiv.form-enum-selector span.form-enum-description {\ndisplay: block;\n- font-family: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n- 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ font-family: var(--font-stack-sans-serif);\nfont-weight: normal;\nfont-size: 13px;\nmax-width: 260px;\n@@ -605,8 +601,7 @@ div.intro-modal {\nbackground-color: #f8f8f8;\nwidth: 310px;\nposition: fixed;\n- font-family: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n- 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ font-family: var(--font-stack-sans-serif);\nmargin-top: 100px;\nbox-shadow: 2px 3px 6px 0px rgba(0, 0, 0, 0.1);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] [refactor] use font-stack css variable
Summary: use css variable for font stack
Test Plan: make sure fonts still render correctly on the page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2780 |
129,184 | 10.01.2022 12:47:24 | 18,000 | 14af49565eaae3b7ad9f2e6e9242d59266652297 | [native] `codeVersion` -> 128 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -430,8 +430,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 127\n- versionName '1.0.127'\n+ versionCode 128\n+ versionName '1.0.128'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.127</string>\n+ <string>1.0.128</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>127</string>\n+ <string>128</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.127</string>\n+ <string>1.0.128</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>127</string>\n+ <string>128</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -381,7 +381,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 127;\n+const codeVersion = 128;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 128 |
129,179 | 11.01.2022 02:18:35 | 18,000 | cd320d23f88971059cf9164981a2496cf6be5159 | [web] [9/n] remove Anaheim from project
Summary: remove anaheim font that's no longer used in the project
Test Plan: make sure there aren't any references to anaheim left. Confirm this style isn't in figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/fonts/local-fonts.css",
"new_path": "server/fonts/local-fonts.css",
"diff": "-/* latin-ext */\n-@font-face {\n- font-family: 'Anaheim';\n- font-style: normal;\n- font-weight: 400;\n- src: local('Anaheim'), local('Anaheim-Regular'), url(anaheim-latin-ext.woff2) format('woff2');\n- unicode-range: U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF;\n-}\n-/* latin */\n-@font-face {\n- font-family: 'Anaheim';\n- font-style: normal;\n- font-weight: 400;\n- src: local('Anaheim'), local('Anaheim-Regular'), url(anaheim-latin.woff2) format('woff2');\n- unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000;\n-}\n/* ibm plex mono medium */\n@font-face {\nfont-family: 'IBM Plex Mono';\n"
},
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -21,7 +21,6 @@ div.content {\n}\nh2.nav {\n- font-family: 'Anaheim', sans-serif;\ntext-align: center;\nmargin: 8px auto 12px auto;\nwidth: 250px;\n@@ -175,7 +174,6 @@ td.day > h2 {\nfont-size: 32px;\nline-height: 32px;\nz-index: 1;\n- font-family: 'Anaheim', sans-serif;\n}\ntd.currentDay > h2 {\ncolor: #ff944d;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/splash/splash.css",
"new_path": "web/splash/splash.css",
"diff": "@@ -36,7 +36,6 @@ div.actionLinks > *:last-child {\npadding-right: 0;\n}\nheader.header h1 {\n- font-family: 'Anaheim', sans-serif;\ncolor: white;\nfont-size: 38px;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -59,7 +59,6 @@ header.header {\nz-index: 1;\n}\ndiv.main-header {\n- font-family: 'Anaheim', sans-serif;\nheight: 62px;\n}\ndiv.main-header > h1 {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [9/n] remove Anaheim from project
Summary: remove anaheim font that's no longer used in the project
Test Plan: make sure there aren't any references to anaheim left. Confirm this style isn't in figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2787 |
129,179 | 07.01.2022 08:32:29 | 18,000 | b7a381feea0f0d543076a60ba1bc646e93556412 | [web] [13/n] add base theme from default color swatch
Summary: add default theme from color swatch.
Test Plan: N/A its not being used anywhere.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/theme.css",
"diff": "+:root {\n+ --bg: var(--shades-black-100);\n+ --color: var(--shades-white-100);\n+ --color-disabled: var(--shades-black-60);\n+ --text-input-bg: var(--shades-black-80);\n+ --text-input-color: var(--shades-black-60);\n+ --border: var(--shades-black-80);\n+ --error: var(--error-primary);\n+ --success: var(--success-dark-50);\n+\n+ /* Color theme */\n+ --btn-bg-primary: var(--violet-dark-100);\n+ --chat-bg: var(--violet-dark-80);\n+ --chat-confirmation-icon: var(--violet-dark-100);\n+ --keyserver-selection: var(--violet-dark-60);\n+ --thread-selection: var(--violet-light-80);\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [13/n] add base theme from default color swatch
Summary: add default theme from color swatch.
Test Plan: N/A its not being used anywhere.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2792 |
129,179 | 05.01.2022 11:18:39 | 18,000 | cbaff1bae726e514860ddf763b00d91a76150ac8 | [landing] [1/2] [refactor] extract cta button into a component
Summary: move cta button to it's own component, will be used in `/team` moving forward.
Test Plan: N/A, will render correctly in the following diff
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/button.css",
"diff": "+button.btn {\n+ all: unset;\n+ border-radius: 4px;\n+ font-size: 16px;\n+ background-color: var(--btn-bg);\n+ color: var(--btn-color);\n+ justify-content: center;\n+ padding: 12px 24px;\n+ transition: 300ms;\n+ flex-basis: 120px;\n+ text-align: center;\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/button.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from './button.css';\n+\n+type Props = {\n+ +onClick: (e: Event) => Promise<void>,\n+ +children?: React.Node,\n+};\n+\n+function Button(props: Props): React.Node {\n+ const { onClick, children } = props;\n+ return (\n+ <button className={css.btn} onClick={onClick}>\n+ {children}\n+ </button>\n+ );\n+}\n+\n+export default Button;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -44,19 +44,6 @@ div.button_container {\njustify-content: flex-end;\n}\n-button.request_access {\n- all: unset;\n- border-radius: 4px;\n- font-size: 16px;\n- background-color: var(--btn-bg);\n- color: var(--btn-color);\n- justify-content: center;\n- padding: 12px 24px;\n- transition: 300ms;\n- flex-basis: 120px;\n- text-align: center;\n-}\n-\n.social_icons {\ngrid-area: sIcons;\ndisplay: flex;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.react.js",
"new_path": "landing/header.react.js",
"diff": "@@ -5,6 +5,7 @@ import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport { NavLink } from 'react-router-dom';\n+import Button from './button.react.js';\nimport css from './header.css';\ntype HeaderProps = {\n@@ -41,9 +42,7 @@ function Header(props: HeaderProps): React.Node {\n</NavLink>\n</div>\n<div className={css.button_container}>\n- <button className={css.request_access} onClick={onRequestAccess}>\n- Request Access\n- </button>\n+ <Button onClick={onRequestAccess}>Request Access</Button>\n</div>\n<div className={css.social_icons}>\n<a className={css.twitter_icon} href=\"https://twitter.com/commdotapp\">\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] [1/2] [refactor] extract cta button into a component
Summary: move cta button to it's own component, will be used in `/team` moving forward.
Test Plan: N/A, will render correctly in the following diff
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2773 |
129,179 | 06.01.2022 16:32:09 | 18,000 | 571fd08949cb4174443246d5cff7116a3b0324a5 | [11/n] [web] add font styles from figma to global variables
Summary: Add style guide values to css variables. Link to style guide:
Test Plan: N/A they aren't used yet
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "web/typography.css",
"new_path": "web/typography.css",
"diff": "--font-stack-sans-serif: -apple-system, 'Segoe UI', 'Roboto', 'Oxygen',\n'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue',\nui-sans-serif;\n+ --xxxl-font-32: 3.2rem;\n+ --xxl-font-28: 2.8rem;\n+ --xxl-font-24: 2.4rem;\n+ --xl-font-20: 2rem;\n+ --l-font-18: 1.8rem;\n+ --m-font-16: 1.6rem;\n+ --s-font-14: 1.4rem;\n+ --xs-font-12: 1.2rem;\n+ --normal: 400;\n+ --semi-bold: 500;\n+ --bold: 600;\n+ --line-height-text: 1.5;\n+ --line-height-display: 1.3;\n}\n.h1,\n@@ -10,7 +23,6 @@ h1,\nh2,\n.h3,\nh3 {\n- letter-spacing: var(--letter-spacing-display);\nline-height: var(--line-height-display);\n}\n@@ -37,7 +49,6 @@ h5,\np,\n.small,\nsmall {\n- letter-spacing: var(--letter-spacing-text);\nline-height: var(--line-height-text);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [11/n] [web] add font styles from figma to global variables
Summary: Add style guide values to css variables. Link to style guide: https://www.figma.com/file/RROVwCKAeFaO7tG64blzlx/Comm-Web-Design-System?node-id=1%3A16
Test Plan: N/A they aren't used yet
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2788 |
129,179 | 10.01.2022 13:49:42 | 18,000 | a12aa8e1bdad73d4f0787edbe68f06418cc4c9ff | [web] [16/n] [refactor] move tool tip css into its own module
Summary: move tooltip styles from chat-message-list to tooltip
Test Plan: make sure page renders and styles look the same as production
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -108,50 +108,6 @@ div.innerRobotextContainer {\nword-break: break-word;\n}\n-div.messageTooltipMenu {\n- position: absolute;\n- background-color: black;\n- color: white;\n- padding: 5px;\n- border-radius: 5px;\n- font-size: 14px;\n- z-index: 1;\n- white-space: nowrap;\n-}\n-div.messageTooltipMenu ul {\n- list-style: none;\n-}\n-div.messageTooltipMenu li:not(:last-child) {\n- padding-bottom: 5px;\n-}\n-div.messageTooltipMenu:after {\n- content: '';\n- position: absolute;\n- width: 0;\n- height: 0;\n- border-width: 7px;\n- border-style: solid;\n-}\n-div.messageTooltipMenu button {\n- border: none;\n- cursor: pointer;\n- font-size: 14px;\n- outline: none;\n- background-color: black;\n- color: white;\n- text-decoration: underline;\n-}\n-div.messageTooltipMenu button:hover {\n- background-color: black;\n- color: #129aff;\n-}\n-\n-div.messageLeftTooltip {\n- transform: translate(0%, -50%);\n-}\n-div.messageRightTooltip {\n- transform: translate(0%, -50%);\n-}\ndiv.messageLeftTooltip:after {\ntop: 7px;\nright: -14px;\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/chat/tooltip.css",
"diff": "+div.messageTooltipMenu {\n+ position: absolute;\n+ background-color: black;\n+ color: white;\n+ padding: 5px;\n+ border-radius: 5px;\n+ font-size: 14px;\n+ z-index: 1;\n+ white-space: nowrap;\n+}\n+div.messageTooltipMenu ul {\n+ list-style: none;\n+}\n+div.messageTooltipMenu li:not(:last-child) {\n+ padding-bottom: 5px;\n+}\n+div.messageTooltipMenu:after {\n+ content: '';\n+ position: absolute;\n+ width: 0;\n+ height: 0;\n+ border-width: 7px;\n+ border-style: solid;\n+}\n+div.messageTooltipMenu button {\n+ border: none;\n+ cursor: pointer;\n+ font-size: 14px;\n+ outline: none;\n+ background-color: black;\n+ color: white;\n+ text-decoration: underline;\n+}\n+div.messageTooltipMenu button:hover {\n+ background-color: black;\n+ color: #129aff;\n+}\n+\n+div.messageLeftTooltip {\n+ transform: translate(0%, -50%);\n+}\n+div.messageRightTooltip {\n+ transform: translate(0%, -50%);\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip.react.js",
"new_path": "web/chat/tooltip.react.js",
"diff": "import classNames from 'classnames';\nimport * as React from 'react';\n-import css from './chat-message-list.css';\nimport type { ItemAndContainerPositionInfo } from './position-types';\nimport { findTooltipPosition, type TooltipPosition } from './tooltip-utils';\n+import css from './tooltip.css';\ntype Style = {\n+left?: number,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [16/n] [refactor] move tool tip css into its own module
Summary: move tooltip styles from chat-message-list to tooltip
Test Plan: make sure page renders and styles look the same as production
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2810 |
129,179 | 10.01.2022 15:36:19 | 18,000 | 5fcac902486961c612aa60a66585ecf3e34f857b | [web] [18/n] [refactor] move robo text css from chat-message-list to robotext-message
Summary: move robo text files to their own module
Test Plan: make sure local and production look the same and aren't broken <beforescreenshot> <afterscreenshot>
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -94,20 +94,6 @@ div.conversationHeader {\ndiv.conversationHeader:last-child {\npadding-top: 6px;\n}\n-\n-div.robotextContainer {\n- text-align: center;\n- color: #333333;\n- padding: 6px 0;\n- margin: 0 40px 5px 40px;\n- font-size: 15px;\n-}\n-div.innerRobotextContainer {\n- display: inline-flex;\n- position: relative;\n- word-break: break-word;\n-}\n-\ndiv.messageLeftTooltip:after {\ntop: 7px;\nright: -14px;\n@@ -332,10 +318,6 @@ div.imageGrid > span.multimedia:nth-last-child(n + 5):first-child ~ * {\ndiv.sidebarMarginBottom {\nmargin-bottom: 8px;\n}\n-div.sidebarMarginTop {\n- margin-top: 4px;\n- margin-bottom: -8px;\n-}\nsvg.inlineSidebarIcon {\ncolor: #666666;\n}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/chat/robotext-message.css",
"diff": "+div.robotextContainer {\n+ text-align: center;\n+ color: #333333;\n+ padding: 6px 0;\n+ margin: 0 40px 5px 40px;\n+ font-size: 15px;\n+}\n+div.innerRobotextContainer {\n+ display: inline-flex;\n+ position: relative;\n+ word-break: break-word;\n+}\n+div.sidebarMarginTop {\n+ margin-top: 4px;\n+ margin-bottom: -8px;\n+}\n+div.messageActionLinks {\n+ position: absolute;\n+ display: flex;\n+ top: 0;\n+ bottom: 0;\n+ align-items: center;\n+ color: gray;\n+ padding: 0 6px;\n+}\n+div.viewerMessageActionLinks {\n+ right: 100%;\n+}\n+div.nonViewerMessageActionLinks {\n+ left: 100%;\n+}\n+div.messageActionLinks > div + div {\n+ margin-left: 4px;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/robotext-message.react.js",
"new_path": "web/chat/robotext-message.react.js",
"diff": "@@ -15,13 +15,13 @@ import Markdown from '../markdown/markdown.react';\nimport { linkRules } from '../markdown/rules.react';\nimport { useSelector } from '../redux/redux-utils';\nimport { updateNavInfoActionType } from '../types/nav-types';\n-import css from './chat-message-list.css';\nimport { InlineSidebar } from './inline-sidebar.react';\nimport MessageActionTooltip from './message-action-button';\nimport type {\nMessagePositionInfo,\nOnMessagePositionWithContainerInfo,\n} from './position-types';\n+import css from './robotext-message.css';\nimport { tooltipPositions } from './tooltip-utils';\nconst availableTooltipPositionsForRobotext = [\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [18/n] [refactor] move robo text css from chat-message-list to robotext-message
Summary: move robo text files to their own module
Test Plan: make sure local and production look the same and aren't broken <beforescreenshot> <afterscreenshot>
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2812 |
129,179 | 11.01.2022 12:25:20 | 18,000 | 2120d8ce800217b886ab6f5bc4b87e6e9a7503c8 | [web] [19/n] [refactor] chat-input-bar styles moved to chat-input-bar
Summary:
refactor styles, move input bar styles to it's own modular css file
Production: {F7906}
Local: {F7914}
Test Plan: input bar looks and works the same as in production.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/chat/chat-input-bar.css",
"diff": "+div.inputBar {\n+ display: flex;\n+ flex-direction: column;\n+ border-top: 2px solid #e4e4e4;\n+}\n+div.inputBarTextInput {\n+ display: flex;\n+ padding: 16px;\n+ align-items: center;\n+ flex-shrink: 0;\n+}\n+div.inputBarTextInput > textarea {\n+ flex: 1;\n+ display: flex;\n+ border: none;\n+ font-size: 14px;\n+ resize: none;\n+ padding-left: 12px;\n+}\n+div.inputBarTextInput > textarea:focus {\n+ outline: none;\n+}\n+div.joinButtonContainer > a {\n+ margin: 8px;\n+ padding: 3px 0 5px 0;\n+ display: flex;\n+ border-radius: 8px;\n+ justify-content: center;\n+ cursor: pointer;\n+}\n+span.joinButtonText {\n+ font-size: 18px;\n+ color: white;\n+ text-align: center;\n+ margin-inline: 6px;\n+}\n+span.explanation {\n+ color: #777777;\n+ text-align: center;\n+ padding-top: 4px;\n+ padding-bottom: 8px;\n+}\n+a.multimediaUpload {\n+ cursor: pointer;\n+ position: relative;\n+}\n+a.multimediaUpload > input[type='file'] {\n+ visibility: hidden;\n+ position: absolute;\n+ top: 0;\n+ bottom: 0;\n+ left: 0;\n+ right: 0;\n+ margin: 0;\n+ padding: 0;\n+}\n+div.previews {\n+ display: flex;\n+ overflow-x: auto;\n+ white-space: nowrap;\n+}\n+div.previews > span.multimedia {\n+ margin: 10px;\n+}\n+div.previews > span.multimedia > span.multimediaImage > img {\n+ max-height: 200px;\n+ max-width: 200px;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -46,7 +46,7 @@ import Multimedia from '../media/multimedia.react';\nimport { useSelector } from '../redux/redux-utils';\nimport { nonThreadCalendarQuery } from '../selectors/nav-selectors';\nimport SWMansionIcon from '../SWMansionIcon.react';\n-import css from './chat-message-list.css';\n+import css from './chat-input-bar.css';\ntype BaseProps = {\n+threadInfo: ThreadInfo,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -35,50 +35,6 @@ div.message {\nflex-shrink: 0;\n}\n-div.inputBar {\n- display: flex;\n- flex-direction: column;\n- border-top: 2px solid #e4e4e4;\n-}\n-div.inputBarTextInput {\n- display: flex;\n- padding: 16px;\n- align-items: center;\n- flex-shrink: 0;\n-}\n-div.inputBarTextInput > textarea {\n- flex: 1;\n- display: flex;\n- border: none;\n- font-size: 14px;\n- resize: none;\n- padding-left: 12px;\n-}\n-div.inputBarTextInput > textarea:focus {\n- outline: none;\n-}\n-\n-div.joinButtonContainer > a {\n- margin: 8px;\n- padding: 3px 0 5px 0;\n- display: flex;\n- border-radius: 8px;\n- justify-content: center;\n- cursor: pointer;\n-}\n-span.joinButtonText {\n- font-size: 18px;\n- color: white;\n- text-align: center;\n- margin-inline: 6px;\n-}\n-span.explanation {\n- color: #777777;\n- text-align: center;\n- padding-top: 4px;\n- padding-bottom: 8px;\n-}\n-\ndiv.loading {\ntext-align: center;\npadding: 12px;\n@@ -240,33 +196,6 @@ a.retrySend {\npadding: 0 3px;\ncursor: pointer;\n}\n-a.multimediaUpload {\n- cursor: pointer;\n- position: relative;\n-}\n-a.multimediaUpload > input[type='file'] {\n- visibility: hidden;\n- position: absolute;\n- top: 0;\n- bottom: 0;\n- left: 0;\n- right: 0;\n- margin: 0;\n- padding: 0;\n-}\n-\n-div.previews {\n- display: flex;\n- overflow-x: auto;\n- white-space: nowrap;\n-}\n-div.previews > span.multimedia {\n- margin: 10px;\n-}\n-div.previews > span.multimedia > span.multimediaImage > img {\n- max-height: 200px;\n- max-width: 200px;\n-}\ndiv.messageBox > div.imageGrid {\ndisplay: grid;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [19/n] [refactor] chat-input-bar styles moved to chat-input-bar
Summary:
refactor styles, move input bar styles to it's own modular css file
Production: {F7906}
Local: {F7914}
Test Plan: input bar looks and works the same as in production.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2813 |
129,179 | 12.01.2022 12:43:34 | 18,000 | e803eec84dd0cff9ea30e4fc2551848d4a99c7c0 | [web] [4/n] [darktheme] SquadCal --> to Comm branding in header
Summary: Add Comm branding to header
Test Plan: header should look like this <add image>
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -178,7 +178,7 @@ class App extends React.PureComponent<Props, State> {\n<React.Fragment>\n<header className={css['header']}>\n<div className={css['main-header']}>\n- <h1>SquadCal</h1>\n+ <h1>Comm</h1>\n<ul className={css['nav-bar']}>\n<li className={calendarNavClasses}>\n<div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] [darktheme] SquadCal --> to Comm branding in header
Summary: Add Comm branding to header
Test Plan: header should look like this <add image>
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2830 |
129,179 | 13.01.2022 16:22:07 | 18,000 | 0cb63db631dab2ed8b96ad40e2d874475ffeaa26 | [web] [typography] import heavier fonts from font source
Summary: Add our other font weights
Test Plan: fonts should render with additional weight, look at the docs:
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "// @flow\nimport '@fontsource/inter';\n+import '@fontsource/inter/500.css';\n+import '@fontsource/inter/600.css';\nimport { config as faConfig } from '@fortawesome/fontawesome-svg-core';\nimport { faCalendar, faComments } from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [typography] import heavier fonts from font source
Summary: Add our other font weights
Test Plan: fonts should render with additional weight, look at the docs: https://fontsource.org/docs/getting-started
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2859 |
129,190 | 14.01.2022 09:45:13 | -3,600 | dcb5b15fa531b4eae9d1691188802e4093eda268 | [services] change server to service in commands
Summary: This makes commands for services consistent
Test Plan: Run changed commands
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"build-all\": \"./scripts/build_base_image.sh\",\n\"build-base-image\": \"./scripts/build_base_image.sh base\",\n\"build-tunnelbroker-base\": \"./scripts/build_base_image.sh tunnelbroker-base\",\n- \"run-tunnelbroker-server\": \"./scripts/run_server_image.sh tunnelbroker\",\n- \"test-tunnelbroker-server\": \"./scripts/test_service.sh tunnelbroker\",\n+ \"run-tunnelbroker-service\": \"./scripts/run_server_image.sh tunnelbroker\",\n+ \"test-tunnelbroker-service\": \"./scripts/test_service.sh tunnelbroker\",\n\"build-backup-base\": \"./scripts/build_base_image.sh backup-base\",\n- \"run-backup-server\": \"./scripts/run_server_image.sh backup\",\n- \"test-backup-server\": \"./scripts/test_service.sh backup\",\n- \"run-backup-server-dev-mode\": \"export COMM_SERVICES_DEV_MODE=1 && ./scripts/run_server_image.sh backup\",\n- \"test-backup-server-dev-mode\": \"export COMM_SERVICES_DEV_MODE=1 && ./scripts/test_service.sh backup\",\n+ \"run-backup-service\": \"./scripts/run_server_image.sh backup\",\n+ \"test-backup-service\": \"./scripts/test_service.sh backup\",\n+ \"run-backup-service-dev-mode\": \"export COMM_SERVICES_DEV_MODE=1 && ./scripts/run_server_image.sh backup\",\n+ \"test-backup-service-dev-mode\": \"export COMM_SERVICES_DEV_MODE=1 && ./scripts/test_service.sh backup\",\n\"build-blob-base\": \"./scripts/build_base_image.sh blob-base\",\n- \"run-blob-server\": \"./scripts/run_server_image.sh blob\",\n+ \"run-blob-service\": \"./scripts/run_server_image.sh blob\",\n\"test-blob-service\": \"./scripts/test_service.sh blob\",\n\"run-all-services\": \"./scripts/run_all_services.sh\",\n\"test-all-services\": \"./scripts/test_all_services.sh\",\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] change server to service in commands
Summary: This makes commands for services consistent
Test Plan: Run changed commands
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2793 |
129,179 | 13.01.2022 13:41:12 | 18,000 | 77c3a574855accfdf0c05d5d2cb27978ff5d2e93 | [web] update meta data SquadCal --> Comm
Summary:
update web meta data SquadCal --> Comm
Will swap out favicons in the next diff
Test Plan: {F8323}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -242,8 +242,8 @@ async function websiteResponder(\n/>\n<link rel=\"manifest\" href=\"site.webmanifest\" />\n<link rel=\"mask-icon\" href=\"safari-pinned-tab.svg\" color=\"#b91d47\" />\n- <meta name=\"apple-mobile-web-app-title\" content=\"SquadCal\" />\n- <meta name=\"application-name\" content=\"SquadCal\" />\n+ <meta name=\"apple-mobile-web-app-title\" content=\"Comm\" />\n+ <meta name=\"application-name\" content=\"Comm\" />\n<meta name=\"msapplication-TileColor\" content=\"#b91d47\" />\n<meta name=\"theme-color\" content=\"#b91d47\" />\n</head>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/title/getTitle.js",
"new_path": "web/title/getTitle.js",
"diff": "// @flow\nconst getTitle = (count: number): string => {\n- const title = 'SquadCal';\n+ const title = 'Comm';\nif (count > 0) {\nreturn `${title} (${count})`;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] update meta data SquadCal --> Comm
Summary:
update web meta data SquadCal --> Comm
Will swap out favicons in the next diff
Test Plan: {F8323}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2855 |
129,179 | 12.01.2022 12:11:07 | 18,000 | cb443482e07290ea93e35c90807d89126705c262 | [web] [2/n] [darktheme] import colors
Summary: Imports the color swatch into the web app
Test Plan: look in the console, you should see the colors loaded in dev tools {F8069}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -4,6 +4,7 @@ import '@fontsource/inter';\nimport '@fontsource/inter/500.css';\nimport '@fontsource/inter/600.css';\nimport 'basscss/css/basscss.min.css';\n+import './theme.css';\nimport { config as faConfig } from '@fortawesome/fontawesome-svg-core';\nimport { faCalendar, faComments } from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] [darktheme] import colors
Summary: Imports the color swatch into the web app
Test Plan: look in the console, you should see the colors loaded in dev tools {F8069}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2828 |
129,196 | 04.01.2022 10:37:44 | -3,600 | bc3d324b8351a9cf7825205986b902c3131ff63e | Use SingleLine component for thread settings notifications.
Summary: Solve issue eng-299
Test Plan: Run application on iOS and Android (small and big size) emulators to see that bug described in disappears.
Reviewers: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-home-notifs.react.js",
"new_path": "native/chat/settings/thread-settings-home-notifs.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, View, Switch } from 'react-native';\n+import { View, Switch } from 'react-native';\nimport {\nupdateSubscriptionActionTypes,\n@@ -18,6 +18,7 @@ import {\nuseDispatchActionPromise,\n} from 'lib/utils/action-utils';\n+import { SingleLine } from '../../components/single-line.react';\nimport { useStyles } from '../../themes/colors';\ntype BaseProps = {\n@@ -46,9 +47,12 @@ class ThreadSettingsHomeNotifs extends React.PureComponent<Props, State> {\n}\nrender() {\n+ const componentLabel = 'Background';\nreturn (\n<View style={this.props.styles.row}>\n- <Text style={this.props.styles.label}>Background</Text>\n+ <SingleLine style={this.props.styles.label} adjustsFontSizeToFit={true}>\n+ {componentLabel}\n+ </SingleLine>\n<View style={this.props.styles.currentValue}>\n<Switch\nvalue={this.state.currentValue}\n@@ -76,7 +80,6 @@ class ThreadSettingsHomeNotifs extends React.PureComponent<Props, State> {\nconst unboundStyles = {\ncurrentValue: {\nalignItems: 'flex-end',\n- flex: 1,\nmargin: 0,\npaddingLeft: 4,\npaddingRight: 0,\n@@ -85,7 +88,7 @@ const unboundStyles = {\nlabel: {\ncolor: 'panelForegroundTertiaryLabel',\nfontSize: 16,\n- width: 96,\n+ flex: 1,\n},\nrow: {\nalignItems: 'center',\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-push-notifs.react.js",
"new_path": "native/chat/settings/thread-settings-push-notifs.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { Text, View, Switch } from 'react-native';\n+import { View, Switch } from 'react-native';\nimport {\nupdateSubscriptionActionTypes,\n@@ -18,6 +18,7 @@ import {\nuseDispatchActionPromise,\n} from 'lib/utils/action-utils';\n+import { SingleLine } from '../../components/single-line.react';\nimport { useStyles } from '../../themes/colors';\ntype BaseProps = {\n@@ -46,9 +47,12 @@ class ThreadSettingsPushNotifs extends React.PureComponent<Props, State> {\n}\nrender() {\n+ const componentLabel = 'Push notifs';\nreturn (\n<View style={this.props.styles.row}>\n- <Text style={this.props.styles.label}>Push notifs</Text>\n+ <SingleLine style={this.props.styles.label} adjustsFontSizeToFit={true}>\n+ {componentLabel}\n+ </SingleLine>\n<View style={this.props.styles.currentValue}>\n<Switch\nvalue={this.state.currentValue}\n@@ -76,7 +80,6 @@ class ThreadSettingsPushNotifs extends React.PureComponent<Props, State> {\nconst unboundStyles = {\ncurrentValue: {\nalignItems: 'flex-end',\n- flex: 1,\nmargin: 0,\npaddingLeft: 4,\npaddingRight: 0,\n@@ -85,7 +88,7 @@ const unboundStyles = {\nlabel: {\ncolor: 'panelForegroundTertiaryLabel',\nfontSize: 16,\n- width: 96,\n+ flex: 1,\n},\nrow: {\nalignItems: 'center',\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Use SingleLine component for thread settings notifications.
Summary: Solve issue eng-299
Test Plan: Run application on iOS and Android (small and big size) emulators to see that bug described in ENG-299 disappears.
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2770 |
129,187 | 13.01.2022 02:49:53 | 18,000 | a4b1a03f194676f99d1d483beffa05725eb6ffd4 | [native] Rename ComposeThread to ComposeSubchannel
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-router.js",
"new_path": "native/chat/chat-router.js",
"diff": "@@ -27,7 +27,7 @@ import {\n} from '../navigation/navigation-utils';\nimport {\nChatThreadListRouteName,\n- ComposeThreadRouteName,\n+ ComposeSubchannelRouteName,\n} from '../navigation/route-names';\nimport { createNavigateToThreadAction } from './message-list-types';\n@@ -127,7 +127,7 @@ function ChatRouter(\nconst clearedState = removeScreensFromStack(\nlastState,\n(route: Route<>) =>\n- route.name === ComposeThreadRouteName ? 'remove' : 'break',\n+ route.name === ComposeSubchannelRouteName ? 'remove' : 'break',\n);\nconst navigateAction = CommonActions.navigate(\ncreateNavigateToThreadAction({ threadInfo }),\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/chat.react.js",
"new_path": "native/chat/chat.react.js",
"diff": "@@ -30,7 +30,7 @@ import { InputStateContext } from '../input/input-state';\nimport HeaderBackButton from '../navigation/header-back-button.react';\nimport { defaultStackScreenOptions } from '../navigation/options';\nimport {\n- ComposeThreadRouteName,\n+ ComposeSubchannelRouteName,\nDeleteThreadRouteName,\nThreadSettingsRouteName,\nMessageListRouteName,\n@@ -45,8 +45,8 @@ import { useColors, useStyles } from '../themes/colors';\nimport BackgroundChatThreadList from './background-chat-thread-list.react';\nimport ChatHeader from './chat-header.react';\nimport ChatRouter, { type ChatRouterNavigationProp } from './chat-router';\n+import ComposeSubchannel from './compose-subchannel.react';\nimport ComposeThreadButton from './compose-thread-button.react';\n-import ComposeThread from './compose-thread.react';\nimport HomeChatThreadList from './home-chat-thread-list.react';\nimport MessageListContainer from './message-list-container.react';\nimport MessageListHeaderTitle from './message-list-header-title.react';\n@@ -141,13 +141,14 @@ function ChatNavigator({\nscreenOptions,\n});\n- // Clear ComposeThread screens after each message is sent. If a user goes to\n- // ComposeThread to create a new thread, but finds an existing one and uses it\n- // instead, we can assume the intent behind opening ComposeThread is resolved\n+ // Clear ComposeSubchannel screens after each message is sent. If a user goes\n+ // to ComposeSubchannel to create a new thread, but finds an existing one and\n+ // uses it instead, we can assume the intent behind opening ComposeSubchannel\n+ // is resolved\nconst inputState = React.useContext(InputStateContext);\ninvariant(inputState, 'InputState should be set in ChatNavigator');\nconst clearComposeScreensAfterMessageSend = React.useCallback(() => {\n- navigation.clearScreens([ComposeThreadRouteName]);\n+ navigation.clearScreens([ComposeSubchannelRouteName]);\n}, [navigation]);\nReact.useEffect(() => {\ninputState.registerSendCallback(clearComposeScreensAfterMessageSend);\n@@ -281,8 +282,8 @@ export default function ChatComponent(props: { ... }): React.Node {\noptions={messageListOptions}\n/>\n<Chat.Screen\n- name={ComposeThreadRouteName}\n- component={ComposeThread}\n+ name={ComposeSubchannelRouteName}\n+ component={ComposeSubchannel}\noptions={composeThreadOptions}\n/>\n<Chat.Screen\n"
},
{
"change_type": "RENAME",
"old_path": "native/chat/compose-thread.react.js",
"new_path": "native/chat/compose-subchannel.react.js",
"diff": "@@ -57,14 +57,14 @@ const tagInputProps = {\nreturnKeyType: 'go',\n};\n-export type ComposeThreadParams = {\n+export type ComposeSubchannelParams = {\n+threadType: ThreadType,\n+parentThreadInfo: ThreadInfo,\n};\ntype BaseProps = {\n- +navigation: ChatNavigationProp<'ComposeThread'>,\n- +route: NavigationRoute<'ComposeThread'>,\n+ +navigation: ChatNavigationProp<'ComposeSubchannel'>,\n+ +route: NavigationRoute<'ComposeSubchannel'>,\n};\ntype Props = {\n...BaseProps,\n@@ -88,7 +88,7 @@ type State = {\n+userInfoInputArray: $ReadOnlyArray<AccountUserInfo>,\n};\ntype PropsAndState = { ...Props, ...State };\n-class ComposeThread extends React.PureComponent<Props, State> {\n+class ComposeSubchannel extends React.PureComponent<Props, State> {\nstate: State = {\nusernameInputText: '',\nuserInfoInputArray: [],\n@@ -136,7 +136,7 @@ class ComposeThread extends React.PureComponent<Props, State> {\n}\nstatic getParentThreadInfo(props: {\n- route: NavigationRoute<'ComposeThread'>,\n+ route: NavigationRoute<'ComposeSubchannel'>,\n...\n}): ThreadInfo {\nreturn props.route.params.parentThreadInfo;\n@@ -148,7 +148,7 @@ class ComposeThread extends React.PureComponent<Props, State> {\n(propsAndState: PropsAndState) => propsAndState.userSearchIndex,\n(propsAndState: PropsAndState) => propsAndState.userInfoInputArray,\n(propsAndState: PropsAndState) =>\n- ComposeThread.getParentThreadInfo(propsAndState),\n+ ComposeSubchannel.getParentThreadInfo(propsAndState),\n(propsAndState: PropsAndState) => propsAndState.communityThreadInfo,\n(propsAndState: PropsAndState) => propsAndState.route.params.threadType,\n(\n@@ -177,7 +177,7 @@ class ComposeThread extends React.PureComponent<Props, State> {\nexistingThreadsSelector = createSelector(\n(propsAndState: PropsAndState) =>\n- ComposeThread.getParentThreadInfo(propsAndState),\n+ ComposeSubchannel.getParentThreadInfo(propsAndState),\n(propsAndState: PropsAndState) => propsAndState.threadInfos,\n(propsAndState: PropsAndState) => propsAndState.userInfoInputArray,\n(\n@@ -231,7 +231,7 @@ class ComposeThread extends React.PureComponent<Props, State> {\n</View>\n);\n}\n- const parentThreadInfo = ComposeThread.getParentThreadInfo(this.props);\n+ const parentThreadInfo = ComposeSubchannel.getParentThreadInfo(this.props);\nconst inputProps = {\n...tagInputProps,\nonSubmitEditing: this.onPressCreateThread,\n@@ -334,7 +334,9 @@ class ComposeThread extends React.PureComponent<Props, State> {\nconst initialMemberIDs = this.state.userInfoInputArray.map(\n(userInfo: AccountUserInfo) => userInfo.id,\n);\n- const parentThreadInfo = ComposeThread.getParentThreadInfo(this.props);\n+ const parentThreadInfo = ComposeSubchannel.getParentThreadInfo(\n+ this.props,\n+ );\nconst query = this.props.calendarQuery();\ninvariant(\nthreadType === 3 ||\n@@ -434,8 +436,8 @@ const unboundStyles = {\n},\n};\n-const ConnectedComposeThread: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n- function ConnectedComposeThread(props: BaseProps) {\n+const ConnectedComposeSubchannel: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n+ function ConnectedComposeSubchannel(props: BaseProps) {\nconst parentThreadInfoID = props.route.params.parentThreadInfo.id;\nconst reduxParentThreadInfo = useSelector(\n@@ -459,7 +461,7 @@ const ConnectedComposeThread: React.ComponentType<BaseProps> = React.memo<BasePr\nconst dispatchActionPromise = useDispatchActionPromise();\nconst callNewThread = useServerCall(newThread);\nreturn (\n- <ComposeThread\n+ <ComposeSubchannel\n{...props}\nparentThreadInfo={reduxParentThreadInfo}\ncommunityThreadInfo={communityThreadInfo}\n@@ -477,4 +479,4 @@ const ConnectedComposeThread: React.ComponentType<BaseProps> = React.memo<BasePr\n},\n);\n-export default ConnectedComposeThread;\n+export default ConnectedComposeSubchannel;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/compose-subthread-modal.react.js",
"new_path": "native/chat/settings/compose-subthread-modal.react.js",
"diff": "@@ -12,7 +12,7 @@ import Modal from '../../components/modal.react';\nimport SWMansionIcon from '../../components/swmansion-icon.react';\nimport type { RootNavigationProp } from '../../navigation/root-navigator.react';\nimport type { NavigationRoute } from '../../navigation/route-names';\n-import { ComposeThreadRouteName } from '../../navigation/route-names';\n+import { ComposeSubchannelRouteName } from '../../navigation/route-names';\nimport { type Colors, useStyles, useColors } from '../../themes/colors';\nexport type ComposeSubthreadModalParams = {\n@@ -73,13 +73,13 @@ class ComposeSubthreadModal extends React.PureComponent<Props> {\nonPressOpen = () => {\nconst threadInfo = this.props.route.params.threadInfo;\nthis.props.navigation.navigate({\n- name: ComposeThreadRouteName,\n+ name: ComposeSubchannelRouteName,\nparams: {\nthreadType: threadTypes.COMMUNITY_OPEN_SUBTHREAD,\nparentThreadInfo: threadInfo,\n},\nkey:\n- `${ComposeThreadRouteName}|` +\n+ `${ComposeSubchannelRouteName}|` +\n`${threadInfo.id}|${threadTypes.COMMUNITY_OPEN_SUBTHREAD}`,\n});\n};\n@@ -87,13 +87,13 @@ class ComposeSubthreadModal extends React.PureComponent<Props> {\nonPressSecret = () => {\nconst threadInfo = this.props.route.params.threadInfo;\nthis.props.navigation.navigate({\n- name: ComposeThreadRouteName,\n+ name: ComposeSubchannelRouteName,\nparams: {\nthreadType: threadTypes.COMMUNITY_SECRET_SUBTHREAD,\nparentThreadInfo: threadInfo,\n},\nkey:\n- `${ComposeThreadRouteName}|` +\n+ `${ComposeSubchannelRouteName}|` +\n`${threadInfo.id}|${threadTypes.COMMUNITY_SECRET_SUBTHREAD}`,\n});\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/navigation-utils.js",
"new_path": "native/navigation/navigation-utils.js",
"diff": "@@ -9,7 +9,7 @@ import type {\nimport invariant from 'invariant';\nimport {\n- ComposeThreadRouteName,\n+ ComposeSubchannelRouteName,\nAppRouteName,\nthreadRoutes,\n} from './route-names';\n@@ -58,7 +58,7 @@ function getThreadIDFromRoute(\nif (!routes.includes(route.name)) {\nreturn null;\n}\n- if (route.name === ComposeThreadRouteName) {\n+ if (route.name === ComposeSubchannelRouteName) {\nreturn getParentThreadIDFromParams(route.params);\n}\nreturn getThreadIDFromParams(route.params);\n"
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "import type { LeafRoute } from '@react-navigation/native';\nimport type { ThreadPickerModalParams } from '../calendar/thread-picker-modal.react';\n-import type { ComposeThreadParams } from '../chat/compose-thread.react';\n+import type { ComposeSubchannelParams } from '../chat/compose-subchannel.react';\nimport type { ImagePasteModalParams } from '../chat/image-paste-modal.react';\nimport type { MessageListParams } from '../chat/message-list-types';\nimport type { MultimediaMessageTooltipModalParams } from '../chat/multimedia-message-tooltip-modal.react';\n@@ -37,7 +37,7 @@ export const ChatRouteName = 'Chat';\nexport const ChatThreadListRouteName = 'ChatThreadList';\nexport const ColorPickerModalRouteName = 'ColorPickerModal';\nexport const ComposeSubthreadModalRouteName = 'ComposeSubthreadModal';\n-export const ComposeThreadRouteName = 'ComposeThread';\n+export const ComposeSubchannelRouteName = 'ComposeSubchannel';\nexport const CustomServerModalRouteName = 'CustomServerModal';\nexport const DefaultNotificationsPreferencesRouteName = 'DefaultNotifications';\nexport const DeleteAccountRouteName = 'DeleteAccount';\n@@ -112,7 +112,7 @@ export type TabParamList = {\nexport type ChatParamList = {\n+ChatThreadList: void,\n+MessageList: MessageListParams,\n- +ComposeThread: ComposeThreadParams,\n+ +ComposeSubchannel: ComposeSubchannelParams,\n+ThreadSettings: ThreadSettingsParams,\n+DeleteThread: DeleteThreadParams,\n};\n@@ -171,5 +171,5 @@ export const threadRoutes = [\nMessageListRouteName,\nThreadSettingsRouteName,\nDeleteThreadRouteName,\n- ComposeThreadRouteName,\n+ ComposeSubchannelRouteName,\n];\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename ComposeThread to ComposeSubchannel
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Reviewed By: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2841 |
129,187 | 13.01.2022 02:55:24 | 18,000 | 9c8c8d69fc2e879afed5f22fb180dcb43f4bdb8f | [native] Rename ComposeThreadModal to ComposeSubchannelModal
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "native/chat/settings/compose-subthread-modal.react.js",
"new_path": "native/chat/settings/compose-subchannel-modal.react.js",
"diff": "@@ -15,21 +15,21 @@ import type { NavigationRoute } from '../../navigation/route-names';\nimport { ComposeSubchannelRouteName } from '../../navigation/route-names';\nimport { type Colors, useStyles, useColors } from '../../themes/colors';\n-export type ComposeSubthreadModalParams = {\n+export type ComposeSubchannelModalParams = {\npresentedFrom: string,\nthreadInfo: ThreadInfo,\n};\ntype BaseProps = {\n- +navigation: RootNavigationProp<'ComposeSubthreadModal'>,\n- +route: NavigationRoute<'ComposeSubthreadModal'>,\n+ +navigation: RootNavigationProp<'ComposeSubchannelModal'>,\n+ +route: NavigationRoute<'ComposeSubchannelModal'>,\n};\ntype Props = {\n...BaseProps,\n+colors: Colors,\n+styles: typeof unboundStyles,\n};\n-class ComposeSubthreadModal extends React.PureComponent<Props> {\n+class ComposeSubchannelModal extends React.PureComponent<Props> {\nrender() {\nreturn (\n<Modal modalStyle={this.props.styles.modal}>\n@@ -136,13 +136,15 @@ const unboundStyles = {\n},\n};\n-const ConnectedComposeSubthreadModal: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n- function ConnectedComposeSubthreadModal(props: BaseProps) {\n+const ConnectedComposeSubchannelModal: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n+ function ConnectedComposeSubchannelModal(props: BaseProps) {\nconst styles = useStyles(unboundStyles);\nconst colors = useColors();\n- return <ComposeSubthreadModal {...props} styles={styles} colors={colors} />;\n+ return (\n+ <ComposeSubchannelModal {...props} styles={styles} colors={colors} />\n+ );\n},\n);\n-export default ConnectedComposeSubthreadModal;\n+export default ConnectedComposeSubchannelModal;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings-list-action.react.js",
"new_path": "native/chat/settings/thread-settings-list-action.react.js",
"diff": "@@ -75,20 +75,20 @@ function ThreadSettingsAddMember(props: AddMemberProps): React.Node {\n);\n}\n-type AddChildThreadProps = {\n+type AddChildChannelProps = {\n+onPress: () => void,\n};\n-function ThreadSettingsAddSubthread(props: AddChildThreadProps): React.Node {\n+function ThreadSettingsAddSubchannel(props: AddChildChannelProps): React.Node {\nconst styles = useStyles(unboundStyles);\nreturn (\n<View style={styles.addItemRow}>\n<ThreadSettingsListAction\nonPress={props.onPress}\n- text=\"Add subthread\"\n+ text=\"Add subchannel\"\niconName=\"md-add\"\niconStyle={styles.addIcon}\niconSize={20}\n- buttonStyle={styles.addSubthreadButton}\n+ buttonStyle={styles.addSubchannelButton}\nstyles={styles}\n/>\n</View>\n@@ -96,7 +96,7 @@ function ThreadSettingsAddSubthread(props: AddChildThreadProps): React.Node {\n}\nconst unboundStyles = {\n- addSubthreadButton: {\n+ addSubchannelButton: {\npaddingTop: Platform.OS === 'ios' ? 4 : 1,\n},\naddIcon: {\n@@ -148,5 +148,5 @@ const unboundStyles = {\nexport {\nThreadSettingsSeeMore,\nThreadSettingsAddMember,\n- ThreadSettingsAddSubthread,\n+ ThreadSettingsAddSubchannel,\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -47,7 +47,7 @@ import {\nimport type { NavigationRoute } from '../../navigation/route-names';\nimport {\nAddUsersModalRouteName,\n- ComposeSubthreadModalRouteName,\n+ ComposeSubchannelModalRouteName,\n} from '../../navigation/route-names';\nimport { useSelector } from '../../redux/redux-utils';\nimport type { AppState } from '../../redux/state-types';\n@@ -74,7 +74,7 @@ import ThreadSettingsLeaveThread from './thread-settings-leave-thread.react';\nimport {\nThreadSettingsSeeMore,\nThreadSettingsAddMember,\n- ThreadSettingsAddSubthread,\n+ ThreadSettingsAddSubchannel,\n} from './thread-settings-list-action.react';\nimport ThreadSettingsMember from './thread-settings-member.react';\nimport ThreadSettingsName from './thread-settings-name.react';\n@@ -164,7 +164,7 @@ type ChatSettingsItem =\n+lastListItem: boolean,\n}\n| {\n- +itemType: 'addSubthread',\n+ +itemType: 'addSubchannel',\n+key: string,\n}\n| {\n@@ -221,7 +221,7 @@ type Props = {\n};\ntype State = {\n+numMembersShowing: number,\n- +numSubthreadsShowing: number,\n+ +numSubchannelsShowing: number,\n+numSidebarsShowing: number,\n+nameEditValue: ?string,\n+descriptionEditValue: ?string,\n@@ -239,7 +239,7 @@ class ThreadSettings extends React.PureComponent<Props, State> {\ninvariant(threadInfo, 'ThreadInfo should exist when ThreadSettings opened');\nthis.state = {\nnumMembersShowing: itemPageLength,\n- numSubthreadsShowing: itemPageLength,\n+ numSubchannelsShowing: itemPageLength,\nnumSidebarsShowing: itemPageLength,\nnameEditValue: null,\ndescriptionEditValue: null,\n@@ -465,69 +465,69 @@ class ThreadSettings extends React.PureComponent<Props, State> {\n},\n);\n- subthreadsListDataSelector = createSelector(\n+ subchannelsListDataSelector = createSelector(\n(propsAndState: PropsAndState) =>\nThreadSettings.getThreadInfo(propsAndState),\n(propsAndState: PropsAndState) => propsAndState.navigation.navigate,\n(propsAndState: PropsAndState) => propsAndState.childThreadInfos,\n- (propsAndState: PropsAndState) => propsAndState.numSubthreadsShowing,\n+ (propsAndState: PropsAndState) => propsAndState.numSubchannelsShowing,\n(\nthreadInfo: ThreadInfo,\nnavigate: ThreadSettingsNavigate,\nchildThreads: ?$ReadOnlyArray<ThreadInfo>,\n- numSubthreadsShowing: number,\n+ numSubchannelsShowing: number,\n) => {\nconst listData: ChatSettingsItem[] = [];\n- const subthreads =\n+ const subchannels =\nchildThreads?.filter(\nchildThreadInfo => childThreadInfo.type !== threadTypes.SIDEBAR,\n) ?? [];\n- const canCreateSubthreads = threadHasPermission(\n+ const canCreateSubchannels = threadHasPermission(\nthreadInfo,\nthreadPermissions.CREATE_SUBTHREADS,\n);\n- if (subthreads.length === 0 && !canCreateSubthreads) {\n+ if (subchannels.length === 0 && !canCreateSubchannels) {\nreturn listData;\n}\nlistData.push({\nitemType: 'header',\n- key: 'subthreadHeader',\n- title: 'Subthreads',\n+ key: 'subchannelHeader',\n+ title: 'Subchannels',\ncategoryType: 'unpadded',\n});\n- if (canCreateSubthreads) {\n+ if (canCreateSubchannels) {\nlistData.push({\n- itemType: 'addSubthread',\n- key: 'addSubthread',\n+ itemType: 'addSubchannel',\n+ key: 'addSubchannel',\n});\n}\n- const numItems = Math.min(numSubthreadsShowing, subthreads.length);\n+ const numItems = Math.min(numSubchannelsShowing, subchannels.length);\nfor (let i = 0; i < numItems; i++) {\n- const subthreadInfo = subthreads[i];\n+ const subchannelInfo = subchannels[i];\nlistData.push({\nitemType: 'childThread',\n- key: `childThread${subthreadInfo.id}`,\n- threadInfo: subthreadInfo,\n- firstListItem: i === 0 && !canCreateSubthreads,\n- lastListItem: i === numItems - 1 && numItems === subthreads.length,\n+ key: `childThread${subchannelInfo.id}`,\n+ threadInfo: subchannelInfo,\n+ firstListItem: i === 0 && !canCreateSubchannels,\n+ lastListItem: i === numItems - 1 && numItems === subchannels.length,\n});\n}\n- if (numItems < subthreads.length) {\n+ if (numItems < subchannels.length) {\nlistData.push({\nitemType: 'seeMore',\n- key: 'seeMoreSubthreads',\n- onPress: this.onPressSeeMoreSubthreads,\n+ key: 'seeMoreSubchannels',\n+ onPress: this.onPressSeeMoreSubchannels,\n});\n}\nlistData.push({\nitemType: 'footer',\n- key: 'subthreadFooter',\n+ key: 'subchannelFooter',\ncategoryType: 'unpadded',\n});\n@@ -689,14 +689,14 @@ class ThreadSettings extends React.PureComponent<Props, State> {\nthreadInfo,\nthreadPermissions.EDIT_PERMISSIONS,\n);\n- const canCreateSubthreadsInParent = threadHasPermission(\n+ const canCreateSubchannelsInParent = threadHasPermission(\nparentThreadInfo,\nthreadPermissions.CREATE_SUBTHREADS,\n);\nconst canPromoteSidebar =\nthreadInfo.type === threadTypes.SIDEBAR &&\ncanChangeThreadType &&\n- canCreateSubthreadsInParent;\n+ canCreateSubchannelsInParent;\nif (canPromoteSidebar) {\nbuttons.push({\nitemType: 'promoteSidebar',\n@@ -797,19 +797,19 @@ class ThreadSettings extends React.PureComponent<Props, State> {\nlistDataSelector = createSelector(\nthis.threadBasicsListDataSelector,\n- this.subthreadsListDataSelector,\n+ this.subchannelsListDataSelector,\nthis.sidebarsListDataSelector,\nthis.threadMembersListDataSelector,\nthis.actionsListDataSelector,\n(\nthreadBasicsListData: ChatSettingsItem[],\n- subthreadsListData: ChatSettingsItem[],\n+ subchannelsListData: ChatSettingsItem[],\nsidebarsListData: ChatSettingsItem[],\nthreadMembersListData: ChatSettingsItem[],\nactionsListData: ChatSettingsItem[],\n) => [\n...threadBasicsListData,\n- ...subthreadsListData,\n+ ...subchannelsListData,\n...sidebarsListData,\n...threadMembersListData,\n...actionsListData,\n@@ -939,9 +939,9 @@ class ThreadSettings extends React.PureComponent<Props, State> {\nlastListItem={item.lastListItem}\n/>\n);\n- } else if (item.itemType === 'addSubthread') {\n+ } else if (item.itemType === 'addSubchannel') {\nreturn (\n- <ThreadSettingsAddSubthread onPress={this.onPressComposeSubthread} />\n+ <ThreadSettingsAddSubchannel onPress={this.onPressComposeSubchannel} />\n);\n} else if (item.itemType === 'member') {\nreturn (\n@@ -1009,9 +1009,9 @@ class ThreadSettings extends React.PureComponent<Props, State> {\nthis.setState({ descriptionTextHeight: height });\n};\n- onPressComposeSubthread = () => {\n+ onPressComposeSubchannel = () => {\nconst threadInfo = ThreadSettings.getThreadInfo(this.props);\n- this.props.navigation.navigate(ComposeSubthreadModalRouteName, {\n+ this.props.navigation.navigate(ComposeSubchannelModalRouteName, {\npresentedFrom: this.props.route.key,\nthreadInfo,\n});\n@@ -1031,9 +1031,9 @@ class ThreadSettings extends React.PureComponent<Props, State> {\n}));\n};\n- onPressSeeMoreSubthreads = () => {\n+ onPressSeeMoreSubchannels = () => {\nthis.setState(prevState => ({\n- numSubthreadsShowing: prevState.numSubthreadsShowing + itemPageLength,\n+ numSubchannelsShowing: prevState.numSubchannelsShowing + itemPageLength,\n}));\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/root-navigator.react.js",
"new_path": "native/navigation/root-navigator.react.js",
"diff": "@@ -19,7 +19,7 @@ import ThreadPickerModal from '../calendar/thread-picker-modal.react';\nimport ImagePasteModal from '../chat/image-paste-modal.react';\nimport AddUsersModal from '../chat/settings/add-users-modal.react';\nimport ColorPickerModal from '../chat/settings/color-picker-modal.react';\n-import ComposeSubthreadModal from '../chat/settings/compose-subthread-modal.react';\n+import ComposeSubchannelModal from '../chat/settings/compose-subchannel-modal.react';\nimport SidebarListModal from '../chat/sidebar-list-modal.react';\nimport CustomServerModal from '../profile/custom-server-modal.react';\nimport AppNavigator from './app-navigator.react';\n@@ -34,7 +34,7 @@ import {\nAddUsersModalRouteName,\nCustomServerModalRouteName,\nColorPickerModalRouteName,\n- ComposeSubthreadModalRouteName,\n+ ComposeSubchannelModalRouteName,\nSidebarListModalRouteName,\ntype ScreenParamList,\ntype RootParamList,\n@@ -169,8 +169,8 @@ function RootComponent(): React.Node {\noptions={modalOverlayScreenOptions}\n/>\n<Root.Screen\n- name={ComposeSubthreadModalRouteName}\n- component={ComposeSubthreadModal}\n+ name={ComposeSubchannelModalRouteName}\n+ component={ComposeSubchannelModal}\noptions={modalOverlayScreenOptions}\n/>\n<Root.Screen\n"
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/route-names.js",
"new_path": "native/navigation/route-names.js",
"diff": "@@ -10,7 +10,7 @@ import type { MultimediaMessageTooltipModalParams } from '../chat/multimedia-mes\nimport type { RobotextMessageTooltipModalParams } from '../chat/robotext-message-tooltip-modal.react';\nimport type { AddUsersModalParams } from '../chat/settings/add-users-modal.react';\nimport type { ColorPickerModalParams } from '../chat/settings/color-picker-modal.react';\n-import type { ComposeSubthreadModalParams } from '../chat/settings/compose-subthread-modal.react';\n+import type { ComposeSubchannelModalParams } from '../chat/settings/compose-subchannel-modal.react';\nimport type { DeleteThreadParams } from '../chat/settings/delete-thread.react';\nimport type { ThreadSettingsMemberTooltipModalParams } from '../chat/settings/thread-settings-member-tooltip-modal.react';\nimport type { ThreadSettingsParams } from '../chat/settings/thread-settings.react';\n@@ -36,7 +36,7 @@ export const CameraModalRouteName = 'CameraModal';\nexport const ChatRouteName = 'Chat';\nexport const ChatThreadListRouteName = 'ChatThreadList';\nexport const ColorPickerModalRouteName = 'ColorPickerModal';\n-export const ComposeSubthreadModalRouteName = 'ComposeSubthreadModal';\n+export const ComposeSubchannelModalRouteName = 'ComposeSubchannelModal';\nexport const ComposeSubchannelRouteName = 'ComposeSubchannel';\nexport const CustomServerModalRouteName = 'CustomServerModal';\nexport const DefaultNotificationsPreferencesRouteName = 'DefaultNotifications';\n@@ -75,7 +75,7 @@ export type RootParamList = {\n+AddUsersModal: AddUsersModalParams,\n+CustomServerModal: CustomServerModalParams,\n+ColorPickerModal: ColorPickerModalParams,\n- +ComposeSubthreadModal: ComposeSubthreadModalParams,\n+ +ComposeSubchannelModal: ComposeSubchannelModalParams,\n+SidebarListModal: SidebarListModalParams,\n+ImagePasteModal: ImagePasteModalParams,\n};\n@@ -164,7 +164,7 @@ export const scrollBlockingModals = [\nexport const chatRootModals = [\nAddUsersModalRouteName,\nColorPickerModalRouteName,\n- ComposeSubthreadModalRouteName,\n+ ComposeSubchannelModalRouteName,\n];\nexport const threadRoutes = [\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Rename ComposeThreadModal to ComposeSubchannelModal
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Reviewed By: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2842 |
129,187 | 13.01.2022 02:58:43 | 18,000 | c3fbf09073495b1e3bb4a71c2fae7cf26d2bf957 | Rename CREATE_SUBTHREADS to CREATE_SUBCHANNELS
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -861,7 +861,7 @@ const permissionsDisabledByBlockArray = [\nthreadPermissions.EDIT_THREAD_NAME,\nthreadPermissions.EDIT_THREAD_COLOR,\nthreadPermissions.EDIT_THREAD_DESCRIPTION,\n- threadPermissions.CREATE_SUBTHREADS,\n+ threadPermissions.CREATE_SUBCHANNELS,\nthreadPermissions.CREATE_SIDEBARS,\nthreadPermissions.JOIN_THREAD,\nthreadPermissions.EDIT_PERMISSIONS,\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -80,7 +80,7 @@ export const threadPermissions = Object.freeze({\nEDIT_THREAD_DESCRIPTION: 'edit_thread_description',\nEDIT_THREAD_COLOR: 'edit_thread_color',\nDELETE_THREAD: 'delete_thread',\n- CREATE_SUBTHREADS: 'create_subthreads',\n+ CREATE_SUBCHANNELS: 'create_subthreads',\nCREATE_SIDEBARS: 'create_sidebars',\nJOIN_THREAD: 'join_thread',\nEDIT_PERMISSIONS: 'edit_permissions',\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/settings/thread-settings.react.js",
"new_path": "native/chat/settings/thread-settings.react.js",
"diff": "@@ -485,7 +485,7 @@ class ThreadSettings extends React.PureComponent<Props, State> {\n) ?? [];\nconst canCreateSubchannels = threadHasPermission(\nthreadInfo,\n- threadPermissions.CREATE_SUBTHREADS,\n+ threadPermissions.CREATE_SUBCHANNELS,\n);\nif (subchannels.length === 0 && !canCreateSubchannels) {\nreturn listData;\n@@ -691,7 +691,7 @@ class ThreadSettings extends React.PureComponent<Props, State> {\n);\nconst canCreateSubchannelsInParent = threadHasPermission(\nparentThreadInfo,\n- threadPermissions.CREATE_SUBTHREADS,\n+ threadPermissions.CREATE_SUBCHANNELS,\n);\nconst canPromoteSidebar =\nthreadInfo.type === threadTypes.SIDEBAR &&\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/creators/role-creator.js",
"new_path": "server/src/creators/role-creator.js",
"diff": "@@ -83,7 +83,7 @@ const voicedPermissions = {\n[threadPermissions.EDIT_THREAD_NAME]: true,\n[threadPermissions.EDIT_THREAD_COLOR]: true,\n[threadPermissions.EDIT_THREAD_DESCRIPTION]: true,\n- [threadPermissions.CREATE_SUBTHREADS]: true,\n+ [threadPermissions.CREATE_SUBCHANNELS]: true,\n[threadPermissions.ADD_MEMBERS]: true,\n};\n@@ -135,8 +135,8 @@ function getRolePermissionBlobsForCommunity(\nDESCENDANT + threadPermissions.EDIT_THREAD_COLOR;\nconst descendantEditThreadDescription =\nDESCENDANT + threadPermissions.EDIT_THREAD_DESCRIPTION;\n- const topLevelDescendantCreateSubthreads =\n- TOP_LEVEL_DESCENDANT + threadPermissions.CREATE_SUBTHREADS;\n+ const topLevelDescendantCreateSubchannels =\n+ TOP_LEVEL_DESCENDANT + threadPermissions.CREATE_SUBCHANNELS;\nconst topLevelDescendantCreateSidebars =\nTOP_LEVEL_DESCENDANT + threadPermissions.CREATE_SIDEBARS;\nconst descendantAddMembers = DESCENDANT + threadPermissions.ADD_MEMBERS;\n@@ -154,7 +154,7 @@ function getRolePermissionBlobsForCommunity(\n[threadPermissions.EDIT_THREAD_NAME]: true,\n[threadPermissions.EDIT_THREAD_COLOR]: true,\n[threadPermissions.EDIT_THREAD_DESCRIPTION]: true,\n- [threadPermissions.CREATE_SUBTHREADS]: true,\n+ [threadPermissions.CREATE_SUBCHANNELS]: true,\n[threadPermissions.CREATE_SIDEBARS]: true,\n[threadPermissions.ADD_MEMBERS]: true,\n[threadPermissions.DELETE_THREAD]: true,\n@@ -169,7 +169,7 @@ function getRolePermissionBlobsForCommunity(\n[descendantEditThreadName]: true,\n[descendantEditThreadColor]: true,\n[descendantEditThreadDescription]: true,\n- [topLevelDescendantCreateSubthreads]: true,\n+ [topLevelDescendantCreateSubchannels]: true,\n[topLevelDescendantCreateSidebars]: true,\n[descendantAddMembers]: true,\n[descendantDeleteThread]: true,\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -127,7 +127,7 @@ async function createThread(\nrequestParentThreadID,\nthreadType === threadTypes.SIDEBAR\n? threadPermissions.CREATE_SIDEBARS\n- : threadPermissions.CREATE_SUBTHREADS,\n+ : threadPermissions.CREATE_SUBCHANNELS,\n);\nif (!hasParentPermission) {\nthrow new ServerError('invalid_credentials');\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/thread-updaters.js",
"new_path": "server/src/updaters/thread-updaters.js",
"diff": "@@ -508,7 +508,7 @@ async function updateThread(\nnextParentThreadID,\nnextThreadType === threadTypes.SIDEBAR\n? threadPermissions.CREATE_SIDEBARS\n- : threadPermissions.CREATE_SUBTHREADS,\n+ : threadPermissions.CREATE_SUBCHANNELS,\n);\nif (!hasParentPermission) {\nthrow new ServerError('invalid_parameters');\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Rename CREATE_SUBTHREADS to CREATE_SUBCHANNELS
Summary: This is a simple rename.
Test Plan: I haven't had a chance to test this
Reviewers: marcinwasowicz, palys-swm
Reviewed By: marcinwasowicz, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2843 |
129,179 | 20.01.2022 09:25:39 | 18,000 | 0ce4f75d176444734bcb84a0806502b24702a865 | [web] add SWM icons
Summary:
add icons to use in the application. These are the selected icons from icomoon
{F9166}
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "\"metadata\": {\n\"name\": \"AppIcons\",\n\"lastOpened\": 0,\n- \"created\": 1640708563820\n+ \"created\": 1642621856590\n},\n\"iconSets\": [\n{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 8,\n+ \"paths\": [\n+ \"M56.891 512h910.223M56.891 512l341.332-341.332M56.891 512l341.332 341.332\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-arrow-left\"]\n+ },\n+ {\n+ \"id\": 9,\n+ \"paths\": [\n+ \"M967.109 512h-910.223M967.109 512l-341.332 341.332M967.109 512l-341.332-341.332\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"arrow-right\"]\n+ },\n+ {\n+ \"id\": 10,\n+ \"paths\": [\n+ \"M981.331 42.669l-938.669 938.669M42.67 42.669l938.669 938.669\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-cross\"]\n+ },\n+ {\n+ \"id\": 11,\n+ \"paths\": [\n+ \"M96.867 719.567l-27.519-27.518-11.401 11.394v16.125h38.92zM771.461 44.972l27.518-27.519c-15.201-15.201-39.839-15.201-55.036 0l27.518 27.519zM979.028 252.539l27.518 27.519c15.201-15.201 15.201-39.842 0-55.039l-27.518 27.519zM304.433 927.133v38.92h16.119l11.401-11.402-27.519-27.518zM96.867 927.133h-38.92c0 21.493 17.423 38.92 38.92 38.92v-38.92zM124.386 747.085l674.593-674.593-55.036-55.039-674.596 674.596 55.039 55.036zM743.939 72.491l207.567 207.567 55.036-55.039-207.567-207.567-55.036 55.039zM951.51 225.019l-674.596 674.596 55.039 55.036 674.593-674.593-55.036-55.039zM304.433 888.217h-207.567v77.836h207.567v-77.836zM135.783 927.133v-207.567h-77.836v207.567h77.836zM588.267 228.167l207.567 207.565 55.036-55.038-207.567-207.567-55.036 55.039z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(0, 26, 114)\"\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-edit-1\"]\n+ },\n+ {\n+ \"id\": 12,\n+ \"paths\": [\n+ \"M616.297 146.961c0-57.6-46.692-104.297-104.297-104.297s-104.297 46.693-104.297 104.297M616.297 146.961c0 57.6-46.692 104.297-104.297 104.297s-104.297-46.693-104.297-104.297M616.297 146.961h312.888M407.703 146.961h-312.888M720.595 512c0 57.602 46.692 104.297 104.297 104.297s104.297-46.692 104.297-104.297c0-57.602-46.692-104.297-104.297-104.297s-104.297 46.692-104.297 104.297zM720.595 512h-625.776M303.405 877.039c0-57.602-46.693-104.297-104.297-104.297s-104.297 46.692-104.297 104.297c0 57.602 46.693 104.297 104.297 104.297s104.297-46.692 104.297-104.297zM303.405 877.039h625.776\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"miter\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-filters-2\"]\n+ },\n+ {\n+ \"id\": 13,\n+ \"paths\": [\n+ \"M512 554.667c23.565 0 42.667-19.102 42.667-42.667s-19.102-42.667-42.667-42.667c-23.565 0-42.667 19.102-42.667 42.667s19.102 42.667 42.667 42.667z\",\n+ \"M810.665 554.667c23.565 0 42.667-19.102 42.667-42.667s-19.102-42.667-42.667-42.667c-23.565 0-42.667 19.102-42.667 42.667s19.102 42.667 42.667 42.667z\",\n+ \"M213.335 554.667c23.564 0 42.667-19.102 42.667-42.667s-19.103-42.667-42.667-42.667c-23.564 0-42.667 19.102-42.667 42.667s19.103 42.667 42.667 42.667z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-menu-horizontal\"]\n+ },\n+ {\n+ \"id\": 14,\n+ \"paths\": [\n+ \"M512 570.669c32.403 0 58.669-26.266 58.669-58.669s-26.266-58.669-58.669-58.669c-32.403 0-58.669 26.266-58.669 58.669s26.266 58.669 58.669 58.669z\",\n+ \"M512 160c32.403 0 58.669-26.267 58.669-58.669s-26.266-58.669-58.669-58.669c-32.403 0-58.669 26.267-58.669 58.669s26.266 58.669 58.669 58.669z\",\n+ \"M512 981.331c32.403 0 58.669-26.266 58.669-58.669s-26.266-58.669-58.669-58.669c-32.403 0-58.669 26.266-58.669 58.669s26.266 58.669 58.669 58.669z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-menu-vertical\"]\n+ },\n+ {\n+ \"id\": 6,\n+ \"paths\": [\n+ \"M668.444 42.668v208.595M355.556 42.668v208.595M94.815 459.853h834.371M929.185 459.853v417.185c0 57.602-46.692 104.297-104.297 104.297h-625.776c-57.6 0-104.297-46.692-104.297-104.297v-625.776c0-57.6 46.697-104.297 104.297-104.297h625.776c57.602 0 104.297 46.697 104.297 104.297v208.595z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-calendar\"]\n+ },\n+ {\n+ \"id\": 7,\n+ \"paths\": [\n+ \"M933.645 90.355h-843.295v632.472h158.116v263.529l263.529-263.529h421.645v-632.472z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-message-square\"]\n+ },\n{\n\"id\": 5,\n\"paths\": [\n},\n\"selection\": [\n{\n- \"order\": 29,\n+ \"order\": 39,\n+ \"id\": 7,\n+ \"name\": \"arrow-left\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 40,\n+ \"id\": 8,\n+ \"name\": \"arrow-right\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 41,\n+ \"id\": 9,\n+ \"name\": \"cross\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 42,\n+ \"id\": 10,\n+ \"name\": \"edit\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 43,\n+ \"id\": 11,\n+ \"name\": \"filters\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 44,\n+ \"id\": 12,\n+ \"name\": \"menu-horizontal\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 45,\n+ \"id\": 13,\n+ \"name\": \"menu-vertical\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 46,\n+ \"id\": 5,\n+ \"name\": \"calendar\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 47,\n+ \"id\": 6,\n+ \"name\": \"message-square\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 48,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 25,\n+ \"order\": 49,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 26,\n+ \"order\": 50,\n\"id\": 2,\n- \"name\": \"outline-chevron-right-small\",\n+ \"name\": \"chevron-right-small\",\n\"prevSize\": 32\n},\n{\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 27,\n+ \"order\": 51,\n\"prevSize\": 32\n},\n{\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 28,\n+ \"order\": 52,\n\"prevSize\": 32\n}\n],\n{\n\"order\": 0,\n\"id\": 284,\n- \"name\": \"outline-arrow-left\"\n+ \"name\": \"outline-arrow-left\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 279,\n- \"name\": \"outline-arrow-right\"\n+ \"name\": \"outline-arrow-right\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 253,\n- \"name\": \"outline-calendar\"\n+ \"name\": \"outline-calendar\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 205,\n- \"name\": \"outline-cross\"\n+ \"name\": \"outline-cross\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 192,\n- \"name\": \"outline-edit-1\"\n+ \"name\": \"outline-edit-1\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 180,\n- \"name\": \"outline-filters-2\"\n+ \"name\": \"outline-filters-2\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 139,\n- \"name\": \"outline-menu-horizontal\"\n+ \"name\": \"outline-menu-horizontal\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n\"id\": 138,\n- \"name\": \"outline-menu-vertical\"\n+ \"name\": \"outline-menu-vertical\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 132,\n- \"name\": \"outline-message-square\"\n+ \"name\": \"outline-message-square\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n\"useClassSelector\": true\n},\n\"quickUsageToken\": {\n- \"CommIcons\": \"ZDUwZTNmMjUxNWU5YjJmZDIyNTE1ZTE3NmZmOGJkN2IjMSMxNjQwNzA5Mzg3IyMjZWRlNjc0ZjA0MDdm\"\n+ \"AppIcons\": \"OTAwYTNkNGEyZDgwNzA5MzA3NjEyMGRiNDYxM2YwMTkjMSMxNjQyNjIyMzAxIyMjMzY5YjJhZmEwZjMx\"\n},\n\"showCodes\": true,\n\"showGlyphs\": true,\n\"showQuickUse2\": true,\n\"showSVGs\": true\n},\n- \"uid\": -1,\n- \"time\": 1640803264446\n+ \"uid\": -1\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/icons/selection.json",
"new_path": "web/icons/selection.json",
"diff": "{\n\"IcoMoonType\": \"selection\",\n\"icons\": [\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M56.891 512h910.223M56.891 512l341.332-341.332M56.891 512l341.332 341.332\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-arrow-left\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 39,\n+ \"id\": 7,\n+ \"name\": \"arrow-left\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 0\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M967.109 512h-910.223M967.109 512l-341.332 341.332M967.109 512l-341.332-341.332\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"arrow-right\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 40,\n+ \"id\": 8,\n+ \"name\": \"arrow-right\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 1\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M981.331 42.669l-938.669 938.669M42.67 42.669l938.669 938.669\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-cross\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 41,\n+ \"id\": 9,\n+ \"name\": \"cross\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 2\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M96.867 719.567l-27.519-27.518-11.401 11.394v16.125h38.92zM771.461 44.972l27.518-27.519c-15.201-15.201-39.839-15.201-55.036 0l27.518 27.519zM979.028 252.539l27.518 27.519c15.201-15.201 15.201-39.842 0-55.039l-27.518 27.519zM304.433 927.133v38.92h16.119l11.401-11.402-27.519-27.518zM96.867 927.133h-38.92c0 21.493 17.423 38.92 38.92 38.92v-38.92zM124.386 747.085l674.593-674.593-55.036-55.039-674.596 674.596 55.039 55.036zM743.939 72.491l207.567 207.567 55.036-55.039-207.567-207.567-55.036 55.039zM951.51 225.019l-674.596 674.596 55.039 55.036 674.593-674.593-55.036-55.039zM304.433 888.217h-207.567v77.836h207.567v-77.836zM135.783 927.133v-207.567h-77.836v207.567h77.836zM588.267 228.167l207.567 207.565 55.036-55.038-207.567-207.567-55.036 55.039z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(0, 26, 114)\"\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-edit-1\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(0, 26, 114)\"\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 42,\n+ \"id\": 10,\n+ \"name\": \"edit\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 3\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M616.297 146.961c0-57.6-46.692-104.297-104.297-104.297s-104.297 46.693-104.297 104.297M616.297 146.961c0 57.6-46.692 104.297-104.297 104.297s-104.297-46.693-104.297-104.297M616.297 146.961h312.888M407.703 146.961h-312.888M720.595 512c0 57.602 46.692 104.297 104.297 104.297s104.297-46.692 104.297-104.297c0-57.602-46.692-104.297-104.297-104.297s-104.297 46.692-104.297 104.297zM720.595 512h-625.776M303.405 877.039c0-57.602-46.693-104.297-104.297-104.297s-104.297 46.692-104.297 104.297c0 57.602 46.693 104.297 104.297 104.297s104.297-46.692 104.297-104.297zM303.405 877.039h625.776\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"miter\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-filters-2\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"miter\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 43,\n+ \"id\": 11,\n+ \"name\": \"filters\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 4\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M512 554.667c23.565 0 42.667-19.102 42.667-42.667s-19.102-42.667-42.667-42.667c-23.565 0-42.667 19.102-42.667 42.667s19.102 42.667 42.667 42.667z\",\n+ \"M810.665 554.667c23.565 0 42.667-19.102 42.667-42.667s-19.102-42.667-42.667-42.667c-23.565 0-42.667 19.102-42.667 42.667s19.102 42.667 42.667 42.667z\",\n+ \"M213.335 554.667c23.564 0 42.667-19.102 42.667-42.667s-19.103-42.667-42.667-42.667c-23.564 0-42.667 19.102-42.667 42.667s19.103 42.667 42.667 42.667z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-menu-horizontal\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 44,\n+ \"id\": 12,\n+ \"name\": \"menu-horizontal\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 5\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M512 570.669c32.403 0 58.669-26.266 58.669-58.669s-26.266-58.669-58.669-58.669c-32.403 0-58.669 26.266-58.669 58.669s26.266 58.669 58.669 58.669z\",\n+ \"M512 160c32.403 0 58.669-26.267 58.669-58.669s-26.266-58.669-58.669-58.669c-32.403 0-58.669 26.267-58.669 58.669s26.266 58.669 58.669 58.669z\",\n+ \"M512 981.331c32.403 0 58.669-26.266 58.669-58.669s-26.266-58.669-58.669-58.669c-32.403 0-58.669 26.266-58.669 58.669s26.266 58.669 58.669 58.669z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-menu-vertical\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ },\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 85.33333333333333\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 45,\n+ \"id\": 13,\n+ \"name\": \"menu-vertical\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 6\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M668.444 42.668v208.595M355.556 42.668v208.595M94.815 459.853h834.371M929.185 459.853v417.185c0 57.602-46.692 104.297-104.297 104.297h-625.776c-57.6 0-104.297-46.692-104.297-104.297v-625.776c0-57.6 46.697-104.297 104.297-104.297h625.776c57.602 0 104.297 46.697 104.297 104.297v208.595z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-calendar\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 46,\n+ \"id\": 5,\n+ \"name\": \"calendar\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 7\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M933.645 90.355h-843.295v632.472h158.116v263.529l263.529-263.529h421.645v-632.472z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-message-square\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 47,\n+ \"id\": 6,\n+ \"name\": \"message-square\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 8\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M291.091 263.479h441.811M291.091 484.385h276.131M70.186 42.575h883.626v662.72h-441.811l-276.131 276.131v-276.131h-165.68v-662.72z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-message-square-lines\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 48,\n+ \"id\": 4,\n+ \"name\": \"message-square-lines\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 9\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M325.342 104.401c52.109-38.794 116.707-61.749 186.66-61.749 172.809 0 312.9 140.091 312.9 312.9 0 116.375 32.46 232.745 61.159 312.9M196.224 417.445c-16.798 186.050-101.423 355.304-101.423 355.304h443.275M355.55 772.749v52.151c0 86.406 70.042 156.452 156.452 156.452 68.119 0 126.075-43.534 147.549-104.301M42.65 42.648l938.7 938.7\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-bell-disabled\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 49,\n+ \"id\": 3,\n+ \"name\": \"bell-disabled\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 10\n+ },\n{\n\"icon\": {\n\"paths\": [\"M324.23 981.424l469.424-469.424-469.424-469.424\"],\n}\n],\n\"properties\": {\n- \"order\": 18,\n+ \"order\": 50,\n\"id\": 2,\n- \"name\": \"outline-chevron-right-small\",\n+ \"name\": \"chevron-right-small\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 0\n+ \"iconIdx\": 11\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 19,\n+ \"order\": 51,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 1\n+ \"iconIdx\": 12\n},\n{\n\"icon\": {\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n\"paths\": [\n- \"M253.706 653.265v0zM419.208 653.265v0zM429.25 663.305v0zM594.75 663.305v0zM721.82 536.237v0zM887.323 536.237v0zM102.4 87.773h819.198v-87.771h-819.198v87.771zM936.227 102.4v819.198h87.771v-819.198h-87.771zM921.6 936.227h-819.198v87.771h819.198v-87.771zM87.773 921.6v-819.198h-87.771v819.198h87.771zM102.4 936.227c-8.079 0-14.629-6.547-14.629-14.629h-87.771c0 56.553 45.845 102.399 102.399 102.399v-87.771zM936.227 921.6c0 8.080-6.547 14.629-14.629 14.629v87.771c56.553 0 102.399-45.845 102.399-102.399h-87.771zM921.6 87.773c8.080 0 14.629 6.55 14.629 14.629h87.771c0-56.553-45.845-102.399-102.399-102.399v87.771zM102.4-0.001c-56.553 0-102.399 45.845-102.399 102.399h87.771c0-8.079 6.55-14.629 14.629-14.629v-87.771zM74.918 894.115l209.82-209.82-62.063-62.060-209.82 209.82 62.063 62.060zM388.177 684.295l10.043 10.043 62.060-62.060-10.043-10.043-62.061 62.060zM625.78 694.337l127.069-127.069-62.060-62.060-127.069 127.069 62.060 62.060zM856.291 567.267l92.792 92.792 62.060-62.060-92.792-92.792-62.060 62.060zM752.85 567.267c28.567-28.561 74.874-28.561 103.441 0l62.060-62.060c-62.839-62.844-164.723-62.844-227.562 0l62.060 62.060zM398.22 694.337c62.839 62.844 164.723 62.844 227.562 0l-62.060-62.060c-28.567 28.561-74.874 28.561-103.441 0l-62.060 62.060zM284.738 684.295c28.564-28.561 74.876-28.561 103.438 0l62.061-62.060c-62.839-62.844-164.723-62.844-227.563 0l62.063 62.060zM391.519 327.446c0 35.388-28.742 64.132-64.132 64.132v87.771c83.863 0 151.903-68.041 151.903-151.903h-87.771zM327.388 391.578c-35.314 0-64.073-28.727-64.073-64.132h-87.771c0 83.845 68.024 151.903 151.844 151.903v-87.771zM263.315 327.446c0-35.403 28.759-64.132 64.073-64.132v-87.771c-83.82 0-151.844 68.054-151.844 151.903h87.771zM327.388 263.315c35.388 0 64.132 28.742 64.132 64.132h87.771c0-83.863-68.041-151.903-151.903-151.903v87.771z\"\n+ \"M253.706 653.265v0zM419.208 653.265v0zM429.25 663.305v0zM594.75 663.305v0zM721.82 536.237v0zM887.324 536.237v0zM102.4 87.773h819.198v-87.771h-819.198v87.771zM936.227 102.4v819.198h87.771v-819.198h-87.771zM921.6 936.227h-819.198v87.771h819.198v-87.771zM87.773 921.6v-819.198h-87.771v819.198h87.771zM102.4 936.227c-8.079 0-14.629-6.547-14.629-14.629h-87.771c0 56.553 45.845 102.401 102.401 102.401v-87.771zM936.227 921.6c0 8.080-6.547 14.629-14.629 14.629v87.771c56.553 0 102.401-45.845 102.401-102.401h-87.771zM921.6 87.773c8.080 0 14.629 6.55 14.629 14.629h87.771c0-56.553-45.845-102.401-102.401-102.401v87.771zM102.4-0.001c-56.553 0-102.401 45.845-102.401 102.401h87.771c0-8.079 6.55-14.629 14.629-14.629v-87.771zM74.918 894.115l209.82-209.82-62.065-62.060-209.82 209.82 62.065 62.060zM388.177 684.295l10.041 10.041 62.060-62.060-10.041-10.041-62.061 62.060zM625.78 694.337l127.069-127.069-62.060-62.060-127.069 127.069 62.060 62.060zM856.291 567.267l92.792 92.792 62.060-62.060-92.792-92.792-62.060 62.060zM752.85 567.267c28.565-28.561 74.874-28.561 103.441 0l62.060-62.060c-62.839-62.844-164.723-62.844-227.562 0l62.060 62.060zM398.22 694.337c62.839 62.844 164.723 62.844 227.562 0l-62.060-62.060c-28.565 28.561-74.874 28.561-103.441 0l-62.060 62.060zM284.738 684.295c28.564-28.561 74.876-28.561 103.438 0l62.061-62.060c-62.839-62.844-164.723-62.844-227.563 0l62.065 62.060zM391.519 327.446c0 35.388-28.742 64.132-64.132 64.132v87.771c83.863 0 151.901-68.041 151.901-151.901h-87.771zM327.388 391.578c-35.314 0-64.073-28.727-64.073-64.132h-87.771c0 83.845 68.024 151.901 151.844 151.901v-87.771zM263.315 327.446c0-35.403 28.757-64.132 64.073-64.132v-87.771c-83.82 0-151.844 68.054-151.844 151.901h87.771zM327.388 263.315c35.388 0 64.132 28.742 64.132 64.132h87.771c0-83.863-68.041-151.901-151.901-151.901v87.771z\"\n],\n\"tags\": [\"outline-image-1\"]\n},\n\"properties\": {\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 20,\n+ \"order\": 52,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 2\n+ \"iconIdx\": 13\n}\n],\n\"height\": 1024,\n\"useClassSelector\": true\n},\n\"quickUsageToken\": {\n- \"CommIcons\": \"ZDUwZTNmMjUxNWU5YjJmZDIyNTE1ZTE3NmZmOGJkN2IjMSMxNjQwNzA5Mzg3IyMjZWRlNjc0ZjA0MDdm\"\n+ \"AppIcons\": \"OTAwYTNkNGEyZDgwNzA5MzA3NjEyMGRiNDYxM2YwMTkjMSMxNjQyNjIyMzAxIyMjMzY5YjJhZmEwZjMx\"\n},\n\"showCodes\": true,\n\"showGlyphs\": true,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add SWM icons
Summary:
add icons to use in the application. These are the selected icons from icomoon
{F9166}
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2889 |
129,179 | 13.01.2022 13:49:38 | 18,000 | d341a44e5b3e1bb7cf2989b2b750d8002b8f3ae2 | [web] replace favicons from squadcal to comm
Summary: update favicons to match comm brand {F8335}
Test Plan: load page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/icons/apple-touch-icon.png",
"new_path": "server/icons/apple-touch-icon.png",
"diff": "Binary files a/server/icons/apple-touch-icon.png and b/server/icons/apple-touch-icon.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/icons/favicon-16x16.png",
"new_path": "server/icons/favicon-16x16.png",
"diff": "Binary files a/server/icons/favicon-16x16.png and b/server/icons/favicon-16x16.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/icons/favicon-32x32.png",
"new_path": "server/icons/favicon-32x32.png",
"diff": "Binary files a/server/icons/favicon-32x32.png and b/server/icons/favicon-32x32.png differ\n"
},
{
"change_type": "MODIFY",
"old_path": "server/icons/favicon.ico",
"new_path": "server/icons/favicon.ico",
"diff": "Binary files a/server/icons/favicon.ico and b/server/icons/favicon.ico differ\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] replace favicons from squadcal to comm
Summary: update favicons to match comm brand {F8335}
Test Plan: load page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2856 |
129,190 | 24.01.2022 11:23:09 | -3,600 | 70049ffec44a2f2902dfa9965262821bf5b953ba | Services - backup - install aws specific version
Summary:
Raised in
I think we should always install specific versions of libraries.
Test Plan:
```
cd services
yarn build-backup-base
```
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/contents/install_aws_sdk.sh",
"new_path": "services/backup/docker-base/contents/install_aws_sdk.sh",
"diff": "@@ -10,7 +10,7 @@ fi\npushd /usr/lib\n-git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp\n+git clone --recurse-submodules https://github.com/aws/aws-sdk-cpp -b 1.9.176\nmkdir aws_sdk_build\npushd aws_sdk_build\ncmake ../aws-sdk-cpp/ -DCMAKE_BUILD_TYPE=Release -DCMAKE_PREFIX_PATH=/usr/local/aws_sdk -DBUILD_ONLY=\"core;s3;dynamodb\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Services - backup - install aws specific version
Summary:
Raised in https://phabricator.ashoat.com/D2759#73477
I think we should always install specific versions of libraries.
Test Plan:
```
cd services
yarn build-backup-base
```
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2880 |
129,179 | 24.01.2022 14:30:29 | 18,000 | fad95eb52d22a52d887f6339b1bcd550e165d6b5 | [web] [1/n] [style chat tabs] copy change focused --> focus
Summary: copy change to match the designs {F9240}
Test Plan: double check figma this is correct.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.react.js",
"new_path": "web/chat/chat-tabs.react.js",
"diff": "@@ -27,7 +27,7 @@ function ChatTabs(props: Props): React.Node {\n);\nconst { activeTab, setActiveTab } = threadListContext;\n- const onClickHome = React.useCallback(() => setActiveTab('Focused'), [\n+ const onClickHome = React.useCallback(() => setActiveTab('Focus'), [\nsetActiveTab,\n]);\nconst onClickBackground = React.useCallback(\n@@ -39,8 +39,8 @@ function ChatTabs(props: Props): React.Node {\n<div className={css.container}>\n<div className={css.tabs}>\n<ChatThreadTab\n- title=\"Focused\"\n- tabIsActive={activeTab === 'Focused'}\n+ title=\"Focus\"\n+ tabIsActive={activeTab === 'Focus'}\nonClick={onClickHome}\n/>\n<ChatThreadTab\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/thread-list-provider.js",
"new_path": "web/chat/thread-list-provider.js",
"diff": "@@ -21,7 +21,7 @@ import {\nactiveChatThreadItem as activeChatThreadItemSelector,\n} from '../selectors/chat-selectors';\n-type ChatTabType = 'Focused' | 'Background';\n+type ChatTabType = 'Focus' | 'Background';\ntype ThreadListContextType = {\n+activeTab: ChatTabType,\n+threadList: $ReadOnlyArray<ChatThreadItem>,\n@@ -34,7 +34,7 @@ type ThreadListProviderProps = {\n+children: React.Node,\n};\nfunction ThreadListProvider(props: ThreadListProviderProps): React.Node {\n- const [activeTab, setActiveTab] = React.useState('Focused');\n+ const [activeTab, setActiveTab] = React.useState('Focus');\nconst activeChatThreadItem = useSelector(activeChatThreadItemSelector);\nconst activeThreadInfo = activeChatThreadItem?.threadInfo;\n@@ -57,7 +57,7 @@ function ThreadListProvider(props: ThreadListProviderProps): React.Node {\nactiveTopLevelThreadInfo?.currentUser.subscription.home;\nconst activeTopLevelThreadIsFromDifferentTab =\n- (activeTab === 'Focused' && activeTopLevelThreadIsFromHomeTab) ||\n+ (activeTab === 'Focus' && activeTopLevelThreadIsFromHomeTab) ||\n(activeTab === 'Background' && !activeTopLevelThreadIsFromHomeTab);\nconst activeTopLevelThreadIsInChatList = React.useMemo(\n@@ -73,9 +73,7 @@ function ThreadListProvider(props: ThreadListProviderProps): React.Node {\nconst prevActiveThreadID = prevActiveThreadIDRef.current;\nprevActiveThreadIDRef.current = activeThreadID;\nif (activeThreadID !== prevActiveThreadID && shouldChangeTab) {\n- setActiveTab(\n- activeTopLevelThreadIsFromHomeTab ? 'Focused' : 'Background',\n- );\n+ setActiveTab(activeTopLevelThreadIsFromHomeTab ? 'Focus' : 'Background');\n}\n}, [activeThreadID, shouldChangeTab, activeTopLevelThreadIsFromHomeTab]);\n@@ -156,7 +154,7 @@ function ThreadListProvider(props: ThreadListProviderProps): React.Node {\nthreadInBackgroundChatList(item.threadInfo),\n);\nif (activeTopLevelChatThreadItem && !activeTopLevelThreadIsInChatList) {\n- if (activeThreadOriginalTab === 'Focused') {\n+ if (activeThreadOriginalTab === 'Focus') {\nhome.unshift(activeTopLevelChatThreadItem);\n} else {\nbackground.unshift(activeTopLevelChatThreadItem);\n@@ -175,7 +173,7 @@ function ThreadListProvider(props: ThreadListProviderProps): React.Node {\n]);\nconst currentThreadList =\n- activeTab === 'Focused' ? homeThreadList : backgroundThreadList;\n+ activeTab === 'Focus' ? homeThreadList : backgroundThreadList;\nconst threadListContext = React.useMemo(\n() => ({\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1/n] [style chat tabs] copy change focused --> focus
Summary: copy change to match the designs {F9240}
Test Plan: double check figma this is correct.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2899 |
129,179 | 12.01.2022 12:19:24 | 18,000 | b46fb9d9de8ce211302291edc07316cb42e49ce1 | [web] [3/n] [darktheme] update colors in navigation header
Summary: swaps out old background with updated dark theme.
Test Plan: Header should look like this {F8075}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -62,6 +62,7 @@ header.header {\n}\ndiv.main-header {\nheight: 62px;\n+ background: var(--bg);\n}\ndiv.main-header > h1 {\nposition: absolute;\n@@ -92,7 +93,7 @@ ul.nav-bar > li > div {\npadding: 3px 20px 3px 20px;\n}\nul.nav-bar > li > div > a {\n- color: #ffffff;\n+ color: var(--fg);\n}\nul.nav-bar > li.current-tab > div > a {\ncolor: #444444;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--error-dark-90: #4f1203;\n--bg: var(--shades-black-100);\n- --color: var(--shades-white-100);\n+ --fg: var(--shades-white-100);\n--color-disabled: var(--shades-black-60);\n--text-input-bg: var(--shades-black-80);\n--text-input-color: var(--shades-black-60);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [3/n] [darktheme] update colors in navigation header
Summary: swaps out old background with updated dark theme.
Test Plan: Header should look like this {F8075}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2829 |
129,179 | 12.01.2022 12:45:04 | 18,000 | 9a9a634960a85988e4583cf19e97557f49aa7eb1 | [web] [5/n] [darktheme] update brand styling to Figma
Summary: styles for branding should match figma, layout and positioning are still off and will continue to be updated
Test Plan: header should look like this {F8095}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -63,13 +63,16 @@ header.header {\ndiv.main-header {\nheight: 62px;\nbackground: var(--bg);\n+ display: flex;\n+ align-items: center;\n}\ndiv.main-header > h1 {\n- position: absolute;\n- padding-top: 5px;\n- padding-left: 16px;\n- color: white;\n- font-size: 38px;\n+ color: var(--fg);\n+ padding: 0 6px;\n+ font-family: var(--font-logo);\n+ line-height: var(--line-height-text);\n+ font-weight: var(--semi-bold);\n+ font-size: var(--logo-font);\n}\nul.nav-bar {\nposition: absolute;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/typography.css",
"new_path": "web/typography.css",
"diff": ":root {\n--font-stack: 'Inter', -apple-system, 'Segoe UI', 'Roboto', 'Oxygen', 'Ubuntu',\n'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue', ui-sans-serif;\n+ --font-logo: 'IBM Plex Sans', ui-sans-serif;\n+ --logo-font-22: 2.2rem;\n--xxxl-font-32: 3.2rem;\n--xxl-font-28: 2.8rem;\n--xxl-font-24: 2.4rem;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [5/n] [darktheme] update brand styling to Figma
Summary: styles for branding should match figma, layout and positioning are still off and will continue to be updated
Test Plan: header should look like this {F8095}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2831 |
129,179 | 12.01.2022 15:31:26 | 18,000 | ae3d92963c89d61cefa643ebcdfab6ff550342df | [web] [7/n] [darktheme] update thread list color to dark
Summary: change thread list to dark theme
Test Plan: thread list should look like screen shot.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -3,7 +3,7 @@ div.container {\nwidth: 400px;\ntop: 0;\nbottom: 0;\n- background-color: white;\n+ background-color: var(--bg);\nborder-right: 2px solid #e4e4e4;\ndisplay: flex;\nflex-direction: column;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -3,11 +3,9 @@ div.thread {\nflex-direction: row;\npadding: 5px 5px 5px 15px;\n}\n+div.activeThread,\ndiv.thread:hover {\n- background-color: #eeeeee;\n-}\n-div.activeThread {\n- background-color: #eeeeee;\n+ background: var(--selected-thread-bg);\n}\ndiv.thread div.title {\nflex: 1;\n@@ -15,7 +13,7 @@ div.thread div.title {\nwhite-space: nowrap;\noverflow: hidden;\ntext-overflow: ellipsis;\n- color: black;\n+ color: var(--fg);\n}\na.threadButton {\nflex: 1;\n@@ -44,17 +42,17 @@ div.lastMessage {\nflex: 1;\n}\ndiv.unread {\n- color: black;\n+ color: var(--fg);\nfont-weight: 600;\n}\n.black {\n- color: black;\n+ color: var(--fg);\n}\ndiv.dark {\n- color: #666666;\n+ color: var(--fg);\n}\n.light {\n- color: #aaaaaa;\n+ color: var(--fg);\n}\ndiv.italic {\nfont-style: italic;\n@@ -66,7 +64,7 @@ div.thread div.sidebarTitle {\nwhite-space: nowrap;\noverflow: hidden;\ntext-overflow: ellipsis;\n- color: black;\n+ color: var(--fg);\nalign-self: flex-start;\n}\ndiv.sidebarLastActivity {\n@@ -74,7 +72,7 @@ div.sidebarLastActivity {\nfont-size: 14px;\n}\nsvg.sidebarIcon {\n- color: black;\n+ color: var(--fg);\npadding: 0 6px;\nfont-size: 20px;\n}\n@@ -89,6 +87,7 @@ div.sidebar .menu > button svg {\n}\n.menu > button {\nbackground-color: transparent;\n+ color: var(--fg);\nborder: none;\nborder-radius: 5px;\ncursor: pointer;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--chat-confirmation-icon: var(--violet-dark-100);\n--keyserver-selection: var(--violet-dark-60);\n--thread-selection: var(--violet-light-80);\n+ --selected-thread-bg: var(--shades-black-90);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [7/n] [darktheme] update thread list color to dark
Summary: change thread list to dark theme
Test Plan: thread list should look like screen shot.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2833 |
129,179 | 12.01.2022 16:51:39 | 18,000 | f31b820c5978d555e1a795973544c0b2ba66f544 | [web] [10/n] [darktheme] update tool tip theme to dark
Summary:
match color theme from figma {F8149}
Test Plan: tool tip should look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -53,32 +53,32 @@ div.conversationHeader:last-child {\ndiv.messageLeftTooltip:after {\ntop: 7px;\nright: -14px;\n- border-color: transparent transparent transparent black;\n+ border-color: transparent transparent transparent var(--tool-tip-bg);\n}\ndiv.messageRightTooltip:after {\ntop: 7px;\nleft: -14px;\n- border-color: transparent black transparent transparent;\n+ border-color: transparent var(--tool-tip-bg) transparent transparent;\n}\ndiv.messageTopLeftTooltip:after {\nbottom: -14px;\nleft: 4px;\n- border-color: black transparent transparent transparent;\n+ border-color: var(--tool-tip-bg) transparent transparent transparent;\n}\ndiv.messageTopRightTooltip:after {\nbottom: -14px;\nright: 4px;\n- border-color: black transparent transparent transparent;\n+ border-color: var(--tool-tip-bg) transparent transparent transparent;\n}\ndiv.messageBottomLeftTooltip:after {\ntop: -14px;\nleft: 4px;\n- border-color: transparent transparent black transparent;\n+ border-color: transparent transparent var(--tool-tip-bg) transparent;\n}\ndiv.messageBottomRightTooltip:after {\ntop: -14px;\nright: 4px;\n- border-color: transparent transparent black transparent;\n+ border-color: transparent transparent var(--tool-tip-bg) transparent;\n}\ndiv.messageActionLinks {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip.css",
"new_path": "web/chat/tooltip.css",
"diff": "div.messageTooltipMenu {\nposition: absolute;\n- background-color: black;\n- color: white;\n+ background-color: var(--tool-tip-bg);\n+ color: var(--tool-tip-color);\npadding: 5px;\nborder-radius: 5px;\nfont-size: 14px;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--thread-selection: var(--violet-light-80);\n--selected-thread-bg: var(--shades-black-90);\n--chat-timestamp-color: var(--shades-black-60);\n+ --tool-tip-bg: var(--shades-black-80);\n+ --tool-tip-color: var(--shades-black-60);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [10/n] [darktheme] update tool tip theme to dark
Summary:
match color theme from figma {F8149}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Test Plan: tool tip should look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2836 |
129,179 | 13.01.2022 12:27:44 | 18,000 | f0e82ac34acceda27b725939e798ea3f9baa1348 | [web] [11/n] [darktheme] add border to main header
Summary: add border to main header {F8295}
Test Plan: it should look like figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -65,6 +65,7 @@ div.main-header {\nbackground: var(--bg);\ndisplay: flex;\nalign-items: center;\n+ border-bottom: 1px solid var(--border-color);\n}\ndiv.main-header > h1 {\ncolor: var(--fg);\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--chat-timestamp-color: var(--shades-black-60);\n--tool-tip-bg: var(--shades-black-80);\n--tool-tip-color: var(--shades-black-60);\n+ --border-color: var(--shades-black-60);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [11/n] [darktheme] add border to main header
Summary: add border to main header {F8295}
Test Plan: it should look like figma https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2851 |
129,179 | 13.01.2022 12:35:22 | 18,000 | 594d60f0cc28efaa9db47540f50dbd7676cc7876 | [web] [12/n] [darktheme] update border for chat tabs
Summary: to match figma {F8301}
Test Plan: should look like screen shot and match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -4,7 +4,7 @@ div.container {\ntop: 0;\nbottom: 0;\nbackground-color: var(--bg);\n- border-right: 2px solid #e4e4e4;\n+ border-right: 1px solid var(--border-color);\ndisplay: flex;\nflex-direction: column;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [12/n] [darktheme] update border for chat tabs
Summary: to match figma {F8301} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Test Plan: should look like screen shot and match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2852 |
129,179 | 13.01.2022 12:44:48 | 18,000 | 23a23d1c021974f0046d15c7d01a82b0b752d676 | [web] [14/n] [darktheme] add inactive chat tab selection bottom border
Summary: {F8315} to match figma
Test Plan: should match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -30,7 +30,8 @@ div.tabItemActive {\ndiv.tabItemInactive {\nbackground-color: var(--bg);\ncolor: var(--color-disabled);\n- margin-bottom: -1px;\n+ border: outset var(--border-color);\n+ border-width: 0 0 3px 0;\n}\ndiv.threadList {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [14/n] [darktheme] add inactive chat tab selection bottom border
Summary: {F8315} to match figma
Test Plan: should match figma https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77360
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2854 |
129,179 | 18.01.2022 15:58:14 | 18,000 | 80ceed7a0abc6f37fd494f149118f08398183849 | [web] [16/n] [darkmode] position send icon outside of input field background.
Summary: move send icon outside of input field {F8909}
Test Plan: add text to input field
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -6,6 +6,7 @@ div.inputBar {\ndiv.inputBarWrapper {\npadding: 16px;\ndisplay: flex;\n+ align-items: center;\nflex-direction: row;\nalign-items: center;\n}\n@@ -75,3 +76,11 @@ div.previews > span.multimedia > span.multimediaImage > img {\nmax-height: 200px;\nmax-width: 200px;\n}\n+\n+a.sendButton {\n+ padding: 8px 0 0 10px;\n+}\n+\n+a.sendButton svg {\n+ color: var(--fg);\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -226,7 +226,7 @@ class ChatInputBar extends React.PureComponent<Props> {\nlet sendButton;\nif (this.props.inputState.draft.length) {\nsendButton = (\n- <a onClick={this.onSend}>\n+ <a onClick={this.onSend} className={css.sendButton}>\n<SWMansionIcon icon=\"send\" size={16} color=\"#8a8a8a\" />\n</a>\n);\n@@ -258,8 +258,8 @@ class ChatInputBar extends React.PureComponent<Props> {\nref={this.textareaRef}\nautoFocus\n/>\n- {sendButton}\n</div>\n+ {sendButton}\n</div>\n);\n} else if (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [16/n] [darkmode] position send icon outside of input field background.
Summary: move send icon outside of input field {F8909}
Test Plan: add text to input field
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2878 |
129,179 | 19.01.2022 13:08:52 | 18,000 | 1c99643d6f3fdb84f7a8b2f2290f42e777c19328 | [web] [17/n] [darkmode] update image upload to correct white color
Summary: match figma, image upload should be white {F9051}
Test Plan: check figma that the right color is used
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -64,6 +64,11 @@ a.multimediaUpload > input[type='file'] {\nmargin: 0;\npadding: 0;\n}\n+\n+a.multimediaUpload > svg {\n+ color: var(--fg);\n+}\n+\ndiv.previews {\ndisplay: flex;\noverflow-x: auto;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "@@ -246,7 +246,7 @@ class ChatInputBar extends React.PureComponent<Props> {\naccept={allowedMimeTypeString}\nmultiple\n/>\n- <SWMansionIcon icon=\"image\" size={16} color=\"#8a8a8a\" disableFill />\n+ <SWMansionIcon icon=\"image\" size={16} disableFill />\n</a>\n<div className={css.inputBarTextInput}>\n<textarea\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [17/n] [darkmode] update image upload to correct white color
Summary: match figma, image upload should be white {F9051}
Test Plan: check figma that the right color is used
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2882 |
129,179 | 24.01.2022 15:03:49 | 18,000 | d6b1654a2b1d50acac099cd1f0b0b147d42f7bc6 | [web] [fix] comm header incorrect size
Summary: incorrect variable name was added and no font-size was applied {F9234}
Test Plan: make sure the header looks like <screenshot>
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -73,7 +73,7 @@ div.main-header > h1 {\nfont-family: var(--font-logo);\nline-height: var(--line-height-text);\nfont-weight: var(--semi-bold);\n- font-size: var(--logo-font);\n+ font-size: var(--logo-font-22);\n}\nul.nav-bar {\nposition: absolute;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] comm header incorrect size
Summary: incorrect variable name was added and no font-size was applied {F9234}
Test Plan: make sure the header looks like <screenshot>
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2898 |
129,179 | 24.01.2022 15:17:45 | 18,000 | d194968a7e07e8095f6eba83f28e85d0992c4cc6 | [web] [refactor] component prop destructure to be consistent with project
Summary: keep component consistent with project
Test Plan: n/a component does exactly what it did before
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-tab.react.js",
"new_path": "web/chat/chat-thread-tab.react.js",
"diff": "@@ -6,19 +6,20 @@ import * as React from 'react';\nimport css from './chat-tabs.css';\ntype Props = {\n- title: string,\n- onClick: (title: string) => void,\n- tabIsActive: boolean,\n+ +title: string,\n+ +onClick: (title: string) => void,\n+ +tabIsActive: boolean,\n};\nfunction ChatThreadTab(props: Props): React.Node {\n+ const { title, onClick, tabIsActive } = props;\nconst className = classNames({\n[css.tabItem]: true,\n- [css.tabItemActive]: props.tabIsActive,\n- [css.tabItemInactive]: !props.tabIsActive,\n+ [css.tabItemActive]: tabIsActive,\n+ [css.tabItemInactive]: !tabIsActive,\n});\nreturn (\n- <div className={className} onClick={props.onClick}>\n- {props.title}\n+ <div className={className} onClick={onClick}>\n+ {title}\n</div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] component prop destructure to be consistent with project
Summary: keep component consistent with project
Test Plan: n/a component does exactly what it did before
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2900 |
129,179 | 24.01.2022 15:47:19 | 18,000 | 0b985d050842f837997eeb518f9c24d75734713a | [web] [1/n] [darkmodecalendar] swap image background for black
Summary: change image background from image to black, more theme'ing to come {F9408}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/filter-panel.css",
"new_path": "web/calendar/filter-panel.css",
"diff": "@@ -3,15 +3,12 @@ div.container {\nwidth: 300px;\ntop: 62px;\nbottom: 0;\n- background-image: url(../images/background.png);\n- background-size: 3000px 2000px;\nbackground-attachment: fixed;\ndisplay: flex;\nflex-direction: column;\n}\ndiv.filters {\ncolor: #dddddd;\n- background-color: rgba(0, 0, 0, 0.89);\noverflow-y: auto;\nheight: 100%;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -14,9 +14,7 @@ html {\n}\nbody {\nfont-family: var(--font-stack);\n- background-image: url(../images/background.png);\n- background-size: 3000px 2000px;\n- background-attachment: fixed;\n+ background: var(--bg);\nheight: 100%;\noverflow: hidden;\nfont-size: 1.6rem;\n@@ -55,7 +53,7 @@ input[type='submit']::-moz-focus-inner {\n}\nheader.header {\n- background-image: url(../images/background.png);\n+ background: var(--bg);\nbackground-size: 3000px 2000px;\nbackground-attachment: fixed;\nz-index: 1;\n@@ -129,7 +127,6 @@ div.main-content-container {\nheight: calc(100% - 62px);\n}\ndiv.main-content {\n- background-color: rgba(255, 255, 255, 0.84);\nheight: 100%;\n}\n@@ -268,7 +265,7 @@ div.large-modal-overlay {\npadding-top: 50px;\n}\ndiv.modal-container {\n- background-image: url(../images/background.png);\n+ background: var(--bg);\nbackground-size: 3000px 2000px;\nmax-width: 330px;\nborder-radius: 15px;\n@@ -620,7 +617,7 @@ div.intro-modal {\ndiv.modal-container,\nul.nav-bar > li.current-tab,\ndiv.calendar-filters-container {\n- background-image: url(../images/background@2x.png);\n+ background: var(--bg);\n}\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1/n] [darkmodecalendar] swap image background for black
Summary: change image background from image to black, more theme'ing to come {F9408}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2906 |
129,179 | 24.01.2022 15:40:22 | 18,000 | 78e0bf87df9b253c1dc01ed5353f09592f055060 | [web] [4/n] [darkmodecalendar] theme calendar
Summary: theme calendar
Test Plan: should look like this. There isn't design. Happy to take unput
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -62,7 +62,7 @@ textarea.entryText {\n}\ntable.calendar td.day {\nborder: 1px solid transparent;\n- background-color: white;\n+ background: var(--calendar-day-bg);\nposition: relative;\nvertical-align: top;\nline-height: 0;\n@@ -170,13 +170,13 @@ td.day > h2 {\nposition: absolute;\nbottom: 2px;\nright: 3px;\n- color: #999999;\n+ color: var(--fg);\nfont-size: 32px;\nline-height: 32px;\nz-index: 1;\n}\ntd.currentDay > h2 {\n- color: #ff944d;\n+ color: var(--calendar-day-selected-color);\n}\ndiv.clear {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--tool-tip-color: var(--shades-black-60);\n--border-color: var(--shades-black-60);\n--calendar-chevron: var(--shades-black-60);\n+ --calendar-day-bg: var(--shades-black-60);\n+ --calendar-day-selected-color: var(--violet-dark-80);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] [darkmodecalendar] theme calendar
Summary: theme calendar
Test Plan: should look like this. There isn't design. Happy to take unput
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2909 |
129,179 | 25.01.2022 07:57:52 | 18,000 | 998d8b46edbcf8cdefd79161c06da90afb91d407 | [web] [2/n] [darkmodecalendar] update heading text
Summary: update header styling {F9733}
Test Plan: header should match theme
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -34,6 +34,7 @@ nav.nav > a.monthLink {\nnav.nav > .monthName {\ndisplay: inline-block;\nwidth: 200px;\n+ color: var(--fg);\n}\ntable.calendar {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.react.js",
"new_path": "web/calendar/calendar.react.js",
"diff": "@@ -192,10 +192,10 @@ class Calendar extends React.PureComponent<Props, State> {\n>\n<SWMansionIcon icon=\"chevron-left\" size={24} />\n</a>\n- <div className={css.monthName}>\n+ <h2 className={css.monthName}>\n{' '}\n{monthName} {year}{' '}\n- </div>\n+ </h2>\n<a\nclassName={css.monthLink}\nhref={nextURL}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] [darkmodecalendar] update heading text
Summary: update header styling {F9733}
Test Plan: header should match theme
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2920 |
129,179 | 25.01.2022 08:04:02 | 18,000 | 9376da212c8d42695fb76c5b17470d9bd79aa2db | [web] [1,2,3/n] [layout] add css grid layout to top level
Summary:
add basic grid layout, it should be broken visually {F8893}
updated screen shot now that [1,2,3/n] are squashed
Test Plan: n/a
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -42,6 +42,7 @@ import FocusHandler from './redux/focus-handler.react';\nimport { useSelector } from './redux/redux-utils';\nimport VisibilityHandler from './redux/visibility-handler.react';\nimport history from './router-history';\n+import SideBar from './sidebar/sidebar.react';\nimport Splash from './splash/splash.react';\nimport './typography.css';\nimport css from './style.css';\n@@ -181,7 +182,7 @@ class App extends React.PureComponent<Props, State> {\n}\nreturn (\n- <React.Fragment>\n+ <div className={css.layout}>\n<header className={css['header']}>\n<div className={css['main-header']}>\n<h1>Comm</h1>\n@@ -226,7 +227,8 @@ class App extends React.PureComponent<Props, State> {\n<div className={css['main-content']}>{mainContent}</div>\n</div>\n</InputStateContainer>\n- </React.Fragment>\n+ <SideBar />\n+ </div>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -12,7 +12,7 @@ div.activeContainer {\n}\ndiv.outerMessageContainer {\nposition: relative;\n- height: 100%;\n+ height: calc(100vh - 128px);\nmin-height: 0;\n}\ndiv.messageContainer {\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/sidebar.css",
"diff": "+.container {\n+ grid-area: sBar;\n+ background: var(--bg);\n+ color: var(--color);\n+ border-right: 1px solid var(--border-color);\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/sidebar.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from './sidebar.css';\n+\n+function SideBar(): React.Node {\n+ return (\n+ <aside className={css.container}>\n+ <h3>i am side bar</h3>\n+ </aside>\n+ );\n+}\n+\n+export default SideBar;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -52,14 +52,25 @@ input[type='submit']::-moz-focus-inner {\nheight: 100%;\n}\n+div.layout {\n+ height: 100vh;\n+ display: grid;\n+ grid-template-columns: 244px repeat(12, 1fr);\n+ grid-template-rows: 65px 1fr;\n+ grid-template-areas:\n+ 'nav nav nav nav nav nav nav nav nav nav nav nav nav'\n+ 'sBar app app app app app app app app app app app app';\n+}\n+\nheader.header {\nbackground: var(--bg);\nbackground-size: 3000px 2000px;\nbackground-attachment: fixed;\nz-index: 1;\n+ grid-area: nav;\n}\ndiv.main-header {\n- height: 62px;\n+ height: 64px;\nbackground: var(--bg);\ndisplay: flex;\nalign-items: center;\n@@ -124,7 +135,7 @@ div.chatBadge {\ndiv.main-content-container {\nposition: relative;\n- height: calc(100% - 62px);\n+ grid-area: app;\n}\ndiv.main-content {\nheight: 100%;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1,2,3/n] [layout] add css grid layout to top level
Summary:
add basic grid layout, it should be broken visually {F8893}
updated screen shot now that [1,2,3/n] are squashed
Test Plan: n/a
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2865 |
129,179 | 25.01.2022 08:05:34 | 18,000 | 622a51cf717d652a758e0ad0981e997c18fa84f6 | [web] [5/n] [layout] add spaces component
Summary: Add section for community and inbox selection
Test Plan: should look like {F8539}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/community-picker.css",
"diff": "+.container {\n+ display: flex;\n+ flex-direction: column;\n+ width: 84px;\n+ background: var(--community-bg);\n+ border-right: 1px solid var(--border-color);\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/community-picker.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from './community-picker.css';\n+\n+function CommunityPicker(): React.Node {\n+ return <div className={css.container}></div>;\n+}\n+\n+export default CommunityPicker;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/sidebar.react.js",
"new_path": "web/sidebar/sidebar.react.js",
"diff": "import * as React from 'react';\nimport AppSwitcher from './app-switcher.react';\n+import CommunityPicker from './community-picker.react';\nimport css from './sidebar.css';\nfunction SideBar(): React.Node {\nreturn (\n<aside className={css.container}>\n+ <CommunityPicker />\n<AppSwitcher />\n</aside>\n);\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--calendar-chevron: var(--shades-black-60);\n--calendar-day-bg: var(--shades-black-60);\n--calendar-day-selected-color: var(--violet-dark-80);\n+ --community-bg: var(--shades-black-90);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [5/n] [layout] add spaces component
Summary: Add section for community and inbox selection
Test Plan: should look like {F8539}
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2869 |
129,179 | 25.01.2022 09:06:01 | 18,000 | 596a25e766d549a272359ddbf23fb555704285c7 | [web] [navigation] [2/n] move unread functionality to sidebar
Summary: move unread functionality to sidebar {F8993}
Test Plan: send a message to a test user and confirm correct unread count is showing up
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -9,7 +9,6 @@ import { config as faConfig } from '@fortawesome/fontawesome-svg-core';\nimport { faCalendar, faComments } from '@fortawesome/free-solid-svg-icons';\nimport { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport classNames from 'classnames';\n-import invariant from 'invariant';\nimport _isEqual from 'lodash/fp/isEqual';\nimport * as React from 'react';\nimport { DndProvider } from 'react-dnd';\n@@ -24,10 +23,7 @@ import {\ncreateLoadingStatusSelector,\ncombineLoadingStatuses,\n} from 'lib/selectors/loading-selectors';\n-import {\n- mostRecentReadThreadSelector,\n- unreadCount,\n-} from 'lib/selectors/thread-selectors';\n+import { mostRecentReadThreadSelector } from 'lib/selectors/thread-selectors';\nimport { isLoggedIn } from 'lib/selectors/user-selectors';\nimport type { LoadingStatus } from 'lib/types/loading-types';\nimport type { Dispatch } from 'lib/types/redux-types';\n@@ -46,7 +42,6 @@ import SideBar from './sidebar/sidebar.react';\nimport Splash from './splash/splash.react';\nimport './typography.css';\nimport css from './style.css';\n-import getTitle from './title/getTitle';\nimport { type NavInfo, updateNavInfoActionType } from './types/nav-types';\nimport { canonicalURLFromReduxState, navInfoFromURL } from './url-utils';\n@@ -83,8 +78,6 @@ type Props = {\n+loggedIn: boolean,\n+mostRecentReadThread: ?string,\n+activeThreadCurrentlyUnread: boolean,\n- +viewerID: ?string,\n- +unreadCount: number,\n// Redux dispatch functions\n+dispatch: Dispatch,\n};\n@@ -174,13 +167,6 @@ class App extends React.PureComponent<Props, State> {\nmainContent = <Chat setModal={this.setModal} />;\n}\n- const { viewerID, unreadCount: curUnreadCount } = this.props;\n- invariant(viewerID, 'should be set');\n- let chatBadge = null;\n- if (curUnreadCount > 0) {\n- chatBadge = <div className={css.chatBadge}>{curUnreadCount}</div>;\n- }\n-\nreturn (\n<div className={css.layout}>\n<header className={css['header']}>\n@@ -206,7 +192,6 @@ class App extends React.PureComponent<Props, State> {\nclassName={css['nav-bar-icon']}\n/>\nChat\n- {chatBadge}\n</a>\n</div>\n</li>\n@@ -274,15 +259,6 @@ const ConnectedApp: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n!!state.threadStore.threadInfos[activeChatThreadID]?.currentUser.unread,\n);\n- const viewerID = useSelector(\n- state => state.currentUserInfo && state.currentUserInfo.id,\n- );\n- const boundUnreadCount = useSelector(unreadCount);\n-\n- React.useEffect(() => {\n- document.title = getTitle(boundUnreadCount);\n- }, [boundUnreadCount]);\n-\nconst dispatch = useDispatch();\nreturn (\n@@ -293,8 +269,6 @@ const ConnectedApp: React.ComponentType<BaseProps> = React.memo<BaseProps>(\nloggedIn={loggedIn}\nmostRecentReadThread={mostRecentReadThread}\nactiveThreadCurrentlyUnread={activeThreadCurrentlyUnread}\n- viewerID={viewerID}\n- unreadCount={boundUnreadCount}\ndispatch={dispatch}\n/>\n);\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "// @flow\n+import invariant from 'invariant';\nimport * as React from 'react';\nimport { useDispatch } from 'react-redux';\n-import { mostRecentReadThreadSelector } from 'lib/selectors/thread-selectors';\n+import {\n+ mostRecentReadThreadSelector,\n+ unreadCount,\n+} from 'lib/selectors/thread-selectors';\nimport { useSelector } from '../redux/redux-utils';\n+import getTitle from '../title/getTitle';\nimport { updateNavInfoActionType } from '../types/nav-types';\nimport css from './sidebar.css';\n@@ -19,6 +24,15 @@ function AppSwitcher(): React.Node {\n!activeChatThreadID ||\n!!state.threadStore.threadInfos[activeChatThreadID]?.currentUser.unread,\n);\n+ const viewerID = useSelector(\n+ state => state.currentUserInfo && state.currentUserInfo.id,\n+ );\n+\n+ const boundUnreadCount = useSelector(unreadCount);\n+\n+ React.useEffect(() => {\n+ document.title = getTitle(boundUnreadCount);\n+ }, [boundUnreadCount]);\nconst dispatch = useDispatch();\n@@ -54,6 +68,12 @@ function AppSwitcher(): React.Node {\n],\n);\n+ invariant(viewerID, 'should be set');\n+ let chatBadge = null;\n+ if (boundUnreadCount > 0) {\n+ chatBadge = <div className={css.chatBadge}>{boundUnreadCount}</div>;\n+ }\n+\nreturn (\n<div className={css.container}>\n<ul>\n@@ -65,6 +85,7 @@ function AppSwitcher(): React.Node {\n<li>\n<p>\n<a onClick={onClickChat}>Chat</a>\n+ {chatBadge}\n</p>\n</li>\n</ul>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/sidebar.css",
"new_path": "web/sidebar/sidebar.css",
"diff": ".container ul {\nlist-style-type: none;\n}\n+\n+div.chatBadge {\n+ display: inline-block;\n+ box-sizing: border-box;\n+ width: 25px;\n+ height: 25px;\n+ margin-left: 8px;\n+ color: white;\n+ background-color: red;\n+ border-radius: 13px;\n+ font-size: 18px;\n+ text-align: center;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -120,18 +120,6 @@ svg.nav-bar-icon {\npadding-right: 8px;\nfont-size: 20px;\n}\n-div.chatBadge {\n- display: inline-block;\n- box-sizing: border-box;\n- width: 25px;\n- height: 25px;\n- margin-left: 8px;\n- color: white;\n- background-color: red;\n- border-radius: 13px;\n- font-size: 18px;\n- text-align: center;\n-}\ndiv.main-content-container {\nposition: relative;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [navigation] [2/n] move unread functionality to sidebar
Summary: move unread functionality to sidebar {F8993}
Test Plan: send a message to a test user and confirm correct unread count is showing up
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2881 |
129,179 | 25.01.2022 09:07:30 | 18,000 | f90c6d545ba2fd9770ae3a9e3e8e877b68558ec0 | [web] [navigation] [4/n] remove old navigation from header
Summary: remove app switcher from header {F9066}
Test Plan: make sure all code from header is gone
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -6,8 +6,6 @@ import '@fontsource/inter/600.css';\nimport 'basscss/css/basscss.min.css';\nimport './theme.css';\nimport { config as faConfig } from '@fortawesome/fontawesome-svg-core';\n-import { faCalendar, faComments } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport _isEqual from 'lodash/fp/isEqual';\nimport * as React from 'react';\nimport { DndProvider } from 'react-dnd';\n@@ -164,30 +162,6 @@ class App extends React.PureComponent<Props, State> {\n<header className={css['header']}>\n<div className={css['main-header']}>\n<h1>Comm</h1>\n- <ul className={css['nav-bar']}>\n- <li>\n- <div>\n- <a>\n- <FontAwesomeIcon\n- icon={faCalendar}\n- className={css['nav-bar-icon']}\n- />\n- Calendar\n- </a>\n- </div>\n- </li>\n- <li>\n- <div>\n- <a>\n- <FontAwesomeIcon\n- icon={faComments}\n- className={css['nav-bar-icon']}\n- />\n- Chat\n- </a>\n- </div>\n- </li>\n- </ul>\n<div className={css['upper-right']}>\n<LoadingIndicator\nstatus={this.props.entriesLoadingStatus}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -84,28 +84,6 @@ div.main-header > h1 {\nfont-weight: var(--semi-bold);\nfont-size: var(--logo-font-22);\n}\n-ul.nav-bar {\n- position: absolute;\n- padding-left: 180px;\n-}\n-ul.nav-bar > li {\n- display: inline-block;\n- list-style-type: none;\n- font-size: 18px;\n- font-weight: 600;\n- cursor: pointer;\n- text-transform: uppercase;\n-}\n-ul.nav-bar > li > div {\n- padding: 3px 20px 3px 20px;\n-}\n-ul.nav-bar > li > div > a {\n- color: var(--fg);\n-}\n-svg.nav-bar-icon {\n- padding-right: 8px;\n- font-size: 20px;\n-}\ndiv.main-content-container {\nposition: relative;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [navigation] [4/n] remove old navigation from header
Summary: remove app switcher from header {F9066}
Test Plan: make sure all code from header is gone
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2884 |
129,179 | 20.01.2022 13:06:38 | 18,000 | ec30731c5f856cf55393adb22baf1fe44c424b1c | [web] [style app switcher] [1/n] add SWM icons
Summary: add icons to side bar per design. Designing sidebar coming in future diffs {F9196}
Test Plan: make sure icons render
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -11,6 +11,7 @@ import {\n} from 'lib/selectors/thread-selectors';\nimport { useSelector } from '../redux/redux-utils';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport getTitle from '../title/getTitle';\nimport { updateNavInfoActionType } from '../types/nav-types';\nimport css from './sidebar.css';\n@@ -88,13 +89,15 @@ function AppSwitcher(): React.Node {\n<ul>\n<li>\n<p className={calendarNavClasses}>\n+ <SWMansionIcon icon=\"calendar\" color=\"#fff\" size={24} />\n<a onClick={onClickCalendar}>Calendar</a>\n</p>\n</li>\n<li>\n<p className={chatNavClasses}>\n- <a onClick={onClickChat}>Chat</a>\n+ <SWMansionIcon icon=\"message-square\" color=\"#fff\" size={24} />\n{chatBadge}\n+ <a onClick={onClickChat}>Chat</a>\n</p>\n</li>\n</ul>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [1/n] add SWM icons
Summary: add icons to side bar per design. Designing sidebar coming in future diffs {F9196}
Test Plan: make sure icons render
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2893 |
129,179 | 20.01.2022 13:21:06 | 18,000 | ae10dc96b396cfaddc7f4b4288ca59d494478e13 | [web] [style app switcher] [2/n] toggle color on app switch
Summary: when clicking between apps (cal, chat) navigation toggles color both icon and text {F9202}
Test Plan: colors should toggle
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -89,13 +89,13 @@ function AppSwitcher(): React.Node {\n<ul>\n<li>\n<p className={calendarNavClasses}>\n- <SWMansionIcon icon=\"calendar\" color=\"#fff\" size={24} />\n+ <SWMansionIcon icon=\"calendar\" size={24} />\n<a onClick={onClickCalendar}>Calendar</a>\n</p>\n</li>\n<li>\n<p className={chatNavClasses}>\n- <SWMansionIcon icon=\"message-square\" color=\"#fff\" size={24} />\n+ <SWMansionIcon icon=\"message-square\" size={24} />\n{chatBadge}\n<a onClick={onClickChat}>Chat</a>\n</p>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/sidebar.css",
"new_path": "web/sidebar/sidebar.css",
"diff": "color: var(--color-disabled);\n}\n+.container svg {\n+ color: var(--color-disabled);\n+}\n+\ndiv.chatBadge {\ndisplay: inline-block;\nbox-sizing: border-box;\n@@ -32,6 +36,12 @@ div.chatBadge {\ntext-align: center;\n}\n-p.current-tab a {\n+p.current-tab svg {\n+ color: var(--fg);\n+}\n+\n+p.current-tab a,\n+p.current-tab svg {\n+ fill: var(--fg);\ncolor: var(--fg);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [2/n] toggle color on app switch
Summary: when clicking between apps (cal, chat) navigation toggles color both icon and text {F9202}
Test Plan: colors should toggle
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2894 |
129,179 | 20.01.2022 13:39:34 | 18,000 | b6a51ebd4377302ea61ff0b646445336bf742e78 | [web] [style app switcher] [3/n] style notification bell
Summary:
style notif bell on sidebar
{F9208}
{F9209}
Test Plan: have a notif, make sure it looks right
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -95,8 +95,10 @@ function AppSwitcher(): React.Node {\n</li>\n<li>\n<p className={chatNavClasses}>\n+ <span className={css.chatIconWrapper}>\n<SWMansionIcon icon=\"message-square\" size={24} />\n{chatBadge}\n+ </span>\n<a onClick={onClickChat}>Chat</a>\n</p>\n</li>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/sidebar.css",
"new_path": "web/sidebar/sidebar.css",
"diff": "color: var(--color-disabled);\n}\n+.chatIconWrapper {\n+ position: relative;\n+}\n+\ndiv.chatBadge {\n- display: inline-block;\n+ position: absolute;\n+ top: -4px;\n+ left: 13px;\nbox-sizing: border-box;\n- width: 25px;\n- height: 25px;\n- margin-left: 8px;\n- color: white;\n- background-color: red;\n+ display: flex;\n+ align-items: center;\n+ justify-content: center;\n+ width: 16px;\n+ height: 16px;\n+ color: var(--fg);\n+ background: var(--unread-bg);\nborder-radius: 13px;\n- font-size: 18px;\n- text-align: center;\n+ font-size: 8px;\n+ line-height: 1.25;\n}\np.current-tab svg {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--calendar-day-bg: var(--shades-black-60);\n--calendar-day-selected-color: var(--violet-dark-80);\n--community-bg: var(--shades-black-90);\n+ --unread-bg: var(--error-primary);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [3/n] style notification bell
Summary:
style notif bell on sidebar
{F9208}
{F9209}
Test Plan: have a notif, make sure it looks right
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2895 |
129,179 | 20.01.2022 13:51:49 | 18,000 | 5676b6ecfdea01004638ef317b4f606fe392ced9 | [web] [style app switcher] [4/n] space nav items
Summary: space nav items accordingly {F9232}
Test Plan: make sure they match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/sidebar.css",
"new_path": "web/sidebar/sidebar.css",
"diff": ".container ul {\nlist-style-type: none;\n+ padding-top: 24px;\n+ padding-left: 28px;\n}\n.container ul li {\ncursor: pointer;\n+ padding-bottom: 24px;\n+ line-height: 0;\n+}\n+\n+.container p {\n+ display: flex;\n+ align-content: center;\n}\n.container ul a {\n.container svg {\ncolor: var(--color-disabled);\n+ padding-right: 12px;\n}\n.chatIconWrapper {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [style app switcher] [4/n] space nav items
Summary: space nav items accordingly {F9232}
Test Plan: make sure they match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2897 |
129,179 | 20.01.2022 15:35:20 | 18,000 | 1c461c79b72cbb16416c41d1adb30e4a6ad10d1e | [web] [2/n] [style chat tabs] add icons
Summary: add swm icons to tab switcher, layout styles coming in future diffs {F9254}
Test Plan: icons should render like the screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.react.js",
"new_path": "web/chat/chat-tabs.react.js",
"diff": "@@ -42,11 +42,13 @@ function ChatTabs(props: Props): React.Node {\ntitle=\"Focus\"\ntabIsActive={activeTab === 'Focus'}\nonClick={onClickHome}\n+ icon=\"message-square-lines\"\n/>\n<ChatThreadTab\ntitle={backgroundTitle}\ntabIsActive={activeTab === 'Background'}\nonClick={onClickBackground}\n+ icon=\"bell-disabled\"\n/>\n</div>\n<div className={css.threadList}>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-tab.react.js",
"new_path": "web/chat/chat-thread-tab.react.js",
"diff": "import classNames from 'classnames';\nimport * as React from 'react';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-tabs.css';\ntype Props = {\n+title: string,\n+onClick: (title: string) => void,\n+tabIsActive: boolean,\n+ +icon: string,\n};\nfunction ChatThreadTab(props: Props): React.Node {\n- const { title, onClick, tabIsActive } = props;\n+ const { title, onClick, tabIsActive, icon } = props;\nconst className = classNames({\n[css.tabItem]: true,\n[css.tabItemActive]: tabIsActive,\n@@ -19,6 +21,7 @@ function ChatThreadTab(props: Props): React.Node {\n});\nreturn (\n<div className={className} onClick={onClick}>\n+ <SWMansionIcon icon={icon} size={24} />\n{title}\n</div>\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] [style chat tabs] add icons
Summary: add swm icons to tab switcher, layout styles coming in future diffs {F9254}
Test Plan: icons should render like the screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2901 |
129,179 | 20.01.2022 16:16:53 | 18,000 | fc1e458219c0d9f939fa32f61e9ffb88153efc39 | [web] [3/n] [style chat tabs] add spacing to chat tabs
Summary: add correct spacing. I accidentally added the wrong icon. {F9260}
Test Plan: make sure it looks like the figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-tabs.css",
"new_path": "web/chat/chat-tabs.css",
"diff": "@@ -17,12 +17,19 @@ div.tabs {\n}\ndiv.tabItem {\n- flex: 1;\n- display: inline-block;\n- padding: 0.5rem 0.75rem;\n+ display: flex;\n+ justify-content: center;\n+ width: 50%;\n+ padding: 16px 0;\ntext-align: center;\ncursor: pointer;\n}\n+div.tabItem span {\n+ display: flex;\n+}\n+div.tabItem span svg {\n+ padding-right: 12px;\n+}\ndiv.tabItemActive {\nborder: outset var(--thread-selection);\nborder-width: 0 0 3px 0;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-tab.react.js",
"new_path": "web/chat/chat-thread-tab.react.js",
"diff": "@@ -21,8 +21,10 @@ function ChatThreadTab(props: Props): React.Node {\n});\nreturn (\n<div className={className} onClick={onClick}>\n+ <span>\n<SWMansionIcon icon={icon} size={24} />\n{title}\n+ </span>\n</div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [3/n] [style chat tabs] add spacing to chat tabs
Summary: add correct spacing. I accidentally added the wrong icon. {F9260} https://linear.app/comm/issue/ENG-556/update-chat-tabs-with-the-correct-icon
Test Plan: make sure it looks like the figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2902 |
129,191 | 19.01.2022 16:40:45 | -3,600 | 7737291460d3b3a9c8fc1b5fe172cfcb0fab721f | [CommCoreModule] Remove notification from the center
Summary: When a CLEAR notification is received, we search for a notification and clear it in the notifications center
Test Plan: This diff was tested with the next diff
Reviewers: karol-bisztyga, marcinwasowicz, ashoat
Subscribers: benschac, ashoat, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/AppDelegate.mm",
"new_path": "native/ios/Comm/AppDelegate.mm",
"diff": "@@ -57,6 +57,8 @@ static void InitializeFlipper(UIApplication *application) {\n#import <RNReanimated/REAEventDispatcher.h>\n#import <RNReanimated/REAModule.h>\n+#import <UserNotifications/UserNotifications.h>\n+\nNSString *const backgroundNotificationTypeKey = @\"backgroundNotifType\";\n@interface AppDelegate () <\n@@ -208,6 +210,23 @@ extern RCTBridge *_bridge_reanimated;\n});\n});\nreturn YES;\n+ } else if ([notification[backgroundNotificationTypeKey]\n+ isEqualToString:@\"CLEAR\"]) {\n+ [[UNUserNotificationCenter currentNotificationCenter]\n+ getDeliveredNotificationsWithCompletionHandler:^(\n+ NSArray<UNNotification *> *notifications) {\n+ for (UNNotification *notif in notifications) {\n+ if ([notification[@\"notificationId\"]\n+ isEqual:notif.request.content.userInfo[@\"id\"]]) {\n+ NSArray *identifiers =\n+ [NSArray arrayWithObjects:notif.request.identifier, nil];\n+ [[UNUserNotificationCenter currentNotificationCenter]\n+ removeDeliveredNotificationsWithIdentifiers:identifiers];\n+ }\n+ }\n+ completionHandler(UIBackgroundFetchResultNewData);\n+ }];\n+ return YES;\n}\nreturn NO;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Remove notification from the center
Summary: When a CLEAR notification is received, we search for a notification and clear it in the notifications center
Test Plan: This diff was tested with the next diff
Reviewers: karol-bisztyga, marcinwasowicz, ashoat
Reviewed By: karol-bisztyga, ashoat
Subscribers: benschac, ashoat, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D2891 |
129,179 | 27.01.2022 07:42:57 | 18,000 | 882f4366eda7507b8b8e08932d0452c34fcaea66 | [web] [refactor] move modal styles to its own file
Summary: move styles to it's own file because I need to update modal styles in upcoming diffs {F10102}
Test Plan: make sure styles still render on page
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/modal.css",
"diff": "+div.modal-overlay {\n+ position: fixed;\n+ left: 0;\n+ top: 0;\n+ bottom: 0;\n+ z-index: 4;\n+ width: 100%;\n+ background-color: rgba(0, 0, 0, 0.4);\n+ display: flex;\n+ flex-direction: column;\n+ align-items: center;\n+ overflow: auto;\n+}\n+div.resizable-modal-overlay {\n+ min-height: 60px;\n+}\n+div.small-modal-overlay {\n+ padding-top: 100px;\n+}\n+div.large-modal-overlay {\n+ padding-top: 50px;\n+}\n+div.modal-container {\n+ background: var(--bg);\n+ background-size: 3000px 2000px;\n+ max-width: 330px;\n+ border-radius: 15px;\n+ display: flex;\n+ min-height: 0;\n+ max-height: 500px;\n+}\n+div.large-modal-container {\n+ max-width: 500px;\n+}\n+div.modal {\n+ position: relative;\n+ box-shadow: 0 4px 20px rgba(0, 0, 0, 0.3), 0 0 0 1px rgba(0, 0, 0, 0.1);\n+ background-color: rgba(255, 255, 255, 0.61);\n+ border-radius: 15px;\n+ flex: 1;\n+ display: flex;\n+ flex-direction: column;\n+ width: 330px;\n+}\n+div.large-modal-container div.modal {\n+ width: 500px;\n+}\n+div.fixed-height-modal {\n+ height: 100%;\n+}\n+span.modal-close {\n+ float: right;\n+ font-size: 32px;\n+ font-weight: 300;\n+ line-height: 30px;\n+}\n+span.modal-close:hover {\n+ color: black;\n+ cursor: pointer;\n+}\n+div.modal-header {\n+ padding: 8px 15px;\n+}\n+div.modal-header > h2 {\n+ font-size: 22px;\n+ font-weight: 300;\n+}\n+\n+div.intro-modal {\n+ padding: 10px 21px 12px 21px;\n+ border-radius: 5px;\n+ border: 1px solid #c8c8c8;\n+ background-color: #f8f8f8;\n+ width: 310px;\n+ position: fixed;\n+ font-family: var(--font-stack);\n+ margin-top: 100px;\n+ box-shadow: 2px 3px 6px 0px rgba(0, 0, 0, 0.1);\n+}\n+\n+@media only screen and (-webkit-min-device-pixel-ratio: 2),\n+ only screen and (min--moz-device-pixel-ratio: 2),\n+ only screen and (-o-min-device-pixel-ratio: 2/1),\n+ only screen and (min-device-pixel-ratio: 2),\n+ only screen and (min-resolution: 320dpi),\n+ only screen and (min-resolution: 2dppx) {\n+ div.modal-container {\n+ background: var(--bg);\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/modal.react.js",
"new_path": "web/modals/modal.react.js",
"diff": "@@ -4,7 +4,7 @@ import classNames from 'classnames';\nimport invariant from 'invariant';\nimport * as React from 'react';\n-import css from '../style.css';\n+import css from './modal.css';\nexport type ModalSize = 'small' | 'large';\ntype Props = {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -166,197 +166,6 @@ span.loading-indicator-error-black {\nline-height: 0;\n}\n-div.account-bar {\n- background-color: #f8f8f8;\n- border: 1px solid #c8c8c8;\n- border-radius: 5px;\n- font-weight: 600;\n- padding: 0 6px;\n- cursor: pointer;\n- float: right;\n-}\n-div.account-button {\n- padding: 3px 4px 3px 8px;\n-}\n-div.account-button > span {\n- font-size: 16px;\n-}\n-div.account-menu {\n- outline: none;\n-}\n-div.account-menu > div {\n- border-top: 1px solid #c8c8c8;\n- padding: 3px 4px 3px 8px;\n-}\n-span.username {\n- display: inline-block;\n- color: #2a5db0;\n- cursor: pointer;\n- text-overflow: ellipsis;\n- overflow: hidden;\n- max-width: 200px;\n- vertical-align: bottom;\n-}\n-svg.account-caret {\n- padding-left: 6px;\n- fill: #2a5db0;\n- cursor: pointer;\n- height: 10px;\n- width: 10px;\n-}\n-\n-div.modal-overlay {\n- position: fixed;\n- left: 0;\n- top: 0;\n- bottom: 0;\n- z-index: 4;\n- width: 100%;\n- background-color: rgba(0, 0, 0, 0.4);\n- display: flex;\n- flex-direction: column;\n- align-items: center;\n- overflow: auto;\n-}\n-div.resizable-modal-overlay {\n- min-height: 60px;\n-}\n-div.small-modal-overlay {\n- padding-top: 100px;\n-}\n-div.large-modal-overlay {\n- padding-top: 50px;\n-}\n-div.modal-container {\n- background: var(--bg);\n- background-size: 3000px 2000px;\n- max-width: 330px;\n- border-radius: 15px;\n- display: flex;\n- min-height: 0;\n- max-height: 500px;\n-}\n-div.large-modal-container {\n- max-width: 500px;\n-}\n-div.modal {\n- position: relative;\n- box-shadow: 0 4px 20px rgba(0, 0, 0, 0.3), 0 0 0 1px rgba(0, 0, 0, 0.1);\n- background-color: rgba(255, 255, 255, 0.61);\n- border-radius: 15px;\n- flex: 1;\n- display: flex;\n- flex-direction: column;\n- width: 330px;\n-}\n-div.large-modal-container div.modal {\n- width: 500px;\n-}\n-div.fixed-height-modal {\n- height: 100%;\n-}\n-span.modal-close {\n- float: right;\n- font-size: 32px;\n- font-weight: 300;\n- line-height: 30px;\n-}\n-span.modal-close:hover {\n- color: black;\n- cursor: pointer;\n-}\n-div.modal-header {\n- padding: 8px 15px;\n-}\n-div.modal-header > h2 {\n- font-size: 22px;\n- font-weight: 300;\n-}\n-div.modal-body {\n- padding: 6px 6px;\n- width: 100%;\n- box-sizing: border-box;\n- background-color: white;\n- border-bottom-left-radius: 15px;\n- border-bottom-right-radius: 15px;\n- flex: 1;\n- display: flex;\n- flex-direction: column;\n-}\n-div.resized-modal-body {\n- min-height: 250px;\n-}\n-div.modal-body p {\n- padding: 1px 3px 4px 3px;\n- font-size: 14px;\n- text-align: center;\n-}\n-div.modal-body p.form-pre-footer {\n- padding-top: 5px;\n- font-size: 12px;\n- font-style: italic;\n-}\n-div.modal-body input,\n-div.modal-body textarea {\n- margin: 3px;\n-}\n-div.modal-body input[type='text'],\n-div.modal-body input[type='password'],\n-div.modal-body textarea {\n- font-size: 14px;\n- padding: 1px;\n- width: 175px;\n-}\n-div.large-modal-container div.modal-body input[type='text'],\n-div.large-modal-container div.modal-body input[type='password'],\n-div.large-modal-container div.modal-body textarea {\n- width: 275px;\n-}\n-div.modal-body input[type='submit'] {\n- padding: 3px 9px;\n- font-size: 12px;\n- margin-right: 3px;\n- border-radius: 3px;\n- border: 1px solid #c8c8c8;\n- background-color: #f8f8f8;\n- font-weight: 600;\n- color: #444444;\n- margin-top: 1px;\n- cursor: pointer;\n-}\n-div.modal-body input[type='submit']:hover {\n- text-decoration: underline;\n-}\n-div.modal-body input[type='submit']:disabled {\n- cursor: initial;\n- text-decoration: none;\n- color: #999999;\n-}\n-\n-div.modal-body div.form-title {\n- display: inline-block;\n- text-align: right;\n- padding-right: 5px;\n- padding-top: 5px;\n- font-size: 14px;\n- font-weight: 600;\n- vertical-align: top;\n- width: 110px;\n-}\n-div.large-modal-container div.modal-body div.form-title {\n- width: 140px;\n-}\n-div.modal-body div.form-content {\n- display: inline-block;\n- font-family: var(--font-stack);\n- font-size: 15px;\n-}\n-div.modal-body div.form-subtitle {\n- font-size: 12px;\n- padding-left: 4px;\n- font-style: italic;\n-}\n-\ndiv.form-enum-selector {\ndisplay: inline-block;\npadding-bottom: 4px;\n@@ -545,18 +354,6 @@ div.color-picker-selector {\ntop: 34px;\n}\n-div.intro-modal {\n- padding: 10px 21px 12px 21px;\n- border-radius: 5px;\n- border: 1px solid #c8c8c8;\n- background-color: #f8f8f8;\n- width: 310px;\n- position: fixed;\n- font-family: var(--font-stack);\n- margin-top: 100px;\n- box-shadow: 2px 3px 6px 0px rgba(0, 0, 0, 0.1);\n-}\n-\n@media only screen and (-webkit-min-device-pixel-ratio: 2),\nonly screen and (min--moz-device-pixel-ratio: 2),\nonly screen and (-o-min-device-pixel-ratio: 2/1),\n@@ -568,7 +365,6 @@ div.intro-modal {\ndiv.splash-header-container,\ndiv.splash-top-container,\ndiv.splash-bottom,\n- div.modal-container,\ndiv.calendar-filters-container {\nbackground: var(--bg);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move modal styles to its own file
Summary: move styles to it's own file because I need to update modal styles in upcoming diffs {F10102}
Test Plan: make sure styles still render on page
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2938 |
129,179 | 27.01.2022 08:31:42 | 18,000 | 20477fadef6e5bc31fdcb4f425260c9f29ae0a38 | [web] [fix] Comm header aligned correctly per figma
Summary: Header left-padding match figma {F9890}
Test Plan: should look like figma {F9891}
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -78,7 +78,7 @@ div.main-header {\n}\ndiv.main-header > h1 {\ncolor: var(--fg);\n- padding: 0 6px;\n+ padding-left: 92px;\nfont-family: var(--font-logo);\nline-height: var(--line-height-text);\nfont-weight: var(--semi-bold);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] Comm header aligned correctly per figma
Summary: Header left-padding match figma {F9890}
Test Plan: should look like figma {F9891} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1272%3A88750
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2923 |
129,179 | 27.01.2022 08:35:48 | 18,000 | 7eba76f03f4654b9843d961376a3e704848e7a3d | [web] [docs] add a comment on how to use colors in the theme.css file
Summary: short comment to reduce diff review churn on new theme'ing concept
Test Plan: make sure the comment makes sense
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": ":root {\n+ /* Never use color values defined here directly in CSS. Add color variables to \"Color Theme\" below\n+\n+ The reason we never use color values defined here directly in CSS is\n+\n+ 1. It makes changing themes from light / dark / user generated impossible.\n+ 2. Gives the programmer context into the color being used.\n+ 3. If our color system changes it's much easier to change color values in one place.\n+\n+ Add a color value to the theme below, and then use it in your CSS.\n+ naming convention:\n+ - bg: background.\n+ - fg: foreground.\n+ - color: text-color\n+ */\n--shades-white-100: #ffffff;\n--shades-white-90: #f5f5f5;\n--shades-white-80: #ebebeb;\n--error: var(--error-primary);\n--success: var(--success-dark-50);\n- /* Color theme */\n+ /* Color Theme */\n--btn-bg-primary: var(--violet-dark-100);\n--chat-bg: var(--violet-dark-80);\n--chat-confirmation-icon: var(--violet-dark-100);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [docs] add a comment on how to use colors in the theme.css file
Summary: short comment to reduce diff review churn on new theme'ing concept
Test Plan: make sure the comment makes sense
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2939 |
129,179 | 27.01.2022 08:41:35 | 18,000 | 267f2f4945577f4cea698593c382c0dd6b420e4d | [web] swap out font icon for software mansion icon in menu button
Summary: change menu icon to match figma {F10134}
Test Plan: It should render correctly
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "// @flow\n-import { faEllipsisV } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport classNames from 'classnames';\nimport * as React from 'react';\n@@ -19,6 +17,7 @@ import {\nuseDispatchActionPromise,\n} from 'lib/utils/action-utils';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-thread-list.css';\ntype Props = {\n@@ -74,7 +73,7 @@ function ChatThreadListItemMenu(props: Props): React.Node {\nreturn (\n<div className={css.menu} onMouseLeave={hideMenu}>\n<button onClick={toggleMenu}>\n- <FontAwesomeIcon icon={faEllipsisV} />\n+ <SWMansionIcon icon=\"menu-vertical\" size={24} />\n</button>\n<div\nclassName={classNames(css.menuContent, {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] swap out font icon for software mansion icon in menu button
Summary: change menu icon to match figma {F10134}
Test Plan: It should render correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2941 |
129,179 | 25.01.2022 14:02:30 | 18,000 | f8cb9cc0092c99d72bc67bfa9e39be703ed484da | [web] [1/n] add inbox icon
Summary:
add icon on sidebar. This is non-functional because we don't have community switcher {F9916}
Test Plan: make sure the page matches the figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.css",
"new_path": "web/sidebar/community-picker.css",
"diff": ".container {\ndisplay: flex;\nflex-direction: column;\n+ align-items: center;\nwidth: 84px;\nbackground: var(--community-bg);\n+ padding-top: 24px;\nborder-right: 1px solid var(--border-color);\n}\n+\n+.container svg {\n+ color: var(--fg);\n+ padding: 0;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.react.js",
"new_path": "web/sidebar/community-picker.react.js",
"diff": "import * as React from 'react';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport css from './community-picker.css';\nfunction CommunityPicker(): React.Node {\n- return <div className={css.container}></div>;\n+ return (\n+ <div className={css.container}>\n+ <SWMansionIcon icon=\"inbox\" size={28} />\n+ </div>\n+ );\n}\nexport default CommunityPicker;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [1/n] add inbox icon
Summary:
add icon on sidebar. This is non-functional because we don't have community switcher {F9916}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77595
Test Plan: make sure the page matches the figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2924 |
129,179 | 25.01.2022 14:37:14 | 18,000 | 33811c7e7c2b3c48cd7b3feb716de01b26dd13b5 | [web] [2/n] add settings gear icon to community switcher
Summary: add settings gear button {F9928}
Test Plan: should look like figma, button doesn't do anything yet
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.css",
"new_path": "web/sidebar/community-picker.css",
"diff": "align-items: center;\nwidth: 84px;\nbackground: var(--community-bg);\n- padding-top: 24px;\n+ padding: 24px 0 32px 0;\nborder-right: 1px solid var(--border-color);\n+ flex-grow: 1;\n+}\n+\n+.spacer {\n+ flex-grow: 1;\n+}\n+\n+.container button {\n+ color: var(--fg);\n}\n.container svg {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.react.js",
"new_path": "web/sidebar/community-picker.react.js",
"diff": "@@ -4,11 +4,16 @@ import * as React from 'react';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './community-picker.css';\n+import SettingsButton from './settings-button.react';\nfunction CommunityPicker(): React.Node {\nreturn (\n<div className={css.container}>\n<SWMansionIcon icon=\"inbox\" size={28} />\n+ <div className={css.spacer} />\n+ <SettingsButton onClick={() => {}}>\n+ <SWMansionIcon icon=\"settings\" size={16} />\n+ </SettingsButton>\n</div>\n);\n}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/settings-button.css",
"diff": "+.btn {\n+ width: 30px;\n+ height: 30px;\n+ display: flex;\n+ align-items: center;\n+ justify-content: center;\n+ background: var(--settings-btn-bg);\n+ border-radius: 50%;\n+ border-color: transparent;\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/settings-button.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import css from './settings-button.css';\n+\n+type Props = {\n+ +onClick: () => mixed,\n+ +children: React.Node,\n+};\n+\n+function SettingsButton(props: Props): React.Node {\n+ const { onClick, children } = props;\n+ return (\n+ <button className={css.btn} onClick={onClick}>\n+ {children}\n+ </button>\n+ );\n+}\n+\n+export default SettingsButton;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--calendar-day-selected-color: var(--violet-dark-80);\n--community-bg: var(--shades-black-90);\n--unread-bg: var(--error-primary);\n+ --settings-btn-bg: var(--violet-dark-100);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [2/n] add settings gear icon to community switcher
Summary: add settings gear button {F9928}
Test Plan: should look like figma, button doesn't do anything yet
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2925 |
129,179 | 25.01.2022 16:22:34 | 18,000 | 995e56fe6331c6e5b8505404766b317bbe00b8be | [web] [4/n] show user modal on settings gear click
Summary: on click, user should be show modal {F9962}
Test Plan: click modal
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -35,7 +35,7 @@ import FocusHandler from './redux/focus-handler.react';\nimport { useSelector } from './redux/redux-utils';\nimport VisibilityHandler from './redux/visibility-handler.react';\nimport history from './router-history';\n-import SideBar from './sidebar/sidebar.react';\n+import LeftLayoutAside from './sidebar/left-layout-aside.react';\nimport Splash from './splash/splash.react';\nimport './typography.css';\nimport css from './style.css';\n@@ -178,7 +178,7 @@ class App extends React.PureComponent<Props, State> {\n<div className={css['main-content']}>{mainContent}</div>\n</div>\n</InputStateContainer>\n- <SideBar />\n+ <LeftLayoutAside setModal={this.setModal} />\n</div>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/app-switcher.react.js",
"new_path": "web/sidebar/app-switcher.react.js",
"diff": "@@ -14,7 +14,7 @@ import { useSelector } from '../redux/redux-utils';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport getTitle from '../title/getTitle';\nimport { updateNavInfoActionType } from '../types/nav-types';\n-import css from './sidebar.css';\n+import css from './left-layout-aside.css';\nfunction AppSwitcher(): React.Node {\nconst activeChatThreadID = useSelector(\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.react.js",
"new_path": "web/sidebar/community-picker.react.js",
"diff": "import * as React from 'react';\n+import UserSettingsModal from '../modals/account/user-settings-modal.react.js';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './community-picker.css';\nimport SettingsButton from './settings-button.react';\n-function CommunityPicker(): React.Node {\n+type Props = { +setModal: (modal: ?React.Node) => void };\n+\n+function CommunityPicker(props: Props): React.Node {\n+ const { setModal } = props;\n+\n+ const setModalToUserSettings = React.useCallback(() => {\n+ setModal(<UserSettingsModal setModal={setModal} />);\n+ }, [setModal]);\n+\nreturn (\n<div className={css.container}>\n<SWMansionIcon icon=\"inbox\" size={28} />\n<div className={css.spacer} />\n- <SettingsButton onClick={() => {}}>\n+ <SettingsButton onClick={setModalToUserSettings}>\n<SWMansionIcon icon=\"settings\" size={16} />\n</SettingsButton>\n</div>\n"
},
{
"change_type": "RENAME",
"old_path": "web/sidebar/sidebar.css",
"new_path": "web/sidebar/left-layout-aside.css",
"diff": ""
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/sidebar/left-layout-aside.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import AppSwitcher from './app-switcher.react';\n+import CommunityPicker from './community-picker.react';\n+import css from './left-layout-aside.css';\n+type Props = {\n+ +setModal: (modal: ?React.Node) => void,\n+};\n+\n+function LeftLayoutAside(props: Props): React.Node {\n+ const { setModal } = props;\n+ return (\n+ <aside className={css.container}>\n+ <CommunityPicker setModal={setModal} />\n+ <AppSwitcher />\n+ </aside>\n+ );\n+}\n+\n+export default LeftLayoutAside;\n"
},
{
"change_type": "DELETE",
"old_path": "web/sidebar/sidebar.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import * as React from 'react';\n-\n-import AppSwitcher from './app-switcher.react';\n-import CommunityPicker from './community-picker.react';\n-import css from './sidebar.css';\n-\n-function SideBar(): React.Node {\n- return (\n- <aside className={css.container}>\n- <CommunityPicker />\n- <AppSwitcher />\n- </aside>\n- );\n-}\n-\n-export default SideBar;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [4/n] show user modal on settings gear click
Summary: on click, user should be show modal {F9962}
Test Plan: click modal
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2929 |
129,179 | 25.01.2022 16:32:43 | 18,000 | 905cb8530664bd301c604cd847c4fa9ce4b73f20 | [web] [5/n] remove account bar
Summary: remove account bar from header {F9956}
Test Plan: header and all css from the header are deleted. Functionality lives in bottom left gear icon
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "DELETE",
"old_path": "web/account-bar.react.js",
"new_path": null,
"diff": "-// @flow\n-\n-import invariant from 'invariant';\n-import * as React from 'react';\n-\n-import { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\n-import type { PreRequestUserState } from 'lib/types/session-types';\n-import type { CurrentUserInfo } from 'lib/types/user-types';\n-import {\n- useDispatchActionPromise,\n- type DispatchActionPromise,\n-} from 'lib/utils/action-utils';\n-\n-import LogInModal from './modals/account/log-in-modal.react';\n-import UserSettingsModal from './modals/account/user-settings-modal.react.js';\n-import { useSelector } from './redux/redux-utils';\n-import css from './style.css';\n-import { htmlTargetFromEvent } from './vector-utils';\n-import { UpCaret, DownCaret } from './vectors.react';\n-\n-type BaseProps = {\n- +setModal: (modal: ?React.Node) => void,\n-};\n-type Props = {\n- ...BaseProps,\n- // Redux state\n- +currentUserInfo: ?CurrentUserInfo,\n- +preRequestUserState: PreRequestUserState,\n- // Redux dispatch functions\n- +dispatchActionPromise: DispatchActionPromise,\n-};\n-type State = {\n- +expanded: boolean,\n-};\n-class AccountBar extends React.PureComponent<Props, State> {\n- state: State = {\n- expanded: false,\n- };\n- menu: ?HTMLDivElement;\n-\n- componentDidUpdate(prevProps: Props, prevState: State) {\n- if (this.state.expanded && !prevState.expanded) {\n- invariant(this.menu, 'menu ref should be set');\n- this.menu.focus();\n- }\n- }\n-\n- get loggedIn() {\n- return !!(\n- this.props.currentUserInfo &&\n- !this.props.currentUserInfo.anonymous &&\n- true\n- );\n- }\n-\n- get username() {\n- return this.props.currentUserInfo && !this.props.currentUserInfo.anonymous\n- ? this.props.currentUserInfo.username\n- : undefined;\n- }\n-\n- render() {\n- if (!this.loggedIn) {\n- return (\n- <div className={css['account-bar']}>\n- <div className={css['account-button']}>\n- <span>\n- <a href=\"#\" onClick={this.onLogIn}>\n- Log in\n- </a>\n- </span>\n- </div>\n- </div>\n- );\n- }\n-\n- let menu = null;\n- if (this.state.expanded) {\n- menu = (\n- <div\n- className={css['account-menu']}\n- tabIndex=\"0\"\n- onBlur={this.onBlur}\n- onKeyDown={this.onMenuKeyDown}\n- ref={this.menuRef}\n- >\n- <div>\n- <a href=\"#\" onClick={this.onEditAccount}>\n- Edit account\n- </a>\n- </div>\n- </div>\n- );\n- }\n-\n- const caret = this.state.expanded ? (\n- <UpCaret className={css['account-caret']} />\n- ) : (\n- <DownCaret className={css['account-caret']} />\n- );\n- return (\n- <div className={css['account-bar']} onMouseDown={this.onMouseDown}>\n- <div className={css['account-button']}>\n- <span>{'logged in as '}</span>\n- <span className={css['username']}>{this.username}</span>\n- {caret}\n- </div>\n- {menu}\n- </div>\n- );\n- }\n-\n- menuRef = (menu: ?HTMLDivElement) => {\n- this.menu = menu;\n- };\n-\n- onBlur = () => {\n- this.setState({ expanded: false });\n- };\n-\n- // Throw away typechecking here because SyntheticEvent isn't typed\n- onMenuKeyDown = (event: any) => {\n- if (event.keyCode === 27) {\n- // Esc\n- this.setState({ expanded: false });\n- }\n- };\n-\n- onMouseDown = (event: SyntheticEvent<HTMLDivElement>) => {\n- if (!this.state.expanded) {\n- // This prevents onBlur from firing on div.account-menu\n- event.preventDefault();\n- this.setState({ expanded: true });\n- return;\n- }\n- const target = htmlTargetFromEvent(event);\n- invariant(this.menu, 'menu ref not set');\n- if (this.menu.contains(target)) {\n- // This prevents onBlur from firing on div.account-menu\n- event.preventDefault();\n- } else {\n- this.setState({ expanded: false });\n- }\n- };\n-\n- onEditAccount = (event: SyntheticEvent<HTMLAnchorElement>) => {\n- event.preventDefault();\n- // This will blur the focus off the menu which will set expanded to false\n- this.props.setModal(<UserSettingsModal setModal={this.props.setModal} />);\n- };\n-\n- onLogIn = (event: SyntheticEvent<HTMLAnchorElement>) => {\n- event.preventDefault();\n- this.props.setModal(<LogInModal setModal={this.props.setModal} />);\n- };\n-}\n-\n-const ConnectedAccountBar: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n- function ConnectedAccountBar(props) {\n- const currentUserInfo = useSelector(state => state.currentUserInfo);\n- const preRequestUserState = useSelector(preRequestUserStateSelector);\n- const dispatchActionPromise = useDispatchActionPromise();\n- return (\n- <AccountBar\n- {...props}\n- currentUserInfo={currentUserInfo}\n- preRequestUserState={preRequestUserState}\n- dispatchActionPromise={dispatchActionPromise}\n- />\n- );\n- },\n-);\n-\n-export default ConnectedAccountBar;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/app.react.js",
"new_path": "web/app.react.js",
"diff": "@@ -26,7 +26,6 @@ import type { LoadingStatus } from 'lib/types/loading-types';\nimport type { Dispatch } from 'lib/types/redux-types';\nimport { registerConfig } from 'lib/utils/config';\n-import AccountBar from './account-bar.react';\nimport Calendar from './calendar/calendar.react';\nimport Chat from './chat/chat.react';\nimport InputStateContainer from './input/input-state-container.react';\n@@ -169,7 +168,6 @@ class App extends React.PureComponent<Props, State> {\nloadingClassName={css['page-loading']}\nerrorClassName={css['page-error']}\n/>\n- <AccountBar setModal={this.setModal} />\n</div>\n</div>\n</header>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -360,7 +360,7 @@ div.color-picker-selector {\nonly screen and (min-device-pixel-ratio: 2),\nonly screen and (min-resolution: 320dpi),\nonly screen and (min-resolution: 2dppx) {\n- header.header,\n+ headqer.header,\nheader.main-header,\ndiv.splash-header-container,\ndiv.splash-top-container,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [5/n] remove account bar
Summary: remove account bar from header {F9956}
Test Plan: header and all css from the header are deleted. Functionality lives in bottom left gear icon
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2928 |
129,179 | 26.01.2022 08:26:21 | 18,000 | d24ac0f154c2feaf5e2b338c96f5b6c7e1a7dbc0 | [web] [refactor] destructure props in user settings modal render
Summary: touching the render / styles. Wanted to clean up the render and make it consistent with the project
Test Plan: make sure functionality isn't broken.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -39,14 +39,14 @@ type TabProps = {\n};\nclass Tab extends React.PureComponent<TabProps> {\nrender() {\n+ const { selected, name, tabType } = this.props;\nconst classNamesForTab = classNames({\n- [css['current-tab']]: this.props.selected,\n- [css['delete-tab']]:\n- this.props.selected && this.props.tabType === 'delete',\n+ [css['current-tab']]: selected,\n+ [css['delete-tab']]: selected && tabType === 'delete',\n});\nreturn (\n<li className={classNamesForTab} onClick={this.onClick}>\n- <a>{this.props.name}</a>\n+ <a>{name}</a>\n</li>\n);\n}\n@@ -117,6 +117,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n};\nrender() {\n+ const { inputDisabled } = this.props;\nlet mainContent = null;\nif (this.state.currentTabType === 'general') {\nmainContent = (\n@@ -135,7 +136,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nvalue={this.state.newPassword}\nonChange={this.onChangeNewPassword}\nref={this.newPasswordInputRef}\n- disabled={this.props.inputDisabled}\n+ disabled={inputDisabled}\n/>\n</div>\n<div>\n@@ -144,7 +145,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nplaceholder=\"Confirm new password\"\nvalue={this.state.confirmNewPassword}\nonChange={this.onChangeConfirmNewPassword}\n- disabled={this.props.inputDisabled}\n+ disabled={inputDisabled}\n/>\n</div>\n</div>\n@@ -167,7 +168,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\ntype=\"submit\"\nvalue=\"Delete account\"\nonClick={this.onDelete}\n- disabled={this.props.inputDisabled}\n+ disabled={inputDisabled}\n/>\n);\n} else {\n@@ -177,13 +178,13 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\ntype=\"submit\"\nvalue=\"Update account\"\nonClick={this.onSubmit}\n- disabled={this.props.inputDisabled}\n+ disabled={inputDisabled}\n/>\n<input\ntype=\"submit\"\nvalue=\"Log out\"\nonClick={this.onLogOut}\n- disabled={this.props.inputDisabled}\n+ disabled={inputDisabled}\n/>\n</>\n);\n@@ -221,7 +222,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nplaceholder=\"Current password\"\nvalue={this.state.currentPassword}\nonChange={this.onChangeCurrentPassword}\n- disabled={this.props.inputDisabled}\n+ disabled={inputDisabled}\nref={this.currentPasswordInputRef}\n/>\n</div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] destructure props in user settings modal render
Summary: touching the render / styles. Wanted to clean up the render and make it consistent with the project
Test Plan: make sure functionality isn't broken.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2936 |
129,179 | 26.01.2022 13:31:42 | 18,000 | 4e25167dc4eb994b57954c19844094d09e7db556 | [web] [refactor] side bar thread list props destructure
Summary: update props to match project
Test Plan: make sure app still renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -14,13 +14,14 @@ type Props = {\n+sidebarInfo: SidebarInfo,\n};\nfunction ChatThreadListSidebar(props: Props): React.Node {\n- const { threadInfo, mostRecentNonLocalMessage } = props.sidebarInfo;\n+ const { sidebarInfo } = props;\n+ const { threadInfo, mostRecentNonLocalMessage } = sidebarInfo;\nconst threadID = threadInfo.id;\nconst active = useThreadIsActive(threadID);\nconst activeStyle = active ? css.activeThread : null;\nreturn (\n<div className={classNames(css.thread, css.sidebar, activeStyle)}>\n- <SidebarItem sidebarInfo={props.sidebarInfo} />\n+ <SidebarItem sidebarInfo={sidebarInfo} />\n<ChatThreadListItemMenu\nthreadInfo={threadInfo}\nmostRecentNonLocalMessage={mostRecentNonLocalMessage}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] side bar thread list props destructure
Summary: update props to match project
Test Plan: make sure app still renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2942 |
129,179 | 26.01.2022 09:44:09 | 18,000 | bd7d3aea7e6a462b6968126f987567af99dd6a76 | [web] [modal] update color theme
Summary:
color matches figma
{F10343}
Test Plan: Color swatch is correct, design still isn't there. Just wanted the modal to not look super off
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -2,7 +2,7 @@ div.modal-body {\npadding: 6px 6px;\nwidth: 100%;\nbox-sizing: border-box;\n- background-color: white;\n+ background-color: var(--modal-bg);\nborder-bottom-left-radius: 15px;\nborder-bottom-right-radius: 15px;\nflex: 1;\n@@ -43,7 +43,7 @@ div.modal-body input[type='submit'] {\nfont-size: 12px;\nmargin-right: 3px;\nborder-radius: 3px;\n- border: 1px solid #c8c8c8;\n+ border: 1px solid var(--border-color);\nbackground-color: #f8f8f8;\nfont-weight: 600;\ncolor: #444444;\n@@ -70,7 +70,7 @@ div.modal-body div.form-footer {\njustify-content: space-between;\nalign-items: start;\nmargin-top: 5px;\n- border-top: 2px solid #efefef;\n+ border-top: 2px solid var(--border-color);\nmin-height: 26px;\npadding: 7px 4px 4px 0;\n}\n@@ -93,6 +93,7 @@ div.modal-body div.form-title {\nfont-weight: 600;\nvertical-align: top;\nwidth: 110px;\n+ color: var(--fg);\n}\ndiv.large-modal-container div.modal-body div.form-title {\nwidth: 140px;\n@@ -101,6 +102,7 @@ div.modal-body div.form-content {\ndisplay: inline-block;\nfont-family: var(--font-stack);\nfont-size: 15px;\n+ color: var(--fg);\n}\ndiv.modal-body div.form-subtitle {\nfont-size: 12px;\n@@ -141,10 +143,11 @@ div.form-text > div.form-float-content {\n.italic {\nfont-style: italic;\n+ color: var(--fg);\n}\nul.tab-panel {\n- background-color: #f4f4f4;\n+ background-color: var(--modal-bg);\npadding-left: 10px;\npadding-top: 5px;\n}\n@@ -164,7 +167,7 @@ ul.tab-panel > li.delete-tab > a {\n}\ndiv.user-settings-current-password {\n- border-top: 2px solid #efefef;\n+ border-top: 2px solid var(--border-color);\npadding-top: 4px;\nmargin-top: 5px;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/modal.css",
"new_path": "web/modals/modal.css",
"diff": "@@ -35,7 +35,7 @@ div.large-modal-container {\ndiv.modal {\nposition: relative;\nbox-shadow: 0 4px 20px rgba(0, 0, 0, 0.3), 0 0 0 1px rgba(0, 0, 0, 0.1);\n- background-color: rgba(255, 255, 255, 0.61);\n+ background-color: var(--modal-bg);\nborder-radius: 15px;\nflex: 1;\ndisplay: flex;\n@@ -53,6 +53,7 @@ span.modal-close {\nfont-size: 32px;\nfont-weight: 300;\nline-height: 30px;\n+ color: var(--fg);\n}\nspan.modal-close:hover {\ncolor: black;\n@@ -64,6 +65,7 @@ div.modal-header {\ndiv.modal-header > h2 {\nfont-size: 22px;\nfont-weight: 300;\n+ color: var(--fg);\n}\ndiv.intro-modal {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--community-bg: var(--shades-black-90);\n--unread-bg: var(--error-primary);\n--settings-btn-bg: var(--violet-dark-100);\n+ --modal-bg: var(--shades-black-90);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [modal] update color theme
Summary:
color matches figma
{F10343}
Test Plan: Color swatch is correct, design still isn't there. Just wanted the modal to not look super off
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2940 |
129,184 | 28.01.2022 15:09:13 | 18,000 | 5cc74a41fb1e75f483c641680af8772545458841 | [CommCoreModule] Modify `NetworkModule::sendPong()` to actually send pong
Summary: Also modify `networkClient:sendPong()` to log any error instead of crashing app if the gRPC endpoint isn't accessible.
Test Plan: Able to send a pong
Reviewers: palys-swm, varun, def-au1t, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"diff": "@@ -20,10 +20,10 @@ void NetworkModule::initializeNetworkModule(\n}\nvoid NetworkModule::sendPong() {\n- Logger::log(\"Sending PONG\");\n+ this->networkClient->sendPong();\n}\nvoid NetworkModule::close() {\n- networkClient.reset();\n+ this->networkClient.reset();\n}\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "#include \"Client.h\"\n#include \"Logger.h\"\n+#include <sstream>\nnamespace comm {\nnamespace network {\n@@ -56,9 +57,12 @@ void Client::sendPong() {\nrequest.set_userid(this->id);\nrequest.set_devicetoken(this->deviceToken);\n- grpc::Status status = stub_->SendPong(&context, request, &response);\n+ Logger::log(\"Sending PONG\");\n+ grpc::Status status = this->stub_->SendPong(&context, request, &response);\nif (!status.ok()) {\n- throw std::runtime_error(status.error_message());\n+ std::ostringstream errorMsg;\n+ errorMsg << \"Sending PONG failed: \" << status.error_message() << std::endl;\n+ Logger::log(errorMsg.str());\n}\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Modify `NetworkModule::sendPong()` to actually send pong
Summary: Also modify `networkClient:sendPong()` to log any error instead of crashing app if the gRPC endpoint isn't accessible.
Test Plan: Able to send a pong
Reviewers: palys-swm, varun, def-au1t, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2946 |
129,179 | 29.01.2022 10:37:51 | 18,000 | 1ccf3160c535debe64aae163640cb4f82c93fa73 | [web] import shared css in login modal
Summary: didn't realize login modal code was shared with user settings. Changing the import {F10444}
Test Plan: make sure the css is rendering
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -23,8 +23,8 @@ import {\nimport { useSelector } from '../../redux/redux-utils';\nimport { webLogInExtraInfoSelector } from '../../selectors/account-selectors';\n-import css from '../../style.css';\nimport Modal from '../modal.react';\n+import css from './user-settings-modal.css';\ntype BaseProps = {\n+setModal: (modal: ?React.Node) => void,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] import shared css in login modal
Summary: didn't realize login modal code was shared with user settings. Changing the import {F10444}
Test Plan: make sure the css is rendering
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2963 |
129,179 | 29.01.2022 10:40:08 | 18,000 | 38d4dbec75e2aa14f95a2badfd34148571f85b0b | [web] add plus to icon set
Summary: forgot to add plus icon to icomoon {F10392}
Test Plan: everything should work as before with icons
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 30,\n+ \"paths\": [\"M512 42.645v938.717M42.645 512h938.717\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-plus\"]\n+ },\n{\n\"id\": 29,\n\"paths\": [\n],\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n- \"grid\": 0,\n+ \"grid\": 24,\n\"tags\": [\"wrench\"],\n\"colorPermutations\": {\n\"204204204125525525513838381\": [\n},\n\"selection\": [\n{\n- \"order\": 119,\n+ \"order\": 148,\n+ \"id\": 29,\n+ \"name\": \"plus\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 149,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n{\n- \"order\": 120,\n+ \"order\": 150,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n{\n- \"order\": 121,\n+ \"order\": 151,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 122,\n+ \"order\": 152,\n\"id\": 27,\n\"name\": \"Union\",\n\"prevSize\": 32\n},\n{\n- \"order\": 123,\n+ \"order\": 153,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n{\n- \"order\": 124,\n+ \"order\": 154,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n{\n- \"order\": 125,\n+ \"order\": 155,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n{\n- \"order\": 126,\n+ \"order\": 156,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n{\n- \"order\": 127,\n+ \"order\": 157,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 128,\n+ \"order\": 158,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 129,\n+ \"order\": 159,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 130,\n+ \"order\": 160,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n{\n- \"order\": 131,\n+ \"order\": 161,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n{\n- \"order\": 132,\n+ \"order\": 162,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 133,\n+ \"order\": 163,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 134,\n+ \"order\": 164,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n{\n- \"order\": 135,\n+ \"order\": 165,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n{\n- \"order\": 136,\n+ \"order\": 166,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n{\n- \"order\": 137,\n+ \"order\": 167,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n{\n- \"order\": 138,\n+ \"order\": 168,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n{\n- \"order\": 139,\n+ \"order\": 169,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n{\n- \"order\": 140,\n+ \"order\": 170,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n{\n- \"order\": 141,\n+ \"order\": 171,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n{\n- \"order\": 142,\n+ \"order\": 172,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 143,\n+ \"order\": 173,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 144,\n+ \"order\": 174,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n{\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 145,\n+ \"order\": 175,\n\"prevSize\": 32\n},\n{\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 146,\n+ \"order\": 176,\n\"prevSize\": 32\n}\n],\n{\n\"order\": 0,\n\"id\": 104,\n- \"name\": \"outline-plus\"\n+ \"name\": \"outline-plus\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/icons/selection.json",
"new_path": "web/icons/selection.json",
"diff": "{\n\"IcoMoonType\": \"selection\",\n\"icons\": [\n+ {\n+ \"icon\": {\n+ \"paths\": [\"M512 42.645v938.717M42.645 512h938.717\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-plus\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 148,\n+ \"id\": 29,\n+ \"name\": \"plus\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 0\n+ },\n{\n\"icon\": {\n\"paths\": [\n}\n],\n\"properties\": {\n- \"order\": 119,\n+ \"order\": 149,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 0\n+ \"iconIdx\": 1\n},\n{\n\"icon\": {\n],\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n- \"grid\": 0,\n+ \"grid\": 24,\n\"tags\": [\"wrench\"],\n\"colorPermutations\": {\n\"204204204125525525513838381\": [\n}\n],\n\"properties\": {\n- \"order\": 120,\n+ \"order\": 150,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 1\n+ \"iconIdx\": 2\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 121,\n+ \"order\": 151,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 2\n+ \"iconIdx\": 3\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 122,\n+ \"order\": 152,\n\"id\": 27,\n\"name\": \"Union\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 3\n+ \"iconIdx\": 4\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 123,\n+ \"order\": 153,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 4\n+ \"iconIdx\": 5\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 124,\n+ \"order\": 154,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 5\n+ \"iconIdx\": 6\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 125,\n+ \"order\": 155,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 6\n+ \"iconIdx\": 7\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 126,\n+ \"order\": 156,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 7\n+ \"iconIdx\": 8\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 127,\n+ \"order\": 157,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 8\n+ \"iconIdx\": 9\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 128,\n+ \"order\": 158,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 9\n+ \"iconIdx\": 10\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 129,\n+ \"order\": 159,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 10\n+ \"iconIdx\": 11\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 130,\n+ \"order\": 160,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 11\n+ \"iconIdx\": 12\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 131,\n+ \"order\": 161,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 12\n+ \"iconIdx\": 13\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 132,\n+ \"order\": 162,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 13\n+ \"iconIdx\": 14\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 133,\n+ \"order\": 163,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 14\n+ \"iconIdx\": 15\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 134,\n+ \"order\": 164,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 15\n+ \"iconIdx\": 16\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 135,\n+ \"order\": 165,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 16\n+ \"iconIdx\": 17\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 136,\n+ \"order\": 166,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 17\n+ \"iconIdx\": 18\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 137,\n+ \"order\": 167,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 18\n+ \"iconIdx\": 19\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 138,\n+ \"order\": 168,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 19\n+ \"iconIdx\": 20\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 139,\n+ \"order\": 169,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 20\n+ \"iconIdx\": 21\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 140,\n+ \"order\": 170,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 21\n+ \"iconIdx\": 22\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 141,\n+ \"order\": 171,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 22\n+ \"iconIdx\": 23\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 142,\n+ \"order\": 172,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 23\n+ \"iconIdx\": 24\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 143,\n+ \"order\": 173,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 24\n+ \"iconIdx\": 25\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 144,\n+ \"order\": 174,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 25\n+ \"iconIdx\": 26\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 145,\n+ \"order\": 175,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 26\n+ \"iconIdx\": 27\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 146,\n+ \"order\": 176,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 27\n+ \"iconIdx\": 28\n}\n],\n\"height\": 1024,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add plus to icon set
Summary: forgot to add plus icon to icomoon {F10392}
Test Plan: everything should work as before with icons
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2957 |
129,179 | 29.01.2022 10:51:23 | 18,000 | 1792446893b003dd0ab2ace20b8146d1dff35d49 | [web] [splash] SquadCal --> Comm
Summary: Remove Comm
Test Plan: N/A, squadcal should be gone
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/splash/splash.react.js",
"new_path": "web/splash/splash.react.js",
"diff": "@@ -89,7 +89,7 @@ class Splash extends React.PureComponent<Props, State> {\n<div className={css.top}>\n<header className={css.header}>\n<div className={css.headerContents}>\n- <h1>SquadCal</h1>\n+ <h1>Comm</h1>\n<div className={css.actionLinks}>\n<a href=\"#\" onClick={this.onClickRequestAccess}>\n<span className={css.requestAccess}>Request access</span>\n@@ -108,7 +108,7 @@ class Splash extends React.PureComponent<Props, State> {\n<div className={css.body}>\n<div className={css.intro}>\n<p className={css.introHeader}>\n- SquadCal is a chat app with an integrated calendar.\n+ Comm is a chat app with an integrated calendar.\n</p>\n<p className={css.introDescription}>\nWe make it incredibly easy to plan events with your friends.\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [splash] SquadCal --> Comm
Summary: Remove Comm
Test Plan: N/A, squadcal should be gone
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2962 |
129,179 | 29.01.2022 18:48:02 | 18,000 | d519abe338082e5cb55e766b7585c1391edc7aa5 | [native] [lib] move ancestor threads to hook in lib/shared
Summary: moving this function to a hook so we can re-use it in web
Test Plan: make sure ancestor thread labels are still working on native
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/shared/ancestor-threads.js",
"diff": "+// @flow\n+\n+import genesis from '../facts/genesis';\n+import {\n+ threadInfoSelector,\n+ ancestorThreadInfos,\n+} from '../selectors/thread-selectors';\n+import { threadIsPending } from '../shared/thread-utils';\n+import { type ThreadInfo } from '../types/thread-types';\n+import { useSelector } from '../utils/redux-utils';\n+\n+function useAncestorThreads(\n+ threadInfo: ThreadInfo,\n+): $ReadOnlyArray<ThreadInfo> {\n+ return useSelector(state => {\n+ if (!threadIsPending(threadInfo.id)) {\n+ return ancestorThreadInfos(threadInfo.id)(state).slice(0, -1);\n+ }\n+ const genesisThreadInfo = threadInfoSelector(state)[genesis.id];\n+ return genesisThreadInfo ? [genesisThreadInfo] : [];\n+ });\n+}\n+\n+export { useAncestorThreads };\n"
},
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors-label.react.js",
"new_path": "native/components/thread-ancestors-label.react.js",
"diff": "@@ -4,15 +4,9 @@ import * as React from 'react';\nimport { Text, View } from 'react-native';\nimport Icon from 'react-native-vector-icons/FontAwesome5';\n-import genesis from 'lib/facts/genesis';\n-import {\n- threadInfoSelector,\n- ancestorThreadInfos,\n-} from 'lib/selectors/thread-selectors';\n-import { threadIsPending } from 'lib/shared/thread-utils';\n+import { useAncestorThreads } from 'lib/shared/ancestor-threads';\nimport { type ThreadInfo } from 'lib/types/thread-types';\n-import { useSelector } from '../redux/redux-utils';\nimport { useColors, useStyles } from '../themes/colors';\ntype Props = {\n@@ -23,13 +17,7 @@ function ThreadAncestorsLabel(props: Props): React.Node {\nconst { unread, threadInfo } = props;\nconst styles = useStyles(unboundStyles);\nconst colors = useColors();\n- const ancestorThreads: $ReadOnlyArray<ThreadInfo> = useSelector(state => {\n- if (!threadIsPending(threadInfo.id)) {\n- return ancestorThreadInfos(threadInfo.id)(state).slice(0, -1);\n- }\n- const genesisThreadInfo = threadInfoSelector(state)[genesis.id];\n- return genesisThreadInfo ? [genesisThreadInfo] : [];\n- });\n+ const ancestorThreads = useAncestorThreads(threadInfo);\nconst chevronIcon = React.useMemo(\n() => (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [lib] move ancestor threads to hook in lib/shared
Summary: moving this function to a hook so we can re-use it in web
Test Plan: make sure ancestor thread labels are still working on native
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2974 |
129,179 | 30.01.2022 20:57:17 | 18,000 | fdec2d16616e49f66573c9892060c683e33ff658 | [native] [refactor] remove null path check
Summary: array never doesn't exist. This condition will never be met.
Test Plan: make sure ancestor threads still work.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors-label.react.js",
"new_path": "native/components/thread-ancestors-label.react.js",
"diff": "@@ -48,10 +48,6 @@ function ThreadAncestorsLabel(props: Props): React.Node {\nreturn unread ? [styles.pathText, styles.unread] : styles.pathText;\n}, [styles.pathText, styles.unread, unread]);\n- if (!ancestorPath) {\n- return null;\n- }\n-\nreturn (\n<Text numberOfLines={1} style={ancestorPathStyle}>\n{ancestorPath}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [refactor] remove null path check
Summary: array never doesn't exist. This condition will never be met.
Test Plan: make sure ancestor threads still work.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2975 |
129,187 | 30.01.2022 16:21:36 | 18,000 | 750c842f82a0ffced457a6bca26b7ec022900e1d | [RN0.66] 13/n: Flow version upgrade
Summary: Fixes for type errors will follow in other diffs.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/.flowconfig",
"new_path": "landing/.flowconfig",
"diff": "[options]\nmodule.name_mapper.extension='css' -> '<PROJECT_ROOT>/flow/CSSModule.js.flow'\n-esproposal.optional_chaining=enable\n-esproposal.nullish_coalescing=enable\nexact_by_default=true\n+format.bracket_spacing=false\n+\n[lints]\nsketchy-null-number=warn\nsketchy-null-mixed=warn\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"clean-webpack-plugin\": \"^3.0.0\",\n\"concurrently\": \"^5.3.0\",\n\"css-loader\": \"^4.3.0\",\n- \"flow-bin\": \"^0.137.0\",\n+ \"flow-bin\": \"^0.158.0\",\n\"flow-typed\": \"^3.2.1\",\n\"mini-css-extract-plugin\": \"^0.11.2\",\n\"optimize-css-assets-webpack-plugin\": \"^5.0.3\",\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/.flowconfig",
"new_path": "lib/.flowconfig",
"diff": "[libs]\n[options]\n-esproposal.optional_chaining=enable\n-esproposal.nullish_coalescing=enable\n-\nexact_by_default=true\n+format.bracket_spacing=false\n+\n[lints]\nsketchy-null-number=warn\nsketchy-null-mixed=warn\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/package.json",
"new_path": "lib/package.json",
"diff": "\"@babel/preset-flow\": \"^7.13.13\",\n\"@babel/preset-react\": \"^7.13.13\",\n\"babel-jest\": \"^26.6.3\",\n- \"flow-bin\": \"^0.137.0\",\n+ \"flow-bin\": \"^0.158.0\",\n\"flow-typed\": \"^3.2.1\"\n},\n\"dependencies\": {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/.flowconfig",
"new_path": "native/.flowconfig",
"diff": "[options]\nemoji=true\n-esproposal.optional_chaining=enable\n-esproposal.nullish_coalescing=enable\n-\nexact_by_default=true\n+format.bracket_spacing=false\n+\nmodule.file_ext=.js\nmodule.file_ext=.json\nmodule.file_ext=.ios.js\n@@ -72,4 +71,4 @@ untyped-import\nuntyped-type-import\n[version]\n-^0.137.0\n+^0.158.0\n"
},
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"babel-plugin-transform-remove-console\": \"^6.9.4\",\n\"babel-plugin-transform-remove-strict-mode\": \"0.0.2\",\n\"comm-react-native-codegen\": \"npm:react-native-codegen@0.0.7\",\n- \"flow-bin\": \"^0.137.0\",\n+ \"flow-bin\": \"^0.158.0\",\n\"flow-mono-cli\": \"^1.5.0\",\n\"flow-typed\": \"^3.2.1\",\n\"fs-extra\": \"^8.1.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "server/.flowconfig",
"new_path": "server/.flowconfig",
"diff": "module.file_ext=.js\nmodule.file_ext=.cjs\nmodule.file_ext=.json\n-esproposal.optional_chaining=enable\n-esproposal.nullish_coalescing=enable\nexact_by_default=true\n+format.bracket_spacing=false\n+\n[lints]\nsketchy-null-number=warn\nsketchy-null-mixed=warn\n"
},
{
"change_type": "MODIFY",
"old_path": "server/package.json",
"new_path": "server/package.json",
"diff": "\"babel-jest\": \"^26.6.3\",\n\"chokidar-cli\": \"^2.1.0\",\n\"concurrently\": \"^5.3.0\",\n- \"flow-bin\": \"^0.137.0\",\n+ \"flow-bin\": \"^0.158.0\",\n\"flow-typed\": \"^3.2.1\",\n\"jest\": \"^26.6.3\",\n\"nodemon\": \"^2.0.4\"\n"
},
{
"change_type": "MODIFY",
"old_path": "web/.flowconfig",
"new_path": "web/.flowconfig",
"diff": "[options]\nmodule.name_mapper.extension='css' -> '<PROJECT_ROOT>/flow/CSSModule.js.flow'\n-esproposal.optional_chaining=enable\n-esproposal.nullish_coalescing=enable\nexact_by_default=true\n+format.bracket_spacing=false\n+\n[lints]\nsketchy-null-number=warn\nsketchy-null-mixed=warn\n"
},
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"clean-webpack-plugin\": \"^3.0.0\",\n\"concurrently\": \"^5.3.0\",\n\"css-loader\": \"^4.3.0\",\n- \"flow-bin\": \"^0.137.0\",\n+ \"flow-bin\": \"^0.158.0\",\n\"flow-typed\": \"^3.2.1\",\n\"mini-css-extract-plugin\": \"^0.11.2\",\n\"optimize-css-assets-webpack-plugin\": \"^5.0.3\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -5629,6 +5629,7 @@ combined-stream@^1.0.6, combined-stream@~1.0.6:\ndelayed-stream \"~1.0.0\"\n\"comm-react-native-codegen@npm:react-native-codegen@0.0.7\", react-native-codegen@^0.0.7:\n+ name comm-react-native-codegen\nversion \"0.0.7\"\nresolved \"https://registry.yarnpkg.com/react-native-codegen/-/react-native-codegen-0.0.7.tgz#86651c5c5fec67a8077ef7f4e36f7ed459043e14\"\nintegrity sha512-dwNgR8zJ3ALr480QnAmpTiqvFo+rDtq6V5oCggKhYFlRjzOmVSFn3YD41u8ltvKS5G2nQ8gCs2vReFFnRGLYng==\n@@ -7972,10 +7973,10 @@ fleximap@^1.0.0:\nresolved \"https://registry.yarnpkg.com/fleximap/-/fleximap-1.0.0.tgz#1ad448de87b8e023ba6a60623b7e8b0867360ef6\"\nintegrity sha512-zg/PthjBzESYKomTw/wivo8Id6B+obVkWriIzDuRfuw4wxEIV2/0D/NIGf+LKcGTTifHRfw73+oAAQozZ9MAhA==\n-flow-bin@^0.137.0:\n- version \"0.137.0\"\n- resolved \"https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.137.0.tgz#322a15b3744195af1e02bf1fec0a716296aee7d5\"\n- integrity sha512-ytwUn68fPKK/VWVpCxJ4KNeNIjCC/uX0Ll6Z1E98sOXfMknB000WtgQjKYDdO6tOR8mvXBE0adzjgCrChVympw==\n+flow-bin@^0.158.0:\n+ version \"0.158.0\"\n+ resolved \"https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.158.0.tgz#0a09763d41eb8ec7135ced6a3b9f8fa370a393d8\"\n+ integrity sha512-Gk5md8XTwk/M+J5M+rFyS1LJfFen6ldY60jM9+meWixlKf4b0vwdoUO8R7oo471pze+GY+blrnskUeqLDxFJfg==\nflow-mono-cli@^1.5.0:\nversion \"1.5.3\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 13/n: Flow version upgrade
Summary: Fixes for type errors will follow in other diffs.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2992 |
129,187 | 30.01.2022 21:14:33 | 18,000 | 12a04910e6bc95ed2348c411e994c1113908b1b9 | [RN0.66] 15/n: Update to
Summary: The old one has a `jcenter` dependency that no longer works.
Test Plan: Built and ran the whole stack on iOS and Android across various architectures
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/ios/Podfile.lock",
"new_path": "native/ios/Podfile.lock",
"diff": "@@ -741,7 +741,7 @@ PODS:\n- React-jsinspector (0.66.4)\n- React-logger (0.66.4):\n- glog\n- - react-native-background-upload (5.6.0):\n+ - react-native-background-upload (6.5.1):\n- React\n- react-native-camera (3.31.0):\n- React\n@@ -1268,7 +1268,7 @@ SPEC CHECKSUMS:\nReact-jsiexecutor: 94ce921e1d8ce7023366873ec371f3441383b396\nReact-jsinspector: d0374f7509d407d2264168b6d0fad0b54e300b85\nReact-logger: 933f80c97c633ee8965d609876848148e3fef438\n- react-native-background-upload: 6e8ba7f41a6308231306bddc88f11da3b74c9de4\n+ react-native-background-upload: c62f25610ffd49b1781fbdf1135b3b17f2f914b9\nreact-native-camera: b5c8c7a71feecfdd5b39f0dbbf6b64b957ed55f2\nreact-native-ffmpeg: f9a60452aaa5d478aac205b248224994f3bde416\nreact-native-flipper: 80b71629f5bf7b942dfae7af0c5f88526d19b3ca\n"
},
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"olm\": \"git+https://gitlab.matrix.org/matrix-org/olm.git#v3.2.4\",\n\"react\": \"17.0.2\",\n\"react-native\": \"0.66.4\",\n- \"react-native-background-upload\": \"^5.6.0\",\n+ \"react-native-background-upload\": \"^6.5.1\",\n\"react-native-camera\": \"^3.31.0\",\n\"react-native-dark-mode\": \"^0.2.0-rc.1\",\n\"react-native-device-info\": \"^8.0.7\",\n"
},
{
"change_type": "DELETE",
"old_path": "patches/react-native-background-upload+5.6.0.patch",
"new_path": null,
"diff": "-diff --git a/node_modules/react-native-background-upload/android/build.gradle b/node_modules/react-native-background-upload/android/build.gradle\n-index 9262df3..ba3e21c 100755\n---- a/node_modules/react-native-background-upload/android/build.gradle\n-+++ b/node_modules/react-native-background-upload/android/build.gradle\n-@@ -19,7 +19,7 @@ android {\n- buildToolsVersion project.hasProperty('buildToolsVersion') ? project.buildToolsVersion : DEFAULT_BUILD_TOOLS_VERSION\n-\n- defaultConfig {\n-- minSdkVersion 18\n-+ minSdkVersion 16\n- targetSdkVersion project.hasProperty('targetSdkVersion') ? project.targetSdkVersion : DEFAULT_TARGET_SDK_VERSION\n- versionCode 1\n- versionName \"1.0\"\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -14212,10 +14212,10 @@ react-motion@^0.5.2:\nprop-types \"^15.5.8\"\nraf \"^3.1.0\"\n-react-native-background-upload@^5.6.0:\n- version \"5.6.0\"\n- resolved \"https://registry.yarnpkg.com/react-native-background-upload/-/react-native-background-upload-5.6.0.tgz#77953c78571c5c7d7a4885207743c6c462f22066\"\n- integrity sha512-JWtRVs3LIP41BFIEd01wit/O/hsGcGPDBYASZFal+0wPYJHjZZCVFOj2sEQ/NSOb4ow7RXtkYYJEKnQt+RiMPw==\n+react-native-background-upload@^6.5.1:\n+ version \"6.5.1\"\n+ resolved \"https://registry.yarnpkg.com/react-native-background-upload/-/react-native-background-upload-6.5.1.tgz#862e1d783e608bdca073ca2d7aeae79503e0507c\"\n+ integrity sha512-cKVCrpQ7xIePL9rh+TBFQw69Z2eG3tL5/R732+I7lfpq6F9xwrwkYDgxqKfGzTtY3V6JZ3ZENCO8MOMEh6O0jw==\nreact-native-camera@^3.31.0:\nversion \"3.31.0\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 15/n: Update to react-native-background-uploader@6.5.1
Summary: The old one has a `jcenter` dependency that no longer works.
Test Plan: Built and ran the whole stack on iOS and Android across various architectures
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2994 |
129,187 | 30.01.2022 22:25:43 | 18,000 | 88d61c73194ddf122b041d55514dee9c2c39f0eb | [RN0.66] 19/n: Fix lodash/fp maxBy type
Summary: Flow fails to recognize the single-parameter variant when it's specified first. The variant with more parameters should always be specified first.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/flow-typed/npm/lodash_v4.x.x.js",
"new_path": "lib/flow-typed/npm/lodash_v4.x.x.js",
"diff": "@@ -2880,8 +2880,8 @@ declare module \"lodash/fp\" {\ndivide(dividend: number, divisor: number): number;\nfloor(number: number): number;\nmax<T>(array: $ReadOnlyArray<T>): T;\n- maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmaxBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): T;\n+ maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmean(array: $ReadOnlyArray<*>): number;\nmeanBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => number;\nmeanBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): number;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/flow-typed/npm/lodash_v4.x.x.js",
"new_path": "native/flow-typed/npm/lodash_v4.x.x.js",
"diff": "@@ -2880,8 +2880,8 @@ declare module \"lodash/fp\" {\ndivide(dividend: number, divisor: number): number;\nfloor(number: number): number;\nmax<T>(array: $ReadOnlyArray<T>): T;\n- maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmaxBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): T;\n+ maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmean(array: $ReadOnlyArray<*>): number;\nmeanBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => number;\nmeanBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): number;\n"
},
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/lodash_v4.x.x.js",
"new_path": "server/flow-typed/npm/lodash_v4.x.x.js",
"diff": "@@ -2880,8 +2880,8 @@ declare module \"lodash/fp\" {\ndivide(dividend: number, divisor: number): number;\nfloor(number: number): number;\nmax<T>(array: $ReadOnlyArray<T>): T;\n- maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmaxBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): T;\n+ maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmean(array: $ReadOnlyArray<*>): number;\nmeanBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => number;\nmeanBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): number;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/flow-typed/npm/lodash_v4.x.x.js",
"new_path": "web/flow-typed/npm/lodash_v4.x.x.js",
"diff": "@@ -2880,8 +2880,8 @@ declare module \"lodash/fp\" {\ndivide(dividend: number, divisor: number): number;\nfloor(number: number): number;\nmax<T>(array: $ReadOnlyArray<T>): T;\n- maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmaxBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): T;\n+ maxBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => T;\nmean(array: $ReadOnlyArray<*>): number;\nmeanBy<T>(iteratee: Iteratee<T>): (array: $ReadOnlyArray<T>) => number;\nmeanBy<T>(iteratee: Iteratee<T>, array: $ReadOnlyArray<T>): number;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 19/n: Fix lodash/fp maxBy type
Summary: Flow fails to recognize the single-parameter variant when it's specified first. The variant with more parameters should always be specified first.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2998 |
129,187 | 30.01.2022 22:38:13 | 18,000 | 31eec30a4aa1b882d6ea9f2ffba1b9d638f76080 | [RN0.66] 21/n: Fix type error in makePermissionsBlob
Summary: The type of `ThreadPermissionInfo` is very particular that `source` can only be non-null if `value` is `true`.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/permissions/thread-permissions.js",
"new_path": "lib/permissions/thread-permissions.js",
"diff": "@@ -5,6 +5,7 @@ import {\ntype ThreadType,\ntype ThreadPermission,\ntype ThreadRolePermissionsBlob,\n+ type ThreadPermissionInfo,\ntype ThreadPermissionsInfo,\nthreadPermissions,\nthreadPermissionPropagationPrefixes,\n@@ -75,16 +76,23 @@ function makePermissionsBlob(\n}\n}\n- const combinedPermissions = { ...permissions };\n+ const combinedPermissions: {\n+ [permission: string]: ThreadPermissionInfo,\n+ } = { ...permissions };\nif (rolePermissions) {\nfor (const permissionKey in rolePermissions) {\nconst permissionValue = rolePermissions[permissionKey];\nconst currentValue = combinedPermissions[permissionKey];\n- if (permissionValue || !currentValue || !currentValue.value) {\n+ if (permissionValue) {\ncombinedPermissions[permissionKey] = {\n- value: permissionValue,\n+ value: true,\nsource: threadID,\n};\n+ } else if (!currentValue || !currentValue.value) {\n+ combinedPermissions[permissionKey] = {\n+ value: false,\n+ source: null,\n+ };\n}\n}\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 21/n: Fix type error in makePermissionsBlob
Summary: The type of `ThreadPermissionInfo` is very particular that `source` can only be non-null if `value` is `true`.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3000 |
129,187 | 30.01.2022 22:58:02 | 18,000 | d74f26559c9486860c1e25485e9680e779963701 | [RN0.66] 23/n: Move imports into module declarations for redux-devtools-extension
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/flow-typed/npm/redux-devtools-extension_v2.x.x.js",
"new_path": "web/flow-typed/npm/redux-devtools-extension_v2.x.x.js",
"diff": "// flow-typed signature: dde9329b5d39c60765e23c080dc5d018\n// flow-typed version: 9931c6ffb0/redux-devtools-extension_v2.x.x/flow_>=v0.47.x <=v0.103.x\n+declare module 'redux-devtools-extension' {\nimport type { ActionCreator, StoreEnhancer } from 'redux';\nimport typeof { compose } from 'redux';\n-declare type $npm$ReduxDevtoolsExtension$DevToolsOptions = {\n+ declare export type DevToolsOptions = {\nname?: string,\nactionCreators?: Array<ActionCreator<any>> | { [string]: ActionCreator<any> },\nlatency?: number,\n@@ -45,7 +46,7 @@ declare type $npm$ReduxDevtoolsExtension$DevToolsOptions = {\n};\ndeclare function $npm$ReduxDevtoolsExtension$composeWithDevTools<A, B>(ab: A => B): A => B;\n-declare function $npm$ReduxDevtoolsExtension$composeWithDevTools(options: $npm$ReduxDevtoolsExtension$DevToolsOptions): compose;\n+ declare function $npm$ReduxDevtoolsExtension$composeWithDevTools(options: DevToolsOptions): compose;\ndeclare function $npm$ReduxDevtoolsExtension$composeWithDevTools<A, B, C>(\nbc: B => C,\nab: A => B\n@@ -96,32 +97,46 @@ declare function $npm$ReduxDevtoolsExtension$composeWithDevTools<A, B, C, D, E,\nab: A => B\n): A => H;\n-declare function $npm$ReduxDevtoolsExtension$devToolsEnhancer<S, A>(options?: $npm$ReduxDevtoolsExtension$DevToolsOptions): StoreEnhancer<S, A>;\n+ declare function $npm$ReduxDevtoolsExtension$devToolsEnhancer<S, A>(options?: DevToolsOptions): StoreEnhancer<S, A>;\n-declare module 'redux-devtools-extension' {\n- declare export type DevToolsOptions = $npm$ReduxDevtoolsExtension$DevToolsOptions;\n+ // Exports below\ndeclare export var composeWithDevTools: typeof $npm$ReduxDevtoolsExtension$composeWithDevTools;\ndeclare export var devToolsEnhancer: typeof $npm$ReduxDevtoolsExtension$devToolsEnhancer;\n}\ndeclare module 'redux-devtools-extension/developmentOnly' {\n- declare export type DevToolsOptions = $npm$ReduxDevtoolsExtension$DevToolsOptions;\n+ import type { StoreEnhancer } from 'redux';\n+ import type { DevToolsOptions as DevToolsOptionsBase } from 'redux-devtools-extension';\n+ import typeof { composeWithDevTools as ComposeWithDevTools } from 'redux-devtools-extension';\n- declare export var composeWithDevTools: typeof $npm$ReduxDevtoolsExtension$composeWithDevTools;\n- declare export var devToolsEnhancer: typeof $npm$ReduxDevtoolsExtension$devToolsEnhancer;\n+ declare function DevToolsEnhancer<S, A>(options?: DevToolsOptions): StoreEnhancer<S, A>;\n+\n+ declare export type DevToolsOptions = DevToolsOptionsBase;\n+ declare export var composeWithDevTools: ComposeWithDevTools;\n+ declare export var devToolsEnhancer: typeof DevToolsEnhancer;\n}\ndeclare module 'redux-devtools-extension/logOnly' {\n- declare export type DevToolsOptions = $npm$ReduxDevtoolsExtension$DevToolsOptions;\n+ import type { StoreEnhancer } from 'redux';\n+ import type { DevToolsOptions as DevToolsOptionsBase } from 'redux-devtools-extension';\n+ import typeof { composeWithDevTools as ComposeWithDevTools } from 'redux-devtools-extension';\n- declare export var composeWithDevTools: typeof $npm$ReduxDevtoolsExtension$composeWithDevTools;\n- declare export var devToolsEnhancer: typeof $npm$ReduxDevtoolsExtension$devToolsEnhancer;\n+ declare function DevToolsEnhancer<S, A>(options?: DevToolsOptions): StoreEnhancer<S, A>;\n+\n+ declare export type DevToolsOptions = DevToolsOptionsBase;\n+ declare export var composeWithDevTools: ComposeWithDevTools;\n+ declare export var devToolsEnhancer: typeof DevToolsEnhancer;\n}\ndeclare module 'redux-devtools-extension/logOnlyInProduction' {\n- declare export type DevToolsOptions = $npm$ReduxDevtoolsExtension$DevToolsOptions;\n+ import type { StoreEnhancer } from 'redux';\n+ import type { DevToolsOptions as DevToolsOptionsBase } from 'redux-devtools-extension';\n+ import typeof { composeWithDevTools as ComposeWithDevTools } from 'redux-devtools-extension';\n- declare export var composeWithDevTools: typeof $npm$ReduxDevtoolsExtension$composeWithDevTools;\n- declare export var devToolsEnhancer: typeof $npm$ReduxDevtoolsExtension$devToolsEnhancer;\n+ declare function DevToolsEnhancer<S, A>(options?: DevToolsOptions): StoreEnhancer<S, A>;\n+\n+ declare export type DevToolsOptions = DevToolsOptionsBase;\n+ declare export var composeWithDevTools: ComposeWithDevTools;\n+ declare export var devToolsEnhancer: typeof DevToolsEnhancer;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 23/n: Move imports into module declarations for redux-devtools-extension
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3002 |
129,187 | 30.01.2022 23:30:08 | 18,000 | 0451e9b720e57396f2619a3e544019ed04fbd5e8 | [RN0.66] 24/n: Move imports into module declarations for webpack
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/flow-typed/npm/webpack_v4.x.x.js",
"new_path": "web/flow-typed/npm/webpack_v4.x.x.js",
"diff": "// flow-typed signature: 249ddfcae5dfea268feb3f85fbd35f97\n// flow-typed version: d14eb225e8/webpack_v4.x.x/flow_>=v0.71.x <=v0.103.x\n-import * as http from 'http';\n-import fs from 'fs';\n-\ndeclare module 'webpack' {\n+ import typeof { Server, ServerResponse } from 'http';\n+ import typeof { Stats as FSStats } from 'fs';\n+\ndeclare class $WebpackError extends Error {\nconstructor(message: string): WebpackError;\ninspect(): string;\n@@ -441,9 +441,9 @@ declare module 'webpack' {\ncontext?: string,\ndependencies?: Array<string>,\ndevServer?: {\n- after?: (app: any, server: http.Server) => void,\n+ after?: (app: any, server: Server) => void,\nallowedHosts?: string[],\n- before?: (app: any, server: http.Server) => void,\n+ before?: (app: any, server: Server) => void,\nbonjour?: boolean,\nclientLogLevel?: 'none' | 'info' | 'error' | 'warning',\ncompress?: boolean,\n@@ -498,9 +498,9 @@ declare module 'webpack' {\nmaxAge?: number,\nredirect?: boolean,\nsetHeaders?: (\n- res: http.OutgoingMessage,\n+ res: ServerResponse,\npath: string,\n- stat: fs.Stat\n+ stat: FSStats\n) => void,\n},\nstats?: StatsOptions,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 24/n: Move imports into module declarations for webpack
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3003 |
129,187 | 30.01.2022 23:39:20 | 18,000 | 42b661c2fb7f27ffb4b5d180c5a7f3dcfd77874b | [RN0.66] 26/n: Use arrow function for web Entry's updateHeight
Summary: Flow doesn't want to see `this.memberFunction.bind` anymore, it seems. Fair enough...
Test Plan: Flow
Reviewers: benschac, palys-swm, atul
Subscribers: Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/entry.react.js",
"new_path": "web/calendar/entry.react.js",
"diff": "@@ -150,14 +150,14 @@ class Entry extends React.PureComponent<Props, State> {\nthis.mounted = false;\n}\n- updateHeight() {\n+ updateHeight: () => void = () => {\ninvariant(\nthis.textarea instanceof HTMLTextAreaElement,\n'textarea ref not set',\n);\nthis.textarea.style.height = 'auto';\nthis.textarea.style.height = this.textarea.scrollHeight + 'px';\n- }\n+ };\nrender(): React.Node {\nlet actionLinks = null;\n@@ -267,7 +267,7 @@ class Entry extends React.PureComponent<Props, State> {\n}\nconst target = event.target;\ninvariant(target instanceof HTMLTextAreaElement, 'target not textarea');\n- this.setState({ text: target.value }, this.updateHeight.bind(this));\n+ this.setState({ text: target.value }, this.updateHeight);\n};\nonKeyDown: (\n@@ -384,10 +384,7 @@ class Entry extends React.PureComponent<Props, State> {\nthis.currentlySaving = null;\nif (e instanceof ServerError && e.message === 'concurrent_modification') {\nconst onRefresh = () => {\n- this.setState(\n- { loadingStatus: 'inactive' },\n- this.updateHeight.bind(this),\n- );\n+ this.setState({ loadingStatus: 'inactive' }, this.updateHeight);\nthis.props.dispatch({\ntype: concurrentModificationResetActionType,\npayload: { id: entryID, dbText: e.payload.db },\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 26/n: Use arrow function for web Entry's updateHeight
Summary: Flow doesn't want to see `this.memberFunction.bind` anymore, it seems. Fair enough...
Test Plan: Flow
Reviewers: benschac, palys-swm, atul
Reviewed By: benschac, palys-swm
Subscribers: Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3005 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.