author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,184 | 04.11.2021 15:10:49 | 14,400 | f16dbb30cadd3332c81cb870a8f05b4c3a46293d | [CI] Add `googleapis` dependency to `native`
Summary: Add `googleapis` dependency so we can access `androidpublisherv3` endpoint from `upload-aab.js` script.
Test Plan: NA
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"flow-mono-cli\": \"^1.5.0\",\n\"flow-typed\": \"^3.2.1\",\n\"fs-extra\": \"^8.1.0\",\n+ \"googleapis\": \"^89.0.0\",\n\"jest\": \"^26.6.3\",\n\"jetifier\": \"^1.6.4\",\n\"metro-react-native-babel-preset\": \"^0.64.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -9126,6 +9126,17 @@ gaxios@^3.0.0:\nis-stream \"^2.0.0\"\nnode-fetch \"^2.3.0\"\n+gaxios@^4.0.0:\n+ version \"4.3.2\"\n+ resolved \"https://registry.yarnpkg.com/gaxios/-/gaxios-4.3.2.tgz#845827c2dc25a0213c8ab4155c7a28910f5be83f\"\n+ integrity sha512-T+ap6GM6UZ0c4E6yb1y/hy2UB6hTrqhglp3XfmU9qbLCGRYhLVV5aRPpC4EmoG8N8zOnkYCgoBz+ScvGAARY6Q==\n+ dependencies:\n+ abort-controller \"^3.0.0\"\n+ extend \"^3.0.2\"\n+ https-proxy-agent \"^5.0.0\"\n+ is-stream \"^2.0.0\"\n+ node-fetch \"^2.6.1\"\n+\ngcp-metadata@^4.1.0:\nversion \"4.2.0\"\nresolved \"https://registry.yarnpkg.com/gcp-metadata/-/gcp-metadata-4.2.0.tgz#3b424355ccdc240ee07c5791e2fd6a60a283d89a\"\n@@ -9134,6 +9145,14 @@ gcp-metadata@^4.1.0:\ngaxios \"^3.0.0\"\njson-bigint \"^1.0.0\"\n+gcp-metadata@^4.2.0:\n+ version \"4.3.1\"\n+ resolved \"https://registry.yarnpkg.com/gcp-metadata/-/gcp-metadata-4.3.1.tgz#fb205fe6a90fef2fd9c85e6ba06e5559ee1eefa9\"\n+ integrity sha512-x850LS5N7V1F3UcV7PoupzGsyD6iVwTVvsh3tbXfkctZnBnjW5yu5z1/3k3SehF7TyoTIe78rJs02GMMy+LF+A==\n+ dependencies:\n+ gaxios \"^4.0.0\"\n+ json-bigint \"^1.0.0\"\n+\ngcs-resumable-upload@^3.1.0:\nversion \"3.1.1\"\nresolved \"https://registry.yarnpkg.com/gcs-resumable-upload/-/gcs-resumable-upload-3.1.1.tgz#67c766a0555d6a352f9651b7603337207167d0de\"\n@@ -9423,6 +9442,21 @@ google-auth-library@^6.0.0:\njws \"^4.0.0\"\nlru-cache \"^6.0.0\"\n+google-auth-library@^7.0.2:\n+ version \"7.10.2\"\n+ resolved \"https://registry.yarnpkg.com/google-auth-library/-/google-auth-library-7.10.2.tgz#7e48176f50e725e1d65b6a838ec9e9464e6ba689\"\n+ integrity sha512-M37o9Kxa/TLvOLgF71SXvLeVEP5sbSTmKl1zlIgl72SFy5PtsU3pOdu8G8MIHHpQ3/NZabDI8rQkA9DvQVKkPA==\n+ dependencies:\n+ arrify \"^2.0.0\"\n+ base64-js \"^1.3.0\"\n+ ecdsa-sig-formatter \"^1.0.11\"\n+ fast-text-encoding \"^1.0.0\"\n+ gaxios \"^4.0.0\"\n+ gcp-metadata \"^4.2.0\"\n+ gtoken \"^5.0.4\"\n+ jws \"^4.0.0\"\n+ lru-cache \"^6.0.0\"\n+\ngoogle-gax@^2.2.0:\nversion \"2.8.0\"\nresolved \"https://registry.yarnpkg.com/google-gax/-/google-gax-2.8.0.tgz#e62bb93c0a9255a76f24e180a0f92a58865f3ebb\"\n@@ -9450,6 +9484,33 @@ google-p12-pem@^3.0.0:\ndependencies:\nnode-forge \"^0.10.0\"\n+google-p12-pem@^3.0.3:\n+ version \"3.1.2\"\n+ resolved \"https://registry.yarnpkg.com/google-p12-pem/-/google-p12-pem-3.1.2.tgz#c3d61c2da8e10843ff830fdb0d2059046238c1d4\"\n+ integrity sha512-tjf3IQIt7tWCDsa0ofDQ1qqSCNzahXDxdAGJDbruWqu3eCg5CKLYKN+hi0s6lfvzYZ1GDVr+oDF9OOWlDSdf0A==\n+ dependencies:\n+ node-forge \"^0.10.0\"\n+\n+googleapis-common@^5.0.2:\n+ version \"5.0.5\"\n+ resolved \"https://registry.yarnpkg.com/googleapis-common/-/googleapis-common-5.0.5.tgz#4c7160be1ed7e4cc8cdbcdb6eac8a4b3a61dd782\"\n+ integrity sha512-o2dgoW4x4fLIAN+IVAOccz3mEH8Lj1LP9c9BSSvkNJEn+U7UZh0WSr4fdH08x5VH7+sstIpd1lOYFZD0g7j4pw==\n+ dependencies:\n+ extend \"^3.0.2\"\n+ gaxios \"^4.0.0\"\n+ google-auth-library \"^7.0.2\"\n+ qs \"^6.7.0\"\n+ url-template \"^2.0.8\"\n+ uuid \"^8.0.0\"\n+\n+googleapis@^89.0.0:\n+ version \"89.0.0\"\n+ resolved \"https://registry.yarnpkg.com/googleapis/-/googleapis-89.0.0.tgz#03de7b1467c066d48b989f6a8384857ef6971e69\"\n+ integrity sha512-eH91BN+6R/Mp5uulrhKWGwKAbibfDNOIu1Oq8n12aFTiqb23/A9kVdRhituYVqhRqSWLr/kv1dpFbd6n+uN+7Q==\n+ dependencies:\n+ google-auth-library \"^7.0.2\"\n+ googleapis-common \"^5.0.2\"\n+\ngot@^10.5.7:\nversion \"10.7.0\"\nresolved \"https://registry.yarnpkg.com/got/-/got-10.7.0.tgz#62889dbcd6cca32cd6a154cc2d0c6895121d091f\"\n@@ -9546,6 +9607,15 @@ gtoken@^5.0.0:\njws \"^4.0.0\"\nmime \"^2.2.0\"\n+gtoken@^5.0.4:\n+ version \"5.3.1\"\n+ resolved \"https://registry.yarnpkg.com/gtoken/-/gtoken-5.3.1.tgz#c1c2598a826f2b5df7c6bb53d7be6cf6d50c3c78\"\n+ integrity sha512-yqOREjzLHcbzz1UrQoxhBtpk8KjrVhuqPE7od1K2uhyxG2BHjKZetlbLw/SPZak/QqTIQW+addS+EcjqQsZbwQ==\n+ dependencies:\n+ gaxios \"^4.0.0\"\n+ google-p12-pem \"^3.0.3\"\n+ jws \"^4.0.0\"\n+\nhandle-thing@^2.0.0:\nversion \"2.0.0\"\nresolved \"https://registry.yarnpkg.com/handle-thing/-/handle-thing-2.0.0.tgz#0e039695ff50c93fc288557d696f3c1dc6776754\"\n@@ -12955,6 +13025,13 @@ node-fetch@^2.2.0, node-fetch@^2.3.0, node-fetch@^2.6.0:\nresolved \"https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.0.tgz#e633456386d4aa55863f676a7ab0daa8fdecb0fd\"\nintegrity sha512-8dG4H5ujfvFiqDmVu9fQ5bOHUC15JMjMY/Zumv26oOvvVJjM67KF8koCWIabKQ1GJIa9r2mMZscBq/TbdOcmNA==\n+node-fetch@^2.6.1:\n+ version \"2.6.6\"\n+ resolved \"https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.6.tgz#1751a7c01834e8e1697758732e9efb6eeadfaf89\"\n+ integrity sha512-Z8/6vRlTUChSdIgMa51jxQ4lrw/Jy5SOW10ObaA47/RElsAN2c5Pn8bTgFGWn/ibwzXTE8qwr1Yzx28vsecXEA==\n+ dependencies:\n+ whatwg-url \"^5.0.0\"\n+\nnode-forge@0.10.0, node-forge@^0.10.0:\nversion \"0.10.0\"\nresolved \"https://registry.yarnpkg.com/node-forge/-/node-forge-0.10.0.tgz#32dea2afb3e9926f02ee5ce8794902691a676bf3\"\n@@ -14680,6 +14757,13 @@ qs@6.7.0:\nresolved \"https://registry.yarnpkg.com/qs/-/qs-6.7.0.tgz#41dc1a015e3d581f1621776be31afb2876a9b1bc\"\nintegrity sha512-VCdBRNFTX1fyE7Nb6FYoURo/SPe62QCaAyzJvUjwRaIsc+NePBEniHlvxFmmX56+HZphIGtV0XeCirBtpDrTyQ==\n+qs@^6.7.0:\n+ version \"6.10.1\"\n+ resolved \"https://registry.yarnpkg.com/qs/-/qs-6.10.1.tgz#4931482fa8d647a5aab799c5271d2133b981fb6a\"\n+ integrity sha512-M528Hph6wsSVOBiYUnGf+K/7w0hNshs/duGsNXPUCLH5XAqjEtiPGwNONLV0tBH8NoGb0mvD5JubnUTrujKDTg==\n+ dependencies:\n+ side-channel \"^1.0.4\"\n+\nqs@~6.5.2:\nversion \"6.5.2\"\nresolved \"https://registry.yarnpkg.com/qs/-/qs-6.5.2.tgz#cb3ae806e8740444584ef154ce8ee98d403f3e36\"\n@@ -17711,6 +17795,11 @@ tr46@^2.0.2:\ndependencies:\npunycode \"^2.1.1\"\n+tr46@~0.0.3:\n+ version \"0.0.3\"\n+ resolved \"https://registry.yarnpkg.com/tr46/-/tr46-0.0.3.tgz#8184fd347dac9cdc185992f3a6622e14b9d9ab6a\"\n+ integrity sha1-gYT9NH2snNwYWZLzpmIuFLnZq2o=\n+\n\"traverse@>=0.3.0 <0.4\":\nversion \"0.3.9\"\nresolved \"https://registry.yarnpkg.com/traverse/-/traverse-0.3.9.tgz#717b8f220cc0bb7b44e40514c22b2e8bbc70d8b9\"\n@@ -18132,6 +18221,11 @@ url-parse@^1.4.3, url-parse@^1.4.4:\nquerystringify \"^2.1.1\"\nrequires-port \"^1.0.0\"\n+url-template@^2.0.8:\n+ version \"2.0.8\"\n+ resolved \"https://registry.yarnpkg.com/url-template/-/url-template-2.0.8.tgz#fc565a3cccbff7730c775f5641f9555791439f21\"\n+ integrity sha1-/FZaPMy/93MMd19WQflVV5FDnyE=\n+\nurl@^0.11.0:\nversion \"0.11.0\"\nresolved \"https://registry.yarnpkg.com/url/-/url-0.11.0.tgz#3838e97cfc60521eb73c525a8e55bfdd9e2e28f1\"\n@@ -18464,6 +18558,11 @@ wcwidth@^1.0.1:\ndependencies:\ndefaults \"^1.0.3\"\n+webidl-conversions@^3.0.0:\n+ version \"3.0.1\"\n+ resolved \"https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-3.0.1.tgz#24534275e2a7bc6be7bc86611cc16ae0a5654871\"\n+ integrity sha1-JFNCdeKnvGvnvIZhHMFq4KVlSHE=\n+\nwebidl-conversions@^5.0.0:\nversion \"5.0.0\"\nresolved \"https://registry.yarnpkg.com/webidl-conversions/-/webidl-conversions-5.0.0.tgz#ae59c8a00b121543a2acc65c0434f57b0fc11aff\"\n@@ -18624,6 +18723,14 @@ whatwg-mimetype@^2.3.0:\nresolved \"https://registry.yarnpkg.com/whatwg-mimetype/-/whatwg-mimetype-2.3.0.tgz#3d4b1e0312d2079879f826aff18dbeeca5960fbf\"\nintegrity sha512-M4yMwr6mAnQz76TbJm914+gPpB/nCwvZbJU28cUD6dR004SAxDLOOSUaB1JDRqLtaOV/vi0IC5lEAGFgrjGv/g==\n+whatwg-url@^5.0.0:\n+ version \"5.0.0\"\n+ resolved \"https://registry.yarnpkg.com/whatwg-url/-/whatwg-url-5.0.0.tgz#966454e8765462e37644d3626f6742ce8b70965d\"\n+ integrity sha1-lmRU6HZUYuN2RNNib2dCzotwll0=\n+ dependencies:\n+ tr46 \"~0.0.3\"\n+ webidl-conversions \"^3.0.0\"\n+\nwhatwg-url@^8.0.0:\nversion \"8.4.0\"\nresolved \"https://registry.yarnpkg.com/whatwg-url/-/whatwg-url-8.4.0.tgz#50fb9615b05469591d2b2bd6dfaed2942ed72837\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Add `googleapis` dependency to `native`
Summary: Add `googleapis` dependency so we can access `androidpublisherv3` endpoint from `upload-aab.js` script.
Test Plan: NA
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2322 |
129,179 | 05.11.2021 14:14:46 | 14,400 | fc9a99ccf555fd1ecb6ff72f73fc37b68bd5227a | [lib][refactor] sort ascending user action exports
Summary: sort exports asc
Test Plan: login and out of the application to confirm actions are still behaving as expected
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -220,27 +220,27 @@ const getUserPublicKeys = (\nawait fetchJSON('get_user_public_keys', data);\nexport {\n- logOutActionTypes,\n- logOut,\n- deleteAccountActionTypes,\n- deleteAccount,\n- registerActionTypes,\n- register,\n- cookieInvalidationResolutionAttempt,\nappStartNativeCredentialsAutoLogIn,\nappStartReduxLoggedInButInvalidCookie,\n- socketAuthErrorResolutionAttempt,\n- sqliteOpFailure,\n- sqliteLoadFailure,\n- logInActionTypes,\n- logIn,\n- changeUserSettingsActionTypes,\nchangeUserSettings,\n- searchUsersActionTypes,\n+ changeUserSettingsActionTypes,\n+ cookieInvalidationResolutionAttempt,\n+ deleteAccount,\n+ deleteAccountActionTypes,\n+ getUserPublicKeys,\n+ logIn,\n+ logInActionTypes,\n+ logOut,\n+ logOutActionTypes,\n+ register,\n+ registerActionTypes,\n+ requestAccess,\n+ requestAccessActionTypes,\nsearchUsers,\n- updateSubscriptionActionTypes,\n+ searchUsersActionTypes,\n+ socketAuthErrorResolutionAttempt,\n+ sqliteLoadFailure,\n+ sqliteOpFailure,\nupdateSubscription,\n- requestAccessActionTypes,\n- requestAccess,\n- getUserPublicKeys,\n+ updateSubscriptionActionTypes,\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib][refactor] sort ascending user action exports
Summary: sort exports asc
Test Plan: login and out of the application to confirm actions are still behaving as expected
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2321 |
129,184 | 05.11.2021 13:16:52 | 14,400 | 13d6aa40368be7d78b0349286556d349a60e69fd | [CI] Get rid of iOS CI `pod install` step
Summary: This step is redundant and covered by `yarn cleaninstall`.
Test Plan:
Successfully built/archived/exported w/o `pod install` step:
{F5398}
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": ".github/workflows/ios.yml",
"new_path": ".github/workflows/ios.yml",
"diff": "@@ -58,10 +58,6 @@ jobs:\nAUTH_KEY: ${{secrets.AUTH_KEY}}\nrun: echo \"$AUTH_KEY\" > AUTH_KEY.p8\n- - name: Pod install\n- working-directory: ./native/ios\n- run: pod install\n-\n- name: Archive\nworking-directory: ./native/ios\nenv:\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Get rid of iOS CI `pod install` step
Summary: This step is redundant and covered by `yarn cleaninstall`.
Test Plan:
Successfully built/archived/exported w/o `pod install` step:
{F5398}
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2328 |
129,191 | 02.11.2021 18:11:20 | -3,600 | da1a9b7f3dea9036af58d636dcd8dd17d83cf218 | [CommCoreModule] Introduce GlobalNetworkSingleton
Summary: Create a global object that can be used to interact with network module. This object is hiding all the threading related logic.
Test Plan: Tested with the next diffs.
Reviewers: karol-bisztyga, ashoat
Subscribers: def-au1t, Adrian, atul, benschac, boristopalov
Tags: #background-notifications | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/GlobalNetworkSingleton.cpp",
"diff": "+#include \"GlobalNetworkSingleton.h\"\n+\n+namespace comm {\n+GlobalNetworkSingleton GlobalNetworkSingleton::instance;\n+\n+NetworkModule &GlobalNetworkSingleton::networkModule() {\n+ static thread_local NetworkModule module;\n+ return module;\n+}\n+\n+void GlobalNetworkSingleton::scheduleOrRun(\n+ std::function<void(NetworkModule &)> &&task) {\n+ if (this->thread != nullptr) {\n+ this->thread->scheduleTask(\n+ [=, task = std::move(task)]() { task(this->networkModule()); });\n+ } else {\n+ task(this->networkModule());\n+ }\n+}\n+\n+void GlobalNetworkSingleton::enableMultithreading() {\n+ if (this->thread == nullptr) {\n+ this->thread = std::make_unique<WorkerThread>(\"network\");\n+ }\n+}\n+} // namespace comm\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/GlobalNetworkSingleton.h",
"diff": "+#pragma once\n+\n+#include \"../../Tools/WorkerThread.h\"\n+#include \"NetworkModule.h\"\n+#include <functional>\n+#include <memory>\n+\n+namespace comm {\n+class GlobalNetworkSingleton {\n+ std::unique_ptr<WorkerThread> thread;\n+ static NetworkModule &networkModule();\n+\n+public:\n+ static GlobalNetworkSingleton instance;\n+ void scheduleOrRun(std::function<void(NetworkModule &)> &&task);\n+ void enableMultithreading();\n+};\n+} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "71CA4AEC262F236100835C89 /* Tools.mm in Sources */ = {isa = PBXBuildFile; fileRef = 71CA4AEB262F236100835C89 /* Tools.mm */; };\n71D4D7CC26C50B1000FCDBCD /* CommSecureStore.mm in Sources */ = {isa = PBXBuildFile; fileRef = 71D4D7CB26C50B1000FCDBCD /* CommSecureStore.mm */; };\n726E5D752731A4790032361D /* NetworkModule.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 726E5D732731A4790032361D /* NetworkModule.cpp */; };\n+ 726E5D782731A5E10032361D /* GlobalNetworkSingleton.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 726E5D762731A5E10032361D /* GlobalNetworkSingleton.cpp */; };\n7F761E602201141E001B6FB7 /* JavaScriptCore.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 7F761E292201141E001B6FB7 /* JavaScriptCore.framework */; };\n7F788C2C248AA2140098F071 /* SplashScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = 7F788C2B248AA2130098F071 /* SplashScreen.storyboard */; };\n7F8D602126535E060053CB29 /* OpenSans-Semibold.ttf in Resources */ = {isa = PBXBuildFile; fileRef = 7F8D601E26535E060053CB29 /* OpenSans-Semibold.ttf */; };\n71DC160C270C43D300822863 /* PlatformSpecificTools.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = PlatformSpecificTools.h; sourceTree = \"<group>\"; };\n726E5D732731A4790032361D /* NetworkModule.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = NetworkModule.cpp; sourceTree = \"<group>\"; };\n726E5D742731A4790032361D /* NetworkModule.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = NetworkModule.h; sourceTree = \"<group>\"; };\n+ 726E5D762731A5E10032361D /* GlobalNetworkSingleton.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = GlobalNetworkSingleton.cpp; sourceTree = \"<group>\"; };\n+ 726E5D772731A5E10032361D /* GlobalNetworkSingleton.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = GlobalNetworkSingleton.h; sourceTree = \"<group>\"; };\n7F26E81B24440D87004049C6 /* dummy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = dummy.swift; sourceTree = \"<group>\"; };\n7F554F822332D58B007CB9F7 /* Info.debug.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = Info.debug.plist; path = Comm/Info.debug.plist; sourceTree = \"<group>\"; };\n7F761E292201141E001B6FB7 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; };\nchildren = (\n726E5D732731A4790032361D /* NetworkModule.cpp */,\n726E5D742731A4790032361D /* NetworkModule.h */,\n+ 726E5D762731A5E10032361D /* GlobalNetworkSingleton.cpp */,\n+ 726E5D772731A5E10032361D /* GlobalNetworkSingleton.h */,\n);\npath = InternalModules;\nsourceTree = \"<group>\";\n71BE844A2636A944002849D2 /* CommCoreModule.cpp in Sources */,\n71D4D7CC26C50B1000FCDBCD /* CommSecureStore.mm in Sources */,\n711B408425DA97F9005F8F06 /* dummy.swift in Sources */,\n+ 726E5D782731A5E10032361D /* GlobalNetworkSingleton.cpp in Sources */,\n13B07FC11A68108700A75B9A /* main.m in Sources */,\n71BE844B2636A944002849D2 /* SQLiteQueryExecutor.cpp in Sources */,\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce GlobalNetworkSingleton
Summary: Create a global object that can be used to interact with network module. This object is hiding all the threading related logic.
Test Plan: Tested with the next diffs.
Reviewers: karol-bisztyga, ashoat
Reviewed By: ashoat
Subscribers: def-au1t, Adrian, atul, benschac, boristopalov
Tags: #background-notifications
Differential Revision: https://phabricator.ashoat.com/D2313 |
129,191 | 02.11.2021 18:19:38 | -3,600 | 2e33b1b64404b1923b5c8920b03acb849ced5c1e | [CommCoreModule] Use network singleton in CommCoreModule
Summary: Modify functions to use network module via the singleton.
Test Plan: We're not calling this function currently, so nothing should change.
Reviewers: ashoat, karol-bisztyga
Subscribers: Adrian, atul, benschac, boristopalov
Tags: #background-notifications | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "#include \"CommCoreModule.h\"\n#include \"DatabaseManager.h\"\n+#include \"InternalModules/GlobalNetworkSingleton.h\"\n+#include \"InternalModules/NetworkModule.h\"\n#include \"Logger.h\"\n#include \"MessageStoreOperations.h\"\n#include \"ThreadStoreOperations.h\"\n@@ -662,17 +664,10 @@ void CommCoreModule::initializeNetworkModule(\nconst std::string &userId,\nconst std::string &deviceToken,\nconst std::string &hostname) {\n- std::string host = (hostname.size() == 0) ? \"localhost\" : hostname;\n- // initialize network module\n- // this is going to differ depending on a device\n- // 10.0.2.2 for android emulator\n- // 192.168.x.x for a physical device etc\n- const std::shared_ptr<grpc::ChannelCredentials> credentials =\n- (host.substr(0, 5) == \"https\")\n- ? grpc::SslCredentials(grpc::SslCredentialsOptions())\n- : grpc::InsecureChannelCredentials();\n- this->networkClient.reset(\n- new network::Client(host, \"50051\", credentials, userId, deviceToken));\n+ GlobalNetworkSingleton::instance.scheduleOrRun(\n+ [=](NetworkModule &networkModule) {\n+ networkModule.initializeNetworkModule(userId, deviceToken, hostname);\n+ });\n}\njsi::Value CommCoreModule::getUserPublicKey(jsi::Runtime &rt) {\n@@ -725,7 +720,8 @@ CommCoreModule::CommCoreModule(\nstd::shared_ptr<facebook::react::CallInvoker> jsInvoker)\n: facebook::react::CommCoreModuleSchemaCxxSpecJSI(jsInvoker),\ndatabaseThread(std::make_unique<WorkerThread>(\"database\")),\n- cryptoThread(std::make_unique<WorkerThread>(\"crypto\")),\n- networkThread(std::make_unique<WorkerThread>(\"network\")){};\n+ cryptoThread(std::make_unique<WorkerThread>(\"crypto\")) {\n+ GlobalNetworkSingleton::instance.enableMultithreading();\n+};\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "@@ -15,7 +15,6 @@ namespace jsi = facebook::jsi;\nclass CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {\nstd::unique_ptr<WorkerThread> databaseThread;\nstd::unique_ptr<WorkerThread> cryptoThread;\n- std::unique_ptr<WorkerThread> networkThread;\nCommSecureStore secureStore;\nconst std::string secureStoreAccountDataKey = \"cryptoAccountDataKey\";\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Use network singleton in CommCoreModule
Summary: Modify functions to use network module via the singleton.
Test Plan: We're not calling this function currently, so nothing should change.
Reviewers: ashoat, karol-bisztyga
Reviewed By: ashoat
Subscribers: Adrian, atul, benschac, boristopalov
Tags: #background-notifications
Differential Revision: https://phabricator.ashoat.com/D2314 |
129,184 | 08.11.2021 14:02:21 | 18,000 | 7c08466c6cf0772bed944c8830b3d0bf22d099bf | [native] `codeVersion` -> 112 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 111\n- versionName '1.0.111'\n+ versionCode 112\n+ versionName '1.0.112'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.111</string>\n+ <string>1.0.112</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>111</string>\n+ <string>112</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.111</string>\n+ <string>1.0.112</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>111</string>\n+ <string>112</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 111;\n+const codeVersion = 112;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 112 |
129,184 | 08.11.2021 17:52:31 | 18,000 | 4ebaa65307008aa82b36041102e85bbe7ae2f2f6 | [native] `codeVersion` -> 113 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 112\n- versionName '1.0.112'\n+ versionCode 113\n+ versionName '1.0.113'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.112</string>\n+ <string>1.0.113</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>112</string>\n+ <string>113</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.112</string>\n+ <string>1.0.113</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>112</string>\n+ <string>113</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 112;\n+const codeVersion = 113;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 113 |
129,190 | 09.11.2021 16:17:57 | -3,600 | 4ff0571ab3d3fddbbc4da5b87d782abeda68a732 | [services] Avoid boilerplate
Summary: In response to I made scripts spawning docker images parameterized.
Test Plan: Run all scripts from `services/package.json`
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-base/config.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+IMAGE_NAME=\"commapp/backup-base\"\n+VERSION=\"1.0\"\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/config.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+# this script should be run from the comm's root directory\n+\n+IMAGE_NAME=\"commapp/backup-server\"\n+VERSION=\"1.0\"\n+EXTRA_ARGS=\"-v $HOME/.aws/credentials:/root/.aws/credentials:ro\"\n"
},
{
"change_type": "DELETE",
"old_path": "services/backup/docker-server/run.sh",
"new_path": null,
"diff": "-#/bin/bash\n-\n-set -e\n-\n-# this script should be run from the comm's root directory\n-\n-IMAGE_NAME=\"commapp/backup-server\"\n-VERSION=\"1.0\"\n-CONTAINERS_IDS=$(docker ps -aq -f ancestor=$IMAGE_NAME:$VERSION)\n-NCONTAINERS=$(docker ps -aq -f ancestor=$IMAGE_NAME:$VERSION | wc -l | sed 's/ //g')\n-\n-if [[ $NCONTAINERS -gt 1 ]]\n-then\n- echo \"There's more than one container of '$IMAGE_NAME' image. Due to possible large sizes of containers creating a new one will be aborted now. Please remove containers manually and run this script again.\"\n- echo \"You can run:\"\n- echo \"docker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\"\n- exit 0;\n-elif [[ $NCONTAINERS -eq 1 ]]\n-then\n- echo \"A container of image $IMAGE_NAME already exists(container id: $CONTAINERS_IDS).\"\n- if [[ $1 == \"--overwrite\" ]]\n- then\n- echo \"Overwriting an existing image\"\n- docker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\n- docker rmi $IMAGE_NAME:$VERSION\n-\n- docker build -t $IMAGE_NAME:$VERSION -f services/backup/docker-server/Dockerfile .\n- docker run -it -p 50051:50051 -v $HOME/.aws/credentials:/root/.aws/credentials:ro $IMAGE_NAME:$VERSION\n- else\n- echo \"A new one will not be created, the current one will be used.\"\n- echo \"If you encounter errors, please remove this container manually and re-run this script.\"\n- echo \"To remove this container, you can run:\"\n- echo \"docker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\"\n- docker start $CONTAINERS_IDS\n- docker attach $CONTAINERS_IDS\n- fi\n-else\n- echo \"Creating a new container for image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/backup/docker-server/Dockerfile .\n- docker run -it -p 50051:50051 -v $HOME/.aws/credentials:/root/.aws/credentials:ro $IMAGE_NAME:$VERSION\n-fi\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/base-image/config.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+IMAGE_NAME=\"commapp/services-base\"\n+VERSION=\"1.0\"\n"
},
{
"change_type": "DELETE",
"old_path": "services/base-image/run.sh",
"new_path": null,
"diff": "-#/bin/bash\n-\n-set -e\n-\n-# this script should be run from the comm's root directory\n-\n-IMAGE_NAME=\"commapp/services-base\"\n-VERSION=\"1.0\"\n-IMAGES_IDS=$(docker images -f \"reference=$IMAGE_NAME\" -q)\n-NIMAGES=$(docker images -f \"reference=$IMAGE_NAME\" -q | wc -l | sed 's/ //g')\n-\n-if [[ $NIMAGES -gt 1 ]]\n-then\n- echo \"There's more than one image '$IMAGE_NAME'. Due to possible large sizes of images creating a new one will be aborted now. Please remove images manually and run this script again.\"\n- echo \"You can run:\"\n- echo \"docker rmi $(echo $IMAGES_IDS)\"\n- exit 1;\n-elif [[ $NIMAGES -eq 1 ]]\n-then\n- echo \"An image $IMAGE_NAME already exists. A new one will not be created, the current one will be used.\"\n- echo \"If you encounter errors, please remove this image manually and re-run this script.\"\n- echo \"To remove this image, you can run:\"\n- echo \"docker rmi $(echo $IMAGES_IDS)\"\n-else\n- echo \"Creating a new image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/base-image/Dockerfile .\n-fi\n"
},
{
"change_type": "MODIFY",
"old_path": "services/package.json",
"new_path": "services/package.json",
"diff": "\"private\": true,\n\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n- \"build-base-image\": \"cd .. && ./services/base-image/run.sh && cd -\",\n- \"build-tunnelbroker-base\": \"cd .. && ./services/tunnelbroker/docker-base/run.sh && cd -\",\n- \"run-tunnelbroker-server\": \"cd .. && ./services/tunnelbroker/docker-server/run.sh --overwrite && cd -\",\n- \"build-backup-base\": \"cd .. && ./services/backup/docker-base/run.sh && cd -\",\n- \"run-backup-server\": \"cd .. && ./services/backup/docker-server/run.sh --overwrite && cd -\"\n+ \"build-base-image\": \"cd .. && ./services/scripts/build_base_image.sh ./services/base-image && cd -\",\n+ \"build-tunnelbroker-base\": \"cd .. && ./services/scripts/build_base_image.sh ./services/tunnelbroker/docker-base && cd -\",\n+ \"run-tunnelbroker-server\": \"cd .. && ./services/scripts/run_server_image.sh ./services/tunnelbroker/docker-server --overwrite && cd -\",\n+ \"build-backup-base\": \"cd .. && ./services/scripts/build_base_image.sh ./services/backup/docker-base && cd -\",\n+ \"run-backup-server\": \"cd .. && ./services/scripts/run_server_image.sh ./services/backup/docker-server --overwrite && cd -\"\n}\n}\n"
},
{
"change_type": "RENAME",
"old_path": "services/backup/docker-base/run.sh",
"new_path": "services/scripts/build_base_image.sh",
"diff": "@@ -4,8 +4,28 @@ set -e\n# this script should be run from the comm's root directory\n-IMAGE_NAME=\"commapp/backup-base\"\n-VERSION=\"1.0\"\n+if [ \"$#\" -ne 1 ]; then\n+ echo \"Illegal number of parameters, expected one argument with a path to a directory containing Dockerfile and a config file\"\n+ exit 1;\n+fi\n+\n+GIVEN_PATH=$1\n+CONFIG_PATH=$GIVEN_PATH/config.sh\n+DOCKERFILE_PATH=$GIVEN_PATH/Dockerfile\n+\n+if [ ! -f $CONFIG_PATH ]; then\n+ echo \"Config file not found in $GIVEN_PATH, it has to be named \\`config.sh\\`\"\n+ exit 1;\n+fi\n+\n+if [ ! -f $DOCKERFILE_PATH ]; then\n+ echo \"Dockerfile not found in $GIVEN_PATH\"\n+ exit 1;\n+fi\n+\n+echo \"reading configuration from $GIVEN_PATH\"\n+source $CONFIG_PATH\n+\nIMAGES_IDS=$(docker images -f \"reference=$IMAGE_NAME\" -q)\nNIMAGES=$(docker images -f \"reference=$IMAGE_NAME\" -q | wc -l | sed 's/ //g')\n@@ -23,5 +43,5 @@ then\necho \"docker rmi $(echo $IMAGES_IDS)\"\nelse\necho \"Creating a new image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/backup/docker-base/Dockerfile .\n+ docker build -t $IMAGE_NAME:$VERSION -f $DOCKERFILE_PATH .\nfi\n"
},
{
"change_type": "RENAME",
"old_path": "services/tunnelbroker/docker-server/run.sh",
"new_path": "services/scripts/run_server_image.sh",
"diff": "@@ -4,8 +4,30 @@ set -e\n# this script should be run from the comm's root directory\n-IMAGE_NAME=\"commapp/tunnelbroker-server\"\n-VERSION=\"1.0\"\n+if [ \"$#\" -lt 1 ] || [ \"$#\" -gt 2 ]; then\n+ echo \"Illegal number of parameters, expected:\"\n+ echo \"- one argument with a path to a directory containing Dockerfile and a config file\"\n+ echo \"- one optional argument --overwrite\"\n+ exit 1;\n+fi\n+\n+GIVEN_PATH=$1\n+CONFIG_PATH=$GIVEN_PATH/config.sh\n+DOCKERFILE_PATH=$GIVEN_PATH/Dockerfile\n+\n+if [ ! -f $CONFIG_PATH ]; then\n+ echo \"Config file not found in $GIVEN_PATH, it has to be named \\`config.sh\\`\"\n+ exit 1;\n+fi\n+\n+if [ ! -f $DOCKERFILE_PATH ]; then\n+ echo \"Dockerfile not found in $GIVEN_PATH\"\n+ exit 1;\n+fi\n+\n+echo \"reading configuration from $GIVEN_PATH\"\n+source $CONFIG_PATH\n+\nCONTAINERS_IDS=$(docker ps -aq -f ancestor=$IMAGE_NAME:$VERSION)\nNCONTAINERS=$(docker ps -aq -f ancestor=$IMAGE_NAME:$VERSION | wc -l | sed 's/ //g')\n@@ -18,14 +40,14 @@ then\nelif [[ $NCONTAINERS -eq 1 ]]\nthen\necho \"A container of image $IMAGE_NAME already exists(container id: $CONTAINERS_IDS).\"\n- if [[ $1 == \"--overwrite\" ]]\n+ if [[ $2 == \"--overwrite\" ]]\nthen\necho \"Overwriting an existing image\"\ndocker stop $(echo $CONTAINERS_IDS) && docker rm $(echo $CONTAINERS_IDS)\ndocker rmi $IMAGE_NAME:$VERSION\n- docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/docker-server/Dockerfile .\n- docker run -it -p 50051:50051 $IMAGE_NAME:$VERSION\n+ docker build -t $IMAGE_NAME:$VERSION -f $DOCKERFILE_PATH .\n+ docker run -it -p 50051:50051 $EXTRA_ARGS $IMAGE_NAME:$VERSION\nelse\necho \"A new one will not be created, the current one will be used.\"\necho \"If you encounter errors, please remove this container manually and re-run this script.\"\n@@ -36,6 +58,6 @@ then\nfi\nelse\necho \"Creating a new container for image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/docker-server/Dockerfile .\n- docker run -it -p 50051:50051 $IMAGE_NAME:$VERSION\n+ docker build -t $IMAGE_NAME:$VERSION -f $DOCKERFILE_PATH .\n+ docker run -it -p 50051:50051 $EXTRA_ARGS $IMAGE_NAME:$VERSION\nfi\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/tunnelbroker/docker-base/config.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+IMAGE_NAME=\"commapp/tunnelbroker-base\"\n+VERSION=\"1.0\"\n"
},
{
"change_type": "DELETE",
"old_path": "services/tunnelbroker/docker-base/run.sh",
"new_path": null,
"diff": "-#/bin/bash\n-\n-set -e\n-\n-# this script should be run from the comm's root directory\n-\n-IMAGE_NAME=\"commapp/tunnelbroker-base\"\n-VERSION=\"1.0\"\n-IMAGES_IDS=$(docker images -f \"reference=$IMAGE_NAME\" -q)\n-NIMAGES=$(docker images -f \"reference=$IMAGE_NAME\" -q | wc -l | sed 's/ //g')\n-\n-if [[ $NIMAGES -gt 1 ]]\n-then\n- echo \"There's more than one image '$IMAGE_NAME'. Due to possible large sizes of images creating a new one will be aborted now. Please remove images manually and run this script again.\"\n- echo \"You can run:\"\n- echo \"docker rmi $(echo $IMAGES_IDS)\"\n- exit 1;\n-elif [[ $NIMAGES -eq 1 ]]\n-then\n- echo \"An image $IMAGE_NAME already exists. A new one will not be created, the current one will be used.\"\n- echo \"If you encounter errors, please remove this image manually and re-run this script.\"\n- echo \"To remove this image, you can run:\"\n- echo \"docker rmi $(echo $IMAGES_IDS)\"\n-else\n- echo \"Creating a new image $IMAGE_NAME\"\n- docker build -t $IMAGE_NAME:$VERSION -f services/tunnelbroker/docker-base/Dockerfile .\n-fi\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/tunnelbroker/docker-server/config.sh",
"diff": "+#/bin/bash\n+\n+set -e\n+\n+IMAGE_NAME=\"commapp/tunnelbroker-server\"\n+VERSION=\"1.0\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Avoid boilerplate
Summary: In response to https://linear.app/comm/issue/COM-29/avoid-dry-in-services, I made scripts spawning docker images parameterized.
Test Plan: Run all scripts from `services/package.json`
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services
Differential Revision: https://phabricator.ashoat.com/D2311 |
129,184 | 10.11.2021 13:09:36 | 18,000 | 4867283d3baf7b1f3fa8b5f12752be5ea7eb753b | [native] `codeVersion` -> 114 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 113\n- versionName '1.0.113'\n+ versionCode 114\n+ versionName '1.0.114'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.113</string>\n+ <string>1.0.114</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>113</string>\n+ <string>114</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.113</string>\n+ <string>1.0.114</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>113</string>\n+ <string>114</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 113;\n+const codeVersion = 114;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 114 |
129,184 | 10.11.2021 13:13:26 | 18,000 | ca30b49038f440b42687fa4ce47a408ed780af5b | [native] `codeVersion` -> 115 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 114\n- versionName '1.0.114'\n+ versionCode 115\n+ versionName '1.0.115'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.114</string>\n+ <string>1.0.115</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>114</string>\n+ <string>115</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.114</string>\n+ <string>1.0.115</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>114</string>\n+ <string>115</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 114;\n+const codeVersion = 115;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 115 |
129,179 | 10.11.2021 15:32:29 | 18,000 | 0f34fe43ed01600a7207a3f5b31fb96b9dc1fe57 | [lib] [refactor] CHANGE_USER_SETTINGS --> CHANGE_USER_PASSWORD
Summary: CHANGE_USER_SETTING and USER_SETTINGS are a bit redundant so I renamed CHANGE_USER_SETTING to CHANGE_USER_PASSWORD
Test Plan: go though the user password change flow to confirm functionality isn't broken
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -155,9 +155,9 @@ const logIn = (\n};\nconst changeUserSettingsActionTypes = Object.freeze({\n- started: 'CHANGE_USER_SETTINGS_STARTED',\n- success: 'CHANGE_USER_SETTINGS_SUCCESS',\n- failed: 'CHANGE_USER_SETTINGS_FAILED',\n+ started: 'CHANGE_USER_PASSWORD_SETTINGS_STARTED',\n+ success: 'CHANGE_USER_PASSWORD_SETTINGS_SUCCESS',\n+ failed: 'CHANGE_USER_PASSWORD_SETTINGS_FAILED',\n});\nconst changeUserSettings = (\nfetchJSON: FetchJSON,\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -259,18 +259,18 @@ export type BaseAction =\n+loadingInfo: LoadingInfo,\n}\n| {\n- +type: 'CHANGE_USER_SETTINGS_STARTED',\n+ +type: 'CHANGE_USER_PASSWORD_SETTINGS_STARTED',\n+payload?: void,\n+loadingInfo: LoadingInfo,\n}\n| {\n- +type: 'CHANGE_USER_SETTINGS_FAILED',\n+ +type: 'CHANGE_USER_PASSWORD_SETTINGS_FAILED',\n+error: true,\n+payload: Error,\n+loadingInfo: LoadingInfo,\n}\n| {\n- +type: 'CHANGE_USER_SETTINGS_SUCCESS',\n+ +type: 'CHANGE_USER_PASSWORD_SETTINGS_SUCCESS',\n+payload?: void,\n+loadingInfo: LoadingInfo,\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [refactor] CHANGE_USER_SETTINGS --> CHANGE_USER_PASSWORD
Summary: CHANGE_USER_SETTING and USER_SETTINGS are a bit redundant so I renamed CHANGE_USER_SETTING to CHANGE_USER_PASSWORD
Test Plan: go though the user password change flow to confirm functionality isn't broken
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2343 |
129,179 | 11.11.2021 14:30:19 | 18,000 | 1acbe8c1da4235f62dc2b8f8334742d5a355c745 | refactor add brackets to function
Summary: small code style change. Every other function had {} braces.
Test Plan: N/A make sure nothing is broken
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -216,8 +216,9 @@ const getUserPublicKeys = (\nfetchJSON: FetchJSON,\n): ((\ndata: GetUserPublicKeysArgs,\n-) => Promise<UserPublicKeys | null>) => async data =>\n- await fetchJSON('get_user_public_keys', data);\n+) => Promise<UserPublicKeys | null>) => async data => {\n+ return await fetchJSON('get_user_public_keys', data);\n+};\nexport {\nappStartNativeCredentialsAutoLogIn,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | refactor add brackets to function
Summary: small code style change. Every other function had {} braces.
Test Plan: N/A make sure nothing is broken
Reviewers: atul, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2348 |
129,184 | 11.11.2021 17:13:15 | 18,000 | ae9d23ef4b0185eb0bdf4ddc84755c38986cc8b1 | [lib] Add `PRIVATE` to `threadTypeCanBePending`
Summary: Fixes crash when creating a new thread from "New Message" screen
Test Plan: tbd
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -432,6 +432,15 @@ function pendingThreadType(numberOfOtherMembers: number): 4 | 6 | 7 {\n}\n}\n+function threadTypeCanBePending(threadType: ThreadType): boolean {\n+ return (\n+ threadType === threadTypes.PERSONAL ||\n+ threadType === threadTypes.LOCAL ||\n+ threadType === threadTypes.SIDEBAR ||\n+ threadType === threadTypes.PRIVATE\n+ );\n+}\n+\ntype CreateRealThreadParameters = {\n+threadInfo: ThreadInfo,\n+dispatchActionPromise: DispatchActionPromise,\n@@ -1127,14 +1136,6 @@ function draftKeyFromThreadID(threadID: string): string {\nreturn `${threadID}/message_composer`;\n}\n-function threadTypeCanBePending(threadType: ThreadType): boolean {\n- return (\n- threadType === threadTypes.PERSONAL ||\n- threadType === threadTypes.LOCAL ||\n- threadType === threadTypes.SIDEBAR\n- );\n-}\n-\nfunction getContainingThreadID(\nparentThreadInfo: ?ServerThreadInfo | RawThreadInfo | ThreadInfo,\nthreadType: ThreadType,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `PRIVATE` to `threadTypeCanBePending`
Summary: Fixes crash when creating a new thread from "New Message" screen
Test Plan: tbd
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2349 |
129,184 | 11.11.2021 17:42:16 | 18,000 | 5fc5edad781135a37efd30a09de8bc715ee60a26 | [native] `codeVersion` -> 117 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 115\n- versionName '1.0.115'\n+ versionCode 117\n+ versionName '1.0.117'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.115</string>\n+ <string>1.0.117</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>115</string>\n+ <string>117</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.115</string>\n+ <string>1.0.117</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>115</string>\n+ <string>117</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 115;\n+const codeVersion = 117;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 117 |
129,184 | 11.11.2021 17:47:55 | 18,000 | ecd16fc4874e7714edae717629796b839b895d1d | [native] `codeVersion` -> 118 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 117\n- versionName '1.0.117'\n+ versionCode 118\n+ versionName '1.0.118'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.117</string>\n+ <string>1.0.118</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>117</string>\n+ <string>118</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.117</string>\n+ <string>1.0.118</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>117</string>\n+ <string>118</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 117;\n+const codeVersion = 118;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 118 |
129,184 | 11.11.2021 18:12:30 | 18,000 | f3b70b37059b1c26076e15ff9e399c334bafa9c9 | [native] `codeVersion` -> 119 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 118\n- versionName '1.0.118'\n+ versionCode 119\n+ versionName '1.0.119'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.118</string>\n+ <string>1.0.119</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>118</string>\n+ <string>119</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.118</string>\n+ <string>1.0.119</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>118</string>\n+ <string>119</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 118;\n+const codeVersion = 119;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 119 |
129,179 | 10.11.2021 10:25:32 | 18,000 | cfdeb1a0b188ea92e4b8818c13cc34a188299829 | [lib] [1/n] add UserSettingsRequest action
Summary: Add User Setting action for user default notification settings
Test Plan: N/A just a small piece of the redux life cycle
Reviewers: atul, ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -8,6 +8,7 @@ import type {\nRegisterResult,\nRegisterInfo,\nAccessRequest,\n+ UpdateUserSettingsRequest,\n} from '../types/account-types';\nimport type { GetUserPublicKeysArgs } from '../types/request-types';\nimport type { UserSearchResult } from '../types/search-types';\n@@ -212,6 +213,20 @@ const requestAccess = (\nawait fetchJSON('request_access', accessRequest);\n};\n+const setUserSettingsActionTypes = Object.freeze({\n+ started: 'SET_USER_SETTINGS_STARTED',\n+ success: 'SET_USER_SETTINGS_SUCCESS',\n+ failed: 'SET_USER_SETTINGS_FAILED',\n+});\n+\n+const setUserSettings = (\n+ fetchJSON: FetchJSON,\n+): ((\n+ userSettingsRequest: UpdateUserSettingsRequest,\n+) => Promise<void>) => async userSettingsRequest => {\n+ await fetchJSON('update_user_settings', userSettingsRequest);\n+};\n+\nconst getUserPublicKeys = (\nfetchJSON: FetchJSON,\n): ((\n@@ -239,6 +254,8 @@ export {\nrequestAccessActionTypes,\nsearchUsers,\nsearchUsersActionTypes,\n+ setUserSettings,\n+ setUserSettingsActionTypes,\nsocketAuthErrorResolutionAttempt,\nsqliteLoadFailure,\nsqliteOpFailure,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [1/n] add UserSettingsRequest action
Summary: Add User Setting action for user default notification settings
Test Plan: N/A just a small piece of the redux life cycle
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2331 |
129,179 | 08.11.2021 07:40:29 | 18,000 | 7dd157e8993afd3f00bc58622d5b460c8f4d22c8 | [native] [2/n] add pref boilerplate for redux
Summary: Add boilerplate, more or less copy-pasta'ed from relationship-list.react.js
Test Plan: default notifications should still render, no new functionality yet, just breaking up diffs.
Reviewers: atul, palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "@@ -5,7 +5,9 @@ import { View, Text, ScrollView, Platform } from 'react-native';\nimport Action from '../components/action-row.react';\nimport SWMansionIcon from '../components/swmansion-icon.react';\n+import type { NavigationRoute } from '../navigation/route-names';\nimport { useStyles } from '../themes/colors';\n+import type { ProfileNavigationProp } from './profile.react';\nconst CheckIcon = () => (\n<SWMansionIcon\n@@ -32,10 +34,19 @@ function NotificationRow(props: ProfileRowProps): React.Node {\n);\n}\n-// eslint-disable-next-line no-unused-vars\n-function DefaultNotificationsPreferences(props: { ... }): React.Node {\n- const styles = useStyles(unboundStyles);\n+type BaseProps = {\n+ +navigation: ProfileNavigationProp<>,\n+ +route: NavigationRoute<'DefaultNotifications'>,\n+};\n+type Props = {\n+ ...BaseProps,\n+ styles: typeof unboundStyles,\n+};\n+\n+class DefaultNotificationsPreferences extends React.PureComponent<Props> {\n+ render() {\n+ const { styles } = this.props;\nreturn (\n<ScrollView\ncontentContainerStyle={styles.scrollViewContentContainer}\n@@ -50,6 +61,7 @@ function DefaultNotificationsPreferences(props: { ... }): React.Node {\n</ScrollView>\n);\n}\n+}\nconst unboundStyles = {\nscrollView: {\n@@ -78,4 +90,11 @@ const unboundStyles = {\n},\n};\n-export default DefaultNotificationsPreferences;\n+const ConnectedDefaultNotificationPreferences: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n+ function ConnectedDefaultNotificationPreferences(props: BaseProps) {\n+ const styles = useStyles(unboundStyles);\n+ return <DefaultNotificationsPreferences {...props} {...{ styles }} />;\n+ },\n+);\n+\n+export default ConnectedDefaultNotificationPreferences;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [2/n] add pref boilerplate for redux
Summary: Add boilerplate, more or less copy-pasta'ed from relationship-list.react.js
Test Plan: default notifications should still render, no new functionality yet, just breaking up diffs.
Reviewers: atul, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2333 |
129,179 | 10.11.2021 12:06:30 | 18,000 | 355fa295da4d81c60c2d7075710562fe1fb49f3a | [lib] [4/n] add action types to base types
Summary: add USER_SETTINGS to base actions
Test Plan: N/A just adding types
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -764,6 +764,22 @@ export type BaseAction =\n| {\n+type: 'SET_THREAD_STORE',\n+payload: ThreadStore,\n+ }\n+ | {\n+ +type: 'SET_USER_SETTINGS_STARTED',\n+ +payload?: void,\n+ +loadingInfo: LoadingInfo,\n+ }\n+ | {\n+ +type: 'SET_USER_SETTINGS_SUCCESS',\n+ +payload: {\n+ +defaultNotifications: string,\n+ },\n+ }\n+ | {\n+ +type: 'SET_USER_SETTINGS_FAILED',\n+ +payload: Error,\n+ +loadingInfo: LoadingInfo,\n};\nexport type ActionPayload = ?(Object | Array<*> | $ReadOnlyArray<*> | string);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] [4/n] add action types to base types
Summary: add USER_SETTINGS to base actions
Test Plan: N/A just adding types
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2342 |
129,184 | 12.11.2021 10:13:50 | 18,000 | 737d451b1fa6ed95ece61a9ae8903e2dd0043678 | [native] Add `jsonwebtoken` and `gaxios` to `package.json`
Summary:
So we can hit App Store Connect API endpoints:
Test Plan: na
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/package.json",
"new_path": "native/package.json",
"diff": "\"flow-typed\": \"^3.2.1\",\n\"fs-extra\": \"^8.1.0\",\n\"googleapis\": \"^89.0.0\",\n+ \"gaxios\": \"^4.3.2\",\n+ \"jsonwebtoken\": \"^8.5.1\",\n\"jest\": \"^26.6.3\",\n\"jetifier\": \"^1.6.4\",\n\"metro-react-native-babel-preset\": \"^0.64.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -9126,7 +9126,7 @@ gaxios@^3.0.0:\nis-stream \"^2.0.0\"\nnode-fetch \"^2.3.0\"\n-gaxios@^4.0.0:\n+gaxios@^4.0.0, gaxios@^4.3.2:\nversion \"4.3.2\"\nresolved \"https://registry.yarnpkg.com/gaxios/-/gaxios-4.3.2.tgz#845827c2dc25a0213c8ab4155c7a28910f5be83f\"\nintegrity sha512-T+ap6GM6UZ0c4E6yb1y/hy2UB6hTrqhglp3XfmU9qbLCGRYhLVV5aRPpC4EmoG8N8zOnkYCgoBz+ScvGAARY6Q==\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Add `jsonwebtoken` and `gaxios` to `package.json`
Summary:
So we can hit App Store Connect API endpoints:
https://developer.apple.com/documentation/appstoreconnectapi/generating_tokens_for_api_requests
Test Plan: na
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2354 |
129,190 | 15.11.2021 09:39:48 | -3,600 | 8cf304bee06686d3c50db10919586529686712ad | [services] Add oneof data to PullCompactionResponse
Summary: to make it consistent with `ResetKeyRequest`
Test Plan: backup service should run as usual
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.cc",
"new_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.cc",
"diff": "@@ -108,8 +108,7 @@ struct PullCompactionRequestDefaultTypeInternal {\nPROTOBUF_ATTRIBUTE_NO_DESTROY PROTOBUF_CONSTINIT PullCompactionRequestDefaultTypeInternal _PullCompactionRequest_default_instance_;\nconstexpr PullCompactionResponse::PullCompactionResponse(\n::PROTOBUF_NAMESPACE_ID::internal::ConstantInitialized)\n- : compactionchunk_(&::PROTOBUF_NAMESPACE_ID::internal::fixed_address_empty_string)\n- , logchunk_(&::PROTOBUF_NAMESPACE_ID::internal::fixed_address_empty_string){}\n+ : _oneof_case_{}{}\nstruct PullCompactionResponseDefaultTypeInternal {\nconstexpr PullCompactionResponseDefaultTypeInternal()\n: _instance(::PROTOBUF_NAMESPACE_ID::internal::ConstantInitialized{}) {}\n@@ -177,10 +176,11 @@ const ::PROTOBUF_NAMESPACE_ID::uint32 TableStruct_backup_2eproto::offsets[] PROT\n~0u, // no _has_bits_\nPROTOBUF_FIELD_OFFSET(::backup::PullCompactionResponse, _internal_metadata_),\n~0u, // no _extensions_\n- ~0u, // no _oneof_case_\n+ PROTOBUF_FIELD_OFFSET(::backup::PullCompactionResponse, _oneof_case_[0]),\n~0u, // no _weak_field_map_\n- PROTOBUF_FIELD_OFFSET(::backup::PullCompactionResponse, compactionchunk_),\n- PROTOBUF_FIELD_OFFSET(::backup::PullCompactionResponse, logchunk_),\n+ ::PROTOBUF_NAMESPACE_ID::internal::kInvalidFieldOffsetTag,\n+ ::PROTOBUF_NAMESPACE_ID::internal::kInvalidFieldOffsetTag,\n+ PROTOBUF_FIELD_OFFSET(::backup::PullCompactionResponse, data_),\n};\nstatic const ::PROTOBUF_NAMESPACE_ID::internal::MigrationSchema schemas[] PROTOBUF_SECTION_VARIABLE(protodesc_cold) = {\n{ 0, -1, sizeof(::backup::ResetKeyRequest)},\n@@ -215,21 +215,21 @@ const char descriptor_table_protodef_backup_2eproto[] PROTOBUF_SECTION_VARIABLE(\n\"ey\\030\\002 \\001(\\014\\\"D\\n\\025PullBackupKeyResponse\\022\\017\\n\\007suc\"\n\"cess\\030\\001 \\001(\\010\\022\\032\\n\\022encryptedBackupKey\\030\\002 \\001(\\014\\\"8\"\n\"\\n\\025PullCompactionRequest\\022\\016\\n\\006userId\\030\\001 \\001(\\t\\022\"\n- \"\\017\\n\\007message\\030\\002 \\001(\\014\\\"C\\n\\026PullCompactionRespon\"\n- \"se\\022\\027\\n\\017compactionChunk\\030\\001 \\001(\\014\\022\\020\\n\\010logChunk\\030\"\n- \"\\002 \\001(\\0142\\265\\002\\n\\rBackupService\\022A\\n\\010ResetKey\\022\\027.ba\"\n- \"ckup.ResetKeyRequest\\032\\030.backup.ResetKeyRe\"\n- \"sponse\\\"\\000(\\001\\022<\\n\\007SendLog\\022\\026.backup.SendLogRe\"\n- \"quest\\032\\027.backup.SendLogResponse\\\"\\000\\022N\\n\\rPull\"\n- \"BackupKey\\022\\034.backup.PullBackupKeyRequest\\032\"\n- \"\\035.backup.PullBackupKeyResponse\\\"\\000\\022S\\n\\016Pull\"\n- \"Compaction\\022\\035.backup.PullCompactionReques\"\n- \"t\\032\\036.backup.PullCompactionResponse\\\"\\0000\\001b\\006p\"\n- \"roto3\"\n+ \"\\017\\n\\007message\\030\\002 \\001(\\014\\\"O\\n\\026PullCompactionRespon\"\n+ \"se\\022\\031\\n\\017compactionChunk\\030\\001 \\001(\\014H\\000\\022\\022\\n\\010logChun\"\n+ \"k\\030\\002 \\001(\\014H\\000B\\006\\n\\004data2\\265\\002\\n\\rBackupService\\022A\\n\\010R\"\n+ \"esetKey\\022\\027.backup.ResetKeyRequest\\032\\030.backu\"\n+ \"p.ResetKeyResponse\\\"\\000(\\001\\022<\\n\\007SendLog\\022\\026.back\"\n+ \"up.SendLogRequest\\032\\027.backup.SendLogRespon\"\n+ \"se\\\"\\000\\022N\\n\\rPullBackupKey\\022\\034.backup.PullBacku\"\n+ \"pKeyRequest\\032\\035.backup.PullBackupKeyRespon\"\n+ \"se\\\"\\000\\022S\\n\\016PullCompaction\\022\\035.backup.PullComp\"\n+ \"actionRequest\\032\\036.backup.PullCompactionRes\"\n+ \"ponse\\\"\\0000\\001b\\006proto3\"\n;\nstatic ::PROTOBUF_NAMESPACE_ID::internal::once_flag descriptor_table_backup_2eproto_once;\nconst ::PROTOBUF_NAMESPACE_ID::internal::DescriptorTable descriptor_table_backup_2eproto = {\n- false, false, 805, descriptor_table_protodef_backup_2eproto, \"backup.proto\",\n+ false, false, 817, descriptor_table_protodef_backup_2eproto, \"backup.proto\",\n&descriptor_table_backup_2eproto_once, nullptr, 0, 8,\nschemas, file_default_instances, TableStruct_backup_2eproto::offsets,\nfile_level_metadata_backup_2eproto, file_level_enum_descriptors_backup_2eproto, file_level_service_descriptors_backup_2eproto,\n@@ -1852,22 +1852,25 @@ PullCompactionResponse::PullCompactionResponse(::PROTOBUF_NAMESPACE_ID::Arena* a\nPullCompactionResponse::PullCompactionResponse(const PullCompactionResponse& from)\n: ::PROTOBUF_NAMESPACE_ID::Message() {\n_internal_metadata_.MergeFrom<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(from._internal_metadata_);\n- compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n- if (!from._internal_compactionchunk().empty()) {\n- compactionchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, from._internal_compactionchunk(),\n- GetArena());\n+ clear_has_data();\n+ switch (from.data_case()) {\n+ case kCompactionChunk: {\n+ _internal_set_compactionchunk(from._internal_compactionchunk());\n+ break;\n+ }\n+ case kLogChunk: {\n+ _internal_set_logchunk(from._internal_logchunk());\n+ break;\n+ }\n+ case DATA_NOT_SET: {\n+ break;\n}\n- logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n- if (!from._internal_logchunk().empty()) {\n- logchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, from._internal_logchunk(),\n- GetArena());\n}\n// @@protoc_insertion_point(copy_constructor:backup.PullCompactionResponse)\n}\nvoid PullCompactionResponse::SharedCtor() {\n-compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n-logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+clear_has_data();\n}\nPullCompactionResponse::~PullCompactionResponse() {\n@@ -1878,8 +1881,9 @@ PullCompactionResponse::~PullCompactionResponse() {\nvoid PullCompactionResponse::SharedDtor() {\nGOOGLE_DCHECK(GetArena() == nullptr);\n- compactionchunk_.DestroyNoArena(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n- logchunk_.DestroyNoArena(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ if (has_data()) {\n+ clear_data();\n+ }\n}\nvoid PullCompactionResponse::ArenaDtor(void* object) {\n@@ -1892,14 +1896,32 @@ void PullCompactionResponse::SetCachedSize(int size) const {\n_cached_size_.Set(size);\n}\n+void PullCompactionResponse::clear_data() {\n+// @@protoc_insertion_point(one_of_clear_start:backup.PullCompactionResponse)\n+ switch (data_case()) {\n+ case kCompactionChunk: {\n+ data_.compactionchunk_.Destroy(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n+ break;\n+ }\n+ case kLogChunk: {\n+ data_.logchunk_.Destroy(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n+ break;\n+ }\n+ case DATA_NOT_SET: {\n+ break;\n+ }\n+ }\n+ _oneof_case_[0] = DATA_NOT_SET;\n+}\n+\n+\nvoid PullCompactionResponse::Clear() {\n// @@protoc_insertion_point(message_clear_start:backup.PullCompactionResponse)\n::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;\n// Prevent compiler warnings about cached_has_bits being unused\n(void) cached_has_bits;\n- compactionchunk_.ClearToEmpty();\n- logchunk_.ClearToEmpty();\n+ clear_data();\n_internal_metadata_.Clear<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>();\n}\n@@ -1955,13 +1977,13 @@ failure:\n(void) cached_has_bits;\n// bytes compactionChunk = 1;\n- if (this->compactionchunk().size() > 0) {\n+ if (_internal_has_compactionchunk()) {\ntarget = stream->WriteBytesMaybeAliased(\n1, this->_internal_compactionchunk(), target);\n}\n// bytes logChunk = 2;\n- if (this->logchunk().size() > 0) {\n+ if (_internal_has_logchunk()) {\ntarget = stream->WriteBytesMaybeAliased(\n2, this->_internal_logchunk(), target);\n}\n@@ -1982,20 +2004,25 @@ size_t PullCompactionResponse::ByteSizeLong() const {\n// Prevent compiler warnings about cached_has_bits being unused\n(void) cached_has_bits;\n+ switch (data_case()) {\n// bytes compactionChunk = 1;\n- if (this->compactionchunk().size() > 0) {\n+ case kCompactionChunk: {\ntotal_size += 1 +\n::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::BytesSize(\nthis->_internal_compactionchunk());\n+ break;\n}\n-\n// bytes logChunk = 2;\n- if (this->logchunk().size() > 0) {\n+ case kLogChunk: {\ntotal_size += 1 +\n::PROTOBUF_NAMESPACE_ID::internal::WireFormatLite::BytesSize(\nthis->_internal_logchunk());\n+ break;\n+ }\n+ case DATA_NOT_SET: {\n+ break;\n+ }\n}\n-\nif (PROTOBUF_PREDICT_FALSE(_internal_metadata_.have_unknown_fields())) {\nreturn ::PROTOBUF_NAMESPACE_ID::internal::ComputeUnknownFieldsSize(\n_internal_metadata_, total_size, &_cached_size_);\n@@ -2027,11 +2054,18 @@ void PullCompactionResponse::MergeFrom(const PullCompactionResponse& from) {\n::PROTOBUF_NAMESPACE_ID::uint32 cached_has_bits = 0;\n(void) cached_has_bits;\n- if (from.compactionchunk().size() > 0) {\n+ switch (from.data_case()) {\n+ case kCompactionChunk: {\n_internal_set_compactionchunk(from._internal_compactionchunk());\n+ break;\n}\n- if (from.logchunk().size() > 0) {\n+ case kLogChunk: {\n_internal_set_logchunk(from._internal_logchunk());\n+ break;\n+ }\n+ case DATA_NOT_SET: {\n+ break;\n+ }\n}\n}\n@@ -2056,8 +2090,8 @@ bool PullCompactionResponse::IsInitialized() const {\nvoid PullCompactionResponse::InternalSwap(PullCompactionResponse* other) {\nusing std::swap;\n_internal_metadata_.Swap<::PROTOBUF_NAMESPACE_ID::UnknownFieldSet>(&other->_internal_metadata_);\n- compactionchunk_.Swap(&other->compactionchunk_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());\n- logchunk_.Swap(&other->logchunk_, &::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());\n+ swap(data_, other->data_);\n+ swap(_oneof_case_[0], other->_oneof_case_[0]);\n}\n::PROTOBUF_NAMESPACE_ID::Metadata PullCompactionResponse::GetMetadata() const {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.h",
"new_path": "native/cpp/CommonCpp/grpc/_generated/backup.pb.h",
"diff": "@@ -1254,6 +1254,12 @@ class PullCompactionResponse PROTOBUF_FINAL :\nstatic const PullCompactionResponse& default_instance() {\nreturn *internal_default_instance();\n}\n+ enum DataCase {\n+ kCompactionChunk = 1,\n+ kLogChunk = 2,\n+ DATA_NOT_SET = 0,\n+ };\n+\nstatic inline const PullCompactionResponse* internal_default_instance() {\nreturn reinterpret_cast<const PullCompactionResponse*>(\n&_PullCompactionResponse_default_instance_);\n@@ -1333,6 +1339,10 @@ class PullCompactionResponse PROTOBUF_FINAL :\nkLogChunkFieldNumber = 2,\n};\n// bytes compactionChunk = 1;\n+ bool has_compactionchunk() const;\n+ private:\n+ bool _internal_has_compactionchunk() const;\n+ public:\nvoid clear_compactionchunk();\nconst std::string& compactionchunk() const;\nvoid set_compactionchunk(const std::string& value);\n@@ -1349,6 +1359,10 @@ class PullCompactionResponse PROTOBUF_FINAL :\npublic:\n// bytes logChunk = 2;\n+ bool has_logchunk() const;\n+ private:\n+ bool _internal_has_logchunk() const;\n+ public:\nvoid clear_logchunk();\nconst std::string& logchunk() const;\nvoid set_logchunk(const std::string& value);\n@@ -1364,16 +1378,29 @@ class PullCompactionResponse PROTOBUF_FINAL :\nstd::string* _internal_mutable_logchunk();\npublic:\n+ void clear_data();\n+ DataCase data_case() const;\n// @@protoc_insertion_point(class_scope:backup.PullCompactionResponse)\nprivate:\nclass _Internal;\n+ void set_has_compactionchunk();\n+ void set_has_logchunk();\n+\n+ inline bool has_data() const;\n+ inline void clear_has_data();\ntemplate <typename T> friend class ::PROTOBUF_NAMESPACE_ID::Arena::InternalHelper;\ntypedef void InternalArenaConstructable_;\ntypedef void DestructorSkippable_;\n+ union DataUnion {\n+ constexpr DataUnion() : _constinit_{} {}\n+ ::PROTOBUF_NAMESPACE_ID::internal::ConstantInitialized _constinit_;\n::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr compactionchunk_;\n::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr logchunk_;\n+ } data_;\nmutable ::PROTOBUF_NAMESPACE_ID::internal::CachedSize _cached_size_;\n+ ::PROTOBUF_NAMESPACE_ID::uint32 _oneof_case_[1];\n+\nfriend struct ::TableStruct_backup_2eproto;\n};\n// ===================================================================\n@@ -2193,8 +2220,20 @@ inline void PullCompactionRequest::set_allocated_message(std::string* message) {\n// PullCompactionResponse\n// bytes compactionChunk = 1;\n+inline bool PullCompactionResponse::_internal_has_compactionchunk() const {\n+ return data_case() == kCompactionChunk;\n+}\n+inline bool PullCompactionResponse::has_compactionchunk() const {\n+ return _internal_has_compactionchunk();\n+}\n+inline void PullCompactionResponse::set_has_compactionchunk() {\n+ _oneof_case_[0] = kCompactionChunk;\n+}\ninline void PullCompactionResponse::clear_compactionchunk() {\n- compactionchunk_.ClearToEmpty();\n+ if (_internal_has_compactionchunk()) {\n+ data_.compactionchunk_.Destroy(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n+ clear_has_data();\n+ }\n}\ninline const std::string& PullCompactionResponse::compactionchunk() const {\n// @@protoc_insertion_point(field_get:backup.PullCompactionResponse.compactionChunk)\n@@ -2209,53 +2248,102 @@ inline std::string* PullCompactionResponse::mutable_compactionchunk() {\nreturn _internal_mutable_compactionchunk();\n}\ninline const std::string& PullCompactionResponse::_internal_compactionchunk() const {\n- return compactionchunk_.Get();\n+ if (_internal_has_compactionchunk()) {\n+ return data_.compactionchunk_.Get();\n+ }\n+ return ::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited();\n}\ninline void PullCompactionResponse::_internal_set_compactionchunk(const std::string& value) {\n-\n- compactionchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, value, GetArena());\n+ if (!_internal_has_compactionchunk()) {\n+ clear_data();\n+ set_has_compactionchunk();\n+ data_.compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.compactionchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, value, GetArena());\n}\ninline void PullCompactionResponse::set_compactionchunk(std::string&& value) {\n-\n- compactionchunk_.Set(\n+ // @@protoc_insertion_point(field_set:backup.PullCompactionResponse.compactionChunk)\n+ if (!_internal_has_compactionchunk()) {\n+ clear_data();\n+ set_has_compactionchunk();\n+ data_.compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.compactionchunk_.Set(\n::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::move(value), GetArena());\n// @@protoc_insertion_point(field_set_rvalue:backup.PullCompactionResponse.compactionChunk)\n}\ninline void PullCompactionResponse::set_compactionchunk(const char* value) {\nGOOGLE_DCHECK(value != nullptr);\n-\n- compactionchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::string(value), GetArena());\n+ if (!_internal_has_compactionchunk()) {\n+ clear_data();\n+ set_has_compactionchunk();\n+ data_.compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.compactionchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{},\n+ ::std::string(value), GetArena());\n// @@protoc_insertion_point(field_set_char:backup.PullCompactionResponse.compactionChunk)\n}\ninline void PullCompactionResponse::set_compactionchunk(const void* value,\nsize_t size) {\n-\n- compactionchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::string(\n- reinterpret_cast<const char*>(value), size), GetArena());\n+ if (!_internal_has_compactionchunk()) {\n+ clear_data();\n+ set_has_compactionchunk();\n+ data_.compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.compactionchunk_.Set(\n+ ::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::string(\n+ reinterpret_cast<const char*>(value), size),\n+ GetArena());\n// @@protoc_insertion_point(field_set_pointer:backup.PullCompactionResponse.compactionChunk)\n}\ninline std::string* PullCompactionResponse::_internal_mutable_compactionchunk() {\n-\n- return compactionchunk_.Mutable(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n+ if (!_internal_has_compactionchunk()) {\n+ clear_data();\n+ set_has_compactionchunk();\n+ data_.compactionchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ return data_.compactionchunk_.Mutable(\n+ ::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n}\ninline std::string* PullCompactionResponse::release_compactionchunk() {\n// @@protoc_insertion_point(field_release:backup.PullCompactionResponse.compactionChunk)\n- return compactionchunk_.Release(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());\n+ if (_internal_has_compactionchunk()) {\n+ clear_has_data();\n+ return data_.compactionchunk_.ReleaseNonDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());\n+ } else {\n+ return nullptr;\n+ }\n}\ninline void PullCompactionResponse::set_allocated_compactionchunk(std::string* compactionchunk) {\n+ if (has_data()) {\n+ clear_data();\n+ }\nif (compactionchunk != nullptr) {\n-\n- } else {\n-\n+ set_has_compactionchunk();\n+ data_.compactionchunk_.UnsafeSetDefault(compactionchunk);\n+ ::PROTOBUF_NAMESPACE_ID::Arena* arena = GetArena();\n+ if (arena != nullptr) {\n+ arena->Own(compactionchunk);\n+ }\n}\n- compactionchunk_.SetAllocated(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), compactionchunk,\n- GetArena());\n// @@protoc_insertion_point(field_set_allocated:backup.PullCompactionResponse.compactionChunk)\n}\n// bytes logChunk = 2;\n+inline bool PullCompactionResponse::_internal_has_logchunk() const {\n+ return data_case() == kLogChunk;\n+}\n+inline bool PullCompactionResponse::has_logchunk() const {\n+ return _internal_has_logchunk();\n+}\n+inline void PullCompactionResponse::set_has_logchunk() {\n+ _oneof_case_[0] = kLogChunk;\n+}\ninline void PullCompactionResponse::clear_logchunk() {\n- logchunk_.ClearToEmpty();\n+ if (_internal_has_logchunk()) {\n+ data_.logchunk_.Destroy(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n+ clear_has_data();\n+ }\n}\ninline const std::string& PullCompactionResponse::logchunk() const {\n// @@protoc_insertion_point(field_get:backup.PullCompactionResponse.logChunk)\n@@ -2270,50 +2358,96 @@ inline std::string* PullCompactionResponse::mutable_logchunk() {\nreturn _internal_mutable_logchunk();\n}\ninline const std::string& PullCompactionResponse::_internal_logchunk() const {\n- return logchunk_.Get();\n+ if (_internal_has_logchunk()) {\n+ return data_.logchunk_.Get();\n+ }\n+ return ::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited();\n}\ninline void PullCompactionResponse::_internal_set_logchunk(const std::string& value) {\n-\n- logchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, value, GetArena());\n+ if (!_internal_has_logchunk()) {\n+ clear_data();\n+ set_has_logchunk();\n+ data_.logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.logchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, value, GetArena());\n}\ninline void PullCompactionResponse::set_logchunk(std::string&& value) {\n-\n- logchunk_.Set(\n+ // @@protoc_insertion_point(field_set:backup.PullCompactionResponse.logChunk)\n+ if (!_internal_has_logchunk()) {\n+ clear_data();\n+ set_has_logchunk();\n+ data_.logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.logchunk_.Set(\n::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::move(value), GetArena());\n// @@protoc_insertion_point(field_set_rvalue:backup.PullCompactionResponse.logChunk)\n}\ninline void PullCompactionResponse::set_logchunk(const char* value) {\nGOOGLE_DCHECK(value != nullptr);\n-\n- logchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::string(value), GetArena());\n+ if (!_internal_has_logchunk()) {\n+ clear_data();\n+ set_has_logchunk();\n+ data_.logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.logchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{},\n+ ::std::string(value), GetArena());\n// @@protoc_insertion_point(field_set_char:backup.PullCompactionResponse.logChunk)\n}\ninline void PullCompactionResponse::set_logchunk(const void* value,\nsize_t size) {\n-\n- logchunk_.Set(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::string(\n- reinterpret_cast<const char*>(value), size), GetArena());\n+ if (!_internal_has_logchunk()) {\n+ clear_data();\n+ set_has_logchunk();\n+ data_.logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ data_.logchunk_.Set(\n+ ::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, ::std::string(\n+ reinterpret_cast<const char*>(value), size),\n+ GetArena());\n// @@protoc_insertion_point(field_set_pointer:backup.PullCompactionResponse.logChunk)\n}\ninline std::string* PullCompactionResponse::_internal_mutable_logchunk() {\n-\n- return logchunk_.Mutable(::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n+ if (!_internal_has_logchunk()) {\n+ clear_data();\n+ set_has_logchunk();\n+ data_.logchunk_.UnsafeSetDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited());\n+ }\n+ return data_.logchunk_.Mutable(\n+ ::PROTOBUF_NAMESPACE_ID::internal::ArenaStringPtr::EmptyDefault{}, GetArena());\n}\ninline std::string* PullCompactionResponse::release_logchunk() {\n// @@protoc_insertion_point(field_release:backup.PullCompactionResponse.logChunk)\n- return logchunk_.Release(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());\n+ if (_internal_has_logchunk()) {\n+ clear_has_data();\n+ return data_.logchunk_.ReleaseNonDefault(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), GetArena());\n+ } else {\n+ return nullptr;\n+ }\n}\ninline void PullCompactionResponse::set_allocated_logchunk(std::string* logchunk) {\n+ if (has_data()) {\n+ clear_data();\n+ }\nif (logchunk != nullptr) {\n-\n- } else {\n-\n+ set_has_logchunk();\n+ data_.logchunk_.UnsafeSetDefault(logchunk);\n+ ::PROTOBUF_NAMESPACE_ID::Arena* arena = GetArena();\n+ if (arena != nullptr) {\n+ arena->Own(logchunk);\n+ }\n}\n- logchunk_.SetAllocated(&::PROTOBUF_NAMESPACE_ID::internal::GetEmptyStringAlreadyInited(), logchunk,\n- GetArena());\n// @@protoc_insertion_point(field_set_allocated:backup.PullCompactionResponse.logChunk)\n}\n+inline bool PullCompactionResponse::has_data() const {\n+ return data_case() != DATA_NOT_SET;\n+}\n+inline void PullCompactionResponse::clear_has_data() {\n+ _oneof_case_[0] = DATA_NOT_SET;\n+}\n+inline PullCompactionResponse::DataCase PullCompactionResponse::data_case() const {\n+ return PullCompactionResponse::DataCase(_oneof_case_[0]);\n+}\n#ifdef __GNUC__\n#pragma GCC diagnostic pop\n#endif // __GNUC__\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/protos/backup.proto",
"new_path": "native/cpp/CommonCpp/grpc/protos/backup.proto",
"diff": "@@ -54,6 +54,8 @@ message PullCompactionRequest {\n}\nmessage PullCompactionResponse {\n+ oneof data {\nbytes compactionChunk = 1;\nbytes logChunk = 2;\n}\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Add oneof data to PullCompactionResponse
Summary: to make it consistent with `ResetKeyRequest`
Test Plan: backup service should run as usual
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services
Differential Revision: https://phabricator.ashoat.com/D2338 |
129,184 | 15.11.2021 09:20:10 | 18,000 | 88d804813660d44a83a81b46a113ffe035c51008 | [CI] Introduce `assign-build:getAuthToken`
Summary: Generates auth token for use with App Store Connect API:
Test Plan: Was able to successfully make API calls
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/ios/assign-build.js",
"diff": "+// @flow\n+\n+const fs = require('fs');\n+const jwt = require('jsonwebtoken');\n+\n+const getAuthToken = () => {\n+ const p8 = fs.readFileSync('./AUTH_KEY.p8');\n+ const apiKeyID = process.env.AUTH_KEY_ID;\n+ const issuerID = process.env.AUTH_KEY_ISSUER_ID;\n+\n+ if (!p8 || !apiKeyID || !issuerID) {\n+ console.log('ERROR: credentials needed to generate authToken not found.');\n+ process.exit(1);\n+ }\n+\n+ const jwtPayload = {\n+ iss: issuerID,\n+ exp: Math.round(Date.now() / 1000) + 60,\n+ aud: \"appstoreconnect-v1\",\n+ };\n+\n+ const jwtSigningConfig = {\n+ algorithm: \"ES256\",\n+ header: {\n+ alg: \"ES256\",\n+ kid: apiKeyID,\n+ typ: \"JWT\"\n+ }\n+ };\n+\n+ return jwt.sign(jwtPayload, p8, jwtSigningConfig);\n+};\n+\n+async function main() {\n+ getAuthToken();\n+}\n+\n+main();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getAuthToken`
Summary: Generates auth token for use with App Store Connect API: https://developer.apple.com/documentation/appstoreconnectapi/generating_tokens_for_api_requests
Test Plan: Was able to successfully make API calls
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2365 |
129,184 | 15.11.2021 09:36:32 | 18,000 | 04954b82acb6f9bd00723c3007b5ce94d16a97eb | [CI] Introduce `assign-build:getPreReleaseVersions`
Summary: Endpoint:
Test Plan: Got expected result
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "// @flow\nconst fs = require('fs');\n+const { request } = require('gaxios');\nconst jwt = require('jsonwebtoken');\n+const IOS_APP_ID = process.env.IOS_APP_ID;\n+\nconst getAuthToken = () => {\nconst p8 = fs.readFileSync('./AUTH_KEY.p8');\nconst apiKeyID = process.env.AUTH_KEY_ID;\n@@ -31,8 +34,32 @@ const getAuthToken = () => {\nreturn jwt.sign(jwtPayload, p8, jwtSigningConfig);\n};\n+const getPreReleaseVersions = async (authToken) => {\n+ if (!IOS_APP_ID) {\n+ console.log('ERROR: No IOS_APP_ID found in env.');\n+ process.exit(1);\n+ return;\n+ }\n+\n+ const res = await request({\n+ url: `https://api.appstoreconnect.apple.com/v1/apps/${IOS_APP_ID}/preReleaseVersions`,\n+ headers: {\n+ Authorization: authToken,\n+ },\n+ });\n+\n+ if (res.status !== 200 ) {\n+ console.log(\n+ \"ERROR: GET preReleaseVersions from AppStoreConnect API failed.\"\n+ );\n+ process.exit(1);\n+ }\n+ return res.data.data;\n+};\n+\nasync function main() {\n- getAuthToken();\n+ const authToken = getAuthToken();\n+ await getPreReleaseVersions(authToken);\n}\nmain();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getPreReleaseVersions`
Summary: Endpoint: https://developer.apple.com/documentation/appstoreconnectapi/list_prerelease_versions
Test Plan: Got expected result
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2366 |
129,184 | 15.11.2021 09:54:15 | 18,000 | eb54d5ca906c6649306c688d7a77ef266c7dbc9f | [CI] Introduce `assign-build:getCurrentVersionInfo`
Summary: Get information about the current version (based on git tag)
Test Plan: Got expected result.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -5,6 +5,8 @@ const { request } = require('gaxios');\nconst jwt = require('jsonwebtoken');\nconst IOS_APP_ID = process.env.IOS_APP_ID;\n+const GIT_REF = process.env.GITHUB_REF ?? \"\";\n+const GIT_TAG = GIT_REF.replace(/^refs\\/tags\\/v/, \"\");\nconst getAuthToken = () => {\nconst p8 = fs.readFileSync('./AUTH_KEY.p8');\n@@ -57,9 +59,23 @@ const getPreReleaseVersions = async (authToken) => {\nreturn res.data.data;\n};\n+const getCurrentVersionInfo = (preReleaseVersions, currentVersion) => {\n+ if (!preReleaseVersions) {\n+ console.log('ERROR: No preReleaseVersions found.');\n+ process.exit(1);\n+ return;\n+ }\n+\n+ return preReleaseVersions.filter(\n+ (each) => each.attributes.version === currentVersion\n+ )[0];\n+};\n+\n+\nasync function main() {\nconst authToken = getAuthToken();\n- await getPreReleaseVersions(authToken);\n+ const preReleaseVersions = await getPreReleaseVersions(authToken);\n+ getCurrentVersionInfo(preReleaseVersions, GIT_TAG);\n}\nmain();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getCurrentVersionInfo`
Summary: Get information about the current version (based on git tag)
Test Plan: Got expected result.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2368 |
129,184 | 15.11.2021 11:30:20 | 18,000 | f3242ad6d4f7870f77e89d171736fd12693d69b4 | [CI] Introduce `assign-build:getCurrentVersionID`
Summary: Extract versionID from versionInfo if it exists.
Test Plan: Got versionID as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -71,11 +71,21 @@ const getCurrentVersionInfo = (preReleaseVersions, currentVersion) => {\n)[0];\n};\n+const getCurrentVersionID = (currentVersionInfo) => {\n+ if (!currentVersionInfo || !currentVersionInfo.id) {\n+ console.log('ERROR: currentVersionID could not be determined.');\n+ process.exit(1);\n+ return;\n+ }\n+ return currentVersionInfo.id;\n+};\n+\nasync function main() {\nconst authToken = getAuthToken();\nconst preReleaseVersions = await getPreReleaseVersions(authToken);\n- getCurrentVersionInfo(preReleaseVersions, GIT_TAG);\n+ const currentVersionInfo = getCurrentVersionInfo(preReleaseVersions, GIT_TAG);\n+ getCurrentVersionID(currentVersionInfo);\n}\nmain();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getCurrentVersionID`
Summary: Extract versionID from versionInfo if it exists.
Test Plan: Got versionID as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2369 |
129,184 | 15.11.2021 11:40:57 | 18,000 | a121836b1074ab20ad19933a32fcf61f5fa5c6e8 | [CI] Introduce `assign-build:getBuildInfoForVersionID`
Summary: Given valid versionID, get build information.
Test Plan: Got build information as expected
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -80,12 +80,35 @@ const getCurrentVersionID = (currentVersionInfo) => {\nreturn currentVersionInfo.id;\n};\n+const getBuildInfoForVersionID = async (authToken, versionID) => {\n+ if (!versionID) {\n+ console.log('ERROR: versionID is undefined.');\n+ process.exit(1);\n+ return;\n+ }\n+\n+ const res = await request({\n+ url: `https://api.appstoreconnect.apple.com/v1/preReleaseVersions/${versionID}/relationships/builds`,\n+ headers: {\n+ Authorization: authToken,\n+ },\n+ });\n+\n+ if (res.status !== 200) {\n+ console.log('ERROR: GET currentVersion/builds from AppStoreConnect API failed.');\n+ process.exit(1);\n+ }\n+\n+ return res.data.data[0];\n+};\n+\nasync function main() {\nconst authToken = getAuthToken();\nconst preReleaseVersions = await getPreReleaseVersions(authToken);\nconst currentVersionInfo = getCurrentVersionInfo(preReleaseVersions, GIT_TAG);\n- getCurrentVersionID(currentVersionInfo);\n+ const currentVersionID = getCurrentVersionID(currentVersionInfo);\n+ await getBuildInfoForVersionID(authToken, currentVersionID);\n}\nmain();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getBuildInfoForVersionID`
Summary: Given valid versionID, get build information.
Test Plan: Got build information as expected
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2370 |
129,184 | 15.11.2021 11:56:26 | 18,000 | 6936e26f6f793585a0e146d54f175166efd589d5 | [CI] Introduce `assign-build:getBuildID`
Summary: Extracts buildID from buildInfo if it exists.
Test Plan: Got buildID as expected.
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -102,13 +102,22 @@ const getBuildInfoForVersionID = async (authToken, versionID) => {\nreturn res.data.data[0];\n};\n+const getBuildID = (buildInfo) => {\n+ if (!buildInfo || !buildInfo.id) {\n+ console.log('ERROR: buildID could not be determined.');\n+ process.exit(1);\n+ return;\n+ }\n+ return buildInfo.id;\n+};\nasync function main() {\nconst authToken = getAuthToken();\nconst preReleaseVersions = await getPreReleaseVersions(authToken);\nconst currentVersionInfo = getCurrentVersionInfo(preReleaseVersions, GIT_TAG);\nconst currentVersionID = getCurrentVersionID(currentVersionInfo);\n- await getBuildInfoForVersionID(authToken, currentVersionID);\n+ const buildInfo = await getBuildInfoForVersionID(authToken, currentVersionID);\n+ getBuildID(buildInfo);\n}\nmain();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:getBuildID`
Summary: Extracts buildID from buildInfo if it exists.
Test Plan: Got buildID as expected.
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2371 |
129,184 | 15.11.2021 13:50:10 | 18,000 | 097e0b94089caff4850715c34e6335d846a548ef | [CI] Introduce `assign-build:assignBuildToStaffGroup`
Summary: Assigns build to staff staff testing group
Test Plan:
It worked for v1.0.119:
{F5525}
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/ios/assign-build.js",
"new_path": "native/ios/assign-build.js",
"diff": "@@ -5,6 +5,7 @@ const { request } = require('gaxios');\nconst jwt = require('jsonwebtoken');\nconst IOS_APP_ID = process.env.IOS_APP_ID;\n+const IOS_STAFF_GROUP_ID = process.env.IOS_STAFF_GROUP_ID;\nconst GIT_REF = process.env.GITHUB_REF ?? \"\";\nconst GIT_TAG = GIT_REF.replace(/^refs\\/tags\\/v/, \"\");\n@@ -111,13 +112,49 @@ const getBuildID = (buildInfo) => {\nreturn buildInfo.id;\n};\n+const assignBuildToStaffGroup = async (authToken, buildID) => {\n+ if (!IOS_STAFF_GROUP_ID) {\n+ console.log('ERROR: No IOS_STAFF_GROUP_ID found in env.');\n+ process.exit(1);\n+ return;\n+ }\n+ if (!buildID) {\n+ console.log('ERROR: buildID is undefined.');\n+ process.exit(1);\n+ return;\n+ }\n+\n+ const res = await request({\n+ method: 'POST',\n+ url: `https://api.appstoreconnect.apple.com/v1/builds/${buildID}/relationships/betaGroups`,\n+ headers: {\n+ Authorization: authToken,\n+ 'Content-Type': 'application/json'\n+ },\n+ data: {\n+ data: [\n+ {\n+ id: IOS_STAFF_GROUP_ID,\n+ type: 'betaGroups'\n+ }\n+ ]\n+ }\n+ });\n+\n+ if (res.status !== 204) {\n+ console.log('ERROR: Unable to assign build to staff group.');\n+ process.exit(1);\n+ }\n+};\n+\nasync function main() {\nconst authToken = getAuthToken();\nconst preReleaseVersions = await getPreReleaseVersions(authToken);\nconst currentVersionInfo = getCurrentVersionInfo(preReleaseVersions, GIT_TAG);\nconst currentVersionID = getCurrentVersionID(currentVersionInfo);\nconst buildInfo = await getBuildInfoForVersionID(authToken, currentVersionID);\n- getBuildID(buildInfo);\n+ const buildID = getBuildID(buildInfo);\n+ await assignBuildToStaffGroup(authToken, buildID);\n}\nmain();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Introduce `assign-build:assignBuildToStaffGroup`
Summary: Assigns build to staff staff testing group
Test Plan:
It worked for v1.0.119:
{F5525}
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2373 |
129,179 | 12.11.2021 09:57:00 | 18,000 | 17ab9494405487c60aca11cc7056b15b687e215d | [1/n] change types CHANGE_USER_PASSWORD_SETTINGS --> CHANGE_USER_PASSWORD
Summary: start change references from changeSettings --> change password
Test Plan: test password change functionality on web and native
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -156,14 +156,16 @@ const logIn = (\n};\nconst changeUserSettingsActionTypes = Object.freeze({\n- started: 'CHANGE_USER_PASSWORD_SETTINGS_STARTED',\n- success: 'CHANGE_USER_PASSWORD_SETTINGS_SUCCESS',\n- failed: 'CHANGE_USER_PASSWORD_SETTINGS_FAILED',\n+ started: 'CHANGE_USER_PASSWORD_STARTED',\n+ success: 'CHANGE_USER_PASSWORD_SUCCESS',\n+ failed: 'CHANGE_USER_PASSWORD_FAILED',\n});\nconst changeUserSettings = (\nfetchJSON: FetchJSON,\n-): ((accountUpdate: AccountUpdate) => Promise<void>) => async accountUpdate => {\n- await fetchJSON('update_account', accountUpdate);\n+): ((\n+ passwordUpdate: AccountUpdate,\n+) => Promise<void>) => async passwordUpdate => {\n+ await fetchJSON('update_account', passwordUpdate);\n};\nconst searchUsersActionTypes = Object.freeze({\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -259,18 +259,18 @@ export type BaseAction =\n+loadingInfo: LoadingInfo,\n}\n| {\n- +type: 'CHANGE_USER_PASSWORD_SETTINGS_STARTED',\n+ +type: 'CHANGE_USER_PASSWORD_STARTED',\n+payload?: void,\n+loadingInfo: LoadingInfo,\n}\n| {\n- +type: 'CHANGE_USER_PASSWORD_SETTINGS_FAILED',\n+ +type: 'CHANGE_USER_PASSWORD_FAILED',\n+error: true,\n+payload: Error,\n+loadingInfo: LoadingInfo,\n}\n| {\n- +type: 'CHANGE_USER_PASSWORD_SETTINGS_SUCCESS',\n+ +type: 'CHANGE_USER_PASSWORD_SUCCESS',\n+payload?: void,\n+loadingInfo: LoadingInfo,\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] change types CHANGE_USER_PASSWORD_SETTINGS --> CHANGE_USER_PASSWORD
Summary: start change references from changeSettings --> change password
Test Plan: test password change functionality on web and native
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2352 |
129,179 | 15.11.2021 13:41:19 | 18,000 | 6cdc04b9ec7537092e82d3a8ebac9dfe4c2d931c | folllow up backend diff: refactor notification types
Summary: follow up diff from
Test Plan: make sure functionality still works and we're not getting any type errors
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "// @flow\n+import { values } from '../../lib/utils/objects';\nimport type { PlatformDetails, DeviceType } from './device-types';\nimport type {\nCalendarQuery,\n@@ -157,4 +158,14 @@ export const userSettingsTypes = Object.freeze({\nDEFAULT_NOTIFICATIONS: 'default_user_notifications',\n});\n-export type NotificationTypes = 'all' | 'background' | 'none';\n+const notificationTypes = Object.freeze({\n+ ALL: 'all',\n+ BACKGROUND: 'background',\n+ NONE: 'none',\n+});\n+\n+export type NotificationTypes = $Values<typeof notificationTypes>;\n+\n+export const notificationTypeValues: $ReadOnlyArray<NotificationTypes> = values(\n+ notificationTypes,\n+);\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -16,7 +16,10 @@ import type {\nAccessRequest,\nUpdateUserSettingsRequest,\n} from 'lib/types/account-types';\n-import { userSettingsTypes } from 'lib/types/account-types';\n+import {\n+ userSettingsTypes,\n+ notificationTypeValues,\n+} from 'lib/types/account-types';\nimport { defaultNumberPerThread } from 'lib/types/message-types';\nimport type {\nSubscriptionUpdateRequest,\n@@ -324,7 +327,7 @@ const updateUserSettingsInputValidator = tShape({\nuserSettingsTypes.DEFAULT_NOTIFICATIONS,\nx => x === userSettingsTypes.DEFAULT_NOTIFICATIONS,\n),\n- data: t.enums.of(Object.freeze(['all', 'background', 'none'])),\n+ data: t.enums.of(notificationTypeValues),\n});\nasync function updateUserSettingsResponder(\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | folllow up backend diff: refactor notification types
Summary: follow up diff from https://phabricator.ashoat.com/D2276
Test Plan: make sure functionality still works and we're not getting any type errors
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2372 |
129,179 | 12.11.2021 10:06:27 | 18,000 | fdfe10ae51f38ac9ec3ac79a5c1c0da1a1ea0800 | [2/n] change account --> password types and some function names
Summary: continue changing references to Account --> Password
Test Plan: make sure change functionality functionality works in native and web
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -20,7 +20,7 @@ import type {\nimport type {\nUserPublicKeys,\nUserInfo,\n- AccountUpdate,\n+ PasswordUpdate,\n} from '../types/user-types';\nimport { getConfig } from '../utils/config';\nimport type { FetchJSON } from '../utils/fetch-json';\n@@ -163,7 +163,7 @@ const changeUserSettingsActionTypes = Object.freeze({\nconst changeUserSettings = (\nfetchJSON: FetchJSON,\n): ((\n- passwordUpdate: AccountUpdate,\n+ passwordUpdate: PasswordUpdate,\n) => Promise<void>) => async passwordUpdate => {\nawait fetchJSON('update_account', passwordUpdate);\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/user-types.js",
"new_path": "lib/types/user-types.js",
"diff": "@@ -60,7 +60,7 @@ export type LoggedOutUserInfo = {\nexport type OldCurrentUserInfo = OldLoggedInUserInfo | LoggedOutUserInfo;\nexport type CurrentUserInfo = LoggedInUserInfo | LoggedOutUserInfo;\n-export type AccountUpdate = {\n+export type PasswordUpdate = {\n+updatedFields: {\n+password?: ?string,\n},\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/edit-password.react.js",
"new_path": "native/profile/edit-password.react.js",
"diff": "@@ -18,7 +18,7 @@ import {\n} from 'lib/actions/user-actions';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport type { LoadingStatus } from 'lib/types/loading-types';\n-import type { AccountUpdate } from 'lib/types/user-types';\n+import type { PasswordUpdate } from 'lib/types/user-types';\nimport {\nuseServerCall,\nuseDispatchActionPromise,\n@@ -49,7 +49,7 @@ type Props = {\n// Redux dispatch functions\n+dispatchActionPromise: DispatchActionPromise,\n// async functions that hit server APIs\n- +changeUserSettings: (accountUpdate: AccountUpdate) => Promise<void>,\n+ +changeUserPassword: (passwordUpdate: PasswordUpdate) => Promise<void>,\n};\ntype State = {\n+currentPassword: string,\n@@ -232,7 +232,7 @@ class EditPassword extends React.PureComponent<Props, State> {\nreturn;\n}\ntry {\n- await this.props.changeUserSettings({\n+ await this.props.changeUserPassword({\nupdatedFields: {\npassword: this.state.newPassword,\n},\n@@ -355,7 +355,7 @@ const ConnectedEditPassword: React.ComponentType<BaseProps> = React.memo<BasePro\nconst styles = useStyles(unboundStyles);\nconst dispatchActionPromise = useDispatchActionPromise();\n- const callChangeUserSettings = useServerCall(changeUserSettings);\n+ const callChangeUserPassword = useServerCall(changeUserSettings);\nreturn (\n<EditPassword\n@@ -366,7 +366,7 @@ const ConnectedEditPassword: React.ComponentType<BaseProps> = React.memo<BasePro\ncolors={colors}\nstyles={styles}\ndispatchActionPromise={dispatchActionPromise}\n- changeUserSettings={callChangeUserSettings}\n+ changeUserPassword={callChangeUserPassword}\n/>\n);\n},\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -25,7 +25,7 @@ import type {\nSubscriptionUpdateRequest,\nSubscriptionUpdateResponse,\n} from 'lib/types/subscription-types';\n-import type { AccountUpdate } from 'lib/types/user-types';\n+import type { PasswordUpdate } from 'lib/types/user-types';\nimport { ServerError } from 'lib/utils/errors';\nimport { values } from 'lib/utils/objects';\nimport { promiseAll } from 'lib/utils/promises';\n@@ -102,7 +102,7 @@ async function accountUpdateResponder(\nviewer: Viewer,\ninput: any,\n): Promise<void> {\n- const request: AccountUpdate = input;\n+ const request: PasswordUpdate = input;\nawait validateInput(viewer, accountUpdateInputValidator, request);\nawait accountUpdater(viewer, request);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/updaters/account-updaters.js",
"new_path": "server/src/updaters/account-updaters.js",
"diff": "@@ -8,7 +8,7 @@ import type {\nUpdateUserSettingsRequest,\n} from 'lib/types/account-types';\nimport { updateTypes } from 'lib/types/update-types';\n-import type { AccountUpdate } from 'lib/types/user-types';\n+import type { PasswordUpdate } from 'lib/types/user-types';\nimport { ServerError } from 'lib/utils/errors';\nimport { createUpdates } from '../creators/update-creator';\n@@ -17,7 +17,7 @@ import type { Viewer } from '../session/viewer';\nasync function accountUpdater(\nviewer: Viewer,\n- update: AccountUpdate,\n+ update: PasswordUpdate,\n): Promise<void> {\nif (!viewer.loggedIn) {\nthrow new ServerError('not_logged_in');\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -14,7 +14,10 @@ import { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport type { LogOutResult } from 'lib/types/account-types';\nimport { type PreRequestUserState } from 'lib/types/session-types';\n-import { type AccountUpdate, type CurrentUserInfo } from 'lib/types/user-types';\n+import {\n+ type PasswordUpdate,\n+ type CurrentUserInfo,\n+} from 'lib/types/user-types';\nimport {\ntype DispatchActionPromise,\nuseDispatchActionPromise,\n@@ -64,7 +67,7 @@ type Props = {\npassword: string,\npreRequestUserState: PreRequestUserState,\n) => Promise<LogOutResult>,\n- +changeUserSettings: (accountUpdate: AccountUpdate) => Promise<void>,\n+ +changeUserPassword: (passwordUpdate: PasswordUpdate) => Promise<void>,\n};\ntype State = {\n+newPassword: string,\n@@ -284,7 +287,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nasync changeUserSettingsAction() {\ntry {\n- await this.props.changeUserSettings({\n+ await this.props.changeUserPassword({\nupdatedFields: {\npassword: this.state.newPassword,\n},\n@@ -371,7 +374,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nconst deleteAccountLoadingStatusSelector = createLoadingStatusSelector(\ndeleteAccountActionTypes,\n);\n-const changeUserSettingsLoadingStatusSelector = createLoadingStatusSelector(\n+const changeUserPasswordLoadingStatusSelector = createLoadingStatusSelector(\nchangeUserSettingsActionTypes,\n);\n@@ -382,10 +385,10 @@ const ConnectedUserSettingsModal: React.ComponentType<BaseProps> = React.memo<Ba\nconst inputDisabled = useSelector(\nstate =>\ndeleteAccountLoadingStatusSelector(state) === 'loading' ||\n- changeUserSettingsLoadingStatusSelector(state) === 'loading',\n+ changeUserPasswordLoadingStatusSelector(state) === 'loading',\n);\nconst callDeleteAccount = useServerCall(deleteAccount);\n- const callChangeUserSettings = useServerCall(changeUserSettings);\n+ const callChangeUserPassword = useServerCall(changeUserSettings);\nconst dispatchActionPromise = useDispatchActionPromise();\nreturn (\n@@ -395,7 +398,7 @@ const ConnectedUserSettingsModal: React.ComponentType<BaseProps> = React.memo<Ba\npreRequestUserState={preRequestUserState}\ninputDisabled={inputDisabled}\ndeleteAccount={callDeleteAccount}\n- changeUserSettings={callChangeUserSettings}\n+ changeUserPassword={callChangeUserPassword}\ndispatchActionPromise={dispatchActionPromise}\n/>\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] change account --> password types and some function names
Summary: continue changing references to Account --> Password
Test Plan: make sure change functionality functionality works in native and web
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2353 |
129,179 | 12.11.2021 10:14:19 | 18,000 | d421a719b7ad104b64a5eb2323805772403fcc7a | [3/n] changeUserSettings --> changeUserPassword
Summary: continue changing references
Test Plan: same as above
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -155,12 +155,12 @@ const logIn = (\n};\n};\n-const changeUserSettingsActionTypes = Object.freeze({\n+const changeUserPasswordActionTypes = Object.freeze({\nstarted: 'CHANGE_USER_PASSWORD_STARTED',\nsuccess: 'CHANGE_USER_PASSWORD_SUCCESS',\nfailed: 'CHANGE_USER_PASSWORD_FAILED',\n});\n-const changeUserSettings = (\n+const changeUserPassword = (\nfetchJSON: FetchJSON,\n): ((\npasswordUpdate: PasswordUpdate,\n@@ -240,8 +240,8 @@ const getUserPublicKeys = (\nexport {\nappStartNativeCredentialsAutoLogIn,\nappStartReduxLoggedInButInvalidCookie,\n- changeUserSettings,\n- changeUserSettingsActionTypes,\n+ changeUserPasswordActionTypes,\n+ changeUserPassword,\ncookieInvalidationResolutionAttempt,\ndeleteAccount,\ndeleteAccountActionTypes,\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/edit-password.react.js",
"new_path": "native/profile/edit-password.react.js",
"diff": "@@ -13,8 +13,8 @@ import {\n} from 'react-native';\nimport {\n- changeUserSettingsActionTypes,\n- changeUserSettings,\n+ changeUserPasswordActionTypes,\n+ changeUserPassword,\n} from 'lib/actions/user-actions';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\nimport type { LoadingStatus } from 'lib/types/loading-types';\n@@ -220,7 +220,7 @@ class EditPassword extends React.PureComponent<Props, State> {\nthis.goBackOnce();\n} else {\nthis.props.dispatchActionPromise(\n- changeUserSettingsActionTypes,\n+ changeUserPasswordActionTypes,\nthis.savePassword(),\n);\n}\n@@ -338,7 +338,7 @@ const unboundStyles = {\n};\nconst loadingStatusSelector = createLoadingStatusSelector(\n- changeUserSettingsActionTypes,\n+ changeUserPasswordActionTypes,\n);\nconst ConnectedEditPassword: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n@@ -355,7 +355,7 @@ const ConnectedEditPassword: React.ComponentType<BaseProps> = React.memo<BasePro\nconst styles = useStyles(unboundStyles);\nconst dispatchActionPromise = useDispatchActionPromise();\n- const callChangeUserPassword = useServerCall(changeUserSettings);\n+ const callChangeUserPassword = useServerCall(changeUserPassword);\nreturn (\n<EditPassword\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -7,8 +7,8 @@ import * as React from 'react';\nimport {\ndeleteAccountActionTypes,\ndeleteAccount,\n- changeUserSettingsActionTypes,\n- changeUserSettings,\n+ changeUserPasswordActionTypes,\n+ changeUserPassword,\n} from 'lib/actions/user-actions';\nimport { preRequestUserStateSelector } from 'lib/selectors/account-selectors';\nimport { createLoadingStatusSelector } from 'lib/selectors/loading-selectors';\n@@ -280,7 +280,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n}\nthis.props.dispatchActionPromise(\n- changeUserSettingsActionTypes,\n+ changeUserPasswordActionTypes,\nthis.changeUserSettingsAction(),\n);\n};\n@@ -375,7 +375,7 @@ const deleteAccountLoadingStatusSelector = createLoadingStatusSelector(\ndeleteAccountActionTypes,\n);\nconst changeUserPasswordLoadingStatusSelector = createLoadingStatusSelector(\n- changeUserSettingsActionTypes,\n+ changeUserPasswordActionTypes,\n);\nconst ConnectedUserSettingsModal: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n@@ -388,7 +388,7 @@ const ConnectedUserSettingsModal: React.ComponentType<BaseProps> = React.memo<Ba\nchangeUserPasswordLoadingStatusSelector(state) === 'loading',\n);\nconst callDeleteAccount = useServerCall(deleteAccount);\n- const callChangeUserPassword = useServerCall(changeUserSettings);\n+ const callChangeUserPassword = useServerCall(changeUserPassword);\nconst dispatchActionPromise = useDispatchActionPromise();\nreturn (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] changeUserSettings --> changeUserPassword
Summary: continue changing references
Test Plan: same as above
Reviewers: atul, palys-swm, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2355 |
129,179 | 16.11.2021 11:56:12 | 18,000 | c2050295952d97afcb47730bdf80642454f793c8 | [4/n] [server] rename accountUpdater --> passwordUpdater, update legacy, prepend with old
Summary: update account to password, prepend old to legacy password updater
Test Plan: reset password, confirm functionality still works
Reviewers: atul, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "server/src/endpoints.js",
"new_path": "server/src/endpoints.js",
"diff": "@@ -41,14 +41,14 @@ import {\n} from './responders/thread-responders';\nimport {\nuserSubscriptionUpdateResponder,\n- accountUpdateResponder,\n+ passwordUpdateResponder,\nsendVerificationEmailResponder,\nsendPasswordResetEmailResponder,\nlogOutResponder,\naccountDeletionResponder,\naccountCreationResponder,\nlogInResponder,\n- passwordUpdateResponder,\n+ oldPasswordUpdateResponder,\nrequestAccessResponder,\nupdateUserSettingsResponder,\n} from './responders/user-responders';\n@@ -84,13 +84,13 @@ const jsonEndpoints: { [id: Endpoint]: JSONResponder } = {\nsend_password_reset_email: sendPasswordResetEmailResponder,\nsend_verification_email: sendVerificationEmailResponder,\nset_thread_unread_status: threadSetUnreadStatusResponder,\n- update_account: accountUpdateResponder,\n+ update_account: passwordUpdateResponder,\nupdate_activity: updateActivityResponder,\nupdate_calendar_query: calendarQueryUpdateResponder,\nupdate_user_settings: updateUserSettingsResponder,\nupdate_device_token: deviceTokenUpdateResponder,\nupdate_entry: entryUpdateResponder,\n- update_password: passwordUpdateResponder,\n+ update_password: oldPasswordUpdateResponder,\nupdate_relationships: updateRelationshipsResponder,\nupdate_role: roleUpdateResponder,\nupdate_thread: threadUpdateResponder,\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/responders/user-responders.js",
"new_path": "server/src/responders/user-responders.js",
"diff": "@@ -98,7 +98,7 @@ const accountUpdateInputValidator = tShape({\ncurrentPassword: tPassword,\n});\n-async function accountUpdateResponder(\n+async function passwordUpdateResponder(\nviewer: Viewer,\ninput: any,\n): Promise<void> {\n@@ -295,7 +295,7 @@ const updatePasswordRequestInputValidator = tShape({\nplatformDetails: tPlatformDetails,\n});\n-async function passwordUpdateResponder(\n+async function oldPasswordUpdateResponder(\nviewer: Viewer,\ninput: any,\n): Promise<LogInResponse> {\n@@ -341,14 +341,14 @@ async function updateUserSettingsResponder(\nexport {\nuserSubscriptionUpdateResponder,\n- accountUpdateResponder,\n+ passwordUpdateResponder,\nsendVerificationEmailResponder,\nsendPasswordResetEmailResponder,\nlogOutResponder,\naccountDeletionResponder,\naccountCreationResponder,\nlogInResponder,\n- passwordUpdateResponder,\n+ oldPasswordUpdateResponder,\nrequestAccessResponder,\nupdateUserSettingsResponder,\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [4/n] [server] rename accountUpdater --> passwordUpdater, update legacy, prepend with old
Summary: update account to password, prepend old to legacy password updater
Test Plan: reset password, confirm functionality still works
Reviewers: atul, palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2381 |
129,179 | 16.11.2021 13:49:19 | 18,000 | f035da0ca0d4b18a1a3a06c93a2945788f5c76e6 | [0/n] [native] add selection of default notif row
Summary: select prop. for default notif row
Test Plan: N/A do not review
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "@@ -38,14 +38,15 @@ type ProfileRowProps = {\n+content: string,\n+onPress: () => void,\n+danger?: boolean,\n+ +selected?: boolean,\n};\nfunction NotificationRow(props: ProfileRowProps): React.Node {\n- const { content, onPress, danger } = props;\n+ const { content, onPress, danger, selected } = props;\nreturn (\n<Action.Row onPress={onPress}>\n<Action.Text {...{ danger, content }} />\n- <CheckIcon />\n+ {selected ? <CheckIcon /> : null}\n</Action.Row>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [0/n] [native] add selection of default notif row
Summary: select prop. for default notif row
Test Plan: N/A do not review
Reviewers: palys-swm, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2382 |
129,184 | 16.11.2021 14:56:33 | 18,000 | e50b321d761afb783cf550fead82faf2cbfc25a1 | [lib] Add `rawMessageInfoFromClientDB` to `MessageSpec` type
Summary: For each message type, we'll implement a `rawMessageInfoFromClientDB` function to go from `ClientDBMessageInfo` -> `Raw[whatever]MessageInfo`
Test Plan: NA, just introduces type
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/message-spec.js",
"new_path": "lib/shared/messages/message-spec.js",
"diff": "@@ -4,6 +4,7 @@ import type { PlatformDetails } from '../../types/device-types';\nimport type { Media } from '../../types/media-types';\nimport type {\nMessageInfo,\n+ ClientDBMessageInfo,\nRawComposableMessageInfo,\nRawMessageInfo,\nRawRobotextMessageInfo,\n@@ -73,6 +74,9 @@ export type MessageSpec<Data, RawInfo, Info> = {\nrow: Object,\nparams: RawMessageInfoFromServerDBRowParams,\n) => ?RawInfo,\n+ +rawMessageInfoFromClientDB?: (\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ) => RawInfo,\n+createMessageInfo: (\nrawMessageInfo: RawInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Add `rawMessageInfoFromClientDB` to `MessageSpec` type
Summary: For each message type, we'll implement a `rawMessageInfoFromClientDB` function to go from `ClientDBMessageInfo` -> `Raw[whatever]MessageInfo`
Test Plan: NA, just introduces type
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2384 |
129,184 | 16.11.2021 15:30:29 | 18,000 | 855fa8d3a68c42ff822f284c9d4b8d097440b14d | [lib] Implement `rawMessageInfoFromClientDB` for `TEXT`
Summary: Pull `RawTextMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/text-message-spec.js",
"new_path": "lib/shared/messages/text-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport * as SimpleMarkdown from 'simple-markdown';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nRawTextMessageInfo,\nTextMessageData,\n@@ -100,6 +103,23 @@ export const textMessageSpec: MessageSpec<\nreturn rawTextMessageInfo;\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawTextMessageInfo {\n+ const rawTextMessageInfo: RawTextMessageInfo = {\n+ type: messageTypes.TEXT,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ text: clientDBMessageInfo.content ?? '',\n+ };\n+ if (clientDBMessageInfo.local_id) {\n+ rawTextMessageInfo.localID = clientDBMessageInfo.local_id;\n+ }\n+ return rawTextMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawTextMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `TEXT`
Summary: Pull `RawTextMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2385 |
129,184 | 16.11.2021 15:45:06 | 18,000 | d93db45df94a6444c60107433cf416f8c93a9813 | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_THREAD`
Summary: Pull `RawCreateThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-thread-message-spec.js",
"new_path": "lib/shared/messages/create-thread-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nCreateThreadMessageData,\nCreateThreadMessageInfo,\n@@ -75,6 +78,25 @@ export const createThreadMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawCreateThreadMessageInfo {\n+ const content = clientDBMessageInfo.content;\n+ invariant(\n+ content !== undefined && content !== null,\n+ 'content must be defined',\n+ );\n+ const rawCreateThreadMessageInfo: RawCreateThreadMessageInfo = {\n+ type: messageTypes.CREATE_THREAD,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ initialThreadState: JSON.parse(content),\n+ };\n+ return rawCreateThreadMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawCreateThreadMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_THREAD`
Summary: Pull `RawCreateThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2386 |
129,184 | 16.11.2021 15:59:38 | 18,000 | 0253a067d2b456f6f2fba20db79ea02fdb08a201 | [lib] Implement `rawMessageInfoFromClientDB` for `ADD_MEMBERS`
Summary: Pull `RawAddMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/add-members-message-spec.js",
"new_path": "lib/shared/messages/add-members-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nAddMembersMessageData,\nAddMembersMessageInfo,\n@@ -70,6 +73,25 @@ export const addMembersMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawAddMembersMessageInfo {\n+ const content = clientDBMessageInfo.content;\n+ invariant(\n+ content !== undefined && content !== null,\n+ 'content must be defined',\n+ );\n+ const rawAddMembersMessageInfo: RawAddMembersMessageInfo = {\n+ type: messageTypes.ADD_MEMBERS,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ addedUserIDs: JSON.parse(content),\n+ };\n+ return rawAddMembersMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawAddMembersMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `ADD_MEMBERS`
Summary: Pull `RawAddMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2387 |
129,184 | 16.11.2021 16:19:28 | 18,000 | a6cf92faaae7106222a2955107daf9997820b99b | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SUB_THREAD`
Summary: Pull `RawCreateSubthreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sub-thread-message-spec.js",
"new_path": "lib/shared/messages/create-sub-thread-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport { permissionLookup } from '../../permissions/thread-permissions';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nCreateSubthreadMessageData,\nCreateSubthreadMessageInfo,\n@@ -67,6 +70,25 @@ export const createSubThreadMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawCreateSubthreadMessageInfo {\n+ const content = clientDBMessageInfo.content;\n+ invariant(\n+ content !== undefined && content !== null,\n+ 'content must be defined',\n+ );\n+ const rawCreateSubthreadMessageInfo: RawCreateSubthreadMessageInfo = {\n+ type: messageTypes.CREATE_SUB_THREAD,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ childThreadID: content,\n+ };\n+ return rawCreateSubthreadMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawCreateSubthreadMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SUB_THREAD`
Summary: Pull `RawCreateSubthreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2388 |
129,184 | 16.11.2021 16:39:57 | 18,000 | c72c8890ef25106ae65228382cc708376d9e524f | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_SETTINGS`
Summary: Pull `RawChangeSettingsMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-settings-message-spec.js",
"new_path": "lib/shared/messages/change-settings-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nChangeSettingsMessageData,\nChangeSettingsMessageInfo,\n@@ -69,6 +72,28 @@ export const changeSettingsMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawChangeSettingsMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const field = Object.keys(content)[0];\n+ const rawChangeSettingsMessageInfo: RawChangeSettingsMessageInfo = {\n+ type: messageTypes.CHANGE_SETTINGS,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ field,\n+ value: content[field],\n+ };\n+ return rawChangeSettingsMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawChangeSettingsMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_SETTINGS`
Summary: Pull `RawChangeSettingsMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2390 |
129,184 | 16.11.2021 16:47:25 | 18,000 | 2fd67790070d3f05e6d624ec4aa092ba0d91d151 | [lib] Implement `rawMessageInfoFromClientDB` for `REMOVE_MEMBERS`
Summary: Pull `RawRemoveMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/remove-members-message-spec.js",
"new_path": "lib/shared/messages/remove-members-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nRawRemoveMembersMessageInfo,\nRemoveMembersMessageData,\n@@ -70,6 +73,25 @@ export const removeMembersMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawRemoveMembersMessageInfo {\n+ const content = clientDBMessageInfo.content;\n+ invariant(\n+ content !== undefined && content !== null,\n+ 'content must be defined',\n+ );\n+ const rawRemoveMembersMessageInfo: RawRemoveMembersMessageInfo = {\n+ type: messageTypes.REMOVE_MEMBERS,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ removedUserIDs: JSON.parse(content),\n+ };\n+ return rawRemoveMembersMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawRemoveMembersMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `REMOVE_MEMBERS`
Summary: Pull `RawRemoveMembersMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2391 |
129,184 | 16.11.2021 17:01:07 | 18,000 | c6be290f3f813c0c191c466fd072ce529ca249d8 | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_ROLE`
Summary: Pull `RawChangeRoleMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/change-role-message-spec.js",
"new_path": "lib/shared/messages/change-role-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nChangeRoleMessageData,\nChangeRoleMessageInfo,\n@@ -75,6 +78,27 @@ export const changeRoleMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawChangeRoleMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const rawChangeRoleMessageInfo: RawChangeRoleMessageInfo = {\n+ type: messageTypes.CHANGE_ROLE,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ userIDs: content.userIDs,\n+ newRole: content.newRole,\n+ };\n+ return rawChangeRoleMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawChangeRoleMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CHANGE_ROLE`
Summary: Pull `RawChangeRoleMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2392 |
129,184 | 16.11.2021 17:09:51 | 18,000 | d735bd12840c8236eb17298f63a3382ae8daac9d | [lib] Implement `rawMessageInfoFromClientDB` for `LEAVE_THREAD`
Summary: Pull `RawLeaveThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/leave-thread-message-spec.js",
"new_path": "lib/shared/messages/leave-thread-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nLeaveThreadMessageData,\nLeaveThreadMessageInfo,\n@@ -43,6 +46,19 @@ export const leaveThreadMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawLeaveThreadMessageInfo {\n+ const rawLeaveThreadMessageInfo: RawLeaveThreadMessageInfo = {\n+ type: messageTypes.LEAVE_THREAD,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ };\n+ return rawLeaveThreadMessageInfo;\n+ },\n+\nmessageTitle({\nmessageInfo,\nthreadInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `LEAVE_THREAD`
Summary: Pull `RawLeaveThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2393 |
129,184 | 16.11.2021 17:15:04 | 18,000 | 7a9c2174ded17f34987abc26e1b979e63cea444b | [lib] Implement `rawMessageInfoFromClientDB` for `JOIN_THREAD`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/join-thread-message-spec.js",
"new_path": "lib/shared/messages/join-thread-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nJoinThreadMessageData,\nJoinThreadMessageInfo,\n@@ -43,6 +46,19 @@ export const joinThreadMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawJoinThreadMessageInfo {\n+ const rawJoinThreadMessageInfo: RawJoinThreadMessageInfo = {\n+ type: messageTypes.JOIN_THREAD,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ };\n+ return rawJoinThreadMessageInfo;\n+ },\n+\nmessageTitle({\nmessageInfo,\nthreadInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `JOIN_THREAD`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2394 |
129,184 | 16.11.2021 17:20:37 | 18,000 | a8b52aace198f4249425119df68dcf1e32e24c3b | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_ENTRY`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-entry-message-spec.js",
"new_path": "lib/shared/messages/create-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nCreateEntryMessageData,\nCreateEntryMessageInfo,\n@@ -69,6 +72,28 @@ export const createEntryMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawCreateEntryMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const rawCreateEntryMessageInfo: RawCreateEntryMessageInfo = {\n+ type: messageTypes.CREATE_ENTRY,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ entryID: content.entryID,\n+ date: content.date,\n+ text: content.text,\n+ };\n+ return rawCreateEntryMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawCreateEntryMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_ENTRY`
Summary: Pull `RawJoinThreadMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2395 |
129,184 | 16.11.2021 17:43:10 | 18,000 | 29f46bb0251159298307b8135ec50315211d52b9 | [lib] Implement `rawMessageInfoFromClientDB` for `EDIT_ENTRY`
Summary: Pull `RawEditEntryMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/edit-entry-message-spec.js",
"new_path": "lib/shared/messages/edit-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nEditEntryMessageData,\nEditEntryMessageInfo,\n@@ -69,6 +72,28 @@ export const editEntryMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawEditEntryMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== null &&\n+ clientDBMessageInfo.content !== undefined,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const rawEditEntryMessageInfo: RawEditEntryMessageInfo = {\n+ type: messageTypes.EDIT_ENTRY,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ entryID: content.entryID,\n+ date: content.date,\n+ text: content.text,\n+ };\n+ return rawEditEntryMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawEditEntryMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `EDIT_ENTRY`
Summary: Pull `RawEditEntryMessageInfo` out of `ClientDBMessageInfo`
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2396 |
129,184 | 16.11.2021 17:46:14 | 18,000 | c4191b1620c67f265b24c4eb4b49ffbbf7ffa34a | [lib] Implement `rawMessageInfoFromClientDB` for `DELETE_ENTRY`
Summary: Pull `RawDeleteEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/delete-entry-message-spec.js",
"new_path": "lib/shared/messages/delete-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nDeleteEntryMessageData,\nDeleteEntryMessageInfo,\n@@ -69,6 +72,28 @@ export const deleteEntryMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawDeleteEntryMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const rawDeleteEntryMessageInfo: RawDeleteEntryMessageInfo = {\n+ type: messageTypes.DELETE_ENTRY,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ entryID: content.entryID,\n+ date: content.date,\n+ text: content.text,\n+ };\n+ return rawDeleteEntryMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawDeleteEntryMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `DELETE_ENTRY`
Summary: Pull `RawDeleteEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2397 |
129,184 | 16.11.2021 17:57:22 | 18,000 | 7130bf1f6f0b8faf8cfc36896559835a24a56f91 | [lib] Implement `rawMessageInfoFromClientDB` for `RESTORE_ENTRY`
Summary: Pull `RawRestoreEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/restore-entry-message-spec.js",
"new_path": "lib/shared/messages/restore-entry-message-spec.js",
"diff": "import invariant from 'invariant';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nRawRestoreEntryMessageInfo,\nRestoreEntryMessageData,\n@@ -69,6 +72,28 @@ export const restoreEntryMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawRestoreEntryMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const rawRestoreEntryMessageInfo: RawRestoreEntryMessageInfo = {\n+ type: messageTypes.RESTORE_ENTRY,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ entryID: content.entryID,\n+ date: content.date,\n+ text: content.text,\n+ };\n+ return rawRestoreEntryMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawRestoreEntryMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `RESTORE_ENTRY`
Summary: Pull `RawRestoreEntryMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2398 |
129,184 | 16.11.2021 13:35:07 | 18,000 | 74535438f561576e3317ccfd86c42faf1ddb33e6 | [lib] Introduce `translateClientDBMediaInfoToMedia`
Summary:
Takes the `ClientDBMediaInfo` from the C++ side, and gives us a `Media` object.
We aren't considering video messages for now, but maybe we should be.
Test Plan: Seems to work:
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/message-ops-utils.js",
"new_path": "lib/utils/message-ops-utils.js",
"diff": "@@ -22,6 +22,24 @@ function translateMediaToClientDBMediaInfo(media: Media): ClientDBMediaInfo {\n};\n}\n+function translateClientDBMediaInfoToMedia(\n+ clientDBMediaInfo: ClientDBMediaInfo,\n+): ?Media {\n+ if (clientDBMediaInfo.type !== 'photo') {\n+ return undefined;\n+ }\n+ const { dimensions, local_media_selection } = JSON.parse(\n+ clientDBMediaInfo.extras,\n+ );\n+ return {\n+ id: clientDBMediaInfo.id,\n+ uri: clientDBMediaInfo.uri,\n+ type: 'photo',\n+ dimensions: dimensions,\n+ localMediaSelection: local_media_selection,\n+ };\n+}\n+\nfunction translateRawMessageInfoToClientDBMessageInfo(\nrawMessageInfo: RawMessageInfo,\n): ClientDBMessageInfo {\n@@ -48,6 +66,7 @@ function translateRawMessageInfoToClientDBMessageInfo(\n}\nexport {\n+ translateClientDBMediaInfoToMedia,\ntranslateMediaToClientDBMediaInfo,\ntranslateRawMessageInfoToClientDBMessageInfo,\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `translateClientDBMediaInfoToMedia`
Summary:
Takes the `ClientDBMediaInfo` from the C++ side, and gives us a `Media` object.
We aren't considering video messages for now, but maybe we should be.
Test Plan: Seems to work: https://blob.sh/atul/952f.png
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2383 |
129,184 | 17.11.2021 13:00:03 | 18,000 | 100ef746be9cfdbb754c1a7d5161c9670672ec4e | [lib] Implement `rawMessageInfoFromClientDB` for `UPDATE_RELATIONSHIP`
Summary: Pull `RawUpdateRelationshipMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/update-relationship-message-spec.js",
"new_path": "lib/shared/messages/update-relationship-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport type { PlatformDetails } from '../../types/device-types';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type { RawUnsupportedMessageInfo } from '../../types/messages/unsupported';\nimport type {\nRawUpdateRelationshipMessageInfo,\n@@ -74,6 +77,27 @@ export const updateRelationshipMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawUpdateRelationshipMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+ const content = JSON.parse(clientDBMessageInfo.content);\n+ const rawUpdateRelationshipMessageInfo: RawUpdateRelationshipMessageInfo = {\n+ type: messageTypes.UPDATE_RELATIONSHIP,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ targetID: content.target,\n+ operation: content.operation,\n+ };\n+ return rawUpdateRelationshipMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawUpdateRelationshipMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `UPDATE_RELATIONSHIP`
Summary: Pull `RawUpdateRelationshipMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2403 |
129,184 | 17.11.2021 14:33:52 | 18,000 | 2de2415ccdd8c99e6a612dad534ab02b69f87318 | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SIDEBAR`
Summary: Pull `RawCreateSidebarMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/create-sidebar-message-spec.js",
"new_path": "lib/shared/messages/create-sidebar-message-spec.js",
"diff": "@@ -4,7 +4,10 @@ import invariant from 'invariant';\nimport type { PlatformDetails } from '../../types/device-types';\nimport { messageTypes } from '../../types/message-types';\n-import type { MessageInfo } from '../../types/message-types';\n+import type {\n+ MessageInfo,\n+ ClientDBMessageInfo,\n+} from '../../types/message-types';\nimport type {\nCreateSidebarMessageData,\nCreateSidebarMessageInfo,\n@@ -88,6 +91,30 @@ export const createSidebarMessageSpec: MessageSpec<\n};\n},\n+ rawMessageInfoFromClientDB(\n+ clientDBMessageInfo: ClientDBMessageInfo,\n+ ): RawCreateSidebarMessageInfo {\n+ invariant(\n+ clientDBMessageInfo.content !== undefined &&\n+ clientDBMessageInfo.content !== null,\n+ 'content must be defined',\n+ );\n+\n+ const { sourceMessageAuthorID, ...initialThreadState } = JSON.parse(\n+ clientDBMessageInfo.content,\n+ );\n+ const rawCreateSidebarMessageInfo: RawCreateSidebarMessageInfo = {\n+ type: messageTypes.CREATE_SIDEBAR,\n+ id: clientDBMessageInfo.id,\n+ threadID: clientDBMessageInfo.thread,\n+ time: parseInt(clientDBMessageInfo.time),\n+ creatorID: clientDBMessageInfo.user,\n+ sourceMessageAuthorID: sourceMessageAuthorID,\n+ initialThreadState: initialThreadState,\n+ };\n+ return rawCreateSidebarMessageInfo;\n+ },\n+\ncreateMessageInfo(\nrawMessageInfo: RawCreateSidebarMessageInfo,\ncreator: RelativeUserInfo,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `rawMessageInfoFromClientDB` for `CREATE_SIDEBAR`
Summary: Pull `RawCreateSidebarMessageInfo` out of ClientDBMessageInfo
Test Plan: All of these implementations will be tested manually + with my prod redux store
Reviewers: ashoat, palys-swm
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2405 |
129,190 | 19.11.2021 10:20:53 | -3,600 | 79f7b36e38d53b1fa014fa38c63d20cdb3cbafc0 | [1/n] [services] Add tools for the storage manager
Summary: Add tools to storage manager introduced in D2334
Test Plan: -
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/contents/server/src/Tools.h",
"diff": "+#include <exception>\n+\n+namespace comm {\n+namespace network {\n+\n+// 4MB limit\n+const size_t GRPC_CHUNK_SIZE_LIMIT = 4 * 1024 * 1024;\n+\n+// 5MB limit\n+const size_t AWS_MULTIPART_UPLOAD_MINIMUM_CHUNK_SIZE = 5 * 1024 * 1024;\n+\n+enum class OBJECT_TYPE {\n+ ENCRYPTED_BACKUP_KEY = 0,\n+ TRANSACTION_LOGS = 1,\n+ COMPACTION = 2,\n+};\n+\n+} // namespace network\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] [services] Add tools for the storage manager
Summary: Add tools to storage manager introduced in D2334
Test Plan: -
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Tags: #aws_implement_services
Differential Revision: https://phabricator.ashoat.com/D2339 |
129,184 | 21.11.2021 16:36:35 | 18,000 | dd3e989a597cdf877ee72ea1c602df5df85be5ed | [native] `codeVersion` -> 120 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 119\n- versionName '1.0.119'\n+ versionCode 120\n+ versionName '1.0.120'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.119</string>\n+ <string>1.0.120</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>119</string>\n+ <string>120</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.119</string>\n+ <string>1.0.120</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>119</string>\n+ <string>120</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 119;\n+const codeVersion = 120;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 120 |
129,190 | 22.11.2021 15:49:17 | -3,600 | abeefac291ca3a4871f8d191ff16fc8615cbe632 | [native] Fix build after proto refactor
Summary: In reponse to
Test Plan: build iOS/android
Reviewers: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -51,7 +51,7 @@ bool Client::becomeNewPrimaryDevice() {\nvoid Client::sendPong() {\ngrpc::ClientContext context;\ntunnelbroker::PongRequest request;\n- tunnelbroker::PongResponse response;\n+ google::protobuf::Empty response;\nrequest.set_userid(this->id);\nrequest.set_devicetoken(this->deviceToken);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Fix build after proto refactor
Summary: In reponse to https://linear.app/comm/issue/ENG-207/fix-native-after-refactoring-proto-files
Test Plan: build iOS/android
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2424 |
129,184 | 22.11.2021 15:07:25 | 18,000 | bd1bcb9eb50a387f81f567d24f07ee4ab8375526 | [lib] Increase `create_account` timeout to 60s
Summary: Increase timeout since account creation can take a while.
Test Plan: NA
Reviewers: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/user-actions.js",
"new_path": "lib/actions/user-actions.js",
"diff": "@@ -70,15 +70,20 @@ const registerActionTypes = Object.freeze({\nsuccess: 'REGISTER_SUCCESS',\nfailed: 'REGISTER_FAILED',\n});\n+const registerFetchJSONOptions = { timeout: 60000 };\nconst register = (\nfetchJSON: FetchJSON,\n): ((\nregisterInfo: RegisterInfo,\n) => Promise<RegisterResult>) => async registerInfo => {\n- const response = await fetchJSON('create_account', {\n+ const response = await fetchJSON(\n+ 'create_account',\n+ {\n...registerInfo,\nplatformDetails: getConfig().platformDetails,\n- });\n+ },\n+ registerFetchJSONOptions,\n+ );\nreturn {\ncurrentUserInfo: response.currentUserInfo,\nrawMessageInfos: response.rawMessageInfos,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Increase `create_account` timeout to 60s
Summary: Increase timeout since account creation can take a while.
Test Plan: NA
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2426 |
129,187 | 22.11.2021 19:58:21 | 18,000 | e49a887ed6acd0750162b17f3850d45d952de6ec | [native] Render PushHandler even if SplashScreen fails to hide
Summary: This should solve the notif badging issue once and for all!
Test Plan: This is based on our staff-only build 120
Reviewers: atul
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/app-navigator.react.js",
"new_path": "native/navigation/app-navigator.react.js",
"diff": "@@ -186,8 +186,9 @@ function AppNavigator(props: AppNavigatorProps): React.Node {\nawait waitForInteractions();\ntry {\nawait SplashScreen.hideAsync();\n+ } finally {\nsetLocalSplashScreenHasHidden(true);\n- } catch {}\n+ }\n})();\n}, [localSplashScreenHasHidden]);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Render PushHandler even if SplashScreen fails to hide
Summary: This should solve the notif badging issue once and for all!
Test Plan: This is based on our staff-only build 120
Reviewers: atul
Reviewed By: atul
Subscribers: palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2427 |
129,187 | 22.11.2021 23:36:07 | 18,000 | f9a1399e10593270df677f11aee8aa72f2f9f7f8 | Remove .vscode directory
Summary: It's being `.gitignore`'d, so we should exclude it from the repository.
Test Plan: N/A
Reviewers: atul, benschac, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "DELETE",
"old_path": ".vscode/launch.json",
"new_path": null,
"diff": "-{\n- \"configurations\": [\n- {\n- \"name\": \"Debug iOS Hermes\",\n- \"cwd\": \"${workspaceFolder}/native\",\n- \"type\": \"reactnativedirect\",\n- \"request\": \"attach\",\n- \"platform\": \"ios\",\n- \"trace\": \"verbose\"\n- }\n- ]\n-}\n"
},
{
"change_type": "DELETE",
"old_path": ".vscode/settings.json",
"new_path": null,
"diff": "-{\n- \"javascript.validate.enable\": false\n-}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | Remove .vscode directory
Summary: It's being `.gitignore`'d, so we should exclude it from the repository.
Test Plan: N/A
Reviewers: atul, benschac, palys-swm
Reviewed By: palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2431 |
129,179 | 23.11.2021 14:49:12 | 18,000 | 522763355c3a34198ea47b5e45135ba221980c18 | [lib] fix: bad path
Summary: clean up import from:
Test Plan: make sure code still works by going to default notifs screen.
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "// @flow\n-import { values } from '../../lib/utils/objects';\n+import { values } from '../utils/objects';\nimport type { PlatformDetails, DeviceType } from './device-types';\nimport type {\nCalendarQuery,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] fix: bad path
Summary: clean up import from: https://phabricator.ashoat.com/D2372
Test Plan: make sure code still works by going to default notifs screen.
Reviewers: atul, ashoat, palys-swm
Reviewed By: atul, ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2425 |
129,184 | 23.11.2021 15:42:45 | 18,000 | 42b8d1e958558b3a2f4fea2ede48d82f0d646404 | [native] `codeVersion` -> 121 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 120\n- versionName '1.0.120'\n+ versionCode 121\n+ versionName '1.0.121'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.120</string>\n+ <string>1.0.121</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>120</string>\n+ <string>121</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.120</string>\n+ <string>1.0.121</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>120</string>\n+ <string>121</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 120;\n+const codeVersion = 121;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 121 |
129,184 | 23.11.2021 15:47:21 | 18,000 | 8fd27eb9a42276ef48f7197bfd17c0584f8115a3 | [native] `codeVersion` -> 122 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 121\n- versionName '1.0.121'\n+ versionCode 122\n+ versionName '1.0.122'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.121</string>\n+ <string>1.0.122</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>121</string>\n+ <string>122</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.121</string>\n+ <string>1.0.122</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>121</string>\n+ <string>122</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -359,7 +359,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 121;\n+const codeVersion = 122;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 122 |
129,184 | 24.11.2021 14:54:23 | 18,000 | 6a24846120914118be9b8149138c90b8dfaee0a4 | [lib] Implement `messageContentForClientDB` for `SIDEBAR_SOURCE`
Summary: Serialize the entire `sourceMessage` so it can be reconstructed by `rawMessageInfoFromClientDBRow`
Test Plan: Will test with implementation of `SIDEBAR_SOURCE:rawMessageInfoFromClientDB`
Reviewers: ashoat
Subscribers: def-au1t, palys-swm, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/sidebar-source-message-spec.js",
"new_path": "lib/shared/messages/sidebar-source-message-spec.js",
"diff": "@@ -39,7 +39,11 @@ export const sidebarSourceMessageSpec: MessageSpec<\n},\nmessageContentForClientDB(data: RawSidebarSourceMessageInfo): string {\n- return this.messageContentForServerDB(data);\n+ invariant(\n+ data.sourceMessage && data.sourceMessage.id,\n+ 'sourceMessage and sourceMessage.id should be defined',\n+ );\n+ return JSON.stringify(data.sourceMessage);\n},\nmessageTitle() {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Implement `messageContentForClientDB` for `SIDEBAR_SOURCE`
Summary: Serialize the entire `sourceMessage` so it can be reconstructed by `rawMessageInfoFromClientDBRow`
Test Plan: Will test with implementation of `SIDEBAR_SOURCE:rawMessageInfoFromClientDB`
Reviewers: ashoat
Reviewed By: ashoat
Subscribers: def-au1t, palys-swm, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2464 |
129,184 | 29.11.2021 23:45:31 | 28,800 | 92a0c7bf5903727091f23aea4f019d0037927676 | [native] `codeVersion` -> 123 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 122\n- versionName '1.0.122'\n+ versionCode 123\n+ versionName '1.0.123'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.122</string>\n+ <string>1.0.123</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>122</string>\n+ <string>123</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.122</string>\n+ <string>1.0.123</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>122</string>\n+ <string>123</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -354,12 +354,12 @@ const persistConfig = {\n'frozen',\n],\ndebug: __DEV__,\n- version: 29,\n+ version: 30,\nmigrate: (createMigrate(migrations, { debug: __DEV__ }): any),\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 122;\n+const codeVersion = 123;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 123 |
129,184 | 29.11.2021 23:53:55 | 28,800 | 1752b228e0f112a544da401b76782a885fd6beb5 | [native] `codeVersion` -> 124 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 123\n- versionName '1.0.123'\n+ versionCode 124\n+ versionName '1.0.124'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.123</string>\n+ <string>1.0.124</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>123</string>\n+ <string>124</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.123</string>\n+ <string>1.0.124</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>123</string>\n+ <string>124</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -352,6 +352,7 @@ const persistConfig = {\n'connectivity',\n'deviceOrientation',\n'frozen',\n+ 'threadStore',\n],\ndebug: __DEV__,\nversion: 30,\n@@ -359,7 +360,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 123;\n+const codeVersion = 124;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 124 |
129,184 | 29.11.2021 14:48:55 | 28,800 | 316ebb30c03585172059b526bc049729320234fc | [CI] Run `[lib] yarn jest` on each push
Summary: Yeah ik CI stuff on pause, but this took like 10 seconds
Test Plan: Ran successfully on fork:
Reviewers: ashoat, benschac, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "RENAME",
"old_path": ".github/workflows/eslint_flow.yml",
"new_path": ".github/workflows/eslint_flow_jest.yml",
"diff": "-name: ESLint & Flow\n+name: ESLint & Flow & Jest\non:\npush:\n@@ -45,3 +45,7 @@ jobs:\n- name: '[native] flow'\nworking-directory: ./native\nrun: ./node_modules/.bin/flow\n+\n+ - name: '[lib] test'\n+ working-directory: ./lib\n+ run: yarn test\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/package.json",
"new_path": "lib/package.json",
"diff": "\"private\": true,\n\"license\": \"BSD-3-Clause\",\n\"scripts\": {\n- \"clean\": \"rm -rf node_modules/\"\n+ \"clean\": \"rm -rf node_modules/\",\n+ \"test\": \"jest\"\n},\n\"devDependencies\": {\n\"@babel/core\": \"^7.13.14\",\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CI] Run `[lib] yarn jest` on each push
Summary: Yeah ik CI stuff on pause, but this took like 10 seconds
Test Plan: Ran successfully on fork: https://blob.sh/atul/2f70.png
Reviewers: ashoat, benschac, palys-swm
Reviewed By: ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2483 |
129,184 | 02.12.2021 16:51:58 | 28,800 | 2c194f207fcfe817673962e76cdeae8b0c427996 | [native] `codeVersion` -> 125 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 124\n- versionName '1.0.124'\n+ versionCode 125\n+ versionName '1.0.125'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.124</string>\n+ <string>1.0.125</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>124</string>\n+ <string>125</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.124</string>\n+ <string>1.0.125</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>124</string>\n+ <string>125</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -352,15 +352,14 @@ const persistConfig = {\n'connectivity',\n'deviceOrientation',\n'frozen',\n- 'threadStore',\n],\ndebug: __DEV__,\n- version: 30,\n+ version: 29,\nmigrate: (createMigrate(migrations, { debug: __DEV__ }): any),\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 124;\n+const codeVersion = 125;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 125 |
129,179 | 03.12.2021 13:37:02 | 18,000 | 5bd2821d51e376b912bc13152e523bb8a1002e87 | [1/n] remove active_card styling functionality on scroll
Summary: scroll page, active card should not light up anymore
Test Plan: scroll page, active card should not light up anymore
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\n-import { Waypoint } from 'react-waypoint';\nimport css from './landing.css';\ntype InfoCardProps = {\n- +idx: number,\n- +active: boolean,\n+label: string,\n+icon: mixed,\n+description: string,\n+baseStyle: string,\n- +setActiveCardIdx: number => void,\n};\nfunction InfoCard(props: InfoCardProps): React.Node {\n- const {\n- idx,\n- active,\n- label,\n- icon,\n- description,\n- baseStyle,\n- setActiveCardIdx,\n- } = props;\n-\n- const onTopPositionChange = React.useCallback(\n- obj => {\n- if (\n- obj.previousPosition === 'above' &&\n- obj.currentPosition === 'inside'\n- ) {\n- setActiveCardIdx(idx);\n- } else if (\n- obj.previousPosition === 'inside' &&\n- obj.currentPosition === 'above'\n- ) {\n- setActiveCardIdx(idx + 1);\n- }\n- },\n- [idx, setActiveCardIdx],\n- );\n-\n- const onBottomPositionChange = React.useCallback(\n- obj => {\n- if (\n- obj.previousPosition === 'below' &&\n- obj.currentPosition === 'inside'\n- ) {\n- setActiveCardIdx(idx);\n- } else if (\n- obj.previousPosition === 'inside' &&\n- obj.currentPosition === 'below'\n- ) {\n- setActiveCardIdx(idx - 1);\n- }\n- },\n- [idx, setActiveCardIdx],\n- );\n+ const { label, icon, description, baseStyle } = props;\nreturn (\n- <div className={active ? `${baseStyle} ${css.active_card}` : baseStyle}>\n- <Waypoint onPositionChange={onTopPositionChange} />\n+ <div className={baseStyle}>\n<div className={css.tile_title_row}>\n<FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={icon} />\n<p className={css.tile_title}>{label}</p>\n</div>\n<p>{description}</p>\n- <Waypoint onPositionChange={onBottomPositionChange} />\n</div>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -218,10 +218,6 @@ div.tile_grid > div {\ntransition: 300ms;\n}\n-.active_card {\n- box-shadow: 0px 20px 50px rgba(126, 87, 194, 0.5);\n-}\n-\ndiv.tile_title_row {\ndisplay: flex;\nflex-direction: row;\n@@ -482,10 +478,6 @@ div.body_grid > div + .starting_section {\nfont-size: 20px;\n}\n- .active_card {\n- box-shadow: none;\n- }\n-\n/* ===== LAYOUT HACKS ===== */\n.section {\npadding-top: 20px;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/package.json",
"new_path": "landing/package.json",
"diff": "\"dependencies\": {\n\"@babel/runtime\": \"^7.13.10\",\n\"@fortawesome/fontawesome-svg-core\": \"^1.2.25\",\n+ \"@fortawesome/free-brands-svg-icons\": \"^5.15.4\",\n\"@fortawesome/free-regular-svg-icons\": \"^5.11.2\",\n\"@fortawesome/free-solid-svg-icons\": \"^5.11.2\",\n- \"@fortawesome/free-brands-svg-icons\": \"^5.15.4\",\n\"@fortawesome/react-fontawesome\": \"^0.1.5\",\n- \"react-text-loop\": \"^2.3.0\",\n- \"react-waypoint\": \"^10.1.0\",\n\"@lottiefiles/lottie-interactivity\": \"^0.1.4\",\n\"@lottiefiles/lottie-player\": \"^1.0.3\",\n\"core-js\": \"^3.6.5\",\n\"react-dom\": \"17.0.1\",\n\"react-hot-loader\": \"^4.12.14\",\n\"react-router\": \"^5.2.0\",\n- \"react-router-dom\": \"^5.2.0\"\n+ \"react-router-dom\": \"^5.2.0\",\n+ \"react-text-loop\": \"^2.3.0\"\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "pirates \"^4.0.0\"\nsource-map-support \"^0.5.16\"\n-\"@babel/runtime@^7.1.2\", \"@babel/runtime@^7.12.1\", \"@babel/runtime@^7.12.5\", \"@babel/runtime@^7.13.10\", \"@babel/runtime@^7.5.5\", \"@babel/runtime@^7.8.4\", \"@babel/runtime@^7.8.7\":\n+\"@babel/runtime@^7.1.2\", \"@babel/runtime@^7.12.1\", \"@babel/runtime@^7.13.10\", \"@babel/runtime@^7.5.5\", \"@babel/runtime@^7.8.4\", \"@babel/runtime@^7.8.7\":\nversion \"7.15.4\"\nresolved \"https://registry.yarnpkg.com/@babel/runtime/-/runtime-7.15.4.tgz#fd17d16bfdf878e6dd02d19753a39fa8a8d9c84a\"\nintegrity sha512-99catp6bHCaxr4sJ/DbTGgHS4+Rs2RVd2g7iOap6SLGPDknRK9ztKNsE/Fg6QhSeh1FGE5f6gHGQmvvn3I3xhw==\n@@ -4675,11 +4675,6 @@ console-control-strings@^1.0.0, console-control-strings@~1.1.0:\nresolved \"https://registry.yarnpkg.com/console-control-strings/-/console-control-strings-1.1.0.tgz#3d7cf4464db6446ea644bf4b39507f9851008e8e\"\nintegrity sha1-PXz0Rk22RG6mRL9LOVB/mFEAjo4=\n-\"consolidated-events@^1.1.0 || ^2.0.0\":\n- version \"2.0.2\"\n- resolved \"https://registry.yarnpkg.com/consolidated-events/-/consolidated-events-2.0.2.tgz#da8d8f8c2b232831413d9e190dc11669c79f4a91\"\n- integrity sha512-2/uRVMdRypf5z/TW/ncD/66l75P5hH2vM/GR8Jf8HLc2xnfJtmina6F6du8+v4Z2vTrMo7jC+W1tmEEuuELgkQ==\n-\nconst-max-uint32@^1.0.2:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/const-max-uint32/-/const-max-uint32-1.0.2.tgz#f009bb6230e678ed874dd2d6a9cd9e3cbfabb676\"\n@@ -12170,7 +12165,7 @@ prompts@^2.0.1, prompts@^2.4.0:\nkleur \"^3.0.3\"\nsisteransi \"^1.0.5\"\n-prop-types@^15.0.0, prop-types@^15.5.10, prop-types@^15.5.8, prop-types@^15.6.1, prop-types@^15.6.2, prop-types@^15.7.2:\n+prop-types@^15.5.10, prop-types@^15.5.8, prop-types@^15.6.1, prop-types@^15.6.2, prop-types@^15.7.2:\nversion \"15.7.2\"\nresolved \"https://registry.yarnpkg.com/prop-types/-/prop-types-15.7.2.tgz#52c41e75b8c87e72b9d9360e0206b99dcbffa6c5\"\nintegrity sha512-8QQikdH7//R2vurIJSutZ1smHYTcLpRWEOlHnzcWHmBYrOGUysKwSsrC89BCiFj3CbrfJ/nXFdJepOVrY1GCHQ==\n@@ -12876,16 +12871,6 @@ react-timeago@^5.2.0:\nresolved \"https://registry.yarnpkg.com/react-timeago/-/react-timeago-5.2.0.tgz#d655d40aa55e4fe08a92234481a6aea7f656ab5d\"\nintegrity sha512-wCEEDGQHMdFh/PLp+Hj5vk9ZoC4KjQ5u0u6+KrrY9rny5LqJ2gZvNNEAS4mhSZDV1i7JLgQI5VQTAux7f+vj2w==\n-react-waypoint@^10.1.0:\n- version \"10.1.0\"\n- resolved \"https://registry.yarnpkg.com/react-waypoint/-/react-waypoint-10.1.0.tgz#6ab522a61bd52946260e4a78b3182759a97b40ec\"\n- integrity sha512-wiVF0lTslVm27xHbnvUUADUrcDjrQxAp9lEYGExvcoEBScYbXu3Kt++pLrfj6CqOeeRAL4HcX8aANVLSn6bK0Q==\n- dependencies:\n- \"@babel/runtime\" \"^7.12.5\"\n- consolidated-events \"^1.1.0 || ^2.0.0\"\n- prop-types \"^15.0.0\"\n- react-is \"^17.0.1\"\n-\nreact@17.0.1:\nversion \"17.0.1\"\nresolved \"https://registry.yarnpkg.com/react/-/react-17.0.1.tgz#6e0600416bd57574e3f86d92edba3d9008726127\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] remove active_card styling functionality on scroll
Summary: scroll page, active card should not light up anymore
Test Plan: scroll page, active card should not light up anymore
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2551 |
129,179 | 03.12.2021 13:42:34 | 18,000 | 28dcc90a69f90d4a3099398022b090db63441ae2 | [2/n] [landing] change label to title in info block
Summary: label prop is changed to title prop
Test Plan: N/A code should run
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "@@ -6,19 +6,19 @@ import * as React from 'react';\nimport css from './landing.css';\ntype InfoCardProps = {\n- +label: string,\n+ +title: string,\n+icon: mixed,\n+description: string,\n+baseStyle: string,\n};\nfunction InfoCard(props: InfoCardProps): React.Node {\n- const { label, icon, description, baseStyle } = props;\n+ const { title, icon, description, baseStyle } = props;\nreturn (\n<div className={baseStyle}>\n<div className={css.tile_title_row}>\n<FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={icon} />\n- <p className={css.tile_title}>{label}</p>\n+ <p className={css.tile_title}>{title}</p>\n</div>\n<p>{description}</p>\n</div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n] [landing] change label to title in info block
Summary: label prop is changed to title prop
Test Plan: N/A code should run
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2552 |
129,179 | 03.12.2021 13:45:40 | 18,000 | 86dfdfc1bfe3658bc3faa922cf14e6ed1ca1c1f9 | [3/n] [landing] remove font icon from info block
Summary: design no longer calls for icons in the info blocks
Test Plan: make sure the font icon isn't being rendered
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "// @flow\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport * as React from 'react';\nimport css from './landing.css';\ntype InfoCardProps = {\n+title: string,\n- +icon: mixed,\n+description: string,\n+baseStyle: string,\n};\nfunction InfoCard(props: InfoCardProps): React.Node {\n- const { title, icon, description, baseStyle } = props;\n+ const { title, description, baseStyle } = props;\nreturn (\n<div className={baseStyle}>\n<div className={css.tile_title_row}>\n- <FontAwesomeIcon size=\"2x\" color=\"#ffffff\" icon={icon} />\n<p className={css.tile_title}>{title}</p>\n</div>\n<p>{description}</p>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] [landing] remove font icon from info block
Summary: design no longer calls for icons in the info blocks
Test Plan: make sure the font icon isn't being rendered
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2553 |
129,179 | 03.12.2021 14:07:03 | 18,000 | df7f2a442de7e027b207bc31d361ce84ca2a4ca8 | [4/n] [landing] move meta data into asset file
Summary: Move asset data into its own file
Test Plan: Make sure site still renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.react.js",
"new_path": "landing/keyservers.react.js",
"diff": "import { create } from '@lottiefiles/lottie-interactivity';\nimport * as React from 'react';\n+import { assetUrl } from './asset-meta-data';\nimport css from './landing.css';\nimport ReadDocsButton from './read-docs-btn.react';\nimport StarBackground from './star-background.react';\n@@ -66,8 +67,6 @@ function Keyservers(): React.Node {\nreturn () => cloudNode.removeEventListener('load', onCloudIllustrationLoad);\n}, [cloudNode, onCloudIllustrationLoad]);\n- const LandingAssetsS3URL = 'https://dh9fld3hutpxf.cloudfront.net';\n-\nreturn (\n<div>\n<StarBackground />\n@@ -77,7 +76,7 @@ function Keyservers(): React.Node {\nid=\"eye-illustration\"\nref={setEyeNode}\nmode=\"normal\"\n- src={`${LandingAssetsS3URL}/animated_eye.json`}\n+ src={`${assetUrl}/animated_eye.json`}\nspeed={1}\n/>\n</div>\n@@ -101,7 +100,7 @@ function Keyservers(): React.Node {\nid=\"cloud-illustration\"\nref={setCloudNode}\nmode=\"normal\"\n- src={`${LandingAssetsS3URL}/animated_cloud.json`}\n+ src={`${assetUrl}/animated_cloud.json`}\nspeed={1}\n/>\n</div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [4/n] [landing] move meta data into asset file
Summary: Move asset data into its own file
Test Plan: Make sure site still renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2554 |
129,179 | 03.12.2021 14:25:28 | 18,000 | 79ba0c3c3d3c4510c9f2549f22650b63713d0d35 | [5/n] [landing] move preloadassets to hook
Summary: Move preload assets effect to a hook
Test Plan: look in developer console and see assets are being preloaded
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "import * as React from 'react';\n-import { assetUrl, assetMetaData } from './asset-meta-data';\n+import { assetMetaData } from './asset-meta-data';\nimport CyclingHeader from './cycling-header.react';\nimport InfoCard from './info-card.react';\nimport css from './landing.css';\nimport StarBackground from './star-background.react';\n+import usePreloadAssets from './use-pre-load-assets.react';\nfunction AppLanding(): React.Node {\n+ usePreloadAssets(assetMetaData);\nconst [\nhero,\nfederated,\n@@ -19,29 +21,6 @@ function AppLanding(): React.Node {\nlessNoisy,\n] = assetMetaData;\n- React.useEffect(() => {\n- const testWEBP = 'UklGRiIAAABXRUJQVlA4IBYAAAAwAQCdASoBAAEADsD+JaQAA3AAAAAA';\n- const testImg = new Image();\n-\n- // preload webp if supported\n- testImg.onload = () => {\n- for (const imageFileName of assetMetaData) {\n- const image = new Image();\n- image.src = `${assetUrl}/${imageFileName.url}.webp`;\n- }\n- };\n-\n- // preload png if webp not supported\n- testImg.onerror = () => {\n- for (const imageFileName of assetMetaData) {\n- const image = new Image();\n- image.src = `${assetUrl}/${imageFileName.url}.png`;\n- }\n- };\n-\n- testImg.src = `data:image/webp;base64,${testWEBP}`;\n- }, []);\n-\nreturn (\n<>\n<StarBackground />\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/use-pre-load-assets.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+import { assetUrl } from './asset-meta-data';\n+\n+type Asset = {\n+ +alt: string,\n+ +url: string,\n+ +title: string,\n+ +description: string,\n+};\n+\n+function usePreloadAssets(assets: Asset[]) {\n+ React.useEffect(() => {\n+ const testWEBP = 'UklGRiIAAABXRUJQVlA4IBYAAAAwAQCdASoBAAEADsD+JaQAA3AAAAAA';\n+ const testImg = new Image();\n+\n+ // preload webp if supported\n+ testImg.onload = () => {\n+ for (const { url } of assets) {\n+ const image = new Image();\n+ image.src = `${assetUrl}/${url}.webp`;\n+ }\n+ };\n+\n+ // preload png if webp not supported\n+ testImg.onerror = () => {\n+ for (const { url } of assets) {\n+ const image = new Image();\n+ image.src = `${assetUrl}/${url}.png`;\n+ }\n+ };\n+\n+ testImg.src = `data:image/webp;base64,${testWEBP}`;\n+ }, [assets]);\n+}\n+\n+export default usePreloadAssets;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [5/n] [landing] move preloadassets to hook
Summary: Move preload assets effect to a hook
Test Plan: look in developer console and see assets are being preloaded
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2555 |
129,179 | 03.12.2021 14:38:07 | 18,000 | 76b773896dca7af1f585c0916a4016c42ff344a8 | [6/n] [landing] move picture into its own component
Summary: move picture to component
Test Plan: make sure picture is loading
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/Picture.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+type PictureProps = {\n+ +url: string,\n+ +alt: string,\n+};\n+\n+function Picture(props: PictureProps): React.Node {\n+ const { url, alt } = props;\n+ return (\n+ <picture>\n+ <source srcSet={`${url}.webp`} type=\"image/webp\" />\n+ <source srcSet={`${url}.png`} type=\"image/png\" />\n+ <img src={`${url}.png`} alt={alt} />\n+ </picture>\n+ );\n+}\n+\n+export default Picture;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -6,6 +6,7 @@ import { assetMetaData } from './asset-meta-data';\nimport CyclingHeader from './cycling-header.react';\nimport InfoCard from './info-card.react';\nimport css from './landing.css';\n+import Picture from './Picture.react';\nimport StarBackground from './star-background.react';\nimport usePreloadAssets from './use-pre-load-assets.react';\n@@ -26,11 +27,7 @@ function AppLanding(): React.Node {\n<StarBackground />\n<div className={css.app_landing_grid}>\n<div className={css.app_preview}>\n- <picture>\n- <source srcSet={`${hero.url}.webp`} type=\"image/webp\" />\n- <source srcSet={`${hero.url}.png`} type=\"image/png\" />\n- <img src={`${hero.url}.png`} alt={hero.alt} />\n- </picture>\n+ <Picture url={hero.url} alt={hero.alt} />\n</div>\n<div className={css.app_copy}>\n<div className={css.app_copy_wrapper}>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [6/n] [landing] move picture into its own component
Summary: move picture to component
Test Plan: make sure picture is loading
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2556 |
129,184 | 08.12.2021 16:47:31 | 18,000 | 21f6f0e03b59c5084d103a59ee945dcc89e807e8 | [native] Call C++ `processMessageStoreOperations` from redux-setup:reducer
Summary: Apply message store operations to the SQLite store.
Test Plan:
1. Set breakpoints and observed expected behavior
2. Checked the SQLite `messages` table and everything looked as expected
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/redux/redux-setup.js",
"new_path": "native/redux/redux-setup.js",
"diff": "@@ -30,6 +30,7 @@ import {\nimport { updateTypes } from 'lib/types/update-types';\nimport { reduxLoggerMiddleware } from 'lib/utils/action-logger';\nimport { setNewSessionActionType } from 'lib/utils/action-utils';\n+import { convertMessageStoreOperationsToClientDBOperations } from 'lib/utils/message-ops-utils';\nimport { convertThreadStoreOperationsToClientDBOperations } from 'lib/utils/thread-ops-utils';\nimport { defaultNavInfo } from '../navigation/default-state';\n@@ -292,16 +293,35 @@ function reducer(state: AppState = defaultState, action: Action) {\nconst baseReducerResult = baseReducer(state, (action: BaseAction));\nstate = baseReducerResult.state;\n- const {\n- storeOperations: { threadStoreOperations },\n- } = baseReducerResult;\n- if (threadStoreOperations.length > 0) {\n- const operations = convertThreadStoreOperationsToClientDBOperations(\n+\n+ const { storeOperations } = baseReducerResult;\n+ const { threadStoreOperations, messageStoreOperations } = storeOperations;\n+\n+ const convertedThreadStoreOperations = convertThreadStoreOperationsToClientDBOperations(\nthreadStoreOperations,\n);\n+ const convertedMessageStoreOperations = convertMessageStoreOperationsToClientDBOperations(\n+ messageStoreOperations,\n+ );\n+\n(async () => {\ntry {\n- await global.CommCoreModule.processThreadStoreOperations(operations);\n+ const promises = [];\n+ if (convertedThreadStoreOperations.length > 0) {\n+ promises.push(\n+ global.CommCoreModule.processThreadStoreOperations(\n+ convertedThreadStoreOperations,\n+ ),\n+ );\n+ }\n+ if (convertedMessageStoreOperations.length > 0) {\n+ promises.push(\n+ global.CommCoreModule.processMessageStoreOperations(\n+ convertedMessageStoreOperations,\n+ ),\n+ );\n+ }\n+ await Promise.all(promises);\n} catch {\ndispatch({\ntype: setNewSessionActionType,\n@@ -324,7 +344,6 @@ function reducer(state: AppState = defaultState, action: Action) {\nExitApp.exitApp();\n}\n})();\n- }\nreturn fixUnreadActiveThread(state, action);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Call C++ `processMessageStoreOperations` from redux-setup:reducer
Summary: Apply message store operations to the SQLite store.
Test Plan:
1. Set breakpoints and observed expected behavior
2. Checked the SQLite `messages` table and everything looked as expected
Reviewers: def-au1t, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2502 |
129,184 | 08.12.2021 22:18:25 | 18,000 | fd53c08608993a493da30dd846e84b087f62951a | [CommCoreModule] Implement `processMessageStoreOperationsSync`
Summary: To be used in the redux migration
Test Plan: Will be tested with subsequent diffs
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -326,6 +326,42 @@ jsi::Value CommCoreModule::processMessageStoreOperations(\n});\n}\n+bool CommCoreModule::processMessageStoreOperationsSync(\n+ jsi::Runtime &rt,\n+ const jsi::Array &operations) {\n+\n+ std::promise<bool> operationsResult;\n+ std::future<bool> operationsResultFuture = operationsResult.get_future();\n+\n+ std::vector<std::unique_ptr<MessageStoreOperationBase>> messageStoreOps;\n+ std::string operationsError;\n+\n+ try {\n+ messageStoreOps = createMessageStoreOperations(rt, operations);\n+ } catch (std::runtime_error &e) {\n+ return false;\n+ }\n+\n+ this->databaseThread->scheduleTask(\n+ [=, &messageStoreOps, &operationsResult, &rt]() {\n+ std::string error = operationsError;\n+ if (!error.size()) {\n+ try {\n+ DatabaseManager::getQueryExecutor().beginTransaction();\n+ for (const auto &operation : messageStoreOps) {\n+ operation->execute();\n+ }\n+ DatabaseManager::getQueryExecutor().commitTransaction();\n+ } catch (std::system_error &e) {\n+ error = e.what();\n+ DatabaseManager::getQueryExecutor().rollbackTransaction();\n+ }\n+ }\n+ operationsResult.set_value(error.size() == 0);\n+ });\n+ return operationsResultFuture.get();\n+}\n+\njsi::Value CommCoreModule::getAllThreads(jsi::Runtime &rt) {\nreturn createPromiseAsJSIValue(\nrt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "@@ -34,6 +34,9 @@ class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {\njsi::Value processMessageStoreOperations(\njsi::Runtime &rt,\nconst jsi::Array &operations) override;\n+ bool processMessageStoreOperationsSync(\n+ jsi::Runtime &rt,\n+ const jsi::Array &operations) override;\njsi::Value getAllThreads(jsi::Runtime &rt) override;\njsi::Value processThreadStoreOperations(\njsi::Runtime &rt,\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"diff": "@@ -33,6 +33,9 @@ static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllMessages(j\nstatic jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperations(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\nreturn static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->processMessageStoreOperations(rt, args[0].getObject(rt).getArray(rt));\n}\n+static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperationsSync(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\n+ return static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->processMessageStoreOperationsSync(rt, args[0].getObject(rt).getArray(rt));\n+}\nstatic jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllThreads(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\nreturn static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->getAllThreads(rt);\n}\n@@ -61,6 +64,7 @@ CommCoreModuleSchemaCxxSpecJSI::CommCoreModuleSchemaCxxSpecJSI(std::shared_ptr<C\nmethodMap_[\"removeAllDrafts\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_removeAllDrafts};\nmethodMap_[\"getAllMessages\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllMessages};\nmethodMap_[\"processMessageStoreOperations\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperations};\n+ methodMap_[\"processMessageStoreOperationsSync\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processMessageStoreOperationsSync};\nmethodMap_[\"getAllThreads\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getAllThreads};\nmethodMap_[\"processThreadStoreOperations\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processThreadStoreOperations};\nmethodMap_[\"processThreadStoreOperationsSync\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_processThreadStoreOperationsSync};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"diff": "@@ -25,6 +25,7 @@ virtual jsi::Value getAllDrafts(jsi::Runtime &rt) = 0;\nvirtual jsi::Value removeAllDrafts(jsi::Runtime &rt) = 0;\nvirtual jsi::Value getAllMessages(jsi::Runtime &rt) = 0;\nvirtual jsi::Value processMessageStoreOperations(jsi::Runtime &rt, const jsi::Array &operations) = 0;\n+virtual bool processMessageStoreOperationsSync(jsi::Runtime &rt, const jsi::Array &operations) = 0;\nvirtual jsi::Value getAllThreads(jsi::Runtime &rt) = 0;\nvirtual jsi::Value processThreadStoreOperations(jsi::Runtime &rt, const jsi::Array &operations) = 0;\nvirtual bool processThreadStoreOperationsSync(jsi::Runtime &rt, const jsi::Array &operations) = 0;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "@@ -29,6 +29,9 @@ export interface Spec extends TurboModule {\n+processMessageStoreOperations: (\noperations: $ReadOnlyArray<ClientDBMessageStoreOperation>,\n) => Promise<void>;\n+ +processMessageStoreOperationsSync: (\n+ operations: $ReadOnlyArray<ClientDBMessageStoreOperation>,\n+ ) => boolean;\n+getAllThreads: () => Promise<$ReadOnlyArray<ClientDBThreadInfo>>;\n+processThreadStoreOperations: (\noperations: $ReadOnlyArray<ClientDBThreadStoreOperation>,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Implement `processMessageStoreOperationsSync`
Summary: To be used in the redux migration
Test Plan: Will be tested with subsequent diffs
Reviewers: def-au1t, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2597 |
129,184 | 08.12.2021 22:35:31 | 18,000 | 7ee4ae47a15165357a11725bd7120d180e232fe5 | [lib] Introduce `translateClientDBMessageInfosToRawMessageInfos`
Summary: Will be used to create `messageStore.messages` "in the correct shape" from an array of `clientDBMessageInfos`
Test Plan: Will be tested with subsequent diffs
Reviewers: palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/utils/message-ops-utils.js",
"new_path": "lib/utils/message-ops-utils.js",
"diff": "@@ -82,6 +82,17 @@ function translateClientDBMessageInfoToRawMessageInfo(\n].rawMessageInfoFromClientDB(clientDBMessageInfo);\n}\n+function translateClientDBMessageInfosToRawMessageInfos(\n+ clientDBMessageInfos: $ReadOnlyArray<ClientDBMessageInfo>,\n+): { +[id: string]: RawMessageInfo } {\n+ return Object.fromEntries(\n+ clientDBMessageInfos.map((dbMessageInfo: ClientDBMessageInfo) => [\n+ dbMessageInfo.id,\n+ translateClientDBMessageInfoToRawMessageInfo(dbMessageInfo),\n+ ]),\n+ );\n+}\n+\nfunction convertMessageStoreOperationsToClientDBOperations(\nmessageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,\n): $ReadOnlyArray<ClientDBMessageStoreOperation> {\n@@ -103,5 +114,6 @@ export {\ntranslateMediaToClientDBMediaInfo,\ntranslateRawMessageInfoToClientDBMessageInfo,\ntranslateClientDBMessageInfoToRawMessageInfo,\n+ translateClientDBMessageInfosToRawMessageInfos,\nconvertMessageStoreOperationsToClientDBOperations,\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `translateClientDBMessageInfosToRawMessageInfos`
Summary: Will be used to create `messageStore.messages` "in the correct shape" from an array of `clientDBMessageInfos`
Test Plan: Will be tested with subsequent diffs
Reviewers: palys-swm, def-au1t, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2598 |
129,184 | 09.12.2021 02:23:38 | 18,000 | 23cfcb478adee6684e498e88a915d7065aaccddf | [lib] Introduce `setMessageStoreMessages` redux action
Summary: To be dispatched from `sqlite-context-provider` in future diffs to restore `messageStore.messages` persisted in SQLite.
Test Plan: Will be tested with subsequent diffs.
Reviewers: palys-swm, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/actions/message-actions.js",
"new_path": "lib/actions/message-actions.js",
"diff": "@@ -135,6 +135,7 @@ const sendMultimediaMessage = (\nconst saveMessagesActionType = 'SAVE_MESSAGES';\nconst processMessagesActionType = 'PROCESS_MESSAGES';\nconst messageStorePruneActionType = 'MESSAGE_STORE_PRUNE';\n+const setMessageStoreMessages = 'SET_MESSAGE_STORE_MESSAGES';\nexport {\nfetchMessagesBeforeCursorActionTypes,\n@@ -149,4 +150,5 @@ export {\nsaveMessagesActionType,\nprocessMessagesActionType,\nmessageStorePruneActionType,\n+ setMessageStoreMessages,\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/reducers/message-reducer.js",
"new_path": "lib/reducers/message-reducer.js",
"diff": "@@ -29,6 +29,7 @@ import {\nprocessMessagesActionType,\nmessageStorePruneActionType,\ncreateLocalMessageActionType,\n+ setMessageStoreMessages,\n} from '../actions/message-actions';\nimport {\nchangeThreadSettingsActionTypes,\n@@ -91,6 +92,7 @@ import {\n} from '../types/update-types';\nimport { setNewSessionActionType } from '../utils/action-utils';\nimport { isDev } from '../utils/dev-utils';\n+import { translateClientDBMessageInfosToRawMessageInfos } from '../utils/message-ops-utils';\nimport { assertObjectsAreEqual } from '../utils/objects';\nconst PROCESSED_MSG_STORE_INVARIANTS_DISABLED = !isDev;\n@@ -1443,6 +1445,16 @@ function reduceMessageStore(\nmessageStoreOperations,\nmessageStore: messageStoreAfterReassignment,\n};\n+ } else if (action.type === setMessageStoreMessages) {\n+ return {\n+ messageStoreOperations: [],\n+ messageStore: {\n+ ...messageStore,\n+ messages: translateClientDBMessageInfosToRawMessageInfos(\n+ action.payload,\n+ ),\n+ },\n+ };\n}\nreturn { messageStoreOperations: [], messageStore };\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/redux-types.js",
"new_path": "lib/types/redux-types.js",
"diff": "@@ -41,6 +41,7 @@ import type {\nNewMessagesPayload,\nMessageStorePrunePayload,\nLocallyComposedMessageInfo,\n+ ClientDBMessageInfo,\n} from './message-types';\nimport type { RawTextMessageInfo } from './messages/text';\nimport type { BaseNavInfo } from './nav-types';\n@@ -695,6 +696,10 @@ export type BaseAction =\n+type: 'MESSAGE_STORE_PRUNE',\n+payload: MessageStorePrunePayload,\n}\n+ | {\n+ +type: 'SET_MESSAGE_STORE_MESSAGES',\n+ +payload: $ReadOnlyArray<ClientDBMessageInfo>,\n+ }\n| {\n+type: 'SET_LATE_RESPONSE',\n+payload: SetLateResponsePayload,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Introduce `setMessageStoreMessages` redux action
Summary: To be dispatched from `sqlite-context-provider` in future diffs to restore `messageStore.messages` persisted in SQLite.
Test Plan: Will be tested with subsequent diffs.
Reviewers: palys-swm, def-au1t, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2599 |
129,184 | 09.12.2021 23:37:08 | 18,000 | fe44777bb087a7a624c860435907a36af54f63c9 | [lib] Fix `rawMessageInfoFromClientDB` to exclude `id` from local image messages
Summary: See D2601, but for image messages.
Test Plan: Our SQLite store and Redux store are no longer different
Reviewers: def-au1t, palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/messages/multimedia-message-spec.js",
"new_path": "lib/shared/messages/multimedia-message-spec.js",
"diff": "@@ -89,7 +89,6 @@ export const multimediaMessageSpec: MessageSpec<\n);\nconst rawImagesMessageInfo: RawImagesMessageInfo = {\ntype: messageTypes.IMAGES,\n- id: clientDBMessageInfo.id,\nthreadID: clientDBMessageInfo.thread,\ncreatorID: clientDBMessageInfo.user,\ntime: parseInt(clientDBMessageInfo.time),\n@@ -98,6 +97,9 @@ export const multimediaMessageSpec: MessageSpec<\nif (clientDBMessageInfo.local_id) {\nrawImagesMessageInfo.localID = clientDBMessageInfo.local_id;\n}\n+ if (clientDBMessageInfo.id !== clientDBMessageInfo.local_id) {\n+ rawImagesMessageInfo.id = clientDBMessageInfo.id;\n+ }\nreturn rawImagesMessageInfo;\n},\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/utils/message-ops-utils.test.js",
"new_path": "lib/utils/message-ops-utils.test.js",
"diff": "@@ -286,6 +286,32 @@ test('IMAGES: rawMessageInfo -> clientDBMessageInfo -> rawMessageInfo', () => {\n).toStrictEqual(rawImagesMessageInfo);\n});\n+test('IMAGES (local): rawMessageInfo -> clientDBMessageInfo -> rawMessageInfo', () => {\n+ const localRawImagesMessageInfo: RawImagesMessageInfo = {\n+ type: 14,\n+ threadID: '85466',\n+ creatorID: '85435',\n+ time: 1637779260087,\n+ media: [\n+ {\n+ id: '85504',\n+ type: 'photo',\n+ uri: 'http://localhost/comm/upload/85504/ba36cea2b5a796f6',\n+ dimensions: {\n+ width: 1920,\n+ height: 1281,\n+ },\n+ },\n+ ],\n+ localID: 'local123',\n+ };\n+ expect(\n+ translateClientDBMessageInfoToRawMessageInfo(\n+ translateRawMessageInfoToClientDBMessageInfo(localRawImagesMessageInfo),\n+ ),\n+ ).toStrictEqual(localRawImagesMessageInfo);\n+});\n+\ntest('UPDATE_RELATIONSHIP: rawMessageInfo -> clientDBMessageInfo -> rawMessageInfo', () => {\nconst rawUpdateRelationshipMessageInfo: RawUpdateRelationshipMessageInfo = {\ntype: 16,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Fix `rawMessageInfoFromClientDB` to exclude `id` from local image messages
Summary: See D2601, but for image messages.
Test Plan: Our SQLite store and Redux store are no longer different
Reviewers: def-au1t, palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2602 |
129,190 | 14.12.2021 16:24:47 | -3,600 | e3d11ac0c7e94b6fa85761d69013176b3a75bc6d | [2/n][services] Tests - backup
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/Dockerfile",
"new_path": "services/backup/docker-server/Dockerfile",
"diff": "FROM commapp/backup-base:1.0\n+ARG COMM_TEST_SERVICES\n+\nENV SHELL=/bin/bash\n+ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}\nCOPY services/backup/docker-server/contents /transferred\nCOPY native/cpp/CommonCpp/grpc/protos/backup.proto /transferred/server/protos/backup.proto\n+# todo move this to the parent Dockerfile maybe\n+RUN apk add gtest-dev\n+\nRUN /transferred/build_server.sh\n-CMD /transferred/run_server.sh && /bin/bash\n+CMD if [ \"$COMM_TEST_SERVICES\" -eq 1 ]; then /transferred/run_tests.sh; else /transferred/run_server.sh; fi\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/run_tests.sh",
"diff": "+#!/bin/bash\n+\n+set -e\n+\n+pushd transferred/server/cmake/build\n+make test ARGS=\"-V\"\n+popd # transferred/server/cmake/build\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -50,6 +50,16 @@ include_directories(\n${Boost_INCLUDE_DIR}\n)\n+set(\n+ LIBS\n+\n+ ${_GRPC_GRPCPP}\n+ ${_PROTOBUF_LIBPROTOBUF}\n+ gRPC::grpc++_reflection\n+ ${AWSSDK_LINK_LIBRARIES}\n+ ${Boost_LIBRARIES}\n+)\n+\n#SERVER\nadd_executable(\nbackup\n@@ -62,14 +72,40 @@ add_executable(\ntarget_link_libraries(\nbackup\n- ${_GRPC_GRPCPP}\n- ${_PROTOBUF_LIBPROTOBUF}\n- gRPC::grpc++_reflection\n- ${AWSSDK_LINK_LIBRARIES}\n- ${Boost_LIBRARIES}\n+ ${LIBS}\n)\ninstall(\nTARGETS backup\nRUNTIME DESTINATION bin/\n)\n+\n+# TEST\n+if ($ENV{COMM_TEST_SERVICES} MATCHES 1)\n+ file(GLOB TEST_CODE \"./test/*.cpp\")\n+ list(FILTER SOURCE_CODE EXCLUDE REGEX \"./src/server.cpp\")\n+ enable_testing()\n+\n+ find_package(GTest REQUIRED)\n+ include_directories(${GTEST_INCLUDE_DIR})\n+\n+ add_executable(\n+ runTests\n+\n+ ${GENERATED_CODE}\n+ ${SOURCE_CODE}\n+ ${TEST_CODE}\n+ )\n+ target_link_libraries(\n+ runTests\n+\n+ ${LIBS}\n+ gtest\n+ gtest_main\n+ )\n+\n+ add_test(\n+ NAME runTests\n+ COMMAND runTests\n+ )\n+endif()\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Tools.h",
"new_path": "services/backup/docker-server/contents/server/src/Tools.h",
"diff": "+#pragma once\n+\n#include <exception>\nnamespace comm {\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/test/BackupTest.cpp",
"diff": "+#include <gtest/gtest.h>\n+\n+class BackupTest : public testing::Test\n+{\n+protected:\n+ virtual void SetUp() {\n+ //...\n+ }\n+\n+ virtual void TearDown() {\n+ //...\n+ }\n+};\n+\n+TEST_F(BackupTest, passingTest)\n+{\n+ EXPECT_TRUE(true);\n+}\n+\n+TEST_F(BackupTest, failingTest) {\n+ // EXPECT_TRUE(false);\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [2/n][services] Tests - backup
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2575 |
129,190 | 14.12.2021 16:24:51 | -3,600 | 12a2e02f81b1037788ca26b84a1673809e7c5257 | [3/n][services] Tests - tunnelbroker
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/docker-server/Dockerfile",
"new_path": "services/tunnelbroker/docker-server/Dockerfile",
"diff": "FROM commapp/tunnelbroker-base:1.0\n+ARG COMM_TEST_SERVICES\n+\nENV SHELL=/bin/bash\n+ENV COMM_TEST_SERVICES=${COMM_TEST_SERVICES}\nCOPY services/tunnelbroker/docker-server/contents /transferred\nCOPY native/cpp/CommonCpp/grpc/protos/tunnelbroker.proto /transferred/server/protos/tunnelbroker.proto\n+# todo move this to the parent Dockerfile maybe\n+RUN apk add gtest-dev\n+\nRUN /transferred/build_server.sh\n-CMD /transferred/run_server.sh && /bin/bash\n+CMD if [ \"$COMM_TEST_SERVICES\" -eq 1 ]; then /transferred/run_tests.sh; else /transferred/run_server.sh; fi\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/tunnelbroker/docker-server/contents/run_tests.sh",
"diff": "+#!/bin/bash\n+\n+set -e\n+\n+pushd transferred/server/cmake/build\n+make test ARGS=\"-V\"\n+popd # transferred/server/cmake/build\n"
},
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/tunnelbroker/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -40,7 +40,7 @@ set(WITH_GFLAGS OFF CACHE BOOL \"Use gflags\" FORCE)\nadd_subdirectory(./lib/glog)\n-file(GLOB SOURCE_CODE \"./src/*.cpp\")\n+file(GLOB TUNNELBROKER_SOURCES \"./src/*.cpp\")\nfile(GLOB GENERATED_CODE \"./_generated/*.cc\")\nfile(GLOB DOUBLE_CONVERSION_SOURCES \"./lib/double-conversion/double-conversion/*.cc\")\n@@ -59,9 +59,8 @@ include_directories(\n./lib/double-conversion\n)\n-#SERVER\n-add_executable(\n- tunnelbroker\n+set(\n+ SOURCE_CODE\n# folly\n./lib/folly/folly/detail/Futex.cpp\n@@ -102,14 +101,12 @@ add_executable(\n./lib/folly/folly/memory/MallctlHelper.cpp\n${DOUBLE_CONVERSION_SOURCES}\n-\n${GENERATED_CODE}\n-\n- ${SOURCE_CODE}\n+ ${TUNNELBROKER_SOURCES}\n)\n-target_link_libraries(\n- tunnelbroker\n+set(\n+ LIBS\n${_GRPC_GRPCPP}\n${_PROTOBUF_LIBPROTOBUF}\n@@ -117,7 +114,49 @@ target_link_libraries(\nglog::glog\n)\n+#SERVER\n+add_executable(\n+ tunnelbroker\n+\n+ ${SOURCE_CODE}\n+)\n+\n+target_link_libraries(\n+ tunnelbroker\n+\n+ ${LIBS}\n+)\n+\ninstall(\nTARGETS tunnelbroker\nRUNTIME DESTINATION bin/\n)\n+\n+# TEST\n+if ($ENV{COMM_TEST_SERVICES} MATCHES 1)\n+ file(GLOB TEST_CODE \"./test/*.cpp\")\n+ list(FILTER SOURCE_CODE EXCLUDE REGEX \"./src/server.cpp\")\n+ enable_testing()\n+\n+ find_package(GTest REQUIRED)\n+ include_directories(${GTEST_INCLUDE_DIR})\n+\n+ add_executable(\n+ runTests\n+\n+ ${SOURCE_CODE}\n+ ${TEST_CODE}\n+ )\n+ target_link_libraries(\n+ runTests\n+\n+ ${LIBS}\n+ gtest\n+ gtest_main\n+ )\n+\n+ add_test(\n+ NAME runTests\n+ COMMAND runTests\n+ )\n+endif()\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/tunnelbroker/docker-server/contents/server/test/TunnelBrokerTest.cpp",
"diff": "+#include <gtest/gtest.h>\n+\n+class TunnelBrokerTest : public testing::Test\n+{\n+protected:\n+ virtual void SetUp() {\n+ //...\n+ }\n+\n+ virtual void TearDown() {\n+ //...\n+ }\n+};\n+\n+TEST_F(TunnelBrokerTest, passingTest) {\n+ EXPECT_TRUE(true);\n+}\n+\n+TEST_F(TunnelBrokerTest, failingTest) {\n+ // EXPECT_TRUE(false);\n+}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n][services] Tests - tunnelbroker
Summary: the backup part for changes from D2574
Test Plan: See D2574
Reviewers: palys-swm, geekbrother, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, benschac, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2576 |
129,179 | 14.12.2021 11:44:58 | 18,000 | 46ac8e7f39b23db322ee71a86b3097fbd92b1174 | [3/n] change default notifs from all, background, none --> Focused, Badge, Background
Summary:
change default notifs from all, background, none --> Focused, Badge, Background
{F5648}
Test Plan: go to default notifs, make sure they have the right content
Reviewers: atul, ashoat, palys-swm
Subscribers: Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "lib/types/account-types.js",
"new_path": "lib/types/account-types.js",
"diff": "@@ -163,9 +163,9 @@ export type DefaultNotificationPayload = {\n};\nexport const notificationTypes = Object.freeze({\n- ALL: 'all',\n+ FOCUSED: 'focused',\n+ BADGE_ONLY: 'badge_only',\nBACKGROUND: 'background',\n- NONE: 'none',\n});\nexport type NotificationTypes = $Values<typeof notificationTypes>;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/default-notifications-preferences.react.js",
"new_path": "native/profile/default-notifications-preferences.react.js",
"diff": "@@ -104,7 +104,7 @@ class DefaultNotificationsPreferences extends React.PureComponent<Props> {\n};\nselectAllNotifications = () => {\n- this.selectNotificationSetting(notificationTypes.ALL);\n+ this.selectNotificationSetting(notificationTypes.FOCUSED);\n};\nselectBackgroundNotifications = () => {\n@@ -112,7 +112,7 @@ class DefaultNotificationsPreferences extends React.PureComponent<Props> {\n};\nselectNoneNotifications = () => {\n- this.selectNotificationSetting(notificationTypes.NONE);\n+ this.selectNotificationSetting(notificationTypes.BADGE_ONLY);\n};\nrender() {\n@@ -125,21 +125,23 @@ class DefaultNotificationsPreferences extends React.PureComponent<Props> {\n<Text style={styles.header}>NOTIFICATIONS</Text>\n<View style={styles.section}>\n<NotificationRow\n- content=\"All\"\n+ content=\"Focused\"\nonPress={this.selectAllNotifications}\n- selected={notificationTypes.ALL === selectedDefaultNotification}\n+ selected={notificationTypes.FOCUSED === selectedDefaultNotification}\n/>\n<NotificationRow\n- content=\"Background\"\n+ content=\"Focused (badge only)\"\nonPress={this.selectBackgroundNotifications}\nselected={\n- notificationTypes.BACKGROUND === selectedDefaultNotification\n+ notificationTypes.BADGE_ONLY === selectedDefaultNotification\n}\n/>\n<NotificationRow\n- content=\"None\"\n+ content=\"Background\"\nonPress={this.selectNoneNotifications}\n- selected={notificationTypes.NONE === selectedDefaultNotification}\n+ selected={\n+ notificationTypes.BACKGROUND === selectedDefaultNotification\n+ }\n/>\n</View>\n</ScrollView>\n@@ -190,7 +192,7 @@ const ConnectedDefaultNotificationPreferences: React.ComponentType<BaseProps> =\n) {\nreturn currentUserInfo?.settings[defaultNotification];\n}\n- return notificationTypes.ALL;\n+ return notificationTypes.FOCUSED;\n},\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [3/n] change default notifs from all, background, none --> Focused, Badge, Background
Summary:
change default notifs from all, background, none --> Focused, Badge, Background
{F5648}
Test Plan: go to default notifs, make sure they have the right content
Reviewers: atul, ashoat, palys-swm
Reviewed By: ashoat
Subscribers: Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2412 |
129,179 | 06.12.2021 15:42:13 | 18,000 | 82361039b038f33cfd9a93a646b51b9394f90a2e | [10/n] [landing] move keyservers styles from landing to keyservers.css
Summary: move keyservers styles to it's own file from landing.css styles
Test Plan: Make sure keyservers styles still work as expected and didn't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/keyservers.css",
"diff": "+div.body_grid {\n+ max-width: 1920px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ column-gap: 6em;\n+ padding-left: 60px;\n+ padding-right: 60px;\n+ padding-top: 20px;\n+ padding-bottom: 40px;\n+ transition-property: max-width;\n+ transition: 300ms;\n+}\n+\n+.mono {\n+ font-family: 'iA Writer Duo S', monospace;\n+}\n+\n+span.purple_accent {\n+ color: #7e57c2;\n+}\n+\n+/* ===== CSS BODY GRID LAYOUT ===== */\n+div.body_grid {\n+ grid-template-columns: 1fr 1fr;\n+ grid-template-areas:\n+ 'hero_copy hero_image'\n+ 'server_image server_copy'\n+ 'keyserver_company keyserver_company'\n+ 'keyserver_copy read_the_docs';\n+}\n+\n+div.hero_copy {\n+ grid-area: hero_copy;\n+ align-self: center;\n+}\n+div.hero_image {\n+ grid-area: hero_image;\n+ object-fit: scale-down;\n+ align-self: center;\n+}\n+div.server_image {\n+ grid-area: server_image;\n+ object-fit: scale-down;\n+ align-self: center;\n+}\n+div.server_copy {\n+ grid-area: server_copy;\n+ align-self: center;\n+}\n+div.keyserver_company {\n+ grid-area: keyserver_company;\n+ text-align: center;\n+ padding-top: 80px;\n+}\n+div.read_the_docs {\n+ grid-area: read_the_docs;\n+ align-self: center;\n+ padding-bottom: 40px;\n+}\n+\n+/* ===== LAYOUT HACKS ===== */\n+div.body_grid > div + .starting_section {\n+ padding-top: 80px;\n+}\n+\n+.section {\n+ padding-top: 80px;\n+}\n+\n+/* ===== MEDIUM BREAKPOINT ===== */\n+@media (max-width: 1499px) {\n+ div.body_grid {\n+ padding-left: 60px;\n+ padding-right: 60px;\n+ }\n+}\n+\n+/* ===== SMALLEST BREAKPOINT ===== */\n+@media (max-width: 1099px) {\n+ /* ===== COMMON CSS GRID LAYOUT ===== */\n+ div.body_grid,\n+ div.app_landing_grid {\n+ padding-left: 3%;\n+ padding-right: 3%;\n+ grid-template-columns: minmax(auto, 540px);\n+ justify-content: center;\n+ padding-top: 0vh;\n+ padding-bottom: 2vh;\n+ }\n+\n+ /* ===== CSS BODY GRID LAYOUT ===== */\n+ div.body_grid {\n+ grid-template-areas:\n+ 'hero_image'\n+ 'hero_copy'\n+ 'server_image'\n+ 'server_copy'\n+ 'keyserver_company'\n+ 'keyserver_copy'\n+ 'read_the_docs';\n+ }\n+\n+ div.keyserver_company {\n+ text-align: left;\n+ padding-top: 60px;\n+ }\n+ .keyserver_company > h1 {\n+ font-size: 24px;\n+ }\n+ div.keyserver_copy {\n+ padding-bottom: 0;\n+ }\n+ div.read_the_docs {\n+ padding-top: 20px;\n+ padding-bottom: 0;\n+ }\n+\n+ /* ===== LAYOUT HACKS ===== */\n+ .section {\n+ padding-top: 20px;\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.react.js",
"new_path": "landing/keyservers.react.js",
"diff": "@@ -4,7 +4,7 @@ import { create } from '@lottiefiles/lottie-interactivity';\nimport * as React from 'react';\nimport { assetUrl } from './asset-meta-data';\n-import css from './landing.css';\n+import css from './keyservers.css';\nimport ReadDocsButton from './read-docs-btn.react';\nimport StarBackground from './star-background.react';\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -29,10 +29,6 @@ a {\ntext-decoration: none;\n}\n-.mono {\n- font-family: 'iA Writer Duo S', monospace;\n-}\n-\n.no_bottom_margin {\nmargin-bottom: 0;\n}\n@@ -84,12 +80,7 @@ p.app_landing_subheading {\npadding-inline: 0px;\n}\n-span.purple_accent {\n- color: #7e57c2;\n-}\n-\n/* ===== COMMON CSS GRID LAYOUT ===== */\n-div.body_grid,\ndiv.app_landing_grid {\nmax-width: 1920px;\nmargin-left: auto;\n@@ -104,45 +95,6 @@ div.app_landing_grid {\ntransition: 300ms;\n}\n-/* ===== CSS BODY GRID LAYOUT ===== */\n-div.body_grid {\n- grid-template-columns: 1fr 1fr;\n- grid-template-areas:\n- 'hero_copy hero_image'\n- 'server_image server_copy'\n- 'keyserver_company keyserver_company'\n- 'keyserver_copy read_the_docs';\n-}\n-\n-div.hero_copy {\n- grid-area: hero_copy;\n- align-self: center;\n-}\n-div.hero_image {\n- grid-area: hero_image;\n- object-fit: scale-down;\n- align-self: center;\n-}\n-div.server_image {\n- grid-area: server_image;\n- object-fit: scale-down;\n- align-self: center;\n-}\n-div.server_copy {\n- grid-area: server_copy;\n- align-self: center;\n-}\n-div.keyserver_company {\n- grid-area: keyserver_company;\n- text-align: center;\n- padding-top: 80px;\n-}\n-div.read_the_docs {\n- grid-area: read_the_docs;\n- align-self: center;\n- padding-bottom: 40px;\n-}\n-\n/* ===== APP LANDING GRID ===== */\ndiv.app_landing_grid {\ngrid-template-columns: 2fr 3fr;\n@@ -291,15 +243,6 @@ div.legal_container a:hover {\ncolor: #8c69c9;\n}\n-/* ===== LAYOUT HACKS ===== */\n-div.body_grid > div + .starting_section {\n- padding-top: 80px;\n-}\n-\n-.section {\n- padding-top: 80px;\n-}\n-\n/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n@media (max-width: 1699px) {\ndiv.tile_title_row > p.tile_title {\n@@ -313,10 +256,6 @@ div.body_grid > div + .starting_section {\n/* ===== MEDIUM BREAKPOINT ===== */\n@media (max-width: 1499px) {\n- div.body_grid {\n- padding-left: 60px;\n- padding-right: 60px;\n- }\nh1 {\nfont-size: 42px;\n}\n@@ -378,7 +317,6 @@ div.body_grid > div + .starting_section {\n}\n/* ===== COMMON CSS GRID LAYOUT ===== */\n- div.body_grid,\ndiv.app_landing_grid {\npadding-left: 3%;\npadding-right: 3%;\n@@ -388,33 +326,6 @@ div.body_grid > div + .starting_section {\npadding-bottom: 2vh;\n}\n- /* ===== CSS BODY GRID LAYOUT ===== */\n- div.body_grid {\n- grid-template-areas:\n- 'hero_image'\n- 'hero_copy'\n- 'server_image'\n- 'server_copy'\n- 'keyserver_company'\n- 'keyserver_copy'\n- 'read_the_docs';\n- }\n-\n- div.keyserver_company {\n- text-align: left;\n- padding-top: 60px;\n- }\n- .keyserver_company > h1 {\n- font-size: 24px;\n- }\n- div.keyserver_copy {\n- padding-bottom: 0;\n- }\n- div.read_the_docs {\n- padding-top: 20px;\n- padding-bottom: 0;\n- }\n-\n/* ===== APP LANDING GRID LAYOUT ===== */\ndiv.app_landing_grid {\ngrid-template-areas:\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [10/n] [landing] move keyservers styles from landing to keyservers.css
Summary: move keyservers styles to it's own file from landing.css styles
Test Plan: Make sure keyservers styles still work as expected and didn't break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2563 |
129,179 | 06.12.2021 15:57:25 | 18,000 | 557c28c3d43562259999798677ad5d0e38790ac5 | [11/n] [landing] move legal styles from landing to legal.css
Summary: Move all legal styles from landing.css to legal.css
Test Plan: Make sure legal styles are not broken on terms, support, privacy policy pages
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -218,31 +218,6 @@ div.tile_six {\ngrid-area: tile_six;\n}\n-/* ===== LEGAL PAGE STYLING ===== */\n-div.legal_container {\n- max-width: 1080px;\n- margin-left: auto;\n- margin-right: auto;\n- padding-left: 60px;\n- padding-right: 60px;\n-}\n-div.legal_container h1 {\n- font-size: 42px;\n-}\n-div.legal_container h2 {\n- font-size: 38px;\n-}\n-div.legal_container p,\n-li {\n- font-size: 20px;\n-}\n-div.legal_container a {\n- color: #7e57c2;\n-}\n-div.legal_container a:hover {\n- color: #8c69c9;\n-}\n-\n/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n@media (max-width: 1699px) {\ndiv.tile_title_row > p.tile_title {\n@@ -266,14 +241,6 @@ div.legal_container a:hover {\nli {\nfont-size: 18px;\n}\n- /* ===== LEGAL PAGE STYLING ===== */\n- div.legal_container h1 {\n- font-size: 28px;\n- }\n- div.legal_container h2 {\n- font-size: 24px;\n- }\n- div.legal_container p,\nli {\nfont-size: 16px;\n}\n@@ -393,11 +360,4 @@ div.legal_container a:hover {\n.section {\npadding-top: 20px;\n}\n-\n- /* ===== LEGAL PAGE STYLING ===== */\n- div.legal_container {\n- max-width: 540px;\n- padding-left: 3%;\n- padding-right: 3%;\n- }\n}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/legal.css",
"diff": "+/* ===== LEGAL PAGE STYLING ===== */\n+div.legal_container {\n+ max-width: 1080px;\n+ margin-left: auto;\n+ margin-right: auto;\n+ padding-left: 60px;\n+ padding-right: 60px;\n+}\n+div.legal_container h1 {\n+ font-size: 42px;\n+}\n+div.legal_container h2 {\n+ font-size: 38px;\n+}\n+div.legal_container p,\n+li {\n+ font-size: 20px;\n+}\n+div.legal_container a {\n+ color: #7e57c2;\n+}\n+div.legal_container a:hover {\n+ color: #8c69c9;\n+}\n+\n+/* ===== MEDIUM BREAKPOINT ===== */\n+@media (max-width: 1499px) {\n+ /* ===== LEGAL PAGE STYLING ===== */\n+ div.legal_container h1 {\n+ font-size: 28px;\n+ }\n+ div.legal_container h2 {\n+ font-size: 24px;\n+ }\n+ div.legal_container p {\n+ font-size: 16px;\n+ }\n+}\n+\n+/* ===== SMALLEST BREAKPOINT ===== */\n+@media (max-width: 1099px) {\n+ /* ===== LEGAL PAGE STYLING ===== */\n+ div.legal_container {\n+ max-width: 540px;\n+ padding-left: 3%;\n+ padding-right: 3%;\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/privacy.react.js",
"new_path": "landing/privacy.react.js",
"diff": "import * as React from 'react';\n-import css from './landing.css';\n+import css from './legal.css';\nfunction Privacy(): React.Node {\nreturn (\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/support.react.js",
"new_path": "landing/support.react.js",
"diff": "import * as React from 'react';\n-import css from './landing.css';\n+import css from './legal.css';\nfunction Support(): React.Node {\nreturn (\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/terms.react.js",
"new_path": "landing/terms.react.js",
"diff": "import * as React from 'react';\n-import css from './landing.css';\n+import css from './legal.css';\nfunction Terms(): React.Node {\nreturn (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [11/n] [landing] move legal styles from landing to legal.css
Summary: Move all legal styles from landing.css to legal.css
Test Plan: Make sure legal styles are not broken on terms, support, privacy policy pages
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2564 |
129,179 | 06.12.2021 16:27:10 | 18,000 | c0bc1f98b19afc25920e3ce60623bbd63435dfa2 | [13/n] [landing] move info-card styles into info-card.css
Summary: move infocard styles from landing to info-card.css
Test Plan: make sure styles load and page isn't broken
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/info-card.css",
"diff": "+div.tile_title_row {\n+ display: flex;\n+ flex-direction: row;\n+ align-items: center;\n+ align-content: center;\n+ justify-content: flex-start;\n+ margin-left: 20px;\n+ margin-right: 20px;\n+ padding-bottom: 20px;\n+}\n+\n+.info_card {\n+ display: flex;\n+ padding: 36px;\n+ border-radius: 8px;\n+ background-color: #ebedee;\n+ justify-content: center;\n+ flex-direction: column;\n+ transition: 300ms;\n+ background-color: rgba(0, 0, 0, 0.35);\n+ backdrop-filter: none;\n+ -webkit-backdrop-filter: blur(2px);\n+ transition: 300ms;\n+}\n+\n+.description {\n+ font-size: 22px;\n+ text-align: left;\n+ margin-top: 0px;\n+ margin-bottom: 0px;\n+ margin-left: 20px;\n+ margin-right: 20px;\n+}\n+\n+div.tile_title_row > p.tile_title {\n+ font-family: 'iA Writer Duo S', monospace;\n+ font-weight: bold;\n+ font-size: 36px;\n+ transition: 300ms;\n+}\n+\n+/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n+@media (max-width: 1699px) {\n+ div.tile_title_row > p.tile_title {\n+ font-size: 30px;\n+ }\n+}\n+\n+/* ===== MEDIUM BREAKPOINT ===== */\n+@media (max-width: 1499px) {\n+ .description {\n+ font-size: 16px;\n+ }\n+\n+ div.tile_title_row > p.tile_title {\n+ font-size: 24px;\n+ }\n+}\n+\n+/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n+@media (max-width: 1299px) {\n+ div.tile_title_row > p.tile_title {\n+ font-size: 22px;\n+ }\n+}\n+\n+/* ===== SMALLEST BREAKPOINT ===== */\n+@media (max-width: 1099px) {\n+ div.tile_title_row > p.tile_title {\n+ font-size: 20px;\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "import * as React from 'react';\n-import css from './landing.css';\n+import css from './info-card.css';\ntype InfoCardProps = {\n+title: string,\n@@ -13,11 +13,11 @@ function InfoCard(props: InfoCardProps): React.Node {\nconst { title, description, baseStyle } = props;\nreturn (\n- <div className={baseStyle}>\n+ <div className={`${baseStyle} ${css.info_card}`}>\n<div className={css.tile_title_row}>\n<p className={css.tile_title}>{title}</p>\n</div>\n- <p>{description}</p>\n+ <p className={css.description}>{description}</p>\n</div>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -94,49 +94,6 @@ div.tile_grid {\n'tile_six';\n}\n-div.tile_grid > div {\n- display: flex;\n- padding: 36px;\n- border-radius: 8px;\n- background-color: #ebedee;\n- justify-content: center;\n- flex-direction: column;\n- transition: 300ms;\n- background-color: rgba(0, 0, 0, 0.35);\n- backdrop-filter: none;\n- -webkit-backdrop-filter: blur(2px);\n- transition: 300ms;\n-}\n-\n-div.tile_title_row {\n- display: flex;\n- flex-direction: row;\n- align-items: center;\n- align-content: center;\n- justify-content: flex-start;\n- margin-left: 20px;\n- margin-right: 20px;\n- padding-bottom: 20px;\n-}\n-\n-div.tile_title_row > p.tile_title {\n- font-family: 'iA Writer Duo S', monospace;\n- font-weight: bold;\n- font-size: 36px;\n- transition: 300ms;\n-}\n-\n-div.tile_grid > div p {\n- font-size: 22px;\n- color: white;\n- text-align: left;\n- margin-top: 0px;\n- margin-bottom: 0px;\n- margin-left: 20px;\n- margin-right: 20px;\n- transition: 300ms;\n-}\n-\ndiv.tile_one {\ngrid-area: tile_one;\n}\n@@ -158,10 +115,6 @@ div.tile_six {\n/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n@media (max-width: 1699px) {\n- div.tile_title_row > p.tile_title {\n- font-size: 30px;\n- }\n-\nh1.cycling_header {\nfont-size: 44px;\n}\n@@ -170,13 +123,6 @@ div.tile_six {\n/* ===== MEDIUM BREAKPOINT ===== */\n@media (max-width: 1499px) {\n/* ===== APP LANDING GRID STYLING ===== */\n- div.tile_grid > div p {\n- font-size: 16px;\n- }\n-\n- div.tile_title_row > p.tile_title {\n- font-size: 24px;\n- }\nh1.cycling_header {\nfont-size: 38px;\n@@ -185,10 +131,6 @@ div.tile_six {\n/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n@media (max-width: 1299px) {\n- div.tile_title_row > p.tile_title {\n- font-size: 22px;\n- }\n-\nh1.cycling_header {\nfont-size: 30px;\n}\n@@ -265,10 +207,6 @@ div.tile_six {\npadding-bottom: 4vh;\n}\n- div.tile_title_row > p.tile_title {\n- font-size: 20px;\n- }\n-\n/* ===== LAYOUT HACKS ===== */\n.section {\npadding-top: 20px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [13/n] [landing] move info-card styles into info-card.css
Summary: move infocard styles from landing to info-card.css
Test Plan: make sure styles load and page isn't broken
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2566 |
129,179 | 06.12.2021 16:38:16 | 18,000 | a062da1aaefae8d7e1083e675bb6d3c3279e0e74 | [14/n] [landing] move cycling header css to cycling-header.css
Summary: move cycling header styles to cycling-header.css
Test Plan: make sure styles dont break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/cycling-header.css",
"diff": "+h1.cycling_header {\n+ font-family: 'iA Writer Duo S', monospace;\n+ font-size: 50px;\n+ margin: 0;\n+ white-space: pre-wrap;\n+}\n+\n+.app_landing_subheading {\n+ font-weight: bold;\n+ padding-inline: 4px;\n+}\n+\n+span.app_landing_subheading {\n+ background-color: #7e57c2;\n+}\n+\n+p.app_landing_subheading {\n+ font-family: 'iA Writer Duo S', monospace;\n+ color: #7e57c2;\n+ font-size: 32px;\n+ padding-inline: 0px;\n+}\n+\n+/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n+@media (max-width: 1699px) {\n+ h1.cycling_header {\n+ font-size: 44px;\n+ }\n+}\n+\n+/* ===== MEDIUM BREAKPOINT ===== */\n+@media (max-width: 1499px) {\n+ h1.cycling_header {\n+ font-size: 38px;\n+ }\n+}\n+\n+/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n+@media (max-width: 1299px) {\n+ h1.cycling_header {\n+ font-size: 30px;\n+ }\n+}\n+\n+/* ===== SMALLEST BREAKPOINT ===== */\n+@media (max-width: 1099px) {\n+ h1.cycling_header {\n+ font-family: 'iA Writer Duo S', monospace;\n+ margin-top: 4vh;\n+ font-size: 22px;\n+ text-align: center;\n+ }\n+\n+ .app_landing_subheading {\n+ margin-bottom: 6vh;\n+ text-align: center;\n+ }\n+\n+ p.app_landing_subheading {\n+ font-size: 18px;\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/cycling-header.react.js",
"new_path": "landing/cycling-header.react.js",
"diff": "import * as React from 'react';\nimport TextLoop from 'react-text-loop';\n-import css from './landing.css';\n+import css from './cycling-header.css';\nfunction CyclingHeader(): React.Node {\nreturn (\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "@@ -69,13 +69,6 @@ div.app_copy {\njustify-content: center;\n}\n-h1.cycling_header {\n- font-family: 'iA Writer Duo S', monospace;\n- font-size: 50px;\n- margin: 0;\n- white-space: pre-wrap;\n-}\n-\n/* ===== TILE GRID STYLING ===== */\ndiv.tile_grid {\ndisplay: grid;\n@@ -113,29 +106,6 @@ div.tile_six {\ngrid-area: tile_six;\n}\n-/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n-@media (max-width: 1699px) {\n- h1.cycling_header {\n- font-size: 44px;\n- }\n-}\n-\n-/* ===== MEDIUM BREAKPOINT ===== */\n-@media (max-width: 1499px) {\n- /* ===== APP LANDING GRID STYLING ===== */\n-\n- h1.cycling_header {\n- font-size: 38px;\n- }\n-}\n-\n-/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n-@media (max-width: 1299px) {\n- h1.cycling_header {\n- font-size: 30px;\n- }\n-}\n-\n/* ===== SMALLEST BREAKPOINT ===== */\n@media (max-width: 1099px) {\n/* ===== COMMON CSS GRID LAYOUT ===== */\n@@ -175,13 +145,6 @@ div.tile_six {\njustify-self: center;\n}\n- h1.cycling_header {\n- font-family: 'iA Writer Duo S', monospace;\n- margin-top: 4vh;\n- font-size: 22px;\n- text-align: center;\n- }\n-\n.app_landing_subheading {\nmargin-bottom: 6vh;\ntext-align: center;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [14/n] [landing] move cycling header css to cycling-header.css
Summary: move cycling header styles to cycling-header.css
Test Plan: make sure styles dont break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2567 |
129,179 | 06.12.2021 18:10:37 | 18,000 | 5f56882611a9d1d15b58905eb457fbb6874167af | [15/n] [landing] remove dead code in landing
Summary: code was never used
Test Plan: N/A double check via grep
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "-.no_bottom_margin {\n- margin-bottom: 0;\n-}\n-\n.app_landing_subheading {\nfont-weight: bold;\npadding-inline: 4px;\n@@ -169,9 +165,4 @@ div.tile_six {\ndiv.tile_grid {\npadding-bottom: 4vh;\n}\n-\n- /* ===== LAYOUT HACKS ===== */\n- .section {\n- padding-top: 20px;\n- }\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [15/n] [landing] remove dead code in landing
Summary: code was never used
Test Plan: N/A double check via grep
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2568 |
129,179 | 06.12.2021 19:39:48 | 18,000 | a8a4c32d06099808c28f655fcefcc7032ac4e8f2 | [16/n] [landing] move hero sub header into cycling header
Summary: Move subheading content into cycling text component. Will turn it into a hero content component next diff
Test Plan: Make sure styles don't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -32,11 +32,7 @@ function AppLanding(): React.Node {\n<div className={css.app_copy}>\n<div className={css.app_copy_wrapper}>\n<CyclingHeader />\n- <p className={css.app_landing_subheading}>\n- (think "Web3 Discord")\n- </p>\n</div>\n-\n<div className={css.tile_grid}>\n<InfoCard\ntitle={federated.title}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/cycling-header.react.js",
"new_path": "landing/cycling-header.react.js",
"diff": "@@ -7,9 +7,13 @@ import css from './cycling-header.css';\nfunction CyclingHeader(): React.Node {\nreturn (\n+ <>\n<h1 className={css.cycling_header}>\n{'Comm is crypto-native\\nchat for '}\n- <TextLoop interval={1750} springConfig={{ stiffness: 180, damping: 16 }}>\n+ <TextLoop\n+ interval={1750}\n+ springConfig={{ stiffness: 180, damping: 16 }}\n+ >\n<span className={css.app_landing_subheading}>DAOs</span>\n<span className={css.app_landing_subheading}>art collectives</span>\n<span className={css.app_landing_subheading}>venture funds</span>\n@@ -18,6 +22,10 @@ function CyclingHeader(): React.Node {\n<span className={css.app_landing_subheading}>social clubs</span>\n</TextLoop>\n</h1>\n+ <p className={css.app_landing_subheading}>\n+ (think "Web3 Discord")\n+ </p>\n+ </>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "-.app_landing_subheading {\n- font-weight: bold;\n- padding-inline: 4px;\n-}\n-\n-span.app_landing_subheading {\n- background-color: #7e57c2;\n-}\n-\n-p.app_landing_subheading {\n- font-family: 'iA Writer Duo S', monospace;\n- color: #7e57c2;\n- font-size: 32px;\n- padding-inline: 0px;\n-}\n-\n/* ===== COMMON CSS GRID LAYOUT ===== */\ndiv.app_landing_grid {\nmax-width: 1920px;\n@@ -141,15 +125,6 @@ div.tile_six {\njustify-self: center;\n}\n- .app_landing_subheading {\n- margin-bottom: 6vh;\n- text-align: center;\n- }\n-\n- p.app_landing_subheading {\n- font-size: 18px;\n- }\n-\ndiv.tile_grid {\nrow-gap: 4vh;\npadding-left: 3%;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [16/n] [landing] move hero sub header into cycling header
Summary: Move subheading content into cycling text component. Will turn it into a hero content component next diff
Test Plan: Make sure styles don't break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, atul, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2569 |
129,179 | 06.12.2021 20:27:54 | 18,000 | c9b4ddd33d058655c31beb31ff737709c3ed2030 | [18/n] [landing] remove old layout on landing app
Summary: remove html + css layout styles and structure
Test Plan: Layout should look broken and in non-functional state
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "import * as React from 'react';\nimport { assetMetaData } from './asset-meta-data';\n-import CyclingHeader from './cycling-header.react';\n+import HeroContent from './hero-content.react';\nimport InfoCard from './info-card.react';\n-import css from './landing.css';\nimport Picture from './Picture.react';\nimport StarBackground from './star-background.react';\nimport usePreloadAssets from './use-pre-load-assets.react';\n@@ -25,47 +24,17 @@ function AppLanding(): React.Node {\nreturn (\n<>\n<StarBackground />\n- <div className={css.app_landing_grid}>\n- <div className={css.app_preview}>\n<Picture url={hero.url} alt={hero.alt} />\n- </div>\n- <div className={css.app_copy}>\n- <div className={css.app_copy_wrapper}>\n- <CyclingHeader />\n- </div>\n- <div className={css.tile_grid}>\n- <InfoCard\n- title={federated.title}\n- description={federated.description}\n- />\n-\n+ <HeroContent />\n+ <InfoCard title={federated.title} description={federated.description} />\n<InfoCard\ntitle={customizable.title}\ndescription={customizable.description}\n/>\n-\n- <InfoCard\n- title={encrypted.title}\n- description={encrypted.description}\n- />\n-\n- <InfoCard\n- title={sovereign.title}\n- description={sovereign.description}\n- />\n-\n- <InfoCard\n- title={openSource.title}\n- description={openSource.description}\n- />\n-\n- <InfoCard\n- title={lessNoisy.title}\n- description={lessNoisy.description}\n- />\n- </div>\n- </div>\n- </div>\n+ <InfoCard title={encrypted.title} description={encrypted.description} />\n+ <InfoCard title={sovereign.title} description={sovereign.description} />\n+ <InfoCard title={openSource.title} description={openSource.description} />\n+ <InfoCard title={lessNoisy.title} description={lessNoisy.description} />\n</>\n);\n}\n"
},
{
"change_type": "RENAME",
"old_path": "landing/cycling-header.css",
"new_path": "landing/hero-content.css",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "landing/cycling-header.react.js",
"new_path": "landing/hero-content.react.js",
"diff": "import * as React from 'react';\nimport TextLoop from 'react-text-loop';\n-import css from './cycling-header.css';\n+import css from './hero-content.css';\n-function CyclingHeader(): React.Node {\n+function HeroContent(): React.Node {\nreturn (\n<>\n<h1 className={css.cycling_header}>\n@@ -29,4 +29,4 @@ function CyclingHeader(): React.Node {\n);\n}\n-export default CyclingHeader;\n+export default HeroContent;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "-/* ===== COMMON CSS GRID LAYOUT ===== */\n-div.app_landing_grid {\n- max-width: 1920px;\n- margin-left: auto;\n- margin-right: auto;\n- display: grid;\n- column-gap: 6em;\n- padding-left: 60px;\n- padding-right: 60px;\n- padding-top: 20px;\n- padding-bottom: 40px;\n- transition-property: max-width;\n- transition: 300ms;\n-}\n-\n-/* ===== APP LANDING GRID ===== */\n-div.app_landing_grid {\n- grid-template-columns: 2fr 3fr;\n- grid-template-areas: 'app_preview app_copy';\n- padding-top: 6vh;\n- padding-bottom: 8vh;\n-}\n-\n-div.app_preview {\n- grid-area: app_preview;\n- justify-self: right;\n-}\n-\n-div.app_preview img {\n- min-height: 560px;\n- max-height: 70vh;\n- max-width: 30vw;\n- object-fit: scale-down;\n- position: sticky;\n- top: 18vh;\n- left: 0;\n-}\n-\n-div.app_copy {\n- grid-area: app_copy;\n- align-self: center;\n- justify-self: left;\n-}\n-\n-.app_copy_wrapper {\n- height: 70vh;\n- display: flex;\n- flex-direction: column;\n- justify-content: center;\n-}\n-\n-/* ===== TILE GRID STYLING ===== */\n-div.tile_grid {\n- display: grid;\n- margin-right: 16%;\n- grid-template-columns: 1fr;\n- grid-template-rows: 1fr 1fr 1fr 1fr 1fr 1fr;\n- row-gap: 36vh;\n- margin-top: 32vh;\n- margin-bottom: 36vh;\n- grid-template-areas:\n- 'tile_one'\n- 'tile_two'\n- 'tile_three'\n- 'tile_four'\n- 'tile_five'\n- 'tile_six';\n-}\n-\n-div.tile_one {\n- grid-area: tile_one;\n-}\n-div.tile_two {\n- grid-area: tile_two;\n-}\n-div.tile_three {\n- grid-area: tile_three;\n-}\n-div.tile_four {\n- grid-area: tile_four;\n-}\n-div.tile_five {\n- grid-area: tile_five;\n-}\n-div.tile_six {\n- grid-area: tile_six;\n-}\n-\n-/* ===== SMALLEST BREAKPOINT ===== */\n-@media (max-width: 1099px) {\n- /* ===== COMMON CSS GRID LAYOUT ===== */\n- div.app_landing_grid {\n- padding-left: 3%;\n- padding-right: 3%;\n- grid-template-columns: minmax(auto, 540px);\n- justify-content: center;\n- padding-top: 0vh;\n- padding-bottom: 2vh;\n- }\n-\n- /* ===== APP LANDING GRID LAYOUT ===== */\n- div.app_landing_grid {\n- grid-template-areas:\n- 'app_preview'\n- 'app_copy';\n- }\n-\n- div.app_preview {\n- grid-area: app_preview;\n- align-self: center;\n- justify-self: center;\n- }\n- div.app_preview img {\n- max-height: 92vh;\n- max-width: 96vw;\n- }\n-\n- .app_copy_wrapper {\n- height: 30vh;\n- }\n-\n- div.app_copy {\n- grid-area: app_copy;\n- align-self: center;\n- justify-self: center;\n- }\n-\n- div.tile_grid {\n- row-gap: 4vh;\n- padding-left: 3%;\n- padding-right: 3%;\n- grid-template-columns: minmax(auto, 540px);\n- justify-content: center;\n- }\n-\n- div.app_copy div.tile_grid {\n- margin: 0;\n- }\n-\n- div.tile_grid {\n- padding-bottom: 4vh;\n- }\n-}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [18/n] [landing] remove old layout on landing app
Summary: remove html + css layout styles and structure
Test Plan: Layout should look broken and in non-functional state
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2572 |
129,179 | 07.12.2021 09:01:35 | 18,000 | 132f262b9be8fc7ced0bd277cca7f037fac1f885 | [20/n] [landing] add picture to infoblock component
Summary: Move picture into info-block component meet requirements on design
Test Plan: Make sure images are rendering.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -26,15 +26,12 @@ function AppLanding(): React.Node {\n<StarBackground />\n<Picture url={hero.url} alt={hero.alt} />\n<HeroContent />\n- <InfoCard title={federated.title} description={federated.description} />\n- <InfoCard\n- title={customizable.title}\n- description={customizable.description}\n- />\n- <InfoCard title={encrypted.title} description={encrypted.description} />\n- <InfoCard title={sovereign.title} description={sovereign.description} />\n- <InfoCard title={openSource.title} description={openSource.description} />\n- <InfoCard title={lessNoisy.title} description={lessNoisy.description} />\n+ <InfoCard {...federated} />\n+ <InfoCard {...customizable} />\n+ <InfoCard {...encrypted} />\n+ <InfoCard {...sovereign} />\n+ <InfoCard {...openSource} />\n+ <InfoCard {...lessNoisy} />\n</>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-card.react.js",
"diff": "import * as React from 'react';\nimport css from './info-card.css';\n+import Picture from './Picture.react';\ntype InfoCardProps = {\n+title: string,\n+description: string,\n+ +url: string,\n+ +alt: string,\n};\nfunction InfoCard(props: InfoCardProps): React.Node {\n- const { title, description } = props;\n+ const { title, description, url, alt } = props;\nreturn (\n<div className={css.info_card}>\n+ <Picture {...{ url, alt }} />\n<div className={css.tile_title_row}>\n<p className={css.tile_title}>{title}</p>\n</div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [20/n] [landing] add picture to infoblock component
Summary: Move picture into info-block component meet requirements on design
Test Plan: Make sure images are rendering.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2577 |
129,179 | 07.12.2021 09:13:12 | 18,000 | 7eb04c13579f8a6fd917baae67e2a5307377b7e0 | [21/n] [landing] fix typo in asset file
Summary: Image URL is broken, remove typo
Test Plan: make sure image renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/asset-meta-data.js",
"new_path": "landing/asset-meta-data.js",
"diff": "@@ -18,7 +18,7 @@ export const assetMetaData = [\n},\n{\nalt: 'a web app screen highlighting web3 apps in Comm',\n- url: `${assetUrl}/'Customizable`,\n+ url: `${assetUrl}/Customizable`,\ntitle: 'Customizable',\ndescription: `Write mini-apps and custom modules in React.\nSkin your community. Customize your tabs and your home page.`,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [21/n] [landing] fix typo in asset file
Summary: Image URL is broken, remove typo
Test Plan: make sure image renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2578 |
129,179 | 07.12.2021 10:32:33 | 18,000 | ce3f9263cef2e310e040a2da9c8ae79281882e55 | [22/n] [landing] add css reset, apply spacing where broken
Summary: add reset with generic spacing where reset has stripped it.
Test Plan: Make sure header, footer keyserver and legal pages all look reasonable.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "@@ -16,6 +16,7 @@ nav.wrapper {\nmargin-left: auto;\nmargin-right: auto;\ndisplay: grid;\n+ padding: 16px 0;\nalign-items: center;\ngrid-template-columns: 40px repeat(12, 1fr) 40px;\ncolumn-gap: 1.5%;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/keyservers.css",
"new_path": "landing/keyservers.css",
"diff": "@@ -14,6 +14,11 @@ div.body_grid {\n.mono {\nfont-family: 'iA Writer Duo S', monospace;\n+ padding-bottom: 24px;\n+}\n+\n+.mono + p {\n+ padding-bottom: 24px;\n}\nspan.purple_accent {\n@@ -53,6 +58,10 @@ div.keyserver_company {\ntext-align: center;\npadding-top: 80px;\n}\n+\n+.keyserver_company > h1 {\n+ padding-bottom: 24px;\n+}\ndiv.read_the_docs {\ngrid-area: read_the_docs;\nalign-self: center;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "@@ -11,6 +11,7 @@ import Privacy from './privacy.react';\nimport Support from './support.react';\nimport Terms from './terms.react';\nimport useScrollToTopOnNavigate from './use-scroll-to-top-on-navigate.react';\n+import './reset.css';\nimport './global.css';\nexport type LandingPageName =\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/legal.css",
"new_path": "landing/legal.css",
"diff": "@@ -8,13 +8,16 @@ div.legal_container {\n}\ndiv.legal_container h1 {\nfont-size: 42px;\n+ padding-bottom: 24px;\n}\ndiv.legal_container h2 {\nfont-size: 38px;\n+ padding-bottom: 24px;\n}\ndiv.legal_container p,\nli {\nfont-size: 20px;\n+ padding-bottom: 16px;\n}\ndiv.legal_container a {\ncolor: #7e57c2;\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/reset.css",
"diff": "+/* https://www.joshwcomeau.com/css/custom-css-reset/ */\n+\n+/*\n+ 1. Use a more-intuitive box-sizing model.\n+*/\n+*,\n+*::before,\n+*::after {\n+ box-sizing: border-box;\n+}\n+/*\n+ 2. Remove default margin\n+*/\n+* {\n+ margin: 0;\n+}\n+/*\n+ 3. Allow percentage-based heights in the application\n+*/\n+html,\n+body {\n+ height: 100%;\n+}\n+/*\n+ Typographic tweaks!\n+ 4. Add accessible line-height\n+ 5. Improve text rendering\n+*/\n+body {\n+ line-height: 1.5;\n+ -webkit-font-smoothing: antialiased;\n+}\n+/*\n+ 6. Improve media defaults\n+*/\n+img,\n+picture,\n+video,\n+canvas,\n+svg {\n+ display: block;\n+ max-width: 100%;\n+}\n+/*\n+ 7. Remove built-in form typography styles\n+*/\n+input,\n+button,\n+textarea,\n+select {\n+ font: inherit;\n+}\n+/*\n+ 8. Avoid text overflows\n+*/\n+p,\n+h1,\n+h2,\n+h3,\n+h4,\n+h5,\n+h6 {\n+ overflow-wrap: break-word;\n+}\n+/*\n+ 9. Create a root stacking context\n+*/\n+#react-root {\n+ isolation: isolate;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/subscription-form.css",
"new_path": "landing/subscription-form.css",
"diff": "@@ -5,7 +5,6 @@ form {\n.button {\nposition: relative;\nwidth: auto;\n- height: 50px;\nborder: 1px solid white;\nborder-radius: 8px;\nborder-left: none;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [22/n] [landing] add css reset, apply spacing where broken
Summary: add reset with generic spacing where reset has stripped it.
Test Plan: Make sure header, footer keyserver and legal pages all look reasonable.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2579 |
129,179 | 07.12.2021 10:45:11 | 18,000 | 99b7ad1f6105be702313ca4d3ac8f69fff7ee443 | [23/n] [landing] change name infocard --> infoblock
Summary: Info card should be a block per the design.
Test Plan: make sure code runs
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -4,7 +4,7 @@ import * as React from 'react';\nimport { assetMetaData } from './asset-meta-data';\nimport HeroContent from './hero-content.react';\n-import InfoCard from './info-card.react';\n+import InfoBlock from './info-block.react';\nimport Picture from './Picture.react';\nimport StarBackground from './star-background.react';\nimport usePreloadAssets from './use-pre-load-assets.react';\n@@ -26,12 +26,12 @@ function AppLanding(): React.Node {\n<StarBackground />\n<Picture url={hero.url} alt={hero.alt} />\n<HeroContent />\n- <InfoCard {...federated} />\n- <InfoCard {...customizable} />\n- <InfoCard {...encrypted} />\n- <InfoCard {...sovereign} />\n- <InfoCard {...openSource} />\n- <InfoCard {...lessNoisy} />\n+ <InfoBlock {...federated} />\n+ <InfoBlock {...customizable} />\n+ <InfoBlock {...encrypted} />\n+ <InfoBlock {...sovereign} />\n+ <InfoBlock {...openSource} />\n+ <InfoBlock {...lessNoisy} />\n</>\n);\n}\n"
},
{
"change_type": "RENAME",
"old_path": "landing/info-card.css",
"new_path": "landing/info-block.css",
"diff": "@@ -9,7 +9,7 @@ div.tile_title_row {\npadding-bottom: 20px;\n}\n-.info_card {\n+.info_block {\ndisplay: flex;\npadding: 36px;\nborder-radius: 8px;\n"
},
{
"change_type": "RENAME",
"old_path": "landing/info-card.react.js",
"new_path": "landing/info-block.react.js",
"diff": "import * as React from 'react';\n-import css from './info-card.css';\n+import css from './info-block.css';\nimport Picture from './Picture.react';\n-type InfoCardProps = {\n+type InfoBlockProps = {\n+title: string,\n+description: string,\n+url: string,\n+alt: string,\n};\n-function InfoCard(props: InfoCardProps): React.Node {\n+function InfoBlock(props: InfoBlockProps): React.Node {\nconst { title, description, url, alt } = props;\nreturn (\n- <div className={css.info_card}>\n+ <div className={css.info_block}>\n<Picture {...{ url, alt }} />\n<div className={css.tile_title_row}>\n<p className={css.tile_title}>{title}</p>\n@@ -25,4 +25,4 @@ function InfoCard(props: InfoCardProps): React.Node {\n);\n}\n-export default InfoCard;\n+export default InfoBlock;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [23/n] [landing] change name infocard --> infoblock
Summary: Info card should be a block per the design.
Test Plan: make sure code runs
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2580 |
129,179 | 07.12.2021 11:00:47 | 18,000 | 5201ef0c3728b0bc08c0e66a561789f8ca47433a | [24/n] [landing] make infoblock a section
Summary: should be a section
Test Plan: make sure page renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -15,13 +15,13 @@ function InfoBlock(props: InfoBlockProps): React.Node {\nconst { title, description, url, alt } = props;\nreturn (\n- <div className={css.info_block}>\n+ <section className={css.info_block}>\n<Picture {...{ url, alt }} />\n<div className={css.tile_title_row}>\n<p className={css.tile_title}>{title}</p>\n</div>\n<p className={css.description}>{description}</p>\n- </div>\n+ </section>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [24/n] [landing] make infoblock a section
Summary: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/section should be a section
Test Plan: make sure page renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2581 |
129,179 | 07.12.2021 11:35:26 | 18,000 | 541c32feee83044cc7afaea6946d3880fae1ff44 | [25/n] [landing] change content structure of info block
Summary: Make info block html less complex, rename css classes
Test Plan: make sure webpage renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "-div.tile_title_row {\n+div.content {\ndisplay: flex;\nflex-direction: row;\nalign-items: center;\n@@ -32,7 +32,7 @@ div.tile_title_row {\nmargin-right: 20px;\n}\n-div.tile_title_row > p.tile_title {\n+div.content > p.title {\nfont-family: 'iA Writer Duo S', monospace;\nfont-weight: bold;\nfont-size: 36px;\n@@ -41,7 +41,7 @@ div.tile_title_row > p.tile_title {\n/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n@media (max-width: 1699px) {\n- div.tile_title_row > p.tile_title {\n+ div.content > p.title {\nfont-size: 30px;\n}\n}\n@@ -52,21 +52,21 @@ div.tile_title_row > p.tile_title {\nfont-size: 16px;\n}\n- div.tile_title_row > p.tile_title {\n+ div.content > p.title {\nfont-size: 24px;\n}\n}\n/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n@media (max-width: 1299px) {\n- div.tile_title_row > p.tile_title {\n+ div.content > p.title {\nfont-size: 22px;\n}\n}\n/* ===== SMALLEST BREAKPOINT ===== */\n@media (max-width: 1099px) {\n- div.tile_title_row > p.tile_title {\n+ div.content > p.title {\nfont-size: 20px;\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -17,10 +17,10 @@ function InfoBlock(props: InfoBlockProps): React.Node {\nreturn (\n<section className={css.info_block}>\n<Picture {...{ url, alt }} />\n- <div className={css.tile_title_row}>\n- <p className={css.tile_title}>{title}</p>\n- </div>\n+ <div className={css.content}>\n+ <p className={css.title}>{title}</p>\n<p className={css.description}>{description}</p>\n+ </div>\n</section>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [25/n] [landing] change content structure of info block
Summary: Make info block html less complex, rename css classes
Test Plan: make sure webpage renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2582 |
129,179 | 07.12.2021 12:20:44 | 18,000 | d8b7f08e2297b3ff2662c2a403c3e2e6d7b465da | [26/n] [landing] add css_class to asset meta
Summary: add css class to query info blocks from landing
Test Plan: make sure page renders, no type errors
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -10,6 +10,7 @@ type InfoBlockProps = {\n+description: string,\n+url: string,\n+alt: string,\n+ +css_class: string,\n};\nfunction InfoBlock(props: InfoBlockProps): React.Node {\nconst { title, description, url, alt } = props;\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/use-pre-load-assets.react.js",
"new_path": "landing/use-pre-load-assets.react.js",
"diff": "@@ -9,6 +9,7 @@ type Asset = {\n+url: string,\n+title: string,\n+description: string,\n+ +css_class: string,\n};\nfunction usePreloadAssets(assets: Asset[]) {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [26/n] [landing] add css_class to asset meta
Summary: add css class to query info blocks from landing
Test Plan: make sure page renders, no type errors
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2583 |
129,184 | 15.12.2021 15:27:13 | 18,000 | 4039a8147c4e32ef104edf195aeb162809e49a9f | [native] `codeVersion` -> 126 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -427,8 +427,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 125\n- versionName '1.0.125'\n+ versionCode 126\n+ versionName '1.0.126'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.125</string>\n+ <string>1.0.126</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>125</string>\n+ <string>126</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.125</string>\n+ <string>1.0.126</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>125</string>\n+ <string>126</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -373,14 +373,15 @@ const persistConfig = {\n'connectivity',\n'deviceOrientation',\n'frozen',\n+ 'threadStore',\n],\ndebug: __DEV__,\n- version: 29,\n+ version: 30,\nmigrate: (createMigrate(migrations, { debug: __DEV__ }): any),\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 125;\n+const codeVersion = 126;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 126 |
129,179 | 07.12.2021 12:46:30 | 18,000 | e83a3cb67c72da7bd2fbddd008ffe98b43939949 | [28/n] [landing] add css_class to info block to query with css grid
Summary: add css class name to query grid elements from landing
Test Plan: make sure page renders no flow errors
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.react.js",
"new_path": "landing/info-block.react.js",
"diff": "@@ -10,19 +10,22 @@ type InfoBlockProps = {\n+description: string,\n+url: string,\n+alt: string,\n- +css_class: string,\n+ +imageStyle: string,\n+ +infoStyle: string,\n};\nfunction InfoBlock(props: InfoBlockProps): React.Node {\n- const { title, description, url, alt } = props;\n+ const { title, description, url, alt, imageStyle, infoStyle } = props;\nreturn (\n- <section className={css.info_block}>\n+ <>\n+ <div className={imageStyle}>\n<Picture {...{ url, alt }} />\n- <div className={css.content}>\n+ </div>\n+ <div className={`${css.info_block} ${infoStyle}`}>\n<p className={css.title}>{title}</p>\n<p className={css.description}>{description}</p>\n</div>\n- </section>\n+ </>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/use-pre-load-assets.react.js",
"new_path": "landing/use-pre-load-assets.react.js",
"diff": "import * as React from 'react';\n-import { assetUrl } from './asset-meta-data';\n-\n-type Asset = {\n- +alt: string,\n- +url: string,\n- +title: string,\n- +description: string,\n- +css_class: string,\n-};\n+import { assetUrl, type Asset } from './asset-meta-data';\nfunction usePreloadAssets(assets: Asset[]) {\nReact.useEffect(() => {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [28/n] [landing] add css_class to info block to query with css grid
Summary: add css class name to query grid elements from landing
Test Plan: make sure page renders no flow errors
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2584 |
129,179 | 07.12.2021 17:56:59 | 18,000 | a3c7c6c52a2570b5dde48bb7e9137f54bf8eb720 | [29/n] [landing] add layout
Summary: add desktop grid layout
Test Plan: layout grid should match grid in figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/app-landing.react.js",
"new_path": "landing/app-landing.react.js",
"diff": "@@ -25,7 +25,9 @@ function AppLanding(): React.Node {\nreturn (\n<main className={css.wrapper}>\n<StarBackground />\n+ <div className={hero.imageStyle}>\n<Picture url={hero.url} alt={hero.alt} />\n+ </div>\n<HeroContent />\n<InfoBlock {...federated} />\n<InfoBlock {...customizable} />\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/hero-content.react.js",
"new_path": "landing/hero-content.react.js",
"diff": "import * as React from 'react';\nimport TextLoop from 'react-text-loop';\n+import { assetMetaData } from './asset-meta-data';\nimport css from './hero-content.css';\nfunction HeroContent(): React.Node {\n+ const [hero] = assetMetaData;\n+\nreturn (\n- <>\n+ <section className={hero.infoStyle}>\n<h1 className={css.cycling_header}>\n{'Comm is crypto-native\\nchat for '}\n<TextLoop\n@@ -25,7 +28,7 @@ function HeroContent(): React.Node {\n<p className={css.app_landing_subheading}>\n(think "Web3 Discord")\n</p>\n- </>\n+ </section>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "margin-right: auto;\ndisplay: grid;\nalign-items: center;\n- grid-template-columns: 80px repeat(12, 1fr) 80px;\n- grid-template-rows: repeat(7, 1fr);\n+ padding-top: 7vh;\n+ padding-bottom: 235px;\n+ grid-template-columns: 40px repeat(12, 1fr) 40px;\n+ grid-template-rows: repeat(auto-fill, 1fr);\ncolumn-gap: 1.5%;\n+ row-gap: 75px;\ngrid-template-areas:\n- '. . . . . . . . . . . . . .'\n- '. . . . . . . . . . . . . .'\n- '. . . . . . . . . . . . . .'\n- '. . . . . . . . . . . . . .'\n- '. . . . . . . . . . . . . .'\n- '. . . . . . . . . . . . . .'\n- '. . . . . . . . . . . . . .';\n+ '. hImg hImg hImg hImg . hInfo hInfo hInfo hInfo hInfo hInfo hInfo .'\n+ '. fImg fImg fImg fImg fImg . fInfo fInfo fInfo fInfo fInfo fInfo .'\n+ '. cInfo cInfo cInfo cInfo cInfo cInfo . cImg cImg cImg cImg cImg cImg'\n+ '. eImg eImg eImg eImg eImg . eInfo eInfo eInfo eInfo eInfo eInfo .'\n+ '. sInfo sInfo sInfo sInfo sInfo sInfo . sImg sImg sImg sImg sImg .'\n+ 'oImg oImg oImg oImg oImg oImg . oInfo oInfo oInfo oInfo oInfo oInfo .'\n+ '. lInfo lInfo lInfo lInfo lInfo lInfo . lImg lImg lImg lImg lImg .';\n+}\n+\n+.heroImage {\n+ grid-area: hImg;\n+}\n+\n+.heroInfo {\n+ grid-area: hInfo;\n+}\n+\n+.federatedImage {\n+ grid-area: fImg;\n+}\n+\n+.federatedInfo {\n+ grid-area: fInfo;\n+}\n+\n+.customizableImage {\n+ grid-area: cImg;\n+}\n+\n+.customizableInfo {\n+ grid-area: cInfo;\n+}\n+\n+.encryptedImage {\n+ grid-area: eImg;\n+}\n+\n+.encryptedInfo {\n+ grid-area: eInfo;\n+}\n+\n+.sovereignImage {\n+ grid-area: sImg;\n+}\n+\n+.sovereignInfo {\n+ grid-area: sInfo;\n+}\n+\n+.openSourceImage {\n+ grid-area: oImg;\n+}\n+\n+.openSourceInfo {\n+ grid-area: oInfo;\n+}\n+\n+.lessNoisyImage {\n+ grid-area: lImg;\n+}\n+\n+.lessNoisyInfo {\n+ grid-area: lInfo;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [29/n] [landing] add layout
Summary: add desktop grid layout
Test Plan: layout grid should match grid in figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2587 |
129,179 | 08.12.2021 12:08:28 | 18,000 | a383c185b4262ac6f0fb13438798587bd7ec48d7 | [30/n] [landing] add mobile layout for landing
Summary:
check mobile view at 1099px
{F5883}
Info blocks should still be incorrect.
Test Plan: check mobile view at 1099px should match design
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.css",
"new_path": "landing/landing.css",
"diff": "'. lInfo lInfo lInfo lInfo lInfo lInfo . lImg lImg lImg lImg lImg .';\n}\n+@media screen and (max-width: 1099px) {\n+ .wrapper {\n+ margin-left: auto;\n+ margin-right: auto;\n+ display: grid;\n+ align-items: center;\n+ padding-top: 7vh;\n+ padding-bottom: 235px;\n+ grid-template-columns: 16px repeat(6, 1fr) 16px;\n+ grid-template-rows: repeat(auto-fill, 1fr);\n+ column-gap: 1.5%;\n+ row-gap: 75px;\n+ grid-template-areas:\n+ '. hInfo hInfo hInfo hInfo hInfo hInfo .'\n+ '. fInfo fInfo fInfo fInfo fInfo fInfo .'\n+ '. fImg fImg fImg fImg fImg fImg .'\n+ '. cInfo cInfo cInfo cInfo cInfo cInfo .'\n+ '. cImg cImg cImg cImg cImg cImg cImg'\n+ '. eInfo eInfo eInfo eInfo eInfo eInfo .'\n+ '. eImg eImg eImg eImg eImg eImg .'\n+ '. sInfo sInfo sInfo sInfo sInfo sInfo .'\n+ '. sImg sImg sImg sImg sImg sImg .'\n+ '. oInfo oInfo oInfo oInfo oInfo oInfo .'\n+ 'oImg oImg oImg oImg oImg oImg oImg .'\n+ '. lInfo lInfo lInfo lInfo lInfo lInfo .'\n+ '. lImg lImg lImg lImg lImg lImg .';\n+ }\n+\n+ .heroImage {\n+ display: none;\n+ }\n+\n+ .federatedImage {\n+ justify-self: center;\n+ }\n+\n+ .encryptedImage {\n+ justify-self: center;\n+ max-width: 585px;\n+ }\n+\n+ .sovereignImage {\n+ justify-self: center;\n+ }\n+}\n+\n.heroImage {\ngrid-area: hImg;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [30/n] [landing] add mobile layout for landing
Summary:
check mobile view at 1099px
{F5883}
Info blocks should still be incorrect.
Test Plan: check mobile view at 1099px should match design
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2588 |
129,179 | 08.12.2021 13:32:45 | 18,000 | 1498f13ace4d7cb2d77b458084832b9b71adc40c | [31/n] [landing] remove infoblock styling
Summary: remove styling, with fluid typography coming in additional diff it makes sense to remove styles now.
Test Plan: make sure page still renders.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/info-block.css",
"new_path": "landing/info-block.css",
"diff": "-div.content {\n- display: flex;\n- flex-direction: row;\n- align-items: center;\n- align-content: center;\n- justify-content: flex-start;\n- margin-left: 20px;\n- margin-right: 20px;\n- padding-bottom: 20px;\n-}\n-\n-.info_block {\n- display: flex;\n- padding: 36px;\n- border-radius: 8px;\n- background-color: #ebedee;\n- justify-content: center;\n- flex-direction: column;\n- transition: 300ms;\n- background-color: rgba(0, 0, 0, 0.35);\n- backdrop-filter: none;\n- -webkit-backdrop-filter: blur(2px);\n- transition: 300ms;\n-}\n-\n-.description {\n- font-size: 22px;\n- text-align: left;\n- margin-top: 0px;\n- margin-bottom: 0px;\n- margin-left: 20px;\n- margin-right: 20px;\n-}\n-\n-div.content > p.title {\n- font-family: 'iA Writer Duo S', monospace;\n- font-weight: bold;\n- font-size: 36px;\n- transition: 300ms;\n-}\n-\n-/* ===== MEDIUM-LARGE BREAKPOINT ===== */\n-@media (max-width: 1699px) {\n- div.content > p.title {\n- font-size: 30px;\n- }\n-}\n-\n-/* ===== MEDIUM BREAKPOINT ===== */\n-@media (max-width: 1499px) {\n- .description {\n- font-size: 16px;\n- }\n-\n- div.content > p.title {\n- font-size: 24px;\n- }\n-}\n-\n-/* ===== MEDIUM-SMALL BREAKPOINT ===== */\n-@media (max-width: 1299px) {\n- div.content > p.title {\n- font-size: 22px;\n- }\n-}\n-\n-/* ===== SMALLEST BREAKPOINT ===== */\n-@media (max-width: 1099px) {\n- div.content > p.title {\n- font-size: 20px;\n- }\n-}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [31/n] [landing] remove infoblock styling
Summary: remove styling, with fluid typography coming in additional diff it makes sense to remove styles now.
Test Plan: make sure page still renders.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2590 |
129,179 | 08.12.2021 13:39:36 | 18,000 | c18c4ab9ae2f703d0879c5d8ec0dfcad8722954e | [32/n] [landing] move global css variables to shared
Summary: move root css variables to shared
Test Plan: make sure header colors still render correctly
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "+:root {\n+ --purple: #7e57c2;\n+ --white: #fff;\n+ --white1: #ebedee;\n+ --grey: #808080;\n+ --btn-bg: var(--purple);\n+ --unselected: var(--grey);\n+ --btn-color: var(--white1);\n+ --logo-color: var(--white);\n+}\n+\n/* ===== GENERAL PAGE STYLES ===== */\nhtml {\nbackground: radial-gradient(ellipse at bottom, #1f252e, #111827);\n"
},
{
"change_type": "MODIFY",
"old_path": "landing/header.css",
"new_path": "landing/header.css",
"diff": "-:root {\n- --purple: #7e57c2;\n- --white: #fff;\n- --white1: #ebedee;\n- --grey: #808080;\n- --btn-bg: var(--purple);\n- --unselected: var(--grey);\n- --btn-color: var(--white1);\n- --logo-color: var(--white);\n-}\n-\nnav.wrapper {\ntransition-property: max-width;\ntransition: 300ms;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [32/n] [landing] move global css variables to shared
Summary: move root css variables to shared
Test Plan: make sure header colors still render correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2589 |
129,179 | 08.12.2021 13:44:03 | 18,000 | 417000547349fa56e36c7023ad72eb0f81fee8d3 | [33/n] [landing] remove typography styles
Summary: remove typography with break points in favor of fluid and static typography classes.
Test Plan: make sure page still renders, typography is gone
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/global.css",
"new_path": "landing/global.css",
"diff": "@@ -53,52 +53,3 @@ a {\n}\n}\n}\n-\n-/* ===== TEXT STYLES ===== */\n-h1 {\n- font-size: 58px;\n- font-family: 'IBM Plex Sans', sans-serif;\n-}\n-\n-h2 {\n- font-size: 50px;\n- font-family: 'IBM Plex Sans', sans-serif;\n-}\n-\n-p,\n-li {\n- font-size: 24px;\n- line-height: 1.6em;\n-}\n-\n-/* ===== MEDIUM BREAKPOINT ===== */\n-@media (max-width: 1499px) {\n- h1 {\n- font-size: 42px;\n- }\n- h2 {\n- font-size: 38px;\n- }\n- p,\n- li {\n- font-size: 18px;\n- }\n- li {\n- font-size: 16px;\n- }\n-}\n-\n-/* ===== SMALLEST BREAKPOINT ===== */\n-@media (max-width: 1099px) {\n- /* ===== TEXT STYLES ===== */\n- h1 {\n- font-size: 28px;\n- }\n- h2 {\n- font-size: 24px;\n- }\n- p,\n- li {\n- font-size: 16px;\n- }\n-}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [33/n] [landing] remove typography styles
Summary: remove typography with break points in favor of fluid and static typography classes.
Test Plan: make sure page still renders, typography is gone
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2591 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.