author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
129,187 | 30.01.2022 23:44:57 | 18,000 | c006173deed1ac5d5ac1f1760126365680ef8210 | [RN0.66] 27/n: Move imports into module declarations for body-parser
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/body-parser_v1.x.x.js",
"new_path": "server/flow-typed/npm/body-parser_v1.x.x.js",
"diff": "// flow-typed signature: bac0ee66e0653772d037dc47b51a5e1f\n// flow-typed version: da30fe6876/body-parser_v1.x.x/flow_>=v0.25.x\n+declare module \"body-parser\" {\nimport type { Middleware, $Request, $Response } from \"express\";\n-declare type bodyParser$Options = {\n+ declare type Options = {\ninflate?: boolean,\nlimit?: number | string,\ntype?: string | string[] | ((req: $Request) => any),\n@@ -15,32 +16,34 @@ declare type bodyParser$Options = {\n) => void\n};\n-declare type bodyParser$OptionsText = bodyParser$Options & {\n+ declare type OptionsText = Options & {\nreviver?: (key: string, value: any) => any,\nstrict?: boolean\n};\n-declare type bodyParser$OptionsJson = bodyParser$Options & {\n+ declare type OptionsJson = Options & {\nreviver?: (key: string, value: any) => any,\nstrict?: boolean\n};\n-declare type bodyParser$OptionsUrlencoded = bodyParser$Options & {\n+ declare type OptionsUrlencoded = Options & {\nextended?: boolean,\nparameterLimit?: number\n};\n-declare module \"body-parser\" {\n- declare type Options = bodyParser$Options;\n- declare type OptionsText = bodyParser$OptionsText;\n- declare type OptionsJson = bodyParser$OptionsJson;\n- declare type OptionsUrlencoded = bodyParser$OptionsUrlencoded;\n-\n- declare function json(options?: OptionsJson): Middleware;\n+ declare function json<Request: $Request, Response: $Response>(\n+ options?: OptionsJson,\n+ ): Middleware<Request, Response>;\n- declare function raw(options?: Options): Middleware;\n+ declare function raw<Request: $Request, Response: $Response>(\n+ options?: Options,\n+ ): Middleware<Request, Response>;\n- declare function text(options?: OptionsText): Middleware;\n+ declare function text<Request: $Request, Response: $Response>(\n+ options?: OptionsText,\n+ ): Middleware<Request, Response>;\n- declare function urlencoded(options?: OptionsUrlencoded): Middleware;\n+ declare function urlencoded<Request: $Request, Response: $Response>(\n+ options?: OptionsUrlencoded,\n+ ): Middleware<Request, Response>;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 27/n: Move imports into module declarations for body-parser
Summary: The new Flow errors when you import outside of a module declaration.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac
Differential Revision: https://phabricator.ashoat.com/D3006 |
129,187 | 30.01.2022 23:52:53 | 18,000 | c837d8c799c0ec20577db36bdcca0954ae227e2e | [RN0.66] 29/n: Fix ws type compatibility with events$EventEmitter type
Summary: See [here](https://github.com/facebook/flow/blob/main/lib/node.js); the `on` function must be able to take any kind of `string` to be compatible.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/flow-typed/npm/ws_v7.x.x.js",
"new_path": "server/flow-typed/npm/ws_v7.x.x.js",
"diff": "@@ -99,6 +99,11 @@ declare class ws$WebSocketServer extends events$EventEmitter {\n*/\non(event: 'listening', () => mixed): this;\n+ /**\n+ * Included for compatibility with events$EventEmitter type.\n+ */\n+ on(event: string, Function): this;\n+\n/**\n* Returns the bound address, the address family name, and port of the server\n* as reported by the operating system if listening on an IP socket.\n@@ -232,6 +237,11 @@ declare class ws$WebSocket extends events$EventEmitter {\n*/\non('upgrade', ws$UpgradeListener): this;\n+ /**\n+ * Included for compatibility with events$EventEmitter type.\n+ */\n+ on(event: string, Function): this;\n+\n/**\n* Register an event listener emulating the `EventTarget` interface.\n*/\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 29/n: Fix ws type compatibility with events$EventEmitter type
Summary: See [here](https://github.com/facebook/flow/blob/main/lib/node.js); the `on` function must be able to take any kind of `string` to be compatible.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3008 |
129,187 | 31.01.2022 00:12:23 | 18,000 | fce41a055b52c2e2d651851d02692b8fbb87b090 | [RN0.66] 30/n: Fix UserInfo types on server
Summary: The new version of Flow caught some type errors here. We were using `AccountUserInfo` (username cannot be `null`) when in fact we were returning `UserInfo` (username can be `null`).
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac | [
{
"change_type": "MODIFY",
"old_path": "lib/types/thread-types.js",
"new_path": "lib/types/thread-types.js",
"diff": "@@ -10,7 +10,7 @@ import type {\n} from './message-types';\nimport type { ThreadSubscription } from './subscription-types';\nimport type { ServerUpdateInfo, ClientUpdateInfo } from './update-types';\n-import type { UserInfo, AccountUserInfo } from './user-types';\n+import type { UserInfo, UserInfos } from './user-types';\nexport const threadTypes = Object.freeze({\n//OPEN: 0, (DEPRECATED)\n@@ -387,7 +387,7 @@ export type NewThreadResponse = {\n},\n+newMessageInfos: $ReadOnlyArray<RawMessageInfo>,\n+newThreadInfo?: RawThreadInfo,\n- +userInfos: { [string]: AccountUserInfo },\n+ +userInfos: UserInfos,\n+newThreadID?: string,\n};\nexport type NewThreadResult = {\n@@ -395,7 +395,7 @@ export type NewThreadResult = {\n+newUpdates: $ReadOnlyArray<ClientUpdateInfo>,\n},\n+newMessageInfos: $ReadOnlyArray<RawMessageInfo>,\n- +userInfos: { [string]: AccountUserInfo },\n+ +userInfos: UserInfos,\n+newThreadID: string,\n};\n@@ -414,7 +414,7 @@ export type ThreadJoinResult = {\n},\nrawMessageInfos: $ReadOnlyArray<RawMessageInfo>,\ntruncationStatuses: MessageTruncationStatuses,\n- userInfos: { [string]: AccountUserInfo },\n+ userInfos: UserInfos,\nrawEntryInfos?: ?$ReadOnlyArray<RawEntryInfo>,\n};\nexport type ThreadJoinPayload = {\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/types/update-types.js",
"new_path": "lib/types/update-types.js",
"diff": "@@ -7,7 +7,7 @@ import type { RawMessageInfo, MessageTruncationStatus } from './message-types';\nimport type { RawThreadInfo } from './thread-types';\nimport type {\nUserInfo,\n- AccountUserInfo,\n+ UserInfos,\nLoggedInUserInfo,\nOldLoggedInUserInfo,\n} from './user-types';\n@@ -300,17 +300,17 @@ export type ClientUpdatesResultWithUserInfos = {\nexport type CreateUpdatesResult = {\n+viewerUpdates: $ReadOnlyArray<ServerUpdateInfo>,\n- +userInfos: { [id: string]: AccountUserInfo },\n+ +userInfos: UserInfos,\n};\nexport type ServerCreateUpdatesResponse = {\n+viewerUpdates: $ReadOnlyArray<ServerUpdateInfo>,\n- +userInfos: $ReadOnlyArray<AccountUserInfo>,\n+ +userInfos: $ReadOnlyArray<UserInfo>,\n};\nexport type ClientCreateUpdatesResponse = {\n+viewerUpdates: $ReadOnlyArray<ClientUpdateInfo>,\n- +userInfos: $ReadOnlyArray<AccountUserInfo>,\n+ +userInfos: $ReadOnlyArray<UserInfo>,\n};\nexport const processUpdatesActionType = 'PROCESS_UPDATES';\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/creators/thread-creator.js",
"new_path": "server/src/creators/thread-creator.js",
"diff": "@@ -19,7 +19,7 @@ import {\nthreadPermissions,\nthreadTypeIsCommunityRoot,\n} from 'lib/types/thread-types';\n-import type { AccountUserInfo } from 'lib/types/user-types';\n+import type { UserInfos } from 'lib/types/user-types';\nimport { pushAll } from 'lib/utils/array';\nimport { ServerError } from 'lib/utils/errors';\nimport { promiseAll } from 'lib/utils/promises';\n@@ -292,7 +292,7 @@ async function createThread(\n}\nlet joinUpdateInfos = [];\n- let userInfos: { [id: string]: AccountUserInfo } = {};\n+ let userInfos: UserInfos = {};\nlet newMessageInfos = [];\nif (threadType !== threadTypes.PERSONAL) {\nconst joinThreadResult = await joinThread(viewer, {\n"
},
{
"change_type": "MODIFY",
"old_path": "server/src/creators/update-creator.js",
"new_path": "server/src/creators/update-creator.js",
"diff": "@@ -32,7 +32,7 @@ import {\nupdateTypes,\n} from 'lib/types/update-types';\nimport type {\n- AccountUserInfo,\n+ UserInfos,\nLoggedInUserInfo,\nOldLoggedInUserInfo,\n} from 'lib/types/user-types';\n@@ -407,8 +407,8 @@ async function createUpdates(\n}\nexport type FetchUpdatesResult = {\n- updateInfos: $ReadOnlyArray<ServerUpdateInfo>,\n- userInfos: { [id: string]: AccountUserInfo },\n+ +updateInfos: $ReadOnlyArray<ServerUpdateInfo>,\n+ +userInfos: UserInfos,\n};\nasync function fetchUpdateInfosWithRawUpdateInfos(\nrawUpdateInfos: $ReadOnlyArray<RawUpdateInfo>,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 30/n: Fix UserInfo types on server
Summary: The new version of Flow caught some type errors here. We were using `AccountUserInfo` (username cannot be `null`) when in fact we were returning `UserInfo` (username can be `null`).
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac
Differential Revision: https://phabricator.ashoat.com/D3009 |
129,187 | 31.01.2022 00:31:18 | 18,000 | d6a162410eb1b3612049154abb82ef9960078505 | [RN0.66] 32/n: Fix type mismatch in updateAndReloadGeoipDB
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/cron/update-geoip-db.js",
"new_path": "server/src/cron/update-geoip-db.js",
"diff": "@@ -62,7 +62,7 @@ async function updateAndReloadGeoipDB(): Promise<void> {\nreturn;\n}\nfor (const id in cluster.workers) {\n- cluster.workers[id].send(reloadMessage);\n+ cluster.workers[Number(id)].send(reloadMessage);\n}\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 32/n: Fix type mismatch in updateAndReloadGeoipDB
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3011 |
129,187 | 31.01.2022 02:09:14 | 18,000 | c71dbcd9649d2a450e39e063925450fa2944e758 | [RN0.66] 37/n: Fix type of generic TextInput component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/text-input.react.js",
"new_path": "native/components/text-input.react.js",
"diff": "// @flow\nimport * as React from 'react';\n-import { TextInput as BaseTextInput } from 'react-native';\n+import { TextInput } from 'react-native';\nimport { useKeyboardAppearance } from '../themes/colors';\n-type Props = React.ElementConfig<typeof BaseTextInput>;\n-function ForwardedTextInput(\n- props: Props,\n- ref: React.Ref<typeof TextInput>,\n-): React.Node {\n+type Props = React.ElementConfig<typeof TextInput>;\n+function ForwardedTextInput(props: Props, ref): React.Node {\nconst keyboardAppearance = useKeyboardAppearance();\nreturn (\n- <BaseTextInput\n- keyboardAppearance={keyboardAppearance}\n- {...props}\n- ref={ref}\n- />\n+ <TextInput keyboardAppearance={keyboardAppearance} {...props} ref={ref} />\n);\n}\n-const TextInput: React.AbstractComponent<\n+const WrappedTextInput: React.AbstractComponent<\nProps,\n- typeof BaseTextInput,\n-> = React.forwardRef<Props, typeof BaseTextInput>(ForwardedTextInput);\n-TextInput.displayName = 'CommTextInput';\n+ React.ElementRef<typeof TextInput>,\n+> = React.forwardRef<Props, React.ElementRef<typeof TextInput>>(\n+ ForwardedTextInput,\n+);\n+WrappedTextInput.displayName = 'CommTextInput';\n-export default TextInput;\n+export default WrappedTextInput;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 37/n: Fix type of generic TextInput component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3018 |
129,187 | 31.01.2022 02:13:50 | 18,000 | 29d706fe3680b9bf6f3d21ed924f0f6b782a919a | [RN0.66] 38/n: Fix function unbound from context Flow error across native FlatLists
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -509,10 +509,10 @@ class Calendar extends React.PureComponent<Props, State> {\ninvariant(false, 'keyExtractor conditions should be exhaustive');\n};\n- static getItemLayout(\n+ static getItemLayout = (\ndata: ?$ReadOnlyArray<CalendarItemWithHeight>,\nindex: number,\n- ) {\n+ ) => {\nif (!data) {\nreturn { length: 0, offset: 0, index };\n}\n@@ -520,9 +520,9 @@ class Calendar extends React.PureComponent<Props, State> {\nconst item = data[index];\nconst length = item ? Calendar.itemHeight(item) : 0;\nreturn { length, offset, index };\n- }\n+ };\n- static itemHeight(item: CalendarItemWithHeight): number {\n+ static itemHeight = (item: CalendarItemWithHeight) => {\nif (item.itemType === 'loader') {\nreturn 56;\n} else if (item.itemType === 'header') {\n@@ -534,11 +534,11 @@ class Calendar extends React.PureComponent<Props, State> {\nreturn 40;\n}\ninvariant(false, 'itemHeight conditions should be exhaustive');\n- }\n+ };\n- static heightOfItems(data: $ReadOnlyArray<CalendarItemWithHeight>): number {\n+ static heightOfItems = (data: $ReadOnlyArray<CalendarItemWithHeight>) => {\nreturn _sum(data.map(Calendar.itemHeight));\n- }\n+ };\nrender() {\nconst { listDataWithHeights } = this.state;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -234,10 +234,10 @@ class ChatList extends React.PureComponent<Props, State> {\nthis.flatList = flatList;\n};\n- static getItemLayout(\n+ static getItemLayout = (\ndata: ?$ReadOnlyArray<ChatMessageItemWithHeight>,\nindex: number,\n- ) {\n+ ) => {\nif (!data) {\nreturn { length: 0, offset: 0, index };\n}\n@@ -245,7 +245,7 @@ class ChatList extends React.PureComponent<Props, State> {\nconst item = data[index];\nconst length = item ? chatMessageItemHeight(item) : 0;\nreturn { length, offset, index };\n- }\n+ };\nstatic heightOfItems(\ndata: $ReadOnlyArray<ChatMessageItemWithHeight>,\n"
},
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list.react.js",
"new_path": "native/chat/chat-thread-list.react.js",
"diff": "@@ -336,7 +336,7 @@ class ChatThreadList extends React.PureComponent<Props, State> {\n);\n};\n- static keyExtractor(item: Item) {\n+ static keyExtractor = (item: Item) => {\nif (item.type === 'chatThreadItem') {\nreturn item.threadInfo.id;\n} else if (item.type === 'empty') {\n@@ -344,9 +344,9 @@ class ChatThreadList extends React.PureComponent<Props, State> {\n} else {\nreturn 'search';\n}\n- }\n+ };\n- static getItemLayout(data: ?$ReadOnlyArray<Item>, index: number) {\n+ static getItemLayout = (data: ?$ReadOnlyArray<Item>, index: number) => {\nif (!data) {\nreturn { length: 0, offset: 0, index };\n}\n@@ -356,9 +356,9 @@ class ChatThreadList extends React.PureComponent<Props, State> {\nconst item = data[index];\nconst length = item ? ChatThreadList.itemHeight(item) : 0;\nreturn { length, offset, index };\n- }\n+ };\n- static itemHeight(item: Item): number {\n+ static itemHeight = (item: Item) => {\nif (item.type === 'search') {\nreturn Platform.OS === 'ios' ? 54.5 : 55;\n}\n@@ -376,7 +376,7 @@ class ChatThreadList extends React.PureComponent<Props, State> {\nheight += spacerHeight;\n}\nreturn height;\n- }\n+ };\nstatic heightOfItems(data: $ReadOnlyArray<Item>): number {\nreturn _sum(data.map(ChatThreadList.itemHeight));\n"
},
{
"change_type": "MODIFY",
"old_path": "native/components/thread-list.react.js",
"new_path": "native/components/thread-list.react.js",
"diff": "@@ -94,9 +94,9 @@ class ThreadList extends React.PureComponent<Props, State> {\n);\n}\n- static keyExtractor(threadInfo: ThreadInfo) {\n+ static keyExtractor = (threadInfo: ThreadInfo) => {\nreturn threadInfo.id;\n- }\n+ };\nrenderItem = (row: { item: ThreadInfo, ... }) => {\nreturn (\n@@ -109,9 +109,9 @@ class ThreadList extends React.PureComponent<Props, State> {\n);\n};\n- static getItemLayout(data: ?$ReadOnlyArray<ThreadInfo>, index: number) {\n+ static getItemLayout = (data: ?$ReadOnlyArray<ThreadInfo>, index: number) => {\nreturn { length: 24, offset: 24 * index, index };\n- }\n+ };\nonChangeSearchText = (searchText: string) => {\ninvariant(this.props.searchIndex, 'should be set');\n"
},
{
"change_type": "MODIFY",
"old_path": "native/components/user-list.react.js",
"new_path": "native/components/user-list.react.js",
"diff": "@@ -36,9 +36,9 @@ class UserList extends React.PureComponent<Props> {\n);\n}\n- static keyExtractor(userInfo: UserListItem) {\n+ static keyExtractor = (userInfo: UserListItem) => {\nreturn userInfo.id;\n- }\n+ };\nrenderItem = (row: { item: UserListItem, ... }) => {\nreturn (\n@@ -50,7 +50,10 @@ class UserList extends React.PureComponent<Props> {\n);\n};\n- static getItemLayout(data: ?$ReadOnlyArray<UserListItem>, index: number) {\n+ static getItemLayout = (\n+ data: ?$ReadOnlyArray<UserListItem>,\n+ index: number,\n+ ) => {\nif (!data) {\nreturn { length: 0, offset: 0, index };\n}\n@@ -60,7 +63,7 @@ class UserList extends React.PureComponent<Props> {\nconst item = data[index];\nconst length = item ? getUserListItemHeight(item) : 0;\nreturn { length, offset, index };\n- }\n+ };\n}\nconst ConnectedUserList: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n"
},
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -315,9 +315,9 @@ class MediaGalleryKeyboard extends React.PureComponent<Props, State> {\nreturn <View style={this.props.styles.separator} />;\n};\n- static keyExtractor(item: MediaLibrarySelection) {\n+ static keyExtractor = (item: MediaLibrarySelection) => {\nreturn item.uri;\n- }\n+ };\nrender() {\nlet content;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/profile/relationship-list.react.js",
"new_path": "native/profile/relationship-list.react.js",
"diff": "@@ -148,7 +148,7 @@ class RelationshipList extends React.PureComponent<Props, State> {\n});\n}\n- static keyExtractor(item: ListItem) {\n+ static keyExtractor = (item: ListItem) => {\nif (item.userInfo) {\nreturn item.userInfo.id;\n} else if (item.type === 'empty') {\n@@ -159,7 +159,7 @@ class RelationshipList extends React.PureComponent<Props, State> {\nreturn 'footer';\n}\ninvariant(false, 'keyExtractor conditions should be exhaustive');\n- }\n+ };\nget listData() {\nreturn this.listDataSelector({ ...this.props, ...this.state });\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 38/n: Fix function unbound from context Flow error across native FlatLists
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3019 |
129,187 | 31.01.2022 02:16:05 | 18,000 | 824d7824efdcf2d66ecd0fb35aa5bfd8947854ef | [RN0.66] 39/n: Fix KeyboardInputHost BaseProps type
Summary:
`ChatInputBar` can render `KeyboardInputHost` with a `textInputRef` set to `null`.
This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard-input-host.react.js",
"new_path": "native/keyboard/keyboard-input-host.react.js",
"diff": "@@ -15,7 +15,7 @@ import { useStyles } from '../themes/colors';\nimport { type KeyboardState, KeyboardContext } from './keyboard-state';\ntype BaseProps = {\n- +textInputRef?: React.ElementRef<typeof TextInput>,\n+ +textInputRef?: ?React.ElementRef<typeof TextInput>,\n};\ntype Props = {\n...BaseProps,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 39/n: Fix KeyboardInputHost BaseProps type
Summary:
`ChatInputBar` can render `KeyboardInputHost` with a `textInputRef` set to `null`.
This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3020 |
129,187 | 31.01.2022 02:23:25 | 18,000 | d96a67373f912a779c53de86886d442bc2022d8a | [RN0.66] 40/n: Fix FlatList type in ChatList
Summary: This type error was caught as part of the Flow upgrade. Managed to remove a `$FlowFixMe` too!
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -11,10 +11,6 @@ import {\nTouchableWithoutFeedback,\nView,\n} from 'react-native';\n-import type {\n- Props as FlatListProps,\n- DefaultProps as FlatListDefaultProps,\n-} from 'react-native/Libraries/Lists/FlatList';\nimport type { ChatMessageItem } from 'lib/selectors/chat-selectors';\nimport { localIDPrefix, messageKey } from 'lib/shared/message-utils';\n@@ -47,16 +43,10 @@ const animationSpec = {\n};\ntype BaseProps = {\n- ...$ReadOnly<\n- $Exact<\n- React.Config<\n- FlatListProps<ChatMessageItemWithHeight>,\n- FlatListDefaultProps,\n- >,\n- >,\n- >,\n+ ...React.ElementConfig<typeof FlatList>,\n+navigation: ChatNavigationProp<'MessageList'>,\n+data: $ReadOnlyArray<ChatMessageItemWithHeight>,\n+ ...\n};\ntype Props = {\n...BaseProps,\n@@ -64,6 +54,7 @@ type Props = {\n+viewerID: ?string,\n// withKeyboardState\n+keyboardState: ?KeyboardState,\n+ ...\n};\ntype State = {\n+newMessageCount: number,\n@@ -270,7 +261,6 @@ class ChatList extends React.PureComponent<Props, State> {\nif (this.scrollPos <= 0) {\nthis.toggleNewMessagesPill(false);\n}\n- // $FlowFixMe FlatList doesn't type ScrollView props\nthis.props.onScroll && this.props.onScroll(event);\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 40/n: Fix FlatList type in ChatList
Summary: This type error was caught as part of the Flow upgrade. Managed to remove a `$FlowFixMe` too!
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3021 |
129,187 | 31.01.2022 02:33:46 | 18,000 | bf432e64a8960c2e294891cc50b2a4a8bc21e3ec | [RN0.66] 41/n: Patch Easing types
Summary: This is what Facebook did, so we'll do the same. It will be fixed in React Native 0.68 with [this patch](https://github.com/facebook/react-native/commit/851e87a1a6b4291b3e928b30185be18ac1079e0b).
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-list.react.js",
"new_path": "native/chat/chat-list.react.js",
"diff": "@@ -247,6 +247,7 @@ class ChatList extends React.PureComponent<Props, State> {\ntoggleNewMessagesPill(show: boolean) {\nAnimated.timing(this.newMessagesPillProgress, {\n...animationSpec,\n+ // $FlowFixMe[method-unbinding]\neasing: show ? Easing.ease : Easing.out(Easing.ease),\ntoValue: show ? 1 : 0,\n}).start(({ finished }) => {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/media/camera-modal.react.js",
"new_path": "native/media/camera-modal.react.js",
"diff": "@@ -108,6 +108,7 @@ const stagingModeAnimationConfig = {\n};\nconst sendButtonAnimationConfig = {\nduration: 150,\n+ // $FlowFixMe[method-unbinding]\neasing: Easing.inOut(Easing.ease),\nuseNativeDriver: true,\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-keyboard.react.js",
"new_path": "native/media/media-gallery-keyboard.react.js",
"diff": "@@ -31,6 +31,7 @@ import SendMediaButton from './send-media-button.react';\nconst animationSpec = {\nduration: 400,\n+ // $FlowFixMe[method-unbinding]\neasing: Easing.inOut(Easing.ease),\nuseNativeDriver: true,\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/media/media-gallery-media.react.js",
"new_path": "native/media/media-gallery-media.react.js",
"diff": "@@ -32,6 +32,7 @@ import {\nconst animatedSpec = {\nduration: 400,\n+ // $FlowFixMe[method-unbinding]\neasing: Easing.inOut(Easing.ease),\nuseNativeDriver: true,\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar.react.js",
"new_path": "native/navigation/disconnected-bar.react.js",
"diff": "@@ -13,6 +13,7 @@ const expandedHeight = Platform.select({\nconst timingConfig = {\nuseNativeDriver: false,\nduration: 200,\n+ // $FlowFixMe[method-unbinding]\neasing: Easing.inOut(Easing.ease),\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 41/n: Patch Easing types
Summary: This is what Facebook did, so we'll do the same. It will be fixed in React Native 0.68 with [this patch](https://github.com/facebook/react-native/commit/851e87a1a6b4291b3e928b30185be18ac1079e0b).
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3022 |
129,187 | 31.01.2022 02:54:02 | 18,000 | 26e284c31e7352331e85c7f7146867647f14a86a | [RN0.66] 42/n: Fix type of Search component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/components/search.react.js",
"new_path": "native/components/search.react.js",
"diff": "@@ -25,7 +25,7 @@ type Props = {\n+active?: boolean,\n};\n-function ForwardedSearch(props: Props, ref: React.Ref<typeof BaseTextInput>) {\n+function ForwardedSearch(props: Props, ref) {\nconst { onChangeText, searchText, containerStyle, active, ...rest } = props;\nconst clearSearch = React.useCallback(() => {\n@@ -99,7 +99,12 @@ function ForwardedSearch(props: Props, ref: React.Ref<typeof BaseTextInput>) {\n);\n}\n-const Search = React.forwardRef<Props, typeof BaseTextInput>(ForwardedSearch);\n+const Search: React.AbstractComponent<\n+ Props,\n+ React.ElementRef<typeof BaseTextInput>,\n+> = React.forwardRef<Props, React.ElementRef<typeof BaseTextInput>>(\n+ ForwardedSearch,\n+);\nSearch.displayName = 'Search';\nconst unboundStyles = {\n@@ -132,6 +137,9 @@ const unboundStyles = {\n},\n};\n-const MemoizedSearch: React.ComponentType<Props> = React.memo<Props>(Search);\n+const MemoizedSearch: typeof Search = React.memo<\n+ Props,\n+ React.ElementRef<typeof BaseTextInput>,\n+>(Search);\nexport default MemoizedSearch;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 42/n: Fix type of Search component
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3023 |
129,187 | 31.01.2022 03:07:39 | 18,000 | ab262673eef9e88b1785f40a1df9e21b4bfea78a | [RN0.66] 43/n: Fix KeyboardEvent type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -29,7 +29,6 @@ import { fetchNewCookieFromNativeCredentials } from 'lib/utils/action-utils';\nimport KeyboardAvoidingView from '../components/keyboard-avoiding-view.react';\nimport ConnectedStatusBar from '../connected-status-bar.react';\nimport {\n- type KeyboardEvent,\naddKeyboardShowListener,\naddKeyboardDismissListener,\nremoveKeyboardListener,\n@@ -45,7 +44,7 @@ import {\nderivedDimensionsInfoSelector,\n} from '../selectors/dimensions-selectors';\nimport { splashStyleSelector } from '../splash';\n-import type { EmitterSubscription } from '../types/react-native';\n+import type { EmitterSubscription, KeyboardEvent } from '../types/react-native';\nimport type { ImageStyle } from '../types/styles';\nimport {\nrunTiming,\n"
},
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -49,7 +49,6 @@ import KeyboardAvoidingView from '../components/keyboard-avoiding-view.react';\nimport ListLoadingIndicator from '../components/list-loading-indicator.react';\nimport NodeHeightMeasurer from '../components/node-height-measurer.react';\nimport {\n- type KeyboardEvent,\naddKeyboardShowListener,\naddKeyboardDismissListener,\nremoveKeyboardListener,\n@@ -89,6 +88,7 @@ import type {\nEmitterSubscription,\nScrollEvent,\nViewableItemsChange,\n+ KeyboardEvent,\n} from '../types/react-native';\nimport CalendarInputBar from './calendar-input-bar.react';\nimport {\n"
},
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -10,7 +10,7 @@ import {\nStyleSheet,\n} from 'react-native';\n-import type { ScreenRect, KeyboardEvent } from '../keyboard/keyboard';\n+import type { ScreenRect } from '../keyboard/keyboard';\nimport {\ntype KeyboardState,\nKeyboardContext,\n@@ -19,6 +19,7 @@ import type {\nLayout,\nLayoutEvent,\nEmitterSubscription,\n+ KeyboardEvent,\n} from '../types/react-native';\nimport type { ViewStyle } from '../types/styles';\n"
},
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard.js",
"new_path": "native/keyboard/keyboard.js",
"diff": "import { Keyboard, Platform, DeviceInfo } from 'react-native';\nimport type { EmitterSubscription } from '../types/react-native';\n+import type { KeyboardEvent } from '../types/react-native';\nexport type ScreenRect = $ReadOnly<{\nscreenX: number,\n@@ -10,12 +11,6 @@ export type ScreenRect = $ReadOnly<{\nwidth: number,\nheight: number,\n}>;\n-export type KeyboardEvent = $ReadOnly<{\n- duration?: number,\n- easing?: string,\n- endCoordinates: ScreenRect,\n- startCoordinates?: ScreenRect,\n-}>;\ntype ShowKeyboardCallback = (event: KeyboardEvent) => void;\ntype HideKeyboardCallback = (event: ?KeyboardEvent) => void;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/types/react-native.js",
"new_path": "native/types/react-native.js",
"diff": "@@ -17,6 +17,8 @@ export type {\nexport type { NativeMethods } from 'react-native/Libraries/Renderer/shims/ReactNativeTypes';\n+export type { KeyboardEvent } from 'react-native/Libraries/Components/Keyboard/Keyboard';\n+\nexport type AnimatedValue = ReactNativeAnimatedValue;\nexport type ViewableItemsChange = {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 43/n: Fix KeyboardEvent type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3024 |
129,187 | 31.01.2022 03:11:34 | 18,000 | e9469f4cfa8ef6fbcadcd1d7dbfd37d747278814 | [RN0.66] 44/n: Fix EventSubscription type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -44,7 +44,7 @@ import {\nderivedDimensionsInfoSelector,\n} from '../selectors/dimensions-selectors';\nimport { splashStyleSelector } from '../splash';\n-import type { EmitterSubscription, KeyboardEvent } from '../types/react-native';\n+import type { EventSubscription, KeyboardEvent } from '../types/react-native';\nimport type { ImageStyle } from '../types/styles';\nimport {\nrunTiming,\n@@ -123,8 +123,8 @@ type State = {\n+registerState: StateContainer<RegisterState>,\n};\nclass LoggedOutModal extends React.PureComponent<Props, State> {\n- keyboardShowListener: ?EmitterSubscription;\n- keyboardHideListener: ?EmitterSubscription;\n+ keyboardShowListener: ?EventSubscription;\n+ keyboardHideListener: ?EventSubscription;\nmounted = false;\nnextMode: LoggedOutMode = 'loading';\n"
},
{
"change_type": "MODIFY",
"old_path": "native/calendar/calendar.react.js",
"new_path": "native/calendar/calendar.react.js",
"diff": "@@ -85,7 +85,7 @@ import {\ntype IndicatorStyle,\n} from '../themes/colors';\nimport type {\n- EmitterSubscription,\n+ EventSubscription,\nScrollEvent,\nViewableItemsChange,\nKeyboardEvent,\n@@ -169,8 +169,8 @@ class Calendar extends React.PureComponent<Props, State> {\n// When an entry becomes active, we make a note of its key so that once the\n// keyboard event happens, we know where to move the scrollPos to\nlastEntryKeyActive: ?string = null;\n- keyboardShowListener: ?EmitterSubscription;\n- keyboardDismissListener: ?EmitterSubscription;\n+ keyboardShowListener: ?EventSubscription;\n+ keyboardDismissListener: ?EventSubscription;\nkeyboardShownHeight: ?number = null;\n// If the query fails, we try it again\ntopLoadingFromScroll: ?CalendarQuery = null;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/components/keyboard-avoiding-view.react.js",
"new_path": "native/components/keyboard-avoiding-view.react.js",
"diff": "@@ -18,7 +18,7 @@ import {\nimport type {\nLayout,\nLayoutEvent,\n- EmitterSubscription,\n+ EventSubscription,\nKeyboardEvent,\n} from '../types/react-native';\nimport type { ViewStyle } from '../types/styles';\n@@ -50,7 +50,7 @@ class InnerKeyboardAvoidingView extends React.PureComponent<Props, State> {\nstate: State = {\nbottom: 0,\n};\n- subscriptions: EmitterSubscription[] = [];\n+ subscriptions: EventSubscription[] = [];\nviewFrame: ?Layout;\nkeyboardFrame: ?ScreenRect;\ndefaultViewFrameHeight = 0;\n"
},
{
"change_type": "MODIFY",
"old_path": "native/keyboard/keyboard.js",
"new_path": "native/keyboard/keyboard.js",
"diff": "import { Keyboard, Platform, DeviceInfo } from 'react-native';\n-import type { EmitterSubscription } from '../types/react-native';\n-import type { KeyboardEvent } from '../types/react-native';\n+import type { EventSubscription, KeyboardEvent } from '../types/react-native';\nexport type ScreenRect = $ReadOnly<{\nscreenX: number,\n@@ -46,7 +45,7 @@ function callShowCallback(\n}\nfunction addKeyboardShowListener(\ncallback: ShowKeyboardCallback,\n-): EmitterSubscription {\n+): EventSubscription {\nreturn Keyboard.addListener(\nPlatform.OS === 'ios' ? 'keyboardWillShow' : 'keyboardDidShow',\ncallShowCallback(callback),\n@@ -68,7 +67,7 @@ function callHideCallback(\n}\nfunction addKeyboardDismissListener(\ncallback: HideKeyboardCallback,\n-): EmitterSubscription {\n+): EventSubscription {\nreturn Keyboard.addListener(\nPlatform.OS === 'ios' ? 'keyboardWillHide' : 'keyboardDidHide',\ncallHideCallback(callback),\n@@ -76,11 +75,11 @@ function addKeyboardDismissListener(\n}\nfunction addKeyboardDidDismissListener(\ncallback: HideKeyboardCallback,\n-): EmitterSubscription {\n+): EventSubscription {\nreturn Keyboard.addListener('keyboardDidHide', callHideCallback(callback));\n}\n-function removeKeyboardListener(listener: EmitterSubscription) {\n+function removeKeyboardListener(listener: EventSubscription) {\nlistener.remove();\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/types/react-native.js",
"new_path": "native/types/react-native.js",
"diff": "@@ -19,6 +19,8 @@ export type { NativeMethods } from 'react-native/Libraries/Renderer/shims/ReactN\nexport type { KeyboardEvent } from 'react-native/Libraries/Components/Keyboard/Keyboard';\n+export type { EventSubscription } from 'react-native/Libraries/vendor/emitter/EventEmitter';\n+\nexport type AnimatedValue = ReactNativeAnimatedValue;\nexport type ViewableItemsChange = {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 44/n: Fix EventSubscription type
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3025 |
129,187 | 31.01.2022 03:13:00 | 18,000 | 7a208aef32028e2ed4bab1bb587069cf134cff47 | [RN0.66] 45/n: Fix event.startCoordinates check in LoggedOutModal
Summary: Turns out that `event.startCoordinates` is only available on iOS, and Flow caught this. We should check before making the comparison here (should be a no-op).
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/account/logged-out-modal.react.js",
"new_path": "native/account/logged-out-modal.react.js",
"diff": "@@ -415,7 +415,10 @@ class LoggedOutModal extends React.PureComponent<Props, State> {\n}\nkeyboardShow = (event: KeyboardEvent) => {\n- if (_isEqual(event.startCoordinates)(event.endCoordinates)) {\n+ if (\n+ event.startCoordinates &&\n+ _isEqual(event.startCoordinates)(event.endCoordinates)\n+ ) {\nreturn;\n}\nconst keyboardHeight = Platform.select({\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 45/n: Fix event.startCoordinates check in LoggedOutModal
Summary: Turns out that `event.startCoordinates` is only available on iOS, and Flow caught this. We should check before making the comparison here (should be a no-op).
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3026 |
129,187 | 31.01.2022 03:23:22 | 18,000 | 31a55d6747cc550f76099cb39e1e94444fef7461 | [RN0.66] 46/n: Fix LifecycleEventEmitter types
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Subscribers: benschac | [
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle-event-emitter.js",
"new_path": "native/lifecycle/lifecycle-event-emitter.js",
"diff": "@@ -8,7 +8,7 @@ import * as TurboModuleRegistry from 'react-native/Libraries/TurboModule/TurboMo\nimport type { LifecycleState } from 'lib/types/lifecycle-state-types';\n-import type { EmitterSubscription } from '../types/react-native';\n+import type { EventSubscription } from '../types/react-native';\ninterface Spec extends TurboModule {\n+getConstants: () => {\n@@ -21,20 +21,23 @@ const AndroidLifecycle = (TurboModuleRegistry.getEnforcing<Spec>(\n'AndroidLifecycle',\n): Spec);\n-class LifecycleEventEmitter extends NativeEventEmitter {\n+type LifecycleEventEmitterArgs = {\n+ +LIFECYCLE_CHANGE: [{ +status: ?LifecycleState }],\n+};\n+class LifecycleEventEmitter extends NativeEventEmitter<LifecycleEventEmitterArgs> {\ncurrentLifecycleStatus: ?string;\nconstructor() {\nsuper(AndroidLifecycle);\nthis.currentLifecycleStatus = AndroidLifecycle.getConstants().initialStatus;\nthis.addLifecycleListener(state => {\n- this.currentAndroidLifecycle = state;\n+ this.currentLifecycleStatus = state;\n});\n}\naddLifecycleListener: (\n- listener: (state: ?LifecycleState) => mixed,\n- ) => EmitterSubscription = listener => {\n+ listener: (state: ?LifecycleState) => void,\n+ ) => EventSubscription = listener => {\nreturn this.addListener('LIFECYCLE_CHANGE', event => {\nlistener(event.status);\n});\n"
},
{
"change_type": "MODIFY",
"old_path": "native/lifecycle/lifecycle.js",
"new_path": "native/lifecycle/lifecycle.js",
"diff": "@@ -4,12 +4,12 @@ import { Platform, AppState as NativeAppState } from 'react-native';\nimport { type LifecycleState } from 'lib/types/lifecycle-state-types';\n-import type { EmitterSubscription } from '../types/react-native';\n+import type { EventSubscription } from '../types/react-native';\nimport { getLifecycleEventEmitter } from './lifecycle-event-emitter';\nfunction addLifecycleListener(\n- listener: (state: ?LifecycleState) => mixed,\n-): EmitterSubscription {\n+ listener: (state: ?LifecycleState) => void,\n+): EventSubscription {\nif (Platform.OS === 'android') {\nreturn getLifecycleEventEmitter().addLifecycleListener(listener);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/push/push-handler.react.js",
"new_path": "native/push/push-handler.react.js",
"diff": "@@ -45,7 +45,7 @@ import {\n} from '../redux/action-types';\nimport { useSelector } from '../redux/redux-utils';\nimport { RootContext, type RootContextType } from '../root-context';\n-import type { EmitterSubscription } from '../types/react-native';\n+import type { EventSubscription } from '../types/react-native';\nimport { type GlobalTheme } from '../types/themes';\nimport { type NotifPermissionAlertInfo } from './alerts';\nimport {\n@@ -113,7 +113,7 @@ class PushHandler extends React.PureComponent<Props, State> {\nandroidNotifOpenListener: ?() => void = null;\ninitialAndroidNotifHandled = false;\nopenThreadOnceReceived: Set<string> = new Set();\n- lifecycleSubscription: ?EmitterSubscription;\n+ lifecycleSubscription: ?EventSubscription;\ncomponentDidMount() {\nthis.appStarted = Date.now();\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [RN0.66] 46/n: Fix LifecycleEventEmitter types
Summary: This type error was caught as part of the Flow upgrade.
Test Plan: Flow
Reviewers: palys-swm, atul
Reviewed By: palys-swm
Subscribers: benschac
Differential Revision: https://phabricator.ashoat.com/D3027 |
129,187 | 31.01.2022 05:52:49 | 18,000 | a96d76144150d88765b40c130a194456137e7cbb | [docs] Remove php7_module from httpd.conf module list
Summary: It's not available on new versions of macOS anyways.
Test Plan: I walked through these instructions today
Reviewers: atul, palys-swm
Subscribers: benschac, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "docs/dev_environment.md",
"new_path": "docs/dev_environment.md",
"diff": "@@ -353,7 +353,6 @@ LoadModule proxy_module libexec/apache2/mod_proxy.so\nLoadModule proxy_http_module libexec/apache2/mod_proxy_http.so\nLoadModule proxy_wstunnel_module libexec/apache2/mod_proxy_wstunnel.so\nLoadModule userdir_module libexec/apache2/mod_userdir.so\n-LoadModule php7_module libexec/apache2/libphp7.so\nInclude /private/etc/apache2/extra/httpd-userdir.conf\n```\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docs] Remove php7_module from httpd.conf module list
Summary: It's not available on new versions of macOS anyways.
Test Plan: I walked through these instructions today
Reviewers: atul, palys-swm
Reviewed By: atul, palys-swm
Subscribers: benschac, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3030 |
129,184 | 29.01.2022 15:05:25 | 18,000 | a3a57f69edb29084851ab27c1fecf4cb56c97bbb | [CommCoreModule] Implement `Client::send`
Summary: Filled out this boilerplate to communicate with dummy gRPC node server
Test Plan:
Was able to send stuff and see it on the other side
{F9982}
Reviewers: palys-swm, def-au1t, varun, karol-bisztyga, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"diff": "@@ -26,4 +26,17 @@ void NetworkModule::sendPong() {\nvoid NetworkModule::close() {\nthis->networkClient.reset();\n}\n+\n+grpc::Status NetworkModule::send(\n+ std::string sessionID,\n+ std::string toDeviceID,\n+ std::string payload,\n+ std::vector<std::string> blobHashes) {\n+\n+ if (!this->networkClient) {\n+ return grpc::Status::CANCELLED;\n+ }\n+ return this->networkClient->send(sessionID, toDeviceID, payload, blobHashes);\n+}\n+\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.h",
"diff": "@@ -14,6 +14,11 @@ public:\nconst std::string &deviceToken,\nconst std::string &hostname = \"\");\nvoid sendPong();\n+ grpc::Status send(\n+ std::string sessionID,\n+ std::string toDeviceID,\n+ std::string payload,\n+ std::vector<std::string> blobHashes);\nvoid close();\n};\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -66,5 +66,25 @@ void Client::sendPong() {\n}\n}\n+grpc::Status Client::send(\n+ std::string sessionID,\n+ std::string toDeviceID,\n+ std::string payload,\n+ std::vector<std::string> blobHashes) {\n+ grpc::ClientContext context;\n+ tunnelbroker::SendRequest request;\n+ google::protobuf::Empty response;\n+\n+ request.set_sessionid(sessionID);\n+ request.set_todeviceid(toDeviceID);\n+ request.set_payload(payload);\n+\n+ for (const auto &blob : blobHashes) {\n+ request.add_blobhashes(blob);\n+ }\n+\n+ return this->stub_->Send(&context, request, &response);\n+}\n+\n} // namespace network\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.h",
"new_path": "native/cpp/CommonCpp/grpc/Client.h",
"diff": "@@ -31,6 +31,12 @@ public:\nCheckResponseType checkIfPrimaryDeviceOnline();\nbool becomeNewPrimaryDevice();\nvoid sendPong();\n+\n+ grpc::Status send(\n+ std::string sessionID,\n+ std::string toDeviceID,\n+ std::string payload,\n+ std::vector<std::string> blobHashes);\n};\n} // namespace network\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Implement `Client::send`
Summary: Filled out this boilerplate to communicate with dummy gRPC node server
Test Plan:
Was able to send stuff and see it on the other side
{F9982}
Reviewers: palys-swm, def-au1t, varun, karol-bisztyga, ashoat
Reviewed By: palys-swm, karol-bisztyga, ashoat
Subscribers: benschac, ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2932 |
129,179 | 31.01.2022 13:42:58 | 18,000 | 9ce6b17f3c5868b1648cd8e8533cc4f7d54fa6c1 | [native] [refactor] remove unneed unread prop in thread ancestor
Summary: threadInfo has unread in it which is being passed down already
Test Plan: confirm unread functionality still works as expected.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/chat-thread-list-item.react.js",
"new_path": "native/chat/chat-thread-list-item.react.js",
"diff": "@@ -134,10 +134,7 @@ function ChatThreadListItem({\n<ColorSplotch color={data.threadInfo.color} size=\"profile\" />\n</View>\n<View style={styles.threadDetails}>\n- <ThreadAncestorsLabel\n- threadInfo={data.threadInfo}\n- unread={data.threadInfo.currentUser.unread}\n- />\n+ <ThreadAncestorsLabel threadInfo={data.threadInfo} />\n<View style={styles.row}>\n<SingleLine style={threadNameStyle}>\n{data.threadInfo.uiName}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/components/thread-ancestors-label.react.js",
"new_path": "native/components/thread-ancestors-label.react.js",
"diff": "@@ -11,10 +11,10 @@ import { useColors, useStyles } from '../themes/colors';\ntype Props = {\n+threadInfo: ThreadInfo,\n- +unread: ?boolean,\n};\nfunction ThreadAncestorsLabel(props: Props): React.Node {\n- const { unread, threadInfo } = props;\n+ const { threadInfo } = props;\n+ const { unread } = threadInfo.currentUser;\nconst styles = useStyles(unboundStyles);\nconst colors = useColors();\nconst ancestorThreads = useAncestorThreads(threadInfo);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] [refactor] remove unneed unread prop in thread ancestor
Summary: threadInfo has unread in it which is being passed down already
Test Plan: confirm unread functionality still works as expected.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2973 |
129,179 | 31.01.2022 16:45:50 | 18,000 | 92ef4cde7ede2bf4b6134f1fe5a3ed673c1fe5b5 | [web] swap font awesome plus for swm icon
Summary: use plus from swm per the design {F10398}
Test Plan: make sure icon renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -37,6 +37,9 @@ div.joinButtonContainer > a {\njustify-content: center;\ncursor: pointer;\n}\n+div.joinButtonContainer > a svg {\n+ color: var(--fg);\n+}\nspan.joinButtonText {\nfont-size: 18px;\ncolor: white;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.react.js",
"new_path": "web/chat/chat-input-bar.react.js",
"diff": "// @flow\n-import { faPlus } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport invariant from 'invariant';\nimport _difference from 'lodash/fp/difference';\nimport * as React from 'react';\n@@ -180,7 +178,7 @@ class ChatInputBar extends React.PureComponent<Props> {\n} else {\nbuttonContent = (\n<div>\n- <FontAwesomeIcon color=\"white\" icon={faPlus} />\n+ <SWMansionIcon icon=\"plus\" size={16} />\n<span className={css.joinButtonText}>Join Thread</span>\n</div>\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] swap font awesome plus for swm icon
Summary: use plus from swm per the design {F10398}
Test Plan: make sure icon renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2958 |
129,179 | 31.01.2022 17:28:58 | 18,000 | 7e16d29bddf6df127496392a2cd31bb13f8155ee | [web] fix bug safari thread menu icons positioned incorrectly
Summary:
on safari, there was a visual regression
Before: {F11351}
After: {F11350}
Test Plan: make sure browsers are consistent
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -112,7 +112,7 @@ div.sidebar .menu > button svg {\n.menu {\nposition: relative;\ndisplay: flex;\n- justify-content: end;\n+ justify-content: flex-end;\n}\n.menu > button {\nbackground-color: transparent;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] fix bug safari thread menu icons positioned incorrectly
Summary:
on safari, there was a visual regression
Before: {F11351}
After: {F11350}
https://stackoverflow.com/questions/54654050/difference-between-flex-end-and-end
Test Plan: make sure browsers are consistent
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3037 |
129,179 | 31.01.2022 18:09:25 | 18,000 | f22f5052dcc2862fc963e0b38b3360b23a87b5cb | [web] [move] settings button from settings --> components
Summary: move button to shared components file follow up with re-name
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "web/sidebar/settings-button.css",
"new_path": "web/components/settings-button.css",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "web/sidebar/settings-button.react.js",
"new_path": "web/components/settings-button.react.js",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.react.js",
"new_path": "web/sidebar/community-picker.react.js",
"diff": "import * as React from 'react';\n+import SettingsButton from '../components/settings-button.react';\nimport UserSettingsModal from '../modals/account/user-settings-modal.react.js';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './community-picker.css';\n-import SettingsButton from './settings-button.react';\ntype Props = { +setModal: (modal: ?React.Node) => void };\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [move] settings button from settings --> components
Summary: move button to shared components file follow up with re-name
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3040 |
129,179 | 31.01.2022 18:10:55 | 18,000 | 05e26115d33f543cc42ee8d1cb6ccd61d7f8592c | [web] [rename] settings button --> button
Summary: change name from settings button --> button
Test Plan: N/A make sure nothing breaks
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "RENAME",
"old_path": "web/components/settings-button.css",
"new_path": "web/components/button.css",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "web/components/settings-button.react.js",
"new_path": "web/components/button.react.js",
"diff": "import classnames from 'classnames';\nimport * as React from 'react';\n-import css from './settings-button.css';\n+import css from './button.css';\ntype Props = {\n+onClick: () => mixed,\n@@ -11,7 +11,7 @@ type Props = {\n+variant?: 'round',\n};\n-function SettingsButton(props: Props): React.Node {\n+function Button(props: Props): React.Node {\nconst { onClick, children, variant } = props;\nconst btnCls = classnames(css.btn, { [css.round]: variant === 'round' });\n@@ -22,4 +22,4 @@ function SettingsButton(props: Props): React.Node {\n);\n}\n-export default SettingsButton;\n+export default Button;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/sidebar/community-picker.react.js",
"new_path": "web/sidebar/community-picker.react.js",
"diff": "import * as React from 'react';\n-import SettingsButton from '../components/settings-button.react';\n+import Button from '../components/button.react';\nimport UserSettingsModal from '../modals/account/user-settings-modal.react.js';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './community-picker.css';\n@@ -20,9 +20,9 @@ function CommunityPicker(props: Props): React.Node {\n<div className={css.container}>\n<SWMansionIcon icon=\"inbox\" size={28} />\n<div className={css.spacer} />\n- <SettingsButton variant=\"round\" onClick={setModalToUserSettings}>\n+ <Button variant=\"round\" onClick={setModalToUserSettings}>\n<SWMansionIcon icon=\"settings\" size={16} />\n- </SettingsButton>\n+ </Button>\n</div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [rename] settings button --> button
Summary: change name from settings button --> button
Test Plan: N/A make sure nothing breaks
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3041 |
129,179 | 01.02.2022 08:03:26 | 18,000 | e168e9eb9126e3e4c3a57f23e22e8604c4ae8d3b | [web] create an input component
Summary: create generic input component
Test Plan: N/A its not used anywhere yet
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/input.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+type Props = {\n+ +type: string,\n+ +placeholder: string,\n+ +value: string,\n+ +onChange: (value: SyntheticEvent<HTMLInputElement>) => mixed,\n+ +disabled: boolean,\n+};\n+\n+function Input(props: Props, ref): React.Node {\n+ return <input {...props} ref={ref} />;\n+}\n+\n+const ForwardedInput: React.AbstractComponent<\n+ Props,\n+ HTMLInputElement,\n+> = React.forwardRef<Props, HTMLInputElement>(Input);\n+\n+export default ForwardedInput;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] create an input component
Summary: create generic input component
Test Plan: N/A its not used anywhere yet
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2964 |
129,179 | 01.02.2022 09:03:38 | 18,000 | d0fe8c657f58fd6b0cc45dd67dbcfeb4a2666496 | [web] replace html input modals with Input component
Summary:
replace input elements with components, will style inputs in the next diff.
{F11113}
{F11114}
Test Plan: make sure input forms work as expected in login / usersettings / delete
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -23,6 +23,7 @@ import {\nimport { useSelector } from '../../redux/redux-utils';\nimport { webLogInExtraInfoSelector } from '../../selectors/account-selectors';\n+import Input from '../input.react';\nimport Modal from '../modal.react';\nimport css from './user-settings-modal.css';\n@@ -67,7 +68,7 @@ class LogInModal extends React.PureComponent<Props, State> {\n<div>\n<div className={css['form-title']}>Username</div>\n<div className={css['form-content']}>\n- <input\n+ <Input\ntype=\"text\"\nplaceholder=\"Username\"\nvalue={this.state.username}\n@@ -80,7 +81,7 @@ class LogInModal extends React.PureComponent<Props, State> {\n<div>\n<div className={css['form-title']}>Password</div>\n<div className={css['form-content']}>\n- <input\n+ <Input\ntype=\"password\"\nplaceholder=\"Password\"\nvalue={this.state.password}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -27,6 +27,7 @@ import {\n} from 'lib/utils/action-utils';\nimport { useSelector } from '../../redux/redux-utils';\n+import Input from '../input.react';\nimport Modal from '../modal.react';\nimport css from './user-settings-modal.css';\n@@ -130,7 +131,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n<div className={css['form-title']}>New password</div>\n<div className={css['form-content']}>\n<div>\n- <input\n+ <Input\ntype=\"password\"\nplaceholder=\"New password\"\nvalue={this.state.newPassword}\n@@ -140,7 +141,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n/>\n</div>\n<div>\n- <input\n+ <Input\ntype=\"password\"\nplaceholder=\"Confirm new password\"\nvalue={this.state.confirmNewPassword}\n@@ -217,7 +218,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n</p>\n<div className={css['form-title']}>Current password</div>\n<div className={css['form-content']}>\n- <input\n+ <Input\ntype=\"password\"\nplaceholder=\"Current password\"\nvalue={this.state.currentPassword}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] replace html input modals with Input component
Summary:
replace input elements with components, will style inputs in the next diff.
{F11113}
{F11114}
Test Plan: make sure input forms work as expected in login / usersettings / delete
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3033 |
129,179 | 01.02.2022 09:07:40 | 18,000 | 6e4b1143d1de6f45075316840634ebf06593be54 | [web] add label to input component
Summary: add label for both design + accessability
Test Plan: everything should still work since the prop is optional
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/input.react.js",
"new_path": "web/modals/input.react.js",
"diff": "@@ -8,10 +8,23 @@ type Props = {\n+value: string,\n+onChange: (value: SyntheticEvent<HTMLInputElement>) => mixed,\n+disabled: boolean,\n+ +label?: string,\n+ id?: string,\n};\nfunction Input(props: Props, ref): React.Node {\n- return <input {...props} ref={ref} />;\n+ const { label: labelProps, id, ...rest } = props;\n+ let label;\n+ if (labelProps) {\n+ label = <label htmlFor={id}>{labelProps}</label>;\n+ }\n+\n+ return (\n+ <>\n+ {label}\n+ <input id={id} {...rest} ref={ref} />\n+ </>\n+ );\n}\nconst ForwardedInput: React.AbstractComponent<\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add label to input component
Summary: add label for both design + accessability https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label
Test Plan: everything should still work since the prop is optional
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3034 |
129,179 | 03.02.2022 11:35:34 | 18,000 | f897d84eb4ed4d79ca4670706de93b028200e3b1 | [web] [refactor] move ternary out of rendered css class
Summary: remove ternary from render and class name
Test Plan: make sure highlight still works.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -24,15 +24,12 @@ function SidebarItem(props: Props): React.Node {\nconst lastActivity = shortAbsoluteDate(lastUpdatedTime, timeZone);\nconst { unread } = threadInfo.currentUser;\n+ const unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });\nreturn (\n<a className={css.threadButton} onClick={onClick}>\n<div className={css.threadRow}>\n+ <div className={unreadCls}>{threadInfo.uiName}</div>\n<AlignRightIcon className={css.sidebarIcon} />\n- <div\n- className={classNames([css.sidebarTitle, unread ? css.unread : null])}\n- >\n- {threadInfo.uiName}\n- </div>\n<div\nclassName={classNames([\ncss.sidebarLastActivity,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] move ternary out of rendered css class
Summary: remove ternary from render and class name
Test Plan: make sure highlight still works.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3072 |
129,179 | 03.02.2022 13:44:27 | 18,000 | a639c3e550e52562f53f1b3f1baaf2e7192c1bb5 | [web] update icons from icomoon
Summary:
add icons, (long arrow right), edit chat bubble, bug
{F12013}
Test Plan: make sure icons still work correctly
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 31,\n+ \"paths\": [\n+ \"M34.133 887.467h-17.067v17.067h17.067v-17.067zM899.536 899.536c6.663-6.666 6.663-17.473 0-24.139l-108.612-108.609c-6.666-6.666-17.473-6.666-24.136 0-6.666 6.663-6.666 17.469 0 24.136l96.543 96.543-96.543 96.543c-6.666 6.666-6.666 17.473 0 24.136 6.663 6.666 17.469 6.666 24.136 0l108.612-108.609zM17.067-0v887.467h34.133v-887.467h-34.133zM34.133 904.533h853.333v-34.133h-853.333v34.133z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(128, 128, 128)\"\n+ }\n+ ],\n+ \"width\": 922,\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"long-right-angle-arrow\"],\n+ \"colorPermutations\": {\n+ \"128128128120420420412552552551\": [\n+ {\n+ \"f\": 0\n+ }\n+ ]\n+ }\n+ },\n{\n\"id\": 30,\n\"paths\": [\"M512 42.645v938.717M42.645 512h938.717\"],\n{\n\"id\": 26,\n\"paths\": [\n- \"M927.957 639.996c0 42.667-42.667 85.333-85.333 85.333h-511.999l-170.667 170.667v-640.001c0-42.667 42.667-85.333 85.333-85.333h597.332c42.667 0 85.333 42.667 85.333 85.333v384.001z\",\n- \"M373.375 341.333h341.334\",\n- \"M373.375 554.667h213.334\"\n+ \"M1030.442 650.040c0 55.217-55.217 110.433-110.433 110.433h-662.589l-220.862 220.862v-828.236c0-55.217 55.217-110.433 110.433-110.433h773.017c55.217 0 110.433 55.217 110.433 110.433v496.941z\",\n+ \"M312.75 263.536h441.724\",\n+ \"M312.75 539.615h276.079\"\n],\n\"attrs\": [\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n},\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n},\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n\"width\": 1067,\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n- \"grid\": 0,\n+ \"grid\": 24,\n\"tags\": [\"Filled\"],\n- \"colorPermutations\": {\n- \"204204204125525525513838381\": [\n- {\n- \"s\": 2\n- },\n- {\n- \"s\": 2\n- },\n- {\n- \"s\": 2\n- }\n- ]\n- }\n+ \"colorPermutations\": {}\n},\n{\n\"id\": 28,\n\"paths\": [\n- \"M352.263 32.769v79.872h79.872v159.744h159.742v-159.744h79.872v-79.872h79.872v79.872h-79.872v159.744h79.872v79.872h79.872v79.872h79.872v79.871h79.872v159.744h-79.872v-159.744h-79.872v239.616h-79.872v79.872h-79.872v79.872h79.872v79.872h-159.744v-159.744h-159.742v159.744h-159.744v-79.872h79.872v-79.872h-79.872v-79.872h-79.872v-239.616h-79.872v159.744h-79.872v-159.744h79.872v-79.871h79.872v-79.872h79.872v-79.872h79.872v-159.744h-79.872v-79.872h79.872zM671.749 432.129h-79.872v159.743h79.872v-159.743zM432.135 432.129h-79.872v159.743h79.872v-159.743z\"\n+ \"M338.039-9.905v86.984h86.984v173.97h173.966v-173.97h86.984v-86.984h86.984v86.984h-86.984v173.97h86.984v86.984h86.984v86.984h86.984v86.983h86.984v173.97h-86.984v-173.97h-86.984v260.954h-86.984v86.984h-86.984v86.984h86.984v86.984h-173.97v-173.97h-173.966v173.97h-173.97v-86.984h86.984v-86.984h-86.984v-86.984h-86.984v-260.954h-86.984v173.97h-86.984v-173.97h86.984v-86.983h86.984v-86.984h86.984v-86.984h86.984v-173.97h-86.984v-86.984h86.984zM685.975 425.017h-86.984v173.967h86.984v-173.967zM425.023 425.017h-86.984v173.967h86.984v-173.967z\"\n],\n\"attrs\": [\n{\n],\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n- \"grid\": 0,\n+ \"grid\": 24,\n\"tags\": [\"Union\"],\n\"colorPermutations\": {\n\"204204204125525525513838381\": [\n},\n\"selection\": [\n{\n- \"order\": 148,\n+ \"order\": 178,\n+ \"id\": 30,\n+ \"name\": \"right-angle-arrow\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 179,\n\"id\": 29,\n\"name\": \"plus\",\n\"prevSize\": 32\n},\n{\n- \"order\": 149,\n+ \"order\": 180,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n{\n- \"order\": 150,\n+ \"order\": 181,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n{\n- \"order\": 151,\n+ \"order\": 182,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 152,\n+ \"order\": 183,\n\"id\": 27,\n- \"name\": \"Union\",\n+ \"name\": \"bug\",\n\"prevSize\": 32\n},\n{\n- \"order\": 153,\n+ \"order\": 184,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n{\n- \"order\": 154,\n+ \"order\": 185,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n{\n- \"order\": 155,\n+ \"order\": 186,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n{\n- \"order\": 156,\n+ \"order\": 187,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n{\n- \"order\": 157,\n+ \"order\": 188,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 158,\n+ \"order\": 189,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 159,\n+ \"order\": 190,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 160,\n+ \"order\": 191,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n{\n- \"order\": 161,\n+ \"order\": 192,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n{\n- \"order\": 162,\n+ \"order\": 193,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 163,\n+ \"order\": 194,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 164,\n+ \"order\": 195,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n{\n- \"order\": 165,\n+ \"order\": 196,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n{\n- \"order\": 166,\n+ \"order\": 197,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n{\n- \"order\": 167,\n+ \"order\": 198,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n{\n- \"order\": 168,\n+ \"order\": 199,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n{\n- \"order\": 169,\n+ \"order\": 200,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n{\n- \"order\": 170,\n+ \"order\": 201,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n{\n- \"order\": 171,\n+ \"order\": 202,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n{\n- \"order\": 172,\n+ \"order\": 203,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 173,\n+ \"order\": 204,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 174,\n+ \"order\": 205,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n{\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 175,\n+ \"order\": 206,\n\"prevSize\": 32\n},\n{\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 176,\n+ \"order\": 207,\n\"prevSize\": 32\n}\n],\n},\n{\n\"selection\": [\n+ {\n+ \"order\": 0,\n+ \"id\": 6,\n+ \"name\": \"long-right-angle-arrow\",\n+ \"prevSize\": 32\n+ },\n{\n\"order\": 0,\n\"id\": 5,\n\"metadata\": {\n\"name\": \"Custom Icons\",\n\"importSize\": {\n- \"width\": 28,\n- \"height\": 28\n+ \"width\": 27,\n+ \"height\": 30\n}\n},\n\"height\": 1024,\n\"prevSize\": 32,\n\"icons\": [\n+ {\n+ \"id\": 6,\n+ \"paths\": [\n+ \"M34.133 887.467h-17.067v17.067h17.067v-17.067zM899.536 899.536c6.663-6.666 6.663-17.473 0-24.139l-108.612-108.609c-6.666-6.666-17.473-6.666-24.136 0-6.666 6.663-6.666 17.469 0 24.136l96.543 96.543-96.543 96.543c-6.666 6.666-6.666 17.473 0 24.136 6.663 6.666 17.469 6.666 24.136 0l108.612-108.609zM17.067 0v887.467h34.133v-887.467h-34.133zM34.133 904.533h853.333v-34.133h-853.333v34.133z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(128, 128, 128)\"\n+ }\n+ ],\n+ \"width\": 922,\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 0,\n+ \"tags\": [\"long-right-angle-arrow\"],\n+ \"colorPermutations\": {\n+ \"128128128120420420412552552551\": [\n+ {\n+ \"f\": 0\n+ }\n+ ]\n+ }\n+ },\n{\n\"id\": 5,\n\"paths\": [\n{\n\"s\": 2\n}\n+ ],\n+ \"128128128120420420412552552551\": [\n+ {\n+ \"s\": 2\n+ },\n+ {\n+ \"s\": 2\n+ },\n+ {\n+ \"s\": 2\n+ }\n]\n}\n},\n{\n\"f\": 1\n}\n+ ],\n+ \"128128128120420420412552552551\": [\n+ {\n+ \"f\": 1\n+ }\n]\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/icons/selection.json",
"new_path": "web/icons/selection.json",
"diff": "{\n\"IcoMoonType\": \"selection\",\n\"icons\": [\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M34.133 887.467h-17.067v17.067h17.067v-17.067zM899.536 899.536c6.663-6.666 6.663-17.473 0-24.139l-108.612-108.609c-6.666-6.666-17.473-6.666-24.136 0-6.666 6.663-6.666 17.469 0 24.136l96.543 96.543-96.543 96.543c-6.666 6.666-6.666 17.473 0 24.136 6.663 6.666 17.469 6.666 24.136 0l108.612-108.609zM17.067-0v887.467h34.133v-887.467h-34.133zM34.133 904.533h853.333v-34.133h-853.333v34.133z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(128, 128, 128)\"\n+ }\n+ ],\n+ \"width\": 922,\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"long-right-angle-arrow\"],\n+ \"colorPermutations\": {\n+ \"128128128120420420412552552551\": [\n+ {\n+ \"f\": 0\n+ }\n+ ]\n+ }\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(128, 128, 128)\"\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 178,\n+ \"id\": 30,\n+ \"name\": \"right-angle-arrow\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 0\n+ },\n{\n\"icon\": {\n\"paths\": [\"M512 42.645v938.717M42.645 512h938.717\"],\n}\n],\n\"properties\": {\n- \"order\": 148,\n+ \"order\": 179,\n\"id\": 29,\n\"name\": \"plus\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 0\n+ \"iconIdx\": 1\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 149,\n+ \"order\": 180,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 1\n+ \"iconIdx\": 2\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 150,\n+ \"order\": 181,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 2\n+ \"iconIdx\": 3\n},\n{\n\"icon\": {\n\"paths\": [\n- \"M927.957 639.996c0 42.667-42.667 85.333-85.333 85.333h-511.999l-170.667 170.667v-640.001c0-42.667 42.667-85.333 85.333-85.333h597.332c42.667 0 85.333 42.667 85.333 85.333v384.001z\",\n- \"M373.375 341.333h341.334\",\n- \"M373.375 554.667h213.334\"\n+ \"M1030.442 650.040c0 55.217-55.217 110.433-110.433 110.433h-662.589l-220.862 220.862v-828.236c0-55.217 55.217-110.433 110.433-110.433h773.017c55.217 0 110.433 55.217 110.433 110.433v496.941z\",\n+ \"M312.75 263.536h441.724\",\n+ \"M312.75 539.615h276.079\"\n],\n\"attrs\": [\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n},\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n},\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n\"width\": 1067,\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n- \"grid\": 0,\n+ \"grid\": 24,\n\"tags\": [\"Filled\"],\n- \"colorPermutations\": {\n- \"204204204125525525513838381\": [\n- {\n- \"s\": 2\n- },\n- {\n- \"s\": 2\n- },\n- {\n- \"s\": 2\n- }\n- ]\n- }\n+ \"colorPermutations\": {}\n},\n\"attrs\": [\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n},\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n},\n{\n\"fill\": \"none\",\n- \"stroke\": \"rgb(255, 255, 255)\",\n\"strokeLinejoin\": \"round\",\n\"strokeLinecap\": \"round\",\n\"strokeMiterlimit\": \"4\",\n}\n],\n\"properties\": {\n- \"order\": 151,\n+ \"order\": 182,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 3\n+ \"iconIdx\": 4\n},\n{\n\"icon\": {\n\"paths\": [\n- \"M352.263 32.769v79.872h79.872v159.744h159.742v-159.744h79.872v-79.872h79.872v79.872h-79.872v159.744h79.872v79.872h79.872v79.872h79.872v79.871h79.872v159.744h-79.872v-159.744h-79.872v239.616h-79.872v79.872h-79.872v79.872h79.872v79.872h-159.744v-159.744h-159.742v159.744h-159.744v-79.872h79.872v-79.872h-79.872v-79.872h-79.872v-239.616h-79.872v159.744h-79.872v-159.744h79.872v-79.871h79.872v-79.872h79.872v-79.872h79.872v-159.744h-79.872v-79.872h79.872zM671.749 432.129h-79.872v159.743h79.872v-159.743zM432.135 432.129h-79.872v159.743h79.872v-159.743z\"\n+ \"M338.039-9.905v86.984h86.984v173.97h173.966v-173.97h86.984v-86.984h86.984v86.984h-86.984v173.97h86.984v86.984h86.984v86.984h86.984v86.983h86.984v173.97h-86.984v-173.97h-86.984v260.954h-86.984v86.984h-86.984v86.984h86.984v86.984h-173.97v-173.97h-173.966v173.97h-173.97v-86.984h86.984v-86.984h-86.984v-86.984h-86.984v-260.954h-86.984v173.97h-86.984v-173.97h86.984v-86.983h86.984v-86.984h86.984v-86.984h86.984v-173.97h-86.984v-86.984h86.984zM685.975 425.017h-86.984v173.967h86.984v-173.967zM425.023 425.017h-86.984v173.967h86.984v-173.967z\"\n],\n\"attrs\": [\n{\n],\n\"isMulticolor\": false,\n\"isMulticolor2\": false,\n- \"grid\": 0,\n+ \"grid\": 24,\n\"tags\": [\"Union\"],\n\"colorPermutations\": {\n\"204204204125525525513838381\": [\n}\n],\n\"properties\": {\n- \"order\": 152,\n+ \"order\": 183,\n\"id\": 27,\n- \"name\": \"Union\",\n+ \"name\": \"bug\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 4\n+ \"iconIdx\": 5\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 153,\n+ \"order\": 184,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 5\n+ \"iconIdx\": 6\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 154,\n+ \"order\": 185,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 6\n+ \"iconIdx\": 7\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 155,\n+ \"order\": 186,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 7\n+ \"iconIdx\": 8\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 156,\n+ \"order\": 187,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 8\n+ \"iconIdx\": 9\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 157,\n+ \"order\": 188,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 9\n+ \"iconIdx\": 10\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 158,\n+ \"order\": 189,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 10\n+ \"iconIdx\": 11\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 159,\n+ \"order\": 190,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 11\n+ \"iconIdx\": 12\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 160,\n+ \"order\": 191,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 12\n+ \"iconIdx\": 13\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 161,\n+ \"order\": 192,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 13\n+ \"iconIdx\": 14\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 162,\n+ \"order\": 193,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 14\n+ \"iconIdx\": 15\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 163,\n+ \"order\": 194,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 15\n+ \"iconIdx\": 16\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 164,\n+ \"order\": 195,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 16\n+ \"iconIdx\": 17\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 165,\n+ \"order\": 196,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 17\n+ \"iconIdx\": 18\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 166,\n+ \"order\": 197,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 18\n+ \"iconIdx\": 19\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 167,\n+ \"order\": 198,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 19\n+ \"iconIdx\": 20\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 168,\n+ \"order\": 199,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 20\n+ \"iconIdx\": 21\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 169,\n+ \"order\": 200,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 21\n+ \"iconIdx\": 22\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 170,\n+ \"order\": 201,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 22\n+ \"iconIdx\": 23\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 171,\n+ \"order\": 202,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 23\n+ \"iconIdx\": 24\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 172,\n+ \"order\": 203,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 24\n+ \"iconIdx\": 25\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 173,\n+ \"order\": 204,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 25\n+ \"iconIdx\": 26\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 174,\n+ \"order\": 205,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 26\n+ \"iconIdx\": 27\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 175,\n+ \"order\": 206,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 27\n+ \"iconIdx\": 28\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 176,\n+ \"order\": 207,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 28\n+ \"iconIdx\": 29\n}\n],\n\"height\": 1024,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] update icons from icomoon
Summary:
add icons, (long arrow right), edit chat bubble, bug
{F12013}
Test Plan: make sure icons still work correctly
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3071 |
129,184 | 03.02.2022 20:52:43 | 18,000 | 95208a50de36a7d7b1c9f1b0ac5d7f7979478452 | [native] `codeVersion` -> 129 | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/build.gradle",
"new_path": "native/android/app/build.gradle",
"diff": "@@ -433,8 +433,8 @@ android {\napplicationId 'app.comm.android'\nminSdkVersion rootProject.ext.minSdkVersion\ntargetSdkVersion rootProject.ext.targetSdkVersion\n- versionCode 128\n- versionName '1.0.128'\n+ versionCode 129\n+ versionName '1.0.129'\nmissingDimensionStrategy 'react-native-camera', 'general'\nmultiDexEnabled true\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.debug.plist",
"new_path": "native/ios/Comm/Info.debug.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.128</string>\n+ <string>1.0.129</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>128</string>\n+ <string>129</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/Info.release.plist",
"new_path": "native/ios/Comm/Info.release.plist",
"diff": "<key>CFBundlePackageType</key>\n<string>APPL</string>\n<key>CFBundleShortVersionString</key>\n- <string>1.0.128</string>\n+ <string>1.0.129</string>\n<key>CFBundleSignature</key>\n<string>????</string>\n<key>CFBundleVersion</key>\n- <string>128</string>\n+ <string>129</string>\n<key>LSApplicationQueriesSchemes</key>\n<array>\n<string>org-appextension-feature-password-management</string>\n"
},
{
"change_type": "MODIFY",
"old_path": "native/redux/persist.js",
"new_path": "native/redux/persist.js",
"diff": "@@ -381,7 +381,7 @@ const persistConfig = {\ntimeout: ((__DEV__ ? 0 : undefined): number | void),\n};\n-const codeVersion = 128;\n+const codeVersion = 129;\n// This local exists to avoid a circular dependency where redux-setup needs to\n// import all the navigation and screen stuff, but some of those screens want to\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] `codeVersion` -> 129 |
129,179 | 03.02.2022 18:25:42 | 18,000 | e504fd23f89483129c896c236736f77d1a32ddf3 | [web] [fix] header word mark font
Summary:
we've been loading from google fonts this whole time. I removed it preemptively, re-adding the font
{F12417}
Test Plan: should work on prod now
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "server/src/responders/website-responders.js",
"new_path": "server/src/responders/website-responders.js",
"diff": "@@ -51,7 +51,7 @@ const baseHref = baseDomain + baseURL;\nconst access = promisify(fs.access);\nconst googleFontsURL =\n- 'https://fonts.googleapis.com/css?family=Open+Sans:300,600%7CAnaheim';\n+ 'https://fonts.googleapis.com/css?family=Open+Sans:300,600%7CAnaheim&family=IBM+Plex+Sans:wght@400;500&display=swap';\nconst localFontsURL = 'fonts/local-fonts.css';\nasync function getFontsURL() {\ntry {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] header word mark font
Summary:
we've been loading from google fonts this whole time. I removed it preemptively, re-adding the font
{F12417}
Test Plan: should work on prod now
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3100 |
129,184 | 03.02.2022 12:58:45 | 18,000 | d6b18aaeba2cb8698d8d6ea5a879843cebeec868 | [CommCoreModule] Split `ClientGetReadReactor` `.h` and `.cpp`
Summary: NA
Test Plan: Copy/paste/still builds
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga
Subscribers: Adrian, benschac | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"diff": "+#include \"ClientGetReadReactor.h\"\n+\n+ClientGetReadReactor::ClientGetReadReactor(\n+ tunnelbroker::TunnelbrokerService::Stub *stub,\n+ std::string sessionID)\n+ : sessionID{sessionID}, request{} {\n+ request.set_sessionid(sessionID);\n+ stub->async()->Get(&(this->context), &(this->request), this);\n+ StartRead(&(this->response));\n+ StartCall();\n+}\n+\n+void ClientGetReadReactor::OnReadDone(bool ok) {\n+ if (!ok) {\n+ return;\n+ }\n+ std::lock_guard<std::mutex> guard{this->onReadDoneCallbackMutex};\n+ if (this->onReadDoneCallback) {\n+ this->onReadDoneCallback(this->response.payload());\n+ }\n+ StartRead(&(this->response));\n+}\n+\n+void ClientGetReadReactor::close() {\n+ this->context.TryCancel();\n+}\n+\n+void ClientGetReadReactor::setOnOpenCallback(\n+ std::function<void()> onOpenCallback) {\n+ std::lock_guard<std::mutex> guard{this->onOpenCallbackMutex};\n+ this->onOpenCallback = onOpenCallback;\n+}\n+\n+void ClientGetReadReactor::setOnReadDoneCallback(\n+ std::function<void(std::string)> onReadDoneCallback) {\n+ std::lock_guard<std::mutex> guard{this->onReadDoneCallbackMutex};\n+ this->onReadDoneCallback = onReadDoneCallback;\n+}\n+\n+void ClientGetReadReactor::setOnCloseCallback(\n+ std::function<void()> onCloseCallback) {\n+ std::lock_guard<std::mutex> guard{this->onCloseCallbackMutex};\n+ this->onCloseCallback = onCloseCallback;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.h",
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.h",
"diff": "@@ -21,42 +21,13 @@ class ClientGetReadReactor\npublic:\nClientGetReadReactor(\ntunnelbroker::TunnelbrokerService::Stub *stub,\n- std::string sessionID)\n- : sessionID{sessionID}, request{} {\n- request.set_sessionid(sessionID);\n- stub->async()->Get(&(this->context), &(this->request), this);\n- StartRead(&(this->response));\n- StartCall();\n- }\n+ std::string sessionID);\n- void OnReadDone(bool ok) override {\n- if (!ok) {\n- return;\n- }\n- std::lock_guard<std::mutex> guard{this->onReadDoneCallbackMutex};\n- if (this->onReadDoneCallback) {\n- this->onReadDoneCallback(this->response.payload());\n- }\n- StartRead(&(this->response));\n- }\n+ void OnReadDone(bool ok) override;\n+ void close();\n+ void setOnOpenCallback(std::function<void()> onOpenCallback);\nvoid\n- setOnReadDoneCallback(std::function<void(std::string)> onReadDoneCallback) {\n- std::lock_guard<std::mutex> guard{this->onReadDoneCallbackMutex};\n- this->onReadDoneCallback = onReadDoneCallback;\n- }\n-\n- void setOnOpenCallback(std::function<void()> onOpenCallback) {\n- std::lock_guard<std::mutex> guard{this->onOpenCallbackMutex};\n- this->onOpenCallback = onOpenCallback;\n- }\n-\n- void setOnCloseCallback(std::function<void()> onCloseCallback) {\n- std::lock_guard<std::mutex> guard{this->onCloseCallbackMutex};\n- this->onCloseCallback = onCloseCallback;\n- }\n-\n- void close() {\n- this->context.TryCancel();\n- }\n+ setOnReadDoneCallback(std::function<void(std::string)> onReadDoneCallback);\n+ void setOnCloseCallback(std::function<void()> onCloseCallback);\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"new_path": "native/ios/Comm.xcodeproj/project.pbxproj",
"diff": "13B07FBC1A68108700A75B9A /* AppDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB01A68108700A75B9A /* AppDelegate.mm */; };\n13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; };\n13B07FC11A68108700A75B9A /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.m */; };\n+ 2DDA0AE067906E18B83A455C /* ClientGetReadReactor.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 2DDA00CA889DFF0ECB7E338D /* ClientGetReadReactor.cpp */; };\n71009A7726FDCA67002C8453 /* tunnelbroker.pb.cc in Sources */ = {isa = PBXBuildFile; fileRef = 71009A7326FDCA67002C8453 /* tunnelbroker.pb.cc */; };\n71009A7826FDCA67002C8453 /* tunnelbroker.grpc.pb.cc in Sources */ = {isa = PBXBuildFile; fileRef = 71009A7526FDCA67002C8453 /* tunnelbroker.grpc.pb.cc */; };\n71009A7B26FDCD72002C8453 /* Client.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 71009A7926FDCD71002C8453 /* Client.cpp */; };\n13B07FB51A68108700A75B9A /* Images.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; name = Images.xcassets; path = Comm/Images.xcassets; sourceTree = \"<group>\"; };\n13B07FB61A68108700A75B9A /* Info.release.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = Info.release.plist; path = Comm/Info.release.plist; sourceTree = \"<group>\"; };\n13B07FB71A68108700A75B9A /* main.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; name = main.m; path = Comm/main.m; sourceTree = \"<group>\"; };\n+ 2DDA00CA889DFF0ECB7E338D /* ClientGetReadReactor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ClientGetReadReactor.cpp; sourceTree = \"<group>\"; };\n2DDA05D6D8D20D885F22F82C /* SocketStatus.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SocketStatus.h; sourceTree = \"<group>\"; };\n71009A7326FDCA67002C8453 /* tunnelbroker.pb.cc */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = tunnelbroker.pb.cc; sourceTree = \"<group>\"; };\n71009A7426FDCA67002C8453 /* tunnelbroker.pb.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = tunnelbroker.pb.h; sourceTree = \"<group>\"; };\nB7BEE748279B3F2E009CCA35 /* GRPCStreamHostObject.h */,\n718A3C0626F22D0A00F04A8D /* _generated */,\nB72879B827A865EF008A04CC /* ClientGetReadReactor.h */,\n+ 2DDA00CA889DFF0ECB7E338D /* ClientGetReadReactor.cpp */,\n);\npath = grpc;\nsourceTree = \"<group>\";\n726E5D782731A5E10032361D /* GlobalNetworkSingleton.cpp in Sources */,\n13B07FC11A68108700A75B9A /* main.m in Sources */,\n71BE844B2636A944002849D2 /* SQLiteQueryExecutor.cpp in Sources */,\n+ 2DDA0AE067906E18B83A455C /* ClientGetReadReactor.cpp in Sources */,\n);\nrunOnlyForDeploymentPostprocessing = 0;\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Split `ClientGetReadReactor` `.h` and `.cpp`
Summary: NA
Test Plan: Copy/paste/still builds
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3094 |
129,179 | 07.02.2022 09:32:49 | 18,000 | 3409a2e59a4e989314df3f67c4491fae3a4ca86c | [web] [fix] input bar on multiline text input and image uploader
Summary: fixes current regression in web {F12649}
Test Plan: add multiline text, drag and drop image, upload image. It all should work
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -56,7 +56,7 @@ div.layout {\nheight: 100vh;\ndisplay: grid;\ngrid-template-columns: 244px repeat(12, 1fr);\n- grid-template-rows: 65px 1fr;\n+ grid-template-rows: 65px calc(100vh - 65px);\ngrid-template-areas:\n'nav nav nav nav nav nav nav nav nav nav nav nav nav'\n'sBar app app app app app app app app app app app app';\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] input bar on multiline text input and image uploader
Summary: fixes current regression in web {F12649}
Test Plan: add multiline text, drag and drop image, upload image. It all should work
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3115 |
129,190 | 08.02.2022 10:51:18 | -3,600 | f12c9ef9a3533cb0579b4423da87336f69552ae8 | [services] Backup - add AWS Tools
Summary:
This is needed for the database manager added later
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -37,7 +37,7 @@ set(_GRPC_CPP_PLUGIN_EXECUTABLE $<TARGET_FILE:gRPC::grpc_cpp_plugin>)\nset(BUILD_TESTING OFF CACHE BOOL \"Turn off tests\" FORCE)\n-find_package(AWSSDK REQUIRED COMPONENTS s3 core)\n+find_package(AWSSDK REQUIRED COMPONENTS core dynamodb)\nfind_package(Boost 1.40 COMPONENTS program_options REQUIRED)\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/AwsTools.cpp",
"diff": "+#include \"AwsTools.h\"\n+#include \"Constants.h\"\n+\n+namespace comm {\n+namespace network {\n+\n+std::unique_ptr<Aws::DynamoDB::DynamoDBClient> getDynamoDBClient() {\n+ Aws::Client::ClientConfiguration config;\n+ config.region = AWS_REGION;\n+ return std::make_unique<Aws::DynamoDB::DynamoDBClient>(config);\n+}\n+\n+} // namespace network\n+} // namespace comm\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/AwsTools.h",
"diff": "+#pragma once\n+\n+#include <aws/core/Aws.h>\n+#include <aws/dynamodb/DynamoDBClient.h>\n+\n+#include <memory>\n+\n+namespace comm {\n+namespace network {\n+\n+std::unique_ptr<Aws::DynamoDB::DynamoDBClient> getDynamoDBClient();\n+\n+} // namespace network\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - add AWS Tools
Summary:
This is needed for the database manager added later
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3080 |
129,190 | 08.02.2022 10:52:26 | -3,600 | 035dcc8fa6bedddb83fe8e83b223f5fa296b2a91 | [services] Backup - Database - add Item
Summary:
Parent class for all database items
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -62,6 +62,7 @@ endforeach()\ninclude_directories(\n./src\n+ ./src/DatabaseEntities\n./_generated\n${Boost_INCLUDE_DIR}\n${DEV_HEADERS_PATH}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/Item.h",
"diff": "+#pragma once\n+\n+#include <aws/core/Aws.h>\n+#include <aws/dynamodb/DynamoDBClient.h>\n+\n+#include <string>\n+\n+namespace comm {\n+namespace network {\n+namespace database {\n+\n+typedef Aws::Map<Aws::String, Aws::DynamoDB::Model::AttributeValue>\n+ AttributeValues;\n+\n+class Item {\n+ virtual void validate() const = 0;\n+\n+public:\n+ virtual std::string getTableName() const = 0;\n+ virtual std::string getPrimaryKey() const = 0;\n+ virtual void assignItemFromDatabase(const AttributeValues &itemFromDB) = 0;\n+};\n+\n+} // namespace database\n+} // namespace network\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Database - add Item
Summary:
Parent class for all database items
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3083 |
129,184 | 07.02.2022 08:09:02 | 18,000 | 3b8c3ee41ae5892170e805f4aaffd760c0aec6a8 | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSED` on `ClientGetReadReactor::OnDone`
Summary: Set `readyState` to `3: CLOSED` once the `Get()` stream is closed.
Test Plan: Logged `readyState` and it was as expected
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"diff": "@@ -53,3 +53,8 @@ void ClientGetReadReactor::OnReadInitialMetadataDone(bool ok) {\nstd::lock_guard<std::mutex> guard{this->setReadyStateMutex};\nthis->setReadyState(SocketStatus::OPEN);\n}\n+\n+void ClientGetReadReactor::OnDone(const grpc::Status &status) {\n+ std::lock_guard<std::mutex> guard{this->setReadyStateMutex};\n+ this->setReadyState(SocketStatus::CLOSED);\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.h",
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.h",
"diff": "@@ -28,6 +28,7 @@ public:\nvoid OnReadInitialMetadataDone(bool ok) override;\nvoid OnReadDone(bool ok) override;\n+ void OnDone(const grpc::Status &status) override;\nvoid close();\nvoid setOnOpenCallback(std::function<void()> onOpenCallback);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSED` on `ClientGetReadReactor::OnDone`
Summary: Set `readyState` to `3: CLOSED` once the `Get()` stream is closed.
Test Plan: Logged `readyState` and it was as expected
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, karol-bisztyga
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3121 |
129,184 | 07.02.2022 12:57:44 | 18,000 | 94cccc82926822e27cdf23c351cbae736e6e7fd8 | [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`
Summary:
Right now we're just hardcoding in `localhost`
[ignore: D3125]
Test Plan: Haven't tested with anything other than `localhost`... but continues to build/work as expected
Reviewers: ashoat, varun, def-au1t, karol-bisztyga, jimpo
Subscribers: palys-swm, Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -887,7 +887,8 @@ jsi::Value CommCoreModule::getUserOneTimeKeys(jsi::Runtime &rt) {\n});\n}\n-jsi::Object CommCoreModule::openSocket(jsi::Runtime &rt) {\n+jsi::Object\n+CommCoreModule::openSocket(jsi::Runtime &rt, const jsi::String &endpoint) {\nauto hostObject =\nstd::make_shared<GRPCStreamHostObject>(rt, this->jsInvoker_);\nreturn jsi::Object::createFromHostObject(rt, hostObject);\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "@@ -50,7 +50,8 @@ class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {\ninitializeCryptoAccount(jsi::Runtime &rt, const jsi::String &userId) override;\njsi::Value getUserPublicKey(jsi::Runtime &rt) override;\njsi::Value getUserOneTimeKeys(jsi::Runtime &rt) override;\n- jsi::Object openSocket(jsi::Runtime &rt) override;\n+ jsi::Object\n+ openSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;\npublic:\nCommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"diff": "@@ -61,7 +61,7 @@ static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getUserOneTimeKe\nreturn static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->getUserOneTimeKeys(rt);\n}\nstatic jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_openSocket(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\n- return static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->openSocket(rt);\n+ return static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->openSocket(rt, args[0].getString(rt));\n}\nCommCoreModuleSchemaCxxSpecJSI::CommCoreModuleSchemaCxxSpecJSI(std::shared_ptr<CallInvoker> jsInvoker)\n@@ -82,7 +82,7 @@ CommCoreModuleSchemaCxxSpecJSI::CommCoreModuleSchemaCxxSpecJSI(std::shared_ptr<C\nmethodMap_[\"initializeCryptoAccount\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_initializeCryptoAccount};\nmethodMap_[\"getUserPublicKey\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getUserPublicKey};\nmethodMap_[\"getUserOneTimeKeys\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getUserOneTimeKeys};\n- methodMap_[\"openSocket\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_openSocket};\n+ methodMap_[\"openSocket\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_openSocket};\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"diff": "@@ -34,7 +34,7 @@ virtual bool processThreadStoreOperationsSync(jsi::Runtime &rt, const jsi::Array\nvirtual jsi::Value initializeCryptoAccount(jsi::Runtime &rt, const jsi::String &userId) = 0;\nvirtual jsi::Value getUserPublicKey(jsi::Runtime &rt) = 0;\nvirtual jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) = 0;\n-virtual jsi::Object openSocket(jsi::Runtime &rt) = 0;\n+virtual jsi::Object openSocket(jsi::Runtime &rt, const jsi::String &endpoint) = 0;\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "@@ -44,7 +44,7 @@ export interface Spec extends TurboModule {\n+initializeCryptoAccount: (userId: string) => Promise<string>;\n+getUserPublicKey: () => Promise<string>;\n+getUserOneTimeKeys: () => Promise<string>;\n- +openSocket: () => Object;\n+ +openSocket: (endpoint: string) => Object;\n}\nexport default (TurboModuleRegistry.getEnforcing<Spec>(\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Add `endpoint: string` arg to `CommCoreModule.openSocket()`
Summary:
Right now we're just hardcoding in `localhost`
[ignore: D3125]
Test Plan: Haven't tested with anything other than `localhost`... but continues to build/work as expected
Reviewers: ashoat, varun, def-au1t, karol-bisztyga, jimpo
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3127 |
129,184 | 07.02.2022 15:21:12 | 18,000 | 10a6a24973e7cddf03a14dc1643526fb786e08ba | [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly
Summary: Shouldn't be able to set `readyState` from the JS side
Test Plan: NA, still builds as expected
Reviewers: ashoat, varun, karol-bisztyga, palys-swm, def-au1t, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"new_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"diff": "@@ -172,10 +172,7 @@ void GRPCStreamHostObject::set(\nconst jsi::Value &value) {\nauto propName = name.utf8(runtime);\n- if (propName == \"readyState\" && value.isNumber()) {\n- this->readyState = static_cast<int>(value.asNumber());\n- } else if (\n- propName == \"onopen\" && value.isObject() &&\n+ if (propName == \"onopen\" && value.isObject() &&\nvalue.asObject(runtime).isFunction(runtime)) {\nthis->onopen = value.asObject(runtime).asFunction(runtime);\n} else if (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Make `GRPCStreamHostObj.readyState` readonly
Summary: Shouldn't be able to set `readyState` from the JS side
Test Plan: NA, still builds as expected
Reviewers: ashoat, varun, karol-bisztyga, palys-swm, def-au1t, jimpo
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3128 |
129,184 | 06.02.2022 19:43:17 | 18,000 | a1375e4f3d073a68173f81f132ff1e03c4bc11f4 | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSING` on call to `ClientGetReadReactor::close()`
Summary: We don't really distinguish between `2: CLOSING` and `3: CLOSED` in `lib/socket.react.js`, but don't think it hurts to add this here.
Test Plan: Logged readyState
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"new_path": "native/cpp/CommonCpp/grpc/ClientGetReadReactor.cpp",
"diff": "@@ -22,6 +22,10 @@ void ClientGetReadReactor::OnReadDone(bool ok) {\n}\nvoid ClientGetReadReactor::close() {\n+ {\n+ std::lock_guard<std::mutex> guard{this->setReadyStateMutex};\n+ this->setReadyState(SocketStatus::CLOSING);\n+ }\nthis->context.TryCancel();\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Set `readyState` to `SocketStatus::CLOSING` on call to `ClientGetReadReactor::close()`
Summary: We don't really distinguish between `2: CLOSING` and `3: CLOSED` in `lib/socket.react.js`, but don't think it hurts to add this here.
Test Plan: Logged readyState
Reviewers: ashoat, palys-swm, def-au1t, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, karol-bisztyga
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3120 |
129,190 | 09.02.2022 09:24:15 | -3,600 | 6bdcf54ff77d454686e8e8c4eaf4966893ce1102 | [services] Backup - add constants
Summary:
Constant values for the backup service
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/Constants.h",
"diff": "+#pragma once\n+\n+#include <string>\n+\n+namespace comm {\n+namespace network {\n+\n+// 4MB limit\n+// WARNING: use keeping in mind that grpc adds its own headers to messages\n+// https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md\n+// so the message that actually is being sent over the network looks like this\n+// [Compressed-Flag] [Message-Length] [Message]\n+// [Compressed-Flag] 1 byte - added by grpc\n+// [Message-Length] 4 bytes - added by grpc\n+// [Message] N bytes - actual data\n+// so for every message we get 5 additional bytes of data\n+// as mentioned here\n+// https://github.com/grpc/grpc/issues/15734#issuecomment-396962671\n+// grpc stream may contain more than one message\n+const size_t GRPC_CHUNK_SIZE_LIMIT = 4 * 1024 * 1024;\n+const size_t GRPC_METADATA_SIZE_PER_MESSAGE = 5;\n+\n+const std::string AWS_REGION = \"us-east-2\";\n+\n+} // namespace network\n+} // namespace comm\n"
},
{
"change_type": "DELETE",
"old_path": "services/backup/docker-server/contents/server/src/Tools.h",
"new_path": null,
"diff": "-#pragma once\n-\n-namespace comm {\n-namespace network {\n-\n-// 4MB limit\n-const size_t GRPC_CHUNK_SIZE_LIMIT = 4 * 1024 * 1024;\n-\n-// 5MB limit\n-const size_t AWS_MULTIPART_UPLOAD_MINIMUM_CHUNK_SIZE = 5 * 1024 * 1024;\n-\n-enum class OBJECT_TYPE {\n- ENCRYPTED_BACKUP_KEY = 0,\n- TRANSACTION_LOGS = 1,\n- COMPACTION = 2,\n-};\n-\n-class invalid_argument_error : public std::runtime_error {\n-public:\n- invalid_argument_error(std::string errorMessage)\n- : std::runtime_error(errorMessage) {\n- }\n-};\n-\n-} // namespace network\n-} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - add constants
Summary:
Constant values for the backup service
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3079 |
129,179 | 09.02.2022 09:48:05 | 18,000 | 7fb384d842c746b9a12773de04fdc867f76c3b65 | [web] [fix] icon regression thread item
Summary: move icon back to where it once was {F13091}
Test Plan: should look like screen shot and where it was once before
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -28,8 +28,8 @@ function SidebarItem(props: Props): React.Node {\nreturn (\n<a className={css.threadButton} onClick={onClick}>\n<div className={css.threadRow}>\n- <div className={unreadCls}>{threadInfo.uiName}</div>\n<AlignRightIcon className={css.sidebarIcon} />\n+ <div className={unreadCls}>{threadInfo.uiName}</div>\n<div\nclassName={classNames([\ncss.sidebarLastActivity,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] icon regression thread item
Summary: move icon back to where it once was {F13091}
Test Plan: should look like screen shot and where it was once before
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3135 |
129,179 | 09.02.2022 09:52:44 | 18,000 | 0a8c046bee6be69c5dc1ab090ddfff2727e00d7c | [web] re-skin robo text
Summary: match figma more closely {F11967}
Test Plan:
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/robotext-message.css",
"new_path": "web/chat/robotext-message.css",
"diff": "div.robotextContainer {\ntext-align: center;\n- color: #333333;\n+ color: var(--fg);\npadding: 6px 0;\nmargin: 0 40px 5px 40px;\n- font-size: 15px;\n+ font-size: var(--s-font-14);\n+ line-height: var(--line-height-text);\n}\ndiv.innerRobotextContainer {\ndisplay: inline-flex;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] re-skin robo text
Summary: match figma more closely {F11967}
Test Plan: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77198
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3068 |
129,179 | 07.02.2022 11:40:17 | 18,000 | 891b4d0f11f01b9e2561eed537dc4470769381ed | [web] [refactor] thread-list-sidebar, active thread style to use classnames lib instead of ternary
Summary: use the classnames library rather than ternary.
Test Plan: Make sure active class still renders.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -18,9 +18,13 @@ function ChatThreadListSidebar(props: Props): React.Node {\nconst { threadInfo, mostRecentNonLocalMessage } = sidebarInfo;\nconst threadID = threadInfo.id;\nconst active = useThreadIsActive(threadID);\n- const activeStyle = active ? css.activeThread : null;\n+\nreturn (\n- <div className={classNames(css.thread, css.sidebar, activeStyle)}>\n+ <div\n+ className={classNames(css.thread, css.sidebar, {\n+ [css.activeThread]: active,\n+ })}\n+ >\n<SidebarItem sidebarInfo={sidebarInfo} />\n<ChatThreadListItemMenu\nthreadInfo={threadInfo}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] thread-list-sidebar, active thread style to use classnames lib instead of ternary
Summary: use the classnames library rather than ternary.
Test Plan: Make sure active class still renders.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3126 |
129,179 | 09.02.2022 10:15:47 | 18,000 | e6ae1375ea6cd5fcbad75c13986cd4d5d62baf5a | [web] [feat] thread menu button hoverable
Summary:
remove menu button for threads
updated with hover: {F13085}
note: arrow positioning updated in future diffs.
Test Plan: should render, look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -134,7 +134,12 @@ div.sidebar .menu > button svg {\nfont-size: 16px;\ncolor: var(--thread-color-read);\n}\n-\n+div.sidebar .menu {\n+ display: none;\n+}\n+div.sidebar:hover .menu {\n+ display: block;\n+}\n.menu {\nposition: relative;\ndisplay: flex;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [feat] thread menu button hoverable
Summary:
remove menu button for threads
updated with hover: {F13085}
note: arrow positioning updated in future diffs.
Test Plan: should render, look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3099 |
129,179 | 09.02.2022 10:21:17 | 18,000 | de6e7d38b1e484cccad6a3da89e934e6403ce93a | [web] re-skin timestamp in message component
Summary: match figma more closely {F11955}
Test Plan: match figma more closely
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -41,10 +41,9 @@ div.loading {\n}\ndiv.conversationHeader {\n- text-transform: uppercase;\ncolor: var(--chat-timestamp-color);\n- font-size: 14px;\n- padding: 7px 0;\n+ font-size: var(--xs-font-12);\n+ line-height: var(--line-height-text);\ntext-align: center;\n}\ndiv.conversationHeader:last-child {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] re-skin timestamp in message component
Summary: match figma more closely {F11955} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77595
Test Plan: match figma more closely
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3067 |
129,179 | 09.02.2022 10:32:04 | 18,000 | 48d8013dc7f6fef415a85b87ed1befb839e5368a | [web] [fix] Calendar is on two lines
Summary:
make calendar on one line
before: {F13166}
after: {F13165}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/calendar.css",
"new_path": "web/calendar/calendar.css",
"diff": "@@ -23,7 +23,7 @@ div.content {\nnav.nav {\ntext-align: center;\nmargin: 8px auto 12px auto;\n- width: 250px;\n+ width: 350px;\ncolor: #333333;\ndisplay: flex;\nalign-items: center;\n@@ -33,7 +33,7 @@ nav.nav > a.monthLink {\n}\nnav.nav > .monthName {\ndisplay: inline-block;\n- width: 200px;\n+ width: 250px;\ncolor: var(--fg);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] Calendar is on two lines
Summary:
make calendar on one line
before: {F13166}
after: {F13165}
Test Plan: should look like screen shot
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3141 |
129,185 | 09.02.2022 15:58:22 | -3,600 | 12859895cdf453ff96ca41a70d04d3ea3c4fba70 | [native] Use `useRelationshipPrompt` hook in `RelationshipPrompt`
Summary: Switch to newly introduced hook with native `RelationshipPrompt`.
Test Plan: The prompt behavior didn't change. Tested on virtual iOS device.
Reviewers: palys-swm, benschac, atul, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/chat/relationship-prompt.react.js",
"new_path": "native/chat/relationship-prompt.react.js",
"diff": "// @flow\n-import invariant from 'invariant';\nimport * as React from 'react';\nimport { Alert, Text, View } from 'react-native';\nimport Icon from 'react-native-vector-icons/FontAwesome5';\n-import {\n- updateRelationships as serverUpdateRelationships,\n- updateRelationshipsActionTypes,\n-} from 'lib/actions/relationship-actions';\n-import { getSingleOtherUser } from 'lib/shared/thread-utils';\n-import type { RelationshipAction } from 'lib/types/relationship-types';\n-import {\n- relationshipActions,\n- userRelationshipStatus,\n-} from 'lib/types/relationship-types';\n+import { useRelationshipPrompt } from 'lib/hooks/relationship-prompt';\n+import { userRelationshipStatus } from 'lib/types/relationship-types';\nimport type { ThreadInfo } from 'lib/types/thread-types';\nimport type { UserInfo } from 'lib/types/user-types';\n-import {\n- useDispatchActionPromise,\n- useServerCall,\n-} from 'lib/utils/action-utils';\nimport Button from '../components/button.react';\n-import { useSelector } from '../redux/redux-utils';\nimport { useStyles } from '../themes/colors';\ntype Props = {\n@@ -36,68 +22,17 @@ const RelationshipPrompt: React.ComponentType<Props> = React.memo<Props>(\npendingPersonalThreadUserInfo,\nthreadInfo,\n}: Props) {\n- // We're fetching the info from state because we need the most recent\n- // relationship status. Additionally, member info does not contain info\n- // about relationship.\n- const otherUserInfo = useSelector(state => {\n- const otherUserID =\n- getSingleOtherUser(threadInfo, state.currentUserInfo?.id) ??\n- pendingPersonalThreadUserInfo?.id;\n- const { userInfos } = state.userStore;\n- return otherUserID && userInfos[otherUserID]\n- ? userInfos[otherUserID]\n- : pendingPersonalThreadUserInfo;\n- });\n-\n- const callUpdateRelationships = useServerCall(serverUpdateRelationships);\n- const updateRelationship = React.useCallback(\n- async (action: RelationshipAction) => {\n- try {\n- invariant(otherUserInfo, 'Other user info should be present');\n- return await callUpdateRelationships({\n- action,\n- userIDs: [otherUserInfo.id],\n- });\n- } catch (e) {\n+ const onErrorCallback = React.useCallback(() => {\nAlert.alert('Unknown error', 'Uhh... try again?', [{ text: 'OK' }]);\n- throw e;\n- }\n- },\n- [callUpdateRelationships, otherUserInfo],\n- );\n-\n- const dispatchActionPromise = useDispatchActionPromise();\n- const onButtonPress = React.useCallback(\n- (action: RelationshipAction) => {\n- invariant(\n+ }, []);\n+ const {\notherUserInfo,\n- 'User info should be present when a button is clicked',\n- );\n- dispatchActionPromise(\n- updateRelationshipsActionTypes,\n- updateRelationship(action),\n- );\n- },\n- [dispatchActionPromise, otherUserInfo, updateRelationship],\n- );\n-\n- const blockUser = React.useCallback(\n- () => onButtonPress(relationshipActions.BLOCK),\n- [onButtonPress],\n- );\n- const unblockUser = React.useCallback(\n- () => onButtonPress(relationshipActions.UNBLOCK),\n- [onButtonPress],\n- );\n- const friendUser = React.useCallback(\n- () => onButtonPress(relationshipActions.FRIEND),\n- [onButtonPress],\n- );\n- const unfriendUser = React.useCallback(\n- () => onButtonPress(relationshipActions.UNFRIEND),\n- [onButtonPress],\n+ callbacks: { blockUser, unblockUser, friendUser, unfriendUser },\n+ } = useRelationshipPrompt(\n+ threadInfo,\n+ onErrorCallback,\n+ pendingPersonalThreadUserInfo,\n);\n-\nconst styles = useStyles(unboundStyles);\nif (\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `useRelationshipPrompt` hook in `RelationshipPrompt`
Summary: Switch to newly introduced hook with native `RelationshipPrompt`.
Test Plan: The prompt behavior didn't change. Tested on virtual iOS device.
Reviewers: palys-swm, benschac, atul, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2846 |
129,185 | 09.02.2022 17:36:05 | -3,600 | e081976919951cdaf98e6ed3fb3bd47c13d377e7 | [lib] Create hooks for common `DisconnectedBar` logic for web and native
Summary: Created hooks with common logic for web and mobile app.
Test Plan: Tested the hooks on mobile and web (in the next diffs)
Reviewers: palys-swm, benschac, atul, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "lib/hooks/disconnected-bar.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+import { useDispatch } from 'react-redux';\n+\n+import { updateDisconnectedBarActionType } from '../types/socket-types';\n+import { useSelector } from '../utils/redux-utils';\n+\n+function useDisconnectedBarVisibilityHandler(networkConnected: boolean): void {\n+ const dispatch = useDispatch();\n+ const disconnected = useSelector(\n+ state => state.connection.showDisconnectedBar,\n+ );\n+ const setDisconnected = React.useCallback(\n+ (newDisconnected: boolean) => {\n+ if (newDisconnected === disconnected) {\n+ return;\n+ }\n+ dispatch({\n+ type: updateDisconnectedBarActionType,\n+ payload: { visible: newDisconnected },\n+ });\n+ },\n+ [disconnected, dispatch],\n+ );\n+\n+ const networkActiveRef = React.useRef(true);\n+ React.useEffect(() => {\n+ networkActiveRef.current = networkConnected;\n+ if (!networkConnected) {\n+ setDisconnected(true);\n+ }\n+ }, [setDisconnected, networkConnected]);\n+\n+ const prevConnectionStatusRef = React.useRef();\n+ const connectionStatus = useSelector(state => state.connection.status);\n+ const someRequestIsLate = useSelector(\n+ state => state.connection.lateResponses.length !== 0,\n+ );\n+ React.useEffect(() => {\n+ const prevConnectionStatus = prevConnectionStatusRef.current;\n+ prevConnectionStatusRef.current = connectionStatus;\n+\n+ if (\n+ connectionStatus === 'connected' &&\n+ prevConnectionStatus !== 'connected'\n+ ) {\n+ // Sometimes NetInfo misses the network coming back online for some\n+ // reason. But if the socket reconnects, the network must be up\n+ networkActiveRef.current = true;\n+ setDisconnected(false);\n+ } else if (!networkActiveRef.current || someRequestIsLate) {\n+ setDisconnected(true);\n+ } else if (\n+ connectionStatus === 'reconnecting' ||\n+ connectionStatus === 'forcedDisconnecting'\n+ ) {\n+ setDisconnected(true);\n+ } else if (connectionStatus === 'connected') {\n+ setDisconnected(false);\n+ }\n+ }, [connectionStatus, someRequestIsLate, setDisconnected]);\n+}\n+\n+function useShouldShowDisconnectedBar(): {\n+ +disconnected: boolean,\n+ +shouldShowDisconnectedBar: boolean,\n+} {\n+ const disconnected = useSelector(\n+ state => state.connection.showDisconnectedBar,\n+ );\n+ const socketConnected = useSelector(\n+ state => state.connection.status === 'connected',\n+ );\n+\n+ const shouldShowDisconnectedBar = disconnected || !socketConnected;\n+ return { disconnected, shouldShowDisconnectedBar };\n+}\n+\n+type DisconnectedBarCause = 'connecting' | 'disconnected';\n+\n+function useDisconnectedBar(\n+ changeShowing: boolean => void,\n+): DisconnectedBarCause {\n+ const {\n+ disconnected,\n+ shouldShowDisconnectedBar,\n+ } = useShouldShowDisconnectedBar();\n+\n+ const prevShowDisconnectedBar = React.useRef();\n+ React.useEffect(() => {\n+ const wasShowing = prevShowDisconnectedBar.current;\n+ if (shouldShowDisconnectedBar && wasShowing === false) {\n+ changeShowing(true);\n+ } else if (!shouldShowDisconnectedBar && wasShowing) {\n+ changeShowing(false);\n+ }\n+ prevShowDisconnectedBar.current = shouldShowDisconnectedBar;\n+ }, [shouldShowDisconnectedBar, changeShowing]);\n+\n+ const [barCause, setBarCause] = React.useState<DisconnectedBarCause>(\n+ 'connecting',\n+ );\n+ React.useEffect(() => {\n+ if (shouldShowDisconnectedBar && disconnected) {\n+ setBarCause('disconnected');\n+ } else if (shouldShowDisconnectedBar) {\n+ setBarCause('connecting');\n+ }\n+ }, [shouldShowDisconnectedBar, disconnected]);\n+ return barCause;\n+}\n+\n+export {\n+ useDisconnectedBarVisibilityHandler,\n+ useShouldShowDisconnectedBar,\n+ useDisconnectedBar,\n+};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Create hooks for common `DisconnectedBar` logic for web and native
Summary: Created hooks with common logic for web and mobile app.
Test Plan: Tested the hooks on mobile and web (in the next diffs)
Reviewers: palys-swm, benschac, atul, ashoat
Reviewed By: palys-swm, benschac, ashoat
Subscribers: ashoat, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2848 |
129,185 | 09.02.2022 17:36:06 | -3,600 | 7188146230ea693c3f573f8c74df200e0317d784 | [native] Use `DisconnectedBar` logic from hook
Summary: Used newly introduced hooks in native app.
Test Plan: The change was teted on virtual iOS device with different network conditions. I didn't observed any behavior change.
Reviewers: palys-swm, atul, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "native/navigation/disconnected-bar-visibility-handler.react.js",
"new_path": "native/navigation/disconnected-bar-visibility-handler.react.js",
"diff": "// @flow\n-import * as React from 'react';\n-import { useDispatch } from 'react-redux';\n-\n-import { updateDisconnectedBarActionType } from 'lib/types/socket-types';\n+import { useDisconnectedBarVisibilityHandler } from 'lib/hooks/disconnected-bar';\nimport { useSelector } from '../redux/redux-utils';\nfunction DisconnectedBarVisibilityHandler(): null {\n- const dispatch = useDispatch();\n- const disconnected = useSelector(\n- state => state.connection.showDisconnectedBar,\n- );\n- const setDisconnected = React.useCallback(\n- (newDisconnected: boolean) => {\n- if (newDisconnected === disconnected) {\n- return;\n- }\n- dispatch({\n- type: updateDisconnectedBarActionType,\n- payload: { visible: newDisconnected },\n- });\n- },\n- [disconnected, dispatch],\n- );\n-\n- const networkActiveRef = React.useRef(true);\nconst networkConnected = useSelector(state => state.connectivity.connected);\n- React.useEffect(() => {\n- networkActiveRef.current = networkConnected;\n- if (!networkConnected) {\n- setDisconnected(true);\n- }\n- }, [setDisconnected, networkConnected]);\n-\n- const prevConnectionStatusRef = React.useRef();\n- const connectionStatus = useSelector(state => state.connection.status);\n- const someRequestIsLate = useSelector(\n- state => state.connection.lateResponses.length !== 0,\n- );\n- React.useEffect(() => {\n- const prevConnectionStatus = prevConnectionStatusRef.current;\n- prevConnectionStatusRef.current = connectionStatus;\n- if (\n- connectionStatus === 'connected' &&\n- prevConnectionStatus !== 'connected'\n- ) {\n- // Sometimes NetInfo misses the network coming back online for some\n- // reason. But if the socket reconnects, the network must be up\n- networkActiveRef.current = true;\n- setDisconnected(false);\n- } else if (!networkActiveRef.current || someRequestIsLate) {\n- setDisconnected(true);\n- } else if (\n- connectionStatus === 'reconnecting' ||\n- connectionStatus === 'forcedDisconnecting'\n- ) {\n- setDisconnected(true);\n- } else if (connectionStatus === 'connected') {\n- setDisconnected(false);\n- }\n- }, [connectionStatus, someRequestIsLate, setDisconnected]);\n+ useDisconnectedBarVisibilityHandler(networkConnected);\nreturn null;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [native] Use `DisconnectedBar` logic from hook
Summary: Used newly introduced hooks in native app.
Test Plan: The change was teted on virtual iOS device with different network conditions. I didn't observed any behavior change.
Reviewers: palys-swm, atul, benschac, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D2849 |
129,179 | 09.02.2022 13:29:24 | 18,000 | ac4520661c2a8d657b9db20cc397b808d2ba20b6 | [web] remove user settings borders
Summary:
{F12119}
No more white lines, will not land without all the modal updates
Test Plan: remove user settings borders from modal
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -38,7 +38,6 @@ div.modal-body input[type='submit'] {\nfont-size: 12px;\nmargin-right: 3px;\nborder-radius: 3px;\n- border: 1px solid var(--border-color);\nbackground-color: #f8f8f8;\nfont-weight: 600;\ncolor: #444444;\n@@ -65,7 +64,6 @@ div.modal-body div.form-footer {\njustify-content: space-between;\nalign-items: start;\nmargin-top: 5px;\n- border-top: 2px solid var(--border-color);\nmin-height: 26px;\npadding: 7px 4px 4px 0;\n}\n@@ -161,7 +159,6 @@ ul.tab-panel > li.delete-tab > a {\n}\ndiv.user-settings-current-password {\n- border-top: 2px solid var(--border-color);\npadding-top: 4px;\nmargin-top: 5px;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] remove user settings borders
Summary:
{F12119}
No more white lines, will not land without all the modal updates
Test Plan: remove user settings borders from modal
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3090 |
129,184 | 08.02.2022 16:18:08 | 18,000 | e0c71c04d2fd549863a206494f1becac8ec1bcbc | [CommCoreModule] Fill out `sessionSignature(deviceID) => toSign` boilerplate in `Client`
Summary: So we can hit `SessionSignature(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -127,5 +127,18 @@ void Client::assignSetReadyStateCallback(\nthis->clientGetReadReactor->assignSetReadyStateCallback(callback);\n}\n+std::string Client::sessionSignature(std::string deviceID) {\n+ grpc::ClientContext context;\n+ tunnelbroker::SessionSignatureRequest request;\n+ tunnelbroker::SessionSignatureResponse response;\n+\n+ request.set_deviceid(deviceID);\n+ auto status{this->stub_->SessionSignature(&context, request, &response)};\n+ if (!status.ok()) {\n+ return std::string{};\n+ }\n+ return response.tosign();\n+}\n+\n} // namespace network\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.h",
"new_path": "native/cpp/CommonCpp/grpc/Client.h",
"diff": "@@ -46,6 +46,8 @@ public:\nvoid setOnCloseCallback(std::function<void()> callback);\nvoid closeGetStream();\nvoid assignSetReadyStateCallback(std::function<void(SocketStatus)> callback);\n+\n+ std::string sessionSignature(std::string deviceID);\n};\n} // namespace network\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Fill out `sessionSignature(deviceID) => toSign` boilerplate in `Client`
Summary: So we can hit `SessionSignature(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, varun
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3143 |
129,184 | 08.02.2022 16:39:29 | 18,000 | b0280f92d3bab65a214bde91ddfde96821d43af6 | [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`
Summary: So we can hit `NewSession(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"new_path": "native/cpp/CommonCpp/grpc/Client.cpp",
"diff": "@@ -140,5 +140,32 @@ std::string Client::sessionSignature(std::string deviceID) {\nreturn response.tosign();\n}\n+std::string Client::newSession(\n+ std::string deviceID,\n+ std::string publicKey,\n+ std::string signature,\n+ std::string notifyToken,\n+ tunnelbroker::NewSessionRequest_DeviceTypes deviceType,\n+ std::string deviceAppVersion,\n+ std::string deviceOS) {\n+ grpc::ClientContext context;\n+ tunnelbroker::NewSessionRequest request;\n+ tunnelbroker::NewSessionResponse response;\n+\n+ request.set_deviceid(deviceID);\n+ request.set_publickey(publicKey);\n+ request.set_signature(signature);\n+ request.set_notifytoken(notifyToken);\n+ request.set_devicetype(deviceType);\n+ request.set_deviceappversion(deviceAppVersion);\n+ request.set_deviceos(deviceOS);\n+\n+ auto status{this->stub_->NewSession(&context, request, &response)};\n+ if (!status.ok()) {\n+ return std::string{};\n+ }\n+ return response.sessionid();\n+}\n+\n} // namespace network\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/Client.h",
"new_path": "native/cpp/CommonCpp/grpc/Client.h",
"diff": "@@ -48,6 +48,14 @@ public:\nvoid assignSetReadyStateCallback(std::function<void(SocketStatus)> callback);\nstd::string sessionSignature(std::string deviceID);\n+ std::string newSession(\n+ std::string deviceID,\n+ std::string publicKey,\n+ std::string signature,\n+ std::string notifyToken,\n+ tunnelbroker::NewSessionRequest_DeviceTypes deviceType,\n+ std::string deviceAppVersion,\n+ std::string deviceOS);\n};\n} // namespace network\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Fill out `newSession(...) => sessionID` boilerplate in `Client`
Summary: So we can hit `NewSession(...)` endpoint
Test Plan: Hit `tunnelbroker` with request and see if we get a response
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga, jimpo
Reviewed By: ashoat, varun
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3144 |
129,179 | 09.02.2022 14:45:58 | 18,000 | e97e636c9ec81d93a6f1780a9d5dad2091b79a03 | [web] add thread arrow
Summary: add arrow {F12369}
Test Plan: make sure it renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-see-more-sidebars.react.js",
"new_path": "web/chat/chat-thread-list-see-more-sidebars.react.js",
"diff": "import classNames from 'classnames';\nimport * as React from 'react';\n-import DotsThreeHorizontal from 'react-entypo-icons/lib/entypo/DotsThreeHorizontal';\nimport type { ThreadInfo } from 'lib/types/thread-types';\n@@ -29,7 +28,6 @@ function ChatThreadListSeeMoreSidebars(props: Props): React.Node {\n<div className={classNames(css.thread, css.sidebar)} onClick={onClick}>\n<a className={css.threadButton}>\n<div className={css.threadRow}>\n- <DotsThreeHorizontal className={css.sidebarIcon} />\n<div\nclassName={classNames([\ncss.sidebarTitle,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-sidebar.react.js",
"new_path": "web/chat/chat-thread-list-sidebar.react.js",
"diff": "@@ -21,7 +21,7 @@ function ChatThreadListSidebar(props: Props): React.Node {\nreturn (\n<div\n- className={classNames(css.thread, css.sidebar, {\n+ className={classNames(css.threadListSideBar, css.sidebar, {\n[css.activeThread]: active,\n})}\n>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -2,12 +2,25 @@ div.thread {\ndisplay: flex;\nflex-direction: row;\nalign-items: flex-start;\n- margin-bottom: 8px;\npadding-top: 4px;\npadding-bottom: 4px;\npadding-left: 16px;\npadding-right: 10px;\n}\n+div.threadListSideBar {\n+ display: flex;\n+ flex-direction: row;\n+ align-items: flex-start;\n+ padding-bottom: 4px;\n+ padding-left: 16px;\n+ padding-right: 10px;\n+ position: relative;\n+}\n+div.threadListSideBar > svg {\n+ position: absolute;\n+ top: -13px;\n+ left: 30px;\n+}\ndiv.thread:first-child {\npadding-top: 6px;\n}\n@@ -43,10 +56,11 @@ a.threadButton {\noverflow: hidden;\npadding-left: 8px;\n}\n-div.threadRow {\n- display: flex;\n- justify-content: space-between;\n- align-items: center;\n+.threadButtonSidebar {\n+ flex: 1;\n+ cursor: pointer;\n+ overflow: hidden;\n+ padding-left: 8px;\n}\np.breadCrumbs {\ndisplay: flex;\n@@ -67,6 +81,7 @@ span.breadCrumb {\nspan.breadCrumb svg {\ncolor: var(--fg);\n}\n+div.spacer,\ndiv.colorSplotch {\nheight: 40px;\nwidth: 40px;\n@@ -110,8 +125,7 @@ div.dark {\ndiv.italic {\nfont-style: italic;\n}\n-\n-div.thread div.sidebarTitle {\n+div.sidebarTitle {\nflex: 1;\nfont-size: 15px;\nwhite-space: nowrap;\n@@ -139,7 +153,8 @@ div.sidebar .menu {\ndisplay: none;\n}\ndiv.sidebar:hover .menu {\n- display: block;\n+ display: flex;\n+ align-self: flex-end;\n}\n.menu {\nposition: relative;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "import classNames from 'classnames';\nimport * as React from 'react';\n-import AlignRightIcon from 'react-entypo-icons/lib/entypo/AlignRight';\nimport type { SidebarInfo } from 'lib/types/thread-types';\nimport { shortAbsoluteDate } from 'lib/utils/date-utils';\nimport { useSelector } from '../redux/redux-utils';\nimport { useOnClickThread } from '../selectors/nav-selectors';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-thread-list.css';\ntype Props = {\n@@ -26,9 +26,11 @@ function SidebarItem(props: Props): React.Node {\nconst { unread } = threadInfo.currentUser;\nconst unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });\nreturn (\n- <a className={css.threadButton} onClick={onClick}>\n+ <>\n+ <SWMansionIcon icon=\"right-angle-arrow\" size={28} />\n+ <div className={css.spacer}></div>\n+ <a className={css.threadButtonSidebar} onClick={onClick}>\n<div className={css.threadRow}>\n- <AlignRightIcon className={css.sidebarIcon} />\n<div className={unreadCls}>{threadInfo.uiName}</div>\n<div\nclassName={classNames([\n@@ -40,6 +42,7 @@ function SidebarItem(props: Props): React.Node {\n</div>\n</div>\n</a>\n+ </>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add thread arrow
Summary: add arrow {F12369}
Test Plan: make sure it renders
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3095 |
129,179 | 09.02.2022 15:19:16 | 18,000 | 63c137107764589f1e337c80c59296acaf2cb616 | [web] button add, disabled and onClick
Summary: add additional types to button
Test Plan: make sure types are correct
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -6,17 +6,27 @@ import * as React from 'react';\nimport css from './button.css';\ntype Props = {\n- +onClick: () => mixed,\n+ +onClick: (event: SyntheticEvent<HTMLButtonElement>) => void,\n+children: React.Node,\n- +variant?: 'round',\n+ +variant?: 'primary' | 'round',\n+ +type?: string,\n+ +disabled?: boolean,\n};\nfunction Button(props: Props): React.Node {\n- const { onClick, children, variant } = props;\n- const btnCls = classnames(css.btn, { [css.round]: variant === 'round' });\n+ const { onClick, children, variant, type, disabled = false } = props;\n+ const btnCls = classnames(css.btn, {\n+ [css.round]: variant === 'round',\n+ [css.primary]: variant === 'primary',\n+ });\nreturn (\n- <button className={btnCls} onClick={onClick}>\n+ <button\n+ type={type}\n+ className={btnCls}\n+ onClick={onClick}\n+ disabled={disabled}\n+ >\n{children}\n</button>\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] button add, disabled and onClick
Summary: add additional types to button
Test Plan: make sure types are correct
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3093 |
129,179 | 09.02.2022 15:27:36 | 18,000 | aa5a009ee4d23615411be51ef8ff129f7d66fc25 | [web] add button primary variant
Summary:
add button primary
{F12121}
Test Plan: make sure button looks correct
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "justify-content: center;\nbackground: var(--settings-btn-bg);\nborder-color: transparent;\n+ font-size: var(--m-font-16);\n+}\n+\n+.primary {\n+ background: var(--btn-bg-primary);\n+ padding: 12px 24px;\n+ color: var(--fg);\n+ border-radius: 4px;\n}\n.round {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add button primary variant
Summary:
add button primary
{F12121}
Test Plan: make sure button looks correct
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3091 |
129,179 | 09.02.2022 15:36:02 | 18,000 | 0fad46c8844300314586ef06ba8d333b6a147e31 | [web] use button component in user-settings modal
Summary: use button component. It's not styled just yet, just importing {F11858}
Test Plan: make sure buttons work, render. functionality doesn't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -33,25 +33,6 @@ div.modal-body textarea {\ndiv.large-modal-container div.modal-body textarea {\nwidth: 275px;\n}\n-div.modal-body input[type='submit'] {\n- padding: 3px 9px;\n- font-size: 12px;\n- margin-right: 3px;\n- border-radius: 3px;\n- background-color: #f8f8f8;\n- font-weight: 600;\n- color: #444444;\n- margin-top: 1px;\n- cursor: pointer;\n-}\n-div.modal-body input[type='submit']:hover {\n- text-decoration: underline;\n-}\n-div.modal-body input[type='submit']:disabled {\n- cursor: initial;\n- text-decoration: none;\n- color: #999999;\n-}\ndiv.modal-body p.confirm-account-password {\npadding: 3px 0px 5px 0px;\nfont-style: italic;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -26,6 +26,7 @@ import {\nuseServerCall,\n} from 'lib/utils/action-utils';\n+import Button from '../../components/button.react';\nimport { useSelector } from '../../redux/redux-utils';\nimport Input from '../input.react';\nimport Modal from '../modal.react';\n@@ -107,7 +108,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n: undefined;\n}\n- onLogOut = (event: SyntheticEvent<HTMLAnchorElement>) => {\n+ onLogOut = (event: SyntheticEvent<HTMLButtonElement>) => {\nevent.preventDefault();\nthis.props.dispatchActionPromise(logOutActionTypes, this.logOut());\n};\n@@ -165,28 +166,34 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nlet buttons = null;\nif (this.state.currentTabType === 'delete') {\nbuttons = (\n- <input\n+ <Button\n+ variant=\"primary\"\ntype=\"submit\"\n- value=\"Delete account\"\nonClick={this.onDelete}\ndisabled={inputDisabled}\n- />\n+ >\n+ Delete account\n+ </Button>\n);\n} else {\nbuttons = (\n<>\n- <input\n+ <Button\ntype=\"submit\"\n- value=\"Update account\"\n+ variant=\"primary\"\nonClick={this.onSubmit}\ndisabled={inputDisabled}\n- />\n- <input\n+ >\n+ Update Account\n+ </Button>\n+ <Button\ntype=\"submit\"\n- value=\"Log out\"\n+ variant=\"primary\"\nonClick={this.onLogOut}\ndisabled={inputDisabled}\n- />\n+ >\n+ Log out\n+ </Button>\n</>\n);\n}\n@@ -270,7 +277,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nthis.setState({ currentPassword: target.value });\n};\n- onSubmit = (event: SyntheticEvent<HTMLInputElement>) => {\n+ onSubmit = (event: SyntheticEvent<HTMLButtonElement>) => {\nevent.preventDefault();\nif (this.state.newPassword === '') {\n@@ -351,7 +358,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n}\n}\n- onDelete = (event: SyntheticEvent<HTMLInputElement>) => {\n+ onDelete = (event: SyntheticEvent<HTMLButtonElement>) => {\nevent.preventDefault();\nthis.props.dispatchActionPromise(\ndeleteAccountActionTypes,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] use button component in user-settings modal
Summary: use button component. It's not styled just yet, just importing {F11858}
Test Plan: make sure buttons work, render. functionality doesn't break
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3056 |
129,179 | 09.02.2022 15:50:46 | 18,000 | 2972f61ef6e52f93449a4d66d04aa465db47ebf2 | [web] button secondary variant
Summary: add secondary variant to button {F11852}
Test Plan: should look like figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "border-radius: 4px;\n}\n+.secondary {\n+ border: 1px solid var(--btn-secondary-border);\n+ padding: 12px 24px;\n+ color: var(--fg);\n+ background: var(--shades-black-90);\n+ border-radius: 4px;\n+}\n+\n.round {\nwidth: 30px;\nheight: 30px;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -8,7 +8,7 @@ import css from './button.css';\ntype Props = {\n+onClick: (event: SyntheticEvent<HTMLButtonElement>) => void,\n+children: React.Node,\n- +variant?: 'primary' | 'round',\n+ +variant?: 'primary' | 'secondary' | 'round',\n+type?: string,\n+disabled?: boolean,\n};\n@@ -18,6 +18,7 @@ function Button(props: Props): React.Node {\nconst btnCls = classnames(css.btn, {\n[css.round]: variant === 'round',\n[css.primary]: variant === 'primary',\n+ [css.secondary]: variant === 'secondary',\n});\nreturn (\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -188,7 +188,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\n</Button>\n<Button\ntype=\"submit\"\n- variant=\"primary\"\n+ variant=\"secondary\"\nonClick={this.onLogOut}\ndisabled={inputDisabled}\n>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] button secondary variant
Summary: add secondary variant to button {F11852}
Test Plan: should look like figma https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1313%3A99486
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3057 |
129,179 | 09.02.2022 15:56:00 | 18,000 | 89e7ea9669538dfa6cbc2aeab8583a8dd443a471 | [web] add danger button variant
Summary: add danger button, should match figma {F11884}
Test Plan: button should still work as expected
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "background: var(--settings-btn-bg);\nborder-color: transparent;\nfont-size: var(--m-font-16);\n+ padding: 12px 24px;\n+ border-radius: 4px;\n}\n.primary {\nbackground: var(--btn-bg-primary);\n- padding: 12px 24px;\ncolor: var(--fg);\n- border-radius: 4px;\n}\n.secondary {\n+ background: var(--shades-black-90);\n+ color: var(--fg);\nborder: 1px solid var(--btn-secondary-border);\n- padding: 12px 24px;\n+}\n+\n+.danger {\n+ background: var(--btn-bg-danger);\ncolor: var(--fg);\n- background: var(--shades-black-90);\n- border-radius: 4px;\n}\n.round {\nwidth: 30px;\nheight: 30px;\nborder-radius: 50%;\n+ padding: 0;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -8,7 +8,7 @@ import css from './button.css';\ntype Props = {\n+onClick: (event: SyntheticEvent<HTMLButtonElement>) => void,\n+children: React.Node,\n- +variant?: 'primary' | 'secondary' | 'round',\n+ +variant?: 'primary' | 'secondary' | 'danger' | 'round',\n+type?: string,\n+disabled?: boolean,\n};\n@@ -19,6 +19,7 @@ function Button(props: Props): React.Node {\n[css.round]: variant === 'round',\n[css.primary]: variant === 'primary',\n[css.secondary]: variant === 'secondary',\n+ [css.danger]: variant === 'danger',\n});\nreturn (\n"
},
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.react.js",
"new_path": "web/modals/account/user-settings-modal.react.js",
"diff": "@@ -167,7 +167,7 @@ class UserSettingsModal extends React.PureComponent<Props, State> {\nif (this.state.currentTabType === 'delete') {\nbuttons = (\n<Button\n- variant=\"primary\"\n+ variant=\"danger\"\ntype=\"submit\"\nonClick={this.onDelete}\ndisabled={inputDisabled}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "/* Color Theme */\n--btn-bg-primary: var(--violet-dark-100);\n+ --btn-bg-danger: var(--error-primary);\n--chat-bg: var(--violet-dark-80);\n--chat-confirmation-icon: var(--violet-dark-100);\n--keyserver-selection: var(--violet-dark-60);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add danger button variant
Summary: add danger button, should match figma {F11884} https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1060%3A60514
Test Plan: button should still work as expected
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3060 |
129,179 | 09.02.2022 16:00:01 | 18,000 | 5de555ac9bed87a9350ab7a16273248958941f7c | [web] add className prop to btn
Summary: add className prop to support styling from the parent component
Test Plan: N/A
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -11,10 +11,18 @@ type Props = {\n+variant?: 'primary' | 'secondary' | 'danger' | 'round',\n+type?: string,\n+disabled?: boolean,\n+ +className?: string,\n};\nfunction Button(props: Props): React.Node {\n- const { onClick, children, variant, type, disabled = false } = props;\n+ const {\n+ onClick,\n+ children,\n+ variant,\n+ type,\n+ disabled = false,\n+ className = '',\n+ } = props;\nconst btnCls = classnames(css.btn, {\n[css.round]: variant === 'round',\n[css.primary]: variant === 'primary',\n@@ -25,7 +33,7 @@ function Button(props: Props): React.Node {\nreturn (\n<button\ntype={type}\n- className={btnCls}\n+ className={`${btnCls} ${className}`}\nonClick={onClick}\ndisabled={disabled}\n>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add className prop to btn
Summary: add className prop to support styling from the parent component
Test Plan: N/A
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3064 |
129,179 | 09.02.2022 16:08:48 | 18,000 | ae4a2601e7884430439230c8526cc63b3530eeaa | [web] [refactor] button classnames to be more terse
Summary: small refactor, buttons work the same
Test Plan: make sure buttons aren't busted
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -18,17 +18,12 @@ function Button(props: Props): React.Node {\nconst {\nonClick,\nchildren,\n- variant,\n+ variant = 'primary',\ntype,\ndisabled = false,\nclassName = '',\n} = props;\n- const btnCls = classnames(css.btn, {\n- [css.round]: variant === 'round',\n- [css.primary]: variant === 'primary',\n- [css.secondary]: variant === 'secondary',\n- [css.danger]: variant === 'danger',\n- });\n+ const btnCls = classnames(css.btn, css[variant]);\nreturn (\n<button\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] button classnames to be more terse
Summary: small refactor, buttons work the same
Test Plan: make sure buttons aren't busted
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3065 |
129,179 | 09.02.2022 16:16:00 | 18,000 | e3a5b8c7b86a9fd05455b4ba69deca2f26c72919 | [web] [fix] a login button to modal
Summary: add button component to login modal. more design work to be done soon {F13109}
Test Plan: make sure login still works
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/log-in-modal.react.js",
"new_path": "web/modals/account/log-in-modal.react.js",
"diff": "@@ -21,6 +21,7 @@ import {\nuseServerCall,\n} from 'lib/utils/action-utils';\n+import Button from '../../components/button.react';\nimport { useSelector } from '../../redux/redux-utils';\nimport { webLogInExtraInfoSelector } from '../../selectors/account-selectors';\nimport Input from '../input.react';\n@@ -92,12 +93,13 @@ class LogInModal extends React.PureComponent<Props, State> {\n</div>\n</div>\n<div className={css['form-footer']}>\n- <input\n+ <Button\ntype=\"submit\"\n- value=\"Log in\"\nonClick={this.onSubmit}\ndisabled={this.props.inputDisabled}\n- />\n+ >\n+ Log in\n+ </Button>\n<div className={css['modal-form-error']}>\n{this.state.errorMessage}\n</div>\n@@ -128,7 +130,7 @@ class LogInModal extends React.PureComponent<Props, State> {\nthis.setState({ password: target.value });\n};\n- onSubmit = (event: SyntheticEvent<HTMLInputElement>) => {\n+ onSubmit = (event: SyntheticEvent<HTMLButtonElement>) => {\nevent.preventDefault();\nif (this.state.username.search(validEmailRegex) > -1) {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] a login button to modal
Summary: add button component to login modal. more design work to be done soon {F13109}
Test Plan: make sure login still works
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3136 |
129,179 | 09.02.2022 16:28:16 | 18,000 | d40b754693a3fb9e1667b593fed30a1aee61d1a3 | [web] clean up modal design
Summary: clean up modal , interm. CSS as a whole needs work to get this a lot closer to the intended design.{F11969}
Test Plan: N/A, make sure modal still works.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/modals/account/user-settings-modal.css",
"new_path": "web/modals/account/user-settings-modal.css",
"diff": "@@ -34,19 +34,15 @@ div.large-modal-container div.modal-body textarea {\nwidth: 275px;\n}\ndiv.modal-body p.confirm-account-password {\n- padding: 3px 0px 5px 0px;\n- font-style: italic;\n- font-size: 13px;\ncolor: #777777;\n+ margin-bottom: 4px;\n+ color: var(--fg);\n}\ndiv.modal-body div.form-footer {\ndisplay: flex;\nflex-direction: row-reverse;\njustify-content: space-between;\n- align-items: start;\n- margin-top: 5px;\n- min-height: 26px;\n- padding: 7px 4px 4px 0;\n+ padding-top: 8px;\n}\ndiv.modal-body div.form-footer div.modal-form-error {\nfont-size: 12px;\n@@ -77,6 +73,9 @@ div.modal-body div.form-content {\nfont-family: var(--font-stack);\ncolor: var(--fg);\n}\n+div.modal-body div.form-content input {\n+ margin-bottom: 4px;\n+}\ndiv.modal-body div.form-subtitle {\nfont-size: 12px;\npadding-left: 4px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] clean up modal design
Summary: clean up modal , interm. CSS as a whole needs work to get this a lot closer to the intended design.{F11969}
Test Plan: N/A, make sure modal still works.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3063 |
129,179 | 10.02.2022 09:34:43 | 18,000 | 6a808278513c3a944f4ea5e1f1f301208cd7e923 | [web] [remove] no longer use "react-entypo-icons"
Summary: remove package, icons aren't used in the project
Test Plan: make sure app doesn't crash
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/package.json",
"new_path": "web/package.json",
"diff": "\"react-dnd\": \"^11.1.3\",\n\"react-dnd-html5-backend\": \"^11.1.3\",\n\"react-dom\": \"17.0.2\",\n- \"react-entypo-icons\": \"^1.4.1\",\n\"react-feather\": \"^2.0.3\",\n\"react-hot-loader\": \"^4.12.14\",\n\"react-icomoon\": \"^2.4.1\",\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "@@ -14136,11 +14136,6 @@ react-dragula@^1.1.17:\natoa \"1.0.0\"\ndragula \"3.7.2\"\n-react-entypo-icons@^1.4.1:\n- version \"1.4.1\"\n- resolved \"https://registry.yarnpkg.com/react-entypo-icons/-/react-entypo-icons-1.4.1.tgz#f7403adeb36d9b2b7e66c6dca7e6ad5baee1fd95\"\n- integrity sha512-XaFvXW1SqymEn3+rdxHsdoKXeHBjM3BOI1N5gDSyedmy+wGUPeyzDDV0PCS8f8V8d1GWJAwb+0rydfi61aR6wQ==\n-\nreact-fast-compare@2.0.4:\nversion \"2.0.4\"\nresolved \"https://registry.yarnpkg.com/react-fast-compare/-/react-fast-compare-2.0.4.tgz#e84b4d455b0fec113e0402c329352715196f81f9\"\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [remove] no longer use "react-entypo-icons"
Summary: remove package, icons aren't used in the project
Test Plan: make sure app doesn't crash
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3096 |
129,179 | 10.02.2022 09:37:43 | 18,000 | ae0985dee4bc941125634b4ad51ae900b371d370 | [web] [theme] you need permission, update theme, center content
Summary:
before: {F13156}
after: {F13155}
Test Plan: make sure it looks okay
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-input-bar.css",
"new_path": "web/chat/chat-input-bar.css",
"diff": "@@ -63,9 +63,9 @@ p.joinButtonText {\npadding-left: 12px;\n}\nspan.explanation {\n- color: #777777;\n+ color: var(--permission-color);\ntext-align: center;\n- padding-top: 4px;\n+ padding-top: 20px;\npadding-bottom: 8px;\n}\na.multimediaUpload {\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--disconnected-bar-alert-color: var(--shades-white-100);\n--disconnected-bar-connecting-bg: var(--shades-white-70);\n--disconnected-bar-connecting-color: var(--shades-black-100);\n+ --permission-color: var(--shades-white-60);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [theme] you need permission, update theme, center content
Summary:
before: {F13156}
after: {F13155}
Test Plan: make sure it looks okay
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3140 |
129,184 | 09.02.2022 14:53:23 | 18,000 | 0ae429c073d6897430975dfc850b85f8f69d132d | [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to `NetworkModule`
Summary: NA, boilerplate (should've been squashed with previous `Client` diffs)
Test Plan: Continues to build, able to call
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.cpp",
"diff": "@@ -83,4 +83,32 @@ void NetworkModule::assignSetReadyStateCallback(\nthis->networkClient->assignSetReadyStateCallback(callback);\n}\n+std::string NetworkModule::sessionSignature(std::string deviceID) {\n+ if (!this->networkClient) {\n+ return std::string{};\n+ }\n+ return this->networkClient->sessionSignature(deviceID);\n+}\n+\n+std::string NetworkModule::newSession(\n+ std::string deviceID,\n+ std::string publicKey,\n+ std::string signature,\n+ std::string notifyToken,\n+ tunnelbroker::NewSessionRequest_DeviceTypes deviceType,\n+ std::string deviceAppVersion,\n+ std::string deviceOS) {\n+ if (!this->networkClient) {\n+ return std::string{};\n+ }\n+ return this->networkClient->newSession(\n+ deviceID,\n+ publicKey,\n+ signature,\n+ notifyToken,\n+ deviceType,\n+ deviceAppVersion,\n+ deviceOS);\n+}\n+\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/InternalModules/NetworkModule.h",
"diff": "@@ -27,5 +27,15 @@ public:\nvoid setOnOpenCallback(std::function<void()> callback);\nvoid setOnCloseCallback(std::function<void()> callback);\nvoid assignSetReadyStateCallback(std::function<void(SocketStatus)> callback);\n+\n+ std::string sessionSignature(std::string deviceID);\n+ std::string newSession(\n+ std::string deviceID,\n+ std::string publicKey,\n+ std::string signature,\n+ std::string notifyToken,\n+ tunnelbroker::NewSessionRequest_DeviceTypes deviceType,\n+ std::string deviceAppVersion,\n+ std::string deviceOS);\n};\n} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Add `sessionSignature` & `newSession` boilerplate to `NetworkModule`
Summary: NA, boilerplate (should've been squashed with previous `Client` diffs)
Test Plan: Continues to build, able to call
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3152 |
129,184 | 09.02.2022 15:07:51 | 18,000 | 6441b1c3300b6d2138253780279331229a6d1701 | [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`
Summary: We need `deviceOS` for `SessionSignature(...)` unary gRPC call
Test Plan: Call function and log result. Only tested on iOS thus far, will test android before landing
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/android/app/src/cpp/PlatformSpecificTools.cpp",
"new_path": "native/android/app/src/cpp/PlatformSpecificTools.cpp",
"diff": "@@ -33,4 +33,8 @@ void PlatformSpecificTools::generateSecureRandomBytes(\nbuffer = PlatformSpecificToolsJavaClass::generateSecureRandomBytes(size);\n}\n+std::string PlatformSpecificTools::getDeviceOS() {\n+ return std::string{\"android\"};\n+}\n+\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/Tools/PlatformSpecificTools.h",
"new_path": "native/cpp/CommonCpp/Tools/PlatformSpecificTools.h",
"diff": "@@ -7,6 +7,7 @@ namespace comm {\nclass PlatformSpecificTools {\npublic:\nstatic void generateSecureRandomBytes(crypto::OlmBuffer &buffer, size_t size);\n+ static std::string getDeviceOS();\n};\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/ios/Comm/PlatformSpecificTools.mm",
"new_path": "native/ios/Comm/PlatformSpecificTools.mm",
"diff": "@@ -19,4 +19,8 @@ void PlatformSpecificTools::generateSecureRandomBytes(\n}\n}\n+std::string PlatformSpecificTools::getDeviceOS() {\n+ return std::string{\"ios\"};\n+}\n+\n};\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `PlatformSpecificTools::getDeviceOS()`
Summary: We need `deviceOS` for `SessionSignature(...)` unary gRPC call
Test Plan: Call function and log result. Only tested on iOS thus far, will test android before landing
Reviewers: ashoat, def-au1t, varun, palys-swm, karol-bisztyga, jimpo
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3153 |
129,184 | 09.02.2022 15:40:23 | 18,000 | 2671925ca5b2017d4bea51656fd0b23c24d54f7f | [CommCoreModule] Use `CONNECTING` instead of `0` in `readyState` initialization
Summary: Super minor fix, should've switched this over when we introduced the `SocketStatus` enum
Test Plan: Still builds
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"new_path": "native/cpp/CommonCpp/grpc/GRPCStreamHostObject.cpp",
"diff": "@@ -7,7 +7,7 @@ using namespace facebook;\nGRPCStreamHostObject::GRPCStreamHostObject(\njsi::Runtime &rt,\nstd::shared_ptr<react::CallInvoker> jsInvoker)\n- : readyState{0},\n+ : readyState{SocketStatus::CONNECTING},\nonopen{},\nonmessage{},\nonclose{},\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Use `CONNECTING` instead of `0` in `readyState` initialization
Summary: Super minor fix, should've switched this over when we introduced the `SocketStatus` enum
Test Plan: Still builds
Reviewers: ashoat, def-au1t, palys-swm, varun, karol-bisztyga
Reviewed By: ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3154 |
129,179 | 11.02.2022 10:02:36 | 18,000 | 4fb8282eeede012c90fda4ac2cc8641e7220470f | [web] add sidebar icon
Summary: add icon per figma {F13879}
Test Plan: make sure its the right icon. More updates to design coming in future diffs.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-button.js",
"new_path": "web/chat/message-action-button.js",
"diff": "// @flow\n-import { faEllipsisH } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport classNames from 'classnames';\nimport invariant from 'invariant';\nimport * as React from 'react';\n@@ -13,6 +11,7 @@ import {\nuseOnClickThread,\nuseOnClickPendingSidebar,\n} from '../selectors/nav-selectors';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport css from './message-action-button.css';\nimport type {\nItemAndContainerPositionInfo,\n@@ -121,7 +120,7 @@ function MessageActionButton(props: MessageActionTooltipProps): React.Node {\nonMouseLeave={hideTooltip}\nonClick={toggleTooltip}\n>\n- <FontAwesomeIcon icon={faEllipsisH} />\n+ <SWMansionIcon icon=\"message-circle-lines\" size={18} />\n{tooltipMenu}\n</div>\n</div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add sidebar icon
Summary: add icon per figma {F13879}
Test Plan: make sure its the right icon. More updates to design coming in future diffs.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3166 |
129,179 | 11.02.2022 10:04:09 | 18,000 | 3b7e9222ae6b69d307d9b8b2ab0dfc0b43cccdbb | [web] add icons, reply and chevron small
Summary: screenshot, add these two {F13851}
Test Plan: n/a make sure icons in the app don't break
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 64,\n+ \"paths\": [\"M426.667 725.333l213.333-213.333-213.333-213.333\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 48.39319864908854\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-chevron-right-small\"]\n+ },\n+ {\n+ \"id\": 32,\n+ \"paths\": [\n+ \"M533.389 541.632l140.078 6.734c165.089 7.937 321.791 44.079 457.491 103.643-15.611-16.392-33.157-32.377-52.652-47.834-101.519-80.46-249.46-139.969-423.048-155.341l-121.869-10.792v-221.307l-357.991 295.265 357.991 295.265v-265.633zM1352.619 785.772c0.187 0.847 0.365 1.694 0.544 2.542 1.443 6.835 2.709 13.711 3.787 20.624 3.208 20.412 4.847 41.155 4.847 62.167 0 41.34-50.692 54.84-82.076 27.939-11.156-9.56-22.785-18.879-34.85-27.939-5.23-3.925-10.541-7.803-15.933-11.63-0.365-0.258-0.731-0.517-1.096-0.775-112.488-79.532-260.27-137.512-427.136-163.366-43.36-6.718-88.007-11.268-133.659-13.463v267.144c0 56.502-65.764 87.502-109.352 51.557l-529.852-437.015c-32.409-26.731-32.409-76.381 0-103.112l529.851-437.014c43.589-35.951 109.352-4.946 109.352 51.556v240.709c351.894 31.162 632.205 224.318 685.571 470.076z\"\n+ ],\n+ \"attrs\": [],\n+ \"width\": 1365.3333333333321,\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"reply-arrow\"],\n+ \"colorPermutations\": {}\n+ },\n{\n\"id\": 31,\n\"paths\": [\n},\n\"selection\": [\n{\n- \"order\": 178,\n+ \"order\": 311,\n+ \"id\": 63,\n+ \"name\": \"chevron-right-small\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 312,\n+ \"id\": 31,\n+ \"name\": \"reply-arrow\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 313,\n\"id\": 30,\n\"name\": \"right-angle-arrow\",\n\"prevSize\": 32\n},\n{\n- \"order\": 179,\n+ \"order\": 314,\n\"id\": 29,\n\"name\": \"plus\",\n\"prevSize\": 32\n},\n{\n- \"order\": 180,\n+ \"order\": 315,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n{\n- \"order\": 181,\n+ \"order\": 316,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n{\n- \"order\": 182,\n+ \"order\": 317,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 183,\n+ \"order\": 318,\n\"id\": 27,\n\"name\": \"bug\",\n\"prevSize\": 32\n},\n{\n- \"order\": 184,\n+ \"order\": 319,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n{\n- \"order\": 185,\n+ \"order\": 320,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n{\n- \"order\": 186,\n+ \"order\": 321,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n{\n- \"order\": 187,\n+ \"order\": 322,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n{\n- \"order\": 188,\n+ \"order\": 323,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 189,\n+ \"order\": 324,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 190,\n+ \"order\": 325,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 191,\n+ \"order\": 326,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n{\n- \"order\": 192,\n+ \"order\": 327,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n{\n- \"order\": 193,\n+ \"order\": 328,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 194,\n+ \"order\": 329,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 195,\n+ \"order\": 330,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n{\n- \"order\": 196,\n+ \"order\": 331,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n{\n- \"order\": 197,\n+ \"order\": 332,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n{\n- \"order\": 198,\n+ \"order\": 333,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n{\n- \"order\": 199,\n+ \"order\": 334,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n{\n- \"order\": 200,\n+ \"order\": 335,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n{\n- \"order\": 201,\n+ \"order\": 336,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n{\n- \"order\": 202,\n+ \"order\": 337,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n{\n- \"order\": 203,\n+ \"order\": 338,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 204,\n+ \"order\": 339,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 205,\n+ \"order\": 340,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n{\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 206,\n+ \"order\": 341,\n\"prevSize\": 32\n},\n{\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 207,\n+ \"order\": 342,\n\"prevSize\": 32\n}\n],\n},\n{\n\"selection\": [\n+ {\n+ \"order\": 0,\n+ \"id\": 8,\n+ \"name\": \"icon wrapper\",\n+ \"prevSize\": 32\n+ },\n{\n\"order\": 0,\n\"id\": 6,\n\"metadata\": {\n\"name\": \"Custom Icons\",\n\"importSize\": {\n- \"width\": 27,\n- \"height\": 30\n+ \"width\": 16,\n+ \"height\": 12\n}\n},\n\"height\": 1024,\n\"prevSize\": 32,\n\"icons\": [\n+ {\n+ \"id\": 8,\n+ \"paths\": [\n+ \"M561.583 519.759l134.147 6.449c158.099 7.601 308.166 42.213 438.12 99.255-14.95-15.698-31.753-31.006-50.423-45.809-97.22-77.053-238.897-134.042-405.135-148.764l-116.709-10.335v-211.936l-342.833 282.763 342.833 282.763v-254.386zM1346.125 753.561c0.179 0.811 0.35 1.622 0.521 2.434 1.382 6.546 2.594 13.13 3.627 19.751 3.072 19.548 4.642 39.412 4.642 59.535 0 39.59-48.546 52.518-78.601 26.756-10.684-9.155-21.82-18.080-33.374-26.756-5.009-3.759-10.095-7.473-15.258-11.138-0.35-0.247-0.7-0.495-1.050-0.742-107.725-76.164-249.25-131.689-409.050-156.449-41.524-6.434-84.281-10.791-128-12.893v255.833c0 54.11-62.979 83.797-104.722 49.374l-507.417-418.511c-31.037-25.599-31.037-73.147 0-98.746l507.416-418.51c41.743-34.429 104.722-4.737 104.722 49.373v230.517c336.994 29.843 605.436 214.82 656.542 450.172z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(255, 255, 255)\"\n+ }\n+ ],\n+ \"width\": 1365,\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 0,\n+ \"tags\": [\"icon wrapper\"],\n+ \"colorPermutations\": {\n+ \"128128128120420420412552552551\": [\n+ {\n+ \"f\": 2\n+ }\n+ ]\n+ }\n+ },\n{\n\"id\": 6,\n\"paths\": [\n},\n{\n\"selection\": [\n+ {\n+ \"order\": 0,\n+ \"id\": 297,\n+ \"name\": \"outline-chevron-right-small\",\n+ \"prevSize\": 32\n+ },\n{\n\"order\": 0,\n\"id\": 296,\n{\n\"order\": 0,\n\"id\": 228,\n- \"name\": \"outline-chevron-left-small\"\n+ \"name\": \"outline-chevron-left-small\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n\"height\": 1024,\n\"prevSize\": 32,\n\"icons\": [\n+ {\n+ \"id\": 297,\n+ \"paths\": [\"M426.667 725.333l213.333-213.333-213.333-213.333\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 48.39319864908854\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-chevron-right-small\"]\n+ },\n{\n\"id\": 296,\n\"paths\": [\n"
},
{
"change_type": "MODIFY",
"old_path": "web/icons/selection.json",
"new_path": "web/icons/selection.json",
"diff": "{\n\"IcoMoonType\": \"selection\",\n\"icons\": [\n+ {\n+ \"icon\": {\n+ \"paths\": [\"M426.667 725.333l213.333-213.333-213.333-213.333\"],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 48.39319864908854\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-chevron-right-small\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 48.39319864908854\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 311,\n+ \"id\": 63,\n+ \"name\": \"chevron-right-small\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 0\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M533.389 541.632l140.078 6.734c165.089 7.937 321.791 44.079 457.491 103.643-15.611-16.392-33.157-32.377-52.652-47.834-101.519-80.46-249.46-139.969-423.048-155.341l-121.869-10.792v-221.307l-357.991 295.265 357.991 295.265v-265.633zM1352.619 785.772c0.187 0.847 0.365 1.694 0.544 2.542 1.443 6.835 2.709 13.711 3.787 20.624 3.208 20.412 4.847 41.155 4.847 62.167 0 41.34-50.692 54.84-82.076 27.939-11.156-9.56-22.785-18.879-34.85-27.939-5.23-3.925-10.541-7.803-15.933-11.63-0.365-0.258-0.731-0.517-1.096-0.775-112.488-79.532-260.27-137.512-427.136-163.366-43.36-6.718-88.007-11.268-133.659-13.463v267.144c0 56.502-65.764 87.502-109.352 51.557l-529.852-437.015c-32.409-26.731-32.409-76.381 0-103.112l529.851-437.014c43.589-35.951 109.352-4.946 109.352 51.556v240.709c351.894 31.162 632.205 224.318 685.571 470.076z\"\n+ ],\n+ \"attrs\": [],\n+ \"width\": 1365.3333333333321,\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"reply-arrow\"],\n+ \"colorPermutations\": {}\n+ },\n+ \"attrs\": [],\n+ \"properties\": {\n+ \"order\": 312,\n+ \"id\": 31,\n+ \"name\": \"reply-arrow\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 1\n+ },\n{\n\"icon\": {\n\"paths\": [\n}\n],\n\"properties\": {\n- \"order\": 178,\n+ \"order\": 313,\n\"id\": 30,\n\"name\": \"right-angle-arrow\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 0\n+ \"iconIdx\": 2\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 179,\n+ \"order\": 314,\n\"id\": 29,\n\"name\": \"plus\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 1\n+ \"iconIdx\": 3\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 180,\n+ \"order\": 315,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 2\n+ \"iconIdx\": 4\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 181,\n+ \"order\": 316,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 3\n+ \"iconIdx\": 5\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 182,\n+ \"order\": 317,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 4\n+ \"iconIdx\": 6\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 183,\n+ \"order\": 318,\n\"id\": 27,\n\"name\": \"bug\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 5\n+ \"iconIdx\": 7\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 184,\n+ \"order\": 319,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 6\n+ \"iconIdx\": 8\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 185,\n+ \"order\": 320,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 7\n+ \"iconIdx\": 9\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 186,\n+ \"order\": 321,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 8\n+ \"iconIdx\": 10\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 187,\n+ \"order\": 322,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 9\n+ \"iconIdx\": 11\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 188,\n+ \"order\": 323,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 10\n+ \"iconIdx\": 12\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 189,\n+ \"order\": 324,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 11\n+ \"iconIdx\": 13\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 190,\n+ \"order\": 325,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 12\n+ \"iconIdx\": 14\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 191,\n+ \"order\": 326,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 13\n+ \"iconIdx\": 15\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 192,\n+ \"order\": 327,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 14\n+ \"iconIdx\": 16\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 193,\n+ \"order\": 328,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 15\n+ \"iconIdx\": 17\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 194,\n+ \"order\": 329,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 16\n+ \"iconIdx\": 18\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 195,\n+ \"order\": 330,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 17\n+ \"iconIdx\": 19\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 196,\n+ \"order\": 331,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 18\n+ \"iconIdx\": 20\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 197,\n+ \"order\": 332,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 19\n+ \"iconIdx\": 21\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 198,\n+ \"order\": 333,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 20\n+ \"iconIdx\": 22\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 199,\n+ \"order\": 334,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 21\n+ \"iconIdx\": 23\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 200,\n+ \"order\": 335,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 22\n+ \"iconIdx\": 24\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 201,\n+ \"order\": 336,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 23\n+ \"iconIdx\": 25\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 202,\n+ \"order\": 337,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 24\n+ \"iconIdx\": 26\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 203,\n+ \"order\": 338,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 25\n+ \"iconIdx\": 27\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 204,\n+ \"order\": 339,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 26\n+ \"iconIdx\": 28\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 205,\n+ \"order\": 340,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 27\n+ \"iconIdx\": 29\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 206,\n+ \"order\": 341,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 28\n+ \"iconIdx\": 30\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 207,\n+ \"order\": 342,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 29\n+ \"iconIdx\": 31\n}\n],\n\"height\": 1024,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add icons, reply and chevron small
Summary: screenshot, add these two {F13851}
Test Plan: n/a make sure icons in the app don't break
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3167 |
129,179 | 11.02.2022 10:06:14 | 18,000 | 1a74dfbc2eaaac1a25e89c33727f35476665cc1b | [web] add reply icon on hover
Summary: {F13881}
Test Plan: make sure page renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -100,9 +100,6 @@ div.nonViewerMessageActionLinks {\ndiv.messageActionLinks > div + div {\nmargin-left: 4px;\n}\n-div.messageReplyButton {\n- font-size: 14px;\n-}\ndiv.messageActionLinkIcon:hover {\ncursor: pointer;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/message-reply-button.react.js",
"new_path": "web/chat/message-reply-button.react.js",
"diff": "// @flow\n-import { faReply } from '@fortawesome/free-solid-svg-icons';\n-import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';\nimport invariant from 'invariant';\nimport * as React from 'react';\nimport { createMessageReply } from 'lib/shared/message-utils';\nimport type { InputState } from '../input/input-state';\n+import SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-message-list.css';\nimport type { OnMessagePositionWithContainerInfo } from './position-types';\n@@ -28,10 +27,8 @@ function MessageReplyButton(props: Props): React.Node {\n}, [addReply, item, onReplyClick]);\nreturn (\n- <div className={css.messageReplyButton}>\n<div className={css.messageActionLinkIcon} onClick={replyClicked}>\n- <FontAwesomeIcon icon={faReply} />\n- </div>\n+ <SWMansionIcon icon=\"reply-arrow\" size={18} />\n</div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] add reply icon on hover
Summary: {F13881}
Test Plan: make sure page renders
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3168 |
129,179 | 11.02.2022 10:18:15 | 18,000 | 1a21b8f48a428cc5e16e4ec1235a37f825a9c046 | [web] [fix] thread thread moves on hover
Summary:
before: {F13814}
after: {F13813}
Test Plan: make sure its not moving
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -150,11 +150,12 @@ div.sidebar .menu > button svg {\ncolor: var(--thread-color-read);\n}\ndiv.sidebar .menu {\n- display: none;\n+ opacity: 0;\n}\ndiv.sidebar:hover .menu {\ndisplay: flex;\nalign-self: flex-end;\n+ opacity: 1;\n}\n.menu {\nposition: relative;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] thread thread moves on hover
Summary:
before: {F13814}
after: {F13813}
Test Plan: make sure its not moving
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3164 |
129,184 | 10.02.2022 21:05:14 | 18,000 | 0a06e4a9d2aaa7bafa78ec117f2d241fb45732eb | [CommCoreModule] Introduce `CommCoreModule::setNotifyToken`
Summary: Stores `notifyToken` value in the SQLite `metadata` table
Test Plan:
1. Call the function
2. Verify that the row was created in the SQLite DB
Reviewers: palys-swm, def-au1t, karol-bisztyga, varun, ashoat, jimpo
Subscribers: Adrian, benschac | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h",
"diff": "@@ -55,6 +55,7 @@ public:\nvirtual std::vector<OlmPersistSession> getOlmPersistSessionsData() const = 0;\nvirtual folly::Optional<std::string> getOlmPersistAccountData() const = 0;\nvirtual void storeOlmPersistData(crypto::Persist persist) const = 0;\n+ virtual void setNotifyToken(std::string token) const = 0;\n};\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp",
"diff": "@@ -733,4 +733,12 @@ void SQLiteQueryExecutor::storeOlmPersistData(crypto::Persist persist) const {\n}\n}\n+void SQLiteQueryExecutor::setNotifyToken(std::string token) const {\n+ Metadata entry{\n+ \"notify_token\",\n+ token,\n+ };\n+ SQLiteQueryExecutor::getStorage().replace(entry);\n+}\n+\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h",
"new_path": "native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h",
"diff": "@@ -48,6 +48,7 @@ public:\nstd::vector<OlmPersistSession> getOlmPersistSessionsData() const override;\nfolly::Optional<std::string> getOlmPersistAccountData() const override;\nvoid storeOlmPersistData(crypto::Persist persist) const override;\n+ void setNotifyToken(std::string token) const override;\n};\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp",
"diff": "@@ -904,6 +904,32 @@ CommCoreModule::CommCoreModule(\ndouble CommCoreModule::getCodeVersion(jsi::Runtime &rt) {\nreturn this->codeVersion;\n+}\n+\n+jsi::Value\n+CommCoreModule::setNotifyToken(jsi::Runtime &rt, const jsi::String &token) {\n+ auto notifyToken{token.utf8(rt)};\n+ return createPromiseAsJSIValue(\n+ rt,\n+ [this,\n+ notifyToken](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {\n+ this->databaseThread->scheduleTask([this, notifyToken, promise]() {\n+ std::string error;\n+ try {\n+ DatabaseManager::getQueryExecutor().setNotifyToken(notifyToken);\n+ } catch (std::system_error &e) {\n+ error = e.what();\n+ }\n+\n+ this->jsInvoker_->invokeAsync([error, promise]() {\n+ if (error.size()) {\n+ promise->reject(error);\n+ } else {\n+ promise->resolve(jsi::Value::undefined());\n+ }\n+ });\n+ });\n+ });\n};\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"new_path": "native/cpp/CommonCpp/NativeModules/CommCoreModule.h",
"diff": "@@ -55,6 +55,8 @@ class CommCoreModule : public facebook::react::CommCoreModuleSchemaCxxSpecJSI {\njsi::Object\nopenSocket(jsi::Runtime &rt, const jsi::String &endpoint) override;\ndouble getCodeVersion(jsi::Runtime &rt) override;\n+ jsi::Value\n+ setNotifyToken(jsi::Runtime &rt, const jsi::String &token) override;\npublic:\nCommCoreModule(std::shared_ptr<facebook::react::CallInvoker> jsInvoker);\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.cpp",
"diff": "@@ -66,6 +66,9 @@ static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_openSocket(jsi::\nstatic jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getCodeVersion(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\nreturn static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->getCodeVersion(rt);\n}\n+static jsi::Value __hostFunction_CommCoreModuleSchemaCxxSpecJSI_setNotifyToken(jsi::Runtime &rt, TurboModule &turboModule, const jsi::Value* args, size_t count) {\n+ return static_cast<CommCoreModuleSchemaCxxSpecJSI *>(&turboModule)->setNotifyToken(rt, args[0].getString(rt));\n+}\nCommCoreModuleSchemaCxxSpecJSI::CommCoreModuleSchemaCxxSpecJSI(std::shared_ptr<CallInvoker> jsInvoker)\n: TurboModule(\"CommTurboModule\", jsInvoker) {\n@@ -87,6 +90,7 @@ CommCoreModuleSchemaCxxSpecJSI::CommCoreModuleSchemaCxxSpecJSI(std::shared_ptr<C\nmethodMap_[\"getUserOneTimeKeys\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getUserOneTimeKeys};\nmethodMap_[\"openSocket\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_openSocket};\nmethodMap_[\"getCodeVersion\"] = MethodMetadata {0, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_getCodeVersion};\n+ methodMap_[\"setNotifyToken\"] = MethodMetadata {1, __hostFunction_CommCoreModuleSchemaCxxSpecJSI_setNotifyToken};\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"new_path": "native/cpp/CommonCpp/_generated/NativeModules.h",
"diff": "@@ -36,6 +36,7 @@ virtual jsi::Value getUserPublicKey(jsi::Runtime &rt) = 0;\nvirtual jsi::Value getUserOneTimeKeys(jsi::Runtime &rt) = 0;\nvirtual jsi::Object openSocket(jsi::Runtime &rt, const jsi::String &endpoint) = 0;\nvirtual double getCodeVersion(jsi::Runtime &rt) = 0;\n+virtual jsi::Value setNotifyToken(jsi::Runtime &rt, const jsi::String &token) = 0;\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "native/schema/CommCoreModuleSchema.js",
"new_path": "native/schema/CommCoreModuleSchema.js",
"diff": "@@ -46,6 +46,7 @@ export interface Spec extends TurboModule {\n+getUserOneTimeKeys: () => Promise<string>;\n+openSocket: (endpoint: string) => Object;\n+getCodeVersion: () => number;\n+ +setNotifyToken: (token: string) => Promise<void>;\n}\nexport default (TurboModuleRegistry.getEnforcing<Spec>(\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Introduce `CommCoreModule::setNotifyToken`
Summary: Stores `notifyToken` value in the SQLite `metadata` table
Test Plan:
1. Call the function
2. Verify that the row was created in the SQLite DB
https://blob.sh/atul/50fb.png
Reviewers: palys-swm, def-au1t, karol-bisztyga, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: Adrian, benschac
Differential Revision: https://phabricator.ashoat.com/D3171 |
129,179 | 14.02.2022 10:41:28 | 18,000 | a27f687018e61953ad819826d3e5663c54f8ea2f | [web] [remove] lastActivity from thread
Summary:
talked IRL with ashoat about removing timestamp {F12385}
follow up diff here:
Test Plan: make sure page renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/sidebar-item.react.js",
"new_path": "web/chat/sidebar-item.react.js",
"diff": "@@ -4,9 +4,7 @@ import classNames from 'classnames';\nimport * as React from 'react';\nimport type { SidebarInfo } from 'lib/types/thread-types';\n-import { shortAbsoluteDate } from 'lib/utils/date-utils';\n-import { useSelector } from '../redux/redux-utils';\nimport { useOnClickThread } from '../selectors/nav-selectors';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-thread-list.css';\n@@ -15,16 +13,12 @@ type Props = {\n+sidebarInfo: SidebarInfo,\n};\nfunction SidebarItem(props: Props): React.Node {\n- const { threadInfo, lastUpdatedTime } = props.sidebarInfo;\n+ const { threadInfo } = props.sidebarInfo;\nconst threadID = threadInfo.id;\n-\nconst onClick = useOnClickThread(threadID);\n-\n- const timeZone = useSelector(state => state.timeZone);\n- const lastActivity = shortAbsoluteDate(lastUpdatedTime, timeZone);\n-\nconst { unread } = threadInfo.currentUser;\nconst unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });\n+\nreturn (\n<>\n<SWMansionIcon icon=\"right-angle-arrow\" size={28} />\n@@ -32,14 +26,6 @@ function SidebarItem(props: Props): React.Node {\n<a className={css.threadButtonSidebar} onClick={onClick}>\n<div className={css.threadRow}>\n<div className={unreadCls}>{threadInfo.uiName}</div>\n- <div\n- className={classNames([\n- css.sidebarLastActivity,\n- unread ? css.black : css.dark,\n- ])}\n- >\n- {lastActivity}\n- </div>\n</div>\n</a>\n</>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [remove] lastActivity from thread
Summary:
talked IRL with ashoat about removing timestamp {F12385}
follow up diff here: https://phabricator.ashoat.com/D3163
Test Plan: make sure page renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3098 |
129,179 | 14.02.2022 10:43:25 | 18,000 | c3b7fe726365c224210fe019e66c3295aadd2cad | [web] [fix] ancestorThreads styling
Summary:
fix up styles. Right size chevrons, align correctly {F14090}
Assigning too since Atul is OOO.
Test Plan: n/a make sure it's close to figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -107,7 +107,7 @@ function ChatThreadListItem(props: Props): React.Node {\nconst isNotLast = idx !== ancestorThreads.length - 1;\nconst chevron = isNotLast && (\n<span className={css.breadCrumb}>\n- <SWMansionIcon icon=\"chevron-right\" size={10} />\n+ <SWMansionIcon icon=\"chevron-right-small\" size={16} />\n</span>\n);\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -64,7 +64,6 @@ a.threadButton {\n}\np.breadCrumbs {\ndisplay: flex;\n- align-items: center;\nfont-size: var(--xs-font-12);\nfont-weight: var(--normal);\ncolor: var(--breadcrumb-color);\n@@ -73,14 +72,12 @@ p.breadCrumbs.unread {\ncolor: var(--breadcrumb-color-unread);\n}\nspan.breadCrumb {\n- padding-right: 4px;\n+ display: flex;\n+ align-items: center;\nwhite-space: nowrap;\ntext-overflow: ellipsis;\n}\n-span.breadCrumb svg {\n- color: var(--fg);\n-}\ndiv.spacer,\ndiv.colorSplotch {\nheight: 40px;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] ancestorThreads styling
Summary:
fix up styles. Right size chevrons, align correctly {F14090}
https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A77116
Assigning @ashoat too since Atul is OOO.
Test Plan: n/a make sure it's close to figma
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3183 |
129,179 | 14.02.2022 10:44:08 | 18,000 | b7aa268a54452383bb8d459f25d401a729346a0e | [web] [remove] text highlighting from active thread
Summary:
remove highlight on active (selected) thread screenshot (adding ashoat since atul is out today)
{F14039}
Test Plan: should work like before, without highlighting of text.
Reviewers: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -38,18 +38,6 @@ div.thread div.title {\ncolor: var(--thread-color-read);\nline-height: var(--line-height-text);\n}\n-div.thread div.title.unread,\n-div.thread.activeThread div.title,\n-div.thread.activeThread div.lastMessage,\n-div.thread.activeThread div.breadCrumbs,\n-div.thread.activeThread div.lastActivity,\n-div.thread.activeThread .menu button {\n- color: var(--fg);\n-}\n-\n-div.thread.activeThread p.breadCrumbs {\n- color: var(--breadcrumb-color-unread);\n-}\na.threadButton {\nflex: 1;\ncursor: pointer;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [remove] text highlighting from active thread
Summary:
remove highlight on active (selected) thread screenshot (adding ashoat since atul is out today)
{F14039}
Test Plan: should work like before, without highlighting of text.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3182 |
129,179 | 15.02.2022 09:16:09 | 18,000 | 1a3f76d0c9c3f7846fb7494e03eaecf31651b1ff | [web] [refator] Chat thread list
Summary: destructure item a bit more. No new functionality.
Test Plan: make sure thread item still works.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -25,8 +25,14 @@ type Props = {\n};\nfunction ChatThreadListItem(props: Props): React.Node {\nconst { item, setModal } = props;\n- const { threadInfo, lastUpdatedTimeIncludingSidebars } = item;\n- const threadID = item.threadInfo.id;\n+ const {\n+ threadInfo,\n+ lastUpdatedTimeIncludingSidebars,\n+ mostRecentNonLocalMessage,\n+ mostRecentMessageInfo,\n+ } = item;\n+ const { id: threadID, currentUser } = threadInfo;\n+\nconst ancestorThreads = useAncestorThreads(threadInfo);\nconst onClick = useOnClickThread(item.threadInfo);\n@@ -46,7 +52,7 @@ function ChatThreadListItem(props: Props): React.Node {\n[active],\n);\n- const { unread } = item.threadInfo.currentUser;\n+ const { unread } = currentUser;\nconst titleClassName = React.useMemo(\n() =>\nclassNames({\n@@ -126,19 +132,19 @@ function ChatThreadListItem(props: Props): React.Node {\n<a className={css.threadButton} onClick={onClick}>\n<p className={breadCrumbsClassName}>{ancestorPath}</p>\n<div className={css.threadRow}>\n- <div className={titleClassName}>{item.threadInfo.uiName}</div>\n+ <div className={titleClassName}>{threadInfo.uiName}</div>\n</div>\n<div className={css.threadRow}>\n<MessagePreview\n- messageInfo={item.mostRecentMessageInfo}\n- threadInfo={item.threadInfo}\n+ messageInfo={mostRecentMessageInfo}\n+ threadInfo={threadInfo}\n/>\n</div>\n</a>\n<div>\n<ChatThreadListItemMenu\n- threadInfo={item.threadInfo}\n- mostRecentNonLocalMessage={item.mostRecentNonLocalMessage}\n+ threadInfo={threadInfo}\n+ mostRecentNonLocalMessage={mostRecentNonLocalMessage}\n/>\n<div className={lastActivityClassName}>{lastActivity}</div>\n</div>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refator] Chat thread list
Summary: destructure item a bit more. No new functionality.
Test Plan: make sure thread item still works.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3184 |
129,179 | 15.02.2022 09:35:03 | 18,000 | fb93ae4b58bab7a9c48a983fee2f9e98a74b1b8e | [web] [darkmode] unread button
Summary:
theme unread button, no design in web. Generally just theme'ed with our color palette.
{F14033}
Adding ashoat since Atul is OOO today.
Test Plan: should work as before.
Reviewers: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "// @flow\n-import classNames from 'classnames';\nimport * as React from 'react';\nimport {\n@@ -17,6 +16,7 @@ import {\nuseDispatchActionPromise,\n} from 'lib/utils/action-utils';\n+import Button from '../components/button.react';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-thread-list.css';\n@@ -74,24 +74,22 @@ function ChatThreadListItemMenu(props: Props): React.Node {\n}`;\nconst menuIconSize = renderStyle === 'chat' ? 24 : 16;\n+\n+ let btn;\n+ if (menuVisible) {\n+ btn = (\n+ <Button variant=\"toggle_read\" onClick={toggleUnreadStatus}>\n+ {toggleUnreadStatusButtonText}\n+ </Button>\n+ );\n+ }\n+\nreturn (\n<div className={css.menu} onMouseLeave={hideMenu}>\n<button onClick={toggleMenu}>\n<SWMansionIcon icon=\"menu-vertical\" size={menuIconSize} />\n</button>\n- <div\n- className={classNames(css.menuContent, {\n- [css.menuContentVisible]: menuVisible,\n- })}\n- >\n- <ul>\n- <li>\n- <button onClick={toggleUnreadStatus}>\n- {toggleUnreadStatusButtonText}\n- </button>\n- </li>\n- </ul>\n- </div>\n+ <div>{btn}</div>\n</div>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -145,6 +145,7 @@ div.sidebar:hover .menu {\n.menu {\nposition: relative;\ndisplay: flex;\n+ padding: 5px;\njustify-content: flex-end;\n}\n.menu > button {\n@@ -172,16 +173,7 @@ div.sidebar:hover .menu {\nborder-radius: 5px;\nbox-shadow: 1px 1px 5px 2px #00000022;\n}\n-.menuContentVisible {\n- display: block;\n-}\n-.menuContent ul {\n- list-style: none;\n-}\n-.menuContent li:not(:last-child) {\n- border-bottom: 1px solid #dddddd;\n-}\n-.menuContent button {\n+button.menuContent {\nborder: none;\ncursor: pointer;\npadding: 10px;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/components/button.css",
"new_path": "web/components/button.css",
"diff": "border-radius: 50%;\npadding: 0;\n}\n+\n+.unread {\n+ background: var(--unread-btn-bg);\n+ color: var(--fg);\n+ position: absolute;\n+ z-index: 1;\n+ font-size: var(--xs-font-12);\n+ font-weight: var(--semi-bold);\n+ top: 0;\n+ right: 25px;\n+ width: max-content;\n+ padding: 10px;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/components/button.react.js",
"new_path": "web/components/button.react.js",
"diff": "@@ -8,7 +8,7 @@ import css from './button.css';\ntype Props = {\n+onClick: (event: SyntheticEvent<HTMLButtonElement>) => void,\n+children: React.Node,\n- +variant?: 'primary' | 'secondary' | 'danger' | 'round',\n+ +variant?: 'primary' | 'secondary' | 'danger' | 'round' | 'toggle_read',\n+type?: string,\n+disabled?: boolean,\n+className?: string,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--thread-ancestor-keyserver-border: var(--shades-black-70);\n--thread-ancestor-color-light: var(--shades-white-70);\n--thread-ancestor-color-dark: var(--shades-black-100);\n+ --unread-btn-bg: var(--shades-black-80);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [darkmode] unread button
Summary:
theme unread button, no design in web. Generally just theme'ed with our color palette.
{F14033}
Adding ashoat since Atul is OOO today.
Test Plan: should work as before.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3181 |
129,179 | 15.02.2022 09:58:41 | 18,000 | 167b315db3e100c697174aaa71f267d63a211c12 | [web] [feat] add unread dot
Summary:
add unread dot per figma screen shot {F14118}
Ignore title color, will fix in a follow up diff.
Test Plan: match figma
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item.react.js",
"new_path": "web/chat/chat-thread-list-item.react.js",
"diff": "@@ -79,6 +79,11 @@ function ChatThreadListItem(props: Props): React.Node {\n[unread],\n);\n+ let unreadDot;\n+ if (unread) {\n+ unreadDot = <div className={css.unreadDot} />;\n+ }\n+\nconst { color } = item.threadInfo;\nconst colorSplotchStyle = React.useMemo(\n() => ({ backgroundColor: `#${color}` }),\n@@ -128,7 +133,11 @@ function ChatThreadListItem(props: Props): React.Node {\nreturn (\n<>\n<div className={containerClassName}>\n+ <div className={css.colorContainer}>\n+ <div className={css.dotContainer}>{unreadDot}</div>\n+\n<div className={css.colorSplotch} style={colorSplotchStyle} />\n+ </div>\n<a className={css.threadButton} onClick={onClick}>\n<p className={breadCrumbsClassName}>{ancestorPath}</p>\n<div className={css.threadRow}>\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -4,7 +4,6 @@ div.thread {\nalign-items: flex-start;\npadding-top: 4px;\npadding-bottom: 4px;\n- padding-left: 16px;\npadding-right: 10px;\n}\ndiv.threadListSideBar {\n@@ -66,6 +65,10 @@ span.breadCrumb {\ntext-overflow: ellipsis;\n}\n+div.colorContainer {\n+ display: flex;\n+}\n+\ndiv.spacer,\ndiv.colorSplotch {\nheight: 40px;\n@@ -107,6 +110,19 @@ div.dark {\n.light {\ncolor: var(--thread-from-color-read);\n}\n+div.dotContainer {\n+ display: flex;\n+ align-items: center;\n+ justify-content: center;\n+ width: 16px;\n+}\n+div.unreadDot {\n+ height: 4px;\n+ width: 4px;\n+ background: var(--fg);\n+ border-radius: 15px;\n+ align-self: center;\n+}\ndiv.italic {\nfont-style: italic;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [feat] add unread dot
Summary:
add unread dot per figma screen shot {F14118}
Ignore title color, will fix in a follow up diff.
Test Plan: match figma
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3185 |
129,187 | 08.02.2022 22:40:50 | 18,000 | 03db030f6828c9b630035e7c8062f570b1465484 | [lib] Simplify filterChatThreadList
Summary:
It's good this function got factored out, because it turns out the logic can be significantly simplified now.
Depends on D2885
Test Plan: Flow, careful code inspection
Reviewers: def-au1t, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "lib/shared/thread-utils.js",
"new_path": "lib/shared/thread-utils.js",
"diff": "@@ -1190,15 +1190,13 @@ function getThreadListSearchResults(\nusersSearchResults: $ReadOnlyArray<GlobalAccountUserInfo>,\nviewerID: ?string,\n): $ReadOnlyArray<ChatThreadItem> {\n- const chatItems = [];\nif (!searchText) {\n- chatItems.push(\n- ...chatListData.filter(\n+ return chatListData.filter(\nitem =>\nthreadIsTopLevel(item.threadInfo) && threadFilter(item.threadInfo),\n- ),\n);\n- } else {\n+ }\n+\nconst privateThreads = [];\nconst personalThreads = [];\nconst otherThreads = [];\n@@ -1214,7 +1212,8 @@ function getThreadListSearchResults(\notherThreads.push({ ...item, sidebars: [] });\n}\n}\n- chatItems.push(...privateThreads, ...personalThreads, ...otherThreads);\n+\n+ const chatItems = [...privateThreads, ...personalThreads, ...otherThreads];\nif (viewerID) {\nchatItems.push(\n...usersSearchResults.map(user =>\n@@ -1222,7 +1221,6 @@ function getThreadListSearchResults(\n),\n);\n}\n- }\nreturn chatItems;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [lib] Simplify filterChatThreadList
Summary:
It's good this function got factored out, because it turns out the logic can be significantly simplified now.
Depends on D2885
Test Plan: Flow, careful code inspection
Reviewers: def-au1t, palys-swm
Reviewed By: def-au1t, palys-swm
Subscribers: benschac, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3145 |
129,179 | 16.02.2022 15:12:46 | 18,000 | 8b1ffb2a4fa72fe66621599ff3502b3b024b4169 | [landing] [fix] footer layout on mobile
Summary:
before: {F15004}
after: {F15005}
side stepping normal diff review because we don't want a broken signup experience this week.
Test Plan: shrink browser, it should not look broken
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "landing/footer.css",
"new_path": "landing/footer.css",
"diff": "@@ -18,7 +18,7 @@ footer.wrapper {\n}\n@media screen and (max-width: 1099px) {\n- footer.wrapper {\n+ .contentWrapper {\ngrid-template-columns: 16px repeat(6, 1fr) 16px;\ngrid-template-rows: 1fr 1fr;\ncolumn-gap: 1.5%;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [landing] [fix] footer layout on mobile
Summary:
before: {F15004}
after: {F15005}
side stepping normal diff review because we don't want a broken signup experience this week.
Test Plan: shrink browser, it should not look broken
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3232 |
129,179 | 22.02.2022 08:54:55 | 18,000 | 64e2cb75bc0560d7a65712ebe09dca5f0b7443f8 | [web] [fix] loading LoadingIndicator color to white
Summary: make loading indicator correct color {F14712}
Test Plan: should be white, when scrolling new messages
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.react.js",
"new_path": "web/chat/chat-message-list.react.js",
"diff": "@@ -187,7 +187,7 @@ class ChatMessageList extends React.PureComponent<Props, State> {\nif (item.itemType === 'loader') {\nreturn (\n<div key=\"loader\" className={css.loading}>\n- <LoadingIndicator status=\"loading\" size=\"large\" color=\"black\" />\n+ <LoadingIndicator status=\"loading\" size=\"large\" color=\"white\" />\n</div>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [fix] loading LoadingIndicator color to white
Summary: make loading indicator correct color {F14712}
Test Plan: should be white, when scrolling new messages
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3210 |
129,179 | 22.02.2022 09:22:01 | 18,000 | aa5887f7949a57f276573aa5144ffeeee72203cd | [web] [chore] add additional icons for drop down menu
Summary: Adds additional icons {F15348}
Test Plan: clean cache, re-load page, icons should render as expected
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/icons/AppIcons.json",
"new_path": "web/icons/AppIcons.json",
"diff": "{\n\"height\": 1024,\n\"icons\": [\n+ {\n+ \"id\": 65,\n+ \"paths\": [\n+ \"M725.333 512h-426.667M725.333 512l-170.667 170.667M725.333 512l-170.667-170.667\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-arrow-right-small\"]\n+ },\n+ {\n+ \"id\": 66,\n+ \"paths\": [\n+ \"M100.635 769.101l-34.494-17.246c-5.976 11.956-5.338 26.152 1.689 37.522s19.439 18.289 32.805 18.289v-38.564zM923.365 769.101v38.564c13.365 0 25.777-6.923 32.805-18.289 7.024-11.37 7.666-25.566 1.687-37.522l-34.493 17.246zM242.044 357.74c0-149.092 120.864-269.956 269.956-269.956v-77.132c-191.69 0-347.088 155.398-347.088 347.088h77.132zM512 87.78c149.092 0 269.956 120.864 269.956 269.956h77.132c0-191.69-155.399-347.088-347.088-347.088v77.132zM164.912 357.74c0 97.011-24.372 195.414-49.44 270.614-12.457 37.374-24.91 68.501-34.212 90.206-4.648 10.838-8.497 19.305-11.152 24.992-1.325 2.843-2.353 4.995-3.032 6.391-0.337 0.705-0.59 1.215-0.749 1.536-0.077 0.16-0.135 0.274-0.165 0.333-0.017 0.030-0.025 0.051-0.027 0.055s-0.002 0.004 0 0c0 0 0.002-0.004 0.003-0.004 0.002-0.004 0.005-0.009 34.498 17.238s34.497 17.242 34.5 17.23c0.002-0.004 0.006-0.009 0.009-0.021 0.006-0.017 0.018-0.038 0.027-0.055 0.022-0.042 0.049-0.097 0.085-0.165 0.068-0.139 0.161-0.325 0.277-0.561 0.232-0.468 0.559-1.135 0.97-1.991 0.828-1.713 2.013-4.185 3.497-7.37 2.968-6.366 7.157-15.576 12.15-27.232 9.982-23.288 23.238-56.435 36.49-96.193 26.354-79.060 53.401-186.339 53.401-295.011h-77.132zM100.635 807.669h822.727v-77.132h-822.727v77.132zM923.365 769.101c34.493-17.246 34.497-17.242 34.497-17.238 0 0 0.004 0.004 0.004 0.004 0 0.004 0 0.004 0 0-0.004-0.004-0.017-0.025-0.030-0.055-0.030-0.063-0.089-0.173-0.165-0.333-0.16-0.325-0.409-0.831-0.747-1.536-0.679-1.401-1.709-3.548-3.033-6.391-2.654-5.687-6.505-14.15-11.146-24.992-9.302-21.706-21.756-52.836-34.214-90.206-25.068-75.204-49.44-173.607-49.44-270.614h-77.132c0 108.672 27.047 215.951 53.401 295.011 13.251 39.758 26.507 72.905 36.488 96.193 4.999 11.657 9.184 20.866 12.15 27.232 1.485 3.181 2.67 5.657 3.497 7.37 0.418 0.852 0.738 1.523 0.97 1.991 0.118 0.236 0.211 0.422 0.278 0.561 0.030 0.067 0.063 0.122 0.080 0.165 0.009 0.021 0.021 0.042 0.025 0.055 0.004 0.009 0.009 0.017 0.009 0.021 0.004 0.009 0.009 0.017 34.501-17.23zM627.696 820.524c0 63.894-51.802 115.696-115.696 115.696v77.132c106.499 0 192.828-86.329 192.828-192.828h-77.132zM512 936.22c-63.894 0-115.696-51.802-115.696-115.696h-77.132c0 106.499 86.33 192.828 192.828 192.828v-77.132zM396.304 820.524v-51.419h-77.132v51.419h77.132zM704.828 820.524v-51.419h-77.132v51.419h77.132z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(0, 26, 114)\"\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-bell\"]\n+ },\n+ {\n+ \"id\": 67,\n+ \"paths\": [\n+ \"M652.006 63.98h224.012c61.86 0 112.003 50.145 112.003 112.003v672.030c0 61.86-50.144 112.003-112.003 112.003h-224.012M35.978 512.003h672.030M35.978 512.003l224.012-224.012M35.978 512.003l224.012 224.012\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-logout\"]\n+ },\n+ {\n+ \"id\": 68,\n+ \"paths\": [\n+ \"M550.564 306.317c0-21.297-17.267-38.564-38.564-38.564s-38.564 17.267-38.564 38.564h77.132zM473.436 717.683c0 21.297 17.267 38.564 38.564 38.564s38.564-17.267 38.564-38.564h-77.132zM306.317 473.436c-21.297 0-38.564 17.267-38.564 38.564s17.267 38.564 38.564 38.564v-77.132zM717.683 550.564c21.297 0 38.564-17.267 38.564-38.564s-17.267-38.564-38.564-38.564v77.132zM473.436 306.317v411.365h77.132v-411.365h-77.132zM306.317 550.564h411.365v-77.132h-411.365v77.132zM936.22 512c0 234.286-189.934 424.22-424.22 424.22v77.132c276.887 0 501.352-224.461 501.352-501.352h-77.132zM512 936.22c-234.288 0-424.22-189.934-424.22-424.22h-77.132c0 276.887 224.461 501.352 501.352 501.352v-77.132zM87.78 512c0-234.288 189.928-424.22 424.22-424.22v-77.132c-276.887 0-501.352 224.461-501.352 501.352h77.132zM512 87.78c234.286 0 424.22 189.928 424.22 424.22h77.132c0-276.887-224.461-501.352-501.352-501.352v77.132z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"rgb(0, 26, 114)\"\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-plus-circle\"]\n+ },\n+ {\n+ \"id\": 69,\n+ \"paths\": [\n+ \"M981.334 896v-85.333c0-94.255-76.412-170.667-170.667-170.667h-21.333M640.001 469.333c94.255 0 170.667-76.41 170.667-170.667s-76.412-170.667-170.667-170.667M725.334 896v-85.333c0-94.255-76.412-170.667-170.667-170.667h-341.333c-94.257 0-170.667 76.412-170.667 170.667v85.333M554.668 298.667c0 94.257-76.412 170.667-170.667 170.667-94.257 0-170.667-76.41-170.667-170.667s76.41-170.667 170.667-170.667c94.255 0 170.667 76.41 170.667 170.667z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"stroke\": \"rgb(0, 26, 114)\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-users\"]\n+ },\n{\n\"id\": 64,\n\"paths\": [\"M426.667 725.333l213.333-213.333-213.333-213.333\"],\n},\n\"selection\": [\n{\n- \"order\": 311,\n+ \"order\": 348,\n+ \"id\": 64,\n+ \"name\": \"arrow-right-small\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 349,\n+ \"id\": 65,\n+ \"name\": \"bell\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 350,\n+ \"id\": 66,\n+ \"name\": \"logout\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 351,\n+ \"id\": 67,\n+ \"name\": \"plus-circle\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 352,\n+ \"id\": 68,\n+ \"name\": \"users\",\n+ \"prevSize\": 32\n+ },\n+ {\n+ \"order\": 353,\n\"id\": 63,\n\"name\": \"chevron-right-small\",\n\"prevSize\": 32\n},\n{\n- \"order\": 312,\n+ \"order\": 354,\n\"id\": 31,\n\"name\": \"reply-arrow\",\n\"prevSize\": 32\n},\n{\n- \"order\": 313,\n+ \"order\": 355,\n\"id\": 30,\n\"name\": \"right-angle-arrow\",\n\"prevSize\": 32\n},\n{\n- \"order\": 314,\n+ \"order\": 356,\n\"id\": 29,\n\"name\": \"plus\",\n\"prevSize\": 32\n},\n{\n- \"order\": 315,\n+ \"order\": 357,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n{\n- \"order\": 316,\n+ \"order\": 358,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n{\n- \"order\": 317,\n+ \"order\": 359,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 318,\n+ \"order\": 360,\n\"id\": 27,\n\"name\": \"bug\",\n\"prevSize\": 32\n},\n{\n- \"order\": 319,\n+ \"order\": 361,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n{\n- \"order\": 320,\n+ \"order\": 362,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n{\n- \"order\": 321,\n+ \"order\": 363,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n{\n- \"order\": 322,\n+ \"order\": 364,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n{\n- \"order\": 323,\n+ \"order\": 365,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 324,\n+ \"order\": 366,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 325,\n+ \"order\": 367,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n{\n- \"order\": 326,\n+ \"order\": 368,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n{\n- \"order\": 327,\n+ \"order\": 369,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n{\n- \"order\": 328,\n+ \"order\": 370,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 329,\n+ \"order\": 371,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n{\n- \"order\": 330,\n+ \"order\": 372,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n{\n- \"order\": 331,\n+ \"order\": 373,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n{\n- \"order\": 332,\n+ \"order\": 374,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n{\n- \"order\": 333,\n+ \"order\": 375,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n{\n- \"order\": 334,\n+ \"order\": 376,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n{\n- \"order\": 335,\n+ \"order\": 377,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n{\n- \"order\": 336,\n+ \"order\": 378,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n{\n- \"order\": 337,\n+ \"order\": 379,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n{\n- \"order\": 338,\n+ \"order\": 380,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n{\n- \"order\": 339,\n+ \"order\": 381,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n{\n- \"order\": 340,\n+ \"order\": 382,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n{\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 341,\n+ \"order\": 383,\n\"prevSize\": 32\n},\n{\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 342,\n+ \"order\": 384,\n\"prevSize\": 32\n}\n],\n{\n\"order\": 0,\n\"id\": 281,\n- \"name\": \"outline-arrow-right-small\"\n+ \"name\": \"outline-arrow-right-small\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 268,\n- \"name\": \"outline-bell\"\n+ \"name\": \"outline-bell\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 145,\n- \"name\": \"outline-logout\"\n+ \"name\": \"outline-logout\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 108,\n- \"name\": \"outline-plus-circle\"\n+ \"name\": \"outline-plus-circle\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n{\n\"order\": 0,\n\"id\": 12,\n- \"name\": \"outline-users\"\n+ \"name\": \"outline-users\",\n+ \"prevSize\": 32\n},\n{\n\"order\": 0,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/icons/selection.json",
"new_path": "web/icons/selection.json",
"diff": "{\n\"IcoMoonType\": \"selection\",\n\"icons\": [\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M725.333 512h-426.667M725.333 512l-170.667 170.667M725.333 512l-170.667-170.667\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-arrow-right-small\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 348,\n+ \"id\": 64,\n+ \"name\": \"arrow-right-small\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 0\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M100.635 769.101l-34.494-17.246c-5.976 11.956-5.338 26.152 1.689 37.522s19.439 18.289 32.805 18.289v-38.564zM923.365 769.101v38.564c13.365 0 25.777-6.923 32.805-18.289 7.024-11.37 7.666-25.566 1.687-37.522l-34.493 17.246zM242.044 357.74c0-149.092 120.864-269.956 269.956-269.956v-77.132c-191.69 0-347.088 155.398-347.088 347.088h77.132zM512 87.78c149.092 0 269.956 120.864 269.956 269.956h77.132c0-191.69-155.399-347.088-347.088-347.088v77.132zM164.912 357.74c0 97.011-24.372 195.414-49.44 270.614-12.457 37.374-24.91 68.501-34.212 90.206-4.648 10.838-8.497 19.305-11.152 24.992-1.325 2.843-2.353 4.995-3.032 6.391-0.337 0.705-0.59 1.215-0.749 1.536-0.077 0.16-0.135 0.274-0.165 0.333-0.017 0.030-0.025 0.051-0.027 0.055s-0.002 0.004 0 0c0 0 0.002-0.004 0.003-0.004 0.002-0.004 0.005-0.009 34.498 17.238s34.497 17.242 34.5 17.23c0.002-0.004 0.006-0.009 0.009-0.021 0.006-0.017 0.018-0.038 0.027-0.055 0.022-0.042 0.049-0.097 0.085-0.165 0.068-0.139 0.161-0.325 0.277-0.561 0.232-0.468 0.559-1.135 0.97-1.991 0.828-1.713 2.013-4.185 3.497-7.37 2.968-6.366 7.157-15.576 12.15-27.232 9.982-23.288 23.238-56.435 36.49-96.193 26.354-79.060 53.401-186.339 53.401-295.011h-77.132zM100.635 807.669h822.727v-77.132h-822.727v77.132zM923.365 769.101c34.493-17.246 34.497-17.242 34.497-17.238 0 0 0.004 0.004 0.004 0.004 0 0.004 0 0.004 0 0-0.004-0.004-0.017-0.025-0.030-0.055-0.030-0.063-0.089-0.173-0.165-0.333-0.16-0.325-0.409-0.831-0.747-1.536-0.679-1.401-1.709-3.548-3.033-6.391-2.654-5.687-6.505-14.15-11.146-24.992-9.302-21.706-21.756-52.836-34.214-90.206-25.068-75.204-49.44-173.607-49.44-270.614h-77.132c0 108.672 27.047 215.951 53.401 295.011 13.251 39.758 26.507 72.905 36.488 96.193 4.999 11.657 9.184 20.866 12.15 27.232 1.485 3.181 2.67 5.657 3.497 7.37 0.418 0.852 0.738 1.523 0.97 1.991 0.118 0.236 0.211 0.422 0.278 0.561 0.030 0.067 0.063 0.122 0.080 0.165 0.009 0.021 0.021 0.042 0.025 0.055 0.004 0.009 0.009 0.017 0.009 0.021 0.004 0.009 0.009 0.017 34.501-17.23zM627.696 820.524c0 63.894-51.802 115.696-115.696 115.696v77.132c106.499 0 192.828-86.329 192.828-192.828h-77.132zM512 936.22c-63.894 0-115.696-51.802-115.696-115.696h-77.132c0 106.499 86.33 192.828 192.828 192.828v-77.132zM396.304 820.524v-51.419h-77.132v51.419h77.132zM704.828 820.524v-51.419h-77.132v51.419h77.132z\"\n+ ],\n+ \"attrs\": [{}],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-bell\"]\n+ },\n+ \"attrs\": [{}],\n+ \"properties\": {\n+ \"order\": 349,\n+ \"id\": 65,\n+ \"name\": \"bell\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 1\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M652.006 63.98h224.012c61.86 0 112.003 50.145 112.003 112.003v672.030c0 61.86-50.144 112.003-112.003 112.003h-224.012M35.978 512.003h672.030M35.978 512.003l224.012-224.012M35.978 512.003l224.012 224.012\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-logout\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 350,\n+ \"id\": 66,\n+ \"name\": \"logout\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 2\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M550.564 306.317c0-21.297-17.267-38.564-38.564-38.564s-38.564 17.267-38.564 38.564h77.132zM473.436 717.683c0 21.297 17.267 38.564 38.564 38.564s38.564-17.267 38.564-38.564h-77.132zM306.317 473.436c-21.297 0-38.564 17.267-38.564 38.564s17.267 38.564 38.564 38.564v-77.132zM717.683 550.564c21.297 0 38.564-17.267 38.564-38.564s-17.267-38.564-38.564-38.564v77.132zM473.436 306.317v411.365h77.132v-411.365h-77.132zM306.317 550.564h411.365v-77.132h-411.365v77.132zM936.22 512c0 234.286-189.934 424.22-424.22 424.22v77.132c276.887 0 501.352-224.461 501.352-501.352h-77.132zM512 936.22c-234.288 0-424.22-189.934-424.22-424.22h-77.132c0 276.887 224.461 501.352 501.352 501.352v-77.132zM87.78 512c0-234.288 189.928-424.22 424.22-424.22v-77.132c-276.887 0-501.352 224.461-501.352 501.352h77.132zM512 87.78c234.286 0 424.22 189.928 424.22 424.22h77.132c0-276.887-224.461-501.352-501.352-501.352v77.132z\"\n+ ],\n+ \"attrs\": [{}],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-plus-circle\"]\n+ },\n+ \"attrs\": [{}],\n+ \"properties\": {\n+ \"order\": 351,\n+ \"id\": 67,\n+ \"name\": \"plus-circle\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 3\n+ },\n+ {\n+ \"icon\": {\n+ \"paths\": [\n+ \"M981.334 896v-85.333c0-94.255-76.412-170.667-170.667-170.667h-21.333M640.001 469.333c94.255 0 170.667-76.41 170.667-170.667s-76.412-170.667-170.667-170.667M725.334 896v-85.333c0-94.255-76.412-170.667-170.667-170.667h-341.333c-94.257 0-170.667 76.412-170.667 170.667v85.333M554.668 298.667c0 94.257-76.412 170.667-170.667 170.667-94.257 0-170.667-76.41-170.667-170.667s76.41-170.667 170.667-170.667c94.255 0 170.667 76.41 170.667 170.667z\"\n+ ],\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"isMulticolor\": false,\n+ \"isMulticolor2\": false,\n+ \"grid\": 24,\n+ \"tags\": [\"outline-users\"]\n+ },\n+ \"attrs\": [\n+ {\n+ \"fill\": \"none\",\n+ \"strokeLinejoin\": \"round\",\n+ \"strokeLinecap\": \"round\",\n+ \"strokeMiterlimit\": \"4\",\n+ \"strokeWidth\": 64\n+ }\n+ ],\n+ \"properties\": {\n+ \"order\": 352,\n+ \"id\": 68,\n+ \"name\": \"users\",\n+ \"prevSize\": 32\n+ },\n+ \"setIdx\": 0,\n+ \"setId\": 1,\n+ \"iconIdx\": 4\n+ },\n{\n\"icon\": {\n\"paths\": [\"M426.667 725.333l213.333-213.333-213.333-213.333\"],\n}\n],\n\"properties\": {\n- \"order\": 311,\n+ \"order\": 353,\n\"id\": 63,\n\"name\": \"chevron-right-small\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 0\n+ \"iconIdx\": 5\n},\n{\n\"icon\": {\n},\n\"attrs\": [],\n\"properties\": {\n- \"order\": 312,\n+ \"order\": 354,\n\"id\": 31,\n\"name\": \"reply-arrow\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 1\n+ \"iconIdx\": 6\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 313,\n+ \"order\": 355,\n\"id\": 30,\n\"name\": \"right-angle-arrow\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 2\n+ \"iconIdx\": 7\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 314,\n+ \"order\": 356,\n\"id\": 29,\n\"name\": \"plus\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 3\n+ \"iconIdx\": 8\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 315,\n+ \"order\": 357,\n\"id\": 28,\n\"name\": \"settings\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 4\n+ \"iconIdx\": 9\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 316,\n+ \"order\": 358,\n\"id\": 24,\n\"name\": \"wrench\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 5\n+ \"iconIdx\": 10\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 317,\n+ \"order\": 359,\n\"id\": 25,\n\"name\": \"Filled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 6\n+ \"iconIdx\": 11\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 318,\n+ \"order\": 360,\n\"id\": 27,\n\"name\": \"bug\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 7\n+ \"iconIdx\": 12\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 319,\n+ \"order\": 361,\n\"id\": 18,\n\"name\": \"cloud\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 8\n+ \"iconIdx\": 13\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 320,\n+ \"order\": 362,\n\"id\": 19,\n\"name\": \"copy\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 9\n+ \"iconIdx\": 14\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 321,\n+ \"order\": 363,\n\"id\": 20,\n\"name\": \"smile\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 10\n+ \"iconIdx\": 15\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 322,\n+ \"order\": 364,\n\"id\": 21,\n\"name\": \"inbox\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 11\n+ \"iconIdx\": 16\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 323,\n+ \"order\": 365,\n\"id\": 22,\n\"name\": \"info-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 12\n+ \"iconIdx\": 17\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 324,\n+ \"order\": 366,\n\"id\": 23,\n\"name\": \"message-circle-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 13\n+ \"iconIdx\": 18\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 325,\n+ \"order\": 367,\n\"id\": 16,\n\"name\": \"question-circle\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 14\n+ \"iconIdx\": 19\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 326,\n+ \"order\": 368,\n\"id\": 17,\n\"name\": \"search\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 15\n+ \"iconIdx\": 20\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 327,\n+ \"order\": 369,\n\"id\": 15,\n\"name\": \"outline-key\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 16\n+ \"iconIdx\": 21\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 328,\n+ \"order\": 370,\n\"id\": 14,\n\"name\": \"chevron-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 17\n+ \"iconIdx\": 22\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 329,\n+ \"order\": 371,\n\"id\": 7,\n\"name\": \"arrow-left\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 18\n+ \"iconIdx\": 23\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 330,\n+ \"order\": 372,\n\"id\": 8,\n\"name\": \"arrow-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 19\n+ \"iconIdx\": 24\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 331,\n+ \"order\": 373,\n\"id\": 9,\n\"name\": \"cross\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 20\n+ \"iconIdx\": 25\n},\n{\n\"icon\": {\n},\n\"attrs\": [{}],\n\"properties\": {\n- \"order\": 332,\n+ \"order\": 374,\n\"id\": 10,\n\"name\": \"edit\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 21\n+ \"iconIdx\": 26\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 333,\n+ \"order\": 375,\n\"id\": 11,\n\"name\": \"filters\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 22\n+ \"iconIdx\": 27\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 334,\n+ \"order\": 376,\n\"id\": 12,\n\"name\": \"menu-horizontal\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 23\n+ \"iconIdx\": 28\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 335,\n+ \"order\": 377,\n\"id\": 13,\n\"name\": \"menu-vertical\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 24\n+ \"iconIdx\": 29\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 336,\n+ \"order\": 378,\n\"id\": 5,\n\"name\": \"calendar\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 25\n+ \"iconIdx\": 30\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 337,\n+ \"order\": 379,\n\"id\": 6,\n\"name\": \"message-square\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 26\n+ \"iconIdx\": 31\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 338,\n+ \"order\": 380,\n\"id\": 4,\n\"name\": \"message-square-lines\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 27\n+ \"iconIdx\": 32\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 339,\n+ \"order\": 381,\n\"id\": 3,\n\"name\": \"bell-disabled\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 28\n+ \"iconIdx\": 33\n},\n{\n\"icon\": {\n}\n],\n\"properties\": {\n- \"order\": 340,\n+ \"order\": 382,\n\"id\": 2,\n\"name\": \"chevron-right\",\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 29\n+ \"iconIdx\": 34\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 1,\n\"name\": \"send\",\n- \"order\": 341,\n+ \"order\": 383,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 30\n+ \"iconIdx\": 35\n},\n{\n\"icon\": {\n\"properties\": {\n\"id\": 0,\n\"name\": \"image\",\n- \"order\": 342,\n+ \"order\": 384,\n\"prevSize\": 32\n},\n\"setIdx\": 0,\n\"setId\": 1,\n- \"iconIdx\": 31\n+ \"iconIdx\": 36\n}\n],\n\"height\": 1024,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [chore] add additional icons for drop down menu
Summary: Adds additional icons {F15348}
Test Plan: clean cache, re-load page, icons should render as expected
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3249 |
129,179 | 22.02.2022 10:05:01 | 18,000 | becd97298c437c4c43885f5196763cd5c3229673 | [web] [chore] add icon types to Icons component
Summary: Type icon names, add auto-complete to icon component for better developer experience
Test Plan: flow shouldn't error out
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/SWMansionIcon.react.js",
"new_path": "web/SWMansionIcon.react.js",
"diff": "@@ -5,8 +5,48 @@ import IcomoonReact from 'react-icomoon';\nimport iconSet from './icons/selection.json';\n+export type Icon =\n+ | 'arrow-right-small'\n+ | 'bell'\n+ | 'logout'\n+ | 'plus-circle'\n+ | 'users'\n+ | 'chevron-right-small'\n+ | 'reply-arrow'\n+ | 'right-angle-arrow'\n+ | 'plus'\n+ | 'settings'\n+ | 'wrench'\n+ | 'Filled'\n+ | 'bug'\n+ | 'cloud'\n+ | 'copy'\n+ | 'smile'\n+ | 'inbox'\n+ | 'info-circle'\n+ | 'message-circle-line'\n+ | 'question-circle'\n+ | 'search'\n+ | 'outline-key'\n+ | 'chevron-left'\n+ | 'arrow-left'\n+ | 'arrow-right'\n+ | 'cross'\n+ | 'edit'\n+ | 'filters'\n+ | 'menu-horizontal'\n+ | 'menu-vertical'\n+ | 'message-square'\n+ | 'message-square-lines'\n+ | 'bell-disabled'\n+ | 'chevron-right'\n+ | 'send'\n+ | 'calendar'\n+ | 'message-circle-lines'\n+ | 'image';\n+\ntype SWMansionIconProps = {\n- +icon: string,\n+ +icon: Icon,\n+size: number | string,\n+color?: string,\n+title?: string,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-tab.react.js",
"new_path": "web/chat/chat-thread-tab.react.js",
"diff": "import classNames from 'classnames';\nimport * as React from 'react';\n-import SWMansionIcon from '../SWMansionIcon.react';\n+import SWMansionIcon, { type Icon } from '../SWMansionIcon.react';\nimport css from './chat-tabs.css';\ntype Props = {\n+title: string,\n+onClick: (title: string) => void,\n+tabIsActive: boolean,\n- +icon: string,\n+ +icon: Icon,\n};\nfunction ChatThreadTab(props: Props): React.Node {\nconst { title, onClick, tabIsActive, icon } = props;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [chore] add icon types to Icons component
Summary: Type icon names, add auto-complete to icon component for better developer experience
Test Plan: flow shouldn't error out
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3250 |
129,184 | 15.02.2022 15:27:51 | 28,800 | 970cc73a360c9ff6e1ac8e3bfac96b80c98d2bfb | [docker] Switch base image from `alpine:3.14` to `ubuntu:20.04`
Summary: This is Ubuntu "minimal" or whatever according to:
Test Plan: Putting this up to see what happens with the CI
Reviewers: varun, geekbrother, karol-bisztyga, jimpo, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/Dockerfile",
"new_path": "services/backup/docker-base/Dockerfile",
"diff": "@@ -4,8 +4,12 @@ ENV SHELL=/bin/bash\nCOPY services/backup/docker-base/contents /transferred\n-RUN apk update\n-RUN apk add curl-dev openssl-dev libuuid zlib-dev\n+RUN apt-get update && apt-get install -y \\\n+ libcurl4-openssl-dev \\\n+ libssl-dev \\\n+ uuid-dev \\\n+ zlib1g-dev\n+\nRUN cd /\nRUN /transferred/install_aws_sdk.sh\n"
},
{
"change_type": "MODIFY",
"old_path": "services/base-image/Dockerfile",
"new_path": "services/base-image/Dockerfile",
"diff": "-FROM alpine:3.14\n+FROM ubuntu:20.04\nENV SHELL=/bin/bash\n@@ -6,8 +6,17 @@ WORKDIR /\nCOPY contents /transferred\n-RUN apk update\n-RUN apk add bash cmake git build-base autoconf libtool pkgconfig boost-dev fmt gtest-dev\n+RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \\\n+ cmake \\\n+ git \\\n+ build-essential \\\n+ autoconf \\\n+ libtool \\\n+ pkg-config \\\n+ libboost-all-dev \\\n+ libfmt-dev \\\n+ libgtest-dev\n+\nRUN /transferred/install_grpc.sh\nCMD /bin/bash\n"
},
{
"change_type": "MODIFY",
"old_path": "services/blob/docker-base/Dockerfile",
"new_path": "services/blob/docker-base/Dockerfile",
"diff": "@@ -2,7 +2,7 @@ FROM commapp/backup-base:1.0\nCOPY services/tunnelbroker/docker-base/contents /transferred\n-RUN apk add openssl-dev\n+RUN apt-get install -y libssl-dev\nRUN /transferred/install_folly.sh\nCMD /bin/bash\n"
},
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/docker-base/Dockerfile",
"new_path": "services/tunnelbroker/docker-base/Dockerfile",
"diff": "@@ -4,8 +4,10 @@ ENV SHELL=/bin/bash\nCOPY services/tunnelbroker/docker-base/contents /transferred\n-RUN apk update\n-RUN apk add curl-dev openssl-dev zlib-dev\n+RUN apt-get update && apt-get install -y \\\n+ libcurl4-openssl-dev \\\n+ libssl-dev \\\n+ zlib1g-dev\n# Install SDKs\nRUN /transferred/install_folly.sh\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docker] Switch base image from `alpine:3.14` to `ubuntu:20.04`
Summary: This is Ubuntu "minimal" or whatever according to: https://ubuntu.com/blog/minimal-ubuntu-released
Test Plan: Putting this up to see what happens with the CI
Reviewers: varun, geekbrother, karol-bisztyga, jimpo, ashoat
Reviewed By: varun, karol-bisztyga, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3212 |
129,184 | 23.02.2022 12:44:54 | 18,000 | 9dda4dd52097119f7181fd7fe7538f4bbe46f255 | [CommCoreModule] Simplify `matchesInboundSession` return logic
Summary: Minor thing I noticed when working in `CryptoModule.cpp`
Test Plan: Close reading.. logic should be identical
Reviewers: karol-bisztyga, varun, palys-swm, jimpo, ashoat
Subscribers: benschac, ashoat, Adrian | [
{
"change_type": "MODIFY",
"old_path": "native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp",
"new_path": "native/cpp/CommonCpp/CryptoTools/CryptoModule.cpp",
"diff": "@@ -176,16 +176,13 @@ bool CryptoModule::matchesInboundSession(\n// Check that the inbound session matches the key this message is supposed\n// to be from.\ntmpEncryptedMessage = OlmBuffer(encryptedData.message);\n- if (1 !=\n+ return 1 ==\n::olm_matches_inbound_session_from(\nsession,\ntheirIdentityKey.data() + ID_KEYS_PREFIX_OFFSET,\nKEYSIZE,\ntmpEncryptedMessage.data(),\n- tmpEncryptedMessage.size())) {\n- return false;\n- }\n- return true;\n+ tmpEncryptedMessage.size());\n}\nPersist CryptoModule::storeAsB64(const std::string &secretKey) {\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [CommCoreModule] Simplify `matchesInboundSession` return logic
Summary: Minor thing I noticed when working in `CryptoModule.cpp`
Test Plan: Close reading.. logic should be identical
Reviewers: karol-bisztyga, varun, palys-swm, jimpo, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian
Differential Revision: https://phabricator.ashoat.com/D3269 |
129,185 | 24.02.2022 13:11:50 | -3,600 | 6eefa46c7da69a7c48d4892296da58561e527f80 | [web] Disable "see full structure" button
Summary:
I disabled the button until we will have the feature implemented.
Test Plan:
The text disappears from bar on web.
{F15598}
Reviewers: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-ancestors.react.js",
"new_path": "web/chat/chat-thread-ancestors.react.js",
"diff": "@@ -11,6 +11,8 @@ import { useSelector } from '../redux/redux-utils';\nimport SWMansionIcon from '../SWMansionIcon.react';\nimport css from './chat-thread-ancestors.css';\n+const SHOW_SEE_FULL_STRUCTURE = false;\n+\ntype ThreadAncestorsProps = {\n+threadInfo: ThreadInfo,\n};\n@@ -97,6 +99,18 @@ function ThreadAncestors(props: ThreadAncestorsProps): React.Node {\n);\n}, [threadHasNoAncestors, threadColorStyle, threadInfo.uiName]);\n+ let seeFullStructure = null;\n+ if (SHOW_SEE_FULL_STRUCTURE) {\n+ seeFullStructure = (\n+ <button\n+ style={fullStructureButtonColorStyle}\n+ className={css.seeFullStructure}\n+ >\n+ See full structure\n+ </button>\n+ );\n+ }\n+\nreturn (\n<>\n<div className={css.ancestorThreadsContainer}>\n@@ -104,12 +118,7 @@ function ThreadAncestors(props: ThreadAncestorsProps): React.Node {\n{middlePath}\n{currentThread}\n</div>\n- <button\n- style={fullStructureButtonColorStyle}\n- className={css.seeFullStructure}\n- >\n- See full structure\n- </button>\n+ {seeFullStructure}\n</>\n);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Disable "see full structure" button
Summary:
https://linear.app/comm/issue/ENG-783/see-full-structure-button-doesnt-do-anything
I disabled the button until we will have the feature implemented.
Test Plan:
The text disappears from bar on web.
{F15598}
Reviewers: palys-swm, ashoat
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, Adrian, atul, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3262 |
129,179 | 24.02.2022 16:20:33 | 18,000 | b54b78480344195e857a34d405c057c9dbcf3afb | [web] [refactor] create modal context, use for setModal
Summary:
adds modal context to be used instead of internal state so we don't have to prop drill
Depends On: D3214
Test Plan: n/a this doesn't do anything yet.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "web/modals/modal-provider.react.js",
"diff": "+// @flow\n+\n+import invariant from 'invariant';\n+import * as React from 'react';\n+\n+type Props = {\n+ +children: React.Node,\n+};\n+type ModalContextType = {\n+ +modal: ?React.Node,\n+ +setModal: (?React.Node) => void,\n+ +clearModal: () => void,\n+};\n+\n+const ModalContext: React.Context<?ModalContextType> = React.createContext<?ModalContextType>(\n+ {\n+ modal: null,\n+ setModal: () => {},\n+ clearModal: () => {},\n+ },\n+);\n+\n+function ModalProvider(props: Props): React.Node {\n+ const { children } = props;\n+ const [modal, setModal] = React.useState(null);\n+ const clearModal = React.useCallback(() => setModal(null), []);\n+\n+ const value = React.useMemo(\n+ () => ({\n+ modal,\n+ setModal,\n+ clearModal,\n+ }),\n+ [modal, clearModal],\n+ );\n+\n+ return (\n+ <ModalContext.Provider value={value}>{children}</ModalContext.Provider>\n+ );\n+}\n+\n+function useModalContext(): ModalContextType {\n+ const context = React.useContext(ModalContext);\n+ invariant(context, 'ModalContext not found');\n+\n+ return context;\n+}\n+\n+export { ModalProvider, useModalContext };\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] create modal context, use for setModal
Summary:
adds modal context to be used instead of internal state so we don't have to prop drill
Depends On: D3214
Test Plan: n/a this doesn't do anything yet.
Reviewers: atul, ashoat
Reviewed By: ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3215 |
129,179 | 24.02.2022 16:44:23 | 18,000 | 6e04330f42aab96389295a9224166bdcec42ed56 | [web] [refactor] chat thread list item menu html cleanup
Summary:
fix up html + css while changing the unread theme
before: {F16220}
after: {F16221}
Test Plan: click unread, no new functionality or changes should happen.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list-item-menu.react.js",
"new_path": "web/chat/chat-thread-list-item-menu.react.js",
"diff": "@@ -74,23 +74,18 @@ function ChatThreadListItemMenu(props: Props): React.Node {\n}`;\nconst menuIconSize = renderStyle === 'chat' ? 24 : 16;\n+ const btnCls = classNames(css.menuContent, {\n+ [css.menuContentVisible]: menuVisible,\n+ });\nreturn (\n<div className={css.menu} onMouseLeave={hideMenu}>\n<button onClick={toggleMenu}>\n<SWMansionIcon icon=\"menu-vertical\" size={menuIconSize} />\n</button>\n- <div\n- className={classNames(css.menuContent, {\n- [css.menuContentVisible]: menuVisible,\n- })}\n- >\n- <ul>\n- <li>\n- <button onClick={toggleUnreadStatus}>\n+ <div>\n+ <button className={btnCls} onClick={toggleUnreadStatus}>\n{toggleUnreadStatusButtonText}\n</button>\n- </li>\n- </ul>\n</div>\n</div>\n);\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-thread-list.css",
"new_path": "web/chat/chat-thread-list.css",
"diff": "@@ -191,19 +191,14 @@ div.sidebar:hover .menu {\n.menuContentVisible {\ndisplay: block;\n}\n-.menuContent ul {\n- list-style: none;\n-}\n-.menuContent li:not(:last-child) {\n- border-bottom: 1px solid #dddddd;\n-}\n-.menuContent button {\n+\n+button.menuContent {\nborder: none;\ncursor: pointer;\npadding: 10px;\nfont-size: 16px;\n}\n-.menuContent button:hover {\n+button.menuContent:hover {\nbackground-color: #dddddd;\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [refactor] chat thread list item menu html cleanup
Summary:
fix up html + css while changing the unread theme
before: {F16220}
after: {F16221}
Test Plan: click unread, no new functionality or changes should happen.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3180 |
129,184 | 24.02.2022 17:13:40 | 18,000 | b417f69c4044da4e0f32aee99f940f6c68d175ad | [web] Fix `TextMessage` styling for inbound messages
Summary:
Before:
After:
Test Plan: NA
Reviewers: palys-swm, def-au1t, varun, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -111,6 +111,9 @@ div.textMessage {\nwidth: 100%;\nbox-sizing: border-box;\n}\n+div.textMessageDefaultBackground {\n+ background-color: var(--text-message-default-background);\n+}\ndiv.normalTextMessage {\nfont-size: 16px;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/text-message.react.js",
"new_path": "web/chat/text-message.react.js",
"diff": "@@ -39,18 +39,17 @@ function TextMessage(props: Props): React.Node {\n} = props.item.messageInfo;\nconst messageStyle = {};\n- let darkColor = false;\n+ let darkColor = true;\nif (isViewer) {\nconst threadColor = props.threadInfo.color;\ndarkColor = colorIsDark(threadColor);\nmessageStyle.backgroundColor = `#${threadColor}`;\n- } else {\n- messageStyle.backgroundColor = 'rgba(221,221,221,0.73)';\n}\nconst onlyEmoji = onlyEmojiRegex.test(text);\nconst messageClassName = classNames({\n[css.textMessage]: true,\n+ [css.textMessageDefaultBackground]: !isViewer,\n[css.normalTextMessage]: !onlyEmoji,\n[css.emojiOnlyTextMessage]: onlyEmoji,\n[css.darkTextMessage]: darkColor,\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--thread-ancestor-keyserver-border: var(--shades-black-70);\n--thread-ancestor-color-light: var(--shades-white-70);\n--thread-ancestor-color-dark: var(--shades-black-100);\n+ --text-message-default-background: var(--shades-black-80);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix `TextMessage` styling for inbound messages
Summary:
Before: https://blob.sh/atul/2427.png
After: https://blob.sh/atul/d70c.png
Test Plan: NA
Reviewers: palys-swm, def-au1t, varun, benschac, ashoat
Reviewed By: palys-swm, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3272 |
129,184 | 25.02.2022 11:50:57 | 18,000 | 2ceaa19650940459a8d776408a27a697c2beb0c6 | [web] Get rid of duplicate variables in `theme.css`
Summary: NA
Test Plan: NA
Reviewers: varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--modal-bg: var(--shades-black-90);\n--join-bg: var(--shades-black-90);\n--help-color: var(--shades-black-60);\n- --modal-bg: var(--shades-black-90);\n--breadcrumb-color: var(--shades-black-60);\n--breadcrumb-color-unread: var(--shades-white-60);\n- --join-bg: var(--shades-black-90);\n--btn-secondary-border: var(--shades-black-60);\n--thread-color-read: var(--shades-black-60);\n--thread-from-color-read: var(--shades-black-80);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of duplicate variables in `theme.css`
Summary: NA
Test Plan: NA
Reviewers: varun, ashoat
Reviewed By: varun, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3291 |
129,179 | 25.02.2022 16:48:42 | 18,000 | aaff95b79181c891865ad2f6c00a8af512d13bfb | [web] [chore] fix typo calandarQuery --> calendarQuery
Summary: Saw a typo and wanted to fix it.
Test Plan: N/A application should run as expected.
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/calendar/entry.react.js",
"new_path": "web/calendar/entry.react.js",
"diff": "@@ -482,7 +482,7 @@ const ConnectedEntry: React.ComponentType<BaseProps> = React.memo<BaseProps>(\nstate =>\n!!(state.currentUserInfo && !state.currentUserInfo.anonymous && true),\n);\n- const calanderQuery = useSelector(nonThreadCalendarQuery);\n+ const calendarQuery = useSelector(nonThreadCalendarQuery);\nconst online = useSelector(\nstate => state.connection.status === 'connected',\n);\n@@ -497,7 +497,7 @@ const ConnectedEntry: React.ComponentType<BaseProps> = React.memo<BaseProps>(\n{...props}\nthreadInfo={threadInfo}\nloggedIn={loggedIn}\n- calendarQuery={calanderQuery}\n+ calendarQuery={calendarQuery}\nonline={online}\ncreateEntry={callCreateEntry}\nsaveEntry={callSaveEntry}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] [chore] fix typo calandarQuery --> calendarQuery
Summary: Saw a typo and wanted to fix it.
Test Plan: N/A application should run as expected.
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3289 |
129,184 | 23.02.2022 23:29:38 | 18,000 | 8ac1900c521b72e1003825f774d3c046fb615bca | [web] Introduce and style `messageActionContainer` for `ComposedMessage`
Summary:
Before:
After:
Illustration of `messageActionActiveArea`:
Test Plan: NA
Reviewers: palys-swm, def-au1t, benschac, varun, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/chat-message-list.css",
"new_path": "web/chat/chat-message-list.css",
"diff": "@@ -82,24 +82,43 @@ div.messageBottomRightTooltip:after {\nborder-color: transparent transparent var(--tool-tip-bg) transparent;\n}\n-div.messageActionLinks {\n+div.messageActionActiveArea {\nposition: absolute;\ndisplay: flex;\ntop: 0;\nbottom: 0;\nalign-items: center;\n- color: gray;\n- padding: 0 6px;\n+ padding: 0 12px;\n}\n-div.viewerMessageActionLinks {\n+\n+div.viewerMessageActionActiveArea {\nright: 100%;\n}\n-div.nonViewerMessageActionLinks {\n+div.nonViewerMessageActiveArea {\nleft: 100%;\n}\n-div.messageActionLinks > div + div {\n+div.messageActionActiveArea > div + div {\nmargin-left: 4px;\n}\n+\n+div.messageActionContainer {\n+ display: flex;\n+ flex-direction: row;\n+ align-items: center;\n+ justify-content: center;\n+ padding: 0 6px;\n+ background-color: var(--message-action-tooltip-bg);\n+ border-radius: 8px;\n+}\n+\n+div.messageActionContainer svg {\n+ padding: 10px 6px 6px;\n+ color: var(--fg);\n+}\n+div.messageActionContainer svg:hover {\n+ cursor: pointer;\n+}\n+\ndiv.messageActionLinkIcon:hover {\ncursor: pointer;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -166,25 +166,29 @@ class ComposedMessage extends React.PureComponent<Props> {\nviewerActionLinks = (\n<div\nclassName={classNames(\n- css.messageActionLinks,\n- css.viewerMessageActionLinks,\n+ css.messageActionActiveArea,\n+ css.viewerMessageActionActiveArea,\n)}\n>\n+ <div className={css.messageActionContainer}>\n{messageActionButton}\n{replyButton}\n</div>\n+ </div>\n);\n} else if (replyButton || messageActionButton) {\nnonViewerActionLinks = (\n<div\nclassName={classNames(\n- css.messageActionLinks,\n- css.nonViewerMessageActionLinks,\n+ css.messageActionActiveArea,\n+ css.nonViewerMessageActiveArea,\n)}\n>\n+ <div className={css.messageActionContainer}>\n{replyButton}\n{messageActionButton}\n</div>\n+ </div>\n);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "web/theme.css",
"new_path": "web/theme.css",
"diff": "--thread-ancestor-color-light: var(--shades-white-70);\n--thread-ancestor-color-dark: var(--shades-black-100);\n--text-message-default-background: var(--shades-black-80);\n+ --message-action-tooltip-bg: var(--shades-black-90);\n}\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Introduce and style `messageActionContainer` for `ComposedMessage`
Summary:
Before: https://blob.sh/atul/36ae.png
After: https://blob.sh/atul/5b10.png
Illustration of `messageActionActiveArea`: https://blob.sh/atul/aa2b.png
Test Plan: NA
Reviewers: palys-swm, def-au1t, benschac, varun, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3283 |
129,179 | 28.02.2022 10:18:13 | 18,000 | 15359388e442fc9c798288f64752ce27218e2eb7 | [1/n] [landing] add team page route
Summary:
add a route for the team page
{F6672}
Test Plan: go to route, make sure it renders
Reviewers: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov | [
{
"change_type": "MODIFY",
"old_path": "landing/landing.react.js",
"new_path": "landing/landing.react.js",
"diff": "import * as React from 'react';\nimport { useRouteMatch } from 'react-router-dom';\n+import { isDev } from 'lib/utils/dev-utils';\n+\nimport AppLanding from './app-landing.react';\nimport Footer from './footer.react';\nimport Header from './header.react';\n@@ -10,6 +12,7 @@ import Keyservers from './keyservers.react';\nimport Privacy from './privacy.react';\nimport QR from './qr.react';\nimport Support from './support.react';\n+import Team from './team.react';\nimport Terms from './terms.react';\nimport useScrollToTopOnNavigate from './use-scroll-to-top-on-navigate.react';\nimport './reset.css';\n@@ -22,6 +25,7 @@ function Landing(): React.Node {\nconst onSupport = useRouteMatch({ path: '/support' });\nconst onKeyservers = useRouteMatch({ path: '/keyservers' });\nconst onQR = useRouteMatch({ path: '/qr' });\n+ const onTeam = useRouteMatch({ path: '/team' });\nconst scrollToSubscriptionForm = React.useCallback(async (e: Event) => {\ne.preventDefault();\n@@ -40,6 +44,8 @@ function Landing(): React.Node {\nreturn <Keyservers />;\n} else if (onQR) {\nreturn <QR />;\n+ } else if (isDev && onTeam) {\n+ return <Team />;\n} else {\nreturn <AppLanding onRequestAccess={scrollToSubscriptionForm} />;\n}\n@@ -48,6 +54,7 @@ function Landing(): React.Node {\nonPrivacy,\nonSupport,\nonTerms,\n+ onTeam,\nonQR,\nscrollToSubscriptionForm,\n]);\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "landing/team.react.js",
"diff": "+// @flow\n+\n+import * as React from 'react';\n+\n+function Team(): React.Node {\n+ return (\n+ <div>\n+ <h1>Team page</h1>\n+ </div>\n+ );\n+}\n+\n+export default Team;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [1/n] [landing] add team page route
Summary:
add a route for the team page
{F6672}
Test Plan: go to route, make sure it renders
Reviewers: atul, ashoat
Reviewed By: atul, ashoat
Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga, boristopalov
Differential Revision: https://phabricator.ashoat.com/D2748 |
129,184 | 27.02.2022 17:45:49 | 18,000 | cd1400550f0d945df5f96bdc36c26b6e1a9da32f | [docker] Run `rm -rf /var/lib/apt/lists/*` after `apt-get install`
Summary: Addresses feedback from
Test Plan: CI
Reviewers: jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, jimpo | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-base/Dockerfile",
"new_path": "services/backup/docker-base/Dockerfile",
"diff": "@@ -8,7 +8,8 @@ RUN apt-get update && apt-get install -y \\\nlibcurl4-openssl-dev \\\nlibssl-dev \\\nuuid-dev \\\n- zlib1g-dev\n+ zlib1g-dev \\\n+ && rm -rf /var/lib/apt/lists/*\nRUN cd /\nRUN /transferred/install_aws_sdk.sh\n"
},
{
"change_type": "MODIFY",
"old_path": "services/base-image/Dockerfile",
"new_path": "services/base-image/Dockerfile",
"diff": "@@ -15,7 +15,8 @@ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \\\npkg-config \\\nlibboost-all-dev \\\nlibfmt-dev \\\n- libgtest-dev\n+ libgtest-dev \\\n+ && rm -rf /var/lib/apt/lists/*\nRUN /transferred/install_grpc.sh\n"
},
{
"change_type": "MODIFY",
"old_path": "services/blob/docker-base/Dockerfile",
"new_path": "services/blob/docker-base/Dockerfile",
"diff": "@@ -2,7 +2,7 @@ FROM commapp/backup-base:1.0\nCOPY services/tunnelbroker/docker-base/contents /transferred\n-RUN apt-get install -y libssl-dev\n+RUN apt-get update && apt-get install -y libssl-dev && rm -rf /var/lib/apt/lists/*\nRUN /transferred/install_folly.sh\nCMD /bin/bash\n"
},
{
"change_type": "MODIFY",
"old_path": "services/tunnelbroker/docker-base/Dockerfile",
"new_path": "services/tunnelbroker/docker-base/Dockerfile",
"diff": "@@ -7,7 +7,8 @@ COPY services/tunnelbroker/docker-base/contents /transferred\nRUN apt-get update && apt-get install -y \\\nlibcurl4-openssl-dev \\\nlibssl-dev \\\n- zlib1g-dev\n+ zlib1g-dev \\\n+ && rm -rf /var/lib/apt/lists/*\n# Install SDKs\nRUN /transferred/install_folly.sh\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [docker] Run `rm -rf /var/lib/apt/lists/*` after `apt-get install`
Summary: Addresses feedback from @jimpo: https://phabricator.ashoat.com/D3212#88571
Test Plan: CI
Reviewers: jimpo
Reviewed By: jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, karol-bisztyga, jimpo
Differential Revision: https://phabricator.ashoat.com/D3295 |
129,184 | 25.02.2022 12:25:17 | 18,000 | 1ceb95e9448b929e19fb09b94542539b38ce38fd | [web] Get rid of "square" under `messageTooltipMenu`
Summary:
Before:
After:
Test Plan: NA
Reviewers: varun, benschac, def-au1t, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/tooltip.css",
"new_path": "web/chat/tooltip.css",
"diff": "@@ -14,14 +14,6 @@ div.messageTooltipMenu ul {\ndiv.messageTooltipMenu li:not(:last-child) {\npadding-bottom: 5px;\n}\n-div.messageTooltipMenu:after {\n- content: '';\n- position: absolute;\n- width: 0;\n- height: 0;\n- border-width: 7px;\n- border-style: solid;\n-}\ndiv.messageTooltipMenu button {\nborder: none;\ncursor: pointer;\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Get rid of "square" under `messageTooltipMenu`
Summary:
Before: https://blob.sh/atul/6b5c.png
After: https://blob.sh/atul/2041.png
Test Plan: NA
Reviewers: varun, benschac, def-au1t, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3301 |
129,184 | 28.02.2022 16:18:15 | 18,000 | 395d10a875b000515aaa3ff8fdb8f4d8669978a8 | [web] Remove unused styles
Summary: These styles no longer exist and I believe were left in by mistake.
Test Plan: NA
Reviewers: varun, def-au1t, benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -76,8 +76,6 @@ class ComposedMessage extends React.PureComponent<Props> {\n});\nconst messageBoxContainerClassName = classNames({\n[css.messageBoxContainer]: true,\n- [css.viewerMessageBoxContainer]: isViewer,\n- [css.nonViewerMessageBoxContainer]: !isViewer,\n[css.fixedWidthMessageBoxContainer]: this.props.fixedWidth,\n});\nconst messageBoxClassName = classNames({\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-button.js",
"new_path": "web/chat/message-action-button.js",
"diff": "@@ -134,28 +134,24 @@ function getMessageActionTooltipStyle(\nif (tooltipPosition === tooltipPositions.TOP_RIGHT) {\nclassName = classNames(\ncss.messageActionTopRightTooltip,\n- css.messageTopRightTooltip,\ncss.messageActionExtraAreaTop,\ncss.messageActionExtraAreaTopRight,\n);\n} else if (tooltipPosition === tooltipPositions.TOP_LEFT) {\nclassName = classNames(\ncss.messageActionTopLeftTooltip,\n- css.messageTopLeftTooltip,\ncss.messageActionExtraAreaTop,\ncss.messageActionExtraAreaTopLeft,\n);\n} else if (tooltipPosition === tooltipPositions.RIGHT) {\nclassName = classNames(\ncss.messageActionRightTooltip,\n- css.messageRightTooltip,\ncss.messageActionExtraArea,\ncss.messageActionExtraAreaRight,\n);\n} else if (tooltipPosition === tooltipPositions.LEFT) {\nclassName = classNames(\ncss.messageActionLeftTooltip,\n- css.messageLeftTooltip,\ncss.messageActionExtraArea,\ncss.messageActionExtraAreaLeft,\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Remove unused styles
Summary: These styles no longer exist and I believe were left in by mistake.
Test Plan: NA
Reviewers: varun, def-au1t, benschac, ashoat
Reviewed By: benschac, ashoat
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3305 |
129,184 | 28.02.2022 18:12:42 | 18,000 | 13216d67276e71a1b7522be1ea2262277a27c0b7 | [web] Fix typo in `style.css`
Summary: NA
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/style.css",
"new_path": "web/style.css",
"diff": "@@ -276,7 +276,7 @@ div.color-picker-selector {\nonly screen and (min-device-pixel-ratio: 2),\nonly screen and (min-resolution: 320dpi),\nonly screen and (min-resolution: 2dppx) {\n- headqer.header,\n+ header.header,\nheader.main-header,\ndiv.splash-header-container,\ndiv.splash-top-container,\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Fix typo in `style.css`
Summary: NA
Test Plan: NA
Reviewers: def-au1t, palys-swm, varun, benschac
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3308 |
129,184 | 28.02.2022 16:01:25 | 18,000 | 55aa432cc87d7204a7ca86fef3255565a678bcc1 | [web] Rename `MessageActionButton` to `MessageActionButtons`
Summary: After subsequent diffs, this component will be the parent of the sidebar and reply buttons.
Test Plan: NA, just separating this out for easier review
Reviewers: benschac, palys-swm, def-au1t, varun
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/composed-message.react.js",
"new_path": "web/chat/composed-message.react.js",
"diff": "@@ -19,7 +19,7 @@ import { type InputState, InputStateContext } from '../input/input-state';\nimport css from './chat-message-list.css';\nimport FailedSend from './failed-send.react';\nimport { InlineSidebar } from './inline-sidebar.react';\n-import MessageActionButton from './message-action-button';\n+import MessageActionButtons from './message-action-buttons';\nimport MessageReplyButton from './message-reply-button.react';\nimport {\ntype OnMessagePositionWithContainerInfo,\n@@ -148,7 +148,7 @@ class ComposedMessage extends React.PureComponent<Props> {\n: availableTooltipPositionsForNonViewerMessage;\nmessageActionButton = (\n- <MessageActionButton\n+ <MessageActionButtons\nthreadInfo={threadInfo}\nitem={item}\ncontainerPosition={\n"
},
{
"change_type": "RENAME",
"old_path": "web/chat/message-action-button.css",
"new_path": "web/chat/message-action-buttons.css",
"diff": ""
},
{
"change_type": "RENAME",
"old_path": "web/chat/message-action-button.js",
"new_path": "web/chat/message-action-buttons.js",
"diff": "@@ -12,7 +12,7 @@ import {\nuseOnClickPendingSidebar,\n} from '../selectors/nav-selectors';\nimport SWMansionIcon from '../SWMansionIcon.react';\n-import css from './message-action-button.css';\n+import css from './message-action-buttons.css';\nimport type {\nItemAndContainerPositionInfo,\nPositionInfo,\n@@ -25,13 +25,13 @@ const ellipsisIconExcessVerticalWhitespace = 10;\nconst openSidebarText = 'Go to sidebar';\nconst createSidebarText = 'Create sidebar';\n-type MessageActionTooltipProps = {\n+type MessageActionButtonsProps = {\n+threadInfo: ThreadInfo,\n+item: ChatMessageInfoItem,\n+containerPosition: PositionInfo,\n+availableTooltipPositions: $ReadOnlyArray<TooltipPosition>,\n};\n-function MessageActionButton(props: MessageActionTooltipProps): React.Node {\n+function MessageActionButtons(props: MessageActionButtonsProps): React.Node {\nconst {\nthreadInfo,\nitem,\n@@ -161,4 +161,4 @@ function getMessageActionTooltipStyle(\nreturn { className };\n}\n-export default MessageActionButton;\n+export default MessageActionButtons;\n"
},
{
"change_type": "MODIFY",
"old_path": "web/chat/robotext-message.react.js",
"new_path": "web/chat/robotext-message.react.js",
"diff": "@@ -16,7 +16,7 @@ import { linkRules } from '../markdown/rules.react';\nimport { useSelector } from '../redux/redux-utils';\nimport { updateNavInfoActionType } from '../types/nav-types';\nimport { InlineSidebar } from './inline-sidebar.react';\n-import MessageActionTooltip from './message-action-button';\n+import MessageActionButtons from './message-action-buttons';\nimport type {\nMessagePositionInfo,\nOnMessagePositionWithContainerInfo,\n@@ -66,7 +66,7 @@ class RobotextMessage extends React.PureComponent<Props> {\nsidebarExistsOrCanBeCreated\n) {\nmessageActionTooltip = (\n- <MessageActionTooltip\n+ <MessageActionButtons\nthreadInfo={threadInfo}\nitem={item}\ncontainerPosition={\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Rename `MessageActionButton` to `MessageActionButtons`
Summary: After subsequent diffs, this component will be the parent of the sidebar and reply buttons.
Test Plan: NA, just separating this out for easier review
Reviewers: benschac, palys-swm, def-au1t, varun
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3304 |
129,184 | 28.02.2022 21:45:01 | 18,000 | 0dffc27ea480416373e51e75448d2a8c38839b01 | [web] Misc renaming in `MessageActionButtons` component
Summary: Changed some previously implementation-specific variable names to be more generic
Test Plan: Find and replace
Reviewers: varun, benschac, def-au1t, palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga | [
{
"change_type": "MODIFY",
"old_path": "web/chat/message-action-buttons.js",
"new_path": "web/chat/message-action-buttons.js",
"diff": "@@ -20,7 +20,7 @@ import type {\nimport { tooltipPositions, type TooltipPosition } from './tooltip-utils';\nimport { TooltipMenu, type TooltipStyle, TooltipButton } from './tooltip.react';\n-const ellipsisIconExcessVerticalWhitespace = 10;\n+const messageActionIconExcessVerticalWhitespace = 10;\nconst openSidebarText = 'Go to sidebar';\nconst createSidebarText = 'Create sidebar';\n@@ -50,22 +50,24 @@ function MessageActionButtons(props: MessageActionButtonsProps): React.Node {\nconst rect = event.currentTarget.getBoundingClientRect();\nconst { top, bottom, left, right, width, height } = rect;\n- const dotsPosition: ItemAndContainerPositionInfo = {\n+ const iconPosition: ItemAndContainerPositionInfo = {\ncontainerPosition,\nitemPosition: {\ntop:\n- top - containerPosition.top + ellipsisIconExcessVerticalWhitespace,\n+ top -\n+ containerPosition.top +\n+ messageActionIconExcessVerticalWhitespace,\nbottom:\nbottom -\ncontainerPosition.top -\n- ellipsisIconExcessVerticalWhitespace,\n+ messageActionIconExcessVerticalWhitespace,\nleft: left - containerPosition.left,\nright: right - containerPosition.left,\nwidth,\n- height: height - ellipsisIconExcessVerticalWhitespace * 2,\n+ height: height - messageActionIconExcessVerticalWhitespace * 2,\n},\n};\n- setPointingTo(dotsPosition);\n+ setPointingTo(iconPosition);\n},\n[containerPosition, tooltipVisible],\n);\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [web] Misc renaming in `MessageActionButtons` component
Summary: Changed some previously implementation-specific variable names to be more generic
Test Plan: Find and replace
Reviewers: varun, benschac, def-au1t, palys-swm
Reviewed By: palys-swm
Subscribers: ashoat, Adrian, karol-bisztyga
Differential Revision: https://phabricator.ashoat.com/D3312 |
129,190 | 04.03.2022 11:52:31 | 0 | d160f83fb92dfde3a356fb83ad3e4058b0d506b7 | [services] Backup - add Database Entities Tools
Summary:
There is a "DB schema" described as in D2950 and the method for creating items by type.
Depends on D3076
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h",
"diff": "+#pragma once\n+\n+#include \"Item.h\"\n+\n+#include <memory>\n+#include <type_traits>\n+\n+namespace comm {\n+namespace network {\n+namespace database {\n+\n+template <typename T> std::shared_ptr<T> createItemByType() {\n+ static_assert(std::is_base_of<Item, T>::value, \"T must inherit from Item\");\n+ return std::make_shared<T>();\n+}\n+\n+} // namespace database\n+} // namespace network\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - add Database Entities Tools
Summary:
There is a "DB schema" described as in D2950 and the method for creating items by type.
Depends on D3076
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3081 |
129,190 | 04.03.2022 11:55:25 | 0 | c96a1b5897235638a17fa52cfe5a5a56529d61bc | [services] Backup - Database - add Log Item
Summary:
Item for `UserPersist` database entity
Depends on D3082
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: jimpo, benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"new_path": "services/backup/docker-server/contents/server/CMakeLists.txt",
"diff": "@@ -49,7 +49,7 @@ if ($ENV{COMM_SERVICES_DEV_MODE} MATCHES 1)\nset(DEV_HEADERS_PATH \"./dev\")\nendif()\n-file(GLOB SOURCE_CODE \"./src/*.cpp\")\n+file(GLOB SOURCE_CODE \"./src/*.cpp\" \"./src/**/*.cpp\")\nlist(FILTER SOURCE_CODE EXCLUDE REGEX \".*.dev.cpp$\")\nforeach (ITEM ${DEV_SOURCE_CODE})\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Constants.h",
"new_path": "services/backup/docker-server/contents/server/src/Constants.h",
"diff": "@@ -22,5 +22,11 @@ const size_t GRPC_METADATA_SIZE_PER_MESSAGE = 5;\nconst std::string AWS_REGION = \"us-east-2\";\n+#ifdef COMM_TEST_SERVICES\n+const std::string LOG_TABLE_NAME = \"backup-service-log-test\";\n+#else\n+const std::string LOG_TABLE_NAME = \"backup-service-log\";\n+#endif\n+\n} // namespace network\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h",
"diff": "#include \"Item.h\"\n+#include \"LogItem.h\"\n+\n#include <memory>\n#include <type_traits>\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.cpp",
"diff": "+#include \"LogItem.h\"\n+\n+#include \"AwsTools.h\"\n+#include \"Constants.h\"\n+\n+#include <stdexcept>\n+\n+namespace comm {\n+namespace network {\n+namespace database {\n+\n+const std::string LogItem::FIELD_BACKUP_ID = \"backupID\";\n+const std::string LogItem::FIELD_LOG_ID = \"logID\";\n+const std::string LogItem::FIELD_PERSISTED_IN_BLOB = \"persistedInBlob\";\n+const std::string LogItem::FIELD_VALUE = \"value\";\n+const std::string LogItem::FIELD_ATTACHMENT_HOLDERS = \"attachmentHolders\";\n+\n+std::string LogItem::tableName = LOG_TABLE_NAME;\n+\n+LogItem::LogItem(\n+ const std::string backupID,\n+ const std::string logID,\n+ const bool persistedInBlob,\n+ const std::string value,\n+ std::vector<std::string> attachmentHolders)\n+ : backupID(backupID),\n+ logID(logID),\n+ persistedInBlob(persistedInBlob),\n+ value(value),\n+ attachmentHolders(attachmentHolders) {\n+ this->validate();\n+}\n+\n+LogItem::LogItem(const AttributeValues &itemFromDB) {\n+ this->assignItemFromDatabase(itemFromDB);\n+}\n+\n+void LogItem::validate() const {\n+ if (!this->backupID.size()) {\n+ throw std::runtime_error(\"backupID empty\");\n+ }\n+ if (!this->logID.size()) {\n+ throw std::runtime_error(\"logID empty\");\n+ }\n+ if (!this->value.size()) {\n+ throw std::runtime_error(\"value empty\");\n+ }\n+ // todo maybe check if values is not too big if persistedInBlob is false\n+}\n+\n+void LogItem::assignItemFromDatabase(const AttributeValues &itemFromDB) {\n+ try {\n+ this->backupID = itemFromDB.at(LogItem::FIELD_BACKUP_ID).GetS();\n+ this->logID = itemFromDB.at(LogItem::FIELD_LOG_ID).GetS();\n+ this->persistedInBlob = std::stoi(\n+ std::string(itemFromDB.at(LogItem::FIELD_PERSISTED_IN_BLOB).GetS())\n+ .c_str());\n+ this->value = itemFromDB.at(LogItem::FIELD_VALUE).GetS();\n+ this->attachmentHolders =\n+ itemFromDB.at(LogItem::FIELD_ATTACHMENT_HOLDERS).GetSS();\n+ } catch (std::logic_error &e) {\n+ throw std::runtime_error(\n+ \"invalid log item provided, \" + std::string(e.what()));\n+ }\n+ this->validate();\n+}\n+\n+std::string LogItem::getTableName() const {\n+ return LogItem::tableName;\n+}\n+\n+std::string LogItem::getPrimaryKey() const {\n+ return LogItem::FIELD_BACKUP_ID;\n+}\n+\n+std::string LogItem::getBackupID() const {\n+ return this->backupID;\n+}\n+\n+std::string LogItem::getLogID() const {\n+ return this->logID;\n+}\n+\n+bool LogItem::getPersistedInBlob() const {\n+ return this->persistedInBlob;\n+}\n+\n+std::string LogItem::getValue() const {\n+ return this->value;\n+}\n+\n+std::vector<std::string> LogItem::getAttachmentHolders() const {\n+ return this->attachmentHolders;\n+}\n+\n+} // namespace database\n+} // namespace network\n+} // namespace comm\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/LogItem.h",
"diff": "+#pragma once\n+\n+#include \"Item.h\"\n+\n+#include <string>\n+#include <vector>\n+\n+namespace comm {\n+namespace network {\n+namespace database {\n+\n+class LogItem : public Item {\n+\n+ std::string backupID;\n+ std::string logID;\n+ bool persistedInBlob;\n+ std::string value;\n+ std::vector<std::string> attachmentHolders;\n+\n+ void validate() const override;\n+\n+public:\n+ static std::string tableName;\n+ static const std::string FIELD_BACKUP_ID;\n+ static const std::string FIELD_LOG_ID;\n+ static const std::string FIELD_PERSISTED_IN_BLOB;\n+ static const std::string FIELD_VALUE;\n+ static const std::string FIELD_ATTACHMENT_HOLDERS;\n+\n+ LogItem() {\n+ }\n+ LogItem(\n+ const std::string backupID,\n+ const std::string logID,\n+ const bool persistedInBlob,\n+ const std::string value,\n+ std::vector<std::string> attachmentHolders);\n+ LogItem(const AttributeValues &itemFromDB);\n+\n+ void assignItemFromDatabase(const AttributeValues &itemFromDB) override;\n+\n+ std::string getTableName() const override;\n+ std::string getPrimaryKey() const override;\n+\n+ std::string getBackupID() const;\n+ std::string getLogID() const;\n+ bool getPersistedInBlob() const;\n+ std::string getValue() const;\n+ std::vector<std::string> getAttachmentHolders() const;\n+};\n+\n+} // namespace database\n+} // namespace network\n+} // namespace comm\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Database - add Log Item
Summary:
Item for `UserPersist` database entity
Depends on D3082
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: jimpo, benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3084 |
129,190 | 04.03.2022 11:56:04 | 0 | 2d9294c892848881bade6eb6ee221f13970b3195 | [services] Backup - Database - add Backup Item
Summary:
C++ representation of the backup database entity
Depends on D3084
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/Constants.h",
"new_path": "services/backup/docker-server/contents/server/src/Constants.h",
"diff": "@@ -24,8 +24,10 @@ const std::string AWS_REGION = \"us-east-2\";\n#ifdef COMM_TEST_SERVICES\nconst std::string LOG_TABLE_NAME = \"backup-service-log-test\";\n+const std::string BACKUP_TABLE_NAME = \"backup-service-backup-test\";\n#else\nconst std::string LOG_TABLE_NAME = \"backup-service-log\";\n+const std::string BACKUP_TABLE_NAME = \"backup-service-backup\";\n#endif\n} // namespace network\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.cpp",
"diff": "+#include \"BackupItem.h\"\n+\n+#include \"Constants.h\"\n+\n+namespace comm {\n+namespace network {\n+namespace database {\n+\n+const std::string BackupItem::FIELD_USER_ID = \"userID\";\n+const std::string BackupItem::FIELD_BACKUP_ID = \"backupID\";\n+const std::string BackupItem::FIELD_CREATED = \"created\";\n+const std::string BackupItem::FIELD_RECOVERY_DATA = \"recoveryData\";\n+const std::string BackupItem::FIELD_COMPACTION_HOLDER = \"compactionHolder\";\n+const std::string BackupItem::FIELD_ATTACHMENT_HOLDERS = \"attachmentHolders\";\n+\n+std::string BackupItem::tableName = BACKUP_TABLE_NAME;\n+\n+BackupItem::BackupItem(\n+ std::string userID,\n+ std::string backupID,\n+ uint64_t created,\n+ std::string recoveryData,\n+ std::string compactionHolder,\n+ std::vector<std::string> attachmentHolders)\n+ : userID(userID),\n+ backupID(backupID),\n+ created(created),\n+ recoveryData(recoveryData),\n+ compactionHolder(compactionHolder),\n+ attachmentHolders(attachmentHolders) {\n+ this->validate();\n+}\n+\n+BackupItem::BackupItem(const AttributeValues &itemFromDB) {\n+ this->assignItemFromDatabase(itemFromDB);\n+}\n+\n+void BackupItem::validate() const {\n+ if (!this->userID.size()) {\n+ throw std::runtime_error(\"userID empty\");\n+ }\n+ if (!this->backupID.size()) {\n+ throw std::runtime_error(\"backupID empty\");\n+ }\n+ if (!this->created) {\n+ throw std::runtime_error(\"created not provided\");\n+ }\n+ if (!this->recoveryData.size()) {\n+ throw std::runtime_error(\"recoveryData empty\");\n+ }\n+}\n+\n+void BackupItem::assignItemFromDatabase(const AttributeValues &itemFromDB) {\n+ try {\n+ this->userID = itemFromDB.at(BackupItem::FIELD_USER_ID).GetS();\n+ this->backupID = itemFromDB.at(BackupItem::FIELD_BACKUP_ID).GetS();\n+ this->created = std::stoll(\n+ std::string(itemFromDB.at(BackupItem::FIELD_CREATED).GetS()).c_str());\n+ this->recoveryData = itemFromDB.at(BackupItem::FIELD_RECOVERY_DATA).GetS();\n+ auto compactionHolder =\n+ itemFromDB.find(BackupItem::FIELD_COMPACTION_HOLDER);\n+ if (compactionHolder != itemFromDB.end()) {\n+ this->compactionHolder = compactionHolder->second.GetS();\n+ }\n+ auto attachmentsHolders =\n+ itemFromDB.find(BackupItem::FIELD_ATTACHMENT_HOLDERS);\n+ if (attachmentsHolders != itemFromDB.end()) {\n+ this->attachmentHolders = attachmentsHolders->second.GetSS();\n+ }\n+ } catch (std::logic_error &e) {\n+ throw std::runtime_error(\n+ \"invalid backup item provided, \" + std::string(e.what()));\n+ }\n+ this->validate();\n+}\n+\n+std::string BackupItem::getTableName() const {\n+ return BackupItem::tableName;\n+}\n+\n+std::string BackupItem::getPrimaryKey() const {\n+ return BackupItem::FIELD_USER_ID;\n+}\n+\n+std::string BackupItem::getUserID() const {\n+ return this->userID;\n+}\n+\n+std::string BackupItem::getBackupID() const {\n+ return this->backupID;\n+}\n+\n+uint64_t BackupItem::getCreated() const {\n+ return this->created;\n+}\n+\n+std::string BackupItem::getRecoveryData() const {\n+ return this->recoveryData;\n+}\n+\n+std::string BackupItem::getCompactionHolder() const {\n+ return this->compactionHolder;\n+}\n+\n+std::vector<std::string> BackupItem::getAttachmentHolders() const {\n+ return this->attachmentHolders;\n+}\n+\n+} // namespace database\n+} // namespace network\n+} // namespace comm\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/BackupItem.h",
"diff": "+#pragma once\n+\n+#include \"Item.h\"\n+\n+#include <string>\n+#include <vector>\n+\n+namespace comm {\n+namespace network {\n+namespace database {\n+\n+class BackupItem : public Item {\n+\n+ std::string userID;\n+ std::string backupID;\n+ uint64_t created;\n+ std::string recoveryData;\n+ std::string compactionHolder;\n+ std::vector<std::string> attachmentHolders;\n+\n+ void validate() const override;\n+\n+public:\n+ static std::string tableName;\n+ static const std::string FIELD_USER_ID;\n+ static const std::string FIELD_BACKUP_ID;\n+ static const std::string FIELD_CREATED;\n+ static const std::string FIELD_RECOVERY_DATA;\n+ static const std::string FIELD_COMPACTION_HOLDER;\n+ static const std::string FIELD_ATTACHMENT_HOLDERS;\n+\n+ BackupItem() {\n+ }\n+ BackupItem(\n+ std::string userID,\n+ std::string backupID,\n+ uint64_t created,\n+ std::string recoveryData,\n+ std::string compactionHolder,\n+ std::vector<std::string> attachmentHolders);\n+ BackupItem(const AttributeValues &itemFromDB);\n+\n+ void assignItemFromDatabase(const AttributeValues &itemFromDB) override;\n+\n+ std::string getTableName() const override;\n+ std::string getPrimaryKey() const override;\n+\n+ std::string getUserID() const;\n+ std::string getBackupID() const;\n+ uint64_t getCreated() const;\n+ std::string getRecoveryData() const;\n+ std::string getCompactionHolder() const;\n+ std::vector<std::string> getAttachmentHolders() const;\n+};\n+\n+} // namespace database\n+} // namespace network\n+} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h",
"new_path": "services/backup/docker-server/contents/server/src/DatabaseEntities/DatabaseEntitiesTools.h",
"diff": "#include \"Item.h\"\n+#include \"BackupItem.h\"\n#include \"LogItem.h\"\n#include <memory>\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Database - add Backup Item
Summary:
C++ representation of the backup database entity
Depends on D3084
Test Plan: -
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3087 |
129,190 | 04.03.2022 11:59:50 | 0 | a91bed30ff24a2acf215728d8ca61f3eae366852 | [services] Backup - Implementation structure
Summary:
Implementation structure based on the `.proto` file
Depends on D3087
Test Plan: Backup service builds successfully
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Subscribers: benschac, ashoat, palys-swm, Adrian, atul | [
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"new_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.cpp",
"diff": "@@ -12,11 +12,12 @@ BackupServiceImpl::BackupServiceImpl() {\nBackupServiceImpl::~BackupServiceImpl() {\nAws::ShutdownAPI({});\n}\n-/*\n+\ngrpc::Status BackupServiceImpl::CreateNewBackup(\ngrpc::ServerContext *context,\n- grpc::ServerReader<backup::CreateNewBackupRequest> *reader,\n- google::protobuf::Empty *response) {\n+ grpc::ServerReaderWriter<\n+ backup::CreateNewBackupResponse,\n+ backup::CreateNewBackupRequest> *stream) {\nreturn grpc::Status(grpc::StatusCode::UNIMPLEMENTED, \"not implemented yet\");\n}\n@@ -27,21 +28,21 @@ grpc::Status BackupServiceImpl::SendLog(\nreturn grpc::Status(grpc::StatusCode::UNIMPLEMENTED, \"not implemented yet\");\n}\n-grpc::Status BackupServiceImpl::PullBackupKey(\n+grpc::Status BackupServiceImpl::RecoverBackupKey(\ngrpc::ServerContext *context,\ngrpc::ServerReaderWriter<\n- backup::PullBackupKeyResponse,\n- backup::PullBackupKeyRequest> *stream) {\n+ backup::RecoverBackupKeyResponse,\n+ backup::RecoverBackupKeyRequest> *stream) {\nreturn grpc::Status(grpc::StatusCode::UNIMPLEMENTED, \"not implemented yet\");\n}\n-grpc::Status BackupServiceImpl::PullCompaction(\n+grpc::Status BackupServiceImpl::PullBackup(\ngrpc::ServerContext *context,\ngrpc::ServerReaderWriter<\n- backup::PullCompactionResponse,\n- backup::PullCompactionRequest> *stream) {\n+ backup::PullBackupResponse,\n+ backup::PullBackupRequest> *stream) {\nreturn grpc::Status(grpc::StatusCode::UNIMPLEMENTED, \"not implemented yet\");\n}\n-*/\n+\n} // namespace network\n} // namespace comm\n"
},
{
"change_type": "MODIFY",
"old_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.h",
"new_path": "services/backup/docker-server/contents/server/src/BackupServiceImpl.h",
"diff": "@@ -13,26 +13,26 @@ class BackupServiceImpl final : public backup::BackupService::Service {\npublic:\nBackupServiceImpl();\nvirtual ~BackupServiceImpl();\n- /*\n+\ngrpc::Status CreateNewBackup(\ngrpc::ServerContext *context,\n- grpc::ServerReader<backup::CreateNewBackupRequest> *reader,\n- google::protobuf::Empty *response) override;\n+ grpc::ServerReaderWriter<\n+ backup::CreateNewBackupResponse,\n+ backup::CreateNewBackupRequest> *stream) override;\ngrpc::Status SendLog(\ngrpc::ServerContext *context,\ngrpc::ServerReader<backup::SendLogRequest> *reader,\ngoogle::protobuf::Empty *response) override;\n- grpc::Status PullBackupKey(\n+ grpc::Status RecoverBackupKey(\ngrpc::ServerContext *context,\ngrpc::ServerReaderWriter<\n- backup::PullBackupKeyResponse,\n- backup::PullBackupKeyRequest> *stream) override;\n- grpc::Status PullCompaction(\n+ backup::RecoverBackupKeyResponse,\n+ backup::RecoverBackupKeyRequest> *stream) override;\n+ grpc::Status PullBackup(\ngrpc::ServerContext *context,\ngrpc::ServerReaderWriter<\n- backup::PullCompactionResponse,\n- backup::PullCompactionRequest> *stream) override;\n- */\n+ backup::PullBackupResponse,\n+ backup::PullBackupRequest> *stream) override;\n};\n} // namespace network\n"
}
] | JavaScript | BSD 3-Clause New or Revised License | comme2e/comm | [services] Backup - Implementation structure
Summary:
Implementation structure based on the `.proto` file
Depends on D3087
Test Plan: Backup service builds successfully
Reviewers: palys-swm, geekbrother, varun, ashoat, jimpo
Reviewed By: palys-swm, ashoat
Subscribers: benschac, ashoat, palys-swm, Adrian, atul
Differential Revision: https://phabricator.ashoat.com/D3158 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.