author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,427 | 22.04.2020 18:48:31 | 21,600 | 8b94f96b9c92e181f1ecb58840fddaa0ca2075ae | TCPMv2: Cleanup: remove TC_FLAGS_AUTO_TOGGLE_SUPPORTED
Calling tcpm_auto_toggle_supported() directly is simpler
and avoids bugs like crrev.com/c/2144482
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "#define TC_FLAGS_DISC_IDENT_IN_PROGRESS BIT(20)\n/* Flag to note we should check for connection */\n#define TC_FLAGS_CHECK_CONNECTION BIT(21)\n-/* Flag to n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Cleanup: remove TC_FLAGS_AUTO_TOGGLE_SUPPORTED
Calling tcpm_auto_toggle_supported() directly is simpler
and avoids bugs like crrev.com/c/2144482
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I93c4c616e19756bd596bfbf0097f7eff2fb2d15d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2160995
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,427 | 30.03.2020 18:10:30 | 21,600 | e0da937f6e9f5bf507b80e18d041be8bd7dc8d7a | Liara: adjust Sunwoda and SMP precharge_current
BRANCH=grunt
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/liara/battery.c",
"new_path": "board/liara/battery.c",
"diff": "@@ -89,7 +89,7 @@ const struct board_batt_params board_battery_info[] = {\n.voltage_max = 13200,\n.voltage_normal = 11520, /* mV */\n.voltage_min = 9000, /* mV */\n- .precharge_current = 256... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Liara: adjust Sunwoda and SMP precharge_current
BUG=b:151877162
BRANCH=grunt
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Icc7c1349db9ecfbb0fa71ab2305a3094dd1ecdac
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128891
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,282 | 22.04.2020 10:01:16 | -28,800 | 574a6e121a29a69aa67b5927a5b24c4251158f5c | jinlon: update thermal table for board version 3
BRANCH=firmware-hatch-12672.B
TEST=thermal team verified thermal policy is expected. | [
{
"change_type": "MODIFY",
"old_path": "board/jinlon/board.c",
"new_path": "board/jinlon/board.c",
"diff": "@@ -351,12 +351,10 @@ const static struct ec_thermal_config thermal_a = {\n.temp_host = {\n[EC_TEMP_THRESH_WARN] = 0,\n[EC_TEMP_THRESH_HIGH] = C_TO_K(75),\n- [EC_TEMP_THRESH_HALT] = C_TO_K(85)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | jinlon: update thermal table for board version 3
BUG=b:154564062
BRANCH=firmware-hatch-12672.B
TEST=thermal team verified thermal policy is expected.
Change-Id: I8455facfe534208ac41bd4a25f803c83e40dad8e
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2157343
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,427 | 22.04.2020 19:30:16 | 21,600 | 0392c499b633c5bfb53a61d4504b396e59671c7a | TCPMv2: Cleanup: Ensure PD_FLAGS_* are not used.
PD_FLAGS_* are TCPMv1 only, so make sure they are not used with
TCPMv2.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "common/usb_common.c",
"new_path": "common/usb_common.c",
"diff": "@@ -492,14 +492,6 @@ __overridable int pd_check_data_swap(int port,\nreturn (data_role == PD_ROLE_UFP) ? 1 : 0;\n}\n-__overridable void pd_check_dr_role(int port,\n- enum pd_data_role dr_role, i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Cleanup: Ensure PD_FLAGS_* are not used.
PD_FLAGS_* are TCPMv1 only, so make sure they are not used with
TCPMv2.
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I7a119c9745b0004b6067862205f185557f704cb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2161923
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,319 | 20.04.2020 22:11:40 | 25,200 | 87c2d45e333909cd2d9e2b187b83ca07cf7007cc | Gingerbread: Initial skeleton EC image.
This CL contains a skelton image. It is a derivative of honeybuns.
BRANCH=none
TEST=make BOARD=Gingerbread and verify that image builds successfully | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/gingerbread/board.c",
"diff": "+/* Copyright 2020 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* Gingerbread board-spe... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Gingerbread: Initial skeleton EC image.
This CL contains a skelton image. It is a derivative of honeybuns.
BUG=b:154667178
BRANCH=none
TEST=make BOARD=Gingerbread and verify that image builds successfully
Signed-off-by: Udaya Kiran Ammu <udaykiran@google.com>
Change-Id: I63a0e07956ed4cf430c09b94c9cd221fae3c4dd4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2161461
Reviewed-by: Scott Collyer <scollyer@chromium.org> |
136,427 | 22.04.2020 19:58:37 | 21,600 | 3ada77a6324ee45a5c3d440c8e686618fb0f4223 | TCPMv2: Cleanup pd_set_dual_role() events
Change pd_set_dual_role_no_wakeup() to take PD_EVENT_* param.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -410,22 +410,21 @@ static void tc_enable_try_src(int en)\natomic_clear(&pd_try_src, 1);\n}\n-static inline void pd_set_dual_role_no_wakeup(int port,\n- e... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Cleanup pd_set_dual_role() events
Change pd_set_dual_role_no_wakeup() to take PD_EVENT_* param.
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ibc29131a1f571830cd7fd6c8c4d54eccbacbf9fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2161922 |
136,282 | 27.04.2020 11:20:30 | -28,800 | 06d6c8cd58de175f8061906182b3e2a79728b9ef | garg: add HDMI SKU ID
BRANCH=octopus
TEST=make buildall -j
Tested-by: Henry Sun | [
{
"change_type": "MODIFY",
"old_path": "board/garg/board.c",
"new_path": "board/garg/board.c",
"diff": "@@ -299,7 +299,7 @@ void board_overcurrent_event(int port, int is_overcurrented)\nuint8_t board_get_usb_pd_port_count(void)\n{\n/* HDMI SKU has one USB PD port */\n- if (sku_id == 9)\n+ if (sku_id... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | garg: add HDMI SKU ID
BUG=b:146260545, b:152861752
BRANCH=octopus
TEST=make buildall -j
Change-Id: I824dc180f30b5e978342fea47a438e0dfa80e7cf
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167119
Reviewed-by: Henry Sun <henrysun@google.com>
Commit-Queue: Henry Sun <henrysun@google.com>
Tested-by: Henry Sun <henrysun@google.com> |
136,257 | 27.04.2020 14:18:39 | -28,800 | 7639883334b6b1586ac39823075ed17e30fccde3 | kakadu: update led pwm duty
Set led pwm duty to max to get full brightness.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
TEST=Check LED on kakadu. | [
{
"change_type": "MODIFY",
"old_path": "board/kakadu/led.c",
"new_path": "board/kakadu/led.c",
"diff": "@@ -116,8 +116,8 @@ static void kakadu_led_init(void)\nmt6370_led_set_dim_mode(LED_GREEN, dim);\nmt6370_led_set_pwm_frequency(LED_RED, freq);\nmt6370_led_set_pwm_frequency(LED_GREEN, freq);\n- mt6... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: update led pwm duty
Set led pwm duty to max to get full brightness.
BUG=b:152719659
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
TEST=Check LED on kakadu.
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I1f401580a463d3d6afeb68ce4f085bba3481f319
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167121
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,446 | 22.04.2020 18:46:03 | 25,200 | 64fa1645aae189d0f0bfb2802ee2f6c6fc092318 | tests/kb_8042: Add vivaldi keyboard tests
Add tests for the vivaldi keyboard
TEST=make -j buildall
BRANCH=None
Tested-by: Rajat Jain | [
{
"change_type": "MODIFY",
"old_path": "test/kb_8042.c",
"new_path": "test/kb_8042.c",
"diff": "@@ -255,6 +255,74 @@ static int test_sysjump_cont(void)\nreturn EC_SUCCESS;\n}\n+static const struct ec_response_keybd_config keybd_config = {\n+ .num_top_row_keys = 13,\n+ .action_keys = {\n+ TK_BACK, /*... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tests/kb_8042: Add vivaldi keyboard tests
Add tests for the vivaldi keyboard
Signed-off-by: Rajat Jain <rajatja@google.com>
BUG=b:154772934
TEST=make -j buildall
BRANCH=None
Change-Id: I3bd36162077a7770a6af30f6783b7c70736e8c74
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2162187
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Rajat Jain <rajatja@google.com>
Tested-by: Rajat Jain <rajatja@google.com> |
136,391 | 27.04.2020 11:58:42 | -28,800 | 24e7cabf30c5c756382bc6b0d2bcc16d9276913b | malefor: turn off USB4 and Thunderbolt support
Malefor board only support USB3, so turn off USB4 and Thunderbolt support.
BRANCH=none
TEST=male buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.h",
"new_path": "baseboard/volteer/baseboard.h",
"diff": "#define CONFIG_CMD_USB_PD_CABLE\n#define CONFIG_USB_PD_DECODE_SOP\n-/* Enabling Thunderbolt-compatible mode */\n-#define CONFIG_USB_PD_TBT_COMPAT_MODE\n-\n-/* Enabling USB4 m... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | malefor: turn off USB4 and Thunderbolt support
Malefor board only support USB3, so turn off USB4 and Thunderbolt support.
BUG=b:153996396
BRANCH=none
TEST=male buildall
Signed-off-by: xiong.huang <xiong.huang@bitland.corp-partner.google.com>
Change-Id: Iff87d7cae7876656ac082cfe322dd63d87a74b50
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167120
Reviewed-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,280 | 20.04.2020 13:31:17 | -28,800 | 626103813e35c43a21ca2af3a75ea7dc19d0c118 | power/mt8183: fix power btn behavior for clamshell devices
TEST=able to do hard showdown between 8~10 sec
BRANCH=kukui
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "power/mt8183.c",
"new_path": "power/mt8183.c",
"diff": "#define IN_ALL_S0 (IN_PGOOD_S0 & ~IN_SUSPEND_ASSERTED)\n/* Long power key press to force shutdown in S0. go/crosdebug */\n+#ifdef VARIANT_KUKUI_JACUZZI\n+#define FORCED_SHUTDOWN_DELAY (8 * SECOND)\n+#else... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | power/mt8183: fix power btn behavior for clamshell devices
BUG=b:154443823
TEST=able to do hard showdown between 8~10 sec
BRANCH=kukui
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ia06507c42ce492e83b758d2f70ad2a3f9e91212c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2155826
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,358 | 01.04.2020 15:47:21 | -19,080 | 5d7cc5d7e1100f0767d3bd0bf53c1f7de81f444e | Button: Add unit tests for simulated button press
Added unit test cases to verify the button simulate operations.
BRANCH=None
TEST= Executed all unit tests locally
make runhosttests -j | [
{
"change_type": "MODIFY",
"old_path": "test/button.c",
"new_path": "test/button.c",
"diff": "#include \"common.h\"\n#include \"console.h\"\n#include \"gpio.h\"\n+#include \"host_command.h\"\n#include \"test_util.h\"\n#include \"timer.h\"\n#include \"keyboard_config.h\"\n#include \"keyboard_protocol... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Button: Add unit tests for simulated button press
Added unit test cases to verify the button simulate operations.
BUG=b:149659987
BRANCH=None
TEST= Executed all unit tests locally
make runhosttests -j
Signed-off-by: pandeyan <anshuman.pandey@intel.com>
Change-Id: If936766e03d574590fd90b1ea7a543102e263b0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131966
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,257 | 29.04.2020 11:33:24 | -28,800 | 67fa59b3ad5e49877003f02b8c639d9ed7707a63 | kakadu: implementation of Vconn boost
Kakadu is (potentially) going to implement Vconn Boost to solve Apple
HDMI dongle issue in EVT.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/kakadu/gpio.inc",
"new_path": "board/kakadu/gpio.inc",
"diff": "@@ -48,8 +48,8 @@ GPIO_INT(POGO_ADC_INT_L, PIN(A, 6), GPIO_INT_BOTH,\n/* unused */\nGPIO(POGO_VBUS_PRESENT, PIN(A, 14), GPIO_INPUT)\n-/* unused after board rev 5 */\n-GPIO(USB_C0_DP_POLARITY... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: implementation of Vconn boost
Kakadu is (potentially) going to implement Vconn Boost to solve Apple
HDMI dongle issue in EVT.
BUG=b:155242849
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Change-Id: I2e7f60e5a6119777431852cca53f6f4e2dc13e89
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2172558
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,269 | 29.04.2020 15:13:36 | 25,200 | 1f692079b7ff0fd9f3bc1b0f0b7cd1a6b473b8d9 | test: Add on-device unit test for STM32 RTC
BRANCH=none
TEST=make BOARD=bloonchipper test-stm32f_rtc -j
Flash stm32f_rtc.bin and "runtest" in the console | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/build.mk",
"new_path": "board/hatch_fp/build.mk",
"diff": "@@ -20,3 +20,4 @@ test-list-y=\\\nrtc \\\nsha256 \\\nsha256_unrolled \\\n+ stm32f_rtc \\\n"
},
{
"change_type": "MODIFY",
"old_path": "board/nocturne_fp/build.mk",
"new_p... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: Add on-device unit test for STM32 RTC
BRANCH=none
BUG=b:151105339
TEST=make BOARD=bloonchipper test-stm32f_rtc -j
Flash stm32f_rtc.bin and "runtest" in the console
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I3debfd93b62cb269ad61af0e4ca7e195554b5548
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2171569
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,250 | 01.05.2020 11:42:54 | 25,200 | f2379de6f3e694153e782f7a10b074b57c226a72 | i2c-pseudo: Fix wrong word in ADAPTER_START documentation
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "extra/i2c_pseudo/Documentation.txt",
"new_path": "extra/i2c_pseudo/Documentation.txt",
"diff": "@@ -170,7 +170,7 @@ that has the same meaning as here.)\nWrite Command: ADAPTER_START\nExample: \"ADAPTER_START\\n\"\n-Details: Tells i2c-pseudo the actually create... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | i2c-pseudo: Fix wrong word in ADAPTER_START documentation
BRANCH=none
BUG=none
TEST=none
Change-Id: Ia8c99a4d68ba350f03cafa6457e673b8ca66a737
Signed-off-by: Matthew Blecker <matthewb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2176179
Reviewed-by: Harry Cutts <hcutts@chromium.org> |
136,368 | 04.05.2020 12:15:52 | 25,200 | c6626fa92e91e2195a2757435f2765e4b8232d55 | TCPMv2: Limit tc_is_vconn_src function to returning 0 or 1
BRANCH=none
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -1404,11 +1404,7 @@ void pd_request_vconn_swap(int port)\n#ifdef CONFIG_USBC_VCONN\nint tc_is_vconn_src(int port)\n{\n- if (get_state_tc(port) == TC_ATTA... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Limit tc_is_vconn_src function to returning 0 or 1
BUG=b:155653950
BRANCH=none
TEST=make -j buildall
Signed-off-by: Sam Hurst <shurst@google.com>
Change-Id: I0154175024f0f87fe217836a6e66720830f3e5d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2180924 |
136,305 | 04.05.2020 14:38:58 | 21,600 | 773db9a931ccc9ee591c04a6c610a805d74bdad8 | SM5803: Update charger inits
Updating inits per new suggestion from the vendor.
BRANCH=None
TEST=on waddledee, load inits and verify battery can be charged from C0 | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.c",
"new_path": "driver/charger/sm5803.c",
"diff": "@@ -224,9 +224,9 @@ static void sm5803_init(int chgnum)\nrv |= chg_write8(chgnum, 0x4F, 0xFF);\nrv |= chg_write8(chgnum, 0x50, 0x98);\n- rv |= chg_write8(chgnum, 0x51, 0x80);\n+ rv |= ch... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Update charger inits
Updating inits per new suggestion from the vendor.
BRANCH=None
BUG=None
TEST=on waddledee, load inits and verify battery can be charged from C0
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I00ec254e9b13da0e14618c3be9277bfdc6f9fc3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2181037
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,427 | 04.05.2020 19:44:49 | 21,600 | af09e1bdd78924850fd6f1c188c9203c77757153 | pi3hdx1204: Add driver.
Add simple driver to just turn power on and off via I2C.
BRANCH=none
TEST=check i2c writes | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -146,6 +146,7 @@ driver-$(CONFIG_USB_PD_TCPM_RAA489000)+=tcpm/raa489000.o\ndriver-$(CONFIG_USBC_RETIMER_INTEL_BB)+=retimer/bb_retimer.o\ndriver-$(CONFIG_USBC_RETIMER_NB7V904M)+=retimer/nb7v904m.o\ndr... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pi3hdx1204: Add driver.
Add simple driver to just turn power on and off via I2C.
BUG=b:154874071
BRANCH=none
TEST=check i2c writes
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I836340dbd7a9e41380d1469dac0a94e268bd2bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2181793
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,427 | 04.05.2020 19:56:11 | 21,600 | 95abc80e5b38434f92204eece73bc6974fdd30ac | Zork: Add PI3HDX1204 power control.
Power the PI3HDX1204 HDMI retimer on at resume and off at suspend.
BRANCH=none
TEST=HDMI still works | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"driver/bc12/pi3usb9201.h\"\n#include \"driver/ppc/aoz1380.h\"\n#include \"driver/ppc/nx20p348x.h\"\n+#include \"driver/retimer/pi3hdx1204.h\"\n#include \"driver/tcpm/nct... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zork: Add PI3HDX1204 power control.
Power the PI3HDX1204 HDMI retimer on at resume and off at suspend.
BUG=b:154874071
BRANCH=none
TEST=HDMI still works
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I1753177db4b99d2c4a6af0720ace70ad3ba7f530
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2181794
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,257 | 30.04.2020 10:36:39 | -28,800 | 4711c8b28efc892d3785bbfed69fd7545e63375d | damu: fix lid sensor rotation matrix
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=boot into OS and screen show normally. | [
{
"change_type": "MODIFY",
"old_path": "board/damu/board.c",
"new_path": "board/damu/board.c",
"diff": "@@ -337,15 +337,15 @@ static struct mutex g_base_mutex;\n/* Rotation matrixes */\nstatic const mat33_fp_t base_standard_ref = {\n- {0, FLOAT_TO_FP(1), 0},\n- {FLOAT_TO_FP(-1), 0, 0},\n- {0, 0, FLO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: fix lid sensor rotation matrix
BUG=b:155315888
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=boot into OS and screen show normally.
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I65176198555e37bb5deb7f54cbf49e767fe4253f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2172284
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,443 | 06.05.2020 16:52:34 | 25,200 | f7a387beb22193384309bfd9a199a84fad962a41 | compare_build.sh: Modularize parsing board groups
Allow reuse of the board/board-group parsing function.
BRANCH=none
TEST=./util/compare_build.sh -b "mchp fp -nucleo-h743zi"
TEST=./util/compare_build.sh | [
{
"change_type": "MODIFY",
"old_path": "util/compare_build.sh",
"new_path": "util/compare_build.sh",
"diff": "@@ -91,38 +91,18 @@ boards-with() {\ndone\n}\n+# Usage: parse-boards <associate_array_name> [board-grp1 [board-grp2...]]\n+parse-boards() {\n+ # shellcheck disable=SC2034\n+ local -n boards=... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | compare_build.sh: Modularize parsing board groups
Allow reuse of the board/board-group parsing function.
BRANCH=none
BUG=none
TEST=./util/compare_build.sh -b "mchp fp -nucleo-h743zi"
TEST=./util/compare_build.sh
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I7acaeaf93830c10dca2fa49c23593d0940191848
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110535 |
136,443 | 19.03.2020 11:52:37 | 25,200 | 6586dda0f619554169c905cd0a2eed3b227b2107 | compare_build.sh: Add stm32f4 and stm32h7 board groups
BRANCH=none
TEST=./util/compare_build.sh -b "stm32f4 stm32h7" | [
{
"change_type": "MODIFY",
"old_path": "util/compare_build.sh",
"new_path": "util/compare_build.sh",
"diff": "# * all - All boards that are built by the \"buildall\" target\n# * fp - All relevant boards for fingerprint\n# * stm32 - All boards that use an STM32 chip\n+# * stm32f4 - All boards that us... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | compare_build.sh: Add stm32f4 and stm32h7 board groups
BRANCH=none
BUG=none
TEST=./util/compare_build.sh -b "stm32f4 stm32h7"
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Ie7645300d3731bbd93449722b674b4806dff8063
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110536
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,257 | 05.05.2020 13:20:04 | -28,800 | 5f04430b37f229869b5afb0f7cee660800970d30 | damu: update LED GPIO pins
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=LED on damu work as expected. | [
{
"change_type": "MODIFY",
"old_path": "board/damu/gpio.inc",
"new_path": "board/damu/gpio.inc",
"diff": "@@ -84,7 +84,7 @@ GPIO(BOOTBLOCK_EN_L, PIN(C, 1), GPIO_ODR_HIGH)\nGPIO(EN_PP1800_S5_L, PIN(A, 14), GPIO_OUT_LOW)\nGPIO(USB_C0_DISCHARGE, PIN(B, 6), GPIO_OUT_LOW)\n-IOEX(PWR_LED_WHITE_L, EXPIN(0,... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: update LED GPIO pins
BUG=b:147163799
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=LED on damu work as expected.
Change-Id: Ie0d6a4b968cf6d186f420cda19ebe2ac9456c47c
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2182112
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,427 | 07.05.2020 11:38:29 | 21,600 | 461b02c3bf62c0fe6760571a9ae37efc3b84077f | Trembyle: Add EN_PWR_TOUCHPAD_PS2 GPIO
Allow reading EN_PWR_TOUCHPAD_PS2 for debugging.
BRANCH=none
TEST=gpioget EN_PWR_TOUCHPAD_PS2 | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/gpio.inc",
"new_path": "board/trembyle/gpio.inc",
"diff": "@@ -50,6 +50,7 @@ GPIO(USB_C0_IN_HPD, PIN(7, 3), GPIO_OUT_LOW) /* C0 IN Hotplug Detect */\nGPIO(DP1_HPD, PIN(F, 4), GPIO_OUT_LOW) /* C1 DP Hotplug Detect */\nGPIO(DP2_HPD, PIN(C, 1), GPI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Add EN_PWR_TOUCHPAD_PS2 GPIO
Allow reading EN_PWR_TOUCHPAD_PS2 for debugging.
BUG=b:154676993
BRANCH=none
TEST=gpioget EN_PWR_TOUCHPAD_PS2
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ifbde03181879289bc0433dc81d0282a3b109ee2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2188115
Reviewed-by: Martin Roth <martinroth@google.com> |
136,405 | 07.05.2020 15:59:49 | 25,200 | 2bd83ad7c1cef3808572ff4a6d90c92e571c6446 | Remove unused CONFIG macros
CONFIG_GPU, CONFIG_USB_SM_FRAMEWORK, CONFIG_BOARD_HAS_AFTER_RSMRST
are no longer used. This patch removes them.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define CONFIG_PWM\n/* SoC */\n-#define CONFIG_BOARD_HAS_AFTER_RSMRST\n#define CONFIG_BOARD_HAS_RTC_RESET\n#define CONFIG_CHIPSET_JASPERLAKE\n#define CONFIG_POWER_BUTTON\n"
}... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Remove unused CONFIG macros
CONFIG_GPU, CONFIG_USB_SM_FRAMEWORK, CONFIG_BOARD_HAS_AFTER_RSMRST
are no longer used. This patch removes them.
BUG=b/155996358
BRANCH=none
TEST=buildall
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Ia407850398c07b7cdb01cddb0288ae977b9dca82
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2189171
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,256 | 08.05.2020 13:37:12 | 21,600 | dd5c0437677814b24f24628da23725ea731db03c | cleanup: rename kpbs to kbps for i2c
This changes follows the hdctool change for c2d2 that ensures either
kpbs or kbps on the console output will work (CL:2161642)
BRANCH=servo
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "board/c2d2/board.c",
"new_path": "board/c2d2/board.c",
"diff": "@@ -753,7 +753,7 @@ static int command_enable_i2c(int argc, char **argv)\n}\n/* Print status for get and set case. */\n- ccprintf(\"I2C speed kpbs: %d\\n\",\n+ ccprintf(\"I2C speed kbps: %d\\n\",\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: rename kpbs to kbps for i2c
This changes follows the hdctool change for c2d2 that ensures either
kpbs or kbps on the console output will work (CL:2161642)
BRANCH=servo
BUG=none
TEST=builds
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I57e1638a4e8c9a61d58705c70d4d24c7b65e48bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191132
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,257 | 08.05.2020 14:54:09 | -28,800 | 8fc99fe9d0c8ac7aa2e4483a002b84df767bf64f | damu: modify lid accel to LIS2DWL
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/damu/board.c",
"new_path": "board/damu/board.c",
"diff": "#include \"chipset.h\"\n#include \"common.h\"\n#include \"console.h\"\n-#include \"driver/accel_lis2dh.h\"\n+#include \"driver/accel_lis2dw12.h\"\n#include \"driver/accelgyro_bmi_common.h\"\n#incl... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: modify lid accel to LIS2DWL
BUG=b:147689571
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I2e05202e062a16c9f746a13608c3d31d90148481
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2190099
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,257 | 11.05.2020 16:48:29 | -28,800 | 2cc64405ddbbac298d276b9ee52f73490e03415f | damu: fix battery cutoff
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=ectool batterycutoff | [
{
"change_type": "MODIFY",
"old_path": "board/damu/battery.c",
"new_path": "board/damu/battery.c",
"diff": "@@ -13,7 +13,7 @@ const struct board_batt_params board_battery_info[] = {\n.manuf_name = \"AS3GWRc3KA\",\n.device_name = \"C235-41\",\n.ship_mode = {\n- .reg_addr = 0x10,\n+ .reg_addr = 0x00,\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: fix battery cutoff
BUG=b:156209241
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=ectool batterycutoff
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: Ie2555d7f3254c193d9d76289f53b4833708c6c0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2193252
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,208 | 27.04.2020 14:23:25 | -28,800 | 467afef24f49b3f639da2d611a71a0f9007af6c2 | asurada: detect subboard type
There are two different subboard configurations on Asurada:
1. Type-C
2. HDMI
and they can be distinguished by EC_X_GPIO3.
BRANCH=master
TEST=ensure Type-C subboard is detected. | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "#include \"timer.h\"\n#include \"uart.h\"\n+#define CPRINTS(format, args...) cprints(CC_USBCHARGE, format, ## args)\n+#define CPRINTF(format, args...) cprintf(CC_USBCHARGE, format, ## args)\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: detect subboard type
There are two different subboard configurations on Asurada:
1. Type-C
2. HDMI
and they can be distinguished by EC_X_GPIO3.
BRANCH=master
BUG=b:154565980
TEST=ensure Type-C subboard is detected.
Change-Id: Ic7dfeaee8b0f6e84e1f2e598dc93deb773bee059
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167124
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,269 | 04.05.2020 13:51:23 | 25,200 | ba9dec325753f75bc3ba605cd321b4d2b6635bd1 | util: Remove unnecessary halt in gdbinit
The reset on the line before is sufficient.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "util/gdbinit",
"new_path": "util/gdbinit",
"diff": "@@ -70,8 +70,6 @@ define target hookpost-remote\nload {EC_DIR}/build/{BOARD}/{BIN_DIR}/{BIN_NAME}.obj\necho \\ Resetting target\nmonitor reset\n- echo \\ Halting target\n- monitor halt\necho \\ Setting breakp... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util: Remove unnecessary halt in gdbinit
The reset on the line before is sufficient.
BRANCH=none
BUG=none
TEST=none
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I7eef41a4263764375ff1c8a16bb462edf7b3209c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2190820
Commit-Queue: Craig Hesling <hesling@chromium.org>
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,330 | 11.05.2020 13:32:29 | 21,600 | b0dbe83daf55cd76056f3cda19b5fcfd0dac7596 | usb_pd_alt_mode_dfp: Move pd_set_svids_discovery
Place it next to the other SVIDs accessor functions.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_alt_mode_dfp.c",
"new_path": "common/usb_pd_alt_mode_dfp.c",
"diff": "@@ -442,15 +442,6 @@ void pd_set_identity_discovery(int port, enum tcpm_transmit_type type,\npd->identity_discovery = disc;\n}\n-void pd_set_svids_discovery(int port, enum tcpm... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_pd_alt_mode_dfp: Move pd_set_svids_discovery
Place it next to the other SVIDs accessor functions.
BUG=none
TEST=make buildall
BRANCH=none
Change-Id: I1ddfd5cc1d4617671e78c6405ddecc3d27be16fc
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2194260
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,280 | 24.04.2020 14:51:05 | -28,800 | fa31ad509dbdd852d72e9d48bf601dba2c026ff6 | asurada: set uart_rx gpio to hi-z
remove pull-down to save power
TEST=flash ec over ccd
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/gpio.inc",
"new_path": "board/asurada/gpio.inc",
"diff": "@@ -37,7 +37,7 @@ GPIO_INT(PMIC_EC_PWRGD, PIN(F, 3),\n/* Other interrupts */\nGPIO_INT(AC_PRESENT, PIN(M, 2), GPIO_INT_BOTH | GPIO_HIB_WAKE_HIGH,\nextpower_interrupt) /* ACOK_OD */\n-GPIO_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: set uart_rx gpio to hi-z
remove pull-down to save power
BUG=b:154279402
TEST=flash ec over ccd
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I876e4b967bd15b4129dc6777c440ecb82dcb8119
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2164466
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,345 | 13.05.2020 18:38:47 | -36,000 | b70e2768c856641e91205fdb50b20a4147b2a7e2 | puff: Determine BJ power based on fw config.
TEST=make buildall -j; chgsup reports current according to fw config
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "board/puff/board.c",
"new_path": "board/puff/board.c",
"diff": "@@ -172,17 +172,16 @@ static void adp_connect_deferred(void)\nif (connected == adp_connected)\nreturn;\nif (connected) {\n+ switch (ec_config_get_bj_power()) {\n+ case BJ_POWER_65W:\n+ pi.voltage ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | puff: Determine BJ power based on fw config.
BUG=b:154657629
TEST=make buildall -j; chgsup reports current according to fw config
BRANCH=none
Change-Id: Ieea86484ee49e056c368a6e764a217958bae3835
Signed-off-by: Sam McNally <sammc@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198816
Reviewed-by: Andrew McRae <amcrae@chromium.org> |
136,257 | 13.05.2020 14:35:40 | -28,800 | c6534cc428cc6d58ed4417a74752d84c7747e700 | kakadu: modify charger and gauge parameter to reduce charging time
After power team experiment, change those parameter can reduce charging
time.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/battery_max17055.c",
"new_path": "baseboard/kukui/battery_max17055.c",
"diff": "@@ -72,7 +72,7 @@ static const struct max17055_batt_profile batt_profile[] = {\n[BATTERY_ATL] = {\n.is_ez_config = 1,\n.design_cap = MAX17055_DESIGNCAP_REG(7270),\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: modify charger and gauge parameter to reduce charging time
After power team experiment, change those parameter can reduce charging
time.
BUG=b:156398259
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I636ac4608e7af4afcc8d1adbadeead75d3e6c3b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198815
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,305 | 08.05.2020 14:45:09 | 21,600 | f94240f0d8b1b73675d0683626bfdabd89e726d5 | SM5803: Correct Vbus threshold registers
Vbus threshold register addresses end in A.
BRANCH=None
TEST=on waddledee, verify Vbus interrupt comes in when a charger is
plugged in | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.h",
"new_path": "driver/charger/sm5803.h",
"diff": "@@ -113,8 +113,8 @@ enum sm5803_gpio0_modes {\n#define SM5803_GPADCC1_TINT_EN BIT(7)\n/* Note: Threshold registers all assume lower 2 bits are 0 */\n-#define SM5803_REG_VBUS_LOW_TH 0x1B\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Correct Vbus threshold registers
Vbus threshold register addresses end in A.
BRANCH=None
BUG=None
TEST=on waddledee, verify Vbus interrupt comes in when a charger is
plugged in
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I86e3367216aecae76f25d1712b34c8683743052e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191140
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 08.05.2020 16:50:34 | 21,600 | 82976779e1ee613824da39d6215bf880f6434c90 | Waddledee: Remove CONFIG_FPU
FPU no longer needed with charger using integer math to convert Vbus
into a voltage.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/board.h",
"new_path": "board/waddledee/board.h",
"diff": "/* Charger */\n#define CONFIG_CHARGER_SM5803 /* C0 and C1: Charger */\n-#define CONFIG_FPU /* For charger calculations */\n#define CONFIG_USB_PD_VBUS_DETECT_CHARGER\n#define CONFIG_USB_P... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Remove CONFIG_FPU
FPU no longer needed with charger using integer math to convert Vbus
into a voltage.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I77fd210ad60c051f2632083215d4f10dc074c4c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191373
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 08.05.2020 16:01:02 | 21,600 | 1b9e5bf0c2768275c7b4e811b85854f4f7b5ab96 | SM5803: Add cached vbus presence
Cache the current Vbus presence to provide a quick-access reference to
the PD task.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.c",
"new_path": "driver/charger/sm5803.c",
"diff": "@@ -42,6 +42,8 @@ static uint32_t irq_pending; /* Bitmask of chips with interrupts pending */\nstatic struct mutex flow1_access_lock[CHARGER_NUM];\n+static int charger_vbus[CHARGER_NUM];... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Add cached vbus presence
Cache the current Vbus presence to provide a quick-access reference to
the PD task.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I4b90339b28d182a57dabd39725315d061b8b7336
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191374
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 08.05.2020 16:01:56 | 21,600 | 652fdd9e805dafb9eafb0289d3304926c6151bb4 | Waddledee: Use cached Vbus presence
Convert pd_snk_is_vbus_provided() to return the cached Vbus presence
from the charger driver.
BRANCH=None
TEST=on waddledee, confirm charger and powered dongle can connect to
both ports | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/usb_pd_policy.c",
"new_path": "board/waddledee/usb_pd_policy.c",
"diff": "@@ -76,9 +76,5 @@ int pd_set_power_supply_ready(int port)\nint pd_snk_is_vbus_provided(int port)\n{\n- int chg_det = 0;\n-\n- sm5803_get_chg_det(port, &chg_det);\n-\n- re... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Use cached Vbus presence
Convert pd_snk_is_vbus_provided() to return the cached Vbus presence
from the charger driver.
BRANCH=None
BUG=None
TEST=on waddledee, confirm charger and powered dongle can connect to
both ports
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: If45956072f41f8a20e5880825e687230ef239a1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191375
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,269 | 12.05.2020 10:43:53 | 25,200 | 4be909bf3b6e4cf1b131a8da8f023cd01f9df641 | rollback: const correctness
Entropy being added is never modified.
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/rollback.c",
"new_path": "common/rollback.c",
"diff": "@@ -202,7 +202,7 @@ failed:\n#ifdef CONFIG_ROLLBACK_SECRET_SIZE\nstatic int add_entropy(uint8_t *dst, const uint8_t *src,\n- uint8_t *add, unsigned int add_len)\n+ const uint8_t *add, unsigned int a... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | rollback: const correctness
Entropy being added is never modified.
BRANCH=none
BUG=none
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I2b54334812c9a86fad059576725e6212e88c2ec9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2197334
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org> |
136,269 | 14.05.2020 10:16:37 | 25,200 | f21e39083c70a3a04aed865cef65ce4ef95d78b8 | common/util: Add is_aligned
Helper function to check power-of-two alignment.
BRANCH=none
TEST=make buildall -j
TEST=make run-utils | [
{
"change_type": "MODIFY",
"old_path": "common/util.c",
"new_path": "common/util.c",
"diff": "@@ -552,6 +552,14 @@ bool bytes_are_trivial(const uint8_t *buffer, size_t size)\nreturn (result0 == 0) || (result1 == 0);\n}\n+bool is_aligned(uint32_t addr, uint32_t align)\n+{\n+ if (!POWER_OF_TWO(align))... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/util: Add is_aligned
Helper function to check power-of-two alignment.
BRANCH=none
BUG=b:155229277, b:156501835
TEST=make buildall -j
TEST=make run-utils
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Iadcdaeb59e496f10035bd6c7f9660a3cc33a4898
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2202849
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,269 | 02.04.2020 11:14:36 | 25,200 | 263b54489f08557690791fe7f0aaed634ddc6a2e | docs: Update CCD docs
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/case_closed_debugging.md",
"new_path": "docs/case_closed_debugging.md",
"diff": "# Case Closed Debugging (CCD)\nCase closed debugging is a feature of the EC codebase that can bridge UART\n-consoles and SPI busses from a DUT (Device Under Test) to the host... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Update CCD docs
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I7da8856cb0d39befead6418e53e709569adae613
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2134806 |
136,269 | 07.05.2020 16:28:43 | 25,200 | c828740d6050fc40cf1b881374679ebf0e4b5666 | util: Script for flashing via J-Link
BRANCH=none
TEST=make BOARD=bloonchipper -j && \
./util/flash_jlink.py --board bloonchipper | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "util/flash_jlink.py",
"diff": "+#!/usr/bin/env python\n+\n+# Copyright 2020 The Chromium OS Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+\n+\"\"\"Flashe... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util: Script for flashing via J-Link
BRANCH=none
BUG=none
TEST=make BOARD=bloonchipper -j && \
./util/flash_jlink.py --board bloonchipper
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ida382ade28451eaab62ca852337256740b81d30f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2191292
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,418 | 13.05.2020 15:32:10 | 25,200 | d3f7940da1510b6dc9726556ce483aff01833c38 | Lazor: Change the lid accel sensor driver
Change the driver from KX022 to BMA253.
BRANCH=None
TEST=Build the lazor image and check the lid accel sensor info. | [
{
"change_type": "MODIFY",
"old_path": "board/lazor/board.c",
"new_path": "board/lazor/board.c",
"diff": "#include \"charge_manager.h\"\n#include \"charge_state.h\"\n#include \"extpower.h\"\n-#include \"driver/accel_kionix.h\"\n+#include \"driver/accel_bma2x2.h\"\n#include \"driver/accelgyro_bmi_com... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Lazor: Change the lid accel sensor driver
Change the driver from KX022 to BMA253.
BRANCH=None
BUG=b:155853349
TEST=Build the lazor image and check the lid accel sensor info.
Change-Id: I945173dfa0592adbfc4ff16ebe203a92515c5f29
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2200067
Reviewed-by: Philip Chen <philipchen@chromium.org>
Reviewed-by: Alexandru M Stan <amstan@chromium.org> |
136,221 | 14.05.2020 13:40:32 | -7,200 | 983a7db44cbfd0bf8eceaee92c0a6c42d4477375 | test: Change init condition for test_polarity_cc1_default
BRANCH=none
TEST=Run usb_typec_drp_acc_trysrc host test | [
{
"change_type": "MODIFY",
"old_path": "test/usb_typec_drp_acc_trysrc.c",
"new_path": "test/usb_typec_drp_acc_trysrc.c",
"diff": "@@ -162,6 +162,14 @@ __maybe_unused static int test_polarity_cc1_default(void)\nmock_tcpc.cc1 = TYPEC_CC_VOLT_RP_DEF;\nmock_tcpc.cc2 = TYPEC_CC_VOLT_OPEN;\nmock_tcpc.vbus... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: Change init condition for test_polarity_cc1_default
BUG=none
BRANCH=none
TEST=Run usb_typec_drp_acc_trysrc host test
Signed-off-by: Jan Dabros <jsd@semihalf.com>
Change-Id: I65b57f667efb4ee5ed3c106543cd7492bb69a0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2203062
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,221 | 14.05.2020 22:26:45 | -7,200 | 2701bf1ba764b9d0da83e837c1ac8d4608a64d11 | test: Fix misleading comment in usb_typec_drp_acc_trysrc
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "test/usb_typec_drp_acc_trysrc.c",
"new_path": "test/usb_typec_drp_acc_trysrc.c",
"diff": "* Use of this source code is governed by a BSD-style license that can be\n* found in the LICENSE file.\n*\n- * Test USB Type-C VPD and CTVPD module.\n+ * Test USB Type-C ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: Fix misleading comment in usb_typec_drp_acc_trysrc
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Jan Dabros <jsd@semihalf.com>
Change-Id: I57a3ee4669c7c2a863227950aed46792178f01b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2203063
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,377 | 19.05.2020 03:13:05 | -36,000 | be7c49d46cd1e8b94be5ce7b3752ec6f4a04223d | cr50_rma_open: fix version check
BRANCH=none
TEST=script works with a cr50 running 0.6.2 | [
{
"change_type": "MODIFY",
"old_path": "extra/cr50_rma_open/cr50_rma_open.py",
"new_path": "extra/cr50_rma_open/cr50_rma_open.py",
"diff": "@@ -468,13 +468,13 @@ class RMAOpen(object):\nraise ValueError('%s does not have RMA support. Update to at '\n'least %s' % (version, rma_support))\n- def _runni... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_rma_open: fix version check
BUG=none
BRANCH=none
TEST=script works with a cr50 running 0.6.2
Change-Id: I14cfd8d90bff40843493d22576307421524d3350
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2207571
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,377 | 19.05.2020 03:14:30 | -36,000 | 26dfe4442eb06ef1c3e60b47fbf2065c095de824 | cr50_rma_open: raise an error if cr50 is too old
At this point images with testlab support are available. Fail if cr50 is
running a prod image that is too old.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "extra/cr50_rma_open/cr50_rma_open.py",
"new_path": "extra/cr50_rma_open/cr50_rma_open.py",
"diff": "@@ -462,8 +462,8 @@ class RMAOpen(object):\nlogging.info('%s RMA support added in: %s',\n'prePVT' if self.is_prepvt else 'prod', rma_support)\nif not self.is_pr... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cr50_rma_open: raise an error if cr50 is too old
At this point images with testlab support are available. Fail if cr50 is
running a prod image that is too old.
BUG=none
BRANCH=none
TEST=none
Change-Id: I096502417c4a44b4a2f458a2a5601de2d154d5cf
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2207572
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,222 | 04.05.2020 14:27:51 | -28,800 | 5d7adbc5d0138a3338c4d34afa61ba1cdde8365e | core/riscv-rv32i: do not expose get_sw_int()
Do not expose get_sw_int().
BRANCH=none
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version | [
{
"change_type": "MODIFY",
"old_path": "core/nds32/irq_chip.h",
"new_path": "core/nds32/irq_chip.h",
"diff": "@@ -51,11 +51,6 @@ int chip_trigger_irq(int irq);\n*/\nvoid chip_init_irqs(void);\n-/**\n- * Return interrupt number of software interrupt.\n- */\n-int get_sw_int(void);\n-\n/**\n* Return ex... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/riscv-rv32i: do not expose get_sw_int()
Do not expose get_sw_int().
BRANCH=none
BUG=b:151897847
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I9a5bbeec152780b54b4dd6ce07f2390633c64366
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2178699
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,222 | 04.05.2020 16:36:45 | -28,800 | 93166a6e6a6acafbe104aadc560bb075f8766b71 | core/riscv-rv32i: add default __idle()
Adds default __idle() implementation.
BRANCH=none
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version | [
{
"change_type": "MODIFY",
"old_path": "core/riscv-rv32i/task.c",
"new_path": "core/riscv-rv32i/task.c",
"diff": "@@ -74,9 +74,13 @@ void __idle(void)\ncprints(CC_TASK, \"idle task started\");\nwhile (1) {\n+#if defined(CHIP_FAMILY_IT83XX)\n/* doze mode */\nIT83XX_ECPM_PLLCTRL = EC_PLL_DOZE;\nclock_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/riscv-rv32i: add default __idle()
Adds default __idle() implementation.
BRANCH=none
BUG=b:151897847
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: Ie4711b568f8d1880eb933027c10fc43672871d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2178701
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,324 | 14.05.2020 21:54:37 | 21,600 | 7a77a24dd37e9b567b22a6a902ef68fd4d643026 | tcpmv2: use tcpci safe0v alert for auto discharge
BRANCH=none
TEST=verify USB is still working
Tested-by: Denis Brockus | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"new_path": "common/usbc/usb_tc_drp_acc_trysrc_sm.c",
"diff": "@@ -653,9 +653,6 @@ int tc_check_vconn_swap(int port)\nvoid tc_pr_swap_complete(int port)\n{\nTC_CLR_FLAG(port, TC_FLAGS_PR_SWAP_IN_PROGRESS);\n-\n- /* Enab... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpmv2: use tcpci safe0v alert for auto discharge
BUG=none
BRANCH=none
TEST=verify USB is still working
Signed-off-by: Denis Brockus <dbrockus@google.com>
Change-Id: Ic8e2440ad929b854439edebcb0fa6bcc044ce854
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2202565
Tested-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Edward Hill <ecgh@chromium.org>
Commit-Queue: Edward Hill <ecgh@chromium.org>
Auto-Submit: Denis Brockus <dbrockus@chromium.org> |
136,269 | 19.05.2020 13:38:16 | 25,200 | e885fc3efa2c579e00c4ef526ce634ba7da9b103 | test_util: Fix typo
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "include/test_util.h",
"new_path": "include/test_util.h",
"diff": "__auto_type _a = (a); \\\n__auto_type _b = (b); \\\nif (!(_a op _b)) { \\\n- ccprintf(\"%d: ASSERSION failed: %s \" #op \" %s\\n\", \\\n+ ccprintf(\"%d: ASSERTION failed: %s \" #op \" %s\\n\", \... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test_util: Fix typo
BRANCH=none
BUG=none
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: I259c18e09c568e2e7c38c18c93cf666fb17de44b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209368
Commit-Queue: Diana Z <dzigterman@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,330 | 13.05.2020 10:24:02 | 21,600 | 1ab9349d07d8a16c5c11c05683dd07020ab7eaf0 | TCPMv2: Remove PE_FLAGS_SEND_SVDM
It is never checked.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "/*\n* Policy Engine Layer Flags\n+ * These are reproduced in test/usb_pe.h. If they change here, they must change\n+ * there.\n*/\n/* At least one successful PD communication pac... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Remove PE_FLAGS_SEND_SVDM
It is never checked.
BUG=none
TEST=make buildall
BRANCH=none
Change-Id: I74034ae998c8c8ac068c6712f9b078afcab8942b
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2203840
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,330 | 13.05.2020 11:20:59 | 21,600 | a26fa8b63e1ef4a57ea98e79b390f60b54b245b1 | TCPMv2: Use atomic operations for DPM requests
Avoid race conditions between host commands and the PE state machine.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "* These macros SET, CLEAR, and CHECK, a DPM (Device Policy Manager)\n* Request. The Requests are listed in usb_pe_sm.h.\n*/\n-#define PE_SET_DPM_REQUEST(port, req) (pe[port].dpm_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Use atomic operations for DPM requests
Avoid race conditions between host commands and the PE state machine.
BUG=none
TEST=make buildall
BRANCH=none
Change-Id: I9bb386b6c4e5410152057b2d2d9fd66cdd69441b
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2203841
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,311 | 19.05.2020 14:21:42 | 21,600 | 7517d5c48ba735e942c6389097585f5551a3bf2d | tcpc: Cleanup register dump
Shorten the strings used for the TCPC register dump. This change saves
300 bytes of flash space (RO and RW each).
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/tcpci.c",
"new_path": "driver/tcpm/tcpci.c",
"diff": "@@ -1446,47 +1446,154 @@ struct tcpci_reg {\nuint8_t size;\n};\n-#define TCPCI_REG(reg_name, reg_size) \\\n- [reg_name] = { .name = #reg_name, .size = (reg_size) }\n-\nstatic const struct tcpci_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | tcpc: Cleanup register dump
Shorten the strings used for the TCPC register dump. This change saves
300 bytes of flash space (RO and RW each).
BUG=none
BRANCH=none
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I2740c50a3c0bd88271b1d7d574ef3e877389016c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209575
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,427 | 19.05.2020 14:21:17 | 21,600 | 8d7bd376c17fbbaaa1fc528ad607546295b04838 | printf: Avoid null pointer dereference
Avoid null pointer dereference for %ph and %pb. %pT and %pP can
accept null.
BRANCH=none
TEST=make -j host-host_command_fuzz TEST_MSAN=1 | [
{
"change_type": "MODIFY",
"old_path": "common/printf.c",
"new_path": "common/printf.c",
"diff": "@@ -266,6 +266,13 @@ int vfnprintf(int (*addchar)(void *context, int c), void *context,\nc = -1;\nptrspec = *format++;\nptrval = va_arg(args, void *);\n+ /*\n+ * Avoid null pointer dereference for %ph a... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | printf: Avoid null pointer dereference
Avoid null pointer dereference for %ph and %pb. %pT and %pP can
accept null.
BUG=chromium:1076023
BRANCH=none
TEST=make -j host-host_command_fuzz TEST_MSAN=1
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I0248d03cff428b8dd1aded84417d8ea2f3efe3b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209367
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Evan Green <evgreen@chromium.org> |
136,356 | 28.04.2020 15:10:47 | -28,800 | 3927b746bc29f693a8c9335c734e50ea45a7c3e3 | Ezkinil: Setting input current limit to 95%
Setting lower input current limit to make sure safety
confirm test pass.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -355,7 +355,7 @@ static void baseboard_chipset_resume(void)\n}\nDECLARE_HOOK(HOOK_CHIPSET_RESUME, baseboard_chipset_resume, HOOK_PRIO_DEFAULT);\n-void board_set_charge_limit(int... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ezkinil: Setting input current limit to 95%
Setting lower input current limit to make sure safety
confirm test pass.
BUG=b:156962946
BRANCH=none
TEST=make buildall
Change-Id: I3afa3c70076fcff319e47c08901616916c0a467b
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2172276
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,258 | 19.05.2020 16:25:06 | 21,600 | 192f1de90e1e6d97f24dd56b361ba9ddc3e110c2 | docs: add howto for code coverage
Add documentation for how to build the unit tests for code coverage.
BRANCH=none
TEST=renders in gerrit | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "docs/code_coverage.md",
"diff": "+# Code Coverage\n+\n+Provides an overview of how to use code coverage tools when running the unit\n+tests in the EC codebase.\n+\n+[TOC]\n+\n+## Availability\n+\n+Code coverage is only available for host-based u... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: add howto for code coverage
Add documentation for how to build the unit tests for code coverage.
BUG=b:156553508
BRANCH=none
TEST=renders in gerrit
Signed-off-by: Paul Fagerburg <pfagerburg@chromium.org>
Change-Id: Iaf7a4e231f6817f51848af101dac6c73afe3f59a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209427
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,297 | 19.05.2020 17:35:48 | -32,400 | 1cea0e980f3a1efddecdb4b1f9595ab83de37aa3 | nightfury : blink charge led on low battery
need to blink charge led to notify user that battery is low.
BRANCH=firmware-hatch-12672.B
TEST=make -j BOARD=nightfury | [
{
"change_type": "MODIFY",
"old_path": "board/nightfury/led.c",
"new_path": "board/nightfury/led.c",
"diff": "#define LED_OFF_LVL 1\n#define LED_ON_LVL 0\n-const int led_charge_lvl_1 = 0;\n+const int led_charge_lvl_1 = 1;\nconst int led_charge_lvl_2 = 100;\n/* Nightfury : There are 3 leds for AC, Ba... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nightfury : blink charge led on low battery
need to blink charge led to notify user that battery is low.
BUG=b:156972095
BRANCH=firmware-hatch-12672.B
TEST=make -j BOARD=nightfury
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I76f984c8d78c5e19e4ee1e8a158e1773982ca1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2206942
Reviewed-by: Bob Moragues <moragues@chromium.org>
Commit-Queue: Bob Moragues <moragues@chromium.org> |
136,200 | 11.05.2020 08:41:12 | -28,800 | 506d5bed29d3785e21da8f2deab45687919cbc33 | pi3hdx1204: Allow tuning to be adjusted.
BRANCH=none
TEST=check i2c writes
Tested-by: Edward Hill | [
{
"change_type": "MODIFY",
"old_path": "driver/retimer/pi3hdx1204.c",
"new_path": "driver/retimer/pi3hdx1204.c",
"diff": "@@ -12,12 +12,20 @@ int pi3hdx1204_enable(const int i2c_port,\nconst uint16_t i2c_addr_flags,\nconst int enable)\n{\n- uint8_t buf[PI3HDX1204_ENABLE_OFFSET + 1] = {0};\n-\n- buf[... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | pi3hdx1204: Allow tuning to be adjusted.
BUG=b:156058725
BRANCH=none
TEST=check i2c writes
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I636a39e7b0540bea9cd7db70aa91330fa80ea5b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2192454
Tested-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,305 | 20.05.2020 09:43:11 | 21,600 | da57dbbd3070915738934da7cb4d2a1c5cffc53b | Waddledee: configure ECH1_PACKET_MODE
This GPIO will be used for communication with the cr50 when EFS2 is
enabled.
BRANCH=None
TEST=make -j buildall, waddledee boots | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define GPIO_EN_PP5000 GPIO_EN_PP5000_U\n#define GPIO_ENTERING_RW GPIO_EC_ENTERING_RW\n#define GPIO_KBD_KSO2 GPIO_EC_KSO_02_INV\n+#define GPIO_PACKET_MODE_EN GPIO_ECH1_PACKET_M... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: configure ECH1_PACKET_MODE
This GPIO will be used for communication with the cr50 when EFS2 is
enabled.
BRANCH=None
BUG=b:156785198
TEST=make -j buildall, waddledee boots
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ia1193bf61995ec0f1892a753570f28eaba64ab26
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210863
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 20.05.2020 09:46:27 | 21,600 | bf889b296035360369abc13fe7892040079d93a8 | Waddledoo: configure ECH1_PACKET_MODE
This GPIO will be used to communicate with the cr50 when we
enable EFS2.
BRANCH=None
TEST=make -j buildall, boots on waddledoo | [
{
"change_type": "MODIFY",
"old_path": "board/waddledoo/gpio.inc",
"new_path": "board/waddledoo/gpio.inc",
"diff": "@@ -67,6 +67,7 @@ GPIO(EN_SLP_Z, PIN(8, 3), GPIO_OUT_LOW)\nGPIO(EN_KB_BL, PIN(6, 0), GPIO_OUT_LOW)\nGPIO(EN_BL_OD, PIN(D, 3), GPIO_ODR_LOW)\nGPIO(IMVP9_PE, PIN(E, 0), GPIO_OUT_LOW)\n+G... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledoo: configure ECH1_PACKET_MODE
This GPIO will be used to communicate with the cr50 when we
enable EFS2.
BRANCH=None
BUG=b:156785199
TEST=make -j buildall, boots on waddledoo
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ia960e1ad6ddd83338570cae133697ed5d4f61597
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210864
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,311 | 19.05.2020 09:23:56 | 21,600 | c92f3d36f70a551e3df442cc7e015000f73f0578 | volteer: correct lid g-sensor orientation
Correc the lid g-sensor orientation to match the latest boards.
BRANCH=none
TEST=make buildall
TEST=Verify lid angle using "ectool motionsense lid_angle" | [
{
"change_type": "MODIFY",
"old_path": "board/volteer/sensors.c",
"new_path": "board/volteer/sensors.c",
"diff": "@@ -85,9 +85,9 @@ static struct tcs3400_rgb_drv_data_t g_tcs3400_rgb_data = {\n/* Rotation matrix for the lid accelerometer */\nstatic const mat33_fp_t lid_standard_ref = {\n- { FLOAT_TO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: correct lid g-sensor orientation
Correc the lid g-sensor orientation to match the latest boards.
BUG=b:157001290, b:157018535
BRANCH=none
TEST=make buildall
TEST=Verify lid angle using "ectool motionsense lid_angle"
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I661e5aa7542371ba7d05944be965f22cb6fd4277
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209025
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,427 | 19.05.2020 18:12:34 | 21,600 | 8e6ab39b174272d6114b90cdc11adc9c0723eb9f | Trembyle: Power off PS8811 retimer in S3
BRANCH=none
TEST=USB-A still works | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/board.c",
"new_path": "board/trembyle/board.c",
"diff": "@@ -193,7 +193,7 @@ static void ps8811_tuning_init(void)\nCPRINTSUSB(\"C1: PS8811 not detected\");\n}\n}\n-DECLARE_HOOK(HOOK_CHIPSET_STARTUP, ps8811_tuning_init, HOOK_PRIO_DEFAULT);\n+DECL... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Power off PS8811 retimer in S3
BUG=b:156696798
BRANCH=none
TEST=USB-A still works
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I5d15c99925956583f2382f1ea8a2d91ea8196e92
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2209659
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 20.05.2020 17:54:46 | 21,600 | 3775fb30b240a411c49f30f61a00acbc86b141a7 | Trembyle: Adjust fan speeds and temps
Reduce fan speeds and increase temperature limits.
BRANCH=none
TEST=check fan speed | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/board.c",
"new_path": "board/trembyle/board.c",
"diff": "@@ -329,9 +329,9 @@ const struct fan_conf fan_conf_0 = {\n.enable_gpio = -1,\n};\nconst struct fan_rpm fan_rpm_0 = {\n- .rpm_min = 3100,\n- .rpm_start = 3100,\n- .rpm_max = 6900,\n+ .rpm_m... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Trembyle: Adjust fan speeds and temps
Reduce fan speeds and increase temperature limits.
BUG=b:154938623
BRANCH=none
TEST=check fan speed
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ic0411eb621246ecc60afa77045d284a200128cba
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210832
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 20.05.2020 18:02:59 | 21,600 | 092918a531ec535a12db6bdf01af3d1b782630f5 | zork: Enable CC_PWM console channel
Now that "fan stalled" spam has been fixed.
BRANCH=none
TEST=no annoying console messages | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_SPI_FLASH_REGS\n#define CONFIG_SPI_FLASH_W25Q40 /* Internal SPI flash type. */\n-#define CC_DEFAULT (CC_ALL & ~(CC_MASK(CC_HOSTCMD) | CC_MASK(CC_PWM)))\n+#define CC_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zork: Enable CC_PWM console channel
Now that "fan stalled" spam has been fixed.
BUG=b:154938623
BRANCH=none
TEST=no annoying console messages
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ie5655cbfc53f74dbd3b6b0aa36d8fc7a91eafeaa
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2210833
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,405 | 21.05.2020 12:01:29 | 25,200 | d2b33ef5fd9aef1da3d17bc0134dba0a4592108b | npcx/system: Clean up bbram_data_read
This patch replaces calls to bbram_data_read for
BBRM_DATA_INDEX_SAVED_RESET_FLAGS with chip_read_reset_flags.
BRANCH=none
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "chip/npcx/system.c",
"new_path": "chip/npcx/system.c",
"diff": "@@ -328,7 +328,7 @@ uint32_t chip_read_reset_flags(void)\n*/\nstatic void board_chipset_startup(void)\n{\n- uint32_t flags = bbram_data_read(BBRM_DATA_INDEX_SAVED_RESET_FLAGS);\n+ uint32_t flags =... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | npcx/system: Clean up bbram_data_read
This patch replaces calls to bbram_data_read for
BBRM_DATA_INDEX_SAVED_RESET_FLAGS with chip_read_reset_flags.
BUG=none
BRANCH=none
TEST=buildall
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: I008ff594c1d754eb4cc814d4020e587c36f24cda
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2213358
Reviewed-by: Yicheng Li <yichengli@chromium.org> |
136,405 | 22.05.2020 13:09:36 | 25,200 | 4622782bec34ef489c792d8834fb432cbcadd1c9 | system: Add EC_RESET_FLAG_AP_IDLE
This patch adds EC_RESET_FLAG_AP_IDLE. It will make RW leave the
AP idle on start-up. The AP will continue to sequence up or down.
BRANCH=none
TEST=Verify test_that suite:faft_bios passes. | [
{
"change_type": "MODIFY",
"old_path": "common/power_button_x86.c",
"new_path": "common/power_button_x86.c",
"diff": "@@ -246,6 +246,11 @@ static void set_initial_pwrbtn_state(void)\nCPRINTS(\"PB init-off\");\npower_button_pch_release();\nreturn;\n+ } else if (reset_flags & EC_RESET_FLAG_AP_IDLE) {\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | system: Add EC_RESET_FLAG_AP_IDLE
This patch adds EC_RESET_FLAG_AP_IDLE. It will make RW leave the
AP idle on start-up. The AP will continue to sequence up or down.
BUG=b:154778457
BRANCH=none
TEST=Verify test_that suite:faft_bios passes.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Ib4cad6c52952b139d4c6bea98747fe701c53a230
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2213729
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,405 | 22.05.2020 18:23:24 | 25,200 | 71bd6510b8a4e3867849a0984c3e73a7d67b8f9c | MPU: Don't panic when mpu_pre_init fails
This is a workaround for chromium:1085868.
BRANCH=none
TEST=Boot Puff. | [
{
"change_type": "MODIFY",
"old_path": "common/main.c",
"new_path": "common/main.c",
"diff": "@@ -137,7 +137,8 @@ test_mockable __keep int main(void)\n/* We wait to report the failure until here where we have console. */\nif (mpu_pre_init_rv != EC_SUCCESS)\n- panic(\"MPU init failed\\n\");\n+ /* TOD... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | MPU: Don't panic when mpu_pre_init fails
This is a workaround for chromium:1085868.
BUG=chromium:1085868
BRANCH=none
TEST=Boot Puff.
Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
Change-Id: Iea223bc992206d70f69b4789da3f9f009790df9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2213600
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> |
136,221 | 14.05.2020 23:45:47 | -7,200 | 5dd7dbac5565e09bee7e01ecd9404bffa7c85ea5 | USB: Fix handling of CONFIG_COMMON_RUNTIME
Fix compilation error when building with CONFIG_COMMON_RUNTIME disabled.
BRANCH=none
TEST=make buildall succeeds | [
{
"change_type": "MODIFY",
"old_path": "common/mock/tcpc_mock.c",
"new_path": "common/mock/tcpc_mock.c",
"diff": "#include \"tests/enum_strings.h\"\n#include \"usb_pd_tcpm.h\"\n+#ifndef CONFIG_COMMON_RUNTIME\n+#define cprints(format, args...)\n+#endif\n+\n/* Public API for controlling/inspecting thi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | USB: Fix handling of CONFIG_COMMON_RUNTIME
Fix compilation error when building with CONFIG_COMMON_RUNTIME disabled.
BUG=none
BRANCH=none
TEST=make buildall succeeds
Signed-off-by: Jan Dabros <jsd@semihalf.com>
Change-Id: I19b4f620588a393f01ae97a3997d3fe6dd1cc009
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2203064
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org> |
136,311 | 26.05.2020 14:16:33 | 21,600 | 2f49516dd133f850eea302cc849725731185c119 | kukui: reduce image size
Remove the hcdebug from the Kukui board family RO images to reduce code
size.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/baseboard.h",
"new_path": "baseboard/kukui/baseboard.h",
"diff": "#define CONFIG_IO_EXPANDER\n#define CONFIG_IO_EXPANDER_IT8801\n#define CONFIG_IO_EXPANDER_PORT_COUNT 1\n-#define CONFIG_KEYBOARD_DEBUG\n#define CONFIG_KEYBOARD_NOT_RAW\n#define C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kukui: reduce image size
Remove the hcdebug from the Kukui board family RO images to reduce code
size.
BUG=b:156398243
BRANCH=none
TEST=make buildall
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I6b21aa2df6242bb0f384a107013f2a171d27416a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2216587
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,330 | 26.05.2020 14:30:43 | 21,600 | 357925c4e02cea8c102a3996e79e25e358f9e109 | TCPMv2: Remove DPM_REQUEST_DISCOVER_IDENTITY
It is unused, and it accesses data structures that will need to be
synchronized to support generic mode entry.
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/usbc/usb_pe_drp_sm.c",
"new_path": "common/usbc/usb_pe_drp_sm.c",
"diff": "@@ -1047,19 +1047,6 @@ static bool common_src_snk_dpm_requests(int port)\nPE_CLR_DPM_REQUEST(port, DPM_REQUEST_VCONN_SWAP);\nset_state_pe(port, PE_VCS_SEND_SWAP);\nreturn true;\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Remove DPM_REQUEST_DISCOVER_IDENTITY
It is unused, and it accesses data structures that will need to be
synchronized to support generic mode entry.
BUG=b:155890173
TEST=make buildall
BRANCH=none
Change-Id: I9440259f05e2a19940202f61548b4171517e1275
Signed-off-by: Abe Levkoy <alevkoy@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2217061
Reviewed-by: Diana Z <dzigterman@chromium.org>
Commit-Queue: Diana Z <dzigterman@chromium.org> |
136,209 | 28.05.2020 02:00:10 | -36,000 | 8a7666863b51b8dc7cc1be467cd9c41c3dd5e932 | Puff: Increase I2C bus speed to 400KHz
TEST=Run on Puff
BRANCH=none
Tested-by: Andrew McRae | [
{
"change_type": "MODIFY",
"old_path": "board/puff/board.c",
"new_path": "board/puff/board.c",
"diff": "@@ -261,11 +261,11 @@ const struct usb_mux usb_muxes[CONFIG_USB_PD_PORT_MAX_COUNT] = {\n/******************************************************************************/\n/* I2C port map configurat... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Puff: Increase I2C bus speed to 400KHz
BUG=b:157554433
TEST=Run on Puff
BRANCH=none
Change-Id: I9566dd8bc59b6a508ab2a98d08ffcc2708c121e0
Signed-off-by: Andrew McRae <amcrae@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2217601
Reviewed-by: Jett Rink <jettrink@chromium.org>
Tested-by: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org> |
136,295 | 25.05.2020 11:00:43 | -28,800 | f6424dd187d7123c90f4d7a16d08e4ca01370694 | driver/temp_sensor: fix tmp432 compile issue
temp sensor tmp432 will compiler fail when
board define CONFIG_TEMP_SENSOR_POWER_GPIO.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/temp_sensor/tmp432.c",
"new_path": "driver/temp_sensor/tmp432.c",
"diff": "static int temp_val_local;\nstatic int temp_val_remote1;\nstatic int temp_val_remote2;\n+#ifndef CONFIG_TEMP_SENSOR_POWER_GPIO\nstatic uint8_t is_sensor_shutdown;\n+#endif\nstati... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver/temp_sensor: fix tmp432 compile issue
temp sensor tmp432 will compiler fail when
board define CONFIG_TEMP_SENSOR_POWER_GPIO.
BUG=b:154189125
BRANCH=none
TEST=make buildall
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: I3037a6a114b39568a42bbe2bf1f4da99a30d2044
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2214448
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,418 | 28.05.2020 10:19:46 | 25,200 | 9a09d68f111caf3129723c3fb1307474b7cb2fc3 | Lazor: Rename GPIO USB_A_CDP_ILIM_EN
The netname was recently changed in the schematic, to reflect the
active-high signal. Do the same change on EC side.
BRANCH=None
TEST=Build successfully. | [
{
"change_type": "MODIFY",
"old_path": "board/lazor/gpio.inc",
"new_path": "board/lazor/gpio.inc",
"diff": "@@ -90,7 +90,7 @@ GPIO(USB_C1_VBUS_DET_L, PIN(8, 3), GPIO_INPUT) /* Deprecated BC1.2 VBUS\n/* USB-A */\nGPIO(EN_USB_A_5V, PIN(8, 6), GPIO_OUT_LOW)\n-GPIO(USB_A_CDP_ILIM_EN_L, PIN(7, 5), GPIO_O... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Lazor: Rename GPIO USB_A_CDP_ILIM_EN
The netname was recently changed in the schematic, to reflect the
active-high signal. Do the same change on EC side.
BRANCH=None
BUG=b:156965411
TEST=Build successfully.
Change-Id: Idc69f35cb8233894c61284e10dbe81b54366c207
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2219680
Reviewed-by: Stephen Boyd <swboyd@chromium.org> |
136,305 | 28.05.2020 14:29:22 | 21,600 | 468f2fb73676f0a4db3cc62e4874d1962ba3746a | SM5803: Update inits
Updated register inits from the vendor.
BRANCH=None
TEST=on waddledee, boot and verify battery charges | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.c",
"new_path": "driver/charger/sm5803.c",
"diff": "@@ -238,24 +238,24 @@ static void sm5803_init(int chgnum)\nrv |= chg_write8(chgnum, 0x50, 0x98);\nrv |= chg_write8(chgnum, 0x51, 0x00);\nrv |= chg_write8(chgnum, 0x52, 0x77);\n- rv |= ch... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Update inits
Updated register inits from the vendor.
BRANCH=None
BUG=None
TEST=on waddledee, boot and verify battery charges
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ie27de5276c480b5209fb3493a1f4d4174ff7792f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2219264
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,222 | 27.05.2020 10:14:44 | -28,800 | 7808773254b3c4b910eef167319b49e6acec738a | core/riscv-rv32i: remove get_sw_int()
Inline the function definition.
BRANCH=none
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version | [
{
"change_type": "MODIFY",
"old_path": "core/nds32/task.c",
"new_path": "core/nds32/task.c",
"diff": "@@ -249,14 +249,6 @@ int task_start_called(void)\nreturn start_called;\n}\n-static int get_sw_int(void)\n-{\n- /* If this is a SW interrupt */\n- if (get_itype() & 8)\n- return sw_int_num;\n- return... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/riscv-rv32i: remove get_sw_int()
Inline the function definition.
BRANCH=none
BUG=b:146213943
BUG=b:157521370
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: Icfde6399b2dd560924128f9e7fbeb54efaa9c14c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2217595
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,209 | 29.05.2020 10:18:38 | -36,000 | 8ed77c62110f9ce3f6469c7a70db36f81fd5a5f2 | ANX3447: Add some more registers to dump
Display some more chip specific registers.
TEST=Registers are displayed
BRANCH=none
Tested-by: Andrew McRae | [
{
"change_type": "MODIFY",
"old_path": "driver/tcpm/anx7447.c",
"new_path": "driver/tcpm/anx7447.c",
"diff": "@@ -784,6 +784,22 @@ const struct {\n.name = \"HPD_DEGLITCH_H\",\n.addr = ANX7447_REG_HPD_DEGLITCH_H,\n},\n+ {\n+ .name = \"INTP_SOURCE_0\",\n+ .addr = ANX7447_REG_INTP_SOURCE_0,\n+ },\n+ {\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ANX3447: Add some more registers to dump
Display some more chip specific registers.
BUG=none
TEST=Registers are displayed
BRANCH=none
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I77fc36eb8a9ddc18f7410b5bff4f572acc68c1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2219790
Tested-by: Andrew McRae <amcrae@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org> |
136,305 | 29.05.2020 16:06:10 | 21,600 | 8aedc7bdd2f404293ee93c65851dfa79c4990d73 | Dedede: Enable PD 3.0
Semantics to set PD 3.0 on the v2 stack changed recently, so enable PD
3.0 specifically (rather than it being default)
BRANCH=None
TEST=make -j buidall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define CONFIG_USB_PD_LOGGING\n#define CONFIG_USB_PD_MAX_SINGLE_SOURCE_CURRENT TYPEC_RP_3A0\n#define CONFIG_USB_PD_PORT_MAX_COUNT 2\n+#define CONFIG_USB_PD_REV30\n#define CONFI... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Dedede: Enable PD 3.0
Semantics to set PD 3.0 on the v2 stack changed recently, so enable PD
3.0 specifically (rather than it being default)
BRANCH=None
BUG=None
TEST=make -j buidall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I681a406665f7f9673bdf96c0a7c8dfcd13a28186
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2219285
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,222 | 27.05.2020 10:48:38 | -28,800 | b0b03bbfe3aba4d90bd59642ed786ff7ee7b843e | core/riscv-rv32i: add in_soft_interrupt_context()
BRANCH=none
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version | [
{
"change_type": "MODIFY",
"old_path": "core/riscv-rv32i/task.c",
"new_path": "core/riscv-rv32i/task.c",
"diff": "@@ -204,6 +204,12 @@ inline int in_interrupt_context(void)\nreturn in_interrupt;\n}\n+int in_soft_interrupt_context(void)\n+{\n+ /* group 16 is reserved for soft-irq */\n+ return in_inte... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/riscv-rv32i: add in_soft_interrupt_context()
BRANCH=none
BUG=b:146213943
BUG=b:156218912
TEST=1. make BOARD=asurada
2. flash_ec --board=asurada --image build/asurada/ec.bin
3. (EC console)> version
Change-Id: If8df1fb768ea9c83f025d8bd17010481389d7aa1
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2217596
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,222 | 13.05.2020 15:43:32 | -28,800 | 9d9f7b29fe9a3406100d91ca89fbab8bf4c8713c | chip/mt8192_scp: add dummy chip implementations
BRANCH=none
TEST=make buildall | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mt8192_scp/build.mk",
"diff": "+# -*- makefile -*-\n+# Copyright 2020 The Chromium OS Authors. All rights reserved.\n+# Use of this source code is governed by a BSD-style license that can be\n+# found in the LICENSE file.\n+#\n+# SCP specif... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: add dummy chip implementations
BRANCH=none
BUG=b:146213943
TEST=make buildall
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: Ib5da01056c5624eae1efc14e64638c052f74c50c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198817
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,222 | 13.05.2020 15:50:20 | -28,800 | 8fd3c3ef70dfd575fe91630a441a5364544dd239 | asurada_scp: add dummy board implementations
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "board/asurada_scp/board.c",
"diff": "+/* Copyright 2020 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+/* Asurada SCP configuratio... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada_scp: add dummy board implementations
BRANCH=none
BUG=b:146213943
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I2b3a93777fe912a6a6793963d331ebc781218f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198818
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,222 | 13.05.2020 17:34:07 | -28,800 | 9cfae101b2e6959c5f32aee1293469e441c9413f | chip/mt8192_scp: add basic system settings
Settings include:
default memmap
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/registers.h",
"new_path": "chip/mt8192_scp/registers.h",
"diff": "#define DUMMY_GPIO_BANK 0\n+#define SCP_REG_BASE 0x70000000\n+\n+/* memory remap */\n+#define SCP_R_REMAP_0X0123 REG32(SCP_REG_BASE + 0xA5060)\n+#define SCP_R_REMAP_0X4567 REG32(... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: add basic system settings
Settings include:
- default memmap
BRANCH=none
BUG=b:146213943
TEST=make BOARD=asurada_scp
Change-Id: I581a22527df579a815f895c6ba370e2e8bc0397d
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198819
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,427 | 02.06.2020 18:49:47 | 21,600 | 3940e1c6099a371df0b34f19ec7e0111ecca7928 | Zork: Power off USB-A1 retimer in S3
Fix from CL:2209659 for Trembyle is also needed for Dalboz and Ezkinil.
BRANCH=none
TEST=USB-A still works | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/variant_dalboz.c",
"new_path": "baseboard/zork/variant_dalboz.c",
"diff": "@@ -128,13 +128,13 @@ static void usba_retimer_on(void)\n{\nioex_set_level(IOEX_USB_A1_RETIMER_EN, 1);\n}\n-DECLARE_HOOK(HOOK_CHIPSET_STARTUP, usba_retimer_on, HOOK_PRIO_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zork: Power off USB-A1 retimer in S3
Fix from CL:2209659 for Trembyle is also needed for Dalboz and Ezkinil.
BUG=b:156696798
BRANCH=none
TEST=USB-A still works
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Id62bb9668042642eb3b0a64798a2aa4c763a604d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227590
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,280 | 02.06.2020 17:40:38 | -28,800 | 4a18035a752d43f22acb27f23168b182c96ad271 | asurada: enable base motion sensor interrupt
TEST=`accelinfo on`, see sensor data is updating
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -99,6 +99,9 @@ static void board_init(void)\n/* Set PWM of PWRLED to 5%. */\npwm_set_duty(PWM_CH_PWRLED, 5);\npwm_enable(PWM_CH_PWRLED, 1);\n+\n+ /* Enable motion sensor interrupt */\n+ g... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable base motion sensor interrupt
BUG=b:150341271
TEST=`accelinfo on`, see sensor data is updating
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ib2918d79dd319a82ce3ce74d3214aacb4c702f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2228409
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,222 | 13.05.2020 16:38:04 | -28,800 | 45f96454b8663375bbf45df9bd321615976d830e | chip/mt8192_scp: support INTC
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "chip/mt8192_scp/csr.h",
"diff": "+/* Copyright 2020 The Chromium OS Authors. All rights reserved.\n+ * Use of this source code is governed by a BSD-style license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+/* Control and status regist... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: support INTC
BRANCH=none
BUG=b:146213943
BUG=b:156223049
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I1916d12bf92154853c90bf06050587ad1e73a093
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198820
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,222 | 13.05.2020 17:08:49 | -28,800 | cb2a4b7a3b8ccb123ffb270057228d8635d357a8 | chip/mt8192_scp: support UART
BRANCH=none
TEST=make BOARD=asurada_scp | [
{
"change_type": "MODIFY",
"old_path": "chip/mt8192_scp/intc.c",
"new_path": "chip/mt8192_scp/intc.c",
"diff": "@@ -46,8 +46,8 @@ static struct {\n[SCP_IRQ_EINT] = { INTC_GRP_0 },\n[SCP_IRQ_PMIC] = { INTC_GRP_0 },\n/* 8 */\n- [SCP_IRQ_UART0_TX] = { INTC_GRP_0 },\n- [SCP_IRQ_UART1_TX] = { INTC_GRP_0 ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | chip/mt8192_scp: support UART
BRANCH=none
BUG=b:146213943
BUG=b:156221696
TEST=make BOARD=asurada_scp
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Change-Id: I95a547b9d1763dc7faa6d7a1c18cf9ae675bae39
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2198821
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,200 | 03.06.2020 11:56:36 | -28,800 | 076eb93f14583372bd69447591ed50237c986726 | Bobba: add PPC syv682x config
Supoprt PPC SYV682X on bobba.
BRANCH=octopus
TEST=Check usb dongle/typec adapter worked properly in any power state. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/octopus/baseboard.h",
"new_path": "baseboard/octopus/baseboard.h",
"diff": "#endif /* VARIANT_OCTOPUS_USBC */\n/* Common USB-C defines */\n+#define USB_PD_PORT_TCPC_0 0\n+#define USB_PD_PORT_TCPC_1 1\n#define CONFIG_USB_POWER_DELIVERY\n#define CONFIG... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Bobba: add PPC syv682x config
Supoprt PPC SYV682X on bobba.
BUG=b:154772847, b:156711950
BRANCH=octopus
TEST=Check usb dongle/typec adapter worked properly in any power state.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I1b87d3de4a749005b5bf4c1d42cb4bf1fa61f1ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227772
Reviewed-by: Marco Chen <marcochen@chromium.org> |
136,443 | 02.06.2020 08:29:52 | 25,200 | 4b75792e64ff071581a4d51caa0c88b26e5da851 | util/flash_jlink.py: Fix formatting + parsing convention
BRANCH=none
TEST=./util/flash_jlink.py --jlink JLinkExe --ip blah
# Ensure that the blah parameter was passed | [
{
"change_type": "MODIFY",
"old_path": "util/flash_jlink.py",
"new_path": "util/flash_jlink.py",
"diff": "@@ -62,7 +62,8 @@ def flash(jlink_exe, ip, device, interface, cmd_file):\nsubprocess.run(cmd)\n-def main():\n+def main(argv: list):\n+\nparser = argparse.ArgumentParser()\ndefault_jlink = './JLi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util/flash_jlink.py: Fix formatting + parsing convention
BRANCH=none
BUG=none
TEST=./util/flash_jlink.py --jlink JLinkExe --ip blah
# Ensure that the blah parameter was passed
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Iee38468eb38e91eb3f2b6c19de9c5070f1c0bc5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2226878
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,451 | 03.06.2020 21:33:48 | -28,800 | 1a91ab29a3b91e6a5e3829b6e6bcb2954bb283bd | vilboz: Remove PCAL6408 entirely and enable HDMI
BRANCH=none
TEST=make BOARD=vilboz | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -569,23 +569,6 @@ void board_hibernate(void)\n}\n}\n-static void hdmi_hpd_handler(void)\n-{\n- int hpd = 0;\n-\n- /* Pass HPD through from DB OPT1 HDMI connector to AP's DP1. */... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | vilboz: Remove PCAL6408 entirely and enable HDMI
BUG=b:157182792, b:158125500
BRANCH=none
TEST=make BOARD=vilboz
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I71e38117309277c39ed245535643d601e8759d28
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2227782
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Commit-Queue: Lu Zhang <lu.zhang@bitland.corp-partner.google.com> |
136,295 | 03.06.2020 10:54:51 | -28,800 | 05a4c577abbcbe181f9b1b41ccc6d00ec282554a | berknip: add Cosmx battery configuration
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/berknip/battery.c",
"new_path": "board/berknip/battery.c",
"diff": "@@ -60,6 +60,34 @@ const struct board_batt_params board_battery_info[] = {\n.discharging_max_c = 60,\n},\n},\n+/* Cosmx CA407792G Battery Information */\n+ [BATTERY_COSMX] = {\n+ .fuel_g... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | berknip: add Cosmx battery configuration
BUG=b:157950071
BRANCH=none
TEST=make buildall
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Icb01629d04be5f2b31a28d906d14095606e7b78d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2229899
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,190 | 01.06.2020 14:32:09 | 25,200 | 2645ebbbd4aac058bf43c6102d366a50b4c1b364 | volteer: Enable CONFIG_USB_PD_USB32_DRD
BRANCH=None
TEST=On connecting Gatkex Creek with DUT as UFP, the DUT enter into USB3
mode. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.h",
"new_path": "baseboard/volteer/baseboard.h",
"diff": "#define CONFIG_HOSTCMD_PD_CONTROL /* Needed for TCPC FW update */\n#define CONFIG_CMD_USB_PD_PE\n+/* Enable USB3.2 DRD */\n+#define CONFIG_USB_PD_USB32_DRD\n+\n#define CONFIG... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: Enable CONFIG_USB_PD_USB32_DRD
BUG=b:148528713
BRANCH=None
TEST=On connecting Gatkex Creek with DUT as UFP, the DUT enter into USB3
mode.
Change-Id: I98d83ed14d92431b9e0392ffceb4e37792dde9f1
Signed-off-by: Ayushee <ayushee.shah@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2225602
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,280 | 03.06.2020 14:15:07 | -28,800 | 8432637e62220c5eeb237f14ae1f7cd4e8a7ce84 | asurada: enable lid angle calculation
TEST=`accelread on`, verify the value looks reasonable
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -375,6 +375,22 @@ __override uint8_t board_get_usb_pd_port_count(void)\nreturn CONFIG_USB_PD_PORT_MAX_COUNT - 1;\n}\n+/* Lid */\n+#ifndef TEST_BUILD\n+/* This callback disables keyboard w... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable lid angle calculation
BUG=b:150341271
TEST=`accelread on`, verify the value looks reasonable
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I03bf63d95abba2c713ec6094dd3ba3e9ba6d4738
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2228079
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,451 | 04.06.2020 19:52:30 | -28,800 | 6c08aba5c3ce54888abcdb2fef6f6b093865a5d6 | zork: Move tcpc,ppc,bc12 from baseboard to board
BRANCH=none
TEST=Build all zork boards | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"console.h\"\n#include \"cros_board_info.h\"\n#include \"driver/accelgyro_bmi_common.h\"\n-#include \"driver/bc12/pi3usb9201.h\"\n-#include \"driver/ppc/aoz1380.h\"\n-#in... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zork: Move tcpc,ppc,bc12 from baseboard to board
BUG=b:158125500
BRANCH=none
TEST=Build all zork boards
Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Change-Id: I86a21a049f97c42d330be6c1bfbecbda10e1ebb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2230941
Reviewed-by: Peter Marheine <pmarheine@chromium.org> |
136,311 | 29.05.2020 10:33:26 | 21,600 | 541b3b1c99479e74de72885d16d2bbb4650539d5 | volteer: add USB overcurrent notification to AP
Enable the USB C0 and USB C1 overcurrent signals to the AP.
BRANCH=none
TEST=make buildall
TEST=Force overcurrent event by manually setting PPC current limit below
PD contract. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.c",
"new_path": "baseboard/volteer/baseboard.c",
"diff": "@@ -558,7 +558,15 @@ void board_set_charge_limit(int port, int supplier, int charge_ma,\nvoid board_overcurrent_event(int port, int is_overcurrented)\n{\n- /* TODO: b/1405618... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | volteer: add USB overcurrent notification to AP
Enable the USB C0 and USB C1 overcurrent signals to the AP.
BUG=b:140561826
BRANCH=none
TEST=make buildall
TEST=Force overcurrent event by manually setting PPC current limit below
PD contract.
Signed-off-by: Keith Short <keithshort@chromium.org>
Change-Id: I5eea4812c212496f1c483c4149697b2d53a16a37
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2222960
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,208 | 27.04.2020 15:18:38 | -28,800 | 2bb86028ddaa556fcb5edbaf0d44697e4e3bae22 | asurada: enable C0/C1 USB mux
C0: IT5205
C1: PS8743 redriver
BRANCH=master
TEST=make build | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "#include \"driver/charger/isl923x.h\"\n#include \"driver/ppc/syv682x.h\"\n#include \"driver/tcpm/it83xx_pd.h\"\n+#include \"driver/usb_mux/it5205.h\"\n+#include \"driver/usb_mux/ps8743.h\"\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable C0/C1 USB mux
C0: IT5205
C1: PS8743 redriver
BRANCH=master
BUG=b:154559495
TEST=make build
Change-Id: I103e6f5d41d6c2f2618f95753547bb8e5a190bac
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167126
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,257 | 09.06.2020 13:36:03 | -28,800 | f6392851299ee41e006febcf0029d00f1b31c5be | kakadu: turn off Vconn boost gpio pin when S5/G3
It should be ~0V in G3, 5V in S3/S0. And this pin can solve apple HDMI dongle issue.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "power/mt8183.c",
"new_path": "power/mt8183.c",
"diff": "@@ -109,6 +109,9 @@ static const struct power_seq_op s3s5_power_seq[] = {\n{ GPIO_AP_SYS_RST_L, 0, 0 },\n/* Assert watchdog to PMIC (there may be a 1.6ms debounce) */\n{ GPIO_PMIC_WATCHDOG_L, 0, 3 },\n+#i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: turn off Vconn boost gpio pin when S5/G3
It should be ~0V in G3, 5V in S3/S0. And this pin can solve apple HDMI dongle issue.
BUG=b:156570690
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I3bd23a0534d0d63fe22bf26ed3a24b34b73fa142
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2235235
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,368 | 01.06.2020 10:53:18 | 25,200 | cf2a457ac189e46c85e78c7adb46e3485ae14f5d | servo_v4p1: Add TCA6416A and TCA6424A drivers
Add TCA6416A and TCA6424A IO Expander driver.
BRANCH=none
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/servo_v4p1/build.mk",
"new_path": "board/servo_v4p1/build.mk",
"diff": "@@ -14,6 +14,6 @@ CHIP_VARIANT:=stm32f07x\ntest-list-y=\n# These files are compiled into RO and RW\n-board-y=board.o\n+board-y=board.o tca6416a.o tca6424a.o\nall_deps=$(patsubst ro,,... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | servo_v4p1: Add TCA6416A and TCA6424A drivers
Add TCA6416A and TCA6424A IO Expander driver.
BRANCH=none
BUG=b:146793000
TEST=make -j buildall
Signed-off-by: Sam Hurst <shurst@google.com>
Change-Id: I498496bab9f1b874b502c2a1f704d1693a7c1cf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2223822
Reviewed-by: Wai-Hong Tam <waihong@google.com> |
136,451 | 09.06.2020 11:38:09 | -28,800 | 1587e30266cf7e2efdd6c11872fe98d2034e5279 | vilboz: Split mux to dalboz and vilboz
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -325,22 +325,6 @@ __override uint32_t board_override_feature_flags0(uint32_t flags0)\nreturn flags0;\n}\n-void board_overcurrent_event(int port, int is_overcurrented)\n-{\n- swi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | vilboz: Split mux to dalboz and vilboz
BUG=b:158125500
BRANCH=none
TEST=make buildall -j
Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Change-Id: I0836daf254f1c1c1fb2d7fd45868b55517689cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2235236
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org> |
136,451 | 09.06.2020 17:32:17 | -28,800 | 355b4dcfd970e3f51f9fbf9ef4d525a9e9b78f35 | vilboz: Remove USBC1 port
Remove C1 tcpc, ppc, bc12
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/vilboz/board.c",
"new_path": "board/vilboz/board.c",
"diff": "#include \"driver/bc12/pi3usb9201.h\"\n#include \"driver/ioexpander/pcal6408.h\"\n#include \"driver/ppc/aoz1380.h\"\n-#include \"driver/ppc/nx20p348x.h\"\n#include \"driver/tcpm/nct38xx.h\"\n#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | vilboz: Remove USBC1 port
Remove C1 tcpc, ppc, bc12
BUG=b:158125500
BRANCH=none
TEST=make buildall -j
Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Change-Id: Ifd472cea62a1ae9d1860cf84f46d8d02e7e2da95
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2235241
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org> |
136,208 | 27.04.2020 16:29:46 | -28,800 | 3f4a4390a7d65bc51bb30af4ddb48db5033ee0ec | asurada: enable DP HPD
BRANCH=master
TEST=Asurada has DP out on C0 and C1. | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.c",
"new_path": "board/asurada/board.c",
"diff": "@@ -262,6 +262,14 @@ static int board_ps8743_mux_set(const struct usb_mux *me,\n/* Disable CE_DP pin, enable I2C control. */\nreg |= PS8743_MODE_DP_REG_CONTROL;\n+ /*\n+ * DP specific config... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable DP HPD
BRANCH=master
BUG=b:154565980
TEST=Asurada has DP out on C0 and C1.
Change-Id: If71a29b4b7fb1c2ca966d707f142b4350edc8125
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2167129
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.