author int64 658 755k | date stringlengths 19 19 | timezone int64 -46,800 43.2k | hash stringlengths 40 40 | message stringlengths 5 490 | mods list | language stringclasses 20 values | license stringclasses 3 values | repo stringlengths 5 68 | original_message stringlengths 12 491 |
|---|---|---|---|---|---|---|---|---|---|
136,340 | 06.03.2020 10:15:43 | 28,800 | b13856bc9f193c8c7f4a045b684131b5cf7d0900 | driver: lis2dw12: Fix maximal ODR
Be sure EC max frequency is taken into account.
BRANCH=hatch, grunt
TEST=Check tast run <IP> hardware.SensorRing
works on Akemi(hatch) with new firwmare. | [
{
"change_type": "MODIFY",
"old_path": "driver/accel_lis2dw12.h",
"new_path": "driver/accel_lis2dw12.h",
"diff": "@@ -176,7 +176,9 @@ enum lis2dw12_odr {\n/* Absolute Acc rate. */\n#define LIS2DW12_ODR_MIN_VAL 12500\n-#define LIS2DW12_ODR_MAX_VAL 1600000\n+#define LIS2DW12_ODR_MAX_VAL \\\n+ MOTION_M... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: lis2dw12: Fix maximal ODR
Be sure EC max frequency is taken into account.
BUG=chromium:615059,chromium:1059318
BRANCH=hatch, grunt
TEST=Check tast run <IP> hardware.SensorRing
works on Akemi(hatch) with new firwmare.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I8c4bf1213c876ceec4b20a4dd87094aab79d7b0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2092214
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> |
136,340 | 06.03.2020 10:24:05 | 28,800 | 487317f4f06c563bfd591c2e6a439489548b7d1a | driver: l3gd20h: Fix maximal ODR
Be sure EC max frequency is taken into account.
[The component does not seem to be used.]
BRANCH=none
TEST=Compile | [
{
"change_type": "MODIFY",
"old_path": "driver/gyro_l3gd20h.h",
"new_path": "driver/gyro_l3gd20h.h",
"diff": "/* Min and Max sampling frequency in mHz */\n#define L3GD20_GYRO_MIN_FREQ 12500\n-#define L3GD20_GYRO_MAX_FREQ 800000\n+#define L3GD20_GYRO_MAX_FREQ \\\n+ MOTION_MAX_SENSOR_FREQUENCY(800000,... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | driver: l3gd20h: Fix maximal ODR
Be sure EC max frequency is taken into account.
[The component does not seem to be used.]
BUG=chromium:615059,chromium:1059318
BRANCH=none
TEST=Compile
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: I00afa72d1642e2a3237e842a73ecc8ed50ec4a69
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2092215
Reviewed-by: Heng-ruey Hsu <henryhsu@chromium.org> |
136,269 | 06.03.2020 17:46:42 | 28,800 | 739d2762604760e5ce24ef7be060f39f2ca5abd0 | docs/fingerprint: Add issue tracker docs
Add details on how to use the partner issue tracker and expectations
around communication.
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint-dev-for-partners.md",
"new_path": "docs/fingerprint/fingerprint-dev-for-partners.md",
"diff": "@@ -398,6 +398,24 @@ at Google for the exact values to use below:\n```\n***\n+### Tracking Issues and Communication\n+\n+Development iss... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Add issue tracker docs
Add details on how to use the partner issue tracker and expectations
around communication.
BRANCH=none
BUG=none
TEST=view in gitiles
Change-Id: I49e81b9331c514371dc9f49d44b1ff8856081cee
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2092914
Commit-Queue: Craig Hesling <hesling@chromium.org>
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,204 | 03.02.2020 16:28:43 | -28,800 | 8799bde592c944cb51c9861011d8e57bb58bc50d | palkia: fix battery info
BRANCH=firmware-hatch-12672.B
TEST=battery can be charged. | [
{
"change_type": "MODIFY",
"old_path": "board/palkia/battery.c",
"new_path": "board/palkia/battery.c",
"diff": "*/\nconst struct board_batt_params board_battery_info[] = {\n/* Simplo Battery Information */\n- [BATTERY_SIMPLO_C424] = {\n+ [BATTERY_DYNAPACK_UX48144] = {\n.fuel_gauge = {\n- .manuf_name... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | palkia: fix battery info
BUG=b:147867658
BRANCH=firmware-hatch-12672.B
TEST=battery can be charged.
Change-Id: I982356657087f76542219de0ce29ddd2e140d9bd
Signed-off-by: Zhuohao Lee <zhuohao@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2035443
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,324 | 05.03.2020 14:28:22 | 25,200 | 3515ab7ed26fd6b07be2f8154fed3836c3192b96 | zork: add EC fw_config framework
BRANCH=none
TEST=verify adding a call to fw_config routines work | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"adc.h\"\n#include \"adc_chip.h\"\n#include \"button.h\"\n+#include \"cbi_ec_fw_config.h\"\n#include \"charge_manager.h\"\n#include \"charge_state.h\"\n#include \"charge_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zork: add EC fw_config framework
BUG=none
BRANCH=none
TEST=verify adding a call to fw_config routines work
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Change-Id: Ib56bae5a0ce0b1078fdd235a3595fa059181dc2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2090086
Reviewed-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,287 | 05.02.2020 14:25:02 | 25,200 | 6a0ad26931135a3811eedade595a7b1a80bb1931 | common: motion_sense: implement AP command to read dirty calibration
BRANCH=None
TEST=buildall | [
{
"change_type": "MODIFY",
"old_path": "common/motion_sense.c",
"new_path": "common/motion_sense.c",
"diff": "#include \"motion_sense.h\"\n#include \"motion_sense_fifo.h\"\n#include \"motion_lid.h\"\n+#include \"online_calibration.h\"\n#include \"power.h\"\n#include \"queue.h\"\n#include \"tablet_mo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: motion_sense: implement AP command to read dirty calibration
BRANCH=None
BUG=b:138303429,chromium:1023858
TEST=buildall
Change-Id: I857dbc0975a239a6d8419015d8b9e34415b477cf
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2044702
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Commit-Queue: Gwendal Grignou <gwendal@chromium.org> |
136,257 | 06.03.2020 13:38:40 | -28,800 | da4e343794782a124c09d669805718f91185dbd4 | damu: Enable IMU sensors
The LIS2DWLTR is used on lid and BMI160 is used on base.
BRANCH=
TEST=make -j BOARD=duma
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/damu/board.c",
"new_path": "board/damu/board.c",
"diff": "#include \"chipset.h\"\n#include \"common.h\"\n#include \"console.h\"\n+#include \"driver/accel_lis2dw12.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/battery/max17055.h\"\n#inclu... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: Enable IMU sensors
The LIS2DWLTR is used on lid and BMI160 is used on base.
BUG=b:147206199
BRANCH=
TEST=make -j BOARD=duma
TEST=make buildall
Change-Id: I010fe245bf183aaec050ef9390a74ad73b4ab716
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2091132
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,287 | 09.03.2020 11:41:00 | 21,600 | 47bd81774313e37af925d468d3b943b66a9268fc | common: online_calibration: Initialize accelerometer calibration
Update the init function for online calibration to initialize
the accelerometer calibration.
BRANCH=None
TEST=build | [
{
"change_type": "MODIFY",
"old_path": "common/online_calibration.c",
"new_path": "common/online_calibration.c",
"diff": "@@ -93,8 +93,29 @@ void online_calibration_init(void)\n{\nsize_t i;\n- for (i = 0; i < SENSOR_COUNT; i++)\n- motion_sensors[i].online_calib_data->last_temperature = -1;\n+ for (i... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common: online_calibration: Initialize accelerometer calibration
Update the init function for online calibration to initialize
the accelerometer calibration.
BRANCH=None
BUG=b:138303429,chromium:1023858
TEST=build
Change-Id: I01c353830edb4b7508e6614dcebbceffee41690f
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2095518
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org> |
136,340 | 11.03.2020 11:59:32 | 25,200 | 5dccb3d59aa936441f55fc8b984173d2c557e8d3 | ec_commands: Add limits.h for linux kernel compatibility
For Uxx_MAX macros, we need to include limits.h.
BRANCH=none
TEST=compile. Check kernel 4.19 with this change compiles as well. | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -32,12 +32,12 @@ extern \"C\" {\n#include \"compile_time_macros.h\"\n#else\n-\n#define BUILD_ASSERT(_cond)\n-\n#endif /* CHROMIUM_EC */\n-#ifndef __KERNEL__\n+#ifdef __KERNEL__\n+#include... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_commands: Add limits.h for linux kernel compatibility
For Uxx_MAX macros, we need to include limits.h.
BUG=chromium:945948
BRANCH=none
TEST=compile. Check kernel 4.19 with this change compiles as well.
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Change-Id: Id498a1c647acab3007d5e368ed4b15382ef1c392
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2098871
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,293 | 11.03.2020 15:09:54 | 14,400 | c79b2278103e077ddb6e04b43c248f25b03b7af4 | endeavour: update led names and fix init
Copy fix from puff:
BRANCH=none
TEST=boot endeavour; ectool led commands | [
{
"change_type": "MODIFY",
"old_path": "board/endeavour/board.c",
"new_path": "board/endeavour/board.c",
"diff": "@@ -296,7 +296,7 @@ int64_t get_time_dsw_pwrok(void)\nconst struct pwm_t pwm_channels[] = {\n[PWM_CH_LED_RED] = { 3, PWM_CONFIG_DSLEEP, 100 },\n- [PWM_CH_LED_BLUE] = { 5, PWM_CONFIG_DSLE... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | endeavour: update led names and fix init
Copy fix from puff: d34e19b1c
BUG=b:151172843
BRANCH=none
TEST=boot endeavour; ectool led commands
Change-Id: I7f0dba7a15587607882c9c9ba8f847df201190f2
Signed-off-by: Jeff Chase <jnchase@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2097068
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,443 | 03.03.2020 10:42:25 | 28,800 | d9ee9a446f5eccc61efd67b53f9d89847d0b3bd5 | docs: Add IDE Support
Had to uglify the table content because Gitiles doesn't understand |
inside backticks, in a table.
It also doesn't like < or > inside backticks.
BRANCH=none
TEST=Observe in gitiles | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "docs/ide-support.md",
"diff": "+# IDE Support\n+\n+[TOC]\n+\n+## Odd File Types\n+\n+EC uses a few odd file types/names. Some are included from other header files\n+and used to generate data structures, thus it is important for your IDE to index... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add IDE Support
Had to uglify the table content because Gitiles doesn't understand |
inside backticks, in a table.
It also doesn't like < or > inside backticks.
BRANCH=none
BUG=none
TEST=Observe in gitiles
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Id6e29899878f1b17c12a475e5e882553d32b712b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2085157 |
136,443 | 12.03.2020 20:53:40 | 0 | 4d5a5e5ee9f2a33f1ee2ca8dbe1bf9b17e7f4b78 | docs/ide-support.md: Add .vscode/setting.json tip
BRANCH=none
TEST=viewed in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/ide-support.md",
"new_path": "docs/ide-support.md",
"diff": "@@ -44,3 +44,23 @@ includes selectable sub-configurations for every board/image pair.\nYou will only see this option when a C/C++ file is open. Additionally, you\ncan select a configuration by p... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/ide-support.md: Add .vscode/setting.json tip
BRANCH=none
BUG=none
TEST=viewed in gitiles
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I25810b8a7aa2b55200ef07f2eb4a45c1d03c9160
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101591
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,222 | 11.03.2020 10:54:40 | -28,800 | 85016d46504baed5735be70d477874bc7d3a0ede | Fix comment typo
TEST=make buildall
BRANCH=none | [
{
"change_type": "MODIFY",
"old_path": "common/main.c",
"new_path": "common/main.c",
"diff": "@@ -82,7 +82,7 @@ test_mockable __keep int main(void)\nboard_config_post_gpio_init();\n#endif\n/*\n- * Initialize interrupts, but don't enable any of them. Note that\n+ * Initialize tasks, but don't enable ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Fix comment typo
BUG=none
TEST=make buildall
BRANCH=none
Change-Id: I1c75aa5050ccb21015d5feb0d93a09ed4f0430d9
Signed-off-by: Tzung-Bi Shih <tzungbi@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2099724
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,208 | 13.03.2020 10:05:35 | -28,800 | 23b93b7b24fec66d3b3d0e75d2383081a81008cf | asurada/gpio: add headings for each component
Reference kohaku's classfication.
BRANCH=master
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/gpio.inc",
"new_path": "board/asurada/gpio.inc",
"diff": "/* Declare symbolic names for all the GPIOs that we care about.\n* Note: Those with interrupt handlers must be declared first. */\n+/* Wake Source interrupts */\n+\n+/* Power sequencing in... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada/gpio: add headings for each component
Reference kohaku's classfication.
BRANCH=master
BUG=b:150341271
TEST=make buildall
Change-Id: I45623d6e98a169cc0969d1cd69f5f119fa5fb74f
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2102095
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,293 | 13.03.2020 14:04:09 | 14,400 | ae56c680adeba3cea589d45788d77f186c2f8fbe | endeavour: ensure correct led state on init
Also remove dead led_alert() code since this board does not use USB-C
power.
BRANCH=none
TEST=various reboots, power cycles, and suspends | [
{
"change_type": "MODIFY",
"old_path": "board/endeavour/board.h",
"new_path": "board/endeavour/board.h",
"diff": "@@ -147,7 +147,6 @@ enum OEM_ID {\n};\n/* Board specific handlers */\n-void led_alert(int enable);\nvoid show_critical_error(void);\n#endif /* !__ASSEMBLER__ */\n"
},
{
"change_t... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | endeavour: ensure correct led state on init
Also remove dead led_alert() code since this board does not use USB-C
power.
BUG=b:151172843
BRANCH=none
TEST=various reboots, power cycles, and suspends
Signed-off-by: Jeff Chase <jnchase@google.com>
Change-Id: I60ab17e0bfc15731005ae81682e0cde9fff3f8d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2103050
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,282 | 16.03.2020 09:26:52 | -28,800 | 512a11f19e37560f9add73d146a910dd9ac3796b | bipship: add SKU IDs
BRANCH=octopus
TEST=make buildall -j
Tested-by: Henry Sun | [
{
"change_type": "MODIFY",
"old_path": "board/bloog/board.c",
"new_path": "board/bloog/board.c",
"diff": "@@ -222,12 +222,13 @@ int board_is_convertible(void)\n/*\n* Bloog: 33, 34, 35, 36\n* Blooguard: 49, 50, 51, 52\n- * Bipship: 53, 54\n+ * Bipship: 53, 54, 55, 56\n* Unprovisioned: 255\n*/\nreturn... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bipship: add SKU IDs
BUG=b:147021309
BRANCH=octopus
TEST=make buildall -j
Change-Id: Idff9783ff6e1e9dc2bcf99af32333f57967f33ab
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2102836
Reviewed-by: Henry Sun <henrysun@google.com>
Tested-by: Henry Sun <henrysun@google.com>
Commit-Queue: Henry Sun <henrysun@google.com> |
136,305 | 05.03.2020 13:10:55 | 25,200 | b9d829a21f2c4ea85d96ba7df8426720591cc75c | TUSB544: Add driver structure declaration
This adds the extern declaration for the tusb544_drv structure for
boards to use, clarifies the name of the I2C address flag, and updates
to the new redriver driver type.
BRANCH=None
TEST=builds | [
{
"change_type": "MODIFY",
"old_path": "driver/retimer/tusb544.c",
"new_path": "driver/retimer/tusb544.c",
"diff": "#include \"tusb544.h\"\n#include \"usb_mux.h\"\n-static int tusb544_write(int port, int offset, int data)\n+static int tusb544_write(const struct usb_mux *me, int offset, int data)\n{\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TUSB544: Add driver structure declaration
This adds the extern declaration for the tusb544_drv structure for
boards to use, clarifies the name of the I2C address flag, and updates
to the new redriver driver type.
BUG=None
BRANCH=None
TEST=builds
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I045b76599f6cc5a4c64ae88bda7cd72c94a19e40
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101218
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 12.03.2020 15:39:34 | 21,600 | 27f5a494fc2d6f40b4f33f1f6887f0836ff7e195 | ISL923x: Accept charger chip for prochot functions
This commit moves the charger chip number into a parameter for the
isl923x driver, so it can be used for boards which use more than one
charger chip.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/nami/board.c",
"new_path": "board/nami/board.c",
"diff": "@@ -1043,17 +1043,17 @@ static void board_init(void)\nswap(scancode_set2[0][4], scancode_set2[7][2]);\n#endif\n- isl923x_set_ac_prochot(3328 /* mA */);\n+ isl923x_set_ac_prochot(CHARGER_SOLO, 3328... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ISL923x: Accept charger chip for prochot functions
This commit moves the charger chip number into a parameter for the
isl923x driver, so it can be used for boards which use more than one
charger chip.
BUG=None
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ibfc7aaf30e2c00be0d1b2171052e15c3098516a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101219
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 12.03.2020 13:00:19 | 21,600 | 3027dd55428433becca109b12b2df87291f5d66d | OCPC: Introduce charger enum
This enum will specify which charger is primary, and the number of total
charger chips for the board. This will be pre-defined for boards using
a single charger chip.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define CONFIG_USB_CHARGER\n#define CONFIG_USB_PD_5V_EN_CUSTOM\n#define CONFIG_TRICKLE_CHARGING\n+#undef CONFIG_CHARGER_SINGLE_CHIP\n/* Keyboard */\n#define CONFIG_KEYBOARD_COL... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | OCPC: Introduce charger enum
This enum will specify which charger is primary, and the number of total
charger chips for the board. This will be pre-defined for boards using
a single charger chip.
BUG=b:147440290
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Id612ace560207a7805e103465fd4035d46beed8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101220
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,443 | 13.03.2020 00:06:24 | 0 | 7fbaf04a93af9c56819cf795789c378d539364ce | util/ide-config.sh: Cleanup
* Change error messages to print to stderr
* Uglify variables to adhere to shell scripting style
BRANCH=none
TEST=none
Tested-by: Craig Hesling | [
{
"change_type": "MODIFY",
"old_path": "util/ide-config.sh",
"new_path": "util/ide-config.sh",
"diff": "# Use of this source code is governed by a BSD-style license that can be\n# found in the LICENSE file.\n#\n-# Usage: ./util/ide-config vscode all all:RO | tee .vscode/c_cpp_properties.json\n+# Usa... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | util/ide-config.sh: Cleanup
* Change error messages to print to stderr
* Uglify variables to adhere to shell scripting style
BRANCH=none
BUG=none
TEST=none
Change-Id: I2baef1b9711447b3506c74674db5701e9ba8c753
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101901
Tested-by: Craig Hesling <hesling@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Commit-Queue: Craig Hesling <hesling@chromium.org> |
136,443 | 14.03.2020 13:46:23 | 25,200 | 57d7636cb077c4b5d1fbcf2dd0f0a912203b2867 | docs/ide-suport.md: Add better editor settings
This adds a more complete view of file styles in EC.
This may not represent the goal, but more the trend of
file styles seen in EC.
BRANCH=none
TEST=viewed in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/ide-support.md",
"new_path": "docs/ide-support.md",
"diff": "@@ -49,9 +49,25 @@ includes selectable sub-configurations for every board/image pair.\n```json\n{\n\"editor.rulers\": [80],\n- \"[c]\": {\n+ /* C, Makefiles, ASM, Linkerfiles, Properties */\n\"e... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/ide-suport.md: Add better editor settings
This adds a more complete view of file styles in EC.
This may not represent the goal, but more the trend of
file styles seen in EC.
BRANCH=none
BUG=none
TEST=viewed in gitiles
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: Ib981590703088fa34320ab0f7496e7cb0a23df55
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2103866
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,390 | 19.03.2020 13:16:54 | -28,800 | ee0cd07ecf50972d0fa024ef579a00e44a6ef7d0 | jacuzzi: Fix sensor rotation matrix
TEST=pass CTSV Accelerometer Measurement Tests
BRANCH=None | [
{
"change_type": "MODIFY",
"old_path": "board/jacuzzi/board.c",
"new_path": "board/jacuzzi/board.c",
"diff": "@@ -339,8 +339,8 @@ static struct mutex g_base_mutex;\n/* Rotation matrixes */\nstatic const mat33_fp_t base_standard_ref = {\n+ {FLOAT_TO_FP(1), 0, 0},\n{0, FLOAT_TO_FP(1), 0},\n- {FLOAT_TO... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | jacuzzi: Fix sensor rotation matrix
BUG=b:151693584
TEST=pass CTSV Accelerometer Measurement Tests
BRANCH=None
Change-Id: I9b23e6c32311722d53f76fb831aa72bc1331ad73
Signed-off-by: Heng-ruey Hsu <henryhsu@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2109435
Reviewed-by: Ricky Liang <jcliang@chromium.org> |
136,257 | 19.03.2020 10:41:10 | -28,800 | d7957d559f0af9bd07fcb56dcafec6f4bf061191 | damu: change lid sensor
change lid sensor from LIS2DWL to LIS2DE12.
BUG:b:147689571
BRANCH:kukui
TEST=make -j BOARD=damu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/damu/board.c",
"new_path": "board/damu/board.c",
"diff": "#include \"chipset.h\"\n#include \"common.h\"\n#include \"console.h\"\n-#include \"driver/accel_lis2dw12.h\"\n+#include \"driver/accel_lis2dh.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: change lid sensor
change lid sensor from LIS2DWL to LIS2DE12.
BUG:b:147689571
BRANCH:kukui
TEST=make -j BOARD=damu
TEST=make buildall
Change-Id: I3920e41df83d264af177fd3ae36029e866f8a01a
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2109433
Reviewed-by: Li-jen Chen <lijen@google.com>
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,427 | 17.03.2020 23:40:08 | 21,600 | 9f17f26d0ac487ea4092809f23fe7c38cfb7e866 | usb_port_power: Add CONFIG_USB_PORT_ENABLE_DYNAMIC
BRANCH=none
TEST=none
Tested-by: Paul Ma | [
{
"change_type": "MODIFY",
"old_path": "include/config.h",
"new_path": "include/config.h",
"diff": "*/\n#undef CONFIG_USB_PORT_POWER_SMART\n+/*\n+ * GPIOs to enable USB port power have non-const configuration.\n+ */\n+#undef CONFIG_USB_PORT_ENABLE_DYNAMIC\n+\n/*\n* Support smart power control to the... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_port_power: Add CONFIG_USB_PORT_ENABLE_DYNAMIC
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I06c2ceee818499eabf3a240d27151dbd1ff88653
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108333
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Paul Ma <magf@bitland.corp-partner.google.com>
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> |
136,427 | 17.03.2020 20:37:39 | 21,600 | 1deb79863d965a2410515f633ff66646badd9a65 | ioexpander: add IOEX_FLAGS_DISABLED
BRANCH=none
TEST=none
Tested-by: Paul Ma | [
{
"change_type": "MODIFY",
"old_path": "common/ioexpander.c",
"new_path": "common/ioexpander.c",
"diff": "@@ -40,9 +40,18 @@ int signal_is_ioex(int signal)\nstatic const struct ioex_info *ioex_get_signal_info(enum ioex_signal signal)\n{\n+ const struct ioex_info *g;\n+\nASSERT(signal_is_ioex(signal)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ioexpander: add IOEX_FLAGS_DISABLED
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Id264d633576ca79b288a435f95de7fda9ca201ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108334
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Paul Ma <magf@bitland.corp-partner.google.com>
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> |
136,427 | 17.03.2020 20:59:46 | 21,600 | d9f78047be7d7cc1d2e9279a6f2c3bac16c54af9 | zork: split ioex_config[] to trembyle and dalboz
BRANCH=none
TEST=none
Tested-by: Paul Ma | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "#include \"gpio.h\"\n#include \"hooks.h\"\n#include \"ioexpander.h\"\n-#include \"ioexpander_nct38xx.h\"\n#include \"i2c.h\"\n#include \"keyboard_scan.h\"\n#include \"lid_switch.h\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zork: split ioex_config[] to trembyle and dalboz
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ifc615bf8c4c5c8a684954ef932c5e9f5e60122de
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108335
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Paul Ma <magf@bitland.corp-partner.google.com>
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> |
136,427 | 17.03.2020 21:05:24 | 21,600 | eedeace7ae301aca482d6a2f5a2d722e1e0cec31 | zork: split baseboard_tcpc_init to trembyle and dalboz
BRANCH=none
TEST=none
Tested-by: Paul Ma | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -295,28 +295,6 @@ const struct pi3usb9201_config_t pi3usb9201_bc12_chips[] = {\n};\nBUILD_ASSERT(ARRAY_SIZE(pi3usb9201_bc12_chips) == USBC_PORT_COUNT);\n-void baseboard_tcpc_ini... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zork: split baseboard_tcpc_init to trembyle and dalboz
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I5cae9cd365d198873c4d022dd1b166b318c1a4c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108336
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Paul Ma <magf@bitland.corp-partner.google.com>
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> |
136,427 | 17.03.2020 23:29:25 | 21,600 | 32a40f3a2cfe46607e5d259927aec67c3c7d47ef | dalboz: select GPIOs based on DB option
BRANCH=none
TEST=none
Tested-by: Paul Ma | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -406,11 +406,6 @@ void bc12_interrupt(enum gpio_signal signal)\n}\n}\n-const int usb_port_enable[USB_PORT_COUNT] = {\n- IOEX_EN_USB_A0_5V,\n- IOEX_EN_USB_A1_5V_DB,\n-};\n-\nstat... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dalboz: select GPIOs based on DB option
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I7079d989013e022fb0bc7ffa925f51e6490d864c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2101223
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Paul Ma <magf@bitland.corp-partner.google.com>
Tested-by: Paul Ma <magf@bitland.corp-partner.google.com> |
136,427 | 17.03.2020 23:44:43 | 21,600 | 455c33c43c72c838a46db4b58520489f57c3363a | dalboz: Set usb_port_enable[] for DB option
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_USB_MUX_PS8740\n#define CONFIG_IO_EXPANDER_PCAL6408\n#define CONFIG_IO_EXPANDER_PORT_COUNT IOEX_PORT_COUNT\n+ #define CONFIG_USB_PORT_ENABLE_DYNAMIC\n#endif\n/* USB-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dalboz: Set usb_port_enable[] for DB option
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I9e914a767a6b0fd1d77b3c32a2414711531404f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108337
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 17.03.2020 23:56:31 | 21,600 | d3554c0366a9d5a9a548c0a2267221a69c41f556 | dalboz: Set IOEX interrupt handler for DB option
BRANCH=none
TEST=IO expander works on both OPT1 and OPT2 DB | [
{
"change_type": "MODIFY",
"old_path": "board/dalboz/board.c",
"new_path": "board/dalboz/board.c",
"diff": "#include \"button.h\"\n#include \"driver/accel_lis2dw12.h\"\n#include \"driver/accelgyro_lsm6dsm.h\"\n+#include \"driver/ioexpander/pcal6408.h\"\n#include \"extpower.h\"\n#include \"fan.h\"\n#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dalboz: Set IOEX interrupt handler for DB option
BUG=b:150349225
BRANCH=none
TEST=IO expander works on both OPT1 and OPT2 DB
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: If4152427d7c3ec8ea3f719cb0f13f1d3d689fc6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2108338
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 19.03.2020 13:48:21 | 21,600 | a18873f6ebbac08cd6bc3eee80ee0f8823b350b3 | nct38xx: Remove ioexpander_nct38xx.h
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/variant_dalboz.c",
"new_path": "baseboard/zork/variant_dalboz.c",
"diff": "#include \"common.h\"\n#include \"console.h\"\n#include \"driver/ioexpander/pcal6408.h\"\n+#include \"driver/tcpm/nct38xx.h\"\n#include \"driver/usb_mux/amd_fp5.h\"\n#inc... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nct38xx: Remove ioexpander_nct38xx.h
BUG=b:150349225
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I830196908012778254e7306ea6a53bb3e4e4258d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110547
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,305 | 18.03.2020 14:31:42 | 21,600 | d68abb5d52c3474aa247a47c23375354d08be600 | Charger: Add driver function for sourcing OTG
Fold charger_is_sourcing_otg_power into the charger driver structure.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/charger.c",
"new_path": "common/charger.c",
"diff": "@@ -318,6 +318,22 @@ enum ec_error_list charger_set_otg_current_voltage(int output_current,\nreturn rv;\n}\n+int charger_is_sourcing_otg_power(int port)\n+{\n+ int chgnum = 0;\n+ int rv = 0;\n+\n+ if ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Charger: Add driver function for sourcing OTG
Fold charger_is_sourcing_otg_power into the charger driver structure.
BUG=None
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I0526495fff8464539e216d2cf80c34e09af2c418
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110530
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,282 | 24.03.2020 16:00:18 | -28,800 | 5b7ba935f2d192c524be8ec6932e25ee9668d0d6 | kappa: fix battery manufacturer name data
BRANCH=kukui
TEST=make BOARD=kappa | [
{
"change_type": "MODIFY",
"old_path": "board/kappa/battery.c",
"new_path": "board/kappa/battery.c",
"diff": "@@ -39,7 +39,7 @@ const struct board_batt_params board_battery_info[] = {\n/* Dynapack CosMX DAK124960-W0P0707HT Battery Information */\n[BATTERY_DANAPACK_COS] = {\n.fuel_gauge = {\n- .manuf... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kappa: fix battery manufacturer name data
BUG=b:146504215
BRANCH=kukui
TEST=make BOARD=kappa
Change-Id: Id56be3e3e98fc88f5ebac7ea8604a1d65dc1d0df
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2115907
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,443 | 18.03.2020 16:44:25 | 25,200 | a847dd2e7a9feb8e584c31a9c491b5df4bf59c2c | bloonchipper: Reorganize board.h into sections
This brings no functional change, as verified with
compare_build.sh @
BRANCH=none
TEST=./util/compare_builds.sh -b hatch_fp | [
{
"change_type": "MODIFY",
"old_path": "board/hatch_fp/board.h",
"new_path": "board/hatch_fp/board.h",
"diff": "#undef CONFIG_SYSTEM_UNLOCKED\n-/*\n- * These allow console commands to be flagged as restricted.\n- * Restricted commands will only be permitted to run when\n- * console_is_restricted() r... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | bloonchipper: Reorganize board.h into sections
This brings no functional change, as verified with
compare_build.sh @ https://crrev.com/c/2093897/11.
BRANCH=none
BUG=none
TEST=./util/compare_builds.sh -b hatch_fp
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I98cb9a8f3419b376051d23c64db11b2059d71aa3
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2109246
Reviewed-by: Tom Hughes <tomhughes@chromium.org> |
136,305 | 19.03.2020 12:22:51 | 21,600 | decfcb46088d616a102b3239a739608790eab73b | Waddledee: Fill in batteries
This copies the batteries from the bobba (sparky) board.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/battery.c",
"new_path": "board/waddledee/battery.c",
"diff": "* address, mask, and disconnect value need to be provided.\n*/\nconst struct board_batt_params board_battery_info[] = {\n- /* TODO(b/146557556): get battery spec(s) */\n+ /* LGC AC15... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Fill in batteries
This copies the batteries from the bobba (sparky) board.
BUG=b:146557556
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I7deb5ca6409c990c807db477ba3932026e4e6c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110533
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,197 | 09.05.2019 13:35:30 | -32,400 | c830ecc1f728b722fde24a5da14a89f9223f291c | core/cortex-m0/curve25519: Move code to third_party folder
Also, add LICENSE file (some files are under CC0, some are
public domain), and METADATA file.
BRANCH=none
TEST=make buildall -j, which also include basic tests. | [
{
"change_type": "ADD",
"old_path": null,
"new_path": "core/cortex-m0/curve25519",
"diff": "+../../third_party/unacl-curve25519/core/cortex-m0/curve25519\n\\ No newline at end of file\n"
},
{
"change_type": "RENAME",
"old_path": "core/cortex-m0/curve25519/cc0_1.0",
"new_path": "third... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | core/cortex-m0/curve25519: Move code to third_party folder
Also, add LICENSE file (some files are under CC0, some are
public domain), and METADATA file.
BRANCH=none
BUG=chromium:884905
TEST=make buildall -j, which also include basic tests.
Change-Id: Ib3a7eb9245a0634c4052064c3e36cbe2ddafbcb9
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1599761
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,197 | 09.05.2019 14:37:08 | -32,400 | 6d2a49dc7f603551ec3d898b74b8740fe0736cd9 | common/sha256: Move to third_party
The code originally comes from vboot_reference, and is now
found on github: .
BRANCH=none
TEST=make buildall -j, which also include basic tests. | [
{
"change_type": "DELETE",
"old_path": "common/sha256.c",
"new_path": null,
"diff": "-/* SHA-256 and SHA-512 implementation based on code by Oliver Gay\n- * <olivier.gay@a3.epfl.ch> under a BSD-style license. See below.\n- */\n-\n-/*\n- * FIPS 180-2 SHA-224/256/384/512 implementation\n- * Last updat... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | common/sha256: Move to third_party
The code originally comes from vboot_reference, and is now
found on github: https://github.com/ogay/sha2 .
BRANCH=none
BUG=chromium:884905
TEST=make buildall -j, which also include basic tests.
Change-Id: I8beac95430b2126f625a3981a9ebe038ab588212
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1599763
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,280 | 18.03.2020 02:12:20 | -28,800 | 6f84456a665b04f67beb2b0ec0b25c5838cd566e | asurada: board.h: add more section headings
TEST=make
BRANCH=master
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.h",
"new_path": "board/asurada/board.h",
"diff": "* Use of this source code is governed by a BSD-style license that can be\n* found in the LICENSE file.\n*/\n-/* Asurada development board configuration */\n+/* Asurada board configuration */... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: board.h: add more section headings
BUG=b:150341271
TEST=make
BRANCH=master
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I17063436ccce10304d8af46c7b2b5bf3575d97f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2107117
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,305 | 19.03.2020 12:35:16 | 21,600 | f6a87936b224620c18b58f45af5ef1a42e116561 | Waddledee: Configure DAC for PSYS
This commit configures the DAC module in the waddledee build and sets
up the PSYS output to use it.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define CONFIG_CHARGER_SM5803 /* C0 and C1: Charger */\n#define CONFIG_FPU /* For charger calculations */\n+ #define CONFIG_USB_PD_VBUS_DETECT_CHARGER\n+ #define CONFIG_USB_PD_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Configure DAC for PSYS
This commit configures the DAC module in the waddledee build and sets
up the PSYS output to use it.
BUG=b:149094279
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I1b08e46f25ec3f14924b0ed9da17a8cd213ddacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110534 |
136,305 | 19.03.2020 14:22:17 | 21,600 | 002db692bc570732d5a2c347085d71bec77c1402 | Waddledee: Set up ADC thresholds for PP3300_A_PGOOD
This configures the ADC threshold interrupts for ITE dedede variants,
and has them set the baseboard pp3300_a_pgood flag.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define I2C_ADDR_EEPROM_FLAGS 0x50\n+ #define CONFIG_ADC_VOLTAGE_COMPARATOR /* ITE ADC thresholds */\n+\n#define CONFIG_CHARGER_SM5803 /* C0 and C1: Charger */\n#define CONFIG_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Set up ADC thresholds for PP3300_A_PGOOD
This configures the ADC threshold interrupts for ITE dedede variants,
and has them set the baseboard pp3300_a_pgood flag.
BUG=b:149094481
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I0a0af6f8c7093a5ce3a618cf04d25b062e6a96d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2110975
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 23.03.2020 09:56:15 | 21,600 | 7107a70c8c583f128838fc48fef7a6ebbea91188 | SM5803: Configure lower TINT threshold
In order to detect when temperatures have returned to a good range and
cease AP throttling, add the lower TINT threshold.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.c",
"new_path": "driver/charger/sm5803.c",
"diff": "@@ -186,8 +186,11 @@ static void sm5803_init(int chgnum)\nrv |= meas_write8(chgnum, SM5803_REG_VBUS_HIGH_TH,\nSM5803_VBUS_HIGH_LEVEL);\n- /* Set TINT for 360K (steps are in 0.43K) */\n- ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Configure lower TINT threshold
In order to detect when temperatures have returned to a good range and
cease AP throttling, add the lower TINT threshold.
BUG=b:148289370
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Id8a22c4220539e3959cd2f831552f57ab12853fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2115569
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,200 | 24.03.2020 15:00:06 | -28,800 | f21d9520fb51508d24c2128c1bc4065b30fc7a0f | Ezkinil: Add redriver TUSB544 and PS8743 for Ezkinil
Setup usb_muxes for TUSB544 and PS8743.
BRANCH=ezkinil
TEST=verify USB is working. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define I2C_PORT_AP_HDMI NPCX_I2C_PORT7_0\n#define I2C_ADDR_EEPROM_FLAGS 0x50\n+#define PS8743_I2C_ADDR_FLAGS 0x11\n/* Sensors */\n#define CONFIG_MKBP_EVENT\n"
},
{
"change... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ezkinil: Add redriver TUSB544 and PS8743 for Ezkinil
Setup usb_muxes for TUSB544 and PS8743.
BUG=None
BRANCH=ezkinil
TEST=verify USB is working.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I606a571960bc0ff2634dd432573683e8d5631c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2115904
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,257 | 06.03.2020 10:10:49 | -28,800 | e7d7019dc5ecd064c42b5e081083c5a6e0d973b2 | kakadu: add new battery support for gauge max17055
Configure battery parameter for gauge max17055 on kakadu.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/battery_max17055.c",
"new_path": "baseboard/kukui/battery_max17055.c",
"diff": "#define TEMP_OUT_OF_RANGE TEMP_ZONE_COUNT\n+#ifdef BOARD_KAKADU\n+#define BATT_ID 1\n+#else\n#define BATT_ID 0\n+#endif\n#define BATTERY_SIMPLO_CHARGE_MIN_TEMP 0\n#... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: add new battery support for gauge max17055
Configure battery parameter for gauge max17055 on kakadu.
BUG=b:151899905
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Change-Id: I5253f248f0ec4dd0a8e41cf1609160d82212ee6e
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2089221
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,200 | 24.03.2020 15:21:41 | -28,800 | a88bd6dd2ce985f15cee44e95562639a4112f283 | Ezkinil: Add FSUSB42UMX driver
Add FSUSB42UMX support. This chip is used as SBU mux of usb
c0 port.
BRANCH=ezkinil
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/ezkinil/board.c",
"new_path": "board/ezkinil/board.c",
"diff": "@@ -168,6 +168,37 @@ const struct mft_t mft_channels[] = {\n};\nBUILD_ASSERT(ARRAY_SIZE(mft_channels) == MFT_CH_COUNT);\n+/*\n+ * USB C0 port SBU mux use standalone FSUSB42UMX\n+ * chip and ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ezkinil: Add FSUSB42UMX driver
Add FSUSB42UMX support. This chip is used as SBU mux of usb
c0 port.
BUG=none
BRANCH=ezkinil
TEST=make buildall -j
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I566723de6b996652dc611262b609c08fe0d4b124
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2115906
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,257 | 25.03.2020 23:02:07 | 14,400 | 39088753b33270156592866df2a21927f0f2b653 | damu: enable bit-bang for battery smbus
EC using PA5/PC4 as i2c pin for battery.
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=On board testing to wait until we receive proto1 board. | [
{
"change_type": "MODIFY",
"old_path": "board/damu/board.c",
"new_path": "board/damu/board.c",
"diff": "#include \"hooks.h\"\n#include \"host_command.h\"\n#include \"i2c.h\"\n+#include \"i2c_bitbang.h\"\n#include \"it8801.h\"\n#include \"keyboard_scan.h\"\n#include \"lid_switch.h\"\n@@ -73,6 +74,11 ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: enable bit-bang for battery smbus
EC using PA5/PC4 as i2c pin for battery.
BUG=b:152456966
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
TEST=On board testing to wait until we receive proto1 board.
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I0064b8fde634fc3824593102e5fe8bc64563b0d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120877
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,305 | 25.03.2020 14:55:19 | 21,600 | 4b0e42bf7402c899f3690ea0cbf4d157c41fab93 | SM5803: Clear Vbus source bits when setting charge mode
When either inhibiting charging from happening or enabling charging, the
bits in FLOW_REG1 which cause Vbus to be sourced should be cleared.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.c",
"new_path": "driver/charger/sm5803.c",
"diff": "@@ -290,23 +290,19 @@ static enum ec_error_list sm5803_set_mode(int chgnum, int mode)\nenum ec_error_list rv;\nint flow1_reg, flow2_reg;\n- rv = chg_read8(chgnum, SM5803_REG_FLOW1, &flow... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Clear Vbus source bits when setting charge mode
When either inhibiting charging from happening or enabling charging, the
bits in FLOW_REG1 which cause Vbus to be sourced should be cleared.
BUG=None
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I8713c50f7f6706882ecb9917bb329be22e0e1384
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2121199
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,443 | 29.02.2020 21:49:49 | 28,800 | 7bffc114e8f56cea32c04ac127092d29577894b8 | nucleo-h743zi: Enable blink example
BRANCH=none
TEST=make BOARD=nucleo-h743zi
# Flash to nucleo
# Check lights are counting in binary | [
{
"change_type": "MODIFY",
"old_path": "board/nucleo-h743zi/board.h",
"new_path": "board/nucleo-h743zi/board.h",
"diff": "#define CONFIG_CONSOLE_COMMAND_FLAGS\n#define CONFIG_RESTRICTED_CONSOLE_COMMANDS\n+/*\n+ * Enable the blink example that exercises the LEDs.\n+ */\n+#define CONFIG_BLINK\n+#defin... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nucleo-h743zi: Enable blink example
BRANCH=none
BUG=none
TEST=make BOARD=nucleo-h743zi
# Flash to nucleo
# Check lights are counting in binary
Signed-off-by: Craig Hesling <hesling@chromium.org>
Change-Id: I66ff4e9f6a0af1922ec5c54c0f154e6f66d65435
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2082075
Reviewed-by: Jett Rink <jettrink@chromium.org>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org> |
136,190 | 07.02.2020 15:13:51 | 28,800 | d4bc8b52d0562e1a05baea2531f735f5e3b723f4 | usb_pd: Move cable communication functions to common file
BRANCH=none
TEST=Verified on TCPMV1 and TCPMv2, able to get correct
cable characteristics. | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_alt_mode_dfp.c",
"new_path": "common/usb_pd_alt_mode_dfp.c",
"diff": "@@ -437,6 +437,53 @@ void usb_mux_set_safe_mode(int port)\nppc_set_sbu(port, 0);\n}\n+bool is_vdo_present(int cnt, int index)\n+{\n+ return cnt > index;\n+}\n+\n+/*\n+ * ######... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | usb_pd: Move cable communication functions to common file
BUG=b:148528713
BRANCH=none
TEST=Verified on TCPMV1 and TCPMv2, able to get correct
cable characteristics.
Change-Id: I812b21c87661952bf4e86acaa194d4b136371594
Signed-off-by: Ayushee <ayushee.shah@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2051628
Reviewed-by: Diana Z <dzigterman@chromium.org>
Reviewed-by: Vijay P Hiremath <vijay.p.hiremath@intel.com> |
136,230 | 27.03.2020 11:48:41 | 25,200 | a849c04ef246554480ce6b048720a38006998d68 | docs: Add factory quick guide to sitemap
BRANCH=none
TEST=View Markdown in gitiles
Tested-by: Tom Hughes | [
{
"change_type": "MODIFY",
"old_path": "docs/sitemap.md",
"new_path": "docs/sitemap.md",
"diff": "* [EC Acronyms and Technologies](./ec_terms.md)\n## EC Bringup\n+\n* [New Board Checklist](./new_board_checklist.md)\n## Case Closed Debugging (CCD)\n* [FPMCU Debugging](./fingerprint/fingerprint-debugg... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Add factory quick guide to sitemap
BUG=none
BRANCH=none
TEST=View Markdown in gitiles
Change-Id: I047797c977643cf1c5a3b87c8573ddcbce963f63
Signed-off-by: Philip Chen <philipchen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124877
Reviewed-by: Tom Hughes <tomhughes@chromium.org>
Commit-Queue: Tom Hughes <tomhughes@chromium.org>
Tested-by: Tom Hughes <tomhughes@chromium.org> |
136,427 | 27.03.2020 20:11:43 | 21,600 | 9f3ade325ef2111c078009e2d223e33f1abac871 | Morphius/Ezkinil: Remove Trembyle V0 HW support.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/ezkinil/board.c",
"new_path": "board/ezkinil/board.c",
"diff": "@@ -120,26 +120,8 @@ unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors);\n#endif /* HAS_TASK_MOTIONSENSE */\n-/* These GPIOs moved. Temporarily detect and support the V0 HW. */\n-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Morphius/Ezkinil: Remove Trembyle V0 HW support.
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I618a0ca9de0e767f47084527a11b56e10210223b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2125587
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,427 | 27.03.2020 20:28:18 | 21,600 | 3fd849f1ba5c22836d3c23bce213dc87f87bcb36 | Zork: Clean up FW_CONFIG hook functions
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.c",
"new_path": "baseboard/zork/baseboard.c",
"diff": "@@ -566,11 +566,6 @@ static void cbi_init(void)\nccprints(\"FW Config: not set in cbi\");\nelse\nccprints(\"FW Config: %d (0x%x)\", val, val);\n-\n-#ifdef HAS_TASK_MOTIONSENSE\n- b... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zork: Clean up FW_CONFIG hook functions
BUG=b:150239200
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I01238a98e17cd0a6320986e12bba32c08e1244fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2125588
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,257 | 30.03.2020 08:58:49 | -28,800 | 68048d1f5846ab6894c1a434d15ddca06c738b24 | damu: reduce bitbang failrate
apply CL:2050003 to damu.
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/damu/board.c",
"new_path": "board/damu/board.c",
"diff": "@@ -97,8 +97,8 @@ struct keyboard_scan_config keyscan_config = {\n.output_settle_us = 35,\n.debounce_down_us = 5 * MSEC,\n.debounce_up_us = 40 * MSEC,\n- .scan_period_us = 3 * MSEC,\n- .min_post_s... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | damu: reduce bitbang failrate
apply CL:2050003 to damu.
BUG=b:152456966
BRANCH=kukui
TEST=make -j BOARD=damu
TEST=make buildall
Change-Id: I397b8e2ae548080e4d6d3cd75f3e57b10080f09a
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2124431
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,282 | 27.03.2020 16:31:25 | -28,800 | 997429577782ae07e87cc5a1a8883d65725679d9 | dratini: change thermal configuration for PVT
BRANCH=firmware-hatch-12672.B
TEST=manually remove dptf control then do following:
make sure system shutdown when over 80 degree with temp sensor 1. | [
{
"change_type": "MODIFY",
"old_path": "board/dratini/board.c",
"new_path": "board/dratini/board.c",
"diff": "@@ -345,7 +345,7 @@ const static struct ec_thermal_config thermal_a = {\n.temp_host = {\n[EC_TEMP_THRESH_WARN] = 0,\n[EC_TEMP_THRESH_HIGH] = C_TO_K(73),\n- [EC_TEMP_THRESH_HALT] = C_TO_K(75)... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dratini: change thermal configuration for PVT
BUG=b:152695211
BRANCH=firmware-hatch-12672.B
TEST=manually remove dptf control then do following:
make sure system shutdown when over 80 degree with temp sensor 1.
Change-Id: Idf5ee08ed58239239aa9d7b326b8fcf2be5946b9
Signed-off-by: Devin Lu <Devin.Lu@quantatw.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2123625
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,427 | 30.03.2020 18:00:08 | 21,600 | f74b98accc39b60f8c95746d04aae2b5b89efe40 | trembyle: LED_FULL is blue, not green
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/trembyle/led.c",
"new_path": "board/trembyle/led.c",
"diff": "@@ -15,17 +15,17 @@ const int led_charge_lvl_1;\nconst int led_charge_lvl_2 = 100;\nstruct led_descriptor led_bat_state_table[LED_NUM_STATES][LED_NUM_PHASES] = {\n- [STATE_CHARGING_LVL_1] = {{... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | trembyle: LED_FULL is blue, not green
BUG=b:146085773
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Icdbccb6df2ba5320fa7a5eb8227952520354509b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2128890
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,437 | 01.04.2020 09:52:52 | -28,800 | ced16b95b2ada60c38b07b905b94ed9d236e78fb | dalboz: use physical pin to generate SCI to SOC
Use physical pin (GPIO) to generate SCI to SOC.
BRANCH=none
TEST=build and boot dalboz, console command 'tabletmode on' and
'tabletmode off' work well. | [
{
"change_type": "MODIFY",
"old_path": "board/dalboz/board.h",
"new_path": "board/dalboz/board.h",
"diff": "/* GPIO mapping from board specific name to EC common name. */\n#define CONFIG_BATTERY_PRESENT_GPIO GPIO_EC_BATT_PRES_ODL\n+#define CONFIG_SCI_GPIO GPIO_EC_FCH_SCI_ODL\n#define GPIO_AC_PRESENT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dalboz: use physical pin to generate SCI to SOC
Use physical pin (GPIO) to generate SCI to SOC.
BUG=b:152820928, b:150239200
BRANCH=none
TEST=build and boot dalboz, console command 'tabletmode on' and
'tabletmode off' work well.
Change-Id: I2f8396891c2be58f2518a2c8d33ed5f55cd08d3b
Signed-off-by: Paul Ma <magf@bitland.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130147
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,256 | 31.03.2020 13:45:53 | 21,600 | b5bfa22ec42b7936d02821b0e50c1cf91fb7f279 | cleanup: correct max port count on test
Looking at code, we only test one port, so make the test
defines match the test code
BRANCH=none
TEST=all tests pass | [
{
"change_type": "MODIFY",
"old_path": "test/test_config.h",
"new_path": "test/test_config.h",
"diff": "@@ -312,7 +312,7 @@ int ncp15wb_calculate_temp(uint16_t adc);\n#endif\n#if defined(TEST_USB_PRL)\n-#define CONFIG_USB_PD_PORT_MAX_COUNT 2\n+#define CONFIG_USB_PD_PORT_MAX_COUNT 1\n#define CONFIG_U... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | cleanup: correct max port count on test
Looking at code, we only test one port, so make the test
defines match the test code
BRANCH=none
BUG=none
TEST=all tests pass
Change-Id: I0b793425e20678173f3ec52fdcff4567f0b8ccb4
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131047
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,256 | 31.03.2020 13:43:03 | 21,600 | dec09934db166678c573c25b405cbfcaea426445 | test: add better test prints
Update test runner and mux mock to print information
with tags
Also print out when a test passes for easier debugging
BRANCH=none]
TEST=used in child CL | [
{
"change_type": "MODIFY",
"old_path": "common/mock/usb_mux_mock.c",
"new_path": "common/mock/usb_mux_mock.c",
"diff": "@@ -27,7 +27,7 @@ static int mock_set(const struct usb_mux *me, mux_state_t mux_state)\n{\nmock_usb_mux.state = mux_state;\n++mock_usb_mux.num_set_calls;\n- ccprints(\"Called into ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: add better test prints
Update test runner and mux mock to print information
with tags
Also print out when a test passes for easier debugging
BRANCH=none]
BUG=none
TEST=used in child CL
Change-Id: I29a1193831239c160cf75be20380e677936ba9d8
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131048
Reviewed-by: Diana Z <dzigterman@chromium.org> |
136,297 | 01.04.2020 15:13:14 | -32,400 | 34dfe4c7df343eb656955c8f0ab230c1b450d7e7 | nightfury : Enable PWM and Tach for Fan
Enable PWM and Tach to control fan
BRANCH=firmware-hatch-12672.B
TEST=make -j BOARD=nightfury | [
{
"change_type": "MODIFY",
"old_path": "board/nightfury/board.c",
"new_path": "board/nightfury/board.c",
"diff": "@@ -316,9 +316,9 @@ const struct fan_conf fan_conf_0 = {\n/* Default */\nconst struct fan_rpm fan_rpm_0 = {\n- .rpm_min = 3100,\n- .rpm_start = 3100,\n- .rpm_max = 6900,\n+ .rpm_min = 10... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | nightfury : Enable PWM and Tach for Fan
Enable PWM and Tach to control fan
BUG=b:149226871
BRANCH=firmware-hatch-12672.B
TEST=make -j BOARD=nightfury
Signed-off-by: YongBeum.Ha <ybha@samsung.corp-partner.google.com>
Change-Id: I9ce748d81c1015565a37b2fb0d29792df4a8997a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130148
Reviewed-by: Bob Moragues <moragues@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,269 | 02.04.2020 10:23:14 | 25,200 | 697b49ae69ae35e1df9188e2c6f4df07b0cdc2cc | docs: Run mdformat on case_closed_debugging.md
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/case_closed_debugging.md",
"new_path": "docs/case_closed_debugging.md",
"diff": "-Case Closed Debugging (CCD)\n-===========================\n+# Case Closed Debugging (CCD)\nCase closed debugging is a feature of the EC codebase that can bridge UART\nconsol... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs: Run mdformat on case_closed_debugging.md
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Id55665d87e80a472af61f0ccb7ecb8bc097ebb3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2134646
Reviewed-by: Furquan Shaikh <furquan@chromium.org> |
136,256 | 31.03.2020 13:42:07 | 21,600 | 47f4e1bb56535e5e24785497ef48bae5cca10419 | mock: add callback functionality to tcpc mock
Also update prints functionality to make tests easier
to see what is happening
BRANCH=none
TEST=use mock in child CL | [
{
"change_type": "MODIFY",
"old_path": "common/mock/tcpc_mock.c",
"new_path": "common/mock/tcpc_mock.c",
"diff": "#include \"common.h\"\n#include \"console.h\"\n-#include \"usb_pd_tcpm.h\"\n-#include \"mock/tcpc_mock.h\"\n#include \"memory.h\"\n+#include \"mock/tcpc_mock.h\"\n+#include \"tests/enum_... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | mock: add callback functionality to tcpc mock
Also update prints functionality to make tests easier
to see what is happening
BRANCH=none
BUG=b:153071799
TEST=use mock in child CL
Change-Id: Ia9cfeeff220e3255e6fc0aa41f0795df3b1920e4
Signed-off-by: Jett Rink <jettrink@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131049
Commit-Queue: LaMont Jones <lamontjones@chromium.org> |
136,256 | 31.03.2020 13:59:09 | 21,600 | a08de50a749ab4ec09ad2b7b32b1605f49d8a5c6 | test: isolate tc_drp test cases better
Ensure that state between test cases is getting fully cleared between
different test cases
BRANCH=none
TEST=child CL pass when commenting various tests out without issue | [
{
"change_type": "MODIFY",
"old_path": "common/mock/tcpc_mock.c",
"new_path": "common/mock/tcpc_mock.c",
"diff": "@@ -16,12 +16,13 @@ struct mock_tcpc_ctrl mock_tcpc;\nvoid mock_tcpc_reset(void)\n{\n- /* Reset all control values to 0 */\n+ /* Reset all control values to 0. See also build assert belo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: isolate tc_drp test cases better
Ensure that state between test cases is getting fully cleared between
different test cases
BRANCH=none
BUG=b:153071799
TEST=child CL pass when commenting various tests out without issue
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: I7628d580c5c16bc404694a93ecc2418241d432b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131050
Reviewed-by: LaMont Jones <lamontjones@chromium.org> |
136,256 | 31.03.2020 14:05:15 | 21,600 | 2c3cc23589fb9cb2884d2c0a8bb776d962b023f8 | test: add tc_drp tests
Add polarity tests
Add try source tests
Add no try source test
BRANCH=none
TEST=all unit tests pass | [
{
"change_type": "MODIFY",
"old_path": "test/usb_typec_drp_acc_trysrc.c",
"new_path": "test/usb_typec_drp_acc_trysrc.c",
"diff": "#define PORT0 0\n+/*\n+ * Amount of time to wait after a specified timeout. Allows for an extra loop\n+ * through statemachine plus 1000 calls to clock\n+ */\n+#define FU... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | test: add tc_drp tests
Add polarity tests
Add try source tests
Add no try source test
BRANCH=none
BUG=b:153071799
TEST=all unit tests pass
Signed-off-by: Jett Rink <jettrink@chromium.org>
Change-Id: Ib3d8b6afa2e8fdd80642e026deb4322e2c3e1e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2132872 |
136,305 | 28.03.2020 22:15:44 | 21,600 | 2e268611ee4a42d202492df59584c5b08567ad22 | PD: Rename pd_policy to pd_discovery
Rename struct pd_policy to struct pd_discovery to more
accurately reflect what the structure contains.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_alt_mode_dfp.c",
"new_path": "common/usb_pd_alt_mode_dfp.c",
"diff": "@@ -48,11 +48,11 @@ __overridable const struct svdm_response svdm_rsp = {\nstatic int pd_get_mode_idx(int port, uint16_t svid)\n{\nint i;\n- struct pd_policy *pe = pd_get_am_po... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | PD: Rename pd_policy to pd_discovery
Rename struct pd_policy to struct pd_discovery to more
accurately reflect what the structure contains.
BRANCH=None
BUG=b:152417977
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I51de48103053aa60b3cdb15cf9fbf15dd75d727a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2130473
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,427 | 31.03.2020 16:09:28 | 21,600 | 68968cab21ac0c89322e44bddc18988f037ae7b2 | Zork: avoid losing edges from MST hub to DP1_HPD
BRANCH=none
TEST=scope shows 1ms HPD pulses preserved by EC | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/variant_trembyle.c",
"new_path": "baseboard/zork/variant_trembyle.c",
"diff": "@@ -133,7 +133,10 @@ static void mst_hpd_handler(void)\n{\nint hpd = 0;\n- /* Pass HPD through from DB OPT3 MST hub to AP's DP1. */\n+ /*\n+ * Ensure level on GPIO_DP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zork: avoid losing edges from MST hub to DP1_HPD
BUG=b:152512560
BRANCH=none
TEST=scope shows 1ms HPD pulses preserved by EC
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I37c983385582955f31f24aed65b4b2c5b15e93ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2131051
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,295 | 20.03.2020 14:51:02 | -28,800 | 62e4ff1b2ace788736a37e7fc26b297bd8954eb5 | zork: move thermal setting to variant
This CL move thermal setting from baseboard to variant.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/variant_trembyle.c",
"new_path": "baseboard/zork/variant_trembyle.c",
"diff": "@@ -67,64 +67,6 @@ struct ioexpander_config_t ioex_config[] = {\nBUILD_ASSERT(ARRAY_SIZE(ioex_config) == USBC_PORT_COUNT);\nBUILD_ASSERT(CONFIG_IO_EXPANDER_PORT_COUNT... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | zork: move thermal setting to variant
This CL move thermal setting from baseboard to variant.
BUG=b:153277249
BRANCH=none
TEST=make buildall
Change-Id: I456a00f2b72a079b875267bfa0a56dc7f87b7f9b
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120765
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,427 | 03.04.2020 23:53:58 | 21,600 | c5242b3d910f611493e93ab11dddc2ae236dfa59 | config: Rename CONFIG_I2C_PASSTHROUGH to CONFIG_SB_PASSTHROUGH
It only enables smart battery pass-through host commands,
and has no effect on EC_CMD_I2C_PASSTHRU.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "driver/battery/smart.c",
"new_path": "driver/battery/smart.c",
"diff": "@@ -566,7 +566,7 @@ DECLARE_CONSOLE_COMMAND(battmfgacc, command_batt_mfg_access_read,\n/*****************************************************************************/\n/* Smart battery pas... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | config: Rename CONFIG_I2C_PASSTHROUGH to CONFIG_SB_PASSTHROUGH
It only enables smart battery pass-through host commands,
and has no effect on EC_CMD_I2C_PASSTHRU.
BUG=none
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: If391545623d28fb7ef772fca7c38d7b0afafcb06
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2136527
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org> |
136,295 | 06.04.2020 17:03:13 | -28,800 | cc781aaeb1c56bac803bf625dcd51386105113e4 | morphius: add thermal control table
This CL add thermal control table for morphius.
BRANCH=none
TEST=make sure fan RPM match fan curve table. | [
{
"change_type": "MODIFY",
"old_path": "board/morphius/board.c",
"new_path": "board/morphius/board.c",
"diff": "@@ -278,9 +278,9 @@ const struct fan_conf fan_conf_0 = {\n.enable_gpio = -1,\n};\nconst struct fan_rpm fan_rpm_0 = {\n- .rpm_min = 3100,\n- .rpm_start = 3100,\n- .rpm_max = 6900,\n+ .rpm_m... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | morphius: add thermal control table
This CL add thermal control table for morphius.
BUG=b:153277249
BRANCH=none
TEST=make sure fan RPM match fan curve table.
Signed-off-by: Zick Wei <zick.wei@quanta.corp-partner.google.com>
Change-Id: Ia16611b9ce0aaff10e768e7fdcea2d7f6021c029
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2137193
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,269 | 08.04.2020 13:25:16 | 25,200 | f327ba4fcf20a314bba988b7aac778bbaf94101c | docs/fingerprint: Make power its own section
BRANCH=none
TEST=view in gitiles | [
{
"change_type": "MODIFY",
"old_path": "docs/fingerprint/fingerprint-dev-for-partners.md",
"new_path": "docs/fingerprint/fingerprint-dev-for-partners.md",
"diff": "@@ -324,20 +324,21 @@ Start a fingerprint enrollment:\n> fpenroll\n```\n-The Dragonclaw reference board has an onboard INA that monitors... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | docs/fingerprint: Make power its own section
BRANCH=none
BUG=none
TEST=view in gitiles
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: If8b15ac197f1e18eb85b30b9fa29023a20e02ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2140923
Commit-Queue: Craig Hesling <hesling@chromium.org>
Reviewed-by: Craig Hesling <hesling@chromium.org> |
136,305 | 07.04.2020 15:14:07 | 21,600 | 4d39614441258dc5788c2a55000abe56ac43d3fe | Waddledee: Add more LED colors
Add more colors for the RGB LED to produce.
BRANCH=None
TEST=with ledtest command enabled, set LED to each new color to confirm
it looks like the named color | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/led.c",
"new_path": "board/waddledee/led.c",
"diff": "@@ -24,9 +24,9 @@ struct pwm_led led_color_map[EC_LED_COLOR_COUNT] = {\n[EC_LED_COLOR_RED] = { 100, 0, 0 },\n[EC_LED_COLOR_GREEN] = { 0, 100, 0 },\n[EC_LED_COLOR_BLUE] = { 0, 0, 100 },\n- [E... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Add more LED colors
Add more colors for the RGB LED to produce.
BUG=None
BRANCH=None
TEST=with ledtest command enabled, set LED to each new color to confirm
it looks like the named color
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Iab86e7236796c52948f7e055c69b29b72473d7cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142560
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,418 | 26.03.2020 15:57:07 | 25,200 | 1fa8c8eb918d7f7fd136bd31a3ac24f88b34cb6d | Lazor: Support tablet mode
Add functions to support tablet mode:
* Lid acceleration definitions
* TABLET_MODE_L interrupt
* Lid angle detection that disables keyboard
BRANCH=None
TEST=Built the Lazor image successfully. | [
{
"change_type": "MODIFY",
"old_path": "board/lazor/board.c",
"new_path": "board/lazor/board.c",
"diff": "#include \"charge_manager.h\"\n#include \"charge_state.h\"\n#include \"extpower.h\"\n+#include \"driver/accel_kionix.h\"\n#include \"driver/accelgyro_bmi160.h\"\n#include \"driver/ppc/sn5s330.h\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Lazor: Support tablet mode
Add functions to support tablet mode:
* Lid acceleration definitions
* TABLET_MODE_L interrupt
* Lid angle detection that disables keyboard
BRANCH=None
BUG=b:150793669
TEST=Built the Lazor image successfully.
Change-Id: I2622bdb1c4899f70b8dd1321b33cac9306fd4abb
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2122838
Reviewed-by: Alexandru M Stan <amstan@chromium.org> |
136,418 | 26.09.2019 11:01:50 | 25,200 | b4acf41a01a174d02cdbf487b9b4525b2ffe0aa9 | ps8742: Add support of PS8742 Type-C SS/DP demux
Add PS8742 related definition to the PS874X series. Better reuse some
common definition. Some following patches will it.
BRANCH=servo
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "driver/build.mk",
"new_path": "driver/build.mk",
"diff": "@@ -159,6 +159,7 @@ driver-$(CONFIG_USB_MUX_IT5205)+=usb_mux/it5205.o\ndriver-$(CONFIG_USB_MUX_PI3USB30532)+=usb_mux/pi3usb3x532.o\ndriver-$(CONFIG_USB_MUX_PI3USB31532)+=usb_mux/pi3usb3x532.o\ndriver-$(... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ps8742: Add support of PS8742 Type-C SS/DP demux
Add PS8742 related definition to the PS874X series. Better reuse some
common definition. Some following patches will it.
BRANCH=servo
BUG=b:137219603
TEST=make buildall -j
Change-Id: I045fdf35f9b7c3aba2852140121e8c597465ddc7
Signed-off-by: Wai-Hong Tam <waihong@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1829757
Reviewed-by: Brian Nemec <bnemec@chromium.org> |
136,305 | 09.04.2020 16:34:41 | 21,600 | 382d22af0ffafba034f254276c5a6481ccbba1de | Waddledee: Call board init
Add the hook to call the board init function during init time.
BRANCH=None
TEST=on waddledee, add prints for the board init and confirm they are
called during startup | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/board.c",
"new_path": "board/waddledee/board.c",
"diff": "#include \"driver/tcpm/anx7447.h\"\n#include \"driver/usb_mux/it5205.h\"\n#include \"gpio.h\"\n+#include \"hooks.h\"\n#include \"intc.h\"\n#include \"keyboard_scan.h\"\n#include \"lid_sw... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Waddledee: Call board init
Add the hook to call the board init function during init time.
BRANCH=None
BUG=b:153398237
TEST=on waddledee, add prints for the board init and confirm they are
called during startup
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ia5b6701b1024e9f61707cf6710cceff0a18369c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2145073
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 09.04.2020 17:02:35 | 21,600 | 207082eb3ca62116e55c3a15d04b532db70026c3 | SM5803: Add open drain parameter to GPIO setup
Explicitly set GPIO0 to be open drain or not, depending on the
application needed.
BRANCH=None
TEST=on waddledee, redriver now inits and responds correctly | [
{
"change_type": "MODIFY",
"old_path": "board/waddledee/board.c",
"new_path": "board/waddledee/board.c",
"diff": "@@ -91,12 +91,12 @@ void board_init(void)\ngpio_enable_interrupt(GPIO_USB_C1_INT_ODL);\ngpio_enable_interrupt(GPIO_USB_C0_CCSBU_OVP_ODL);\n- /* Charger on the MB will be outputting PROCH... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Add open drain parameter to GPIO setup
Explicitly set GPIO0 to be open drain or not, depending on the
application needed.
BRANCH=None
BUG=b:153398237
TEST=on waddledee, redriver now inits and responds correctly
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Iaf6c66841a618ae5a522ad7f817dac3a5e0c755c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2145074
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,257 | 10.04.2020 10:45:29 | -28,800 | e0b4917a07f1a2ec4d0e1d363b2553314714a3ca | kakadu: remove als sensor
We don't support als sensor on kakadu.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/kakadu/board.c",
"new_path": "board/kakadu/board.c",
"diff": "@@ -314,60 +314,6 @@ static struct mutex g_lid_mutex;\nstatic struct lsm6dsm_data lsm6dsm_data = LSM6DSM_DATA;\n-/* TCS3400 private data */\n-static struct als_drv_data_t g_tcs3400_data = {\n-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: remove als sensor
We don't support als sensor on kakadu.
BUG=b:153699591
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I86318d7653858fb1066c89811c7f550f3d2a10d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142841
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,234 | 07.04.2020 12:40:30 | 25,200 | ee4b7135b0b474447d0c087691b84a6995c28764 | TCPMv1/v2: Move pd_prepare_sysjump() to common file
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_alt_mode_dfp.c",
"new_path": "common/usb_pd_alt_mode_dfp.c",
"diff": "#define PORT_TO_HPD(port) ((port) ? GPIO_USB_C1_DP_HPD : GPIO_USB_C0_DP_HPD)\n#endif /* PORT_TO_HPD */\n+/* Tracker for which task is waiting on sysjump prep to finish */\n+sta... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv1/v2: Move pd_prepare_sysjump() to common file
BUG=b:137493121
BRANCH=none
TEST=make buildall -j
Change-Id: I5123f26137d7590bcc00d86894eb981ac23d502a
Signed-off-by: Vijay Hiremath <vijay.p.hiremath@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2140534
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,279 | 09.04.2020 11:31:51 | -28,800 | 29bcae1e42b6e9b4d86b5ee4cb44cbbbe9995c85 | Volteer/baseboard: Move fan configure to variant
This CL move fan configure from baseboard to variant.
BRANCH=none
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/volteer/baseboard.c",
"new_path": "baseboard/volteer/baseboard.c",
"diff": "#include \"driver/tcpm/tcpci.h\"\n#include \"driver/tcpm/tusb422.h\"\n#include \"driver/temp_sensor/thermistor.h\"\n-#include \"fan.h\"\n-#include \"fan_chip.h\"\n#include \"... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Volteer/baseboard: Move fan configure to variant
This CL move fan configure from baseboard to variant.
BUG=none
BRANCH=none
TEST=make buildall
Change-Id: I5109a0b18e5e3f740db67c13cf6473ab2c926b42
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2142835
Reviewed-by: Ruby Lee <ruby_lee@compal.corp-partner.google.com>
Reviewed-by: Keith Short <keithshort@chromium.org> |
136,279 | 26.03.2020 10:17:10 | -28,800 | 5a94904f8b744690f96b388833fb1b96342acc2e | Halvor: Initial GPIO and CONFIG_* definitions
Update GPIO to match schematic.
First pass at CONFIG_* definitions.
Just enough [base]board.c changes to build.
BRANCH=none
TEST=make BOARD=halvor | [
{
"change_type": "MODIFY",
"old_path": "board/halvor/board.h",
"new_path": "board/halvor/board.h",
"diff": "#define GPIO_SYS_RESET_L GPIO_SYS_RST_ODL\n#define GPIO_WP_L GPIO_EC_WP_L\n#define GPIO_USB_C1_BC12_INT_ODL GPIO_USB_C1_MIX_INT_ODL\n-#define GPIO_VOLUME_UP_L GPIO_EC_VOLUP_BTN_ODL\n-#define G... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Halvor: Initial GPIO and CONFIG_* definitions
Update GPIO to match schematic.
First pass at CONFIG_* definitions.
Just enough [base]board.c changes to build.
BUG=none
BRANCH=none
TEST=make BOARD=halvor
Change-Id: Ic5b48581b860833e6d9e74600f807b4875862ad4
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2120757
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
136,257 | 13.04.2020 22:02:53 | -28,800 | f1d4d43109c8c97b2a84d58d4f2b3d871f8ba322 | kakadu: update battery parameter
When battery charge enter CV mode, it can be charged more power if the setting changed to 200.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/battery_max17055.c",
"new_path": "baseboard/kukui/battery_max17055.c",
"diff": "@@ -72,7 +72,7 @@ static const struct max17055_batt_profile batt_profile[] = {\n[BATTERY_ATL] = {\n.is_ez_config = 1,\n.design_cap = MAX17055_DESIGNCAP_REG(7270),\n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: update battery parameter
When battery charge enter CV mode, it can be charged more power if the setting changed to 200.
BUG=b:153832582
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: Ie2bdff88ca230a3f05458a9cb1b9a3fb546a7f15
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2145551
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,446 | 01.04.2020 17:50:44 | 25,200 | db664eaccf085e83e8495063655ac9cf871d8e29 | ec_commands.h: Add host command EC_CMD_GET_KEYBD_CONFIG
Add command to query the EC for the keyboard layout. Also
add supporting data structures for the exchange.
TEST=Build
BRANCH=firmware-hatch-12672.B | [
{
"change_type": "MODIFY",
"old_path": "include/ec_commands.h",
"new_path": "include/ec_commands.h",
"diff": "@@ -6057,6 +6057,84 @@ enum keyboard_button_type {\nKEYBOARD_BUTTON_COUNT\n};\n+/*****************************************************************************/\n+/*\n+ * \"Get the Keyboard C... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | ec_commands.h: Add host command EC_CMD_GET_KEYBD_CONFIG
Add command to query the EC for the keyboard layout. Also
add supporting data structures for the exchange.
BUG=b:146501925
TEST=Build
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: I7031196bc1f7f86e8dcd6baaa9fd967bef16d2e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2133824
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,451 | 14.04.2020 15:26:07 | -28,800 | c9d9c37e3e29b1833ed6e67d74d216eaaecfd2e4 | dalboz: add power led support
dalboz has a power led.
BRANCH=none
TEST=S0: on
S3: blink
S5: off | [
{
"change_type": "MODIFY",
"old_path": "board/dalboz/board.h",
"new_path": "board/dalboz/board.h",
"diff": "#define CONFIG_MKBP_USE_GPIO\n+/* Power LEDs */\n+#define CONFIG_LED_POWER_LED\n+\n/* Motion sensing drivers */\n#define CONFIG_ACCELGYRO_LSM6DSM\n#define CONFIG_ACCEL_LSM6DSM_INT_EVENT \\\n"
... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | dalboz: add power led support
dalboz has a power led.
BRANCH=none
BUG=none
TEST=S0: on
S3: blink
S5: off
Signed-off-by: Lu Zhang <lu.zhang@bitland.corp-partner.google.com>
Change-Id: Ic63f18cdf3ce697d2a1b612629c0c6067932e1d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2147767
Reviewed-by: Edward Hill <ecgh@chromium.org> |
136,311 | 14.04.2020 10:18:36 | 21,600 | c822930e96290fe8eff6e4ede10fe90693c70f4a | halvor: Update bug tracking USB-C features
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/halvor/board.c",
"new_path": "board/halvor/board.c",
"diff": "@@ -42,8 +42,8 @@ __override enum tbt_compat_cable_speed board_get_max_tbt_speed(int port)\n/*\n* Thunderbolt-compatible mode not supported\n*\n- * TODO (b/147726366): All the USB-C ports need... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | halvor: Update bug tracking USB-C features
BUG=b:153995632
BRANCH=none
TEST=make buildall -j
Change-Id: I283049e74073799ac086a16e801bd282817b5e94
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2149271
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org> |
136,311 | 14.04.2020 10:28:01 | 21,600 | 5af9101c093350b299ddac21039cf1671392299c | malefor: Update bug tracking USB-C features
BRANCH=none
TEST=make buildall -j | [
{
"change_type": "MODIFY",
"old_path": "board/malefor/board.c",
"new_path": "board/malefor/board.c",
"diff": "@@ -47,7 +47,7 @@ __override enum tbt_compat_cable_speed board_get_max_tbt_speed(int port)\n/*\n* Thunderbolt-compatible mode not supported\n*\n- * TODO (b/147726366): All the USB-C ports ne... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | malefor: Update bug tracking USB-C features
BUG=b:153996396
BRANCH=none
TEST=make buildall -j
Change-Id: I91091e8bb46ef986e8f0f3363e90107e86e928e0
Signed-off-by: Keith Short <keithshort@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2149273
Reviewed-by: Abe Levkoy <alevkoy@chromium.org>
Commit-Queue: Abe Levkoy <alevkoy@chromium.org> |
136,427 | 15.04.2020 11:57:53 | 21,600 | 3969b0c1fb8a169ca2cceaf77958c7f1668f1a55 | Zork: move PI3DPX1207 config out of baseboard
PI3DPX1207 config needs to be board specific.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#if defined(VARIANT_ZORK_TREMBYLE)\n#define CONFIG_USB_MUX_RUNTIME_CONFIG\n- #define CONFIG_USBC_RETIMER_PI3DPX1207\n#define CONFIG_USBC_RETIMER_PS8802\n#define CONFIG_USBC_RETIMER... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Zork: move PI3DPX1207 config out of baseboard
PI3DPX1207 config needs to be board specific.
BUG=b:144227077
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Ib2760f3786dabb5a14baab546d6320792e2d2e3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2150557
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,356 | 08.04.2020 17:20:44 | -28,800 | 2f6626d427eb6f3b9c2dc7406b152a85aa55b7b3 | Ezkinil: remove unused GPIO definition
remove unused GPIO pin defined in gpio.inc
BRANCH=none
TEST=make buildall -j
Tested-by: Edward Hill | [
{
"change_type": "MODIFY",
"old_path": "board/ezkinil/gpio.inc",
"new_path": "board/ezkinil/gpio.inc",
"diff": "@@ -46,7 +46,6 @@ GPIO(EC_SYS_RST_L, PIN(C, 7), GPIO_ODR_HIGH) /* Cold Reset to SOC */\nGPIO(USB_C0_TCPC_RST_L, PIN(E, 1), GPIO_OUT_HIGH) /* C0 TCPC Reset */\nGPIO(USB_C1_TCPC_RST_L, PIN(F... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ezkinil: remove unused GPIO definition
remove unused GPIO pin defined in gpio.inc
BUG=b:144227077
BRANCH=none
TEST=make buildall -j
Change-Id: I7ac7d63b2c124843d1ccdaada1838669f02d534b
Signed-off-by: Sue Chen <sue.chen@quanta.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2143071
Tested-by: Edward Hill <ecgh@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,427 | 15.04.2020 17:47:23 | 21,600 | 8ce48815d2b4522f171b5666ba3b974020380130 | Dalboz: Support PS8743 and PS8740 HW
BRANCH=none
TEST=PS8740 still works | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/baseboard.h",
"new_path": "baseboard/zork/baseboard.h",
"diff": "#define CONFIG_USBC_VCONN\n#define CONFIG_USBC_VCONN_SWAP\n#define CONFIG_USB_MUX_AMD_FP5\n+#define CONFIG_USB_MUX_RUNTIME_CONFIG\n#if defined(VARIANT_ZORK_TREMBYLE)\n- #define CON... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Dalboz: Support PS8743 and PS8740 HW
BUG=b:153454399
BRANCH=none
TEST=PS8740 still works
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: Iaf09c4986b3a03ee2bf4c2408f6dd61ea64388af
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2151648
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Commit-Queue: Denis Brockus <dbrockus@chromium.org> |
136,305 | 04.04.2020 23:52:45 | 21,600 | d9936b2edcb715950421f9ced02c92bb408b87c4 | TCPMv2: Configure PE test for alternate modes
Configures the TCPMv2 PE test to build the alternate mode code.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "test/fake_usbc.c",
"new_path": "test/fake_usbc.c",
"diff": "@@ -190,11 +190,6 @@ bool pd_is_disconnected(int port)\n#endif /* !CONFIG_USB_DRP_ACC_TRYSRC && !CONFIG_USB_CTVPD */\n#ifndef CONFIG_USB_DRP_ACC_TRYSRC\n-void dfp_consume_cable_response(int port, int ... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Configure PE test for alternate modes
Configures the TCPMv2 PE test to build the alternate mode code.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I4cb5824875e2a4b4e93fbae0a4d8762195b987f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2137258 |
136,200 | 16.04.2020 09:23:43 | -28,800 | f6bed060ec8abbf438c2f774525c23925ed0c2ba | Ezkinil: Set mux board tuning for TUSB544 and PS8743
Set correct mode and HPD_IN_DB for TUSB544/PS8743.
BRANCH=ezkinil
TEST=Check typec both side usb speed shows 5G in "lsusb -t" and display is
workable. | [
{
"change_type": "MODIFY",
"old_path": "baseboard/zork/variant_trembyle.c",
"new_path": "baseboard/zork/variant_trembyle.c",
"diff": "#include \"driver/retimer/tusb544.h\"\n#include \"driver/tcpm/nct38xx.h\"\n#include \"driver/usb_mux/amd_fp5.h\"\n-#include \"driver/usb_mux/ps8743.h\"\n#include \"fa... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Ezkinil: Set mux board tuning for TUSB544 and PS8743
Set correct mode and HPD_IN_DB for TUSB544/PS8743.
BUG=b:152736880
BRANCH=ezkinil
TEST=Check typec both side usb speed shows 5G in "lsusb -t" and display is
workable.
Signed-off-by: David Huang <david.huang@quanta.corp-partner.google.com>
Change-Id: I9b16e650f15eedbcd7b35b69fdfe93c3268942f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2141371
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,257 | 16.04.2020 13:24:35 | -28,800 | 4e463c4b9b1fcd2e89c82bb803517af0af5ba3e3 | kakadu: correct sensor orientation matrix
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
TEST=panel rotate correctly in OS. | [
{
"change_type": "MODIFY",
"old_path": "board/kakadu/board.c",
"new_path": "board/kakadu/board.c",
"diff": "@@ -315,8 +315,8 @@ static struct lsm6dsm_data lsm6dsm_data = LSM6DSM_DATA;\n/* Matrix to rotate accelerometer into standard reference frame */\nstatic const mat33_fp_t lid_standard_ref = {\n+... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: correct sensor orientation matrix
BUG=b:154159907
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
TEST=panel rotate correctly in OS.
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I6ec1adaf5878c646fac777d715a02fee9a59fa1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2152026
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,209 | 16.04.2020 16:47:45 | -36,000 | 9be9876341fff089adb4ee3645c02f8d612ac4c4 | Puff: Fix timer/GPIO assignments for fan tacho and HDMI CEC.
BRANCH=none
TEST=Check fan tacho.
Tested-by: Andrew McRae | [
{
"change_type": "MODIFY",
"old_path": "board/puff/board.c",
"new_path": "board/puff/board.c",
"diff": "@@ -354,7 +354,7 @@ BUILD_ASSERT(ARRAY_SIZE(fans) == FAN_CH_COUNT);\n/******************************************************************************/\n/* MFT channels. These are logically separate... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Puff: Fix timer/GPIO assignments for fan tacho and HDMI CEC.
BUG=b:152267803
BRANCH=none
TEST=Check fan tacho.
Signed-off-by: Andrew McRae <amcrae@google.com>
Change-Id: I993da17dd51dee7b3ffb174635346f6b9b1a51b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2152031
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Tested-by: Andrew McRae <amcrae@chromium.org>
Commit-Queue: Andrew McRae <amcrae@chromium.org> |
136,427 | 15.04.2020 21:23:09 | 21,600 | bed6cac7b4d68c4315f5426b741a6ee508e459c6 | PS8743: Clean up mode reg bit names
Align names for PS8743_REG_MODE with similar PS8802_REG2_MODE.
BRANCH=none
TEST=none | [
{
"change_type": "MODIFY",
"old_path": "board/ezkinil/board.c",
"new_path": "board/ezkinil/board.c",
"diff": "@@ -276,15 +276,11 @@ static int board_ps8743_mux_set(const struct usb_mux *me,\nrv = ps8743_read(me, PS8743_REG_MODE, ®);\nif (rv)\nreturn rv;\n- /*\n- * TODO(b:152736880) Due to Ezkinil... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | PS8743: Clean up mode reg bit names
Align names for PS8743_REG_MODE with similar PS8802_REG2_MODE.
BUG=b:152736880
BRANCH=none
TEST=none
Signed-off-by: Edward Hill <ecgh@chromium.org>
Change-Id: I8b8ebe41eb2bffad14cee8347549447d5583da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2151791
Reviewed-by: Denis Brockus <dbrockus@chromium.org> |
136,280 | 14.04.2020 15:49:12 | -28,800 | bdf0eb73c307be1287e5b63d737154ca3ec3d5de | jacuzzi: introduce VARIANT_KUKUI_JACUZZI
move common configs from jacuzzi derivatives into baseboard
TEST=make
BRANCH=kukui
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "baseboard/kukui/baseboard.h",
"new_path": "baseboard/kukui/baseboard.h",
"diff": "#define CONFIG_BASE_ATTACHED_SWITCH\n#endif\n+/* define this if the board is jacuzzi family */\n+#ifdef VARIANT_KUKUI_JACUZZI\n+#define CONFIG_IO_EXPANDER\n+#define CONFIG_IO_EXP... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | jacuzzi: introduce VARIANT_KUKUI_JACUZZI
move common configs from jacuzzi derivatives into baseboard
BUG=None
TEST=make
BRANCH=kukui
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: I5baf8c5bbb6520c324be4d30824b642141eeb331
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2147824
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org> |
136,257 | 16.04.2020 18:19:08 | -28,800 | c1c5a9393c054a6a49b23e7f2b11cc16442b897c | kakadu: update LED behavior
We don't support blue LED, so remove it.
And change LED brightness to 255.
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall | [
{
"change_type": "MODIFY",
"old_path": "board/kakadu/led.c",
"new_path": "board/kakadu/led.c",
"diff": "@@ -20,17 +20,15 @@ static enum charge_state prv_chstate = PWR_STATE_INIT;\n#define LED_OFF MT6370_LED_ID_OFF\n#define LED_RED MT6370_LED_ID1\n#define LED_GREEN MT6370_LED_ID2\n-#define LED_BLUE M... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | kakadu: update LED behavior
We don't support blue LED, so remove it.
And change LED brightness to 255.
BUG=b:152719659
BRANCH=kukui
TEST=make -j BOARD=kakadu
TEST=make buildall
Signed-off-by: Scott Chao <scott.chao@bitland.corp-partner.google.com>
Change-Id: I34e48fe9ea2475a0a07720606e38981b03612533
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2152033
Reviewed-by: Ting Shen <phoenixshen@chromium.org> |
136,305 | 09.04.2020 16:48:41 | 21,600 | 82065675d1a81520fe093db90257889711780911 | SM5803: Add new init parameters
Add parameters for initialization needed for 3S batteries on this
revision of silicon.
BRANCH=None
TEST=on waddledee, battery is able to charge through motherboard
without noticeable noise | [
{
"change_type": "MODIFY",
"old_path": "driver/charger/sm5803.c",
"new_path": "driver/charger/sm5803.c",
"diff": "#include \"i2c.h\"\n#include \"sm5803.h\"\n#include \"throttle_ap.h\"\n+#include \"timer.h\"\n#include \"usb_charge.h\"\n#ifndef CONFIG_CHARGER_NARROW_VDC\n@@ -176,6 +177,75 @@ static vo... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | SM5803: Add new init parameters
Add parameters for initialization needed for 3S batteries on this
revision of silicon.
BRANCH=None
BUG=b:153922818
TEST=on waddledee, battery is able to charge through motherboard
without noticeable noise
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I1f74d7929fa273cdd8ab0e195e6dca8c6cfa2c91
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2145075
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,305 | 13.04.2020 22:00:34 | 21,600 | bea99fdf5db6f7901bbfa7b5d467b0d13d06fc80 | PD: Store cable identity in pd_discovery structure
Stores SOP' cable response in pd_discovery identity array.
BRANCH=None
TEST=on kindred with TCPMv2, ensure "pe" command shows correct
information for cable and port partner | [
{
"change_type": "MODIFY",
"old_path": "common/usb_pd_alt_mode_dfp.c",
"new_path": "common/usb_pd_alt_mode_dfp.c",
"diff": "@@ -292,6 +292,7 @@ void dfp_consume_identity(int port, int cnt, uint32_t *payload)\nstruct pd_discovery *disc = pd_get_am_discovery(port);\nsize_t identity_size = MIN(sizeof(u... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | PD: Store cable identity in pd_discovery structure
Stores SOP' cable response in pd_discovery identity array.
BRANCH=None
BUG=b:152417977
TEST=on kindred with TCPMv2, ensure "pe" command shows correct
information for cable and port partner
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ia1186e25b92d9ae4f34e8c039b2ad1d1abbff9eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2148426
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,305 | 16.04.2020 21:46:50 | 21,600 | 91faf6ab44df50d49d0a428aebf744d6a4db3f23 | TCPMv2: Remove storage for SOP'' discovery
SOP'' cable plugs aren't required to respond to Discover Identity, so
removing storage for the SOP'' response.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "include/usb_pd.h",
"new_path": "include/usb_pd.h",
"diff": "@@ -366,7 +366,7 @@ enum pd_alternate_modes {\n/* Discover all SOP* communications when enabled */\n#ifdef CONFIG_USB_PD_DECODE_SOP\n-#define DISCOVERY_TYPE_COUNT (TCPC_TX_SOP_PRIME_PRIME + 1)\n+#defi... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | TCPMv2: Remove storage for SOP'' discovery
SOP'' cable plugs aren't required to respond to Discover Identity, so
removing storage for the SOP'' response.
BUG=b:152417977
BRANCH=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: Ic51e3ed647d5bca45848fb878698673b27591cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2155123
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,280 | 14.04.2020 16:50:57 | -28,800 | fee5ee977403bfc4bbd35a712dbed1d00d66a163 | asurada: enable battery / charger
TEST=boot on asurada, verify `chgstate` and `battery` looks good
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/battery.c",
"new_path": "board/asurada/battery.c",
"diff": "#include \"gpio.h\"\nconst struct board_batt_params board_battery_info[] = {\n- [BATTERY_DUMMY] = {\n+ [BATTERY_C235] = {\n+ .fuel_gauge = {\n+ .manuf_name = \"AS3GWRc3KA\",\n+ .device_n... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable battery / charger
BUG=b:150341271
TEST=boot on asurada, verify `chgstate` and `battery` looks good
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Icf1bda085307280ffb4bd96d22ed5e6e760a5336
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2148852
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Eric Yilun Lin <yllin@chromium.org> |
136,305 | 15.04.2020 16:10:18 | 21,600 | d2b73ad856c4ba697a2dfd8c4bf4263ffc18a5ce | Dedede: Move waddledee chips out of baseboard
Moves chip specifics (ex. charger, TCPC) from baseboard out to the
waddledee board files in anticipation of Wheelie.
BRANCH=None
TEST=make -j buildall | [
{
"change_type": "MODIFY",
"old_path": "baseboard/dedede/baseboard.h",
"new_path": "baseboard/dedede/baseboard.h",
"diff": "#define CONFIG_ADC_VOLTAGE_COMPARATOR /* ITE ADC thresholds */\n- #define CONFIG_CHARGER_SM5803 /* C0 and C1: Charger */\n- #define CONFIG_FPU /* For charger calculations */\n-... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Dedede: Move waddledee chips out of baseboard
Moves chip specifics (ex. charger, TCPC) from baseboard out to the
waddledee board files in anticipation of Wheelie.
BRANCH=None
BUG=None
TEST=make -j buildall
Signed-off-by: Diana Z <dzigterman@chromium.org>
Change-Id: I99bf33d683cc89e6508fbbe305cd0b4c05a53090
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2157949
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org> |
136,208 | 15.04.2020 09:46:10 | -28,800 | a628c8eecc6194c992cc17f54a339c0093a58d1f | asurada: enable keyboard
TEST=`ksstate on`, verify key press shows on ec console
BRANCH=none
Tested-by: Ting Shen | [
{
"change_type": "MODIFY",
"old_path": "board/asurada/board.h",
"new_path": "board/asurada/board.h",
"diff": "/* Chipset */\n/* Keyboard */\n-/*\n- * #define CONFIG_KEYBOARD_BOARD_CONFIG\n- * #define CONFIG_KEYBOARD_PROTOCOL_MKBP\n- * #define CONFIG_MKBP_USE_GPIO\n- */\n+#define CONFIG_CMD_KEYBOARD\... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | asurada: enable keyboard
BUG=b:150341271
TEST=`ksstate on`, verify key press shows on ec console
BRANCH=none
Change-Id: Iea6102caa085ba65498fc32f80d7a0c3cd51d17d
Signed-off-by: Ting Shen <phoenixshen@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2148987
Reviewed-by: Eric Yilun Lin <yllin@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org> |
136,446 | 01.04.2020 18:01:58 | 25,200 | f99e7c124fc064416cdb202463287ea767457244 | Jinlon: Initialize keyboard
Initialize the Jinlon keyboard configuration.
TEST=TEst the top row on Jinlon
BRANCH=firmware-hatch-12672.B | [
{
"change_type": "MODIFY",
"old_path": "board/jinlon/board.c",
"new_path": "board/jinlon/board.c",
"diff": "#include \"gpio.h\"\n#include \"hooks.h\"\n#include \"host_command.h\"\n+#include \"keyboard_8042.h\"\n#include \"lid_switch.h\"\n#include \"power.h\"\n#include \"power_button.h\"\n@@ -391,6 +... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Jinlon: Initialize keyboard
Initialize the Jinlon keyboard configuration.
BUG=b:146501925
TEST=TEst the top row on Jinlon
BRANCH=firmware-hatch-12672.B
Signed-off-by: Rajat Jain <rajatja@google.com>
Change-Id: Ib8ffdbd783126aa097c097dfc968c9d226ac042b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2135567
Reviewed-by: Jett Rink <jettrink@chromium.org> |
136,279 | 15.04.2020 14:37:53 | -28,800 | 246044881c894aac0f552e5218b8207f74d105f7 | Halvor: Add 3rd USB-C GPIO and interrupt function
Because Halvor is support three USB-C
So add the 3rd USB-C GPIO and interrupt function
BRANCH=none
TEST=make BOARD=halvor | [
{
"change_type": "MODIFY",
"old_path": "board/halvor/board.c",
"new_path": "board/halvor/board.c",
"diff": "@@ -113,3 +113,19 @@ const struct i2c_port_t i2c_ports[] = {\n},\n};\nconst unsigned int i2c_ports_used = ARRAY_SIZE(i2c_ports);\n+\n+/*********************************************************... | C | BSD 3-Clause New or Revised License | coreboot/chrome-ec | Halvor: Add 3rd USB-C GPIO and interrupt function
Because Halvor is support three USB-C
So add the 3rd USB-C GPIO and interrupt function
BUG=none
BRANCH=none
TEST=make BOARD=halvor
Change-Id: Ia4d4aa13f0a43f15f24d6d8321fd7a111fdb3ea5
Signed-off-by: Josh Tsai <josh_tsai@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2148982
Reviewed-by: Keith Short <keithshort@chromium.org>
Reviewed-by: Abe Levkoy <alevkoy@chromium.org> |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.