url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/2657
2,657
`to_json` reporting enhancements
While using `to_json` 2 things came to mind that would have made the experience easier on the user: 1. Could we have a `desc` arg for the tqdm use and a fallback to just `to_json` so that it'd be clear to the user what's happening? Surely, one can just print the description before calling json, but I thought perhaps...
open
2021-07-15T23:32:18
https://api.github.com/repos/huggingface/datasets/issues/2657/comments
null
false
`to_json` reporting enhancements While using `to_json` 2 things came to mind that would have made the experience easier on the user: 1. Could we have a `desc` arg for the tqdm use and a fallback to just `to_json` so that it'd be clear to the user what's happening? Surely, one can just print the description before ca...
[]
https://api.github.com/repos/huggingface/datasets/issues/2656
2,656
Change `from_csv` default arguments
Passing `sep=None` to pandas's `read_csv` lets pandas guess the CSV file's separator This PR allows users to use this pandas's feature by passing `sep=None` to `Dataset.from_csv`: ```python Dataset.from_csv( ..., sep=None ) ```
closed
2021-07-15T14:09:06
https://api.github.com/repos/huggingface/datasets/issues/2656/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2656", "html_url": "https://github.com/huggingface/datasets/pull/2656", "diff_url": "https://github.com/huggingface/datasets/pull/2656.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2656.patch", "merged_at": null }
true
Change `from_csv` default arguments Passing `sep=None` to pandas's `read_csv` lets pandas guess the CSV file's separator This PR allows users to use this pandas's feature by passing `sep=None` to `Dataset.from_csv`: ```python Dataset.from_csv( ..., sep=None ) ```
[ "This is not the default in pandas right ?\r\nWe try to align our CSV loader with the pandas API.\r\n\r\nMoreover according to their documentation, the python parser is used when sep is None, which might not be the fastest one.\r\n\r\nMaybe users could just specify `sep=None` themselves ?\r\nIn this case we should ...
https://api.github.com/repos/huggingface/datasets/issues/2655
2,655
Allow the selection of multiple columns at once
**Is your feature request related to a problem? Please describe.** Similar to pandas, it would be great if we could select multiple columns at once. **Describe the solution you'd like** ```python my_dataset = ... # Has columns ['idx', 'sentence', 'label'] idx, label = my_dataset[['idx', 'label']] ``` **...
closed
2021-07-15T13:30:45
https://api.github.com/repos/huggingface/datasets/issues/2655/comments
null
false
Allow the selection of multiple columns at once **Is your feature request related to a problem? Please describe.** Similar to pandas, it would be great if we could select multiple columns at once. **Describe the solution you'd like** ```python my_dataset = ... # Has columns ['idx', 'sentence', 'label'] idx,...
[ "Hi! I was looking into this and hope you can clarify a point. Your my_dataset variable would be of type DatasetDict which means the alternative you've described (dict comprehension) is what makes sense. \r\nIs there a reason why you wouldn't want to convert my_dataset to a pandas df if you'd like to use it like on...
https://api.github.com/repos/huggingface/datasets/issues/2654
2,654
Give a user feedback if the dataset he loads is streamable or not
**Is your feature request related to a problem? Please describe.** I would love to know if a `dataset` is with the current implementation streamable or not. **Describe the solution you'd like** We could show a warning when a dataset is loaded with `load_dataset('...',streaming=True)` when its lot streamable, e.g....
open
2021-07-15T09:07:27
https://api.github.com/repos/huggingface/datasets/issues/2654/comments
null
false
Give a user feedback if the dataset he loads is streamable or not **Is your feature request related to a problem? Please describe.** I would love to know if a `dataset` is with the current implementation streamable or not. **Describe the solution you'd like** We could show a warning when a dataset is loaded with ...
[ "#self-assign", "I understand it already raises a `NotImplementedError` exception, eg:\r\n\r\n```\r\n>>> dataset = load_dataset(\"journalists_questions\", name=\"plain_text\", split=\"train\", streaming=True)\r\n\r\n[...]\r\nNotImplementedError: Extraction protocol for file at https://drive.google.com/uc?export=d...
https://api.github.com/repos/huggingface/datasets/issues/2653
2,653
Add SD task for SUPERB
Include the SD (Speaker Diarization) task as described in the [SUPERB paper](https://arxiv.org/abs/2105.01051) and `s3prl` [instructions](https://github.com/s3prl/s3prl/tree/master/s3prl/downstream#sd-speaker-diarization). Steps: - [x] Generate the LibriMix corpus - [x] Prepare the corpus for diarization - [x] Up...
closed
2021-07-15T07:51:40
https://api.github.com/repos/huggingface/datasets/issues/2653/comments
null
false
Add SD task for SUPERB Include the SD (Speaker Diarization) task as described in the [SUPERB paper](https://arxiv.org/abs/2105.01051) and `s3prl` [instructions](https://github.com/s3prl/s3prl/tree/master/s3prl/downstream#sd-speaker-diarization). Steps: - [x] Generate the LibriMix corpus - [x] Prepare the corpus fo...
[ "Note that this subset requires us to:\r\n\r\n* generate the LibriMix corpus from LibriSpeech\r\n* prepare the corpus for diarization\r\n\r\nAs suggested by @lhoestq we should perform these steps locally and add the prepared data to this public repo on the Hub: https://huggingface.co/datasets/superb/superb-data\r\n...
https://api.github.com/repos/huggingface/datasets/issues/2652
2,652
Fix logging docstring
Remove "no tqdm bars" from the docstring in the logging module to align it with the changes introduced in #2534.
closed
2021-07-14T23:19:58
https://api.github.com/repos/huggingface/datasets/issues/2652/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2652", "html_url": "https://github.com/huggingface/datasets/pull/2652", "diff_url": "https://github.com/huggingface/datasets/pull/2652.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2652.patch", "merged_at": "2021-07-15T09:57...
true
Fix logging docstring Remove "no tqdm bars" from the docstring in the logging module to align it with the changes introduced in #2534.
[]
https://api.github.com/repos/huggingface/datasets/issues/2651
2,651
Setting log level higher than warning does not suppress progress bar
## Describe the bug I would like to disable progress bars for `.map` method (and other methods like `.filter` and `load_dataset` as well). According to #1627 one can suppress it by setting log level higher than `warning`, however doing so doesn't suppress it with version 1.9.0. I also tried to set `DATASETS_VERBOS...
closed
2021-07-14T21:06:51
https://api.github.com/repos/huggingface/datasets/issues/2651/comments
null
false
Setting log level higher than warning does not suppress progress bar ## Describe the bug I would like to disable progress bars for `.map` method (and other methods like `.filter` and `load_dataset` as well). According to #1627 one can suppress it by setting log level higher than `warning`, however doing so doesn't su...
[ "Hi,\r\n\r\nyou can suppress progress bars by patching logging as follows:\r\n```python\r\nimport datasets\r\nimport logging\r\ndatasets.logging.get_verbosity = lambda: logging.NOTSET\r\n# map call ...\r\n```\r\nEDIT: now you have to use `disable_progress_bar `", "Thank you, it worked :)", "See https://github.c...
https://api.github.com/repos/huggingface/datasets/issues/2650
2,650
[load_dataset] shard and parallelize the process
- Some huge datasets take forever to build the first time. (e.g. oscar/en) as it's done in a single cpu core. - If the build crashes, everything done up to that point gets lost Request: Shard the build over multiple arrow files, which would enable: - much faster build by parallelizing the build process - if the p...
closed
2021-07-14T18:04:58
https://api.github.com/repos/huggingface/datasets/issues/2650/comments
null
false
[load_dataset] shard and parallelize the process - Some huge datasets take forever to build the first time. (e.g. oscar/en) as it's done in a single cpu core. - If the build crashes, everything done up to that point gets lost Request: Shard the build over multiple arrow files, which would enable: - much faster bui...
[ "I need the same feature for distributed training", "I think @TevenLeScao is exploring adding multiprocessing in `GeneratorBasedBuilder._prepare_split` - feel free to post updates here :)", "Posted a PR to address the building side, still needs something to load sharded arrow files + tests", "Closing as this ...
https://api.github.com/repos/huggingface/datasets/issues/2649
2,649
adding progress bar / ETA for `load_dataset`
Please consider: ``` Downloading and preparing dataset oscar/unshuffled_deduplicated_en (download: 462.40 GiB, generated: 1.18 TiB, post-processed: Unknown size, total: 1.63 TiB) to cache/oscar/unshuffled_deduplicated_en/1.0.0/84838bd49d2295f62008383b05620571535451d84545037bb94d6f3501651df2... HF google storage unre...
open
2021-07-14T17:34:39
https://api.github.com/repos/huggingface/datasets/issues/2649/comments
null
false
adding progress bar / ETA for `load_dataset` Please consider: ``` Downloading and preparing dataset oscar/unshuffled_deduplicated_en (download: 462.40 GiB, generated: 1.18 TiB, post-processed: Unknown size, total: 1.63 TiB) to cache/oscar/unshuffled_deduplicated_en/1.0.0/84838bd49d2295f62008383b05620571535451d8454503...
[ "Is this done now? I see progress bars when using `load_dataset`.", "There are progress bars when downloading data and when preparing them as Arrow files.\r\n\r\nThe \"total silence\" part mentioned in OP refer to checksums verifications which have had some changes in the latest release 2.10:\r\n- they're disable...
https://api.github.com/repos/huggingface/datasets/issues/2648
2,648
Add web_split dataset for Paraphase and Rephrase benchmark
## Describe: For getting simple sentences from complex sentence there are dataset and task like wiki_split that is available in hugging face datasets. This web_split is a very similar dataset. There some research paper which states that by combining these two datasets we if we train the model it will yield better resu...
open
2021-07-14T14:24:36
https://api.github.com/repos/huggingface/datasets/issues/2648/comments
null
false
Add web_split dataset for Paraphase and Rephrase benchmark ## Describe: For getting simple sentences from complex sentence there are dataset and task like wiki_split that is available in hugging face datasets. This web_split is a very similar dataset. There some research paper which states that by combining these two ...
[ "#take" ]
https://api.github.com/repos/huggingface/datasets/issues/2647
2,647
Fix anchor in README
I forgot to push this fix in #2611, so I'm sending it now.
closed
2021-07-14T13:22:44
https://api.github.com/repos/huggingface/datasets/issues/2647/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2647", "html_url": "https://github.com/huggingface/datasets/pull/2647", "diff_url": "https://github.com/huggingface/datasets/pull/2647.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2647.patch", "merged_at": "2021-07-15T06:50...
true
Fix anchor in README I forgot to push this fix in #2611, so I'm sending it now.
[]
https://api.github.com/repos/huggingface/datasets/issues/2646
2,646
downloading of yahoo_answers_topics dataset failed
## Describe the bug I get an error datasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files when I try to download the yahoo_answers_topics dataset ## Steps to reproduce the bug self.dataset = load_dataset( 'yahoo_answers_topics', cache_dir=self.config...
closed
2021-07-14T12:31:05
https://api.github.com/repos/huggingface/datasets/issues/2646/comments
null
false
downloading of yahoo_answers_topics dataset failed ## Describe the bug I get an error datasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files when I try to download the yahoo_answers_topics dataset ## Steps to reproduce the bug self.dataset = load_dataset( ...
[ "Hi ! I just tested and it worked fine today for me.\r\n\r\nI think this is because the dataset is stored on Google Drive which has a quota limit for the number of downloads per day, see this similar issue https://github.com/huggingface/datasets/issues/996 \r\n\r\nFeel free to try again today, now that the quota wa...
https://api.github.com/repos/huggingface/datasets/issues/2645
2,645
load_dataset processing failed with OS error after downloading a dataset
## Describe the bug After downloading a dataset like opus100, there is a bug that OSError: Cannot find data file. Original error: dlopen: cannot load any more object with static TLS ## Steps to reproduce the bug ```python from datasets import load_dataset this_dataset = load_dataset('opus100', 'af-en') ``` ...
closed
2021-07-14T12:23:53
https://api.github.com/repos/huggingface/datasets/issues/2645/comments
null
false
load_dataset processing failed with OS error after downloading a dataset ## Describe the bug After downloading a dataset like opus100, there is a bug that OSError: Cannot find data file. Original error: dlopen: cannot load any more object with static TLS ## Steps to reproduce the bug ```python from datasets i...
[ "Hi ! It looks like an issue with pytorch.\r\n\r\nCould you try to run `import torch` and see if it raises an error ?", "> Hi ! It looks like an issue with pytorch.\r\n> \r\n> Could you try to run `import torch` and see if it raises an error ?\r\n\r\nIt works. Thank you!" ]
https://api.github.com/repos/huggingface/datasets/issues/2644
2,644
Batched `map` not allowed to return 0 items
## Describe the bug I'm trying to use `map` to filter a large dataset by selecting rows that match an expensive condition (files referenced by one of the columns need to exist in the filesystem, so we have to `stat` them). According to [the documentation](https://huggingface.co/docs/datasets/processing.html#augmenting...
closed
2021-07-14T09:58:19
https://api.github.com/repos/huggingface/datasets/issues/2644/comments
null
false
Batched `map` not allowed to return 0 items ## Describe the bug I'm trying to use `map` to filter a large dataset by selecting rows that match an expensive condition (files referenced by one of the columns need to exist in the filesystem, so we have to `stat` them). According to [the documentation](https://huggingface...
[ "Hi ! Thanks for reporting. Indeed it looks like type inference makes it fail. We should probably just ignore this step until a non-empty batch is passed.", "Sounds good! Do you want me to propose a PR? I'm quite busy right now, but if it's not too urgent I could take a look next week.", "Sure if you're interes...
https://api.github.com/repos/huggingface/datasets/issues/2643
2,643
Enum used in map functions will raise a RecursionError with dill.
## Describe the bug Enums used in functions pass to `map` will fail at pickling with a maximum recursion exception as described here: https://github.com/uqfoundation/dill/issues/250#issuecomment-852566284 In my particular case, I use an enum to define an argument with fixed options using the `TraininigArguments` ...
open
2021-07-14T09:16:08
https://api.github.com/repos/huggingface/datasets/issues/2643/comments
null
false
Enum used in map functions will raise a RecursionError with dill. ## Describe the bug Enums used in functions pass to `map` will fail at pickling with a maximum recursion exception as described here: https://github.com/uqfoundation/dill/issues/250#issuecomment-852566284 In my particular case, I use an enum to def...
[ "I'm running into this as well. (Thank you so much for reporting @jorgeecardona — was staring at this massive stack trace and unsure what exactly was wrong!)", "Hi ! Thanks for reporting :)\r\n\r\nUntil this is fixed on `dill`'s side, we could implement a custom saving in our Pickler indefined in utils.py_utils.p...
https://api.github.com/repos/huggingface/datasets/issues/2642
2,642
Support multi-worker with streaming dataset (IterableDataset).
**Is your feature request related to a problem? Please describe.** The current `.map` does not support multi-process, CPU can become bottleneck if the pre-processing is complex (e.g. t5 span masking). **Describe the solution you'd like** Ideally `.map` should support multi-worker like tfds, with `AUTOTUNE`. **D...
open
2021-07-14T08:22:58
https://api.github.com/repos/huggingface/datasets/issues/2642/comments
null
false
Support multi-worker with streaming dataset (IterableDataset). **Is your feature request related to a problem? Please describe.** The current `.map` does not support multi-process, CPU can become bottleneck if the pre-processing is complex (e.g. t5 span masking). **Describe the solution you'd like** Ideally `.map`...
[ "Hi ! This is a great idea :)\r\nI think we could have something similar to what we have in `datasets.Dataset.map`, i.e. a `num_proc` parameter that tells how many processes to spawn to parallelize the data processing. \r\n\r\nRegarding AUTOTUNE, this could be a nice feature as well, we could see how to add it in a...
https://api.github.com/repos/huggingface/datasets/issues/2641
2,641
load_dataset("financial_phrasebank") NonMatchingChecksumError
## Describe the bug Attempting to download the financial_phrasebank dataset results in a NonMatchingChecksumError ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("financial_phrasebank", 'sentences_allagree') ``` ## Expected results I expect to see the financi...
closed
2021-07-13T21:21:49
https://api.github.com/repos/huggingface/datasets/issues/2641/comments
null
false
load_dataset("financial_phrasebank") NonMatchingChecksumError ## Describe the bug Attempting to download the financial_phrasebank dataset results in a NonMatchingChecksumError ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("financial_phrasebank", 'sentences_allag...
[ "Hi! It's probably because this dataset is stored on google drive and it has a per day quota limit. It should work if you retry, I was able to initiate the download.\r\n\r\nSimilar issue [here](https://github.com/huggingface/datasets/issues/2646)", "Hi ! Loading the dataset works on my side as well.\r\nFeel free ...
https://api.github.com/repos/huggingface/datasets/issues/2640
2,640
Fix docstrings
Fix rendering of some docstrings.
closed
2021-07-13T16:09:14
https://api.github.com/repos/huggingface/datasets/issues/2640/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2640", "html_url": "https://github.com/huggingface/datasets/pull/2640", "diff_url": "https://github.com/huggingface/datasets/pull/2640.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2640.patch", "merged_at": "2021-07-15T06:06...
true
Fix docstrings Fix rendering of some docstrings.
[]
https://api.github.com/repos/huggingface/datasets/issues/2639
2,639
Refactor patching to specific submodule
Minor reorganization of the code, so that additional patching functions (not related to streaming) might be created. In relation with the initial approach followed in #2631.
closed
2021-07-13T15:08:45
https://api.github.com/repos/huggingface/datasets/issues/2639/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2639", "html_url": "https://github.com/huggingface/datasets/pull/2639", "diff_url": "https://github.com/huggingface/datasets/pull/2639.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2639.patch", "merged_at": "2021-07-13T16:52...
true
Refactor patching to specific submodule Minor reorganization of the code, so that additional patching functions (not related to streaming) might be created. In relation with the initial approach followed in #2631.
[]
https://api.github.com/repos/huggingface/datasets/issues/2638
2,638
Streaming for the Json loader
It was not using `open` in the builder. Therefore `pyarrow.json.read_json` was downloading the full file to start yielding rows. Moreover, it appeared that `pyarrow.json.read_json` was not really suited for streaming as it was downloading too much data and failing if `block_size` was not properly configured (related...
closed
2021-07-13T14:37:06
https://api.github.com/repos/huggingface/datasets/issues/2638/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2638", "html_url": "https://github.com/huggingface/datasets/pull/2638", "diff_url": "https://github.com/huggingface/datasets/pull/2638.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2638.patch", "merged_at": "2021-07-16T15:59...
true
Streaming for the Json loader It was not using `open` in the builder. Therefore `pyarrow.json.read_json` was downloading the full file to start yielding rows. Moreover, it appeared that `pyarrow.json.read_json` was not really suited for streaming as it was downloading too much data and failing if `block_size` was no...
[ "A note is that I think we should add a few indicator of status (as mentioned by @stas00 in #2649), probably at the (1) downloading, (2) extracting and (3) reading steps. In particular when loading many very large files it's interesting to know a bit where we are in the process.", "I tested locally, and the built...
https://api.github.com/repos/huggingface/datasets/issues/2636
2,636
Streaming for the Pandas loader
It was not using open in the builder. Therefore pd.read_pickle could fail when streaming from a private repo for example. Indeed, when streaming, open is extended to support reading from remote files and handles authentication to the HF Hub
closed
2021-07-13T09:18:21
https://api.github.com/repos/huggingface/datasets/issues/2636/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2636", "html_url": "https://github.com/huggingface/datasets/pull/2636", "diff_url": "https://github.com/huggingface/datasets/pull/2636.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2636.patch", "merged_at": "2021-07-13T14:37...
true
Streaming for the Pandas loader It was not using open in the builder. Therefore pd.read_pickle could fail when streaming from a private repo for example. Indeed, when streaming, open is extended to support reading from remote files and handles authentication to the HF Hub
[]
https://api.github.com/repos/huggingface/datasets/issues/2635
2,635
Streaming for the CSV loader
It was not using `open` in the builder. Therefore `pd.read_csv` was downloading the full file to start yielding rows. Indeed, when streaming, `open` is extended to support reading from remote file progressively.
closed
2021-07-13T09:08:58
https://api.github.com/repos/huggingface/datasets/issues/2635/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2635", "html_url": "https://github.com/huggingface/datasets/pull/2635", "diff_url": "https://github.com/huggingface/datasets/pull/2635.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2635.patch", "merged_at": "2021-07-13T15:19...
true
Streaming for the CSV loader It was not using `open` in the builder. Therefore `pd.read_csv` was downloading the full file to start yielding rows. Indeed, when streaming, `open` is extended to support reading from remote file progressively.
[]
https://api.github.com/repos/huggingface/datasets/issues/2634
2,634
Inject ASR template for lj_speech dataset
Related to: #2565, #2633. cc: @lewtun
closed
2021-07-13T06:04:54
https://api.github.com/repos/huggingface/datasets/issues/2634/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2634", "html_url": "https://github.com/huggingface/datasets/pull/2634", "diff_url": "https://github.com/huggingface/datasets/pull/2634.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2634.patch", "merged_at": "2021-07-13T09:05...
true
Inject ASR template for lj_speech dataset Related to: #2565, #2633. cc: @lewtun
[]
https://api.github.com/repos/huggingface/datasets/issues/2633
2,633
Update ASR tags
This PR updates the ASR tags of the 5 datasets added in #2565 following the change of task categories in #2620
closed
2021-07-12T19:58:31
https://api.github.com/repos/huggingface/datasets/issues/2633/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2633", "html_url": "https://github.com/huggingface/datasets/pull/2633", "diff_url": "https://github.com/huggingface/datasets/pull/2633.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2633.patch", "merged_at": "2021-07-13T05:45...
true
Update ASR tags This PR updates the ASR tags of the 5 datasets added in #2565 following the change of task categories in #2620
[]
https://api.github.com/repos/huggingface/datasets/issues/2632
2,632
add image-classification task template
Snippet below is the tl;dr, but you can try it out directly here: [![Open In Collab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/gist/nateraw/005c025d41f0e48ae3d4ee61c0f20b70/image-classification-task-template-demo.ipynb) ```python from datasets import load_datase...
closed
2021-07-12T17:41:03
https://api.github.com/repos/huggingface/datasets/issues/2632/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2632", "html_url": "https://github.com/huggingface/datasets/pull/2632", "diff_url": "https://github.com/huggingface/datasets/pull/2632.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2632.patch", "merged_at": "2021-07-13T15:28...
true
add image-classification task template Snippet below is the tl;dr, but you can try it out directly here: [![Open In Collab](https://colab.research.google.com/assets/colab-badge.svg)](https://colab.research.google.com/gist/nateraw/005c025d41f0e48ae3d4ee61c0f20b70/image-classification-task-template-demo.ipynb) ```p...
[ "Awesome!", "Thanks for adding a new task template - great work @nateraw 🚀 !" ]
https://api.github.com/repos/huggingface/datasets/issues/2631
2,631
Delete extracted files when loading dataset
Close #2481, close #2604, close #2591. cc: @stas00, @thomwolf, @BirgerMoell
closed
2021-07-12T16:39:33
https://api.github.com/repos/huggingface/datasets/issues/2631/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2631", "html_url": "https://github.com/huggingface/datasets/pull/2631", "diff_url": "https://github.com/huggingface/datasets/pull/2631.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2631.patch", "merged_at": "2021-07-19T09:08...
true
Delete extracted files when loading dataset Close #2481, close #2604, close #2591. cc: @stas00, @thomwolf, @BirgerMoell
[ "Sure @stas00, it is still a draft pull request. :)", "Yes, I noticed it after reviewing - my apologies.", "The problem with this approach is that it also deletes the downloaded files (if they need not be extracted). 😟 ", "> The problem with this approach is that it also deletes the downloaded files (if they...
https://api.github.com/repos/huggingface/datasets/issues/2630
2,630
Progress bars are not properly rendered in Jupyter notebook
## Describe the bug The progress bars are not Jupyter widgets; regular progress bars appear (like in a terminal). ## Steps to reproduce the bug ```python ds.map(tokenize, num_proc=10) ``` ## Expected results Jupyter widgets displaying the progress bars. ## Actual results Simple plane progress bars. cc...
closed
2021-07-12T14:07:13
https://api.github.com/repos/huggingface/datasets/issues/2630/comments
null
false
Progress bars are not properly rendered in Jupyter notebook ## Describe the bug The progress bars are not Jupyter widgets; regular progress bars appear (like in a terminal). ## Steps to reproduce the bug ```python ds.map(tokenize, num_proc=10) ``` ## Expected results Jupyter widgets displaying the progress b...
[ "To add my experience when trying to debug this issue:\r\n\r\nSeems like previously the workaround given [here](https://github.com/tqdm/tqdm/issues/485#issuecomment-473338308) worked around this issue. But with the latest version of jupyter/tqdm I still get terminal warnings that IPython tried to send a message fro...
https://api.github.com/repos/huggingface/datasets/issues/2629
2,629
Load datasets from the Hub without requiring a dataset script
As a user I would like to be able to upload my csv/json/text/parquet/etc. files in a dataset repository on the Hugging Face Hub and be able to load this dataset with `load_dataset` without having to implement a dataset script. Moreover I would like to be able to specify which file goes into which split using the `da...
closed
2021-07-12T08:45:17
https://api.github.com/repos/huggingface/datasets/issues/2629/comments
null
false
Load datasets from the Hub without requiring a dataset script As a user I would like to be able to upload my csv/json/text/parquet/etc. files in a dataset repository on the Hugging Face Hub and be able to load this dataset with `load_dataset` without having to implement a dataset script. Moreover I would like to be ...
[ "This is so cool, let us know if we can help with anything on the hub side (@Pierrci @elishowk) 🎉 " ]
https://api.github.com/repos/huggingface/datasets/issues/2628
2,628
Use ETag of remote data files
Use ETag of remote data files to create config ID. Related to #2616.
closed
2021-07-12T05:10:10
https://api.github.com/repos/huggingface/datasets/issues/2628/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2628", "html_url": "https://github.com/huggingface/datasets/pull/2628", "diff_url": "https://github.com/huggingface/datasets/pull/2628.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2628.patch", "merged_at": "2021-07-12T08:40...
true
Use ETag of remote data files Use ETag of remote data files to create config ID. Related to #2616.
[]
https://api.github.com/repos/huggingface/datasets/issues/2627
2,627
Minor fix tests with Windows paths
Minor fix tests with Windows paths.
closed
2021-07-11T17:55:48
https://api.github.com/repos/huggingface/datasets/issues/2627/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2627", "html_url": "https://github.com/huggingface/datasets/pull/2627", "diff_url": "https://github.com/huggingface/datasets/pull/2627.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2627.patch", "merged_at": "2021-07-12T08:34...
true
Minor fix tests with Windows paths Minor fix tests with Windows paths.
[]
https://api.github.com/repos/huggingface/datasets/issues/2626
2,626
Use correct logger in metrics.py
Fixes #2624
closed
2021-07-11T17:22:30
https://api.github.com/repos/huggingface/datasets/issues/2626/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2626", "html_url": "https://github.com/huggingface/datasets/pull/2626", "diff_url": "https://github.com/huggingface/datasets/pull/2626.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2626.patch", "merged_at": "2021-07-12T05:54...
true
Use correct logger in metrics.py Fixes #2624
[]
https://api.github.com/repos/huggingface/datasets/issues/2625
2,625
⚛️😇⚙️🔑
closed
2021-07-11T12:14:34
https://api.github.com/repos/huggingface/datasets/issues/2625/comments
null
false
⚛️😇⚙️🔑
[]
https://api.github.com/repos/huggingface/datasets/issues/2624
2,624
can't set verbosity for `metric.py`
## Describe the bug ``` [2021-07-10 20:13:11,528][datasets.utils.filelock][INFO] - Lock 139705371374976 acquired on /root/.cache/huggingface/metrics/seqeval/default/default_experiment-1-0.arrow.lock [2021-07-10 20:13:11,529][datasets.arrow_writer][INFO] - Done writing 32 examples in 6100 bytes /root/.cache/huggingfa...
closed
2021-07-10T20:23:45
https://api.github.com/repos/huggingface/datasets/issues/2624/comments
null
false
can't set verbosity for `metric.py` ## Describe the bug ``` [2021-07-10 20:13:11,528][datasets.utils.filelock][INFO] - Lock 139705371374976 acquired on /root/.cache/huggingface/metrics/seqeval/default/default_experiment-1-0.arrow.lock [2021-07-10 20:13:11,529][datasets.arrow_writer][INFO] - Done writing 32 examples ...
[ "Thanks @thomas-happify for reporting and thanks @mariosasko for the fix." ]
https://api.github.com/repos/huggingface/datasets/issues/2623
2,623
[Metrics] added wiki_split metrics
Fixes: #2606 This pull request adds combine metrics for the wikisplit or English sentence split task Reviewer: @patrickvonplaten
closed
2021-07-10T14:51:50
https://api.github.com/repos/huggingface/datasets/issues/2623/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2623", "html_url": "https://github.com/huggingface/datasets/pull/2623", "diff_url": "https://github.com/huggingface/datasets/pull/2623.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2623.patch", "merged_at": "2021-07-12T22:34...
true
[Metrics] added wiki_split metrics Fixes: #2606 This pull request adds combine metrics for the wikisplit or English sentence split task Reviewer: @patrickvonplaten
[ "Looks all good to me thanks :)\r\nJust did some minor corrections in the docstring" ]
https://api.github.com/repos/huggingface/datasets/issues/2622
2,622
Integration with AugLy
**Is your feature request related to a problem? Please describe.** Facebook recently launched a library, [AugLy](https://github.com/facebookresearch/AugLy) , that has a unified API for augmentations for image, video and text. It would be pretty exciting to have it hooked up to HF libraries so that we can make NLP m...
closed
2021-07-10T00:03:09
https://api.github.com/repos/huggingface/datasets/issues/2622/comments
null
false
Integration with AugLy **Is your feature request related to a problem? Please describe.** Facebook recently launched a library, [AugLy](https://github.com/facebookresearch/AugLy) , that has a unified API for augmentations for image, video and text. It would be pretty exciting to have it hooked up to HF libraries so...
[ "Hi,\r\n\r\nyou can define your own custom formatting with `Dataset.set_transform()` and then run the tokenizer with the batches of augmented data as follows:\r\n```python\r\ndset = load_dataset(\"imdb\", split=\"train\") # Let's say we are working with the IMDB dataset\r\ndset.set_transform(lambda ex: {\"text\": ...
https://api.github.com/repos/huggingface/datasets/issues/2621
2,621
Use prefix to allow exceed Windows MAX_PATH
By using this prefix, you can exceed the Windows MAX_PATH limit. See: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#win32-file-namespaces Related to #2524, #2220.
closed
2021-07-09T16:39:53
https://api.github.com/repos/huggingface/datasets/issues/2621/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2621", "html_url": "https://github.com/huggingface/datasets/pull/2621", "diff_url": "https://github.com/huggingface/datasets/pull/2621.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2621.patch", "merged_at": "2021-07-16T15:28...
true
Use prefix to allow exceed Windows MAX_PATH By using this prefix, you can exceed the Windows MAX_PATH limit. See: https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file?redirectedfrom=MSDN#win32-file-namespaces Related to #2524, #2220.
[ "Does this mean the `FileNotFoundError` that avoids infinite loop can be removed?", "Yes, I think so...", "Or maybe we could leave it in case a relative path exceeds the MAX_PATH limit?", " > Or maybe we could leave it in case a relative path exceeds the MAX_PATH limit?\r\n\r\nWhat about converting relative p...
https://api.github.com/repos/huggingface/datasets/issues/2620
2,620
Add speech processing tasks
This PR replaces the `automatic-speech-recognition` task category with a broader `speech-processing` category. The tasks associated with this category are derived from the [SUPERB benchmark](https://arxiv.org/abs/2105.01051), and ASR is included in this set.
closed
2021-07-09T16:07:29
https://api.github.com/repos/huggingface/datasets/issues/2620/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2620", "html_url": "https://github.com/huggingface/datasets/pull/2620", "diff_url": "https://github.com/huggingface/datasets/pull/2620.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2620.patch", "merged_at": "2021-07-12T17:32...
true
Add speech processing tasks This PR replaces the `automatic-speech-recognition` task category with a broader `speech-processing` category. The tasks associated with this category are derived from the [SUPERB benchmark](https://arxiv.org/abs/2105.01051), and ASR is included in this set.
[ "Are there any `task_categories:automatic-speech-recognition` dataset for which we should update the tags ?", "> Are there any `task_categories:automatic-speech-recognition` dataset for which we should update the tags ?\r\n\r\nYes there's a few - I'll fix them tomorrow :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2619
2,619
Add ASR task for SUPERB
This PR starts building up the SUPERB benchmark by including the ASR task as described in the [SUPERB paper](https://arxiv.org/abs/2105.01051) and `s3prl` [instructions](https://github.com/s3prl/s3prl/tree/v0.2.0/downstream#asr-automatic-speech-recognition). Usage: ```python from datasets import load_dataset ...
closed
2021-07-09T15:19:45
https://api.github.com/repos/huggingface/datasets/issues/2619/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2619", "html_url": "https://github.com/huggingface/datasets/pull/2619", "diff_url": "https://github.com/huggingface/datasets/pull/2619.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2619.patch", "merged_at": "2021-07-13T12:40...
true
Add ASR task for SUPERB This PR starts building up the SUPERB benchmark by including the ASR task as described in the [SUPERB paper](https://arxiv.org/abs/2105.01051) and `s3prl` [instructions](https://github.com/s3prl/s3prl/tree/v0.2.0/downstream#asr-automatic-speech-recognition). Usage: ```python from datasets...
[ "Wait until #2620 is merged before pushing the README tags in this PR", "> Thanks!\r\n> \r\n> One question: aren't you adding `task_templates` to the `_info` method (and to the `dataset_infos.json`?\r\n\r\ngreat catch! i've now added the asr task template (along with a mapping from superb task -> template) and up...
https://api.github.com/repos/huggingface/datasets/issues/2618
2,618
`filelock.py` Error
## Describe the bug It seems that the `filelock.py` went error. ``` >>> ds=load_dataset('xsum') ^CTraceback (most recent call last): File "/user/HS502/yl02706/.conda/envs/lyc/lib/python3.6/site-packages/datasets/utils/filelock.py", line 402, in _acquire fcntl.flock(fd, fcntl.LOCK_EX | fcntl.LOCK_NB) ...
closed
2021-07-09T15:12:49
https://api.github.com/repos/huggingface/datasets/issues/2618/comments
null
false
`filelock.py` Error ## Describe the bug It seems that the `filelock.py` went error. ``` >>> ds=load_dataset('xsum') ^CTraceback (most recent call last): File "/user/HS502/yl02706/.conda/envs/lyc/lib/python3.6/site-packages/datasets/utils/filelock.py", line 402, in _acquire fcntl.flock(fd, fcntl.LOCK_...
[ "Hi @liyucheng09, thanks for reporting.\r\n\r\nApparently this issue has to do with your environment setup. One question: is your data in an NFS share? Some people have reported this error when using `fcntl` to write to an NFS share... If this is the case, then it might be that your NFS just may not be set up to pr...
https://api.github.com/repos/huggingface/datasets/issues/2617
2,617
Fix missing EOL issue in to_json for old versions of pandas
Some versions of pandas don't add an EOL at the end of the output of `to_json`. Therefore users could end up having two samples in the same line Close https://github.com/huggingface/datasets/issues/2615
closed
2021-07-09T15:05:45
https://api.github.com/repos/huggingface/datasets/issues/2617/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2617", "html_url": "https://github.com/huggingface/datasets/pull/2617", "diff_url": "https://github.com/huggingface/datasets/pull/2617.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2617.patch", "merged_at": "2021-07-09T15:28...
true
Fix missing EOL issue in to_json for old versions of pandas Some versions of pandas don't add an EOL at the end of the output of `to_json`. Therefore users could end up having two samples in the same line Close https://github.com/huggingface/datasets/issues/2615
[]
https://api.github.com/repos/huggingface/datasets/issues/2616
2,616
Support remote data files
Add support for (streaming) remote data files: ```python data_files = f"https://huggingface.co/datasets/{repo_id}/resolve/main/{relative_file_path}" ds = load_dataset("json", split="train", data_files=data_files, streaming=True) ``` cc: @thomwolf
closed
2021-07-09T14:07:38
https://api.github.com/repos/huggingface/datasets/issues/2616/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2616", "html_url": "https://github.com/huggingface/datasets/pull/2616", "diff_url": "https://github.com/huggingface/datasets/pull/2616.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2616.patch", "merged_at": "2021-07-09T16:13...
true
Support remote data files Add support for (streaming) remote data files: ```python data_files = f"https://huggingface.co/datasets/{repo_id}/resolve/main/{relative_file_path}" ds = load_dataset("json", split="train", data_files=data_files, streaming=True) ``` cc: @thomwolf
[ "@lhoestq maybe we could also use (if available) the ETag of the remote file in `create_config_id`?", "> @lhoestq maybe we could also use (if available) the ETag of the remote file in `create_config_id`?\r\n\r\nSure ! We can get the ETag with\r\n```python\r\nheaders = get_authentication_headers_for_url(url, use_a...
https://api.github.com/repos/huggingface/datasets/issues/2615
2,615
Jsonlines export error
## Describe the bug When exporting large datasets in jsonlines (c4 in my case) the created file has an error every 9999 lines: the 9999th and 10000th are concatenated, thus breaking the jsonlines format. This sounds like it is related to batching, which is by 10000 by default ## Steps to reproduce the bug This wha...
closed
2021-07-09T14:02:05
https://api.github.com/repos/huggingface/datasets/issues/2615/comments
null
false
Jsonlines export error ## Describe the bug When exporting large datasets in jsonlines (c4 in my case) the created file has an error every 9999 lines: the 9999th and 10000th are concatenated, thus breaking the jsonlines format. This sounds like it is related to batching, which is by 10000 by default ## Steps to repr...
[ "Thanks for reporting @TevenLeScao! I'm having a look...", "(not sure what just happened on the assignations sorry)", "For some reason this happens (both `datasets` version are on master) only on Python 3.6 and not Python 3.8.", "@TevenLeScao we are using `pandas` to serialize the dataset to JSON Lines. So it...
https://api.github.com/repos/huggingface/datasets/issues/2614
2,614
Convert numpy scalar to python float in Pearsonr output
Following of https://github.com/huggingface/datasets/pull/2612
closed
2021-07-09T13:22:55
https://api.github.com/repos/huggingface/datasets/issues/2614/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2614", "html_url": "https://github.com/huggingface/datasets/pull/2614", "diff_url": "https://github.com/huggingface/datasets/pull/2614.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2614.patch", "merged_at": "2021-07-09T14:04...
true
Convert numpy scalar to python float in Pearsonr output Following of https://github.com/huggingface/datasets/pull/2612
[]
https://api.github.com/repos/huggingface/datasets/issues/2613
2,613
Use ndarray.item instead of ndarray.tolist
This PR follows up on #2612 to use `numpy.ndarray.item` instead of `numpy.ndarray.tolist` as the latter is somewhat confusing to the developer (even though it works). Judging from the `numpy` docs, `ndarray.item` is closer to what we want: https://numpy.org/doc/stable/reference/generated/numpy.ndarray.item.html#nump...
closed
2021-07-09T13:19:35
https://api.github.com/repos/huggingface/datasets/issues/2613/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2613", "html_url": "https://github.com/huggingface/datasets/pull/2613", "diff_url": "https://github.com/huggingface/datasets/pull/2613.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2613.patch", "merged_at": "2021-07-09T13:50...
true
Use ndarray.item instead of ndarray.tolist This PR follows up on #2612 to use `numpy.ndarray.item` instead of `numpy.ndarray.tolist` as the latter is somewhat confusing to the developer (even though it works). Judging from the `numpy` docs, `ndarray.item` is closer to what we want: https://numpy.org/doc/stable/refer...
[]
https://api.github.com/repos/huggingface/datasets/issues/2612
2,612
Return Python float instead of numpy.float64 in sklearn metrics
This PR converts the return type of all `sklearn` metrics to be Python `float` instead of `numpy.float64`. The reason behind this is that our Hub evaluation framework relies on converting benchmark-specific metrics to YAML ([example](https://huggingface.co/datasets/autonlp/autonlp-benchmark-raft-neelalex__raft-test-...
closed
2021-07-09T09:48:09
https://api.github.com/repos/huggingface/datasets/issues/2612/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2612", "html_url": "https://github.com/huggingface/datasets/pull/2612", "diff_url": "https://github.com/huggingface/datasets/pull/2612.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2612.patch", "merged_at": "2021-07-09T13:03...
true
Return Python float instead of numpy.float64 in sklearn metrics This PR converts the return type of all `sklearn` metrics to be Python `float` instead of `numpy.float64`. The reason behind this is that our Hub evaluation framework relies on converting benchmark-specific metrics to YAML ([example](https://huggingface...
[ "I opened an issue on the `sklearn` repo to understand why `numpy.float64` is the default: https://github.com/scikit-learn/scikit-learn/discussions/20490", "It could be surprising at first to use `tolist()` on numpy scalars but it works ^^", "did the same for Pearsonr here: https://github.com/huggingface/datase...
https://api.github.com/repos/huggingface/datasets/issues/2611
2,611
More consistent naming
As per @stas00's suggestion in #2500, this PR inserts a space between the logo and the lib name (`🤗Datasets` -> `🤗 Datasets`) for consistency with the Transformers lib. Additionally, more consistent names are used for Datasets Hub, etc.
closed
2021-07-09T00:09:17
https://api.github.com/repos/huggingface/datasets/issues/2611/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2611", "html_url": "https://github.com/huggingface/datasets/pull/2611", "diff_url": "https://github.com/huggingface/datasets/pull/2611.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2611.patch", "merged_at": "2021-07-13T16:08...
true
More consistent naming As per @stas00's suggestion in #2500, this PR inserts a space between the logo and the lib name (`🤗Datasets` -> `🤗 Datasets`) for consistency with the Transformers lib. Additionally, more consistent names are used for Datasets Hub, etc.
[]
https://api.github.com/repos/huggingface/datasets/issues/2610
2,610
Add missing WikiANN language tags
Add missing language tags for WikiANN datasets.
closed
2021-07-08T14:08:01
https://api.github.com/repos/huggingface/datasets/issues/2610/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2610", "html_url": "https://github.com/huggingface/datasets/pull/2610", "diff_url": "https://github.com/huggingface/datasets/pull/2610.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2610.patch", "merged_at": "2021-07-08T15:44...
true
Add missing WikiANN language tags Add missing language tags for WikiANN datasets.
[]
https://api.github.com/repos/huggingface/datasets/issues/2609
2,609
Fix potential DuplicatedKeysError
Fix potential DiplicatedKeysError by ensuring keys are unique. We should promote as a good practice, that the keys should be programmatically generated as unique, instead of read from data (which might be not unique).
closed
2021-07-08T08:38:04
https://api.github.com/repos/huggingface/datasets/issues/2609/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2609", "html_url": "https://github.com/huggingface/datasets/pull/2609", "diff_url": "https://github.com/huggingface/datasets/pull/2609.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2609.patch", "merged_at": "2021-07-09T16:42...
true
Fix potential DuplicatedKeysError Fix potential DiplicatedKeysError by ensuring keys are unique. We should promote as a good practice, that the keys should be programmatically generated as unique, instead of read from data (which might be not unique).
[ "Finally, I'm splitting this PR." ]
https://api.github.com/repos/huggingface/datasets/issues/2608
2,608
Support streaming JSON files
Use open in JSON dataset builder, so that it can be patched with xopen for streaming. Close #2607.
closed
2021-07-07T13:30:22
https://api.github.com/repos/huggingface/datasets/issues/2608/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2608", "html_url": "https://github.com/huggingface/datasets/pull/2608", "diff_url": "https://github.com/huggingface/datasets/pull/2608.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2608.patch", "merged_at": "2021-07-08T16:08...
true
Support streaming JSON files Use open in JSON dataset builder, so that it can be patched with xopen for streaming. Close #2607.
[]
https://api.github.com/repos/huggingface/datasets/issues/2607
2,607
Streaming local gzip compressed JSON line files is not working
## Describe the bug Using streaming to iterate on local gzip compressed JSON files raise a file not exist error ## Steps to reproduce the bug ```python from datasets import load_dataset streamed_dataset = load_dataset('json', split='train', data_files=data_files, streaming=True) next(iter(streamed_dataset))...
closed
2021-07-07T11:36:33
https://api.github.com/repos/huggingface/datasets/issues/2607/comments
null
false
Streaming local gzip compressed JSON line files is not working ## Describe the bug Using streaming to iterate on local gzip compressed JSON files raise a file not exist error ## Steps to reproduce the bug ```python from datasets import load_dataset streamed_dataset = load_dataset('json', split='train', data_fi...
[ "Updating to pyarrow-4.0.1 didn't fix the issue", "Here is an exemple dataset with 2 of these compressed JSON files: https://huggingface.co/datasets/thomwolf/github-python", "Hi @thomwolf, thanks for reporting.\r\n\r\nIt seems this might be due to the fact that the JSON Dataset builder uses `pyarrow.json` (`paj...
https://api.github.com/repos/huggingface/datasets/issues/2606
2,606
[Metrics] addition of wiki_split metrics
**Is your feature request related to a problem? Please describe.** While training the model on sentence split the task in English we require to evaluate the trained model on `Exact Match`, `SARI` and `BLEU` score like this ![image](https://user-images.githubusercontent.com/26653468/124746876-ff5a3380-df3e-11eb-9a01...
closed
2021-07-07T10:56:04
https://api.github.com/repos/huggingface/datasets/issues/2606/comments
null
false
[Metrics] addition of wiki_split metrics **Is your feature request related to a problem? Please describe.** While training the model on sentence split the task in English we require to evaluate the trained model on `Exact Match`, `SARI` and `BLEU` score like this ![image](https://user-images.githubusercontent.com/2...
[ "#take" ]
https://api.github.com/repos/huggingface/datasets/issues/2605
2,605
Make any ClientError trigger retry in streaming mode (e.g. ClientOSError)
During the FLAX sprint some users have this error when streaming datasets: ```python aiohttp.client_exceptions.ClientOSError: [Errno 104] Connection reset by peer ``` This error must trigger a retry instead of directly crashing Therefore I extended the error type that triggers the retry to be the base aiohttp er...
closed
2021-07-07T08:47:23
https://api.github.com/repos/huggingface/datasets/issues/2605/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2605", "html_url": "https://github.com/huggingface/datasets/pull/2605", "diff_url": "https://github.com/huggingface/datasets/pull/2605.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2605.patch", "merged_at": "2021-07-07T08:59...
true
Make any ClientError trigger retry in streaming mode (e.g. ClientOSError) During the FLAX sprint some users have this error when streaming datasets: ```python aiohttp.client_exceptions.ClientOSError: [Errno 104] Connection reset by peer ``` This error must trigger a retry instead of directly crashing Therefore I...
[]
https://api.github.com/repos/huggingface/datasets/issues/2604
2,604
Add option to delete temporary files (e.g. extracted files) when loading dataset
I'm loading a dataset constituted of 44 GB of compressed JSON files. When loading the dataset with the JSON script, extracting the files create about 200 GB of uncompressed files before creating the 180GB of arrow cache tables Having a simple way to delete the extracted files after usage (or even better, to strea...
closed
2021-07-07T07:56:16
https://api.github.com/repos/huggingface/datasets/issues/2604/comments
null
false
Add option to delete temporary files (e.g. extracted files) when loading dataset I'm loading a dataset constituted of 44 GB of compressed JSON files. When loading the dataset with the JSON script, extracting the files create about 200 GB of uncompressed files before creating the 180GB of arrow cache tables Having...
[ "Hi !\r\nIf we want something more general, we could either\r\n1. delete the extracted files after the arrow data generation automatically, or \r\n2. delete each extracted file during the arrow generation right after it has been closed.\r\n\r\nSolution 2 is better to save disk space during the arrow generation. Is ...
https://api.github.com/repos/huggingface/datasets/issues/2603
2,603
Fix DuplicatedKeysError in omp
Close #2598.
closed
2021-07-07T07:38:32
https://api.github.com/repos/huggingface/datasets/issues/2603/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2603", "html_url": "https://github.com/huggingface/datasets/pull/2603", "diff_url": "https://github.com/huggingface/datasets/pull/2603.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2603.patch", "merged_at": "2021-07-07T12:56...
true
Fix DuplicatedKeysError in omp Close #2598.
[]
https://api.github.com/repos/huggingface/datasets/issues/2602
2,602
Remove import of transformers
When pickling a tokenizer within multiprocessing, check that is instance of transformers PreTrainedTokenizerBase without importing transformers. Related to huggingface/transformers#12549 and #502.
closed
2021-07-07T06:58:18
https://api.github.com/repos/huggingface/datasets/issues/2602/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2602", "html_url": "https://github.com/huggingface/datasets/pull/2602", "diff_url": "https://github.com/huggingface/datasets/pull/2602.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2602.patch", "merged_at": "2021-07-07T08:28...
true
Remove import of transformers When pickling a tokenizer within multiprocessing, check that is instance of transformers PreTrainedTokenizerBase without importing transformers. Related to huggingface/transformers#12549 and #502.
[]
https://api.github.com/repos/huggingface/datasets/issues/2601
2,601
Fix `filter` with multiprocessing in case all samples are discarded
Fixes #2600 Also I moved the check for `num_proc` larger than dataset size added in #2566 up so that multiprocessing is not used with one process.
closed
2021-07-06T17:06:28
https://api.github.com/repos/huggingface/datasets/issues/2601/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2601", "html_url": "https://github.com/huggingface/datasets/pull/2601", "diff_url": "https://github.com/huggingface/datasets/pull/2601.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2601.patch", "merged_at": "2021-07-07T12:50...
true
Fix `filter` with multiprocessing in case all samples are discarded Fixes #2600 Also I moved the check for `num_proc` larger than dataset size added in #2566 up so that multiprocessing is not used with one process.
[]
https://api.github.com/repos/huggingface/datasets/issues/2600
2,600
Crash when using multiprocessing (`num_proc` > 1) on `filter` and all samples are discarded
## Describe the bug If `filter` is applied to a dataset using multiprocessing (`num_proc` > 1) and all sharded datasets are empty afterwards (due to all samples being discarded), the program crashes. ## Steps to reproduce the bug ```python from datasets import Dataset data = Dataset.from_dict({'id': [0,1]}) dat...
closed
2021-07-06T16:53:25
https://api.github.com/repos/huggingface/datasets/issues/2600/comments
null
false
Crash when using multiprocessing (`num_proc` > 1) on `filter` and all samples are discarded ## Describe the bug If `filter` is applied to a dataset using multiprocessing (`num_proc` > 1) and all sharded datasets are empty afterwards (due to all samples being discarded), the program crashes. ## Steps to reproduce th...
[]
https://api.github.com/repos/huggingface/datasets/issues/2599
2,599
Update processing.rst with other export formats
Add other supported export formats than CSV in the docs.
closed
2021-07-06T14:50:38
https://api.github.com/repos/huggingface/datasets/issues/2599/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2599", "html_url": "https://github.com/huggingface/datasets/pull/2599", "diff_url": "https://github.com/huggingface/datasets/pull/2599.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2599.patch", "merged_at": "2021-07-07T08:05...
true
Update processing.rst with other export formats Add other supported export formats than CSV in the docs.
[]
https://api.github.com/repos/huggingface/datasets/issues/2598
2,598
Unable to download omp dataset
## Describe the bug The omp dataset cannot be downloaded because of a DuplicatedKeysError ## Steps to reproduce the bug from datasets import load_dataset omp = load_dataset('omp', 'posts_labeled') print(omp) ## Expected results This code should download the omp dataset and print the dictionary ## Actual r...
closed
2021-07-06T14:00:52
https://api.github.com/repos/huggingface/datasets/issues/2598/comments
null
false
Unable to download omp dataset ## Describe the bug The omp dataset cannot be downloaded because of a DuplicatedKeysError ## Steps to reproduce the bug from datasets import load_dataset omp = load_dataset('omp', 'posts_labeled') print(omp) ## Expected results This code should download the omp dataset and prin...
[ "Hi @erikadistefano , thanks for reporting the issue.\r\n\r\nI have created a Pull Request that should fix it. \r\n\r\nOnce merged into master, feel free to update your installed `datasets` library (either by installing it from our GitHub master branch or waiting until our next release) to be able to load omp datas...
https://api.github.com/repos/huggingface/datasets/issues/2597
2,597
Remove redundant prepare_module
I have noticed that after implementing `load_dataset_builder` (#2500), there is a redundant call to `prepare_module`.
closed
2021-07-06T13:47:45
https://api.github.com/repos/huggingface/datasets/issues/2597/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2597", "html_url": "https://github.com/huggingface/datasets/pull/2597", "diff_url": "https://github.com/huggingface/datasets/pull/2597.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2597.patch", "merged_at": "2021-07-07T13:01...
true
Remove redundant prepare_module I have noticed that after implementing `load_dataset_builder` (#2500), there is a redundant call to `prepare_module`.
[]
https://api.github.com/repos/huggingface/datasets/issues/2596
2,596
Transformer Class on dataset
Just wondering if you have intenttion to create TransformerClass : dataset --> dataset and make determnistic transformation (ie not fit).
closed
2021-07-06T07:27:15
https://api.github.com/repos/huggingface/datasets/issues/2596/comments
null
false
Transformer Class on dataset Just wondering if you have intenttion to create TransformerClass : dataset --> dataset and make determnistic transformation (ie not fit).
[ "Hi ! Do you have an example in mind that shows how this could be useful ?", "Example:\n\nMerge 2 datasets into one datasets\n\nLabel extraction from dataset\n\ndataset(text, label)\n —> dataset(text, newlabel)\n\nTextCleaning.\n\n\nFor image dataset, \nTransformation are easier (ie linear algebra).\n\n\n\n\n\n...
https://api.github.com/repos/huggingface/datasets/issues/2595
2,595
ModuleNotFoundError: No module named 'datasets.tasks' while importing common voice datasets
Error traceback: --------------------------------------------------------------------------- ModuleNotFoundError Traceback (most recent call last) <ipython-input-8-a7b592d3bca0> in <module>() 1 from datasets import load_dataset, load_metric 2 ----> 3 common_voice_train = load_da...
closed
2021-07-06T03:20:55
https://api.github.com/repos/huggingface/datasets/issues/2595/comments
null
false
ModuleNotFoundError: No module named 'datasets.tasks' while importing common voice datasets Error traceback: --------------------------------------------------------------------------- ModuleNotFoundError Traceback (most recent call last) <ipython-input-8-a7b592d3bca0> in <module>() 1 fr...
[ "Hi @profsatwinder.\r\n\r\nIt looks like you are using an old version of `datasets`. Please update it with `pip install -U datasets` and indicate if the problem persists.", "@albertvillanova Thanks for the information. I updated it to 1.9.0 and the issue is resolved. Thanks again. " ]
https://api.github.com/repos/huggingface/datasets/issues/2594
2,594
Fix BibTeX entry
Fix BibTeX entry.
closed
2021-07-05T18:24:10
https://api.github.com/repos/huggingface/datasets/issues/2594/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2594", "html_url": "https://github.com/huggingface/datasets/pull/2594", "diff_url": "https://github.com/huggingface/datasets/pull/2594.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2594.patch", "merged_at": "2021-07-06T04:59...
true
Fix BibTeX entry Fix BibTeX entry.
[]
https://api.github.com/repos/huggingface/datasets/issues/2593
2,593
Support pandas 1.3.0 read_csv
Workaround for this issue in pandas 1.3.0 : https://github.com/pandas-dev/pandas/issues/42387 The csv reader raises an error: ```python /usr/local/lib/python3.7/dist-packages/pandas/io/parsers/readers.py in _refine_defaults_read(dialect, delimiter, delim_whitespace, engine, sep, error_bad_lines, warn_bad_lines, on...
closed
2021-07-05T16:40:04
https://api.github.com/repos/huggingface/datasets/issues/2593/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2593", "html_url": "https://github.com/huggingface/datasets/pull/2593", "diff_url": "https://github.com/huggingface/datasets/pull/2593.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2593.patch", "merged_at": "2021-07-05T17:14...
true
Support pandas 1.3.0 read_csv Workaround for this issue in pandas 1.3.0 : https://github.com/pandas-dev/pandas/issues/42387 The csv reader raises an error: ```python /usr/local/lib/python3.7/dist-packages/pandas/io/parsers/readers.py in _refine_defaults_read(dialect, delimiter, delim_whitespace, engine, sep, error...
[]
https://api.github.com/repos/huggingface/datasets/issues/2592
2,592
Add c4.noclean infos
Adding the data files checksums and the dataset size of the c4.noclean configuration of the C4 dataset
closed
2021-07-05T12:51:40
https://api.github.com/repos/huggingface/datasets/issues/2592/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2592", "html_url": "https://github.com/huggingface/datasets/pull/2592", "diff_url": "https://github.com/huggingface/datasets/pull/2592.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2592.patch", "merged_at": "2021-07-05T13:15...
true
Add c4.noclean infos Adding the data files checksums and the dataset size of the c4.noclean configuration of the C4 dataset
[]
https://api.github.com/repos/huggingface/datasets/issues/2591
2,591
Cached dataset overflowing disk space
I'm training a Swedish Wav2vec2 model on a Linux GPU and having issues that the huggingface cached dataset folder is completely filling up my disk space (I'm training on a dataset of around 500 gb). The cache folder is 500gb (and now my disk space is full). Is there a way to toggle caching or set the caching to b...
closed
2021-07-05T10:43:19
https://api.github.com/repos/huggingface/datasets/issues/2591/comments
null
false
Cached dataset overflowing disk space I'm training a Swedish Wav2vec2 model on a Linux GPU and having issues that the huggingface cached dataset folder is completely filling up my disk space (I'm training on a dataset of around 500 gb). The cache folder is 500gb (and now my disk space is full). Is there a way to ...
[ "Hi! I'm transferring this issue over to `datasets`", "I'm using the datasets concatenate dataset to combine the datasets and then train.\r\ntrain_dataset = concatenate_datasets([dataset1, dataset2, common_voice_train])\r\n\r\n", "Hi @BirgerMoell.\r\n\r\nYou have several options:\r\n- to set caching to be store...
https://api.github.com/repos/huggingface/datasets/issues/2590
2,590
Add language tags
This PR adds some missing language tags needed for ASR datasets in #2565
closed
2021-07-05T10:39:57
https://api.github.com/repos/huggingface/datasets/issues/2590/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2590", "html_url": "https://github.com/huggingface/datasets/pull/2590", "diff_url": "https://github.com/huggingface/datasets/pull/2590.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2590.patch", "merged_at": "2021-07-05T10:58...
true
Add language tags This PR adds some missing language tags needed for ASR datasets in #2565
[]
https://api.github.com/repos/huggingface/datasets/issues/2589
2,589
Support multilabel metrics
Currently, multilabel metrics are not supported because `predictions` and `references` are defined as `Value("int32")`. This PR creates a new feature type `OptionalSequence` which can act as either `Value("int32")` or `Sequence(Value("int32"))`, depending on the data passed. Close #2554.
closed
2021-07-05T08:19:25
https://api.github.com/repos/huggingface/datasets/issues/2589/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2589", "html_url": "https://github.com/huggingface/datasets/pull/2589", "diff_url": "https://github.com/huggingface/datasets/pull/2589.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2589.patch", "merged_at": "2021-07-08T08:40...
true
Support multilabel metrics Currently, multilabel metrics are not supported because `predictions` and `references` are defined as `Value("int32")`. This PR creates a new feature type `OptionalSequence` which can act as either `Value("int32")` or `Sequence(Value("int32"))`, depending on the data passed. Close #25...
[ "Hi ! Thanks for the fix :)\r\n\r\nIf I understand correctly, `OptionalSequence` doesn't have an associated arrow type that we know in advance unlike the other feature types, because it depends on the type of the examples.\r\n\r\nFor example, I tested this and it raises an error:\r\n```python\r\nimport datasets as ...
https://api.github.com/repos/huggingface/datasets/issues/2588
2,588
Fix test_is_small_dataset
Remove environment variable fixture `env_max_in_memory_dataset_size`. This fixture does not work because env variable is read in datasets.config when first loading datasets, and it is never reread during tests.
closed
2021-07-05T07:46:26
https://api.github.com/repos/huggingface/datasets/issues/2588/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2588", "html_url": "https://github.com/huggingface/datasets/pull/2588", "diff_url": "https://github.com/huggingface/datasets/pull/2588.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2588.patch", "merged_at": "2021-07-06T17:09...
true
Fix test_is_small_dataset Remove environment variable fixture `env_max_in_memory_dataset_size`. This fixture does not work because env variable is read in datasets.config when first loading datasets, and it is never reread during tests.
[]
https://api.github.com/repos/huggingface/datasets/issues/2587
2,587
Add aiohttp to tests extras require
Currently, none of the streaming tests are runned within our CI test suite, because the streaming tests require aiohttp and this is missing from our tests extras require dependencies. Our CI test suite should be exhaustive and test all the library functionalities.
closed
2021-07-05T07:14:01
https://api.github.com/repos/huggingface/datasets/issues/2587/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2587", "html_url": "https://github.com/huggingface/datasets/pull/2587", "diff_url": "https://github.com/huggingface/datasets/pull/2587.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2587.patch", "merged_at": "2021-07-05T09:04...
true
Add aiohttp to tests extras require Currently, none of the streaming tests are runned within our CI test suite, because the streaming tests require aiohttp and this is missing from our tests extras require dependencies. Our CI test suite should be exhaustive and test all the library functionalities.
[]
https://api.github.com/repos/huggingface/datasets/issues/2586
2,586
Fix misalignment in SQuAD
Fix misalignment between: - the answer text and - the answer_start within the context by keeping original leading blank spaces in the context. Fix #2585.
closed
2021-07-05T06:42:20
https://api.github.com/repos/huggingface/datasets/issues/2586/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2586", "html_url": "https://github.com/huggingface/datasets/pull/2586", "diff_url": "https://github.com/huggingface/datasets/pull/2586.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2586.patch", "merged_at": "2021-07-07T13:18...
true
Fix misalignment in SQuAD Fix misalignment between: - the answer text and - the answer_start within the context by keeping original leading blank spaces in the context. Fix #2585.
[]
https://api.github.com/repos/huggingface/datasets/issues/2585
2,585
sqaud_v2 dataset contains misalignment between the answer text and the context value at the answer index
## Describe the bug The built in huggingface squad_v2 dataset that you can access via datasets.load_dataset contains mis-alignment between the answers['text'] and the characters in the context at the location specified by answers['answer_start']. For example: id = '56d1f453e7d4791d009025bd' answers = {'text': ['P...
closed
2021-07-04T15:39:49
https://api.github.com/repos/huggingface/datasets/issues/2585/comments
null
false
sqaud_v2 dataset contains misalignment between the answer text and the context value at the answer index ## Describe the bug The built in huggingface squad_v2 dataset that you can access via datasets.load_dataset contains mis-alignment between the answers['text'] and the characters in the context at the location speci...
[ "Hi @mmajurski, thanks for reporting this issue.\r\n\r\nIndeed this misalignment arises because the source dataset context field contains leading blank spaces (and these are counted within the answer_start), while our datasets loading script removes these leading blank spaces.\r\n\r\nI'm going to fix our script so ...
https://api.github.com/repos/huggingface/datasets/issues/2584
2,584
wi_locness: reference latest leaderboard on codalab
The dataset's author asked me to put this codalab link into the dataset's README.
closed
2021-07-02T20:26:22
https://api.github.com/repos/huggingface/datasets/issues/2584/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2584", "html_url": "https://github.com/huggingface/datasets/pull/2584", "diff_url": "https://github.com/huggingface/datasets/pull/2584.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2584.patch", "merged_at": "2021-07-05T09:06...
true
wi_locness: reference latest leaderboard on codalab The dataset's author asked me to put this codalab link into the dataset's README.
[]
https://api.github.com/repos/huggingface/datasets/issues/2583
2,583
Error iteration over IterableDataset using Torch DataLoader
## Describe the bug I have an IterableDataset (created using streaming=True) and I am trying to create batches using Torch DataLoader class by passing this IterableDataset to it. This throws error which is pasted below. I can do the same by using Torch IterableDataset. One thing I noticed is that in the former case wh...
closed
2021-07-02T19:55:58
https://api.github.com/repos/huggingface/datasets/issues/2583/comments
null
false
Error iteration over IterableDataset using Torch DataLoader ## Describe the bug I have an IterableDataset (created using streaming=True) and I am trying to create batches using Torch DataLoader class by passing this IterableDataset to it. This throws error which is pasted below. I can do the same by using Torch Iterab...
[ "Hi ! This is because you first need to format the dataset for pytorch:\r\n\r\n```python\r\n>>> import torch\r\n>>> from datasets import load_dataset\r\n>>> dataset = load_dataset('oscar', \"unshuffled_deduplicated_en\", split='train', streaming=True)\r\n>>> torch_iterable_dataset = dataset.with_format(\"torch\")\r...
https://api.github.com/repos/huggingface/datasets/issues/2582
2,582
Add skip and take
As discussed in https://github.com/huggingface/datasets/pull/2375#discussion_r657084544 I added the `IterableDataset.skip` and `IterableDataset.take` methods that allows to do basic splitting of iterable datasets. You can create new dataset with the first `n` examples using `IterableDataset.take()`, or you can get a...
closed
2021-07-02T15:10:19
https://api.github.com/repos/huggingface/datasets/issues/2582/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2582", "html_url": "https://github.com/huggingface/datasets/pull/2582", "diff_url": "https://github.com/huggingface/datasets/pull/2582.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2582.patch", "merged_at": "2021-07-05T16:06...
true
Add skip and take As discussed in https://github.com/huggingface/datasets/pull/2375#discussion_r657084544 I added the `IterableDataset.skip` and `IterableDataset.take` methods that allows to do basic splitting of iterable datasets. You can create new dataset with the first `n` examples using `IterableDataset.take()`...
[ "@lhoestq looks good. I tried with https://huggingface.co/datasets/vblagoje/wikipedia_snippets_streamed and it worked nicely. I would add more unit tests for edge cases. What happens if the n is larger than the total number of samples? Just to make sure these cases are handled properly. ", "Yup I'll add the tests...
https://api.github.com/repos/huggingface/datasets/issues/2581
2,581
Faster search_batch for ElasticsearchIndex due to threading
Hey, I think it makes sense to perform search_batch threaded, so ES can perform search in parallel. Cheers!
closed
2021-07-02T13:42:07
https://api.github.com/repos/huggingface/datasets/issues/2581/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2581", "html_url": "https://github.com/huggingface/datasets/pull/2581", "diff_url": "https://github.com/huggingface/datasets/pull/2581.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2581.patch", "merged_at": "2021-07-12T09:52...
true
Faster search_batch for ElasticsearchIndex due to threading Hey, I think it makes sense to perform search_batch threaded, so ES can perform search in parallel. Cheers!
[]
https://api.github.com/repos/huggingface/datasets/issues/2580
2,580
Fix Counter import
Import from `collections` instead of `typing`.
closed
2021-07-02T13:21:48
https://api.github.com/repos/huggingface/datasets/issues/2580/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2580", "html_url": "https://github.com/huggingface/datasets/pull/2580", "diff_url": "https://github.com/huggingface/datasets/pull/2580.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2580.patch", "merged_at": "2021-07-02T14:37...
true
Fix Counter import Import from `collections` instead of `typing`.
[]
https://api.github.com/repos/huggingface/datasets/issues/2579
2,579
Fix BibTeX entry
Add missing contributor to BibTeX entry. cc: @abhishekkrthakur @thomwolf
closed
2021-07-02T07:10:40
https://api.github.com/repos/huggingface/datasets/issues/2579/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2579", "html_url": "https://github.com/huggingface/datasets/pull/2579", "diff_url": "https://github.com/huggingface/datasets/pull/2579.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2579.patch", "merged_at": "2021-07-02T07:33...
true
Fix BibTeX entry Add missing contributor to BibTeX entry. cc: @abhishekkrthakur @thomwolf
[]
https://api.github.com/repos/huggingface/datasets/issues/2578
2,578
Support Zstandard compressed files
Close #2572. cc: @thomwolf
closed
2021-07-01T20:22:34
https://api.github.com/repos/huggingface/datasets/issues/2578/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2578", "html_url": "https://github.com/huggingface/datasets/pull/2578", "diff_url": "https://github.com/huggingface/datasets/pull/2578.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2578.patch", "merged_at": "2021-07-05T10:50...
true
Support Zstandard compressed files Close #2572. cc: @thomwolf
[ "> What if people want to run some tests without having zstandard ?\r\n> Usually what we do is add a decorator @require_zstandard for example\r\n\r\n@lhoestq I think I'm missing something here...\r\n\r\nTests are a *development* tool (to ensure we deliver a good quality lib), not something we offer to the end users...
https://api.github.com/repos/huggingface/datasets/issues/2576
2,576
Add mC4
AllenAI is now hosting the processed C4 and mC4 dataset in this repo: https://huggingface.co/datasets/allenai/c4 Thanks a lot to them ! In this PR I added the mC4 dataset builder. It supports 108 languages You can load it with ```python from datasets import load_dataset en_mc4 = load_dataset("mc4", "en") f...
closed
2021-07-01T15:51:25
https://api.github.com/repos/huggingface/datasets/issues/2576/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2576", "html_url": "https://github.com/huggingface/datasets/pull/2576", "diff_url": "https://github.com/huggingface/datasets/pull/2576.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2576.patch", "merged_at": "2021-07-02T14:50...
true
Add mC4 AllenAI is now hosting the processed C4 and mC4 dataset in this repo: https://huggingface.co/datasets/allenai/c4 Thanks a lot to them ! In this PR I added the mC4 dataset builder. It supports 108 languages You can load it with ```python from datasets import load_dataset en_mc4 = load_dataset("mc4", ...
[]
https://api.github.com/repos/huggingface/datasets/issues/2575
2,575
Add C4
The old code for the C4 dataset was to generate the C4 with Apache Beam, as in Tensorflow Datasets. However AllenAI is now hosting the processed C4 dataset in this repo: https://huggingface.co/datasets/allenai/c4 Thanks a lot to them for their amazing work ! In this PR I changed the script to download and prepare ...
closed
2021-07-01T13:58:08
https://api.github.com/repos/huggingface/datasets/issues/2575/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2575", "html_url": "https://github.com/huggingface/datasets/pull/2575", "diff_url": "https://github.com/huggingface/datasets/pull/2575.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2575.patch", "merged_at": "2021-07-02T14:50...
true
Add C4 The old code for the C4 dataset was to generate the C4 with Apache Beam, as in Tensorflow Datasets. However AllenAI is now hosting the processed C4 dataset in this repo: https://huggingface.co/datasets/allenai/c4 Thanks a lot to them for their amazing work ! In this PR I changed the script to download and p...
[ "C4 has broken:\r\n\r\nIn offline mode C4 downloader will request a hash from nowhere\r\n\r\n> ValueError: Couldn't find cache for allenai/c4 for config 'default-c2cff5d7da675c1c'\r\n\r\n\r\nwhile the cache files:\r\n\r\n> Available configs in the cache: ['default-b04fc8a0b8562884', 'default-c7bc8b0aefc5e48f']\r\n\...
https://api.github.com/repos/huggingface/datasets/issues/2574
2,574
Add streaming in load a dataset docs
Mention dataset streaming on the "loading a dataset" page of the documentation
closed
2021-07-01T09:32:53
https://api.github.com/repos/huggingface/datasets/issues/2574/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2574", "html_url": "https://github.com/huggingface/datasets/pull/2574", "diff_url": "https://github.com/huggingface/datasets/pull/2574.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2574.patch", "merged_at": "2021-07-01T14:12...
true
Add streaming in load a dataset docs Mention dataset streaming on the "loading a dataset" page of the documentation
[]
https://api.github.com/repos/huggingface/datasets/issues/2573
2,573
Finding right block-size with JSON loading difficult for user
As reported by @thomwolf, while loading a JSON Lines file with "json" loading script, he gets > json.decoder.JSONDecodeError: Extra data: line 2 column 1 (char 383)
open
2021-07-01T08:48:35
https://api.github.com/repos/huggingface/datasets/issues/2573/comments
null
false
Finding right block-size with JSON loading difficult for user As reported by @thomwolf, while loading a JSON Lines file with "json" loading script, he gets > json.decoder.JSONDecodeError: Extra data: line 2 column 1 (char 383)
[ "This was actually a second error arising from a too small block-size in the json reader.\r\n\r\nFinding the right block size is difficult for the layman user" ]
https://api.github.com/repos/huggingface/datasets/issues/2572
2,572
Support Zstandard compressed files
Add support for Zstandard compressed files: https://facebook.github.io/zstd/
closed
2021-07-01T08:37:04
https://api.github.com/repos/huggingface/datasets/issues/2572/comments
null
false
Support Zstandard compressed files Add support for Zstandard compressed files: https://facebook.github.io/zstd/
[ "I am trying to load a dataset using Hugging Face Datasets load_dataset method. I am getting the value error as show below. Can someone help with this? I am using Windows laptop and Google Colab notebook.\r\n\r\n```\r\n!pip install zstandard\r\nfrom datasets import load_dataset\r\n\r\nlds = load_dataset(\r\n \"j...
https://api.github.com/repos/huggingface/datasets/issues/2571
2,571
Filter expected warning log from transformers
Close #2569.
closed
2021-06-30T14:48:19
https://api.github.com/repos/huggingface/datasets/issues/2571/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2571", "html_url": "https://github.com/huggingface/datasets/pull/2571", "diff_url": "https://github.com/huggingface/datasets/pull/2571.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2571.patch", "merged_at": "2021-07-02T04:08...
true
Filter expected warning log from transformers Close #2569.
[ "I think the failing test has nothing to do with my PR..." ]
https://api.github.com/repos/huggingface/datasets/issues/2570
2,570
Minor fix docs format for bertscore
Minor fix docs format for bertscore: - link to README - format of KWARGS_DESCRIPTION
closed
2021-06-30T07:42:12
https://api.github.com/repos/huggingface/datasets/issues/2570/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2570", "html_url": "https://github.com/huggingface/datasets/pull/2570", "diff_url": "https://github.com/huggingface/datasets/pull/2570.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2570.patch", "merged_at": "2021-06-30T15:31...
true
Minor fix docs format for bertscore Minor fix docs format for bertscore: - link to README - format of KWARGS_DESCRIPTION
[]
https://api.github.com/repos/huggingface/datasets/issues/2569
2,569
Weights of model checkpoint not initialized for RobertaModel for Bertscore
When applying bertscore out of the box, ```Some weights of the model checkpoint at roberta-large were not used when initializing RobertaModel: ['lm_head.decoder.weight', 'lm_head.bias', 'lm_head.dense.bias', 'lm_head.layer_norm.bias', 'lm_head.dense.weight', 'lm_head.layer_norm.weight']``` Following the typical ...
closed
2021-06-29T18:55:23
https://api.github.com/repos/huggingface/datasets/issues/2569/comments
null
false
Weights of model checkpoint not initialized for RobertaModel for Bertscore When applying bertscore out of the box, ```Some weights of the model checkpoint at roberta-large were not used when initializing RobertaModel: ['lm_head.decoder.weight', 'lm_head.bias', 'lm_head.dense.bias', 'lm_head.layer_norm.bias', 'lm_he...
[ "Hi @suzyahyah, thanks for reporting.\r\n\r\nThe message you get is indeed not an error message, but a warning coming from Hugging Face `transformers`. The complete warning message is:\r\n```\r\nSome weights of the model checkpoint at roberta-large were not used when initializing RobertaModel: ['lm_head.decoder.wei...
https://api.github.com/repos/huggingface/datasets/issues/2568
2,568
Add interleave_datasets for map-style datasets
### Add interleave_datasets for map-style datasets Add support for map-style datasets (i.e. `Dataset` objects) in `interleave_datasets`. It was only supporting iterable datasets (i.e. `IterableDataset` objects). ### Implementation details It works by concatenating the datasets and then re-order the indices to...
closed
2021-06-29T17:19:24
https://api.github.com/repos/huggingface/datasets/issues/2568/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2568", "html_url": "https://github.com/huggingface/datasets/pull/2568", "diff_url": "https://github.com/huggingface/datasets/pull/2568.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2568.patch", "merged_at": "2021-07-01T09:33...
true
Add interleave_datasets for map-style datasets ### Add interleave_datasets for map-style datasets Add support for map-style datasets (i.e. `Dataset` objects) in `interleave_datasets`. It was only supporting iterable datasets (i.e. `IterableDataset` objects). ### Implementation details It works by concatenatin...
[]
https://api.github.com/repos/huggingface/datasets/issues/2567
2,567
Add ASR task and new languages to resources
This PR adds a new `automatic-speech-recognition` task to the list of supported tasks in `tasks.json` and also includes a few new languages missing from `common_voice`. Note: I used the [Papers with Code list](https://www.paperswithcode.com/area/speech/speech-recognition) as inspiration for the ASR subtasks
closed
2021-06-29T17:18:01
https://api.github.com/repos/huggingface/datasets/issues/2567/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2567", "html_url": "https://github.com/huggingface/datasets/pull/2567", "diff_url": "https://github.com/huggingface/datasets/pull/2567.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2567.patch", "merged_at": "2021-07-01T09:42...
true
Add ASR task and new languages to resources This PR adds a new `automatic-speech-recognition` task to the list of supported tasks in `tasks.json` and also includes a few new languages missing from `common_voice`. Note: I used the [Papers with Code list](https://www.paperswithcode.com/area/speech/speech-recognition) ...
[]
https://api.github.com/repos/huggingface/datasets/issues/2566
2,566
fix Dataset.map when num_procs > num rows
closes #2470 ## Testing notes To run updated tests: ```sh pytest tests/test_arrow_dataset.py -k "BaseDatasetTest and test_map_multiprocessing" -s ``` With Python code (to view warning): ```python from datasets import Dataset dataset = Dataset.from_dict({"x": ["sample"]}) print(len(dataset)) dataset.map...
closed
2021-06-29T15:07:07
https://api.github.com/repos/huggingface/datasets/issues/2566/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2566", "html_url": "https://github.com/huggingface/datasets/pull/2566", "diff_url": "https://github.com/huggingface/datasets/pull/2566.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2566.patch", "merged_at": "2021-07-01T09:11...
true
fix Dataset.map when num_procs > num rows closes #2470 ## Testing notes To run updated tests: ```sh pytest tests/test_arrow_dataset.py -k "BaseDatasetTest and test_map_multiprocessing" -s ``` With Python code (to view warning): ```python from datasets import Dataset dataset = Dataset.from_dict({"x": ["sa...
[]
https://api.github.com/repos/huggingface/datasets/issues/2565
2,565
Inject templates for ASR datasets
This PR adds ASR templates for 5 of the most common speech datasets on the Hub, where "common" is defined by the number of models trained on them. I also fixed a bunch of the tags in the READMEs 😎
closed
2021-06-29T10:02:01
https://api.github.com/repos/huggingface/datasets/issues/2565/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2565", "html_url": "https://github.com/huggingface/datasets/pull/2565", "diff_url": "https://github.com/huggingface/datasets/pull/2565.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2565.patch", "merged_at": "2021-07-05T14:26...
true
Inject templates for ASR datasets This PR adds ASR templates for 5 of the most common speech datasets on the Hub, where "common" is defined by the number of models trained on them. I also fixed a bunch of the tags in the READMEs 😎
[ "Wait until #2567 is merged so we can benefit from the tagger :)", "thanks for the feedback @lhoestq! i've added the new language codes and this PR should be ready for a merge :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2564
2,564
concatenate_datasets for iterable datasets
Currently `concatenate_datasets` only works for map-style `Dataset`. It would be nice to have it work for `IterableDataset` objects as well. It would simply chain the iterables of the iterable datasets.
closed
2021-06-29T08:59:41
https://api.github.com/repos/huggingface/datasets/issues/2564/comments
null
false
concatenate_datasets for iterable datasets Currently `concatenate_datasets` only works for map-style `Dataset`. It would be nice to have it work for `IterableDataset` objects as well. It would simply chain the iterables of the iterable datasets.
[ "It is probably worth noting here that the [documentation](https://huggingface.co/docs/datasets/process#concatenate) is misleading (indicating that it does work for IterableDatasets):\r\n\r\n> You can also mix several datasets together by taking alternating examples from each one to create a new dataset. This is kn...
https://api.github.com/repos/huggingface/datasets/issues/2563
2,563
interleave_datasets for map-style datasets
Currently the `interleave_datasets` functions only works for `IterableDataset`. Let's make it work for map-style `Dataset` objects as well. It would work the same way: either alternate between the datasets in order or randomly given probabilities specified by the user.
closed
2021-06-29T08:57:24
https://api.github.com/repos/huggingface/datasets/issues/2563/comments
null
false
interleave_datasets for map-style datasets Currently the `interleave_datasets` functions only works for `IterableDataset`. Let's make it work for map-style `Dataset` objects as well. It would work the same way: either alternate between the datasets in order or randomly given probabilities specified by the user.
[]
https://api.github.com/repos/huggingface/datasets/issues/2562
2,562
Minor fix in loading metrics docs
Make some minor fixes in "Loading metrics" docs.
closed
2021-06-29T07:55:11
https://api.github.com/repos/huggingface/datasets/issues/2562/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2562", "html_url": "https://github.com/huggingface/datasets/pull/2562", "diff_url": "https://github.com/huggingface/datasets/pull/2562.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2562.patch", "merged_at": "2021-06-29T17:21...
true
Minor fix in loading metrics docs Make some minor fixes in "Loading metrics" docs.
[]
https://api.github.com/repos/huggingface/datasets/issues/2561
2,561
Existing cache for local dataset builder file updates is ignored with `ignore_verifications=True`
## Describe the bug If i have local file defining a dataset builder class and I load it using `load_dataset` functionality, the existing cache is ignored whenever the file is update even with `ignore_verifications=True`. This slows down debugging and cache generator for very large datasets. ## Steps to reproduce th...
closed
2021-06-29T07:43:03
https://api.github.com/repos/huggingface/datasets/issues/2561/comments
null
false
Existing cache for local dataset builder file updates is ignored with `ignore_verifications=True` ## Describe the bug If i have local file defining a dataset builder class and I load it using `load_dataset` functionality, the existing cache is ignored whenever the file is update even with `ignore_verifications=True`. ...
[ "Hi ! I just tried to reproduce what you said:\r\n- create a local builder class\r\n- use `load_dataset`\r\n- update the builder class code\r\n- use `load_dataset` again (with or without `ignore_verifications=True`)\r\nAnd it creates a new cache, as expected.\r\n\r\nWhat modifications did you do to your builder's c...
https://api.github.com/repos/huggingface/datasets/issues/2560
2,560
fix Dataset.map when num_procs > num rows
closes #2470 ## Testing notes To run updated tests: ```sh pytest tests/test_arrow_dataset.py -k "BaseDatasetTest and test_map_multiprocessing" -s ``` With Python code (to view warning): ```python from datasets import Dataset dataset = Dataset.from_dict({"x": ["sample"]}) print(len(dataset)) dataset.map...
closed
2021-06-29T02:24:11
https://api.github.com/repos/huggingface/datasets/issues/2560/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2560", "html_url": "https://github.com/huggingface/datasets/pull/2560", "diff_url": "https://github.com/huggingface/datasets/pull/2560.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2560.patch", "merged_at": null }
true
fix Dataset.map when num_procs > num rows closes #2470 ## Testing notes To run updated tests: ```sh pytest tests/test_arrow_dataset.py -k "BaseDatasetTest and test_map_multiprocessing" -s ``` With Python code (to view warning): ```python from datasets import Dataset dataset = Dataset.from_dict({"x": ["sa...
[ "Hi ! Thanks for fixing this :)\r\n\r\nLooks like you have tons of changes due to code formatting.\r\nWe're using `black` for this, with a custom line length. To run our code formatting, you just need to run\r\n```\r\nmake style\r\n```\r\n\r\nThen for the windows error in the CI, I'm looking into it. It's probably ...
https://api.github.com/repos/huggingface/datasets/issues/2559
2,559
Memory usage consistently increases when processing a dataset with `.map`
## Describe the bug I have a HF dataset with image paths stored in it and I am trying to load those image paths using `.map` with `num_proc=80`. I am noticing that the memory usage consistently keeps on increasing with time. I tried using `DEFAULT_WRITER_BATCH_SIZE=10` in the builder to decrease arrow writer's batch...
closed
2021-06-28T18:31:58
https://api.github.com/repos/huggingface/datasets/issues/2559/comments
null
false
Memory usage consistently increases when processing a dataset with `.map` ## Describe the bug I have a HF dataset with image paths stored in it and I am trying to load those image paths using `.map` with `num_proc=80`. I am noticing that the memory usage consistently keeps on increasing with time. I tried using `DEF...
[ "Hi ! Can you share the function you pass to `map` ?\r\nI know you mentioned it would be hard to share some code but this would really help to understand what happened", "This is the same behavior as in #4883, so I'm closing this issue as a duplicate. " ]
https://api.github.com/repos/huggingface/datasets/issues/2558
2,558
Update: WebNLG - update checksums
The master branch changed so I computed the new checksums. I also pinned a specific revision so that it doesn't happen again in the future. Fix https://github.com/huggingface/datasets/issues/2553
closed
2021-06-28T16:16:37
https://api.github.com/repos/huggingface/datasets/issues/2558/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2558", "html_url": "https://github.com/huggingface/datasets/pull/2558", "diff_url": "https://github.com/huggingface/datasets/pull/2558.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2558.patch", "merged_at": "2021-06-28T17:23...
true
Update: WebNLG - update checksums The master branch changed so I computed the new checksums. I also pinned a specific revision so that it doesn't happen again in the future. Fix https://github.com/huggingface/datasets/issues/2553
[]
https://api.github.com/repos/huggingface/datasets/issues/2557
2,557
Fix `fever` keys
The keys has duplicates since they were reset to 0 after each file. I fixed it by taking into account the file index as well.
closed
2021-06-28T14:27:02
https://api.github.com/repos/huggingface/datasets/issues/2557/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2557", "html_url": "https://github.com/huggingface/datasets/pull/2557", "diff_url": "https://github.com/huggingface/datasets/pull/2557.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2557.patch", "merged_at": "2021-06-28T16:11...
true
Fix `fever` keys The keys has duplicates since they were reset to 0 after each file. I fixed it by taking into account the file index as well.
[]
https://api.github.com/repos/huggingface/datasets/issues/2556
2,556
Better DuplicateKeysError error to help the user debug the issue
As mentioned in https://github.com/huggingface/datasets/issues/2552 it would be nice to improve the error message when a dataset fails to build because there are duplicate example keys. The current one is ```python datasets.keyhash.DuplicatedKeysError: FAILURE TO GENERATE DATASET ! Found duplicate Key: 48 Keys s...
closed
2021-06-28T13:50:57
https://api.github.com/repos/huggingface/datasets/issues/2556/comments
null
false
Better DuplicateKeysError error to help the user debug the issue As mentioned in https://github.com/huggingface/datasets/issues/2552 it would be nice to improve the error message when a dataset fails to build because there are duplicate example keys. The current one is ```python datasets.keyhash.DuplicatedKeysErro...
[ "excuse me, my `datasets` version is `2.2.2`, but I also just see the error info like \r\n```\r\nDuplicatedKeysError: FAILURE TO GENERATE DATASET !\r\nFound duplicate Key: 0\r\nKeys should be unique and deterministic in nature\r\n```", "Hi ! for which dataset do you have this error ?\r\n\r\nAlso note that this is...