url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/2453 | 2,453 | Keep original features order | When loading a Dataset from a JSON file whose column names are not sorted alphabetically, we should get the same column name order, whether we pass features (in the same order as in the file) or not.
I found this issue while working on #2366. | closed | 2021-06-07T16:26:38 | https://api.github.com/repos/huggingface/datasets/issues/2453/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2453",
"html_url": "https://github.com/huggingface/datasets/pull/2453",
"diff_url": "https://github.com/huggingface/datasets/pull/2453.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2453.patch",
"merged_at": "2021-06-15T15:43... | true | Keep original features order
When loading a Dataset from a JSON file whose column names are not sorted alphabetically, we should get the same column name order, whether we pass features (in the same order as in the file) or not.
I found this issue while working on #2366. | [
"The arrow writer was supposing that the columns were always in the sorted order. I just pushed a fix to reorder the arrays accordingly to the schema. It was failing for many datasets like squad",
"and obviously it broke everything",
"Feel free to revert my commit. I can investigate this in the coming days",
... |
https://api.github.com/repos/huggingface/datasets/issues/2452 | 2,452 | MRPC test set differences between torch and tensorflow datasets | ## Describe the bug
When using `load_dataset("glue", "mrpc")` to load the MRPC dataset, the test set includes the labels. When using `tensorflow_datasets.load('glue/{}'.format('mrpc'))` to load the dataset the test set does not contain the labels. There should be consistency between torch and tensorflow ways of import... | closed | 2021-06-07T14:20:26 | https://api.github.com/repos/huggingface/datasets/issues/2452/comments | null | false | MRPC test set differences between torch and tensorflow datasets
## Describe the bug
When using `load_dataset("glue", "mrpc")` to load the MRPC dataset, the test set includes the labels. When using `tensorflow_datasets.load('glue/{}'.format('mrpc'))` to load the dataset the test set does not contain the labels. There s... | [
"Realized that `tensorflow_datasets` is not provided by Huggingface and should therefore raise the issue there."
] |
https://api.github.com/repos/huggingface/datasets/issues/2451 | 2,451 | Mention that there are no answers in adversarial_qa test set | As mention in issue https://github.com/huggingface/datasets/issues/2447, there are no answers in the test set | closed | 2021-06-07T08:13:57 | https://api.github.com/repos/huggingface/datasets/issues/2451/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2451",
"html_url": "https://github.com/huggingface/datasets/pull/2451",
"diff_url": "https://github.com/huggingface/datasets/pull/2451.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2451.patch",
"merged_at": "2021-06-07T08:34... | true | Mention that there are no answers in adversarial_qa test set
As mention in issue https://github.com/huggingface/datasets/issues/2447, there are no answers in the test set | [] |
https://api.github.com/repos/huggingface/datasets/issues/2450 | 2,450 | BLUE file not found | Hi, I'm having the following issue when I try to load the `blue` metric.
```shell
import datasets
metric = datasets.load_metric('blue')
Traceback (most recent call last):
File "/home/irfan/environments/Perplexity_Transformers/lib/python3.6/site-packages/datasets/load.py", line 320, in prepare_module
local... | closed | 2021-06-06T17:01:54 | https://api.github.com/repos/huggingface/datasets/issues/2450/comments | null | false | BLUE file not found
Hi, I'm having the following issue when I try to load the `blue` metric.
```shell
import datasets
metric = datasets.load_metric('blue')
Traceback (most recent call last):
File "/home/irfan/environments/Perplexity_Transformers/lib/python3.6/site-packages/datasets/load.py", line 320, in prepa... | [
"Hi ! The `blue` metric doesn't exist, but the `bleu` metric does.\r\nYou can get the full list of metrics [here](https://github.com/huggingface/datasets/tree/master/metrics) or by running\r\n```python\r\nfrom datasets import list_metrics\r\n\r\nprint(list_metrics())\r\n```",
"Ah, my mistake. Thanks for correctin... |
https://api.github.com/repos/huggingface/datasets/issues/2449 | 2,449 | Update `xor_tydi_qa` url to v1.1 | The dataset is updated and the old url no longer works. So I updated it.
I faced a bug while trying to fix this. Documenting the solution here. Maybe we can add it to the doc (`CONTRIBUTING.md` and `ADD_NEW_DATASET.md`).
> And to make the command work without the ExpectedMoreDownloadedFiles error, you just need to ... | closed | 2021-06-06T09:44:58 | https://api.github.com/repos/huggingface/datasets/issues/2449/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2449",
"html_url": "https://github.com/huggingface/datasets/pull/2449",
"diff_url": "https://github.com/huggingface/datasets/pull/2449.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2449.patch",
"merged_at": "2021-06-07T08:31... | true | Update `xor_tydi_qa` url to v1.1
The dataset is updated and the old url no longer works. So I updated it.
I faced a bug while trying to fix this. Documenting the solution here. Maybe we can add it to the doc (`CONTRIBUTING.md` and `ADD_NEW_DATASET.md`).
> And to make the command work without the ExpectedMoreDownloa... | [
"Just noticed while \r\n```load_dataset('local_path/datastes/xor_tydi_qa')``` works,\r\n```load_dataset('xor_tydi_qa')``` \r\noutputs an error: \r\n`\r\nFileNotFoundError: Couldn't find file at https://nlp.cs.washington.edu/xorqa/XORQA_site/data/xor_dev_retrieve_eng_span.jsonl\r\n`\r\n(the old url)\r\n\r\nI tired c... |
https://api.github.com/repos/huggingface/datasets/issues/2448 | 2,448 | Fix flores download link | closed | 2021-06-05T17:30:24 | https://api.github.com/repos/huggingface/datasets/issues/2448/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2448",
"html_url": "https://github.com/huggingface/datasets/pull/2448",
"diff_url": "https://github.com/huggingface/datasets/pull/2448.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2448.patch",
"merged_at": "2021-06-07T08:18... | true | Fix flores download link
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/2447 | 2,447 | dataset adversarial_qa has no answers in the "test" set | ## Describe the bug
When loading the adversarial_qa dataset the 'test' portion has no answers. Only the 'train' and 'validation' portions do. This occurs with all four of the configs ('adversarialQA', 'dbidaf', 'dbert', 'droberta')
## Steps to reproduce the bug
```
from datasets import load_dataset
examples ... | closed | 2021-06-05T14:57:38 | https://api.github.com/repos/huggingface/datasets/issues/2447/comments | null | false | dataset adversarial_qa has no answers in the "test" set
## Describe the bug
When loading the adversarial_qa dataset the 'test' portion has no answers. Only the 'train' and 'validation' portions do. This occurs with all four of the configs ('adversarialQA', 'dbidaf', 'dbert', 'droberta')
## Steps to reproduce the ... | [
"Hi ! I'm pretty sure that the answers are not made available for the test set on purpose because it is part of the DynaBench benchmark, for which you can submit your predictions on the website.\r\nIn any case we should mention this in the dataset card of this dataset.",
"Makes sense, but not intuitive for someon... |
https://api.github.com/repos/huggingface/datasets/issues/2446 | 2,446 | `yelp_polarity` is broken | 
| closed | 2021-06-04T15:44:29 | https://api.github.com/repos/huggingface/datasets/issues/2446/comments | null | false | `yelp_polarity` is broken
| [
"```\r\nFile \"/home/sasha/.local/share/virtualenvs/lib-ogGKnCK_/lib/python3.7/site-packages/streamlit/script_runner.py\", line 332, in _run_script\r\n exec(code, module.__dict__)\r\nFile \"/home/sasha/nlp-viewer/run.py\", line 233, in <module>\r\n configs = get_confs(option)\r\nFile \"/home/sasha/.local/shar... |
https://api.github.com/repos/huggingface/datasets/issues/2445 | 2,445 | Fix broken URLs for bn_hate_speech and covid_tweets_japanese | Closes #2388 | closed | 2021-06-04T14:53:35 | https://api.github.com/repos/huggingface/datasets/issues/2445/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2445",
"html_url": "https://github.com/huggingface/datasets/pull/2445",
"diff_url": "https://github.com/huggingface/datasets/pull/2445.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2445.patch",
"merged_at": "2021-06-04T17:39... | true | Fix broken URLs for bn_hate_speech and covid_tweets_japanese
Closes #2388 | [
"Thanks ! To fix the CI you just have to rename the dummy data file in the dummy_data.zip files",
"thanks for the tip with the dummy data - all fixed now!"
] |
https://api.github.com/repos/huggingface/datasets/issues/2444 | 2,444 | Sentence Boundaries missing in Dataset: xtreme / udpos | I was browsing through annotation guidelines, as suggested by the datasets introduction.
The guidlines saids "There must be exactly one blank line after every sentence, including the last sentence in the file. Empty sentences are not allowed." in the [Sentence Boundaries and Comments section](https://universaldepend... | closed | 2021-06-04T09:10:26 | https://api.github.com/repos/huggingface/datasets/issues/2444/comments | null | false | Sentence Boundaries missing in Dataset: xtreme / udpos
I was browsing through annotation guidelines, as suggested by the datasets introduction.
The guidlines saids "There must be exactly one blank line after every sentence, including the last sentence in the file. Empty sentences are not allowed." in the [Sentence B... | [
"Hi,\r\n\r\nThis is a known issue. More info on this issue can be found in #2061. If you are looking for an open-source contribution, there are step-by-step instructions in the linked issue that you can follow to fix it.",
"Closed by #2466."
] |
https://api.github.com/repos/huggingface/datasets/issues/2443 | 2,443 | Some tests hang on Windows | Currently, several tests hang on Windows if the max path limit of 260 characters is not disabled. This happens due to the changes introduced by #2223 that cause an infinite loop in `WindowsFileLock` described in #2220. This can be very tricky to debug, so I think now is a good time to address these issues/PRs. IMO thr... | closed | 2021-06-03T00:27:30 | https://api.github.com/repos/huggingface/datasets/issues/2443/comments | null | false | Some tests hang on Windows
Currently, several tests hang on Windows if the max path limit of 260 characters is not disabled. This happens due to the changes introduced by #2223 that cause an infinite loop in `WindowsFileLock` described in #2220. This can be very tricky to debug, so I think now is a good time to addres... | [
"Hi ! That would be nice indeed to at least have a warning, since we don't handle the max path length limit.\r\nAlso if we could have an error instead of an infinite loop I'm sure windows users will appreciate that",
"Unfortunately, I know this problem very well... 😅 \r\n\r\nI remember having proposed to throw a... |
https://api.github.com/repos/huggingface/datasets/issues/2442 | 2,442 | add english language tags for ~100 datasets | As discussed on Slack, I have manually checked for ~100 datasets that they have at least one subset in English. This information was missing so adding into the READMEs.
Note that I didn't check all the subsets so it's possible that some of the datasets have subsets in other languages than English... | closed | 2021-06-02T16:24:56 | https://api.github.com/repos/huggingface/datasets/issues/2442/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2442",
"html_url": "https://github.com/huggingface/datasets/pull/2442",
"diff_url": "https://github.com/huggingface/datasets/pull/2442.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2442.patch",
"merged_at": "2021-06-04T09:51... | true | add english language tags for ~100 datasets
As discussed on Slack, I have manually checked for ~100 datasets that they have at least one subset in English. This information was missing so adding into the READMEs.
Note that I didn't check all the subsets so it's possible that some of the datasets have subsets in othe... | [
"Fixing the tags of all the datasets is out of scope for this PR so I'm merging even though the CI fails because of the missing tags"
] |
https://api.github.com/repos/huggingface/datasets/issues/2441 | 2,441 | DuplicatedKeysError on personal dataset | ## Describe the bug
Ever since today, I have been getting a DuplicatedKeysError while trying to load my dataset from my own script.
Error returned when running this line: `dataset = load_dataset('/content/drive/MyDrive/Thesis/Datasets/book_preprocessing/goodreads_maharjan_trimmed_and_nered/goodreadsnered.py')`
Note ... | closed | 2021-06-01T17:59:41 | https://api.github.com/repos/huggingface/datasets/issues/2441/comments | null | false | DuplicatedKeysError on personal dataset
## Describe the bug
Ever since today, I have been getting a DuplicatedKeysError while trying to load my dataset from my own script.
Error returned when running this line: `dataset = load_dataset('/content/drive/MyDrive/Thesis/Datasets/book_preprocessing/goodreads_maharjan_trimm... | [
"Hi ! In your dataset script you must be yielding examples like\r\n```python\r\nfor line in file:\r\n ...\r\n yield key, {...}\r\n```\r\n\r\nSince `datasets` 1.7.0 we enforce the keys to be unique.\r\nHowever it looks like your examples generator creates duplicate keys: at least two examples have key 0.\r\n\r... |
https://api.github.com/repos/huggingface/datasets/issues/2440 | 2,440 | Remove `extended` field from dataset tagger | ## Describe the bug
While working on #2435 I used the [dataset tagger](https://huggingface.co/datasets/tagging/) to generate the missing tags for the YAML metadata of each README.md file. However, it seems that our CI raises an error when the `extended` field is included:
```
dataset_name = 'arcd'
@pytest.m... | closed | 2021-06-01T17:18:42 | https://api.github.com/repos/huggingface/datasets/issues/2440/comments | null | false | Remove `extended` field from dataset tagger
## Describe the bug
While working on #2435 I used the [dataset tagger](https://huggingface.co/datasets/tagging/) to generate the missing tags for the YAML metadata of each README.md file. However, it seems that our CI raises an error when the `extended` field is included:
... | [
"The tagger also doesn't insert the value for the `size_categories` field automatically, so this should be fixed too",
"Thanks for reporting. Indeed the `extended` tag doesn't exist. Not sure why we had that in the tagger.\r\nThe repo of the tagger is here if someone wants to give this a try: https://github.com/h... |
https://api.github.com/repos/huggingface/datasets/issues/2439 | 2,439 | Better error message when trying to access elements of a DatasetDict without specifying the split | As mentioned in #2437 it'd be nice to to have an indication to the users when they try to access an element of a DatasetDict without specifying the split name.
cc @thomwolf | closed | 2021-06-01T17:04:32 | https://api.github.com/repos/huggingface/datasets/issues/2439/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2439",
"html_url": "https://github.com/huggingface/datasets/pull/2439",
"diff_url": "https://github.com/huggingface/datasets/pull/2439.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2439.patch",
"merged_at": "2021-06-07T08:54... | true | Better error message when trying to access elements of a DatasetDict without specifying the split
As mentioned in #2437 it'd be nice to to have an indication to the users when they try to access an element of a DatasetDict without specifying the split name.
cc @thomwolf | [] |
https://api.github.com/repos/huggingface/datasets/issues/2438 | 2,438 | Fix NQ features loading: reorder fields of features to match nested fields order in arrow data | As mentioned in #2401, there is an issue when loading the features of `natural_questions` since the order of the nested fields in the features don't match. The order is important since it matters for the underlying arrow schema.
To fix that I re-order the features based on the arrow schema:
```python
inferred_fe... | closed | 2021-06-01T16:09:30 | https://api.github.com/repos/huggingface/datasets/issues/2438/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2438",
"html_url": "https://github.com/huggingface/datasets/pull/2438",
"diff_url": "https://github.com/huggingface/datasets/pull/2438.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2438.patch",
"merged_at": "2021-06-04T09:02... | true | Fix NQ features loading: reorder fields of features to match nested fields order in arrow data
As mentioned in #2401, there is an issue when loading the features of `natural_questions` since the order of the nested fields in the features don't match. The order is important since it matters for the underlying arrow sche... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2437 | 2,437 | Better error message when using the wrong load_from_disk | As mentioned in #2424, the error message when one tries to use `Dataset.load_from_disk` to load a DatasetDict object (or _vice versa_) can be improved. I added a suggestion in the error message to let users know that they should use the other one. | closed | 2021-06-01T09:43:22 | https://api.github.com/repos/huggingface/datasets/issues/2437/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2437",
"html_url": "https://github.com/huggingface/datasets/pull/2437",
"diff_url": "https://github.com/huggingface/datasets/pull/2437.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2437.patch",
"merged_at": "2021-06-08T18:03... | true | Better error message when using the wrong load_from_disk
As mentioned in #2424, the error message when one tries to use `Dataset.load_from_disk` to load a DatasetDict object (or _vice versa_) can be improved. I added a suggestion in the error message to let users know that they should use the other one. | [
"We also have other cases where people are lost between Dataset and DatasetDict, maybe let's gather and solve them all here?\r\n\r\nFor instance, I remember that some people thought they would request a single element of a split but are calling this on a DatasetDict. Maybe here also a better error message when the ... |
https://api.github.com/repos/huggingface/datasets/issues/2436 | 2,436 | Update DatasetMetadata and ReadMe | This PR contains the changes discussed in #2395.
**Edit**:
In addition to those changes, I'll be updating the `ReadMe` as follows:
Currently, `Section` has separate parsing and validation error lists. In `.validate()`, we add these lists to the final lists and throw errors.
One way to make `ReadMe` consistent... | closed | 2021-06-01T09:32:37 | https://api.github.com/repos/huggingface/datasets/issues/2436/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2436",
"html_url": "https://github.com/huggingface/datasets/pull/2436",
"diff_url": "https://github.com/huggingface/datasets/pull/2436.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2436.patch",
"merged_at": "2021-06-14T13:23... | true | Update DatasetMetadata and ReadMe
This PR contains the changes discussed in #2395.
**Edit**:
In addition to those changes, I'll be updating the `ReadMe` as follows:
Currently, `Section` has separate parsing and validation error lists. In `.validate()`, we add these lists to the final lists and throw errors.
O... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2435 | 2,435 | Insert Extractive QA templates for SQuAD-like datasets | This PR adds task templates for 9 SQuAD-like templates with the following properties:
* 1 config
* A schema that matches the `squad` one (i.e. same column names, especially for the nested `answers` column because the current implementation does not support casting with mismatched columns. see #2434)
* Less than 20... | closed | 2021-05-31T14:09:11 | https://api.github.com/repos/huggingface/datasets/issues/2435/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2435",
"html_url": "https://github.com/huggingface/datasets/pull/2435",
"diff_url": "https://github.com/huggingface/datasets/pull/2435.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2435.patch",
"merged_at": "2021-06-03T14:32... | true | Insert Extractive QA templates for SQuAD-like datasets
This PR adds task templates for 9 SQuAD-like templates with the following properties:
* 1 config
* A schema that matches the `squad` one (i.e. same column names, especially for the nested `answers` column because the current implementation does not support cast... | [
"hi @lhoestq @SBrandeis i've now added the missing YAML tags, so this PR should be good to go :)",
"urgh, the windows tests are failing because of encoding issues 😢 \r\n\r\n```\r\ndataset_name = 'squad_kor_v1'\r\n\r\n @pytest.mark.parametrize(\"dataset_name\", get_changed_datasets(repo_path))\r\n def test_... |
https://api.github.com/repos/huggingface/datasets/issues/2434 | 2,434 | Extend QuestionAnsweringExtractive template to handle nested columns | Currently the `QuestionAnsweringExtractive` task template and `preprare_for_task` only support "flat" features. We should extend the functionality to cover QA datasets like:
* `iapp_wiki_qa_squad`
* `parsinlu_reading_comprehension`
where the nested features differ with those from `squad` and trigger an `ArrowNot... | closed | 2021-05-31T14:06:51 | https://api.github.com/repos/huggingface/datasets/issues/2434/comments | null | false | Extend QuestionAnsweringExtractive template to handle nested columns
Currently the `QuestionAnsweringExtractive` task template and `preprare_for_task` only support "flat" features. We should extend the functionality to cover QA datasets like:
* `iapp_wiki_qa_squad`
* `parsinlu_reading_comprehension`
where the ne... | [
"this is also the case for the following datasets and configurations:\r\n\r\n* `mlqa` with config `mlqa-translate-train.ar`\r\n\r\n",
"The current task API is somewhat deprecated (we plan to align it with `train eval index` at some point), so I think we can close this issue."
] |
https://api.github.com/repos/huggingface/datasets/issues/2433 | 2,433 | Fix DuplicatedKeysError in adversarial_qa | Fixes #2431 | closed | 2021-05-31T13:48:47 | https://api.github.com/repos/huggingface/datasets/issues/2433/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2433",
"html_url": "https://github.com/huggingface/datasets/pull/2433",
"diff_url": "https://github.com/huggingface/datasets/pull/2433.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2433.patch",
"merged_at": "2021-06-01T08:52... | true | Fix DuplicatedKeysError in adversarial_qa
Fixes #2431 | [] |
https://api.github.com/repos/huggingface/datasets/issues/2432 | 2,432 | Fix CI six installation on linux | For some reason we end up with this error in the linux CI when running pip install .[tests]
```
pip._vendor.resolvelib.resolvers.InconsistentCandidate: Provided candidate AlreadyInstalledCandidate(six 1.16.0 (/usr/local/lib/python3.6/site-packages)) does not satisfy SpecifierRequirement('six>1.9'), SpecifierRequireme... | closed | 2021-05-31T13:15:36 | https://api.github.com/repos/huggingface/datasets/issues/2432/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2432",
"html_url": "https://github.com/huggingface/datasets/pull/2432",
"diff_url": "https://github.com/huggingface/datasets/pull/2432.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2432.patch",
"merged_at": "2021-05-31T13:17... | true | Fix CI six installation on linux
For some reason we end up with this error in the linux CI when running pip install .[tests]
```
pip._vendor.resolvelib.resolvers.InconsistentCandidate: Provided candidate AlreadyInstalledCandidate(six 1.16.0 (/usr/local/lib/python3.6/site-packages)) does not satisfy SpecifierRequireme... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2431 | 2,431 | DuplicatedKeysError when trying to load adversarial_qa | ## Describe the bug
A clear and concise description of what the bug is.
## Steps to reproduce the bug
```python
dataset = load_dataset('adversarial_qa', 'adversarialQA')
```
## Expected results
The dataset should be loaded into memory
## Actual results
>DuplicatedKeysError: FAILURE TO GENERATE DATASET ... | closed | 2021-05-31T12:11:19 | https://api.github.com/repos/huggingface/datasets/issues/2431/comments | null | false | DuplicatedKeysError when trying to load adversarial_qa
## Describe the bug
A clear and concise description of what the bug is.
## Steps to reproduce the bug
```python
dataset = load_dataset('adversarial_qa', 'adversarialQA')
```
## Expected results
The dataset should be loaded into memory
## Actual result... | [
"Thanks for reporting !\r\n#2433 fixed the issue, thanks @mariosasko :)\r\n\r\nWe'll do a patch release soon of the library.\r\nIn the meantime, you can use the fixed version of adversarial_qa by adding `script_version=\"master\"` in `load_dataset`"
] |
https://api.github.com/repos/huggingface/datasets/issues/2430 | 2,430 | Add version-specific BibTeX | As pointed out by @lhoestq in #2411, after the creation of the Zenodo DOI for Datasets, a new BibTeX entry is created with each release.
This PR adds a version-specific BibTeX entry, besides the existing one which is generic for the project.
See version-specific BibTeX entry here: https://zenodo.org/record/481776... | closed | 2021-05-31T10:05:42 | https://api.github.com/repos/huggingface/datasets/issues/2430/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2430",
"html_url": "https://github.com/huggingface/datasets/pull/2430",
"diff_url": "https://github.com/huggingface/datasets/pull/2430.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2430.patch",
"merged_at": "2021-06-08T07:53... | true | Add version-specific BibTeX
As pointed out by @lhoestq in #2411, after the creation of the Zenodo DOI for Datasets, a new BibTeX entry is created with each release.
This PR adds a version-specific BibTeX entry, besides the existing one which is generic for the project.
See version-specific BibTeX entry here: http... | [
"Maybe we should only keep one citation ?\r\ncc @thomwolf @yjernite ",
"For info:\r\n- The one automatically generated by Zenodo is version-specific, and a new one will be generated after each release.\r\n- Zenodo has also generated a project-specific DOI (they call it *Concept DOI* as opposed to *Version DOI*), ... |
https://api.github.com/repos/huggingface/datasets/issues/2429 | 2,429 | Rename QuestionAnswering template to QuestionAnsweringExtractive | Following the discussion with @thomwolf in #2255, this PR renames the QA template to distinguish extractive vs abstractive QA. The abstractive template will be added in a future PR. | closed | 2021-05-31T10:04:42 | https://api.github.com/repos/huggingface/datasets/issues/2429/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2429",
"html_url": "https://github.com/huggingface/datasets/pull/2429",
"diff_url": "https://github.com/huggingface/datasets/pull/2429.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2429.patch",
"merged_at": "2021-05-31T15:57... | true | Rename QuestionAnswering template to QuestionAnsweringExtractive
Following the discussion with @thomwolf in #2255, this PR renames the QA template to distinguish extractive vs abstractive QA. The abstractive template will be added in a future PR. | [
"> I like having \"extractive\" in the name to make things explicit. However this creates an inconsistency with transformers.\r\n> \r\n> See\r\n> https://huggingface.co/transformers/task_summary.html#extractive-question-answering\r\n> \r\n> But this is minor IMO and I'm ok with this renaming\r\n\r\nyes i chose this... |
https://api.github.com/repos/huggingface/datasets/issues/2428 | 2,428 | Add copyright info for wiki_lingua dataset | closed | 2021-05-31T07:22:52 | https://api.github.com/repos/huggingface/datasets/issues/2428/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2428",
"html_url": "https://github.com/huggingface/datasets/pull/2428",
"diff_url": "https://github.com/huggingface/datasets/pull/2428.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2428.patch",
"merged_at": "2021-06-04T10:22... | true | Add copyright info for wiki_lingua dataset
| [
"Build fails but this change should not be the reason...",
"rebased on master",
"rebased on master"
] | |
https://api.github.com/repos/huggingface/datasets/issues/2427 | 2,427 | Add copyright info to MLSUM dataset | closed | 2021-05-31T07:15:57 | https://api.github.com/repos/huggingface/datasets/issues/2427/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2427",
"html_url": "https://github.com/huggingface/datasets/pull/2427",
"diff_url": "https://github.com/huggingface/datasets/pull/2427.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2427.patch",
"merged_at": "2021-06-04T09:53... | true | Add copyright info to MLSUM dataset
| [
"Build fails but this change should not be the reason...",
"rebased on master"
] | |
https://api.github.com/repos/huggingface/datasets/issues/2426 | 2,426 | Saving Graph/Structured Data in Datasets | Thanks for this amazing library! And my question is I have structured data that is organized with a graph. For example, a dataset with users' friendship relations and user's articles. When I try to save a python dict in the dataset, an error occurred ``did not recognize Python value type when inferring an Arrow data ty... | closed | 2021-05-29T13:35:21 | https://api.github.com/repos/huggingface/datasets/issues/2426/comments | null | false | Saving Graph/Structured Data in Datasets
Thanks for this amazing library! And my question is I have structured data that is organized with a graph. For example, a dataset with users' friendship relations and user's articles. When I try to save a python dict in the dataset, an error occurred ``did not recognize Python v... | [
"It should probably work out of the box to save structured data. If you want to show an example we can help you.",
"An example of a toy dataset is like:\r\n```json\r\n[\r\n {\r\n \"name\": \"mike\",\r\n \"friends\": [\r\n \"tom\",\r\n \"lily\"\r\n ],\r\n \"arti... |
https://api.github.com/repos/huggingface/datasets/issues/2425 | 2,425 | Fix Docstring Mistake: dataset vs. metric | PR to fix #2412 | closed | 2021-05-29T06:09:53 | https://api.github.com/repos/huggingface/datasets/issues/2425/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2425",
"html_url": "https://github.com/huggingface/datasets/pull/2425",
"diff_url": "https://github.com/huggingface/datasets/pull/2425.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2425.patch",
"merged_at": "2021-06-01T08:18... | true | Fix Docstring Mistake: dataset vs. metric
PR to fix #2412 | [
"IMO this PR is ready for review. I do not know why tests fail...",
"The CI fail is unrelated to this PR, and it has been fixed on master, merging :)",
"> I just have one comment: we use rouge, not rogue :p\r\n\r\nOops!",
"rebased on master"
] |
https://api.github.com/repos/huggingface/datasets/issues/2424 | 2,424 | load_from_disk and save_to_disk are not compatible with each other | ## Describe the bug
load_from_disk and save_to_disk are not compatible. When I use save_to_disk to save a dataset to disk it works perfectly but given the same directory load_from_disk throws an error that it can't find state.json. looks like the load_from_disk only works on one split
## Steps to reproduce the bug
... | closed | 2021-05-28T23:07:10 | https://api.github.com/repos/huggingface/datasets/issues/2424/comments | null | false | load_from_disk and save_to_disk are not compatible with each other
## Describe the bug
load_from_disk and save_to_disk are not compatible. When I use save_to_disk to save a dataset to disk it works perfectly but given the same directory load_from_disk throws an error that it can't find state.json. looks like the load_... | [
"Hi,\r\n\r\n`load_dataset` returns an instance of `DatasetDict` if `split` is not specified, so instead of `Dataset.load_from_disk`, use `DatasetDict.load_from_disk` to load the dataset from disk.",
"Thanks it worked!",
"Though I see a stream of issues open by people lost between datasets and datasets dicts so ... |
https://api.github.com/repos/huggingface/datasets/issues/2423 | 2,423 | add `desc` in `map` for `DatasetDict` object | `desc` in `map` currently only works with `Dataset` objects. This PR adds support for `DatasetDict` objects as well | closed | 2021-05-28T19:28:44 | https://api.github.com/repos/huggingface/datasets/issues/2423/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2423",
"html_url": "https://github.com/huggingface/datasets/pull/2423",
"diff_url": "https://github.com/huggingface/datasets/pull/2423.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2423.patch",
"merged_at": "2021-05-31T13:08... | true | add `desc` in `map` for `DatasetDict` object
`desc` in `map` currently only works with `Dataset` objects. This PR adds support for `DatasetDict` objects as well | [
"The CI error is unrelated to the PR, merging",
"@lhoestq, can we release this feature if you guys are planning for any patch release for Datasets. It'll slow down [#11927](https://github.com/huggingface/transformers/pull/11927) otherwise :/ ",
"Sure definitely, having a discrepancy between Dataset.map and Data... |
https://api.github.com/repos/huggingface/datasets/issues/2422 | 2,422 | Fix save_to_disk nested features order in dataset_info.json | Fix issue https://github.com/huggingface/datasets/issues/2267
The order of the nested features matters (pyarrow limitation), but the save_to_disk method was saving the features types as JSON with `sort_keys=True`, which was breaking the order of the nested features. | closed | 2021-05-28T15:03:28 | https://api.github.com/repos/huggingface/datasets/issues/2422/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2422",
"html_url": "https://github.com/huggingface/datasets/pull/2422",
"diff_url": "https://github.com/huggingface/datasets/pull/2422.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2422.patch",
"merged_at": "2021-05-28T15:26... | true | Fix save_to_disk nested features order in dataset_info.json
Fix issue https://github.com/huggingface/datasets/issues/2267
The order of the nested features matters (pyarrow limitation), but the save_to_disk method was saving the features types as JSON with `sort_keys=True`, which was breaking the order of the nested ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2421 | 2,421 | doc: fix typo HF_MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES | MAX_MEMORY_DATASET_SIZE_IN_BYTES should be HF_MAX_MEMORY_DATASET_SIZE_IN_BYTES | closed | 2021-05-28T14:52:10 | https://api.github.com/repos/huggingface/datasets/issues/2421/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2421",
"html_url": "https://github.com/huggingface/datasets/pull/2421",
"diff_url": "https://github.com/huggingface/datasets/pull/2421.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2421.patch",
"merged_at": "2021-06-04T09:52... | true | doc: fix typo HF_MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES
MAX_MEMORY_DATASET_SIZE_IN_BYTES should be HF_MAX_MEMORY_DATASET_SIZE_IN_BYTES | [] |
https://api.github.com/repos/huggingface/datasets/issues/2420 | 2,420 | Updated Dataset Description | Added Point of contact information and several other details about the dataset. | closed | 2021-05-28T07:10:51 | https://api.github.com/repos/huggingface/datasets/issues/2420/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2420",
"html_url": "https://github.com/huggingface/datasets/pull/2420",
"diff_url": "https://github.com/huggingface/datasets/pull/2420.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2420.patch",
"merged_at": "2021-06-10T12:11... | true | Updated Dataset Description
Added Point of contact information and several other details about the dataset. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2419 | 2,419 | adds license information for DailyDialog. | closed | 2021-05-27T23:03:42 | https://api.github.com/repos/huggingface/datasets/issues/2419/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2419",
"html_url": "https://github.com/huggingface/datasets/pull/2419",
"diff_url": "https://github.com/huggingface/datasets/pull/2419.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2419.patch",
"merged_at": "2021-05-31T13:16... | true | adds license information for DailyDialog.
| [
"Thanks! Can you also add it as metadata in the YAML block at the top of the file?\r\n\r\nShould be in the form:\r\n\r\n```\r\nlicenses:\r\n- cc-by-sa-4.0\r\n```",
"seems like we need to add all the other tags ? \r\n``` \r\nif error_messages:\r\n> raise ValueError(\"\\n\".join(error_messages))\r\n... | |
https://api.github.com/repos/huggingface/datasets/issues/2418 | 2,418 | add utf-8 while reading README | It was causing tests to fail in Windows (see #2416). In Windows, the default encoding is CP1252 which is unable to decode the character byte 0x9d | closed | 2021-05-27T18:12:28 | https://api.github.com/repos/huggingface/datasets/issues/2418/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2418",
"html_url": "https://github.com/huggingface/datasets/pull/2418",
"diff_url": "https://github.com/huggingface/datasets/pull/2418.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2418.patch",
"merged_at": "2021-06-04T09:55... | true | add utf-8 while reading README
It was causing tests to fail in Windows (see #2416). In Windows, the default encoding is CP1252 which is unable to decode the character byte 0x9d | [
"Can you please add encoding to this line as well to fix the issue (and maybe replace `path.open(...)` with `open(path, ...)`)?\r\nhttps://github.com/huggingface/datasets/blob/7bee4be44706a59b084b9b69c4cd00f73ee72f76/src/datasets/utils/metadata.py#L58",
"Sure, in fact even I was thinking of adding this in order t... |
https://api.github.com/repos/huggingface/datasets/issues/2417 | 2,417 | Make datasets PEP-561 compliant | Allows to type-check datasets with `mypy` when imported as a third-party library
PEP-561: https://www.python.org/dev/peps/pep-0561
MyPy doc on the subject: https://mypy.readthedocs.io/en/stable/installed_packages.html
| closed | 2021-05-27T16:16:17 | https://api.github.com/repos/huggingface/datasets/issues/2417/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2417",
"html_url": "https://github.com/huggingface/datasets/pull/2417",
"diff_url": "https://github.com/huggingface/datasets/pull/2417.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2417.patch",
"merged_at": "2021-05-28T13:09... | true | Make datasets PEP-561 compliant
Allows to type-check datasets with `mypy` when imported as a third-party library
PEP-561: https://www.python.org/dev/peps/pep-0561
MyPy doc on the subject: https://mypy.readthedocs.io/en/stable/installed_packages.html
| [
"This is super cool, I love that ❤️ "
] |
https://api.github.com/repos/huggingface/datasets/issues/2416 | 2,416 | Add KLUE dataset | Add `KLUE (Korean Language Understanding Evaluation)` dataset released recently from [paper](https://arxiv.org/abs/2105.09680), [github](https://github.com/KLUE-benchmark/KLUE) and [webpage](https://klue-benchmark.com/tasks).
Please let me know if there's anything missing in the code or README.
Thanks!
| closed | 2021-05-27T15:49:51 | https://api.github.com/repos/huggingface/datasets/issues/2416/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2416",
"html_url": "https://github.com/huggingface/datasets/pull/2416",
"diff_url": "https://github.com/huggingface/datasets/pull/2416.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2416.patch",
"merged_at": "2021-06-04T17:45... | true | Add KLUE dataset
Add `KLUE (Korean Language Understanding Evaluation)` dataset released recently from [paper](https://arxiv.org/abs/2105.09680), [github](https://github.com/KLUE-benchmark/KLUE) and [webpage](https://klue-benchmark.com/tasks).
Please let me know if there's anything missing in the code or README.
Thank... | [
"I'm not sure why I got error like below when I auto-generate dummy data \"mrc\" \r\n```\r\ndatasets.keyhash.DuplicatedKeysError: FAILURE TO GENERATE DATASET !\r\nFound duplicate Key: 0\r\nKeys should be unique and deterministic in nature\r\n```",
"> I'm not sure why I got error like below when I auto-generate du... |
https://api.github.com/repos/huggingface/datasets/issues/2415 | 2,415 | Cached dataset not loaded | ## Describe the bug
I have a large dataset (common_voice, english) where I use several map and filter functions.
Sometimes my cached datasets after specific functions are not loaded.
I always use the same arguments, same functions, no seed…
## Steps to reproduce the bug
```python
def filter_by_duration(batch):
... | closed | 2021-05-27T15:40:06 | https://api.github.com/repos/huggingface/datasets/issues/2415/comments | null | false | Cached dataset not loaded
## Describe the bug
I have a large dataset (common_voice, english) where I use several map and filter functions.
Sometimes my cached datasets after specific functions are not loaded.
I always use the same arguments, same functions, no seed…
## Steps to reproduce the bug
```python
def f... | [
"It actually seems to happen all the time in above configuration:\r\n* the function `filter_by_duration` correctly loads cached processed dataset\r\n* the function `prepare_dataset` is always reexecuted\r\n\r\nI end up solving the issue by saving to disk my dataset at the end but I'm still wondering if it's a bug o... |
https://api.github.com/repos/huggingface/datasets/issues/2414 | 2,414 | Update README.md | Provides description of data instances and dataset features
| closed | 2021-05-27T14:53:19 | https://api.github.com/repos/huggingface/datasets/issues/2414/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2414",
"html_url": "https://github.com/huggingface/datasets/pull/2414",
"diff_url": "https://github.com/huggingface/datasets/pull/2414.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2414.patch",
"merged_at": "2021-06-28T13:04... | true | Update README.md
Provides description of data instances and dataset features
| [
"Merging since the CI error is unrelated to this PR and has been fixed on master",
"Thank you for taking a look at the CI error - I was a bit confused with that. Thanks!"
] |
https://api.github.com/repos/huggingface/datasets/issues/2413 | 2,413 | AttributeError: 'DatasetInfo' object has no attribute 'task_templates' | ## Describe the bug
Hello,
I'm trying to add dataset and contribute, but test keep fail with below cli.
` RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<my_dataset>`
## Steps to reproduce the bug
It seems like a bug when I see an error with the existing dataset,... | closed | 2021-05-27T13:44:28 | https://api.github.com/repos/huggingface/datasets/issues/2413/comments | null | false | AttributeError: 'DatasetInfo' object has no attribute 'task_templates'
## Describe the bug
Hello,
I'm trying to add dataset and contribute, but test keep fail with below cli.
` RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<my_dataset>`
## Steps to reproduce the ... | [
"Hi ! Can you try using a more up-to-date version ? We added the task_templates in `datasets` 1.7.0.\r\n\r\nIdeally when you're working on new datasets, you should install and use the local version of your fork of `datasets`. Here I think you tried to run the 1.7.0 tests with the 1.6.2 code"
] |
https://api.github.com/repos/huggingface/datasets/issues/2412 | 2,412 | Docstring mistake: dataset vs. metric | This:
https://github.com/huggingface/datasets/blob/d95b95f8cf3cb0cff5f77a675139b584dcfcf719/src/datasets/load.py#L582
Should better be something like:
`a metric identifier on HuggingFace AWS bucket (list all available metrics and ids with ``datasets.list_metrics()``)`
I can provide a PR l8er... | closed | 2021-05-27T13:39:11 | https://api.github.com/repos/huggingface/datasets/issues/2412/comments | null | false | Docstring mistake: dataset vs. metric
This:
https://github.com/huggingface/datasets/blob/d95b95f8cf3cb0cff5f77a675139b584dcfcf719/src/datasets/load.py#L582
Should better be something like:
`a metric identifier on HuggingFace AWS bucket (list all available metrics and ids with ``datasets.list_metrics()``)`
I... | [
"> I can provide a PR l8er...\r\n\r\nSee #2425 "
] |
https://api.github.com/repos/huggingface/datasets/issues/2411 | 2,411 | Add DOI badge to README | Once published the latest release, the DOI badge has been automatically generated by Zenodo. | closed | 2021-05-27T12:36:47 | https://api.github.com/repos/huggingface/datasets/issues/2411/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2411",
"html_url": "https://github.com/huggingface/datasets/pull/2411",
"diff_url": "https://github.com/huggingface/datasets/pull/2411.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2411.patch",
"merged_at": "2021-05-27T13:42... | true | Add DOI badge to README
Once published the latest release, the DOI badge has been automatically generated by Zenodo. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2410 | 2,410 | fix #2391 add original answers in kilt-TriviaQA | cc @yjernite is it ok like this? | closed | 2021-05-27T11:54:29 | https://api.github.com/repos/huggingface/datasets/issues/2410/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2410",
"html_url": "https://github.com/huggingface/datasets/pull/2410",
"diff_url": "https://github.com/huggingface/datasets/pull/2410.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2410.patch",
"merged_at": "2021-06-14T17:29... | true | fix #2391 add original answers in kilt-TriviaQA
cc @yjernite is it ok like this? | [
"LGTM, but I'm not sure what's going on with the Unix tests @lhoestq ",
"The CI error is unrelated to this PR, it's been fixed now on master.",
"Thanks @PaulLerner !",
"> #- [ ] - Hey@fr[fr_fr**fr~~... |
https://api.github.com/repos/huggingface/datasets/issues/2409 | 2,409 | Add HF_ prefix to env var MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES | As mentioned in https://github.com/huggingface/datasets/pull/2399 the env var should be prefixed by HF_ | closed | 2021-05-27T09:07:00 | https://api.github.com/repos/huggingface/datasets/issues/2409/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2409",
"html_url": "https://github.com/huggingface/datasets/pull/2409",
"diff_url": "https://github.com/huggingface/datasets/pull/2409.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2409.patch",
"merged_at": "2021-05-27T09:33... | true | Add HF_ prefix to env var MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES
As mentioned in https://github.com/huggingface/datasets/pull/2399 the env var should be prefixed by HF_ | [
"I thought the renaming was suggested only for the env var, and not for the config variable... As you think is better! ;)",
"I think it's better if they match, so that users understand directly that they're directly connected",
"Well, if you're not concerned about back-compat here, perhaps it could be renamed a... |
https://api.github.com/repos/huggingface/datasets/issues/2408 | 2,408 | Fix head_qa keys | There were duplicate in the keys, as mentioned in #2382 | closed | 2021-05-27T08:50:19 | https://api.github.com/repos/huggingface/datasets/issues/2408/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2408",
"html_url": "https://github.com/huggingface/datasets/pull/2408",
"diff_url": "https://github.com/huggingface/datasets/pull/2408.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2408.patch",
"merged_at": "2021-05-27T09:05... | true | Fix head_qa keys
There were duplicate in the keys, as mentioned in #2382 | [] |
https://api.github.com/repos/huggingface/datasets/issues/2407 | 2,407 | .map() function got an unexpected keyword argument 'cache_file_name' | ## Describe the bug
I'm trying to save the result of datasets.map() to a specific file, so that I can easily share it among multiple computers without reprocessing the dataset. However, when I try to pass an argument 'cache_file_name' to the .map() function, it throws an error that ".map() function got an unexpected... | closed | 2021-05-27T01:54:26 | https://api.github.com/repos/huggingface/datasets/issues/2407/comments | null | false | .map() function got an unexpected keyword argument 'cache_file_name'
## Describe the bug
I'm trying to save the result of datasets.map() to a specific file, so that I can easily share it among multiple computers without reprocessing the dataset. However, when I try to pass an argument 'cache_file_name' to the .map()... | [
"Hi @cindyxinyiwang,\r\nDid you try adding `.arrow` after `cache_file_name` argument? Here I think they're expecting something like that only for a cache file:\r\nhttps://github.com/huggingface/datasets/blob/e08362256fb157c0b3038437fc0d7a0bbb50de5c/src/datasets/arrow_dataset.py#L1556-L1558",
"Hi ! `cache_file_nam... |
https://api.github.com/repos/huggingface/datasets/issues/2406 | 2,406 | Add guide on using task templates to documentation | Once we have a stable API on the text classification and question answering task templates, add a guide on how to use them in the documentation.
| closed | 2021-05-26T16:28:26 | https://api.github.com/repos/huggingface/datasets/issues/2406/comments | null | false | Add guide on using task templates to documentation
Once we have a stable API on the text classification and question answering task templates, add a guide on how to use them in the documentation.
| [] |
https://api.github.com/repos/huggingface/datasets/issues/2405 | 2,405 | Add dataset tags | The dataset tags were provided by Peter Clark following the guide. | closed | 2021-05-25T18:57:29 | https://api.github.com/repos/huggingface/datasets/issues/2405/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2405",
"html_url": "https://github.com/huggingface/datasets/pull/2405",
"diff_url": "https://github.com/huggingface/datasets/pull/2405.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2405.patch",
"merged_at": "2021-05-26T16:40... | true | Add dataset tags
The dataset tags were provided by Peter Clark following the guide. | [
"Thanks!"
] |
https://api.github.com/repos/huggingface/datasets/issues/2404 | 2,404 | Paperswithcode dataset mapping | This is a continuation of https://github.com/huggingface/huggingface_hub/pull/43, encoded directly inside dataset cards.
As discussed:
- `paperswithcode_id: null` when the dataset doesn't exist on paperswithcode's side.
- I've added this new key at the end of the yaml instead of ordering all keys alphabetically as... | closed | 2021-05-25T18:14:26 | https://api.github.com/repos/huggingface/datasets/issues/2404/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2404",
"html_url": "https://github.com/huggingface/datasets/pull/2404",
"diff_url": "https://github.com/huggingface/datasets/pull/2404.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2404.patch",
"merged_at": "2021-05-26T11:17... | true | Paperswithcode dataset mapping
This is a continuation of https://github.com/huggingface/huggingface_hub/pull/43, encoded directly inside dataset cards.
As discussed:
- `paperswithcode_id: null` when the dataset doesn't exist on paperswithcode's side.
- I've added this new key at the end of the yaml instead of orde... | [
"messed up my branch, repushing",
"live mapping can be found at https://huggingface.co/api/pwc/datasets-mapping and will be kept up to date going forward"
] |
https://api.github.com/repos/huggingface/datasets/issues/2403 | 2,403 | Free datasets with cache file in temp dir on exit | This PR properly cleans up the memory-mapped tables that reference the cache files inside the temp dir.
Since the built-in `_finalizer` of `TemporaryDirectory` can't be modified, this PR defines its own `TemporaryDirectory` class that accepts a custom clean-up function.
Fixes #2402 | closed | 2021-05-24T22:15:11 | https://api.github.com/repos/huggingface/datasets/issues/2403/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2403",
"html_url": "https://github.com/huggingface/datasets/pull/2403",
"diff_url": "https://github.com/huggingface/datasets/pull/2403.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2403.patch",
"merged_at": "2021-05-26T16:39... | true | Free datasets with cache file in temp dir on exit
This PR properly cleans up the memory-mapped tables that reference the cache files inside the temp dir.
Since the built-in `_finalizer` of `TemporaryDirectory` can't be modified, this PR defines its own `TemporaryDirectory` class that accepts a custom clean-up function... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2402 | 2,402 | PermissionError on Windows when using temp dir for caching | Currently, the following code raises a PermissionError on master if working on Windows:
```python
# run as a script or call exit() in REPL to initiate the temp dir cleanup
from datasets import *
d = load_dataset("sst", split="train", keep_in_memory=False)
set_caching_enabled(False)
d.map(lambda ex: ex)
```
... | closed | 2021-05-24T21:22:59 | https://api.github.com/repos/huggingface/datasets/issues/2402/comments | null | false | PermissionError on Windows when using temp dir for caching
Currently, the following code raises a PermissionError on master if working on Windows:
```python
# run as a script or call exit() in REPL to initiate the temp dir cleanup
from datasets import *
d = load_dataset("sst", split="train", keep_in_memory=False)... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2401 | 2,401 | load_dataset('natural_questions') fails with "ValueError: External features info don't match the dataset" | ## Describe the bug
load_dataset('natural_questions') throws ValueError
## Steps to reproduce the bug
```python
from datasets import load_dataset
datasets = load_dataset('natural_questions', split='validation[:10]')
```
## Expected results
Call to load_dataset returns data.
## Actual results
```
Using ... | closed | 2021-05-24T18:38:53 | https://api.github.com/repos/huggingface/datasets/issues/2401/comments | null | false | load_dataset('natural_questions') fails with "ValueError: External features info don't match the dataset"
## Describe the bug
load_dataset('natural_questions') throws ValueError
## Steps to reproduce the bug
```python
from datasets import load_dataset
datasets = load_dataset('natural_questions', split='validatio... | [
"I faced the similar problem. Downgrading datasets to 1.5.0 fixed it.",
"Thanks for reporting, I'm looking into it",
"I just opened #2438 to fix this :)",
"Hi ! This has been fixed in the 1.8.0 release of `datasets`"
] |
https://api.github.com/repos/huggingface/datasets/issues/2400 | 2,400 | Concatenate several datasets with removed columns is not working. | ## Describe the bug
You can't concatenate datasets when you removed columns before.
## Steps to reproduce the bug
```python
from datasets import load_dataset, concatenate_datasets
wikiann= load_dataset("wikiann","en")
wikiann["train"] = wikiann["train"].remove_columns(["langs","spans"])
wikiann["test"] =... | closed | 2021-05-24T17:40:15 | https://api.github.com/repos/huggingface/datasets/issues/2400/comments | null | false | Concatenate several datasets with removed columns is not working.
## Describe the bug
You can't concatenate datasets when you removed columns before.
## Steps to reproduce the bug
```python
from datasets import load_dataset, concatenate_datasets
wikiann= load_dataset("wikiann","en")
wikiann["train"] = wik... | [
"Hi,\r\n\r\ndid you fill out the env info section manually or by copy-pasting the output of the `datasets-cli env` command?\r\n\r\nThis code should work without issues on 1.6.2 version (I'm working on master (1.6.2.dev0 version) and can't reproduce this error).",
"@mariosasko you are right I was still on `1.5.0`.... |
https://api.github.com/repos/huggingface/datasets/issues/2399 | 2,399 | Add env variable for MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES | Add env variable for `MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES`.
This will allow to turn off default behavior: loading in memory (and not caching) small datasets.
Fix #2387. | closed | 2021-05-24T17:19:15 | https://api.github.com/repos/huggingface/datasets/issues/2399/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2399",
"html_url": "https://github.com/huggingface/datasets/pull/2399",
"diff_url": "https://github.com/huggingface/datasets/pull/2399.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2399.patch",
"merged_at": "2021-05-26T16:07... | true | Add env variable for MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES
Add env variable for `MAX_IN_MEMORY_DATASET_SIZE_IN_BYTES`.
This will allow to turn off default behavior: loading in memory (and not caching) small datasets.
Fix #2387. | [
"Thank you for clarifying the precedence, @albertvillanova \r\n\r\nIsn't it typically the case where env vars have the highest precedence? \r\n\r\nIn my understanding the point of env vars is to be able to override software w/o needing to touch the code. \r\n\r\nPlease correct me if this is not so in the general ca... |
https://api.github.com/repos/huggingface/datasets/issues/2398 | 2,398 | News_commentary Dataset Translation Pairs are of Incorrect Language Specified Pairs | I used load_dataset to load the news_commentary dataset for "ar-en" translation pairs but found translations from Arabic to Hindi.
```
train_ds = load_dataset("news_commentary", "ar-en", split='train[:98%]')
val_ds = load_dataset("news_commentary", "ar-en", split='train[98%:]')
# filtering out examples that a... | closed | 2021-05-24T10:03:34 | https://api.github.com/repos/huggingface/datasets/issues/2398/comments | null | false | News_commentary Dataset Translation Pairs are of Incorrect Language Specified Pairs
I used load_dataset to load the news_commentary dataset for "ar-en" translation pairs but found translations from Arabic to Hindi.
```
train_ds = load_dataset("news_commentary", "ar-en", split='train[:98%]')
val_ds = load_dataset... | [
"These ranges seem to be valid English. Closing."
] |
https://api.github.com/repos/huggingface/datasets/issues/2397 | 2,397 | Fix number of classes in indic_glue sna.bn dataset | As read in the [paper](https://www.aclweb.org/anthology/2020.findings-emnlp.445.pdf), Table 11. | closed | 2021-05-24T08:18:55 | https://api.github.com/repos/huggingface/datasets/issues/2397/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2397",
"html_url": "https://github.com/huggingface/datasets/pull/2397",
"diff_url": "https://github.com/huggingface/datasets/pull/2397.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2397.patch",
"merged_at": "2021-05-25T16:32... | true | Fix number of classes in indic_glue sna.bn dataset
As read in the [paper](https://www.aclweb.org/anthology/2020.findings-emnlp.445.pdf), Table 11. | [
"@lhoestq there are many things missing in the README.md file, but this correction is right despite not passing the validation tests...",
"Yes indeed. We run the validation in all modified readme because we think that it is the time when contributors are the most likely to fix a dataset card - or it will never be... |
https://api.github.com/repos/huggingface/datasets/issues/2396 | 2,396 | strange datasets from OSCAR corpus | 
From the [official site ](https://oscar-corpus.com/), the Yue Chinese dataset should have 2.2K... | open | 2021-05-23T13:06:02 | https://api.github.com/repos/huggingface/datasets/issues/2396/comments | null | false | strange datasets from OSCAR corpus
From the [official site ](https://oscar-corpus.com/), the Y... | [
"Hi ! Thanks for reporting\r\ncc @pjox is this an issue from the data ?\r\n\r\nAnyway we should at least mention that OSCAR could contain such contents in the dataset card, you're totally right @jerryIsHere ",
"Hi @jerryIsHere , sorry for the late response! Sadly this is normal, the problem comes form fasttext's ... |
https://api.github.com/repos/huggingface/datasets/issues/2395 | 2,395 | `pretty_name` for dataset in YAML tags | I'm updating `pretty_name` for datasets in YAML tags as discussed with @lhoestq. Here are the first 10, please let me know if they're looking good.
If dataset has 1 config, I've added `pretty_name` as `config_name: full_name_of_dataset` as config names were `plain_text`, `default`, `squad` etc (not so important in t... | closed | 2021-05-22T09:24:45 | https://api.github.com/repos/huggingface/datasets/issues/2395/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2395",
"html_url": "https://github.com/huggingface/datasets/pull/2395",
"diff_url": "https://github.com/huggingface/datasets/pull/2395.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2395.patch",
"merged_at": null
} | true | `pretty_name` for dataset in YAML tags
I'm updating `pretty_name` for datasets in YAML tags as discussed with @lhoestq. Here are the first 10, please let me know if they're looking good.
If dataset has 1 config, I've added `pretty_name` as `config_name: full_name_of_dataset` as config names were `plain_text`, `defau... | [
"Initially I removed the ` - ` since there was only one `pretty_name` per config but turns out it was breaking here in `from_yaml_string`https://github.com/huggingface/datasets/blob/74751e3f98c74d22c48c6beb1fab0c13b5dfd075/src/datasets/utils/metadata.py#L197 in `/utils/metadata.py`",
"@lhoestq I guess this will a... |
https://api.github.com/repos/huggingface/datasets/issues/2392 | 2,392 | Update text classification template labels in DatasetInfo __post_init__ | This PR implements the idea discussed in #2389 to update the `labels` of the `TextClassification` template in the `DatasetInfo.__post_init__`. The main reason for doing so is so avoid duplicating the label definitions in both `DatasetInfo.features` and `DatasetInfo.task_templates`.
To avoid storing state in `Dataset... | closed | 2021-05-21T15:29:41 | https://api.github.com/repos/huggingface/datasets/issues/2392/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2392",
"html_url": "https://github.com/huggingface/datasets/pull/2392",
"diff_url": "https://github.com/huggingface/datasets/pull/2392.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2392.patch",
"merged_at": "2021-05-28T11:37... | true | Update text classification template labels in DatasetInfo __post_init__
This PR implements the idea discussed in #2389 to update the `labels` of the `TextClassification` template in the `DatasetInfo.__post_init__`. The main reason for doing so is so avoid duplicating the label definitions in both `DatasetInfo.features`... | [
"If I'm not mistaken, one way to fix this would be to drop the task templates when copying the info by inserting `dataset.info.task_templates = None` before the `Dataset.cast` call in `Dataset.prepare_for_task`. Moreover, we should do this change independently of the KeyError being raised because currently the foll... |
https://api.github.com/repos/huggingface/datasets/issues/2391 | 2,391 | Missing original answers in kilt-TriviaQA | I previously opened an issue at https://github.com/facebookresearch/KILT/issues/42 but from the answer of @fabiopetroni it seems that the problem comes from HF-datasets
## Describe the bug
The `answer` field in kilt-TriviaQA, e.g. `kilt_tasks['train_triviaqa'][0]['output']['answer']` contains a list of alternative ... | closed | 2021-05-21T14:57:07 | https://api.github.com/repos/huggingface/datasets/issues/2391/comments | null | false | Missing original answers in kilt-TriviaQA
I previously opened an issue at https://github.com/facebookresearch/KILT/issues/42 but from the answer of @fabiopetroni it seems that the problem comes from HF-datasets
## Describe the bug
The `answer` field in kilt-TriviaQA, e.g. `kilt_tasks['train_triviaqa'][0]['output'][... | [
"That could be useful indeed! Feel free to open a PR on the dataset card if you already have some code that runs, otherwise we'll take care of it soon :) ",
"I can open a PR but there is 2 details to fix:\r\n- the name for the corresponding key (e.g. `original_answer`)\r\n- how to implement it: I’m not sure what ... |
https://api.github.com/repos/huggingface/datasets/issues/2390 | 2,390 | Add check for task templates on dataset load | This PR adds a check that the features of a dataset match the schema of each compatible task template. | closed | 2021-05-21T10:16:57 | https://api.github.com/repos/huggingface/datasets/issues/2390/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2390",
"html_url": "https://github.com/huggingface/datasets/pull/2390",
"diff_url": "https://github.com/huggingface/datasets/pull/2390.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2390.patch",
"merged_at": "2021-05-21T15:49... | true | Add check for task templates on dataset load
This PR adds a check that the features of a dataset match the schema of each compatible task template. | [
"LGTM now, thank you =)"
] |
https://api.github.com/repos/huggingface/datasets/issues/2389 | 2,389 | Insert task templates for text classification | This PR inserts text-classification templates for datasets with the following properties:
* Only one config
* At most two features of `(Value, ClassLabel)` type
Note that this misses datasets like `sentiment140` which only has `Value` type features - these will be handled in a separate PR | closed | 2021-05-21T08:36:26 | https://api.github.com/repos/huggingface/datasets/issues/2389/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2389",
"html_url": "https://github.com/huggingface/datasets/pull/2389",
"diff_url": "https://github.com/huggingface/datasets/pull/2389.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2389.patch",
"merged_at": "2021-05-28T15:26... | true | Insert task templates for text classification
This PR inserts text-classification templates for datasets with the following properties:
* Only one config
* At most two features of `(Value, ClassLabel)` type
Note that this misses datasets like `sentiment140` which only has `Value` type features - these will be ha... | [
"Update: found a few datasets that slipped through the net. Adding them shortly!",
"You might have thought about this already, but would it make sense to use the `datasets.features.ClassLabel` values when possible instead of declaring the list once for the `feature` and once for the `template`?",
"> You might h... |
https://api.github.com/repos/huggingface/datasets/issues/2388 | 2,388 | Incorrect URLs for some datasets | ## Describe the bug
It seems that the URLs for the following datasets are invalid:
- [ ] `bn_hate_speech` has been renamed: https://github.com/rezacsedu/Bengali-Hate-Speech-Dataset/commit/c67ecfc4184911e12814f6b36901f9828df8a63a
- [ ] `covid_tweets_japanese` has been renamed: http://www.db.info.gifu-u.ac.jp/covi... | closed | 2021-05-21T07:22:35 | https://api.github.com/repos/huggingface/datasets/issues/2388/comments | null | false | Incorrect URLs for some datasets
## Describe the bug
It seems that the URLs for the following datasets are invalid:
- [ ] `bn_hate_speech` has been renamed: https://github.com/rezacsedu/Bengali-Hate-Speech-Dataset/commit/c67ecfc4184911e12814f6b36901f9828df8a63a
- [ ] `covid_tweets_japanese` has been renamed: htt... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2387 | 2,387 | datasets 1.6 ignores cache | Moving from https://github.com/huggingface/transformers/issues/11801#issuecomment-845546612
Quoting @VictorSanh:
>
> I downgraded datasets to `1.5.0` and printed `tokenized_datasets.cache_files` (L335):
>
> > `{'train': [{'filename': '/home/victor/.cache/huggingface/datasets/openwebtext10k/plain_text/1.0.0/... | closed | 2021-05-21T00:12:58 | https://api.github.com/repos/huggingface/datasets/issues/2387/comments | null | false | datasets 1.6 ignores cache
Moving from https://github.com/huggingface/transformers/issues/11801#issuecomment-845546612
Quoting @VictorSanh:
>
> I downgraded datasets to `1.5.0` and printed `tokenized_datasets.cache_files` (L335):
>
> > `{'train': [{'filename': '/home/victor/.cache/huggingface/datasets/openw... | [
"Looks like there are multiple issues regarding this (#2386, #2322) and it's a WIP #2329. Currently these datasets are being loaded in-memory which is causing this issue. Quoting @mariosasko here for a quick fix:\r\n\r\n> set `keep_in_memory` to `False` when loading a dataset (`sst = load_dataset(\"sst\", keep_in_m... |
https://api.github.com/repos/huggingface/datasets/issues/2386 | 2,386 | Accessing Arrow dataset cache_files | ## Describe the bug
In datasets 1.5.0 the following code snippet would have printed the cache_files:
```
train_data = load_dataset('conll2003', split='train', cache_dir='data')
print(train_data.cache_files[0]['filename'])
```
However, in the newest release (1.6.1), it prints an empty list.
I also tried l... | closed | 2021-05-20T23:57:43 | https://api.github.com/repos/huggingface/datasets/issues/2386/comments | null | false | Accessing Arrow dataset cache_files
## Describe the bug
In datasets 1.5.0 the following code snippet would have printed the cache_files:
```
train_data = load_dataset('conll2003', split='train', cache_dir='data')
print(train_data.cache_files[0]['filename'])
```
However, in the newest release (1.6.1), it pri... | [
"Thanks @bhavitvyamalik for referencing the workaround. Setting `keep_in_memory=False` is working."
] |
https://api.github.com/repos/huggingface/datasets/issues/2385 | 2,385 | update citations | To update citations for [Offenseval_dravidiain](https://huggingface.co/datasets/offenseval_dravidian)
| closed | 2021-05-20T17:54:08 | https://api.github.com/repos/huggingface/datasets/issues/2385/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2385",
"html_url": "https://github.com/huggingface/datasets/pull/2385",
"diff_url": "https://github.com/huggingface/datasets/pull/2385.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2385.patch",
"merged_at": "2021-05-21T12:38... | true | update citations
To update citations for [Offenseval_dravidiain](https://huggingface.co/datasets/offenseval_dravidian)
| [] |
https://api.github.com/repos/huggingface/datasets/issues/2384 | 2,384 | Add args description to DatasetInfo | Closes #2354
I am not sure what `post_processed` and `post_processing_size` correspond to, so have left them empty for now. I also took a guess at some of the other fields like `dataset_size` vs `size_in_bytes`, so might have misunderstood their meaning. | closed | 2021-05-20T13:53:10 | https://api.github.com/repos/huggingface/datasets/issues/2384/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2384",
"html_url": "https://github.com/huggingface/datasets/pull/2384",
"diff_url": "https://github.com/huggingface/datasets/pull/2384.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2384.patch",
"merged_at": "2021-05-22T09:26... | true | Add args description to DatasetInfo
Closes #2354
I am not sure what `post_processed` and `post_processing_size` correspond to, so have left them empty for now. I also took a guess at some of the other fields like `dataset_size` vs `size_in_bytes`, so might have misunderstood their meaning. | [
"Thanks for the suggestions! I've included them and made a few minor tweaks along the way",
"Please merge master into this branch to fix the CI, I just fixed metadata validation tests."
] |
https://api.github.com/repos/huggingface/datasets/issues/2383 | 2,383 | Improve example in rounding docs | Improves the example in the rounding subsection of the Split API docs. With this change, it should more clear what's the difference between the `closest` and the `pct1_dropremainder` rounding. | closed | 2021-05-19T18:59:23 | https://api.github.com/repos/huggingface/datasets/issues/2383/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2383",
"html_url": "https://github.com/huggingface/datasets/pull/2383",
"diff_url": "https://github.com/huggingface/datasets/pull/2383.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2383.patch",
"merged_at": "2021-05-21T12:36... | true | Improve example in rounding docs
Improves the example in the rounding subsection of the Split API docs. With this change, it should more clear what's the difference between the `closest` and the `pct1_dropremainder` rounding. | [] |
https://api.github.com/repos/huggingface/datasets/issues/2382 | 2,382 | DuplicatedKeysError: FAILURE TO GENERATE DATASET ! load_dataset('head_qa', 'en') | Hello everyone,
I try to use head_qa dataset in [https://huggingface.co/datasets/viewer/?dataset=head_qa&config=en](url)
```
!pip install datasets
from datasets import load_dataset
dataset = load_dataset(
'head_qa', 'en')
```
When I write above load_dataset(.), it throws the following:
```
Duplicated... | closed | 2021-05-19T15:49:48 | https://api.github.com/repos/huggingface/datasets/issues/2382/comments | null | false | DuplicatedKeysError: FAILURE TO GENERATE DATASET ! load_dataset('head_qa', 'en')
Hello everyone,
I try to use head_qa dataset in [https://huggingface.co/datasets/viewer/?dataset=head_qa&config=en](url)
```
!pip install datasets
from datasets import load_dataset
dataset = load_dataset(
'head_qa', 'en')
```... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2381 | 2,381 | add dataset card title | few of them were missed by me earlier which I've added now | closed | 2021-05-19T15:30:03 | https://api.github.com/repos/huggingface/datasets/issues/2381/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2381",
"html_url": "https://github.com/huggingface/datasets/pull/2381",
"diff_url": "https://github.com/huggingface/datasets/pull/2381.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2381.patch",
"merged_at": "2021-05-20T18:51... | true | add dataset card title
few of them were missed by me earlier which I've added now | [] |
https://api.github.com/repos/huggingface/datasets/issues/2380 | 2,380 | maintain YAML structure reading from README | How YAML used be loaded earlier in the string (structure of YAML was affected because of this and YAML for datasets with multiple configs was not being loaded correctly):
```
annotations_creators:
labeled_final:
- expert-generated
labeled_swap:
- expert-generated
unlabeled_final:
- machine-generated
language_c... | closed | 2021-05-19T12:12:07 | https://api.github.com/repos/huggingface/datasets/issues/2380/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2380",
"html_url": "https://github.com/huggingface/datasets/pull/2380",
"diff_url": "https://github.com/huggingface/datasets/pull/2380.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2380.patch",
"merged_at": "2021-05-19T13:08... | true | maintain YAML structure reading from README
How YAML used be loaded earlier in the string (structure of YAML was affected because of this and YAML for datasets with multiple configs was not being loaded correctly):
```
annotations_creators:
labeled_final:
- expert-generated
labeled_swap:
- expert-generated
unlab... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2379 | 2,379 | Disallow duplicate keys in yaml tags | Make sure that there's no duplidate keys in yaml tags.
I added the check in the yaml tree constructor's method, so that the verification is done at every level in the yaml structure.
cc @julien-c | closed | 2021-05-19T10:10:07 | https://api.github.com/repos/huggingface/datasets/issues/2379/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2379",
"html_url": "https://github.com/huggingface/datasets/pull/2379",
"diff_url": "https://github.com/huggingface/datasets/pull/2379.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2379.patch",
"merged_at": "2021-05-19T10:45... | true | Disallow duplicate keys in yaml tags
Make sure that there's no duplidate keys in yaml tags.
I added the check in the yaml tree constructor's method, so that the verification is done at every level in the yaml structure.
cc @julien-c | [] |
https://api.github.com/repos/huggingface/datasets/issues/2378 | 2,378 | Add missing dataset_infos.json files | Some of the datasets in `datasets` are missing a `dataset_infos.json` file, e.g.
```
[PosixPath('datasets/chr_en/chr_en.py'), PosixPath('datasets/chr_en/README.md')]
[PosixPath('datasets/telugu_books/README.md'), PosixPath('datasets/telugu_books/telugu_books.py')]
[PosixPath('datasets/reclor/README.md'), PosixPat... | open | 2021-05-19T08:11:12 | https://api.github.com/repos/huggingface/datasets/issues/2378/comments | null | false | Add missing dataset_infos.json files
Some of the datasets in `datasets` are missing a `dataset_infos.json` file, e.g.
```
[PosixPath('datasets/chr_en/chr_en.py'), PosixPath('datasets/chr_en/README.md')]
[PosixPath('datasets/telugu_books/README.md'), PosixPath('datasets/telugu_books/telugu_books.py')]
[PosixPath('... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2377 | 2,377 | ArrowDataset.save_to_disk produces files that cannot be read using pyarrow.feather | ## Describe the bug
A clear and concise description of what the bug is.
## Steps to reproduce the bug
```python
from datasets import load_dataset
from pyarrow import feather
dataset = load_dataset('imdb', split='train')
dataset.save_to_disk('dataset_dir')
table = feather.read_table('dataset_dir/dataset.arro... | open | 2021-05-19T02:04:37 | https://api.github.com/repos/huggingface/datasets/issues/2377/comments | null | false | ArrowDataset.save_to_disk produces files that cannot be read using pyarrow.feather
## Describe the bug
A clear and concise description of what the bug is.
## Steps to reproduce the bug
```python
from datasets import load_dataset
from pyarrow import feather
dataset = load_dataset('imdb', split='train')
datase... | [
"Hi ! This is because we are actually using the arrow streaming format. We plan to switch to the arrow IPC format.\r\nMore info at #1933 ",
"Not sure if this was resolved, but I am getting a similar error when trying to load a dataset.arrow file directly: `ArrowInvalid: Not an Arrow file`",
"Since we're using t... |
https://api.github.com/repos/huggingface/datasets/issues/2376 | 2,376 | Improve task api code quality | Improves the code quality of the `TaskTemplate` dataclasses.
Changes:
* replaces `return NotImplemented` with raise `NotImplementedError`
* replaces `sorted` with `len` in the uniqueness check
* defines `label2id` and `id2label` in the `TextClassification` template as properties
* replaces the `object.__setatt... | closed | 2021-05-18T23:13:40 | https://api.github.com/repos/huggingface/datasets/issues/2376/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2376",
"html_url": "https://github.com/huggingface/datasets/pull/2376",
"diff_url": "https://github.com/huggingface/datasets/pull/2376.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2376.patch",
"merged_at": "2021-05-25T15:30... | true | Improve task api code quality
Improves the code quality of the `TaskTemplate` dataclasses.
Changes:
* replaces `return NotImplemented` with raise `NotImplementedError`
* replaces `sorted` with `len` in the uniqueness check
* defines `label2id` and `id2label` in the `TextClassification` template as properties
*... | [
"Looks good thanks, what do you think @lewtun ?",
"thanks for including the lazy `ClassLabel` class @mariosasko ! from my side this LGTM!"
] |
https://api.github.com/repos/huggingface/datasets/issues/2375 | 2,375 | Dataset Streaming | # Dataset Streaming
## API
Current API is
```python
from datasets import load_dataset
# Load an IterableDataset without downloading data
snli = load_dataset("snli", streaming=True)
# Access examples by streaming data
print(next(iter(snli["train"])))
# {'premise': 'A person on a horse jumps over a br... | closed | 2021-05-18T18:20:00 | https://api.github.com/repos/huggingface/datasets/issues/2375/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2375",
"html_url": "https://github.com/huggingface/datasets/pull/2375",
"diff_url": "https://github.com/huggingface/datasets/pull/2375.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2375.patch",
"merged_at": "2021-06-23T16:35... | true | Dataset Streaming
# Dataset Streaming
## API
Current API is
```python
from datasets import load_dataset
# Load an IterableDataset without downloading data
snli = load_dataset("snli", streaming=True)
# Access examples by streaming data
print(next(iter(snli["train"])))
# {'premise': 'A person on a hor... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2374 | 2,374 | add `desc` to `tqdm` in `Dataset.map()` | Fixes #2330. Please let me know if anything is also required in this | closed | 2021-05-18T16:44:29 | https://api.github.com/repos/huggingface/datasets/issues/2374/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2374",
"html_url": "https://github.com/huggingface/datasets/pull/2374",
"diff_url": "https://github.com/huggingface/datasets/pull/2374.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2374.patch",
"merged_at": "2021-05-26T14:59... | true | add `desc` to `tqdm` in `Dataset.map()`
Fixes #2330. Please let me know if anything is also required in this | [
"Once this is merged, let's update `transformers` examples to use this new code. As currently all those tqdm bars are who knows what they are....\r\n\r\nhttps://github.com/huggingface/transformers/issues/11797",
"Sure @stas00! Once this is merged let's discuss what all changes can be done on `transformers` side",... |
https://api.github.com/repos/huggingface/datasets/issues/2373 | 2,373 | Loading dataset from local path | I'm trying to load a local dataset with the code below
```
ds = datasets.load_dataset('my_script.py',
data_files='corpus.txt',
data_dir='/data/dir',
cache_dir='.')
```
But internally a BuilderConfig is created, which tries to u... | closed | 2021-05-18T15:20:50 | https://api.github.com/repos/huggingface/datasets/issues/2373/comments | null | false | Loading dataset from local path
I'm trying to load a local dataset with the code below
```
ds = datasets.load_dataset('my_script.py',
data_files='corpus.txt',
data_dir='/data/dir',
cache_dir='.')
```
But internally a BuilderCon... | [
"Version below works, checked again in the docs, and data_files should be a path.\r\n```\r\nds = datasets.load_dataset('my_script.py', \r\n data_files='/data/dir/corpus.txt', \r\n cache_dir='.')\r\n```"
] |
https://api.github.com/repos/huggingface/datasets/issues/2372 | 2,372 | ConvQuestions benchmark added | Hello,
I would like to integrate our dataset on conversational QA. The answers are grounded in the KG.
The work was published in CIKM 2019 (https://dl.acm.org/doi/10.1145/3357384.3358016).
We hope for further research on how to deal with the challenges of factoid conversational QA.
Thanks! :) | closed | 2021-05-18T15:16:50 | https://api.github.com/repos/huggingface/datasets/issues/2372/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2372",
"html_url": "https://github.com/huggingface/datasets/pull/2372",
"diff_url": "https://github.com/huggingface/datasets/pull/2372.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2372.patch",
"merged_at": "2021-05-26T10:31... | true | ConvQuestions benchmark added
Hello,
I would like to integrate our dataset on conversational QA. The answers are grounded in the KG.
The work was published in CIKM 2019 (https://dl.acm.org/doi/10.1145/3357384.3358016).
We hope for further research on how to deal with the challenges of factoid conversational QA.
Tha... | [
"Thanks for your helpful comments and suggestions! :)\r\nI integrated the additional fields, and extended some of the README/dataset card.\r\nAnd I actually realized that we had the cc-by-4.0 for the dataset, so this was also changed.",
"I added the answers to the test set actually :)",
"Oh great ! Let me rever... |
https://api.github.com/repos/huggingface/datasets/issues/2371 | 2,371 | Align question answering tasks with sub-domains | As pointed out by @thomwolf in #2255 we should consider breaking with the pipeline taxonomy of `transformers` to account for the various types of question-answering domains:
> `question-answering` exists in two forms: abstractive and extractive question answering.
>
> we can keep a generic `question-answering` bu... | closed | 2021-05-18T09:47:59 | https://api.github.com/repos/huggingface/datasets/issues/2371/comments | null | false | Align question answering tasks with sub-domains
As pointed out by @thomwolf in #2255 we should consider breaking with the pipeline taxonomy of `transformers` to account for the various types of question-answering domains:
> `question-answering` exists in two forms: abstractive and extractive question answering.
>
... | [
"Closing this issue as the `task_templates` API has been deprecated."
] |
https://api.github.com/repos/huggingface/datasets/issues/2370 | 2,370 | Adding HendrycksTest dataset | Adding Hendrycks test from https://arxiv.org/abs/2009.03300.
I'm having a bit of trouble with dummy data creation because some lines in the csv files aren't being loaded properly (only the first entry loaded in a row of length 6). The dataset is loading just fine. Hope you can kindly help!
Thank you! | closed | 2021-05-17T18:53:05 | https://api.github.com/repos/huggingface/datasets/issues/2370/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2370",
"html_url": "https://github.com/huggingface/datasets/pull/2370",
"diff_url": "https://github.com/huggingface/datasets/pull/2370.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2370.patch",
"merged_at": "2021-05-31T16:37... | true | Adding HendrycksTest dataset
Adding Hendrycks test from https://arxiv.org/abs/2009.03300.
I'm having a bit of trouble with dummy data creation because some lines in the csv files aren't being loaded properly (only the first entry loaded in a row of length 6). The dataset is loading just fine. Hope you can kindly help!... | [
"@lhoestq Thank you for the review. I've made the suggested changes. There still might be some problems with dummy data though due to some csv loading issues (which I haven't found the cause to).",
"I took a look at the dummy data and some csv lines were cropped. I fixed them :)",
"@andyzoujm Any reason why thi... |
https://api.github.com/repos/huggingface/datasets/issues/2369 | 2,369 | correct labels of conll2003 | # What does this PR
It fixes/extends the `ner_tags` for conll2003 to include all.
Paper reference https://arxiv.org/pdf/cs/0306050v1.pdf
Model reference https://huggingface.co/elastic/distilbert-base-cased-finetuned-conll03-english/blob/main/config.json
| closed | 2021-05-17T17:37:54 | https://api.github.com/repos/huggingface/datasets/issues/2369/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2369",
"html_url": "https://github.com/huggingface/datasets/pull/2369",
"diff_url": "https://github.com/huggingface/datasets/pull/2369.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2369.patch",
"merged_at": "2021-05-18T08:27... | true | correct labels of conll2003
# What does this PR
It fixes/extends the `ner_tags` for conll2003 to include all.
Paper reference https://arxiv.org/pdf/cs/0306050v1.pdf
Model reference https://huggingface.co/elastic/distilbert-base-cased-finetuned-conll03-english/blob/main/config.json
| [] |
https://api.github.com/repos/huggingface/datasets/issues/2368 | 2,368 | Allow "other-X" in licenses | This PR allows "other-X" licenses during metadata validation.
@lhoestq | closed | 2021-05-17T14:47:54 | https://api.github.com/repos/huggingface/datasets/issues/2368/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2368",
"html_url": "https://github.com/huggingface/datasets/pull/2368",
"diff_url": "https://github.com/huggingface/datasets/pull/2368.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2368.patch",
"merged_at": "2021-05-17T16:36... | true | Allow "other-X" in licenses
This PR allows "other-X" licenses during metadata validation.
@lhoestq | [] |
https://api.github.com/repos/huggingface/datasets/issues/2367 | 2,367 | Remove getchildren from hyperpartisan news detection | `Element.getchildren()` is now deprecated in the ElementTree library (I think in python 3.9, so it still passes the automated tests which are using 3.6. But for those of us on bleeding-edge distros it now fails).
https://bugs.python.org/issue29209 | closed | 2021-05-17T13:10:37 | https://api.github.com/repos/huggingface/datasets/issues/2367/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2367",
"html_url": "https://github.com/huggingface/datasets/pull/2367",
"diff_url": "https://github.com/huggingface/datasets/pull/2367.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2367.patch",
"merged_at": "2021-05-17T14:07... | true | Remove getchildren from hyperpartisan news detection
`Element.getchildren()` is now deprecated in the ElementTree library (I think in python 3.9, so it still passes the automated tests which are using 3.6. But for those of us on bleeding-edge distros it now fails).
https://bugs.python.org/issue29209 | [] |
https://api.github.com/repos/huggingface/datasets/issues/2366 | 2,366 | Json loader fails if user-specified features don't match the json data fields order | If you do
```python
dataset = load_dataset("json", data_files=data_files, features=features)
```
Then depending on the order of the features in the json data field it fails:
```python
[...]
~/Desktop/hf/datasets/src/datasets/packaged_modules/json/json.py in _generate_tables(self, files)
94 if s... | closed | 2021-05-17T10:26:08 | https://api.github.com/repos/huggingface/datasets/issues/2366/comments | null | false | Json loader fails if user-specified features don't match the json data fields order
If you do
```python
dataset = load_dataset("json", data_files=data_files, features=features)
```
Then depending on the order of the features in the json data field it fails:
```python
[...]
~/Desktop/hf/datasets/src/datasets/pack... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2365 | 2,365 | Missing ClassLabel encoding in Json loader | Currently if you want to load a json dataset this way
```python
dataset = load_dataset("json", data_files=data_files, features=features)
```
Then if your features has ClassLabel types and if your json data needs class label encoding (i.e. if the labels in the json files are strings and not integers), then it would ... | closed | 2021-05-17T10:19:10 | https://api.github.com/repos/huggingface/datasets/issues/2365/comments | null | false | Missing ClassLabel encoding in Json loader
Currently if you want to load a json dataset this way
```python
dataset = load_dataset("json", data_files=data_files, features=features)
```
Then if your features has ClassLabel types and if your json data needs class label encoding (i.e. if the labels in the json files ar... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2364 | 2,364 | README updated for SNLI, MNLI | Closes #2275. Mentioned about -1 labels in MNLI, SNLI and how they should be removed before training. @lhoestq `check_code_quality` test might fail for MNLI as the license name `other-Open Portion of the American National Corpus` is not a registered tag for 'licenses' | closed | 2021-05-15T11:37:59 | https://api.github.com/repos/huggingface/datasets/issues/2364/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2364",
"html_url": "https://github.com/huggingface/datasets/pull/2364",
"diff_url": "https://github.com/huggingface/datasets/pull/2364.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2364.patch",
"merged_at": "2021-05-17T13:34... | true | README updated for SNLI, MNLI
Closes #2275. Mentioned about -1 labels in MNLI, SNLI and how they should be removed before training. @lhoestq `check_code_quality` test might fail for MNLI as the license name `other-Open Portion of the American National Corpus` is not a registered tag for 'licenses' | [
"Regarding the license issue, I think we should allow it since it starts with `other-`. Cc @gchhablani what do you think ?",
"@lhoestq I agree, I'll look into it."
] |
https://api.github.com/repos/huggingface/datasets/issues/2362 | 2,362 | Fix web_nlg metadata | Our metadata storage system does not support `.` inside keys. cc @Pierrci
| closed | 2021-05-14T17:15:07 | https://api.github.com/repos/huggingface/datasets/issues/2362/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2362",
"html_url": "https://github.com/huggingface/datasets/pull/2362",
"diff_url": "https://github.com/huggingface/datasets/pull/2362.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2362.patch",
"merged_at": null
} | true | Fix web_nlg metadata
Our metadata storage system does not support `.` inside keys. cc @Pierrci
| [
"Hi ! `release_v2.1` and the others are dataset configuration names.\r\n\r\nThe configuration names are used to show the right code snippet in the UI to load the dataset.\r\nFor example if the parsing of the web_nlg tags worked correctly we would have:\r\n![image](https://user-images.githubusercontent.com/42851186/... |
https://api.github.com/repos/huggingface/datasets/issues/2361 | 2,361 | Preserve dtype for numpy/torch/tf/jax arrays | Fixes #625. This lets the user preserve the dtype of numpy array to pyarrow array which was getting lost due to conversion of numpy array -> list -> pyarrow array. | closed | 2021-05-14T14:45:23 | https://api.github.com/repos/huggingface/datasets/issues/2361/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2361",
"html_url": "https://github.com/huggingface/datasets/pull/2361",
"diff_url": "https://github.com/huggingface/datasets/pull/2361.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2361.patch",
"merged_at": "2021-08-17T08:30... | true | Preserve dtype for numpy/torch/tf/jax arrays
Fixes #625. This lets the user preserve the dtype of numpy array to pyarrow array which was getting lost due to conversion of numpy array -> list -> pyarrow array. | [
"Hi @lhoestq, \r\nIt turns out that pyarrow `ListArray` are not recognized as list-like when we get output from `numpy_to_pyarrow_listarray`. This might cause tests to fail. If possible can we convert that `ListArray` output to list inorder for tests to pass? Under the hood it'll maintain the dtype as that of numpy... |
https://api.github.com/repos/huggingface/datasets/issues/2360 | 2,360 | Automatically detect datasets with compatible task schemas | See description of #2255 for details.
| open | 2021-05-14T14:23:40 | https://api.github.com/repos/huggingface/datasets/issues/2360/comments | null | false | Automatically detect datasets with compatible task schemas
See description of #2255 for details.
| [] |
https://api.github.com/repos/huggingface/datasets/issues/2359 | 2,359 | Allow model labels to be passed during task preparation | Models have a config with label2id. And we have the same for datasets with the ClassLabel feature type. At one point either the model or the dataset must sync with the other. It would be great to do that on the dataset side.
For example for sentiment classification on amazon reviews with you could have these labels:... | closed | 2021-05-14T13:58:28 | https://api.github.com/repos/huggingface/datasets/issues/2359/comments | null | false | Allow model labels to be passed during task preparation
Models have a config with label2id. And we have the same for datasets with the ClassLabel feature type. At one point either the model or the dataset must sync with the other. It would be great to do that on the dataset side.
For example for sentiment classifica... | [
"We now have the `align_labels_with_mapping` method in the API for this purpose."
] |
https://api.github.com/repos/huggingface/datasets/issues/2358 | 2,358 | Roman Urdu Stopwords List | A list of most frequently used Roman Urdu words with different spellings and usages.
This is a very basic effort to collect some basic stopwords for Roman Urdu to help efforts of analyzing text data in roman Urdu which makes up a huge part of daily internet interaction of Roman-Urdu users. | closed | 2021-05-13T18:29:27 | https://api.github.com/repos/huggingface/datasets/issues/2358/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2358",
"html_url": "https://github.com/huggingface/datasets/pull/2358",
"diff_url": "https://github.com/huggingface/datasets/pull/2358.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2358.patch",
"merged_at": null
} | true | Roman Urdu Stopwords List
A list of most frequently used Roman Urdu words with different spellings and usages.
This is a very basic effort to collect some basic stopwords for Roman Urdu to help efforts of analyzing text data in roman Urdu which makes up a huge part of daily internet interaction of Roman-Urdu users. | [
"Hi ! Thanks for sharing :)\r\nI think the best place to share this is probably the `Languages at Hugging Face` section of the forum:\r\nhttps://discuss.huggingface.co/c/languages-at-hugging-face/15\r\n\r\nSince this is not a dataset, I'm closing this PR if you don't mind",
"Thank you I will look into the link th... |
https://api.github.com/repos/huggingface/datasets/issues/2357 | 2,357 | Adding Microsoft CodeXGlue Datasets | Hi there, this is a new pull request to get the CodeXGlue datasets into the awesome HF datasets lib. Most of the work has been done in this PR #997 by the awesome @madlag. However, that PR has been stale for a while now and so I spoke with @lhoestq about finishing up the final mile and so he told me to open a new PR wi... | closed | 2021-05-13T00:43:01 | https://api.github.com/repos/huggingface/datasets/issues/2357/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2357",
"html_url": "https://github.com/huggingface/datasets/pull/2357",
"diff_url": "https://github.com/huggingface/datasets/pull/2357.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2357.patch",
"merged_at": "2021-06-08T09:29... | true | Adding Microsoft CodeXGlue Datasets
Hi there, this is a new pull request to get the CodeXGlue datasets into the awesome HF datasets lib. Most of the work has been done in this PR #997 by the awesome @madlag. However, that PR has been stale for a while now and so I spoke with @lhoestq about finishing up the final mile a... | [
"Oh one other thing. Mentioned in the PR was that I would need to regenerate the dataset_infos.json once the camel casing was done. However, I am unsure why this is the case since there is no reference to any object names in the dataset_infos.json file.\r\n\r\nIf it needs to be reran, I can try it do it on my own m... |
https://api.github.com/repos/huggingface/datasets/issues/2355 | 2,355 | normalized TOCs and titles in data cards | I started fixing some of the READMEs that were failing the tests introduced by @gchhablani but then realized that there were some consistent differences between earlier and newer versions of some of the titles (e.g. Data Splits vs Data Splits Sample Size, Supported Tasks vs Supported Tasks and Leaderboards). We also ha... | closed | 2021-05-12T20:59:59 | https://api.github.com/repos/huggingface/datasets/issues/2355/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2355",
"html_url": "https://github.com/huggingface/datasets/pull/2355",
"diff_url": "https://github.com/huggingface/datasets/pull/2355.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2355.patch",
"merged_at": "2021-05-14T13:23... | true | normalized TOCs and titles in data cards
I started fixing some of the READMEs that were failing the tests introduced by @gchhablani but then realized that there were some consistent differences between earlier and newer versions of some of the titles (e.g. Data Splits vs Data Splits Sample Size, Supported Tasks vs Supp... | [
"Oh right! I'd be in favor of still having the same TOC across the board, we can either leave it as is or add a `[More Info Needed]` `Contributions` Section wherever it's currently missing, wdyt?",
"(I thought those were programmatically updated based on git history :D )",
"Merging for now to avoid conflict sin... |
https://api.github.com/repos/huggingface/datasets/issues/2354 | 2,354 | Document DatasetInfo attributes | **Is your feature request related to a problem? Please describe.**
As noted in PR #2255, the attributes of `DatasetInfo` are not documented in the [docs](https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=datasetinfo#datasetinfo). It would be nice to do so :)
| closed | 2021-05-12T20:01:29 | https://api.github.com/repos/huggingface/datasets/issues/2354/comments | null | false | Document DatasetInfo attributes
**Is your feature request related to a problem? Please describe.**
As noted in PR #2255, the attributes of `DatasetInfo` are not documented in the [docs](https://huggingface.co/docs/datasets/package_reference/main_classes.html?highlight=datasetinfo#datasetinfo). It would be nice to do s... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2353 | 2,353 | Update README vallidation rules | This PR allows unexpected subsections under third-level headings. All except `Contributions`.
@lhoestq | closed | 2021-05-12T16:57:26 | https://api.github.com/repos/huggingface/datasets/issues/2353/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2353",
"html_url": "https://github.com/huggingface/datasets/pull/2353",
"diff_url": "https://github.com/huggingface/datasets/pull/2353.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2353.patch",
"merged_at": "2021-05-14T08:56... | true | Update README vallidation rules
This PR allows unexpected subsections under third-level headings. All except `Contributions`.
@lhoestq | [] |
https://api.github.com/repos/huggingface/datasets/issues/2352 | 2,352 | Set to_json default to JSON lines | With this PR, the method `Dataset.to_json`:
- is added to the docs
- defaults to JSON lines | closed | 2021-05-12T08:19:25 | https://api.github.com/repos/huggingface/datasets/issues/2352/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2352",
"html_url": "https://github.com/huggingface/datasets/pull/2352",
"diff_url": "https://github.com/huggingface/datasets/pull/2352.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2352.patch",
"merged_at": "2021-05-21T09:01... | true | Set to_json default to JSON lines
With this PR, the method `Dataset.to_json`:
- is added to the docs
- defaults to JSON lines | [
"This is perfect, @albertvillanova - thank you! Tested it to work.\r\n\r\nMight it be a good idea to document the args to `to_json`?\r\n\r\nand also even a very basic progress bar? took 10min for 8M large records for `openwebtext` so perhaps some indication of it's being alive every min or so?",
"@lhoestq I added... |
https://api.github.com/repos/huggingface/datasets/issues/2351 | 2,351 | simpllify faiss index save | Fixes #2350
In some cases, Faiss GPU index objects do not have neither "device" nor "getDevice". Possibly this happens when some part of the index is computed on CPU.
In particular, this would happen with the index `OPQ16_128,IVF512,PQ32` (issue #2350). I did check it, but it is likely that `OPQ` or `PQ` transfor... | closed | 2021-05-12T03:54:10 | https://api.github.com/repos/huggingface/datasets/issues/2351/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/2351",
"html_url": "https://github.com/huggingface/datasets/pull/2351",
"diff_url": "https://github.com/huggingface/datasets/pull/2351.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/2351.patch",
"merged_at": "2021-05-17T13:41... | true | simpllify faiss index save
Fixes #2350
In some cases, Faiss GPU index objects do not have neither "device" nor "getDevice". Possibly this happens when some part of the index is computed on CPU.
In particular, this would happen with the index `OPQ16_128,IVF512,PQ32` (issue #2350). I did check it, but it is likely ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/2350 | 2,350 | `FaissIndex.save` throws error on GPU | ## Describe the bug
After training an index with a factory string `OPQ16_128,IVF512,PQ32` on GPU, `.save_faiss_index` throws this error.
```
File "index_wikipedia.py", line 119, in <module>
data["train"].save_faiss_index("text_emb", index_save_path)
File "/home/vlialin/miniconda3/envs/cat/lib/python3.8... | closed | 2021-05-12T03:41:56 | https://api.github.com/repos/huggingface/datasets/issues/2350/comments | null | false | `FaissIndex.save` throws error on GPU
## Describe the bug
After training an index with a factory string `OPQ16_128,IVF512,PQ32` on GPU, `.save_faiss_index` throws this error.
```
File "index_wikipedia.py", line 119, in <module>
data["train"].save_faiss_index("text_emb", index_save_path)
File "/home/vli... | [
"Just in case, this is a workaround that I use in my code and it seems to do the job.\r\n\r\n```python\r\nif use_gpu_index:\r\n data[\"train\"]._indexes[\"text_emb\"].faiss_index = faiss.index_gpu_to_cpu(data[\"train\"]._indexes[\"text_emb\"].faiss_index)\r\n```"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.