url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/2555
2,555
Fix code_search_net keys
There were duplicate keys in the `code_search_net` dataset, as reported in https://github.com/huggingface/datasets/issues/2552 I fixed the keys (it was an addition of the file and row indices, which was causing collisions) Fix #2552.
closed
2021-06-28T13:40:23
https://api.github.com/repos/huggingface/datasets/issues/2555/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2555", "html_url": "https://github.com/huggingface/datasets/pull/2555", "diff_url": "https://github.com/huggingface/datasets/pull/2555.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2555.patch", "merged_at": "2021-06-28T14:10...
true
Fix code_search_net keys There were duplicate keys in the `code_search_net` dataset, as reported in https://github.com/huggingface/datasets/issues/2552 I fixed the keys (it was an addition of the file and row indices, which was causing collisions) Fix #2552.
[ "Fix #2552." ]
https://api.github.com/repos/huggingface/datasets/issues/2554
2,554
Multilabel metrics not supported
When I try to use a metric like F1 macro I get the following error: ``` TypeError: int() argument must be a string, a bytes-like object or a number, not 'list' ``` There is an explicit casting here: https://github.com/huggingface/datasets/blob/fc79f61cbbcfa0e8c68b28c0a8257f17e768a075/src/datasets/features.py#L...
closed
2021-06-28T11:09:46
https://api.github.com/repos/huggingface/datasets/issues/2554/comments
null
false
Multilabel metrics not supported When I try to use a metric like F1 macro I get the following error: ``` TypeError: int() argument must be a string, a bytes-like object or a number, not 'list' ``` There is an explicit casting here: https://github.com/huggingface/datasets/blob/fc79f61cbbcfa0e8c68b28c0a8257f17e7...
[ "Hi @GuillemGSubies, thanks for reporting.\r\n\r\nI have made a PR to fix this issue and allow metrics to be computed also for multilabel classification problems.", "Looks nice, thank you very much! 🚀 ", "Sorry for reopening but I just noticed that the `_compute` method for the F1 metric is still not good enou...
https://api.github.com/repos/huggingface/datasets/issues/2553
2,553
load_dataset("web_nlg") NonMatchingChecksumError
Hi! It seems the WebNLG dataset gives a NonMatchingChecksumError. ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset('web_nlg', name="release_v3.0_en", split="dev") ``` Gives ``` NonMatchingChecksumError: Checksums didn't match for dataset source files: ['h...
closed
2021-06-28T09:26:46
https://api.github.com/repos/huggingface/datasets/issues/2553/comments
null
false
load_dataset("web_nlg") NonMatchingChecksumError Hi! It seems the WebNLG dataset gives a NonMatchingChecksumError. ## Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset('web_nlg', name="release_v3.0_en", split="dev") ``` Gives ``` NonMatchingChecksumError: Chec...
[ "Hi ! Thanks for reporting. This is due to the WebNLG repository that got updated today.\r\nI just pushed a fix at #2558 - this shouldn't happen anymore in the future.", "This is fixed on `master` now :)\r\nWe'll do a new release soon !" ]
https://api.github.com/repos/huggingface/datasets/issues/2552
2,552
Keys should be unique error on code_search_net
## Describe the bug Loading `code_search_net` seems not possible at the moment. ## Steps to reproduce the bug ```python >>> load_dataset('code_search_net') Downloading: 8.50kB [00:00, 3.09MB/s] ...
closed
2021-06-28T09:15:20
https://api.github.com/repos/huggingface/datasets/issues/2552/comments
null
false
Keys should be unique error on code_search_net ## Describe the bug Loading `code_search_net` seems not possible at the moment. ## Steps to reproduce the bug ```python >>> load_dataset('code_search_net') Downloading: 8.50kB [00:00, 3.09MB/s] ...
[ "Two questions:\r\n- with `datasets-cli env` we don't have any information on the dataset script version used. Should we give access to this somehow? Either as a note in the Error message or as an argument with the name of the dataset to `datasets-cli env`?\r\n- I don't really understand why the id is duplicated in...
https://api.github.com/repos/huggingface/datasets/issues/2551
2,551
Fix FileSystems documentation
### What this fixes: This PR resolves several issues I discovered in the documentation on the `datasets.filesystems` module ([this page](https://huggingface.co/docs/datasets/filesystems.html)). ### What were the issues? When I originally tried implementing the code examples I faced several bugs attributed to: -...
closed
2021-06-27T16:18:42
https://api.github.com/repos/huggingface/datasets/issues/2551/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2551", "html_url": "https://github.com/huggingface/datasets/pull/2551", "diff_url": "https://github.com/huggingface/datasets/pull/2551.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2551.patch", "merged_at": "2021-06-28T13:09...
true
Fix FileSystems documentation ### What this fixes: This PR resolves several issues I discovered in the documentation on the `datasets.filesystems` module ([this page](https://huggingface.co/docs/datasets/filesystems.html)). ### What were the issues? When I originally tried implementing the code examples I faced se...
[]
https://api.github.com/repos/huggingface/datasets/issues/2550
2,550
Allow for incremental cumulative metric updates in a distributed setup
Currently, using a metric allows for one of the following: - Per example/batch metrics - Cumulative metrics over the whole data What I'd like is to have an efficient way to get cumulative metrics over the examples/batches added so far, in order to display it as part of the progress bar during training/evaluation. ...
closed
2021-06-27T15:00:58
https://api.github.com/repos/huggingface/datasets/issues/2550/comments
null
false
Allow for incremental cumulative metric updates in a distributed setup Currently, using a metric allows for one of the following: - Per example/batch metrics - Cumulative metrics over the whole data What I'd like is to have an efficient way to get cumulative metrics over the examples/batches added so far, in order...
[]
https://api.github.com/repos/huggingface/datasets/issues/2549
2,549
Handling unlabeled datasets
Hi! Is there a way for datasets to produce unlabeled instances (e.g., the `ClassLabel` can be nullable). For example, I want to use the MNLI dataset reader ( https://github.com/huggingface/datasets/blob/master/datasets/multi_nli/multi_nli.py ) on a file that doesn't have the `gold_label` field. I tried setting `"...
closed
2021-06-25T04:32:23
https://api.github.com/repos/huggingface/datasets/issues/2549/comments
null
false
Handling unlabeled datasets Hi! Is there a way for datasets to produce unlabeled instances (e.g., the `ClassLabel` can be nullable). For example, I want to use the MNLI dataset reader ( https://github.com/huggingface/datasets/blob/master/datasets/multi_nli/multi_nli.py ) on a file that doesn't have the `gold_labe...
[ "Hi @nelson-liu,\r\n\r\nYou can pass the parameter `features` to `load_dataset`: https://huggingface.co/docs/datasets/_modules/datasets/load.html#load_dataset\r\n\r\nIf you look at the code of the MNLI script you referred in your question (https://github.com/huggingface/datasets/blob/master/datasets/multi_nli/multi...
https://api.github.com/repos/huggingface/datasets/issues/2548
2,548
Field order issue in loading json
## Describe the bug The `load_dataset` function expects columns in alphabetical order when loading json files. Similar bug was previously reported for csv in #623 and fixed in #684. ## Steps to reproduce the bug For a json file `j.json`, ``` {"c":321, "a": 1, "b": 2} ``` Running the following, ``` f= data...
closed
2021-06-24T13:29:53
https://api.github.com/repos/huggingface/datasets/issues/2548/comments
null
false
Field order issue in loading json ## Describe the bug The `load_dataset` function expects columns in alphabetical order when loading json files. Similar bug was previously reported for csv in #623 and fixed in #684. ## Steps to reproduce the bug For a json file `j.json`, ``` {"c":321, "a": 1, "b": 2} ``` Ru...
[ "Hi @luyug, thanks for reporting.\r\n\r\nThe good news is that we fixed this issue only 9 days ago: #2507.\r\n\r\nThe patch is already in the master branch of our repository and it will be included in our next `datasets` release version 1.9.0.\r\n\r\nFeel free to reopen the issue if the problem persists." ]
https://api.github.com/repos/huggingface/datasets/issues/2547
2,547
Dataset load_from_disk is too slow
@lhoestq ## Describe the bug It's not normal that I have to wait 7-8 hours for a dataset to be loaded from disk, as there are no preprocessing steps, it's only loading it with load_from_disk. I have 96 cpus, however only 1 is used for this, which is inefficient. Moreover, its usage is at 1%... This is happening in t...
open
2021-06-24T12:45:44
https://api.github.com/repos/huggingface/datasets/issues/2547/comments
null
false
Dataset load_from_disk is too slow @lhoestq ## Describe the bug It's not normal that I have to wait 7-8 hours for a dataset to be loaded from disk, as there are no preprocessing steps, it's only loading it with load_from_disk. I have 96 cpus, however only 1 is used for this, which is inefficient. Moreover, its usage...
[ "Hi ! It looks like an issue with the virtual disk you are using.\r\n\r\nWe load datasets using memory mapping. In general it makes it possible to load very big files instantaneously since it doesn't have to read the file (it just assigns virtual memory to the file on disk).\r\nHowever there happens to be issues wi...
https://api.github.com/repos/huggingface/datasets/issues/2546
2,546
Add license to the Cambridge English Write & Improve + LOCNESS dataset card
As noticed in https://github.com/huggingface/datasets/pull/2539, the licensing information was missing for this dataset. I added it and I also filled a few other empty sections.
closed
2021-06-24T10:39:29
https://api.github.com/repos/huggingface/datasets/issues/2546/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2546", "html_url": "https://github.com/huggingface/datasets/pull/2546", "diff_url": "https://github.com/huggingface/datasets/pull/2546.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2546.patch", "merged_at": "2021-06-24T10:52...
true
Add license to the Cambridge English Write & Improve + LOCNESS dataset card As noticed in https://github.com/huggingface/datasets/pull/2539, the licensing information was missing for this dataset. I added it and I also filled a few other empty sections.
[]
https://api.github.com/repos/huggingface/datasets/issues/2545
2,545
Fix DuplicatedKeysError in drop dataset
Close #2542. cc: @VictorSanh.
closed
2021-06-24T09:10:39
https://api.github.com/repos/huggingface/datasets/issues/2545/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2545", "html_url": "https://github.com/huggingface/datasets/pull/2545", "diff_url": "https://github.com/huggingface/datasets/pull/2545.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2545.patch", "merged_at": "2021-06-24T14:57...
true
Fix DuplicatedKeysError in drop dataset Close #2542. cc: @VictorSanh.
[]
https://api.github.com/repos/huggingface/datasets/issues/2544
2,544
Fix logging levels
Sometimes default `datasets` logging can be too verbose. One approach could be reducing some logging levels, from info to debug, or from warning to info. Close #2543. cc: @stas00
closed
2021-06-24T06:41:36
https://api.github.com/repos/huggingface/datasets/issues/2544/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2544", "html_url": "https://github.com/huggingface/datasets/pull/2544", "diff_url": "https://github.com/huggingface/datasets/pull/2544.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2544.patch", "merged_at": "2021-06-25T13:40...
true
Fix logging levels Sometimes default `datasets` logging can be too verbose. One approach could be reducing some logging levels, from info to debug, or from warning to info. Close #2543. cc: @stas00
[]
https://api.github.com/repos/huggingface/datasets/issues/2543
2,543
switching some low-level log.info's to log.debug?
In https://github.com/huggingface/transformers/pull/12276 we are now changing the examples to have `datasets` on the same log level as `transformers`, so that one setting can do a consistent logging across all involved components. The trouble is that now we get a ton of these: ``` 06/23/2021 12:15:31 - INFO - da...
closed
2021-06-23T19:26:55
https://api.github.com/repos/huggingface/datasets/issues/2543/comments
null
false
switching some low-level log.info's to log.debug? In https://github.com/huggingface/transformers/pull/12276 we are now changing the examples to have `datasets` on the same log level as `transformers`, so that one setting can do a consistent logging across all involved components. The trouble is that now we get a ton...
[ "Hi @stas00, thanks for pointing out this issue with logging.\r\n\r\nI agree that `datasets` can sometimes be too verbose... I can create a PR and we could discuss there the choice of the log levels for different parts of the code." ]
https://api.github.com/repos/huggingface/datasets/issues/2542
2,542
`datasets.keyhash.DuplicatedKeysError` for `drop` and `adversarial_qa/adversarialQA`
## Describe the bug Failure to generate the datasets (`drop` and subset `adversarialQA` from `adversarial_qa`) because of duplicate keys. ## Steps to reproduce the bug ```python from datasets import load_dataset load_dataset("drop") load_dataset("adversarial_qa", "adversarialQA") ``` ## Expected results Th...
closed
2021-06-23T18:41:16
https://api.github.com/repos/huggingface/datasets/issues/2542/comments
null
false
`datasets.keyhash.DuplicatedKeysError` for `drop` and `adversarial_qa/adversarialQA` ## Describe the bug Failure to generate the datasets (`drop` and subset `adversarialQA` from `adversarial_qa`) because of duplicate keys. ## Steps to reproduce the bug ```python from datasets import load_dataset load_dataset("dr...
[ "very much related: https://github.com/huggingface/datasets/pull/2333", "Hi @VictorSanh, thank you for reporting this issue with duplicated keys.\r\n\r\n- The issue with \"adversarial_qa\" was fixed 23 days ago: #2433. Current version of `datasets` (1.8.0) includes the patch.\r\n- I am investigating the issue wit...
https://api.github.com/repos/huggingface/datasets/issues/2541
2,541
update discofuse link cc @ekQ
Updating the discofuse link: https://github.com/google-research-datasets/discofuse/commit/fd4b120cb3dd19a417e7f3b5432010b574b5eeee
closed
2021-06-23T18:24:58
https://api.github.com/repos/huggingface/datasets/issues/2541/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2541", "html_url": "https://github.com/huggingface/datasets/pull/2541", "diff_url": "https://github.com/huggingface/datasets/pull/2541.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2541.patch", "merged_at": "2021-06-28T14:34...
true
update discofuse link cc @ekQ Updating the discofuse link: https://github.com/google-research-datasets/discofuse/commit/fd4b120cb3dd19a417e7f3b5432010b574b5eeee
[ "The CI is failing because the dataset tags for `discofuse` are missing. I'm merging this PR since this is unrelated to this PR, but feel free to open another PR to add the tags here if you have some time:\r\n\r\nhttps://github.com/huggingface/datasets/blob/19408f9fab85c79b966085574cd2da3b90959179/datasets/discofus...
https://api.github.com/repos/huggingface/datasets/issues/2540
2,540
Remove task templates if required features are removed during `Dataset.map`
This PR fixes a bug reported by @craffel where removing a dataset's columns during `Dataset.map` triggered a `KeyError` because the `TextClassification` template tried to access the removed columns during `DatasetInfo.__post_init__`: ```python from datasets import load_dataset # `yelp_polarity` comes with a `Tex...
closed
2021-06-23T16:20:25
https://api.github.com/repos/huggingface/datasets/issues/2540/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2540", "html_url": "https://github.com/huggingface/datasets/pull/2540", "diff_url": "https://github.com/huggingface/datasets/pull/2540.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2540.patch", "merged_at": "2021-06-24T13:34...
true
Remove task templates if required features are removed during `Dataset.map` This PR fixes a bug reported by @craffel where removing a dataset's columns during `Dataset.map` triggered a `KeyError` because the `TextClassification` template tried to access the removed columns during `DatasetInfo.__post_init__`: ```pyth...
[]
https://api.github.com/repos/huggingface/datasets/issues/2539
2,539
remove wi_locness dataset due to licensing issues
It was brought to my attention that this dataset's license is not only missing, but also prohibits redistribution. I contacted the original author to apologize for this oversight and asked if we could still use it, but unfortunately we can't and the author kindly asked to take down this dataset.
closed
2021-06-23T07:35:32
https://api.github.com/repos/huggingface/datasets/issues/2539/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2539", "html_url": "https://github.com/huggingface/datasets/pull/2539", "diff_url": "https://github.com/huggingface/datasets/pull/2539.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2539.patch", "merged_at": null }
true
remove wi_locness dataset due to licensing issues It was brought to my attention that this dataset's license is not only missing, but also prohibits redistribution. I contacted the original author to apologize for this oversight and asked if we could still use it, but unfortunately we can't and the author kindly asked ...
[ "Hi ! I'm sorry to hear that.\r\nThough we are not redistributing the dataset, we just provide a python script that downloads and process the dataset from its original source hosted at https://www.cl.cam.ac.uk\r\n\r\nTherefore I'm not sure what's the issue with licensing. What do you mean exactly ?", "I think tha...
https://api.github.com/repos/huggingface/datasets/issues/2538
2,538
Loading partial dataset when debugging
I am using PyTorch Lightning along with datasets (thanks for so many datasets already prepared and the great splits). Every time I execute load_dataset for the imdb dataset it takes some time even if I specify a split involving very few samples. I guess this due to hashing as per the other issues. Is there a wa...
open
2021-06-23T07:19:52
https://api.github.com/repos/huggingface/datasets/issues/2538/comments
null
false
Loading partial dataset when debugging I am using PyTorch Lightning along with datasets (thanks for so many datasets already prepared and the great splits). Every time I execute load_dataset for the imdb dataset it takes some time even if I specify a split involving very few samples. I guess this due to hashing as...
[ "Hi ! `load_dataset` downloads the full dataset once and caches it, so that subsequent calls to `load_dataset` just reloads the dataset from your disk.\r\nThen when you specify a `split` in `load_dataset`, it will just load the requested split from the disk. If your specified split is a sliced split (e.g. `\"train[...
https://api.github.com/repos/huggingface/datasets/issues/2537
2,537
Add Parquet loader + from_parquet and to_parquet
Continuation of #2247 I added a "parquet" dataset builder, as well as the methods `Dataset.from_parquet` and `Dataset.to_parquet`. As usual, the data are converted to arrow in a batched way to avoid loading everything in memory.
closed
2021-06-22T17:28:23
https://api.github.com/repos/huggingface/datasets/issues/2537/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2537", "html_url": "https://github.com/huggingface/datasets/pull/2537", "diff_url": "https://github.com/huggingface/datasets/pull/2537.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2537.patch", "merged_at": "2021-06-30T16:30...
true
Add Parquet loader + from_parquet and to_parquet Continuation of #2247 I added a "parquet" dataset builder, as well as the methods `Dataset.from_parquet` and `Dataset.to_parquet`. As usual, the data are converted to arrow in a batched way to avoid loading everything in memory.
[ "`pyarrow` 1.0.0 doesn't support some types in parquet, we'll have to bump its minimum version.\r\n\r\nAlso I still need to add dummy data to test the parquet builder.", "I had to bump the minimum pyarrow version to 3.0.0 to properly support parquet.\r\n\r\nEverything is ready for review now :)\r\nI reused pretty...
https://api.github.com/repos/huggingface/datasets/issues/2536
2,536
Use `Audio` features for `AutomaticSpeechRecognition` task template
In #2533 we added a task template for speech recognition that relies on the file paths to the audio files. As pointed out by @SBrandeis this is brittle as it doesn't port easily across different OS'. The solution is to use dedicated `Audio` features when casting the dataset. These features are not yet available in ...
closed
2021-06-22T15:07:21
https://api.github.com/repos/huggingface/datasets/issues/2536/comments
null
false
Use `Audio` features for `AutomaticSpeechRecognition` task template In #2533 we added a task template for speech recognition that relies on the file paths to the audio files. As pointed out by @SBrandeis this is brittle as it doesn't port easily across different OS'. The solution is to use dedicated `Audio` feature...
[ "I'm just retaking and working on #2324. 😉 ", "Resolved via https://github.com/huggingface/datasets/pull/4006." ]
https://api.github.com/repos/huggingface/datasets/issues/2535
2,535
Improve Features docs
- Fix rendering and cross-references in Features docs - Add docstrings to Features methods
closed
2021-06-22T15:03:27
https://api.github.com/repos/huggingface/datasets/issues/2535/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2535", "html_url": "https://github.com/huggingface/datasets/pull/2535", "diff_url": "https://github.com/huggingface/datasets/pull/2535.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2535.patch", "merged_at": "2021-06-23T13:40...
true
Improve Features docs - Fix rendering and cross-references in Features docs - Add docstrings to Features methods
[]
https://api.github.com/repos/huggingface/datasets/issues/2534
2,534
Sync with transformers disabling NOTSET
Close #2528.
closed
2021-06-22T12:54:21
https://api.github.com/repos/huggingface/datasets/issues/2534/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2534", "html_url": "https://github.com/huggingface/datasets/pull/2534", "diff_url": "https://github.com/huggingface/datasets/pull/2534.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2534.patch", "merged_at": "2021-06-24T14:42...
true
Sync with transformers disabling NOTSET Close #2528.
[ "Nice thanks ! I think there are other places with\r\n```python\r\nnot_verbose = bool(logger.getEffectiveLevel() > WARNING)\r\n```\r\n\r\nCould you replace them as well ?", "Sure @lhoestq! I was not sure if this change should only be circumscribed to `http_get`..." ]
https://api.github.com/repos/huggingface/datasets/issues/2533
2,533
Add task template for automatic speech recognition
This PR adds a task template for automatic speech recognition. In this task, the input is a path to an audio file which the model consumes to produce a transcription. Usage: ```python from datasets import load_dataset from datasets.tasks import AutomaticSpeechRecognition ds = load_dataset("timit_asr", split=...
closed
2021-06-22T12:45:02
https://api.github.com/repos/huggingface/datasets/issues/2533/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2533", "html_url": "https://github.com/huggingface/datasets/pull/2533", "diff_url": "https://github.com/huggingface/datasets/pull/2533.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2533.patch", "merged_at": "2021-06-23T15:56...
true
Add task template for automatic speech recognition This PR adds a task template for automatic speech recognition. In this task, the input is a path to an audio file which the model consumes to produce a transcription. Usage: ```python from datasets import load_dataset from datasets.tasks import AutomaticSpeechR...
[ "@SBrandeis @lhoestq i've integrated your suggestions, so this is ready for another review :)", "Merging if it's good for you @lewtun :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2532
2,532
Tokenizer's normalization preprocessor cause misalignment in return_offsets_mapping for tokenizer classification task
[This colab notebook](https://colab.research.google.com/drive/151gKyo0YIwnlznrOHst23oYH_a3mAe3Z?usp=sharing) implements a token classification input pipeline extending the logic from [this hugging example](https://huggingface.co/transformers/custom_datasets.html#tok-ner). The pipeline works fine with most instance i...
closed
2021-06-22T10:08:18
https://api.github.com/repos/huggingface/datasets/issues/2532/comments
null
false
Tokenizer's normalization preprocessor cause misalignment in return_offsets_mapping for tokenizer classification task [This colab notebook](https://colab.research.google.com/drive/151gKyo0YIwnlznrOHst23oYH_a3mAe3Z?usp=sharing) implements a token classification input pipeline extending the logic from [this hugging examp...
[ "Hi @jerryIsHere, thanks for reporting the issue. But are you sure this is a bug in HuggingFace **Datasets**?", "> Hi @jerryIsHere, thanks for reporting the issue. But are you sure this is a bug in HuggingFace **Datasets**?\r\n\r\nOh, I am sorry\r\nI would reopen the post on huggingface/transformers" ]
https://api.github.com/repos/huggingface/datasets/issues/2531
2,531
Fix dev version
The dev version that ends in `.dev0` should be greater than the current version. However it happens that `1.8.0 > 1.8.0.dev0` for example. Therefore we need to use `1.8.1.dev0` for example in this case. I updated the dev version to use `1.8.1.dev0`, and I also added a comment in the setup.py in the release steps a...
closed
2021-06-22T09:17:10
https://api.github.com/repos/huggingface/datasets/issues/2531/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2531", "html_url": "https://github.com/huggingface/datasets/pull/2531", "diff_url": "https://github.com/huggingface/datasets/pull/2531.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2531.patch", "merged_at": "2021-06-22T09:47...
true
Fix dev version The dev version that ends in `.dev0` should be greater than the current version. However it happens that `1.8.0 > 1.8.0.dev0` for example. Therefore we need to use `1.8.1.dev0` for example in this case. I updated the dev version to use `1.8.1.dev0`, and I also added a comment in the setup.py in the...
[]
https://api.github.com/repos/huggingface/datasets/issues/2530
2,530
Fixed label parsing in the ProductReviews dataset
Fixed issue with parsing dataset labels.
closed
2021-06-22T09:12:45
https://api.github.com/repos/huggingface/datasets/issues/2530/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2530", "html_url": "https://github.com/huggingface/datasets/pull/2530", "diff_url": "https://github.com/huggingface/datasets/pull/2530.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2530.patch", "merged_at": "2021-06-22T12:52...
true
Fixed label parsing in the ProductReviews dataset Fixed issue with parsing dataset labels.
[ "@lhoestq, can you please review this PR?\r\nWhat exactly is the problem in the test case? Should it matter?", "Hi ! Thanks for fixing this :)\r\n\r\nThe CI fails for two reasons:\r\n- the `pretty_name` tag is missing in yaml tags in ./datasets/turkish_product_reviews/README.md. You can fix that by adding this in...
https://api.github.com/repos/huggingface/datasets/issues/2529
2,529
Add summarization template
This PR adds a task template for text summarization. As far as I can tell, we do not need to distinguish between "extractive" or "abstractive" summarization - both can be handled with this template. Usage: ```python from datasets import load_dataset from datasets.tasks import Summarization ds = load_dataset(...
closed
2021-06-21T16:08:31
https://api.github.com/repos/huggingface/datasets/issues/2529/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2529", "html_url": "https://github.com/huggingface/datasets/pull/2529", "diff_url": "https://github.com/huggingface/datasets/pull/2529.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2529.patch", "merged_at": "2021-06-23T13:30...
true
Add summarization template This PR adds a task template for text summarization. As far as I can tell, we do not need to distinguish between "extractive" or "abstractive" summarization - both can be handled with this template. Usage: ```python from datasets import load_dataset from datasets.tasks import Summariz...
[ "> Nice thanks !\r\n> Could you just move the test outside of the BaseDatasetTest class please ? Otherwise it will unnecessarily be run twice.\r\n\r\nsure, on it! thanks for the explanations about the `self._to` method :)", "@lhoestq i've moved all the task template tests outside of `BaseDatasetTest` and collecte...
https://api.github.com/repos/huggingface/datasets/issues/2528
2,528
Logging cannot be set to NOTSET similar to transformers
## Describe the bug In the transformers library you can set the verbosity level to logging.NOTSET to work around the usage of tqdm and IPywidgets, however in Datasets this is no longer possible. This is because transformers set the verbosity level of tqdm with [this](https://github.com/huggingface/transformers/blob/b5...
closed
2021-06-21T15:04:54
https://api.github.com/repos/huggingface/datasets/issues/2528/comments
null
false
Logging cannot be set to NOTSET similar to transformers ## Describe the bug In the transformers library you can set the verbosity level to logging.NOTSET to work around the usage of tqdm and IPywidgets, however in Datasets this is no longer possible. This is because transformers set the verbosity level of tqdm with [t...
[ "Hi @joshzwiebel, thanks for reporting. We are going to align with `transformers`." ]
https://api.github.com/repos/huggingface/datasets/issues/2527
2,527
Replace bad `n>1M` size tag
Some datasets were still using the old `n>1M` tag which has been replaced with tags `1M<n<10M`, etc. This resulted in unexpected results when searching for datasets bigger than 1M on the hub, since it was only showing the ones with the tag `n>1M`.
closed
2021-06-21T09:42:35
https://api.github.com/repos/huggingface/datasets/issues/2527/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2527", "html_url": "https://github.com/huggingface/datasets/pull/2527", "diff_url": "https://github.com/huggingface/datasets/pull/2527.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2527.patch", "merged_at": "2021-06-21T15:06...
true
Replace bad `n>1M` size tag Some datasets were still using the old `n>1M` tag which has been replaced with tags `1M<n<10M`, etc. This resulted in unexpected results when searching for datasets bigger than 1M on the hub, since it was only showing the ones with the tag `n>1M`.
[]
https://api.github.com/repos/huggingface/datasets/issues/2526
2,526
Add COCO datasets
## Adding a Dataset - **Name:** COCO - **Description:** COCO is a large-scale object detection, segmentation, and captioning dataset. - **Paper + website:** https://cocodataset.org/#home - **Data:** https://cocodataset.org/#download - **Motivation:** It would be great to have COCO available in HuggingFace datasets...
open
2021-06-21T07:48:32
https://api.github.com/repos/huggingface/datasets/issues/2526/comments
null
false
Add COCO datasets ## Adding a Dataset - **Name:** COCO - **Description:** COCO is a large-scale object detection, segmentation, and captioning dataset. - **Paper + website:** https://cocodataset.org/#home - **Data:** https://cocodataset.org/#download - **Motivation:** It would be great to have COCO available in Hu...
[ "I'm currently adding it, the entire dataset is quite big around 30 GB so I add splits separately. You can take a look here https://huggingface.co/datasets/merve/coco", "I talked to @lhoestq and it's best if I download this dataset through TensorFlow datasets instead, so I'll be implementing that one really soon....
https://api.github.com/repos/huggingface/datasets/issues/2525
2,525
Use scikit-learn package rather than sklearn in setup.py
The sklearn package is an historical thing and should probably not be used by anyone, see https://github.com/scikit-learn/scikit-learn/issues/8215#issuecomment-344679114 for some caveats. Note: this affects only TESTS_REQUIRE so I guess only developers not end users.
closed
2021-06-21T07:04:25
https://api.github.com/repos/huggingface/datasets/issues/2525/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2525", "html_url": "https://github.com/huggingface/datasets/pull/2525", "diff_url": "https://github.com/huggingface/datasets/pull/2525.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2525.patch", "merged_at": "2021-06-21T08:57...
true
Use scikit-learn package rather than sklearn in setup.py The sklearn package is an historical thing and should probably not be used by anyone, see https://github.com/scikit-learn/scikit-learn/issues/8215#issuecomment-344679114 for some caveats. Note: this affects only TESTS_REQUIRE so I guess only developers not end...
[]
https://api.github.com/repos/huggingface/datasets/issues/2524
2,524
Raise FileNotFoundError in WindowsFileLock
Closes #2443
closed
2021-06-20T14:25:11
https://api.github.com/repos/huggingface/datasets/issues/2524/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2524", "html_url": "https://github.com/huggingface/datasets/pull/2524", "diff_url": "https://github.com/huggingface/datasets/pull/2524.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2524.patch", "merged_at": "2021-06-28T08:47...
true
Raise FileNotFoundError in WindowsFileLock Closes #2443
[ "Hi ! Could you clarify what it fixes exactly and give more details please ? Especially why this is related to the windows hanging error ?", "This has already been merged, but I'll clarify the idea of this PR. Before this merge, FileLock was the only component affected by the max path limit on Windows (that came ...
https://api.github.com/repos/huggingface/datasets/issues/2523
2,523
Fr
__Originally posted by @lewtun in https://github.com/huggingface/datasets/pull/2469__
closed
2021-06-19T15:56:32
https://api.github.com/repos/huggingface/datasets/issues/2523/comments
null
false
Fr __Originally posted by @lewtun in https://github.com/huggingface/datasets/pull/2469__
[]
https://api.github.com/repos/huggingface/datasets/issues/2522
2,522
Documentation Mistakes in Dataset: emotion
As per documentation, Dataset: emotion Homepage: https://github.com/dair-ai/emotion_dataset Dataset: https://github.com/huggingface/datasets/blob/master/datasets/emotion/emotion.py Permalink: https://huggingface.co/datasets/viewer/?dataset=emotion Emotion is a dataset of English Twitter messages with eight b...
closed
2021-06-19T07:08:57
https://api.github.com/repos/huggingface/datasets/issues/2522/comments
null
false
Documentation Mistakes in Dataset: emotion As per documentation, Dataset: emotion Homepage: https://github.com/dair-ai/emotion_dataset Dataset: https://github.com/huggingface/datasets/blob/master/datasets/emotion/emotion.py Permalink: https://huggingface.co/datasets/viewer/?dataset=emotion Emotion is a datas...
[ "Hi,\r\n\r\nthis issue has been already reported in the dataset repo (https://github.com/dair-ai/emotion_dataset/issues/2), so this is a bug on their side.", "The documentation has another bug in the dataset card [here](https://huggingface.co/datasets/emotion). \r\n\r\nIn the dataset summary **six** emotions are ...
https://api.github.com/repos/huggingface/datasets/issues/2521
2,521
Insert text classification template for Emotion dataset
This PR includes a template and updated `dataset_infos.json` for the `emotion` dataset.
closed
2021-06-18T15:56:19
https://api.github.com/repos/huggingface/datasets/issues/2521/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2521", "html_url": "https://github.com/huggingface/datasets/pull/2521", "diff_url": "https://github.com/huggingface/datasets/pull/2521.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2521.patch", "merged_at": "2021-06-21T09:22...
true
Insert text classification template for Emotion dataset This PR includes a template and updated `dataset_infos.json` for the `emotion` dataset.
[]
https://api.github.com/repos/huggingface/datasets/issues/2520
2,520
Datasets with tricky task templates
I'm collecting a list of datasets here that don't follow the "standard" taxonomy and require further investigation to implement task templates for. ## Text classification * [hatexplain](https://huggingface.co/datasets/hatexplain): ostensibly a form of text classification, but not in the standard `(text, target)` ...
closed
2021-06-18T15:33:57
https://api.github.com/repos/huggingface/datasets/issues/2520/comments
null
false
Datasets with tricky task templates I'm collecting a list of datasets here that don't follow the "standard" taxonomy and require further investigation to implement task templates for. ## Text classification * [hatexplain](https://huggingface.co/datasets/hatexplain): ostensibly a form of text classification, but n...
[ "The `task_templates` API is deprecated in favor of the `train-eval-index` YAML field, so I'm closing this issue." ]
https://api.github.com/repos/huggingface/datasets/issues/2519
2,519
Improve performance of pandas arrow extractor
While reviewing PR #2505, I noticed that pandas arrow extractor could be refactored to be faster.
closed
2021-06-18T13:24:41
https://api.github.com/repos/huggingface/datasets/issues/2519/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2519", "html_url": "https://github.com/huggingface/datasets/pull/2519", "diff_url": "https://github.com/huggingface/datasets/pull/2519.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2519.patch", "merged_at": "2021-06-21T09:06...
true
Improve performance of pandas arrow extractor While reviewing PR #2505, I noticed that pandas arrow extractor could be refactored to be faster.
[ "Looks like this change\r\n```\r\npa_table[pa_table.column_names[0]].to_pandas(types_mapper=pandas_types_mapper)\r\n```\r\ndoesn't return a Series with the correct type.\r\nThis is related to https://issues.apache.org/jira/browse/ARROW-9664\r\n\r\nSince the types_mapper isn't taken into account, the ArrayXD types a...
https://api.github.com/repos/huggingface/datasets/issues/2518
2,518
Add task templates for tydiqa and xquad
This PR adds question-answering templates to the remaining datasets that are linked to a model on the Hub. Notes: * I could not test the tydiqa implementation since I don't have enough disk space 😢 . But I am confident the template works :) * there exist other datasets like `fquad` and `mlqa` which are candida...
closed
2021-06-18T08:06:34
https://api.github.com/repos/huggingface/datasets/issues/2518/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2518", "html_url": "https://github.com/huggingface/datasets/pull/2518", "diff_url": "https://github.com/huggingface/datasets/pull/2518.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2518.patch", "merged_at": "2021-06-18T14:50...
true
Add task templates for tydiqa and xquad This PR adds question-answering templates to the remaining datasets that are linked to a model on the Hub. Notes: * I could not test the tydiqa implementation since I don't have enough disk space 😢 . But I am confident the template works :) * there exist other datasets l...
[ "Just tested TydiQA and it works fine :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2517
2,517
Fix typo in MatthewsCorrelation class name
Close #2513.
closed
2021-06-18T07:53:06
https://api.github.com/repos/huggingface/datasets/issues/2517/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2517", "html_url": "https://github.com/huggingface/datasets/pull/2517", "diff_url": "https://github.com/huggingface/datasets/pull/2517.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2517.patch", "merged_at": "2021-06-18T08:43...
true
Fix typo in MatthewsCorrelation class name Close #2513.
[]
https://api.github.com/repos/huggingface/datasets/issues/2516
2,516
datasets.map pickle issue resulting in invalid mapping function
I trained my own tokenizer, and I needed to use a python custom class. Because of this I have to detach the custom step before saving and reattach after restore. I did this using the standard pickle `__get_state__` / `__set_state__` mechanism. I think it's correct but it fails when I use it inside a function which is m...
open
2021-06-18T06:47:26
https://api.github.com/repos/huggingface/datasets/issues/2516/comments
null
false
datasets.map pickle issue resulting in invalid mapping function I trained my own tokenizer, and I needed to use a python custom class. Because of this I have to detach the custom step before saving and reattach after restore. I did this using the standard pickle `__get_state__` / `__set_state__` mechanism. I think it's...
[ "Hi ! `map` calls `__getstate__` using `dill` to hash your map function. This is used by the caching mechanism to recover previously computed results. That's why you don't see any `__setstate__` call.\r\n\r\nWhy do you change an attribute of your tokenizer when `__getstate__` is called ?", "@lhoestq because if I ...
https://api.github.com/repos/huggingface/datasets/issues/2515
2,515
CRD3 dataset card
This PR adds additional information to the CRD3 dataset card.
closed
2021-06-18T00:24:07
https://api.github.com/repos/huggingface/datasets/issues/2515/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2515", "html_url": "https://github.com/huggingface/datasets/pull/2515", "diff_url": "https://github.com/huggingface/datasets/pull/2515.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2515.patch", "merged_at": "2021-06-21T10:18...
true
CRD3 dataset card This PR adds additional information to the CRD3 dataset card.
[]
https://api.github.com/repos/huggingface/datasets/issues/2514
2,514
Can datasets remove duplicated rows?
**Is your feature request related to a problem? Please describe.** i find myself more and more relying on datasets just to do all the preprocessing. One thing however, for removing duplicated rows, I couldn't find out how and am always converting datasets to pandas to do that.. **Describe the solution you'd like*...
open
2021-06-17T23:35:38
https://api.github.com/repos/huggingface/datasets/issues/2514/comments
null
false
Can datasets remove duplicated rows? **Is your feature request related to a problem? Please describe.** i find myself more and more relying on datasets just to do all the preprocessing. One thing however, for removing duplicated rows, I couldn't find out how and am always converting datasets to pandas to do that.. ...
[ "Hi ! For now this is probably the best option.\r\nWe might add a feature like this in the feature as well.\r\n\r\nDo you know any deduplication method that works on arbitrary big datasets without filling up RAM ?\r\nOtherwise we can have do the deduplication in memory like pandas but I feel like this is going to b...
https://api.github.com/repos/huggingface/datasets/issues/2513
2,513
Corelation should be Correlation
https://github.com/huggingface/datasets/blob/0e87e1d053220e8ecddfa679bcd89a4c7bc5af62/metrics/matthews_correlation/matthews_correlation.py#L66
closed
2021-06-17T17:28:48
https://api.github.com/repos/huggingface/datasets/issues/2513/comments
null
false
Corelation should be Correlation https://github.com/huggingface/datasets/blob/0e87e1d053220e8ecddfa679bcd89a4c7bc5af62/metrics/matthews_correlation/matthews_correlation.py#L66
[ "Hi @colbym-MM, thanks for reporting. We are fixing it." ]
https://api.github.com/repos/huggingface/datasets/issues/2512
2,512
seqeval metric does not work with a recent version of sklearn: classification_report() got an unexpected keyword argument 'output_dict'
## Describe the bug A clear and concise description of what the bug is. ## Steps to reproduce the bug ```python from datasets import load_dataset, load_metric seqeval = load_metric("seqeval") seqeval.compute(predictions=[['A']], references=[['A']]) ``` ## Expected results The function computes a dict with ...
closed
2021-06-17T15:36:02
https://api.github.com/repos/huggingface/datasets/issues/2512/comments
null
false
seqeval metric does not work with a recent version of sklearn: classification_report() got an unexpected keyword argument 'output_dict' ## Describe the bug A clear and concise description of what the bug is. ## Steps to reproduce the bug ```python from datasets import load_dataset, load_metric seqeval = load_met...
[ "Sorry, I was using an old version of sequeval" ]
https://api.github.com/repos/huggingface/datasets/issues/2511
2,511
Add C4
## Adding a Dataset - **Name:** *C4* - **Description:** *https://github.com/allenai/allennlp/discussions/5056* - **Paper:** *https://arxiv.org/abs/1910.10683* - **Data:** *https://huggingface.co/datasets/allenai/c4* - **Motivation:** *Used a lot for pretraining* Instructions to add a new dataset can be found [h...
closed
2021-06-17T10:31:04
https://api.github.com/repos/huggingface/datasets/issues/2511/comments
null
false
Add C4 ## Adding a Dataset - **Name:** *C4* - **Description:** *https://github.com/allenai/allennlp/discussions/5056* - **Paper:** *https://arxiv.org/abs/1910.10683* - **Data:** *https://huggingface.co/datasets/allenai/c4* - **Motivation:** *Used a lot for pretraining* Instructions to add a new dataset can be f...
[ "Update on this: I'm computing the checksums of the data files. It will be available soon", "Added in #2575 :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2510
2,510
Add align_labels_with_mapping to DatasetDict
https://github.com/huggingface/datasets/pull/2457 added the `Dataset.align_labels_with_mapping` method. In this PR I also added `DatasetDict.align_labels_with_mapping`
closed
2021-06-17T10:03:35
https://api.github.com/repos/huggingface/datasets/issues/2510/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2510", "html_url": "https://github.com/huggingface/datasets/pull/2510", "diff_url": "https://github.com/huggingface/datasets/pull/2510.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2510.patch", "merged_at": "2021-06-17T10:45...
true
Add align_labels_with_mapping to DatasetDict https://github.com/huggingface/datasets/pull/2457 added the `Dataset.align_labels_with_mapping` method. In this PR I also added `DatasetDict.align_labels_with_mapping`
[]
https://api.github.com/repos/huggingface/datasets/issues/2509
2,509
Fix fingerprint when moving cache dir
The fingerprint of a dataset changes if the cache directory is moved. I fixed that by setting the fingerprint to be the hash of: - the relative cache dir (dataset_name/version/config_id) - the requested split Close #2496 I had to fix an issue with the filelock filename that was too long (>255). It prevented t...
closed
2021-06-16T16:45:09
https://api.github.com/repos/huggingface/datasets/issues/2509/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2509", "html_url": "https://github.com/huggingface/datasets/pull/2509", "diff_url": "https://github.com/huggingface/datasets/pull/2509.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2509.patch", "merged_at": "2021-06-21T15:05...
true
Fix fingerprint when moving cache dir The fingerprint of a dataset changes if the cache directory is moved. I fixed that by setting the fingerprint to be the hash of: - the relative cache dir (dataset_name/version/config_id) - the requested split Close #2496 I had to fix an issue with the filelock filename th...
[ "Windows, why are you doing this to me ?", "Thanks @lhoestq, I'm starting reviewing this PR.", "Yea issues on windows are about long paths, not long filenames.\r\nWe can make sure the lock filenames are not too long, but not for the paths", "Took your suggestions into account @albertvillanova :)" ]
https://api.github.com/repos/huggingface/datasets/issues/2508
2,508
Load Image Classification Dataset from Local
**Is your feature request related to a problem? Please describe.** Yes - we would like to load an image classification dataset with datasets without having to write a custom data loader. **Describe the solution you'd like** Given a folder structure with images of each class in each folder, the ability to load th...
closed
2021-06-15T22:43:33
https://api.github.com/repos/huggingface/datasets/issues/2508/comments
null
false
Load Image Classification Dataset from Local **Is your feature request related to a problem? Please describe.** Yes - we would like to load an image classification dataset with datasets without having to write a custom data loader. **Describe the solution you'd like** Given a folder structure with images of eac...
[ "Hi ! Is this folder structure a standard, a bit like imagenet ?\r\nIn this case maybe we can consider having a dataset loader for cifar-like, imagenet-like, squad-like, conll-like etc. datasets ?\r\n```python\r\nfrom datasets import load_dataset\r\n\r\nmy_custom_cifar = load_dataset(\"cifar_like\", data_dir=\"path...
https://api.github.com/repos/huggingface/datasets/issues/2507
2,507
Rearrange JSON field names to match passed features schema field names
This PR depends on PR #2453 (which must be merged first). Close #2366.
closed
2021-06-15T14:10:02
https://api.github.com/repos/huggingface/datasets/issues/2507/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2507", "html_url": "https://github.com/huggingface/datasets/pull/2507", "diff_url": "https://github.com/huggingface/datasets/pull/2507.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2507.patch", "merged_at": "2021-06-16T10:47...
true
Rearrange JSON field names to match passed features schema field names This PR depends on PR #2453 (which must be merged first). Close #2366.
[]
https://api.github.com/repos/huggingface/datasets/issues/2506
2,506
Add course banner
This PR adds a course banner similar to the one you can now see in the [Transformers repo](https://github.com/huggingface/transformers) that links to the course. Let me know if placement seems right to you or not, I can move it just below the badges too.
closed
2021-06-15T14:03:54
https://api.github.com/repos/huggingface/datasets/issues/2506/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2506", "html_url": "https://github.com/huggingface/datasets/pull/2506", "diff_url": "https://github.com/huggingface/datasets/pull/2506.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2506.patch", "merged_at": "2021-06-15T16:25...
true
Add course banner This PR adds a course banner similar to the one you can now see in the [Transformers repo](https://github.com/huggingface/transformers) that links to the course. Let me know if placement seems right to you or not, I can move it just below the badges too.
[]
https://api.github.com/repos/huggingface/datasets/issues/2505
2,505
Make numpy arrow extractor faster
I changed the NumpyArrowExtractor to call directly to_numpy and see if it can lead to speed-ups as discussed in https://github.com/huggingface/datasets/issues/2498 This could make the numpy/torch/tf/jax formatting faster
closed
2021-06-15T10:11:32
https://api.github.com/repos/huggingface/datasets/issues/2505/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2505", "html_url": "https://github.com/huggingface/datasets/pull/2505", "diff_url": "https://github.com/huggingface/datasets/pull/2505.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2505.patch", "merged_at": "2021-06-28T09:53...
true
Make numpy arrow extractor faster I changed the NumpyArrowExtractor to call directly to_numpy and see if it can lead to speed-ups as discussed in https://github.com/huggingface/datasets/issues/2498 This could make the numpy/torch/tf/jax formatting faster
[ "Looks like we have a nice speed up in some benchmarks. For example:\r\n- `read_formatted numpy 5000`: 4.584777 sec -> 0.487113 sec\r\n- `read_formatted torch 5000`: 4.565676 sec -> 1.289514 sec", "Can we convert this draft to PR @lhoestq ?", "Ready for review ! cc @vblagoje", "@lhoestq I tried the branch a...
https://api.github.com/repos/huggingface/datasets/issues/2503
2,503
SubjQA wrong boolean values in entries
## Describe the bug SubjQA seems to have a boolean that's consistently wrong. It defines: - question_subj_level: The subjectiviy level of the question (on a 1 to 5 scale with 1 being the most subjective). - is_ques_subjective: A boolean subjectivity label derived from question_subj_level (i.e., scores below 4 are...
open
2021-06-14T17:42:46
https://api.github.com/repos/huggingface/datasets/issues/2503/comments
null
false
SubjQA wrong boolean values in entries ## Describe the bug SubjQA seems to have a boolean that's consistently wrong. It defines: - question_subj_level: The subjectiviy level of the question (on a 1 to 5 scale with 1 being the most subjective). - is_ques_subjective: A boolean subjectivity label derived from questi...
[ "Hi @arnaudstiegler, thanks for reporting. I'm investigating it.", "@arnaudstiegler I have just checked that these mismatches are already present in the original dataset: https://github.com/megagonlabs/SubjQA\r\n\r\nWe are going to contact the dataset owners to report this.", "I have:\r\n- opened an issue in th...
https://api.github.com/repos/huggingface/datasets/issues/2502
2,502
JAX integration
Hi ! I just added the "jax" formatting, as we already have for pytorch, tensorflow, numpy (and also pandas and arrow). It does pretty much the same thing as the pytorch formatter except it creates jax.numpy.ndarray objects. ```python from datasets import Dataset d = Dataset.from_dict({"foo": [[0., 1., 2.]]})...
closed
2021-06-14T17:24:23
https://api.github.com/repos/huggingface/datasets/issues/2502/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2502", "html_url": "https://github.com/huggingface/datasets/pull/2502", "diff_url": "https://github.com/huggingface/datasets/pull/2502.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2502.patch", "merged_at": "2021-06-21T16:15...
true
JAX integration Hi ! I just added the "jax" formatting, as we already have for pytorch, tensorflow, numpy (and also pandas and arrow). It does pretty much the same thing as the pytorch formatter except it creates jax.numpy.ndarray objects. ```python from datasets import Dataset d = Dataset.from_dict({"foo": ...
[]
https://api.github.com/repos/huggingface/datasets/issues/2501
2,501
Add Zenodo metadata file with license
This Zenodo metadata file fixes the name of the `Datasets` license appearing in the DOI as `"Apache-2.0"`, which otherwise by default is `"other-open"`. Close #2472.
closed
2021-06-14T16:28:12
https://api.github.com/repos/huggingface/datasets/issues/2501/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2501", "html_url": "https://github.com/huggingface/datasets/pull/2501", "diff_url": "https://github.com/huggingface/datasets/pull/2501.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2501.patch", "merged_at": "2021-06-14T16:49...
true
Add Zenodo metadata file with license This Zenodo metadata file fixes the name of the `Datasets` license appearing in the DOI as `"Apache-2.0"`, which otherwise by default is `"other-open"`. Close #2472.
[]
https://api.github.com/repos/huggingface/datasets/issues/2500
2,500
Add load_dataset_builder
Adds the `load_dataset_builder` function. The good thing is that we can reuse this function to load the dataset info without downloading the dataset itself. TODOs: - [x] Add docstring and entry in the docs - [x] Add tests Closes #2484
closed
2021-06-14T14:27:45
https://api.github.com/repos/huggingface/datasets/issues/2500/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2500", "html_url": "https://github.com/huggingface/datasets/pull/2500", "diff_url": "https://github.com/huggingface/datasets/pull/2500.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2500.patch", "merged_at": "2021-07-05T10:45...
true
Add load_dataset_builder Adds the `load_dataset_builder` function. The good thing is that we can reuse this function to load the dataset info without downloading the dataset itself. TODOs: - [x] Add docstring and entry in the docs - [x] Add tests Closes #2484
[ "Hi @mariosasko, thanks for taking on this issue.\r\n\r\nJust a few logistic suggestions, as you are one of our most active contributors ❤️ :\r\n- When you start working on an issue, you can self-assign it to you by commenting on the issue page with the keyword: `#self-assign`; we have implemented a GitHub Action t...
https://api.github.com/repos/huggingface/datasets/issues/2499
2,499
Python Programming Puzzles
## Adding a Dataset - **Name:** Python Programming Puzzles - **Description:** Programming challenge called programming puzzles, as an objective and comprehensive evaluation of program synthesis - **Paper:** https://arxiv.org/pdf/2106.05784.pdf - **Data:** https://github.com/microsoft/PythonProgrammingPuzzles ([Scro...
open
2021-06-14T13:27:18
https://api.github.com/repos/huggingface/datasets/issues/2499/comments
null
false
Python Programming Puzzles ## Adding a Dataset - **Name:** Python Programming Puzzles - **Description:** Programming challenge called programming puzzles, as an objective and comprehensive evaluation of program synthesis - **Paper:** https://arxiv.org/pdf/2106.05784.pdf - **Data:** https://github.com/microsoft/Pyt...
[ "👀 @TalSchuster", "Thanks @VictorSanh!\r\nThere's also a [notebook](https://aka.ms/python_puzzles) and [demo](https://aka.ms/python_puzzles_study) available now to try out some of the puzzles" ]
https://api.github.com/repos/huggingface/datasets/issues/2498
2,498
Improve torch formatting performance
**Is your feature request related to a problem? Please describe.** It would be great, if possible, to further improve read performance of raw encoded datasets and their subsequent conversion to torch tensors. A bit more background. I am working on LM pre-training using HF ecosystem. We use encoded HF Wikipedia an...
open
2021-06-14T13:25:24
https://api.github.com/repos/huggingface/datasets/issues/2498/comments
null
false
Improve torch formatting performance **Is your feature request related to a problem? Please describe.** It would be great, if possible, to further improve read performance of raw encoded datasets and their subsequent conversion to torch tensors. A bit more background. I am working on LM pre-training using HF ecos...
[ "That’s interesting thanks, let’s see what we can do. Can you detail your last sentence? I’m not sure I understand it well.", "Hi ! I just re-ran a quick benchmark and using `to_numpy()` seems to be faster now:\r\n\r\n```python\r\nimport pyarrow as pa # I used pyarrow 3.0.0\r\nimport numpy as np\r\n\r\nn, max_le...
https://api.github.com/repos/huggingface/datasets/issues/2497
2,497
Use default cast for sliced list arrays if pyarrow >= 4
From pyarrow version 4, it is supported to cast sliced lists. This PR uses default pyarrow cast in Datasets to cast sliced list arrays if pyarrow version is >= 4. In relation with PR #2461 and #2490. cc: @lhoestq, @abhi1thakur, @SBrandeis
closed
2021-06-14T10:02:47
https://api.github.com/repos/huggingface/datasets/issues/2497/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2497", "html_url": "https://github.com/huggingface/datasets/pull/2497", "diff_url": "https://github.com/huggingface/datasets/pull/2497.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2497.patch", "merged_at": "2021-06-14T14:24...
true
Use default cast for sliced list arrays if pyarrow >= 4 From pyarrow version 4, it is supported to cast sliced lists. This PR uses default pyarrow cast in Datasets to cast sliced list arrays if pyarrow version is >= 4. In relation with PR #2461 and #2490. cc: @lhoestq, @abhi1thakur, @SBrandeis
[ "I believe we don't use PyArrow >= 4.0.0 because of some segfault issues:\r\nhttps://github.com/huggingface/datasets/blob/1206ffbcd42dda415f6bfb3d5040708f50413c93/setup.py#L78\r\nCan you confirm @lhoestq ?", "@SBrandeis pyarrow version 4.0.1 has fixed that issue: #2489 😉 " ]
https://api.github.com/repos/huggingface/datasets/issues/2496
2,496
Dataset fingerprint changes after moving the cache directory, which prevent cache reload when using `map`
`Dataset.map` uses the dataset fingerprint (a hash) for caching. However the fingerprint seems to change when someone moves the cache directory of the dataset. This is because it uses the default fingerprint generation: 1. the dataset path is used to get the fingerprint 2. the modification times of the arrow file...
closed
2021-06-14T09:20:26
https://api.github.com/repos/huggingface/datasets/issues/2496/comments
null
false
Dataset fingerprint changes after moving the cache directory, which prevent cache reload when using `map` `Dataset.map` uses the dataset fingerprint (a hash) for caching. However the fingerprint seems to change when someone moves the cache directory of the dataset. This is because it uses the default fingerprint ge...
[]
https://api.github.com/repos/huggingface/datasets/issues/2495
2,495
JAX formatting
We already support pytorch, tensorflow, numpy, pandas and arrow dataset formatting. Let's add jax as well
closed
2021-06-14T08:32:07
https://api.github.com/repos/huggingface/datasets/issues/2495/comments
null
false
JAX formatting We already support pytorch, tensorflow, numpy, pandas and arrow dataset formatting. Let's add jax as well
[]
https://api.github.com/repos/huggingface/datasets/issues/2494
2,494
Improve docs on Enhancing performance
In the ["Enhancing performance"](https://huggingface.co/docs/datasets/loading_datasets.html#enhancing-performance) section of docs, add specific use cases: - How to make datasets the fastest - How to make datasets take the less RAM - How to make datasets take the less hard drive mem cc: @thomwolf
open
2021-06-14T08:11:48
https://api.github.com/repos/huggingface/datasets/issues/2494/comments
null
false
Improve docs on Enhancing performance In the ["Enhancing performance"](https://huggingface.co/docs/datasets/loading_datasets.html#enhancing-performance) section of docs, add specific use cases: - How to make datasets the fastest - How to make datasets take the less RAM - How to make datasets take the less hard drive...
[ "Hi @albertvillanova, I hope you are doing well.\r\n\r\nI am interested in this issue, is this still unresolved and open ?\r\n\r\nThe link you have provided in the above message directs to a webpage that does not exist.\r\n\r\nThanks and Regards", "#self-assign" ]
https://api.github.com/repos/huggingface/datasets/issues/2493
2,493
add tensorflow-macos support
ref - https://github.com/huggingface/datasets/issues/2068
closed
2021-06-13T16:20:08
https://api.github.com/repos/huggingface/datasets/issues/2493/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2493", "html_url": "https://github.com/huggingface/datasets/pull/2493", "diff_url": "https://github.com/huggingface/datasets/pull/2493.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2493.patch", "merged_at": "2021-06-15T08:53...
true
add tensorflow-macos support ref - https://github.com/huggingface/datasets/issues/2068
[ "@albertvillanova done!" ]
https://api.github.com/repos/huggingface/datasets/issues/2492
2,492
Eduge
Hi, awesome folks behind the huggingface! Here is my PR for the text classification dataset in Mongolian. Please do let me know in case you have anything to clarify. Thanks & Regards, Enod
closed
2021-06-13T05:10:59
https://api.github.com/repos/huggingface/datasets/issues/2492/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2492", "html_url": "https://github.com/huggingface/datasets/pull/2492", "diff_url": "https://github.com/huggingface/datasets/pull/2492.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2492.patch", "merged_at": "2021-06-16T10:41...
true
Eduge Hi, awesome folks behind the huggingface! Here is my PR for the text classification dataset in Mongolian. Please do let me know in case you have anything to clarify. Thanks & Regards, Enod
[]
https://api.github.com/repos/huggingface/datasets/issues/2491
2,491
add eduge classification dataset
closed
2021-06-13T04:37:01
https://api.github.com/repos/huggingface/datasets/issues/2491/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2491", "html_url": "https://github.com/huggingface/datasets/pull/2491", "diff_url": "https://github.com/huggingface/datasets/pull/2491.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2491.patch", "merged_at": null }
true
add eduge classification dataset
[ "Closing this PR as I'll submit a new one - bug free" ]
https://api.github.com/repos/huggingface/datasets/issues/2490
2,490
Allow latest pyarrow version
Allow latest pyarrow version, once that version 4.0.1 fixes the segfault bug introduced in version 4.0.0. Close #2489.
closed
2021-06-12T14:17:34
https://api.github.com/repos/huggingface/datasets/issues/2490/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2490", "html_url": "https://github.com/huggingface/datasets/pull/2490", "diff_url": "https://github.com/huggingface/datasets/pull/2490.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2490.patch", "merged_at": "2021-06-14T07:53...
true
Allow latest pyarrow version Allow latest pyarrow version, once that version 4.0.1 fixes the segfault bug introduced in version 4.0.0. Close #2489.
[ "i need some help with this" ]
https://api.github.com/repos/huggingface/datasets/issues/2489
2,489
Allow latest pyarrow version once segfault bug is fixed
As pointed out by @symeneses (see https://github.com/huggingface/datasets/pull/2268#issuecomment-860048613), pyarrow has fixed the segfault bug present in version 4.0.0 (see https://issues.apache.org/jira/browse/ARROW-12568): - it was fixed on 3 May 2021 - version 4.0.1 was released on 19 May 2021 with the bug fix
closed
2021-06-12T14:09:52
https://api.github.com/repos/huggingface/datasets/issues/2489/comments
null
false
Allow latest pyarrow version once segfault bug is fixed As pointed out by @symeneses (see https://github.com/huggingface/datasets/pull/2268#issuecomment-860048613), pyarrow has fixed the segfault bug present in version 4.0.0 (see https://issues.apache.org/jira/browse/ARROW-12568): - it was fixed on 3 May 2021 - versi...
[]
https://api.github.com/repos/huggingface/datasets/issues/2488
2,488
Set configurable downloaded datasets path
Part of #2480.
closed
2021-06-12T09:09:03
https://api.github.com/repos/huggingface/datasets/issues/2488/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2488", "html_url": "https://github.com/huggingface/datasets/pull/2488", "diff_url": "https://github.com/huggingface/datasets/pull/2488.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2488.patch", "merged_at": "2021-06-14T08:29...
true
Set configurable downloaded datasets path Part of #2480.
[]
https://api.github.com/repos/huggingface/datasets/issues/2487
2,487
Set configurable extracted datasets path
Part of #2480.
closed
2021-06-12T05:47:29
https://api.github.com/repos/huggingface/datasets/issues/2487/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2487", "html_url": "https://github.com/huggingface/datasets/pull/2487", "diff_url": "https://github.com/huggingface/datasets/pull/2487.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2487.patch", "merged_at": "2021-06-14T09:02...
true
Set configurable extracted datasets path Part of #2480.
[ "Let me push a small fix... 😉 ", "Thanks !" ]
https://api.github.com/repos/huggingface/datasets/issues/2486
2,486
Add Rico Dataset
Hi there! I'm wanting to add the Rico datasets for software engineering type data to y'alls awesome library. However, as I have started coding, I've ran into a few hiccups so I thought it best to open the PR early to get a bit of discussion on how the Rico datasets should be added to the `datasets` lib. 1) There ...
closed
2021-06-11T20:17:41
https://api.github.com/repos/huggingface/datasets/issues/2486/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2486", "html_url": "https://github.com/huggingface/datasets/pull/2486", "diff_url": "https://github.com/huggingface/datasets/pull/2486.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2486.patch", "merged_at": null }
true
Add Rico Dataset Hi there! I'm wanting to add the Rico datasets for software engineering type data to y'alls awesome library. However, as I have started coding, I've ran into a few hiccups so I thought it best to open the PR early to get a bit of discussion on how the Rico datasets should be added to the `datasets` ...
[ "Hi ! Thanks for adding this dataset :)\r\n\r\nRegarding your questions:\r\n1. We can have them as different configuration of the `rico` dataset\r\n2. Yes please use the path to the image and not open the image directly, so that we can let users open the image one at at time during training if they want to for exam...
https://api.github.com/repos/huggingface/datasets/issues/2485
2,485
Implement layered building
As discussed with @stas00 and @lhoestq (see also here https://github.com/huggingface/datasets/issues/2481#issuecomment-859712190): > My suggestion for this would be to have this enabled by default. > > Plus I don't know if there should be a dedicated issue to that is another functionality. But I propose layered b...
open
2021-06-11T18:54:25
https://api.github.com/repos/huggingface/datasets/issues/2485/comments
null
false
Implement layered building As discussed with @stas00 and @lhoestq (see also here https://github.com/huggingface/datasets/issues/2481#issuecomment-859712190): > My suggestion for this would be to have this enabled by default. > > Plus I don't know if there should be a dedicated issue to that is another functionali...
[]
https://api.github.com/repos/huggingface/datasets/issues/2484
2,484
Implement loading a dataset builder
As discussed with @stas00 and @lhoestq, this would allow things like: ```python from datasets import load_dataset_builder dataset_name = "openwebtext" builder = load_dataset_builder(dataset_name) print(builder.cache_dir) ```
closed
2021-06-11T18:47:22
https://api.github.com/repos/huggingface/datasets/issues/2484/comments
null
false
Implement loading a dataset builder As discussed with @stas00 and @lhoestq, this would allow things like: ```python from datasets import load_dataset_builder dataset_name = "openwebtext" builder = load_dataset_builder(dataset_name) print(builder.cache_dir) ```
[ "#self-assign" ]
https://api.github.com/repos/huggingface/datasets/issues/2483
2,483
Use gc.collect only when needed to avoid slow downs
In https://github.com/huggingface/datasets/commit/42320a110d9d072703814e1f630a0d90d626a1e6 we added a call to gc.collect to resolve some issues on windows (see https://github.com/huggingface/datasets/pull/2482) However calling gc.collect too often causes significant slow downs (the CI run time doubled). So I just m...
closed
2021-06-11T15:09:30
https://api.github.com/repos/huggingface/datasets/issues/2483/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2483", "html_url": "https://github.com/huggingface/datasets/pull/2483", "diff_url": "https://github.com/huggingface/datasets/pull/2483.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2483.patch", "merged_at": "2021-06-11T15:31...
true
Use gc.collect only when needed to avoid slow downs In https://github.com/huggingface/datasets/commit/42320a110d9d072703814e1f630a0d90d626a1e6 we added a call to gc.collect to resolve some issues on windows (see https://github.com/huggingface/datasets/pull/2482) However calling gc.collect too often causes significan...
[ "I continue thinking that the origin of the issue has to do with tqdm (and not with Arrow): this issue only arises for version 4.50.0 (and later) of tqdm, not for previous versions of tqdm.\r\n\r\nMy guess is that tqdm made a change from version 4.50.0 that does not properly release the iterable. ", "FR" ]
https://api.github.com/repos/huggingface/datasets/issues/2482
2,482
Allow to use tqdm>=4.50.0
We used to have permission errors on windows whith the latest versions of tqdm (see [here](https://app.circleci.com/pipelines/github/huggingface/datasets/6365/workflows/24f7c960-3176-43a5-9652-7830a23a981e/jobs/39232)) They were due to open arrow files not properly closed by pyarrow. Since https://github.com/huggin...
closed
2021-06-11T14:49:21
https://api.github.com/repos/huggingface/datasets/issues/2482/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2482", "html_url": "https://github.com/huggingface/datasets/pull/2482", "diff_url": "https://github.com/huggingface/datasets/pull/2482.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2482.patch", "merged_at": "2021-06-11T15:11...
true
Allow to use tqdm>=4.50.0 We used to have permission errors on windows whith the latest versions of tqdm (see [here](https://app.circleci.com/pipelines/github/huggingface/datasets/6365/workflows/24f7c960-3176-43a5-9652-7830a23a981e/jobs/39232)) They were due to open arrow files not properly closed by pyarrow. Since...
[]
https://api.github.com/repos/huggingface/datasets/issues/2481
2,481
Delete extracted files to save disk space
As discussed with @stas00 and @lhoestq, allowing the deletion of extracted files would save a great amount of disk space to typical user.
closed
2021-06-11T12:21:52
https://api.github.com/repos/huggingface/datasets/issues/2481/comments
null
false
Delete extracted files to save disk space As discussed with @stas00 and @lhoestq, allowing the deletion of extracted files would save a great amount of disk space to typical user.
[ "My suggestion for this would be to have this enabled by default.\r\n\r\nPlus I don't know if there should be a dedicated issue to that is another functionality. But I propose layered building rather than all at once. That is:\r\n\r\n1. uncompress a handful of files via a generator enough to generate one arrow file...
https://api.github.com/repos/huggingface/datasets/issues/2480
2,480
Set download/extracted paths configurable
As discussed with @stas00 and @lhoestq, setting these paths configurable may allow to overcome disk space limitation on different partitions/drives. TODO: - [x] Set configurable extracted datasets path: #2487 - [x] Set configurable downloaded datasets path: #2488 - [ ] Set configurable "incomplete" datasets path?
open
2021-06-11T12:20:24
https://api.github.com/repos/huggingface/datasets/issues/2480/comments
null
false
Set download/extracted paths configurable As discussed with @stas00 and @lhoestq, setting these paths configurable may allow to overcome disk space limitation on different partitions/drives. TODO: - [x] Set configurable extracted datasets path: #2487 - [x] Set configurable downloaded datasets path: #2488 - [ ] Se...
[ "For example to be able to send uncompressed and temp build files to another volume/partition, so that the user gets the minimal disk usage on their primary setup - and ends up with just the downloaded compressed data + arrow files, but outsourcing the huge files and building to another partition. e.g. on JZ there...
https://api.github.com/repos/huggingface/datasets/issues/2479
2,479
❌ load_datasets ❌
closed
2021-06-11T12:14:36
https://api.github.com/repos/huggingface/datasets/issues/2479/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2479", "html_url": "https://github.com/huggingface/datasets/pull/2479", "diff_url": "https://github.com/huggingface/datasets/pull/2479.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2479.patch", "merged_at": "2021-06-11T14:46...
true
❌ load_datasets ❌
[]
https://api.github.com/repos/huggingface/datasets/issues/2478
2,478
Create release script
Create a script so that releases can be done automatically (as done in `transformers`).
open
2021-06-11T09:38:02
https://api.github.com/repos/huggingface/datasets/issues/2478/comments
null
false
Create release script Create a script so that releases can be done automatically (as done in `transformers`).
[ "I've aligned the release script with Transformers in #6004, so I think this issue can be closed." ]
https://api.github.com/repos/huggingface/datasets/issues/2477
2,477
Fix docs custom stable version
Currently docs default version is 1.5.0. This PR fixes this and sets the latest version instead.
closed
2021-06-11T07:26:03
https://api.github.com/repos/huggingface/datasets/issues/2477/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2477", "html_url": "https://github.com/huggingface/datasets/pull/2477", "diff_url": "https://github.com/huggingface/datasets/pull/2477.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2477.patch", "merged_at": "2021-06-14T08:20...
true
Fix docs custom stable version Currently docs default version is 1.5.0. This PR fixes this and sets the latest version instead.
[ "I see that @lhoestq overlooked this PR with his commit 07e2b05. 😢 \r\n\r\nI'm adding a script so that this issue does not happen again.\r\n", "For the moment, the script only includes `update_custom_js`, but in a follow-up PR I will include all the required steps to make a package release.", "I think we just ...
https://api.github.com/repos/huggingface/datasets/issues/2476
2,476
Add TimeDial
Dataset: https://github.com/google-research-datasets/TimeDial To-Do: Update README.md and add YAML tags
closed
2021-06-10T18:33:07
https://api.github.com/repos/huggingface/datasets/issues/2476/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2476", "html_url": "https://github.com/huggingface/datasets/pull/2476", "diff_url": "https://github.com/huggingface/datasets/pull/2476.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2476.patch", "merged_at": "2021-07-30T12:57...
true
Add TimeDial Dataset: https://github.com/google-research-datasets/TimeDial To-Do: Update README.md and add YAML tags
[ "Hi @lhoestq,\r\nI've pushed the updated README and tags. Let me know if anything is missing/needs some improvement!\r\n\r\n~PS. I don't know why it's not triggering the build~" ]
https://api.github.com/repos/huggingface/datasets/issues/2475
2,475
Issue in timit_asr database
## Describe the bug I am trying to load the timit_asr dataset however only the first record is shown (duplicated over all the rows). I am using the next code line dataset = load_dataset(“timit_asr”, split=“test”).shuffle().select(range(10)) The above code result with the same sentence duplicated ten times. It al...
closed
2021-06-10T18:05:29
https://api.github.com/repos/huggingface/datasets/issues/2475/comments
null
false
Issue in timit_asr database ## Describe the bug I am trying to load the timit_asr dataset however only the first record is shown (duplicated over all the rows). I am using the next code line dataset = load_dataset(“timit_asr”, split=“test”).shuffle().select(range(10)) The above code result with the same sentence ...
[ "This bug was fixed in #1995. Upgrading datasets to version 1.6 fixes the issue!", "Indeed was a fixed bug.\r\nWorks on version 1.8\r\nThanks " ]
https://api.github.com/repos/huggingface/datasets/issues/2474
2,474
cache_dir parameter for load_from_disk ?
**Is your feature request related to a problem? Please describe.** When using Google Colab big datasets can be an issue, as they won't fit on the VM's disk. Therefore mounting google drive could be a possible solution. Unfortunatly when loading my own dataset by using the _load_from_disk_ function, the data gets cache...
closed
2021-06-10T17:39:36
https://api.github.com/repos/huggingface/datasets/issues/2474/comments
null
false
cache_dir parameter for load_from_disk ? **Is your feature request related to a problem? Please describe.** When using Google Colab big datasets can be an issue, as they won't fit on the VM's disk. Therefore mounting google drive could be a possible solution. Unfortunatly when loading my own dataset by using the _load...
[ "Hi ! `load_from_disk` doesn't move the data. If you specify a local path to your mounted drive, then the dataset is going to be loaded directly from the arrow file in this directory. The cache files that result from `map` operations are also stored in the same directory by default.\r\n\r\nHowever note than writing...
https://api.github.com/repos/huggingface/datasets/issues/2473
2,473
Add Disfl-QA
Dataset: https://github.com/google-research-datasets/disfl-qa To-Do: Update README.md and add YAML tags
closed
2021-06-10T16:18:00
https://api.github.com/repos/huggingface/datasets/issues/2473/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2473", "html_url": "https://github.com/huggingface/datasets/pull/2473", "diff_url": "https://github.com/huggingface/datasets/pull/2473.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2473.patch", "merged_at": "2021-07-29T11:56...
true
Add Disfl-QA Dataset: https://github.com/google-research-datasets/disfl-qa To-Do: Update README.md and add YAML tags
[ "Sounds great! It'll make things easier for the user while accessing the dataset. I'll make some changes to the current file then.", "I've updated with the suggested changes. Updated the README, YAML tags as well (not sure of Size category tag as I couldn't pass the path of `dataset_infos.json` for this dataset)\...
https://api.github.com/repos/huggingface/datasets/issues/2472
2,472
Fix automatic generation of Zenodo DOI
After the last release of Datasets (1.8.0), the automatic generation of the Zenodo DOI failed: it appears in yellow as "Received", instead of in green as "Published". I have contacted Zenodo support to fix this issue. TODO: - [x] Check with Zenodo to fix the issue - [x] Check BibTeX entry is right
closed
2021-06-10T15:15:46
https://api.github.com/repos/huggingface/datasets/issues/2472/comments
null
false
Fix automatic generation of Zenodo DOI After the last release of Datasets (1.8.0), the automatic generation of the Zenodo DOI failed: it appears in yellow as "Received", instead of in green as "Published". I have contacted Zenodo support to fix this issue. TODO: - [x] Check with Zenodo to fix the issue - [x] Ch...
[ "I have received a reply from Zenodo support:\r\n> We are currently investigating and fixing this issue related to GitHub releases. As soon as we have solved it we will reach back to you.", "Other repo maintainers had the same problem with Zenodo. \r\n\r\nThere is an open issue on their GitHub repo: zenodo/zenodo...
https://api.github.com/repos/huggingface/datasets/issues/2471
2,471
Fix PermissionError on Windows when using tqdm >=4.50.0
See: https://app.circleci.com/pipelines/github/huggingface/datasets/235/workflows/cfb6a39f-68eb-4802-8b17-2cd5e8ea7369/jobs/1111 ``` PermissionError: [WinError 32] The process cannot access the file because it is being used by another process ```
closed
2021-06-10T08:31:49
https://api.github.com/repos/huggingface/datasets/issues/2471/comments
null
false
Fix PermissionError on Windows when using tqdm >=4.50.0 See: https://app.circleci.com/pipelines/github/huggingface/datasets/235/workflows/cfb6a39f-68eb-4802-8b17-2cd5e8ea7369/jobs/1111 ``` PermissionError: [WinError 32] The process cannot access the file because it is being used by another process ```
[]
https://api.github.com/repos/huggingface/datasets/issues/2470
2,470
Crash when `num_proc` > dataset length for `map()` on a `datasets.Dataset`.
## Describe the bug Crash if when using `num_proc` > 1 (I used 16) for `map()` on a `datasets.Dataset`. I believe I've had cases where `num_proc` > 1 works before, but now it seems either inconsistent, or depends on my data. I'm not sure whether the issue is on my end, because it's difficult for me to debug! Any ti...
closed
2021-06-09T22:40:22
https://api.github.com/repos/huggingface/datasets/issues/2470/comments
null
false
Crash when `num_proc` > dataset length for `map()` on a `datasets.Dataset`. ## Describe the bug Crash if when using `num_proc` > 1 (I used 16) for `map()` on a `datasets.Dataset`. I believe I've had cases where `num_proc` > 1 works before, but now it seems either inconsistent, or depends on my data. I'm not sure wh...
[ "Hi ! It looks like the issue comes from pyarrow. What version of pyarrow are you using ? How did you install it ?", "Thank you for the quick reply! I have `pyarrow==4.0.0`, and I am installing with `pip`. It's not one of my explicit dependencies, so I assume it came along with something else.", "Could you tryi...
https://api.github.com/repos/huggingface/datasets/issues/2469
2,469
Bump tqdm version
closed
2021-06-09T17:24:40
https://api.github.com/repos/huggingface/datasets/issues/2469/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2469", "html_url": "https://github.com/huggingface/datasets/pull/2469", "diff_url": "https://github.com/huggingface/datasets/pull/2469.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2469.patch", "merged_at": null }
true
Bump tqdm version
[ "i tried both the latest version of `tqdm` and the version required by `autonlp` - no luck with windows 😞 \r\n\r\nit's very weird that a progress bar would trigger these kind of errors, so i'll have a look to see if it's something unique to `datasets`", "Closing since this is now fixed in #2482 " ]
https://api.github.com/repos/huggingface/datasets/issues/2468
2,468
Implement ClassLabel encoding in JSON loader
Close #2365.
closed
2021-06-09T17:08:54
https://api.github.com/repos/huggingface/datasets/issues/2468/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2468", "html_url": "https://github.com/huggingface/datasets/pull/2468", "diff_url": "https://github.com/huggingface/datasets/pull/2468.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2468.patch", "merged_at": "2021-06-28T15:05...
true
Implement ClassLabel encoding in JSON loader Close #2365.
[ "No, nevermind @lhoestq. Thanks to you for your reviews!" ]
https://api.github.com/repos/huggingface/datasets/issues/2466
2,466
change udpos features structure
The structure is change such that each example is a sentence The change is done for issues: #2061 #2444 Close #2061 , close #2444.
closed
2021-06-09T08:03:31
https://api.github.com/repos/huggingface/datasets/issues/2466/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2466", "html_url": "https://github.com/huggingface/datasets/pull/2466", "diff_url": "https://github.com/huggingface/datasets/pull/2466.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2466.patch", "merged_at": "2021-06-16T10:41...
true
change udpos features structure The structure is change such that each example is a sentence The change is done for issues: #2061 #2444 Close #2061 , close #2444.
[ "Let's add the tags in another PR. Thanks again !", "Close #2061 , close #2444." ]
https://api.github.com/repos/huggingface/datasets/issues/2465
2,465
adding masahaner dataset
Adding Masakhane dataset https://github.com/masakhane-io/masakhane-ner @lhoestq , can you please review
closed
2021-06-08T21:20:25
https://api.github.com/repos/huggingface/datasets/issues/2465/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2465", "html_url": "https://github.com/huggingface/datasets/pull/2465", "diff_url": "https://github.com/huggingface/datasets/pull/2465.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2465.patch", "merged_at": "2021-06-14T14:59...
true
adding masahaner dataset Adding Masakhane dataset https://github.com/masakhane-io/masakhane-ner @lhoestq , can you please review
[ "Thank you for the review. ", "Thanks a lot for the corrections and comments. \r\n\r\nI have resolved point 2. The make style still throws some errors, please see below\r\n\r\nblack --line-length 119 --target-version py36 tests src benchmarks datasets/**/*.py metrics\r\n/bin/sh: 1: black: not found\r\nMakefile:13...
https://api.github.com/repos/huggingface/datasets/issues/2464
2,464
fix: adjusting indexing for the labels.
The labels index were mismatching the actual ones used in the dataset. Specifically `0` is used for `SUPPORTS` and `1` is used for `REFUTES` After this change, the `README.md` now reflects the content of `dataset_infos.json`. Signed-off-by: Matteo Manica <drugilsberg@gmail.com>
closed
2021-06-08T20:47:25
https://api.github.com/repos/huggingface/datasets/issues/2464/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2464", "html_url": "https://github.com/huggingface/datasets/pull/2464", "diff_url": "https://github.com/huggingface/datasets/pull/2464.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2464.patch", "merged_at": "2021-06-09T09:10...
true
fix: adjusting indexing for the labels. The labels index were mismatching the actual ones used in the dataset. Specifically `0` is used for `SUPPORTS` and `1` is used for `REFUTES` After this change, the `README.md` now reflects the content of `dataset_infos.json`. Signed-off-by: Matteo Manica <drugilsberg@gmail.c...
[ "> Good catch ! Thanks for fixing it\r\n\r\nMy pleasure🙏" ]
https://api.github.com/repos/huggingface/datasets/issues/2463
2,463
Fix proto_qa download link
Fixes #2459 Instead of updating the path, this PR fixes a commit hash as suggested by @lhoestq.
closed
2021-06-08T20:23:16
https://api.github.com/repos/huggingface/datasets/issues/2463/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2463", "html_url": "https://github.com/huggingface/datasets/pull/2463", "diff_url": "https://github.com/huggingface/datasets/pull/2463.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2463.patch", "merged_at": "2021-06-10T08:31...
true
Fix proto_qa download link Fixes #2459 Instead of updating the path, this PR fixes a commit hash as suggested by @lhoestq.
[]
https://api.github.com/repos/huggingface/datasets/issues/2462
2,462
Merge DatasetDict and Dataset
As discussed in #2424 and #2437 (please see there for detailed conversation): - It would be desirable to improve UX with respect the confusion between DatasetDict and Dataset. - The difference between Dataset and DatasetDict is an additional abstraction complexity that confuses "typical" end users. - A user expects...
open
2021-06-08T19:22:04
https://api.github.com/repos/huggingface/datasets/issues/2462/comments
null
false
Merge DatasetDict and Dataset As discussed in #2424 and #2437 (please see there for detailed conversation): - It would be desirable to improve UX with respect the confusion between DatasetDict and Dataset. - The difference between Dataset and DatasetDict is an additional abstraction complexity that confuses "typical"...
[ "Any update on this? @lhoestq ", "Unless there is high demande I don't think we will end up implementing this. This is a lot of work with very few advantages" ]
https://api.github.com/repos/huggingface/datasets/issues/2461
2,461
Support sliced list arrays in cast
There is this issue in pyarrow: ```python import pyarrow as pa arr = pa.array([[i * 10] for i in range(4)]) arr.cast(pa.list_(pa.int32())) # works arr = arr.slice(1) arr.cast(pa.list_(pa.int32())) # fails # ArrowNotImplementedError("Casting sliced lists (non-zero offset) not yet implemented") ``` Howev...
closed
2021-06-08T17:38:47
https://api.github.com/repos/huggingface/datasets/issues/2461/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2461", "html_url": "https://github.com/huggingface/datasets/pull/2461", "diff_url": "https://github.com/huggingface/datasets/pull/2461.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2461.patch", "merged_at": "2021-06-08T17:56...
true
Support sliced list arrays in cast There is this issue in pyarrow: ```python import pyarrow as pa arr = pa.array([[i * 10] for i in range(4)]) arr.cast(pa.list_(pa.int32())) # works arr = arr.slice(1) arr.cast(pa.list_(pa.int32())) # fails # ArrowNotImplementedError("Casting sliced lists (non-zero offset) ...
[]
https://api.github.com/repos/huggingface/datasets/issues/2460
2,460
Revert default in-memory for small datasets
Close #2458
closed
2021-06-08T17:14:23
https://api.github.com/repos/huggingface/datasets/issues/2460/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2460", "html_url": "https://github.com/huggingface/datasets/pull/2460", "diff_url": "https://github.com/huggingface/datasets/pull/2460.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2460.patch", "merged_at": "2021-06-08T17:55...
true
Revert default in-memory for small datasets Close #2458
[ "Thank you for this welcome change guys!" ]
https://api.github.com/repos/huggingface/datasets/issues/2459
2,459
`Proto_qa` hosting seems to be broken
## Describe the bug The hosting (on Github) of the `proto_qa` dataset seems broken. I haven't investigated more yet, just flagging it for now. @zaidalyafeai if you want to dive into it, I think it's just a matter of changing the links in `proto_qa.py` ## Steps to reproduce the bug ```python from datasets impo...
closed
2021-06-08T16:16:32
https://api.github.com/repos/huggingface/datasets/issues/2459/comments
null
false
`Proto_qa` hosting seems to be broken ## Describe the bug The hosting (on Github) of the `proto_qa` dataset seems broken. I haven't investigated more yet, just flagging it for now. @zaidalyafeai if you want to dive into it, I think it's just a matter of changing the links in `proto_qa.py` ## Steps to reproduce ...
[ "@VictorSanh , I think @mariosasko is already working on it. " ]
https://api.github.com/repos/huggingface/datasets/issues/2458
2,458
Revert default in-memory for small datasets
Users are reporting issues and confusion about setting default in-memory to True for small datasets. We see 2 clear use cases of Datasets: - the "canonical" way, where you can work with very large datasets, as they are memory-mapped and cached (after every transformation) - some edge cases (speed benchmarks, inter...
closed
2021-06-08T15:51:41
https://api.github.com/repos/huggingface/datasets/issues/2458/comments
null
false
Revert default in-memory for small datasets Users are reporting issues and confusion about setting default in-memory to True for small datasets. We see 2 clear use cases of Datasets: - the "canonical" way, where you can work with very large datasets, as they are memory-mapped and cached (after every transformation)...
[ "cc: @krandiash (pinged in reverted PR)." ]
https://api.github.com/repos/huggingface/datasets/issues/2457
2,457
Add align_labels_with_mapping function
This PR adds a helper function to align the `label2id` mapping between a `datasets.Dataset` and a classifier (e.g. a transformer with a `PretrainedConfig.label2id` dict), with the alignment performed on the dataset itself. This will help us with the Hub evaluation, where we won't know in advance whether a model that...
closed
2021-06-08T13:54:00
https://api.github.com/repos/huggingface/datasets/issues/2457/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2457", "html_url": "https://github.com/huggingface/datasets/pull/2457", "diff_url": "https://github.com/huggingface/datasets/pull/2457.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2457.patch", "merged_at": "2021-06-17T09:56...
true
Add align_labels_with_mapping function This PR adds a helper function to align the `label2id` mapping between a `datasets.Dataset` and a classifier (e.g. a transformer with a `PretrainedConfig.label2id` dict), with the alignment performed on the dataset itself. This will help us with the Hub evaluation, where we won...
[ "@lhoestq i think this is ready for another review 🙂 ", "@lhoestq thanks for the feedback - it's now integrated :) \r\n\r\ni also added a comment about sorting the input label IDs", "Created the PR here: https://github.com/huggingface/datasets/pull/2510", "> Thanks ! Looks all good now :)\r\n> \r\n> We will ...
https://api.github.com/repos/huggingface/datasets/issues/2456
2,456
Fix cross-reference typos in documentation
Fix some minor typos in docs that avoid the creation of cross-reference links.
closed
2021-06-08T09:45:14
https://api.github.com/repos/huggingface/datasets/issues/2456/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2456", "html_url": "https://github.com/huggingface/datasets/pull/2456", "diff_url": "https://github.com/huggingface/datasets/pull/2456.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2456.patch", "merged_at": "2021-06-08T17:41...
true
Fix cross-reference typos in documentation Fix some minor typos in docs that avoid the creation of cross-reference links.
[]
https://api.github.com/repos/huggingface/datasets/issues/2455
2,455
Update version in xor_tydi_qa.py
Fix #2449 @lhoestq Should I revert to the old `dummy/1.0.0` or delete it and keep only `dummy/1.1.0`?
closed
2021-06-08T02:23:45
https://api.github.com/repos/huggingface/datasets/issues/2455/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2455", "html_url": "https://github.com/huggingface/datasets/pull/2455", "diff_url": "https://github.com/huggingface/datasets/pull/2455.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2455.patch", "merged_at": "2021-06-14T15:35...
true
Update version in xor_tydi_qa.py Fix #2449 @lhoestq Should I revert to the old `dummy/1.0.0` or delete it and keep only `dummy/1.1.0`?
[ "Hi ! Thanks for updating the version\r\n\r\n> Should I revert to the old dummy/1.0.0 or delete it and keep only dummy/1.1.0?\r\n\r\nFeel free to delete the old dummy data files\r\n" ]
https://api.github.com/repos/huggingface/datasets/issues/2454
2,454
Rename config and environment variable for in memory max size
As discussed in #2409, both config and environment variable have been renamed. cc: @stas00, huggingface/transformers#12056
closed
2021-06-07T19:21:08
https://api.github.com/repos/huggingface/datasets/issues/2454/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/2454", "html_url": "https://github.com/huggingface/datasets/pull/2454", "diff_url": "https://github.com/huggingface/datasets/pull/2454.diff", "patch_url": "https://github.com/huggingface/datasets/pull/2454.patch", "merged_at": "2021-06-07T20:43...
true
Rename config and environment variable for in memory max size As discussed in #2409, both config and environment variable have been renamed. cc: @stas00, huggingface/transformers#12056
[ "Thank you for the rename, @albertvillanova!" ]