url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/725
725
pretty print dataset objects
Currently, if I do: ``` from datasets import load_dataset load_dataset("wikihow", 'all', data_dir="/hf/pegasus-datasets/wikihow/") ``` I get: ``` DatasetDict({'train': Dataset(features: {'text': Value(dtype='string', id=None), 'headline': Value(dtype='string', id=None), 'title': Value(dtype='string', id=None...
closed
2020-10-12T02:03:46
https://api.github.com/repos/huggingface/datasets/issues/725/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/725", "html_url": "https://github.com/huggingface/datasets/pull/725", "diff_url": "https://github.com/huggingface/datasets/pull/725.diff", "patch_url": "https://github.com/huggingface/datasets/pull/725.patch", "merged_at": "2020-10-23T09:00:46"...
true
pretty print dataset objects Currently, if I do: ``` from datasets import load_dataset load_dataset("wikihow", 'all', data_dir="/hf/pegasus-datasets/wikihow/") ``` I get: ``` DatasetDict({'train': Dataset(features: {'text': Value(dtype='string', id=None), 'headline': Value(dtype='string', id=None), 'title': V...
[ "Great, as you found it useful I improved the code a bit to automate indentation in the parent class, so that the child repr doesn't need to guess the indentation level, while repr'ing nicely on its own.\r\n\r\n- do we want indent=4 or 2?\r\n- do we want `{` ... `}` or w/o?\r\n\r\ncurrently it's indent4 and w/ curl...
https://api.github.com/repos/huggingface/datasets/issues/724
724
need to redirect /nlp to /datasets and remove outdated info
It looks like the website still has all the `nlp` data, e.g.: https://huggingface.co/nlp/viewer/?dataset=wikihow&config=all should probably redirect to: https://huggingface.co/datasets/wikihow also for some reason the new information is slightly borked. If you look at the old one it was nicely formatted and had t...
closed
2020-10-11T23:12:12
https://api.github.com/repos/huggingface/datasets/issues/724/comments
null
false
need to redirect /nlp to /datasets and remove outdated info It looks like the website still has all the `nlp` data, e.g.: https://huggingface.co/nlp/viewer/?dataset=wikihow&config=all should probably redirect to: https://huggingface.co/datasets/wikihow also for some reason the new information is slightly borked. ...
[ "Should be fixed now: \r\n\r\n![image](https://user-images.githubusercontent.com/35882/95917301-040b0600-0d78-11eb-9655-c4ac0e788089.png)\r\n\r\nNot sure I understand what you mean by the second part?\r\n", "Thank you!\r\n\r\n> Not sure I understand what you mean by the second part?\r\n\r\nCompare the 2:\r\n* htt...
https://api.github.com/repos/huggingface/datasets/issues/723
723
Adding pseudo-labels to datasets
I recently [uploaded pseudo-labels](https://github.com/huggingface/transformers/blob/master/examples/seq2seq/precomputed_pseudo_labels.md) for CNN/DM, XSUM and WMT16-en-ro to s3, and thom mentioned I should add them to this repo. Since pseudo-labels are just a large model's generations on an existing dataset, what is ...
closed
2020-10-11T21:05:45
https://api.github.com/repos/huggingface/datasets/issues/723/comments
null
false
Adding pseudo-labels to datasets I recently [uploaded pseudo-labels](https://github.com/huggingface/transformers/blob/master/examples/seq2seq/precomputed_pseudo_labels.md) for CNN/DM, XSUM and WMT16-en-ro to s3, and thom mentioned I should add them to this repo. Since pseudo-labels are just a large model's generations...
[ "Nice ! :)\r\nIt's indeed the first time we have such contributions so we'll have to figure out the appropriate way to integrate them.\r\nCould you add details on what they could be used for ?\r\n", "They can be used as training data for a smaller model.", "Sounds just like a regular dataset to me then, no?", ...
https://api.github.com/repos/huggingface/datasets/issues/722
722
datasets(RWTH-PHOENIX-Weather 2014 T): add initial loading script
This is the first sign language dataset in this repo as far as I know. Following an old issue I opened https://github.com/huggingface/datasets/issues/302. I added the dataset official REAMDE file, but I see it's not very standard, so it can be removed.
closed
2020-10-10T19:44:08
https://api.github.com/repos/huggingface/datasets/issues/722/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/722", "html_url": "https://github.com/huggingface/datasets/pull/722", "diff_url": "https://github.com/huggingface/datasets/pull/722.diff", "patch_url": "https://github.com/huggingface/datasets/pull/722.patch", "merged_at": null }
true
datasets(RWTH-PHOENIX-Weather 2014 T): add initial loading script This is the first sign language dataset in this repo as far as I know. Following an old issue I opened https://github.com/huggingface/datasets/issues/302. I added the dataset official REAMDE file, but I see it's not very standard, so it can be remove...
[ "This might be interesting to @kayoyin the author of https://github.com/kayoyin/transformer-slt – pinging you just in case :)", "Thanks Amit, this is a great idea! I'm thinking of porting the SLT models from my paper here as well, having this dataset would be perfect for that :)", "Thanks for your contribution,...
https://api.github.com/repos/huggingface/datasets/issues/721
721
feat(dl_manager): add support for ftp downloads
I am working on a new dataset (#302) and encounter a problem downloading it. ```python # This is the official download link from https://www-i6.informatik.rwth-aachen.de/~koller/RWTH-PHOENIX-2014-T/ _URL = "ftp://wasserstoff.informatik.rwth-aachen.de/pub/rwth-phoenix/2016/phoenix-2014-T.v3.tar.gz" dl_manager.do...
closed
2020-10-10T15:50:20
https://api.github.com/repos/huggingface/datasets/issues/721/comments
null
false
feat(dl_manager): add support for ftp downloads I am working on a new dataset (#302) and encounter a problem downloading it. ```python # This is the official download link from https://www-i6.informatik.rwth-aachen.de/~koller/RWTH-PHOENIX-2014-T/ _URL = "ftp://wasserstoff.informatik.rwth-aachen.de/pub/rwth-phoenix...
[ "We only support http by default for downloading.\r\nIf you really need to use ftp, then feel free to use a library that allows to download through ftp in your dataset script (I see that you've started working on #722 , that's awesome !). The users will get a message to install the extra library when they load the ...
https://api.github.com/repos/huggingface/datasets/issues/720
720
OSError: Cannot find data file when not using the dummy dataset in RAG
## Environment info transformers version: 3.3.1 Platform: Linux-4.19 Python version: 3.7.7 PyTorch version (GPU?): 1.6.0 Tensorflow version (GPU?): No Using GPU in script?: Yes Using distributed or parallel set-up in script?: No ## To reproduce Steps to reproduce the behaviour...
closed
2020-10-07T14:27:13
https://api.github.com/repos/huggingface/datasets/issues/720/comments
null
false
OSError: Cannot find data file when not using the dummy dataset in RAG ## Environment info transformers version: 3.3.1 Platform: Linux-4.19 Python version: 3.7.7 PyTorch version (GPU?): 1.6.0 Tensorflow version (GPU?): No Using GPU in script?: Yes Using distributed or parallel set-u...
[ "Same issue here. I will be digging further, but it looks like the [script](https://github.com/huggingface/datasets/blob/master/datasets/wiki_dpr/wiki_dpr.py#L132) is attempting to open a file that is not downloaded yet. \r\n\r\n```\r\n99dcbca09109e58502e6b9271d4d3f3791b43f61f3161a76b25d2775ab1a4498.lock\r\n```\r\n...
https://api.github.com/repos/huggingface/datasets/issues/719
719
Fix train_test_split output format
There was an issue in the `transmit_format` wrapper that returned bad formats when using train_test_split. This was due to `column_names` being handled as a List[str] instead of Dict[str, List[str]] when the dataset transform (train_test_split) returns a DatasetDict (one set of column names per split). This should ...
closed
2020-10-07T12:39:01
https://api.github.com/repos/huggingface/datasets/issues/719/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/719", "html_url": "https://github.com/huggingface/datasets/pull/719", "diff_url": "https://github.com/huggingface/datasets/pull/719.diff", "patch_url": "https://github.com/huggingface/datasets/pull/719.patch", "merged_at": "2020-10-07T13:38:06"...
true
Fix train_test_split output format There was an issue in the `transmit_format` wrapper that returned bad formats when using train_test_split. This was due to `column_names` being handled as a List[str] instead of Dict[str, List[str]] when the dataset transform (train_test_split) returns a DatasetDict (one set of colum...
[]
https://api.github.com/repos/huggingface/datasets/issues/718
718
Don't use tqdm 4.50.0
tqdm 4.50.0 introduced permission errors on windows see [here](https://app.circleci.com/pipelines/github/huggingface/datasets/235/workflows/cfb6a39f-68eb-4802-8b17-2cd5e8ea7369/jobs/1111) for the error details. For now I just added `<4.50.0` in the setup.py Hopefully we can find what's wrong with this version soon
closed
2020-10-06T13:45:53
https://api.github.com/repos/huggingface/datasets/issues/718/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/718", "html_url": "https://github.com/huggingface/datasets/pull/718", "diff_url": "https://github.com/huggingface/datasets/pull/718.diff", "patch_url": "https://github.com/huggingface/datasets/pull/718.patch", "merged_at": "2020-10-06T13:49:22"...
true
Don't use tqdm 4.50.0 tqdm 4.50.0 introduced permission errors on windows see [here](https://app.circleci.com/pipelines/github/huggingface/datasets/235/workflows/cfb6a39f-68eb-4802-8b17-2cd5e8ea7369/jobs/1111) for the error details. For now I just added `<4.50.0` in the setup.py Hopefully we can find what's wrong ...
[]
https://api.github.com/repos/huggingface/datasets/issues/717
717
Fixes #712 Error in the Overview.ipynb notebook
Fixes #712 Error in the Overview.ipynb notebook by adding `with_details=True` parameter to `list_datasets` function in Cell 3 of **overview** notebook
closed
2020-10-05T15:50:41
https://api.github.com/repos/huggingface/datasets/issues/717/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/717", "html_url": "https://github.com/huggingface/datasets/pull/717", "diff_url": "https://github.com/huggingface/datasets/pull/717.diff", "patch_url": "https://github.com/huggingface/datasets/pull/717.patch", "merged_at": "2020-10-05T16:25:40"...
true
Fixes #712 Error in the Overview.ipynb notebook Fixes #712 Error in the Overview.ipynb notebook by adding `with_details=True` parameter to `list_datasets` function in Cell 3 of **overview** notebook
[]
https://api.github.com/repos/huggingface/datasets/issues/716
716
Fixes #712 Attribute error in cell 3 of the overview notebook
Fixes the Attribute error in cell 3 of the overview notebook
closed
2020-10-05T15:42:09
https://api.github.com/repos/huggingface/datasets/issues/716/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/716", "html_url": "https://github.com/huggingface/datasets/pull/716", "diff_url": "https://github.com/huggingface/datasets/pull/716.diff", "patch_url": "https://github.com/huggingface/datasets/pull/716.patch", "merged_at": null }
true
Fixes #712 Attribute error in cell 3 of the overview notebook Fixes the Attribute error in cell 3 of the overview notebook
[ "Referencing the wrong issue # in the commit message. Closing this to fix it again." ]
https://api.github.com/repos/huggingface/datasets/issues/715
715
Use python read for text dataset
As mentioned in #622 the pandas reader used for text dataset doesn't work properly when there are \r characters in the text file. Instead I switched to pure python using `open` and `read`. From my benchmark on a 100MB text file, it's the same speed as the previous pandas reader.
closed
2020-10-05T09:47:55
https://api.github.com/repos/huggingface/datasets/issues/715/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/715", "html_url": "https://github.com/huggingface/datasets/pull/715", "diff_url": "https://github.com/huggingface/datasets/pull/715.diff", "patch_url": "https://github.com/huggingface/datasets/pull/715.patch", "merged_at": "2020-10-05T13:13:16"...
true
Use python read for text dataset As mentioned in #622 the pandas reader used for text dataset doesn't work properly when there are \r characters in the text file. Instead I switched to pure python using `open` and `read`. From my benchmark on a 100MB text file, it's the same speed as the previous pandas reader.
[ "One thing though, could we try to read the files in parallel?", "We could but I'm not sure this would help a lot since the bottleneck is the drive IO if the files are big enough.\r\nIt could make sense for very small files.", "Looks like windows is not a big fan of this approach\r\nI'm working on a fix", "I ...
https://api.github.com/repos/huggingface/datasets/issues/714
714
Add the official dependabot implementation
This will keep dependencies up to date. This will require a pr label `dependencies` being created in order to function correctly.
closed
2020-10-05T03:49:45
https://api.github.com/repos/huggingface/datasets/issues/714/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/714", "html_url": "https://github.com/huggingface/datasets/pull/714", "diff_url": "https://github.com/huggingface/datasets/pull/714.diff", "patch_url": "https://github.com/huggingface/datasets/pull/714.patch", "merged_at": null }
true
Add the official dependabot implementation This will keep dependencies up to date. This will require a pr label `dependencies` being created in order to function correctly.
[]
https://api.github.com/repos/huggingface/datasets/issues/713
713
Fix reading text files with carriage return symbols
The new pandas-based text reader isn't able to work properly with files that contain carriage return symbols (`\r`). It fails with the following error message: ``` ... File "pandas/_libs/parsers.pyx", line 847, in pandas._libs.parsers.TextReader.read File "pandas/_libs/parsers.pyx", line 874, in pandas._l...
closed
2020-10-05T03:07:03
https://api.github.com/repos/huggingface/datasets/issues/713/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/713", "html_url": "https://github.com/huggingface/datasets/pull/713", "diff_url": "https://github.com/huggingface/datasets/pull/713.diff", "patch_url": "https://github.com/huggingface/datasets/pull/713.patch", "merged_at": null }
true
Fix reading text files with carriage return symbols The new pandas-based text reader isn't able to work properly with files that contain carriage return symbols (`\r`). It fails with the following error message: ``` ... File "pandas/_libs/parsers.pyx", line 847, in pandas._libs.parsers.TextReader.read Fil...
[ "Discussed in #622, fixed in #715. Closing the issue. Thanks @lhoestq, it works now! 👍 " ]
https://api.github.com/repos/huggingface/datasets/issues/712
712
Error in the notebooks/Overview.ipynb notebook
Hi, I got the following error in **cell number 3** while exploring the **Overview.ipynb** notebook in google colab. I used the [link ](https://colab.research.google.com/github/huggingface/datasets/blob/master/notebooks/Overview.ipynb) provided in the main README file to open it in colab. ```python # You can acc...
closed
2020-10-04T05:58:31
https://api.github.com/repos/huggingface/datasets/issues/712/comments
null
false
Error in the notebooks/Overview.ipynb notebook Hi, I got the following error in **cell number 3** while exploring the **Overview.ipynb** notebook in google colab. I used the [link ](https://colab.research.google.com/github/huggingface/datasets/blob/master/notebooks/Overview.ipynb) provided in the main README file to...
[ "Do this:\r\n``` python\r\nsquad_dataset = list_datasets(with_details=True)[datasets.index('squad')]\r\npprint(squad_dataset.__dict__) # It's a simple python dataclass\r\n```", "Thanks! This worked. I have created a PR to fix this in the notebook. " ]
https://api.github.com/repos/huggingface/datasets/issues/711
711
New Update bertscore.py
closed
2020-10-04T05:13:09
https://api.github.com/repos/huggingface/datasets/issues/711/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/711", "html_url": "https://github.com/huggingface/datasets/pull/711", "diff_url": "https://github.com/huggingface/datasets/pull/711.diff", "patch_url": "https://github.com/huggingface/datasets/pull/711.patch", "merged_at": "2020-10-05T16:26:51"...
true
New Update bertscore.py
[]
https://api.github.com/repos/huggingface/datasets/issues/710
710
fix README typos/ consistency
closed
2020-10-03T22:20:56
https://api.github.com/repos/huggingface/datasets/issues/710/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/710", "html_url": "https://github.com/huggingface/datasets/pull/710", "diff_url": "https://github.com/huggingface/datasets/pull/710.diff", "patch_url": "https://github.com/huggingface/datasets/pull/710.patch", "merged_at": "2020-10-17T09:52:45"...
true
fix README typos/ consistency
[]
https://api.github.com/repos/huggingface/datasets/issues/709
709
How to use similarity settings other then "BM25" in Elasticsearch index ?
**QUESTION : How should we use other similarity algorithms supported by Elasticsearch other than "BM25" ?** **ES Reference** https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules-similarity.html **HF doc reference:** https://huggingface.co/docs/datasets/faiss_and_ea.html **context :** =...
closed
2020-10-03T11:18:49
https://api.github.com/repos/huggingface/datasets/issues/709/comments
null
false
How to use similarity settings other then "BM25" in Elasticsearch index ? **QUESTION : How should we use other similarity algorithms supported by Elasticsearch other than "BM25" ?** **ES Reference** https://www.elastic.co/guide/en/elasticsearch/reference/current/index-modules-similarity.html **HF doc reference:** ...
[ "Datasets does not use elasticsearch API to define custom similarity. If you want to use a custom similarity, the best would be to run a curl request directly to your elasticsearch instance (see sample hereafter, directly from ES documentation), then you should be able to use `my_similarity` in your configuration p...
https://api.github.com/repos/huggingface/datasets/issues/708
708
Datasets performance slow? - 6.4x slower than in memory dataset
I've been very excited about this amazing datasets project. However, I've noticed that the performance can be substantially slower than using an in-memory dataset. Now, this is expected I guess, due to memory mapping data using arrow files, and you don't get anything for free. But I was surprised at how much slower....
closed
2020-10-03T06:44:07
https://api.github.com/repos/huggingface/datasets/issues/708/comments
null
false
Datasets performance slow? - 6.4x slower than in memory dataset I've been very excited about this amazing datasets project. However, I've noticed that the performance can be substantially slower than using an in-memory dataset. Now, this is expected I guess, due to memory mapping data using arrow files, and you don'...
[ "Facing a similar issue here. My model using SQuAD dataset takes about 1h to process with in memory data and more than 2h with datasets directly.", "And if you use in-memory-data with datasets with `load_dataset(..., keep_in_memory=True)`?", "Thanks for the tip @thomwolf ! I did not see that flag in the docs. I...
https://api.github.com/repos/huggingface/datasets/issues/707
707
Requirements should specify pyarrow<1
I was looking at the docs on [Perplexity](https://huggingface.co/transformers/perplexity.html) via GPT2. When you load datasets and try to load Wikitext, you get the error, ``` module 'pyarrow' has no attribute 'PyExtensionType' ``` I traced it back to datasets having installed PyArrow 1.0.1 but there's not pinni...
closed
2020-10-02T23:39:39
https://api.github.com/repos/huggingface/datasets/issues/707/comments
null
false
Requirements should specify pyarrow<1 I was looking at the docs on [Perplexity](https://huggingface.co/transformers/perplexity.html) via GPT2. When you load datasets and try to load Wikitext, you get the error, ``` module 'pyarrow' has no attribute 'PyExtensionType' ``` I traced it back to datasets having install...
[ "Hello @mathcass I would want to work on this issue. May I do the same? ", "@punitaojha, certainly. Feel free to work on this. Let me know if you need any help or clarity.", "Hello @mathcass \r\n1. I did fork the repository and clone the same on my local system. \r\n\r\n2. Then learnt about how we can publish o...
https://api.github.com/repos/huggingface/datasets/issues/706
706
Fix config creation for data files with NamedSplit
During config creation, we need to iterate through the data files of all the splits to compute a hash. To make sure the hash is unique given a certain combination of files/splits, we sort the split names. However the `NamedSplit` objects can't be passed to `sorted` and currently it raises an error: we need to sort th...
closed
2020-10-02T15:46:49
https://api.github.com/repos/huggingface/datasets/issues/706/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/706", "html_url": "https://github.com/huggingface/datasets/pull/706", "diff_url": "https://github.com/huggingface/datasets/pull/706.diff", "patch_url": "https://github.com/huggingface/datasets/pull/706.patch", "merged_at": "2020-10-05T08:14:59"...
true
Fix config creation for data files with NamedSplit During config creation, we need to iterate through the data files of all the splits to compute a hash. To make sure the hash is unique given a certain combination of files/splits, we sort the split names. However the `NamedSplit` objects can't be passed to `sorted` a...
[]
https://api.github.com/repos/huggingface/datasets/issues/705
705
TypeError: '<' not supported between instances of 'NamedSplit' and 'NamedSplit'
## Environment info <!-- You can run the command `transformers-cli env` and copy-and-paste its output below. Don't forget to fill out the missing fields in that output! --> - `transformers` version: 3.3.1 (installed from master) - `datasets` version: 1.0.2 (installed as a dependency from transformers) ...
closed
2020-10-02T15:27:55
https://api.github.com/repos/huggingface/datasets/issues/705/comments
null
false
TypeError: '<' not supported between instances of 'NamedSplit' and 'NamedSplit' ## Environment info <!-- You can run the command `transformers-cli env` and copy-and-paste its output below. Don't forget to fill out the missing fields in that output! --> - `transformers` version: 3.3.1 (installed from mast...
[ "Hi !\r\nThanks for reporting :) \r\nIndeed this is an issue on the `datasets` side.\r\nI'm creating a PR", "Thanks @lhoestq !" ]
https://api.github.com/repos/huggingface/datasets/issues/704
704
Fix remote tests for new datasets
When adding a new dataset, the remote tests fail because they try to get the new dataset from the master branch (i.e., where the dataset doesn't exist yet) To fix that I reverted to the use of the HF API that fetch the available datasets on S3 that is synced with the master branch
closed
2020-10-02T12:08:04
https://api.github.com/repos/huggingface/datasets/issues/704/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/704", "html_url": "https://github.com/huggingface/datasets/pull/704", "diff_url": "https://github.com/huggingface/datasets/pull/704.diff", "patch_url": "https://github.com/huggingface/datasets/pull/704.patch", "merged_at": "2020-10-02T12:12:01"...
true
Fix remote tests for new datasets When adding a new dataset, the remote tests fail because they try to get the new dataset from the master branch (i.e., where the dataset doesn't exist yet) To fix that I reverted to the use of the HF API that fetch the available datasets on S3 that is synced with the master branch
[]
https://api.github.com/repos/huggingface/datasets/issues/703
703
Add hotpot QA
Added the [HotpotQA](https://github.com/hotpotqa/hotpot) multi-hop question answering dataset.
closed
2020-10-02T11:44:28
https://api.github.com/repos/huggingface/datasets/issues/703/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/703", "html_url": "https://github.com/huggingface/datasets/pull/703", "diff_url": "https://github.com/huggingface/datasets/pull/703.diff", "patch_url": "https://github.com/huggingface/datasets/pull/703.patch", "merged_at": "2020-10-02T12:54:40"...
true
Add hotpot QA Added the [HotpotQA](https://github.com/hotpotqa/hotpot) multi-hop question answering dataset.
[ "Awesome :) \r\n\r\nDon't pay attention to the RemoteDatasetTest error, I'm fixing it right now", "You can rebase from master to fix the CI test :)", "If we're lucky we can even include this dataset in today's release", "Just thinking since `type` can only be `comparison` or `bridge` and `level` can only be `...
https://api.github.com/repos/huggingface/datasets/issues/702
702
Complete rouge kwargs
In #701 we noticed that some kwargs were missing for rouge
closed
2020-10-02T09:59:01
https://api.github.com/repos/huggingface/datasets/issues/702/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/702", "html_url": "https://github.com/huggingface/datasets/pull/702", "diff_url": "https://github.com/huggingface/datasets/pull/702.diff", "patch_url": "https://github.com/huggingface/datasets/pull/702.patch", "merged_at": "2020-10-02T10:11:03"...
true
Complete rouge kwargs In #701 we noticed that some kwargs were missing for rouge
[]
https://api.github.com/repos/huggingface/datasets/issues/701
701
Add rouge 2 and rouge Lsum to rouge metric outputs
Continuation of #700 Rouge 2 and Rouge Lsum were missing in Rouge's outputs. Rouge Lsum is also useful to evaluate Rouge L for sentences with `\n` Fix #617
closed
2020-10-02T09:35:46
https://api.github.com/repos/huggingface/datasets/issues/701/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/701", "html_url": "https://github.com/huggingface/datasets/pull/701", "diff_url": "https://github.com/huggingface/datasets/pull/701.diff", "patch_url": "https://github.com/huggingface/datasets/pull/701.patch", "merged_at": "2020-10-02T09:52:18"...
true
Add rouge 2 and rouge Lsum to rouge metric outputs Continuation of #700 Rouge 2 and Rouge Lsum were missing in Rouge's outputs. Rouge Lsum is also useful to evaluate Rouge L for sentences with `\n` Fix #617
[ "Oups too late, sorry" ]
https://api.github.com/repos/huggingface/datasets/issues/700
700
Add rouge-2 in rouge_types for metric calculation
The description of the ROUGE metric says, ``` _KWARGS_DESCRIPTION = """ Calculates average rouge scores for a list of hypotheses and references Args: predictions: list of predictions to score. Each predictions should be a string with tokens separated by spaces. references: list of reference for ...
closed
2020-10-02T08:36:45
https://api.github.com/repos/huggingface/datasets/issues/700/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/700", "html_url": "https://github.com/huggingface/datasets/pull/700", "diff_url": "https://github.com/huggingface/datasets/pull/700.diff", "patch_url": "https://github.com/huggingface/datasets/pull/700.patch", "merged_at": null }
true
Add rouge-2 in rouge_types for metric calculation The description of the ROUGE metric says, ``` _KWARGS_DESCRIPTION = """ Calculates average rouge scores for a list of hypotheses and references Args: predictions: list of predictions to score. Each predictions should be a string with tokens separated ...
[ "Indeed there's currently a mismatch between the description and what it rouge actually returns.\r\nThanks for proposing this fix :) \r\n\r\nI think it's better to return rouge 1-2-L.\r\nWas there a reason to only include rouge 1 and rouge L @thomwolf ? ", "rougeLsum is also missing, could you add it ?", "Addin...
https://api.github.com/repos/huggingface/datasets/issues/699
699
XNLI dataset is not loading
`dataset = datasets.load_dataset(path='xnli')` showing below error ``` /opt/conda/lib/python3.7/site-packages/nlp/utils/info_utils.py in verify_checksums(expected_checksums, recorded_checksums, verification_name) 36 if len(bad_urls) > 0: 37 error_msg = "Checksums didn't match" + for_verifi...
closed
2020-10-02T06:53:16
https://api.github.com/repos/huggingface/datasets/issues/699/comments
null
false
XNLI dataset is not loading `dataset = datasets.load_dataset(path='xnli')` showing below error ``` /opt/conda/lib/python3.7/site-packages/nlp/utils/info_utils.py in verify_checksums(expected_checksums, recorded_checksums, verification_name) 36 if len(bad_urls) > 0: 37 error_msg = "Checksu...
[ "also i tried below code to solve checksum error \r\n`datasets-cli test ./datasets/xnli --save_infos --all_configs`\r\n\r\nand it shows \r\n\r\n```\r\n2020-10-02 07:06:16.588760: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcudart.so.10.1\r\nTraceback (most ...
https://api.github.com/repos/huggingface/datasets/issues/697
697
Update README.md
Hey I was just telling my subscribers to check out your repositories Thank you
closed
2020-10-01T16:02:42
https://api.github.com/repos/huggingface/datasets/issues/697/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/697", "html_url": "https://github.com/huggingface/datasets/pull/697", "diff_url": "https://github.com/huggingface/datasets/pull/697.diff", "patch_url": "https://github.com/huggingface/datasets/pull/697.patch", "merged_at": null }
true
Update README.md Hey I was just telling my subscribers to check out your repositories Thank you
[]
https://api.github.com/repos/huggingface/datasets/issues/696
696
Elasticsearch index docs
I added the docs for ES indexes. I also added a `load_elasticsearch_index` method to load an index that has already been built. I checked the tests for the ES index and we have tests that mock ElasticSearch. I think this is good for now but at some point it would be cool to have an end-to-end test with a real ES...
closed
2020-10-01T15:18:58
https://api.github.com/repos/huggingface/datasets/issues/696/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/696", "html_url": "https://github.com/huggingface/datasets/pull/696", "diff_url": "https://github.com/huggingface/datasets/pull/696.diff", "patch_url": "https://github.com/huggingface/datasets/pull/696.patch", "merged_at": "2020-10-02T07:48:18"...
true
Elasticsearch index docs I added the docs for ES indexes. I also added a `load_elasticsearch_index` method to load an index that has already been built. I checked the tests for the ES index and we have tests that mock ElasticSearch. I think this is good for now but at some point it would be cool to have an end-t...
[]
https://api.github.com/repos/huggingface/datasets/issues/695
695
Update XNLI download link
The old link isn't working anymore. I updated it with the new official link. Fix #690
closed
2020-10-01T13:27:22
https://api.github.com/repos/huggingface/datasets/issues/695/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/695", "html_url": "https://github.com/huggingface/datasets/pull/695", "diff_url": "https://github.com/huggingface/datasets/pull/695.diff", "patch_url": "https://github.com/huggingface/datasets/pull/695.patch", "merged_at": "2020-10-01T14:01:14"...
true
Update XNLI download link The old link isn't working anymore. I updated it with the new official link. Fix #690
[]
https://api.github.com/repos/huggingface/datasets/issues/694
694
Use GitHub instead of aws in remote dataset tests
Recently we switched from aws s3 to github to download dataset scripts. However in the tests, the dummy data were still downloaded from s3. So I changed that to download them from github instead, in the MockDownloadManager. Moreover I noticed that `anli`'s dummy data were quite heavy (18MB compressed, i.e. the ent...
closed
2020-10-01T13:07:50
https://api.github.com/repos/huggingface/datasets/issues/694/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/694", "html_url": "https://github.com/huggingface/datasets/pull/694", "diff_url": "https://github.com/huggingface/datasets/pull/694.diff", "patch_url": "https://github.com/huggingface/datasets/pull/694.patch", "merged_at": "2020-10-02T07:47:26"...
true
Use GitHub instead of aws in remote dataset tests Recently we switched from aws s3 to github to download dataset scripts. However in the tests, the dummy data were still downloaded from s3. So I changed that to download them from github instead, in the MockDownloadManager. Moreover I noticed that `anli`'s dummy da...
[]
https://api.github.com/repos/huggingface/datasets/issues/693
693
Rachel ker add dataset/mlsum
.
closed
2020-10-01T13:01:10
https://api.github.com/repos/huggingface/datasets/issues/693/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/693", "html_url": "https://github.com/huggingface/datasets/pull/693", "diff_url": "https://github.com/huggingface/datasets/pull/693.diff", "patch_url": "https://github.com/huggingface/datasets/pull/693.patch", "merged_at": null }
true
Rachel ker add dataset/mlsum .
[ "It looks like an outdated PR (we've already added mlsum). Closing it" ]
https://api.github.com/repos/huggingface/datasets/issues/692
692
Update README.md
closed
2020-10-01T12:57:22
https://api.github.com/repos/huggingface/datasets/issues/692/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/692", "html_url": "https://github.com/huggingface/datasets/pull/692", "diff_url": "https://github.com/huggingface/datasets/pull/692.diff", "patch_url": "https://github.com/huggingface/datasets/pull/692.patch", "merged_at": null }
true
Update README.md
[ "Hacktoberfest spam", "To enhance its readability.....not Hacktoberfest spam", "How is adding a punctuation to the end of a sentence justified as \"To enhance its readability\". \r\nConsidering that this is not your first \"README enhancement '' please don't spam the open source community with useless PR to get...
https://api.github.com/repos/huggingface/datasets/issues/691
691
Add UI filter to filter datasets based on task
This is great work, so huge shoutout to contributors and huggingface. The [/nlp/viewer](https://huggingface.co/nlp/viewer/) is great and the [/datasets](https://huggingface.co/datasets) page is great. I was wondering if in both or either places we can have a filter that selects if a dataset is good for the following...
closed
2020-10-01T00:56:18
https://api.github.com/repos/huggingface/datasets/issues/691/comments
null
false
Add UI filter to filter datasets based on task This is great work, so huge shoutout to contributors and huggingface. The [/nlp/viewer](https://huggingface.co/nlp/viewer/) is great and the [/datasets](https://huggingface.co/datasets) page is great. I was wondering if in both or either places we can have a filter that...
[ "Already supported." ]
https://api.github.com/repos/huggingface/datasets/issues/690
690
XNLI dataset: NonMatchingChecksumError
Hi, I tried to download "xnli" dataset in colab using `xnli = load_dataset(path='xnli')` but got 'NonMatchingChecksumError' error `NonMatchingChecksumError Traceback (most recent call last) <ipython-input-27-a87bedc82eeb> in <module>() ----> 1 xnli = load_dataset(path='xnli') 3 frames /usr...
closed
2020-09-30T17:50:03
https://api.github.com/repos/huggingface/datasets/issues/690/comments
null
false
XNLI dataset: NonMatchingChecksumError Hi, I tried to download "xnli" dataset in colab using `xnli = load_dataset(path='xnli')` but got 'NonMatchingChecksumError' error `NonMatchingChecksumError Traceback (most recent call last) <ipython-input-27-a87bedc82eeb> in <module>() ----> 1 xnli = load...
[ "Thanks for reporting.\r\nThe data file must have been updated by the host.\r\nI'll update the checksum with the new one.", "Well actually it looks like the link isn't working anymore :(", "The new link is https://cims.nyu.edu/~sbowman/xnli/XNLI-1.0.zip\r\nI'll update the dataset script", "I'll do a release i...
https://api.github.com/repos/huggingface/datasets/issues/689
689
Switch to pandas reader for text dataset
Following the discussion in #622 , it appears that there's no appropriate ways to use the payrrow csv reader to read text files because of the separator. In this PR I switched to pandas to read the file. Moreover pandas allows to read the file by chunk, which means that you can build the arrow dataset from a text...
closed
2020-09-30T16:28:12
https://api.github.com/repos/huggingface/datasets/issues/689/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/689", "html_url": "https://github.com/huggingface/datasets/pull/689", "diff_url": "https://github.com/huggingface/datasets/pull/689.diff", "patch_url": "https://github.com/huggingface/datasets/pull/689.patch", "merged_at": "2020-09-30T16:45:31"...
true
Switch to pandas reader for text dataset Following the discussion in #622 , it appears that there's no appropriate ways to use the payrrow csv reader to read text files because of the separator. In this PR I switched to pandas to read the file. Moreover pandas allows to read the file by chunk, which means that yo...
[ "If the windows tests in the CI pass, today will be a happy day" ]
https://api.github.com/repos/huggingface/datasets/issues/688
688
Disable tokenizers parallelism in multiprocessed map
It was reported in #620 that using multiprocessing with a tokenizers shows this message: ``` The current process just got forked. Disabling parallelism to avoid deadlocks... To disable this warning, please explicitly set TOKENIZERS_PARALLELISM=(true | false) ``` This message is shown when TOKENIZERS_PARALLELISM is...
closed
2020-09-30T09:53:34
https://api.github.com/repos/huggingface/datasets/issues/688/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/688", "html_url": "https://github.com/huggingface/datasets/pull/688", "diff_url": "https://github.com/huggingface/datasets/pull/688.diff", "patch_url": "https://github.com/huggingface/datasets/pull/688.patch", "merged_at": "2020-10-01T08:45:45"...
true
Disable tokenizers parallelism in multiprocessed map It was reported in #620 that using multiprocessing with a tokenizers shows this message: ``` The current process just got forked. Disabling parallelism to avoid deadlocks... To disable this warning, please explicitly set TOKENIZERS_PARALLELISM=(true | false) ``` ...
[]
https://api.github.com/repos/huggingface/datasets/issues/687
687
`ArrowInvalid` occurs while running `Dataset.map()` function
It seems to fail to process the final batch. This [colab](https://colab.research.google.com/drive/1_byLZRHwGP13PHMkJWo62Wp50S_Z2HMD?usp=sharing) can reproduce the error. Code: ```python # train_ds = Dataset(features: { # 'title': Value(dtype='string', id=None), # 'score': Value(dtype='float64', id=Non...
closed
2020-09-30T06:16:50
https://api.github.com/repos/huggingface/datasets/issues/687/comments
null
false
`ArrowInvalid` occurs while running `Dataset.map()` function It seems to fail to process the final batch. This [colab](https://colab.research.google.com/drive/1_byLZRHwGP13PHMkJWo62Wp50S_Z2HMD?usp=sharing) can reproduce the error. Code: ```python # train_ds = Dataset(features: { # 'title': Value(dtype='stri...
[ "Hi !\r\n\r\nThis is because `encode` expects one single text as input (str), or one tokenized text (List[str]).\r\nI believe that you actually wanted to use `encode_batch` which expects a batch of texts.\r\nHowever this method is only available for our \"fast\" tokenizers (ex: BertTokenizerFast).\r\nBertJapanese i...
https://api.github.com/repos/huggingface/datasets/issues/686
686
Dataset browser url is still https://huggingface.co/nlp/viewer/
Might be worth updating to https://huggingface.co/datasets/viewer/
closed
2020-09-29T19:21:52
https://api.github.com/repos/huggingface/datasets/issues/686/comments
null
false
Dataset browser url is still https://huggingface.co/nlp/viewer/ Might be worth updating to https://huggingface.co/datasets/viewer/
[ "Yes! might do it with @srush one of these days. Hopefully it won't break too many links (we can always redirect from old url to new)", "This was fixed but forgot to close the issue. cc @lhoestq @yjernite \r\n\r\nThanks @jarednielsen!" ]
https://api.github.com/repos/huggingface/datasets/issues/685
685
Add features parameter to CSV
Add support for the `features` parameter when loading a csv dataset: ```python from datasets import load_dataset, Features features = Features({...}) csv_dataset = load_dataset("csv", data_files=["path/to/my/file.csv"], features=features) ``` I added tests to make sure that it is also compatible with the ca...
closed
2020-09-29T14:43:36
https://api.github.com/repos/huggingface/datasets/issues/685/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/685", "html_url": "https://github.com/huggingface/datasets/pull/685", "diff_url": "https://github.com/huggingface/datasets/pull/685.diff", "patch_url": "https://github.com/huggingface/datasets/pull/685.patch", "merged_at": "2020-09-30T08:39:54"...
true
Add features parameter to CSV Add support for the `features` parameter when loading a csv dataset: ```python from datasets import load_dataset, Features features = Features({...}) csv_dataset = load_dataset("csv", data_files=["path/to/my/file.csv"], features=features) ``` I added tests to make sure that it ...
[]
https://api.github.com/repos/huggingface/datasets/issues/684
684
Fix column order issue in cast
Previously, the order of the columns in the features passes to `cast_` mattered. However even though features passed to `cast_` had the same order as the dataset features, it could fail because the schema that was built was always in alphabetical order. This issue was reported by @lewtun in #623 To fix that I fi...
closed
2020-09-29T12:49:13
https://api.github.com/repos/huggingface/datasets/issues/684/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/684", "html_url": "https://github.com/huggingface/datasets/pull/684", "diff_url": "https://github.com/huggingface/datasets/pull/684.diff", "patch_url": "https://github.com/huggingface/datasets/pull/684.patch", "merged_at": "2020-09-29T15:56:45"...
true
Fix column order issue in cast Previously, the order of the columns in the features passes to `cast_` mattered. However even though features passed to `cast_` had the same order as the dataset features, it could fail because the schema that was built was always in alphabetical order. This issue was reported by @lewtu...
[]
https://api.github.com/repos/huggingface/datasets/issues/683
683
Fix wrong delimiter in text dataset
The delimiter is set to the bell character as it is used nowhere is text files usually. However in the text dataset the delimiter was set to `\b` which is backspace in python, while the bell character is `\a`. I replace \b by \a Hopefully it fixes issues mentioned by some users in #622
closed
2020-09-29T09:43:24
https://api.github.com/repos/huggingface/datasets/issues/683/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/683", "html_url": "https://github.com/huggingface/datasets/pull/683", "diff_url": "https://github.com/huggingface/datasets/pull/683.diff", "patch_url": "https://github.com/huggingface/datasets/pull/683.patch", "merged_at": null }
true
Fix wrong delimiter in text dataset The delimiter is set to the bell character as it is used nowhere is text files usually. However in the text dataset the delimiter was set to `\b` which is backspace in python, while the bell character is `\a`. I replace \b by \a Hopefully it fixes issues mentioned by some users ...
[]
https://api.github.com/repos/huggingface/datasets/issues/682
682
Update navbar chapter titles color
Consistency with the color change that was done in transformers at https://github.com/huggingface/transformers/pull/7423 It makes the background-color of the chapter titles in the docs navbar darker, to differentiate them from the inner sections. see changes [here](https://691-250213286-gh.circle-artifacts.com/0/do...
closed
2020-09-28T14:35:17
https://api.github.com/repos/huggingface/datasets/issues/682/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/682", "html_url": "https://github.com/huggingface/datasets/pull/682", "diff_url": "https://github.com/huggingface/datasets/pull/682.diff", "patch_url": "https://github.com/huggingface/datasets/pull/682.patch", "merged_at": "2020-09-28T17:30:12"...
true
Update navbar chapter titles color Consistency with the color change that was done in transformers at https://github.com/huggingface/transformers/pull/7423 It makes the background-color of the chapter titles in the docs navbar darker, to differentiate them from the inner sections. see changes [here](https://691-250...
[]
https://api.github.com/repos/huggingface/datasets/issues/681
681
Adding missing @property (+2 small flake8 fixes).
Fixes #678
closed
2020-09-28T08:53:53
https://api.github.com/repos/huggingface/datasets/issues/681/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/681", "html_url": "https://github.com/huggingface/datasets/pull/681", "diff_url": "https://github.com/huggingface/datasets/pull/681.diff", "patch_url": "https://github.com/huggingface/datasets/pull/681.patch", "merged_at": "2020-09-28T10:26:09"...
true
Adding missing @property (+2 small flake8 fixes). Fixes #678
[]
https://api.github.com/repos/huggingface/datasets/issues/680
680
Fix bug related to boolean in GAP dataset.
### Why I did The value in `row["A-coref"]` and `row["B-coref"]` is `'TRUE'` or `'FALSE'`. This type is `string`, then `bool('FALSE')` is equal to `True` in Python. So, both rows are transformed into `True` now. So, I modified this problem. ### What I did I modified `bool(row["A-coref"])` and `bool(row["B-cor...
closed
2020-09-28T08:39:39
https://api.github.com/repos/huggingface/datasets/issues/680/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/680", "html_url": "https://github.com/huggingface/datasets/pull/680", "diff_url": "https://github.com/huggingface/datasets/pull/680.diff", "patch_url": "https://github.com/huggingface/datasets/pull/680.patch", "merged_at": "2020-09-29T15:54:47"...
true
Fix bug related to boolean in GAP dataset. ### Why I did The value in `row["A-coref"]` and `row["B-coref"]` is `'TRUE'` or `'FALSE'`. This type is `string`, then `bool('FALSE')` is equal to `True` in Python. So, both rows are transformed into `True` now. So, I modified this problem. ### What I did I modified ...
[ "Hi !\r\n\r\nGood catch, thanks for creating this PR :)\r\n\r\nCould you also regenerate the metadata for this dataset using \r\n```\r\ndatasets-cli test ./datasets/gap --save_infos --all_configs\r\n```\r\n\r\nThat'd be awesome", "@lhoestq Thank you for your revieing!!!\r\n\r\nI've performed it and have read CONT...
https://api.github.com/repos/huggingface/datasets/issues/679
679
Fix negative ids when slicing with an array
```python from datasets import Dataset d = ds.Dataset.from_dict({"a": range(10)}) print(d[[0, -1]]) # OverflowError ``` raises an error because of the negative id. This PR fixes that. Fix #668
closed
2020-09-28T08:39:08
https://api.github.com/repos/huggingface/datasets/issues/679/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/679", "html_url": "https://github.com/huggingface/datasets/pull/679", "diff_url": "https://github.com/huggingface/datasets/pull/679.diff", "patch_url": "https://github.com/huggingface/datasets/pull/679.patch", "merged_at": "2020-09-28T14:42:19"...
true
Fix negative ids when slicing with an array ```python from datasets import Dataset d = ds.Dataset.from_dict({"a": range(10)}) print(d[[0, -1]]) # OverflowError ``` raises an error because of the negative id. This PR fixes that. Fix #668
[]
https://api.github.com/repos/huggingface/datasets/issues/678
678
The download instructions for c4 datasets are not contained in the error message
The manual download instructions are not clear ```The dataset c4 with config en requires manual data. Please follow the manual download instructions: <bound method C4.manual_download_instructions of <datasets_modules.datasets.c4.830b0c218bd41fed439812c8dd19dbd4767d2a3faa385eb695cf8666c982b1b3.c4.C4 object at 0x7ff...
closed
2020-09-28T08:30:54
https://api.github.com/repos/huggingface/datasets/issues/678/comments
null
false
The download instructions for c4 datasets are not contained in the error message The manual download instructions are not clear ```The dataset c4 with config en requires manual data. Please follow the manual download instructions: <bound method C4.manual_download_instructions of <datasets_modules.datasets.c4.830b0...
[ "Good catch !\r\nIndeed the `@property` is missing.\r\n\r\nFeel free to open a PR :)", "Also not that C4 is a dataset that needs an Apache Beam runtime to be generated.\r\nFor example Dataflow, Spark, Flink etc.\r\n\r\nUsually we generate the dataset on our side once and for all, but we haven't done it for C4 yet...
https://api.github.com/repos/huggingface/datasets/issues/677
677
Move cache dir root creation in builder's init
We use lock files in the builder initialization but sometimes the cache directory where they're supposed to be was not created. To fix that I moved the builder's cache dir root creation in the builder's init. Fix #671
closed
2020-09-28T08:22:46
https://api.github.com/repos/huggingface/datasets/issues/677/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/677", "html_url": "https://github.com/huggingface/datasets/pull/677", "diff_url": "https://github.com/huggingface/datasets/pull/677.diff", "patch_url": "https://github.com/huggingface/datasets/pull/677.patch", "merged_at": "2020-09-28T14:42:42"...
true
Move cache dir root creation in builder's init We use lock files in the builder initialization but sometimes the cache directory where they're supposed to be was not created. To fix that I moved the builder's cache dir root creation in the builder's init. Fix #671
[]
https://api.github.com/repos/huggingface/datasets/issues/676
676
train_test_split returns empty dataset item
I try to split my dataset by `train_test_split`, but after that the item in `train` and `test` `Dataset` is empty. The codes: ``` yelp_data = datasets.load_from_disk('/home/ssd4/huanglianzhe/test_yelp') print(yelp_data[0]) yelp_data = yelp_data.train_test_split(test_size=0.1) print(yelp_data) pri...
closed
2020-09-28T07:19:33
https://api.github.com/repos/huggingface/datasets/issues/676/comments
null
false
train_test_split returns empty dataset item I try to split my dataset by `train_test_split`, but after that the item in `train` and `test` `Dataset` is empty. The codes: ``` yelp_data = datasets.load_from_disk('/home/ssd4/huanglianzhe/test_yelp') print(yelp_data[0]) yelp_data = yelp_data.train_test_split(t...
[ "The problem still exists after removing the cache files.", "Can you reproduce this example in a Colab so we can investigate? (or give more information on your software/hardware config)", "Thanks for reporting.\r\nI just found the issue, I'm creating a PR", "We'll do a release pretty soon to include the fix :...
https://api.github.com/repos/huggingface/datasets/issues/675
675
Add custom dataset to NLP?
Is it possible to add a custom dataset such as a .csv to the NLP library? Thanks.
closed
2020-09-27T21:22:50
https://api.github.com/repos/huggingface/datasets/issues/675/comments
null
false
Add custom dataset to NLP? Is it possible to add a custom dataset such as a .csv to the NLP library? Thanks.
[ "Yes you can have a look here: https://huggingface.co/docs/datasets/loading_datasets.html#csv-files", "No activity, closing" ]
https://api.github.com/repos/huggingface/datasets/issues/674
674
load_dataset() won't download in Windows
I don't know if this is just me or Windows. Maybe other Windows users can chime in if they don't have this problem. I've been trying to get some of the tutorials working on Windows, but when I use the load_dataset() function, it just stalls and the script keeps running indefinitely without downloading anything. I've wa...
closed
2020-09-27T03:56:25
https://api.github.com/repos/huggingface/datasets/issues/674/comments
null
false
load_dataset() won't download in Windows I don't know if this is just me or Windows. Maybe other Windows users can chime in if they don't have this problem. I've been trying to get some of the tutorials working on Windows, but when I use the load_dataset() function, it just stalls and the script keeps running indefinit...
[ "I have the same issue. Tried to download a few of them and not a single one is downloaded successfully.\r\n\r\nThis is the output:\r\n```\r\n>>> dataset = load_dataset('blended_skill_talk', split='train')\r\nUsing custom data configuration default <-- This step never ends\r\n```", "This was fixed i...
https://api.github.com/repos/huggingface/datasets/issues/673
673
blog_authorship_corpus crashed
This is just to report that When I pick blog_authorship_corpus in https://huggingface.co/nlp/viewer/?dataset=blog_authorship_corpus I get this: ![image](https://user-images.githubusercontent.com/7553188/94349542-4364f300-0013-11eb-897d-b25660a449f0.png)
closed
2020-09-26T20:15:28
https://api.github.com/repos/huggingface/datasets/issues/673/comments
null
false
blog_authorship_corpus crashed This is just to report that When I pick blog_authorship_corpus in https://huggingface.co/nlp/viewer/?dataset=blog_authorship_corpus I get this: ![image](https://user-images.githubusercontent.com/7553188/94349542-4364f300-0013-11eb-897d-b25660a449f0.png)
[ "Thanks for reporting !\r\nWe'll free some memory" ]
https://api.github.com/repos/huggingface/datasets/issues/672
672
Questions about XSUM
Hi there ✋ I'm looking into your `xsum` dataset and I have several questions on that. So here is how I loaded the data: ``` >>> data = datasets.load_dataset('xsum', version='1.0.1') >>> data['train'] Dataset(features: {'document': Value(dtype='string', id=None), 'summary': Value(dtype='string', id=None)}, nu...
closed
2020-09-26T17:16:24
https://api.github.com/repos/huggingface/datasets/issues/672/comments
null
false
Questions about XSUM Hi there ✋ I'm looking into your `xsum` dataset and I have several questions on that. So here is how I loaded the data: ``` >>> data = datasets.load_dataset('xsum', version='1.0.1') >>> data['train'] Dataset(features: {'document': Value(dtype='string', id=None), 'summary': Value(dtype='...
[ "We should try to regenerate the data using the official script.\r\nBut iirc that's what we used in the first place, so not sure why it didn't match in the first place.\r\n\r\nI'll let you know when the dataset is updated", "Thanks, looking forward to hearing your update on this thread. \r\n\r\nThis is a blocking...
https://api.github.com/repos/huggingface/datasets/issues/671
671
[BUG] No such file or directory
This happens when both 1. Huggingface datasets cache dir does not exist 2. Try to load a local dataset script builder.py throws an error when trying to create a filelock in a directory (cache/datasets) that does not exist https://github.com/huggingface/datasets/blob/master/src/datasets/builder.py#L177 Tested o...
closed
2020-09-25T16:38:54
https://api.github.com/repos/huggingface/datasets/issues/671/comments
null
false
[BUG] No such file or directory This happens when both 1. Huggingface datasets cache dir does not exist 2. Try to load a local dataset script builder.py throws an error when trying to create a filelock in a directory (cache/datasets) that does not exist https://github.com/huggingface/datasets/blob/master/src/data...
[]
https://api.github.com/repos/huggingface/datasets/issues/670
670
Fix SQuAD metric kwargs description
The `answer_start` field was missing in the kwargs docstring. This should fix #657 FYI another fix was proposed by @tshrjn in #658 and suggests to remove this field. However IMO `answer_start` is useful to match the squad dataset format for consistency, even though it is not used in the metric computation. I th...
closed
2020-09-25T16:08:57
https://api.github.com/repos/huggingface/datasets/issues/670/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/670", "html_url": "https://github.com/huggingface/datasets/pull/670", "diff_url": "https://github.com/huggingface/datasets/pull/670.diff", "patch_url": "https://github.com/huggingface/datasets/pull/670.patch", "merged_at": "2020-09-29T15:57:37"...
true
Fix SQuAD metric kwargs description The `answer_start` field was missing in the kwargs docstring. This should fix #657 FYI another fix was proposed by @tshrjn in #658 and suggests to remove this field. However IMO `answer_start` is useful to match the squad dataset format for consistency, even though it is not ...
[]
https://api.github.com/repos/huggingface/datasets/issues/669
669
How to skip a example when running dataset.map
in processing func, I process examples and detect some invalid examples, which I did not want it to be added into train dataset. However I did not find how to skip this recognized invalid example when doing dataset.map.
closed
2020-09-25T11:17:53
https://api.github.com/repos/huggingface/datasets/issues/669/comments
null
false
How to skip a example when running dataset.map in processing func, I process examples and detect some invalid examples, which I did not want it to be added into train dataset. However I did not find how to skip this recognized invalid example when doing dataset.map.
[ "Hi @xixiaoyao,\r\nDepending on what you want to do you can:\r\n- use a first step of `filter` to filter out the invalid examples: https://huggingface.co/docs/datasets/processing.html#filtering-rows-select-and-filter\r\n- or directly detect the invalid examples inside the callable used with `map` and return them un...
https://api.github.com/repos/huggingface/datasets/issues/668
668
OverflowError when slicing with an array containing negative ids
```python from datasets import Dataset d = ds.Dataset.from_dict({"a": range(10)}) print(d[0]) # {'a': 0} print(d[-1]) # {'a': 9} print(d[[0, -1]]) # OverflowError ``` results in ``` --------------------------------------------------------------------------- OverflowError ...
closed
2020-09-24T16:27:14
https://api.github.com/repos/huggingface/datasets/issues/668/comments
null
false
OverflowError when slicing with an array containing negative ids ```python from datasets import Dataset d = ds.Dataset.from_dict({"a": range(10)}) print(d[0]) # {'a': 0} print(d[-1]) # {'a': 9} print(d[[0, -1]]) # OverflowError ``` results in ``` -----------------------------------------------------...
[]
https://api.github.com/repos/huggingface/datasets/issues/667
667
Loss not decrease with Datasets and Transformers
HI, The following script is used to fine-tune a BertForSequenceClassification model on SST2. The script is adapted from [this colab](https://colab.research.google.com/github/huggingface/datasets/blob/master/notebooks/Overview.ipynb) that presents an example of fine-tuning BertForQuestionAnswering using squad data...
closed
2020-09-24T15:14:43
https://api.github.com/repos/huggingface/datasets/issues/667/comments
null
false
Loss not decrease with Datasets and Transformers HI, The following script is used to fine-tune a BertForSequenceClassification model on SST2. The script is adapted from [this colab](https://colab.research.google.com/github/huggingface/datasets/blob/master/notebooks/Overview.ipynb) that presents an example of fine...
[ "And I tested it on T5ForConditionalGeneration, that works no problem.", "Hi did you manage to fix your issue ?\r\n\r\nIf so feel free to share your fix and close this thread" ]
https://api.github.com/repos/huggingface/datasets/issues/666
666
Does both 'bookcorpus' and 'wikipedia' belong to the same datasets which Google used for pretraining BERT?
closed
2020-09-23T19:02:25
https://api.github.com/repos/huggingface/datasets/issues/666/comments
null
false
Does both 'bookcorpus' and 'wikipedia' belong to the same datasets which Google used for pretraining BERT?
[ "No they are other similar copies but they are not provided by the official Bert models authors." ]
https://api.github.com/repos/huggingface/datasets/issues/665
665
runing dataset.map, it raises TypeError: can't pickle Tokenizer objects
I load squad dataset. Then want to process data use following function with `Huggingface Transformers LongformerTokenizer`. ``` def convert_to_features(example): # Tokenize contexts and questions (as pairs of inputs) input_pairs = [example['question'], example['context']] encodings = tokenizer.encode...
closed
2020-09-23T04:28:14
https://api.github.com/repos/huggingface/datasets/issues/665/comments
null
false
runing dataset.map, it raises TypeError: can't pickle Tokenizer objects I load squad dataset. Then want to process data use following function with `Huggingface Transformers LongformerTokenizer`. ``` def convert_to_features(example): # Tokenize contexts and questions (as pairs of inputs) input_pairs = [ex...
[ "Hi !\r\nIt works on my side with both the LongFormerTokenizer and the LongFormerTokenizerFast.\r\n\r\nWhich version of transformers/datasets are you using ?", "transformers and datasets are both the latest", "Then I guess you need to give us more informations on your setup (OS, python, GPU, etc) or a Google Co...
https://api.github.com/repos/huggingface/datasets/issues/664
664
load_dataset from local squad.py, raise error: TypeError: 'NoneType' object is not callable
version: 1.0.2 ``` train_dataset = datasets.load_dataset('squad') ``` The above code can works. However, when I download the squad.py from your server, and saved as `my_squad.py` to local. I run followings raise errors. ``` train_dataset = datasets.load_dataset('./my_squad.py') ...
closed
2020-09-23T03:53:36
https://api.github.com/repos/huggingface/datasets/issues/664/comments
null
false
load_dataset from local squad.py, raise error: TypeError: 'NoneType' object is not callable version: 1.0.2 ``` train_dataset = datasets.load_dataset('squad') ``` The above code can works. However, when I download the squad.py from your server, and saved as `my_squad.py` to local. I run followings raise err...
[ "Hi !\r\nThanks for reporting.\r\nIt looks like no object inherits from `datasets.GeneratorBasedBuilder` (or more generally from `datasets.DatasetBuilder`) in your script.\r\n\r\nCould you check that there exist at least one dataset builder class ?", "Hi @xixiaoyao did you manage to fix your issue ?", "No activ...
https://api.github.com/repos/huggingface/datasets/issues/663
663
Created dataset card snli.md
First draft of a dataset card using the SNLI corpus as an example. This is mostly based on the [Google Doc draft](https://docs.google.com/document/d/1dKPGP-dA2W0QoTRGfqQ5eBp0CeSsTy7g2yM8RseHtos/edit), but I added a few sections and moved some things around. - I moved **Who Was Involved** to follow **Language**, ...
closed
2020-09-22T22:29:37
https://api.github.com/repos/huggingface/datasets/issues/663/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/663", "html_url": "https://github.com/huggingface/datasets/pull/663", "diff_url": "https://github.com/huggingface/datasets/pull/663.diff", "patch_url": "https://github.com/huggingface/datasets/pull/663.patch", "merged_at": "2020-10-12T20:26:52"...
true
Created dataset card snli.md First draft of a dataset card using the SNLI corpus as an example. This is mostly based on the [Google Doc draft](https://docs.google.com/document/d/1dKPGP-dA2W0QoTRGfqQ5eBp0CeSsTy7g2yM8RseHtos/edit), but I added a few sections and moved some things around. - I moved **Who Was Involv...
[ "Adding a direct link to the rendered markdown:\r\nhttps://github.com/mcmillanmajora/datasets/blob/add_dataset_documentation/datasets/snli/README.md\r\n", "It would be amazing if we ended up with this much information on all of our datasets :) \r\n\r\nI don't think there's too much repetition, everything that is ...
https://api.github.com/repos/huggingface/datasets/issues/662
662
Created dataset card snli.md
First draft of a dataset card using the SNLI corpus as an example
closed
2020-09-22T21:00:17
https://api.github.com/repos/huggingface/datasets/issues/662/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/662", "html_url": "https://github.com/huggingface/datasets/pull/662", "diff_url": "https://github.com/huggingface/datasets/pull/662.diff", "patch_url": "https://github.com/huggingface/datasets/pull/662.patch", "merged_at": null }
true
Created dataset card snli.md First draft of a dataset card using the SNLI corpus as an example
[ "Resubmitting on a new fork" ]
https://api.github.com/repos/huggingface/datasets/issues/661
661
Replace pa.OSFile by open
It should fix #643
closed
2020-09-22T15:05:59
https://api.github.com/repos/huggingface/datasets/issues/661/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/661", "html_url": "https://github.com/huggingface/datasets/pull/661", "diff_url": "https://github.com/huggingface/datasets/pull/661.diff", "patch_url": "https://github.com/huggingface/datasets/pull/661.patch", "merged_at": null }
true
Replace pa.OSFile by open It should fix #643
[]
https://api.github.com/repos/huggingface/datasets/issues/660
660
add openwebtext
This adds [The OpenWebText Corpus](https://skylion007.github.io/OpenWebTextCorpus/), which is a clean and large text corpus for nlp pretraining. It is an open source effort to reproduce OpenAI’s WebText dataset used by GPT-2, and it is also needed to reproduce ELECTRA. It solves #132 . ### Besides dataset buildin...
closed
2020-09-22T12:05:22
https://api.github.com/repos/huggingface/datasets/issues/660/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/660", "html_url": "https://github.com/huggingface/datasets/pull/660", "diff_url": "https://github.com/huggingface/datasets/pull/660.diff", "patch_url": "https://github.com/huggingface/datasets/pull/660.patch", "merged_at": "2020-09-28T09:07:26"...
true
add openwebtext This adds [The OpenWebText Corpus](https://skylion007.github.io/OpenWebTextCorpus/), which is a clean and large text corpus for nlp pretraining. It is an open source effort to reproduce OpenAI’s WebText dataset used by GPT-2, and it is also needed to reproduce ELECTRA. It solves #132 . ### Besides...
[ "BTW, is there a one-line command to make our building scripts pass flake8 test? (included code quality test), I got like trailing space or mixed space and tab warning and error, and fixed them manually.", "> BTW, is there a one-line command to make our building scripts pass flake8 test? (included code quality te...
https://api.github.com/repos/huggingface/datasets/issues/659
659
Keep new columns in transmit format
When a dataset is formatted with a list of columns that `__getitem__` should return, then calling `map` to add new columns doesn't add the new columns to this list. It caused `KeyError` issues in #620 I changed the logic to add those new columns to the list that `__getitem__` should return.
closed
2020-09-22T09:47:23
https://api.github.com/repos/huggingface/datasets/issues/659/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/659", "html_url": "https://github.com/huggingface/datasets/pull/659", "diff_url": "https://github.com/huggingface/datasets/pull/659.diff", "patch_url": "https://github.com/huggingface/datasets/pull/659.patch", "merged_at": "2020-09-22T10:07:20"...
true
Keep new columns in transmit format When a dataset is formatted with a list of columns that `__getitem__` should return, then calling `map` to add new columns doesn't add the new columns to this list. It caused `KeyError` issues in #620 I changed the logic to add those new columns to the list that `__getitem__`...
[]
https://api.github.com/repos/huggingface/datasets/issues/658
658
Fix squad metric's Features
Resolves issue [657](https://github.com/huggingface/datasets/issues/657).
closed
2020-09-22T09:09:52
https://api.github.com/repos/huggingface/datasets/issues/658/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/658", "html_url": "https://github.com/huggingface/datasets/pull/658", "diff_url": "https://github.com/huggingface/datasets/pull/658.diff", "patch_url": "https://github.com/huggingface/datasets/pull/658.patch", "merged_at": null }
true
Fix squad metric's Features Resolves issue [657](https://github.com/huggingface/datasets/issues/657).
[ "Closing this one in favor of #670 \r\n\r\nThanks again for reporting the issue and proposing this fix !\r\nLet me know if you have other remarks" ]
https://api.github.com/repos/huggingface/datasets/issues/657
657
Squad Metric Description & Feature Mismatch
The [description](https://github.com/huggingface/datasets/blob/master/metrics/squad/squad.py#L39) doesn't mention `answer_start` in squad. However the `datasets.features` require [it](https://github.com/huggingface/datasets/blob/master/metrics/squad/squad.py#L68). It's also not used in the evaluation.
closed
2020-09-22T09:07:00
https://api.github.com/repos/huggingface/datasets/issues/657/comments
null
false
Squad Metric Description & Feature Mismatch The [description](https://github.com/huggingface/datasets/blob/master/metrics/squad/squad.py#L39) doesn't mention `answer_start` in squad. However the `datasets.features` require [it](https://github.com/huggingface/datasets/blob/master/metrics/squad/squad.py#L68). It's also n...
[ "Thanks for reporting !\r\nThere indeed a mismatch between the features and the kwargs description\r\n\r\nI believe `answer_start` was added to match the squad dataset format for consistency, even though it is not used in the metric computation. I think I'd rather keep it this way, so that you can just give `refere...
https://api.github.com/repos/huggingface/datasets/issues/656
656
Use multiprocess from pathos for multiprocessing
[Multiprocess](https://github.com/uqfoundation/multiprocess) (from the [pathos](https://github.com/uqfoundation/pathos) project) allows to use lambda functions in multiprocessed map. It was suggested to use it by @kandorm. We're already using dill which is its only dependency.
closed
2020-09-21T16:12:19
https://api.github.com/repos/huggingface/datasets/issues/656/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/656", "html_url": "https://github.com/huggingface/datasets/pull/656", "diff_url": "https://github.com/huggingface/datasets/pull/656.diff", "patch_url": "https://github.com/huggingface/datasets/pull/656.patch", "merged_at": "2020-09-28T14:45:39"...
true
Use multiprocess from pathos for multiprocessing [Multiprocess](https://github.com/uqfoundation/multiprocess) (from the [pathos](https://github.com/uqfoundation/pathos) project) allows to use lambda functions in multiprocessed map. It was suggested to use it by @kandorm. We're already using dill which is its only d...
[ "We can just install multiprocess actually, I'll change that", "Just an FYI: I remember that I wanted to try pathos a couple of years back and I ran into issues considering cross-platform; the code would just break on Windows. If I can verify this PR by running CPU tests on Windows, let me know!", "That's good ...
https://api.github.com/repos/huggingface/datasets/issues/655
655
added Winogrande debiased subset
The [Winogrande](https://arxiv.org/abs/1907.10641) paper mentions a `debiased` subset that wasn't in the first release; this PR adds it.
closed
2020-09-21T14:51:08
https://api.github.com/repos/huggingface/datasets/issues/655/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/655", "html_url": "https://github.com/huggingface/datasets/pull/655", "diff_url": "https://github.com/huggingface/datasets/pull/655.diff", "patch_url": "https://github.com/huggingface/datasets/pull/655.patch", "merged_at": "2020-09-21T16:16:04"...
true
added Winogrande debiased subset The [Winogrande](https://arxiv.org/abs/1907.10641) paper mentions a `debiased` subset that wasn't in the first release; this PR adds it.
[ "To fix the CI you just have to copy the dummy data to the 1.1.0 folder, and maybe create the dummy ones for the `debiased` configuration", "Fixed! Thanks @lhoestq " ]
https://api.github.com/repos/huggingface/datasets/issues/654
654
Allow empty inputs in metrics
There was an arrow error when trying to compute a metric with empty inputs. The error was occurring when reading the arrow file, before calling metric._compute.
closed
2020-09-21T11:26:36
https://api.github.com/repos/huggingface/datasets/issues/654/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/654", "html_url": "https://github.com/huggingface/datasets/pull/654", "diff_url": "https://github.com/huggingface/datasets/pull/654.diff", "patch_url": "https://github.com/huggingface/datasets/pull/654.patch", "merged_at": "2020-09-21T16:13:38"...
true
Allow empty inputs in metrics There was an arrow error when trying to compute a metric with empty inputs. The error was occurring when reading the arrow file, before calling metric._compute.
[]
https://api.github.com/repos/huggingface/datasets/issues/653
653
handle data alteration when trying type
Fix #649 The bug came from the type inference that didn't handle a weird case in Pyarrow. Indeed this code runs without error but alters the data in arrow: ```python import pyarrow as pa type = pa.struct({"a": pa.struct({"b": pa.string()})}) array_with_altered_data = pa.array([{"a": {"b": "foo", "c": "bar"}}...
closed
2020-09-21T10:41:49
https://api.github.com/repos/huggingface/datasets/issues/653/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/653", "html_url": "https://github.com/huggingface/datasets/pull/653", "diff_url": "https://github.com/huggingface/datasets/pull/653.diff", "patch_url": "https://github.com/huggingface/datasets/pull/653.patch", "merged_at": "2020-09-21T16:13:05"...
true
handle data alteration when trying type Fix #649 The bug came from the type inference that didn't handle a weird case in Pyarrow. Indeed this code runs without error but alters the data in arrow: ```python import pyarrow as pa type = pa.struct({"a": pa.struct({"b": pa.string()})}) array_with_altered_data = p...
[]
https://api.github.com/repos/huggingface/datasets/issues/652
652
handle connection error in download_prepared_from_hf_gcs
Fix #647
closed
2020-09-21T08:21:11
https://api.github.com/repos/huggingface/datasets/issues/652/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/652", "html_url": "https://github.com/huggingface/datasets/pull/652", "diff_url": "https://github.com/huggingface/datasets/pull/652.diff", "patch_url": "https://github.com/huggingface/datasets/pull/652.patch", "merged_at": "2020-09-21T08:28:42"...
true
handle connection error in download_prepared_from_hf_gcs Fix #647
[]
https://api.github.com/repos/huggingface/datasets/issues/651
651
Problem with JSON dataset format
I have a local json dataset with the following form. { 'id01234': {'key1': value1, 'key2': value2, 'key3': value3}, 'id01235': {'key1': value1, 'key2': value2, 'key3': value3}, . . . 'id09999': {'key1': value1, 'key2': value2, 'key3': value3} } Note that instead of a list of records i...
open
2020-09-20T23:57:14
https://api.github.com/repos/huggingface/datasets/issues/651/comments
null
false
Problem with JSON dataset format I have a local json dataset with the following form. { 'id01234': {'key1': value1, 'key2': value2, 'key3': value3}, 'id01235': {'key1': value1, 'key2': value2, 'key3': value3}, . . . 'id09999': {'key1': value1, 'key2': value2, 'key3': value3} } Note th...
[ "Currently the `json` dataset doesn't support this format unfortunately.\r\nHowever you could load it with\r\n```python\r\nfrom datasets import Dataset\r\nimport pandas as pd\r\n\r\ndf = pd.read_json(\"path_to_local.json\", orient=\"index\")\r\ndataset = Dataset.from_pandas(df)\r\n```", "or you can make a custom ...
https://api.github.com/repos/huggingface/datasets/issues/650
650
dummy data testing can't test datasets using `dl_manager.extract` in `_split_generators`
Hi, I recently want to add a dataset whose source data is like this ``` openwebtext.tar.xz |__ openwebtext |__subset000.xz | |__ ....txt | |__ ....txt | ... |__ subset001.xz | .... ``` So I wrote `openwebtext.py` like this ``` d...
closed
2020-09-19T11:07:03
https://api.github.com/repos/huggingface/datasets/issues/650/comments
null
false
dummy data testing can't test datasets using `dl_manager.extract` in `_split_generators` Hi, I recently want to add a dataset whose source data is like this ``` openwebtext.tar.xz |__ openwebtext |__subset000.xz | |__ ....txt | |__ ....txt | ... |__ sub...
[ "Hi :) \r\nIn your dummy data zip file you can just have `subset000.xz` as directories instead of compressed files.\r\nLet me know if it helps", "Thanks for your comment @lhoestq ,\r\nJust for confirmation, changing dummy data like this won't make dummy test test the functionality to extract `subsetxxx.xz` but ac...
https://api.github.com/repos/huggingface/datasets/issues/649
649
Inconsistent behavior in map
I'm observing inconsistent behavior when applying .map(). This happens specifically when I'm incrementally adding onto a feature that is a nested dictionary. Here's a simple example that reproduces the problem. ```python import datasets # Dataset with a single feature called 'field' consisting of two examples d...
closed
2020-09-19T08:41:12
https://api.github.com/repos/huggingface/datasets/issues/649/comments
null
false
Inconsistent behavior in map I'm observing inconsistent behavior when applying .map(). This happens specifically when I'm incrementally adding onto a feature that is a nested dictionary. Here's a simple example that reproduces the problem. ```python import datasets # Dataset with a single feature called 'field' ...
[ "Thanks for reporting !\r\n\r\nThis issue must have appeared when we refactored type inference in `nlp`\r\nBy default the library tries to keep the same feature types when applying `map` but apparently it has troubles with nested structures. I'll try to fix that next week" ]
https://api.github.com/repos/huggingface/datasets/issues/648
648
offset overflow when multiprocessing batched map on large datasets.
It only happened when "multiprocessing" + "batched" + "large dataset" at the same time. ``` def bprocess(examples): examples['len'] = [] for text in examples['text']: examples['len'].append(len(text)) return examples wiki.map(brpocess, batched=True, num_proc=8) ``` ``` ----------------------------...
closed
2020-09-19T02:15:11
https://api.github.com/repos/huggingface/datasets/issues/648/comments
null
false
offset overflow when multiprocessing batched map on large datasets. It only happened when "multiprocessing" + "batched" + "large dataset" at the same time. ``` def bprocess(examples): examples['len'] = [] for text in examples['text']: examples['len'].append(len(text)) return examples wiki.map(brpoces...
[ "This should be fixed with #645 ", "Feel free to re-open if it still occurs", "This has just happened to me while working with a large (65GB) Parquet dataset.\n```\n[rank0]: Traceback (most recent call last):\n[rank0]: File \"/app/LLaMA-Factory/src/llamafactory/launcher.py\", line 23, in <module>\n[rank0]: ...
https://api.github.com/repos/huggingface/datasets/issues/647
647
Cannot download dataset_info.json
I am running my job on a cloud server where does not provide for connections from the standard compute nodes to outside resources. Hence, when I use `dataset.load_dataset()` to load data, I got an error like this: ``` ConnectionError: Couldn't reach https://storage.googleapis.com/huggingface-nlp/cache/datasets/text...
closed
2020-09-19T01:35:15
https://api.github.com/repos/huggingface/datasets/issues/647/comments
null
false
Cannot download dataset_info.json I am running my job on a cloud server where does not provide for connections from the standard compute nodes to outside resources. Hence, when I use `dataset.load_dataset()` to load data, I got an error like this: ``` ConnectionError: Couldn't reach https://storage.googleapis.com/h...
[ "Thanks for reporting !\r\nWe should add support for servers without internet connection indeed\r\nI'll do that early next week", "Thanks, @lhoestq !\r\nPlease let me know when it is available. ", "Right now the recommended way is to create the dataset on a server with internet connection and then to save it an...
https://api.github.com/repos/huggingface/datasets/issues/646
646
Fix docs typos
This PR fixes few typos in the docs and the error in the code snippet in the set_format section in docs/source/torch_tensorflow.rst. `torch.utils.data.Dataloader` expects padded batches so it throws an error due to not being able to stack the unpadded tensors. If we follow the Quick tour from the docs where they add th...
closed
2020-09-18T19:32:27
https://api.github.com/repos/huggingface/datasets/issues/646/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/646", "html_url": "https://github.com/huggingface/datasets/pull/646", "diff_url": "https://github.com/huggingface/datasets/pull/646.diff", "patch_url": "https://github.com/huggingface/datasets/pull/646.patch", "merged_at": "2020-09-21T16:14:12"...
true
Fix docs typos This PR fixes few typos in the docs and the error in the code snippet in the set_format section in docs/source/torch_tensorflow.rst. `torch.utils.data.Dataloader` expects padded batches so it throws an error due to not being able to stack the unpadded tensors. If we follow the Quick tour from the docs wh...
[]
https://api.github.com/repos/huggingface/datasets/issues/645
645
Don't use take on dataset table in pyarrow 1.0.x
Fix #615
closed
2020-09-18T17:31:34
https://api.github.com/repos/huggingface/datasets/issues/645/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/645", "html_url": "https://github.com/huggingface/datasets/pull/645", "diff_url": "https://github.com/huggingface/datasets/pull/645.diff", "patch_url": "https://github.com/huggingface/datasets/pull/645.patch", "merged_at": "2020-09-19T16:46:31"...
true
Don't use take on dataset table in pyarrow 1.0.x Fix #615
[ "I tried lower batch sizes and it didn't accelerate filter (quite the opposite actually).\r\nThe slow-down also appears for pyarrow 0.17.1 for some reason, not sure it comes from these changes", "I just checked the benchmarks of other PRs and some of them had 300s (!!) for filter. This needs some investigation.."...
https://api.github.com/repos/huggingface/datasets/issues/644
644
Better windows support
There are a few differences in the behavior of python and pyarrow on windows. For example there are restrictions when accessing/deleting files that are open Fix #590
closed
2020-09-18T17:17:36
https://api.github.com/repos/huggingface/datasets/issues/644/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/644", "html_url": "https://github.com/huggingface/datasets/pull/644", "diff_url": "https://github.com/huggingface/datasets/pull/644.diff", "patch_url": "https://github.com/huggingface/datasets/pull/644.patch", "merged_at": "2020-09-25T14:02:28"...
true
Better windows support There are a few differences in the behavior of python and pyarrow on windows. For example there are restrictions when accessing/deleting files that are open Fix #590
[ "This PR is ready :)\r\nIt brings official support for windows.\r\n\r\nSome tests `AWSDatasetTest` are failing.\r\nThis is because I had to fix a few datasets that were not compatible with windows.\r\nThese test will pass once they got merged on master :)" ]
https://api.github.com/repos/huggingface/datasets/issues/643
643
Caching processed dataset at wrong folder
Hi guys, I run this on my Colab (PRO): ```python from datasets import load_dataset dataset = load_dataset('text', data_files='/content/corpus.txt', cache_dir='/content/drive/My Drive', split='train') def encode(examples): return tokenizer(examples['text'], truncation=True, padding='max_length') dataset = ...
closed
2020-09-18T15:41:26
https://api.github.com/repos/huggingface/datasets/issues/643/comments
null
false
Caching processed dataset at wrong folder Hi guys, I run this on my Colab (PRO): ```python from datasets import load_dataset dataset = load_dataset('text', data_files='/content/corpus.txt', cache_dir='/content/drive/My Drive', split='train') def encode(examples): return tokenizer(examples['text'], truncation...
[ "Thanks for reporting !\r\nIt uses a temporary file to write the data.\r\nHowever it looks like the temporary file is not placed in the right directory during the processing", "Well actually I just tested and the temporary file is placed in the same directory, so it should work as expected.\r\nWhich version of `d...
https://api.github.com/repos/huggingface/datasets/issues/642
642
Rename wnut fields
As mentioned in #641 it would be cool to have it follow the naming of the other NER datasets
closed
2020-09-18T13:51:31
https://api.github.com/repos/huggingface/datasets/issues/642/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/642", "html_url": "https://github.com/huggingface/datasets/pull/642", "diff_url": "https://github.com/huggingface/datasets/pull/642.diff", "patch_url": "https://github.com/huggingface/datasets/pull/642.patch", "merged_at": "2020-09-18T17:18:30"...
true
Rename wnut fields As mentioned in #641 it would be cool to have it follow the naming of the other NER datasets
[]
https://api.github.com/repos/huggingface/datasets/issues/641
641
Add Polyglot-NER Dataset
Adds the [Polyglot-NER dataset](https://sites.google.com/site/rmyeid/projects/polylgot-ner) with named entity tags for 40 languages. I include separate configs for each language as well as a `combined` config which lumps them all together.
closed
2020-09-18T13:21:44
https://api.github.com/repos/huggingface/datasets/issues/641/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/641", "html_url": "https://github.com/huggingface/datasets/pull/641", "diff_url": "https://github.com/huggingface/datasets/pull/641.diff", "patch_url": "https://github.com/huggingface/datasets/pull/641.patch", "merged_at": "2020-09-20T03:04:43"...
true
Add Polyglot-NER Dataset Adds the [Polyglot-NER dataset](https://sites.google.com/site/rmyeid/projects/polylgot-ner) with named entity tags for 40 languages. I include separate configs for each language as well as a `combined` config which lumps them all together.
[ "Hi @joeddav thanks for adding this! (I did a long webarchive.org session to actually find that dataset a while ago).\r\n\r\nOne question: should we manually correct the labeling scheme to (at least) IOB1?\r\n\r\nThat means \"LOC\" will be converted to \"I-LOC\". IOB1 is not explict. mentioned in the paper, but it ...
https://api.github.com/repos/huggingface/datasets/issues/640
640
Make shuffle compatible with temp_seed
This code used to return different dataset at each run ```python import dataset as ds dataset = ... with ds.temp_seed(42): shuffled = dataset.shuffle() ``` Now it returns the same one since the seed is set
closed
2020-09-18T11:38:58
https://api.github.com/repos/huggingface/datasets/issues/640/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/640", "html_url": "https://github.com/huggingface/datasets/pull/640", "diff_url": "https://github.com/huggingface/datasets/pull/640.diff", "patch_url": "https://github.com/huggingface/datasets/pull/640.patch", "merged_at": "2020-09-18T11:47:50"...
true
Make shuffle compatible with temp_seed This code used to return different dataset at each run ```python import dataset as ds dataset = ... with ds.temp_seed(42): shuffled = dataset.shuffle() ``` Now it returns the same one since the seed is set
[]
https://api.github.com/repos/huggingface/datasets/issues/639
639
Update glue QQP checksum
Fix #638
closed
2020-09-18T09:08:15
https://api.github.com/repos/huggingface/datasets/issues/639/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/639", "html_url": "https://github.com/huggingface/datasets/pull/639", "diff_url": "https://github.com/huggingface/datasets/pull/639.diff", "patch_url": "https://github.com/huggingface/datasets/pull/639.patch", "merged_at": "2020-09-18T11:37:07"...
true
Update glue QQP checksum Fix #638
[]
https://api.github.com/repos/huggingface/datasets/issues/638
638
GLUE/QQP dataset: NonMatchingChecksumError
Hi @lhoestq , I know you are busy and there are also other important issues. But if this is easy to be fixed, I am shamelessly wondering if you can give me some help , so I can evaluate my models and restart with my developing cycle asap. 😚 datasets version: editable install of master at 9/17 `datasets.load_data...
closed
2020-09-18T07:09:10
https://api.github.com/repos/huggingface/datasets/issues/638/comments
null
false
GLUE/QQP dataset: NonMatchingChecksumError Hi @lhoestq , I know you are busy and there are also other important issues. But if this is easy to be fixed, I am shamelessly wondering if you can give me some help , so I can evaluate my models and restart with my developing cycle asap. 😚 datasets version: editable insta...
[ "Hi ! Sure I'll take a look" ]
https://api.github.com/repos/huggingface/datasets/issues/637
637
Add MATINF
closed
2020-09-17T12:24:53
https://api.github.com/repos/huggingface/datasets/issues/637/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/637", "html_url": "https://github.com/huggingface/datasets/pull/637", "diff_url": "https://github.com/huggingface/datasets/pull/637.diff", "patch_url": "https://github.com/huggingface/datasets/pull/637.patch", "merged_at": "2020-09-17T13:23:17"...
true
Add MATINF
[]
https://api.github.com/repos/huggingface/datasets/issues/636
636
Consistent ner features
As discussed in #613 , this PR aims at making NER feature names consistent across datasets. I changed the feature names of LinCE and XTREME/PAN-X
closed
2020-09-16T15:56:25
https://api.github.com/repos/huggingface/datasets/issues/636/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/636", "html_url": "https://github.com/huggingface/datasets/pull/636", "diff_url": "https://github.com/huggingface/datasets/pull/636.diff", "patch_url": "https://github.com/huggingface/datasets/pull/636.patch", "merged_at": "2020-09-17T09:52:58"...
true
Consistent ner features As discussed in #613 , this PR aims at making NER feature names consistent across datasets. I changed the feature names of LinCE and XTREME/PAN-X
[]
https://api.github.com/repos/huggingface/datasets/issues/635
635
Loglevel
Continuation of #618
closed
2020-09-16T14:37:53
https://api.github.com/repos/huggingface/datasets/issues/635/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/635", "html_url": "https://github.com/huggingface/datasets/pull/635", "diff_url": "https://github.com/huggingface/datasets/pull/635.diff", "patch_url": "https://github.com/huggingface/datasets/pull/635.patch", "merged_at": "2020-09-17T09:52:18"...
true
Loglevel Continuation of #618
[ "I think it's ready now @stas00, did you want to add something else ?\r\nThis PR includes your changes but with the level set to warning", "LGTM, thank you, @lhoestq " ]
https://api.github.com/repos/huggingface/datasets/issues/634
634
Add ConLL-2000 dataset
Adds ConLL-2000 dataset used for text chunking. See https://www.clips.uantwerpen.be/conll2000/chunking/ for details and [motivation](https://github.com/huggingface/transformers/pull/7041#issuecomment-692710948) behind this PR
closed
2020-09-16T11:14:11
https://api.github.com/repos/huggingface/datasets/issues/634/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/634", "html_url": "https://github.com/huggingface/datasets/pull/634", "diff_url": "https://github.com/huggingface/datasets/pull/634.diff", "patch_url": "https://github.com/huggingface/datasets/pull/634.patch", "merged_at": "2020-09-17T10:38:10"...
true
Add ConLL-2000 dataset Adds ConLL-2000 dataset used for text chunking. See https://www.clips.uantwerpen.be/conll2000/chunking/ for details and [motivation](https://github.com/huggingface/transformers/pull/7041#issuecomment-692710948) behind this PR
[]
https://api.github.com/repos/huggingface/datasets/issues/633
633
Load large text file for LM pre-training resulting in OOM
I tried to pretrain Longformer using transformers and datasets. But I got OOM issues with loading a large text file. My script is almost like this: ```python from datasets import load_dataset @dataclass class DataCollatorForDatasetsLanguageModeling(DataCollatorForLanguageModeling): """ Data collator u...
open
2020-09-16T04:33:15
https://api.github.com/repos/huggingface/datasets/issues/633/comments
null
false
Load large text file for LM pre-training resulting in OOM I tried to pretrain Longformer using transformers and datasets. But I got OOM issues with loading a large text file. My script is almost like this: ```python from datasets import load_dataset @dataclass class DataCollatorForDatasetsLanguageModeling(DataC...
[ "Not sure what could cause that on the `datasets` side. Could this be a `Trainer` issue ? cc @julien-c @sgugger ?", "There was a memory leak issue fixed recently in master. You should install from source and see if it fixes your problem.", "@lhoestq @sgugger Thanks for your comments. I have install from source ...
https://api.github.com/repos/huggingface/datasets/issues/632
632
Fix typos in the loading datasets docs
This PR fixes two typos in the loading datasets docs, one of them being a broken link to the `load_dataset` function.
closed
2020-09-16T00:27:41
https://api.github.com/repos/huggingface/datasets/issues/632/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/632", "html_url": "https://github.com/huggingface/datasets/pull/632", "diff_url": "https://github.com/huggingface/datasets/pull/632.diff", "patch_url": "https://github.com/huggingface/datasets/pull/632.patch", "merged_at": "2020-09-16T06:52:44"...
true
Fix typos in the loading datasets docs This PR fixes two typos in the loading datasets docs, one of them being a broken link to the `load_dataset` function.
[ "thanks!" ]
https://api.github.com/repos/huggingface/datasets/issues/631
631
Fix text delimiter
I changed the delimiter in the `text` dataset script. It should fix the `pyarrow.lib.ArrowInvalid: CSV parse error` from #622 I changed the delimiter to an unused ascii character that is not present in text files : `\b`
closed
2020-09-15T08:08:42
https://api.github.com/repos/huggingface/datasets/issues/631/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/631", "html_url": "https://github.com/huggingface/datasets/pull/631", "diff_url": "https://github.com/huggingface/datasets/pull/631.diff", "patch_url": "https://github.com/huggingface/datasets/pull/631.patch", "merged_at": "2020-09-15T08:26:25"...
true
Fix text delimiter I changed the delimiter in the `text` dataset script. It should fix the `pyarrow.lib.ArrowInvalid: CSV parse error` from #622 I changed the delimiter to an unused ascii character that is not present in text files : `\b`
[ "Which OS are you using ?@abhi1nandy2", "> Which OS are you using ?\r\n\r\nPRETTY_NAME=\"Debian GNU/Linux 9 (stretch)\"\r\nNAME=\"Debian GNU/Linux\"\r\nVERSION_ID=\"9\"\r\nVERSION=\"9 (stretch)\"\r\nVERSION_CODENAME=stretch\r\nID=debian\r\nHOME_URL=\"https://www.debian.org/\"\r\nSUPPORT_URL=\"https://www.debian.o...
https://api.github.com/repos/huggingface/datasets/issues/630
630
Text dataset not working with large files
``` Traceback (most recent call last): File "examples/language-modeling/run_language_modeling.py", line 333, in <module> main() File "examples/language-modeling/run_language_modeling.py", line 262, in main get_dataset(data_args, tokenizer=tokenizer, cache_dir=model_args.cache_dir) if training_args.do_t...
closed
2020-09-15T06:02:36
https://api.github.com/repos/huggingface/datasets/issues/630/comments
null
false
Text dataset not working with large files ``` Traceback (most recent call last): File "examples/language-modeling/run_language_modeling.py", line 333, in <module> main() File "examples/language-modeling/run_language_modeling.py", line 262, in main get_dataset(data_args, tokenizer=tokenizer, cache_dir=m...
[ "Seems like it works when setting ```block_size=2100000000``` or something arbitrarily large though.", "Can you give us some stats on the data files you use as inputs?", "Basically ~600MB txt files(UTF-8) * 59. \r\ncontents like ```안녕하세요, 이것은 예제로 한번 말해보는 텍스트입니다. 그냥 이렇다고요.<|endoftext|>\\n```\r\n\r\nAlso, it gets...
https://api.github.com/repos/huggingface/datasets/issues/629
629
straddling object straddles two block boundaries
I am trying to read json data (it's an array with lots of dictionaries) and getting block boundaries issue as below : I tried calling read_json with readOptions but no luck . ``` table = json.read_json(fn) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "pyarrow/_json.pyx", li...
closed
2020-09-15T00:30:46
https://api.github.com/repos/huggingface/datasets/issues/629/comments
null
false
straddling object straddles two block boundaries I am trying to read json data (it's an array with lots of dictionaries) and getting block boundaries issue as below : I tried calling read_json with readOptions but no luck . ``` table = json.read_json(fn) Traceback (most recent call last): File "<stdin>", li...
[ "sorry it's an apache arrow issue." ]
https://api.github.com/repos/huggingface/datasets/issues/628
628
Update docs links in the contribution guideline
Fixed the `add a dataset` and `share a dataset` links in the contribution guideline to refer to the new docs website.
closed
2020-09-14T23:27:19
https://api.github.com/repos/huggingface/datasets/issues/628/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/628", "html_url": "https://github.com/huggingface/datasets/pull/628", "diff_url": "https://github.com/huggingface/datasets/pull/628.diff", "patch_url": "https://github.com/huggingface/datasets/pull/628.patch", "merged_at": "2020-09-15T06:19:35"...
true
Update docs links in the contribution guideline Fixed the `add a dataset` and `share a dataset` links in the contribution guideline to refer to the new docs website.
[ "Thanks!" ]
https://api.github.com/repos/huggingface/datasets/issues/627
627
fix (#619) MLQA features names
Fixed the features names as suggested in (#619) in the `_generate_examples` and `_info` methods in the MLQA loading script and also changed the names in the `dataset_infos.json` file.
closed
2020-09-14T20:41:59
https://api.github.com/repos/huggingface/datasets/issues/627/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/627", "html_url": "https://github.com/huggingface/datasets/pull/627", "diff_url": "https://github.com/huggingface/datasets/pull/627.diff", "patch_url": "https://github.com/huggingface/datasets/pull/627.patch", "merged_at": "2020-09-16T06:54:11"...
true
fix (#619) MLQA features names Fixed the features names as suggested in (#619) in the `_generate_examples` and `_info` methods in the MLQA loading script and also changed the names in the `dataset_infos.json` file.
[]
https://api.github.com/repos/huggingface/datasets/issues/626
626
Update GLUE URLs (now hosted on FB)
NYU is switching dataset hosting from Google to FB. This PR closes https://github.com/huggingface/datasets/issues/608 and is necessary for https://github.com/jiant-dev/jiant/issues/161. This PR updates the data URLs based on changes made in https://github.com/nyu-mll/jiant/pull/1112. Note: rebased on huggingface/dat...
closed
2020-09-14T19:05:39
https://api.github.com/repos/huggingface/datasets/issues/626/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/626", "html_url": "https://github.com/huggingface/datasets/pull/626", "diff_url": "https://github.com/huggingface/datasets/pull/626.diff", "patch_url": "https://github.com/huggingface/datasets/pull/626.patch", "merged_at": "2020-09-16T06:53:18"...
true
Update GLUE URLs (now hosted on FB) NYU is switching dataset hosting from Google to FB. This PR closes https://github.com/huggingface/datasets/issues/608 and is necessary for https://github.com/jiant-dev/jiant/issues/161. This PR updates the data URLs based on changes made in https://github.com/nyu-mll/jiant/pull/1112....
[]
https://api.github.com/repos/huggingface/datasets/issues/625
625
dtype of tensors should be preserved
After switching to `datasets` my model just broke. After a weekend of debugging, the issue was that my model could not handle the double that the Dataset provided, as it expected a float (but didn't give a warning, which seems a [PyTorch issue](https://discuss.pytorch.org/t/is-it-required-that-input-and-hidden-for-gru-...
closed
2020-09-14T12:38:05
https://api.github.com/repos/huggingface/datasets/issues/625/comments
null
false
dtype of tensors should be preserved After switching to `datasets` my model just broke. After a weekend of debugging, the issue was that my model could not handle the double that the Dataset provided, as it expected a float (but didn't give a warning, which seems a [PyTorch issue](https://discuss.pytorch.org/t/is-it-re...
[ "Indeed we convert tensors to list to be able to write in arrow format. Because of this conversion we lose the dtype information. We should add the dtype detection when we do type inference. However it would require a bit of refactoring since currently the conversion happens before the type inference..\r\n\r\nAnd t...