url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/624
624
Add learningq dataset
Hi, Thank you again for this amazing repo. Would it be possible for y'all to add the LearningQ dataset - https://github.com/AngusGLChen/LearningQ ?
open
2020-09-13T10:20:27
https://api.github.com/repos/huggingface/datasets/issues/624/comments
null
false
Add learningq dataset Hi, Thank you again for this amazing repo. Would it be possible for y'all to add the LearningQ dataset - https://github.com/AngusGLChen/LearningQ ?
[ "Hi! Triaging older issues this week — I think this one can be closed as out-of-scope for the current `datasets` repo.\n\n- Script-based dataset loaders are no longer added to this repo. The current model is \"upload directly to the Hub\": see [`ADD_NEW_DATASET.md`](https://github.com/huggingface/datasets/blob/main...
https://api.github.com/repos/huggingface/datasets/issues/623
623
Custom feature types in `load_dataset` from CSV
I am trying to load a local file with the `load_dataset` function and I want to predefine the feature types with the `features` argument. However, the types are always the same independent of the value of `features`. I am working with the local files from the emotion dataset. To get the data you can use the followi...
closed
2020-09-12T13:21:34
https://api.github.com/repos/huggingface/datasets/issues/623/comments
null
false
Custom feature types in `load_dataset` from CSV I am trying to load a local file with the `load_dataset` function and I want to predefine the feature types with the `features` argument. However, the types are always the same independent of the value of `features`. I am working with the local files from the emotion ...
[ "Currently `csv` doesn't support the `features` attribute (unlike `json`).\r\nWhat you can do for now is cast the features using the in-place transform `cast_`\r\n\r\n```python\r\nfrom datasets import load_dataset\r\n\r\ndataset = load_dataset('csv', data_files=file_dict, delimiter=';', column_names=['text', 'label...
https://api.github.com/repos/huggingface/datasets/issues/622
622
load_dataset for text files not working
Trying the following snippet, I get different problems on Linux and Windows. ```python dataset = load_dataset("text", data_files="data.txt") # or dataset = load_dataset("text", data_files=["data.txt"]) ``` (ps [This example](https://huggingface.co/docs/datasets/loading_datasets.html#json-files) shows that ...
closed
2020-09-12T12:49:28
https://api.github.com/repos/huggingface/datasets/issues/622/comments
null
false
load_dataset for text files not working Trying the following snippet, I get different problems on Linux and Windows. ```python dataset = load_dataset("text", data_files="data.txt") # or dataset = load_dataset("text", data_files=["data.txt"]) ``` (ps [This example](https://huggingface.co/docs/datasets/loadi...
[ "Can you give us more information on your os and pip environments (pip list)?", "@thomwolf Sure. I'll try downgrading to 3.7 now even though Arrow say they support >=3.5.\r\n\r\nLinux (Ubuntu 18.04) - Python 3.8\r\n======================\r\nPackage - Version\r\n---------------------\r\ncertifi 2...
https://api.github.com/repos/huggingface/datasets/issues/621
621
[docs] Index: The native emoji looks kinda ugly in large size
closed
2020-09-12T09:48:40
https://api.github.com/repos/huggingface/datasets/issues/621/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/621", "html_url": "https://github.com/huggingface/datasets/pull/621", "diff_url": "https://github.com/huggingface/datasets/pull/621.diff", "patch_url": "https://github.com/huggingface/datasets/pull/621.patch", "merged_at": "2020-09-15T06:20:02"...
true
[docs] Index: The native emoji looks kinda ugly in large size
[]
https://api.github.com/repos/huggingface/datasets/issues/620
620
map/filter multiprocessing raises errors and corrupts datasets
After upgrading to the 1.0 started seeing errors in my data loading script after enabling multiprocessing. ```python ... ner_ds_dict = ner_ds.train_test_split(test_size=test_pct, shuffle=True, seed=seed) ner_ds_dict["validation"] = ner_ds_dict["test"] rel_ds_dict = rel_ds.train_test_split(test_si...
closed
2020-09-11T22:30:06
https://api.github.com/repos/huggingface/datasets/issues/620/comments
null
false
map/filter multiprocessing raises errors and corrupts datasets After upgrading to the 1.0 started seeing errors in my data loading script after enabling multiprocessing. ```python ... ner_ds_dict = ner_ds.train_test_split(test_size=test_pct, shuffle=True, seed=seed) ner_ds_dict["validation"] = ner_ds_...
[ "It seems that I ran into the same problem\r\n```\r\ndef tokenize(cols, example):\r\n for in_col, out_col in cols.items():\r\n example[out_col] = hf_tokenizer.convert_tokens_to_ids(hf_tokenizer.tokenize(example[in_col]))\r\n return example\r\ncola = datasets.load_dataset('glue', 'cola')\r\ntokenized_cola = col...
https://api.github.com/repos/huggingface/datasets/issues/619
619
Mistakes in MLQA features names
I think the following features in MLQA shouldn't be named the way they are: 1. `questions` (should be `question`) 2. `ids` (should be `id`) 3. `start` (should be `answer_start`) The reasons I'm suggesting these features be renamed are: * To make them consistent with other QA datasets like SQuAD, XQuAD, TyDiQA et...
closed
2020-09-11T20:46:23
https://api.github.com/repos/huggingface/datasets/issues/619/comments
null
false
Mistakes in MLQA features names I think the following features in MLQA shouldn't be named the way they are: 1. `questions` (should be `question`) 2. `ids` (should be `id`) 3. `start` (should be `answer_start`) The reasons I'm suggesting these features be renamed are: * To make them consistent with other QA datas...
[ "Indeed you're right ! Thanks for reporting that\r\n\r\nCould you open a PR to fix the features names ?" ]
https://api.github.com/repos/huggingface/datasets/issues/618
618
sync logging utils with transformers
sync the docs/code with the recent changes in transformers' `logging` utils: 1. change the default level to `WARNING` 2. add `DATASETS_VERBOSITY` env var 3. expand docs
closed
2020-09-11T19:46:13
https://api.github.com/repos/huggingface/datasets/issues/618/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/618", "html_url": "https://github.com/huggingface/datasets/pull/618", "diff_url": "https://github.com/huggingface/datasets/pull/618.diff", "patch_url": "https://github.com/huggingface/datasets/pull/618.patch", "merged_at": null }
true
sync logging utils with transformers sync the docs/code with the recent changes in transformers' `logging` utils: 1. change the default level to `WARNING` 2. add `DATASETS_VERBOSITY` env var 3. expand docs
[ "Also, some downloads and dataset processing can be quite long for large datasets like wikipedia/pg19/etc. We probably don't want to user to think that the library is hanging. Happy to reorganize logging between DEBUG/INFO/WARNING to make it less verbose by default though.", "The problem is that `transformers` im...
https://api.github.com/repos/huggingface/datasets/issues/617
617
Compare different Rouge implementations
I used RougeL implementation provided in `datasets` [here](https://github.com/huggingface/datasets/blob/master/metrics/rouge/rouge.py) and it gives numbers that match those reported in the pegasus paper but very different from those reported in other papers, [this](https://arxiv.org/pdf/1909.03186.pdf) for example. Ca...
closed
2020-09-11T15:49:32
https://api.github.com/repos/huggingface/datasets/issues/617/comments
null
false
Compare different Rouge implementations I used RougeL implementation provided in `datasets` [here](https://github.com/huggingface/datasets/blob/master/metrics/rouge/rouge.py) and it gives numbers that match those reported in the pegasus paper but very different from those reported in other papers, [this](https://arxi...
[ "Updates - the differences between the following three\r\n(1) https://github.com/bheinzerling/pyrouge (previously popular. The one I trust the most)\r\n(2) https://github.com/google-research/google-research/tree/master/rouge\r\n(3) https://github.com/pltrdy/files2rouge (used in fairseq)\r\ncan be explained by two t...
https://api.github.com/repos/huggingface/datasets/issues/616
616
UserWarning: The given NumPy array is not writeable, and PyTorch does not support non-writeable tensors
I am trying out the library and want to load in pickled data with `from_dict`. In that dict, one column `text` should be tokenized and the other (an embedding vector) should be retained. All other columns should be removed. When I eventually try to set the format for the columns with `set_format` I am getting this stra...
open
2020-09-11T15:39:16
https://api.github.com/repos/huggingface/datasets/issues/616/comments
null
false
UserWarning: The given NumPy array is not writeable, and PyTorch does not support non-writeable tensors I am trying out the library and want to load in pickled data with `from_dict`. In that dict, one column `text` should be tokenized and the other (an embedding vector) should be retained. All other columns should be r...
[ "I have the same issue", "Same issue here when Trying to load a dataset from disk.", "I am also experiencing this issue, and don't know if it's affecting my training.", "Same here. I hope the dataset is not being modified in-place.", "I think the only way to avoid this warning would be to do a copy of the n...
https://api.github.com/repos/huggingface/datasets/issues/615
615
Offset overflow when slicing a big dataset with an array of indices in Pyarrow >= 1.0.0
How to reproduce: ```python from datasets import load_dataset wiki = load_dataset("wikipedia", "20200501.en", split="train") wiki[[0]] --------------------------------------------------------------------------- ArrowInvalid Traceback (most recent call last) <ipython-input-13-38...
closed
2020-09-11T14:50:38
https://api.github.com/repos/huggingface/datasets/issues/615/comments
null
false
Offset overflow when slicing a big dataset with an array of indices in Pyarrow >= 1.0.0 How to reproduce: ```python from datasets import load_dataset wiki = load_dataset("wikipedia", "20200501.en", split="train") wiki[[0]] --------------------------------------------------------------------------- ArrowInva...
[ "Related: https://issues.apache.org/jira/browse/ARROW-9773\r\n\r\nIt's definitely a size thing. I took a smaller dataset with 87000 rows and did:\r\n```\r\nfor i in range(10,1000,20):\r\n table = pa.concat_tables([dset._data]*i)\r\n table.take([0])\r\n```\r\nand it broke at around i=300.\r\n\r\nAlso when `_in...
https://api.github.com/repos/huggingface/datasets/issues/614
614
[doc] Update deploy.sh
closed
2020-09-11T11:06:13
https://api.github.com/repos/huggingface/datasets/issues/614/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/614", "html_url": "https://github.com/huggingface/datasets/pull/614", "diff_url": "https://github.com/huggingface/datasets/pull/614.diff", "patch_url": "https://github.com/huggingface/datasets/pull/614.patch", "merged_at": "2020-09-14T08:49:17"...
true
[doc] Update deploy.sh
[]
https://api.github.com/repos/huggingface/datasets/issues/613
613
Add CoNLL-2003 shared task dataset
Please consider adding CoNLL-2003 shared task dataset as it's beneficial for token classification tasks. The motivation behind this PR is the [PR](https://github.com/huggingface/transformers/pull/7041) in the transformers project. This dataset would be not only useful for the usual run-of-the-mill NER tasks but also fo...
closed
2020-09-11T10:02:30
https://api.github.com/repos/huggingface/datasets/issues/613/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/613", "html_url": "https://github.com/huggingface/datasets/pull/613", "diff_url": "https://github.com/huggingface/datasets/pull/613.diff", "patch_url": "https://github.com/huggingface/datasets/pull/613.patch", "merged_at": "2020-09-17T10:36:38"...
true
Add CoNLL-2003 shared task dataset Please consider adding CoNLL-2003 shared task dataset as it's beneficial for token classification tasks. The motivation behind this PR is the [PR](https://github.com/huggingface/transformers/pull/7041) in the transformers project. This dataset would be not only useful for the usual ru...
[ "I think we should somewhere mention, that is the dataset in IOB2 tagging scheme, whereas the original dataset uses IOB1 :)", "Indeed this is something we want to mention.\r\n\r\nIf would want to add more details about the IOB1->2 change, feel free to ignore my suggestions and edit the description + update the da...
https://api.github.com/repos/huggingface/datasets/issues/612
612
add multi-proc to dataset dict
Add multi-proc to `DatasetDict`
closed
2020-09-11T08:18:13
https://api.github.com/repos/huggingface/datasets/issues/612/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/612", "html_url": "https://github.com/huggingface/datasets/pull/612", "diff_url": "https://github.com/huggingface/datasets/pull/612.diff", "patch_url": "https://github.com/huggingface/datasets/pull/612.patch", "merged_at": "2020-09-11T10:20:11"...
true
add multi-proc to dataset dict Add multi-proc to `DatasetDict`
[]
https://api.github.com/repos/huggingface/datasets/issues/611
611
ArrowCapacityError: List array cannot contain more than 2147483646 child elements, have 2147483648
Hi, I'm trying to load a dataset from Dataframe, but I get the error: ```bash --------------------------------------------------------------------------- ArrowCapacityError Traceback (most recent call last) <ipython-input-7-146b6b495963> in <module> ----> 1 dataset = Dataset.from_pandas(emb)...
closed
2020-09-11T05:29:12
https://api.github.com/repos/huggingface/datasets/issues/611/comments
null
false
ArrowCapacityError: List array cannot contain more than 2147483646 child elements, have 2147483648 Hi, I'm trying to load a dataset from Dataframe, but I get the error: ```bash --------------------------------------------------------------------------- ArrowCapacityError Traceback (most recent...
[ "Can you give us stats/information on your pandas DataFrame?", "```\r\n<class 'pandas.core.frame.DataFrame'>\r\nInt64Index: 17136104 entries, 0 to 17136103\r\nData columns (total 6 columns):\r\n # Column Dtype \r\n--- ------ ----- \r\n 0 item_id int64 \r\n 1 item_titl object \r\n...
https://api.github.com/repos/huggingface/datasets/issues/610
610
Load text file for RoBERTa pre-training.
I migrate my question from https://github.com/huggingface/transformers/pull/4009#issuecomment-690039444 I tried to train a Roberta from scratch using transformers. But I got OOM issues with loading a large text file. According to the suggestion from @thomwolf , I tried to implement `datasets` to load my text file....
closed
2020-09-10T18:41:38
https://api.github.com/repos/huggingface/datasets/issues/610/comments
null
false
Load text file for RoBERTa pre-training. I migrate my question from https://github.com/huggingface/transformers/pull/4009#issuecomment-690039444 I tried to train a Roberta from scratch using transformers. But I got OOM issues with loading a large text file. According to the suggestion from @thomwolf , I tried to ...
[ "Could you try\r\n```python\r\nload_dataset('text', data_files='test.txt',cache_dir=\"./\", split=\"train\")\r\n```\r\n?\r\n\r\n`load_dataset` returns a dictionary by default, like {\"train\": your_dataset}", "Hi @lhoestq\r\nThanks for your suggestion.\r\n\r\nI tried \r\n```\r\ndataset = load_dataset('text', data...
https://api.github.com/repos/huggingface/datasets/issues/609
609
Update GLUE URLs (now hosted on FB)
NYU is switching dataset hosting from Google to FB. This PR closes https://github.com/huggingface/datasets/issues/608 and is necessary for https://github.com/jiant-dev/jiant/issues/161. This PR updates the data URLs based on changes made in https://github.com/nyu-mll/jiant/pull/1112.
closed
2020-09-10T18:16:32
https://api.github.com/repos/huggingface/datasets/issues/609/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/609", "html_url": "https://github.com/huggingface/datasets/pull/609", "diff_url": "https://github.com/huggingface/datasets/pull/609.diff", "patch_url": "https://github.com/huggingface/datasets/pull/609.patch", "merged_at": null }
true
Update GLUE URLs (now hosted on FB) NYU is switching dataset hosting from Google to FB. This PR closes https://github.com/huggingface/datasets/issues/608 and is necessary for https://github.com/jiant-dev/jiant/issues/161. This PR updates the data URLs based on changes made in https://github.com/nyu-mll/jiant/pull/1112.
[ "Thanks for opening this PR :) \r\n\r\nWe changed the name of the lib from nlp to datasets yesterday.\r\nCould you rebase from master and re-generate the dataset_info.json file to fix the name changes ?", "Rebased changes here: https://github.com/huggingface/datasets/pull/626" ]
https://api.github.com/repos/huggingface/datasets/issues/608
608
Don't use the old NYU GLUE dataset URLs
NYU is switching dataset hosting from Google to FB. Initial changes to `datasets` are in https://github.com/jeswan/nlp/commit/b7d4a071d432592ded971e30ef73330529de25ce. What tests do you suggest I run before opening a PR? See: https://github.com/jiant-dev/jiant/issues/161 and https://github.com/nyu-mll/jiant/pull/111...
closed
2020-09-10T17:47:02
https://api.github.com/repos/huggingface/datasets/issues/608/comments
null
false
Don't use the old NYU GLUE dataset URLs NYU is switching dataset hosting from Google to FB. Initial changes to `datasets` are in https://github.com/jeswan/nlp/commit/b7d4a071d432592ded971e30ef73330529de25ce. What tests do you suggest I run before opening a PR? See: https://github.com/jiant-dev/jiant/issues/161 and h...
[ "Feel free to open the PR ;)\r\nThanks for updating the dataset_info.json file !" ]
https://api.github.com/repos/huggingface/datasets/issues/607
607
Add transmit_format wrapper and tests
Same as #605 but using a decorator on-top of dataset transforms that are not in place
closed
2020-09-10T15:03:50
https://api.github.com/repos/huggingface/datasets/issues/607/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/607", "html_url": "https://github.com/huggingface/datasets/pull/607", "diff_url": "https://github.com/huggingface/datasets/pull/607.diff", "patch_url": "https://github.com/huggingface/datasets/pull/607.patch", "merged_at": "2020-09-10T15:21:47"...
true
Add transmit_format wrapper and tests Same as #605 but using a decorator on-top of dataset transforms that are not in place
[]
https://api.github.com/repos/huggingface/datasets/issues/606
606
Quick fix :)
`nlp` => `datasets`
closed
2020-09-10T14:32:06
https://api.github.com/repos/huggingface/datasets/issues/606/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/606", "html_url": "https://github.com/huggingface/datasets/pull/606", "diff_url": "https://github.com/huggingface/datasets/pull/606.diff", "patch_url": "https://github.com/huggingface/datasets/pull/606.patch", "merged_at": "2020-09-10T16:18:30"...
true
Quick fix :) `nlp` => `datasets`
[ ":heart:" ]
https://api.github.com/repos/huggingface/datasets/issues/605
605
[Datasets] Transmit format to children
Transmit format to children obtained when processing a dataset. Added a test. When concatenating datasets, if the formats are disparate, the concatenated dataset has a format reset to defaults.
closed
2020-09-10T12:30:18
https://api.github.com/repos/huggingface/datasets/issues/605/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/605", "html_url": "https://github.com/huggingface/datasets/pull/605", "diff_url": "https://github.com/huggingface/datasets/pull/605.diff", "patch_url": "https://github.com/huggingface/datasets/pull/605.patch", "merged_at": null }
true
[Datasets] Transmit format to children Transmit format to children obtained when processing a dataset. Added a test. When concatenating datasets, if the formats are disparate, the concatenated dataset has a format reset to defaults.
[ "Closing as #607 was merged" ]
https://api.github.com/repos/huggingface/datasets/issues/604
604
Update bucket prefix
cc @julien-c
closed
2020-09-10T11:01:13
https://api.github.com/repos/huggingface/datasets/issues/604/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/604", "html_url": "https://github.com/huggingface/datasets/pull/604", "diff_url": "https://github.com/huggingface/datasets/pull/604.diff", "patch_url": "https://github.com/huggingface/datasets/pull/604.patch", "merged_at": "2020-09-10T12:45:32"...
true
Update bucket prefix cc @julien-c
[]
https://api.github.com/repos/huggingface/datasets/issues/603
603
Set scripts version to master
By default the scripts version is master, so that if the library is installed with ``` pip install git+http://github.com/huggingface/nlp.git ``` or ``` git clone http://github.com/huggingface/nlp.git pip install -e ./nlp ``` will use the latest scripts, and not the ones from the previous version.
closed
2020-09-10T10:47:44
https://api.github.com/repos/huggingface/datasets/issues/603/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/603", "html_url": "https://github.com/huggingface/datasets/pull/603", "diff_url": "https://github.com/huggingface/datasets/pull/603.diff", "patch_url": "https://github.com/huggingface/datasets/pull/603.patch", "merged_at": "2020-09-10T11:02:04"...
true
Set scripts version to master By default the scripts version is master, so that if the library is installed with ``` pip install git+http://github.com/huggingface/nlp.git ``` or ``` git clone http://github.com/huggingface/nlp.git pip install -e ./nlp ``` will use the latest scripts, and not the ones from th...
[]
https://api.github.com/repos/huggingface/datasets/issues/602
602
apply offset to indices in multiprocessed map
Fix #597 I fixed the indices by applying an offset. I added the case to our tests to make sure it doesn't happen again. I also added the message proposed by @thomwolf in #597 ```python >>> d.select(range(10)).map(fn, with_indices=True, batched=True, num_proc=2, load_from_cache_file=False) Done writing 10 ...
closed
2020-09-10T08:54:30
https://api.github.com/repos/huggingface/datasets/issues/602/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/602", "html_url": "https://github.com/huggingface/datasets/pull/602", "diff_url": "https://github.com/huggingface/datasets/pull/602.diff", "patch_url": "https://github.com/huggingface/datasets/pull/602.patch", "merged_at": "2020-09-10T11:03:37"...
true
apply offset to indices in multiprocessed map Fix #597 I fixed the indices by applying an offset. I added the case to our tests to make sure it doesn't happen again. I also added the message proposed by @thomwolf in #597 ```python >>> d.select(range(10)).map(fn, with_indices=True, batched=True, num_proc=2,...
[]
https://api.github.com/repos/huggingface/datasets/issues/601
601
check if trasnformers has PreTrainedTokenizerBase
Fix #598
closed
2020-09-10T07:54:56
https://api.github.com/repos/huggingface/datasets/issues/601/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/601", "html_url": "https://github.com/huggingface/datasets/pull/601", "diff_url": "https://github.com/huggingface/datasets/pull/601.diff", "patch_url": "https://github.com/huggingface/datasets/pull/601.patch", "merged_at": "2020-09-10T11:01:36"...
true
check if trasnformers has PreTrainedTokenizerBase Fix #598
[]
https://api.github.com/repos/huggingface/datasets/issues/600
600
Pickling error when loading dataset
Hi, I modified line 136 in the original [run_language_modeling.py](https://github.com/huggingface/transformers/blob/master/examples/language-modeling/run_language_modeling.py) as: ``` # line 136: return LineByLineTextDataset(tokenizer=tokenizer, file_path=file_path, block_size=args.block_size) dataset = load_da...
closed
2020-09-10T06:28:08
https://api.github.com/repos/huggingface/datasets/issues/600/comments
null
false
Pickling error when loading dataset Hi, I modified line 136 in the original [run_language_modeling.py](https://github.com/huggingface/transformers/blob/master/examples/language-modeling/run_language_modeling.py) as: ``` # line 136: return LineByLineTextDataset(tokenizer=tokenizer, file_path=file_path, block_size...
[ "When I change from python3.6 to python3.8, it works! ", "Does it work when you install `nlp` from source on python 3.6?", "No, still the pickling error.", "I wasn't able to reproduce on google colab (python 3.6.9 as well) with \r\n\r\npickle==4.0\r\ndill=0.3.2\r\ntransformers==3.1.0\r\ndatasets=1.0.1 (also t...
https://api.github.com/repos/huggingface/datasets/issues/599
599
Add MATINF dataset
@lhoestq The command to create metadata failed. I guess it's because the zip is not downloaded from a remote address? How to solve that? Also the CI fails and I don't know how to fix that :(
closed
2020-09-10T03:31:09
https://api.github.com/repos/huggingface/datasets/issues/599/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/599", "html_url": "https://github.com/huggingface/datasets/pull/599", "diff_url": "https://github.com/huggingface/datasets/pull/599.diff", "patch_url": "https://github.com/huggingface/datasets/pull/599.patch", "merged_at": null }
true
Add MATINF dataset @lhoestq The command to create metadata failed. I guess it's because the zip is not downloaded from a remote address? How to solve that? Also the CI fails and I don't know how to fix that :(
[ "Hi ! sorry for the late response\r\n\r\nCould you try to rebase from master ? We changed the named of the library last week so you have to include this change in your code.\r\n\r\nCan you give me more details about the error you get when running the cli command ?\r\n\r\nNote that in case of a manual download you h...
https://api.github.com/repos/huggingface/datasets/issues/598
598
The current version of the package on github has an error when loading dataset
Instead of downloading the package from pip, downloading the version from source will result in an error when loading dataset (the pip version is completely fine): To recreate the error: First, installing nlp directly from source: ``` git clone https://github.com/huggingface/nlp.git cd nlp pip install -e . ``...
closed
2020-09-09T21:03:23
https://api.github.com/repos/huggingface/datasets/issues/598/comments
null
false
The current version of the package on github has an error when loading dataset Instead of downloading the package from pip, downloading the version from source will result in an error when loading dataset (the pip version is completely fine): To recreate the error: First, installing nlp directly from source: ``` ...
[ "Thanks for reporting !\r\nWhich version of transformers are you using ?\r\nIt looks like it doesn't have the PreTrainedTokenizerBase class", "I was using transformer 2.9. And I switch to the latest transformer package. Everything works just fine!!\r\n\r\nThanks for helping! I should look more carefully next time...
https://api.github.com/repos/huggingface/datasets/issues/597
597
Indices incorrect with multiprocessing
When `num_proc` > 1, the indices argument passed to the map function is incorrect: ```python d = load_dataset('imdb', split='test[:1%]') def fn(x, inds): print(inds) return x d.select(range(10)).map(fn, with_indices=True, batched=True) # [0, 1] # [0, 1, 2, 3, 4, 5, 6, 7, 8, 9] d.select(range(10...
closed
2020-09-09T19:50:56
https://api.github.com/repos/huggingface/datasets/issues/597/comments
null
false
Indices incorrect with multiprocessing When `num_proc` > 1, the indices argument passed to the map function is incorrect: ```python d = load_dataset('imdb', split='test[:1%]') def fn(x, inds): print(inds) return x d.select(range(10)).map(fn, with_indices=True, batched=True) # [0, 1] # [0, 1, 2, 3,...
[ "I fixed a bug that could cause this issue earlier today. Could you pull the latest version and try again ?", "Still the case on master.\r\nI guess we should have an offset in the multi-procs indeed (hopefully it's enough).\r\n\r\nAlso, side note is that we should add some logging before the \"test\" to say we ar...
https://api.github.com/repos/huggingface/datasets/issues/596
596
[style/quality] Moving to isort 5.0.0 + style/quality on datasets and metrics
Move the repo to isort 5.0.0. Also start testing style/quality on datasets and metrics. Specific rule: we allow F401 (unused imports) in metrics to be able to add imports to detect early on missing dependencies. Maybe we could add this in datasets but while cleaning this I've seen many example of really unused i...
closed
2020-09-09T15:47:21
https://api.github.com/repos/huggingface/datasets/issues/596/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/596", "html_url": "https://github.com/huggingface/datasets/pull/596", "diff_url": "https://github.com/huggingface/datasets/pull/596.diff", "patch_url": "https://github.com/huggingface/datasets/pull/596.patch", "merged_at": "2020-09-10T10:05:03"...
true
[style/quality] Moving to isort 5.0.0 + style/quality on datasets and metrics Move the repo to isort 5.0.0. Also start testing style/quality on datasets and metrics. Specific rule: we allow F401 (unused imports) in metrics to be able to add imports to detect early on missing dependencies. Maybe we could add this...
[ "Ready for review @lhoestq, just updated a few 156 files here" ]
https://api.github.com/repos/huggingface/datasets/issues/595
595
`Dataset`/`DatasetDict` has no attribute 'save_to_disk'
Hi, As the title indicates, both `Dataset` and `DatasetDict` classes don't seem to have the `save_to_disk` method. While the file [`arrow_dataset.py`](https://github.com/huggingface/nlp/blob/34bf0b03bfe03e7f77b8fec1cd48f5452c4fc7c1/src/nlp/arrow_dataset.py) in the repo here has the method, the file `arrow_dataset.p...
closed
2020-09-09T15:01:52
https://api.github.com/repos/huggingface/datasets/issues/595/comments
null
false
`Dataset`/`DatasetDict` has no attribute 'save_to_disk' Hi, As the title indicates, both `Dataset` and `DatasetDict` classes don't seem to have the `save_to_disk` method. While the file [`arrow_dataset.py`](https://github.com/huggingface/nlp/blob/34bf0b03bfe03e7f77b8fec1cd48f5452c4fc7c1/src/nlp/arrow_dataset.py) in...
[ "`pip install git+https://github.com/huggingface/nlp.git` should have done the job.\r\n\r\nDid you uninstall `nlp` before installing from github ?", "> Did you uninstall `nlp` before installing from github ?\r\n\r\nI did not. I created a new environment and installed `nlp` directly from `github` and it worked!\r\...
https://api.github.com/repos/huggingface/datasets/issues/594
594
Fix germeval url
Continuation of #593 but without the dummy data hack
closed
2020-09-09T13:29:35
https://api.github.com/repos/huggingface/datasets/issues/594/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/594", "html_url": "https://github.com/huggingface/datasets/pull/594", "diff_url": "https://github.com/huggingface/datasets/pull/594.diff", "patch_url": "https://github.com/huggingface/datasets/pull/594.patch", "merged_at": "2020-09-09T13:34:34"...
true
Fix germeval url Continuation of #593 but without the dummy data hack
[]
https://api.github.com/repos/huggingface/datasets/issues/593
593
GermEval 2014: new download urls
Hi, unfortunately, the download links for the GermEval 2014 dataset have changed: they're now located on a Google Drive. I changed the URLs and bump version from 1.0.0 to 2.0.0.
closed
2020-09-09T10:07:29
https://api.github.com/repos/huggingface/datasets/issues/593/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/593", "html_url": "https://github.com/huggingface/datasets/pull/593", "diff_url": "https://github.com/huggingface/datasets/pull/593.diff", "patch_url": "https://github.com/huggingface/datasets/pull/593.patch", "merged_at": null }
true
GermEval 2014: new download urls Hi, unfortunately, the download links for the GermEval 2014 dataset have changed: they're now located on a Google Drive. I changed the URLs and bump version from 1.0.0 to 2.0.0.
[ "/cc: @vblagoje", "Closing this one as #594 is merged (same changes except the dummy data hack)", "Awesome @stefan-it ! @lhoestq how soon can I use the fixed GermEval dataset in HF token classification examples?", "I've manually updated the script on S3, so you can actually use it right now with\r\n```python\...
https://api.github.com/repos/huggingface/datasets/issues/592
592
Test in memory and on disk
I added test parameters to do every test both in memory and on disk. I also found a bug in concatenate_dataset thanks to the new tests and fixed it.
closed
2020-09-09T08:59:30
https://api.github.com/repos/huggingface/datasets/issues/592/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/592", "html_url": "https://github.com/huggingface/datasets/pull/592", "diff_url": "https://github.com/huggingface/datasets/pull/592.diff", "patch_url": "https://github.com/huggingface/datasets/pull/592.patch", "merged_at": "2020-09-09T13:50:03"...
true
Test in memory and on disk I added test parameters to do every test both in memory and on disk. I also found a bug in concatenate_dataset thanks to the new tests and fixed it.
[]
https://api.github.com/repos/huggingface/datasets/issues/591
591
fix #589 (backward compat)
Fix #589
closed
2020-09-09T07:33:13
https://api.github.com/repos/huggingface/datasets/issues/591/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/591", "html_url": "https://github.com/huggingface/datasets/pull/591", "diff_url": "https://github.com/huggingface/datasets/pull/591.diff", "patch_url": "https://github.com/huggingface/datasets/pull/591.patch", "merged_at": "2020-09-09T08:57:54"...
true
fix #589 (backward compat) Fix #589
[]
https://api.github.com/repos/huggingface/datasets/issues/590
590
The process cannot access the file because it is being used by another process (windows)
Hi, I consistently get the following error when developing in my PC (windows 10): ``` train_dataset = train_dataset.map(convert_to_features, batched=True) File "C:\Users\saareliad\AppData\Local\Continuum\miniconda3\envs\py38\lib\site-packages\nlp\arrow_dataset.py", line 970, in map shutil.move(tmp_file....
closed
2020-09-09T07:01:36
https://api.github.com/repos/huggingface/datasets/issues/590/comments
null
false
The process cannot access the file because it is being used by another process (windows) Hi, I consistently get the following error when developing in my PC (windows 10): ``` train_dataset = train_dataset.map(convert_to_features, batched=True) File "C:\Users\saareliad\AppData\Local\Continuum\miniconda3\envs\...
[ "Hi, which version of `nlp` are you using?\r\n\r\nBy the way we'll be releasing today a significant update fixing many issues (but also comprising a few breaking changes).\r\nYou can see more informations here #545 and try it by installing from source from the master branch.", "I'm using version 0.4.0.\r\n\r\n", ...
https://api.github.com/repos/huggingface/datasets/issues/589
589
Cannot use nlp.load_dataset text, AttributeError: module 'nlp.utils' has no attribute 'logging'
``` Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/root/anaconda3/envs/pytorch/lib/python3.7/site-packages/nlp/load.py", line 533, in load_dataset builder_cls = import_main_class(module_path, dataset=True) File "/root/anaconda3/envs/pytorch/lib/python3.7/site-packages/nlp...
closed
2020-09-09T06:46:53
https://api.github.com/repos/huggingface/datasets/issues/589/comments
null
false
Cannot use nlp.load_dataset text, AttributeError: module 'nlp.utils' has no attribute 'logging' ``` Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/root/anaconda3/envs/pytorch/lib/python3.7/site-packages/nlp/load.py", line 533, in load_dataset builder_cls = import_main_class(...
[]
https://api.github.com/repos/huggingface/datasets/issues/588
588
Support pathlike obj in load dataset
Fix #582 (I recreated the PR, I got an issue with git)
closed
2020-09-07T16:13:21
https://api.github.com/repos/huggingface/datasets/issues/588/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/588", "html_url": "https://github.com/huggingface/datasets/pull/588", "diff_url": "https://github.com/huggingface/datasets/pull/588.diff", "patch_url": "https://github.com/huggingface/datasets/pull/588.patch", "merged_at": "2020-09-08T07:45:17"...
true
Support pathlike obj in load dataset Fix #582 (I recreated the PR, I got an issue with git)
[]
https://api.github.com/repos/huggingface/datasets/issues/587
587
Support pathlike obj in load dataset
Fix #582
closed
2020-09-07T16:09:16
https://api.github.com/repos/huggingface/datasets/issues/587/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/587", "html_url": "https://github.com/huggingface/datasets/pull/587", "diff_url": "https://github.com/huggingface/datasets/pull/587.diff", "patch_url": "https://github.com/huggingface/datasets/pull/587.patch", "merged_at": null }
true
Support pathlike obj in load dataset Fix #582
[]
https://api.github.com/repos/huggingface/datasets/issues/586
586
Better message when data files is empty
Fix #581
closed
2020-09-07T15:59:57
https://api.github.com/repos/huggingface/datasets/issues/586/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/586", "html_url": "https://github.com/huggingface/datasets/pull/586", "diff_url": "https://github.com/huggingface/datasets/pull/586.diff", "patch_url": "https://github.com/huggingface/datasets/pull/586.patch", "merged_at": "2020-09-09T09:00:07"...
true
Better message when data files is empty Fix #581
[]
https://api.github.com/repos/huggingface/datasets/issues/585
585
Fix select for pyarrow < 1.0.0
Fix #583
closed
2020-09-07T15:02:52
https://api.github.com/repos/huggingface/datasets/issues/585/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/585", "html_url": "https://github.com/huggingface/datasets/pull/585", "diff_url": "https://github.com/huggingface/datasets/pull/585.diff", "patch_url": "https://github.com/huggingface/datasets/pull/585.patch", "merged_at": "2020-09-08T07:43:15"...
true
Fix select for pyarrow < 1.0.0 Fix #583
[]
https://api.github.com/repos/huggingface/datasets/issues/584
584
Use github versioning
Right now dataset scripts and metrics are downloaded from S3 which is in sync with master. It means that it's not currently possible to pin the dataset/metric script version. To fix that I changed the download url from S3 to github, and adding a `version` parameter in `load_dataset` and `load_metric` to pin a certai...
closed
2020-09-07T14:58:15
https://api.github.com/repos/huggingface/datasets/issues/584/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/584", "html_url": "https://github.com/huggingface/datasets/pull/584", "diff_url": "https://github.com/huggingface/datasets/pull/584.diff", "patch_url": "https://github.com/huggingface/datasets/pull/584.patch", "merged_at": "2020-09-09T13:37:34"...
true
Use github versioning Right now dataset scripts and metrics are downloaded from S3 which is in sync with master. It means that it's not currently possible to pin the dataset/metric script version. To fix that I changed the download url from S3 to github, and adding a `version` parameter in `load_dataset` and `load_m...
[ "I noticed that datasets like `cnn_dailymail` need the `version` parameter to be passed to its `config_kwargs`.\r\nShall we rename the `version` paramater in `load_dataset` ? Maybe `repo_version` or `script_version` ?" ]
https://api.github.com/repos/huggingface/datasets/issues/583
583
ArrowIndexError on Dataset.select
If the indices table consists in several chunks, then `dataset.select` results in an `ArrowIndexError` error for pyarrow < 1.0.0 Example: ```python from nlp import load_dataset mnli = load_dataset("glue", "mnli", split="train") shuffled = mnli.shuffle(seed=42) mnli.select(list(range(len(mnli)))) ``` rai...
closed
2020-09-07T14:36:29
https://api.github.com/repos/huggingface/datasets/issues/583/comments
null
false
ArrowIndexError on Dataset.select If the indices table consists in several chunks, then `dataset.select` results in an `ArrowIndexError` error for pyarrow < 1.0.0 Example: ```python from nlp import load_dataset mnli = load_dataset("glue", "mnli", split="train") shuffled = mnli.shuffle(seed=42) mnli.select(l...
[]
https://api.github.com/repos/huggingface/datasets/issues/582
582
Allow for PathLike objects
Using PathLike objects as input for `load_dataset` does not seem to work. The following will throw an error. ```python files = list(Path(r"D:\corpora\yourcorpus").glob("*.txt")) dataset = load_dataset("text", data_files=files) ``` Traceback: ``` Traceback (most recent call last): File "C:/dev/python/dut...
closed
2020-09-07T13:54:51
https://api.github.com/repos/huggingface/datasets/issues/582/comments
null
false
Allow for PathLike objects Using PathLike objects as input for `load_dataset` does not seem to work. The following will throw an error. ```python files = list(Path(r"D:\corpora\yourcorpus").glob("*.txt")) dataset = load_dataset("text", data_files=files) ``` Traceback: ``` Traceback (most recent call last):...
[]
https://api.github.com/repos/huggingface/datasets/issues/581
581
Better error message when input file does not exist
In the following scenario, when `data_files` is an empty list, the stack trace and error message could be improved. This can probably be solved by checking for each file whether it actually exists and/or whether the argument is not false-y. ```python dataset = load_dataset("text", data_files=[]) ``` Example err...
closed
2020-09-07T13:47:59
https://api.github.com/repos/huggingface/datasets/issues/581/comments
null
false
Better error message when input file does not exist In the following scenario, when `data_files` is an empty list, the stack trace and error message could be improved. This can probably be solved by checking for each file whether it actually exists and/or whether the argument is not false-y. ```python dataset = loa...
[]
https://api.github.com/repos/huggingface/datasets/issues/580
580
nlp re-creates already-there caches when using a script, but not within a shell
`nlp` keeps creating new caches for the same file when launching `filter` from a script, and behaves correctly from within the shell. Example: try running ``` import nlp hans_easy_data = nlp.load_dataset('hans', split="validation").filter(lambda x: x['label'] == 0) hans_hard_data = nlp.load_dataset('hans', s...
closed
2020-09-07T10:23:50
https://api.github.com/repos/huggingface/datasets/issues/580/comments
null
false
nlp re-creates already-there caches when using a script, but not within a shell `nlp` keeps creating new caches for the same file when launching `filter` from a script, and behaves correctly from within the shell. Example: try running ``` import nlp hans_easy_data = nlp.load_dataset('hans', split="validation"...
[ "Couln't reproduce on my side :/ \r\nlet me know if you manage to reproduce on another env (colab for example)", "Fixed with a clean re-install!" ]
https://api.github.com/repos/huggingface/datasets/issues/579
579
Doc metrics
Adding documentation on metrics loading/using/sharing
closed
2020-09-07T10:15:24
https://api.github.com/repos/huggingface/datasets/issues/579/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/579", "html_url": "https://github.com/huggingface/datasets/pull/579", "diff_url": "https://github.com/huggingface/datasets/pull/579.diff", "patch_url": "https://github.com/huggingface/datasets/pull/579.patch", "merged_at": "2020-09-10T13:06:10"...
true
Doc metrics Adding documentation on metrics loading/using/sharing
[]
https://api.github.com/repos/huggingface/datasets/issues/578
578
Add CommonGen Dataset
CC Authors: @yuchenlin @MichaelZhouwang
closed
2020-09-07T08:17:17
https://api.github.com/repos/huggingface/datasets/issues/578/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/578", "html_url": "https://github.com/huggingface/datasets/pull/578", "diff_url": "https://github.com/huggingface/datasets/pull/578.diff", "patch_url": "https://github.com/huggingface/datasets/pull/578.patch", "merged_at": "2020-09-07T11:49:07"...
true
Add CommonGen Dataset CC Authors: @yuchenlin @MichaelZhouwang
[]
https://api.github.com/repos/huggingface/datasets/issues/577
577
Some languages in wikipedia dataset are not loading
Hi, I am working with the `wikipedia` dataset and I have a script that goes over 92 of the available languages in that dataset. So far I have detected that `ar`, `af`, `an` are not loading. Other languages like `fr` and `en` are working fine. Here's how I am loading them: ``` import nlp langs = ['ar'. 'af', '...
closed
2020-09-07T01:16:29
https://api.github.com/repos/huggingface/datasets/issues/577/comments
null
false
Some languages in wikipedia dataset are not loading Hi, I am working with the `wikipedia` dataset and I have a script that goes over 92 of the available languages in that dataset. So far I have detected that `ar`, `af`, `an` are not loading. Other languages like `fr` and `en` are working fine. Here's how I am loadin...
[ "Some wikipedia languages have already been processed by us and are hosted on our google storage. This is the case for \"fr\" and \"en\" for example.\r\n\r\nFor other smaller languages (in terms of bytes), they are directly downloaded and parsed from the wikipedia dump site.\r\nParsing can take some time for langua...
https://api.github.com/repos/huggingface/datasets/issues/576
576
Fix the code block in doc
closed
2020-09-06T11:40:55
https://api.github.com/repos/huggingface/datasets/issues/576/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/576", "html_url": "https://github.com/huggingface/datasets/pull/576", "diff_url": "https://github.com/huggingface/datasets/pull/576.diff", "patch_url": "https://github.com/huggingface/datasets/pull/576.patch", "merged_at": "2020-09-07T07:37:18"...
true
Fix the code block in doc
[ "thanks :)" ]
https://api.github.com/repos/huggingface/datasets/issues/575
575
Couldn't reach certain URLs and for the ones that can be reached, code just blocks after downloading.
Hi, I'm following the [quick tour](https://huggingface.co/nlp/quicktour.html) and tried to load the glue dataset: ``` >>> from nlp import load_dataset >>> dataset = load_dataset('glue', 'mrpc', split='train') ``` However, this ran into a `ConnectionError` saying it could not reach the URL (just pasting the la...
closed
2020-09-04T21:46:25
https://api.github.com/repos/huggingface/datasets/issues/575/comments
null
false
Couldn't reach certain URLs and for the ones that can be reached, code just blocks after downloading. Hi, I'm following the [quick tour](https://huggingface.co/nlp/quicktour.html) and tried to load the glue dataset: ``` >>> from nlp import load_dataset >>> dataset = load_dataset('glue', 'mrpc', split='train') ``...
[ "Update:\r\n\r\nThe imdb download completed after a long time (about 45 mins). Ofcourse once download loading was instantaneous. Also, the loaded object was of type `arrow_dataset`. \r\n\r\nThe urls for glue still doesn't work though.", "Thanks for the report, I'll give a look!", "I am also seeing a similar err...
https://api.github.com/repos/huggingface/datasets/issues/574
574
Add modules cache
As discusses in #554 , we should use a module cache directory outside of the python packages directory since we may not have write permissions. I added a new HF_MODULES_PATH directory that is added to the python path when doing `import nlp`. In this directory, a module `nlp_modules` is created so that datasets can ...
closed
2020-09-04T16:30:03
https://api.github.com/repos/huggingface/datasets/issues/574/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/574", "html_url": "https://github.com/huggingface/datasets/pull/574", "diff_url": "https://github.com/huggingface/datasets/pull/574.diff", "patch_url": "https://github.com/huggingface/datasets/pull/574.patch", "merged_at": "2020-09-07T09:01:35"...
true
Add modules cache As discusses in #554 , we should use a module cache directory outside of the python packages directory since we may not have write permissions. I added a new HF_MODULES_PATH directory that is added to the python path when doing `import nlp`. In this directory, a module `nlp_modules` is created so ...
[ "All the tests pass on my side. Not sure if it is a cache issue or a pytest issue or a circleci issue.\r\nEDIT: I have the same error on google colab. Trying to fix that", "I think I fixed it (sorry didn't notice you were on it as well)" ]
https://api.github.com/repos/huggingface/datasets/issues/573
573
Faster caching for text dataset
As mentioned in #546 and #548 , hashing `data_files` contents to get the cache directory name for a text dataset can take a long time. To make it faster I changed the hashing so that it takes into account the `path` and the `last modified timestamp` of each data file, instead of iterating through the content of each...
closed
2020-09-04T11:58:34
https://api.github.com/repos/huggingface/datasets/issues/573/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/573", "html_url": "https://github.com/huggingface/datasets/pull/573", "diff_url": "https://github.com/huggingface/datasets/pull/573.diff", "patch_url": "https://github.com/huggingface/datasets/pull/573.patch", "merged_at": "2020-09-04T12:53:23"...
true
Faster caching for text dataset As mentioned in #546 and #548 , hashing `data_files` contents to get the cache directory name for a text dataset can take a long time. To make it faster I changed the hashing so that it takes into account the `path` and the `last modified timestamp` of each data file, instead of itera...
[]
https://api.github.com/repos/huggingface/datasets/issues/572
572
Add CLUE Benchmark (11 datasets)
Add 11 tasks of [CLUE](https://github.com/CLUEbenchmark/CLUE).
closed
2020-09-04T01:57:40
https://api.github.com/repos/huggingface/datasets/issues/572/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/572", "html_url": "https://github.com/huggingface/datasets/pull/572", "diff_url": "https://github.com/huggingface/datasets/pull/572.diff", "patch_url": "https://github.com/huggingface/datasets/pull/572.patch", "merged_at": "2020-09-07T09:59:10"...
true
Add CLUE Benchmark (11 datasets) Add 11 tasks of [CLUE](https://github.com/CLUEbenchmark/CLUE).
[ "Thanks, @lhoestq! I've addressed the comments. \r\nAlso, I have tried to use `ClassLabel` [when possible](https://github.com/huggingface/nlp/pull/572/files#diff-1026ac7d7b78bf029cb0ebe63162c77dR297). Is there still somewhere else we can use `ClassLabel`? ", "I believe CI failure is unrelated.", "Great job! " ]
https://api.github.com/repos/huggingface/datasets/issues/571
571
Serialization
I added `save` and `load` method to serialize/deserialize a dataset object in a folder. It moves the arrow files there (or write them if the tables were in memory), and saves the pickle state in a json file `state.json`, except the info that are in a separate file `dataset_info.json`. Example: ```python import ...
closed
2020-09-03T16:21:38
https://api.github.com/repos/huggingface/datasets/issues/571/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/571", "html_url": "https://github.com/huggingface/datasets/pull/571", "diff_url": "https://github.com/huggingface/datasets/pull/571.diff", "patch_url": "https://github.com/huggingface/datasets/pull/571.patch", "merged_at": "2020-09-07T07:46:07"...
true
Serialization I added `save` and `load` method to serialize/deserialize a dataset object in a folder. It moves the arrow files there (or write them if the tables were in memory), and saves the pickle state in a json file `state.json`, except the info that are in a separate file `dataset_info.json`. Example: ```p...
[ "I've added save/load for dataset dicts.\r\n\r\nI agree that in the future we should also have a way to save indexes too, and also the in-place history of transforms.\r\n\r\nAlso I understand that it would be cool to have the load function directly at the root of the library, but I'm not sure this should be inside ...
https://api.github.com/repos/huggingface/datasets/issues/570
570
add reuters21578 dataset
Reopen a PR this the merge.
closed
2020-09-03T10:25:47
https://api.github.com/repos/huggingface/datasets/issues/570/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/570", "html_url": "https://github.com/huggingface/datasets/pull/570", "diff_url": "https://github.com/huggingface/datasets/pull/570.diff", "patch_url": "https://github.com/huggingface/datasets/pull/570.patch", "merged_at": "2020-09-03T10:46:51"...
true
add reuters21578 dataset Reopen a PR this the merge.
[]
https://api.github.com/repos/huggingface/datasets/issues/569
569
Revert "add reuters21578 dataset"
Reverts huggingface/nlp#471
closed
2020-09-03T10:06:16
https://api.github.com/repos/huggingface/datasets/issues/569/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/569", "html_url": "https://github.com/huggingface/datasets/pull/569", "diff_url": "https://github.com/huggingface/datasets/pull/569.diff", "patch_url": "https://github.com/huggingface/datasets/pull/569.patch", "merged_at": "2020-09-03T10:07:12"...
true
Revert "add reuters21578 dataset" Reverts huggingface/nlp#471
[]
https://api.github.com/repos/huggingface/datasets/issues/568
568
`metric.compute` throws `ArrowInvalid` error
I get the following error with `rouge.compute`. It happens only with distributed training, and it occurs randomly I can't easily reproduce it. This is using `nlp==0.4.0` ``` File "/home/beltagy/trainer.py", line 92, in validation_step rouge_scores = rouge.compute(predictions=generated_str, references=gold_st...
closed
2020-09-03T04:56:57
https://api.github.com/repos/huggingface/datasets/issues/568/comments
null
false
`metric.compute` throws `ArrowInvalid` error I get the following error with `rouge.compute`. It happens only with distributed training, and it occurs randomly I can't easily reproduce it. This is using `nlp==0.4.0` ``` File "/home/beltagy/trainer.py", line 92, in validation_step rouge_scores = rouge.compute(...
[ "Hmm might be related to what we are solving in #564", "Could you try to update to `datasets>=1.0.0` (we changed the name of the library) and try again ?\r\nIf is was related to the distributed setup settings it must be fixed.\r\nIf it was related to empty metric inputs it's going to be fixed in #654 ", "Closin...
https://api.github.com/repos/huggingface/datasets/issues/567
567
Fix BLEURT metrics for backward compatibility
Fix #565
closed
2020-09-02T21:22:35
https://api.github.com/repos/huggingface/datasets/issues/567/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/567", "html_url": "https://github.com/huggingface/datasets/pull/567", "diff_url": "https://github.com/huggingface/datasets/pull/567.diff", "patch_url": "https://github.com/huggingface/datasets/pull/567.patch", "merged_at": "2020-09-03T07:29:50"...
true
Fix BLEURT metrics for backward compatibility Fix #565
[]
https://api.github.com/repos/huggingface/datasets/issues/566
566
Remove logger pickling to fix gg colab issues
A `logger` objects are not picklable in google colab, contrary to `logger` objects in jupyter notebooks or in python shells. It creates some issues in google colab right now. Indeed by calling any `Dataset` method, the fingerprint update pickles the transform function, and as the logger comes with it, it results in...
closed
2020-09-02T16:16:21
https://api.github.com/repos/huggingface/datasets/issues/566/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/566", "html_url": "https://github.com/huggingface/datasets/pull/566", "diff_url": "https://github.com/huggingface/datasets/pull/566.diff", "patch_url": "https://github.com/huggingface/datasets/pull/566.patch", "merged_at": "2020-09-03T16:31:52"...
true
Remove logger pickling to fix gg colab issues A `logger` objects are not picklable in google colab, contrary to `logger` objects in jupyter notebooks or in python shells. It creates some issues in google colab right now. Indeed by calling any `Dataset` method, the fingerprint update pickles the transform function, ...
[]
https://api.github.com/repos/huggingface/datasets/issues/565
565
No module named 'nlp.logging'
Hi, I am using nlp version 0.4.0. Trying to use bleurt as an eval metric, however, the bleurt script imports nlp.logging which creates the following error. What am I missing? ``` >>> import nlp 2020-09-02 13:47:09.210310: I tensorflow/stream_executor/platform/default/dso_loader.cc:48] Successfully opened dynamic l...
closed
2020-09-02T13:49:50
https://api.github.com/repos/huggingface/datasets/issues/565/comments
null
false
No module named 'nlp.logging' Hi, I am using nlp version 0.4.0. Trying to use bleurt as an eval metric, however, the bleurt script imports nlp.logging which creates the following error. What am I missing? ``` >>> import nlp 2020-09-02 13:47:09.210310: I tensorflow/stream_executor/platform/default/dso_loader.cc:48]...
[ "Thanks for reporting.\r\n\r\nApparently this is a versioning issue: the lib downloaded the `bleurt` script from the master branch where we did this change recently. We'll fix that in a new release this week or early next week. Cc @thomwolf \r\n\r\nUntil that, I'd suggest you to download the right bleurt folder fro...
https://api.github.com/repos/huggingface/datasets/issues/564
564
Wait for writing in distributed metrics
There were CI bugs where a distributed metric would try to read all the files in process 0 while the other processes haven't started writing. To fix that I added a custom locking mechanism that waits for the file to exist before trying to read it
closed
2020-09-02T12:58:50
https://api.github.com/repos/huggingface/datasets/issues/564/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/564", "html_url": "https://github.com/huggingface/datasets/pull/564", "diff_url": "https://github.com/huggingface/datasets/pull/564.diff", "patch_url": "https://github.com/huggingface/datasets/pull/564.patch", "merged_at": "2020-09-09T09:13:22"...
true
Wait for writing in distributed metrics There were CI bugs where a distributed metric would try to read all the files in process 0 while the other processes haven't started writing. To fix that I added a custom locking mechanism that waits for the file to exist before trying to read it
[ "I agree this fix the problem for the CI where the files are always created in a new and clean temporary directory.\r\n\r\nHowever, in a general setting of a succession of fast distributed operation, the files could already exist from previous metrics runs but one process may still finish before another has even st...
https://api.github.com/repos/huggingface/datasets/issues/563
563
[Large datasets] Speed up download and processing
Various improvements to speed-up creation and processing of large scale datasets. Currently: - distributed downloads - remove etag from datafiles hashes to spare a request when restarting a failed download
closed
2020-09-02T10:31:54
https://api.github.com/repos/huggingface/datasets/issues/563/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/563", "html_url": "https://github.com/huggingface/datasets/pull/563", "diff_url": "https://github.com/huggingface/datasets/pull/563.diff", "patch_url": "https://github.com/huggingface/datasets/pull/563.patch", "merged_at": "2020-09-09T09:03:32"...
true
[Large datasets] Speed up download and processing Various improvements to speed-up creation and processing of large scale datasets. Currently: - distributed downloads - remove etag from datafiles hashes to spare a request when restarting a failed download
[ "Looks all good :)\r\nI rebased from master and added a test for parallel `map_nested`", "you're da best" ]
https://api.github.com/repos/huggingface/datasets/issues/562
562
[Reproductibility] Allow to pin versions of datasets/metrics
Repurpose the `version` attribute in datasets and metrics to let the user pin a specific version of datasets and metric scripts: ``` dataset = nlp.load_dataset('squad', version='1.0.0') metric = nlp.load_metric('squad', version='1.0.0') ``` Notes: - version number are the release version of the library - curre...
closed
2020-09-02T10:30:13
https://api.github.com/repos/huggingface/datasets/issues/562/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/562", "html_url": "https://github.com/huggingface/datasets/pull/562", "diff_url": "https://github.com/huggingface/datasets/pull/562.diff", "patch_url": "https://github.com/huggingface/datasets/pull/562.patch", "merged_at": null }
true
[Reproductibility] Allow to pin versions of datasets/metrics Repurpose the `version` attribute in datasets and metrics to let the user pin a specific version of datasets and metric scripts: ``` dataset = nlp.load_dataset('squad', version='1.0.0') metric = nlp.load_metric('squad', version='1.0.0') ``` Notes: - v...
[ "Closing this one in favor of #584 " ]
https://api.github.com/repos/huggingface/datasets/issues/561
561
Made `share_dataset` more readable
closed
2020-09-02T09:34:48
https://api.github.com/repos/huggingface/datasets/issues/561/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/561", "html_url": "https://github.com/huggingface/datasets/pull/561", "diff_url": "https://github.com/huggingface/datasets/pull/561.diff", "patch_url": "https://github.com/huggingface/datasets/pull/561.patch", "merged_at": "2020-09-03T09:00:29"...
true
Made `share_dataset` more readable
[]
https://api.github.com/repos/huggingface/datasets/issues/560
560
Using custom DownloadConfig results in an error
## Version / Environment Ubuntu 18.04 Python 3.6.8 nlp 0.4.0 ## Description Loading `imdb` dataset works fine when when I don't specify any `download_config` argument. When I create a custom `DownloadConfig` object and pass it to the `nlp.load_dataset` function, this results in an error. ## How to reprodu...
closed
2020-09-01T22:23:02
https://api.github.com/repos/huggingface/datasets/issues/560/comments
null
false
Using custom DownloadConfig results in an error ## Version / Environment Ubuntu 18.04 Python 3.6.8 nlp 0.4.0 ## Description Loading `imdb` dataset works fine when when I don't specify any `download_config` argument. When I create a custom `DownloadConfig` object and pass it to the `nlp.load_dataset` function...
[ "From my limited understanding, part of the issue seems related to the `prepare_module` and `download_and_prepare` functions each handling the case where no config is passed. For example, `prepare_module` does mutate the object passed and forces the flags `extract_compressed_file` and `force_extract` to `True`.\r\...
https://api.github.com/repos/huggingface/datasets/issues/559
559
Adding the KILT knowledge source and tasks
This adds Wikipedia pre-processed for KILT, as well as the task data. Only the question IDs are provided for TriviaQA, but they can easily be mapped back with: ``` import nlp kilt_wikipedia = nlp.load_dataset('kilt_wikipedia') kilt_tasks = nlp.load_dataset('kilt_tasks') triviaqa = nlp.load_dataset('trivia_qa',...
closed
2020-09-01T20:05:13
https://api.github.com/repos/huggingface/datasets/issues/559/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/559", "html_url": "https://github.com/huggingface/datasets/pull/559", "diff_url": "https://github.com/huggingface/datasets/pull/559.diff", "patch_url": "https://github.com/huggingface/datasets/pull/559.patch", "merged_at": "2020-09-04T18:05:47"...
true
Adding the KILT knowledge source and tasks This adds Wikipedia pre-processed for KILT, as well as the task data. Only the question IDs are provided for TriviaQA, but they can easily be mapped back with: ``` import nlp kilt_wikipedia = nlp.load_dataset('kilt_wikipedia') kilt_tasks = nlp.load_dataset('kilt_tasks'...
[ "Feel free to merge when you are happy with it @yjernite :-)" ]
https://api.github.com/repos/huggingface/datasets/issues/558
558
Rerun pip install -e
Hopefully it fixes the github actions
closed
2020-09-01T17:24:39
https://api.github.com/repos/huggingface/datasets/issues/558/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/558", "html_url": "https://github.com/huggingface/datasets/pull/558", "diff_url": "https://github.com/huggingface/datasets/pull/558.diff", "patch_url": "https://github.com/huggingface/datasets/pull/558.patch", "merged_at": "2020-09-01T17:24:50"...
true
Rerun pip install -e Hopefully it fixes the github actions
[]
https://api.github.com/repos/huggingface/datasets/issues/557
557
Fix a few typos
closed
2020-09-01T15:03:24
https://api.github.com/repos/huggingface/datasets/issues/557/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/557", "html_url": "https://github.com/huggingface/datasets/pull/557", "diff_url": "https://github.com/huggingface/datasets/pull/557.diff", "patch_url": "https://github.com/huggingface/datasets/pull/557.patch", "merged_at": "2020-09-02T07:39:06"...
true
Fix a few typos
[]
https://api.github.com/repos/huggingface/datasets/issues/556
556
Add DailyDialog
http://yanran.li/dailydialog.html https://arxiv.org/pdf/1710.03957.pdf
closed
2020-09-01T15:01:15
https://api.github.com/repos/huggingface/datasets/issues/556/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/556", "html_url": "https://github.com/huggingface/datasets/pull/556", "diff_url": "https://github.com/huggingface/datasets/pull/556.diff", "patch_url": "https://github.com/huggingface/datasets/pull/556.patch", "merged_at": "2020-09-03T15:38:39"...
true
Add DailyDialog http://yanran.li/dailydialog.html https://arxiv.org/pdf/1710.03957.pdf
[]
https://api.github.com/repos/huggingface/datasets/issues/555
555
Upgrade pip in benchmark github action
It looks like it fixes the `import nlp` issue we have
closed
2020-09-01T14:37:26
https://api.github.com/repos/huggingface/datasets/issues/555/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/555", "html_url": "https://github.com/huggingface/datasets/pull/555", "diff_url": "https://github.com/huggingface/datasets/pull/555.diff", "patch_url": "https://github.com/huggingface/datasets/pull/555.patch", "merged_at": "2020-09-01T15:26:15"...
true
Upgrade pip in benchmark github action It looks like it fixes the `import nlp` issue we have
[]
https://api.github.com/repos/huggingface/datasets/issues/554
554
nlp downloads to its module path
I am trying to package `nlp` for Nix, because it is now an optional dependency for `transformers`. The problem that I encounter is that the `nlp` library downloads to the module path, which is typically not writable in most package management systems: ```>>> import nlp >>> squad_dataset = nlp.load_dataset('squad') ...
closed
2020-09-01T14:06:14
https://api.github.com/repos/huggingface/datasets/issues/554/comments
null
false
nlp downloads to its module path I am trying to package `nlp` for Nix, because it is now an optional dependency for `transformers`. The problem that I encounter is that the `nlp` library downloads to the module path, which is typically not writable in most package management systems: ```>>> import nlp >>> squad_dat...
[ "Indeed this is a known issue arising from the fact that we try to be compatible with cloupickle.\r\n\r\nDoes this also happen if you are installing in a virtual environment?", "> Indeed this is a know issue with the fact that we try to be compatible with cloupickle.\r\n> \r\n> Does this also happen if you are in...
https://api.github.com/repos/huggingface/datasets/issues/553
553
[Fix GitHub Actions] test adding tmate
closed
2020-09-01T13:28:03
https://api.github.com/repos/huggingface/datasets/issues/553/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/553", "html_url": "https://github.com/huggingface/datasets/pull/553", "diff_url": "https://github.com/huggingface/datasets/pull/553.diff", "patch_url": "https://github.com/huggingface/datasets/pull/553.patch", "merged_at": null }
true
[Fix GitHub Actions] test adding tmate
[]
https://api.github.com/repos/huggingface/datasets/issues/552
552
Add multiprocessing
Adding multiprocessing to `.map` It works in 3 steps: - shard the dataset in `num_proc` shards - spawn one process per shard and call `map` on them - concatenate the resulting datasets Example of usage: ```python from nlp import load_dataset dataset = load_dataset("squad", split="train") def function...
closed
2020-09-01T11:56:17
https://api.github.com/repos/huggingface/datasets/issues/552/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/552", "html_url": "https://github.com/huggingface/datasets/pull/552", "diff_url": "https://github.com/huggingface/datasets/pull/552.diff", "patch_url": "https://github.com/huggingface/datasets/pull/552.patch", "merged_at": "2020-09-02T10:01:25"...
true
Add multiprocessing Adding multiprocessing to `.map` It works in 3 steps: - shard the dataset in `num_proc` shards - spawn one process per shard and call `map` on them - concatenate the resulting datasets Example of usage: ```python from nlp import load_dataset dataset = load_dataset("squad", split="tra...
[ "Logging looks like\r\n\r\n```\r\nDone writing 21900 indices in 3854400 bytes .\r\nProcess #0 will write at playground/tmp_00000_of_00004.arrow\r\nDone writing 21900 indices in 3854400 bytes .\r\nProcess #1 will write at playground/tmp_00001_of_00004.arrow\r\nDone writing 21900 indices in 3854400 bytes .\r\nProcess...
https://api.github.com/repos/huggingface/datasets/issues/551
551
added HANS dataset
Adds the [HANS](https://github.com/tommccoy1/hans) dataset to evaluate NLI systems.
closed
2020-09-01T10:42:02
https://api.github.com/repos/huggingface/datasets/issues/551/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/551", "html_url": "https://github.com/huggingface/datasets/pull/551", "diff_url": "https://github.com/huggingface/datasets/pull/551.diff", "patch_url": "https://github.com/huggingface/datasets/pull/551.patch", "merged_at": "2020-09-01T12:17:10"...
true
added HANS dataset Adds the [HANS](https://github.com/tommccoy1/hans) dataset to evaluate NLI systems.
[]
https://api.github.com/repos/huggingface/datasets/issues/550
550
[BUGFIX] Solving mismatched checksum issue for the LinCE dataset (#539)
Hi, I have added the updated `dataset_infos.json` file for the LinCE benchmark. This update is to fix the mismatched checksum bug #539 for one of the datasets in the LinCE benchmark. To update the file, I run this command from the nlp root directory: ``` python nlp-cli test ./datasets/lince --save_infos --all_co...
closed
2020-09-01T03:27:03
https://api.github.com/repos/huggingface/datasets/issues/550/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/550", "html_url": "https://github.com/huggingface/datasets/pull/550", "diff_url": "https://github.com/huggingface/datasets/pull/550.diff", "patch_url": "https://github.com/huggingface/datasets/pull/550.patch", "merged_at": "2020-09-03T09:06:01"...
true
[BUGFIX] Solving mismatched checksum issue for the LinCE dataset (#539) Hi, I have added the updated `dataset_infos.json` file for the LinCE benchmark. This update is to fix the mismatched checksum bug #539 for one of the datasets in the LinCE benchmark. To update the file, I run this command from the nlp root direc...
[ "Thanks a lot for that!\r\nThe line you are mentioning is a bug indeed, do you mind fixing it at the same time?", "No worries! \r\n\r\nI pushed right away the fix, but then I realized that the master branch already had it, so I ended up merging the master branch with lince locally and then overwriting the previou...
https://api.github.com/repos/huggingface/datasets/issues/549
549
Fix bleurt logging import
Bleurt started throwing an error in some code we have. This looks like the fix but... It's also unnerving that even a prebuilt docker image with pinned versions can be working 1 day and then fail the next (especially for production systems). Any way for us to pin your metrics code so that they are guaranteed not...
closed
2020-09-01T03:01:25
https://api.github.com/repos/huggingface/datasets/issues/549/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/549", "html_url": "https://github.com/huggingface/datasets/pull/549", "diff_url": "https://github.com/huggingface/datasets/pull/549.diff", "patch_url": "https://github.com/huggingface/datasets/pull/549.patch", "merged_at": null }
true
Fix bleurt logging import Bleurt started throwing an error in some code we have. This looks like the fix but... It's also unnerving that even a prebuilt docker image with pinned versions can be working 1 day and then fail the next (especially for production systems). Any way for us to pin your metrics code so th...
[ "That’s a good point that we started to discuss internally as well. We should pin the dataset en metrics code by default indeed.\r\nLet’s update this in the coming release.", "Ok closed this with #567 and we are working on a more general solution to pin dataset version in #562 (should be in the coming release)." ...
https://api.github.com/repos/huggingface/datasets/issues/548
548
[Breaking] Switch text loading to multi-threaded PyArrow loading
Test if we can get better performances for large-scale text datasets by using multi-threaded text file loading based on Apache Arrow multi-threaded CSV loader. If it works ok, it would fix #546. **Breaking change**: The text lines now do not include final line-breaks anymore.
closed
2020-08-31T15:15:41
https://api.github.com/repos/huggingface/datasets/issues/548/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/548", "html_url": "https://github.com/huggingface/datasets/pull/548", "diff_url": "https://github.com/huggingface/datasets/pull/548.diff", "patch_url": "https://github.com/huggingface/datasets/pull/548.patch", "merged_at": "2020-09-08T10:19:57"...
true
[Breaking] Switch text loading to multi-threaded PyArrow loading Test if we can get better performances for large-scale text datasets by using multi-threaded text file loading based on Apache Arrow multi-threaded CSV loader. If it works ok, it would fix #546. **Breaking change**: The text lines now do not includ...
[ "Awesome !\r\nAlso I was wondering if we should try to make the hashing of the `data_files` faster (it is used to build the cache directory of datasets like `text` or `json`). Right now it reads each file and hashes all of its data. We could simply hash the path and some metadata including the `time last modified` ...
https://api.github.com/repos/huggingface/datasets/issues/547
547
[Distributed] Making loading distributed datasets a bit safer
Add some file-locks during dataset loading
closed
2020-08-31T14:51:34
https://api.github.com/repos/huggingface/datasets/issues/547/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/547", "html_url": "https://github.com/huggingface/datasets/pull/547", "diff_url": "https://github.com/huggingface/datasets/pull/547.diff", "patch_url": "https://github.com/huggingface/datasets/pull/547.patch", "merged_at": "2020-08-31T15:16:29"...
true
[Distributed] Making loading distributed datasets a bit safer Add some file-locks during dataset loading
[]
https://api.github.com/repos/huggingface/datasets/issues/546
546
Very slow data loading on large dataset
I made a simple python script to check the NLP library speed, which loads 1.1 TB of textual data. It has been 8 hours and still, it is on the loading steps. It does work when the text dataset size is small about 1 GB, but it doesn't scale. It also uses a single thread during the data loading step. ``` train_fil...
closed
2020-08-31T12:57:23
https://api.github.com/repos/huggingface/datasets/issues/546/comments
null
false
Very slow data loading on large dataset I made a simple python script to check the NLP library speed, which loads 1.1 TB of textual data. It has been 8 hours and still, it is on the loading steps. It does work when the text dataset size is small about 1 GB, but it doesn't scale. It also uses a single thread during ...
[ "When you load a text file for the first time with `nlp`, the file is converted into Apache Arrow format. Arrow allows to use memory-mapping, which means that you can load an arbitrary large dataset.\r\n\r\nNote that as soon as the conversion has been done once, the next time you'll load the dataset it will be much...
https://api.github.com/repos/huggingface/datasets/issues/545
545
New release coming up for this library
Hi all, A few words on the roadmap for this library. The next release will be a big one and is planed at the end of this week. In addition to the support for indexed datasets (useful for non-parametric models like REALM, RAG, DPR, knn-LM and many other fast dataset retrieval technics), it will: - have support f...
closed
2020-08-31T11:37:38
https://api.github.com/repos/huggingface/datasets/issues/545/comments
null
false
New release coming up for this library Hi all, A few words on the roadmap for this library. The next release will be a big one and is planed at the end of this week. In addition to the support for indexed datasets (useful for non-parametric models like REALM, RAG, DPR, knn-LM and many other fast dataset retrieva...
[ "Update: release is planed mid-next week." ]
https://api.github.com/repos/huggingface/datasets/issues/544
544
[Distributed] Fix load_dataset error when multiprocessing + add test
Fix #543 + add test
closed
2020-08-31T09:30:10
https://api.github.com/repos/huggingface/datasets/issues/544/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/544", "html_url": "https://github.com/huggingface/datasets/pull/544", "diff_url": "https://github.com/huggingface/datasets/pull/544.diff", "patch_url": "https://github.com/huggingface/datasets/pull/544.patch", "merged_at": "2020-08-31T11:15:10"...
true
[Distributed] Fix load_dataset error when multiprocessing + add test Fix #543 + add test
[]
https://api.github.com/repos/huggingface/datasets/issues/543
543
nlp.load_dataset is not safe for multi processes when loading from local files
Loading from local files, e.g., `dataset = nlp.load_dataset('csv', data_files=['file_1.csv', 'file_2.csv'])` concurrently from multiple processes, will raise `FileExistsError` from builder's line 430, https://github.com/huggingface/nlp/blob/6655008c738cb613c522deb3bd18e35a67b2a7e5/src/nlp/builder.py#L423-L438 Likel...
closed
2020-08-30T03:20:34
https://api.github.com/repos/huggingface/datasets/issues/543/comments
null
false
nlp.load_dataset is not safe for multi processes when loading from local files Loading from local files, e.g., `dataset = nlp.load_dataset('csv', data_files=['file_1.csv', 'file_2.csv'])` concurrently from multiple processes, will raise `FileExistsError` from builder's line 430, https://github.com/huggingface/nlp/blob...
[ "I'll take a look!" ]
https://api.github.com/repos/huggingface/datasets/issues/542
542
Add TensorFlow example
Update the Quick Tour documentation in order to add the TensorFlow equivalent source code for the classification example. Now it is possible to select either the code in PyTorch or in TensorFlow in the Quick tour.
closed
2020-08-29T15:39:27
https://api.github.com/repos/huggingface/datasets/issues/542/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/542", "html_url": "https://github.com/huggingface/datasets/pull/542", "diff_url": "https://github.com/huggingface/datasets/pull/542.diff", "patch_url": "https://github.com/huggingface/datasets/pull/542.patch", "merged_at": "2020-08-31T09:49:19"...
true
Add TensorFlow example Update the Quick Tour documentation in order to add the TensorFlow equivalent source code for the classification example. Now it is possible to select either the code in PyTorch or in TensorFlow in the Quick tour.
[]
https://api.github.com/repos/huggingface/datasets/issues/541
541
Best practices for training tokenizers with nlp
Hi, thank you for developing this library. What do you think are the best practices for training tokenizers using `nlp`? In the document and examples, I could only find pre-trained tokenizers used.
closed
2020-08-29T12:06:49
https://api.github.com/repos/huggingface/datasets/issues/541/comments
null
false
Best practices for training tokenizers with nlp Hi, thank you for developing this library. What do you think are the best practices for training tokenizers using `nlp`? In the document and examples, I could only find pre-trained tokenizers used.
[ "Docs that explain how to train a tokenizer with `datasets` are available here: https://huggingface.co/docs/tokenizers/training_from_memory#using-the-datasets-library" ]
https://api.github.com/repos/huggingface/datasets/issues/540
540
[BUGFIX] Fix Race Dataset Checksum bug
In #537 I noticed that there was a bug in checksum checking when I have tried to download the race dataset. The reason for this is that the current preprocessing was just considering the `high school` data and it was ignoring the `middle` one. This PR just fixes it :) Moreover, I have added some descriptions.
closed
2020-08-29T07:00:10
https://api.github.com/repos/huggingface/datasets/issues/540/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/540", "html_url": "https://github.com/huggingface/datasets/pull/540", "diff_url": "https://github.com/huggingface/datasets/pull/540.diff", "patch_url": "https://github.com/huggingface/datasets/pull/540.patch", "merged_at": "2020-09-18T11:42:20"...
true
[BUGFIX] Fix Race Dataset Checksum bug In #537 I noticed that there was a bug in checksum checking when I have tried to download the race dataset. The reason for this is that the current preprocessing was just considering the `high school` data and it was ignoring the `middle` one. This PR just fixes it :) Moreover,...
[ "I'm not sure this would fix #537 .\r\nHowever your point about the missing `middle` data is right and we probably want to include these data as well.\r\nDo you think it would we worth having different configurations for this dataset for users who want to only load part of it (`high school` or `middle` or `all`) ?"...
https://api.github.com/repos/huggingface/datasets/issues/539
539
[Dataset] `NonMatchingChecksumError` due to an update in the LinCE benchmark data
Hi, There is a `NonMatchingChecksumError` error for the `lid_msaea` (language identification for Modern Standard Arabic - Egyptian Arabic) dataset from the LinCE benchmark due to a minor update on that dataset. How can I update the checksum of the library to solve this issue? The error is below and it also appea...
closed
2020-08-28T19:55:51
https://api.github.com/repos/huggingface/datasets/issues/539/comments
null
false
[Dataset] `NonMatchingChecksumError` due to an update in the LinCE benchmark data Hi, There is a `NonMatchingChecksumError` error for the `lid_msaea` (language identification for Modern Standard Arabic - Egyptian Arabic) dataset from the LinCE benchmark due to a minor update on that dataset. How can I update the...
[ "Hi @gaguilar \r\n\r\nIf you want to take care of this, it very simple, you just need to regenerate the `dataset_infos.json` file as indicated [in the doc](https://huggingface.co/nlp/share_dataset.html#adding-metadata) by [installing from source](https://huggingface.co/nlp/installation.html#installing-from-source) ...
https://api.github.com/repos/huggingface/datasets/issues/538
538
[logging] Add centralized logging - Bump-up cache loads to warnings
Add a `nlp.logging` module to set the global logging level easily. The verbosity level also controls the tqdm bars (disabled when set higher than INFO). You can use: ``` nlp.logging.set_verbosity(verbosity: int) nlp.logging.set_verbosity_info() nlp.logging.set_verbosity_warning() nlp.logging.set_verbosity_debug...
closed
2020-08-28T11:42:29
https://api.github.com/repos/huggingface/datasets/issues/538/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/538", "html_url": "https://github.com/huggingface/datasets/pull/538", "diff_url": "https://github.com/huggingface/datasets/pull/538.diff", "patch_url": "https://github.com/huggingface/datasets/pull/538.patch", "merged_at": "2020-08-31T11:42:50"...
true
[logging] Add centralized logging - Bump-up cache loads to warnings Add a `nlp.logging` module to set the global logging level easily. The verbosity level also controls the tqdm bars (disabled when set higher than INFO). You can use: ``` nlp.logging.set_verbosity(verbosity: int) nlp.logging.set_verbosity_info() ...
[]
https://api.github.com/repos/huggingface/datasets/issues/537
537
[Dataset] RACE dataset Checksums error
Hi there, I just would like to use this awesome lib to perform a dataset fine-tuning on RACE dataset. I have performed the following steps: ``` dataset = nlp.load_dataset("race") len(dataset["train"]), len(dataset["validation"]) ``` But then I got the following error: ``` ----------------------------------...
closed
2020-08-27T23:58:16
https://api.github.com/repos/huggingface/datasets/issues/537/comments
null
false
[Dataset] RACE dataset Checksums error Hi there, I just would like to use this awesome lib to perform a dataset fine-tuning on RACE dataset. I have performed the following steps: ``` dataset = nlp.load_dataset("race") len(dataset["train"]), len(dataset["validation"]) ``` But then I got the following error: ...
[ "`NonMatchingChecksumError` means that the checksum of the downloaded file is not the expected one.\r\nEither the file you downloaded was corrupted along the way, or the host updated the file.\r\nCould you try to clear your cache and run `load_dataset` again ? If the error is still there, it means that there was an...
https://api.github.com/repos/huggingface/datasets/issues/536
536
Fingerprint
This PR is a continuation of #513 , in which many in-place functions were introduced or updated (cast_, flatten_) etc. However the caching didn't handle these changes. Indeed the caching took into account only the previous cache file name of the table, and not the possible in-place transforms of the table. To fix t...
closed
2020-08-27T16:27:09
https://api.github.com/repos/huggingface/datasets/issues/536/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/536", "html_url": "https://github.com/huggingface/datasets/pull/536", "diff_url": "https://github.com/huggingface/datasets/pull/536.diff", "patch_url": "https://github.com/huggingface/datasets/pull/536.patch", "merged_at": "2020-08-31T14:20:39"...
true
Fingerprint This PR is a continuation of #513 , in which many in-place functions were introduced or updated (cast_, flatten_) etc. However the caching didn't handle these changes. Indeed the caching took into account only the previous cache file name of the table, and not the possible in-place transforms of the table....
[ "I changed the way I implemented fingerprint updates to use decorator functions.\r\n\r\nI also added a new attribute called `_inplace_history` that stores the in-place history of transforms (like cast_, rename_columns, etc.). This history is useful to replay the changes that were done in-place when unpickling a dat...
https://api.github.com/repos/huggingface/datasets/issues/535
535
Benchmarks
Adding some benchmarks with DVC/CML To add a new tracked benchmark: - create a new python benchmarking script in `./benchmarks/`. The script can use the utilities in `./benchmarks/utils.py` and should output a JSON file with results in `./benchmarks/results/`. - add a new pipeline stage in [dvc.yaml](./dvc.yaml) w...
closed
2020-08-26T11:21:26
https://api.github.com/repos/huggingface/datasets/issues/535/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/535", "html_url": "https://github.com/huggingface/datasets/pull/535", "diff_url": "https://github.com/huggingface/datasets/pull/535.diff", "patch_url": "https://github.com/huggingface/datasets/pull/535.patch", "merged_at": "2020-08-27T08:39:59"...
true
Benchmarks Adding some benchmarks with DVC/CML To add a new tracked benchmark: - create a new python benchmarking script in `./benchmarks/`. The script can use the utilities in `./benchmarks/utils.py` and should output a JSON file with results in `./benchmarks/results/`. - add a new pipeline stage in [dvc.yaml](./...
[]
https://api.github.com/repos/huggingface/datasets/issues/534
534
`list_datasets()` is broken.
version = '0.4.0' `list_datasets()` is broken. It results in the following error : ``` In [3]: nlp.list_datasets() Out[3]: --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) ~/.virtualenvs/san-lgUCsFg_/lib/py...
closed
2020-08-26T08:19:01
https://api.github.com/repos/huggingface/datasets/issues/534/comments
null
false
`list_datasets()` is broken. version = '0.4.0' `list_datasets()` is broken. It results in the following error : ``` In [3]: nlp.list_datasets() Out[3]: --------------------------------------------------------------------------- AttributeError Traceback (most recent call last) ~/.vi...
[ "Thanks for reporting !\r\nThis has been fixed in #475 and the fix will be available in the next release", "What you can do instead to get the list of the datasets is call\r\n\r\n```python\r\nprint([dataset.id for dataset in nlp.list_datasets()])\r\n```", "Thanks @lhoestq . " ]
https://api.github.com/repos/huggingface/datasets/issues/533
533
Fix ArrayXD for pyarrow 0.17.1 by using non fixed length list arrays
It should fix the CI problems in #513
closed
2020-08-25T15:32:44
https://api.github.com/repos/huggingface/datasets/issues/533/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/533", "html_url": "https://github.com/huggingface/datasets/pull/533", "diff_url": "https://github.com/huggingface/datasets/pull/533.diff", "patch_url": "https://github.com/huggingface/datasets/pull/533.patch", "merged_at": "2020-08-26T08:02:23"...
true
Fix ArrayXD for pyarrow 0.17.1 by using non fixed length list arrays It should fix the CI problems in #513
[]
https://api.github.com/repos/huggingface/datasets/issues/532
532
File exists error when used with TPU
Hi, I'm getting a "File exists" error when I use [text dataset](https://github.com/huggingface/nlp/tree/master/datasets/text) for pre-training a RoBERTa model using `transformers` (3.0.2) and `nlp`(0.4.0) on a VM with TPU (v3-8). I modified [line 131 in the original `run_language_modeling.py`](https://github.com/...
open
2020-08-25T14:36:38
https://api.github.com/repos/huggingface/datasets/issues/532/comments
null
false
File exists error when used with TPU Hi, I'm getting a "File exists" error when I use [text dataset](https://github.com/huggingface/nlp/tree/master/datasets/text) for pre-training a RoBERTa model using `transformers` (3.0.2) and `nlp`(0.4.0) on a VM with TPU (v3-8). I modified [line 131 in the original `run_langu...
[ "I am facing probably facing similar issues with \r\n\r\n`wiki40b_en_100_0`", "Could you try to run `dataset = load_dataset(\"text\", data_files=file_path, split=\"train\")` once before calling the script ?\r\n\r\nIt looks like several processes try to create the dataset in arrow format at the same time. If the d...
https://api.github.com/repos/huggingface/datasets/issues/531
531
add concatenate_datasets to the docs
closed
2020-08-25T08:40:05
https://api.github.com/repos/huggingface/datasets/issues/531/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/531", "html_url": "https://github.com/huggingface/datasets/pull/531", "diff_url": "https://github.com/huggingface/datasets/pull/531.diff", "patch_url": "https://github.com/huggingface/datasets/pull/531.patch", "merged_at": "2020-08-25T09:02:19"...
true
add concatenate_datasets to the docs
[]
https://api.github.com/repos/huggingface/datasets/issues/530
530
use ragged tensor by default
I think it's better if it's clear whether the returned tensor is ragged or not when the type is set to tensorflow. Previously it was a tensor (not ragged) if numpy could stack the output (which can change depending on the batch of example you take), which make things difficult to handle, as it may sometimes return a r...
closed
2020-08-24T17:06:15
https://api.github.com/repos/huggingface/datasets/issues/530/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/530", "html_url": "https://github.com/huggingface/datasets/pull/530", "diff_url": "https://github.com/huggingface/datasets/pull/530.diff", "patch_url": "https://github.com/huggingface/datasets/pull/530.patch", "merged_at": "2020-08-24T19:22:25"...
true
use ragged tensor by default I think it's better if it's clear whether the returned tensor is ragged or not when the type is set to tensorflow. Previously it was a tensor (not ragged) if numpy could stack the output (which can change depending on the batch of example you take), which make things difficult to handle, a...
[ "Yes I agree. Maybe something that lets specify different format depending on the column ? Especially to better control dtype and shape (and ragged for tf)\r\n\r\nOh and I forgot: this one should also fix the second issue found in #477 for the next release", "I am running into the same issue with the error messag...
https://api.github.com/repos/huggingface/datasets/issues/529
529
Add MLSUM
Hello (again :) !), So, I started a new branch because of a [rebase issue](https://github.com/huggingface/nlp/pull/463), sorry for the mess. However, the command `pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_mlsum` still fails because there is no default language dataset : the s...
closed
2020-08-24T16:18:35
https://api.github.com/repos/huggingface/datasets/issues/529/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/529", "html_url": "https://github.com/huggingface/datasets/pull/529", "diff_url": "https://github.com/huggingface/datasets/pull/529.diff", "patch_url": "https://github.com/huggingface/datasets/pull/529.patch", "merged_at": "2020-08-26T08:04:10"...
true
Add MLSUM Hello (again :) !), So, I started a new branch because of a [rebase issue](https://github.com/huggingface/nlp/pull/463), sorry for the mess. However, the command `pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_mlsum` still fails because there is no default language datas...
[ "Could you test to run the test using the changes in #527 and let me know if it fixes the issue ? If so I'll merge it and we'll be good to go :)", "Hello, it does work on the fixing real dataset branch. Merci Quentin :)", "Nice, glad to hear that :)\r\nde rien !" ]
https://api.github.com/repos/huggingface/datasets/issues/528
528
fix missing variable names in docs
fix #524
closed
2020-08-24T13:31:48
https://api.github.com/repos/huggingface/datasets/issues/528/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/528", "html_url": "https://github.com/huggingface/datasets/pull/528", "diff_url": "https://github.com/huggingface/datasets/pull/528.diff", "patch_url": "https://github.com/huggingface/datasets/pull/528.patch", "merged_at": "2020-08-25T09:04:03"...
true
fix missing variable names in docs fix #524
[ "The problem came from `default: ` that is rendered differently and hides the parameter names. I changed `default: ...` to `defaults to ...`" ]
https://api.github.com/repos/huggingface/datasets/issues/527
527
Fix config used for slow test on real dataset
As noticed in #470, #474, #476, #504 , the slow test `test_load_real_dataset` couldn't run on datasets that require config parameters. To fix that I replaced it with one test with the first config of BUILDER_CONFIGS `test_load_real_dataset`, and another test that runs all of the configs in BUILDER_CONFIGS `test_load...
closed
2020-08-24T12:39:34
https://api.github.com/repos/huggingface/datasets/issues/527/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/527", "html_url": "https://github.com/huggingface/datasets/pull/527", "diff_url": "https://github.com/huggingface/datasets/pull/527.diff", "patch_url": "https://github.com/huggingface/datasets/pull/527.patch", "merged_at": "2020-08-25T09:20:44"...
true
Fix config used for slow test on real dataset As noticed in #470, #474, #476, #504 , the slow test `test_load_real_dataset` couldn't run on datasets that require config parameters. To fix that I replaced it with one test with the first config of BUILDER_CONFIGS `test_load_real_dataset`, and another test that runs al...
[]
https://api.github.com/repos/huggingface/datasets/issues/526
526
Returning None instead of "python" if dataset is unformatted
Following the discussion on Slack, this small fix ensures that calling `dataset.set_format(type=dataset.format["type"])` works properly. Slightly breaking as calling `dataset.format` when the dataset is unformatted will return `None` instead of `python`.
closed
2020-08-24T12:10:35
https://api.github.com/repos/huggingface/datasets/issues/526/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/526", "html_url": "https://github.com/huggingface/datasets/pull/526", "diff_url": "https://github.com/huggingface/datasets/pull/526.diff", "patch_url": "https://github.com/huggingface/datasets/pull/526.patch", "merged_at": "2020-08-24T12:50:42"...
true
Returning None instead of "python" if dataset is unformatted Following the discussion on Slack, this small fix ensures that calling `dataset.set_format(type=dataset.format["type"])` works properly. Slightly breaking as calling `dataset.format` when the dataset is unformatted will return `None` instead of `python`.
[ "We have to change the tests to expect `None` instead of `python` then", "Merging!" ]
https://api.github.com/repos/huggingface/datasets/issues/525
525
wmt download speed example
Continuing from the slack 1.0 roadmap thread w @lhoestq , I realized the slow downloads is only a thing sometimes. Here are a few examples, I suspect there are multiple issues. All commands were run from the same gcp us-central-1f machine. ``` import nlp nlp.load_dataset('wmt16', 'de-en') ``` Downloads at 49.1 K...
closed
2020-08-21T23:29:06
https://api.github.com/repos/huggingface/datasets/issues/525/comments
null
false
wmt download speed example Continuing from the slack 1.0 roadmap thread w @lhoestq , I realized the slow downloads is only a thing sometimes. Here are a few examples, I suspect there are multiple issues. All commands were run from the same gcp us-central-1f machine. ``` import nlp nlp.load_dataset('wmt16', 'de-en'...
[ "Thanks for creating the issue :)\r\nThe download link for wmt-en-de raw looks like a mirror. We should use that instead of the current url.\r\nIs this mirror official ?\r\n\r\nAlso it looks like for `ro-en` it tried to download other languages. If we manage to only download the one that is asked it'd be cool\r\n\r...