url stringlengths 58 61 | number int64 1 8.23k | title stringlengths 1 290 | body stringlengths 0 228k ⌀ | state stringclasses 2
values | created_at timestamp[s]date 2020-04-14 10:18:02 2026-05-30 09:38:59 | comments_url stringlengths 67 70 | pull_request dict | is_pull_request bool 2
classes | text stringlengths 2 228k | comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/huggingface/datasets/issues/524 | 524 | Some docs are missing parameter names | See https://huggingface.co/nlp/master/package_reference/main_classes.html#nlp.Dataset.map. I believe this is because the parameter names are enclosed in backticks in the docstrings, maybe it's an old docstring format that doesn't work with the current Sphinx version. | closed | 2020-08-21T16:47:34 | https://api.github.com/repos/huggingface/datasets/issues/524/comments | null | false | Some docs are missing parameter names
See https://huggingface.co/nlp/master/package_reference/main_classes.html#nlp.Dataset.map. I believe this is because the parameter names are enclosed in backticks in the docstrings, maybe it's an old docstring format that doesn't work with the current Sphinx version. | [
"Indeed, good catch!"
] |
https://api.github.com/repos/huggingface/datasets/issues/523 | 523 | Speed up Tokenization by optimizing cast_to_python_objects | I changed how `cast_to_python_objects` works to make it faster.
It is used to cast numpy/pytorch/tensorflow/pandas objects to python lists, and it works recursively.
To avoid iterating over possibly long lists, it first checks if the first element that is not None has to be casted.
If the first element needs to be... | closed | 2020-08-20T09:42:02 | https://api.github.com/repos/huggingface/datasets/issues/523/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/523",
"html_url": "https://github.com/huggingface/datasets/pull/523",
"diff_url": "https://github.com/huggingface/datasets/pull/523.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/523.patch",
"merged_at": "2020-08-24T08:54:14"... | true | Speed up Tokenization by optimizing cast_to_python_objects
I changed how `cast_to_python_objects` works to make it faster.
It is used to cast numpy/pytorch/tensorflow/pandas objects to python lists, and it works recursively.
To avoid iterating over possibly long lists, it first checks if the first element that is n... | [
"I took your comments into account and added tests for `cast_to_python_objects`"
] |
https://api.github.com/repos/huggingface/datasets/issues/522 | 522 | dictionnary typo in docs | Many places dictionary is spelled dictionnary, not sure if its on purpose or not.
Fixed in this pr:
https://github.com/huggingface/nlp/pull/521 | closed | 2020-08-20T07:11:05 | https://api.github.com/repos/huggingface/datasets/issues/522/comments | null | false | dictionnary typo in docs
Many places dictionary is spelled dictionnary, not sure if its on purpose or not.
Fixed in this pr:
https://github.com/huggingface/nlp/pull/521 | [
"Thanks!"
] |
https://api.github.com/repos/huggingface/datasets/issues/521 | 521 | Fix dictionnary (dictionary) typo | This error happens many times I'm thinking maybe its spelled like this on purpose? | closed | 2020-08-20T07:09:02 | https://api.github.com/repos/huggingface/datasets/issues/521/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/521",
"html_url": "https://github.com/huggingface/datasets/pull/521",
"diff_url": "https://github.com/huggingface/datasets/pull/521.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/521.patch",
"merged_at": "2020-08-20T07:52:04"... | true | Fix dictionnary (dictionary) typo
This error happens many times I'm thinking maybe its spelled like this on purpose? | [
"Hahah thanks Yonatan. It was not on purpose, we are just not very good at spelling :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/520 | 520 | Transform references for sacrebleu | Currently it is impossible to use sacrebleu when len(predictions) != the number of references per prediction (very uncommon), due to a strange format expected by sacrebleu. If one passes in the data to `nlp.metric.compute()` in sacrebleu format, `nlp` throws an error due to mismatching lengths between predictions and r... | closed | 2020-08-20T00:26:55 | https://api.github.com/repos/huggingface/datasets/issues/520/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/520",
"html_url": "https://github.com/huggingface/datasets/pull/520",
"diff_url": "https://github.com/huggingface/datasets/pull/520.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/520.patch",
"merged_at": "2020-08-20T09:30:53"... | true | Transform references for sacrebleu
Currently it is impossible to use sacrebleu when len(predictions) != the number of references per prediction (very uncommon), due to a strange format expected by sacrebleu. If one passes in the data to `nlp.metric.compute()` in sacrebleu format, `nlp` throws an error due to mismatchin... | [
"I think I agree @lhoestq so I pushed a change.\r\nThanks for your work on the library!"
] |
https://api.github.com/repos/huggingface/datasets/issues/519 | 519 | [BUG] Metrics throwing new error on master since 0.4.0 | The following error occurs when passing in references of type `List[List[str]]` to metrics like bleu.
Wasn't happening on 0.4.0 but happening now on master.
```
File "/usr/local/lib/python3.7/site-packages/nlp/metric.py", line 226, in compute
self.add_batch(predictions=predictions, references=references)
... | closed | 2020-08-19T21:29:15 | https://api.github.com/repos/huggingface/datasets/issues/519/comments | null | false | [BUG] Metrics throwing new error on master since 0.4.0
The following error occurs when passing in references of type `List[List[str]]` to metrics like bleu.
Wasn't happening on 0.4.0 but happening now on master.
```
File "/usr/local/lib/python3.7/site-packages/nlp/metric.py", line 226, in compute
self.add_b... | [
"Update - maybe this is only failing on bleu because I was not tokenizing inputs to the metric",
"Closing - seems to be just forgetting to tokenize. And found the helpful discussion in huggingface/evaluate#105 "
] |
https://api.github.com/repos/huggingface/datasets/issues/518 | 518 | [METRICS, breaking] Refactor caching behavior, pickle/cloudpickle metrics and dataset, add tests on metrics | Move the acquisition of the filelock at a later stage during metrics processing so it can be pickled/cloudpickled after instantiation.
Also add some tests on pickling, concurrent but separate metric instances and concurrent and distributed metric instances.
Changes significantly the caching behavior for the metri... | closed | 2020-08-19T19:43:08 | https://api.github.com/repos/huggingface/datasets/issues/518/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/518",
"html_url": "https://github.com/huggingface/datasets/pull/518",
"diff_url": "https://github.com/huggingface/datasets/pull/518.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/518.patch",
"merged_at": "2020-08-24T16:01:39"... | true | [METRICS, breaking] Refactor caching behavior, pickle/cloudpickle metrics and dataset, add tests on metrics
Move the acquisition of the filelock at a later stage during metrics processing so it can be pickled/cloudpickled after instantiation.
Also add some tests on pickling, concurrent but separate metric instances ... | [
"(test failure is unrelated)",
"As discussed with @thomwolf merging since the hyperparameter-search has been merged in transformers."
] |
https://api.github.com/repos/huggingface/datasets/issues/517 | 517 | add MLDoc dataset | Hi,
I am recommending that someone add MLDoc, a multilingual news topic classification dataset.
- Here's a link to the Github: https://github.com/facebookresearch/MLDoc
- and the paper: http://www.lrec-conf.org/proceedings/lrec2018/pdf/658.pdf
Looks like the dataset contains news stories in multiple languages... | open | 2020-08-19T14:41:59 | https://api.github.com/repos/huggingface/datasets/issues/517/comments | null | false | add MLDoc dataset
Hi,
I am recommending that someone add MLDoc, a multilingual news topic classification dataset.
- Here's a link to the Github: https://github.com/facebookresearch/MLDoc
- and the paper: http://www.lrec-conf.org/proceedings/lrec2018/pdf/658.pdf
Looks like the dataset contains news stories in ... | [
"Any updates on this?",
"This request is still an open issue waiting to be addressed by any community member, @GuillemGSubies.",
"Hi! Triaging older issues this week — I think this one can be closed as out-of-scope for the current `datasets` repo.\n\n- Script-based dataset loaders are no longer added to this re... |
https://api.github.com/repos/huggingface/datasets/issues/516 | 516 | [Breaking] Rename formated to formatted | `formated` is not correct but `formatted` is | closed | 2020-08-19T13:35:23 | https://api.github.com/repos/huggingface/datasets/issues/516/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/516",
"html_url": "https://github.com/huggingface/datasets/pull/516",
"diff_url": "https://github.com/huggingface/datasets/pull/516.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/516.patch",
"merged_at": "2020-08-20T08:41:16"... | true | [Breaking] Rename formated to formatted
`formated` is not correct but `formatted` is | [] |
https://api.github.com/repos/huggingface/datasets/issues/515 | 515 | Fix batched map for formatted dataset | If you had a dataset formatted as numpy for example, and tried to do a batched map, then it would crash because one of the elements from the inputs was missing for unchanged columns (ex: batch of length 999 instead of 1000).
The happened during the creation of the `pa.Table`, since columns had different lengths. | closed | 2020-08-19T13:34:50 | https://api.github.com/repos/huggingface/datasets/issues/515/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/515",
"html_url": "https://github.com/huggingface/datasets/pull/515",
"diff_url": "https://github.com/huggingface/datasets/pull/515.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/515.patch",
"merged_at": "2020-08-20T20:30:42"... | true | Fix batched map for formatted dataset
If you had a dataset formatted as numpy for example, and tried to do a batched map, then it would crash because one of the elements from the inputs was missing for unchanged columns (ex: batch of length 999 instead of 1000).
The happened during the creation of the `pa.Table`, sinc... | [] |
https://api.github.com/repos/huggingface/datasets/issues/514 | 514 | dataset.shuffle(keep_in_memory=True) is never allowed | As of commit ef4aac2, the usage of the parameter `keep_in_memory=True` is never possible: `dataset.select(keep_in_memory=True)`
The commit added the lines
```python
# lines 994-996 in src/nlp/arrow_dataset.py
assert (
not keep_in_memory or cache_file_name is None
), "Please use either... | closed | 2020-08-18T18:47:40 | https://api.github.com/repos/huggingface/datasets/issues/514/comments | null | false | dataset.shuffle(keep_in_memory=True) is never allowed
As of commit ef4aac2, the usage of the parameter `keep_in_memory=True` is never possible: `dataset.select(keep_in_memory=True)`
The commit added the lines
```python
# lines 994-996 in src/nlp/arrow_dataset.py
assert (
not keep_in_memory or ... | [
"This seems to be fixed in #513 for the filter function, replacing `cache_file_name` with `indices_cache_file_name` in the assert. Although not for the `map()` function @thomwolf ",
"Maybe I'm a bit tired but I fail to see the issue here.\r\n\r\nSince `cache_file_name` is `None` by default, if you set `keep_in_me... |
https://api.github.com/repos/huggingface/datasets/issues/513 | 513 | [speedup] Use indices mappings instead of deepcopy for all the samples reordering methods | Use an indices mapping instead of rewriting the dataset for all the samples re-ordering/selection methods (`select`, `sort`, `shuffle`, `shard`, `train_test_split`).
Added a `flatten_indices` method which copy the dataset to a new table to remove the indices mapping with tests.
All the samples re-ordering/selecti... | closed | 2020-08-18T17:36:02 | https://api.github.com/repos/huggingface/datasets/issues/513/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/513",
"html_url": "https://github.com/huggingface/datasets/pull/513",
"diff_url": "https://github.com/huggingface/datasets/pull/513.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/513.patch",
"merged_at": "2020-08-28T08:41:50"... | true | [speedup] Use indices mappings instead of deepcopy for all the samples reordering methods
Use an indices mapping instead of rewriting the dataset for all the samples re-ordering/selection methods (`select`, `sort`, `shuffle`, `shard`, `train_test_split`).
Added a `flatten_indices` method which copy the dataset to a ... | [
"Ok I fixed `concatenate_datasets` and added tests\r\nFeel free to merge if it's good for you @thomwolf ",
"Ok, adding some benchmarks for map/filters and then I'll merge",
"Warning from pytorch that we should maybe consider at some point @lhoestq:\r\n```\r\n/__w/nlp/nlp/src/nlp/arrow_dataset.py:648: UserWarnin... |
https://api.github.com/repos/huggingface/datasets/issues/512 | 512 | Delete CONTRIBUTING.md | closed | 2020-08-18T15:33:25 | https://api.github.com/repos/huggingface/datasets/issues/512/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/512",
"html_url": "https://github.com/huggingface/datasets/pull/512",
"diff_url": "https://github.com/huggingface/datasets/pull/512.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/512.patch",
"merged_at": null
} | true | Delete CONTRIBUTING.md
| [
"😱",
"Yeah, this is spammy behavior. I've reported the user handle."
] | |
https://api.github.com/repos/huggingface/datasets/issues/511 | 511 | dataset.shuffle() and select() resets format. Intended? | Calling `dataset.shuffle()` or `dataset.select()` on a dataset resets its format set by `dataset.set_format()`. Is this intended or an oversight?
When working on quite large datasets that require a lot of preprocessing I find it convenient to save the processed dataset to file using `torch.save("dataset.pt")`. Later... | closed | 2020-08-18T13:46:01 | https://api.github.com/repos/huggingface/datasets/issues/511/comments | null | false | dataset.shuffle() and select() resets format. Intended?
Calling `dataset.shuffle()` or `dataset.select()` on a dataset resets its format set by `dataset.set_format()`. Is this intended or an oversight?
When working on quite large datasets that require a lot of preprocessing I find it convenient to save the processed... | [
"Hi @vegarab yes feel free to open a discussion here.\r\n\r\nThis design choice was not very much thought about.\r\n\r\nSince `dataset.select()` (like all the method without a trailing underscore) is non-destructive and returns a new dataset it has most of its properties initialized from scratch (except the table a... |
https://api.github.com/repos/huggingface/datasets/issues/510 | 510 | Version of numpy to use the library | Thank you so much for your excellent work! I would like to use nlp library in my project. While importing nlp, I am receiving the following error `AttributeError: module 'numpy.random' has no attribute 'Generator'` Numpy version in my project is 1.16.0. May I learn which numpy version is used for the nlp library.
Th... | closed | 2020-08-18T08:59:13 | https://api.github.com/repos/huggingface/datasets/issues/510/comments | null | false | Version of numpy to use the library
Thank you so much for your excellent work! I would like to use nlp library in my project. While importing nlp, I am receiving the following error `AttributeError: module 'numpy.random' has no attribute 'Generator'` Numpy version in my project is 1.16.0. May I learn which numpy versio... | [
"Seems like this method was added in 1.17. I'll add a requirement on this.",
"Thank you so much. After upgrading the numpy library, it worked."
] |
https://api.github.com/repos/huggingface/datasets/issues/509 | 509 | Converting TensorFlow dataset example | Hi,
I want to use TensorFlow datasets with this repo, I noticed you made some conversion script,
can you give a simple example of using it?
Thanks
| closed | 2020-08-16T08:05:20 | https://api.github.com/repos/huggingface/datasets/issues/509/comments | null | false | Converting TensorFlow dataset example
Hi,
I want to use TensorFlow datasets with this repo, I noticed you made some conversion script,
can you give a simple example of using it?
Thanks
| [
"Do you want to convert a dataset script to the tfds format ?\r\nIf so, we currently have a comversion script nlp/commands/convert.py but it is a conversion script that goes from tfds to nlp.\r\nI think it shouldn't be too hard to do the changes in reverse (at some manual adjustments).\r\nIf you manage to make it w... |
https://api.github.com/repos/huggingface/datasets/issues/508 | 508 | TypeError: Receiver() takes no arguments | I am trying to load a wikipedia data set
```
import nlp
from nlp import load_dataset
dataset = load_dataset("wikipedia", "20200501.en", split="train", cache_dir=data_path, beam_runner='DirectRunner')
#dataset = load_dataset('wikipedia', '20200501.sv', cache_dir=data_path, beam_runner='DirectRunner')
```
Th... | closed | 2020-08-16T07:18:16 | https://api.github.com/repos/huggingface/datasets/issues/508/comments | null | false | TypeError: Receiver() takes no arguments
I am trying to load a wikipedia data set
```
import nlp
from nlp import load_dataset
dataset = load_dataset("wikipedia", "20200501.en", split="train", cache_dir=data_path, beam_runner='DirectRunner')
#dataset = load_dataset('wikipedia', '20200501.sv', cache_dir=data_pat... | [
"Which version of Apache Beam do you have (can you copy your full environment info here)?",
"apache-beam==2.23.0\r\nnlp==0.4.0\r\n\r\nFor me this was resolved by running the same python script on Linux (or really WSL). ",
"Do you manage to run a dummy beam pipeline with python on windows ? \r\nYou can test a du... |
https://api.github.com/repos/huggingface/datasets/issues/507 | 507 | Errors when I use | I tried the following example code from https://huggingface.co/deepset/roberta-base-squad2 and got errors
I am using **transformers 3.0.2** code .
from transformers.pipelines import pipeline
from transformers.modeling_auto import AutoModelForQuestionAnswering
from transformers.tokenization_auto import AutoToke... | closed | 2020-08-14T21:03:57 | https://api.github.com/repos/huggingface/datasets/issues/507/comments | null | false | Errors when I use
I tried the following example code from https://huggingface.co/deepset/roberta-base-squad2 and got errors
I am using **transformers 3.0.2** code .
from transformers.pipelines import pipeline
from transformers.modeling_auto import AutoModelForQuestionAnswering
from transformers.tokenization_a... | [
"Looks like an issue with 3.0.2 transformers version. Works fine when I use \"master\" version of transformers."
] |
https://api.github.com/repos/huggingface/datasets/issues/506 | 506 | fix dataset.map for function without outputs | As noticed in #505 , giving a function that doesn't return anything in `.map` raises an error because of an unreferenced variable.
I fixed that and added tests.
Thanks @avloss for reporting | closed | 2020-08-14T13:40:22 | https://api.github.com/repos/huggingface/datasets/issues/506/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/506",
"html_url": "https://github.com/huggingface/datasets/pull/506",
"diff_url": "https://github.com/huggingface/datasets/pull/506.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/506.patch",
"merged_at": "2020-08-17T11:24:38"... | true | fix dataset.map for function without outputs
As noticed in #505 , giving a function that doesn't return anything in `.map` raises an error because of an unreferenced variable.
I fixed that and added tests.
Thanks @avloss for reporting | [] |
https://api.github.com/repos/huggingface/datasets/issues/505 | 505 | tmp_file referenced before assignment | Just learning about this library - so might've not set up all the flags correctly, but was getting this error about "tmp_file". | closed | 2020-08-13T23:27:33 | https://api.github.com/repos/huggingface/datasets/issues/505/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/505",
"html_url": "https://github.com/huggingface/datasets/pull/505",
"diff_url": "https://github.com/huggingface/datasets/pull/505.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/505.patch",
"merged_at": null
} | true | tmp_file referenced before assignment
Just learning about this library - so might've not set up all the flags correctly, but was getting this error about "tmp_file". | [
"Thanks for reporting the issue ! I'm creating a new PR to fix it and add tests.\r\n(I'm doing a new PR because I know there's some other place where it needs to be fixed)",
"I'm closing this one as I created the other PR."
] |
https://api.github.com/repos/huggingface/datasets/issues/504 | 504 | Added downloading to Hyperpartisan news detection | Following the discussion on Slack and #349, I've updated the hyperpartisan dataset to pull directly from Zenodo rather than manual install, which should make this dataset much more accessible. Many thanks to @johanneskiesel !
Currently doesn't pass `test_load_real_dataset` - I'm using `self.config.name` which is `de... | closed | 2020-08-13T21:53:46 | https://api.github.com/repos/huggingface/datasets/issues/504/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/504",
"html_url": "https://github.com/huggingface/datasets/pull/504",
"diff_url": "https://github.com/huggingface/datasets/pull/504.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/504.patch",
"merged_at": "2020-08-27T08:18:41"... | true | Added downloading to Hyperpartisan news detection
Following the discussion on Slack and #349, I've updated the hyperpartisan dataset to pull directly from Zenodo rather than manual install, which should make this dataset much more accessible. Many thanks to @johanneskiesel !
Currently doesn't pass `test_load_real_da... | [
"Thank you @ghomasHudson for making our dataset available! This is great!",
"The test passes since #527 :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/503 | 503 | CompGuessWhat?! 0.2.0 | We updated some metadata information associated with the dataset. In addition, we've updated the `create_dummy_data.py` script to generate data samples for the dataset. | closed | 2020-08-13T20:51:26 | https://api.github.com/repos/huggingface/datasets/issues/503/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/503",
"html_url": "https://github.com/huggingface/datasets/pull/503",
"diff_url": "https://github.com/huggingface/datasets/pull/503.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/503.patch",
"merged_at": null
} | true | CompGuessWhat?! 0.2.0
We updated some metadata information associated with the dataset. In addition, we've updated the `create_dummy_data.py` script to generate data samples for the dataset. | [
"I don't see any significant change in the dataset script (except the version value update), can you check that again please ?",
"Hi @aleSuglia , can you check that all the changes you wanted to do are in the dataset script ?",
"Hey sorry but I'm in the middle of a conference deadline. I'll let you know asap!",... |
https://api.github.com/repos/huggingface/datasets/issues/502 | 502 | Fix tokenizers caching | I've found some cases where the caching didn't work properly for tokenizers:
1. if a tokenizer has a regex pattern, then the caching would be inconsistent across sessions
2. if a tokenizer has a cache attribute that changes after some calls, the the caching would not work after cache updates
3. if a tokenizer is u... | closed | 2020-08-13T15:53:37 | https://api.github.com/repos/huggingface/datasets/issues/502/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/502",
"html_url": "https://github.com/huggingface/datasets/pull/502",
"diff_url": "https://github.com/huggingface/datasets/pull/502.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/502.patch",
"merged_at": "2020-08-19T13:37:17"... | true | Fix tokenizers caching
I've found some cases where the caching didn't work properly for tokenizers:
1. if a tokenizer has a regex pattern, then the caching would be inconsistent across sessions
2. if a tokenizer has a cache attribute that changes after some calls, the the caching would not work after cache updates
... | [
"This should fix #501 and also the issue you sent me on slack @sgugger ."
] |
https://api.github.com/repos/huggingface/datasets/issues/501 | 501 | Caching doesn't work for map (non-deterministic) | The caching functionality doesn't work reliably when tokenizing a dataset. Here's a small example to reproduce it.
```python
import nlp
import transformers
def main():
ds = nlp.load_dataset("reddit", split="train[:500]")
tokenizer = transformers.AutoTokenizer.from_pretrained("gpt2")
def conv... | closed | 2020-08-12T20:20:07 | https://api.github.com/repos/huggingface/datasets/issues/501/comments | null | false | Caching doesn't work for map (non-deterministic)
The caching functionality doesn't work reliably when tokenizing a dataset. Here's a small example to reproduce it.
```python
import nlp
import transformers
def main():
ds = nlp.load_dataset("reddit", split="train[:500]")
tokenizer = transformers.Auto... | [
"Thanks for reporting !\r\n\r\nTo store the cache file, we compute a hash of the function given in `.map`, using our own hashing function.\r\nThe hash doesn't seem to stay the same over sessions for the tokenizer.\r\nApparently this is because of the regex at `tokenizer.pat` is not well supported by our hashing fun... |
https://api.github.com/repos/huggingface/datasets/issues/500 | 500 | Use hnsw in wiki_dpr | The HNSW faiss index is much faster that regular Flat index. | closed | 2020-08-12T16:58:07 | https://api.github.com/repos/huggingface/datasets/issues/500/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/500",
"html_url": "https://github.com/huggingface/datasets/pull/500",
"diff_url": "https://github.com/huggingface/datasets/pull/500.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/500.patch",
"merged_at": "2020-08-20T07:59:18"... | true | Use hnsw in wiki_dpr
The HNSW faiss index is much faster that regular Flat index. | [] |
https://api.github.com/repos/huggingface/datasets/issues/499 | 499 | Narrativeqa (with full text) | Following the uploading of the full text data in #309, I've added the full text to the narrativeqa dataset.
Few notes:
- Had some encoding issues using the default `open` so am using `open(encoding="latin-1"...` which seems to fix it. Looks fine.
- Can't get the dummy data to work. Currently putting stuff at:
... | closed | 2020-08-12T13:49:43 | https://api.github.com/repos/huggingface/datasets/issues/499/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/499",
"html_url": "https://github.com/huggingface/datasets/pull/499",
"diff_url": "https://github.com/huggingface/datasets/pull/499.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/499.patch",
"merged_at": null
} | true | Narrativeqa (with full text)
Following the uploading of the full text data in #309, I've added the full text to the narrativeqa dataset.
Few notes:
- Had some encoding issues using the default `open` so am using `open(encoding="latin-1"...` which seems to fix it. Looks fine.
- Can't get the dummy data to work. Cu... | [
"I took a look at the dummy data creation for this dataset.\r\n\r\nMaybe it didn't work on your side might be because `master.zip` and `narrativeqa_full_text.zip` are supposed to be directories and not acutal zip files in the dummy data folder.\r\n\r\nI managed to make it work with this `dummy_data.zip` file:\r\nht... |
https://api.github.com/repos/huggingface/datasets/issues/498 | 498 | dont use beam fs to save info for local cache dir | If the cache dir is local, then we shouldn't use beam's filesystem to save the dataset info
Fix #490
| closed | 2020-08-12T11:00:00 | https://api.github.com/repos/huggingface/datasets/issues/498/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/498",
"html_url": "https://github.com/huggingface/datasets/pull/498",
"diff_url": "https://github.com/huggingface/datasets/pull/498.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/498.patch",
"merged_at": "2020-08-14T13:17:20"... | true | dont use beam fs to save info for local cache dir
If the cache dir is local, then we shouldn't use beam's filesystem to save the dataset info
Fix #490
| [] |
https://api.github.com/repos/huggingface/datasets/issues/497 | 497 | skip header in PAWS-X | This should fix #485
I also updated the `dataset_infos.json` file that is used to verify the integrity of the generated splits (the number of examples was reduced by one).
Note that there are new fields in `dataset_infos.json` introduced in the latest release 0.4.0 corresponding to post processing info. I remove... | closed | 2020-08-11T17:26:25 | https://api.github.com/repos/huggingface/datasets/issues/497/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/497",
"html_url": "https://github.com/huggingface/datasets/pull/497",
"diff_url": "https://github.com/huggingface/datasets/pull/497.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/497.patch",
"merged_at": "2020-08-19T09:50:01"... | true | skip header in PAWS-X
This should fix #485
I also updated the `dataset_infos.json` file that is used to verify the integrity of the generated splits (the number of examples was reduced by one).
Note that there are new fields in `dataset_infos.json` introduced in the latest release 0.4.0 corresponding to post pro... | [] |
https://api.github.com/repos/huggingface/datasets/issues/496 | 496 | fix bad type in overflow check | When writing an arrow file and inferring the features, the overflow check could fail if the first example had a `null` field.
This is because we were not using the inferred features to do this check, and we could end up with arrays that don't match because of a type mismatch (`null` vs `string` for example).
This s... | closed | 2020-08-11T16:24:58 | https://api.github.com/repos/huggingface/datasets/issues/496/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/496",
"html_url": "https://github.com/huggingface/datasets/pull/496",
"diff_url": "https://github.com/huggingface/datasets/pull/496.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/496.patch",
"merged_at": "2020-08-14T13:29:34"... | true | fix bad type in overflow check
When writing an arrow file and inferring the features, the overflow check could fail if the first example had a `null` field.
This is because we were not using the inferred features to do this check, and we could end up with arrays that don't match because of a type mismatch (`null` vs `... | [] |
https://api.github.com/repos/huggingface/datasets/issues/495 | 495 | stack vectors in pytorch and tensorflow | When the format of a dataset is set to pytorch or tensorflow, and if the dataset has vectors in it, they were not stacked together as tensors when calling `dataset[i:i + batch_size][column]` or `dataset[column]`.
I added support for stacked tensors for both pytorch and tensorflow.
For ragged tensors, they are stack... | closed | 2020-08-11T15:12:53 | https://api.github.com/repos/huggingface/datasets/issues/495/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/495",
"html_url": "https://github.com/huggingface/datasets/pull/495",
"diff_url": "https://github.com/huggingface/datasets/pull/495.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/495.patch",
"merged_at": "2020-08-12T09:30:48"... | true | stack vectors in pytorch and tensorflow
When the format of a dataset is set to pytorch or tensorflow, and if the dataset has vectors in it, they were not stacked together as tensors when calling `dataset[i:i + batch_size][column]` or `dataset[column]`.
I added support for stacked tensors for both pytorch and tensorf... | [] |
https://api.github.com/repos/huggingface/datasets/issues/494 | 494 | Fix numpy stacking | When getting items using a column name as a key, numpy arrays were not stacked.
I fixed that and added some tests.
There is another issue that still needs to be fixed though: when getting items using a column name as a key, pytorch tensors are not stacked (it outputs a list of tensors). This PR should help with the... | closed | 2020-08-11T13:40:30 | https://api.github.com/repos/huggingface/datasets/issues/494/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/494",
"html_url": "https://github.com/huggingface/datasets/pull/494",
"diff_url": "https://github.com/huggingface/datasets/pull/494.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/494.patch",
"merged_at": "2020-08-11T13:49:52"... | true | Fix numpy stacking
When getting items using a column name as a key, numpy arrays were not stacked.
I fixed that and added some tests.
There is another issue that still needs to be fixed though: when getting items using a column name as a key, pytorch tensors are not stacked (it outputs a list of tensors). This PR s... | [
"This PR also fixed a bug where numpy arrays were returned instead of pytorch tensors when getting with a clumn as a key."
] |
https://api.github.com/repos/huggingface/datasets/issues/493 | 493 | Fix wmt zh-en url | I verified that
```
wget https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-zh.tar.gz.00
```
runs in 2 minutes. | closed | 2020-08-11T02:14:52 | https://api.github.com/repos/huggingface/datasets/issues/493/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/493",
"html_url": "https://github.com/huggingface/datasets/pull/493",
"diff_url": "https://github.com/huggingface/datasets/pull/493.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/493.patch",
"merged_at": null
} | true | Fix wmt zh-en url
I verified that
```
wget https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-zh.tar.gz.00
```
runs in 2 minutes. | [
"this doesn't work. I can decompress the file after download locally."
] |
https://api.github.com/repos/huggingface/datasets/issues/492 | 492 | nlp.Features does not distinguish between nullable and non-nullable types in PyArrow schema | Here's the code I'm trying to run:
```python
dset_wikipedia = nlp.load_dataset("wikipedia", "20200501.en", split="train", cache_dir=args.cache_dir)
dset_wikipedia.drop(columns=["title"])
dset_wikipedia.features.pop("title")
dset_books = nlp.load_dataset("bookcorpus", split="train", cache_dir=args.cache_dir)
dse... | closed | 2020-08-11T00:27:46 | https://api.github.com/repos/huggingface/datasets/issues/492/comments | null | false | nlp.Features does not distinguish between nullable and non-nullable types in PyArrow schema
Here's the code I'm trying to run:
```python
dset_wikipedia = nlp.load_dataset("wikipedia", "20200501.en", split="train", cache_dir=args.cache_dir)
dset_wikipedia.drop(columns=["title"])
dset_wikipedia.features.pop("title"... | [
"In 0.4.0, the assertion in `concatenate_datasets ` is on the features, and not the schema.\r\nCould you try to update `nlp` ?\r\n\r\nAlso, since 0.4.0, you can use `dset_wikipedia.cast_(dset_books.features)` to avoid the schema cast hack.",
"Or maybe the assertion comes from elsewhere ?",
"I'm using the master... |
https://api.github.com/repos/huggingface/datasets/issues/491 | 491 | No 0.4.0 release on GitHub | 0.4.0 was released on PyPi, but not on GitHub. This means [the documentation](https://huggingface.co/nlp/) is still displaying from 0.3.0, and that there's no tag to easily clone the 0.4.0 version of the repo. | closed | 2020-08-10T23:59:57 | https://api.github.com/repos/huggingface/datasets/issues/491/comments | null | false | No 0.4.0 release on GitHub
0.4.0 was released on PyPi, but not on GitHub. This means [the documentation](https://huggingface.co/nlp/) is still displaying from 0.3.0, and that there's no tag to easily clone the 0.4.0 version of the repo. | [
"I did the release on github, and updated the doc :)\r\nSorry for the delay",
"Thanks!"
] |
https://api.github.com/repos/huggingface/datasets/issues/490 | 490 | Loading preprocessed Wikipedia dataset requires apache_beam | Running
`nlp.load_dataset("wikipedia", "20200501.en", split="train", dir="/tmp/wikipedia")`
gives an error if apache_beam is not installed, stemming from
https://github.com/huggingface/nlp/blob/38eb2413de54ee804b0be81781bd65ac4a748ced/src/nlp/builder.py#L981-L988
This succeeded without the dependency in ve... | closed | 2020-08-10T23:46:50 | https://api.github.com/repos/huggingface/datasets/issues/490/comments | null | false | Loading preprocessed Wikipedia dataset requires apache_beam
Running
`nlp.load_dataset("wikipedia", "20200501.en", split="train", dir="/tmp/wikipedia")`
gives an error if apache_beam is not installed, stemming from
https://github.com/huggingface/nlp/blob/38eb2413de54ee804b0be81781bd65ac4a748ced/src/nlp/builder... | [] |
https://api.github.com/repos/huggingface/datasets/issues/489 | 489 | ug | closed | 2020-08-10T22:33:03 | https://api.github.com/repos/huggingface/datasets/issues/489/comments | null | false | ug
| [
"whoops",
"please delete this"
] | |
https://api.github.com/repos/huggingface/datasets/issues/488 | 488 | issues with downloading datasets for wmt16 and wmt19 | I have encountered multiple issues while trying to:
```
import nlp
dataset = nlp.load_dataset('wmt16', 'ru-en')
metric = nlp.load_metric('wmt16')
```
1. I had to do `pip install -e ".[dev]" ` on master, currently released nlp didn't work (sorry, didn't save the error) - I went back to the released version and no... | closed | 2020-08-10T17:32:51 | https://api.github.com/repos/huggingface/datasets/issues/488/comments | null | false | issues with downloading datasets for wmt16 and wmt19
I have encountered multiple issues while trying to:
```
import nlp
dataset = nlp.load_dataset('wmt16', 'ru-en')
metric = nlp.load_metric('wmt16')
```
1. I had to do `pip install -e ".[dev]" ` on master, currently released nlp didn't work (sorry, didn't save th... | [
"I found `UNv1.0.en-ru.tar.gz` here: https://conferences.unite.un.org/uncorpus/en/downloadoverview, so it can be reconstructed with:\r\n```\r\nwget -c https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-ru.tar.gz.00\r\nwget -c https://stuncorpusprod.blob.core.windows.net/corpusfiles/UNv1.0.en-ru.tar.... |
https://api.github.com/repos/huggingface/datasets/issues/487 | 487 | Fix elasticsearch result ids returning as strings | I am using the latest elasticsearch binary and master of nlp. For me elasticsearch searches failed because the resultant "id_" returned for searches are strings, but our library assumes them to be integers. | closed | 2020-08-10T13:37:11 | https://api.github.com/repos/huggingface/datasets/issues/487/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/487",
"html_url": "https://github.com/huggingface/datasets/pull/487",
"diff_url": "https://github.com/huggingface/datasets/pull/487.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/487.patch",
"merged_at": "2020-08-31T10:42:46"... | true | Fix elasticsearch result ids returning as strings
I am using the latest elasticsearch binary and master of nlp. For me elasticsearch searches failed because the resultant "id_" returned for searches are strings, but our library assumes them to be integers. | [
"It looks like you need to rebase from master to fix the CI. Could you do that please ?"
] |
https://api.github.com/repos/huggingface/datasets/issues/486 | 486 | Bookcorpus data contains pretokenized text | It seem that the bookcoprus data downloaded through the library was pretokenized with NLTK's Treebank tokenizer, which changes the text in incompatible ways to how, for instance, BERT's wordpiece tokenizer works. For example, "didn't" becomes "did" + "n't", and double quotes are changed to `` and '' for start and end q... | closed | 2020-08-09T06:53:24 | https://api.github.com/repos/huggingface/datasets/issues/486/comments | null | false | Bookcorpus data contains pretokenized text
It seem that the bookcoprus data downloaded through the library was pretokenized with NLTK's Treebank tokenizer, which changes the text in incompatible ways to how, for instance, BERT's wordpiece tokenizer works. For example, "didn't" becomes "did" + "n't", and double quotes a... | [
"Yes indeed it looks like some `'` and spaces are missing (for example in `dont` or `didnt`).\r\nDo you know if there exist some copies without this issue ?\r\nHow would you fix this issue on the current data exactly ? I can see that the data is raw text (not tokenized) so I'm not sure I understand how you would do... |
https://api.github.com/repos/huggingface/datasets/issues/485 | 485 | PAWS dataset first item is header | ```
import nlp
dataset = nlp.load_dataset('xtreme', 'PAWS-X.en')
dataset['test'][0]
```
prints the following
```
{'label': 'label', 'sentence1': 'sentence1', 'sentence2': 'sentence2'}
```
dataset['test'][0] should probably be the first item in the dataset, not just a dictionary mapping the column names t... | closed | 2020-08-08T22:05:25 | https://api.github.com/repos/huggingface/datasets/issues/485/comments | null | false | PAWS dataset first item is header
```
import nlp
dataset = nlp.load_dataset('xtreme', 'PAWS-X.en')
dataset['test'][0]
```
prints the following
```
{'label': 'label', 'sentence1': 'sentence1', 'sentence2': 'sentence2'}
```
dataset['test'][0] should probably be the first item in the dataset, not just a dic... | [] |
https://api.github.com/repos/huggingface/datasets/issues/484 | 484 | update mirror for RT dataset | closed | 2020-08-07T15:25:45 | https://api.github.com/repos/huggingface/datasets/issues/484/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/484",
"html_url": "https://github.com/huggingface/datasets/pull/484",
"diff_url": "https://github.com/huggingface/datasets/pull/484.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/484.patch",
"merged_at": "2020-08-24T13:33:37"... | true | update mirror for RT dataset
| [
"Thanks for adding this mirror link :)\r\n\r\nCould you run the following command to update the json file `dataset_infos.json` used to verify the integrity of the downloaded file ?\r\n\r\n```\r\nnlp-cli test ./datasets/rotten_tomatoes --save_infos --ignore_verifications\r\n```",
"done! @lhoestq ",
"the build_do... | |
https://api.github.com/repos/huggingface/datasets/issues/483 | 483 | rotten tomatoes movie review dataset taken down | In an interesting twist of events, the individual who created the movie review seems to have left Cornell, and their webpage has been removed, along with the movie review dataset (http://www.cs.cornell.edu/people/pabo/movie-review-data/rt-polaritydata.tar.gz). It's not downloadable anymore. | closed | 2020-08-07T15:12:01 | https://api.github.com/repos/huggingface/datasets/issues/483/comments | null | false | rotten tomatoes movie review dataset taken down
In an interesting twist of events, the individual who created the movie review seems to have left Cornell, and their webpage has been removed, along with the movie review dataset (http://www.cs.cornell.edu/people/pabo/movie-review-data/rt-polaritydata.tar.gz). It's not do... | [
"found a mirror: https://storage.googleapis.com/seldon-datasets/sentence_polarity_v1/rt-polaritydata.tar.gz",
"fixed in #484 ",
"Closing this one. Thanks again @jxmorris12 for taking care of this :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/482 | 482 | Bugs : dataset.map() is frozen on ELI5 | Hi Huggingface Team!
Thank you guys once again for this amazing repo.
I have tried to prepare ELI5 to train with T5, based on [this wonderful notebook of Suraj Patil](https://github.com/patil-suraj/exploring-T5/blob/master/T5_on_TPU.ipynb)
However, when I run `dataset.map()` on ELI5 to prepare `input_text, ta... | closed | 2020-08-07T08:23:35 | https://api.github.com/repos/huggingface/datasets/issues/482/comments | null | false | Bugs : dataset.map() is frozen on ELI5
Hi Huggingface Team!
Thank you guys once again for this amazing repo.
I have tried to prepare ELI5 to train with T5, based on [this wonderful notebook of Suraj Patil](https://github.com/patil-suraj/exploring-T5/blob/master/T5_on_TPU.ipynb)
However, when I run `dataset.ma... | [
"This comes from an overflow in pyarrow's array.\r\nIt is stuck inside the loop that reduces the batch size to avoid the overflow.\r\nI'll take a look",
"I created a PR to fix the issue.\r\nIt was due to an overflow check that handled badly an empty list.\r\n\r\nYou can try the changes by using \r\n```\r\n!pip in... |
https://api.github.com/repos/huggingface/datasets/issues/481 | 481 | Apply utf-8 encoding to all datasets | ## Description
This PR applies utf-8 encoding for all instances of `with open(...) as f` to all Python files in `datasets/`. As suggested by @thomwolf in #468 , we use regular expressions and the following function
```python
def apply_encoding_on_file_open(filepath: str):
"""Apply UTF-8 encoding for all insta... | closed | 2020-08-06T20:02:09 | https://api.github.com/repos/huggingface/datasets/issues/481/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/481",
"html_url": "https://github.com/huggingface/datasets/pull/481",
"diff_url": "https://github.com/huggingface/datasets/pull/481.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/481.patch",
"merged_at": "2020-08-20T08:16:08"... | true | Apply utf-8 encoding to all datasets
## Description
This PR applies utf-8 encoding for all instances of `with open(...) as f` to all Python files in `datasets/`. As suggested by @thomwolf in #468 , we use regular expressions and the following function
```python
def apply_encoding_on_file_open(filepath: str):
... | [
"Not sure why the AWS test is failing - perhaps I made too many concurrent CI builds 😢. Can someone please rerun the CI to check the error is not on my end?",
"I pushed an improved docstring and the unit tests now pass, which suggests the previous failure on AWS was simply a timeout error. \r\n\r\nFor some reaso... |
https://api.github.com/repos/huggingface/datasets/issues/480 | 480 | Column indexing hotfix | As observed for example in #469 , currently `__getitem__` does not convert the data to the dataset format when indexing by column. This is a hotfix that imitates functional 0.3.0. code. In the future it'd probably be nice to have a test there. | closed | 2020-08-06T11:37:05 | https://api.github.com/repos/huggingface/datasets/issues/480/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/480",
"html_url": "https://github.com/huggingface/datasets/pull/480",
"diff_url": "https://github.com/huggingface/datasets/pull/480.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/480.patch",
"merged_at": null
} | true | Column indexing hotfix
As observed for example in #469 , currently `__getitem__` does not convert the data to the dataset format when indexing by column. This is a hotfix that imitates functional 0.3.0. code. In the future it'd probably be nice to have a test there. | [
"Looks good to me as well but we'll want to add a test indeed.\r\nYou can add one if you have time @TevenLeScao.\r\nOtherwise, we'll do it when we are back with Quentin. ",
"I fixed it in #494 "
] |
https://api.github.com/repos/huggingface/datasets/issues/479 | 479 | add METEOR metric | Added the METEOR metric. Can be used like this:
```python
import nlp
meteor = nlp.load_metric('metrics/meteor')
meteor.compute(["some string", "some string"], ["some string", "some similar string"])
# {'meteor': 0.6411637931034483}
meteor.add("some string", "some string")
meteor.add('some string", "some simila... | closed | 2020-08-05T23:13:00 | https://api.github.com/repos/huggingface/datasets/issues/479/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/479",
"html_url": "https://github.com/huggingface/datasets/pull/479",
"diff_url": "https://github.com/huggingface/datasets/pull/479.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/479.patch",
"merged_at": "2020-08-19T13:39:09"... | true | add METEOR metric
Added the METEOR metric. Can be used like this:
```python
import nlp
meteor = nlp.load_metric('metrics/meteor')
meteor.compute(["some string", "some string"], ["some string", "some similar string"])
# {'meteor': 0.6411637931034483}
meteor.add("some string", "some string")
meteor.add('some str... | [
"Really nice !\r\nThanks for adding this one.\r\n\r\nI noticed that there are some '-' that are left in the description in the middle of some workds. It migh come from copy-pasting the pdf paper. ex: `im-provement`. Could you fix that please ?",
"@lhoestq \r\nLinebreaks have been removed! Note that there are stil... |
https://api.github.com/repos/huggingface/datasets/issues/478 | 478 | Export TFRecord to GCP bucket | Previously, I was writing TFRecords manually to GCP bucket with : `with tf.io.TFRecordWriter('gs://my_bucket/x.tfrecord')`
Since `0.4.0` is out with the `export()` function, I tried it. But it seems TFRecords cannot be directly written to GCP bucket.
`dataset.export('local.tfrecord')` works fine,
but `dataset.... | closed | 2020-08-05T01:08:32 | https://api.github.com/repos/huggingface/datasets/issues/478/comments | null | false | Export TFRecord to GCP bucket
Previously, I was writing TFRecords manually to GCP bucket with : `with tf.io.TFRecordWriter('gs://my_bucket/x.tfrecord')`
Since `0.4.0` is out with the `export()` function, I tried it. But it seems TFRecords cannot be directly written to GCP bucket.
`dataset.export('local.tfrecord')... | [
"Nevermind, I restarted my python session and it worked fine...\r\n\r\n---\r\n\r\nI had an authentification error, and I authenticated from another terminal. After that, no more error but it was not working. Restarting the sessions makes it work :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/477 | 477 | Overview.ipynb throws exceptions with nlp 0.4.0 | with nlp 0.4.0, the TensorFlow example in Overview.ipynb throws the following exceptions:
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
<ipython-input-5-48907f2ad433> in <module>
----> 1 features = {x: trai... | closed | 2020-08-04T23:18:15 | https://api.github.com/repos/huggingface/datasets/issues/477/comments | null | false | Overview.ipynb throws exceptions with nlp 0.4.0
with nlp 0.4.0, the TensorFlow example in Overview.ipynb throws the following exceptions:
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
<ipython-input-5-48907f... | [
"Thanks for reporting this issue\r\n\r\nThere was a bug where numpy arrays would get returned instead of tensorflow tensors.\r\nThis is fixed on master.\r\n\r\nI tried to re-run the colab and encountered this error instead:\r\n\r\n```\r\nAttributeError: 'tensorflow.python.framework.ops.EagerTensor' object has no at... |
https://api.github.com/repos/huggingface/datasets/issues/476 | 476 | CheckList | Sorry for the large pull request.
- Added checklists as datasets. I can't run `test_load_real_dataset` (see #474), but I can load the datasets successfully as shown in the example notebook
- Added a checklist wrapper | closed | 2020-08-04T18:32:05 | https://api.github.com/repos/huggingface/datasets/issues/476/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/476",
"html_url": "https://github.com/huggingface/datasets/pull/476",
"diff_url": "https://github.com/huggingface/datasets/pull/476.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/476.patch",
"merged_at": null
} | true | CheckList
Sorry for the large pull request.
- Added checklists as datasets. I can't run `test_load_real_dataset` (see #474), but I can load the datasets successfully as shown in the example notebook
- Added a checklist wrapper | [
"> Also, a little out of my depth there, but would there be a way to have the default pip install checklist command not require mysql and mariadb to be installed? Feels like that might be a source of confusion for users.\r\n\r\nI removed the pattern dependency, mysql is not a requirement anymore. I'm not sure where... |
https://api.github.com/repos/huggingface/datasets/issues/475 | 475 | misc. bugs and quality of life | A few misc. bugs and QOL improvements that I've come across in using the library. Let me know if you don't like any of them and I can adjust/remove them.
1. Printing datasets without a description field throws an error when formatting the `single_line_description`. This fixes that, and also adds some formatting to t... | closed | 2020-08-04T15:32:29 | https://api.github.com/repos/huggingface/datasets/issues/475/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/475",
"html_url": "https://github.com/huggingface/datasets/pull/475",
"diff_url": "https://github.com/huggingface/datasets/pull/475.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/475.patch",
"merged_at": "2020-08-17T21:14:07"... | true | misc. bugs and quality of life
A few misc. bugs and QOL improvements that I've come across in using the library. Let me know if you don't like any of them and I can adjust/remove them.
1. Printing datasets without a description field throws an error when formatting the `single_line_description`. This fixes that, and... | [
"Cool thanks, I made those changes. LMK if you think it's ready for merge.",
"Ok to merge for me"
] |
https://api.github.com/repos/huggingface/datasets/issues/474 | 474 | test_load_real_dataset when config has BUILDER_CONFIGS that matter | It a dataset has custom `BUILDER_CONFIGS` with non-keyword arguments (or keyword arguments with non default values), the config is not loaded during the test and causes an error.
I think the problem is that `test_load_real_dataset` calls `load_dataset` with `data_dir=temp_data_dir` ([here](https://github.com/huggingfa... | closed | 2020-08-03T23:46:36 | https://api.github.com/repos/huggingface/datasets/issues/474/comments | null | false | test_load_real_dataset when config has BUILDER_CONFIGS that matter
It a dataset has custom `BUILDER_CONFIGS` with non-keyword arguments (or keyword arguments with non default values), the config is not loaded during the test and causes an error.
I think the problem is that `test_load_real_dataset` calls `load_dataset`... | [
"The `data_dir` parameter has been removed. Now the error is `ValueError: Config name is missing`\r\n\r\nAs mentioned in #470 I think we can have one test with the first config of BUILDER_CONFIGS, and another test that runs all of the configs in BUILDER_CONFIGS",
"This was fixed in #527 \r\n\r\nClosing this one, ... |
https://api.github.com/repos/huggingface/datasets/issues/473 | 473 | add DoQA dataset (ACL 2020) | add DoQA dataset (ACL 2020) http://ixa.eus/node/12931 | closed | 2020-08-03T11:26:52 | https://api.github.com/repos/huggingface/datasets/issues/473/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/473",
"html_url": "https://github.com/huggingface/datasets/pull/473",
"diff_url": "https://github.com/huggingface/datasets/pull/473.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/473.patch",
"merged_at": "2020-09-03T11:44:14"... | true | add DoQA dataset (ACL 2020)
add DoQA dataset (ACL 2020) http://ixa.eus/node/12931 | [] |
https://api.github.com/repos/huggingface/datasets/issues/472 | 472 | add crd3 dataset | opening new PR for CRD3 dataset (ACL2020) to fix the circle CI problems | closed | 2020-08-03T11:15:02 | https://api.github.com/repos/huggingface/datasets/issues/472/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/472",
"html_url": "https://github.com/huggingface/datasets/pull/472",
"diff_url": "https://github.com/huggingface/datasets/pull/472.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/472.patch",
"merged_at": "2020-08-03T11:22:09"... | true | add crd3 dataset
opening new PR for CRD3 dataset (ACL2020) to fix the circle CI problems | [
"This PR was already approved by @lhoestq in #456 . This one just make style to remove some typos"
] |
https://api.github.com/repos/huggingface/datasets/issues/471 | 471 | add reuters21578 dataset | new PR to add the reuters21578 dataset and fix the circle CI problems.
Fix partially:
- #353
Subsequent PR after:
- #449 | closed | 2020-08-03T11:07:14 | https://api.github.com/repos/huggingface/datasets/issues/471/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/471",
"html_url": "https://github.com/huggingface/datasets/pull/471",
"diff_url": "https://github.com/huggingface/datasets/pull/471.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/471.patch",
"merged_at": "2020-09-03T09:58:50"... | true | add reuters21578 dataset
new PR to add the reuters21578 dataset and fix the circle CI problems.
Fix partially:
- #353
Subsequent PR after:
- #449 | [] |
https://api.github.com/repos/huggingface/datasets/issues/470 | 470 | Adding IWSLT 2017 dataset. | Created a [IWSLT 2017](https://sites.google.com/site/iwsltevaluation2017/TED-tasks) dataset script for the *multilingual data*.
```
Bilingual data: {Arabic, German, French, Japanese, Korean, Chinese} <-> English
Multilingual data: German, English, Italian, Dutch, Romanian. (Any pair)
```
I'm unsure how to h... | closed | 2020-08-03T09:52:39 | https://api.github.com/repos/huggingface/datasets/issues/470/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/470",
"html_url": "https://github.com/huggingface/datasets/pull/470",
"diff_url": "https://github.com/huggingface/datasets/pull/470.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/470.patch",
"merged_at": "2020-09-07T12:33:30"... | true | Adding IWSLT 2017 dataset.
Created a [IWSLT 2017](https://sites.google.com/site/iwsltevaluation2017/TED-tasks) dataset script for the *multilingual data*.
```
Bilingual data: {Arabic, German, French, Japanese, Korean, Chinese} <-> English
Multilingual data: German, English, Italian, Dutch, Romanian. (Any pair)... | [
"Ok I tried to add the dummy dataset (I actually modified the dummy_data command to generate them for me because it was too painful to do that manually).\r\n\r\nThe dummy_data test seems to work:\r\n```bash\r\nRUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_iwslt2017\... |
https://api.github.com/repos/huggingface/datasets/issues/469 | 469 | invalid data type 'str' at _convert_outputs in arrow_dataset.py | I trying to build multi label text classifier model using Transformers lib.
I'm using Transformers NLP to load the data set, while calling trainer.train() method. It throws the following error
File "C:\***\arrow_dataset.py", line 343, in _convert_outputs
v = command(v)
TypeError: new(): invalid data type ... | closed | 2020-08-03T07:48:29 | https://api.github.com/repos/huggingface/datasets/issues/469/comments | null | false | invalid data type 'str' at _convert_outputs in arrow_dataset.py
I trying to build multi label text classifier model using Transformers lib.
I'm using Transformers NLP to load the data set, while calling trainer.train() method. It throws the following error
File "C:\***\arrow_dataset.py", line 343, in _convert_o... | [
"Hi ! Did you try to set the output format to pytorch ? (or tensorflow if you're using tensorflow)\r\nIt can be done with `dataset.set_format(\"torch\", columns=columns)` (or \"tensorflow\").\r\n\r\nNote that for pytorch, string columns can't be converted to `torch.Tensor`, so you have to specify in `columns=` the... |
https://api.github.com/repos/huggingface/datasets/issues/468 | 468 | UnicodeDecodeError while loading PAN-X task of XTREME dataset | Hi 🤗 team!
## Description of the problem
I'm running into a `UnicodeDecodeError` while trying to load the PAN-X subset the XTREME dataset:
```
---------------------------------------------------------------------------
UnicodeDecodeError Traceback (most recent call last)
<ipython-inp... | closed | 2020-08-02T14:05:10 | https://api.github.com/repos/huggingface/datasets/issues/468/comments | null | false | UnicodeDecodeError while loading PAN-X task of XTREME dataset
Hi 🤗 team!
## Description of the problem
I'm running into a `UnicodeDecodeError` while trying to load the PAN-X subset the XTREME dataset:
```
---------------------------------------------------------------------------
UnicodeDecodeError ... | [
"Indeed. Solution 1 is the simplest.\r\n\r\nThis is actually a recurring problem.\r\nI think we should scan all the datasets with regexpr to fix the use of `open()` without encodings.\r\nAnd probably add a test in the CI to forbid using this in the future.",
"I'm happy to tackle the broader problem - will open a ... |
https://api.github.com/repos/huggingface/datasets/issues/467 | 467 | DOCS: Fix typo | Fix typo from dictionnary -> dictionary | closed | 2020-08-02T08:59:37 | https://api.github.com/repos/huggingface/datasets/issues/467/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/467",
"html_url": "https://github.com/huggingface/datasets/pull/467",
"diff_url": "https://github.com/huggingface/datasets/pull/467.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/467.patch",
"merged_at": "2020-08-02T09:18:54"... | true | DOCS: Fix typo
Fix typo from dictionnary -> dictionary | [
"Thanks!"
] |
https://api.github.com/repos/huggingface/datasets/issues/466 | 466 | [METRICS] Various improvements on metrics | - Disallow the use of positional arguments to avoid `predictions` vs `references` mistakes
- Allow to directly feed numpy/pytorch/tensorflow/pandas objects in metrics | closed | 2020-08-01T11:03:45 | https://api.github.com/repos/huggingface/datasets/issues/466/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/466",
"html_url": "https://github.com/huggingface/datasets/pull/466",
"diff_url": "https://github.com/huggingface/datasets/pull/466.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/466.patch",
"merged_at": "2020-08-17T15:14:59"... | true | [METRICS] Various improvements on metrics
- Disallow the use of positional arguments to avoid `predictions` vs `references` mistakes
- Allow to directly feed numpy/pytorch/tensorflow/pandas objects in metrics | [
"The cast function is now called inside `features.encode_example`.\r\nI also added `encode_batch` that was missing.\r\n\r\nMoreover I used the cast function in `Dataset.map` to support torch/tensorflow tensors or numpy arrays inputs.\r\n\r\nThere are tests for tensors inputs in metrics and in .map",
"I think we c... |
https://api.github.com/repos/huggingface/datasets/issues/465 | 465 | Keep features after transform | When applying a transform like `map`, some features were lost (and inferred features were used).
It was the case for ClassLabel, Translation, etc.
To fix that, I did some modifications in the `ArrowWriter`:
- added the `update_features` parameter. When it's `True`, then the features specified by the user (if any... | closed | 2020-07-31T14:43:21 | https://api.github.com/repos/huggingface/datasets/issues/465/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/465",
"html_url": "https://github.com/huggingface/datasets/pull/465",
"diff_url": "https://github.com/huggingface/datasets/pull/465.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/465.patch",
"merged_at": "2020-07-31T18:27:32"... | true | Keep features after transform
When applying a transform like `map`, some features were lost (and inferred features were used).
It was the case for ClassLabel, Translation, etc.
To fix that, I did some modifications in the `ArrowWriter`:
- added the `update_features` parameter. When it's `True`, then the features... | [
"One note on features inference:\r\n\r\nif an arrow type is `struct of items` where each item is a `list`, then we return a `dict` in which each item is a `Sequence`.\r\nIt means that we don't use the Sequence <-> dict swap when we infer features.\r\n\r\nIt's fine because the swap is generally used in dataset scrip... |
https://api.github.com/repos/huggingface/datasets/issues/464 | 464 | Add rename, remove and cast in-place operations | Add a bunch of in-place operation leveraging the Arrow back-end to rename and remove columns and cast to new features without using the more expensive `map` method.
These methods are added to `Dataset` as well as `DatasetDict`.
Added tests for these new methods and add the methods to the doc.
Naming follows th... | closed | 2020-07-31T12:30:21 | https://api.github.com/repos/huggingface/datasets/issues/464/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/464",
"html_url": "https://github.com/huggingface/datasets/pull/464",
"diff_url": "https://github.com/huggingface/datasets/pull/464.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/464.patch",
"merged_at": "2020-07-31T15:50:00"... | true | Add rename, remove and cast in-place operations
Add a bunch of in-place operation leveraging the Arrow back-end to rename and remove columns and cast to new features without using the more expensive `map` method.
These methods are added to `Dataset` as well as `DatasetDict`.
Added tests for these new methods and ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/463 | 463 | Add dataset/mlsum | New pull request that should correct the previous errors.
The load_real_data stills fails because it is looking for a default dataset URL that does not exists, this does not happen when loading the dataset with load_dataset | closed | 2020-07-31T11:50:52 | https://api.github.com/repos/huggingface/datasets/issues/463/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/463",
"html_url": "https://github.com/huggingface/datasets/pull/463",
"diff_url": "https://github.com/huggingface/datasets/pull/463.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/463.patch",
"merged_at": null
} | true | Add dataset/mlsum
New pull request that should correct the previous errors.
The load_real_data stills fails because it is looking for a default dataset URL that does not exists, this does not happen when loading the dataset with load_dataset | [
"I think the problem is related to `wiki_dpr` dataset which is making the circle CI failed as you can see:\r\n```\r\nFAILED tests/test_dataset_common.py::AWSDatasetTest::test_load_dataset_wiki_dpr\r\nFAILED tests/test_hf_gcp.py::TestDatasetOnHfGcp::test_script_synced_with_s3_wiki_dpr/dummy_psgs_w100_no_embeddings\r... |
https://api.github.com/repos/huggingface/datasets/issues/462 | 462 | add DoQA (ACL 2020) dataset | adds DoQA (ACL 2020) dataset | closed | 2020-07-31T11:25:56 | https://api.github.com/repos/huggingface/datasets/issues/462/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/462",
"html_url": "https://github.com/huggingface/datasets/pull/462",
"diff_url": "https://github.com/huggingface/datasets/pull/462.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/462.patch",
"merged_at": null
} | true | add DoQA (ACL 2020) dataset
adds DoQA (ACL 2020) dataset | [] |
https://api.github.com/repos/huggingface/datasets/issues/461 | 461 | Doqa | add DoQA (ACL 2020) dataset | closed | 2020-07-31T11:11:12 | https://api.github.com/repos/huggingface/datasets/issues/461/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/461",
"html_url": "https://github.com/huggingface/datasets/pull/461",
"diff_url": "https://github.com/huggingface/datasets/pull/461.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/461.patch",
"merged_at": null
} | true | Doqa
add DoQA (ACL 2020) dataset | [] |
https://api.github.com/repos/huggingface/datasets/issues/460 | 460 | Fix KeyboardInterrupt in map and bad indices in select | If you interrupted a map function while it was writing, the cached file was not discarded.
Therefore the next time you called map, it was loading an incomplete arrow file.
We had the same issue with select if there was a bad indice at one point.
To fix that I used temporary files that are renamed once everything... | closed | 2020-07-31T08:57:15 | https://api.github.com/repos/huggingface/datasets/issues/460/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/460",
"html_url": "https://github.com/huggingface/datasets/pull/460",
"diff_url": "https://github.com/huggingface/datasets/pull/460.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/460.patch",
"merged_at": "2020-07-31T11:32:18"... | true | Fix KeyboardInterrupt in map and bad indices in select
If you interrupted a map function while it was writing, the cached file was not discarded.
Therefore the next time you called map, it was loading an incomplete arrow file.
We had the same issue with select if there was a bad indice at one point.
To fix that ... | [
"Thanks @TevenLeScao for finding this issue",
"Thanks @lhoestq for catching this ❤️"
] |
https://api.github.com/repos/huggingface/datasets/issues/459 | 459 | [Breaking] Update Dataset and DatasetDict API | This PR contains a few breaking changes so it's probably good to keep it for the next (major) release:
- rename the `flatten`, `drop` and `dictionary_encode_column` methods in `flatten_`, `drop_` and `dictionary_encode_column_` to indicate that these methods have in-place effects as discussed in #166. From now on we s... | closed | 2020-07-31T08:11:33 | https://api.github.com/repos/huggingface/datasets/issues/459/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/459",
"html_url": "https://github.com/huggingface/datasets/pull/459",
"diff_url": "https://github.com/huggingface/datasets/pull/459.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/459.patch",
"merged_at": "2020-08-26T08:28:35"... | true | [Breaking] Update Dataset and DatasetDict API
This PR contains a few breaking changes so it's probably good to keep it for the next (major) release:
- rename the `flatten`, `drop` and `dictionary_encode_column` methods in `flatten_`, `drop_` and `dictionary_encode_column_` to indicate that these methods have in-place ... | [] |
https://api.github.com/repos/huggingface/datasets/issues/458 | 458 | Install CoVal metric from github | Changed the import statements in `coval.py` to direct the user to install the original package from github if it's not already installed (the warning will only display properly after merging [PR455](https://github.com/huggingface/nlp/pull/455))
Also changed the function call to use named rather than positional argum... | closed | 2020-07-30T16:59:25 | https://api.github.com/repos/huggingface/datasets/issues/458/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/458",
"html_url": "https://github.com/huggingface/datasets/pull/458",
"diff_url": "https://github.com/huggingface/datasets/pull/458.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/458.patch",
"merged_at": "2020-07-31T13:56:33"... | true | Install CoVal metric from github
Changed the import statements in `coval.py` to direct the user to install the original package from github if it's not already installed (the warning will only display properly after merging [PR455](https://github.com/huggingface/nlp/pull/455))
Also changed the function call to use n... | [] |
https://api.github.com/repos/huggingface/datasets/issues/457 | 457 | add set_format to DatasetDict + tests | Add the `set_format` and `formated_as` and `reset_format` to `DatasetDict`.
Add tests to these for `Dataset` and `DatasetDict`.
Fix some bugs uncovered by the tests for `pandas` formating. | closed | 2020-07-30T15:53:20 | https://api.github.com/repos/huggingface/datasets/issues/457/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/457",
"html_url": "https://github.com/huggingface/datasets/pull/457",
"diff_url": "https://github.com/huggingface/datasets/pull/457.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/457.patch",
"merged_at": "2020-07-30T17:34:34"... | true | add set_format to DatasetDict + tests
Add the `set_format` and `formated_as` and `reset_format` to `DatasetDict`.
Add tests to these for `Dataset` and `DatasetDict`.
Fix some bugs uncovered by the tests for `pandas` formating. | [] |
https://api.github.com/repos/huggingface/datasets/issues/456 | 456 | add crd3(ACL 2020) dataset | This PR adds the **Critical Role Dungeons and Dragons Dataset** published at ACL 2020 | closed | 2020-07-30T13:28:35 | https://api.github.com/repos/huggingface/datasets/issues/456/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/456",
"html_url": "https://github.com/huggingface/datasets/pull/456",
"diff_url": "https://github.com/huggingface/datasets/pull/456.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/456.patch",
"merged_at": null
} | true | add crd3(ACL 2020) dataset
This PR adds the **Critical Role Dungeons and Dragons Dataset** published at ACL 2020 | [] |
https://api.github.com/repos/huggingface/datasets/issues/455 | 455 | Add bleurt | This PR adds the BLEURT metric to the library.
The BLEURT `Metric` downloads a TF checkpoint corresponding to its `config_name` at creation (in the `_info` function). Default is set to `bleurt-base-128`.
Note that the default in the original package is `bleurt-tiny-128`, but they throw a warning and recommend usi... | closed | 2020-07-29T18:08:32 | https://api.github.com/repos/huggingface/datasets/issues/455/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/455",
"html_url": "https://github.com/huggingface/datasets/pull/455",
"diff_url": "https://github.com/huggingface/datasets/pull/455.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/455.patch",
"merged_at": "2020-07-31T13:56:14"... | true | Add bleurt
This PR adds the BLEURT metric to the library.
The BLEURT `Metric` downloads a TF checkpoint corresponding to its `config_name` at creation (in the `_info` function). Default is set to `bleurt-base-128`.
Note that the default in the original package is `bleurt-tiny-128`, but they throw a warning and re... | [
"Sorry one nit: Could we use named arguments for the call to BLEURT?\r\n\r\ni.e. \r\n scores = self.scorer.score(references=references, candidates=predictions)\r\n\r\n(i.e. so it is less bug prone)\r\n",
"Following up on Ankur's comment---we are going to drop support for\npositional (not named) arguments i... |
https://api.github.com/repos/huggingface/datasets/issues/454 | 454 | Create SECURITY.md | closed | 2020-07-29T17:23:34 | https://api.github.com/repos/huggingface/datasets/issues/454/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/454",
"html_url": "https://github.com/huggingface/datasets/pull/454",
"diff_url": "https://github.com/huggingface/datasets/pull/454.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/454.patch",
"merged_at": null
} | true | Create SECURITY.md
| [] | |
https://api.github.com/repos/huggingface/datasets/issues/453 | 453 | add builder tests | I added `as_dataset` and `download_and_prepare` to the tests | closed | 2020-07-29T10:22:07 | https://api.github.com/repos/huggingface/datasets/issues/453/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/453",
"html_url": "https://github.com/huggingface/datasets/pull/453",
"diff_url": "https://github.com/huggingface/datasets/pull/453.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/453.patch",
"merged_at": "2020-07-29T11:14:05"... | true | add builder tests
I added `as_dataset` and `download_and_prepare` to the tests | [] |
https://api.github.com/repos/huggingface/datasets/issues/452 | 452 | Guardian authorship dataset | A new dataset: Guardian news articles for authorship attribution
**tests passed:**
python nlp-cli dummy_data datasets/guardian_authorship --save_infos --all_configs
RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_guardian_authorship
**Tests failed:**
Real data:... | closed | 2020-07-29T02:23:57 | https://api.github.com/repos/huggingface/datasets/issues/452/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/452",
"html_url": "https://github.com/huggingface/datasets/pull/452",
"diff_url": "https://github.com/huggingface/datasets/pull/452.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/452.patch",
"merged_at": "2020-08-20T15:07:55"... | true | Guardian authorship dataset
A new dataset: Guardian news articles for authorship attribution
**tests passed:**
python nlp-cli dummy_data datasets/guardian_authorship --save_infos --all_configs
RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_guardian_authorship
*... | [
"Hi ! Glad you managed to fix the version issue.\r\n\r\nThe command `\r\npython nlp-cli dummy_data datasets/guardian_authorship --save_infos --all_configs` is supposed to generate a json file `dataset_infos.json` next to your dataset script, but I can't see it in the PR.\r\nCan you make sure you have the json file ... |
https://api.github.com/repos/huggingface/datasets/issues/451 | 451 | Fix csv/json/txt cache dir | The cache dir for csv/json/txt datasets was always the same. This is an issue because it should be different depending on the data files provided by the user.
To fix that, I added a line that use the hash of the data files provided by the user to define the cache dir.
This should fix #444 | closed | 2020-07-28T16:30:51 | https://api.github.com/repos/huggingface/datasets/issues/451/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/451",
"html_url": "https://github.com/huggingface/datasets/pull/451",
"diff_url": "https://github.com/huggingface/datasets/pull/451.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/451.patch",
"merged_at": "2020-07-29T13:57:22"... | true | Fix csv/json/txt cache dir
The cache dir for csv/json/txt datasets was always the same. This is an issue because it should be different depending on the data files provided by the user.
To fix that, I added a line that use the hash of the data files provided by the user to define the cache dir.
This should fix #4... | [
"I think this is the way to go but I’m afraid this might be a little slow. I was thinking that we could use a high quality very fast non crypto hash like xxhash for these stuff (hashing data files)",
"Yep good idea, I'll take a look",
"I tested the hashing speed [here](https://colab.research.google.com/drive/1h... |
https://api.github.com/repos/huggingface/datasets/issues/450 | 450 | add sogou_news | This PR adds the sogou news dataset
#353 | closed | 2020-07-28T13:29:10 | https://api.github.com/repos/huggingface/datasets/issues/450/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/450",
"html_url": "https://github.com/huggingface/datasets/pull/450",
"diff_url": "https://github.com/huggingface/datasets/pull/450.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/450.patch",
"merged_at": "2020-07-29T13:30:17"... | true | add sogou_news
This PR adds the sogou news dataset
#353 | [] |
https://api.github.com/repos/huggingface/datasets/issues/449 | 449 | add reuters21578 dataset | This PR adds the `Reuters_21578` dataset https://kdd.ics.uci.edu/databases/reuters21578/reuters21578.html
#353
The datasets is a lit of `.sgm` files which are a bit different from xml file indeed `xml.etree` couldn't be used to read files. I consider them as text file (to avoid using external library) and read ... | closed | 2020-07-28T08:58:12 | https://api.github.com/repos/huggingface/datasets/issues/449/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/449",
"html_url": "https://github.com/huggingface/datasets/pull/449",
"diff_url": "https://github.com/huggingface/datasets/pull/449.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/449.patch",
"merged_at": null
} | true | add reuters21578 dataset
This PR adds the `Reuters_21578` dataset https://kdd.ics.uci.edu/databases/reuters21578/reuters21578.html
#353
The datasets is a lit of `.sgm` files which are a bit different from xml file indeed `xml.etree` couldn't be used to read files. I consider them as text file (to avoid using ext... | [
"> Awesome !\r\n> Good job on parsing these files :O\r\n> \r\n> Do you think it would be hard to get the two other split configurations ?\r\n\r\nIt shouldn't be that hard, I think I can consider different config names for each split ",
"> > Awesome !\r\n> > Good job on parsing these files :O\r\n> > Do you think i... |
https://api.github.com/repos/huggingface/datasets/issues/448 | 448 | add aws load metric test | Following issue #445
Added a test to recognize import errors of all metrics | closed | 2020-07-28T08:50:22 | https://api.github.com/repos/huggingface/datasets/issues/448/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/448",
"html_url": "https://github.com/huggingface/datasets/pull/448",
"diff_url": "https://github.com/huggingface/datasets/pull/448.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/448.patch",
"merged_at": "2020-07-28T15:02:26"... | true | add aws load metric test
Following issue #445
Added a test to recognize import errors of all metrics | [
"Could you run `make style` to fix the code_quality fail ?\r\nYou'll need `black` and `isort` that you can install by doing `pip install -e .[quality]`",
"Thanks @lhoestq\r\nI fixed the styling",
"Thank you :)"
] |
https://api.github.com/repos/huggingface/datasets/issues/447 | 447 | [BugFix] fix wrong import of DEFAULT_TOKENIZER | Fixed the path to `DEFAULT_TOKENIZER`
#445 | closed | 2020-07-28T07:41:10 | https://api.github.com/repos/huggingface/datasets/issues/447/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/447",
"html_url": "https://github.com/huggingface/datasets/pull/447",
"diff_url": "https://github.com/huggingface/datasets/pull/447.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/447.patch",
"merged_at": "2020-07-28T12:52:05"... | true | [BugFix] fix wrong import of DEFAULT_TOKENIZER
Fixed the path to `DEFAULT_TOKENIZER`
#445 | [] |
https://api.github.com/repos/huggingface/datasets/issues/446 | 446 | [BugFix] fix wrong import of DEFAULT_TOKENIZER | Fixed the path to `DEFAULT_TOKENIZER`
#445 | closed | 2020-07-28T07:32:47 | https://api.github.com/repos/huggingface/datasets/issues/446/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/446",
"html_url": "https://github.com/huggingface/datasets/pull/446",
"diff_url": "https://github.com/huggingface/datasets/pull/446.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/446.patch",
"merged_at": null
} | true | [BugFix] fix wrong import of DEFAULT_TOKENIZER
Fixed the path to `DEFAULT_TOKENIZER`
#445 | [] |
https://api.github.com/repos/huggingface/datasets/issues/445 | 445 | DEFAULT_TOKENIZER import error in sacrebleu | Latest Version 0.3.0
When loading the metric "sacrebleu" there is an import error due to the wrong path
| closed | 2020-07-28T07:31:30 | https://api.github.com/repos/huggingface/datasets/issues/445/comments | null | false | DEFAULT_TOKENIZER import error in sacrebleu
Latest Version 0.3.0
When loading the metric "sacrebleu" there is an import error due to the wrong path
| [
"This issue was resolved by #447 "
] |
https://api.github.com/repos/huggingface/datasets/issues/444 | 444 | Keep loading old file even I specify a new file in load_dataset | I used load a file called 'a.csv' by
```
dataset = load_dataset('csv', data_file='./a.csv')
```
And after a while, I tried to load another csv called 'b.csv'
```
dataset = load_dataset('csv', data_file='./b.csv')
```
However, the new dataset seems to remain the old 'a.csv' and not loading new csv file.
Even... | closed | 2020-07-27T13:08:06 | https://api.github.com/repos/huggingface/datasets/issues/444/comments | null | false | Keep loading old file even I specify a new file in load_dataset
I used load a file called 'a.csv' by
```
dataset = load_dataset('csv', data_file='./a.csv')
```
And after a while, I tried to load another csv called 'b.csv'
```
dataset = load_dataset('csv', data_file='./b.csv')
```
However, the new dataset seems... | [
"Same here !",
"This is the only fix I could come up with without touching the repo's code.\r\n```python\r\nfrom nlp.builder import FORCE_REDOWNLOAD\r\ndataset = load_dataset('csv', data_file='./a.csv', download_mode=FORCE_REDOWNLOAD, version='0.0.1')\r\n```\r\nYou'll have to change the version each time you want... |
https://api.github.com/repos/huggingface/datasets/issues/443 | 443 | Cannot unpickle saved .pt dataset with torch.save()/load() | Saving a formatted torch dataset to file using `torch.save()`. Loading the same file fails during unpickling:
```python
>>> import torch
>>> import nlp
>>> squad = nlp.load_dataset("squad.py", split="train")
>>> squad
Dataset(features: {'source_text': Value(dtype='string', id=None), 'target_text': Value(dtype... | closed | 2020-07-27T12:13:37 | https://api.github.com/repos/huggingface/datasets/issues/443/comments | null | false | Cannot unpickle saved .pt dataset with torch.save()/load()
Saving a formatted torch dataset to file using `torch.save()`. Loading the same file fails during unpickling:
```python
>>> import torch
>>> import nlp
>>> squad = nlp.load_dataset("squad.py", split="train")
>>> squad
Dataset(features: {'source_text':... | [
"This seems to be fixed in a non-released version. \r\n\r\nInstalling nlp from source\r\n```\r\ngit clone https://github.com/huggingface/nlp\r\ncd nlp\r\npip install .\r\n```\r\nsolves the issue. "
] |
https://api.github.com/repos/huggingface/datasets/issues/442 | 442 | [Suggestion] Glue Diagnostic Data with Labels | Hello! First of all, thanks for setting up this useful project!
I've just realised you provide the the [Glue Diagnostics Data](https://huggingface.co/nlp/viewer/?dataset=glue&config=ax) without labels, indicating in the `GlueConfig` that you've only a test set.
Yet, the data with labels is available, too (see als... | open | 2020-07-27T10:59:58 | https://api.github.com/repos/huggingface/datasets/issues/442/comments | null | false | [Suggestion] Glue Diagnostic Data with Labels
Hello! First of all, thanks for setting up this useful project!
I've just realised you provide the the [Glue Diagnostics Data](https://huggingface.co/nlp/viewer/?dataset=glue&config=ax) without labels, indicating in the `GlueConfig` that you've only a test set.
Yet, ... | [
"Hi! Triaging older issues this week — I think this one can be closed as out-of-scope for the current `datasets` repo.\n\n- Script-based dataset loaders (the `datasets/glue/` folder this issue was implicitly targeting) are no longer hosted in this repo. The current model is \"add the dataset directly to the Hub\": ... |
https://api.github.com/repos/huggingface/datasets/issues/441 | 441 | Add features parameter in load dataset | Added `features` argument in `nlp.load_dataset`.
If they don't match the data type, it raises a `ValueError`.
It's a draft PR because #440 needs to be merged first. | closed | 2020-07-27T09:50:01 | https://api.github.com/repos/huggingface/datasets/issues/441/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/441",
"html_url": "https://github.com/huggingface/datasets/pull/441",
"diff_url": "https://github.com/huggingface/datasets/pull/441.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/441.patch",
"merged_at": "2020-07-30T12:51:16"... | true | Add features parameter in load dataset
Added `features` argument in `nlp.load_dataset`.
If they don't match the data type, it raises a `ValueError`.
It's a draft PR because #440 needs to be merged first. | [
"This one is ready for review now",
"I changed to using features only, instead of info.\r\nLet mw know if it sounds good to you now @thomwolf "
] |
https://api.github.com/repos/huggingface/datasets/issues/440 | 440 | Fix user specified features in map | `.map` didn't keep the user specified features because of an issue in the writer.
The writer used to overwrite the user specified features with inferred features.
I also added tests to make sure it doesn't happen again. | closed | 2020-07-27T09:04:26 | https://api.github.com/repos/huggingface/datasets/issues/440/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/440",
"html_url": "https://github.com/huggingface/datasets/pull/440",
"diff_url": "https://github.com/huggingface/datasets/pull/440.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/440.patch",
"merged_at": "2020-07-28T09:25:22"... | true | Fix user specified features in map
`.map` didn't keep the user specified features because of an issue in the writer.
The writer used to overwrite the user specified features with inferred features.
I also added tests to make sure it doesn't happen again. | [] |
https://api.github.com/repos/huggingface/datasets/issues/439 | 439 | Issues: Adding a FAISS or Elastic Search index to a Dataset | It seems the DPRContextEncoder, DPRContextEncoderTokenizer cited[ in this documentation](https://huggingface.co/nlp/faiss_and_ea.html) is not implemented ? It didnot work with the standard nlp installation . Also, I couldn't find or use it with the latest nlp install from github in Colab. Is there any dependency on t... | closed | 2020-07-27T04:25:17 | https://api.github.com/repos/huggingface/datasets/issues/439/comments | null | false | Issues: Adding a FAISS or Elastic Search index to a Dataset
It seems the DPRContextEncoder, DPRContextEncoderTokenizer cited[ in this documentation](https://huggingface.co/nlp/faiss_and_ea.html) is not implemented ? It didnot work with the standard nlp installation . Also, I couldn't find or use it with the latest nlp ... | [
"`DPRContextEncoder` and `DPRContextEncoderTokenizer` will be available in the next release of `transformers`.\r\n\r\nRight now you can experiment with it by installing `transformers` from the master branch.\r\nYou can also check the docs of DPR [here](https://huggingface.co/transformers/master/model_doc/dpr.html).... |
https://api.github.com/repos/huggingface/datasets/issues/438 | 438 | New Datasets: IWSLT15+, ITTB | **Links:**
[iwslt](https://pytorchnlp.readthedocs.io/en/latest/_modules/torchnlp/datasets/iwslt.html)
Don't know if that link is up to date.
[ittb](http://www.cfilt.iitb.ac.in/iitb_parallel/)
**Motivation**: replicate mbart finetuning results (table below)
Don't know if that link is up to date.
[ittb](http://www.cfilt.iitb.ac.in/iitb_parallel/)
**Motivation**: replicate mbart finetuning results (table below)
![image](https://user-image... | [
"Thanks Sam, we now have a very detailed tutorial and template on how to add a new dataset to the library. It typically take 1-2 hours to add one. Do you want to give it a try ?\r\nThe tutorial on writing a new dataset loading script is here: https://huggingface.co/nlp/add_dataset.html\r\nAnd the part on how to sha... |
https://api.github.com/repos/huggingface/datasets/issues/437 | 437 | Fix XTREME PAN-X loading | Hi 🤗
In response to the discussion in #425 @lewtun and I made some fixes to the repo. In the original XTREME implementation the PAN-X dataset for named entity recognition loaded each word/tag pair as a single row and the sentence relation was lost. With the fix each row contains the list of all words in a single sen... | closed | 2020-07-25T14:44:57 | https://api.github.com/repos/huggingface/datasets/issues/437/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/437",
"html_url": "https://github.com/huggingface/datasets/pull/437",
"diff_url": "https://github.com/huggingface/datasets/pull/437.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/437.patch",
"merged_at": "2020-07-30T08:28:15"... | true | Fix XTREME PAN-X loading
Hi 🤗
In response to the discussion in #425 @lewtun and I made some fixes to the repo. In the original XTREME implementation the PAN-X dataset for named entity recognition loaded each word/tag pair as a single row and the sentence relation was lost. With the fix each row contains the list of ... | [
"There is an interesting design question here (cc @lhoestq).\r\n\r\nI guess the labels form a closed set so we could also use a [nlp.ClassLabel](https://huggingface.co/nlp/package_reference/main_classes.html#nlp.ClassLabel) instead of a string. The differences will be mainly that:\r\n- the labels are stored as inte... |
https://api.github.com/repos/huggingface/datasets/issues/436 | 436 | Google Colab - load_dataset - PyArrow exception | With latest PyArrow 1.0.0 installed, I get the following exception . Restarting colab has the same issue
ImportWarning: To use `nlp`, the module `pyarrow>=0.16.0` is required, and the current version of `pyarrow` doesn't match this condition. If you are running this in a Google Colab, you should probably just rest... | closed | 2020-07-25T13:05:20 | https://api.github.com/repos/huggingface/datasets/issues/436/comments | null | false | Google Colab - load_dataset - PyArrow exception
With latest PyArrow 1.0.0 installed, I get the following exception . Restarting colab has the same issue
ImportWarning: To use `nlp`, the module `pyarrow>=0.16.0` is required, and the current version of `pyarrow` doesn't match this condition. If you are running this ... | [
"Indeed, we’ll make a new PyPi release next week to solve this. Cc @lhoestq ",
"+1! this is the reason our tests are failing at [TextAttack](https://github.com/QData/TextAttack) \r\n\r\n(Though it's worth noting if we fixed the version number of pyarrow to 0.16.0 that would fix our problem too. But in this case w... |
https://api.github.com/repos/huggingface/datasets/issues/435 | 435 | ImportWarning for pyarrow 1.0.0 | The following PR raised ImportWarning at `pyarrow ==1.0.0` https://github.com/huggingface/nlp/pull/265/files | closed | 2020-07-25T03:44:39 | https://api.github.com/repos/huggingface/datasets/issues/435/comments | null | false | ImportWarning for pyarrow 1.0.0
The following PR raised ImportWarning at `pyarrow ==1.0.0` https://github.com/huggingface/nlp/pull/265/files | [
"This was fixed in #434 \r\nWe'll do a release later this week to include this fix.\r\nThanks for reporting",
"I dont know if the fix was made but the problem is still present : \r\nInstaled with pip : NLP 0.3.0 // pyarrow 1.0.0 \r\nOS : archlinux with kernel zen 5.8.5",
"Yes it was fixed in `nlp>=0.4.0`\r\nYou... |
https://api.github.com/repos/huggingface/datasets/issues/434 | 434 | Fixed check for pyarrow | Fix check for pyarrow in __init__.py. Previously would raise an error for pyarrow >= 1.0.0 | closed | 2020-07-25T00:16:53 | https://api.github.com/repos/huggingface/datasets/issues/434/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/434",
"html_url": "https://github.com/huggingface/datasets/pull/434",
"diff_url": "https://github.com/huggingface/datasets/pull/434.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/434.patch",
"merged_at": "2020-07-25T06:36:34"... | true | Fixed check for pyarrow
Fix check for pyarrow in __init__.py. Previously would raise an error for pyarrow >= 1.0.0 | [
"Great, thanks!"
] |
https://api.github.com/repos/huggingface/datasets/issues/433 | 433 | How to reuse functionality of a (generic) dataset? | I have written a generic dataset for corpora created with the Brat annotation tool ([specification](https://brat.nlplab.org/standoff.html), [dataset code](https://github.com/ArneBinder/nlp/blob/brat/datasets/brat/brat.py)). Now I wonder how to use that to create specific dataset instances. What's the recommended way to... | closed | 2020-07-24T17:27:37 | https://api.github.com/repos/huggingface/datasets/issues/433/comments | null | false | How to reuse functionality of a (generic) dataset?
I have written a generic dataset for corpora created with the Brat annotation tool ([specification](https://brat.nlplab.org/standoff.html), [dataset code](https://github.com/ArneBinder/nlp/blob/brat/datasets/brat/brat.py)). Now I wonder how to use that to create specif... | [
"Hi @ArneBinder, we have a few \"generic\" datasets which are intended to load data files with a predefined format:\r\n- csv: https://github.com/huggingface/nlp/tree/master/datasets/csv\r\n- json: https://github.com/huggingface/nlp/tree/master/datasets/json\r\n- text: https://github.com/huggingface/nlp/tree/master/... |
https://api.github.com/repos/huggingface/datasets/issues/432 | 432 | Fix handling of config files while loading datasets from multiple processes | When loading shards on several processes, each process upon loading the dataset will overwrite dataset_infos.json in <package path>/datasets/<dataset name>/<hash>/dataset_infos.json. It does so every time, even when the target file already exists and is identical. Because multiple processes rewrite the same file in par... | closed | 2020-07-24T15:10:57 | https://api.github.com/repos/huggingface/datasets/issues/432/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/432",
"html_url": "https://github.com/huggingface/datasets/pull/432",
"diff_url": "https://github.com/huggingface/datasets/pull/432.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/432.patch",
"merged_at": "2020-07-30T08:25:28"... | true | Fix handling of config files while loading datasets from multiple processes
When loading shards on several processes, each process upon loading the dataset will overwrite dataset_infos.json in <package path>/datasets/<dataset name>/<hash>/dataset_infos.json. It does so every time, even when the target file already exis... | [
"Ok for this but I think we may want to use the general `filelock` method we are using at other places in the library instead of filecmp (in particular `filelock` take care of being an atomic operation which is safer for concurrent processes)",
"Ok I see.\r\nWhy not use filelock in this case then ?",
"I think w... |
https://api.github.com/repos/huggingface/datasets/issues/431 | 431 | Specify split post processing + Add post processing resources downloading | Previously if you tried to do
```python
from nlp import load_dataset
wiki = load_dataset("wiki_dpr", "psgs_w100_with_nq_embeddings", split="train[:100]", with_index=True)
```
Then you'd get an error `Index size should match Dataset size...`
This was because it was trying to use the full index (21M elements).
... | closed | 2020-07-24T09:29:19 | https://api.github.com/repos/huggingface/datasets/issues/431/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/431",
"html_url": "https://github.com/huggingface/datasets/pull/431",
"diff_url": "https://github.com/huggingface/datasets/pull/431.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/431.patch",
"merged_at": "2020-07-31T09:05:03"... | true | Specify split post processing + Add post processing resources downloading
Previously if you tried to do
```python
from nlp import load_dataset
wiki = load_dataset("wiki_dpr", "psgs_w100_with_nq_embeddings", split="train[:100]", with_index=True)
```
Then you'd get an error `Index size should match Dataset size...... | [
"I was using a hack in `wiki_dpr` to download the index from GCS even for the configurations without the embeddings.\r\nHowever as GCS is something internal, I changed the logic to add a download step for indexes directly in the dataset script, using the `DownloadManager`.\r\n\r\nThis change was directly linked to ... |
https://api.github.com/repos/huggingface/datasets/issues/430 | 430 | add DatasetDict | ## Add DatasetDict
### Overview
When you call `load_dataset` it can return a dictionary of datasets if there are several splits (train/test for example).
If you wanted to apply dataset transforms you had to iterate over each split and apply the transform.
Instead of returning a dict, it now returns a `nlp.Dat... | closed | 2020-07-23T15:43:49 | https://api.github.com/repos/huggingface/datasets/issues/430/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/430",
"html_url": "https://github.com/huggingface/datasets/pull/430",
"diff_url": "https://github.com/huggingface/datasets/pull/430.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/430.patch",
"merged_at": "2020-07-29T09:06:22"... | true | add DatasetDict
## Add DatasetDict
### Overview
When you call `load_dataset` it can return a dictionary of datasets if there are several splits (train/test for example).
If you wanted to apply dataset transforms you had to iterate over each split and apply the transform.
Instead of returning a dict, it now re... | [
"I did the changes in the docstrings and I added a type check in each `DatasetDict` method to make sure all values are of type `Dataset`",
"Awesome, do you mind adding these in the doc as well?",
"I added it to the docs (processing + main classes)",
"I'm trying to follow along with the following about dataset... |
https://api.github.com/repos/huggingface/datasets/issues/429 | 429 | mlsum | Hello,
The tests for the load_real_data fail, as there is no default language subset to download it looks for a file that does not exist. This bug does not happen when using the load_dataset function, as it asks you to specify a language if you do not, so I submit this PR anyway. The dataset is avalaible on : https... | closed | 2020-07-23T11:52:39 | https://api.github.com/repos/huggingface/datasets/issues/429/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/429",
"html_url": "https://github.com/huggingface/datasets/pull/429",
"diff_url": "https://github.com/huggingface/datasets/pull/429.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/429.patch",
"merged_at": null
} | true | mlsum
Hello,
The tests for the load_real_data fail, as there is no default language subset to download it looks for a file that does not exist. This bug does not happen when using the load_dataset function, as it asks you to specify a language if you do not, so I submit this PR anyway. The dataset is avalaible on :... | [
"Thanks @RachelKer for this PR.\r\n\r\nI think the dummy_data structure does not also match. In the `_split_generator` you have something like `os.path.join(downloaded_files[\"validation\"], lang+'_val.jsonl')` but in you dummy_data you have `os.path.join(downloaded_files[\"validation\"], lang+\"_val.zip\", lang+'... |
https://api.github.com/repos/huggingface/datasets/issues/428 | 428 | fix concatenate_datasets | `concatenate_datatsets` used to test that the different`nlp.Dataset.schema` match, but this attribute was removed in #423 | closed | 2020-07-23T10:30:59 | https://api.github.com/repos/huggingface/datasets/issues/428/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/428",
"html_url": "https://github.com/huggingface/datasets/pull/428",
"diff_url": "https://github.com/huggingface/datasets/pull/428.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/428.patch",
"merged_at": "2020-07-23T10:34:58"... | true | fix concatenate_datasets
`concatenate_datatsets` used to test that the different`nlp.Dataset.schema` match, but this attribute was removed in #423 | [] |
https://api.github.com/repos/huggingface/datasets/issues/427 | 427 | Allow sequence features for beam + add processed Natural Questions | ## Allow Sequence features for Beam Datasets + add Natural Questions
### The issue
The steps of beam datasets processing is the following:
- download the source files and send them in a remote storage (gcs)
- process the files using a beam runner (dataflow)
- save output in remote storage (gcs)
- convert outp... | closed | 2020-07-23T09:52:41 | https://api.github.com/repos/huggingface/datasets/issues/427/comments | {
"url": "https://api.github.com/repos/huggingface/datasets/pulls/427",
"html_url": "https://github.com/huggingface/datasets/pull/427",
"diff_url": "https://github.com/huggingface/datasets/pull/427.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/427.patch",
"merged_at": "2020-07-23T13:09:29"... | true | Allow sequence features for beam + add processed Natural Questions
## Allow Sequence features for Beam Datasets + add Natural Questions
### The issue
The steps of beam datasets processing is the following:
- download the source files and send them in a remote storage (gcs)
- process the files using a beam runne... | [] |
https://api.github.com/repos/huggingface/datasets/issues/426 | 426 | [FEATURE REQUEST] Multiprocessing with for dataset.map, dataset.filter | It would be nice to be able to speed up `dataset.map` or `dataset.filter`. Perhaps this is as easy as sharding the dataset sending each shard to a process/thread/dask pool and using the new `nlp.concatenate_dataset()` function to join them all together? | closed | 2020-07-23T05:00:41 | https://api.github.com/repos/huggingface/datasets/issues/426/comments | null | false | [FEATURE REQUEST] Multiprocessing with for dataset.map, dataset.filter
It would be nice to be able to speed up `dataset.map` or `dataset.filter`. Perhaps this is as easy as sharding the dataset sending each shard to a process/thread/dask pool and using the new `nlp.concatenate_dataset()` function to join them all toget... | [
"Yes that's definitely something we plan to add ^^",
"Yes, that would be nice. We could take a look at what tensorflow `tf.data` does under the hood for instance.",
"So `tf.data.Dataset.map()` returns a `ParallelMapDataset` if `num_parallel_calls is not None` [link](https://github.com/tensorflow/tensorflow/blob... |
https://api.github.com/repos/huggingface/datasets/issues/425 | 425 | Correct data structure for PAN-X task in XTREME dataset? | Hi 🤗 team!
## Description of the problem
Thanks to the fix from #416 I am now able to load the NER task in the XTREME dataset as follows:
```python
from nlp import load_dataset
# AmazonPhotos.zip is located in data/
dataset = load_dataset("xtreme", "PAN-X.en", data_dir='./data')
dataset_train = dataset['tr... | closed | 2020-07-22T20:29:20 | https://api.github.com/repos/huggingface/datasets/issues/425/comments | null | false | Correct data structure for PAN-X task in XTREME dataset?
Hi 🤗 team!
## Description of the problem
Thanks to the fix from #416 I am now able to load the NER task in the XTREME dataset as follows:
```python
from nlp import load_dataset
# AmazonPhotos.zip is located in data/
dataset = load_dataset("xtreme", "P... | [
"Thanks for noticing ! This looks more reasonable indeed.\r\nFeel free to open a PR",
"Hi @lhoestq \r\nI made the proposed changes to the `xtreme.py` script. I noticed that I also need to change the schema in the `dataset_infos.json` file. More specifically the `\"features\"` part of the PAN-X.LANG dataset:\r\n\... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.