url
stringlengths
58
61
number
int64
1
8.23k
title
stringlengths
1
290
body
stringlengths
0
228k
state
stringclasses
2 values
created_at
timestamp[s]date
2020-04-14 10:18:02
2026-05-30 09:38:59
comments_url
stringlengths
67
70
pull_request
dict
is_pull_request
bool
2 classes
text
stringlengths
2
228k
comments
listlengths
0
30
https://api.github.com/repos/huggingface/datasets/issues/424
424
Web of science
this PR adds the WebofScience dataset #353
closed
2020-07-22T15:38:31
https://api.github.com/repos/huggingface/datasets/issues/424/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/424", "html_url": "https://github.com/huggingface/datasets/pull/424", "diff_url": "https://github.com/huggingface/datasets/pull/424.diff", "patch_url": "https://github.com/huggingface/datasets/pull/424.patch", "merged_at": "2020-07-23T14:27:56"...
true
Web of science this PR adds the WebofScience dataset #353
[]
https://api.github.com/repos/huggingface/datasets/issues/423
423
Change features vs schema logic
## New logic for `nlp.Features` in datasets Previously, it was confusing to have `features` and pyarrow's `schema` in `nlp.Dataset`. However `features` is supposed to be the front-facing object to define the different fields of a dataset, while `schema` is only used to write arrow files. Changes: - Remove `sche...
closed
2020-07-21T14:52:47
https://api.github.com/repos/huggingface/datasets/issues/423/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/423", "html_url": "https://github.com/huggingface/datasets/pull/423", "diff_url": "https://github.com/huggingface/datasets/pull/423.diff", "patch_url": "https://github.com/huggingface/datasets/pull/423.patch", "merged_at": "2020-07-23T10:15:16"...
true
Change features vs schema logic ## New logic for `nlp.Features` in datasets Previously, it was confusing to have `features` and pyarrow's `schema` in `nlp.Dataset`. However `features` is supposed to be the front-facing object to define the different fields of a dataset, while `schema` is only used to write arrow fi...
[ "I had to make `SplitDict` serializable to be able to copy `DatasetInfo` objects properly.\r\nSerialization was also asked in #389 ", "One thing I forgot to say here, is that we also want to use the features arguments of `load_dataset` (which goes in the builder’s config) to override the default features of a dat...
https://api.github.com/repos/huggingface/datasets/issues/422
422
- Corrected encoding for IMDB.
The preparation phase (after the download phase) crashed on windows because of charmap encoding not being able to decode certain characters. This change suggested in Issue #347 fixes it for the IMDB dataset.
closed
2020-07-21T13:46:59
https://api.github.com/repos/huggingface/datasets/issues/422/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/422", "html_url": "https://github.com/huggingface/datasets/pull/422", "diff_url": "https://github.com/huggingface/datasets/pull/422.diff", "patch_url": "https://github.com/huggingface/datasets/pull/422.patch", "merged_at": "2020-07-22T16:02:53"...
true
- Corrected encoding for IMDB. The preparation phase (after the download phase) crashed on windows because of charmap encoding not being able to decode certain characters. This change suggested in Issue #347 fixes it for the IMDB dataset.
[]
https://api.github.com/repos/huggingface/datasets/issues/421
421
Style change
make quality and make style ran on scripts
closed
2020-07-20T20:08:29
https://api.github.com/repos/huggingface/datasets/issues/421/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/421", "html_url": "https://github.com/huggingface/datasets/pull/421", "diff_url": "https://github.com/huggingface/datasets/pull/421.diff", "patch_url": "https://github.com/huggingface/datasets/pull/421.patch", "merged_at": null }
true
Style change make quality and make style ran on scripts
[ "What about the other PR #419 ?", "Oh this is the PR where I ran make quality and make style and some previous files from master were changed", "Oh right ! Let me fix the style myself if you don't mind" ]
https://api.github.com/repos/huggingface/datasets/issues/420
420
Better handle nested features
Changes: - added arrow schema to features conversion (it's going to be useful to fix #342 ) - make flatten handle deep features (useful for tfrecords conversion in #339 ) - add tests for flatten and features conversions - the reader now returns the kwargs to instantiate a Dataset (fix circular dependencies)
closed
2020-07-20T16:44:13
https://api.github.com/repos/huggingface/datasets/issues/420/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/420", "html_url": "https://github.com/huggingface/datasets/pull/420", "diff_url": "https://github.com/huggingface/datasets/pull/420.diff", "patch_url": "https://github.com/huggingface/datasets/pull/420.patch", "merged_at": "2020-07-21T08:09:51"...
true
Better handle nested features Changes: - added arrow schema to features conversion (it's going to be useful to fix #342 ) - make flatten handle deep features (useful for tfrecords conversion in #339 ) - add tests for flatten and features conversions - the reader now returns the kwargs to instantiate a Dataset (fix ...
[]
https://api.github.com/repos/huggingface/datasets/issues/419
419
EmoContext dataset add
EmoContext Dataset add Signed-off-by: lordtt13 <thakurtanmay72@yahoo.com>
closed
2020-07-20T15:48:45
https://api.github.com/repos/huggingface/datasets/issues/419/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/419", "html_url": "https://github.com/huggingface/datasets/pull/419", "diff_url": "https://github.com/huggingface/datasets/pull/419.diff", "patch_url": "https://github.com/huggingface/datasets/pull/419.patch", "merged_at": "2020-07-24T08:22:00"...
true
EmoContext dataset add EmoContext Dataset add Signed-off-by: lordtt13 <thakurtanmay72@yahoo.com>
[]
https://api.github.com/repos/huggingface/datasets/issues/418
418
Addition of google drive links to dl_manager
Hello there, I followed the template to create a download script of my own, which works fine for me, although I had to shun the dl_manager because it was downloading nothing from the drive links and instead use gdown. This is the script for me: ```python class EmoConfig(nlp.BuilderConfig): """BuilderConfig ...
closed
2020-07-20T14:52:02
https://api.github.com/repos/huggingface/datasets/issues/418/comments
null
false
Addition of google drive links to dl_manager Hello there, I followed the template to create a download script of my own, which works fine for me, although I had to shun the dl_manager because it was downloading nothing from the drive links and instead use gdown. This is the script for me: ```python class EmoConf...
[ "I think the problem is the way you wrote your urls. Try the following structure to see `https://drive.google.com/uc?export=download&id=your_file_id` . \r\n\r\n@lhoestq ", "Oh sorry, I think `_get_drive_url` is doing that. \r\n\r\nHave you tried to use `dl_manager.download_and_extract(_get_drive_url(_TRAIN_URL)`...
https://api.github.com/repos/huggingface/datasets/issues/417
417
Fix docstrins multiple metrics instances
We change the docstrings of `nlp.Metric.compute`, `nlp.Metric.add` and `nlp.Metric.add_batch` depending on which metric is instantiated. However we had issues when instantiating multiple metrics (docstrings were duplicated). This should fix #304
closed
2020-07-20T13:08:59
https://api.github.com/repos/huggingface/datasets/issues/417/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/417", "html_url": "https://github.com/huggingface/datasets/pull/417", "diff_url": "https://github.com/huggingface/datasets/pull/417.diff", "patch_url": "https://github.com/huggingface/datasets/pull/417.patch", "merged_at": "2020-07-22T09:50:58"...
true
Fix docstrins multiple metrics instances We change the docstrings of `nlp.Metric.compute`, `nlp.Metric.add` and `nlp.Metric.add_batch` depending on which metric is instantiated. However we had issues when instantiating multiple metrics (docstrings were duplicated). This should fix #304
[]
https://api.github.com/repos/huggingface/datasets/issues/416
416
Fix xtreme panx directory
Fix #412
closed
2020-07-20T10:09:17
https://api.github.com/repos/huggingface/datasets/issues/416/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/416", "html_url": "https://github.com/huggingface/datasets/pull/416", "diff_url": "https://github.com/huggingface/datasets/pull/416.diff", "patch_url": "https://github.com/huggingface/datasets/pull/416.patch", "merged_at": "2020-07-21T08:15:44"...
true
Fix xtreme panx directory Fix #412
[ "great, I think I did not download the data the way you do, but yours is more reasonable." ]
https://api.github.com/repos/huggingface/datasets/issues/415
415
Something is wrong with WMT 19 kk-en dataset
The translation in the `train` set does not look right: ``` >>>import nlp >>>from nlp import load_dataset >>>dataset = load_dataset('wmt19', 'kk-en') >>>dataset["train"]["translation"][0] {'kk': 'Trumpian Uncertainty', 'en': 'Трамптық белгісіздік'} >>>dataset["validation"]["translation"][0] {'kk': 'Ақша-несие...
open
2020-07-19T08:18:51
https://api.github.com/repos/huggingface/datasets/issues/415/comments
null
false
Something is wrong with WMT 19 kk-en dataset The translation in the `train` set does not look right: ``` >>>import nlp >>>from nlp import load_dataset >>>dataset = load_dataset('wmt19', 'kk-en') >>>dataset["train"]["translation"][0] {'kk': 'Trumpian Uncertainty', 'en': 'Трамптық белгісіздік'} >>>dataset["valid...
[ "Hi! Triaging older issues — I think this one can be closed as out-of-scope for the current `datasets` repo.\n\n- The script-based `wmt19` loader that this issue targets is no longer hosted in this repo (the old `datasets/wmt19/` folder is gone — script-based loaders were migrated out, see [`ADD_NEW_DATASET.md`](ht...
https://api.github.com/repos/huggingface/datasets/issues/414
414
from_dict delete?
AttributeError: type object 'Dataset' has no attribute 'from_dict'
closed
2020-07-19T07:08:36
https://api.github.com/repos/huggingface/datasets/issues/414/comments
null
false
from_dict delete? AttributeError: type object 'Dataset' has no attribute 'from_dict'
[ "`from_dict` was added in #350 that was unfortunately not included in the 0.3.0 release. It's going to be included in the next release that will be out pretty soon though.\r\nRight now if you want to use `from_dict` you have to install the package from the master branch\r\n```\r\npip install git+https://github.com/...
https://api.github.com/repos/huggingface/datasets/issues/413
413
Is there a way to download only NQ dev?
Maybe I missed that in the docs, but is there a way to only download the dev set of natural questions (~1 GB)? As we want to benchmark QA models on different datasets, I would like to avoid downloading the 41GB of training data. I tried ``` dataset = nlp.load_dataset('natural_questions', split="validation", bea...
closed
2020-07-18T10:28:23
https://api.github.com/repos/huggingface/datasets/issues/413/comments
null
false
Is there a way to download only NQ dev? Maybe I missed that in the docs, but is there a way to only download the dev set of natural questions (~1 GB)? As we want to benchmark QA models on different datasets, I would like to avoid downloading the 41GB of training data. I tried ``` dataset = nlp.load_dataset('nat...
[ "Unfortunately it's not possible to download only the dev set of NQ.\r\n\r\nI think we could add a way to download only the test set by adding a custom configuration to the processing script though.", "Ok, got it. I think this could be a valuable feature - especially for large datasets like NQ, but potentially al...
https://api.github.com/repos/huggingface/datasets/issues/412
412
Unable to load XTREME dataset from disk
Hi 🤗 team! ## Description of the problem Following the [docs](https://huggingface.co/nlp/loading_datasets.html?highlight=xtreme#manually-downloading-files) I'm trying to load the `PAN-X.fr` dataset from the [XTREME](https://github.com/google-research/xtreme) benchmark. I have manually downloaded the `AmazonPho...
closed
2020-07-18T09:55:00
https://api.github.com/repos/huggingface/datasets/issues/412/comments
null
false
Unable to load XTREME dataset from disk Hi 🤗 team! ## Description of the problem Following the [docs](https://huggingface.co/nlp/loading_datasets.html?highlight=xtreme#manually-downloading-files) I'm trying to load the `PAN-X.fr` dataset from the [XTREME](https://github.com/google-research/xtreme) benchmark. I...
[ "Hi @lewtun, you have to provide the full path to the downloaded file for example `/home/lewtum/..`", "I was able to repro. Opening a PR to fix that.\r\nThanks for reporting this issue !", "Thanks for the rapid fix @lhoestq!" ]
https://api.github.com/repos/huggingface/datasets/issues/411
411
Sbf
This PR adds the Social Bias Frames Dataset (ACL 2020) . dataset homepage: https://homes.cs.washington.edu/~msap/social-bias-frames/
closed
2020-07-17T16:19:45
https://api.github.com/repos/huggingface/datasets/issues/411/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/411", "html_url": "https://github.com/huggingface/datasets/pull/411", "diff_url": "https://github.com/huggingface/datasets/pull/411.diff", "patch_url": "https://github.com/huggingface/datasets/pull/411.patch", "merged_at": "2020-07-21T09:13:45"...
true
Sbf This PR adds the Social Bias Frames Dataset (ACL 2020) . dataset homepage: https://homes.cs.washington.edu/~msap/social-bias-frames/
[]
https://api.github.com/repos/huggingface/datasets/issues/410
410
20newsgroup
Add 20Newsgroup dataset. #353
closed
2020-07-17T13:07:57
https://api.github.com/repos/huggingface/datasets/issues/410/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/410", "html_url": "https://github.com/huggingface/datasets/pull/410", "diff_url": "https://github.com/huggingface/datasets/pull/410.diff", "patch_url": "https://github.com/huggingface/datasets/pull/410.patch", "merged_at": "2020-07-20T07:05:28"...
true
20newsgroup Add 20Newsgroup dataset. #353
[]
https://api.github.com/repos/huggingface/datasets/issues/409
409
train_test_split error: 'dict' object has no attribute 'deepcopy'
`train_test_split` is giving me an error when I try and call it: `'dict' object has no attribute 'deepcopy'` ## To reproduce ``` dataset = load_dataset('glue', 'mrpc', split='train') dataset = dataset.train_test_split(test_size=0.2) ``` ## Full Stacktrace ``` -------------------------------------------...
closed
2020-07-17T10:36:28
https://api.github.com/repos/huggingface/datasets/issues/409/comments
null
false
train_test_split error: 'dict' object has no attribute 'deepcopy' `train_test_split` is giving me an error when I try and call it: `'dict' object has no attribute 'deepcopy'` ## To reproduce ``` dataset = load_dataset('glue', 'mrpc', split='train') dataset = dataset.train_test_split(test_size=0.2) ``` ##...
[ "It was fixed in 2ddd18d139d3047c9c3abe96e1e7d05bb360132c.\r\nCould you pull the latest changes from master @morganmcg1 ?", "Thanks @lhoestq, works fine now!" ]
https://api.github.com/repos/huggingface/datasets/issues/408
408
Add tests datasets gcp
Some datasets are available on our google cloud storage in arrow format, so that the users don't need to process the data. These tests make sure that they're always available. It also makes sure that their scripts are in sync between S3 and the repo. This should avoid future issues like #407
closed
2020-07-17T09:23:27
https://api.github.com/repos/huggingface/datasets/issues/408/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/408", "html_url": "https://github.com/huggingface/datasets/pull/408", "diff_url": "https://github.com/huggingface/datasets/pull/408.diff", "patch_url": "https://github.com/huggingface/datasets/pull/408.patch", "merged_at": "2020-07-17T09:26:56"...
true
Add tests datasets gcp Some datasets are available on our google cloud storage in arrow format, so that the users don't need to process the data. These tests make sure that they're always available. It also makes sure that their scripts are in sync between S3 and the repo. This should avoid future issues like #407
[]
https://api.github.com/repos/huggingface/datasets/issues/407
407
MissingBeamOptions for Wikipedia 20200501.en
There may or may not be a regression for the pre-processed Wikipedia dataset. This was working fine 10 commits ago (without having Apache Beam available): ``` nlp.load_dataset('wikipedia', "20200501.en", split='train') ``` And now, having pulled master, I get: ``` Downloading and preparing dataset wikipedia...
closed
2020-07-16T23:48:03
https://api.github.com/repos/huggingface/datasets/issues/407/comments
null
false
MissingBeamOptions for Wikipedia 20200501.en There may or may not be a regression for the pre-processed Wikipedia dataset. This was working fine 10 commits ago (without having Apache Beam available): ``` nlp.load_dataset('wikipedia', "20200501.en", split='train') ``` And now, having pulled master, I get: ```...
[ "Fixed. Could you try again @mitchellgordon95 ?\r\nIt was due a file not being updated on S3.\r\n\r\nWe need to make sure all the datasets scripts get updated properly @julien-c ", "Works for me! Thanks.", "I found the same issue with almost any language other than English. (For English, it works). Will someone...
https://api.github.com/repos/huggingface/datasets/issues/406
406
Faster Shuffling?
Consider shuffling bookcorpus: ``` dataset = nlp.load_dataset('bookcorpus', split='train') dataset.shuffle() ``` According to tqdm, this will take around 2.5 hours on my machine to complete (even with the faster version of select from #405). I've also tried with `keep_in_memory=True` and `writer_batch_size=1000`...
closed
2020-07-16T21:21:53
https://api.github.com/repos/huggingface/datasets/issues/406/comments
null
false
Faster Shuffling? Consider shuffling bookcorpus: ``` dataset = nlp.load_dataset('bookcorpus', split='train') dataset.shuffle() ``` According to tqdm, this will take around 2.5 hours on my machine to complete (even with the faster version of select from #405). I've also tried with `keep_in_memory=True` and `write...
[ "I think the slowness here probably come from the fact that we are copying from and to python.\r\n\r\n@lhoestq for all the `select`-based methods I think we should stay in Arrow format and update the writer so that it can accept Arrow tables or batches as well. What do you think?", "> @lhoestq for all the `select...
https://api.github.com/repos/huggingface/datasets/issues/405
405
Make select() faster by batching reads
Here's a benchmark: ``` dataset = nlp.load_dataset('bookcorpus', split='train') start = time.time() dataset.select(np.arange(1000), reader_batch_size=1, load_from_cache_file=False) end = time.time() print(f'{end - start}') start = time.time() dataset.select(np.arange(1000), reader_batch_size=1000, load_fr...
closed
2020-07-16T21:19:45
https://api.github.com/repos/huggingface/datasets/issues/405/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/405", "html_url": "https://github.com/huggingface/datasets/pull/405", "diff_url": "https://github.com/huggingface/datasets/pull/405.diff", "patch_url": "https://github.com/huggingface/datasets/pull/405.patch", "merged_at": "2020-07-17T16:51:26"...
true
Make select() faster by batching reads Here's a benchmark: ``` dataset = nlp.load_dataset('bookcorpus', split='train') start = time.time() dataset.select(np.arange(1000), reader_batch_size=1, load_from_cache_file=False) end = time.time() print(f'{end - start}') start = time.time() dataset.select(np.arange...
[]
https://api.github.com/repos/huggingface/datasets/issues/404
404
Add seed in metrics
With #361 we noticed that some metrics were not deterministic. In this PR I allow the user to specify numpy's seed when instantiating a metric with `load_metric`. The seed is set only when `compute` is called, and reset afterwards. Moreover when calling `compute` with the same metric instance (i.e. same experiment...
closed
2020-07-16T17:27:05
https://api.github.com/repos/huggingface/datasets/issues/404/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/404", "html_url": "https://github.com/huggingface/datasets/pull/404", "diff_url": "https://github.com/huggingface/datasets/pull/404.diff", "patch_url": "https://github.com/huggingface/datasets/pull/404.patch", "merged_at": "2020-07-20T10:12:34"...
true
Add seed in metrics With #361 we noticed that some metrics were not deterministic. In this PR I allow the user to specify numpy's seed when instantiating a metric with `load_metric`. The seed is set only when `compute` is called, and reset afterwards. Moreover when calling `compute` with the same metric instance (...
[]
https://api.github.com/repos/huggingface/datasets/issues/403
403
return python objects instead of arrays by default
We were using to_pandas() to convert from arrow types, however it returns numpy arrays instead of python lists. I fixed it by using to_pydict/to_pylist instead. Fix #387 It was mentioned in https://github.com/huggingface/transformers/issues/5729
closed
2020-07-16T15:51:52
https://api.github.com/repos/huggingface/datasets/issues/403/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/403", "html_url": "https://github.com/huggingface/datasets/pull/403", "diff_url": "https://github.com/huggingface/datasets/pull/403.diff", "patch_url": "https://github.com/huggingface/datasets/pull/403.patch", "merged_at": "2020-07-17T11:37:00"...
true
return python objects instead of arrays by default We were using to_pandas() to convert from arrow types, however it returns numpy arrays instead of python lists. I fixed it by using to_pydict/to_pylist instead. Fix #387 It was mentioned in https://github.com/huggingface/transformers/issues/5729
[]
https://api.github.com/repos/huggingface/datasets/issues/402
402
Search qa
add SearchQA dataset #336
closed
2020-07-16T09:00:10
https://api.github.com/repos/huggingface/datasets/issues/402/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/402", "html_url": "https://github.com/huggingface/datasets/pull/402", "diff_url": "https://github.com/huggingface/datasets/pull/402.diff", "patch_url": "https://github.com/huggingface/datasets/pull/402.patch", "merged_at": "2020-07-16T14:26:59"...
true
Search qa add SearchQA dataset #336
[]
https://api.github.com/repos/huggingface/datasets/issues/401
401
add web_questions
add Web Question dataset #336 Maybe @patrickvonplaten you can help with the dummy_data structure? it still broken
closed
2020-07-16T08:54:59
https://api.github.com/repos/huggingface/datasets/issues/401/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/401", "html_url": "https://github.com/huggingface/datasets/pull/401", "diff_url": "https://github.com/huggingface/datasets/pull/401.diff", "patch_url": "https://github.com/huggingface/datasets/pull/401.patch", "merged_at": "2020-08-06T06:16:19"...
true
add web_questions add Web Question dataset #336 Maybe @patrickvonplaten you can help with the dummy_data structure? it still broken
[ "What does the `nlp-cli dummy_data` command returns ?", "`test.json` -> `test` \r\nand \r\n`train.json` -> `train`\r\n\r\nas shown by the `nlp-cli dummy_data` command ;-)", "LGTM for merge @lhoestq - I let you merge if you want to." ]
https://api.github.com/repos/huggingface/datasets/issues/400
400
Web questions
add the WebQuestion dataset #336
closed
2020-07-16T08:28:29
https://api.github.com/repos/huggingface/datasets/issues/400/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/400", "html_url": "https://github.com/huggingface/datasets/pull/400", "diff_url": "https://github.com/huggingface/datasets/pull/400.diff", "patch_url": "https://github.com/huggingface/datasets/pull/400.patch", "merged_at": null }
true
Web questions add the WebQuestion dataset #336
[]
https://api.github.com/repos/huggingface/datasets/issues/399
399
Spelling mistake
In "Formatting the dataset" part, "The two toehr modifications..." should be "The two other modifications..." ,the word "other" wrong spelled as "toehr".
closed
2020-07-16T04:37:58
https://api.github.com/repos/huggingface/datasets/issues/399/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/399", "html_url": "https://github.com/huggingface/datasets/pull/399", "diff_url": "https://github.com/huggingface/datasets/pull/399.diff", "patch_url": "https://github.com/huggingface/datasets/pull/399.patch", "merged_at": "2020-07-16T06:49:37"...
true
Spelling mistake In "Formatting the dataset" part, "The two toehr modifications..." should be "The two other modifications..." ,the word "other" wrong spelled as "toehr".
[ "Thanks!" ]
https://api.github.com/repos/huggingface/datasets/issues/398
398
Add inline links
Add inline links to `Contributing.md`
closed
2020-07-15T17:04:04
https://api.github.com/repos/huggingface/datasets/issues/398/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/398", "html_url": "https://github.com/huggingface/datasets/pull/398", "diff_url": "https://github.com/huggingface/datasets/pull/398.diff", "patch_url": "https://github.com/huggingface/datasets/pull/398.patch", "merged_at": "2020-07-22T10:14:22"...
true
Add inline links Add inline links to `Contributing.md`
[ "Do you mind adding a link to the much more extended pages on adding and sharing a dataset in the new documentation?", "Sure, I will do that too" ]
https://api.github.com/repos/huggingface/datasets/issues/397
397
Add contiguous sharding
This makes dset.shard() play nice with nlp.concatenate_datasets(). When I originally wrote the shard() method, I was thinking about a distributed training scenario, but https://github.com/huggingface/nlp/pull/389 also uses it for splitting the dataset for distributed preprocessing. Usage: ``` nlp.concatenate_datas...
closed
2020-07-15T17:02:58
https://api.github.com/repos/huggingface/datasets/issues/397/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/397", "html_url": "https://github.com/huggingface/datasets/pull/397", "diff_url": "https://github.com/huggingface/datasets/pull/397.diff", "patch_url": "https://github.com/huggingface/datasets/pull/397.patch", "merged_at": "2020-07-17T16:59:30"...
true
Add contiguous sharding This makes dset.shard() play nice with nlp.concatenate_datasets(). When I originally wrote the shard() method, I was thinking about a distributed training scenario, but https://github.com/huggingface/nlp/pull/389 also uses it for splitting the dataset for distributed preprocessing. Usage: ``...
[]
https://api.github.com/repos/huggingface/datasets/issues/396
396
Fix memory issue when doing select
We were passing the `nlp.Dataset` object to get the hash for the new dataset's file name. Fix #395
closed
2020-07-15T16:15:04
https://api.github.com/repos/huggingface/datasets/issues/396/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/396", "html_url": "https://github.com/huggingface/datasets/pull/396", "diff_url": "https://github.com/huggingface/datasets/pull/396.diff", "patch_url": "https://github.com/huggingface/datasets/pull/396.patch", "merged_at": "2020-07-16T08:07:30"...
true
Fix memory issue when doing select We were passing the `nlp.Dataset` object to get the hash for the new dataset's file name. Fix #395
[]
https://api.github.com/repos/huggingface/datasets/issues/395
395
Memory issue when doing select
As noticed in #389, the following code loads the entire wikipedia in memory. ```python import nlp w = nlp.load_dataset("wikipedia", "20200501.en", split="train") w.select([0]) ``` This is caused by [this line](https://github.com/huggingface/nlp/blob/master/src/nlp/arrow_dataset.py#L626) for some reason, that ...
closed
2020-07-15T15:43:38
https://api.github.com/repos/huggingface/datasets/issues/395/comments
null
false
Memory issue when doing select As noticed in #389, the following code loads the entire wikipedia in memory. ```python import nlp w = nlp.load_dataset("wikipedia", "20200501.en", split="train") w.select([0]) ``` This is caused by [this line](https://github.com/huggingface/nlp/blob/master/src/nlp/arrow_dataset....
[]
https://api.github.com/repos/huggingface/datasets/issues/394
394
Remove remaining nested dict
This PR deletes the remaining unnecessary nested dict #378
closed
2020-07-15T15:05:52
https://api.github.com/repos/huggingface/datasets/issues/394/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/394", "html_url": "https://github.com/huggingface/datasets/pull/394", "diff_url": "https://github.com/huggingface/datasets/pull/394.diff", "patch_url": "https://github.com/huggingface/datasets/pull/394.patch", "merged_at": "2020-07-16T07:39:51"...
true
Remove remaining nested dict This PR deletes the remaining unnecessary nested dict #378
[]
https://api.github.com/repos/huggingface/datasets/issues/393
393
Fix extracted files directory for the DownloadManager
The cache dir was often cluttered by extracted files because of the download manager. For downloaded files, we are using the `downloads` directory to make things easier to navigate, but extracted files were still placed at the root of the cache directory. To fix that I changed the directory for extracted files to ca...
closed
2020-07-15T12:59:55
https://api.github.com/repos/huggingface/datasets/issues/393/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/393", "html_url": "https://github.com/huggingface/datasets/pull/393", "diff_url": "https://github.com/huggingface/datasets/pull/393.diff", "patch_url": "https://github.com/huggingface/datasets/pull/393.patch", "merged_at": "2020-07-17T17:02:14"...
true
Fix extracted files directory for the DownloadManager The cache dir was often cluttered by extracted files because of the download manager. For downloaded files, we are using the `downloads` directory to make things easier to navigate, but extracted files were still placed at the root of the cache directory. To fix ...
[]
https://api.github.com/repos/huggingface/datasets/issues/392
392
Style change detection
Another [PAN task](https://pan.webis.de/clef20/pan20-web/style-change-detection.html). This time about identifying when the style/author changes in documents. - There's the possibility of adding the [PAN19](https://zenodo.org/record/3577602) and PAN18 style change detection tasks too (these are datasets whose labels...
closed
2020-07-15T12:32:14
https://api.github.com/repos/huggingface/datasets/issues/392/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/392", "html_url": "https://github.com/huggingface/datasets/pull/392", "diff_url": "https://github.com/huggingface/datasets/pull/392.diff", "patch_url": "https://github.com/huggingface/datasets/pull/392.patch", "merged_at": "2020-07-17T17:13:23"...
true
Style change detection Another [PAN task](https://pan.webis.de/clef20/pan20-web/style-change-detection.html). This time about identifying when the style/author changes in documents. - There's the possibility of adding the [PAN19](https://zenodo.org/record/3577602) and PAN18 style change detection tasks too (these ar...
[]
https://api.github.com/repos/huggingface/datasets/issues/390
390
Concatenate datasets
I'm constructing the "WikiBooks" dataset, which is a concatenation of Wikipedia & BookCorpus. So I implemented the `Dataset.from_concat()` method, which concatenates two datasets with the same schema. This would also be useful if someone wants to pretrain on a large generic dataset + their own custom dataset. Not in...
closed
2020-07-14T23:24:37
https://api.github.com/repos/huggingface/datasets/issues/390/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/390", "html_url": "https://github.com/huggingface/datasets/pull/390", "diff_url": "https://github.com/huggingface/datasets/pull/390.diff", "patch_url": "https://github.com/huggingface/datasets/pull/390.patch", "merged_at": "2020-07-22T09:49:58"...
true
Concatenate datasets I'm constructing the "WikiBooks" dataset, which is a concatenation of Wikipedia & BookCorpus. So I implemented the `Dataset.from_concat()` method, which concatenates two datasets with the same schema. This would also be useful if someone wants to pretrain on a large generic dataset + their own c...
[ "Looks cool :)\r\n\r\nI feel like \r\n```python\r\nconcatenated_dataset = dataset1.concatenate(dataset2)\r\n```\r\ncould be more natural. What do you think ?\r\n\r\nAlso could you also concatenate the `nlp.Dataset._data_files` ?\r\n```python\r\nreturn cls(table, info=info, split=split, data_files=self._data_files +...
https://api.github.com/repos/huggingface/datasets/issues/389
389
Fix pickling of SplitDict
It would be nice to pickle and unpickle Datasets, as done in [this tutorial](https://github.com/patil-suraj/exploring-T5/blob/master/T5_on_TPU.ipynb). Example: ``` wiki = nlp.load_dataset('wikipedia', split='train') def sentencize(examples): ... wiki = wiki.map(sentencize, batched=True) torch.save(wiki, '...
closed
2020-07-14T21:53:39
https://api.github.com/repos/huggingface/datasets/issues/389/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/389", "html_url": "https://github.com/huggingface/datasets/pull/389", "diff_url": "https://github.com/huggingface/datasets/pull/389.diff", "patch_url": "https://github.com/huggingface/datasets/pull/389.patch", "merged_at": null }
true
Fix pickling of SplitDict It would be nice to pickle and unpickle Datasets, as done in [this tutorial](https://github.com/patil-suraj/exploring-T5/blob/master/T5_on_TPU.ipynb). Example: ``` wiki = nlp.load_dataset('wikipedia', split='train') def sentencize(examples): ... wiki = wiki.map(sentencize, batched...
[ "By the way, the reason this is an issue for me is because I want to be able to \"save\" changes made to a dataset by writing something to disk. In this case, I would like to pre-process my dataset once, and then train multiple models on the dataset later without having to re-process the data. \r\n\r\nIs pickling/u...
https://api.github.com/repos/huggingface/datasets/issues/388
388
🐛 [Dataset] Cannot download wmt14, wmt15 and wmt17
1. I try downloading `wmt14`, `wmt15`, `wmt17`, `wmt19` with the following code: ``` nlp.load_dataset('wmt14','de-en') nlp.load_dataset('wmt15','de-en') nlp.load_dataset('wmt17','de-en') nlp.load_dataset('wmt19','de-en') ``` The code runs but the download speed is **extremely slow**, the same behaviour is not ob...
closed
2020-07-14T15:36:41
https://api.github.com/repos/huggingface/datasets/issues/388/comments
null
false
🐛 [Dataset] Cannot download wmt14, wmt15 and wmt17 1. I try downloading `wmt14`, `wmt15`, `wmt17`, `wmt19` with the following code: ``` nlp.load_dataset('wmt14','de-en') nlp.load_dataset('wmt15','de-en') nlp.load_dataset('wmt17','de-en') nlp.load_dataset('wmt19','de-en') ``` The code runs but the download speed...
[ "similar slow download speed here for nlp.load_dataset('wmt14', 'fr-en')\r\n`\r\nDownloading: 100%|██████████████████████████████████████████████████████████| 658M/658M [1:00:42<00:00, 181kB/s]\r\nDownloading: 100%|██████████████████████████████████████████████████████████| 918M/918M [1:39:38<00:00, 154kB/s]\r\nDow...
https://api.github.com/repos/huggingface/datasets/issues/387
387
Conversion through to_pandas output numpy arrays for lists instead of python objects
In a related question, the conversion through to_pandas output numpy arrays for the lists instead of python objects. Here is an example: ```python >>> dataset._data.slice(key, 1).to_pandas().to_dict("list") {'sentence1': ['Amrozi accused his brother , whom he called " the witness " , of deliberately distorting hi...
closed
2020-07-14T06:24:01
https://api.github.com/repos/huggingface/datasets/issues/387/comments
null
false
Conversion through to_pandas output numpy arrays for lists instead of python objects In a related question, the conversion through to_pandas output numpy arrays for the lists instead of python objects. Here is an example: ```python >>> dataset._data.slice(key, 1).to_pandas().to_dict("list") {'sentence1': ['Amrozi...
[ "To convert from arrow type we have three options: to_numpy, to_pandas and to_pydict/to_pylist.\r\n\r\n- to_numpy and to_pandas return numpy arrays instead of lists but are very fast.\r\n- to_pydict/to_pylist can be 100x slower and become the bottleneck for reading data, but at least they return lists.\r\n\r\nMaybe...
https://api.github.com/repos/huggingface/datasets/issues/386
386
Update dataset loading and features - Add TREC dataset
This PR: - add a template for a new dataset script - update the caching structure so that the path to the cached data files is also a function of the dataset loading script hash. This way when you update a loading script the data will be automatically updated instead of falling back to the previous version (which is ...
closed
2020-07-13T13:10:18
https://api.github.com/repos/huggingface/datasets/issues/386/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/386", "html_url": "https://github.com/huggingface/datasets/pull/386", "diff_url": "https://github.com/huggingface/datasets/pull/386.diff", "patch_url": "https://github.com/huggingface/datasets/pull/386.patch", "merged_at": "2020-07-16T08:17:58"...
true
Update dataset loading and features - Add TREC dataset This PR: - add a template for a new dataset script - update the caching structure so that the path to the cached data files is also a function of the dataset loading script hash. This way when you update a loading script the data will be automatically updated ins...
[ "I just copied the files that are on google storage to follow the new `_relative_data_dir ` format. It should be good to merge now :)\r\n\r\nWell actually it seems there are some merge conflicts to fix first" ]
https://api.github.com/repos/huggingface/datasets/issues/385
385
Remove unnecessary nested dict
This PR is removing unnecessary nested dictionary used in some datasets. For now the following datasets are updated: - MLQA - RACE Will be adding more if necessary. #378
closed
2020-07-13T08:46:23
https://api.github.com/repos/huggingface/datasets/issues/385/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/385", "html_url": "https://github.com/huggingface/datasets/pull/385", "diff_url": "https://github.com/huggingface/datasets/pull/385.diff", "patch_url": "https://github.com/huggingface/datasets/pull/385.patch", "merged_at": "2020-07-15T10:03:53"...
true
Remove unnecessary nested dict This PR is removing unnecessary nested dictionary used in some datasets. For now the following datasets are updated: - MLQA - RACE Will be adding more if necessary. #378
[ "We can probably scan the dataset scripts with a regexpr to try to identify this pattern cc @patrickvonplaten maybe", "@mariamabarham This script should work. I tested it for a couple of datasets. There might be exceptions where the script breaks - did not test everything.\r\n\r\n```python\r\n#!/usr/bin/env pytho...
https://api.github.com/repos/huggingface/datasets/issues/383
383
Adding the Linguistic Code-switching Evaluation (LinCE) benchmark
Hi, First of all, this library is really cool! Thanks for putting all of this together! This PR contains the [Linguistic Code-switching Evaluation (LinCE) benchmark](https://ritual.uh.edu/lince). As described in the official website (FAQ): > 1. Why do we need LinCE? >LinCE brings 10 code-switching datasets t...
closed
2020-07-11T22:35:20
https://api.github.com/repos/huggingface/datasets/issues/383/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/383", "html_url": "https://github.com/huggingface/datasets/pull/383", "diff_url": "https://github.com/huggingface/datasets/pull/383.diff", "patch_url": "https://github.com/huggingface/datasets/pull/383.patch", "merged_at": "2020-07-16T16:19:46"...
true
Adding the Linguistic Code-switching Evaluation (LinCE) benchmark Hi, First of all, this library is really cool! Thanks for putting all of this together! This PR contains the [Linguistic Code-switching Evaluation (LinCE) benchmark](https://ritual.uh.edu/lince). As described in the official website (FAQ): > 1....
[ "I am checking the details of the CI log for the failed test, but I don't see how the error relates to the code I added; the error is coming from a config builder different than the `LinceConfig`, and it crashes when `self.config.data_files` because is self.config is None. I would appreciate if someone could help m...
https://api.github.com/repos/huggingface/datasets/issues/382
382
1080
closed
2020-07-11T22:29:07
https://api.github.com/repos/huggingface/datasets/issues/382/comments
null
false
1080
[]
https://api.github.com/repos/huggingface/datasets/issues/381
381
NLp
closed
2020-07-11T20:50:14
https://api.github.com/repos/huggingface/datasets/issues/381/comments
null
false
NLp
[]
https://api.github.com/repos/huggingface/datasets/issues/378
378
[dataset] Structure of MLQA seems unecessary nested
The features of the MLQA dataset comprise several nested dictionaries with a single element inside (for `questions` and `ids`): https://github.com/huggingface/nlp/blob/master/datasets/mlqa/mlqa.py#L90-L97 Should we keep this @mariamabarham @patrickvonplaten? Was this added for compatibility with tfds? ```python ...
closed
2020-07-11T15:16:08
https://api.github.com/repos/huggingface/datasets/issues/378/comments
null
false
[dataset] Structure of MLQA seems unecessary nested The features of the MLQA dataset comprise several nested dictionaries with a single element inside (for `questions` and `ids`): https://github.com/huggingface/nlp/blob/master/datasets/mlqa/mlqa.py#L90-L97 Should we keep this @mariamabarham @patrickvonplaten? Was th...
[ "Same for the RACE dataset: https://github.com/huggingface/nlp/blob/master/datasets/race/race.py\r\n\r\nShould we scan all the datasets to remove this pattern of un-necessary nesting?", "You're right, I think we don't need to use the nested dictionary. \r\n" ]
https://api.github.com/repos/huggingface/datasets/issues/377
377
Iyy!!!
closed
2020-07-11T14:11:07
https://api.github.com/repos/huggingface/datasets/issues/377/comments
null
false
Iyy!!!
[]
https://api.github.com/repos/huggingface/datasets/issues/376
376
to_pandas conversion doesn't always work
For some complex nested types, the conversion from Arrow to python dict through pandas doesn't seem to be possible. Here is an example using the official SQUAD v2 JSON file. This example was found while investigating #373. ```python >>> squad = load_dataset('json', data_files={nlp.Split.TRAIN: ["./train-v2.0....
closed
2020-07-10T21:33:31
https://api.github.com/repos/huggingface/datasets/issues/376/comments
null
false
to_pandas conversion doesn't always work For some complex nested types, the conversion from Arrow to python dict through pandas doesn't seem to be possible. Here is an example using the official SQUAD v2 JSON file. This example was found while investigating #373. ```python >>> squad = load_dataset('json', dat...
[ "**Edit**: other topic previously in this message moved to a new issue: https://github.com/huggingface/nlp/issues/387", "Could you try to update pyarrow to >=0.17.0 ? It should fix the `to_pandas` bug\r\n\r\nAlso I'm not sure that structures like list<struct> are fully supported in the lib (none of the datasets u...
https://api.github.com/repos/huggingface/datasets/issues/375
375
TypeError when computing bertscore
Hi, I installed nlp 0.3.0 via pip, and my python version is 3.7. When I tried to compute bertscore with the code: ``` import nlp bertscore = nlp.load_metric('bertscore') # load hyps and refs ... print (bertscore.compute(hyps, refs, lang='en')) ``` I got the following error. ``` Traceback (most rece...
closed
2020-07-10T20:37:44
https://api.github.com/repos/huggingface/datasets/issues/375/comments
null
false
TypeError when computing bertscore Hi, I installed nlp 0.3.0 via pip, and my python version is 3.7. When I tried to compute bertscore with the code: ``` import nlp bertscore = nlp.load_metric('bertscore') # load hyps and refs ... print (bertscore.compute(hyps, refs, lang='en')) ``` I got the followin...
[ "I am not able to reproduce this issue on my side.\r\nCould you give us more details about the inputs you used ?\r\n\r\nI do get another error though:\r\n```\r\n~/.virtualenvs/hf-datasets/lib/python3.7/site-packages/bert_score/utils.py in bert_cos_score_idf(model, refs, hyps, tokenizer, idf_dict, verbose, batch_siz...
https://api.github.com/repos/huggingface/datasets/issues/374
374
Add dataset post processing for faiss indexes
# Post processing of datasets for faiss indexes Now that we can have datasets with embeddings (see `wiki_pr` for example), we can allow users to load the dataset + get the Faiss index that comes with it to do nearest neighbors queries. ## Implementation proposition - Faiss indexes have to be added to the `nlp....
closed
2020-07-10T16:25:59
https://api.github.com/repos/huggingface/datasets/issues/374/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/374", "html_url": "https://github.com/huggingface/datasets/pull/374", "diff_url": "https://github.com/huggingface/datasets/pull/374.diff", "patch_url": "https://github.com/huggingface/datasets/pull/374.patch", "merged_at": "2020-07-13T13:44:01"...
true
Add dataset post processing for faiss indexes # Post processing of datasets for faiss indexes Now that we can have datasets with embeddings (see `wiki_pr` for example), we can allow users to load the dataset + get the Faiss index that comes with it to do nearest neighbors queries. ## Implementation proposition ...
[ "I changed the `wiki_dpr` script to ignore the last 24 examples for now. Hopefully we'll have the full version soon.\r\nThe datasets_infos.json and the data on GCS are updated.\r\n\r\nAnd I also added a check to make sure we don't have post processing resources in sub-directories.", "I added a dummy config that c...
https://api.github.com/repos/huggingface/datasets/issues/373
373
Segmentation fault when loading local JSON dataset as of #372
The last issue was closed (#369) once the #372 update was merged. However, I'm still not able to load a SQuAD formatted JSON file. Instead of the previously recorded pyarrow error, I now get a segmentation fault. ``` dataset = nlp.load_dataset('json', data_files={nlp.Split.TRAIN: ["./datasets/train-v2.0.json"]}, f...
closed
2020-07-10T15:04:25
https://api.github.com/repos/huggingface/datasets/issues/373/comments
null
false
Segmentation fault when loading local JSON dataset as of #372 The last issue was closed (#369) once the #372 update was merged. However, I'm still not able to load a SQuAD formatted JSON file. Instead of the previously recorded pyarrow error, I now get a segmentation fault. ``` dataset = nlp.load_dataset('json', d...
[ "I've seen this sort of thing before -- it might help to delete the directory -- I've also noticed that there is an error with the json Dataloader for any data I've tried to load. I've replaced it with this, which skips over the data feature population step:\r\n\r\n\r\n```python\r\nimport os\r\n\r\nimport pyarrow.j...
https://api.github.com/repos/huggingface/datasets/issues/372
372
Make the json script more flexible
Fix https://github.com/huggingface/nlp/issues/359 Fix https://github.com/huggingface/nlp/issues/369 JSON script now can accept JSON files containing a single dict with the records as a list in one attribute to the dict (previously it only accepted JSON files containing records as rows of dicts in the file). In t...
closed
2020-07-10T13:15:15
https://api.github.com/repos/huggingface/datasets/issues/372/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/372", "html_url": "https://github.com/huggingface/datasets/pull/372", "diff_url": "https://github.com/huggingface/datasets/pull/372.diff", "patch_url": "https://github.com/huggingface/datasets/pull/372.patch", "merged_at": "2020-07-10T14:52:05"...
true
Make the json script more flexible Fix https://github.com/huggingface/nlp/issues/359 Fix https://github.com/huggingface/nlp/issues/369 JSON script now can accept JSON files containing a single dict with the records as a list in one attribute to the dict (previously it only accepted JSON files containing records as ...
[]
https://api.github.com/repos/huggingface/datasets/issues/371
371
Fix cached file path for metrics with different config names
The config name was not taken into account to build the cached file path. It should fix #368
closed
2020-07-10T10:02:24
https://api.github.com/repos/huggingface/datasets/issues/371/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/371", "html_url": "https://github.com/huggingface/datasets/pull/371", "diff_url": "https://github.com/huggingface/datasets/pull/371.diff", "patch_url": "https://github.com/huggingface/datasets/pull/371.patch", "merged_at": "2020-07-10T13:45:20"...
true
Fix cached file path for metrics with different config names The config name was not taken into account to build the cached file path. It should fix #368
[ "Thanks for the fast fix!" ]
https://api.github.com/repos/huggingface/datasets/issues/370
370
Allow indexing Dataset via np.ndarray
closed
2020-07-09T19:43:15
https://api.github.com/repos/huggingface/datasets/issues/370/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/370", "html_url": "https://github.com/huggingface/datasets/pull/370", "diff_url": "https://github.com/huggingface/datasets/pull/370.diff", "patch_url": "https://github.com/huggingface/datasets/pull/370.patch", "merged_at": "2020-07-10T14:05:43"...
true
Allow indexing Dataset via np.ndarray
[ "Looks like a flaky CI, failed download from S3." ]
https://api.github.com/repos/huggingface/datasets/issues/369
369
can't load local dataset: pyarrow.lib.ArrowInvalid: straddling object straddles two block boundaries
Trying to load a local SQuAD-formatted dataset (from a JSON file, about 60MB): ``` dataset = nlp.load_dataset(path='json', data_files={nlp.Split.TRAIN: ["./path/to/file.json"]}) ``` causes ``` Traceback (most recent call last): File "dataloader.py", line 9, in <module> ["./path/to/file.json"]}) File "/...
closed
2020-07-09T16:16:53
https://api.github.com/repos/huggingface/datasets/issues/369/comments
null
false
can't load local dataset: pyarrow.lib.ArrowInvalid: straddling object straddles two block boundaries Trying to load a local SQuAD-formatted dataset (from a JSON file, about 60MB): ``` dataset = nlp.load_dataset(path='json', data_files={nlp.Split.TRAIN: ["./path/to/file.json"]}) ``` causes ``` Traceback (most rece...
[ "I am able to reproduce this with the official SQuAD `train-v2.0.json` file downloaded directly from https://rajpurkar.github.io/SQuAD-explorer/", "I am facing this issue in transformers library 3.0.2 while reading a csv using datasets.\r\nIs this fixed in latest version? \r\nI updated the latest version 4.0.1 bu...
https://api.github.com/repos/huggingface/datasets/issues/368
368
load_metric can't acquire lock anymore
I can't load metric (glue) anymore after an error in a previous run. I even removed the whole cache folder `/home/XXX/.cache/huggingface/`, and the issue persisted. What are the steps to fix this? Traceback (most recent call last): File "/home/XXX/miniconda3/envs/ML-DL-py-3.7/lib/python3.7/site-packages/n...
closed
2020-07-09T14:04:09
https://api.github.com/repos/huggingface/datasets/issues/368/comments
null
false
load_metric can't acquire lock anymore I can't load metric (glue) anymore after an error in a previous run. I even removed the whole cache folder `/home/XXX/.cache/huggingface/`, and the issue persisted. What are the steps to fix this? Traceback (most recent call last): File "/home/XXX/miniconda3/envs/ML-...
[ "I found that, in the same process (or the same interactive session), if I do\r\n\r\nimport nlp\r\n\r\nm1 = nlp.load_metric('glue', 'mrpc')\r\nm2 = nlp.load_metric('glue', 'sst2')\r\n\r\nI will get the same error `ValueError: Cannot acquire lock, caching file might be used by another process, you should setup a uni...
https://api.github.com/repos/huggingface/datasets/issues/367
367
Update Xtreme to add PAWS-X es
This PR adds the `PAWS-X.es` in the Xtreme dataset #362
closed
2020-07-09T12:14:37
https://api.github.com/repos/huggingface/datasets/issues/367/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/367", "html_url": "https://github.com/huggingface/datasets/pull/367", "diff_url": "https://github.com/huggingface/datasets/pull/367.diff", "patch_url": "https://github.com/huggingface/datasets/pull/367.patch", "merged_at": "2020-07-09T12:37:10"...
true
Update Xtreme to add PAWS-X es This PR adds the `PAWS-X.es` in the Xtreme dataset #362
[]
https://api.github.com/repos/huggingface/datasets/issues/366
366
Add quora dataset
Added the [Quora question pairs dataset](https://www.quora.com/q/quoradata/First-Quora-Dataset-Release-Question-Pairs). Implementation Notes: - I used the original version provided on the quora website. There's also a [Kaggle competition](https://www.kaggle.com/c/quora-question-pairs) which has a nice train/test sp...
closed
2020-07-09T10:34:22
https://api.github.com/repos/huggingface/datasets/issues/366/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/366", "html_url": "https://github.com/huggingface/datasets/pull/366", "diff_url": "https://github.com/huggingface/datasets/pull/366.diff", "patch_url": "https://github.com/huggingface/datasets/pull/366.patch", "merged_at": "2020-07-13T17:35:21"...
true
Add quora dataset Added the [Quora question pairs dataset](https://www.quora.com/q/quoradata/First-Quora-Dataset-Release-Question-Pairs). Implementation Notes: - I used the original version provided on the quora website. There's also a [Kaggle competition](https://www.kaggle.com/c/quora-question-pairs) which has a ...
[ "Tests seem to be failing because of pandas", "Kaggle needs authentification to download datasets. We don't have a way to handle that in the lib for now" ]
https://api.github.com/repos/huggingface/datasets/issues/365
365
How to augment data ?
Is there any clean way to augment data ? For now my work-around is to use batched map, like this : ```python def aug(samples): # Simply copy the existing data to have x2 amount of data for k, v in samples.items(): samples[k].extend(v) return samples dataset = dataset.map(aug, batched=T...
closed
2020-07-09T07:52:37
https://api.github.com/repos/huggingface/datasets/issues/365/comments
null
false
How to augment data ? Is there any clean way to augment data ? For now my work-around is to use batched map, like this : ```python def aug(samples): # Simply copy the existing data to have x2 amount of data for k, v in samples.items(): samples[k].extend(v) return samples dataset = data...
[ "Using batched map is probably the easiest way at the moment.\r\nWhat kind of augmentation would you like to do ?", "Some samples in the dataset are too long, I want to divide them in several samples.", "Using batched map is the way to go then.\r\nWe'll make it clearer in the docs that map could be used for aug...
https://api.github.com/repos/huggingface/datasets/issues/364
364
add MS MARCO dataset
This PR adds the MS MARCO dataset as requested in this issue #336. MS mARCO has multiple task including: - Passage and Document Retrieval - Keyphrase Extraction - QA and NLG This PR only adds the 2 versions of the QA and NLG task dataset which was realeased with the original paper here https://arxiv.org/pd...
closed
2020-07-09T07:11:19
https://api.github.com/repos/huggingface/datasets/issues/364/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/364", "html_url": "https://github.com/huggingface/datasets/pull/364", "diff_url": "https://github.com/huggingface/datasets/pull/364.diff", "patch_url": "https://github.com/huggingface/datasets/pull/364.patch", "merged_at": "2020-08-06T06:15:48"...
true
add MS MARCO dataset This PR adds the MS MARCO dataset as requested in this issue #336. MS mARCO has multiple task including: - Passage and Document Retrieval - Keyphrase Extraction - QA and NLG This PR only adds the 2 versions of the QA and NLG task dataset which was realeased with the original paper here...
[ "The dummy data for v2.1 is missing as far as I can see. I think running the dummy data command should work correctly here. ", "Also, it might be that the structure of the dummy data is wrong - looking at `generate_examples` the structure does not look too easy.", "The fact that the dummy data for v2.1 is miss...
https://api.github.com/repos/huggingface/datasets/issues/363
363
Adding support for generic multi dimensional tensors and auxillary image data for multimodal datasets
nlp/features.py: The main factory class is MultiArray, every single time this class is called, a corresponding pyarrow extension array and type class is generated (and added to the list of globals for future use) for a given root data type and set of dimensions/shape. I provide examples on working with this in datas...
closed
2020-07-09T07:10:30
https://api.github.com/repos/huggingface/datasets/issues/363/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/363", "html_url": "https://github.com/huggingface/datasets/pull/363", "diff_url": "https://github.com/huggingface/datasets/pull/363.diff", "patch_url": "https://github.com/huggingface/datasets/pull/363.patch", "merged_at": "2020-08-24T09:59:35"...
true
Adding support for generic multi dimensional tensors and auxillary image data for multimodal datasets nlp/features.py: The main factory class is MultiArray, every single time this class is called, a corresponding pyarrow extension array and type class is generated (and added to the list of globals for future use) f...
[ "Thank you! I just marked this as a draft PR. It probably would be better to create specific Array2D and Array3D classes as needed instead of a generic MultiArray for now, it should simplify the code a lot too so, I'll update it as such. Also i was meaning to reply earlier, but I wanted to thank you for the testing...
https://api.github.com/repos/huggingface/datasets/issues/362
362
[dateset subset missing] xtreme paws-x
I tried nlp.load_dataset('xtreme', 'PAWS-X.es') but get the value error It turns out that the subset for Spanish is missing https://github.com/google-research-datasets/paws/tree/master/pawsx
closed
2020-07-09T05:04:54
https://api.github.com/repos/huggingface/datasets/issues/362/comments
null
false
[dateset subset missing] xtreme paws-x I tried nlp.load_dataset('xtreme', 'PAWS-X.es') but get the value error It turns out that the subset for Spanish is missing https://github.com/google-research-datasets/paws/tree/master/pawsx
[ "You're right, thanks for pointing it out. We will update it " ]
https://api.github.com/repos/huggingface/datasets/issues/361
361
🐛 [Metrics] ROUGE is non-deterministic
If I run the ROUGE metric 2 times, with same predictions / references, the scores are slightly different. Refer to [this Colab notebook](https://colab.research.google.com/drive/1wRssNXgb9ldcp4ulwj-hMJn0ywhDOiDy?usp=sharing) for reproducing the problem. Example of F-score for ROUGE-1, ROUGE-2, ROUGE-L in 2 differe...
closed
2020-07-09T04:39:37
https://api.github.com/repos/huggingface/datasets/issues/361/comments
null
false
🐛 [Metrics] ROUGE is non-deterministic If I run the ROUGE metric 2 times, with same predictions / references, the scores are slightly different. Refer to [this Colab notebook](https://colab.research.google.com/drive/1wRssNXgb9ldcp4ulwj-hMJn0ywhDOiDy?usp=sharing) for reproducing the problem. Example of F-score fo...
[ "Hi, can you give a full self-contained example to reproduce this behavior?", "> Hi, can you give a full self-contained example to reproduce this behavior?\r\n\r\nThere is a notebook in the post ;)", "> If I run the ROUGE metric 2 times, with same predictions / references, the scores are slightly different.\r\n...
https://api.github.com/repos/huggingface/datasets/issues/360
360
[Feature request] Add dataset.ragged_map() function for many-to-many transformations
`dataset.map()` enables one-to-one transformations. Input one example and output one example. This is helpful for tokenizing and cleaning individual lines. `dataset.filter()` enables one-to-(one-or-none) transformations. Input one example and output either zero/one example. This is helpful for removing portions from t...
closed
2020-07-09T01:04:43
https://api.github.com/repos/huggingface/datasets/issues/360/comments
null
false
[Feature request] Add dataset.ragged_map() function for many-to-many transformations `dataset.map()` enables one-to-one transformations. Input one example and output one example. This is helpful for tokenizing and cleaning individual lines. `dataset.filter()` enables one-to-(one-or-none) transformations. Input one exa...
[ "Actually `map(batched=True)` can already change the size of the dataset.\r\nIt can accept examples of length `N` and returns a batch of length `M` (can be null or greater than `N`).\r\n\r\nI'll make that explicit in the doc that I'm currently writing.", "You're two steps ahead of me :) In my testing, it also wor...
https://api.github.com/repos/huggingface/datasets/issues/359
359
ArrowBasedBuilder _prepare_split parse_schema breaks on nested structures
I tried using the Json dataloader to load some JSON lines files. but get an exception in the parse_schema function. ``` --------------------------------------------------------------------------- ValueError Traceback (most recent call last) <ipython-input-23-9aecfbee53bd> in <mo...
closed
2020-07-08T23:24:05
https://api.github.com/repos/huggingface/datasets/issues/359/comments
null
false
ArrowBasedBuilder _prepare_split parse_schema breaks on nested structures I tried using the Json dataloader to load some JSON lines files. but get an exception in the parse_schema function. ``` --------------------------------------------------------------------------- ValueError T...
[ "Hi, it depends on what it is in your `dataset_builder.py` file. Can you share it?\r\n\r\nIf you are just loading `json` files, you can also directly use the `json` script (which will find the schema/features from your JSON structure):\r\n\r\n```python\r\nfrom nlp import load_dataset\r\nds = load_dataset(\"json\", ...
https://api.github.com/repos/huggingface/datasets/issues/358
358
Starting to add some real doc
Adding a lot of documentation for: - load a dataset - explore the dataset object - process data with the dataset - add a new dataset script - share a dataset script - full package reference This version of the doc can be explored here: https://2219-250213286-gh.circle-artifacts.com/0/docs/_build/html/index.htm...
closed
2020-07-08T22:53:03
https://api.github.com/repos/huggingface/datasets/issues/358/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/358", "html_url": "https://github.com/huggingface/datasets/pull/358", "diff_url": "https://github.com/huggingface/datasets/pull/358.diff", "patch_url": "https://github.com/huggingface/datasets/pull/358.patch", "merged_at": "2020-07-14T09:58:15"...
true
Starting to add some real doc Adding a lot of documentation for: - load a dataset - explore the dataset object - process data with the dataset - add a new dataset script - share a dataset script - full package reference This version of the doc can be explored here: https://2219-250213286-gh.circle-artifacts.co...
[ "Ok this is starting to be really big so it's probably good to merge this first version of the doc and continue in another PR :)\r\n\r\nThis first version of the doc can be explored here: https://2219-250213286-gh.circle-artifacts.com/0/docs/_build/html/index.html" ]
https://api.github.com/repos/huggingface/datasets/issues/357
357
Add hashes to cnn_dailymail
The URL hashes are helpful for comparing results from other sources.
closed
2020-07-08T22:45:21
https://api.github.com/repos/huggingface/datasets/issues/357/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/357", "html_url": "https://github.com/huggingface/datasets/pull/357", "diff_url": "https://github.com/huggingface/datasets/pull/357.diff", "patch_url": "https://github.com/huggingface/datasets/pull/357.patch", "merged_at": "2020-07-13T14:16:38"...
true
Add hashes to cnn_dailymail The URL hashes are helpful for comparing results from other sources.
[ "Looks you to me :)\r\n\r\nCould you also update the json file that goes with the dataset script by doing \r\n```\r\nnlp-cli test ./datasets/cnn_dailymail --save_infos --all_configs\r\n```\r\nIt will update the features metadata and the size of the dataset with your changes.", "@lhoestq I ran that command.\r\n\r\...
https://api.github.com/repos/huggingface/datasets/issues/356
356
Add text dataset
Usage: ```python from nlp import load_dataset dset = load_dataset("text", data_files="/path/to/file.txt")["train"] ``` I created a dummy_data.zip which contains three files: `train.txt`, `test.txt`, `dev.txt`. Each of these contains two lines. It passes ```bash RUN_SLOW=1 pytest tests/test_dataset_common...
closed
2020-07-08T19:21:53
https://api.github.com/repos/huggingface/datasets/issues/356/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/356", "html_url": "https://github.com/huggingface/datasets/pull/356", "diff_url": "https://github.com/huggingface/datasets/pull/356.diff", "patch_url": "https://github.com/huggingface/datasets/pull/356.patch", "merged_at": "2020-07-10T14:19:03"...
true
Add text dataset Usage: ```python from nlp import load_dataset dset = load_dataset("text", data_files="/path/to/file.txt")["train"] ``` I created a dummy_data.zip which contains three files: `train.txt`, `test.txt`, `dev.txt`. Each of these contains two lines. It passes ```bash RUN_SLOW=1 pytest tests/te...
[]
https://api.github.com/repos/huggingface/datasets/issues/355
355
can't load SNLI dataset
`nlp` seems to load `snli` from some URL based on nlp.stanford.edu. This subdomain is frequently down -- including right now, when I'd like to load `snli` in a Colab notebook, but can't. Is there a plan to move these datasets to huggingface servers for a more stable solution? Btw, here's the stack trace: ``` ...
closed
2020-07-08T16:54:14
https://api.github.com/repos/huggingface/datasets/issues/355/comments
null
false
can't load SNLI dataset `nlp` seems to load `snli` from some URL based on nlp.stanford.edu. This subdomain is frequently down -- including right now, when I'd like to load `snli` in a Colab notebook, but can't. Is there a plan to move these datasets to huggingface servers for a more stable solution? Btw, here's t...
[ "I just added the processed files of `snli` on our google storage, so that when you do `load_dataset` it can download the processed files from there :)\r\n\r\nWe are thinking about having available those processed files for more datasets in the future, because sometimes files aren't available (like for `snli`), or ...
https://api.github.com/repos/huggingface/datasets/issues/354
354
More faiss control
Allow users to specify a faiss index they created themselves, as sometimes indexes can be composite for examples
closed
2020-07-08T14:45:20
https://api.github.com/repos/huggingface/datasets/issues/354/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/354", "html_url": "https://github.com/huggingface/datasets/pull/354", "diff_url": "https://github.com/huggingface/datasets/pull/354.diff", "patch_url": "https://github.com/huggingface/datasets/pull/354.patch", "merged_at": "2020-07-09T09:54:51"...
true
More faiss control Allow users to specify a faiss index they created themselves, as sometimes indexes can be composite for examples
[ "> Ok, so we're getting rid of the `FaissGpuOptions`?\r\n\r\nWe support `device=...` because it's simple, but faiss GPU options can be used in so many ways (you can set different gpu options for the different parts of your index for example) that it's probably better to let the user create and configure its index a...
https://api.github.com/repos/huggingface/datasets/issues/353
353
[Dataset requests] New datasets for Text Classification
We are missing a few datasets for Text Classification which is an important field. Namely, it would be really nice to add: - [x] TREC-6 dataset (see here for instance: https://pytorchnlp.readthedocs.io/en/latest/source/torchnlp.datasets.html#torchnlp.datasets.trec_dataset) **[done]** - #386 - [x] Yelp-5 - #...
open
2020-07-08T12:17:58
https://api.github.com/repos/huggingface/datasets/issues/353/comments
null
false
[Dataset requests] New datasets for Text Classification We are missing a few datasets for Text Classification which is an important field. Namely, it would be really nice to add: - [x] TREC-6 dataset (see here for instance: https://pytorchnlp.readthedocs.io/en/latest/source/torchnlp.datasets.html#torchnlp.datasets....
[ "Pinging @mariamabarham as well", "- `nlp` has MR! It's called `rotten_tomatoes`\r\n- SST is part of GLUE, or is that just SST-2?\r\n- `nlp` also has `ag_news`, a popular news classification dataset\r\n\r\nI'd also like to see:\r\n- the Yahoo Answers topic classification dataset\r\n- the Kaggle Fake News classifi...
https://api.github.com/repos/huggingface/datasets/issues/352
352
🐛[BugFix]fix seqeval
Fix seqeval process labels such as 'B', 'B-ARGM-LOC'
closed
2020-07-08T09:12:12
https://api.github.com/repos/huggingface/datasets/issues/352/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/352", "html_url": "https://github.com/huggingface/datasets/pull/352", "diff_url": "https://github.com/huggingface/datasets/pull/352.diff", "patch_url": "https://github.com/huggingface/datasets/pull/352.patch", "merged_at": "2020-07-16T08:26:46"...
true
🐛[BugFix]fix seqeval Fix seqeval process labels such as 'B', 'B-ARGM-LOC'
[ "I think this is good but can you detail a bit the behavior before and after your fix?", "examples:\r\n\r\ninput: `['B', 'I', 'I', 'O', 'B', 'I']`\r\nbefore: `[('B', 0, 0), ('I', 1, 2), ('B', 4, 4), ('I', 5, 5)]`\r\nafter: `[('_', 0, 2), ('_', 4, 5)]`\r\n\r\ninput: `['B-ARGM-LOC', 'I-ARGM-LOC', 'I-ARGM-LOC', 'O',...
https://api.github.com/repos/huggingface/datasets/issues/351
351
add pandas dataset
Create a dataset from serialized pandas dataframes. Usage: ```python from nlp import load_dataset dset = load_dataset("pandas", data_files="df.pkl")["train"] ```
closed
2020-07-07T15:38:07
https://api.github.com/repos/huggingface/datasets/issues/351/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/351", "html_url": "https://github.com/huggingface/datasets/pull/351", "diff_url": "https://github.com/huggingface/datasets/pull/351.diff", "patch_url": "https://github.com/huggingface/datasets/pull/351.patch", "merged_at": "2020-07-08T14:15:15"...
true
add pandas dataset Create a dataset from serialized pandas dataframes. Usage: ```python from nlp import load_dataset dset = load_dataset("pandas", data_files="df.pkl")["train"] ```
[]
https://api.github.com/repos/huggingface/datasets/issues/350
350
add from_pandas and from_dict
I added two new methods to the `Dataset` class: - `from_pandas()` to create a dataset from a pandas dataframe - `from_dict()` to create a dataset from a dictionary (keys = columns) It uses the `pa.Table.from_pandas` and `pa.Table.from_pydict` funcitons to do so. It is also possible to specify the features types v...
closed
2020-07-07T15:03:53
https://api.github.com/repos/huggingface/datasets/issues/350/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/350", "html_url": "https://github.com/huggingface/datasets/pull/350", "diff_url": "https://github.com/huggingface/datasets/pull/350.diff", "patch_url": "https://github.com/huggingface/datasets/pull/350.patch", "merged_at": "2020-07-08T14:14:32"...
true
add from_pandas and from_dict I added two new methods to the `Dataset` class: - `from_pandas()` to create a dataset from a pandas dataframe - `from_dict()` to create a dataset from a dictionary (keys = columns) It uses the `pa.Table.from_pandas` and `pa.Table.from_pydict` funcitons to do so. It is also possible t...
[]
https://api.github.com/repos/huggingface/datasets/issues/349
349
Hyperpartisan news detection
Adding the hyperpartisan news detection dataset from PAN. This contains news article text, labelled with whether they're hyper-partisan and why kinds of biases they display. Implementation notes: - As with many PAN tasks, the data is hosted on [Zenodo](https://zenodo.org/record/1489920) and must be requested before...
closed
2020-07-07T11:06:37
https://api.github.com/repos/huggingface/datasets/issues/349/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/349", "html_url": "https://github.com/huggingface/datasets/pull/349", "diff_url": "https://github.com/huggingface/datasets/pull/349.diff", "patch_url": "https://github.com/huggingface/datasets/pull/349.patch", "merged_at": "2020-07-07T14:57:11"...
true
Hyperpartisan news detection Adding the hyperpartisan news detection dataset from PAN. This contains news article text, labelled with whether they're hyper-partisan and why kinds of biases they display. Implementation notes: - As with many PAN tasks, the data is hosted on [Zenodo](https://zenodo.org/record/1489920)...
[ "Thank you so much for working on this! This is awesome!\r\n\r\nHow much would it help you if we would remove the manual request?\r\n\r\nWe are naturally interested in getting some broad idea of how many people and who are using our dataset. But if you consider hosting the dataset yourself, I would rather remove th...
https://api.github.com/repos/huggingface/datasets/issues/348
348
Add OSCAR dataset
I don't know if tests pass, when I run them it tries to download the whole corpus which is around 3.5TB compressed and I don't have that kind of space. I'll really need some help with it 😅 Thanks!
closed
2020-07-07T09:22:07
https://api.github.com/repos/huggingface/datasets/issues/348/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/348", "html_url": "https://github.com/huggingface/datasets/pull/348", "diff_url": "https://github.com/huggingface/datasets/pull/348.diff", "patch_url": "https://github.com/huggingface/datasets/pull/348.patch", "merged_at": null }
true
Add OSCAR dataset I don't know if tests pass, when I run them it tries to download the whole corpus which is around 3.5TB compressed and I don't have that kind of space. I'll really need some help with it 😅 Thanks!
[ "@pjox I think the tests don't pass because you haven't provided any dummy data (`dummy_data.zip`).\r\n\r\n ", "> @pjox I think the tests don't pass because you haven't provided any dummy data (`dummy_data.zip`).\r\n\r\nBut can I do the dummy data without running `python nlp-cli test datasets/<your-dataset-folder...
https://api.github.com/repos/huggingface/datasets/issues/347
347
'cp950' codec error from load_dataset('xtreme', 'tydiqa')
![image](https://user-images.githubusercontent.com/50871412/86744744-67481680-c06c-11ea-8612-b77eba92a392.png) I guess the error is related to python source encoding issue that my PC is trying to decode the source code with wrong encoding-decoding tools, perhaps : https://www.python.org/dev/peps/pep-0263/ I gues...
closed
2020-07-07T08:14:23
https://api.github.com/repos/huggingface/datasets/issues/347/comments
null
false
'cp950' codec error from load_dataset('xtreme', 'tydiqa') ![image](https://user-images.githubusercontent.com/50871412/86744744-67481680-c06c-11ea-8612-b77eba92a392.png) I guess the error is related to python source encoding issue that my PC is trying to decode the source code with wrong encoding-decoding tools, perh...
[ "This is probably a Windows issue, we need to specify the encoding when `load_dataset()` reads the original CSV file.\r\nTry to find the `open()` statement called by `load_dataset()` and add an `encoding='utf-8'` parameter.\r\nSee issues #242 and #307 ", "It should be in `xtreme.py:L755`:\r\n```python\r\n ...
https://api.github.com/repos/huggingface/datasets/issues/346
346
Add emotion dataset
Hello 🤗 team! I am trying to add an emotion classification dataset ([link](https://github.com/dair-ai/emotion_dataset)) to `nlp` but I am a bit stuck about what I should do when the URL for the dataset is not a ZIP file, but just a pickled `pandas.DataFrame` (see [here](https://www.dropbox.com/s/607ptdakxuh5i4s/me...
closed
2020-07-07T06:35:41
https://api.github.com/repos/huggingface/datasets/issues/346/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/346", "html_url": "https://github.com/huggingface/datasets/pull/346", "diff_url": "https://github.com/huggingface/datasets/pull/346.diff", "patch_url": "https://github.com/huggingface/datasets/pull/346.patch", "merged_at": "2020-07-13T14:39:38"...
true
Add emotion dataset Hello 🤗 team! I am trying to add an emotion classification dataset ([link](https://github.com/dair-ai/emotion_dataset)) to `nlp` but I am a bit stuck about what I should do when the URL for the dataset is not a ZIP file, but just a pickled `pandas.DataFrame` (see [here](https://www.dropbox.com/...
[ "I've tried it and am getting the same error as you.\r\n\r\nYou could use the text files rather than the pickle:\r\n```\r\nhttps://www.dropbox.com/s/ikkqxfdbdec3fuj/test.txt\r\nhttps://www.dropbox.com/s/1pzkadrvffbqw6o/train.txt\r\nhttps://www.dropbox.com/s/2mzialpsgf9k5l3/val.txt\r\n```\r\n\r\nThen you would get a...
https://api.github.com/repos/huggingface/datasets/issues/345
345
Supporting documents in ELI5
I was attempting to use the ELI5 dataset, when I realized that huggingface does not provide the supporting documents (the source documents from the common crawl). Without the supporting documents, this makes the dataset about as useful for my project as a block of cheese, or some other more apt metaphor. According to ...
closed
2020-07-06T19:14:13
https://api.github.com/repos/huggingface/datasets/issues/345/comments
null
false
Supporting documents in ELI5 I was attempting to use the ELI5 dataset, when I realized that huggingface does not provide the supporting documents (the source documents from the common crawl). Without the supporting documents, this makes the dataset about as useful for my project as a block of cheese, or some other more...
[ "Hi @saverymax ! For licensing reasons, the original team was unable to release pre-processed CommonCrawl documents. Instead, they provided a script to re-create them from a CommonCrawl dump, but it unfortunately requires access to a medium-large size cluster:\r\nhttps://github.com/facebookresearch/ELI5#downloading...
https://api.github.com/repos/huggingface/datasets/issues/344
344
Search qa
This PR adds the Search QA dataset used in **SearchQA: A New Q&A Dataset Augmented with Context from a Search Engine**. The dataset has the following config name: - raw_jeopardy: raw data - train_test_val: which is the splitted version #336
closed
2020-07-06T12:23:16
https://api.github.com/repos/huggingface/datasets/issues/344/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/344", "html_url": "https://github.com/huggingface/datasets/pull/344", "diff_url": "https://github.com/huggingface/datasets/pull/344.diff", "patch_url": "https://github.com/huggingface/datasets/pull/344.patch", "merged_at": null }
true
Search qa This PR adds the Search QA dataset used in **SearchQA: A New Q&A Dataset Augmented with Context from a Search Engine**. The dataset has the following config name: - raw_jeopardy: raw data - train_test_val: which is the splitted version #336
[ "Could you rebase from master just to make sure we won't break anything for `fever` pls @mariamabarham ?" ]
https://api.github.com/repos/huggingface/datasets/issues/343
343
Fix nested tensorflow format
In #339 and #337 we are thinking about adding a way to export datasets to tfrecords. However I noticed that it was not possible to do `dset.set_format("tensorflow")` on datasets with nested features like `squad`. I fixed that using a nested map operations to convert features to `tf.ragged.constant`. I also added ...
closed
2020-07-06T10:13:45
https://api.github.com/repos/huggingface/datasets/issues/343/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/343", "html_url": "https://github.com/huggingface/datasets/pull/343", "diff_url": "https://github.com/huggingface/datasets/pull/343.diff", "patch_url": "https://github.com/huggingface/datasets/pull/343.patch", "merged_at": "2020-07-06T13:11:51"...
true
Fix nested tensorflow format In #339 and #337 we are thinking about adding a way to export datasets to tfrecords. However I noticed that it was not possible to do `dset.set_format("tensorflow")` on datasets with nested features like `squad`. I fixed that using a nested map operations to convert features to `tf.ragge...
[]
https://api.github.com/repos/huggingface/datasets/issues/342
342
Features should be updated when `map()` changes schema
`dataset.map()` can change the schema and column names. We should update the features in this case (with what is possible to infer).
closed
2020-07-06T08:03:23
https://api.github.com/repos/huggingface/datasets/issues/342/comments
null
false
Features should be updated when `map()` changes schema `dataset.map()` can change the schema and column names. We should update the features in this case (with what is possible to infer).
[ "`dataset.column_names` are being updated but `dataset.features` aren't indeed..." ]
https://api.github.com/repos/huggingface/datasets/issues/341
341
add fever dataset
This PR add the FEVER dataset https://fever.ai/ used in with the paper: FEVER: a large-scale dataset for Fact Extraction and VERification (https://arxiv.org/pdf/1803.05355.pdf). #336
closed
2020-07-03T13:53:07
https://api.github.com/repos/huggingface/datasets/issues/341/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/341", "html_url": "https://github.com/huggingface/datasets/pull/341", "diff_url": "https://github.com/huggingface/datasets/pull/341.diff", "patch_url": "https://github.com/huggingface/datasets/pull/341.patch", "merged_at": "2020-07-06T13:03:47"...
true
add fever dataset This PR add the FEVER dataset https://fever.ai/ used in with the paper: FEVER: a large-scale dataset for Fact Extraction and VERification (https://arxiv.org/pdf/1803.05355.pdf). #336
[]
https://api.github.com/repos/huggingface/datasets/issues/340
340
Update cfq.py
Make the dataset name consistent with in the paper: Compositional Freebase Question => Compositional Freebase Questions.
closed
2020-07-03T11:23:19
https://api.github.com/repos/huggingface/datasets/issues/340/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/340", "html_url": "https://github.com/huggingface/datasets/pull/340", "diff_url": "https://github.com/huggingface/datasets/pull/340.diff", "patch_url": "https://github.com/huggingface/datasets/pull/340.patch", "merged_at": "2020-07-03T12:33:50"...
true
Update cfq.py Make the dataset name consistent with in the paper: Compositional Freebase Question => Compositional Freebase Questions.
[ "Thanks @brainshawn for this update" ]
https://api.github.com/repos/huggingface/datasets/issues/339
339
Add dataset.export() to TFRecords
Fixes https://github.com/huggingface/nlp/issues/337 Some design decisions: - Simplified the function API to not handle sharding. It writes the entire dataset as a single TFRecord file. This simplifies the function logic and users can use other functions (`select`, `shard`, etc) to handle custom sharding or splitt...
closed
2020-07-02T19:26:27
https://api.github.com/repos/huggingface/datasets/issues/339/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/339", "html_url": "https://github.com/huggingface/datasets/pull/339", "diff_url": "https://github.com/huggingface/datasets/pull/339.diff", "patch_url": "https://github.com/huggingface/datasets/pull/339.patch", "merged_at": "2020-07-22T09:16:11"...
true
Add dataset.export() to TFRecords Fixes https://github.com/huggingface/nlp/issues/337 Some design decisions: - Simplified the function API to not handle sharding. It writes the entire dataset as a single TFRecord file. This simplifies the function logic and users can use other functions (`select`, `shard`, etc) t...
[ "Really cool @jarednielsen !\r\nDo you think we can make it work with dataset with nested features like `squad` ?\r\n\r\nI just did a PR to fix `.set_format` for datasets with nested features, but as soon as it's merged we could try to make the conversion work on a dataset like `squad`.", "For datasets with neste...
https://api.github.com/repos/huggingface/datasets/issues/338
338
Run `make style`
These files get changed when I run `make style` on an unrelated PR. Upstreaming these changes so development on a different branch can be easier.
closed
2020-07-02T16:19:47
https://api.github.com/repos/huggingface/datasets/issues/338/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/338", "html_url": "https://github.com/huggingface/datasets/pull/338", "diff_url": "https://github.com/huggingface/datasets/pull/338.diff", "patch_url": "https://github.com/huggingface/datasets/pull/338.patch", "merged_at": "2020-07-02T18:03:10"...
true
Run `make style` These files get changed when I run `make style` on an unrelated PR. Upstreaming these changes so development on a different branch can be easier.
[]
https://api.github.com/repos/huggingface/datasets/issues/337
337
[Feature request] Export Arrow dataset to TFRecords
The TFRecord generation process is error-prone and requires complex separate Python scripts to download and preprocess the data. I propose to combine the user-friendly features of `nlp` with the speed and efficiency of TFRecords. Sample API: ```python # use these existing methods ds = load_dataset("wikitext", "wik...
closed
2020-07-02T15:47:12
https://api.github.com/repos/huggingface/datasets/issues/337/comments
null
false
[Feature request] Export Arrow dataset to TFRecords The TFRecord generation process is error-prone and requires complex separate Python scripts to download and preprocess the data. I propose to combine the user-friendly features of `nlp` with the speed and efficiency of TFRecords. Sample API: ```python # use these ...
[]
https://api.github.com/repos/huggingface/datasets/issues/336
336
[Dataset requests] New datasets for Open Question Answering
We are still a few datasets missing for Open-Question Answering which is currently a field in strong development. Namely, it would be really nice to add: - WebQuestions (Berant et al., 2013) [done] - CuratedTrec (Baudis et al. 2015) [not open-source] - MS-MARCO (NGuyen et al. 2016) [done] - SearchQA (Dunn et al....
closed
2020-07-02T13:03:03
https://api.github.com/repos/huggingface/datasets/issues/336/comments
null
false
[Dataset requests] New datasets for Open Question Answering We are still a few datasets missing for Open-Question Answering which is currently a field in strong development. Namely, it would be really nice to add: - WebQuestions (Berant et al., 2013) [done] - CuratedTrec (Baudis et al. 2015) [not open-source] - M...
[]
https://api.github.com/repos/huggingface/datasets/issues/335
335
BioMRC Dataset presented in BioNLP 2020 ACL Workshop
closed
2020-07-02T09:03:41
https://api.github.com/repos/huggingface/datasets/issues/335/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/335", "html_url": "https://github.com/huggingface/datasets/pull/335", "diff_url": "https://github.com/huggingface/datasets/pull/335.diff", "patch_url": "https://github.com/huggingface/datasets/pull/335.patch", "merged_at": "2020-07-15T08:02:07"...
true
BioMRC Dataset presented in BioNLP 2020 ACL Workshop
[ "I fixed the issues that you pointed out, re-run all the test and pushed the fixed code :-)", "```\r\n=================================== FAILURES ===================================\r\n___________________ AWSDatasetTest.test_load_dataset_pandas ____________________\r\n\r\nself = <tests.test_dataset_common.AWSDat...
https://api.github.com/repos/huggingface/datasets/issues/334
334
Add dataset.shard() method
Fixes https://github.com/huggingface/nlp/issues/312
closed
2020-07-02T06:05:19
https://api.github.com/repos/huggingface/datasets/issues/334/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/334", "html_url": "https://github.com/huggingface/datasets/pull/334", "diff_url": "https://github.com/huggingface/datasets/pull/334.diff", "patch_url": "https://github.com/huggingface/datasets/pull/334.patch", "merged_at": "2020-07-06T12:35:36"...
true
Add dataset.shard() method Fixes https://github.com/huggingface/nlp/issues/312
[ "Great, done!" ]
https://api.github.com/repos/huggingface/datasets/issues/333
333
fix variable name typo
closed
2020-07-01T19:13:50
https://api.github.com/repos/huggingface/datasets/issues/333/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/333", "html_url": "https://github.com/huggingface/datasets/pull/333", "diff_url": "https://github.com/huggingface/datasets/pull/333.diff", "patch_url": "https://github.com/huggingface/datasets/pull/333.patch", "merged_at": null }
true
fix variable name typo
[ "Good catch :)\r\nI think there is another occurence that needs to be fixed in the second gist (line 4924 of the notebook file):\r\n```python\r\nbleu = nlp.load_metric(...)\r\n```", "Was fixed in e16f79b5f7fc12a6a30c777722be46897a272e6f\r\nClosing it." ]
https://api.github.com/repos/huggingface/datasets/issues/332
332
Add wiki_dpr
Presented in the [Dense Passage Retrieval paper](https://arxiv.org/pdf/2004.04906.pdf), this dataset consists in 21M passages from the english wikipedia along with their 768-dim embeddings computed using DPR's context encoder. Note on the implementation: - There are two configs: with and without the embeddings (73G...
closed
2020-07-01T17:12:00
https://api.github.com/repos/huggingface/datasets/issues/332/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/332", "html_url": "https://github.com/huggingface/datasets/pull/332", "diff_url": "https://github.com/huggingface/datasets/pull/332.diff", "patch_url": "https://github.com/huggingface/datasets/pull/332.patch", "merged_at": "2020-07-06T12:21:16"...
true
Add wiki_dpr Presented in the [Dense Passage Retrieval paper](https://arxiv.org/pdf/2004.04906.pdf), this dataset consists in 21M passages from the english wikipedia along with their 768-dim embeddings computed using DPR's context encoder. Note on the implementation: - There are two configs: with and without the em...
[ "The two configurations don't have the same sizes, I may change that so that they both have 21015300 examples for convenience, even though it's supposed to have 21015324 examples in total.\r\n\r\nOne configuration only has 21015300 examples because it seems that the embeddings of the last 24 examples are missing.",...
https://api.github.com/repos/huggingface/datasets/issues/331
331
Loading CNN/Daily Mail dataset produces `nlp.utils.info_utils.NonMatchingSplitsSizesError`
``` >>> import nlp >>> nlp.load_dataset('cnn_dailymail', '3.0.0') Downloading and preparing dataset cnn_dailymail/3.0.0 (download: 558.32 MiB, generated: 1.26 GiB, total: 1.81 GiB) to /u/jm8wx/.cache/huggingface/datasets/cnn_dailymail/3.0.0/3.0.0... Traceback (most recent call last): File "<stdin>", line 1, in...
closed
2020-06-30T22:21:33
https://api.github.com/repos/huggingface/datasets/issues/331/comments
null
false
Loading CNN/Daily Mail dataset produces `nlp.utils.info_utils.NonMatchingSplitsSizesError` ``` >>> import nlp >>> nlp.load_dataset('cnn_dailymail', '3.0.0') Downloading and preparing dataset cnn_dailymail/3.0.0 (download: 558.32 MiB, generated: 1.26 GiB, total: 1.81 GiB) to /u/jm8wx/.cache/huggingface/datasets/cnn_d...
[ "I couldn't reproduce on my side.\r\nIt looks like you were not able to generate all the examples, and you have the problem for each split train-test-validation.\r\nCould you try to enable logging, try again and send the logs ?\r\n```python\r\nimport logging\r\nlogging.basicConfig(level=logging.INFO)\r\n```", "he...
https://api.github.com/repos/huggingface/datasets/issues/330
330
Doc red
Adding [DocRED](https://github.com/thunlp/DocRED) - a relation extraction dataset which tests document-level RE. A few implementation notes: - There are 2 separate versions of the training set - *annotated* and *distant*. Instead of `nlp.Split.Train` I've used the splits `"train_annotated"` and `"train_distant"` to ...
closed
2020-06-30T22:05:31
https://api.github.com/repos/huggingface/datasets/issues/330/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/330", "html_url": "https://github.com/huggingface/datasets/pull/330", "diff_url": "https://github.com/huggingface/datasets/pull/330.diff", "patch_url": "https://github.com/huggingface/datasets/pull/330.patch", "merged_at": "2020-07-05T12:27:29"...
true
Doc red Adding [DocRED](https://github.com/thunlp/DocRED) - a relation extraction dataset which tests document-level RE. A few implementation notes: - There are 2 separate versions of the training set - *annotated* and *distant*. Instead of `nlp.Split.Train` I've used the splits `"train_annotated"` and `"train_dista...
[]
https://api.github.com/repos/huggingface/datasets/issues/329
329
[Bug] FileLock dependency incompatible with filesystem
I'm downloading a dataset successfully with `load_dataset("wikitext", "wikitext-2-raw-v1")` But when I attempt to cache it on an external volume, it hangs indefinitely: `load_dataset("wikitext", "wikitext-2-raw-v1", cache_dir="/fsx") # /fsx is an external volume mount` The filesystem when hanging looks like thi...
closed
2020-06-30T19:45:31
https://api.github.com/repos/huggingface/datasets/issues/329/comments
null
false
[Bug] FileLock dependency incompatible with filesystem I'm downloading a dataset successfully with `load_dataset("wikitext", "wikitext-2-raw-v1")` But when I attempt to cache it on an external volume, it hangs indefinitely: `load_dataset("wikitext", "wikitext-2-raw-v1", cache_dir="/fsx") # /fsx is an external volu...
[ "Hi, can you give details on your environment/os/packages versions/etc?", "Environment is Ubuntu 18.04, Python 3.7.5, nlp==0.3.0, filelock=3.0.12.\r\n\r\nThe external volume is Amazon FSx for Lustre, and it by default creates files with limited permissions. My working theory is that FileLock creates a lockfile th...
https://api.github.com/repos/huggingface/datasets/issues/328
328
Fork dataset
We have a multi-task learning model training I'm trying to convert to using the Arrow-based nlp dataset. We're currently training a custom TensorFlow model but the nlp paradigm should be a bridge for us to be able to use the wealth of pre-trained models in Transformers. Our preprocessing flow parses raw text and...
closed
2020-06-30T16:42:53
https://api.github.com/repos/huggingface/datasets/issues/328/comments
null
false
Fork dataset We have a multi-task learning model training I'm trying to convert to using the Arrow-based nlp dataset. We're currently training a custom TensorFlow model but the nlp paradigm should be a bridge for us to be able to use the wealth of pre-trained models in Transformers. Our preprocessing flow parses...
[ "To be able to generate the Arrow dataset you need to either use our csv or json utilities `load_dataset(\"json\", data_files=my_json_files)` OR write your own custom dataset script (you can find some inspiration from the [squad](https://github.com/huggingface/nlp/blob/master/datasets/squad/squad.py) script for exa...
https://api.github.com/repos/huggingface/datasets/issues/327
327
set seed for suffling tests
Some tests were randomly failing because of a missing seed in a test for `train_test_split(shuffle=True)`
closed
2020-06-30T16:21:34
https://api.github.com/repos/huggingface/datasets/issues/327/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/327", "html_url": "https://github.com/huggingface/datasets/pull/327", "diff_url": "https://github.com/huggingface/datasets/pull/327.diff", "patch_url": "https://github.com/huggingface/datasets/pull/327.patch", "merged_at": "2020-07-02T08:34:04"...
true
set seed for suffling tests Some tests were randomly failing because of a missing seed in a test for `train_test_split(shuffle=True)`
[]
https://api.github.com/repos/huggingface/datasets/issues/326
326
Large dataset in Squad2-format
At the moment we are building an large question answering dataset and think about sharing it with the huggingface community. Caused the computing power we splitted it into multiple tiles, but they are all in the same format. Right now the most important facts about are this: - Contexts: 1.047.671 - questions: 1.677...
closed
2020-06-30T12:18:59
https://api.github.com/repos/huggingface/datasets/issues/326/comments
null
false
Large dataset in Squad2-format At the moment we are building an large question answering dataset and think about sharing it with the huggingface community. Caused the computing power we splitted it into multiple tiles, but they are all in the same format. Right now the most important facts about are this: - Contexts...
[ "I'm pretty sure you can get some inspiration from the squad_v2 script. It looks like the dataset is quite big so it will take some time for the users to generate it, but it should be reasonable.\r\n\r\nAlso you are saying that you are still making the dataset grow in size right ?\r\nIt's probably good practice to ...
https://api.github.com/repos/huggingface/datasets/issues/325
325
Add SQuADShifts dataset
This PR adds the four new variants of the SQuAD dataset used in [The Effect of Natural Distribution Shift on Question Answering Models](https://arxiv.org/abs/2004.14444) to facilitate evaluating model robustness to distribution shift.
closed
2020-06-29T19:11:16
https://api.github.com/repos/huggingface/datasets/issues/325/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/325", "html_url": "https://github.com/huggingface/datasets/pull/325", "diff_url": "https://github.com/huggingface/datasets/pull/325.diff", "patch_url": "https://github.com/huggingface/datasets/pull/325.patch", "merged_at": "2020-06-30T17:07:31"...
true
Add SQuADShifts dataset This PR adds the four new variants of the SQuAD dataset used in [The Effect of Natural Distribution Shift on Question Answering Models](https://arxiv.org/abs/2004.14444) to facilitate evaluating model robustness to distribution shift.
[ "Very cool to have this dataset, thank you for adding it :)" ]
https://api.github.com/repos/huggingface/datasets/issues/324
324
Error when calculating glue score
I was trying glue score along with other metrics here. But glue gives me this error; ``` import nlp glue_metric = nlp.load_metric('glue',name="cola") glue_score = glue_metric.compute(predictions, references) ``` ``` --------------------------------------------------------------------------- --------------...
closed
2020-06-29T16:53:48
https://api.github.com/repos/huggingface/datasets/issues/324/comments
null
false
Error when calculating glue score I was trying glue score along with other metrics here. But glue gives me this error; ``` import nlp glue_metric = nlp.load_metric('glue',name="cola") glue_score = glue_metric.compute(predictions, references) ``` ``` ---------------------------------------------------------...
[ "The glue metric for cola is a metric for classification. It expects label ids as integers as inputs.", "I want to evaluate a sentence pair whether they are semantically equivalent, so I used MRPC and it gives the same error, does that mean we have to encode the sentences and parse as input?\r\n\r\nusing BertToke...
https://api.github.com/repos/huggingface/datasets/issues/323
323
Add package path to sys when downloading package as github archive
This fixes the `coval.py` metric so that imports within the downloaded module work correctly. We can use a similar trick to add the BLEURT metric (@ankparikh) @thomwolf not sure how you feel about adding to the `PYTHONPATH` from the script. This is the only way I could make it work with my understanding of `importli...
closed
2020-06-29T16:46:01
https://api.github.com/repos/huggingface/datasets/issues/323/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/323", "html_url": "https://github.com/huggingface/datasets/pull/323", "diff_url": "https://github.com/huggingface/datasets/pull/323.diff", "patch_url": "https://github.com/huggingface/datasets/pull/323.patch", "merged_at": null }
true
Add package path to sys when downloading package as github archive This fixes the `coval.py` metric so that imports within the downloaded module work correctly. We can use a similar trick to add the BLEURT metric (@ankparikh) @thomwolf not sure how you feel about adding to the `PYTHONPATH` from the script. This is t...
[ "Sorry for the long diff, everything after the imports comes from `black` for code quality :/ ", " I think it's fine and I can't think of another way to make the import work anyways.\r\n\r\nMaybe we can have the `sys.path` behavior inside `prepare_module` instead ? Currently it seems to come out of nowhere in the...
https://api.github.com/repos/huggingface/datasets/issues/322
322
output nested dict in get_nearest_examples
As we are using a columnar format like arrow as the backend for datasets, we expect to have a dictionary of columns when we slice a dataset like in this example: ```python my_examples = dataset[0:10] print(type(my_examples)) # >>> dict print(my_examples["my_column"][0] # >>> this is the first element of the colum...
closed
2020-06-29T15:47:47
https://api.github.com/repos/huggingface/datasets/issues/322/comments
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/322", "html_url": "https://github.com/huggingface/datasets/pull/322", "diff_url": "https://github.com/huggingface/datasets/pull/322.diff", "patch_url": "https://github.com/huggingface/datasets/pull/322.patch", "merged_at": "2020-07-02T08:33:32"...
true
output nested dict in get_nearest_examples As we are using a columnar format like arrow as the backend for datasets, we expect to have a dictionary of columns when we slice a dataset like in this example: ```python my_examples = dataset[0:10] print(type(my_examples)) # >>> dict print(my_examples["my_column"][0] #...
[]
https://api.github.com/repos/huggingface/datasets/issues/321
321
ERROR:root:mwparserfromhell
Hi, I am trying to download some wikipedia data but I got this error for spanish "es" (but there are maybe some others languages which have the same error I haven't tried all of them ). `ERROR:root:mwparserfromhell ParseError: This is a bug and should be reported. Info: C tokenizer exited with non-empty token sta...
closed
2020-06-29T11:10:43
https://api.github.com/repos/huggingface/datasets/issues/321/comments
null
false
ERROR:root:mwparserfromhell Hi, I am trying to download some wikipedia data but I got this error for spanish "es" (but there are maybe some others languages which have the same error I haven't tried all of them ). `ERROR:root:mwparserfromhell ParseError: This is a bug and should be reported. Info: C tokenizer exi...
[ "It looks like it comes from `mwparserfromhell`.\r\n\r\nWould it be possible to get the bad `section` that causes this issue ? The `section` string is from `datasets/wikipedia.py:L548` ? You could just add a `try` statement and print the section if the line `section_text.append(section.strip_code().strip())` crashe...