instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
canonical__operator-565 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/framework.py:Framework.__init__",
"ops/framework.py:Framework._reemit"
],
"edited_modules": [
"ops/framework.py:Framework"
]
},
"file": "ops/framework.py"
... | canonical/operator | 003fdcf7d32578e56f88d9522b81678e36d8db8e | Default 'debug-code' should include hooks
Right now `juju debug-code myapp` defaults to `--at=all` which implies `JUJU_DEBUG_AT=all`.
Operator Framework currently interprets `all` to mean "all explicit breakpoints". However you have to do `juju debug-code --at=hook myapp` if you want to have operator framework stop ... | diff --git a/ops/framework.py b/ops/framework.py
index d20c000..c19d86b 100755
--- a/ops/framework.py
+++ b/ops/framework.py
@@ -515,7 +515,7 @@ class Framework(Object):
# Parse the env var once, which may be used multiple times later
debug_at = os.environ.get('JUJU_DEBUG_AT')
- self._juju_de... |
canonical__operator-567 | [
{
"changes": {
"added_entities": [
"ops/model.py:Container.completed",
"ops/model.py:Container.is_ready",
"ops/model.py:Container.restart",
"ops/model.py:_ContainerReady.__init__",
"ops/model.py:_ContainerReady.__bool__",
"ops/model.py:_ContainerReady.__ente... | canonical/operator | 5943a59ccde766c832d59229f3ac431587799f34 | Confusing / inconsistent errors from interaction between Pebble and Juju events and handlers
I've frequently seen charm authors who are new to the sidecar pattern write something along the lines of this in their charm:
```python
class MyCharm(CharmBase):
def __init__(self, *args):
super().__init__(*ar... | diff --git a/ops/model.py b/ops/model.py
index 88c0e29..0ee56ef 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -18,6 +18,7 @@ import datetime
import decimal
import ipaddress
import json
+import logging
import os
import re
import shutil
@@ -37,6 +38,17 @@ import ops
import ops.pebble as pebble
+logger = logg... |
canonical__operator-648 | [
{
"changes": {
"added_entities": [
"ops/charm.py:StorageEvent.__init__",
"ops/charm.py:StorageEvent.snapshot",
"ops/charm.py:StorageEvent.restore"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"ops/charm.py:StorageEvent"
... | canonical/operator | f2e67e15af1fb1f59f940618f6c0a2a3d96e5363 | [storage] Expand StorageEvent to provide details of disk by default
Hi,
Supposing we are running a configuration such as:
```
storage:
data:
type: block
multiple:
range: 0- <<<--- I may have several volumes here
```
When I get a storage detached, I will need to treat the case where among ... | diff --git a/ops/charm.py b/ops/charm.py
index e4d22cf..010dc99 100755
--- a/ops/charm.py
+++ b/ops/charm.py
@@ -426,6 +426,38 @@ class StorageEvent(HookEvent):
of :class:`StorageEvent`.
"""
+ def __init__(self, handle, storage):
+ super().__init__(handle)
+ self.storage = storage
+
+ de... |
canonical__operator-661 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:Resources.fetch"
],
"edited_modules": [
"ops/model.py:Resources"
]
},
"file": "ops/model.py"
}
] | canonical/operator | 91b6551ac2cdda5ade84e2fd2bddd14b198cae71 | Failing to fetch a resource does not raise the expected exception
According to the doc string and, as a consequence, the rtfm docs, `charm.model.resources.fetch` is expected to throw a `ModelError`. In reality, it's a `RuntimeError`. We should probably change either the docs or the exception raised.
https://github.... | diff --git a/ops/model.py b/ops/model.py
index ec99173..c20d883 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -951,10 +951,10 @@ class Resources:
"""Fetch the resource from the controller or store.
If successfully fetched, this returns a Path object to where the resource is stored
- on disk... |
canonical__operator-702 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:Container.get_services"
],
"edited_modules": [
"ops/model.py:Container"
]
},
"file": "ops/model.py"
}
] | canonical/operator | 88529c95575301f47a1b420dc29394c1a1b9b50b | Harness.Container.get_services() does not seem correctly mocked
I think this test should work, but it does not with `ops 1.3.0`:
```
def test_mocked_get_services(self):
self.harness.begin()
traefik_container = self.harness.charm.unit.get_container("traefik")
traefik_container.add_laye... | diff --git a/ops/model.py b/ops/model.py
index 9974af9..e627951 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -1194,6 +1194,7 @@ class Container:
If no service names are specified, return status information for all
services, otherwise return information for only the given services.
"""
+ ... |
canonical__operator-733 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/framework.py:Framework._reemit"
],
"edited_modules": [
"ops/framework.py:Framework"
]
},
"file": "ops/framework.py"
},
{
"changes": {
"added_entities"... | canonical/operator | ff30d2f4bf0d8e2f24cd11d99e3de67d8e81e3b0 | `ops.harness` prohibits setting application data both in peer relation created and leader elected events
## Issue
Attached to this report is a simple charm (zip file) demonstrating a problem with `ops.harness`. This (workload-less) charm only has handlers for `RelationCreated` and `LeaderElected` events. The charm s... | diff --git a/ops/framework.py b/ops/framework.py
index f455bbd..f08845c 100755
--- a/ops/framework.py
+++ b/ops/framework.py
@@ -753,6 +753,31 @@ class Framework(Object):
self._reemit()
def _reemit(self, single_event_path=None):
+
+ class EventContext:
+ """Handles toggling the hook-is... |
canonical__operator-765 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:RelationData.__getitem__",
"ops/model.py:_ModelBackend.relation_remote_app_name"
],
"edited_modules": [
"ops/model.py:RelationData",
"ops/model.py:_Model... | canonical/operator | 2644ae9368c6b9915967a1e6a117b17ebacffb86 | OF should gracefully handle blank application names in relation-broken hooks
See the discussion here: https://bugs.launchpad.net/juju/+bug/1960934
In a relation-broken hook, Juju does not set JUJU_REMOTE_APP. This is Working as Intended for Juju, but it raises an exception in the framework, when iterating through re... | diff --git a/ops/model.py b/ops/model.py
index 8425736..45e6a48 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -887,6 +887,15 @@ class RelationData(Mapping['UnitOrApplication', 'RelationDataContent']):
return iter(self._data)
def __getitem__(self, key: 'UnitOrApplication'):
+ if key is None and ... |
canonical__operator-795 | [
{
"changes": {
"added_entities": [
"ops/framework.py:Framework._event_context"
],
"added_modules": null,
"edited_entities": [
"ops/framework.py:Framework._reemit"
],
"edited_modules": [
"ops/framework.py:Framework"
]
},
"file": "ops/frame... | canonical/operator | 93ecb33a4b571e9900cdccfcd53dbef8f1c7c1e5 | Better error messages on permission errors with accessing relation databags
In non-peer relations, a unit cannot read or write its own application's databag, which results into authorization errors.
However, those errors surface in unexpected places which can confuse developers:
```
self.unit.is_leader() # False
... | diff --git a/ops/framework.py b/ops/framework.py
index abe4e2c..28a4c29 100755
--- a/ops/framework.py
+++ b/ops/framework.py
@@ -28,6 +28,7 @@ import sys
import types
import typing
import weakref
+from contextlib import contextmanager
from typing import (
TYPE_CHECKING,
Any,
@@ -847,34 +848,33 @@ class Fr... |
canonical__operator-805 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:_ModelBackend._run",
"ops/model.py:_ModelBackend.relation_set"
],
"edited_modules": [
"ops/model.py:_ModelBackend"
]
},
"file": "ops/model.py"
}
... | canonical/operator | bf71c4a1aa84c4f0ddc2a0e334baafaf85b534cb | `RelationDataContent.__setitem__` should dynamically dispatch to a file if it's too long
We've already seen this with Grafana Dashboards, which routinely overflow the maximum argument length from `subprocess`, but it was also observed that relating Prometheus to a very large number of targets could overflow and cause a... | diff --git a/ops/model.py b/ops/model.py
index b4940d2..9682548 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -28,7 +28,7 @@ import typing
import weakref
from abc import ABC, abstractmethod
from pathlib import Path
-from subprocess import PIPE, CalledProcessError, run
+from subprocess import PIPE, CalledProcessErr... |
canonical__operator-823 | [
{
"changes": {
"added_entities": [
"ops/model.py:_cast_network_address"
],
"added_modules": [
"ops/model.py:_cast_network_address"
],
"edited_entities": [
"ops/model.py:Network.__init__",
"ops/model.py:Network.bind_address",
"ops/model.py:Net... | canonical/operator | 77ac36224aa7f79d4ab7c2b11d060a52c8b83ae4 | traefik errors on cos layer with error: hook failed: "metrics-endpoint-relation-joined"
### Bug Description
Solutions QA team has two runs in which traefik errors on cos layer with error: hook failed: "metrics-endpoint-relation-joined"
The cos layer is built on top of kubernetes-aws.
From the logs:
2022-08-... | diff --git a/ops/model.py b/ops/model.py
index 6c51a81..5532a70 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -93,7 +93,7 @@ if typing.TYPE_CHECKING:
_RelationsMeta_Raw = Dict[str, ops.charm.RelationMeta]
# mapping from container name to container metadata
_ContainerMeta_Raw = Dict[str, ops.charm.Conta... |
canonical__operator-860 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:Container.can_connect"
],
"edited_modules": [
"ops/model.py:Container"
]
},
"file": "ops/model.py"
},
{
"changes": {
"added_entities": null,
... | canonical/operator | 28251faf41868017aec5add2b59a80719f5354db | Log format string missing %s in can_connect
When reviewing some unrelated code, I noticed there was an [invalid `logger.debug` format string](https://github.com/canonical/operator/blob/6ee44cfb64d0680ec7e72ad1c746a87a0c63f0c8/ops/model.py#L1148) in the `model.Container.can_connect` code. It does the following:
```py... | diff --git a/ops/model.py b/ops/model.py
index 9412ae9..79af88f 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -1418,17 +1418,17 @@ class Container:
# instance that is in fact 'ready'.
self._pebble.get_system_info()
except pebble.ConnectionError as e:
- logger.debug("Pebb... |
canonical__operator-900 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:_ModelBackend.secret_info_get"
],
"edited_modules": [
"ops/model.py:_ModelBackend"
]
},
"file": "ops/model.py"
}
] | canonical/operator | e33ad4f221dd34cba5c81d3fd9eee868a6d866a7 | uncaught error in `Secret.get_info()`
the following error appears while running the `owner` charm in [this demo bundle](https://github.com/PietroPasotti/secrets-demo-charms/tree/main)
| diff --git a/ops/framework.py b/ops/framework.py
index 0ba99e1..c9da35e 100755
--- a/ops/framework.py
+++ b/ops/framework.py
@@ -549,7 +549,7 @@ _event_regex = r'^(|.*/)on/[a-zA-Z_]+\[\d+\]$'
class Framework(Object):
- """Main interface to from the Charm to the Operator Framework internals."""
+ """Main inte... |
canonical__operator-903 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:Model.get_secret"
],
"edited_modules": [
"ops/model.py:Model"
]
},
"file": "ops/model.py"
}
] | canonical/operator | 2cbee00aa38919d52525a143303332745e3de40c | secret id is not always canonicalized before calling secret_get
Secret canonicalizes the ID it receives upon initialization.
However, before the Secret object is initialized, the ID is used to call secret_get. This results in the ID being sometimes canonicalized, sometimes not, depending on the caller.
For example:... | diff --git a/ops/model.py b/ops/model.py
index 141bd4f..2ab4ff8 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -276,6 +276,9 @@ class Model:
"""
if not (id or label):
raise TypeError('Must provide an id or label, or both')
+ if id is not None:
+ # Canonicalize to "secre... |
canonical__operator-910 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "ops/__init__.py"
},
{
"changes": {
"added_entities": [
"ops/main.py:_CallableModule.__call__"
],
"added_modules": [
... | canonical/operator | 401f19c839f3f0c73c796d19352e4e597384cd0f | Annoyance: Figuring out which module has my object
When writing charms, I am often able to remember the name of object that I want (`EventBase`, `StoredState`, etc.), but often forget which module it comes from. There's logic to the modules, of course -- `CharmBase` is in `charm`, the status objects live in `model`, an... | diff --git a/ops/__init__.py b/ops/__init__.py
index 5e01059..e867516 100644
--- a/ops/__init__.py
+++ b/ops/__init__.py
@@ -39,6 +39,142 @@ and day-2 operations specific to that application.
Full developer documentation is available at https://juju.is/docs/sdk.
"""
-# Import here the bare minimum to break the circ... |
canonical__operator-914 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"setup.py:_requirements"
],
"edited_modules": [
"setup.py:_requirements"
]
},
"file": "setup.py"
}
] | canonical/operator | 34e5dfb08251295c96cbfd3976c78b41c991b4ec | FileNotFoundError: '.../requirements.txt' during `charmcraft pack` with 2.1.0
Since ops 2.1.0 released, I started getting this error when I `charmcraft pack`:
```
2023-02-28 15:57:44.361 :: 2023-02-28 23:57:44.064 :: Running external command ['/root/parts/charm/build/staging-venv/bin/pip3', 'install', '--upgrade', '-... | diff --git a/setup.py b/setup.py
index 7efdfc5..2810a4d 100644
--- a/setup.py
+++ b/setup.py
@@ -16,7 +16,6 @@
from importlib.util import module_from_spec, spec_from_file_location
from pathlib import Path
-from typing import List
from setuptools import find_packages, setup
@@ -28,19 +27,6 @@ def _read_me() -> ... |
canonical__operator-949 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ops/model.py:Container.push_path",
"ops/model.py:Container._build_destpath"
],
"edited_modules": [
"ops/model.py:Container"
]
},
"file": "ops/model.py"
}
] | canonical/operator | 37650135082030830c6420a404933bdc500d26c1 | Container.push_path duplicates src_path
```python3
def local_list(source_path: Path) -> List[pebble.FileInfo]:
paths = source_path.iterdir() if source_path.is_dir() else [source_path]
files = [self._build_fileinfo(source_path / f) for f in paths]
return files
```
in ops.model, ... | diff --git a/ops/model.py b/ops/model.py
index 7d24ec5..3458c77 100644
--- a/ops/model.py
+++ b/ops/model.py
@@ -2093,7 +2093,7 @@ class Container:
def local_list(source_path: Path) -> List[pebble.FileInfo]:
paths = source_path.iterdir() if source_path.is_dir() else [source_path]
- fi... |
canonical__operator-975 | [
{
"changes": {
"added_entities": [
"ops/jujuversion.py:JujuVersion.supports_exec_service_context"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"ops/jujuversion.py:JujuVersion"
]
},
"file": "ops/jujuversion.py"
},
{
"ch... | canonical/operator | 770282b05dd1f0958e600db963c3c4bce07dd9e7 | missing `kill-delay` pebble service support
Pebble merged `kill-delay` support but ops does not yet support it. (See pebble issue [190](https://github.com/canonical/pebble/pull/190/files))
| diff --git a/ops/jujuversion.py b/ops/jujuversion.py
index bb8151b..57153e3 100755
--- a/ops/jujuversion.py
+++ b/ops/jujuversion.py
@@ -128,3 +128,15 @@ class JujuVersion:
"""Report whether this Juju version supports open-port on Kubernetes."""
# Support added: https://bugs.launchpad.net/juju/+bug/19... |
capitalone__datacompy-18 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"datacompy/core.py:Compare.__init__",
"datacompy/core.py:Compare._compare",
"datacompy/core.py:Compare._dataframe_merge",
"datacompy/core.py:Compare._intersect_compare",
"... | capitalone/datacompy | 370f7efbe1a5206c525a6da40410442a4ce8d51c | Would be useful to have a parameter to strip spaces for comparison
As probably expected, the following code will return a mismatch since 'B'<>'B ':
```
import pandas as pd
import datacompy
df1 = pd.DataFrame([
{'id': 1234, 'column_value': 'A'},
{'id': 2345, 'column_value': 'B'}])
df2 = pd.Dat... | diff --git a/datacompy/core.py b/datacompy/core.py
index 7fc296e..e03d75e 100644
--- a/datacompy/core.py
+++ b/datacompy/core.py
@@ -59,6 +59,8 @@ class Compare(object):
more easily track the dataframes.
df2_name : str, optional
A string name for the second dataframe
+ ignore_spaces : bool, op... |
capitalone__datacompy-22 | [
{
"changes": {
"added_entities": [
"datacompy/core.py:calculate_max_diff"
],
"added_modules": [
"datacompy/core.py:calculate_max_diff"
],
"edited_entities": [
"datacompy/core.py:Compare._intersect_compare"
],
"edited_modules": [
"datacomp... | capitalone/datacompy | 4aae55019a72c527ec043e417faae9b40b3bf29b | Max Diff in Report not working if comparing object and numeric datatypes
Although the tolerance values and overall matching seem to work fine when comparing object to float64 or int64, in the summary report, the Max Diff is always 0.000000
Probably can be fixed here with .astype(float)?: https://github.com/capitalon... | diff --git a/.gitignore b/.gitignore
index 432450f..588be13 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,6 +6,7 @@ dist/
.idea/
*.pyc
.DS_Store
+.pytest_cache/
# Spark junk
metastore_db/
@@ -14,4 +15,4 @@ derby.log
*.ipynb*
docs/doctrees
-docs/.buildinfo
\ No newline at end of file
+docs/.buildinfo
diff --... |
capitalone__datacompy-30 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"datacompy/core.py:Compare.__init__",
"datacompy/core.py:Compare._compare",
"datacompy/core.py:Compare._intersect_compare",
"datacompy/core.py:columns_equal"
],
"edite... | capitalone/datacompy | e406940f0c4b9acc6284ab27dcaecd96b857ae83 | Ignore case when comparing strings
Might be a nice to have a optional ignore case feature so that `STRING` == `string`.
Should be relatively simple to add. Happy to take it on.
@theianrobertson thoughts? | diff --git a/datacompy/core.py b/datacompy/core.py
index c6553f8..e39fa5e 100644
--- a/datacompy/core.py
+++ b/datacompy/core.py
@@ -62,6 +62,8 @@ class Compare(object):
A string name for the second dataframe
ignore_spaces : bool, optional
Flag to strip whitespace (including newlines) from string... |
capitalone__datacompy-335 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "datacompy/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"datacompy/core... | capitalone/datacompy | 60c52d2d5d8b1f93954cb979228978c895d2774a | pandas df with datetime.date cols returns false differences if ignore_case=True
When ignore_case=True, identical values with type datetime.date will be reported as unequal.
This happens because in core.py/columns_equal() the attempt to call str.upper() on the col for case insensitive-comparison will throw an exception... | diff --git a/datacompy/__init__.py b/datacompy/__init__.py
index 8dfa816..a189022 100644
--- a/datacompy/__init__.py
+++ b/datacompy/__init__.py
@@ -18,7 +18,7 @@ Originally started to be something of a replacement for SAS's PROC COMPARE for P
Then extended to carry that functionality over to Spark Dataframes.
"""
... |
capitalone__datacompy-36 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "datacompy/_version.py"
},
{
"changes": {
"added_entities": [
"datacompy/core.py:generate_id_within_group"
],
"added_modules"... | capitalone/datacompy | 46748b8842589c444c1c14d0bd76ba60f1306f20 | Issue with nulls in join columns when de-duping
There's an issue with the logic that tries to handle duplicate data. This is a minimal example:
```python
import numpy as np
import pandas as pd
import datacompy
df1 = pd.DataFrame({
'fld_1': [1,2,2,3,3,4,5,5],
'fld_2': ['A',np.nan,np.nan,np.nan,np.nan... | diff --git a/datacompy/_version.py b/datacompy/_version.py
index d11c499..fe34cde 100644
--- a/datacompy/_version.py
+++ b/datacompy/_version.py
@@ -14,4 +14,4 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-__version__ = "0.5.1"
+__version__ = "0.5.2"
diff... |
capitalone__datacompy-62 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"datacompy/core.py:Compare._dataframe_merge"
],
"edited_modules": [
"datacompy/core.py:Compare"
]
},
"file": "datacompy/core.py"
}
] | capitalone/datacompy | bce9c64c1984b944bc4edabf24c6f0b9b56c5537 | Doesnt take into account join columns when doing strip() of white spaces
Join columns can have whitespaces as well,so ideally below section should be enhanced to check for ignore_spaces and strip() if it is true for string columns
This is causing complete mismatch of 2 dataframes here in case 1 of join column has spac... | diff --git a/datacompy/core.py b/datacompy/core.py
index e0cb46f..5bad7dc 100644
--- a/datacompy/core.py
+++ b/datacompy/core.py
@@ -61,7 +61,8 @@ class Compare:
df2_name : str, optional
A string name for the second dataframe
ignore_spaces : bool, optional
- Flag to strip whitespace (including... |
capless__envs-20 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"envs/__init__.py:Env.__call__"
],
"edited_modules": [
"envs/__init__.py:Env"
]
},
"file": "envs/__init__.py"
}
] | capless/envs | 3bfd12ee46c4da92d0cdf68a183531ffdeb5ea73 | allow_none=True, type "integer" -> error
hi
thank you for your usefull package :)
i think i've found one small bug.
```
>>> from envs import env
>>> PAGE_CACHE=env("PAGE_CACHE", None, "integer", allow_none=True)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/tlb/.ca... | diff --git a/envs/__init__.py b/envs/__init__.py
index 9d6bbce..4a0b860 100644
--- a/envs/__init__.py
+++ b/envs/__init__.py
@@ -48,12 +48,14 @@ class Env(object):
json.dump({'key': key, 'var_type': var_type, 'default': default, 'value': os.getenv(key)}, f)
f.write(',')
value ... |
capsulecorplab__mindgraph-17 | [
{
"changes": {
"added_entities": [
"mindgraph/graph.py:Node._postorder",
"mindgraph/graph.py:Node.todo"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"mindgraph/graph.py:Node"
]
},
"file": "mindgraph/graph.py"
}
] | capsulecorplab/mindgraph | 78d3cd912e2a882a2b6cb9569d3122afec05c47e | add method that returns a generator of a "sorted to-do list"
As eluded to in #5, this would be a `Node` object method that traverses its threads, and returns a sequential data structure of all head nodes. Nodes should be sorted by weight, but nodes containing dependencies should be preceded by their dependencies.
I'... | diff --git a/mindgraph/graph.py b/mindgraph/graph.py
index 640c52d..a1a5ad7 100644
--- a/mindgraph/graph.py
+++ b/mindgraph/graph.py
@@ -1,7 +1,8 @@
# -*- coding: utf-8 -*-
import functools
+from typing import (Any, Callable, Generator, Iterator, List, Optional, Set,
+ Tuple)
-from typing import ... |
capsulecorplab__mindgraph-22 | [
{
"changes": {
"added_entities": [
"mindgraph/graph.py:Task.__init__",
"mindgraph/graph.py:Task.append",
"mindgraph/graph.py:Task.pop",
"mindgraph/graph.py:Task.blockedby",
"mindgraph/graph.py:Task.blocking",
"mindgraph/graph.py:Task.__getitem__",
"m... | capsulecorplab/mindgraph | cfc9443eda343310c5f2cadb91f61e1849990a05 | Name changes for Graph, Node, and Node attributes
To implement the following changes to the current naming convention:
`Graph` to `Project`
`Node` to `Task`
`Node.threads` to `Task.subtasks`
`Node.dependencies` to `Task.blockers`
`Node.weight` to `Task.priority` | diff --git a/README.md b/README.md
index c80ec3f..644f1cd 100644
--- a/README.md
+++ b/README.md
@@ -20,14 +20,14 @@ $ pip install git+https://github.com/capsulecorplab/mindgraph.git
```
>>> import mindgraph as mg
->>> graph = mg.Graph('learn all the things')
->>> thing1 = graph.append('1st thing')
->>> thing2 = gr... |
capsulecorplab__mindgraph-23 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mindgraph/graph.py:Task._postorder",
"mindgraph/graph.py:Task.todo"
],
"edited_modules": [
"mindgraph/graph.py:Task"
]
},
"file": "mindgraph/graph.py"
}
] | capsulecorplab/mindgraph | aa05682130d34c308f699936d16299b5029d26ab | add precedence for "blockers" in todo() method
Current `todo()` method implementation, only accounts for `Task.subtasks` and `Task.priority`. Needs to also account for `Task.blockers`, such that `Task` objects in "blockers" yield prior to `Task` objects in "subtasks". | diff --git a/mindgraph/graph.py b/mindgraph/graph.py
index be55272..c1dc475 100644
--- a/mindgraph/graph.py
+++ b/mindgraph/graph.py
@@ -1,6 +1,6 @@
# -*- coding: utf-8 -*-
-from typing import (Any, Callable, Generator, Iterator, List, Optional, Set,
- Tuple)
+from typing import Any, Callable, Itera... |
caronc__apprise-1128 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"apprise/plugins/matrix.py:NotifyMatrix.__init__",
"apprise/plugins/matrix.py:NotifyMatrix._send_server_notification"
],
"edited_modules": [
"apprise/plugins/matrix.py:NotifyM... | caronc/apprise | 286a4374c0988eb996c469557617b8b0c3d885d5 | Matrix v3 messages are rejected as duplicates when the login session is reused
:mega: **Notification Service(s) Impacted**
Matrix
:lady_beetle: **Describe the bug**
In Matrix's v3 API [when a client sends a message](https://spec.matrix.org/unstable/client-server-api/#put_matrixclientv3roomsroomidsendeventtypetxn... | diff --git a/apprise/plugins/matrix.py b/apprise/plugins/matrix.py
index c1401f2..70a4098 100644
--- a/apprise/plugins/matrix.py
+++ b/apprise/plugins/matrix.py
@@ -293,6 +293,9 @@ class NotifyMatrix(NotifyBase):
# This gets initialized after a login/registration
self.access_token = None
+ # ... |
caronc__apprise-119 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"apprise/AppriseLocale.py:AppriseLocale.detect_language"
],
"edited_modules": [
"apprise/AppriseLocale.py:AppriseLocale"
]
},
"file": "apprise/AppriseLocale.py"
}
] | caronc/apprise | cbd35c3b7e4b0559fbdb16b481d7c2cabbb602a1 | AppriseLocale.py TypeError: 'NoneType' object has no attribute '__getitem__'
An system without any universal language identifier existing in it's environment at all causes an unhanded exception:
```python
File "/usr/lib/python2.7/site-packages/apprise/Apprise.py", line 78, in __init__
self.locale = AppriseLoca... | diff --git a/apprise/AppriseLocale.py b/apprise/AppriseLocale.py
index ea88acc..714d201 100644
--- a/apprise/AppriseLocale.py
+++ b/apprise/AppriseLocale.py
@@ -192,16 +192,24 @@ class AppriseLocale(object):
if hasattr(ctypes, 'windll'):
windll = ctypes.windll.kernel32
- l... |
caronc__apprise-324 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"apprise/utils.py:is_hostname"
],
"edited_modules": [
"apprise/utils.py:is_hostname"
]
},
"file": "apprise/utils.py"
}
] | caronc/apprise | 2c2722f61f9f983827c8246943f0462098e5a0ed | 'Unparseable E-Mail URL' error for hostnames containing underscore
With underscore:
```bash
$ docker run --rm caronc/apprise:latest /usr/local/bin/apprise --body='hello world' \
'mailto://smtp_service:25/?from=foo@localhost&to=bar@localhost'
2020-11-22 16:33:16,297 - ERROR - Unparseable E-Mail URL mailto://smtp_s... | diff --git a/.gitignore b/.gitignore
index 11f190a..0315c5b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -67,3 +67,8 @@ target/
#PyCharm
.idea
+
+#PyDev (Eclipse)
+.project
+.pydevproject
+.settings
diff --git a/apprise/utils.py b/apprise/utils.py
index 21f2c49..4b4833b 100644
--- a/apprise/utils.py
+++ b/apprise/ut... |
carpedm20__emoji-128 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"emoji/core.py:emoji_lis",
"emoji/core.py:emoji_count"
],
"edited_modules": [
"emoji/core.py:emoji_lis",
"emoji/core.py:emoji_count"
]
},
"file": "emoji/... | carpedm20/emoji | d26371bd28d2c9307826574cf21b0d0bd47787d8 | emoji_lis() function doesn't work for some sequence emotes
Hi there, I'm noticing that in some circumstances, eg the UK nation flag emoji of Scotland, England and Wales, this function isn't spitting out the complete sequence. Instead, the function just provides a generic black flag emoji with none of the other codepoin... | diff --git a/emoji/core.py b/emoji/core.py
index 9537692..327ad2a 100644
--- a/emoji/core.py
+++ b/emoji/core.py
@@ -99,20 +99,26 @@ def get_emoji_regexp():
_EMOJI_REGEXP = re.compile(pattern)
return _EMOJI_REGEXP
+
def emoji_lis(string):
- """Return the location and emoji in list of dic format
- ... |
carpedm20__emoji-185 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "emoji/unicode_codes/de.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_m... | carpedm20/emoji | 2a757849d841ac2b1eb39534f350535db1e1537b | Inconsistent variant in the languages
There are several emoji in the language files that are stored as a variant instead of the plain emoji.
Here is an example:
```python
import emoji
print(emoji.demojize(emoji.emojize(":eye:")))
# > :eye'
print(emoji.demojize(emoji.emojize(":eye:"), language="es"))
# > ::
... | diff --git a/emoji/unicode_codes/de.py b/emoji/unicode_codes/de.py
index 0bdcd72..580153a 100644
--- a/emoji/unicode_codes/de.py
+++ b/emoji/unicode_codes/de.py
@@ -23,7 +23,7 @@ EMOJI_UNICODE_GERMAN = {
u':überwältigt:': u'\U0001F929',
u':kuss_zuwerfendes_gesicht:': u'\U0001F618',
u':küssendes_gesicht:': u'\U000... |
carsdotcom__skelebot-280 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"skelebot/components/package.py:Package.execute"
],
"edited_modules": [
"skelebot/components/package.py:Package"
]
},
"file": "skelebot/components/package.py"
}
] | carsdotcom/skelebot | 9532b09fb914e0d62c2221464518990c9afebf25 | `skelebot package` appends if archive already exists
### Problem
When using `skelebot package`, if the target `path` already exists skelebot will add/append to it instead of re-creating the file. This is because of how `zip`, the underlying command used by skelebot for this command, works.
This can lead to unexpected ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6dfe89a..7a4077c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,7 +3,15 @@ Documenting All Changes to the Skelebot Project
---
+## v2.1.1
+#### Added
+- **Package Component** | Updated `package` component to delete destination path if it already exists before arch... |
casbin__pycasbin-346 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "casbin/constant/constants.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"casbin/... | casbin/pycasbin | 846cf2490648f344817d53280cfb3c4f03a91f26 | RBAC with Domain model ,get_all_subjects error
1、model.conf
2、code：
3、sqlite info
![image](https://github.com/casbin/py... | diff --git a/casbin/constant/constants.py b/casbin/constant/constants.py
index c5b89b3..428dc13 100644
--- a/casbin/constant/constants.py
+++ b/casbin/constant/constants.py
@@ -13,6 +13,7 @@
# limitations under the License.
# Index constants
+ACTION_INDEX = "act"
DOMAIN_INDEX = "dom"
SUBJECT_INDEX = "sub"
OBJECT... |
casbin__pycasbin-53 | [
{
"changes": {
"added_entities": [
"casbin/enforcer.py:Enforcer.get_implicit_users_for_permission"
],
"added_modules": null,
"edited_entities": [
"casbin/enforcer.py:Enforcer.get_roles_for_user",
"casbin/enforcer.py:Enforcer.get_roles_for_user_in_domain",
... | casbin/pycasbin | 4d228a319768ea38657d5f1a37835aee8a2ec5c1 | Bringing pycasbin in track with casbin-core.
I am sure there must be some features or functionalities which are not in track with casbin-core, why should we not track those features and bring them here and implement it. | diff --git a/casbin/enforcer.py b/casbin/enforcer.py
index deec151..ee8d0e7 100644
--- a/casbin/enforcer.py
+++ b/casbin/enforcer.py
@@ -1,11 +1,9 @@
-import copy
from casbin.management_enforcer import ManagementEnforcer
-from functools import reduce
-
+from casbin.util import join_slice, set_subtract
class Enforce... |
castle__castle-python-29 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "castle/configuration.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"castle/reque... | castle/castle-python | 288780af56d67af5757c6b0d17a74a24c29a9a60 | change timeout configuration from seconds to miliseconds | diff --git a/HISTORY.md b/HISTORY.md
index c705403..e66e5a4 100644
--- a/HISTORY.md
+++ b/HISTORY.md
@@ -1,3 +1,8 @@
+## master
+
+### Breaking Changes:
+- switched configuration request_timeout from seconds to milliseconds
+
## 2.0.0 (2018-02-09)
### Features:
diff --git a/README.rst b/README.rst
index 5fc110f..14... |
catalystneuro__neuroconv-1042 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/nwb_helpers/_configuration_models/_base_dataset_io.py:DatasetIOConfiguration.from_neurodata_object"
],
"edited_modules": [
"src/neuroconv/tools/nwb_helpers/_confi... | catalystneuro/neuroconv | 78c1177a0b5cb78a36f96a59d2060f3949b28ba4 | [Feature]: Add Compression support for compound objects
### What would you like to see added to NeuroConv?
`DatasetIOConfiguration.from_neurodata_object` currently raises a `NotImplementedError` for compound objects with dtype 'object'.
This makes it very difficult to use the `KiloSortSortingInterface`, which incl... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 12ed1eaf..cf4f6bfb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,6 @@
# Upcoming
-## v.0.6.3
+## v0.6.4
## Bug Fixes
* Fixed a setup bug introduced in `v0.6.2` where installation process created a directory instead of a file for test configuration file [P... |
catalystneuro__neuroconv-672 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/data_transfers/_globus.py:get_globus_dataset_content_sizes"
],
"edited_modules": [
"src/neuroconv/tools/data_transfers/_globus.py:get_globus_dataset_content_sizes... | catalystneuro/neuroconv | 4c6931723a3d3464842ca33018567e361483b4e6 | Install neuroconv without dandi
Right now dandi is part of our basic dependencies and naturally it comes itself bundled with a bunch of libraries for handling downloading and uploading.
For the use case of just transforming data within an analysis pipeline none of those dependencies are really needed.
Maybe it ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f8aea59a..e954ce88 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,11 @@
# Upcoming
+### Improvement
+
+* `nwbinspector` has been removed as a minimal dependency. It becomes an extra (optional) dependency with `neuroconv[dandi]`. [PR #672](https://github.com/cat... |
catalystneuro__neuroconv-679 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/path_expansion.py:AbstractPathExpander.extract_metadata"
],
"edited_modules": [
"src/neuroconv/tools/path_expansion.py:AbstractPathExpander"
]
},
"f... | catalystneuro/neuroconv | 29f02ab2b9fc34b4e70c18d0ba122ca58cc4e213 | `LocalPathExpander` should match only `folder_paths` or `file_paths` depending on the spec.
I am trying to use the `LocalPathExpander` for the Clandinin project but I am encountering the following issue. I have something like the following structure:
```python
.
└── base_directory
├── a_simple_pattern_1
... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 769c2f6d..da38e127 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,7 +1,7 @@
# Upcoming
### Bug fixes
-* LocalPathExpander matches only `folder_paths` or `file_paths` if that is indicated in the passed specification. [PR #675](https://github.com/catalystneuro/neuroc... |
catalystneuro__neuroconv-761 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/nwb_helpers/_configuration_models/_base_backend.py:BackendConfiguration.from_nwbfile"
],
"edited_modules": [
"src/neuroconv/tools/nwb_helpers/_configuration_model... | catalystneuro/neuroconv | 16de46bcedb5ac5c75d2645409458a846997875d | [Backend Follow-up]: Change 'location' field name to 'location_in_file'
### What would you like to see added to NeuroConv?
To avoid confusion with 'location' as interpreted as 'brain area' in NWB
### Is your feature request related to a problem?
_No response_
### Do you have any interest in helping implement the fe... | diff --git a/src/neuroconv/tools/nwb_helpers/_configuration_models/_base_backend.py b/src/neuroconv/tools/nwb_helpers/_configuration_models/_base_backend.py
index b9491171..b66d5697 100644
--- a/src/neuroconv/tools/nwb_helpers/_configuration_models/_base_backend.py
+++ b/src/neuroconv/tools/nwb_helpers/_configuration_m... |
catalystneuro__neuroconv-849 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/roiextractors/roiextractors.py:add_devices",
"src/neuroconv/tools/roiextractors/roiextractors.py:add_photon_series"
],
"edited_modules": [
"src/neuroconv/... | catalystneuro/neuroconv | 6bdffa6b5a4136caea7062e08dd12cb17066fa50 | [Bug]: BaseImagingExtractorInterface.add_to_nwbfile() requires metadata
### What happened?
The call signature of BaseImagingExtractorInterface.add_to_nwbfile() states that metadata is optional, however if it is ommitted, you get errors because internal functions in fact require it. I am adjusting to use defaults of me... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 902e1652..c543012c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@
* Fixed an issue with `set_aligned_starting_time` for all `SortingInterface`'s that did not have an initial segment start set (and no recording attached). [PR #823](https://github.com/cataly... |
catalystneuro__neuroconv-894 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/nwb_helpers/_dataset_configuration.py:get_default_dataset_io_configurations"
],
"edited_modules": [
"src/neuroconv/tools/nwb_helpers/_dataset_configuration.py:get... | catalystneuro/neuroconv | ef5ec11235630a59e478ccbd2f251c64d77d364c | [Bug]: Object of type `LabMetaDataExtension` is not JSON serializable
### What happened?
I am save a custom `.mat` matlab data file using nwb extension called tank-lab-to-nwb ([repo](https://github.com/catalystneuro/tank-lab-to-nwb)) that uses the ndx-tank-metadata ([repo](https://github.com/catalystneuro/ndx-tank-me... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 43916805..f1c3a3a1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,10 @@
# Upcoming
+### Bug fixes
+* Added a skip condition in `get_default_dataset_io_configurations` for datasets with any zero-length axis in their `full_shape`. [PR #894](https://github.com/cat... |
catalystneuro__neuroconv-907 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/tools/roiextractors/roiextractors.py:add_photon_series"
],
"edited_modules": [
"src/neuroconv/tools/roiextractors/roiextractors.py:add_photon_series"
]
},
... | catalystneuro/neuroconv | acf576b3f918086c3470ab8f932d3c4a07992846 | [Bug]: AssertionError triggered when trying to add both OnePhotonSeries and TwoPhotonSeries
### What happened?
`AssertionError: Received metadata for 'OnePhotonSeries' but photon_series_type was not explicitly specified.`
Here it is assumed that either OnePhotonSeries or TwoPhotonSeries can co-exist in the same n... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 31be213a..5dcccf0e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,7 @@
### Bug fixes
* Fixed bug causing overwrite of NWB GUIDE watermark. [PR #890](https://github.com/catalystneuro/neuroconv/pull/890)
+* Change error trigger with warning trigger when adding... |
catalystneuro__neuroconv-914 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/neuroconv/datainterfaces/behavior/video/videodatainterface.py:VideoInterface.__init__",
"src/neuroconv/datainterfaces/behavior/video/videodatainterface.py:VideoInterface.get_metadata_schema"... | catalystneuro/neuroconv | 8a402c983fc24844355afe2e423a849a80a1f488 | [Bug]: Converter won't work with multiple VideoInterfaces
### What happened?
I want to store multiple behavioral videos, but these are not sequential, they are independent recordings form different directions (top, side).
As of now, it seems to break due to VideoInterface using always the same key in the general sche... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 18de2d30..a5a76c31 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,7 +16,7 @@
### Improvements
* Propagated `photon_series_type` to `BaseImagingExtractorInterface` init instead of passing it as an argument of `get_metadata()` and `get_metadata_schema()`. [PR #847](... |
catalystneuro__roiextractors-128 | [
{
"changes": {
"added_entities": [
"src/roiextractors/imagingextractor.py:ImagingExtractor.frame_slice",
"src/roiextractors/imagingextractor.py:FrameSliceImagingExtractor.__init__",
"src/roiextractors/imagingextractor.py:FrameSliceImagingExtractor.get_frames",
"src/roiextra... | catalystneuro/roiextractors | 71e2b527366194e42b559cff766d160344863a8d | add stub option
A stub option should limit the conversion to the first ~100 frames so that conversions can be tested quickly without reading/writing all of the data. | diff --git a/src/roiextractors/imagingextractor.py b/src/roiextractors/imagingextractor.py
index e65a618..059d9d4 100644
--- a/src/roiextractors/imagingextractor.py
+++ b/src/roiextractors/imagingextractor.py
@@ -1,5 +1,6 @@
+"""Base class definitions for all ImagingExtractors."""
from abc import ABC, abstractmethod
-... |
catalystneuro__roiextractors-363 | [
{
"changes": {
"added_entities": [
"src/roiextractors/volumetricimagingextractor.py:VolumetricImagingExtractor.depth_slice",
"src/roiextractors/volumetricimagingextractor.py:VolumetricImagingExtractor.frame_slice",
"src/roiextractors/volumetricimagingextractor.py:DepthSliceVolumetr... | catalystneuro/roiextractors | 1a3a8a454aee6cc1a93ea9bc5dd3ebc0b29d572a | [Feature]: Depth Slice for VolumetricImagingExtractor
### What would you like to see added to ROI Extractors?
Depth Slice for VolumetricImagingExtractor
### Do you have any interest in helping implement the feature?
Yes.
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.co... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 21f9cb3..2f4bfe3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,7 @@
### Features
* Added a seed to dummy generators [#361](https://github.com/catalystneuro/roiextractors/pull/361)
+* Added depth_slice for VolumetricImagingExtractors [PR #363](https://github.c... |
catkin__catkin_tools-574 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"catkin_tools/common.py:FakeLock.acquire"
],
"edited_modules": [
"catkin_tools/common.py:FakeLock"
]
},
"file": "catkin_tools/common.py"
},
{
"changes": {
... | catkin/catkin_tools | 7f4506ad3f381a799d6dd5ec19c38a805d6914b5 | Potential trollius issue
[//]: # (Thank you for reporting an issue for catkin_tools!)
[//]: # (Please fill out the details below so that your issue can be resolved quickly!)
[//]: # (If you want to suggest a feature or start a discussion, feel free to delete them.)
### System Info
* Operating System: Docker c... | diff --git a/.travis.before_install.bash b/.travis.before_install.bash
index 27eda82..a0ba725 100755
--- a/.travis.before_install.bash
+++ b/.travis.before_install.bash
@@ -6,13 +6,7 @@ if [ "$TRAVIS_OS_NAME" == "linux" ]; then
sudo apt update
sudo apt install enchant -y
elif [ "$TRAVIS_OS_NAME" == "osx" ]; then... |
catkin__catkin_tools-578 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"catkin_tools/common.py:cmd_split",
"catkin_tools/common.py:FakeLock.acquire",
"catkin_tools/common.py:parse_env_str"
],
"edited_modules": [
"catkin_tools/common.py:cm... | catkin/catkin_tools | 7f4506ad3f381a799d6dd5ec19c38a805d6914b5 | ValueError: No closing quotation
[//]: # (Thank you for reporting an issue for catkin_tools!)
[//]: # (Please fill out the details below so that your issue can be resolved quickly!)
[//]: # (If you want to suggest a feature or start a discussion, feel free to delete them.)
### System Info
* Operating System: ... | diff --git a/.travis.before_install.bash b/.travis.before_install.bash
index 27eda82..a0ba725 100755
--- a/.travis.before_install.bash
+++ b/.travis.before_install.bash
@@ -6,13 +6,7 @@ if [ "$TRAVIS_OS_NAME" == "linux" ]; then
sudo apt update
sudo apt install enchant -y
elif [ "$TRAVIS_OS_NAME" == "osx" ]; then... |
catkin__catkin_tools-728 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"catkin_tools/context.py:Context.load"
],
"edited_modules": [
"catkin_tools/context.py:Context"
]
},
"file": "catkin_tools/context.py"
},
{
"changes": {
"a... | catkin/catkin_tools | c1707309479138b22c97d966b9095dd3ac844197 | catkin locate --build does not find 'profile'_build
[//]: # (Thank you for reporting an issue for catkin_tools!)
[//]: # (Please fill out the details below so that your issue can be resolved quickly!)
[//]: # (If you want to suggest a feature or start a discussion, feel free to delete them.)
### System Info
*... | diff --git a/catkin_tools/context.py b/catkin_tools/context.py
index c6ac7c7..f035063 100644
--- a/catkin_tools/context.py
+++ b/catkin_tools/context.py
@@ -191,6 +191,8 @@ class Context(object):
# Get the active profile
profile = profile or opts_vars.get('profile', None) or metadata.get_active_prof... |
catmaid__catpy-25 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "catpy/__init__.py"
},
{
"changes": {
"added_entities": [
"catpy/image.py:ImageFetcher._make_empty_tile"
],
"added_modules": ... | catmaid/catpy | ab4f858dda1144bec732738f406054248af7103d | Instantiating ImageFetcher from CatMaid fails due to integer orientation | diff --git a/catpy/__init__.py b/catpy/__init__.py
index feba40e..895073e 100644
--- a/catpy/__init__.py
+++ b/catpy/__init__.py
@@ -10,3 +10,5 @@ __all__ = ['client']
from catpy.client import CatmaidClient, CoordinateTransformer, CatmaidUrl # noqa
+from catpy import image # noqa
+from catpy import export # noq... |
cbinyu__bidsphysio-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"bidsphysio.dcm2bids/bidsphysio/dcm2bids/dcm2bidsphysio.py:parse_log"
],
"edited_modules": [
"bidsphysio.dcm2bids/bidsphysio/dcm2bids/dcm2bidsphysio.py:parse_log"
]
},
"... | cbinyu/bidsphysio | 86b9e7c8c461edcfb7888798f2a973f408eb7d9f | Request: CMRR .log files
Hello all,
I would like to use this package to convert physio files exported from CMRR multi-Band sequences to the BIDS format. However, when the data were acquired, the physio files were exported as .log files (*_ECG.log, *_RESP.log, *_PULS.log, *_Info.log).
Would it be possible to have ... | diff --git a/bidsphysio.dcm2bids/bidsphysio/dcm2bids/dcm2bidsphysio.py b/bidsphysio.dcm2bids/bidsphysio/dcm2bids/dcm2bidsphysio.py
index 335251b..254a31c 100644
--- a/bidsphysio.dcm2bids/bidsphysio/dcm2bids/dcm2bidsphysio.py
+++ b/bidsphysio.dcm2bids/bidsphysio/dcm2bids/dcm2bidsphysio.py
@@ -213,10 +213,13 @@ def parse... |
cclib__cclib-1320 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cclib/bridge/cclib2ase.py:_check_ase",
"cclib/bridge/cclib2ase.py:makease",
"cclib/bridge/cclib2ase.py:write_trajectory",
"cclib/bridge/cclib2ase.py:read_trajectory",
"cc... | cclib/cclib | a4831f9c25327f7a49a263da275c9268c58a2f27 | `free_energy` vs. `freeenergy` issue in `cclib2ase.py`
https://github.com/cclib/cclib/blob/880210c18d4cfd7a40e8af6ce50d40a748ee2d7c/cclib/bridge/cclib2ase.py#L109-L110
I believe the cclib property is named `freeenergy` ([source](https://cclib.github.io/data.html)) rather than `free_energy`. I don't have a test case ... | diff --git a/cclib/bridge/cclib2ase.py b/cclib/bridge/cclib2ase.py
index e81c0a15..d0f8de86 100644
--- a/cclib/bridge/cclib2ase.py
+++ b/cclib/bridge/cclib2ase.py
@@ -7,6 +7,8 @@
"""Bridge for using cclib data in ASE (https://wiki.fysik.dtu.dk/ase/)."""
+from typing import Optional, Sequence
+
from cclib.parser.d... |
cclib__cclib-989 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cclib/io/xyzwriter.py:XYZ._xyz_from_ccdata"
],
"edited_modules": [
"cclib/io/xyzwriter.py:XYZ"
]
},
"file": "cclib/io/xyzwriter.py"
}
] | cclib/cclib | 8667016849784b7506a23cd7fe113c13212dd653 | missing `comment` key in parsed `ORCA` `ccData`
I just realized that the parsed object data from `ORCA` (`version 4.2.1`) is missing `comments` key which will result in throwing `KeyError` in the case of writing xyz file.
https://github.com/cclib/cclib/blob/87abf82c6a06836a2e5fb95a64cdf376c5ef8d4f/cclib/io/xyzwriter.... | diff --git a/cclib/io/xyzwriter.py b/cclib/io/xyzwriter.py
index 5a074cec..da14daa6 100644
--- a/cclib/io/xyzwriter.py
+++ b/cclib/io/xyzwriter.py
@@ -81,7 +81,7 @@ class XYZ(filewriter.Writer):
"""Create an XYZ file of the geometry at the given index."""
atomcoords = self.ccdata.atomcoords[index]
-... |
cdent__gabbi-119 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers.py:HeadersResponseHandler.action"
],
"edited_modules": [
"gabbi/handlers.py:HeadersResponseHandler"
]
},
"file": "gabbi/handlers.py"
}
] | cdent/gabbi | 040821d39bd4fa067ea947bbf37687f76f4f325b | If the test value for a response header is not treated by yaml as a string there is an error
```
File "/Users/cdent/src/enamel/.tox/functional/lib/python2.7/site-packages/gabbi/handlers.py", line 149, in action
if header_value.startswith('/') and header_value.endswith('/'):
AttributeError: 'float' object... | diff --git a/gabbi/handlers.py b/gabbi/handlers.py
index 33a4175..6de7f5b 100644
--- a/gabbi/handlers.py
+++ b/gabbi/handlers.py
@@ -128,6 +128,8 @@ class HeadersResponseHandler(ResponseHandler):
If a header value is wrapped in ``/`` it is treated as a raw
regular expression.
+
+ Headers values are alway... |
cdent__gabbi-137 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/runner.py:run"
],
"edited_modules": [
"gabbi/runner.py:run"
]
},
"file": "gabbi/runner.py"
},
{
"changes": {
"added_entities": null,
"added_mo... | cdent/gabbi | e31f9b4f621f46bbd192b240f368fe915557e199 | gabbi can't cope with an ipv6 host argument
If an ipv6 address is passed in host when doing `build_tests` the built url is incorrect. An ipv6 address in a url is supposed to be bracketed: `[::1]`. | diff --git a/docs/source/runner.rst b/docs/source/runner.rst
index fe35932..aaa5815 100644
--- a/docs/source/runner.rst
+++ b/docs/source/runner.rst
@@ -32,5 +32,8 @@ or in the target URL::
The value of prefix will be prepended to the path portion of URLs that
are not fully qualified.
+Anywhere host is used, if it ... |
cdent__gabbi-153 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/driver.py:build_tests",
"gabbi/driver.py:py_test_generator"
],
"edited_modules": [
"gabbi/driver.py:build_tests",
"gabbi/driver.py:py_test_generator"
]
... | cdent/gabbi | 0a8a3b8faf9a900fd132d9b147f67a851d52f178 | In 'live' testing scenarios argument passing to build_tests is convoluted and SSL may not work
If you want to use `build_tests` to create real TestCases against a live server it's likely you know the URL and that would be most convenient thing to pass instead of having to parse out the host, port and prefix (script_nam... | diff --git a/gabbi/driver.py b/gabbi/driver.py
index 33c0a98..49088fa 100644
--- a/gabbi/driver.py
+++ b/gabbi/driver.py
@@ -39,7 +39,8 @@ from gabbi import utils
def build_tests(path, loader, host=None, port=8001, intercept=None,
test_loader_name=None, fixture_module=None,
- response... |
cdent__gabbi-157 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/driver.py:build_tests"
],
"edited_modules": [
"gabbi/driver.py:build_tests"
]
},
"file": "gabbi/driver.py"
},
{
"changes": {
"added_entities": null,... | cdent/gabbi | 1b9a0be830dac86865bee85c33886d3b2fb4d37b | Q: What characters are legal / recommended for test name in YAML?
I suspect plain alphanum + spaces is recommended, but I might sometimes want to do hyphen or parens. So, just being thorough.
Thanks!
| diff --git a/gabbi/driver.py b/gabbi/driver.py
index 9cb88fe..22a48c4 100644
--- a/gabbi/driver.py
+++ b/gabbi/driver.py
@@ -29,8 +29,10 @@ import os
import unittest
from unittest import suite
import uuid
+import warnings
from gabbi import case
+from gabbi import exception
from gabbi import handlers
from gabbi ... |
cdent__gabbi-167 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers.py:JSONResponseHandler.action"
],
"edited_modules": [
"gabbi/handlers.py:JSONResponseHandler"
]
},
"file": "gabbi/handlers.py"
}
] | cdent/gabbi | 2bd1c803b71bd26be7822be87e249a811467b863 | regex matching in JSONResponseHandler doesn't deal with numbers
If the match is a number, the regex matching errors out. We need to cast to a string before doing the regex test. | diff --git a/gabbi/handlers.py b/gabbi/handlers.py
index e4ed7f5..5302f3e 100644
--- a/gabbi/handlers.py
+++ b/gabbi/handlers.py
@@ -110,6 +110,8 @@ class JSONResponseHandler(ResponseHandler):
if (hasattr(expected, 'startswith') and expected.startswith('/')
and expected.endswith('/')):
... |
cdent__gabbi-186 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/httpclient.py:VerboseHttp._print_body"
],
"edited_modules": [
"gabbi/httpclient.py:VerboseHttp"
]
},
"file": "gabbi/httpclient.py"
}
] | cdent/gabbi | f27b9aba8590dbdb16749f917cdcf3fffc6218e3 | If verbose: True and response content-type is json may as well pretty print the output
It kinda seems like if we know the content-type when being verbose about bodies, we may as well pretty print if it is json. It's not much effort to do so (there's already pretty printing happening in some test failure messages) and i... | diff --git a/gabbi/httpclient.py b/gabbi/httpclient.py
index 22869e5..88f873d 100644
--- a/gabbi/httpclient.py
+++ b/gabbi/httpclient.py
@@ -19,6 +19,7 @@ import sys
import urllib3
+from gabbi.handlers import jsonhandler
from gabbi import utils
@@ -138,11 +139,20 @@ class VerboseHttp(Http):
def _print_... |
cdent__gabbi-191 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/runner.py:run",
"gabbi/runner.py:run_suite"
],
"edited_modules": [
"gabbi/runner.py:run",
"gabbi/runner.py:run_suite"
]
},
"file": "gabbi/runner.p... | cdent/gabbi | 07dc4913eb980dd4a4a6130abfd708a39235d7f2 | Data <@filename isn't relative to the YAML file
The [docs say](https://gabbi.readthedocs.io/en/latest/format.html#data):
> If the value is a string that begins with <@ then the rest of the string is treated as the name of a file to be loaded from the same directory as the YAML file.
But I haven't found it works ... | diff --git a/gabbi/runner.py b/gabbi/runner.py
index ac98dea..9f45351 100644
--- a/gabbi/runner.py
+++ b/gabbi/runner.py
@@ -14,6 +14,7 @@
import argparse
from importlib import import_module
+import os
import sys
import unittest
@@ -84,8 +85,9 @@ def run():
else:
for input_file in input_files:
... |
cdent__gabbi-200 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/suite.py:GabbiSuite.run"
],
"edited_modules": [
"gabbi/suite.py:GabbiSuite"
]
},
"file": "gabbi/suite.py"
}
] | cdent/gabbi | 3e450b1d375c2ee8f18a7c6798cfca211ba2fa98 | exceptions that happen in start_fixture() are swallowed during the test discovery process
The discovery will fail and end up producing a seemingly non-related error like `math domain error` and the real exception is nowhere to be found.
This needs to be narrowed to a minimal test case and then figured out.
What s... | diff --git a/gabbi/suite.py b/gabbi/suite.py
index 765a929..f6d3868 100644
--- a/gabbi/suite.py
+++ b/gabbi/suite.py
@@ -16,6 +16,7 @@ This suite has two features: the contained tests are ordered and there
are suite-level fixtures that operate as context managers.
"""
+import sys
import unittest
from wsgi_inter... |
cdent__gabbi-210 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers/base.py:ResponseHandler.__call__"
],
"edited_modules": [
"gabbi/handlers/base.py:ResponseHandler"
]
},
"file": "gabbi/handlers/base.py"
}
] | cdent/gabbi | 867042bc99a844d37e3eb5e7dd748dbb0734ac69 | response_string can lead to false positives if value is a string
The correct way to do the `response_strings` test is to provide a list of strings:
```yaml
response_strings:
- foo
- bar
```
If you forget and do a string, though, it can sometimes pass because the value is use as an iterable and strings... | diff --git a/gabbi/handlers/base.py b/gabbi/handlers/base.py
index 03c37e3..055aff8 100644
--- a/gabbi/handlers/base.py
+++ b/gabbi/handlers/base.py
@@ -13,6 +13,9 @@
"""Base classes for response and content handlers."""
+from gabbi.exception import GabbiFormatError
+
+
class ResponseHandler(object):
"""Add ... |
cdent__gabbi-238 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/case.py:HTTPTestCase._replace_headers_template"
],
"edited_modules": [
"gabbi/case.py:HTTPTestCase"
]
},
"file": "gabbi/case.py"
}
] | cdent/gabbi | d91d8ec9a5516615289d77a30529f9ea496b98c4 | Regression with 1.39.0 and empty reponse_headers field
One of the tests in Gnocchi has an empty `reponse_headers` field:
https://github.com/gnocchixyz/gnocchi/blob/master/gnocchi/tests/functional/gabbits/resource.yaml#L503
This broke the test suite in some way as one behaviour changed between Gabbi 1.38.0 and 1.39.... | diff --git a/gabbi/case.py b/gabbi/case.py
index a7a0f49..2403859 100644
--- a/gabbi/case.py
+++ b/gabbi/case.py
@@ -481,15 +481,15 @@ class HTTPTestCase(testtools.TestCase):
def _replace_headers_template(self, test_name, headers):
replaced_headers = {}
- for name in headers:
- try:
+ ... |
cdent__gabbi-251 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers/jsonhandler.py:JSONHandler.action"
],
"edited_modules": [
"gabbi/handlers/jsonhandler.py:JSONHandler"
]
},
"file": "gabbi/handlers/jsonhandler.py"
}
] | cdent/gabbi | 913cd948c3ac924caf69ceadacf957d98e745917 | jsonhandler: read data from disk improvements
UPDATE: dropping the yaml loading from this issue and updating the querying of the subset of data from disk to enable JSONPath support like the left hand side does already for the jsonhandler. For example, $.versions[?status = "current"].version: <@endpoint.json:[?status = ... | diff --git a/docs/source/jsonpath.rst b/docs/source/jsonpath.rst
index 317603b..3d00663 100644
--- a/docs/source/jsonpath.rst
+++ b/docs/source/jsonpath.rst
@@ -78,6 +78,46 @@ or::
Examples like this can be found in one of gabbi's `own tests`_.
+When reading from disk you can apply the same JSONPath by adding a ':... |
cdent__gabbi-292 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/utils.py:host_info_from_target"
],
"edited_modules": [
"gabbi/utils.py:host_info_from_target"
]
},
"file": "gabbi/utils.py"
}
] | cdent/gabbi | 3e804a7bd35e449c08ef9cb6d47d094691768499 | Python 3.7.6 urllib.parse changes break gabbi tests
Python 3.7.6 was released with a change to how urllib.parse will deal with "localhost:80".
3.7.5:
```python
>>> from urllib import parse
>>> parse.urlparse("foobar.com:999")
ParseResult(scheme='', netloc='', path='foobar.com:999', params='', query='', fragmen... | diff --git a/gabbi/utils.py b/gabbi/utils.py
index cc0285d..82fcb76 100644
--- a/gabbi/utils.py
+++ b/gabbi/utils.py
@@ -147,26 +147,16 @@ def parse_content_type(content_type, default_charset='utf-8'):
def host_info_from_target(target, prefix=None):
"""Turn url or host:port and target into test destination."""
... |
cdent__gabbi-302 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers/jsonhandler.py:JSONHandler.accepts"
],
"edited_modules": [
"gabbi/handlers/jsonhandler.py:JSONHandler"
]
},
"file": "gabbi/handlers/jsonhandler.py"
}
] | cdent/gabbi | a8d200bdfcaabb2351b2ccb8f9a2b4de693b2b81 | Error when response content-type is application/jsonlines
If the response is `application/jsonlines` the JSON content handler kicks in and attempts to decode the response from json, which fails as it treats the whole doc as one single json object, not lines of json.
This is because the accept method for the handler ... | diff --git a/gabbi/handlers/jsonhandler.py b/gabbi/handlers/jsonhandler.py
index 6647f45..6177779 100644
--- a/gabbi/handlers/jsonhandler.py
+++ b/gabbi/handlers/jsonhandler.py
@@ -38,9 +38,14 @@ class JSONHandler(base.ContentHandler):
@staticmethod
def accepts(content_type):
- content_type = content... |
cdent__gabbi-303 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/case.py:HTTPTestCase._test_data_to_string"
],
"edited_modules": [
"gabbi/case.py:HTTPTestCase"
]
},
"file": "gabbi/case.py"
}
] | cdent/gabbi | a8d200bdfcaabb2351b2ccb8f9a2b4de693b2b81 | If content-type is not set, but data is, the error message is incomplete
If you try to write `data` without setting a content-type header, there's no content handler and the error message is not very useful:
```
File "/mnt/share/cdentsrc/nova/.tox/functional/local/lib/python2.7/site-packages/gabbi/suitemaker.... | diff --git a/gabbi/case.py b/gabbi/case.py
index 6b7823c..c1c0dec 100644
--- a/gabbi/case.py
+++ b/gabbi/case.py
@@ -595,8 +595,12 @@ class HTTPTestCase(unittest.TestCase):
data = self.replace_template(data)
data = dumper_class.dumps(data, test=self)
else:
- ... |
cdent__gabbi-327 | [
{
"changes": {
"added_entities": [
"gabbi/handlers/base.py:ResponseHandler.is_regex"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"gabbi/handlers/base.py:ResponseHandler"
]
},
"file": "gabbi/handlers/base.py"
},
{
"cha... | cdent/gabbi | 6939357f81ff7802a42c9f9e3fdfe0677dbf3cc8 | Support regex in response_strings
Many of the other test handlers support regex in the value, but `response_strings` does not.
This should probably fixed, but it has the potential to cause errors in existing tests so we may want to consider it as a version 3 to signal the change. | diff --git a/docs/source/format.rst b/docs/source/format.rst
index 1217255..847c93c 100644
--- a/docs/source/format.rst
+++ b/docs/source/format.rst
@@ -181,6 +181,11 @@ Response Expectations
``response_strings`` A list of string fragments expected
to be present in the... |
cdent__gabbi-56 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers.py:HeadersResponseHandler.action"
],
"edited_modules": [
"gabbi/handlers.py:HeadersResponseHandler"
]
},
"file": "gabbi/handlers.py"
}
] | cdent/gabbi | f2a32ad31bc205580834f009f05586a533f390f7 | case-insensitive headers
As far as I can tell, gabbi enforces lowercase headers:
```yaml
response_headers:
content-type: text/html; charset=utf-8
```
```
... ✓ front page returns HTML
```
vs.
```yaml
response_headers:
Content-Type: text/html; charset=utf-8
```
```
... E front page return... | diff --git a/gabbi/handlers.py b/gabbi/handlers.py
index f754d94..d39a987 100644
--- a/gabbi/handlers.py
+++ b/gabbi/handlers.py
@@ -120,6 +120,8 @@ class HeadersResponseHandler(ResponseHandler):
test_key_value = {}
def action(self, test, header, value):
+ header = header.lower() # case-insensitive ... |
cdent__gabbi-59 | [
{
"changes": {
"added_entities": [
"gabbi/case.py:HTTPTestCase._replacer_regex"
],
"added_modules": null,
"edited_entities": [
"gabbi/case.py:HTTPTestCase._environ_replace",
"gabbi/case.py:HTTPTestCase._environ_replacer",
"gabbi/case.py:HTTPTestCase._heade... | cdent/gabbi | ad9c7d1743576979ae96a74469937afcb980b5af | magical variables enforce single quotes
One of my tests contained the following line:
```yaml
url: $RESPONSE["$._links.next"]
```
That refused to work - it took me quite a while to figure out that's because gabbi seems to only accept single quotes there, as this worked just fine.
```yaml
url: $RESPONSE['$._... | diff --git a/gabbi/case.py b/gabbi/case.py
index 50b8815..2be6949 100644
--- a/gabbi/case.py
+++ b/gabbi/case.py
@@ -153,7 +153,7 @@ class HTTPTestCase(testcase.TestCase):
def _environ_replace(self, message):
"""Replace an indicator in a message with the environment value."""
- value = re.sub(r"\... |
cdent__gabbi-61 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"gabbi/handlers.py:HeadersResponseHandler.action"
],
"edited_modules": [
"gabbi/handlers.py:HeadersResponseHandler"
]
},
"file": "gabbi/handlers.py"
}
] | cdent/gabbi | 081a75f5f0ddfdc31c4bab62db2f084a50c9ee99 | missing response header raises error rather than failure
The following reports an error when it should report a failure instead:
```yaml
tests:
- name: failure
url: http://google.com
status: 302
response_headers:
x-foo: bar
```
AFAICT that's because internally a `KeyError` is rais... | diff --git a/gabbi/handlers.py b/gabbi/handlers.py
index d39a987..0b7a71d 100644
--- a/gabbi/handlers.py
+++ b/gabbi/handlers.py
@@ -128,9 +128,9 @@ class HeadersResponseHandler(ResponseHandler):
try:
response_value = response[header]
except KeyError:
- # Reform KeyError to som... |
cdent__paste-44 | [
{
"changes": {
"added_entities": [
"paste/fixture.py:TestApp.head"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"paste/fixture.py:TestApp"
]
},
"file": "paste/fixture.py"
},
{
"changes": {
"added_entities": null,... | cdent/paste | 1cc7e73f9980618f620d8e176858fe8f59ed03fc | gzip middleware adds a HTTP body when it shouldn't (e.g., HEAD requests)
The [HTTP specification says](https://tools.ietf.org/html/rfc7231#section-4.3.2):
> the server MUST NOT send a message body in the response (i.e., the response terminates at the end of the header section)
Even if the WSGI app is careful abou... | diff --git a/paste/fixture.py b/paste/fixture.py
index 4b88718..9f175fb 100644
--- a/paste/fixture.py
+++ b/paste/fixture.py
@@ -299,6 +299,18 @@ class TestApp(object):
extra_environ=extra_environ,status=status,
upload_files=None, expect_errors=expect_... |
cdent__wsgi-intercept-35 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "wsgi_intercept/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wsgi_inte... | cdent/wsgi-intercept | 3048a0921675822f5f27567d63ecca094077dc25 | kwarg error when $http_proxy is set in environ
```bash
$ echo $http_proxy
some_proxy.com:1234
```
and run the [requests example](http://wsgi-intercept.readthedocs.org/en/latest/requests.html), I got this error:
```
Traceback (most recent call last):
File "test.py", line 20, in <module>
resp = requests.get... | diff --git a/wsgi_intercept/__init__.py b/wsgi_intercept/__init__.py
index 487cd76..b659d75 100644
--- a/wsgi_intercept/__init__.py
+++ b/wsgi_intercept/__init__.py
@@ -50,6 +50,11 @@ Note especially that ``app_create_fn`` is a *function object* returning a WSGI
application; ``script_name`` becomes ``SCRIPT_NAME`` in ... |
cdent__wsgi-intercept-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wsgi_intercept/__init__.py:wsgi_fake_socket.makefile"
],
"edited_modules": [
"wsgi_intercept/__init__.py:wsgi_fake_socket"
]
},
"file": "wsgi_intercept/__init__.py"
}... | cdent/wsgi-intercept | 21276926ff7f9f341c789dc48ddad1ad9785c429 | Write ignores response body when first item in iterable is an empty string
This line has a check for whether the first return value of the application function's returned iterable is falsey: https://github.com/cdent/wsgi-intercept/blob/ac5f41a/wsgi_intercept/__init__.py#L490
```python
try:
generator_data = Non... | diff --git a/wsgi_intercept/__init__.py b/wsgi_intercept/__init__.py
index 08b9a10..c257295 100644
--- a/wsgi_intercept/__init__.py
+++ b/wsgi_intercept/__init__.py
@@ -487,7 +487,7 @@ class wsgi_fake_socket:
for data in self.write_results:
self.output.write(data)
- if... |
cdgriffith__Box-240 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "box/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"box/box.py:Box.__new... | cdgriffith/Box | 15969213c521a43ad40f1b8067e55e514f02d825 | Support for tracking the box "namespace"
I have some nested Boxes using an overridden `__convert_and_store` in a subclass to convert values to an expected type (eg: I want all values to be an `int` or some other custom class). For that conversion, I would like to know the "namespace" of the Box/value in order to refere... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9fbd58f..1760874 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,10 +1,12 @@
Changelog
=========
-Version 6.2.0
+Version 7.0.0
-------------
* Adding support for properties and setters in subclasses (thanks to Serge Lu)
+* Adding way to track changes to the box (tha... |
cdown__srt-53 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"srt.py:TimestampParseError"
],
"edited_entities": [
"srt.py:srt_timestamp_to_timedelta"
],
"edited_modules": [
"srt.py:srt_timestamp_to_timedelta"
]
},
"file": "srt.py"
}
] | cdown/srt | 4709bccde76945e32793df125bdd228e3c15297c | srt is not robust to timestamps whose ms fields do not have exactly 3 digits
First off, awesome library -- I use this in one of my projects and have found it a delight to work with.
Perhaps this isn't an issue with srt but with improperly formatted srt files. Apparently, sometimes the millisecond field in some times... | diff --git a/srt.py b/srt.py
index b037419..2808627 100755
--- a/srt.py
+++ b/srt.py
@@ -11,18 +11,27 @@ import logging
import io
+class TimestampParseError(ValueError):
+ pass
+
+
log = logging.getLogger(__name__)
# "." is not technically valid as a delimiter, but many editors create SRT
# files with this... |
cdriehuys__django-simple-email-auth-15 | [
{
"changes": {
"added_entities": [
"email_auth/models.py:EmailAddress.send_verification_email"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"email_auth/models.py:EmailAddress"
]
},
"file": "email_auth/models.py"
}
] | cdriehuys/django-simple-email-auth | 59b2fabb69aba3bb2c26258cb3f83183d1f177f6 | Add utility method to send verification from EmailAddress instance
It would be nice to have a `send_verification` method on `EmailAddress` instances that would create a new `EmailVerification` instance and send the verification email. | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index c9b45ba..bb73d7c 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -2,6 +2,17 @@
Changelog
#########
+**************
+In Development
+**************
+
+Features
+========
+
+* #11: Added utility method ``EmailAddress.send_verification_email`` to
+ encapsulate the pr... |
cdriehuys__django-simple-email-auth-26 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"email_auth/models.py:EmailVerification.send_email"
],
"edited_modules": [
"email_auth/models.py:EmailVerification"
]
},
"file": "email_auth/models.py"
}
] | cdriehuys/django-simple-email-auth | c5a50423c349db750c1264665738cba10e2b6272 | The 'time_sent' field of the EmailVerification model is never populated
After using the `EmailVerification.send_email` method, I expect the `EmailVerification.time_sent` field to be populated and persisted, but it never is. | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 2434b01..0a6afeb 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -7,10 +7,18 @@ In Development
**************
Features
-* #6: Add `PasswordReset` model to facilitate password resets using verified
+========
+
+* #6: Add ``PasswordReset`` model to facilitate passwor... |
cdriehuys__django-simple-email-auth-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"email_auth/authentication.py:VerifiedEmailBackend.authenticate"
],
"edited_modules": [
"email_auth/authentication.py:VerifiedEmailBackend"
]
},
"file": "email_auth/auth... | cdriehuys/django-simple-email-auth | 6799972ab642486b35e08c11c744efdfb8658eee | Authentication fails for invalid email/password combo
Attempting to authenticate with an invalid email/password combo causes a server error. | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 36b195d..02e278d 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -2,6 +2,16 @@
Changelog
#########
+******
+v0.3.1
+******
+
+Bug Fixes
+=========
+
+* :issue:`30`: Fix error when attempting to authenticate an invalid
+ email/password combination.
+
******
v0.3.... |
cdriehuys__django-simple-email-auth-45 | [
{
"changes": {
"added_entities": [
"email_auth/interfaces/rest/serializers.py:PasswordResetRequestSerializer.save",
"email_auth/interfaces/rest/serializers.py:PasswordResetSerializer.save",
"email_auth/interfaces/rest/serializers.py:PasswordResetSerializer.validate"
],
... | cdriehuys/django-simple-email-auth | 10d86497e3e7e72db785f16ab09773a78283a4b4 | Add endpoints for resetting a password
As a user of the API, I would like to be able to reset my password if I forget it.
### Acceptance
1. Sending a `POST` request to `/password-reset-requests/` with an email address should send a new password reset token to that email address if the email address has been verif... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 1ec9e5e..8cbae66 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -16,6 +16,7 @@ Features
interface.
* :issue:`38`: Add endpoint to resend a verification email to the provided REST
interface.
+* :issue:`39`: Add endpoints to request a password reset and reset a p... |
ceb10n__pydantic-settings-aws-25 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pydantic_settings_aws/aws.py:_create_boto3_client"
],
"edited_modules": [
"pydantic_settings_aws/aws.py:_create_boto3_client"
]
},
"file": "pydantic_settings_aws/aws.py... | ceb10n/pydantic-settings-aws | c8aca4e4597d379a6111deff2bb4cd989b4ec106 | Add boto3 client cache
Add boto3 client cache to same service, region and account | diff --git a/pydantic_settings_aws/aws.py b/pydantic_settings_aws/aws.py
index 6ee7b82..f862433 100644
--- a/pydantic_settings_aws/aws.py
+++ b/pydantic_settings_aws/aws.py
@@ -12,6 +12,8 @@ AWSService = Literal["ssm", "secretsmanager"]
ClientParam = Literal["secrets_client", "ssm_client"]
+_client_cache: Dict[str... |
ceb10n__pydantic-settings-aws-26 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "pydantic_settings_aws/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"py... | ceb10n/pydantic-settings-aws | d89b088a7f7c635f391f1667471a0ccd524ad716 | Create mixed settings (SSM, Secrets and other builtin) | diff --git a/pydantic_settings_aws/__init__.py b/pydantic_settings_aws/__init__.py
index 48af907..32bac88 100644
--- a/pydantic_settings_aws/__init__.py
+++ b/pydantic_settings_aws/__init__.py
@@ -1,6 +1,14 @@
-from .settings import ParameterStoreBaseSettings, SecretsManagerBaseSettings
+from .settings import (
+ AW... |
cekit__cekit-203 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker.py:DockerBuilder.__init__",
"cekit/builders/docker.py:DockerBuilder.check_prerequisities",
"cekit/builders/docker.py:DockerBuilder.build"
],
"edited_mod... | cekit/cekit | 4b1e853c7718adcc5cc98f380cc8067fa30c8d24 | Add support for rhpkg-stage
We currently have support only for `rhpkg` command. We need to support `rhpkg-stage` too. This will help us using the stage environment to test cekit. This should be done probably using a switch, maybe `--build-osbs-stage`? | diff --git a/cekit/builders/docker.py b/cekit/builders/docker.py
index 12abd71..25fbd22 100644
--- a/cekit/builders/docker.py
+++ b/cekit/builders/docker.py
@@ -13,6 +13,7 @@ class DockerBuilder(Builder):
"""This class wraps docker build command to build and image"""
def __init__(self, build_engine, target,... |
cekit__cekit-220 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.__init__",
"cekit/builders/osbs.py:OSBSBuilder.build"
],
"edited_modules": [
"cekit/builders/osbs.py:OSBSBuilder"
]
},
"file"... | cekit/cekit | da759627a7591993df8eb24778e2dd9ea39ae917 | Add support for overriding target in OSBS builder
We should be able to override the build target using the `--target` parameter to `rhpkg`. | diff --git a/bash_completion/cekit b/bash_completion/cekit
index efdb39c..e1465c3 100755
--- a/bash_completion/cekit
+++ b/bash_completion/cekit
@@ -20,6 +20,7 @@ _cekit_build_options()
options+='--build-osbs-user '
options+='--build-osbs-nowait '
options+='--build-osbs-stage '
+ options+='--build-osb... |
cekit__cekit-226 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/cli.py:Cekit.parse",
"cekit/cli.py:Cekit.run"
],
"edited_modules": [
"cekit/cli.py:Cekit"
]
},
"file": "cekit/cli.py"
}
] | cekit/cekit | 7067fb770515c44b28d661fddb5d0f25f706baf3 | Make it possible to specify where dist-git repositories should be cloned
It is important so we do not reuse the same directories when running in parallel. | diff --git a/bash_completion/cekit b/bash_completion/cekit
index e1465c3..ec29995 100755
--- a/bash_completion/cekit
+++ b/bash_completion/cekit
@@ -7,6 +7,7 @@ _cekit_global_options()
options+='--overrides '
options+='--target '
options+='--descriptor '
+ options+='--work-dir '
echo "$options"
... |
cekit__cekit-323 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder.build"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/docker_builde... | cekit/cekit | 6a7fbc5e7bf675fedd137d4c5f58064084a627ef | AttributeError: 'Module' object has no attribute 'version' with certain module dependency graph
Given this stripped-down example of inter-dependent modules, that looks like this:
:
logger.info("Building container image...")
try:
- la... |
cekit__cekit-336 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:Chdir.__init__",
"cekit/builders/osbs.py:Chdir.__enter__",
"cekit/builders/osbs.py:Chdir.__exit__"
],
"edited_modules": [
"cekit/builders/osbs.... | cekit/cekit | b5cc9546adb0a4285628f407abf43c0c5f660470 | Test results are no longer output to target directory
results and output directories are now collocated with the image.yaml file, where they used to be in target/test | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 674c81b..7c4e950 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -11,6 +11,7 @@ from cekit.config import Config
from cekit.builder import Builder
from cekit.descriptor.resource import _PlainResource
from cekit.errors import CekitE... |
cekit__cekit-373 | [
{
"changes": {
"added_entities": [
"cekit/template_helper.py:TemplateHelper.packages_to_install"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"cekit/template_helper.py:TemplateHelper"
]
},
"file": "cekit/template_helper.py"
... | cekit/cekit | 92f0cc5494eb43e939a4cc6060cb705ffb550772 | Make sure we execute cleanup after installing any packages
We need to ensure that YUM/DNF cleanup is executed when we install any packages.
Related to #83 and probably to #343 too. | diff --git a/cekit/template_helper.py b/cekit/template_helper.py
index 9e61cd0..d0eccc9 100644
--- a/cekit/template_helper.py
+++ b/cekit/template_helper.py
@@ -10,6 +10,25 @@ class TemplateHelper(object):
def module(self, to_install):
return self._module_registry.get_module(to_install.name, to_install.ve... |
cekit__cekit-397 | [
{
"changes": {
"added_entities": [
"cekit/builders/osbs.py:OSBSBuilder._wait_for_osbs_task"
],
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.__init__",
"cekit/builders/osbs.py:OSBSBuilder.dependencies",
"cekit/builders/osb... | cekit/cekit | dcb561650f177a800208c89e62d029d5ed9cc912 | Failed OSBS build should fail execution
Currently the return code is `0`, we should throw an exception. | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 252c446..38f2b1d 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -1,11 +1,18 @@
import glob
+import json
import logging
import os
import shutil
import subprocess
import sys
+import time
import yaml
+try:
+ from urllib.par... |
cekit__cekit-403 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.build"
],
"edited_modules": [
"cekit/builder.py:Builder"
]
},
"file": "cekit/builder.py"
},
{
"changes": {
"added_entities": [
... | cekit/cekit | fa598149c33ecc9828ea5a51936953e1ca13b844 | Make it possible to disable squashing
The #329 PR added support for automatic squashing, we should be able to disable it in some cases, leaving the original image untouched for investigation purposes. | diff --git a/cekit/builder.py b/cekit/builder.py
index 4f4ff2c..a96dbe4 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -38,5 +38,5 @@ class Builder(object):
# we dont require prepare to be implemented by builder
pass
- def build(self, build_args):
- raise CekitError("Buider.build(... |
cekit__cekit-416 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.prepare"
],
"edited_modules": [
"cekit/builders/osbs.py:OSBSBuilder"
]
},
"file": "cekit/builders/osbs.py"
}
] | cekit/cekit | 465639868991cca6a6db532623d7ef5d538675d0 | OSBS builder doesn't work well with plain artifacts with target set
It uses the `name` attribute instead of `target` if available. | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 38f2b1d..9048a3d 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -116,11 +116,11 @@ class OSBSBuilder(Builder):
self.dist_git.clean()
# First get all artifacts that are not plain artifacts
- self.artifacts ... |
cekit__cekit-417 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/tools.py:get_brew_url"
],
"edited_modules": [
"cekit/tools.py:get_brew_url"
]
},
"file": "cekit/tools.py"
}
] | cekit/cekit | 93fc5628cbbf65bc31c40e0a6a42f0f2ff1ee2bf | Handle deleted artifacts in koji
When an artifact is deleted we should not try to fetch it. Instead the build should be terminated. | diff --git a/cekit/tools.py b/cekit/tools.py
index e5f8e52..624434a 100644
--- a/cekit/tools.py
+++ b/cekit/tools.py
@@ -83,6 +83,20 @@ def get_brew_url(md5):
get_build_cmd = ['brew', 'call', '--json-output', 'getBuild', 'buildInfo=%s' % build_id]
logger.debug("Executing '%s'" % " ".join(get_build_cmd... |
cekit__cekit-424 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/cache/artifact.py:ArtifactCache.__init__",
"cekit/cache/artifact.py:ArtifactCache._get_cache",
"cekit/cache/artifact.py:ArtifactCache._update_cache",
"cekit/cache/artifact.... | cekit/cekit | 214db7be49d0c5b5fadac18d4cdac356e6a6c90a | Review caching
- [x] `cekit-cache` command without parameters prints nothing
- [x] Caching local file should not use involve usage of cacher, even if defined
- [x] Error handling - in case an error occurs while caching artifact, leftovers should be cleaned up.
- [x] Artifact added to cache should have computed check... | diff --git a/.pylintrc b/.pylintrc
index a2c5df1..ad93845 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -1,5 +1,5 @@
[MESSAGES CONTROL]
-disable=logging-format-interpolation,logging-not-lazy,useless-object-inheritance
+disable=logging-format-interpolation,logging-not-lazy,useless-object-inheritance,invalid-name,missing-do... |
cekit__cekit-428 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/cache/artifact.py:ArtifactCache.__init__",
"cekit/cache/artifact.py:ArtifactCache._get_cache",
"cekit/cache/artifact.py:ArtifactCache._update_cache",
"cekit/cache/artifact.... | cekit/cekit | 214db7be49d0c5b5fadac18d4cdac356e6a6c90a | Update bash and zsh completions for new CLI
Related to #412. | diff --git a/.pylintrc b/.pylintrc
index a2c5df1..ad93845 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -1,5 +1,5 @@
[MESSAGES CONTROL]
-disable=logging-format-interpolation,logging-not-lazy,useless-object-inheritance
+disable=logging-format-interpolation,logging-not-lazy,useless-object-inheritance,invalid-name,missing-do... |
cekit__cekit-429 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/descriptor/resource.py:Resource.__substitute_cache_url",
"cekit/descriptor/resource.py:_PlainResource._copy_impl"
],
"edited_modules": [
"cekit/descriptor/resource.py:R... | cekit/cekit | e966acf8d03e6252aa5d866bc70f147588e0005a | Plain artifacts and cache_url does not work well together
```
2019-02-20 19:56:43,514 cekit INFO Preparing resource 'hawkular-javaagent'
2019-02-20 19:56:43,540 cekit DEBUG Trying to download artifact hawkular-javaagent from remote cache
Traceback (most recent call last):
File "/usr/lib/python... | diff --git a/cekit/descriptor/resource.py b/cekit/descriptor/resource.py
index b506057..2917776 100644
--- a/cekit/descriptor/resource.py
+++ b/cekit/descriptor/resource.py
@@ -156,16 +156,19 @@ class Resource(Descriptor):
def __substitute_cache_url(self, url):
cache = config.get('common', 'cache_url')
... |
cekit__cekit-430 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/buildah.py:BuildahBuilder.run"
],
"edited_modules": [
"cekit/builders/buildah.py:BuildahBuilder"
]
},
"file": "cekit/builders/buildah.py"
},
{
"c... | cekit/cekit | e966acf8d03e6252aa5d866bc70f147588e0005a | Remove support for old type repostitories
Triggered by #385. The deprecation message is there for a while, we can safely remove support for it.
```
2019-02-14 09:50:20,632 cekit WARNING The way of defining repository 'jboss-os' is deprecated. Convert it to an URL based repository object. Consult Cekit docs,... | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3ed99b9..f2bfe90 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1,6 +1,6 @@
version: 2
jobs:
- build:
+ test:
parallelism: 4
machine:
image: circleci/classic:201808-01
@@ -28,3 +28,32 @@ jobs:
if [[ "${CIRCL... |
cekit__cekit-432 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/cache/artifact.py:ArtifactCache.__init__",
"cekit/cache/artifact.py:ArtifactCache._get_cache",
"cekit/cache/artifact.py:ArtifactCache._update_cache",
"cekit/cache/artifact.... | cekit/cekit | 214db7be49d0c5b5fadac18d4cdac356e6a6c90a | Enhance CI to build docs
As part of CI build (for PR) we should also build documentation. Files should be saved as artifacts to check them later. Additionally this will ensure that documentation is still building. | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3ed99b9..f2bfe90 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -1,6 +1,6 @@
version: 2
jobs:
- build:
+ test:
parallelism: 4
machine:
image: circleci/classic:201808-01
@@ -28,3 +28,32 @@ jobs:
if [[ "${CIRCL... |
cekit__cekit-440 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/buildah.py:BuildahBuilder.run"
],
"edited_modules": [
"cekit/builders/buildah.py:BuildahBuilder"
]
},
"file": "cekit/builders/buildah.py"
},
{
"c... | cekit/cekit | aa3e124359eb089837ba3f026dfbc5a5068fed29 | Building images with Podman does not tag the resulting image
```
$ podman images
REPOSITORY TAG IMAGE ID CREATED SIZE
<none> <none> 6fee3d0b86b6 37 seconds ago 253 MB
``` | diff --git a/cekit/builders/buildah.py b/cekit/builders/buildah.py
index 004e543..111b77b 100644
--- a/cekit/builders/buildah.py
+++ b/cekit/builders/buildah.py
@@ -30,6 +30,9 @@ class BuildahBuilder(Builder):
tags = self.params.tags
cmd = ["/usr/bin/buildah", "build-using-dockerfile"]
+ if n... |
cekit__cekit-443 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder._tag"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/docker_builder... | cekit/cekit | 5309dda6a70ce24ab275ff5d3e6acfbcf72e407c | Docker builder does not tag built image with all advertised tags
```
2019-03-12 20:05:28,393 cekit INFO Image built and available under following tags: example/rhel8:1.0, example/rhel8:latest
2019-03-12 20:05:28,393 cekit INFO Finished!
```
But the image is available under `example/rhel8:lat... | diff --git a/cekit/builders/docker_builder.py b/cekit/builders/docker_builder.py
index f3896fd..5bccc72 100644
--- a/cekit/builders/docker_builder.py
+++ b/cekit/builders/docker_builder.py
@@ -161,7 +161,7 @@ class DockerBuilder(Builder):
return squash.run()
def _tag(self, docker_client, image_id, tags)... |
cekit__cekit-446 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"cekit/cli.py:Cekit"
]
},
"file": "cekit/cli.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": ... | cekit/cekit | 980fc1874dfeebe25f56c3edd84e29f9aa6d2529 | Update documentation for artifacts definition
Make it clear what keys are required and what are optional. | diff --git a/cekit/cli.py b/cekit/cli.py
index 6de2472..5fd8f2f 100644
--- a/cekit/cli.py
+++ b/cekit/cli.py
@@ -258,7 +258,7 @@ def run_command(ctx, clazz):
def run_test(ctx, tester):
if tester == 'behave':
- from cekit.test.behave import BehaveTester as tester_impl
+ from cekit.test.behave_teste... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.