instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
cekit__cekit-452 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/tools.py:DependencyHandler.__init__"
],
"edited_modules": [
"cekit/tools.py:DependencyHandler"
]
},
"file": "cekit/tools.py"
}
] | cekit/cekit | b97aded6a433222d79fcbbc4823c33f82c56a473 | ValueError: dictionary update sequence element #12 has length 1; 2 is required
With [this image source](https://github.com/jmtd/openjdk/tree/rhel8-2k19) (branch rhel8-2k19, commit 503685f9621f91183a1d9fcfcf65cbe8f5745b84) and [this module cloned locally](https://github.com/jmtd/cct_module/tree/rhel82k19) (branch rhel82... | diff --git a/cekit/tools.py b/cekit/tools.py
index 04a779c..4c9bd05 100644
--- a/cekit/tools.py
+++ b/cekit/tools.py
@@ -158,7 +158,8 @@ class DependencyHandler(object):
with open(os_release_path, 'r') as f:
content = f.readlines()
- self.os_release = dict(l.strip().split('=')... |
cekit__cekit-493 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.run"
],
"edited_modules": [
"cekit/builders/osbs.py:OSBSBuilder"
]
},
"file": "cekit/builders/osbs.py"
},
{
"changes": {
... | cekit/cekit | 84247e0535849fd12857b42697e1d1dfc80ea788 | Modules and packages defined in overrides are ignored
**Describe the bug**
When modules are defined in overrides, these are ignored.
* the modules to install variable were always empty unless you define the modules on the root image.yaml file.
* The packages install was also being ignored.
But if you define at ... | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 56ec962..f735056 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -257,7 +257,7 @@ class OSBSBuilder(Builder):
# Get the url of the repository
url = subprocess.check_output(
- ["git", "remote... |
cekit__cekit-494 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.run"
],
"edited_modules": [
"cekit/builders/osbs.py:OSBSBuilder"
]
},
"file": "cekit/builders/osbs.py"
}
] | cekit/cekit | 84247e0535849fd12857b42697e1d1dfc80ea788 | error: Unknown subcommand: get-url when performing an OSBS build
**Describe the bug**
Cekit 3.0.0 dies with a python backtrace when attempting an OSBS build (see logs below)
**To reproduce**
[this image source](github.com/jmtd/openjdk), branch CLOUD-2868-RHEL8-JDK11 with [this cct_modules cloned into the checkout]... | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 56ec962..f735056 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -257,7 +257,7 @@ class OSBSBuilder(Builder):
# Get the url of the repository
url = subprocess.check_output(
- ["git", "remote... |
cekit__cekit-507 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder._tag"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/docker_builder... | cekit/cekit | 3b9283cb26b35511517ff5c0c3e11f490cba8feb | Expired krb sessions don't fail the build
```
2019-05-01 01:27:34,395 cekit DEBUG Executing '/usr/bin/brew call --json-output listArchives checksum=cd68ad886a759d21f8dd0cb7646601ee type=maven'.
2019-05-01 01:27:35,812 [ERROR] koji: AuthError: unable to obtain a session
2019-05-01 01:27:35,858 cekit ... | diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md
index 00a9d47..ece94c5 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.md
+++ b/.github/ISSUE_TEMPLATE/bug_report.md
@@ -2,7 +2,7 @@
name: Bug report
about: Found issue? Let us know!
title: ''
-labels: type/bug
+labels: type/bug,... |
cekit__cekit-509 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.update_osbs_image_source",
"cekit/builders/osbs.py:OSBSBuilder.update_lookaside_cache",
"cekit/builders/osbs.py:DistGit.prepare",
"cekit/builde... | cekit/cekit | 6b82c4adc0e2e1d2ddda66305c1c9abe7b91f407 | help.md not added with OSBS builder
If I add the following to my image definition
```help:
add: true```
I can see the help.md generated and added in `target/image` with the "docker" builder, but it does not turn up in my dist-git repository with the osbs builder. | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index f735056..808c404 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -140,12 +140,11 @@ class OSBSBuilder(Builder):
if os.path.exists("container.yaml"):
self._merge_container_yaml("container.yaml",
... |
cekit__cekit-510 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder._tag"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/docker_builder... | cekit/cekit | 6b82c4adc0e2e1d2ddda66305c1c9abe7b91f407 | docker build cannot handle more than one colon passed to the --tag option
**Describe the bug**
When passing more than one colon in the value for docker --tag, cekit will throw an error. This bug does not exist in 2.7, but does in 3.0.
**To reproduce**
This will fail:
`cekit build --overrides-file branch-overrides... | diff --git a/cekit/builders/docker_builder.py b/cekit/builders/docker_builder.py
index 8addd4e..74347bf 100644
--- a/cekit/builders/docker_builder.py
+++ b/cekit/builders/docker_builder.py
@@ -162,7 +162,7 @@ class DockerBuilder(Builder):
def _tag(self, docker_client, image_id, tags):
for tag in tags:
... |
cekit__cekit-516 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder._build_with_docker"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/... | cekit/cekit | dd522634604932a105166ed9674d3a4f58a2384b | Python library client should be used to request ODCS composes
**Describe the solution you'd like**
Currently we use the `odcs` CLI but we should use the Python library to have much cleaner integration.
**Additional context**
None
| diff --git a/.circleci/config.yml b/.circleci/config.yml
index a3ba614..d543756 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -5,6 +5,7 @@ jobs:
machine:
image: circleci/classic:201808-01
steps:
+ - run: sudo apt-get install libkrb5-dev
- checkout
- run: docker vers... |
cekit__cekit-518 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder._build_with_docker"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/... | cekit/cekit | dd522634604932a105166ed9674d3a4f58a2384b | Can't build docker image using MacOSX
**Describe the bug**
The failure occurs during docker build phase. Seems an issue in the way docker output is formatted.
During cekit build docker I am getting:
2019-05-22 11:15:56,272 cekit ERROR ('Image build failed, see logs above.', ParserError())
CekitError: ... | diff --git a/cekit/builders/docker_builder.py b/cekit/builders/docker_builder.py
index 74347bf..5ac381d 100644
--- a/cekit/builders/docker_builder.py
+++ b/cekit/builders/docker_builder.py
@@ -86,32 +86,41 @@ class DockerBuilder(Builder):
docker_args['path'] = os.path.join(self.target, 'image')
docker... |
cekit__cekit-519 | [
{
"changes": {
"added_entities": [
"cekit/builders/osbs.py:OSBSBuilder.copy_to_dist_git"
],
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.prepare",
"cekit/builders/osbs.py:OSBSBuilder.prepare_dist_git",
"cekit/builders/osb... | cekit/cekit | 715f6335931ade5883ef1829b6c857f9bbd4fa91 | Add support for supplementary dist-git items
We have a use case for committing another yaml file for CVP (gating.yaml) which would currently be ignored by cekit, is it possible to add capabilities within cekit to define a list of supplementary items that would be synced to the dist-git at runtime? Or at the very least,... | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 808c404..8d01362 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -19,7 +19,7 @@ from cekit.config import Config
from cekit.builder import Builder
from cekit.descriptor.resource import _PlainResource
from cekit.errors import CekitE... |
cekit__cekit-523 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/generator/base.py:Generator.add_build_labels"
],
"edited_modules": [
"cekit/generator/base.py:Generator"
]
},
"file": "cekit/generator/base.py"
}
] | cekit/cekit | 715f6335931ade5883ef1829b6c857f9bbd4fa91 | Labels with a very large value break container builds
**Describe the bug**
If the image.yaml descriptor has a very huge label value it will make cekit build fails (tested with docker and osbs and podman).
Apparently, the label string value are being parsed to bytes somewhere and this issue happens:
https://pasteb... | diff --git a/cekit/generator/base.py b/cekit/generator/base.py
index 3029050..318c38a 100644
--- a/cekit/generator/base.py
+++ b/cekit/generator/base.py
@@ -2,6 +2,7 @@
import logging
import os
+import re
import platform
import shutil
@@ -116,6 +117,11 @@ class Generator(object):
# was used to build th... |
cekit__cekit-532 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/tools.py:get_brew_url"
],
"edited_modules": [
"cekit/tools.py:get_brew_url"
]
},
"file": "cekit/tools.py"
}
] | cekit/cekit | 9455ee0b01c68cddb5aaad1fa1dbe8a85f0fb1f3 | Dots in artifact names cause issues in generating proper fetch-artifacts-url.yaml file
**Describe the bug**
When an artifact contains dot in the name and it is used
in the fetch-artifacts-url.yaml, the generated URL
is wrong and instead of preserving the dot it is converted to a slash.
Example artifact that is c... | diff --git a/cekit/tools.py b/cekit/tools.py
index cba0a21..32e6567 100644
--- a/cekit/tools.py
+++ b/cekit/tools.py
@@ -122,7 +122,7 @@ def get_brew_url(md5):
url = 'http://download.devel.redhat.com/brewroot/packages/' + package + '/' + \
version.replace('-', '_') + '/' + release + '/maven/' + \
... |
cekit__cekit-540 | [
{
"changes": {
"added_entities": [
"cekit/builder.py:Command.before_run",
"cekit/builder.py:Command.after_run",
"cekit/builder.py:Builder.before_run"
],
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.execute",
"cekit/builder.... | cekit/cekit | 1477fa22e9d9257e50096c208ee77f37838709bb | Disabling content sets using YAML null values is not possible
**Describe the solution you'd like**
The yaml's remove character is not accepted by CEKit thus not possible to remove a property from the image.yaml using overrides file.
Example: given the following image.yaml file:
```yaml
schema_version: 1
nam... | diff --git a/cekit/builder.py b/cekit/builder.py
index 7b2b163..c03bf46 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -29,10 +29,15 @@ class Command(object):
def prepare(self):
pass
+ def before_run(self):
+ pass
+
def run(self):
raise CekitError(
"Command.... |
cekit__cekit-543 | [
{
"changes": {
"added_entities": [
"cekit/builder.py:Command.before_run",
"cekit/builder.py:Command.after_run",
"cekit/builder.py:Builder.before_run"
],
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.execute",
"cekit/builder.... | cekit/cekit | 95f20e5d4307a361152589c0a22e6d1b1611b02c | When OSBS builder is exeuted with --dry-run we should not clone dist-git repository
**Describe the solution you'd like**
Currently the dist-git repository is cloned even if we specify `--dry-run`. We should refrain from doing it. It should be cloned only when a regular run is executed.
**Additional context**
None.... | diff --git a/cekit/builder.py b/cekit/builder.py
index 7b2b163..c03bf46 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -29,10 +29,15 @@ class Command(object):
def prepare(self):
pass
+ def before_run(self):
+ pass
+
def run(self):
raise CekitError(
"Command.... |
cekit__cekit-579 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/tools.py:DependencyHandler.handle_core_dependencies"
],
"edited_modules": [
"cekit/tools.py:DependencyHandler"
]
},
"file": "cekit/tools.py"
}
] | cekit/cekit | c145339f0881a46cb94e1289d8f733f7c6604320 | Try to detect certifi package installs and warn user if custom installation is found
The certifi library when installed locally provides a custom certificate store that can override the globally provided setting. We should try to find if certifi is installed and if yes, we should warn the user that certificate-related ... | diff --git a/cekit/tools.py b/cekit/tools.py
index a53b9ec..9aaba1e 100644
--- a/cekit/tools.py
+++ b/cekit/tools.py
@@ -352,6 +352,14 @@ class DependencyHandler(object):
self._handle_dependencies(
DependencyHandler.EXTERNAL_CORE_DEPENDENCIES)
+ try:
+ import certifi # pylint:... |
cekit__cekit-603 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.prepare"
],
"edited_modules": [
"cekit/builder.py:Builder"
]
},
"file": "cekit/builder.py"
},
{
"changes": {
"added_entities": nu... | cekit/cekit | 818ffb328fe4232fc39304bbba69cfa3a6eb5eaa | Remove --tech-preview OSBS builder switch
**Describe the solution you'd like**
It was deprecated in 3.4 and scheduled to be removed in 3.5. It's time to do it.
| diff --git a/cekit/builder.py b/cekit/builder.py
index 51e0610..39f0c5f 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -85,10 +85,6 @@ class Builder(Command):
"(http://docs.cekit.io/en/latest/handbook/overrides.html) to adjust the koji " +
"target, '--koj... |
cekit__cekit-622 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.prepare"
],
"edited_modules": [
"cekit/builder.py:Builder"
]
},
"file": "cekit/builder.py"
},
{
"changes": {
"added_entities": nu... | cekit/cekit | 3c6cb845a04c83a334da425745221726484dc95c | Modules should use name instead of git repository name + ref
We need the directory containing the features (copied to target/test) to be deterministic and not bound to the kind of module repo acces (GIT vs local file system).
The name of the module should be used when creating the directory.
An example usage in t... | diff --git a/cekit/builder.py b/cekit/builder.py
index 39f0c5f..2b6bac3 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -80,11 +80,6 @@ class Builder(Command):
self.params.target,
self.params.overrides)
- if self.params.g... |
cekit__cekit-624 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.prepare"
],
"edited_modules": [
"cekit/builder.py:Builder"
]
},
"file": "cekit/builder.py"
},
{
"changes": {
"added_entities": nu... | cekit/cekit | 3c6cb845a04c83a334da425745221726484dc95c | Remove --koji-target OSBS builder switch
**Describe the solution you'd like**
The `--koji-target` switch was deprecated in 3.5. We need to remove it in 3.6.
| diff --git a/cekit/builder.py b/cekit/builder.py
index 39f0c5f..2b6bac3 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -80,11 +80,6 @@ class Builder(Command):
self.params.target,
self.params.overrides)
- if self.params.g... |
cekit__cekit-633 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/descriptor/image.py:Image.apply_image_overrides"
],
"edited_modules": [
"cekit/descriptor/image.py:Image"
]
},
"file": "cekit/descriptor/image.py"
},
{
"c... | cekit/cekit | 74df8c5258a3e843a82aa9ffa4b7c94781ee3433 | content_sets (or content_sets_file) cannot be overridden
cekit 3.5.0
With [this image.yaml](https://github.com/jmtd/openjdk/blob/97a8819e36d861c8421acfd4000d763942003c16/image.yaml#L37), using `content_sets_file`, and [this override](https://github.com/jmtd/openjdk/blob/97a8819e36d861c8421acfd4000d763942003c16/rhel8... | diff --git a/cekit/descriptor/image.py b/cekit/descriptor/image.py
index 2409120..e782f47 100644
--- a/cekit/descriptor/image.py
+++ b/cekit/descriptor/image.py
@@ -228,40 +228,17 @@ class Image(Descriptor):
module_repositories[name] = repository
self.modules._descriptor['repositories'... |
cekit__cekit-634 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/descriptor/osbs.py:Configuration.__init__"
],
"edited_modules": [
"cekit/descriptor/osbs.py:Configuration"
]
},
"file": "cekit/descriptor/osbs.py"
},
{
"c... | cekit/cekit | 74df8c5258a3e843a82aa9ffa4b7c94781ee3433 | the git "ref:" argument should accept a valid git reference
**Describe the bug**
cekit permits specifying a git ref for a module, but this does not translate into a git ref underneath, but must actually be a tag or branch name (valid argument to `git clone -b`). It would be nicer if this could be a real git ref (e.g... | diff --git a/cekit/descriptor/osbs.py b/cekit/descriptor/osbs.py
index dcd23b5..dfee1da 100644
--- a/cekit/descriptor/osbs.py
+++ b/cekit/descriptor/osbs.py
@@ -98,7 +98,6 @@ class Configuration(Descriptor):
self.schema = configuration_schema
self.descriptor_path = descriptor_path
super(Confi... |
cekit__cekit-636 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/generator/base.py:ModuleRegistry.get_module"
],
"edited_modules": [
"cekit/generator/base.py:ModuleRegistry"
]
},
"file": "cekit/generator/base.py"
}
] | cekit/cekit | 378208f15f138999b18f3ade603a755a77e8de8c | cekit (-v) warns about missing module version for a dependency
**Describe the bug**
Cekit (in verbose mode) complains (WARNING) about a missing module version, for a module dependency, and chooses a default version. But in practise the most common way to depend upon a module is version-less. So this is very noisy.
... | diff --git a/cekit/generator/base.py b/cekit/generator/base.py
index 85ed250..d79739b 100644
--- a/cekit/generator/base.py
+++ b/cekit/generator/base.py
@@ -526,7 +526,7 @@ class ModuleRegistry(object):
default_module = self.get_module(name, default_version)
- if not suppress_warnings:
+ ... |
cekit__cekit-713 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/cli.py:cli",
"cekit/cli.py:Cekit.init"
],
"edited_modules": [
"cekit/cli.py:cli",
"cekit/cli.py:Cekit"
]
},
"file": "cekit/cli.py"
},
{
"c... | cekit/cekit | d0bc8a13f3bff25431c09dc1e4c7e5689d8ab1df | Support disabling color in logs
**Describe the solution you'd like**
This would be useful for recording logs that don't support the colour codes.
Internal ref : CPAAS-1520
**Additional context**
We should look into supporting https://no-color.org/ | diff --git a/cekit/cli.py b/cekit/cli.py
index 7ce327f..4878825 100644
--- a/cekit/cli.py
+++ b/cekit/cli.py
@@ -13,22 +13,22 @@ from cekit.log import setup_logging
from cekit.tools import Map
from cekit.version import __version__
-# FIXME we should try to move this to json
-setup_logging()
LOGGER = logging.getLog... |
cekit__cekit-736 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:DistGit.clean"
],
"edited_modules": [
"cekit/builders/osbs.py:DistGit"
]
},
"file": "cekit/builders/osbs.py"
},
{
"changes": {
"add... | cekit/cekit | ca7384c7f8f902c2994a684dd0241a2fde52094d | Start using fetch-artifacts-pnc
**Describe the solution you'd like**
CEKit should start generated fetch artifacts configurations using [fetch-artifacts-pnc](https://osbs.readthedocs.io/en/latest/users.html#fetch-artifacts-pnc-yaml). This new mechanism offers close integration with PNC and can fetch artifacts as well a... | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index bcedf4f..938d8ca 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -416,6 +416,10 @@ class DistGit(object):
LOGGER.info("Removing old 'fetch-artifacts-url.yaml' file")
subprocess.check_call(["git", "rm... |
cekit__cekit-803 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder.dependencies"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/docker... | cekit/cekit | 8462a81c711cbade1b59aa84cf5e773ff62bca7d | dependency handling references python2 dependencies
Similar to https://github.com/cekit/behave-test-steps/issues/40 there are references to Python2 dependencies e.g.
```
deps["python-docker"] = {
"library": "docker",
"package": "python-docker-py",
"fedora": {"package": "... | diff --git a/cekit/builders/docker_builder.py b/cekit/builders/docker_builder.py
index 903ffa5..38c59c3 100644
--- a/cekit/builders/docker_builder.py
+++ b/cekit/builders/docker_builder.py
@@ -53,8 +53,8 @@ class DockerBuilder(Builder):
deps["python-docker"] = {
"library": "docker",
- ... |
cekit__cekit-842 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.prepare"
],
"edited_modules": [
"cekit/builder.py:Builder"
]
},
"file": "cekit/builder.py"
},
{
"changes": {
"added_entities": nu... | cekit/cekit | 839980c36c939d9f53fcea913c84925c54048953 | Support Containerfile as output
Currently only `Dockerfile` is generated. For podman and buildah `Containerfile` is natively supported. Docker supports it via the `-f` syntax. OSBS only supports `Dockerfile`.
I would suggest we provide an option to generate `Containerfile` instead of `Dockerfile`.
We could also c... | diff --git a/cekit/builder.py b/cekit/builder.py
index caab3df..c478f7f 100644
--- a/cekit/builder.py
+++ b/cekit/builder.py
@@ -78,25 +78,32 @@ class Builder(Command):
self.run()
def prepare(self) -> None:
- if (
- self.build_engine == "docker"
- or self.build_engine == "bu... |
cekit__cekit-845 | [
{
"changes": {
"added_entities": [
"cekit/builders/osbs.py:OSBSBuilder._establish_tag_name",
"cekit/builders/osbs.py:Git.__init__",
"cekit/builders/osbs.py:Git.tag",
"cekit/builders/osbs.py:Git.push"
],
"added_modules": [
"cekit/builders/osbs.py:Git"
... | cekit/cekit | a757928a2784400886a78753d983c6f86d785684 | Support maintaining repository tags for release builds
**Describe the solution you'd like**
We use cekit to build our container images. We publish container images from builds triggered by cekit. We would like to tag the container source repository to indicate which commits correspond to published images.
For ex... | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index 9b011ac..4b42669 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -40,7 +40,7 @@ class OSBSBuilder(Builder):
self._rhpkg_set_url_repos: List[str] = []
self.artifacts: List[str] = []
- self.dist_git: DistGit
... |
cekit__cekit-850 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "cekit/descriptor/env.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_mod... | cekit/cekit | f022ba3219175a9b061a149f3fdeba48eb1a87fc | Add new fields to module.yaml envs
We are doing some automation that uses module.yaml.
We would need need fields added to envs. Currently we only have name and description, we need required="true"|"false" and usage="build-time"|"execution-time".
| diff --git a/cekit/descriptor/env.py b/cekit/descriptor/env.py
index 036a4f4..5d7949b 100644
--- a/cekit/descriptor/env.py
+++ b/cekit/descriptor/env.py
@@ -6,7 +6,9 @@ from cekit.descriptor import Descriptor
env_schema = yaml.safe_load(
"""
-map:
+type: map
+allowempty: True
+mapping:
name: {type: str, requ... |
cekit__cekit-859 | [
{
"changes": {
"added_entities": [
"cekit/generator/base.py:internal_parse_version"
],
"added_modules": [
"cekit/generator/base.py:internal_parse_version"
],
"edited_entities": [
"cekit/generator/base.py:ModuleRegistry.add_module"
],
"edited_modu... | cekit/cekit | 3269a60ffd2ed7a46ddb17ad24d20f36bcc356fc | CEKit 4.6.0 and packaging upgrade incompatibility
@spolti has noticed that the packaging library changes has caused further issues.
This can be seen since 4.6.0 (4.5.0 doesn't exhibit these) produces a trace like:
```
File "/tmp/cekit/lib/python3.11/site-packages/cekit/cli.py", line 292, in build_osbs
ru... | diff --git a/cekit/generator/base.py b/cekit/generator/base.py
index 5b75fd5..211695a 100644
--- a/cekit/generator/base.py
+++ b/cekit/generator/base.py
@@ -10,7 +10,7 @@ from typing import TYPE_CHECKING, Any, Dict, List, Optional
from urllib.parse import urlparse
from jinja2 import Environment, FileSystemLoader
-f... |
cekit__cekit-874 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/buildah.py:BuildahBuilder.run"
],
"edited_modules": [
"cekit/builders/buildah.py:BuildahBuilder"
]
},
"file": "cekit/builders/buildah.py"
},
{
"c... | cekit/cekit | ef69585c8c145b049a2bfad741f191ffeb3ef78b | When using the --verbose flag also set the debug flag for rhpkg command
**Describe the solution you'd like**
It is useful to debug rhpkg issues, sometimes the error message might not he enough to understand what is happening.
**Additional context**
We hit a issue recently that the rhpkg returns just "None" in the... | diff --git a/cekit/builders/buildah.py b/cekit/builders/buildah.py
index d966a1a..d28b282 100644
--- a/cekit/builders/buildah.py
+++ b/cekit/builders/buildah.py
@@ -33,6 +33,9 @@ class BuildahBuilder(Builder):
if not self.params.no_squash:
cmd.append("--squash")
+ if self.params.trace:
+ ... |
cekit__cekit-877 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/cli.py:test_behave"
],
"edited_modules": [
"cekit/cli.py:test_behave"
]
},
"file": "cekit/cli.py"
}
] | cekit/cekit | 376b6630407f72238a18102e35602121828ed9be | expand `cekit test behave --steps-url` to additionally support selecting branch/ref
**Describe the solution you'd like**
`cekit test behave --steps-url` lets you specify an alternative Git repository from which to fetch behave-test-steps, replacing https://github.com/cekit/behave-test-steps.git
This is useful when... | diff --git a/cekit/cli.py b/cekit/cli.py
index dcbd360..6a4cb1e 100644
--- a/cekit/cli.py
+++ b/cekit/cli.py
@@ -13,7 +13,7 @@ from cekit.config import Config, default_work_dir
from cekit.errors import CekitError
from cekit.log import setup_logging
from cekit.tools import Map
-from cekit.version import __version__
+... |
cekit__cekit-893 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builder.py:Builder.before_generate"
],
"edited_modules": [
"cekit/builder.py:Builder"
]
},
"file": "cekit/builder.py"
},
{
"changes": {
"added_entit... | cekit/cekit | 28085ffa956a65589e59d3b9ade4cc60a76e5e74 | Dependency Handling with descriptor reference
This is a sequel to #696 / #701 ; if we instead we modify builder.py :: before_generate (L81) so that init is called _before_ `dependency_handler.handle` then we could pass the descriptor reference to the static `dependencies` method thereby allowing it to check for content... | diff --git a/Pipfile b/Pipfile
index 7d174a8..b24d716 100644
--- a/Pipfile
+++ b/Pipfile
@@ -19,6 +19,7 @@ autopep8 = "*"
isort = "*"
black = "*"
flake8 = ">3.6.0"
+"odcs[client]" = ">=0.2.10"
[packages]
pykwalify = ">=1.6.0"
@@ -26,7 +27,6 @@ colorlog = ">=2.10.0"
PyYAML = ">=3.10"
Jinja2 = ">=2.7"
click = "... |
cekit__cekit-913 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/docker_builder.py:DockerBuilder._docker_client"
],
"edited_modules": [
"cekit/builders/docker_builder.py:DockerBuilder"
]
},
"file": "cekit/builders/dock... | cekit/cekit | 962949a4ef3f0182d6dcc3d0f3e52db02539a962 | Allow to override the default timeout for OSBS builds
**Describe the solution you'd like**
There are some cases where the OSBS build can take a long time, specially when there is a long queue on the system.
It seems currently there is one non-documented `DOCKER_TIMEOUT` environment variable timeout, but there is no... | diff --git a/cekit/builders/docker_builder.py b/cekit/builders/docker_builder.py
index 1623160..e6b5b95 100644
--- a/cekit/builders/docker_builder.py
+++ b/cekit/builders/docker_builder.py
@@ -6,6 +6,7 @@ import traceback
from cekit.builder import Builder
from cekit.cekit_types import DependencyDefinition
from cekit... |
cekit__cekit-918 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cekit/builders/osbs.py:OSBSBuilder.dependencies"
],
"edited_modules": [
"cekit/builders/osbs.py:OSBSBuilder"
]
},
"file": "cekit/builders/osbs.py"
},
{
"changes... | cekit/cekit | 5efda67ad5f22c6647397cc2e7ce49bd337488bd | add authentication to artifacts
**Describe the solution you'd like**
I'm missing the possibility to add authentication (like tokens, username/password) when using artifacts in cekit. The option to use URL artifacts is pretty nice, if the repository is accessable without any authentication.
This would be a nice addi... | diff --git a/cekit/builders/osbs.py b/cekit/builders/osbs.py
index d9250c0..2f52eb8 100644
--- a/cekit/builders/osbs.py
+++ b/cekit/builders/osbs.py
@@ -62,7 +62,7 @@ class OSBSBuilder(Builder):
deps = {}
if CONFIG.get("common", "redhat"):
- if CONFIG.get("common", "stage"):
+ ... |
celery__billiard-230 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "billiard/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"billiard/heap.p... | celery/billiard | bfe2dc6387853595ef8877809c1404fe4959519d | multiple billiard.Value instances sharing the same state
**Problem description**
When using multiple instances of `billiard.Value` and changing one variable's value, the other one is changed as well. In the example below when I update the variable `value`, `done` is set to the same value as well. When replacing `bil... | diff --git a/CHANGES.txt b/CHANGES.txt
index 9e6c09e..e2366da 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -1,3 +1,16 @@
+3.5.0.3 - 2017-07-16
+--------------------
+
+- Adds Process._authkey alias to .authkey for 2.7 compat.
+- Remove superfluous else clause from max_memory_per_child_check.
+- Document and test all s... |
celery__billiard-372 | [
{
"changes": {
"added_entities": [
"billiard/einfo.py:ExceptionWithTraceback.__str__"
],
"added_modules": null,
"edited_entities": [
"billiard/einfo.py:ExceptionWithTraceback.__init__"
],
"edited_modules": [
"billiard/einfo.py:ExceptionWithTraceback"
... | celery/billiard | 69c576df48d062457baccc06a016d52356755133 | ExceptionWithTraceback object has no attribute __cause__
Platform: Windows
Python: 3.8.6
Celery: 5.3.0b1
billiard: 4.0.1
## Description
I have a celery task that raises `RuntimeError("requires pyicat-plus")`. In `celery.app.trace` the exception gets [logged](https://github.com/celery/celery/blob/feaad3f9fdf98d... | diff --git a/billiard/einfo.py b/billiard/einfo.py
index de385c0..640ddd8 100644
--- a/billiard/einfo.py
+++ b/billiard/einfo.py
@@ -91,16 +91,24 @@ class Traceback:
class RemoteTraceback(Exception):
def __init__(self, tb):
self.tb = tb
+
def __str__(self):
return self.tb
-class Exception... |
celery__kombu-1754 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "kombu/utils/json.py"
}
] | celery/kombu | ccd63ea2d21efc4f6aff7d087fbf087aa93a5f70 | bug: serializer does not accept all uuids
The new serializer introduced in #1575, fails when the payload contains uuids whose version are not within 1 and 5. In our case it starts failing because we have some UUIDs version 7.
This is because in line https://github.com/el-chogo/kombu/blob/6b89388870271e23c31f6c2845f2... | diff --git a/kombu/utils/json.py b/kombu/utils/json.py
index ec6269e2..ce1319ac 100644
--- a/kombu/utils/json.py
+++ b/kombu/utils/json.py
@@ -123,6 +123,6 @@ register_type(Decimal, "decimal", str, Decimal)
register_type(
uuid.UUID,
"uuid",
- lambda o: {"hex": o.hex, "version": o.version},
+ lambda o: ... |
celery__kombu-2016 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kombu/mixins.py:ConsumerMixin.consume"
],
"edited_modules": [
"kombu/mixins.py:ConsumerMixin"
]
},
"file": "kombu/mixins.py"
}
] | celery/kombu | eae75855e06887250399f793018f97cbd398c90b | ConsumerMixin consume method should not heartbeat if timeout None
<!--
Please fill this template entirely and do not erase parts of it.
We reserve the right to close without a response
enhancement requests which are incomplete.
-->
# Checklist
<!--
To check an item on the list replace [ ] with [x].
-->
- [x]... | diff --git a/kombu/mixins.py b/kombu/mixins.py
index 14c1c1b9..92acee98 100644
--- a/kombu/mixins.py
+++ b/kombu/mixins.py
@@ -195,10 +195,11 @@ class ConsumerMixin:
try:
conn.drain_events(timeout=safety_interval)
except socket.timeout:
- conn.he... |
celery__kombu-2024 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"kombu/connection.py:ConnectionPool.setup",
"kombu/connection.py:ChannelPool.setup"
],
"edited_modules": [
"kombu/connection.py:ConnectionPool",
"kombu/connection.py:C... | celery/kombu | e32f8fc39b3135eca2aa9d70a92e35c1c94b9406 | ConnectionPool can't be used after .resize(..., reset=True)
I close pool and then want to use it again. Reinit.
I found the `.resize()` method which has option `reset`. reset=True allow close all available connections and then `.setup()` will be called, but pool will be closed (`._closed=True`) and any `.acquire()` ... | diff --git a/kombu/connection.py b/kombu/connection.py
index 13b1e9e5..beec4c73 100644
--- a/kombu/connection.py
+++ b/kombu/connection.py
@@ -1065,7 +1065,8 @@ class ConnectionPool(Resource):
def setup(self):
if self.limit:
q = self._resource.queue
- while len(q) < self.limit:
+ ... |
celery__py-amqp-344 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"amqp/transport.py:SSLTransport._wrap_socket_sni"
],
"edited_modules": [
"amqp/transport.py:SSLTransport"
]
},
"file": "amqp/transport.py"
}
] | celery/py-amqp | 8e5ddd41b776f31faea6a47fcc757b76c567b007 | SSLTransport error: unexpected keyword argument 'ca_certs'
Using amqp version 5.0.1, I discovered an SSLTransport error. When I use amqp version 5.0.0b1, SSL works just fine.
Here's the error I get when using amqp==5.0.1:
`/usr/local/lib/python3.8/dist-packages/kombu/connection.py:283: in channel
chan = self... | diff --git a/amqp/transport.py b/amqp/transport.py
index 3eec88f..b183120 100644
--- a/amqp/transport.py
+++ b/amqp/transport.py
@@ -354,9 +354,9 @@ class SSLTransport(_AbstractTransport):
def _wrap_socket_sni(self, sock, keyfile=None, certfile=None,
server_side=False, cert_reqs=ssl.CER... |
celery__py-amqp-357 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"amqp/transport.py:SSLTransport._wrap_socket_sni"
],
"edited_modules": [
"amqp/transport.py:SSLTransport"
]
},
"file": "amqp/transport.py"
}
] | celery/py-amqp | 137245bc8cae3290cab20fbbbe03bb5916d237c9 | [BUG] Cannot set cert_reqs=ssl.CERT_NONE due to order of context modification in _wrap_socker_sni
Setting the [broker_use_ssl](https://docs.celeryproject.org/en/stable/userguide/configuration.html#broker-use-ssl) value in celery configuration to `{"cert_reqs": ssl.CERT_NONE}` is not respected. This occurs because of th... | diff --git a/AUTHORS b/AUTHORS
index d6628d4..cc03f59 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -24,3 +24,4 @@ ChangBo Guo(gcb) <eric.guo@easystack.cn>
Alan Justino <alan.justino@yahoo.com.br>
Jelte Fennema <github-tech@jeltef.nl>
Jon Dufresne <jon.dufresne@gmail.com>
+Colton Hicks <github@coltonhicks.com>
diff --git a/... |
celery__py-amqp-379 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"amqp/transport.py:_AbstractTransport.close"
],
"edited_modules": [
"amqp/transport.py:_AbstractTransport"
]
},
"file": "amqp/transport.py"
}
] | celery/py-amqp | be6b5ededa5654ca43cea67927667456e32523a3 | 5.0.7 SSL connection problem
After upgrade to the 5.0.7 celery workers are unable to connect to RabbitMQ (3.9.11) using SSL. Worker dies immediately after start and following exceptions are logged. Reverting to 5.0.6 solves the connection problem.
<pre>2021-12-15 07:31:14 [11] CRITICAL Unrecoverable error: Operation... | diff --git a/amqp/transport.py b/amqp/transport.py
index 177fb22..b87f9fe 100644
--- a/amqp/transport.py
+++ b/amqp/transport.py
@@ -272,7 +272,11 @@ class _AbstractTransport:
def close(self):
if self.sock is not None:
- self._shutdown_transport()
+ try:
+ self._shut... |
celery__py-amqp-431 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"amqp/transport.py:_AbstractTransport.__repr__"
],
"edited_modules": [
"amqp/transport.py:_AbstractTransport"
]
},
"file": "amqp/transport.py"
}
] | celery/py-amqp | ec138c279f9f4d38dcdfd973bac24a031f4793f9 | Potentially broken _AbstractTransport.__repr__
`_AbstractTransport.__repr__` (or `Connection.__repr__`) might crash.
In a report/issue from/in Sentry `self` was reported as "broken repr" in https://github.com/celery/py-amqp/blob/7300741f9fc202083e87abd10e1cb38c28efad92/amqp/transport.py#L352.
`_AbstractTransport.... | diff --git a/amqp/transport.py b/amqp/transport.py
index c915977..3d87e70 100644
--- a/amqp/transport.py
+++ b/amqp/transport.py
@@ -116,7 +116,10 @@ class _AbstractTransport:
def __repr__(self):
if self.sock:
src = f'{self.sock.getsockname()[0]}:{self.sock.getsockname()[1]}'
- dst... |
cerfacs-globc__icclim-258 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "icclim/_generated_api.py"
},
{
"changes": {
"added_entities": [
"icclim/generic_indices/generic_indicators.py:_is_a_diff_indicator",
... | cerfacs-globc/icclim | b93c8b14f74aff7d102cb6f61acd8d19811a40c0 | BUG: Unit handling for temperature difference indices
<!--
If you have encountered a problem while using icclim or you would like to suggest a change,
please follow the structure below to describe your request.
-->
<!-- import icclim; print(icclim.__version__) -->
<!-- import sys; print(sys.version) -->
* icclim ... | diff --git a/doc/source/_static/logo_icclim_colored__displayed.svg b/doc/source/_static/logo_icclim_colored__displayed.svg
index c3d52e8..de59981 100644
--- a/doc/source/_static/logo_icclim_colored__displayed.svg
+++ b/doc/source/_static/logo_icclim_colored__displayed.svg
@@ -1,3 +1,3 @@
version https://git-lfs.github... |
cerfacs-globc__icclim-283 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"icclim/generic_indices/generic_indicators.py:fraction_of_total"
],
"edited_modules": [
"icclim/generic_indices/generic_indicators.py:fraction_of_total"
]
},
"file": "ic... | cerfacs-globc/icclim | 091c4b3085d191df7fce0601b851730bc20bef12 | BUG: Problem with kg m-2 s-1 units for FractionOfTotal indicators
<!--
If you have encountered a problem while using icclim or you would like to suggest a change,
please follow the structure below to describe your request.
-->
<!-- import icclim; print(icclim.__version__) -->
<!-- import sys; print(sys.version) --... | diff --git a/icclim/generic_indices/generic_indicators.py b/icclim/generic_indices/generic_indicators.py
index b5b0843..ce6fd4c 100644
--- a/icclim/generic_indices/generic_indicators.py
+++ b/icclim/generic_indices/generic_indicators.py
@@ -412,10 +412,12 @@ def fraction_of_total(
) -> DataArray:
study, threshold... |
certbot__certbot-4740 | [
{
"changes": {
"added_entities": [
"certbot/log.py:MemoryHandler.close",
"certbot/log.py:MemoryHandler.flush",
"certbot/log.py:TempHandler.emit",
"certbot/log.py:pre_arg_parse_except_hook",
"certbot/log.py:post_arg_parse_except_hook"
],
"added_modules": ... | certbot/certbot | c5d11d333fdac8f2df3e2b0360df4daaa0a54a1a | Temporal files and dirs not removed from /tmp
Since certbot-auto 0.14.0, every time `certbot-auto renew --quiet` runs on my cron job it left behind a tmp file in /tmp.
Just an example:
```
-rw------- 1 root root 361 May 22 12:17 tmpzdqsnC
-rw------- 1 root root 361 May 22 18:17 tmptUuhXk
-rw------- 1 root... | diff --git a/certbot/log.py b/certbot/log.py
index c7bc867f1..889b5c50a 100644
--- a/certbot/log.py
+++ b/certbot/log.py
@@ -70,7 +70,8 @@ def pre_arg_parse_setup():
# close() are explicitly called
util.atexit_register(logging.shutdown)
sys.excepthook = functools.partial(
- except_hook, debug='--d... |
certbot__certbot-5687 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"acme/acme/client.py:ClientBase._revoke"
],
"edited_modules": [
"acme/acme/client.py:ClientBase"
]
},
"file": "acme/acme/client.py"
}
] | certbot/certbot | e0ae356aa35adf22d154113e06dd01409df93bba | `acme` module's `client._revoke` sends incorrect `ContentType` header.
[ACME draft-10, section 6.2](https://tools.ietf.org/html/draft-ietf-acme-acme-10#section-6.2) explicitly requires POSTs be sent with a `Content-Type` of `application/jose+json`:
> Because client requests in ACME carry JWS objects in the Flattene... | diff --git a/acme/acme/client.py b/acme/acme/client.py
index d52c82a5c..9e2478afe 100644
--- a/acme/acme/client.py
+++ b/acme/acme/client.py
@@ -227,8 +227,7 @@ class ClientBase(object): # pylint: disable=too-many-instance-attributes
response = self._post(url,
messages.Revocatio... |
certbot__certbot-5992 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"acme/acme/client.py:ClientNetwork.__init__",
"acme/acme/client.py:ClientNetwork._send_request"
],
"edited_modules": [
"acme/acme/client.py:ClientNetwork"
]
},
"... | certbot/certbot | 907ee797151f270bec3a2697743568362db497cd | HTTP responses logged as hard-to-read bytes repr in Python 3
If you're having trouble using Certbot and aren't sure you've found a bug or
request for a new feature, please first try asking for help at
https://community.letsencrypt.org/. There is a much larger community there of
people familiar with the project who w... | diff --git a/acme/acme/client.py b/acme/acme/client.py
index 7807f0ece..bdc07fb1c 100644
--- a/acme/acme/client.py
+++ b/acme/acme/client.py
@@ -12,7 +12,9 @@ from six.moves import http_client # pylint: disable=import-error
import josepy as jose
import OpenSSL
import re
+from requests_toolbelt.adapters.source impor... |
certbot__certbot-6377 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"acme/acme/messages.py:Order",
"acme/acme/messages.py:NewOrder"
]
},
"file": "acme/acme/messages.py"
},
{
"changes": {
"added_entities": ... | certbot/certbot | 3de3188dd6fe4c8c9952848c155a56944b55ec2d | Put a README in /etc/letsencrypt/live
In addition to putting a README in /etc/letsencrypt/live/example.com, a lot of people work directly in /etc/letsencrypt/live, so we should probably put a README in there telling people not to move certs. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5dd51ef16..20e82b5d7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,7 +10,8 @@ Certbot adheres to [Semantic Versioning](http://semver.org/).
### Changed
-* `--manual` will explicitly warn users that earlier challenges should remain in place when setting up subse... |
certbot__certbot-6536 | [
{
"changes": {
"added_entities": [
"acme/acme/client.py:ClientV2.external_account_required",
"acme/acme/client.py:BackwardsCompatibleClientV2.external_account_required"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"acme/acme/client.... | certbot/certbot | 37d4b983c8abea179874b7d7c83d7dc8f4e41d0b | Conditionally depend on sphinx imgconverter?
This is needed in Sphinx>=1.6, but Sphinx this new may not be available in older distros. Can we configure Sphinx to work with both versions by conditionally depending on imgconverter? Is there another approach we can take entirely?
The relevant PR here is https://github.... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4b10a5805..6d9447ae2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -9,6 +9,8 @@ Certbot adheres to [Semantic Versioning](http://semver.org/).
* Noninteractive renewals with `certbot renew` (those not started from a
terminal) now randomly sleep 1-480 seconds before be... |
certbot__certbot-6602 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "acme/acme/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"certbot/cli.py... | certbot/certbot | 6b145a480ef19309c84bfecc61465571172a4f3f | Pin all dependency installation in the release script
This would prevent changes to our dependencies causing `tools/release.sh` to blow up in the middle of a release. This might be as simple as changing calls to `pip install` to `tools/pip_install.py`, but it requires some testing. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index a0c6f0eb2..c6fac76fe 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,13 +17,17 @@ Certbot adheres to [Semantic Versioning](http://semver.org/).
### Fixed
-*
+* Older modules in the josepy library can now be accessed through acme.jose
+ like it could in previous v... |
certbot__certbot-6766 | [
{
"changes": {
"added_entities": [
"certbot/auth_handler.py:AuthHandler._poll_authorizations",
"certbot/auth_handler.py:_report_failed_authzrs"
],
"added_modules": [
"certbot/auth_handler.py:_report_failed_authzrs"
],
"edited_entities": [
"certbot/au... | certbot/certbot | c7f8f15e9b6c51d67f28af96c84d35b814ba2f73 | Certbot should respect Retry-After when polling authzs | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3eea1923d..764fc0946 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,9 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
* The running of manual plugin hooks is now always included in Certbot's log
output.
* Tests execution for certbot, certb... |
certbot__certbot-6788 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"certbot/hooks.py:_run_pre_hook_if_necessary",
"certbot/hooks.py:post_hook",
"certbot/hooks.py:run_saved_post_hooks",
"certbot/hooks.py:_run_deploy_hook",
"certbot/hooks.p... | certbot/certbot | b10ceb7d907cdcc36ec2d745e7802127919ec043 | Log doesn't mention hook scripts being called
## My operating system is (include version):
Debian unstable
## I installed Certbot with (certbot-auto, OS package manager, pip, etc):
certbot 0.11.1 from Debian unstable
## I ran this command and it produced this output:
certbot renew with lots of --verbose... and... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7744e3745..ce7eac2e9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,8 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
warnings described at https://github.com/certbot/josepy/issues/13.
* Apache plugin now respects CERTBOT_DOCS environment v... |
certbot__certbot-6794 | [
{
"changes": {
"added_entities": [
"certbot/auth_handler.py:AuthHandler._poll_authorizations",
"certbot/auth_handler.py:_report_failed_authzrs"
],
"added_modules": [
"certbot/auth_handler.py:_report_failed_authzrs"
],
"edited_entities": [
"certbot/au... | certbot/certbot | a468a3b255e326dbfa2b7d629eb20fa275631254 | certbot-auto initial bootstrap fails on openSUSE; attempts to install invalid 'python-virtualenv' *src* package
With release certbot-auto
```
wget https://dl.eff.org/certbot-auto
chmod a+x ./certbot-auto
```
1st exec
```
./certbot-auto --version --verbose
```
on openSUSE* bootstraps
```
...
Bootstr... | diff --git a/.travis.yml b/.travis.yml
index 108f853aa..4adab1e4e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -18,11 +18,6 @@ branches:
- /^\d+\.\d+\.x$/
- /^test-.*$/
-# Since master can receive only commits from PR that have already been tested, we avoid with the
-# the following condition to launch aga... |
certbot__certbot-7095 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"certbot/renewal.py:_restore_webroot_config"
],
"edited_modules": [
"certbot/renewal.py:_restore_webroot_config"
]
},
"file": "certbot/renewal.py"
}
] | certbot/certbot | bf818036eb4f23164f92800b9ea83591149c0814 | Certbot drops webroot options from renewal configuration file
To reproduce this, I think you need Certbot 0.31.0+ and an ACME server that reuses authorizations.
## I ran this command and it produced this output:
Here is each command and the renewal configuration file it produces.
The plugin used first here is ... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3cc3ff41f..8669d34a5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -16,12 +16,14 @@ Certbot adheres to [Semantic Versioning](https://semver.org/).
### Fixed
-*
+* Renewal parameter `webroot_path` is always saved, avoiding some regressions
+ when `webroot` authentic... |
certbot__certbot-7270 | [
{
"changes": {
"added_entities": [
"certbot/compat/filesystem.py:is_executable",
"certbot/compat/filesystem.py:_win_is_executable"
],
"added_modules": [
"certbot/compat/filesystem.py:is_executable",
"certbot/compat/filesystem.py:_win_is_executable"
],
... | certbot/certbot | e6bf3fe7f81ff7651b3e8be3d530be725090ed2c | Fix remaining broken tests on Windows
When I started to port Certbot on Windows, a lot of unit tests or the logic tested by them were not working on this platform.
In order to still have a working CI during the port, all failing tests where marked with a temporary decorator, `@broken_on_windows` to skip their execut... | diff --git a/.codecov.yml b/.codecov.yml
index f4d4d1d6c..8a1503da8 100644
--- a/.codecov.yml
+++ b/.codecov.yml
@@ -13,6 +13,6 @@ coverage:
flags: windows
# Fixed target instead of auto set by #7173, can
# be removed when flags in Codecov are added back.
- target: 97.2
+ target... |
cevans87__atools-23 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"atools/memoize_decorator.py:_MemoizeState.make_key",
"atools/memoize_decorator.py:_MemoizeState.get_memo"
],
"edited_modules": [
"atools/memoize_decorator.py:_MemoizeState"
... | cevans87/atools | 5667eef829897574b59a23787fc281c8bf55688d | Memoize decorator keeps input objects alive while cached
The hash key created to memoize function calls is a tuple of the inputs. It should instead be a hash of that tuple so that none of the objects in the tuple are accidentally kept from being garbage collected. | diff --git a/atools/memoize_decorator.py b/atools/memoize_decorator.py
index 1e54ea3..e757e35 100644
--- a/atools/memoize_decorator.py
+++ b/atools/memoize_decorator.py
@@ -6,7 +6,7 @@ from datetime import timedelta
import inspect
from time import time
from threading import Lock as SyncLock
-from typing import Any, ... |
cevans87__atools-35 | [
{
"changes": {
"added_entities": [
"atools/_memoize_decorator.py:_Memoize.__call__",
"atools/_memoize_decorator.py:_Memoize.reset_all",
"atools/_memoize_decorator.py:_Memoize.set_default_db_path"
],
"added_modules": [
"atools/_memoize_decorator.py:_Memoize"
... | cevans87/atools | 84813d73106ad59ab4def34e7b337f50df8bddb0 | Allow global override of default_db_path in memoize decorator
If we enable override of the default_db_path, we can make memoize decorators look a little cleaner. So, rather than something like
```
db_path = Path.cwd() / 'foo_db'
@memoize(db=db_path)
def foo(): ...
@memoize(db=db_path)
def bar() ...
def _... | diff --git a/atools/_memoize_decorator.py b/atools/_memoize_decorator.py
index 9aeaa97..62b064c 100644
--- a/atools/_memoize_decorator.py
+++ b/atools/_memoize_decorator.py
@@ -16,8 +16,6 @@ from typing import Any, Callable, Hashable, Mapping, Optional, Tuple, Type, Unio
Decoratee = Union[Callable, Type]
Keygen = Cal... |
cevans87__atools-39 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"atools/_memoize_decorator.py:_MemoizeBase.__post_init__",
"atools/_memoize_decorator.py:_MemoizeBase.finalize_memo"
],
"edited_modules": [
"atools/_memoize_decorator.py:_Memo... | cevans87/atools | 04ef3fc45c951ad09aa07f346e4272d371d078d6 | Use function return type-hint in `eval` when memoize deserializes from db.
For example
```
@memoize(db=True)
def foo() -> pathlib.Path:
...
```
This cannot currently be stored and deserialized from the memoize db since we currently only allow deserialization of `__builtins__`. Allowing `__builtins__` _plus_ t... | diff --git a/atools/_memoize_decorator.py b/atools/_memoize_decorator.py
index 783caf2..3b0c7ab 100644
--- a/atools/_memoize_decorator.py
+++ b/atools/_memoize_decorator.py
@@ -10,7 +10,7 @@ from sqlite3 import connect, Connection
from textwrap import dedent
from time import time
from threading import Lock as SyncLo... |
cevans87__atools-44 | [
{
"changes": {
"added_entities": [
"atools/_memoize_decorator.py:_MemoizeBase.get_args_as_kwargs"
],
"added_modules": null,
"edited_entities": [
"atools/_memoize_decorator.py:_MemoizeBase.default_keygen",
"atools/_memoize_decorator.py:_AsyncMemoize.get_key",
... | cevans87/atools | ef5ba0a45ac3fd8a0370e7db41c0acdc90354165 | memoize keygen breaks when caller omits keyword args with defaults
Ex
```
@memoize(keygen=lambda bar: bar)
def foo(bar=None):
...
foo(None) # Works fine
foo() # Results in `TypeError: <lambda>() missing 1 required positional argument: 'bar'` | diff --git a/atools/_memoize_decorator.py b/atools/_memoize_decorator.py
index ac7e47b..ffe8028 100644
--- a/atools/_memoize_decorator.py
+++ b/atools/_memoize_decorator.py
@@ -123,11 +123,14 @@ class _MemoizeBase:
def default_keygen(self, *args, **kwargs) -> Tuple[Hashable, ...]:
"""Returns all params ... |
cevans87__atools-52 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"atools/_memoize_decorator.py:_Memoize.__call__",
"atools/_memoize_decorator.py:_Memoize.set_default_db_path"
],
"edited_modules": [
"atools/_memoize_decorator.py:_Memoize"
... | cevans87/atools | f3f59a757ba3894b68b1b49cb9860c989deacf5e | Remove `memoize.set_default_db_path` function
The `memoize.set_default_db_path` function is difficult to use correctly as is. It requires that you call the default before anyone using the decorator actually applies it. AKA, you have to call the function before importing any code that applies the memoize decorator. This... | diff --git a/README.md b/README.md
index 30b3966..04e017b 100644
--- a/README.md
+++ b/README.md
@@ -210,7 +210,7 @@ Python 3.6+ decorators including
- Values can persist to disk and be reloaded when memoize is initialized again.
- @memoize(db=True)
+ @memoize(db_path=Path.home() / '.... |
cevans87__atools-57 | [
{
"changes": {
"added_entities": [
"atools/_memoize_decorator.py:_AsyncMemoize.get_behavior",
"atools/_memoize_decorator.py:_AsyncMemoize.insert",
"atools/_memoize_decorator.py:_AsyncMemoize.update",
"atools/_memoize_decorator.py:_AsyncMemoize.upsert",
"atools/_memo... | cevans87/atools | f8f4a83bbd91a83de2470f0286c8e43a4c7d3cdc | add `memoize.update().to()`
It might be nice to have a mechanism to update the return value of a memo. I keep using memoize with db to save monotonically increasing ids. The general code goes as follows.
```python3
id = 0
@memoize_db
def get_id() -> int:
return id
id = get_id()
if should_inc_id:
i... | diff --git a/atools/_memoize_decorator.py b/atools/_memoize_decorator.py
index 6b1b91e..7700beb 100644
--- a/atools/_memoize_decorator.py
+++ b/atools/_memoize_decorator.py
@@ -11,7 +11,7 @@ from sqlite3 import connect, Connection
from textwrap import dedent
from time import time
from threading import Lock as SyncLo... |
cevoaustralia__aws-google-auth-203 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aws_google_auth/__init__.py:parse_args",
"aws_google_auth/__init__.py:process_auth"
],
"edited_modules": [
"aws_google_auth/__init__.py:parse_args",
"aws_google_auth/... | cevoaustralia/aws-google-auth | d473d67b0772700942f5bb0db3522af0a1005453 | Cannot login: MFA stopped working, then took wrong choice
I signed in no problem on 2020-10-12, but today, 2020-10-13 I cannot sign in because MFA does not work. Looks like Google changed something. Note that `saml2aws` also [stopped working](https://github.com/Versent/saml2aws/issues/568).
Here are the requests (pa... | diff --git a/README.rst b/README.rst
index 59c258e..1fe975f 100644
--- a/README.rst
+++ b/README.rst
@@ -119,7 +119,7 @@ Usage
[--bg-response BG_RESPONSE]
[--saml-assertion SAML_ASSERTION] [--no-cache]
[--print-creds] [--resolve-aliases... |
cevoaustralia__aws-google-auth-34 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aws_google_auth/__init__.py:cli",
"aws_google_auth/__init__.py:_store"
],
"edited_modules": [
"aws_google_auth/__init__.py:cli",
"aws_google_auth/__init__.py:_store"
... | cevoaustralia/aws-google-auth | eb991c78bf4e96c30add65f0520b281f916a31ad | Running twice results in malformed credentials file
On Ubuntu with version 0.0.12. Two runs of aws-google-auth results in ~/.aws/credentials with two "[None]" sections. The config parser of aws-cli throws error configparser.DuplicateSectionError. | diff --git a/README.rst b/README.rst
index fe68570..bac4d06 100644
--- a/README.rst
+++ b/README.rst
@@ -110,7 +110,8 @@ Usage
-d DURATION, --duration DURATION
Credential duration ($DURATION)
-p PROFILE, --profile PROFILE
- AWS profile ($AWS_PROFILE)... |
cevoaustralia__aws-google-auth-67 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"aws_google_auth/configuration.py:Configuration.max_duration"
],
"edited_modules": [
"aws_google_auth/configuration.py:Configuration"
]
},
"file": "aws_google_auth/confi... | cevoaustralia/aws-google-auth | 7840706fb3b10dc45bcf829ff31c45d7e324e551 | Max duration for a session can be increased to 12h
The limit was recently increased on the AWS side: https://aws.amazon.com/about-aws/whats-new/2018/03/longer-role-sessions/ | diff --git a/aws_google_auth/configuration.py b/aws_google_auth/configuration.py
index ce02aa3..270cb5e 100644
--- a/aws_google_auth/configuration.py
+++ b/aws_google_auth/configuration.py
@@ -44,7 +44,7 @@ class Configuration(object):
@property
def max_duration(self):
- return 3600
+ return 4... |
cevoaustralia__aws-google-auth-71 | [
{
"changes": {
"added_entities": [
"aws_google_auth/__init__.py:cli"
],
"added_modules": [
"aws_google_auth/__init__.py:cli"
],
"edited_entities": [
"aws_google_auth/__init__.py:main"
],
"edited_modules": [
"aws_google_auth/__init__.py:ma... | cevoaustralia/aws-google-auth | 390e181516b02baf55bdf67296fe3437e7c8904a | main() takes exactly 1 argument (0 given)
I'm getting the following error, introduced in 48d22e4d62bb6e216cd8932739ea0be4735e2588 (Determined by `git bisect`). I don't have the time to dig right now, but I will later.
```
$ aws-google-auth --help
Traceback (most recent call last):
File "/Users/mide/virtualenv/... | diff --git a/aws_google_auth/__init__.py b/aws_google_auth/__init__.py
index 0ec8126..2163356 100644
--- a/aws_google_auth/__init__.py
+++ b/aws_google_auth/__init__.py
@@ -51,7 +51,7 @@ def exit_if_unsupported_python():
sys.exit(1)
-def main(cli_args):
+def cli(cli_args):
try:
exit_if_unsupp... |
cf-natali__ntplib-22 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"ntplib.py:NTPRolloverException"
],
"edited_entities": [
"ntplib.py:system_to_ntp_time"
],
"edited_modules": [
"ntplib.py:system_to_ntp_time"
]
},
"file": "ntplib.py"
}
] | cf-natali/ntplib | 1e4542873a37f539a927f4bd65ee3521a4d2551f | Very inaccurate client fails to request NTP data
When the client thinks the current time is after the year 2037, the library fails to make an NTP request.
This can be easily demonstrated using [the faketime library](https://packages.debian.org/stable/faketime):
```pytb
$ faketime '2037-01-01 00:00:00' python3 -c... | diff --git a/CHANGELOG b/CHANGELOG
index 9834bec..b9cdfd2 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,9 @@
+version 0.X.X - 2022-XX-XX
+--------------------------
+- Add a new `NTPRolloverException` raised when system time is beyond NTPv3
+ rollover (https://en.wikipedia.org/wiki/Network_Time_Protocol#Timestamps... |
cgarwood__python-openzwave-mqtt-10 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"openzwavemqtt/base.py:ItemCollection.__init__",
"openzwavemqtt/base.py:ItemCollection.process_message",
"openzwavemqtt/base.py:ZWaveBase.__init__"
],
"edited_modules": [
... | cgarwood/python-openzwave-mqtt | 248ce41a6cf3d536a44282376ed88e2e6dd9e995 | Pass "parent" objects to children
Making issues for some items on the todo list in case anyone else wants to jump in with some code.
---
If we have an OZWValue object, we need an easy way to get to the OZWNode and OZWInstance objects that the value belongs to. Right now its easy to go from Instance > Node > Value, ... | diff --git a/openzwavemqtt/base.py b/openzwavemqtt/base.py
index bc529ea..a524c2b 100644
--- a/openzwavemqtt/base.py
+++ b/openzwavemqtt/base.py
@@ -1,5 +1,5 @@
from abc import ABC
-from typing import Callable, Deque
+from typing import Callable, Deque, Optional
from .const import EVENT_PLACEHOLDER, EMPTY, LOGGER
... |
cgarwood__python-openzwave-mqtt-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"openzwavemqtt/models/command_class.py:OZWCommandClass"
]
},
"file": "openzwavemqtt/models/command_class.py"
},
{
"changes": {
"added_entities": ... | cgarwood/python-openzwave-mqtt | aa4ba281c9750e9cdd4e07afcaf18dbc741b6a78 | Rename option `sent_message` to `send_message`
It is a typo 🤦♂ | diff --git a/openzwavemqtt/models/command_class.py b/openzwavemqtt/models/command_class.py
index 0b702fd..fac4637 100644
--- a/openzwavemqtt/models/command_class.py
+++ b/openzwavemqtt/models/command_class.py
@@ -15,6 +15,8 @@ class OZWCommandClass(OZWNodeChildBase):
EVENT_CHANGED = EVENT_COMMAND_CLASS_CHANGED
... |
cgarwood__python-openzwave-mqtt-32 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"openzwavemqtt/base.py:ItemCollection.process_message",
"openzwavemqtt/base.py:ZWaveBase.__init__"
],
"edited_modules": [
"openzwavemqtt/base.py:ItemCollection",
"open... | cgarwood/python-openzwave-mqtt | 399ee0aabb9fb814d636829483165ec949ed3983 | Convert item_id to int
All IDs are ints in OZW. We now extract the ID from the topic and pass them in as strins (`item_id`) to the constructor of `ZWaveBase`. We should convert these to integers as data posted to OZW topics will also refer to nodes as integers. Makes it easier on the consumer of this lib.
Conversio... | diff --git a/openzwavemqtt/base.py b/openzwavemqtt/base.py
index 350ef4a..1d2f426 100644
--- a/openzwavemqtt/base.py
+++ b/openzwavemqtt/base.py
@@ -31,7 +31,7 @@ class ItemCollection:
def process_message(self, topic: Deque[str], message: dict):
"""Process a new message."""
- item_id = topic.popl... |
chainer__chainerui-241 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "chainerui/models/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edite... | chainer/chainerui | 01fb7b56582d90f15ab928d2860fded7ec80b31e | Assets are not deleted
Even if a project is deleted, asset related with the project is remain on database. When register new project, results show remained assets, not new one.
I'll send a PR from https://github.com/disktnk/chainerui/tree/fix/asset-delete to fix it, after merge #214 , | diff --git a/chainerui/models/__init__.py b/chainerui/models/__init__.py
index d0dc9f0..77c7c1e 100644
--- a/chainerui/models/__init__.py
+++ b/chainerui/models/__init__.py
@@ -1,4 +1,6 @@
from chainerui.models.argument import Argument # NOQA
+from chainerui.models.asset import Asset # NOQA
+from chainerui.models.bi... |
chanzuckerberg__miniwdl-136 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"WDL/Tree.py:Workflow.available_inputs",
"WDL/Tree.py:Workflow.required_inputs",
"WDL/Tree.py:_decls_and_calls"
],
"edited_modules": [
"WDL/Tree.py:Workflow",
... | chanzuckerberg/miniwdl | ab96c3a475b04779c314a30125780c48aad86a9d | available_inputs returns output Decls
miniwdl version: V0.1.7
For older workflows (ie draft 2/3) or really any workflow which does not define an `input { ... }` section, the `available_outputs` will return the `output` declarations as well as any input declarations.
For example, calling `available_outputs` on:
... | diff --git a/WDL/Tree.py b/WDL/Tree.py
index a27ba2e..ad9f379 100644
--- a/WDL/Tree.py
+++ b/WDL/Tree.py
@@ -736,7 +736,7 @@ class Workflow(SourceNode):
for decl in self.inputs:
ans = Env.bind(ans, [], decl.name, decl)
- for elt in _decls_and_calls(self):
+ for elt in _decl... |
chanzuckerberg__miniwdl-242 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"WDL/Expr.py:Apply.__str__"
],
"edited_modules": [
"WDL/Expr.py:Apply"
]
},
"file": "WDL/Expr.py"
}
] | chanzuckerberg/miniwdl | db5214a93a9df0481af27360b481f9901cf897a1 | calling str() on some functions results in AttributeError: [...] object has no attribute 'name'
I just found a bug in my implementation of the `__str__` function for expressions (#215). For any functions which do not inherit the `StaticFunction` class the `name` attribute doesn't exist. Which will result in an error wh... | diff --git a/WDL/Expr.py b/WDL/Expr.py
index 40ec922..86b61ef 100644
--- a/WDL/Expr.py
+++ b/WDL/Expr.py
@@ -1031,9 +1031,9 @@ class Apply(Base):
return "{} && {}".format(arguments[0], arguments[1])
elif isinstance(func, StdLib._Or):
return "{} || {}".format(arguments[0], arguments[1]... |
chanzuckerberg__miniwdl-549 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"WDL/_parser.py:parse"
],
"edited_modules": [
"WDL/_parser.py:parse"
]
},
"file": "WDL/_parser.py"
}
] | chanzuckerberg/miniwdl | d50d97a9e263373d8d46610b2fdcc99b16059e49 | Lark parser's comments cache is not cleared when a syntax error occurs
This appears to cause an assertion error when loading multiple WDL workflows. The state ([comments cache](https://github.com/chanzuckerberg/miniwdl/blob/d50d97a9e263373d8d46610b2fdcc99b16059e49/WDL/_parser.py#L13)) is kept at the module level, so on... | diff --git a/WDL/_parser.py b/WDL/_parser.py
index 1705457..e9dda6d 100644
--- a/WDL/_parser.py
+++ b/WDL/_parser.py
@@ -16,19 +16,26 @@ _lark_lock = threading.Lock()
def parse(grammar: str, txt: str, start: str) -> Tuple[lark.Tree, List[lark.Token]]:
with _lark_lock:
- if (grammar, start) not in _lark_c... |
chaostoolkit-incubator__chaostoolkit-aws-106 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaosaws/asg/actions.py:detach_random_instances"
],
"edited_modules": [
"chaosaws/asg/actions.py:detach_random_instances"
]
},
"file": "chaosaws/asg/actions.py"
}
] | chaostoolkit-incubator/chaostoolkit-aws | f84c1a20cf5cbe0c13bbe266771c6fd8cfeca309 | asg.actions.detach_random_instances: also return IDs of detached instances
Referring to [asg.actions.detach_random_instances](https://github.com/chaostoolkit-incubator/chaostoolkit-aws/blob/0.16.0/chaosaws/asg/actions.py#L351), expected similar behavior to other `.*_random_.*` actions that return IDs of the randomly se... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9751079..94f6fe7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,7 @@
- adding put_metric_data to cloudwatch actions
### Changed
+- update return value of asg action detach_random_instances to include instance IDs
## [0.16.0][]
[0.16.0]: https://github.co... |
chaostoolkit-incubator__chaostoolkit-aws-26 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaosaws/ec2/actions.py:stop_instance",
"chaosaws/ec2/actions.py:get_instance_type_from_response",
"chaosaws/ec2/actions.py:get_spot_request_ids_from_response"
],
"edited_mod... | chaostoolkit-incubator/chaostoolkit-aws | 4ab02c19fd02f7c4105f4c5da48f2d70319eeb4d | Can't stop instances with explicit lifecycle
When an instance has no explicit lifecycle, the extension fails to stop it. This is usually the case of On-Demand or Reserved instances. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1cf8254..3e93e48 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,15 @@
[Unreleased]: https://github.com/chaostoolkit-incubator/chaostoolkit-aws/compare/0.7.1...HEAD
+### Changed
+
+- make sure instances with no explicit lifecycle can be stopped. They are
+ ... |
chaostoolkit__chaostoolkit-67 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaostoolkit/cli.py:cli",
"chaostoolkit/cli.py:run",
"chaostoolkit/cli.py:validate",
"chaostoolkit/cli.py:discover",
"chaostoolkit/cli.py:init"
],
"edited_mod... | chaostoolkit/chaostoolkit | f9f0b84a3e3a4243d24926a2cf9f433af1a07664 | Add a new argument to specify the path to the config file
While the default value is enough for generic cases, as soon as you want to embed the toolkit anywhere else, it is helpful to be able to provide a different path.
| diff --git a/.gitignore b/.gitignore
index 0de8567..1dacbf7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -114,4 +114,5 @@ output.png
chaos-report.json
discovery.json
journal.json
-chaostoolkit.log
\ No newline at end of file
+chaostoolkit.log
+.pytest_cache/
\ No newline at end of file
diff --git a/chaostoolkit/cli.p... |
chaostoolkit__chaostoolkit-lib-109 | [
{
"changes": {
"added_entities": [
"chaoslib/control/__init__.py:initialize_global_controls",
"chaoslib/control/__init__.py:cleanup_global_controls",
"chaoslib/control/__init__.py:get_global_controls"
],
"added_modules": [
"chaoslib/control/__init__.py:initializ... | chaostoolkit/chaostoolkit-lib | 257e059645e2998292066b160691acb154df0b45 | Enable global controls from the settings
It would be valuable to allow controls to be declared and defined in the settings and applied globally no matter the experiment. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3c26329..5e4ccfe 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,9 +10,12 @@
- Pass configuration to tolerance checks so that probe tolerance can access it
[#98][98]
- Fix using a probe as a tolerance validator [#98][98]
+- Make settings globally available during ... |
chaostoolkit__chaostoolkit-lib-117 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/caching.py:with_cache"
],
"edited_modules": [
"chaoslib/caching.py:with_cache"
]
},
"file": "chaoslib/caching.py"
},
{
"changes": {
"added_entiti... | chaostoolkit/chaostoolkit-lib | e49afa4e463e441316904850fc6986d35ee63dc8 | Pass configuration and settings to global controls
As per #99, controls loaded from the settings are not provided the experiment configuration and secrets. However, as per https://github.com/chaostoolkit/chaostoolkit-lib/issues/99#issuecomment-487628313, this could be handy and expected. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1f326ad..58d7ee9 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,18 @@
- Fix to ensure a control's `configuration` parameter is populated when it the
control is being `configured` [#114][114]
+- Load and apply global controls, those declared in the settings,... |
chaostoolkit__chaostoolkit-lib-224 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/provider/python.py:validate_python_activity"
],
"edited_modules": [
"chaoslib/provider/python.py:validate_python_activity"
]
},
"file": "chaoslib/provider/pyth... | chaostoolkit/chaostoolkit-lib | 00278203af3100b4f764098f49eaf666ea0fee9b | Invalid name reported in logs on Python provider validation
**Describe the bug**
Say you have the following probe:
```python
invalid_python_func_probe = {
"name": "hello",
"type": "probe",
"provider": {
"type": "python",
"module": "os",
"func": "... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index cb63fa5..49e1527 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,13 @@
## [Unreleased][]
+### Changed
+
+- Fix activity name in the logs shown when the Python provider links to an
+ unknown function [#223][223]
+
+[223]: https://github.com/chaostoolkit/chaost... |
chaostoolkit__chaostoolkit-lib-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/discovery/discover.py:discover_activities"
],
"edited_modules": [
"chaoslib/discovery/discover.py:discover_activities"
]
},
"file": "chaoslib/discovery/discove... | chaostoolkit/chaostoolkit-lib | 3656c8ec9185318d16f6ee7e0815bd9da52cad44 | Do not fail on discovery of module which don't export __all__
Right now the discovery mechanism expects module to have a `__all__` attribute. Do not fail when it is missing. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0af4aa2..c9591c2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,13 @@
[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/0.13.1...HEAD
+### Changed
+
+- Do not fail the discovery when an extension is missing the `__all__`
+ attribute ... |
chaostoolkit__chaostoolkit-lib-41 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "chaoslib/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/config... | chaostoolkit/chaostoolkit-lib | 80fb16cd50d4f6d761cf2c0c5919574d2972932c | Bail cleanly when environment key was not found
It appears the toolkit doesn't tell you when a key couldn't be found in the environment. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 54b1a3c..ff3263c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,7 +2,20 @@
## [Unreleased][]
-[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/0.15.0...HEAD
+[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/0.15.1...HEAD... |
chaostoolkit__chaostoolkit-lib-53 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/activity.py:execute_activity"
],
"edited_modules": [
"chaoslib/activity.py:execute_activity"
]
},
"file": "chaoslib/activity.py"
},
{
"changes": {
... | chaostoolkit/chaostoolkit-lib | 85c2926bef4dd22ebf1b310da3a173d4fcdb83a3 | Migrate FailedActivity exception to ActivityFailed | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ade7eac..f54b037 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,12 @@
[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/0.19.0...HEAD
+## Changed
+
+- renamed `FailedActivity` to a more active style: `ActivityFailed` [#17][17]
+
+[17]: ht... |
chaostoolkit__chaostoolkit-lib-70 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/control/__init__.py:apply_controls"
],
"edited_modules": [
"chaoslib/control/__init__.py:apply_controls"
]
},
"file": "chaoslib/control/__init__.py"
},
{
... | chaostoolkit/chaostoolkit-lib | aa66ce7803dbe4603295f497ca8809ca4d37ac65 | Pass th experiment to all controls
Currently, only the current context (steady-state, method, activity...) is passed down to a control fonction. We should also pass the experiment as it contains a larger context that may be useful as well.
Ideally this should go into 1.0.0rc2 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f55e69d..383e0cb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -14,6 +14,8 @@
- Use `ImportError` exception instead of `ModuleNotFoundError` which is not
declared in Python 3.5 [#67][67]
- Disallow empty JSON path [#68][68]
+- Pass the experiment to each control whe... |
chaostoolkit__chaostoolkit-lib-89 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/control/__init__.py:get_context_controls"
],
"edited_modules": [
"chaoslib/control/__init__.py:get_context_controls"
]
},
"file": "chaoslib/control/__init__.py... | chaostoolkit/chaostoolkit-lib | e18a9985454dbb91a278ea0c019a81db4f6da000 | Fix needed for activity-level controls to work as expected
Currently there is a bug when a `controls` block as applied at the activity level, i.e. not top level, and there are no top level controls applied either.
A fix such as the following needs to be applied to the chaos lib from line 201 onwards:
```
for... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 88eefe3..835f999 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,14 @@
[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/1.1.0...HEAD
+### Changed
+
+- Fix a failure when no top-level controls were provided but an activity
+ control was d... |
chaostoolkit__chaostoolkit-lib-91 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/control/python.py:validate_python_control"
],
"edited_modules": [
"chaoslib/control/python.py:validate_python_control"
]
},
"file": "chaoslib/control/python.py... | chaostoolkit/chaostoolkit-lib | fb1ac7e421f0396c940546951972617889b9a926 | Correct activity-level control behaviour where missing controls are simply warned of in the logging | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 835f999..eca3b3f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,8 +8,11 @@
- Fix a failure when no top-level controls were provided but an activity
control was declared [#88][88]
+- Warn when control Python package is not installed but do not fail experiment
+ d... |
chaostoolkit__chaostoolkit-lib-93 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"chaoslib/settings.py:load_settings"
],
"edited_modules": [
"chaoslib/settings.py:load_settings"
]
},
"file": "chaoslib/settings.py"
}
] | chaostoolkit/chaostoolkit-lib | 52e3b510c44fa315e3a77db780a7de7566bacd55 | Update yaml loader to use the safe loader
Currently we don't load yaml using the safe mechanism of the yaml package. This should be the case as we read from unsafe places. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 317f3d5..2208464 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,12 @@
[Unreleased]: https://github.com/chaostoolkit/chaostoolkit-lib/compare/1.1.1...HEAD
+### Changed
+
+- Use a YAML safe loader for settings [#92][92]
+
+[92]: https://github.com/chaostoolkit/... |
chapinb__chickadee-63 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "doc_src/source/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modu... | chapinb/chickadee | fa9862c3ff48e6ad3e07b2ecaad74ff922eaf926 | VirusTotal rate limiter does not store last request time
**Describe the bug**
The sleeper function checks the last request time to determine how long to sleep for. This value is only set at initialization and does not update per-request.
**Version (please complete the following information):**
- OS: Any (macO... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 104b977..fc87bab 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,11 @@
# Changelog
+## 20200805.0
+
+### Fixed
+
+* Addressed bug in rate limiting VirusTotal. [Issue-62](https://github.com/chapinb/chickadee/issues/62)
+
## 20200802.0
### Added
diff --git a/d... |
charliequinn__python-litmos-api-4 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/litmos/__init__.py:Litmos.__init__"
],
"edited_modules": [
"src/litmos/__init__.py:Litmos"
]
},
"file": "src/litmos/__init__.py"
},
{
"changes": {
"ad... | charliequinn/python-litmos-api | 2c2ed5135dc412a4861b163415410e179cdf9428 | Help needed to assign a list of users for a course
Hi Charlie,
I am unable to go beyond the code mentioned below
litmos = Litmos({'aXXXXXXXXXXXXX'},{'https://api.litmoseu.com/v1.svc'})
Is there anyway I could directly get the Json file downloaded. Or derive a code to assign course to a list of users
Thanks i... | diff --git a/README.rst b/README.rst
index bbcaaf1..4de9b0d 100644
--- a/README.rst
+++ b/README.rst
@@ -56,7 +56,11 @@ Getting started
.. code-block:: python
from litmos import Litmos
- litmos = Litmos({apikey}, {source})
+ API_KEY = 'AXXXXXXXXXX'
+ LITMOS_APP_NAME = 'jins.litmos.com'
+ LITMOS_SERV... |
chemosim-lab__ProLIF-129 | [
{
"changes": {
"added_entities": [
"prolif/fingerprint.py:first_occurence",
"prolif/fingerprint.py:all_occurences",
"prolif/fingerprint.py:Fingerprint.to_countvectors"
],
"added_modules": [
"prolif/fingerprint.py:first_occurence",
"prolif/fingerprint.py:... | chemosim-lab/ProLIF | 7c1c28483ec228af9d96c778a14a6914ffa0b875 | Count fingerprint
- [x] Switch builtin interaction classes to `yield` instead of `return`
- [x] Add `count: bool` attribute to `Fingerprint`
- [x] Switch metadata to `Tuple[Dict]` instead of `Dict`
- [x] Update `to_dataframe`
- [x] Update tests
- [x] Update `to_bitvector`
- [x] Update tests
- [x] Update LigNetwork to u... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6b71728..a7b1ef4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]
### Added
+- Added a `count` argument in `Fingerprint`. If `count=True`, enumerates all group... |
chemosim-lab__ProLIF-236 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"prolif/residue.py:ResidueId.__init__",
"prolif/residue.py:ResidueId.__str__",
"prolif/residue.py:ResidueId.__eq__",
"prolif/residue.py:ResidueId.__lt__"
],
"edited_mo... | chemosim-lab/ProLIF | f1fcb315cf0a4fb00e7fc2aa4c3ed0f5ad88e238 | Regex for parsing residues
Example of `ResidueId` that cannot be roundtriped:
```
K 123.A
MN 123.A
```
These get parsed as
```
UNK0.K
MN0
``` | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bda0062..ff80a16 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -90,7 +90,7 @@ jobs:
- name: Measure tests coverage
if: matrix.coverage
- uses: codecov/codecov-action@v3
+ uses: codecov/codeco... |
cherrypy__cheroot-311 | [
{
"changes": {
"added_entities": [
"cheroot/connections.py:ConnectionManager._expire",
"cheroot/connections.py:ConnectionManager.stop",
"cheroot/connections.py:ConnectionManager.run"
],
"added_modules": null,
"edited_entities": [
"cheroot/connections.py:Co... | cherrypy/cheroot | 6a60fa1a30c573b82489054e16ee83412c9fe5dc | [cheroot==8.1.0 regression] Significant performance drop
❓ **I'm submitting a ...**
- [X] 🐞 bug report
- [ ] 🐣 feature request
- [ ] ❓ question about the decisions made in the repository
🐞 **Describe the bug. What is the current behavior?**
This more a note than a bug report:
I run some benchmark against m... | diff --git a/CHANGES.rst b/CHANGES.rst
index 64bd2881..134e3ff2 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,3 +1,11 @@
+.. scm-version-title:: v8.5.0
+
+- :issue:`305` via :pr:`311`: In
+ :py:class:`~cheroot.connections.ConnectionManager`,
+ process connections as they become active rather than
+ waiting for a ... |
cherrypy__cheroot-505 | [
{
"changes": {
"added_entities": [
"cheroot/server.py:HTTPServer._make_socket_reusable"
],
"added_modules": null,
"edited_entities": [
"cheroot/server.py:HTTPServer.__init__",
"cheroot/server.py:HTTPServer.bind",
"cheroot/server.py:HTTPServer.bind_unix_soc... | cherrypy/cheroot | 580e296b0cf201f02523e539ff1b200773ccfc36 | Add an option for port re-using
❓ **I'm submitting a ...**
- [ ] 🐞 bug report
- [X] 🐣 feature request
- [ ] ❓ question about the decisions made in the repository
🐞 **Is your feature request related to a problem? Please describe.**
We have a process that automatically distributes available ports across multi... | diff --git a/CHANGES.rst b/CHANGES.rst
index ee7becc6..cf19e8ef 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,3 +1,10 @@
+.. scm-version-title:: v10.0.0
+
+- :issue:`504` via :pr:`505`: Cheroot now accepts a
+ ``reuse_port`` parameter on the ``HTTPServer`` object.
+ Subclasses overriding ``prepare_socket`` will no... |
cherrypy__cherrypy-1442 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "cherrypy/_cptools.py"
},
{
"changes": {
"added_entities": [
"cherrypy/lib/cptools.py:convert_params"
],
"added_modules": [
... | cherrypy/cherrypy | adb7ff5aa1f48506e2838a22176c43c6f3aa4fb5 | Convert request params based on function annotations.
With the increasing focus on [type hints](https://docs.python.org/3.5/library/typing.html) in Python, having a tool which automatically converted query params (with exception handling) would be a nice feature.
It's common for apps to have boilerplate code for [co... | diff --git a/CHANGES.txt b/CHANGES.txt
index 20877f63..b06461ad 100644
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -4,6 +4,7 @@
* Issue #1411: Fix issue where autoreload fails when
the host interpreter for CherryPy was launched using
``python -m``.
+* #1441: Added tool to automatically convert request params.
6.1.... |
cherrypy__cherrypy-1578 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cherrypy/_cperror.py:HTTPRedirect.set_response"
],
"edited_modules": [
"cherrypy/_cperror.py:HTTPRedirect"
]
},
"file": "cherrypy/_cperror.py"
}
] | cherrypy/cherrypy | 8c635f55c3634b722260fef501ee49fb440be3ac | Encode URLs in redirect responses
* **I'm submitting a ...**
[x] bug report
[ ] feature request
[ ] question about the decisions made in the repository
* **What is the current behavior?**
The standard response page for 30x errors contains the target URL as `href` as well as clear text.
* **What is the expecte... | diff --git a/cherrypy/_cperror.py b/cherrypy/_cperror.py
index 6c952e91..b597c645 100644
--- a/cherrypy/_cperror.py
+++ b/cherrypy/_cperror.py
@@ -271,7 +271,7 @@ class HTTPRedirect(CherryPyException):
307: 'This resource has moved temporarily to ',
}[status]
msg += '<a href=%... |
cherrypy__cherrypy-1596 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cherrypy/_helper.py:url"
],
"edited_modules": [
"cherrypy/_helper.py:url"
]
},
"file": "cherrypy/_helper.py"
}
] | cherrypy/cherrypy | 2c5643367147bae270e83dfba25c1897f37dbe18 | `cherrypy.url` fails to normalize path
This call to `cherrypy.url` fails with `IndexError`:
```
>>> cherrypy.url(qs='../../../../../../etc/passwd')
...
IndexError: pop from empty list
```
The culprit seems in this logic, which strips `newurl` of as many `atoms` as there are `..`:
https://github.com/cherrypy/ch... | diff --git a/cherrypy/_helper.py b/cherrypy/_helper.py
index 5875ec0f..9b727eac 100644
--- a/cherrypy/_helper.py
+++ b/cherrypy/_helper.py
@@ -223,6 +223,30 @@ def url(path='', qs='', script_name=None, base=None, relative=None):
if qs:
qs = '?' + qs
+ def normalize_path(path):
+ if './' not in... |
cherrypy__cherrypy-1785 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cherrypy/_cpnative_server.py:NativeGateway.respond"
],
"edited_modules": [
"cherrypy/_cpnative_server.py:NativeGateway"
]
},
"file": "cherrypy/_cpnative_server.py"
}
... | cherrypy/cherrypy | 0f8523cd36153194c50b9b900f72591a44d5b95f | disabling wsgi interface fails under python3
Originally reported by: **Tim Miller (Bitbucket: [lashni](http://bitbucket.org/lashni), GitHub: Unknown)**
---
http://docs.cherrypy.org/en/latest/advanced.html#no-need-for-the-wsgi-interface
Error is encountered when the example code from the link above is run under a pyt... | diff --git a/CHANGES.rst b/CHANGES.rst
index 7862fc93..f9961319 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -1,3 +1,9 @@
+v18.1.2 (unreleased)
+--------------------
+
+* Fixed :issue:`1377` via :pr:`1785`: Restore a native WSGI-less
+ HTTP server support.
+
v18.1.1
-------
diff --git a/cherrypy/_cpnative_server.... |
cherrypy__cherrypy-1976 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cherrypy/_cprequest.py:Request.process_headers"
],
"edited_modules": [
"cherrypy/_cprequest.py:Request"
]
},
"file": "cherrypy/_cprequest.py"
},
{
"changes": {
... | cherrypy/cherrypy | 12a06bf717effe21973953f30771a56c74130621 | Undisclosed security issue
This issue was reported to security@cherrypy.dev as a security issue on 2022-06-18.
I'm documenting the investigation in a hackmd.io document, which I will put here after the resolution is concluded. | diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 0c75d0b0..a44f278c 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -59,12 +59,3 @@ repos:
rev: v1.1.0
hooks:
- id: forbid-html-img-without-alt-text
-
-- repo: https://github.com/adrienverge/yamllint.git
- rev: v... |
cherrypy__cherrypy-1992 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"cherrypy/_cplogging.py:LazyRfc3339UtcTime.__str__"
],
"edited_modules": [
"cherrypy/_cplogging.py:LazyRfc3339UtcTime"
]
},
"file": "cherrypy/_cplogging.py"
}
] | cherrypy/cherrypy | 1f2366fb56663b9e8e480b9cba299ff201cba4da | Local time is used as utc time in LazyRfc3339UtcTime
**I'm submitting a ...**
- [x] bug report
- [ ] feature request
- [ ] question about the decisions made in the repository
**Do you want to request a *feature* or report a *bug*?**
Report a *bug*
**What is the current behavior?**
`LazyRfc3339UtcTime` return... | diff --git a/cherrypy/_cplogging.py b/cherrypy/_cplogging.py
index 151d3b40..bce1c87b 100644
--- a/cherrypy/_cplogging.py
+++ b/cherrypy/_cplogging.py
@@ -452,6 +452,6 @@ class WSGIErrorHandler(logging.Handler):
class LazyRfc3339UtcTime(object):
def __str__(self):
- """Return now() in RFC3339 UTC Format.... |
chezou__tabula-py-331 | [
{
"changes": {
"added_entities": [
"tabula/util.py:_validate_area"
],
"added_modules": [
"tabula/util.py:_validate_area"
],
"edited_entities": [
"tabula/util.py:TabulaOption.build_option_list"
],
"edited_modules": [
"tabula/util.py:Tabula... | chezou/tabula-py | 5c7bd93a7c57b880853d5e2c8c04bb73ecb44aca | Assert column option
**Is your feature request related to a problem? Please describe.**
When given invalid columns option, it passes through to tabula-java and the error message isn't clear.
https://stackoverflow.com/questions/70925281/error-in-tabula-tabula-py-when-specifying-area-parameter
**Describe the solution... | diff --git a/tabula/util.py b/tabula/util.py
index ed0a61e..eacbad2 100644
--- a/tabula/util.py
+++ b/tabula/util.py
@@ -208,12 +208,14 @@ class TabulaOption:
if any(type(e) in [list, tuple] for e in self.area):
for e in self.area:
e = cast(Iterable[float],... |
chezou__tabula-py-390 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"tabula/util.py:TabulaOption.build_option_list"
],
"edited_modules": [
"tabula/util.py:TabulaOption"
]
},
"file": "tabula/util.py"
}
] | chezou/tabula-py | 7f2cad175973ada6c1fe0dea39070aae524c7142 | [BUG] column parameter of read_pdf currently needs to be list, not generic iterable
### Summary
Docs say columns parameter can be iterable, but code requires it to be list.
### Did you read the FAQ?
- [X] I have read the FAQ
### Did you search GitHub issues?
- [X] I have searched the issues
### Did you search Git... | diff --git a/tabula/util.py b/tabula/util.py
index 7dc2453..2e49cf7 100644
--- a/tabula/util.py
+++ b/tabula/util.py
@@ -9,7 +9,7 @@ import platform
import shlex
from dataclasses import dataclass
from logging import getLogger
-from typing import IO, Iterable, List, Optional, Union, cast
+from typing import IO, Itera... |
childsish__dynamic-yaml-18 | [
{
"changes": {
"added_entities": [
"dynamic_yaml/yaml_wrappers.py:YamlList.__iter__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"dynamic_yaml/yaml_wrappers.py:YamlList"
]
},
"file": "dynamic_yaml/yaml_wrappers.py"
}
] | childsish/dynamic-yaml | 73895727841024969b854b1c524ce8aa70527f46 | [Enhancement] - Method to resolve the dynamic object
Ran into the issue when trying to pass in a list to a pandas dataframe. I was trying to define some columns, but the list of columns wouldn't resolve. See below example:
```python
import dynamic_yaml
import pandas as pd
yml = '''
names:
n1: "name1"
n2:... | diff --git a/dynamic_yaml/yaml_wrappers.py b/dynamic_yaml/yaml_wrappers.py
index 14c5ecc..1a08d27 100644
--- a/dynamic_yaml/yaml_wrappers.py
+++ b/dynamic_yaml/yaml_wrappers.py
@@ -78,6 +78,10 @@ class YamlList(DynamicYamlObject, MutableSequence):
super().__setattr__('_collection', list(*args, **kwargs))
... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.