instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
childsish__dynamic-yaml-27 | [
{
"changes": {
"added_entities": [
"dynamic_yaml/yaml_wrappers.py:YamlDict.__delattr__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"dynamic_yaml/yaml_wrappers.py:YamlDict"
]
},
"file": "dynamic_yaml/yaml_wrappers.py"
}
] | childsish/dynamic-yaml | 41c9cd918f9941085a5d46b83e9437753152e324 | 'YamlDict' has no __delattr__ method
Is there a reason __delattr__ isn't implemented on YamlDict?
It was a bit surprising to try to delete an attribute and have it raise. | diff --git a/dynamic_yaml/yaml_wrappers.py b/dynamic_yaml/yaml_wrappers.py
index 34ca7e8..2522118 100644
--- a/dynamic_yaml/yaml_wrappers.py
+++ b/dynamic_yaml/yaml_wrappers.py
@@ -66,6 +66,9 @@ class YamlDict(DynamicYamlObject, MutableMapping):
def __setattr__(self, key, value):
self[key] = value
+ ... |
childsish__dynamic-yaml-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dynamic_yaml/__init__.py:dump"
],
"edited_modules": [
"dynamic_yaml/__init__.py:dump"
]
},
"file": "dynamic_yaml/__init__.py"
}
] | childsish/dynamic-yaml | bed4e61cb46744dc8e486cc83097cef010f94557 | How to preserve order when dumping?
How to preserve order when dumping? | diff --git a/dynamic_yaml/__init__.py b/dynamic_yaml/__init__.py
index 2ebbab4..5245f7e 100644
--- a/dynamic_yaml/__init__.py
+++ b/dynamic_yaml/__init__.py
@@ -37,8 +37,8 @@ def load(stream, loader=DynamicYamlLoader, recursive=False):
return result
-def dump(data, *args, **kwargs):
- return yaml.dump(data,... |
childsish__dynamic-yaml-6 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"dynamic_yaml/__init__.py:load"
],
"edited_modules": [
"dynamic_yaml/__init__.py:load"
]
},
"file": "dynamic_yaml/__init__.py"
},
{
"changes": {
"added_ent... | childsish/dynamic-yaml | e28c8cfce18459f28b3f6bfd65d4c5ba3f230e71 | Problems with recursive=True
I have the following .yml file:
```
prefix: /opt/ml
input_path: '{prefix}/input'
model_path: '{prefix}/model'
output_path: '{prefix}/output'
failure_path: '{output_path}/failure'
# Training
training:
training_data_path: '{input_path}/data/training'
# mia_path: '{training_... | diff --git a/dynamic_yaml/__init__.py b/dynamic_yaml/__init__.py
index 8e77e89..1b505aa 100644
--- a/dynamic_yaml/__init__.py
+++ b/dynamic_yaml/__init__.py
@@ -27,5 +27,5 @@ add_wrappers(DynamicYamlLoader)
def load(stream, loader=DynamicYamlLoader, recursive=False):
result = yaml.load(stream, Loader=loader)
- ... |
chimpler__pyhocon-124 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/tool.py:HOCONConverter.to_json",
"pyhocon/tool.py:HOCONConverter.to_hocon",
"pyhocon/tool.py:HOCONConverter.to_yaml",
"pyhocon/tool.py:HOCONConverter.to_properties"
... | chimpler/pyhocon | 4dfa3b8b3c2e254964f28127f2d12ce526217869 | HOCONConverter.to_json can't convert `null` value
After convert into JSON with `HOCONConverter.to_json`, the value should be kept `null`, but it is converted to `NonValue`.
```py
In [19]: hocon = "{foo = null}"
In [20]: conf = ConfigFactory.parse_string(hocon)
In [21]: conf
Out[21]: ConfigTree([('foo', <pyhocon.... | diff --git a/.travis.yml b/.travis.yml
index cffa9ba..368f17e 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,12 +1,13 @@
language: python
-python: 2.7
-env:
- - TOX_ENV=py26
- - TOX_ENV=py27
- - TOX_ENV=py33
- - TOX_ENV=py34
-install: pip install tox coveralls
-before_script: tox -e flake8
-script: tox -e ${TOX_... |
chimpler__pyhocon-13 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/__init__.py:ConfigParser.parse",
"pyhocon/__init__.py:ConfigParser._resolve_substitutions"
],
"edited_modules": [
"pyhocon/__init__.py:ConfigParser"
]
},
... | chimpler/pyhocon | 4e8c1621c49dac503a790cd46f843135342ae618 | String substitution broken?
Could it be that the fix for object merging (issue #10) broken string substitution?
Expanding on the simple unit test from pyhocon codebase:
```
In [54]: config = ConfigFactory.parse_string(
....: """
....: {
....: a: {
....: ... | diff --git a/pyhocon/__init__.py b/pyhocon/__init__.py
index 2a467e8..5b3b7a5 100644
--- a/pyhocon/__init__.py
+++ b/pyhocon/__init__.py
@@ -145,7 +145,7 @@ class ConfigParser(object):
eol = Word('\n\r').suppress()
eol_comma = Word('\n\r,').suppress()
- comment = (Optional(eol_comma) + (Liter... |
chimpler__pyhocon-133 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/config_tree.py:ConfigTree._put",
"pyhocon/config_tree.py:ConfigTree._get"
],
"edited_modules": [
"pyhocon/config_tree.py:ConfigTree"
]
},
"file": "pyhoc... | chimpler/pyhocon | 8609e4f810ca47a3b573d8b79fa39760e97714b5 | get_list() returns NoneValue's, not None's
Given the following pyhocon file:
```
single_value = null
list_value = [null]
```
And the following code:
```python
from pyhocon import ConfigFactory
config = ConfigFactory.parse_file("test.conf")
single_value = config.get("single_value")
print single_value, sing... | diff --git a/pyhocon/config_tree.py b/pyhocon/config_tree.py
index 075bae1..354bfb6 100644
--- a/pyhocon/config_tree.py
+++ b/pyhocon/config_tree.py
@@ -93,7 +93,7 @@ class ConfigTree(OrderedDict):
self._push_history(key_elt, value)
self[key_elt] = value
elif i... |
chimpler__pyhocon-173 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/config_parser.py:ConfigParser.parse"
],
"edited_modules": [
"pyhocon/config_parser.py:ConfigParser"
]
},
"file": "pyhocon/config_parser.py"
}
] | chimpler/pyhocon | 9b8830e409e000927f8029bf6a5c4337720120ba | pyhocon does not handle backslashes the same way json does
```
In [1]: import json, pyhocon
In [2]: single = r'{"a": "b\.c"}'
In [3]: double = r'{"a": "b\\.c"}'
In [4]: json.loads(single)
---------------------------------------------------------------------------
JSONDecodeError...
In [5]: json.loads(dou... | diff --git a/pyhocon/config_parser.py b/pyhocon/config_parser.py
index 0257199..f68839b 100644
--- a/pyhocon/config_parser.py
+++ b/pyhocon/config_parser.py
@@ -3,6 +3,7 @@ import os
import socket
import contextlib
import codecs
+
from pyparsing import Forward, Keyword, QuotedString, Word, Literal, Suppress, Regex,... |
chimpler__pyhocon-196 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"pyhocon/config_tree.py:ConfigTree"
]
},
"file": "pyhocon/config_tree.py"
}
] | chimpler/pyhocon | 9ccb7cac7db3ac3d20c5d7f031f802281a87242d | NoneValue object in parse result of "a=null" in PyPy
In PyPy, parse result of "a=null" has a NoneValue object which is wrong:
```
Python 2.7.12 (aff251e543859ce4508159dd9f1a82a2f553de00, Nov 25 2016, 00:02:08)
[PyPy 5.6.0 with GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin
Type "help", "copyrig... | diff --git a/pyhocon/config_tree.py b/pyhocon/config_tree.py
index 1492793..c39a977 100644
--- a/pyhocon/config_tree.py
+++ b/pyhocon/config_tree.py
@@ -1,7 +1,6 @@
from collections import OrderedDict
from pyparsing import lineno
from pyparsing import col
-
try:
basestring
except NameError: # pragma: no cove... |
chimpler__pyhocon-28 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/config_tree.py:ConfigTree._put"
],
"edited_modules": [
"pyhocon/config_tree.py:ConfigTree"
]
},
"file": "pyhocon/config_tree.py"
}
] | chimpler/pyhocon | 1dfded0867d7de333d2ee9bc90ee25b2d690f819 | ${?foo} unsets previous value if new is undefined
pyhocon==0.3.2
Apparently `${?VAR_NAME}` no longer complains about undefined variables but is seems to be unsetting the key. My expectation is that `${?foo}` would leave the key referencing the last value unless it had something to replace it with.
```
...
Fil... | diff --git a/pyhocon/config_tree.py b/pyhocon/config_tree.py
index 60b2d88..d045c7b 100644
--- a/pyhocon/config_tree.py
+++ b/pyhocon/config_tree.py
@@ -70,6 +70,9 @@ class ConfigTree(OrderedDict):
type=l.__class__.__name__)
)
else:
+ # if th... |
chimpler__pyhocon-292 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/config_parser.py:ConfigTreeParser.postParse"
],
"edited_modules": [
"pyhocon/config_parser.py:ConfigTreeParser"
]
},
"file": "pyhocon/config_parser.py"
},
{... | chimpler/pyhocon | be660deb6d6a5a175d384792e208fd39986758ea | ConfigFactory Parse File update after substitution incorrect
If I have a config called `test.conf`
```
test: {
a: 1
b: 2
}
test2: ${test}
test2.c: 3
```
I would expect
```
conf = ConfigFactory.parse_file("test.conf")
print(conf.get("test2"))
```
to print `{a:1, b:2, c:3}` but it just prints `{c:3}`. | diff --git a/pyhocon/config_parser.py b/pyhocon/config_parser.py
index 6846589..52a06cb 100644
--- a/pyhocon/config_parser.py
+++ b/pyhocon/config_parser.py
@@ -125,6 +125,10 @@ def period(period_value, period_unit):
return period_impl(**arguments)
+U_KEY_SEP = unicode('.')
+U_KEY_FMT = unicode('"{0}"')
+
+
c... |
chimpler__pyhocon-42 | [
{
"changes": {
"added_entities": [
"pyhocon/config_parser.py:ConfigFactory.from_dict"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"pyhocon/config_parser.py:ConfigFactory"
]
},
"file": "pyhocon/config_parser.py"
}
] | chimpler/pyhocon | cfe9a3c34f0fb5aabfa7f5257b573058be84e490 | How to dump HOCON file?
Hi,
Just wonder how to do this with pyhocon?
https://marcinkubala.wordpress.com/2013/10/09/typesafe-config-hocon/
Thanks. | diff --git a/pyhocon/config_parser.py b/pyhocon/config_parser.py
index a3a2191..1c966d6 100644
--- a/pyhocon/config_parser.py
+++ b/pyhocon/config_parser.py
@@ -83,6 +83,16 @@ class ConfigFactory(object):
"""
return ConfigParser().parse(content, basedir, resolve)
+ @staticmethod
+ def from_dic... |
chimpler__pyhocon-81 | [
{
"changes": {
"added_entities": [
"pyhocon/config_parser.py:ConfigParser._fixup_self_references",
"pyhocon/config_parser.py:ConfigParser._find_substitutions",
"pyhocon/config_parser.py:ConfigParser._do_substitute",
"pyhocon/config_parser.py:ConfigParser._final_fixup"
... | chimpler/pyhocon | 24117399090b3ca1ea5d041f9de46101569ace13 | support for "+=" field separator?
I get an error when parsing a hocon file:
```
[ec2-user@ip-172-16-2-117 ~]$ pyhocon -i /opt/mapr/drill/drill-1.1.0/conf/drill-override-example.conf
Traceback (most recent call last):
File "/usr/local/bin/pyhocon", line 9, in <module>
load_entry_point('pyhocon==0.3.4', 'con... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 373df98..5f75182 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,9 @@
# Changelog
+# Version 0.3.xx (TBA)
+
+* Implemented self-referential subsitutions
+
# Version 0.3.25
* ConfigValue.transform: do not wrap lists. PR [#76]
diff --git a/README.md b/README.m... |
chimpler__pyhocon-92 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pyhocon/config_parser.py:ConfigParser.parse"
],
"edited_modules": [
"pyhocon/config_parser.py:ConfigParser"
]
},
"file": "pyhocon/config_parser.py"
}
] | chimpler/pyhocon | abac1214ebcda0634960c29a16fba9a533266043 | Syntax error while parsing variables of form include-blah-blah
Trying to parse the following config:
```
{
include-other-stuff = true
}
```
with `conf = pyhocon.ConfigFactory.parse_file('/tmp/foo.conf')` results in the following stacktrace:
```
File "/home/blah/blahblah.py", line 53, in <module>
... | diff --git a/pyhocon/config_parser.py b/pyhocon/config_parser.py
index 9e20236..27366a5 100644
--- a/pyhocon/config_parser.py
+++ b/pyhocon/config_parser.py
@@ -236,7 +236,7 @@ class ConfigParser(object):
value_expr = number_expr | true_expr | false_expr | null_expr | string_expr
- include_expr = (K... |
choderalab__openmmtools-235 | [
{
"changes": {
"added_entities": [
"openmmtools/cache.py:ContextCache._generate_integrator_id",
"openmmtools/cache.py:ContextCache._get_default_integrator",
"openmmtools/cache.py:ContextCache._default_integrator_id"
],
"added_modules": null,
"edited_entities": [
... | choderalab/openmmtools | fe82cd1b81ae2026ad0299430293e27c0128335e | Context cache failure to access `set*`
Unfortunately, I don't have a minimal example yet, but I did want to note that a few days ago, as I was trying to use the `ContextCache` with a `celery` worker, I ran into a strange bug. Using the `AlchemicalNonequilibriumLangevinIntegrator`, whenever it tried to recover a context... | diff --git a/openmmtools/cache.py b/openmmtools/cache.py
index f6d3ede..87ec8d6 100644
--- a/openmmtools/cache.py
+++ b/openmmtools/cache.py
@@ -17,7 +17,7 @@ Provide cache classes to handle creation of OpenMM Context objects.
import copy
import collections
-from simtk import openmm
+from simtk import openmm, unit
... |
chrahunt__hlp-15 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"hlp/cli.py:NamedObject.get_attr",
"hlp/cli.py:autocomplete"
],
"edited_modules": [
"hlp/cli.py:NamedObject",
"hlp/cli.py:autocomplete"
]
},
"file": "hlp... | chrahunt/hlp | b9d32dd1b2e80733582df93363ac5443837dd993 | Autocomplete builtin names
Currently if autocompleting a prompt like
```
hlp |
```
we only look at top-level packages and modules. We should also be including names of builtins. | diff --git a/hlp/cli.py b/hlp/cli.py
index c3d2476..33ff11c 100644
--- a/hlp/cli.py
+++ b/hlp/cli.py
@@ -6,7 +6,7 @@ import shlex
import sys
from textwrap import dedent
-from .compat import iter_modules
+from .compat import builtins, iter_modules
from .typing import MYPY_RUNNING
from .util import getattr_recursiv... |
chriskuehl__lazy-build-16 | [
{
"changes": {
"added_entities": [
"lazy_build/cache.py:S3Backend.artifact_paths"
],
"added_modules": null,
"edited_entities": [
"lazy_build/cache.py:S3Backend.has_artifact",
"lazy_build/cache.py:S3Backend.get_artifact",
"lazy_build/cache.py:S3Backend.stor... | chriskuehl/lazy-build | c53270b41e1d3716c301e65a283d99f86aa55bb9 | gzip before upload
In some common cases (e.g. node_modules), this reduces ~300MB artifacts to ~100MB artifacts. Probably worth the CPU time. | diff --git a/lazy_build/cache.py b/lazy_build/cache.py
index 27124d9..f1ec74a 100644
--- a/lazy_build/cache.py
+++ b/lazy_build/cache.py
@@ -20,10 +20,15 @@ class S3Backend(collections.namedtuple('S3Backend', (
def key_for_ctx(self, ctx):
return self.path.rstrip('/') + '/' + ctx.hash
+ def artifact_p... |
chriskuehl__rustenv-12 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "rustenv.py"
}
] | chriskuehl/rustenv | b2f3ae3f74bb7407c18e59700112098394eac323 | `deactivate_rustenv` doesn't remove `deactivate_rustenv`
```console
(renv) asottile@babibox:/tmp
$ deactivate_rustenv
asottile@babibox:/tmp
$ which cargo
asottile@babibox:/tmp
$ deactivate_rustenv
ehco hi
bash: ehco: No such file or directory
echo hi
hi
``` | diff --git a/rustenv.py b/rustenv.py
index ac82bb7..4cdbbc2 100644
--- a/rustenv.py
+++ b/rustenv.py
@@ -47,6 +47,7 @@ deactivate_rustenv() {{
unset _RUSTENV_BIN_PATH
unset _RUSTENV_OLD_PS1
unset _RUSTENV_OLD_PATH
+ unset -f deactivate_rustenv
}}
'''
|
chriskuehl__rustenv-15 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "rustenv.py"
}
] | chriskuehl/rustenv | dd94d714d6c1a96bf4b0f5fb0ea7a751b23df915 | activate script doesn't work if there's no PS1 and the shell is `set -e`
This happens e.g. in bash scripts (as opposed to logged-in sessions).
```
$ cat test.sh
#!/bin/bash
set -euo pipefail
. renv/bin/activate
$ ./test.sh
renv/bin/activate: line 6: PS1: unbound variable
```
It should probably skip set... | diff --git a/rustenv.py b/rustenv.py
index 4cdbbc2..f2b8aff 100644
--- a/rustenv.py
+++ b/rustenv.py
@@ -31,15 +31,17 @@ _RUSTENV_NAME='{RUSTENV_NAME}'
# TODO: it might be nice to intelligently add/remove from PATH/PS1 instead of
# just restoring the old one
-_RUSTENV_OLD_PS1="$PS1"
+_RUSTENV_OLD_PS1="${{PS1-}}"
_... |
chrisroadmap__climateforcing-33 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/climateforcing/aprp/apr... | chrisroadmap/climateforcing | 17cb0a0346fbb62d51ec9bdf82fa3e9440d53ebf | Check APRP against Mark Zelinka
- [ ] understand differences (https://github.com/mzelinka/aprp/blob/master/code/python/demonstrate_APRP.ipynb)
- [ ] correct my code if buggy | diff --git a/.github/workflows/checks.yml b/.github/workflows/checks.yml
index f3b092d..15f218c 100644
--- a/.github/workflows/checks.yml
+++ b/.github/workflows/checks.yml
@@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- python-version: [3.6, 3.7, 3.8, 3.9]
+ python-ver... |
christianhbye__21cmVAE-15 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"VeryAccurateEmulator/emulator.py:AutoEncoderEmulator.__init__",
"VeryAccurateEmulator/emulator.py:AutoEncoderEmulator.test_error"
],
"edited_modules": [
"VeryAccurateEmulator... | christianhbye/21cmVAE | 0407243d40173ff725f34ec3483752414dc0d985 | write tests | diff --git a/VeryAccurateEmulator/emulator.py b/VeryAccurateEmulator/emulator.py
index 96452d6..f797d61 100644
--- a/VeryAccurateEmulator/emulator.py
+++ b/VeryAccurateEmulator/emulator.py
@@ -651,7 +651,7 @@ class AutoEncoderEmulator:
)
# build autoencoder by calling it on a batch of data
- ... |
christiansandberg__canopen-446 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"canopen/pdo/base.py:PdoMap.__getitem__",
"canopen/pdo/base.py:PdoMap.read",
"canopen/pdo/base.py:PdoMap.save",
"canopen/pdo/base.py:PdoMap.remote_request",
"canopen/pdo/b... | christiansandberg/canopen | 5367d83ec953e2eaefcbf654ca3f6b65c8ee088c | Saving dynamic/empty PDOs: TypeError: unsupported operand type(s) for |: 'NoneType' and 'int'
Currently, if you have dynamic PDOs, which are only defined but not configured in the EDS-File, you can not save them, because they are initialized with cob_id = None, which can not be compared in this loc in pdo/base.py:376
... | diff --git a/canopen/pdo/base.py b/canopen/pdo/base.py
index 1f4bf3e..1784760 100644
--- a/canopen/pdo/base.py
+++ b/canopen/pdo/base.py
@@ -215,7 +215,6 @@ class PdoMap:
f"{', '.join(valid_values)}")
def __getitem__(self, key: Union[int, str]) -> "PdoVariable":
- var = None
... |
christiansandberg__canopen-476 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"canopen/objectdictionary/__init__.py:export_od",
"canopen/objectdictionary/__init__.py:import_od"
],
"edited_modules": [
"canopen/objectdictionary/__init__.py:export_od",
... | christiansandberg/canopen | 5734f37ee758e1d025701b4d40e0b89a57db2317 | Consider using ObjectDictionaryError iso. NotImplementedError in export/import OD APIs
Discovered while reviewing #469. (See https://github.com/christiansandberg/canopen/pull/469#discussion_r1661613953.)
In most cases, `ObjectDictionaryError` is used for the `export_od` and `import_od` APIs, but for unsupported file... | diff --git a/canopen/objectdictionary/__init__.py b/canopen/objectdictionary/__init__.py
index d9a2a2f..441ade9 100644
--- a/canopen/objectdictionary/__init__.py
+++ b/canopen/objectdictionary/__init__.py
@@ -50,7 +50,11 @@ def export_od(od, dest: Union[str, TextIO, None] = None, doc_type: Optional[str]
fr... |
christiansandberg__canopen-506 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"canopen/nmt.py:NmtBase.state"
],
"edited_modules": [
"canopen/nmt.py:NmtBase"
]
},
"file": "canopen/nmt.py"
}
] | christiansandberg/canopen | fa74236b3f3312c03d09e72de3fa6d3cf077fbec | `NmtBase.state` should always return a `str`
## Problem
`NmtBase.state` is documented and annotated as always returning a string, however there is a code path that may return an `int`:
https://github.com/christiansandberg/canopen/blob/62e9c1f851cb8721355d22c8571f2b41599c1b36/canopen/nmt.py#L74-L92
The code pat... | diff --git a/canopen/nmt.py b/canopen/nmt.py
index 401ad15..8ce737e 100644
--- a/canopen/nmt.py
+++ b/canopen/nmt.py
@@ -86,10 +86,10 @@ class NmtBase:
- 'RESET'
- 'RESET COMMUNICATION'
"""
- if self._state in NMT_STATES:
+ try:
return NMT_STATES[self._state]
- ... |
christophercrouzet__gorilla-4 | [
{
"changes": {
"added_entities": [
"gorilla.py:revert"
],
"added_modules": [
"gorilla.py:revert"
],
"edited_entities": [
"gorilla.py:apply",
"gorilla.py:get_original_attribute"
],
"edited_modules": [
"gorilla.py:apply",
"g... | christophercrouzet/gorilla | 84ab27f38c8ee26816b267406d867f7bac87a34b | Ability to unregister and reload patches
Hi
Would it be possible to add an unregister_extensions() function? Or have the register_extensions function do a reload() of the packages passed into it? I think it would speed up developing with gorilla and help with troubleshooting
Thanks for the awesome module
Luke | diff --git a/doc/core.rst b/doc/core.rst
index 2fcf062..67d8999 100644
--- a/doc/core.rst
+++ b/doc/core.rst
@@ -28,3 +28,7 @@ Core
----
.. autofunction:: apply
+
+----
+
+.. autofunction:: revert
diff --git a/gorilla.py b/gorilla.py
index 81b877d..a72ae65 100644
--- a/gorilla.py
+++ b/gorilla.py
@@ -51,8 +51,14 @@... |
churchmanlab__genewalk-5 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"genewalk/cli.py:main"
],
"edited_modules": [
"genewalk/cli.py:main"
]
},
"file": "genewalk/cli.py"
},
{
"changes": {
"added_entities": [
"genewalk... | churchmanlab/genewalk | ebefe0f83f54acb0c8472bfe919129fa07b8b92d | ENSEMBL IDs
Hi, a quick question: Is it possible to support also ENSEMBL IDs as input? | diff --git a/README.md b/README.md
index 2b734e3..ae5d980 100644
--- a/README.md
+++ b/README.md
@@ -29,7 +29,7 @@ GeneWalk always requires as input a text file containing a list with genes of in
relevant to the biological context. For example, differentially expressed genes
from a sequencing experiment that compares... |
cirKITers__masKIT-15 | [
{
"changes": {
"added_entities": [
"maskit/masks.py:Mask.__len__",
"maskit/masks.py:Mask.shape",
"maskit/masks.py:Mask.size",
"maskit/masks.py:MaskedCircuit.mask_changed"
],
"added_modules": null,
"edited_entities": [
"maskit/masks.py:Mask.__init__... | cirKITers/masKIT | 11eaac5d3166af5924b202b5b078265b2714c291 | Enable adding parameters back into a circuit with specific values
In case parameters, that is gates, are added back into a circuit the current cost will change depending on the parameter value. E.g. in case a rotation is not set to `0` the loss will probably drop immediately. To enable a smoother training it might ther... | diff --git a/maskit/masks.py b/maskit/masks.py
index b5598cd..b8e4fe6 100644
--- a/maskit/masks.py
+++ b/maskit/masks.py
@@ -1,7 +1,7 @@
import random as rand
import pennylane.numpy as np
from enum import Enum
-from typing import Dict, List, Optional, Tuple, Union
+from typing import Any, Dict, List, Optional, Tuple... |
cirKITers__masKIT-30 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:init_parameters",
"main.py:train"
],
"edited_modules": [
"main.py:init_parameters",
"main.py:train"
]
},
"file": "main.py"
},
{
"changes... | cirKITers/masKIT | 438d49358d3eed4737938b57eed6ed1cb62d903f | Support optimisers storing interim results
Some optimisers such as the ADAM optimiser have a memory to store recent results as part of their optimisation concept to improve on other methods such as Gradient Descent. However, currently our project does change the number of parameters relevant for optimisation during the... | diff --git a/main.py b/main.py
index 25b123d..0521fd0 100644
--- a/main.py
+++ b/main.py
@@ -45,7 +45,11 @@ def cost_iris(
def init_parameters(
- layers: int, current_layers: int, wires: int, default_value: Optional[float]
+ layers: int,
+ current_layers: int,
+ wires: int,
+ default_value: Optional... |
cirKITers__masKIT-32 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:init_parameters"
],
"edited_modules": [
"main.py:init_parameters"
]
},
"file": "main.py"
},
{
"changes": {
"added_entities": null,
"added_mo... | cirKITers/masKIT | 007673987180223931396b672c6c24d936dea5dc | Support dropping of entangling gates
So far we only support dropping parameterised gates. But especially with a focus on lowering expressivity of a circuit it might make sense to also enable dropping entangling gates. This could be realised by adding another mask to our `MaskedCircuit` class. | diff --git a/main.py b/main.py
index 0521fd0..0532b73 100644
--- a/main.py
+++ b/main.py
@@ -4,7 +4,7 @@ import random
import pennylane as qml
from pennylane import numpy as np
-from maskit.masks import MaskedCircuit, PerturbationAxis, PerturbationMode
+from maskit.masks import Mask, MaskedCircuit, PerturbationAxis... |
cirKITers__masKIT-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:init_parameters"
],
"edited_modules": [
"main.py:init_parameters"
]
},
"file": "main.py"
},
{
"changes": {
"added_entities": null,
"added_mo... | cirKITers/masKIT | 007673987180223931396b672c6c24d936dea5dc | Normalise predictions for cross entropy calculation
As discussed while implementing cross entropy in #38, we should add a normalisation of the predictions that probabilities add up to `1.0`:
> Adding a normalisation should be our best option.
_Originally posted by @cDenius in https://github.com/cirKITers/masKIT/p... | diff --git a/main.py b/main.py
index 0521fd0..0532b73 100644
--- a/main.py
+++ b/main.py
@@ -4,7 +4,7 @@ import random
import pennylane as qml
from pennylane import numpy as np
-from maskit.masks import MaskedCircuit, PerturbationAxis, PerturbationMode
+from maskit.masks import Mask, MaskedCircuit, PerturbationAxis... |
cirKITers__masKIT-46 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:train",
"main.py:test"
],
"edited_modules": [
"main.py:train",
"main.py:test"
]
},
"file": "main.py"
},
{
"changes": {
"added_enti... | cirKITers/masKIT | 441d44aa48a2929063185680d6085ed7d8589017 | Include number of shots in training parameters
Currently the number of shots is not parametrisable. This should be included into our training parameters for more flexibility during experiments. | diff --git a/main.py b/main.py
index 0532b73..2f8b8a6 100644
--- a/main.py
+++ b/main.py
@@ -86,7 +86,11 @@ def train(
wires = train_params["wires"]
layers = train_params["layers"]
steps = train_params.get("steps", 1000)
- dev = get_device(train_params.get("sim_local", True), wires=wires)
+ dev = g... |
cirKITers__masKIT-54 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"main.py:init_parameters",
"main.py:train"
],
"edited_modules": [
"main.py:init_parameters",
"main.py:train"
]
},
"file": "main.py"
},
{
"changes... | cirKITers/masKIT | 342378fdfc8affec5e30230628eb85cb5980ec04 | New PerturbationMode to change parameter values
It would be cool to have a `PertubationMode` that is not changing the number of gates in the circuit but changes the parameter value of gates by adding `pi` to its current value (and thereby inverting the rotation of the gate). | diff --git a/main.py b/main.py
index 43e0c63..1ae4861 100644
--- a/main.py
+++ b/main.py
@@ -5,7 +5,7 @@ import pennylane as qml
from pennylane import numpy as np
from maskit._masks import (
- Mask,
+ DropoutMask,
PerturbationAxis as Axis,
PerturbationMode as Mode,
)
@@ -70,10 +70,10 @@ def init_pa... |
cisagov__check-cve-2019-19781-10 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/check_cve/check.py:is_vulnerable"
],
"edited_modules": [
"src/check_cve/check.py:is_vulnerable"
]
},
"file": "src/check_cve/check.py"
}
] | cisagov/check-cve-2019-19781 | 4142e02b96a537a4be5d367d564e242d9e8d3a84 | UnicodeDecodeError: 'utf-8' codec can't decode byte 0xf6 in position 1144: invalid start byte
# 🐛 Bug Report
```console
$ cve-2019-19781 citrix.beispiel.de
Traceback (most recent call last):
File "/home/ehret/.local/bin/cve-2019-19781", line 11, in <module>
load_entry_point('cve-2019-19781', 'console_... | diff --git a/src/check_cve/check.py b/src/check_cve/check.py
index 25a8fab..ac27a0f 100755
--- a/src/check_cve/check.py
+++ b/src/check_cve/check.py
@@ -61,7 +61,7 @@ def is_vulnerable(host, retries=2, timeout=10):
logging.debug(f"Response status: {response.status}")
- decoded_data = response.data.decode()
... |
cisagov__ioc-scanner-5 | [
{
"changes": {
"added_entities": [
"src/ioc_scan/ioc_scanner.py:hash_file"
],
"added_modules": [
"src/ioc_scan/ioc_scanner.py:hash_file"
],
"edited_entities": [
"src/ioc_scan/ioc_scanner.py:main"
],
"edited_modules": [
"src/ioc_scan/ioc_s... | cisagov/ioc-scanner | e6bfb28c3ed13c4c9df9b93854fb3e6bd0454bf0 | Support hashes besides MD5
# 🚀 Feature Proposal
Add the ability to scan for other hash types besides MD5, such as SHA-1 and SHA-256.
## Motivation
When we are asked to scan for Indicators of Compromise (IOCs), we occasionally are given SHA-1 and SHA-256 hashes, in addition to MD5 hashes.
## Example
Samp... | diff --git a/src/ioc_scan/ioc_scanner.py b/src/ioc_scan/ioc_scanner.py
index 5d98b02..94cd952 100755
--- a/src/ioc_scan/ioc_scanner.py
+++ b/src/ioc_scan/ioc_scanner.py
@@ -11,11 +11,10 @@ This script should be run as a priveledged user.
from collections import defaultdict
from datetime import datetime
+import hash... |
cityofaustin__knackpy-110 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "knackpy/models.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"setup.py:build_con... | cityofaustin/knackpy | 0035913119e39a0c243603090370e862585a32ab | Knack formatting for equation type fields is not preserved
For equation fields, knackpy saves the same (raw) value as both the raw and formatted version of the value. However, the knack formatted version is preferred sometimes, such as when it is a datetime equation. The solution is likely to be adding a function for e... | diff --git a/coverage.svg b/coverage.svg
index ee07d4c..3438732 100644
--- a/coverage.svg
+++ b/coverage.svg
@@ -15,7 +15,7 @@
<g fill="#fff" text-anchor="middle" font-family="DejaVu Sans,Verdana,Geneva,sans-serif" font-size="11">
<text x="31.5" y="15" fill="#010101" fill-opacity=".3">coverage</text>
... |
civisanalytics__civis-python-300 | [
{
"changes": {
"added_entities": [
"civis/parallel.py:_CivisBackend.terminate"
],
"added_modules": null,
"edited_entities": [
"civis/parallel.py:_CivisBackendResult.get",
"civis/parallel.py:_CivisBackend.__init__"
],
"edited_modules": [
"civis/... | civisanalytics/civis-python | bdd0c664cb1e92da96e616fda183c262a41aee4f | Test with newer version of click and update dependencies
civis-python requires `click` version 6, but there's now a v7. We should test with it and update the `requirements.txt` file. | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4949c98..4f7926c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,13 +4,22 @@ This project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased
+### Fixed
+- Fix unintentional dependency on scikit-learn for `parallel` module tests. (#245, #303)
+
###... |
civisanalytics__civis-python-302 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"civis/base.py:Endpoint.__init__",
"civis/base.py:Endpoint._call_api"
],
"edited_modules": [
"civis/base.py:Endpoint"
]
},
"file": "civis/base.py"
},
{
"... | civisanalytics/civis-python | 7166c8782fe7e9bcf164e8365e15a7bb0cfdb79b | cache last response
It might be nice to save the last response in the `APIClient` class so that users could retrieve it if they forget to assign it when using the client in a REPL or notebook.
e.g.,
```
> client = civis.APIClient()
> client.scripts.post_containers(...)
> client.last_response
{"id": ..., }
`... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 061a244..9ee37b7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- `civis.io.dataframe_to_file` and `civis.io.json_to_file` convenience functions.
(#262, #304)
- Add the user's Python vers... |
civisanalytics__civis-python-316 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"civis/cli/__main__.py:make_operation_name",
"civis/cli/__main__.py:add_path_commands"
],
"edited_modules": [
"civis/cli/__main__.py:make_operation_name",
"civis/cli/_... | civisanalytics/civis-python | 84ecf67d98eef03078e68dbd1dc76d9c9f3a9f02 | CLI: GET /aliases/{alias} endpoint is inaccessible
The CLI emitted a confusing `UserWarning` of `UserWarning: conflicting command name: get` when I used the terminal command of `civis files download <file-id> <filename>`. This is the line that triggered the said `UserWarning`:
https://github.com/civisanalytics/civis... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1fbfc4f..4404411 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -23,6 +23,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- Deprecate the `headers` parameter of `dataframe_to_civis` and always tell Civis
whether the import has headers or not, r... |
civisanalytics__civis-python-353 | [
{
"changes": {
"added_entities": [
"civis/resources/_resources.py:deprecated_notice"
],
"added_modules": [
"civis/resources/_resources.py:deprecated_notice"
],
"edited_entities": [
"civis/resources/_resources.py:parse_method"
],
"edited_modules":... | civisanalytics/civis-python | dd27663851748fdfac7a29b7fc4cb496b1ba38b3 | Add `ignore_deprecated` flag to `APIClient`
The API client currently ignores any endpoints with a deprecation warning. This means that endpoints effectively cannot be deprecated-- once they are tagged deprecated, they are inaccessible from the client.
One option would be to automatically pull in these endpoints, whi... | diff --git a/civis/resources/_resources.py b/civis/resources/_resources.py
index 0a10aa3..cbe0ec5 100644
--- a/civis/resources/_resources.py
+++ b/civis/resources/_resources.py
@@ -132,6 +132,16 @@ def docs_from_properties(properties, level=0):
return docs
+def deprecated_notice(deprecation_warning):
+ """ ... |
civisanalytics__civis-python-474 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"civis/civis.py:find"
],
"edited_modules": [
"civis/civis.py:find"
]
},
"file": "civis/civis.py"
}
] | civisanalytics/civis-python | 3ec616bb9a37f8c09d13cca1f86cfcc7403d1fa7 | `civis.find` has unintuitive behavior with boolean kwargs
The `civis.find` (and `civis.find_one`) function allows users to filter a list of `Response` objects for user-supplied attribute/value pairs. However, the behavior when given a keyword argument with a boolean value is different than when given a keyword argument... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5dcc23a..6ea90be 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -22,6 +22,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
Also dropped the deprecated methods in `ServiceClient`. (#471)
- The `return_type` parameter of a `civis.response.Resp... |
civisanalytics__civis-python-491 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/civis/client.py:APIClient.__init__"
],
"edited_modules": [
"src/civis/client.py:APIClient"
]
},
"file": "src/civis/client.py"
},
{
"changes": {
"added... | civisanalytics/civis-python | d6f10c0f59b4b156ea9b1216257da0f55443a89e | Caching confusion in the client
Heard of a use case recently where a user had a notebook instance open for a while and ran into an issue with caching. The user called `APIClient(resources='all')` but did not see new endpoints they expected to see (because they already called it earlier and the results were cached befo... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2a4adde..1c18ab7 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -17,6 +17,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Bumped the minimum required version of `joblib` to v1.3.0,
which is the version where `joblib.parallel_config` was i... |
civisanalytics__civisml-extensions-22 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"civismlext/stacking.py:BaseStackedModel._base_est_fit_predict"
],
"edited_modules": [
"civismlext/stacking.py:BaseStackedModel"
]
},
"file": "civismlext/stacking.py"
... | civisanalytics/civisml-extensions | 8f4b19e074bace3172269bdce3c16bd3dd242256 | `_base_est_fit_predict` looks wrong
I believe cv.split(X, y) might give different results when called at different times. There might be randomness involved like shuffling, etc.
This is problematic because `ybase`, which is based on the old `train` & `test` but not coincide with with the new `test` and therefore `y[... | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6344c7c..c527285 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## Unreleased
+### Fixed
+- Now caching CV indices. When CV generators are passed with `shuffle=True` and
+ no `rando... |
claranet__ssha-63 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"ssha/ec2.py:_rules_pass"
],
"edited_modules": [
"ssha/ec2.py:_rules_pass"
]
},
"file": "ssha/ec2.py"
}
] | claranet/ssha | 66de5fc0b726aaf076b57c843f7e7d04dbd9641c | Exclude instances
The `discover` and `bastion` blocks allow filters on tags and such. It could be useful to exclude instances with certain tags too. | diff --git a/README.md b/README.md
index ca01c66..5031e43 100644
--- a/README.md
+++ b/README.md
@@ -130,7 +130,13 @@ discover {
name of the config that was selected by the user.
*/
Environment = "${config.name}"
- Service = "bastion"
+ }
+
+ /*
+ TagsNotEqual can be used to exclu... |
clarketm__wait-for-it-26 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"wait_for_it/wait_for_it.py:_wait_until_available"
],
"edited_modules": [
"wait_for_it/wait_for_it.py:_wait_until_available"
]
},
"file": "wait_for_it/wait_for_it.py"
... | clarketm/wait-for-it | 6d21debe387243e646be8f61f780a360b8e11429 | Exception when connecting to an unreachable local host.
```console
wait-for-it -s localhost:1234
```
```
[*] Waiting 15 seconds for localhost:1234
Traceback (most recent call last):
File "/usr/local/bin/wait-for-it", line 8, in <module>
sys.exit(cli())
File "/usr/local/lib/python3.8/site-packages/click/... | diff --git a/wait_for_it/wait_for_it.py b/wait_for_it/wait_for_it.py
index b9f7549..95e856a 100644
--- a/wait_for_it/wait_for_it.py
+++ b/wait_for_it/wait_for_it.py
@@ -54,7 +54,7 @@ async def _wait_until_available(host, port):
if sys.version_info[:2] >= (3, 7):
await writer.wait_closed()
... |
claudep__swiss-qr-bill-49 | [
{
"changes": {
"added_entities": [
"qrbill/bill.py:Address._split_lines"
],
"added_modules": null,
"edited_entities": [
"qrbill/bill.py:CombinedAddress.as_paragraph",
"qrbill/bill.py:StructuredAddress.as_paragraph",
"qrbill/bill.py:QRBill.draw_bill",
... | claudep/swiss-qr-bill | c287ef717e8cac3f178c2a40cb630aa795d7bb07 | newline
Hi,
super project, we will integrate in our access database in order to generate qrr bills.
One problem arises from the fact that our receipt name is very long (an association) and we would like to know how we could split the name in two lines. I attach our example
# Annex... |
claudep__swiss-qr-bill-63 | [
{
"changes": {
"added_entities": [
"qrbill/bill.py:QRBill.title_font_info",
"qrbill/bill.py:QRBill.font_info",
"qrbill/bill.py:QRBill.head_font_info",
"qrbill/bill.py:QRBill.proc_font_info"
],
"added_modules": null,
"edited_entities": [
"qrbill/bil... | claudep/swiss-qr-bill | e810120de71ea0f2944a3ae3302e8debc2c8392e | Add a font factor parameter
In certain cases, the font sizes may be judged a bit too small or too large. Adding a font-factor parameter could allow the user to specify a custom scaling factor for fonts. | diff --git a/qrbill/bill.py b/qrbill/bill.py
index a175623..7f6c186 100644
--- a/qrbill/bill.py
+++ b/qrbill/bill.py
@@ -198,15 +198,10 @@ class QRBill:
# QR reference, Creditor Reference (ISO 11649), without reference
reference_types = ('QRR', 'SCOR', 'NON')
- title_font_info = {'font_size': 12, 'font_f... |
claudep__swiss-qr-bill-76 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"qrbill/bill.py:QRBill.draw_bill"
],
"edited_modules": [
"qrbill/bill.py:QRBill"
]
},
"file": "qrbill/bill.py"
}
] | claudep/swiss-qr-bill | 1945115b01638f8b2344a62979bb9cfe3e36db4f | postfinance doesnt accept generated qr-code
Hi, our postfinance doesnt accept our generated qr-code because there are characters in line 30 that are not allowed (extra_infos, '##' character for visual line split). Is it possible to remove the character after line split (line 680 in bill.py)? Currently its readded after... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index e03592e..d2906f1 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -3,6 +3,10 @@
ChangeLog
=========
+Unreleased
+----------
+- Replaced ``##`` with ``//`` as separator in additional informations (#75).
+
0.7.1 (2022-03-07)
------------------
- Fixed bad position ... |
claudep__swiss-qr-bill-77 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"qrbill/bill.py:QRBill.as_svg",
"qrbill/bill.py:QRBill.transform_to_full_page",
"qrbill/bill.py:QRBill.draw_bill"
],
"edited_modules": [
"qrbill/bill.py:QRBill"
... | claudep/swiss-qr-bill | ca496deaef5cd52a16677b101c6cbb1a07ff3c8c | Scissors missing on top seperation line
Currently the scissor is only shown on the vertical seperation line. However; in the standard it says that a scissor symbol should appear on both of those lines.
I tried adding it to the top line, but my attempt doesn't look great:
```python
grp.add(dwg.text(
... | diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index d2906f1..ab31a95 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -6,6 +6,9 @@ ChangeLog
Unreleased
----------
- Replaced ``##`` with ``//`` as separator in additional informations (#75).
+- Print scissors symbol on horizontal separation line when not in full page.
+... |
claudep__swiss-qr-bill-87 | [
{
"changes": {
"added_entities": [
"qrbill/bill.py:replace_linebreaks"
],
"added_modules": [
"qrbill/bill.py:replace_linebreaks"
],
"edited_entities": [
"qrbill/bill.py:QRBill.qr_data",
"qrbill/bill.py:wrap_infos"
],
"edited_modules": [
... | claudep/swiss-qr-bill | eb12fae5e39cbd10e6d82adbf6a3736363f8def8 | line break in additional_information isnt shown and breaks many scanners
Providing a line break character "\n" in the string for the additional_information parameter will cause problems with many scanners.
steps to reproduce:
QRBill(additional_information= f"Hello \n Line break")
The line break will not be vi... | diff --git a/qrbill/bill.py b/qrbill/bill.py
index 53bee98..4b1ca0c 100644
--- a/qrbill/bill.py
+++ b/qrbill/bill.py
@@ -404,7 +404,7 @@ class QRBill:
values.extend([
self.ref_type or '',
self.reference_number or '',
- self.additional_information or '',
+ replace... |
claws__aioprometheus-29 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/aioprometheus/__init__.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ai... | claws/aioprometheus | 6473101aedc9ace15e781ef896a510134032467c | Histograms are not compatible with prometheus histogram_quantile()
Prometheus histograms are meant to be cumulative. In addition the format specifies that buckets should be ordered so +Inf should be last and +Inf should match _count.
More information can be found here: https://github.com/prometheus/prometheus/issue... | diff --git a/docs/dev/index.rst b/docs/dev/index.rst
index b1c958c..b37444d 100644
--- a/docs/dev/index.rst
+++ b/docs/dev/index.rst
@@ -39,7 +39,7 @@ commands are pointing at the correct tools.
$ python -m venv myvenv
$ cd myvenv
$ source bin/activate
- $ cd ..
+ (myvenv) $ cd ..
To exit the vi... |
cldf__csvw-33 | [
{
"changes": {
"added_entities": [
"src/csvw/metadata.py:Schema.fromvalue"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/csvw/metadata.py:Schema"
]
},
"file": "src/csvw/metadata.py"
}
] | cldf/csvw | 0eccd438b6770ad628223f77a582b55067b06002 | Support for remote table schemas?
CSV on the Web officially specifies that table schemas can be metadata files remotely located on the Web via a URL, see definition from the [spec](https://www.w3.org/TR/tabular-metadata/):
> `tableSchema`: An object property that provides a single schema description as described in ... | diff --git a/src/csvw/metadata.py b/src/csvw/metadata.py
index 6f17514..3467529 100644
--- a/src/csvw/metadata.py
+++ b/src/csvw/metadata.py
@@ -16,6 +16,7 @@ import warnings
import itertools
import collections
from urllib.parse import urljoin
+from urllib.request import urlopen
from ._compat import pathlib, py3_... |
cldf__csvw-51 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/csvw/frictionless.py:convert_dialect"
],
"edited_modules": [
"src/csvw/frictionless.py:convert_dialect"
]
},
"file": "src/csvw/frictionless.py"
},
{
"change... | cldf/csvw | 76b503d5c049bbe6f136a3fea4202ae991cde300 | Add support for reading metadata and data from URLs | diff --git a/src/csvw/frictionless.py b/src/csvw/frictionless.py
index eca4f22..2341419 100644
--- a/src/csvw/frictionless.py
+++ b/src/csvw/frictionless.py
@@ -125,6 +125,8 @@ def convert_table_schema(rsc_name, schema, resource_map):
def convert_dialect(rsc):
"""
+ Limitations: lineTerminator is not support... |
cldf__csvw-65 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/csvw/datatypes.py:nonNegativeInteger",
"src/csvw/datatypes.py:positiveInteger"
]
},
"file": "src/csvw/datatypes.py"
}
] | cldf/csvw | 71abb843f078aa6b11c5f9df775baf8412992b03 | Wrong range for nonNegative- and positiveInteger
See
https://github.com/cldf/csvw/blob/71abb843f078aa6b11c5f9df775baf8412992b03/src/csvw/datatypes.py#L755-L770 | diff --git a/CHANGES b/CHANGES
index d673e5f..2045c52 100644
--- a/CHANGES
+++ b/CHANGES
@@ -4,6 +4,8 @@ Changelog
Unreleased
----------
+- Fixed the ranges of positiveInteger and nonNegativeInteger
+
Version 3.1
-----------
diff --git a/src/csvw/datatypes.py b/src/csvw/datatypes.py
index 775d52e..4730ed3 10064... |
cldf__pycldf-134 | [
{
"changes": {
"added_entities": [
"src/pycldf/dataset.py:Dataset.get_foreign_key_reference"
],
"added_modules": null,
"edited_entities": [
"src/pycldf/dataset.py:Dataset.__getitem__"
],
"edited_modules": [
"src/pycldf/dataset.py:Dataset"
]
}... | cldf/pycldf | e9da4b86dab0e2517642886fe5c6fce92216f852 | Getting the target of a foreign key
I have just tried to update some script to impement what we clarified in the preparation for 1.1, that explicit foreign keys have precedence and do not need to point to ID columns.
The best way I could come up with (commas for tuple unpacking, because all the RHSs of the assigment a... | diff --git a/src/pycldf/dataset.py b/src/pycldf/dataset.py
index dda51be..1355bfc 100644
--- a/src/pycldf/dataset.py
+++ b/src/pycldf/dataset.py
@@ -626,6 +626,9 @@ class Dataset(object):
else:
table, column = item, None
+ if isinstance(table, Link):
+ table = table.string
+
... |
cleder__fastkml-192 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fastkml/data.py:Schema.__init__",
"fastkml/data.py:Schema.simple_fields",
"fastkml/data.py:Schema.append",
"fastkml/data.py:Schema.from_element",
"fastkml/data.py:Schema.... | cleder/fastkml | 2a043bb44319c8c3563fcab42b4982ef80ca892a | Type annotate fastkml.data
Correct and improve the type annotations of the file `fastkml/data.py` so that the `pyproject.toml` directive to exclude this file from `mypy` can be dropped | diff --git a/fastkml/data.py b/fastkml/data.py
index 4e29c3e..c96e631 100644
--- a/fastkml/data.py
+++ b/fastkml/data.py
@@ -1,7 +1,9 @@
+from typing import Dict
from typing import List
from typing import Optional
from typing import Tuple
from typing import Union
+from typing import overload
from typing_extensio... |
cleder__fastkml-223 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fastkml/data.py:Schema.append"
],
"edited_modules": [
"fastkml/data.py:Schema"
]
},
"file": "fastkml/data.py"
}
] | cleder/fastkml | a5f27e82f8b3dfe8408c208bfb517f8bc9dc6d78 | TypeError (TypeError: type must be one of 'string', 'int', 'uint', 'short', 'ushort', 'float', 'double', 'bool')
`No handlers could be found for logger "fastkml.config"
Traceback (most recent call last):
File "/private/var/mobile/Containers/Shared/AppGroup/AA78F2EC-3EE8-40F4-A318-8A9AB1BCB5FF/Pythonista3/Documents/ce... | diff --git a/fastkml/data.py b/fastkml/data.py
index 18ace77..4510fe1 100644
--- a/fastkml/data.py
+++ b/fastkml/data.py
@@ -14,6 +14,7 @@
# along with this library; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
"""Add Custom Data"""
+import loggin... |
cleder__fastkml-226 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"fastkml/geometry.py:Geometry._get_multigeometry"
],
"edited_modules": [
"fastkml/geometry.py:Geometry"
]
},
"file": "fastkml/geometry.py"
}
] | cleder/fastkml | 6bb9374d0704d332be7918c97600e2aacf1dea33 | Wrong parsing of MultiGeometry when containing nested MultiGeometry
When parsing e.g. https://developers.google.com/kml/documentation/us_states.kml, there is a bug because you do not allow a MultiGeometry (which you consider a Geometry) to contain another MultiGeometry. The nested MultiGeometry in the US state placehol... | diff --git a/fastkml/geometry.py b/fastkml/geometry.py
index 62b0c5a..3e337f9 100644
--- a/fastkml/geometry.py
+++ b/fastkml/geometry.py
@@ -406,6 +406,11 @@ class Geometry(_BaseObject):
# MultiGeometry
geoms: List[Union[AnyGeometryType, None]] = []
if element.tag == f"{self.ns}MultiGeometry"... |
click-contrib__click-aliases-3 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"click_aliases/__init__.py:ClickAliasedGroup.format_commands"
],
"edited_modules": [
"click_aliases/__init__.py:ClickAliasedGroup"
]
},
"file": "click_aliases/__init__.p... | click-contrib/click-aliases | 6fdb266540eab2e295363b6459e18cf110117fb3 | Broken with click 7
https://travis-ci.org/jayvdb/click-aliases/jobs/568251511
```
runner = <click.testing.CliRunner object at 0x7fb65f97a550>
def test_cli(runner):
result = runner.invoke(cli)
> assert result.output == TEST_CLI
E AssertionError: assert 'Usage: cli [... ship (boat)\n' == 'Us... | diff --git a/.travis.yml b/.travis.yml
index 6144ff7..d4504af 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -18,6 +18,8 @@ install:
script:
- flake8 click_aliases examples tests setup.py -v --show-source
- py.test tests --cov click_aliases --cov-report term-missing
+ - pip install 'click>6,<7'
+ - py.test test... |
click-contrib__sphinx-click-94 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"sphinx_click/ext.py:_get_help_record"
],
"edited_modules": [
"sphinx_click/ext.py:_get_help_record"
]
},
"file": "sphinx_click/ext.py"
}
] | click-contrib/sphinx-click | b9ce52d554c6a6fcf808cd77fc561954a8b9833f | Display `show_default` string even when `default=None`
# Current behavior
The option
```python
@click.option('--foo', show_default='mydefault')
```
will not have a default documented
# Expected behavior
The text `mydefault` is documented as the default value for this option.
# What now?
Looking a... | diff --git a/sphinx_click/ext.py b/sphinx_click/ext.py
index be645ab..4441588 100644
--- a/sphinx_click/ext.py
+++ b/sphinx_click/ext.py
@@ -73,21 +73,20 @@ def _get_help_record(opt):
extras = []
- if opt.default is not None and opt.show_default:
- if isinstance(opt.show_default, str):
- #... |
climlab__climlab-188 | [
{
"changes": {
"added_entities": [
"climlab/solar/insolation.py:_compute_insolation_Berger",
"climlab/solar/insolation.py:_standardize_inputs"
],
"added_modules": [
"climlab/solar/insolation.py:_compute_insolation_Berger",
"climlab/solar/insolation.py:_standardi... | climlab/climlab | f58430559bb6948be714ab1ec42d49a3b6e44002 | Inconsistent units for solar longitude
The function `climlab.solar.insolation.solar_longitude()` returns a value in radians.
But if you want to use these values to compute insolation, you need to call the function `climlab.solar.insolation.daily_insolation(..., day_type=2)`
But the code then applies `np.deg2rad()` ... | diff --git a/climlab/solar/insolation.py b/climlab/solar/insolation.py
index f2f06ba..77d888d 100644
--- a/climlab/solar/insolation.py
+++ b/climlab/solar/insolation.py
@@ -42,8 +42,12 @@ from climlab import constants as const
from numpy import sqrt, deg2rad, rad2deg, sin, cos, tan, arcsin, arccos, pi
import xarray a... |
climlab__climlab-251 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"climlab/radiation/absorbed_shorwave.py:SimpleAbsorbedShortwave._compute_heating_rates"
],
"edited_modules": [
"climlab/radiation/absorbed_shorwave.py:SimpleAbsorbedShortwave"
]... | climlab/climlab | a989959c304021f2312f8d9e931e952568b4a375 | Diagnostics failure for a simple EBM
This minimal zero-dimensional EBM configuration is currently failing:
```
import climlab
state = climlab.surface_state(num_lat=1)
olr = climlab.radiation.Boltzmann(state=state, name='OutgoingLongwave')
asr = climlab.radiation.SimpleAbsorbedShortwave(state=state, name='AbsorbedShort... | diff --git a/climlab/radiation/absorbed_shorwave.py b/climlab/radiation/absorbed_shorwave.py
index c7930a0..1ec249a 100644
--- a/climlab/radiation/absorbed_shorwave.py
+++ b/climlab/radiation/absorbed_shorwave.py
@@ -29,5 +29,5 @@ class SimpleAbsorbedShortwave(EnergyBudget):
self.topdown = False # call subpro... |
clld__clldutils-20 | [
{
"changes": {
"added_entities": [
"clldutils/path.py:sys_path",
"clldutils/path.py:import_module"
],
"added_modules": [
"clldutils/path.py:sys_path",
"clldutils/path.py:import_module"
],
"edited_entities": null,
"edited_modules": null
},
... | clld/clldutils | cebffac35a42bde46fcd32d2db4a0fd5464968a3 | context manager to temporarily adapt `sys.path`
For several projects we want to be able to import custom code not within a python package. The most convenient (and portable) way to this seems to be via a context manager, adapting `sys.path` appropriately:
```python
@contextmanager
def with_sys_path(d):
p = d.as... | diff --git a/clldutils/misc.py b/clldutils/misc.py
index 7979814..c97f5b3 100644
--- a/clldutils/misc.py
+++ b/clldutils/misc.py
@@ -9,9 +9,6 @@ from string import ascii_letters
from six import PY3, string_types, text_type, binary_type
-# FIXME: add: badge, Stats
-
-
def nfilter(seq):
"""Replacement for pyth... |
clld__clldutils-26 | [
{
"changes": {
"added_entities": [
"clldutils/clilib.py:Command.__init__",
"clldutils/clilib.py:Command.doc",
"clldutils/clilib.py:Command.__call__",
"clldutils/clilib.py:command",
"clldutils/clilib.py:_attr"
],
"added_modules": [
"clldutils/clil... | clld/clldutils | e1655578301e446ca5ec645b1ce1407dd083b56d | `clilib` allow custom names for sub-commands passed to ArgumentParser
Right now, subcommand names for `clilib.ArgumentParser` can only be function names. Thus, reserved words like `class` are impossible and names like `list` would cause shadowing of built-ins where the function is defined. So there should be a way to r... | diff --git a/clldutils/clilib.py b/clldutils/clilib.py
index f2851d4..3df3c0d 100644
--- a/clldutils/clilib.py
+++ b/clldutils/clilib.py
@@ -10,17 +10,53 @@ class ParserError(Exception):
pass
+# Global registry for commands.
+# Note: This registry is global so it can only be used for one ArgumentParser instanc... |
clld__clldutils-27 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"clldutils/badge.py:badge"
],
"edited_modules": [
"clldutils/badge.py:badge"
]
},
"file": "clldutils/badge.py"
}
] | clld/clldutils | 54679df634b93870ea9fec722a56b75e72017645 | The `badge` function should be more flexible
`badge.badge` should accept all atomic parts of the label/URL it creates as input argument; such that it exposes all functionality of the `shields.io` service. | diff --git a/clldutils/badge.py b/clldutils/badge.py
index 14829b5..a74fca1 100644
--- a/clldutils/badge.py
+++ b/clldutils/badge.py
@@ -19,12 +19,8 @@ class Colors(object):
blue = 'blue'
-def badge(subject, status, color, fmt='svg', markdown=True, **kw):
- query = ''
- if kw:
- query = '?' + urle... |
closeio__freezefrog-3 | [
{
"changes": {
"added_entities": [
"freezefrog/__init__.py:FakeDateTime.now"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"freezefrog/__init__.py:FakeDateTime"
]
},
"file": "freezefrog/__init__.py"
}
] | closeio/freezefrog | c7089ad8d9b3900f2528a94b43bfc842f62023c9 | FreezeFrog should also mock datetime.datetime.now
FreezeFrog should raise an exception when datetime.datetime.now() is used without a TZ instead of not mocking it at all.
| diff --git a/freezefrog/__init__.py b/freezefrog/__init__.py
index 44a232a..60463f3 100644
--- a/freezefrog/__init__.py
+++ b/freezefrog/__init__.py
@@ -47,6 +47,12 @@ class FakeDateTime(with_metaclass(FakeDateTimeMeta, real_datetime)):
cls._start = real_datetime.utcnow()
return (real_datetime.utc... |
cloud-custodian__cloud-custodian-4846 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"c7n/resources/awslambda.py:KmsFilter"
],
"edited_entities": null,
"edited_modules": null
},
"file": "c7n/resources/awslambda.py"
},
{
"changes": {
"added_entities": [
"c7n/resources/vpc... | cloud-custodian/cloud-custodian | 91f2016bfe3a595ec2b0a73695ebce8ad962175c | aws - VPC Security Group filters "used" / "unused" and ECS Scheduled Tasks
I just found that those filters were not taking into account the ECS Scheduled Tasks (which do have a Security Group info).
I'm preparing a Pull Request with a proposed workaround. | diff --git a/c7n/resources/awslambda.py b/c7n/resources/awslambda.py
index be593671e..be91fdaa4 100644
--- a/c7n/resources/awslambda.py
+++ b/c7n/resources/awslambda.py
@@ -21,6 +21,7 @@ from concurrent.futures import as_completed
from c7n.actions import BaseAction, RemovePolicyBase, ModifyVpcSecurityGroupsAction
f... |
cloud-custodian__cloud-custodian-5319 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/executor.py:ExecutorRegistry.__init__",
"c7n/executor.py:executor"
],
"edited_modules": [
"c7n/executor.py:ExecutorRegistry",
"c7n/executor.py:executor"
]
... | cloud-custodian/cloud-custodian | fac80370b42016d90db9c723d108aac5f82dcdd8 | ElastiCache - Add support for replication-groups resources
@kapilt Currently ElastiCache only can see resources that are created in a 'Cluster' mode. If creating an ElastiCache NOT in cluster mode, c7n doesn't pick it up as it is a resource type of **replication-group** and would need to be able to pickup the replicat... | diff --git a/c7n/executor.py b/c7n/executor.py
index b5333fca2..cb1577034 100644
--- a/c7n/executor.py
+++ b/c7n/executor.py
@@ -13,33 +13,11 @@
# limitations under the License.
from __future__ import absolute_import, division, print_function, unicode_literals
-from concurrent.futures import (
- ProcessPoolExecu... |
cloud-custodian__cloud-custodian-5472 | [
{
"changes": {
"added_entities": [
"c7n/resources/ec2.py:SsmCompliance.process"
],
"added_modules": [
"c7n/resources/ec2.py:SsmCompliance"
],
"edited_entities": null,
"edited_modules": null
},
"file": "c7n/resources/ec2.py"
}
] | cloud-custodian/cloud-custodian | d3596445a82b76a722dc3244bb18770258109a8a | AWS.EC2 - SSM Compliance Support via Config-Filter
**Description**
Currently, you cannot leverage config-filter to query SSM Patch Compliance or SSM Association Compliance. This is because Custodian queries config for `AWS::EC2::Instance` type which does not expose SSM compliance status. The two types for querying SS... | diff --git a/c7n/resources/ec2.py b/c7n/resources/ec2.py
index abd9a5b64..f83ccdb9b 100644
--- a/c7n/resources/ec2.py
+++ b/c7n/resources/ec2.py
@@ -920,6 +920,112 @@ class SsmStatus(ValueFilter):
r[self.annotation] = info_map.get(r['InstanceId'], {})
+@EC2.filter_registry.register('ssm-compliance')
+c... |
cloud-custodian__cloud-custodian-5526 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"c7n/resources/dms.py:DmsEndpoints"
]
},
"file": "c7n/resources/dms.py"
}
] | cloud-custodian/cloud-custodian | 5f0b86d17ba7056759e2987d01b827d2267e44c5 | Cannot filter dms-endpoints on tags
**Describe the bug**
I would like to try and check dms-endpoint resources for tag compliance. For example I want to be able to check to see if the Owner tag exists. When I write a policy to check for such a tag, it returns all dms-endpoint resources, regardless of whether the Owne... | diff --git a/c7n/resources/dms.py b/c7n/resources/dms.py
index 924327f2f..e72afdbdd 100644
--- a/c7n/resources/dms.py
+++ b/c7n/resources/dms.py
@@ -21,7 +21,7 @@ from c7n.utils import local_session, chunks, type_schema, get_retry
from c7n.filters.vpc import SecurityGroupFilter, SubnetFilter, VpcFilter
from c7n.filte... |
cloud-custodian__cloud-custodian-5531 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"c7n/resources/dms.py:DmsEndpoints"
]
},
"file": "c7n/resources/dms.py"
},
{
"changes": {
"added_entities": [
"c7n/resources/iam.py:Check... | cloud-custodian/cloud-custodian | 5f0b86d17ba7056759e2987d01b827d2267e44c5 | aws - check-permissions - support permission boundaries
aws iam policy simulator supports permission boundaries as of january, 2020
https://awsapichanges.info/archive/changes/98b098-iam.html
check-permissions filter should utilize that on applicable iam resources (user, role).
| diff --git a/c7n/resources/dms.py b/c7n/resources/dms.py
index 924327f2f..e72afdbdd 100644
--- a/c7n/resources/dms.py
+++ b/c7n/resources/dms.py
@@ -21,7 +21,7 @@ from c7n.utils import local_session, chunks, type_schema, get_retry
from c7n.filters.vpc import SecurityGroupFilter, SubnetFilter, VpcFilter
from c7n.filte... |
cloud-custodian__cloud-custodian-5532 | [
{
"changes": {
"added_entities": [
"c7n/resources/iam.py:SetBoundary.validate",
"c7n/resources/iam.py:SetBoundary.process",
"c7n/resources/iam.py:SetBoundary.get_method",
"c7n/resources/iam.py:RoleSetBoundary.get_permissions",
"c7n/resources/iam.py:RoleSetBoundary.g... | cloud-custodian/cloud-custodian | c9a61ade52b5d6eb4c32ede4e2c69220ea38bcd7 | Permissions Boundary Policy support for AWS IAM Roles
Problem Statement:
There doesn't appear to a c7n action that can manage permissions boundary policies for IAM roles.
Proposed Solution:
A solution to this would likely look very similar to the aws.iam-role action called set-policy where instead of making call... | diff --git a/c7n/resources/iam.py b/c7n/resources/iam.py
index f7d933969..1b507dfa3 100644
--- a/c7n/resources/iam.py
+++ b/c7n/resources/iam.py
@@ -38,7 +38,8 @@ from c7n.manager import resources
from c7n.query import QueryResourceManager, DescribeSource, TypeInfo
from c7n.resolver import ValuesFrom
from c7n.tags i... |
cloud-custodian__cloud-custodian-5548 | [
{
"changes": {
"added_entities": [
"c7n/resolver.py:ValuesFrom._get_values"
],
"added_modules": null,
"edited_entities": [
"c7n/resolver.py:URIResolver.resolve",
"c7n/resolver.py:ValuesFrom.__init__",
"c7n/resolver.py:ValuesFrom.get_values"
],
... | cloud-custodian/cloud-custodian | 5c04cde01fe62e15ad99f969289a41c833b6a72e | filter using value_from takes excessively long
**Describe the bug**
We have a security-group ingress filter that uses `value_from` to pull a list of cidr values from a url. This causes the filtering step to take roughly 15 seconds to filter 34 security groups. If I replace this with a `value` with a list of cidr add... | diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
index ffb2b7e31..07eb3a816 100644
--- a/.azure-pipelines.yml
+++ b/.azure-pipelines.yml
@@ -3,150 +3,26 @@ trigger:
variables:
- group: CustodianCoreCI
-- name: WINDOWS_CACHE_DIR
- value: $(LOCALAPPDATA)\pip\cache
jobs:
-- job: 'Lint'
- pool:
- vmIm... |
cloud-custodian__cloud-custodian-5570 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/ami.py:AMI.resources"
],
"edited_modules": [
"c7n/resources/ami.py:AMI"
]
},
"file": "c7n/resources/ami.py"
},
{
"changes": {
"added_entitie... | cloud-custodian/cloud-custodian | 66e4d8718884829ce3e398a3467c16a534d0a917 | Cannot set Owners for aws.ami resource
**Describe the bug**
My intent is to search all canonical public AMIs and return the most recent ones that match my filter.
I'm unable to set the `Owners` key for `aws.ami`.
I'm also unable to find documentation on `Owners` key.
**To Reproduce**
Run policy
```
cu... | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index ee257d316..889b48bf0 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -62,7 +62,7 @@ jobs:
python tools/dev/dockerpkg.py build --scan --test -r cloudcustodian -i policystream
- "Publish Distrole... |
cloud-custodian__cloud-custodian-5595 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/ecr.py:lifecycle_rule_validate"
],
"edited_modules": [
"c7n/resources/ecr.py:lifecycle_rule_validate"
]
},
"file": "c7n/resources/ecr.py"
}
] | cloud-custodian/cloud-custodian | 577aefaf34557a445470be106c954e5d667dc36e | aws: ecr.actions.set-lifecycle's countUnit says it is required for countType imageCountMoreThan
**Describe the bug**
ecr.actions.set-lifecycle's countUnit says it is required for countType imageCountMoreThan when it should only used when the countType is set to sinceImagePushed.
> The tagPrefixList parameter is onl... | diff --git a/c7n/resources/ecr.py b/c7n/resources/ecr.py
index b2c8d8ae7..057232940 100644
--- a/c7n/resources/ecr.py
+++ b/c7n/resources/ecr.py
@@ -174,7 +174,7 @@ LIFECYCLE_RULE_SCHEMA = {
'selection': {
'type': 'object',
'addtionalProperties': False,
- 'required': ['coun... |
cloud-custodian__cloud-custodian-5615 | [
{
"changes": {
"added_entities": [
"c7n/resources/account.py:ServiceLimit.get_available_checks",
"c7n/resources/account.py:ServiceLimit.match_patterns_to_value",
"c7n/resources/account.py:ServiceLimit.should_process",
"c7n/resources/account.py:ServiceLimit.process_check"
... | cloud-custodian/cloud-custodian | 414b4624cb6999958c471adc5520b0e4c572ebe6 | tools/c7n-org - azure subscription generation includes disabled subscriptions
per report on gitter.
ngibbondaimler - We used azuresubs.py from c7n-org to generate a list of our subscriptions, however it's picking up disabled subscriptions and c7n-org throws an exception when it tries to read from a disabled sub to... | diff --git a/c7n/resources/account.py b/c7n/resources/account.py
index 6ffabd631..826d3fb19 100644
--- a/c7n/resources/account.py
+++ b/c7n/resources/account.py
@@ -15,9 +15,9 @@
"""
import json
import time
+import datetime
from botocore.exceptions import ClientError
-from datetime import datetime, timedelta
-
+fro... |
cloud-custodian__cloud-custodian-5616 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/aws.py:join_output"
],
"edited_modules": [
"c7n/resources/aws.py:join_output"
]
},
"file": "c7n/resources/aws.py"
}
] | cloud-custodian/cloud-custodian | 80a8bbdb99472241754781a08945df9fe6bcd73c | aws - custom log/output directories with --region all
**Describe the bug**
--region all unconditionally suffixes a region, even though it may already be present in a custom output/format string. it should detect output region usage and avoid the suffix.
| diff --git a/c7n/resources/aws.py b/c7n/resources/aws.py
index b8acc3716..2b2bdd63b 100644
--- a/c7n/resources/aws.py
+++ b/c7n/resources/aws.py
@@ -639,7 +639,7 @@ class AWS(Provider):
"""Return a set of policies targetted to the given regions.
Supports symbolic regions like 'all'. This will automa... |
cloud-custodian__cloud-custodian-5640 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/asg.py:LaunchInfo.get_launch_id"
],
"edited_modules": [
"c7n/resources/asg.py:LaunchInfo"
]
},
"file": "c7n/resources/asg.py"
},
{
"changes": {
... | cloud-custodian/cloud-custodian | 898910ea9fb3643a72a88ff3ff839d4c75dd1eed | rds-cluster-snapshot
**Is your feature request related to a problem? Please describe.**
No, It's an enhancement
**Describe the solution you'd like**
Need Cross-account filters on AWS RDS Cluster Snapshots.
**Describe alternatives you've considered**
I modified custodian code until it gets fixed.
**Additiona... | diff --git a/c7n/resources/asg.py b/c7n/resources/asg.py
index 80ebf7e4e..be7a1a2c3 100644
--- a/c7n/resources/asg.py
+++ b/c7n/resources/asg.py
@@ -121,12 +121,12 @@ class LaunchInfo:
lid = asg.get('LaunchTemplate')
if lid is not None:
- return (lid['LaunchTemplateId'], lid['Version'])
+... |
cloud-custodian__cloud-custodian-5645 | [
{
"changes": {
"added_entities": [
"c7n/resources/emr.py:EMRSecurityConfiguration.augment",
"c7n/resources/emr.py:DeleteEMRSecurityConfiguration.process"
],
"added_modules": [
"c7n/resources/emr.py:EMRSecurityConfiguration",
"c7n/resources/emr.py:DeleteEMRSecuri... | cloud-custodian/cloud-custodian | b3f4660c3b1104e00f1a63fc6142aa0b3589e199 | aws - set-vpc-flow log support create log group if not exists
For enabling VPC flow-logs through Custodian, If the LogGroup doesn't exist Custodian should create a LogGroup before enabling VPC flow-logs. | diff --git a/c7n/resources/emr.py b/c7n/resources/emr.py
index dafd6ef5f..ab2f9ce2d 100644
--- a/c7n/resources/emr.py
+++ b/c7n/resources/emr.py
@@ -13,6 +13,7 @@
# limitations under the License.
import logging
import time
+import json
import six
@@ -284,3 +285,41 @@ class QueryFilter:
value = [sel... |
cloud-custodian__cloud-custodian-5676 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/query.py:ChildResourceQuery.filter"
],
"edited_modules": [
"c7n/query.py:ChildResourceQuery"
]
},
"file": "c7n/query.py"
},
{
"changes": {
"added_enti... | cloud-custodian/cloud-custodian | b341b670cfc02564e09ecc80260f73d862f26195 | cloudwatch event-rule tagging
**Is your feature request related to a problem? Please describe.**
It would be nice if Custodian support event rule tagging.
policies:
- name: event-rule-tag
resource: event-rule
filters:
- type: value
key: RuleName
value: custodian
value_type... | diff --git a/Makefile b/Makefile
index c2b37e65a..fe9cd569a 100644
--- a/Makefile
+++ b/Makefile
@@ -85,7 +85,6 @@ ftest:
sphinx:
# if this errors either tox -e docs or cd tools/c7n_sphinext && poetry install
- which c7n-sphinxext
make -f docs/Makefile.sphinx html
ghpages:
diff --git a/c7n/query.py b/c7n/query... |
cloud-custodian__cloud-custodian-5682 | [
{
"changes": {
"added_entities": [
"c7n/resources/code.py:DescribePipeline.augment",
"c7n/resources/code.py:DeletePipeline.process"
],
"added_modules": [
"c7n/resources/code.py:DescribePipeline",
"c7n/resources/code.py:DeletePipeline"
],
"edited_enti... | cloud-custodian/cloud-custodian | d3ac682012293602b035b8b10e72beddf84d4f8e | Feature Request - Add Tagging Support For aws.codecommit
**Is your feature request related to a problem? Please describe.**
Not related to a problem but we would like to start enforcing tags on these for our inventory completeness.
**Describe the solution you'd like**
Having the basic tag, remove-tag, mark-for-op ... | diff --git a/c7n/resources/code.py b/c7n/resources/code.py
index 98f62bdc3..5a3ab9348 100644
--- a/c7n/resources/code.py
+++ b/c7n/resources/code.py
@@ -34,9 +34,10 @@ class CodeRepository(QueryResourceManager):
arn = "Arn"
date = 'creationDate'
cfn_type = 'AWS::CodeCommit::Repository'
+ ... |
cloud-custodian__cloud-custodian-5715 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/cloudtrail.py:Status.process"
],
"edited_modules": [
"c7n/resources/cloudtrail.py:Status"
]
},
"file": "c7n/resources/cloudtrail.py"
}
] | cloud-custodian/cloud-custodian | 1a28f06a19980a5ba91f6c15029d17f9475d5984 | aws.cloudtrail status IsLogging fails with KeyError: 'c7n:TrailStatus'
**Describe the bug**
cloudtrail status / IsLogging returns key error KeyError: 'c7n:TrailStatus'
https://cloudcustodian.io/docs/aws/resources/cloudtrail.html#status indicates this should work.
**To Reproduce**
Authenticate to an account that... | diff --git a/c7n/resources/cloudtrail.py b/c7n/resources/cloudtrail.py
index 33511347b..dcff8de90 100644
--- a/c7n/resources/cloudtrail.py
+++ b/c7n/resources/cloudtrail.py
@@ -102,12 +102,16 @@ class Status(ValueFilter):
annotation_key = 'c7n:TrailStatus'
def process(self, resources, event=None):
+
+ ... |
cloud-custodian__cloud-custodian-5749 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/asg.py:ImageAgeFilter.get_resource_date"
],
"edited_modules": [
"c7n/resources/asg.py:ImageAgeFilter"
]
},
"file": "c7n/resources/asg.py"
}
] | cloud-custodian/cloud-custodian | 9f443bf62db693dd0a19f49e0b4f4efb452ca903 | aws - asg.image-age filter fails
**Describe the bug**
A policy that filters asg based off the image-age is failing
**To Reproduce**
Dry run the policy shown below
**Expected behavior**
Should execute the policy completely
**Background (please complete the following information):**
- Python Version: 3... | diff --git a/c7n/resources/asg.py b/c7n/resources/asg.py
index dfefff94d..9d01ee426 100644
--- a/c7n/resources/asg.py
+++ b/c7n/resources/asg.py
@@ -574,6 +574,8 @@ class ImageAgeFilter(AgeFilter):
def get_resource_date(self, asg):
cfg = self.launch_info.get(asg)
+ if cfg is None:
+ cf... |
cloud-custodian__cloud-custodian-5764 | [
{
"changes": {
"added_entities": [
"c7n/policy.py:CloudTrailMode.resolve_resources"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"c7n/policy.py:CloudTrailMode"
]
},
"file": "c7n/policy.py"
}
] | cloud-custodian/cloud-custodian | 55e93f4deb2929edb32ab9a6927f7a214bc2ca90 | Action Delay
So I have made this rule.
```
policies:
- name: untagged-offhour-ec2-rule
resource: ec2
mode:
type: cloudtrail
role: arn:aws:iam::************:role/cloudcustodian_lambda_role
events:
- source: ec2.amazonaws.com
event: StartInstances
ids: "respo... | diff --git a/c7n/policy.py b/c7n/policy.py
index 63b9b9d2b..bae8e04cb 100644
--- a/c7n/policy.py
+++ b/c7n/policy.py
@@ -600,6 +600,8 @@ class CloudTrailMode(LambdaMode):
schema = utils.type_schema(
'cloudtrail',
+ delay={'type': 'integer',
+ 'description': 'sleep for delay seconds ... |
cloud-custodian__cloud-custodian-5765 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/s3.py:DescribeS3.get_resources"
],
"edited_modules": [
"c7n/resources/s3.py:DescribeS3"
]
},
"file": "c7n/resources/s3.py"
}
] | cloud-custodian/cloud-custodian | ec8cca2442dd256f07bfb7811942066a15331d7f | aws.s3 - CreationDate is unavailable in cloudtrail policies
**Describe the bug**
The `CreationDate` field is not available for s3 cloudtrail policies and therefore cannot include filters depending on the age of the bucket. Because the data is missing, the filter will not behave as expected and will simply never match... | diff --git a/c7n/resources/s3.py b/c7n/resources/s3.py
index cfbb0726d..c4cb63203 100644
--- a/c7n/resources/s3.py
+++ b/c7n/resources/s3.py
@@ -97,9 +97,6 @@ class DescribeS3(query.DescribeSource):
results = list(filter(None, results))
return results
- def get_resources(self, bucket_name... |
cloud-custodian__cloud-custodian-5771 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/commands.py:schema_cmd"
],
"edited_modules": [
"c7n/commands.py:schema_cmd"
]
},
"file": "c7n/commands.py"
},
{
"changes": {
"added_entities": [
... | cloud-custodian/cloud-custodian | de00e4b739dfa300fa4f17030fcaaf4a50ed5541 | Schema error with `aws.network-addr`
**Describe the bug**
Schema error with `aws.network-addr`.
**To Reproduce**
Attempt to get the schema, notice `aws.network-addr` is in the list. Next, try to get the schema for `aws.network-addr`, notice that custodian throws an error.
```bash
# custodian schema
resources... | diff --git a/c7n/commands.py b/c7n/commands.py
index e0e41a7b2..2a29bf925 100644
--- a/c7n/commands.py
+++ b/c7n/commands.py
@@ -379,14 +379,14 @@ def schema_cmd(options):
components[0] = '%s.%s' % (cloud_provider, components[0])
load_resources((components[0],))
resource_mapping = schema.reso... |
cloud-custodian__cloud-custodian-5792 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/asg.py:PropagateTags.process_asg"
],
"edited_modules": [
"c7n/resources/asg.py:PropagateTags"
]
},
"file": "c7n/resources/asg.py"
}
] | cloud-custodian/cloud-custodian | dc087d1902e82d74d120a65af2ee22ec27f0d9b2 | aws:asg propagte-tags action errors on asgs without instances
The error message when I try to use the propagate-tags action is the following:
```
[ERROR] 2019-11-19T02:56:38.336Z b1c8af86-d773-412d-b755-638faf7698e8 Error while executing policy
20:56:38 Traceback (most recent call last):
20:56:38 File "/var/task/... | diff --git a/c7n/resources/asg.py b/c7n/resources/asg.py
index 9d01ee426..181141dd9 100644
--- a/c7n/resources/asg.py
+++ b/c7n/resources/asg.py
@@ -1215,7 +1215,7 @@ class PropagateTags(Action):
if self.data.get('trim', False):
instances = [self.instance_map[i] for i in instance_ids]
... |
cloud-custodian__cloud-custodian-5807 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/filters/config.py:ConfigCompliance.process"
],
"edited_modules": [
"c7n/filters/config.py:ConfigCompliance"
]
},
"file": "c7n/filters/config.py"
},
{
"chang... | cloud-custodian/cloud-custodian | 0b6b7d9931ea52c344e5ddae37737713c8589abc | Codecommit and Codepipeline missing tag filters and actions in 0.9.2.0
**Describe the bug**
Codecommit and codepipeline tagging was added per the release notes but it doesn't come up in the schema when you do a custodian schema codecommit or codepipeline
**To Reproduce**
Steps to reproduce the behavior:
cus... | diff --git a/c7n/filters/config.py b/c7n/filters/config.py
index 87b2487bf..ee8ea0b58 100644
--- a/c7n/filters/config.py
+++ b/c7n/filters/config.py
@@ -109,11 +109,26 @@ class ConfigCompliance(Filter):
resource_model = self.manager.get_model()
resource_map = self.get_resource_map(filters, resource_mo... |
cloud-custodian__cloud-custodian-5818 | [
{
"changes": {
"added_entities": [
"c7n/resources/ssm.py:DeleteParameter.process"
],
"added_modules": [
"c7n/resources/ssm.py:DeleteParameter"
],
"edited_entities": null,
"edited_modules": null
},
"file": "c7n/resources/ssm.py"
},
{
"changes": ... | cloud-custodian/cloud-custodian | 284c5d2b5323c665680199512756dde728bc2290 | Add delete action to aws.ssm-parameter resource
**Is your feature request related to a problem? Please describe.**
We would like to enforce that only secure strings are used for the parameter store so we need a delete action to do the actual enforcement as customers will just ignore emails if there is no consequence.
... | diff --git a/c7n/resources/ssm.py b/c7n/resources/ssm.py
index f7d73bbe1..46ecc9ffe 100644
--- a/c7n/resources/ssm.py
+++ b/c7n/resources/ssm.py
@@ -47,6 +47,20 @@ class SSMParameter(QueryResourceManager):
augment = universal_augment
+@SSMParameter.action_registry.register('delete')
+class DeleteParameter(Acti... |
cloud-custodian__cloud-custodian-5843 | [
{
"changes": {
"added_entities": [
"c7n/resources/glue.py:GlueDataCatalog.get_resources"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"c7n/resources/glue.py:GlueDataCatalog"
]
},
"file": "c7n/resources/glue.py"
}
] | cloud-custodian/cloud-custodian | 1ea032d4582d2b18f9dc0d9d4b1bc4e9c8d375d8 | Deprecation warning due to invalid escape sequences
**Describe the bug**
Deprecation warnings are raised due to invalid escape sequences. This can be fixed by using raw strings or escaping the literals. pyupgrade also helps in automatic conversion : https://github.com/asottile/pyupgrade/
**To Reproduce**
```
... | diff --git a/c7n/resources/glue.py b/c7n/resources/glue.py
index e985ebc6d..d46953f56 100644
--- a/c7n/resources/glue.py
+++ b/c7n/resources/glue.py
@@ -528,6 +528,9 @@ class GlueDataCatalog(ResourceManager):
def resources(self):
return self.filter_resources(self._get_catalog_encryption_settings())
+ ... |
cloud-custodian__cloud-custodian-5844 | [
{
"changes": {
"added_entities": [
"c7n/resources/glue.py:GlueDataCatalog.get_resources"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"c7n/resources/glue.py:GlueDataCatalog"
]
},
"file": "c7n/resources/glue.py"
},
{
"c... | cloud-custodian/cloud-custodian | 1ea032d4582d2b18f9dc0d9d4b1bc4e9c8d375d8 | AWS RedShift Reserved Nodes
**Describe the solution you'd like**
Parity of aws.rds-reserved / aws.ec2-reserved with a new aws.redshift-reserved resource.
**Additional context**
I would like the ability to identify redshift reserved nodes in the same way as rds and ec2. | diff --git a/c7n/resources/glue.py b/c7n/resources/glue.py
index e985ebc6d..d46953f56 100644
--- a/c7n/resources/glue.py
+++ b/c7n/resources/glue.py
@@ -528,6 +528,9 @@ class GlueDataCatalog(ResourceManager):
def resources(self):
return self.filter_resources(self._get_catalog_encryption_settings())
+ ... |
cloud-custodian__cloud-custodian-5865 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/kms.py:DescribeKey.augment"
],
"edited_modules": [
"c7n/resources/kms.py:DescribeKey"
]
},
"file": "c7n/resources/kms.py"
},
{
"changes": {
... | cloud-custodian/cloud-custodian | 0b7d44c5d261b831ac9bc44a07fd10658405362e | include alias name in kms-key for filtering and notifications
**Is your feature request related to a problem? Please describe.**
I'd like the `AliasName` available in the kms-key resource information for more enriched notifications.
**Describe the solution you'd like**
We could do this one of two ways:
1. augment... | diff --git a/c7n/resources/kms.py b/c7n/resources/kms.py
index c4d4d85fb..bce35ccb1 100644
--- a/c7n/resources/kms.py
+++ b/c7n/resources/kms.py
@@ -63,12 +63,20 @@ class DescribeKey(DescribeSource):
return super().get_resources(ids, cache)
def augment(self, resources):
- client = local_session(s... |
cloud-custodian__cloud-custodian-5866 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/resources/rds.py:ModifyDb.process",
"c7n/resources/rds.py:ModifyDb.validate"
],
"edited_modules": [
"c7n/resources/rds.py:ModifyDb"
]
},
"file": "c7n/resour... | cloud-custodian/cloud-custodian | f7538740c07e621d5d44a47120ce3cf64e64668e | enabling perfromance insight on RDS failing due wrong key in property
**Describe the bug**
response of describe db instance does not have any key "EnablePerformanceInsights" but "PerformanceInsightsEnabled" :
https://github.com/cloud-custodian/cloud-custodian/blob/master/c7n/resources/rds.py#L1625
Hence, using... | diff --git a/c7n/resources/rds.py b/c7n/resources/rds.py
index b7e5dce63..56db7181e 100644
--- a/c7n/resources/rds.py
+++ b/c7n/resources/rds.py
@@ -1626,8 +1626,11 @@ class ModifyDb(BaseAction):
'PerformanceInsightsKMSKeyId',
'PerformanceInsightsRetentionPeriod',
... |
cloud-custodian__cloud-custodian-5900 | [
{
"changes": {
"added_entities": [
"c7n/resources/emr.py:SecurityGroupFilter.get_related_ids"
],
"added_modules": [
"c7n/resources/emr.py:SubnetFilter",
"c7n/resources/emr.py:SecurityGroupFilter"
],
"edited_entities": null,
"edited_modules": null
}... | cloud-custodian/cloud-custodian | 4283ae8c63e4c828f5de57f6d729f96f69aaa428 | emr extend network-location feature
**Is your feature request related to a problem? Please describe.**
Require subnet/sg tag comparison for resource: emr
**Describe the solution you'd like**
Extend filter `subnet`, `security-group` and `network-location` for emr
**Describe alternatives you've considered**
A cl... | diff --git a/c7n/resources/emr.py b/c7n/resources/emr.py
index 9656c7050..ebf5c502f 100644
--- a/c7n/resources/emr.py
+++ b/c7n/resources/emr.py
@@ -14,6 +14,7 @@
import logging
import time
import json
+import jmespath
from c7n.actions import ActionRegistry, BaseAction
from c7n.exceptions import PolicyValidation... |
cloud-custodian__cloud-custodian-5920 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "c7n/resources/cloudfront.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/reso... | cloud-custodian/cloud-custodian | af521ac1dcfbcc31d7b1ad79160b612dd776223d | Elasticsearch policy sending DomainName as Dict, expect STR
**Describe the bug**
Lambdas created using the Elasticsearch policy are passing the DomainName to the AWS API as a dictionary, and the API needs it to be a string. You can find a gist of the full error here: https://gist.github.com/theotherothermatt/199f78ee... | diff --git a/c7n/resources/cloudfront.py b/c7n/resources/cloudfront.py
index 7d9979bf4..ee7805d23 100644
--- a/c7n/resources/cloudfront.py
+++ b/c7n/resources/cloudfront.py
@@ -661,6 +661,10 @@ class DistributionUpdateAction(BaseUpdateAction):
raise e
+StreamingDistribution.filter_registry.register('sh... |
cloud-custodian__cloud-custodian-5951 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/policy.py:PolicyConditions.__init__"
],
"edited_modules": [
"c7n/policy.py:PolicyConditions"
]
},
"file": "c7n/policy.py"
},
{
"changes": {
"added_ent... | cloud-custodian/cloud-custodian | 22b4fda1a74bff43c854a594076a1c460e5ff573 | App-ELB Conditions Error - PolicyConditions object has no attribute config
**Describe the bug**
When running a app-elb policy which has a conditions statement to see if the account_id is present in a S3 csv file we are getting the error "PolicyConditions object has no attribute config"
**To Reproduce**
Steps to re... | diff --git a/c7n/policy.py b/c7n/policy.py
index bae8e04cb..faa858ca2 100644
--- a/c7n/policy.py
+++ b/c7n/policy.py
@@ -922,6 +922,15 @@ class PolicyConditions:
self.policy = policy
self.data = data
self.filters = self.data.get('conditions', [])
+ # for value_from usage / we use the c... |
cloud-custodian__cloud-custodian-5958 | [
{
"changes": {
"added_entities": [
"c7n/resources/cw.py:LogGroupMetrics.get_dimensions"
],
"added_modules": [
"c7n/resources/cw.py:LogGroupMetrics"
],
"edited_entities": null,
"edited_modules": null
},
"file": "c7n/resources/cw.py"
}
] | cloud-custodian/cloud-custodian | 3736c896bb1fe52537d21b7743d52d5481653807 | AWS-Metric filter on log-group is failing
I am writing a policy to with metric filter on log groups. The policy is
```
policies:
- name: logs-incoming-bytes
resource: log-group
comment: |
Ingested logs size
filters:
- type: metrics
namespace: AWS/Logs
... | diff --git a/c7n/resources/cw.py b/c7n/resources/cw.py
index b0ccf6e14..6c8655a52 100644
--- a/c7n/resources/cw.py
+++ b/c7n/resources/cw.py
@@ -176,6 +176,13 @@ class LogGroup(QueryResourceManager):
return [r['arn'][:-2] for r in resources]
+@LogGroup.filter_registry.register('metrics')
+class LogGroupMet... |
cloud-custodian__cloud-custodian-5980 | [
{
"changes": {
"added_entities": [
"c7n/resources/sns.py:ConfigSNS.load_resource"
],
"added_modules": [
"c7n/resources/sns.py:ConfigSNS"
],
"edited_entities": null,
"edited_modules": [
"c7n/resources/sns.py:SNS"
]
},
"file": "c7n/resource... | cloud-custodian/cloud-custodian | fcf49ea7301a14787898a9697da441316a0b60a5 | AWS config source pass supplementaryConfiguration data with resource
**Is your feature request related to a problem? Please describe.**
Any reason why we do not return `supplementaryConfiguration` along with `configuration` . This would be helpful since this seems to contain tag information on resources which would b... | diff --git a/c7n/resources/sns.py b/c7n/resources/sns.py
index 8a4a441e8..61eaa3328 100644
--- a/c7n/resources/sns.py
+++ b/c7n/resources/sns.py
@@ -41,6 +41,15 @@ class DescribeTopic(DescribeSource):
return list(w.map(_augment, resources))
+class ConfigSNS(ConfigSource):
+
+ def load_resource(self,... |
cloud-custodian__cloud-custodian-6185 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/policy.py:ConfigRuleMode.run"
],
"edited_modules": [
"c7n/policy.py:ConfigRuleMode"
]
},
"file": "c7n/policy.py"
},
{
"changes": {
"added_entities": n... | cloud-custodian/cloud-custodian | f96502a772ce379d81ea3b93543539b7cbcf857b | [ERROR] KeyError: ‘QueueUrl’ : SQS Tag Compliance Policy with Config Mode Failing
**Describe the bug**
-> After deploying the SQS Tag Compliance policy with config-rule mode in the AWS environment, I am encountering an error listed below:
[ERROR] KeyError: ‘QueueUrl’
Traceback (most recent call last):
File “/va... | diff --git a/c7n/policy.py b/c7n/policy.py
index 879fd124c..c0baaa1a7 100644
--- a/c7n/policy.py
+++ b/c7n/policy.py
@@ -842,7 +842,7 @@ class ConfigRuleMode(LambdaMode):
resources = []
# TODO config resource type matches policy check
- if event['eventLeftScope'] or cfg_item['configurationIte... |
cloud-custodian__cloud-custodian-6203 | [
{
"changes": {
"added_entities": [
"c7n/resources/ebs.py:SetPermissions.validate",
"c7n/resources/ebs.py:SetPermissions.process",
"c7n/resources/ebs.py:SetPermissions.process_image"
],
"added_modules": [
"c7n/resources/ebs.py:SetPermissions"
],
"edit... | cloud-custodian/cloud-custodian | 5dac93a58d2a01663ce8163418eb91b45872eb31 | Ability to remove cross-account access to EBS snapshots for matched account IDs
**Is your feature request related to a problem? Please describe.**
I have cases where we share EBS snapshots with various account IDs. I can use filters to find EBS snapshots that are shared with unauthorised accounts, which would be any a... | diff --git a/c7n/resources/ebs.py b/c7n/resources/ebs.py
index 3eeb5ab41..e1699c4e9 100644
--- a/c7n/resources/ebs.py
+++ b/c7n/resources/ebs.py
@@ -513,6 +513,95 @@ class CopySnapshot(BaseAction):
"Cross region copy complete %s", ",".join(copy_ids))
+@Snapshot.action_registry.register('set-permiss... |
cloud-custodian__cloud-custodian-6235 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"c7n/policy.py:PolicyConditions.validate",
"c7n/policy.py:PolicyConditions.__init__"
],
"edited_modules": [
"c7n/policy.py:PolicyConditions"
]
},
"file": "c7n/po... | cloud-custodian/cloud-custodian | 894367fbc3c8fc1417c175586f09f46c90929246 | Custodian errors when using example conditional policy with a gcp resource
**Describe the bug**
Attempting to run the [example conditional execution policy ](https://cloudcustodian.io/docs/quickstart/advanced.html#conditional-policy-execution) in combination with a gcp resource results in an error when validating the ... | diff --git a/c7n/policy.py b/c7n/policy.py
index c0baaa1a7..40d40ea62 100644
--- a/c7n/policy.py
+++ b/c7n/policy.py
@@ -927,10 +927,13 @@ class PolicyConditions:
self.session_factory = rm.session_factory
# used by c7n-org to extend evaluation conditions
self.env_vars = {}
+ self.initi... |
cloud-custodian__cloud-custodian-6294 | [
{
"changes": {
"added_entities": [
"c7n/query.py:ConfigSource._load_item_config",
"c7n/query.py:ConfigSource._load_resource_tags"
],
"added_modules": null,
"edited_entities": [
"c7n/query.py:ConfigSource.load_resource"
],
"edited_modules": [
"c... | cloud-custodian/cloud-custodian | dccdc446aa4c648a5cf96172eaea667825289698 | aws - [ERROR] KeyError: 'name' - CodePeipeline Custodian Policies with mode Config-rule fails
**Describe the bug**
-> After deploying the CodePipeline Tag Compliance policy and Artifact Store Encryption key check with config-rule mode in the AWS environment, I am encountering an error listed below:
Note: The error ... | diff --git a/c7n/query.py b/c7n/query.py
index 5d6c464bc..64b550401 100644
--- a/c7n/query.py
+++ b/c7n/query.py
@@ -337,27 +337,33 @@ class ConfigSource:
return {'expr': s}
def load_resource(self, item):
+ item_config = self._load_item_config(item)
+ resource = camelResource(item_config, ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.