text stringlengths 19 585k | label stringclasses 2
values | category stringclasses 2
values | language stringclasses 14
values | repo stringclasses 932
values | sha stringlengths 40 40 |
|---|---|---|---|---|---|
@@ -157,18 +160,36 @@ protected override Task StopCore()
private async Task StartInternal(string startCmd, string args, string directoriy)
{
- try
+ var tcs = new TaskCompletionSource();
+
+ void Read_SocketIO_Parameters(object sender, string line)
{
- ... | bad | review | csharp | ElectronNET/Electron.NET | 9c89d8481c63fd2fff38a0e7058a89070ebed1e7 |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index b2d32a9e..c74dad80 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9c89d8481c63fd2fff38a0e7058a89070ebed1e7 |
@@ -73,7 +83,7 @@ let manifestJsonFilePath = path.join(currentPath, manifestJsonFileName);
// if running unpackedelectron, lets change the path
if (unpackedelectron || unpackeddotnet) {
- console.log('unpackedelectron! dir: ' + currentPath);
+ console.debug('Running in unpacked mode, dir: ' + currentPath); | bad | review | javascript | ElectronNET/Electron.NET | 9c89d8481c63fd2fff38a0e7058a89070ebed1e7 |
diff --git a/src/ElectronNET.Host/main.js b/src/ElectronNET.Host/main.js
index 9ea21ded..ebf5fbef 100644
--- a/src/ElectronNET.Host/main.js
+++ b/src/ElectronNET.Host/main.js
@@ -1,10 +1,14 @@
const { app } = require('electron');
const { BrowserWindow } = require('electron');
-const { protocol } = require('electron'... | good | review_fixed | javascript | ElectronNET/Electron.NET | 9c89d8481c63fd2fff38a0e7058a89070ebed1e7 |
@@ -53,17 +82,69 @@ protected override Task StartCore()
}
else
{
- dir = dir.Parent?.Parent;
+ dir = dir.Parent!.Parent!;
startCmd = Path.Combine(dir.FullName, this.electronBinaryName);
args = $"-dotnetpacked -electro... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -33,14 +34,42 @@ public ElectronProcessActive(bool isUnpackaged, string electronBinaryName, strin
this.socketPort = socketPort;
}
- protected override Task StartCore()
+ protected override async Task StartCore()
{
var dir = new DirectoryInfo(AppDomain.Curre... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -33,14 +34,42 @@ public ElectronProcessActive(bool isUnpackaged, string electronBinaryName, strin
this.socketPort = socketPort;
}
- protected override Task StartCore()
+ protected override async Task StartCore()
{
var dir = new DirectoryInfo(AppDomain.Curre... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -316,10 +362,9 @@
<PropertyGroup>
<ElectronOutputPath>$([System.IO.Path]::GetFullPath('$(ElectronOutDir)'))</ElectronOutputPath>
- <LinuxPrefix>linux</LinuxPrefix>
- <IsLinuxWsl>false</IsLinuxWsl>
- <IsLinuxWsl Condition="'$(RuntimeIdentifier.StartsWith($(LinuxPrefix)))' == 'true'AND $([... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -376,21 +438,18 @@
</PropertyGroup>
- <PropertyGroup>
- <!-- Default values -->
- <ElectronArch Condition="'$(RuntimeIdentifier)' == 'win-x64'">x64</ElectronArch>
- <ElectronArch Condition="'$(RuntimeIdentifier)' == 'win-x86'">ia32</ElectronArch>
- <ElectronArch Condition="'$(RuntimeI... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -316,10 +362,9 @@
<PropertyGroup>
<ElectronOutputPath>$([System.IO.Path]::GetFullPath('$(ElectronOutDir)'))</ElectronOutputPath>
- <LinuxPrefix>linux</LinuxPrefix>
- <IsLinuxWsl>false</IsLinuxWsl>
- <IsLinuxWsl Condition="'$(RuntimeIdentifier.StartsWith($(LinuxPrefix)))' == 'true'AND $([... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -53,17 +82,69 @@ protected override Task StartCore()
}
else
{
- dir = dir.Parent?.Parent;
+ dir = dir.Parent!.Parent!; | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -53,17 +82,69 @@ protected override Task StartCore()
}
else
{
- dir = dir.Parent?.Parent;
+ dir = dir.Parent!.Parent!;
startCmd = Path.Combine(dir.FullName, this.electronBinaryName);
args = $"-dotnetpacked -electro... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -335,6 +380,23 @@
<Message Importance="High" Text="Electron setup failed!" Condition="'$(ExecExitCode)' != '0'" />
+ <!-- Fix up incorrect symlinks created by npm on Windows when targeting macOS -->
+ <PropertyGroup>
+ <_ElectronFrameworksDir>$(ElectronOutDir)node_modules\electron\dist\Electron.a... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -297,12 +297,58 @@
<RemoveDir Directories="$(ElectronHookTargetModuleDir)" Condition="Exists($(ElectronHookTargetModuleDir))" />
</Target>
+ <Target Name="ElectronCheckVersionMismatch">
+
+ <PropertyGroup>
+ <ElectronArch Condition="'$(RuntimeIdentifier)' == 'win-x64'">x64</ElectronArch>
+ <E... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -33,14 +34,42 @@ public ElectronProcessActive(bool isUnpackaged, string electronBinaryName, strin
this.socketPort = socketPort;
}
- protected override Task StartCore()
+ protected override async Task StartCore()
{
var dir = new DirectoryInfo(AppDomain.Curre... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -297,12 +297,58 @@
<RemoveDir Directories="$(ElectronHookTargetModuleDir)" Condition="Exists($(ElectronHookTargetModuleDir))" />
</Target>
+ <Target Name="ElectronCheckVersionMismatch">
+
+ <PropertyGroup>
+ <ElectronArch Condition="'$(RuntimeIdentifier)' == 'win-x64'">x64</ElectronArch>
+ <E... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -376,21 +438,18 @@
</PropertyGroup>
- <PropertyGroup>
- <!-- Default values -->
- <ElectronArch Condition="'$(RuntimeIdentifier)' == 'win-x64'">x64</ElectronArch>
- <ElectronArch Condition="'$(RuntimeIdentifier)' == 'win-x86'">ia32</ElectronArch>
- <ElectronArch Condition="'$(RuntimeI... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -33,14 +34,42 @@ public ElectronProcessActive(bool isUnpackaged, string electronBinaryName, strin
this.socketPort = socketPort;
}
- protected override Task StartCore()
+ protected override async Task StartCore()
{
var dir = new DirectoryInfo(AppDomain.Curre... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -33,14 +34,42 @@ public ElectronProcessActive(bool isUnpackaged, string electronBinaryName, strin
this.socketPort = socketPort;
}
- protected override Task StartCore()
+ protected override async Task StartCore()
{
var dir = new DirectoryInfo(AppDomain.Curre... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -335,6 +380,23 @@
<Message Importance="High" Text="Electron setup failed!" Condition="'$(ExecExitCode)' != '0'" />
+ <!-- Fix up incorrect symlinks created by npm on Windows when targeting macOS -->
+ <PropertyGroup>
+ <_ElectronFrameworksDir>$(ElectronOutDir)node_modules\electron\dist\Electron.a... | bad | review | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
diff --git a/src/ElectronNET/build/ElectronNET.LateImport.targets b/src/ElectronNET/build/ElectronNET.LateImport.targets
index d82dcbd8..f5e655fc 100644
--- a/src/ElectronNET/build/ElectronNET.LateImport.targets
+++ b/src/ElectronNET/build/ElectronNET.LateImport.targets
@@ -297,12 +297,58 @@
<RemoveDir Directories... | good | review_fixed | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf | |
@@ -53,17 +82,71 @@ protected override Task StartCore()
}
else
{
- dir = dir.Parent?.Parent;
+ dir = dir.Parent!.Parent!;
startCmd = Path.Combine(dir.FullName, this.electronBinaryName);
args = $"-dotnetpacked -electro... | bad | review | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
diff --git a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs b/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
index 61cae062..b2d32a9e 100644
--- a/src/ElectronNET.API/Runtime/Services/ElectronProcess/ElectronProcessActive.cs
+++ b/src/ElectronNET.API/Runtime... | good | review_fixed | csharp | ElectronNET/Electron.NET | 9d0378798b6af1ba9bee9a9bc7c190f072b8c4bf |
@@ -32,19 +32,18 @@ jobs:
echo "Jobs and conclusions:"
echo "$jobs_json" | jq '.jobs[] | {name: .name, conclusion: .conclusion}'
- failed_matrix_jobs=$(echo "$jobs_json" | jq '
+ failed_matrix_jobs=$(echo "$jobs_json" | jq -r '
[ .jobs[]
| select(.co... | bad | review | ElectronNET/Electron.NET | 73c56e245035a7a2dafd93c475f31f3acfdbd18d | |
diff --git a/.github/workflows/retry-test-jobs.yml b/.github/workflows/retry-test-jobs.yml
index 4078b70b..fc7600b8 100644
--- a/.github/workflows/retry-test-jobs.yml
+++ b/.github/workflows/retry-test-jobs.yml
@@ -32,19 +32,18 @@ jobs:
echo "Jobs and conclusions:"
echo "$jobs_json" | jq '.jobs[] ... | good | review_fixed | ElectronNET/Electron.NET | 73c56e245035a7a2dafd93c475f31f3acfdbd18d | |
@@ -12,6 +12,10 @@
<_IsMsAspNetProject Condition="'$(UsingMicrosoftNETSdkWeb)' == 'true'">True</_IsMsAspNetProject>
</PropertyGroup>
+ <PropertyGroup>
+ <PackageId>$(ElectronPackageId)</PackageId> | bad | review | ElectronNET/Electron.NET | 25770db138b84939cb0ce97d74a8e7d751a9cdec | |
diff --git a/src/ElectronNET/build/ElectronNET.Core.targets b/src/ElectronNET/build/ElectronNET.Core.targets
index 9385fa54..962ed6fa 100644
--- a/src/ElectronNET/build/ElectronNET.Core.targets
+++ b/src/ElectronNET/build/ElectronNET.Core.targets
@@ -12,6 +12,10 @@
<_IsMsAspNetProject Condition="'$(UsingMicrosoftN... | good | review_fixed | ElectronNET/Electron.NET | 25770db138b84939cb0ce97d74a8e7d751a9cdec | |
@@ -479,7 +479,7 @@
Description="The version of the app, following the major.minor.patch pattern. Version numbers may include a pre-release suffix."
Category="AppInfo" />
- <StringProperty Name="PackageId"
+ <StringProperty Name="ElectronPackageId"
DisplayNam... | bad | review | ElectronNET/Electron.NET | 13f1203ccc9ada1705ebadb069a456d15bccbf8a | |
diff --git a/src/ElectronNET/build/ElectronNETRules.Project.xaml b/src/ElectronNET/build/ElectronNETRules.Project.xaml
index 62fcb820..5354bc42 100644
--- a/src/ElectronNET/build/ElectronNETRules.Project.xaml
+++ b/src/ElectronNET/build/ElectronNETRules.Project.xaml
@@ -479,7 +479,7 @@
Description="T... | good | review_fixed | ElectronNET/Electron.NET | 13f1203ccc9ada1705ebadb069a456d15bccbf8a | |
@@ -0,0 +1,18 @@
+import { Socket } from "socket.io";
+
+export class Connector {
+ constructor(private socket: Socket, public app: any) {
+ }
+
+ on(key: string, javaScriptCode: Function): void {
+ this.socket.on(key, (...args: any[]) => {
+ const id: string = args.pop();
+ const ... | bad | review | typescript | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/connector.ts b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/connector.ts
new file mode 100644
index 00000000..295ba95f
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/connector.ts
@@ -0,0 +1,21 @@
+import {... | good | review_fixed | typescript | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
@@ -0,0 +1,18 @@
+import { Socket } from "socket.io"; | bad | review | typescript | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/connector.ts b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/connector.ts
new file mode 100644
index 00000000..295ba95f
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/connector.ts
@@ -0,0 +1,21 @@
+import {... | good | review_fixed | typescript | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
@@ -0,0 +1,35 @@
+using ElectronNET.API;
+
+namespace ElectronNET.Samples.ElectronHostHook
+{
+ public class Program
+ {
+ public static void Main(string[] args)
+ {
+ var builder = WebApplication.CreateBuilder(args);
+
+ builder.WebHost.UseElectron(args);
+ builder.... | bad | review | csharp | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/Program.cs b/src/ElectronNET.Samples.ElectronHostHook/Program.cs
new file mode 100644
index 00000000..ee8fa812
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/Program.cs
@@ -0,0 +1,31 @@
+using ElectronNET.API;
+
+namespace ElectronNET.Samples.ElectronH... | good | review_fixed | csharp | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
@@ -0,0 +1,16 @@
+import { Connector } from "./connector"; | bad | review | typescript | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/index.ts b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/index.ts
new file mode 100644
index 00000000..54b69c97
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/index.ts
@@ -0,0 +1,16 @@
+import { Connector }... | good | review_fixed | typescript | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
@@ -0,0 +1,24 @@
+@model string
+@{
+ Layout = null;
+}
+
+<!DOCTYPE html>
+<html> | bad | review | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 | |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/Views/Home/Index.cshtml b/src/ElectronNET.Samples.ElectronHostHook/Views/Home/Index.cshtml
new file mode 100644
index 00000000..f0f3be97
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/Views/Home/Index.cshtml
@@ -0,0 +1,25 @@
+@model string
+@{
+ Lay... | good | review_fixed | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 | |
@@ -0,0 +1,24 @@
+@model string
+@{
+ Layout = null;
+}
+
+<!DOCTYPE html>
+<html>
+<head> | bad | review | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 | |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/Views/Home/Index.cshtml b/src/ElectronNET.Samples.ElectronHostHook/Views/Home/Index.cshtml
new file mode 100644
index 00000000..f0f3be97
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/Views/Home/Index.cshtml
@@ -0,0 +1,25 @@
+@model string
+@{
+ Lay... | good | review_fixed | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 | |
@@ -0,0 +1,12 @@
+{
+ "compilerOptions": {
+ "module": "commonjs",
+ "noImplicitAny": false,
+ "noEmitOnError": true,
+ "removeComments": false,
+ "sourceMap": true,
+ "target": "es5",
+ "lib": ["es2015", "dom"]
+ },
+ "exclude": ["node_modules", "wwwroot"] | bad | review | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 | |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/tsconfig.json b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/tsconfig.json
new file mode 100644
index 00000000..db8ccccd
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/ElectronHostHook/tsconfig.json
@@ -0,0 +1,9 @@
+{
+ "... | good | review_fixed | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 | |
@@ -0,0 +1,35 @@
+using ElectronNET.API;
+
+namespace ElectronNET.Samples.ElectronHostHook
+{
+ public class Program
+ {
+ public static void Main(string[] args)
+ {
+ var builder = WebApplication.CreateBuilder(args);
+
+ builder.WebHost.UseElectron(args);
+ builder.... | bad | review | csharp | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
diff --git a/src/ElectronNET.Samples.ElectronHostHook/Program.cs b/src/ElectronNET.Samples.ElectronHostHook/Program.cs
new file mode 100644
index 00000000..ee8fa812
--- /dev/null
+++ b/src/ElectronNET.Samples.ElectronHostHook/Program.cs
@@ -0,0 +1,31 @@
+using ElectronNET.API;
+
+namespace ElectronNET.Samples.ElectronH... | good | review_fixed | csharp | ElectronNET/Electron.NET | 331c2f548c84647eeff9002cd1e53958025f3020 |
@@ -1,18 +1,15 @@
-name: Tests
+name: Tests
on:
- push:
- branches: [ develop, main ]
- pull_request:
- branches: [ develop, main ]
+ workflow_call:
concurrency:
group: integration-tests-${{ github.ref }}
cancel-in-progress: true
jobs:
tests:
- name: Integration Tests (${{ matrix.os }} / ... | bad | review | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
index d801df2e..89ad3c95 100644
--- a/.github/workflows/integration-tests.yml
+++ b/.github/workflows/integration-tests.yml
@@ -1,10 +1,7 @@
-name: Tests
+name: Tests
on:
- push:
- branches: [ develop, main ]
- pull_... | good | review_fixed | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
@@ -0,0 +1,39 @@
+name: PR Validation
+
+on: [pull_request]
+
+concurrency:
+ group: pr-validation-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ Whitespace-Check:
+ uses: ./.github/workflows/trailing-whitespace-check.yml
+ secrets: inherit
+ name: '1' | bad | review | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
diff --git a/.github/workflows/PR Validation.yml b/.github/workflows/PR Validation.yml
new file mode 100644
index 00000000..540db15b
--- /dev/null
+++ b/.github/workflows/PR Validation.yml
@@ -0,0 +1,39 @@
+name: PR Validation
+
+on: [pull_request]
+
+concurrency:
+ group: pr-validation-${{ github.ref }}
+ cancel-in-... | good | review_fixed | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
@@ -0,0 +1,39 @@
+name: PR Validation
+
+on: [pull_request]
+
+concurrency:
+ group: pr-validation-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ Whitespace-Check:
+ uses: ./.github/workflows/trailing-whitespace-check.yml
+ secrets: inherit
+ name: '1'
+
+ Tests:
+ needs: Whitespace-Check
+... | bad | review | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
diff --git a/.github/workflows/PR Validation.yml b/.github/workflows/PR Validation.yml
new file mode 100644
index 00000000..540db15b
--- /dev/null
+++ b/.github/workflows/PR Validation.yml
@@ -0,0 +1,39 @@
+name: PR Validation
+
+on: [pull_request]
+
+concurrency:
+ group: pr-validation-${{ github.ref }}
+ cancel-in-... | good | review_fixed | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
@@ -0,0 +1,39 @@
+name: PR Validation
+
+on: [pull_request]
+
+concurrency:
+ group: pr-validation-${{ github.ref }}
+ cancel-in-progress: true
+
+jobs:
+ Whitespace-Check:
+ uses: ./.github/workflows/trailing-whitespace-check.yml
+ secrets: inherit
+ name: '1'
+
+ Tests:
+ needs: Whitespace-Check
+... | bad | review | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
diff --git a/.github/workflows/PR Validation.yml b/.github/workflows/PR Validation.yml
new file mode 100644
index 00000000..540db15b
--- /dev/null
+++ b/.github/workflows/PR Validation.yml
@@ -0,0 +1,39 @@
+name: PR Validation
+
+on: [pull_request]
+
+concurrency:
+ group: pr-validation-${{ github.ref }}
+ cancel-in-... | good | review_fixed | ElectronNET/Electron.NET | 5a7cbd972fad97ba42032efcfdc5edfa1a08d870 | |
@@ -50,11 +50,12 @@ module.exports = (socket) => {
const trayIcon = electron_1.nativeImage.createFromPath(image);
tray.value = new electron_1.Tray(trayIcon);
if (menuItems) {
- const menu = electron_1.Menu.buildFromTemplate(menuItems);
- addMenuItemClickConnector(menu.it... | bad | review | javascript | ElectronNET/Electron.NET | 218b99808be1fecccd40dfc577a379e79696a93b |
diff --git a/src/ElectronNET.Host/api/tray.js b/src/ElectronNET.Host/api/tray.js
index 103acfbf..ae20b505 100644
--- a/src/ElectronNET.Host/api/tray.js
+++ b/src/ElectronNET.Host/api/tray.js
@@ -50,11 +50,7 @@ module.exports = (socket) => {
const trayIcon = electron_1.nativeImage.createFromPath(image);
... | good | review_fixed | javascript | ElectronNET/Electron.NET | 218b99808be1fecccd40dfc577a379e79696a93b |
@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {
if email, err := mail.ParseAddress(name); err == nil && email.Address == name {
continue
}
+ if uriName, err := url.Parse(name); err == nil && uriName.Scheme != "" && uriName.Host != "" {
+ continue
+ }
punycode, err := idna.ToASCII(name)
i... | bad | review | go | FiloSottile/mkcert | fbb34f6bf7be5785129aa4134736929f4dd955de |
diff --git a/main.go b/main.go
index 15f247a0..fb1c40fb 100644
--- a/main.go
+++ b/main.go
@@ -13,6 +13,7 @@ import (
"log"
"net"
"net/mail"
+ "net/url"
"os"
"path/filepath"
"regexp"
@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {
if email, err := mail.ParseAddress(name); err == nil && email.... | good | review_fixed | go | FiloSottile/mkcert | fbb34f6bf7be5785129aa4134736929f4dd955de |
@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {
if email, err := mail.ParseAddress(name); err == nil && email.Address == name {
continue
}
+ if uriName, err := url.Parse(name); err == nil && uriName.Scheme != "" && uriName.Host != "" {
+ continue
+ }
punycode, err := idna.ToASCII(name)
i... | bad | review | go | FiloSottile/mkcert | fbb34f6bf7be5785129aa4134736929f4dd955de |
diff --git a/main.go b/main.go
index 15f247a0..fb1c40fb 100644
--- a/main.go
+++ b/main.go
@@ -13,6 +13,7 @@ import (
"log"
"net"
"net/mail"
+ "net/url"
"os"
"path/filepath"
"regexp"
@@ -194,13 +195,16 @@ func (m *mkcert) Run(args []string) {
if email, err := mail.ParseAddress(name); err == nil && email.... | good | review_fixed | go | FiloSottile/mkcert | fbb34f6bf7be5785129aa4134736929f4dd955de |
@@ -172,8 +169,9 @@ program
const resolvedPath = path.resolve(targetPath);
const workspaceRoot = await findWorkspaceRoot(resolvedPath);
if (workspaceRoot) {
- await runWorkspaceUpdateForRoot(workspaceRoot, { force: options?.force });
- return;
+ throw new Error(
+ 'Ope... | bad | review | typescript | Fission-AI/OpenSpec | 771964d938bafbf7c35c14ae8e4c36ae42978626 |
diff --git a/src/cli/index.ts b/src/cli/index.ts
index d06fdddc5..0c42f43cb 100644
--- a/src/cli/index.ts
+++ b/src/cli/index.ts
@@ -4,7 +4,7 @@ import ora from 'ora';
import path from 'path';
import { fileURLToPath } from 'url';
import { promises as fs } from 'fs';
-import { AI_TOOLS } from '../core/config.js';
+im... | good | review_fixed | typescript | Fission-AI/OpenSpec | 771964d938bafbf7c35c14ae8e4c36ae42978626 |
@@ -100,6 +97,15 @@ program.hook('postAction', async () => {
const availableToolIds = AI_TOOLS.filter((tool) => tool.skillsDir).map((tool) => tool.value);
const toolsOptionDescription = `Configure AI tools non-interactively. Use "all", "none", or a comma-separated list of: ${availableToolIds.join(', ')}`;
+async fu... | bad | review | typescript | Fission-AI/OpenSpec | 771964d938bafbf7c35c14ae8e4c36ae42978626 |
diff --git a/src/cli/index.ts b/src/cli/index.ts
index d06fdddc5..0c42f43cb 100644
--- a/src/cli/index.ts
+++ b/src/cli/index.ts
@@ -4,7 +4,7 @@ import ora from 'ora';
import path from 'path';
import { fileURLToPath } from 'url';
import { promises as fs } from 'fs';
-import { AI_TOOLS } from '../core/config.js';
+im... | good | review_fixed | typescript | Fission-AI/OpenSpec | 771964d938bafbf7c35c14ae8e4c36ae42978626 |
@@ -8,7 +8,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali
|----------|----------|---------|
| **Setup** | `init`, `update` | Initialize and update OpenSpec in your project |
| **Workspaces (beta)** | `workspace setup`, `workspace list`, `workspace ls`, `workspace link`, `worksp... | bad | review | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | |
diff --git a/docs/cli.md b/docs/cli.md
index 06c64f402..9e85c5aa7 100644
--- a/docs/cli.md
+++ b/docs/cli.md
@@ -8,7 +8,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali
|----------|----------|---------|
| **Setup** | `init`, `update` | Initialize and update OpenSpec in your projec... | good | review_fixed | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c | |
@@ -139,6 +166,65 @@ async function isGitRepositoryAtRoot(storeRoot: string): Promise<boolean> {
return kind === 'directory' || kind === 'file';
}
+async function nearestExistingDirectory(targetPath: string): Promise<string | null> {
+ let current = path.resolve(targetPath);
+
+ while (true) {
+ const kind =... | bad | review | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
diff --git a/src/core/context-store/operations.ts b/src/core/context-store/operations.ts
index ce49f44d1..c61a3e07e 100644
--- a/src/core/context-store/operations.ts
+++ b/src/core/context-store/operations.ts
@@ -1,5 +1,6 @@
import { execFile } from 'node:child_process';
import * as nodeFs from 'node:fs';
+import * a... | good | review_fixed | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
@@ -413,6 +515,164 @@ export async function registerExistingContextStore(
}, createdFiles);
}
+function cleanupStoreOutput(id: string, storeRoot: string): ContextStoreInfo {
+ return {
+ id,
+ root: storeRoot,
+ metadataPath: getContextStoreMetadataPath(storeRoot),
+ };
+}
+
+export async function prep... | bad | review | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
diff --git a/src/core/context-store/operations.ts b/src/core/context-store/operations.ts
index ce49f44d1..c61a3e07e 100644
--- a/src/core/context-store/operations.ts
+++ b/src/core/context-store/operations.ts
@@ -1,5 +1,6 @@
import { execFile } from 'node:child_process';
import * as nodeFs from 'node:fs';
+import * a... | good | review_fixed | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
@@ -128,6 +137,74 @@ function withRegisteredStore(
};
}
+function getRegisteredStoreOrThrow(
+ registry: ContextStoreRegistryState | null,
+ id: string
+): ContextStoreRegistryEntry {
+ const entry = registry?.stores[id];
+ if (!entry) {
+ throw new ContextStoreError(`Unknown context store '${id}'`, 'conte... | bad | review | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
diff --git a/src/core/context-store/registry.ts b/src/core/context-store/registry.ts
index b3629e958..0544c37f8 100644
--- a/src/core/context-store/registry.ts
+++ b/src/core/context-store/registry.ts
@@ -31,6 +31,16 @@ export interface ResolveRegisteredContextStoreInput extends ContextStorePathOpti
id: string;
}
... | good | review_fixed | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
@@ -298,6 +412,168 @@ describe('context-store command', () => {
});
});
+ it('unregisters a context store without deleting local files', async () => {
+ const storeRoot = mkdir('team-context');
+ await writeContextStoreMetadataState(storeRoot, { version: 1, id: 'team-context' });
+ await writeContex... | bad | review | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
diff --git a/test/commands/context-store.test.ts b/test/commands/context-store.test.ts
index 7cbf9123f..6f7ae926e 100644
--- a/test/commands/context-store.test.ts
+++ b/test/commands/context-store.test.ts
@@ -1,5 +1,6 @@
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import { Command } from... | good | review_fixed | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
@@ -449,6 +452,142 @@ describe('context store registry facade', () => {
).rejects.toThrow(/does not match registered id/u);
});
+ it('refuses a prepared remove when the registry entry changes before deletion', async () => {
+ const firstRoot = mkdir('first/team-context');
+ const secondRoot = mkdir('se... | bad | review | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
diff --git a/test/core/context-store/registry.test.ts b/test/core/context-store/registry.test.ts
index 2122a584b..533fcb453 100644
--- a/test/core/context-store/registry.test.ts
+++ b/test/core/context-store/registry.test.ts
@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import ... | good | review_fixed | typescript | Fission-AI/OpenSpec | 47b9f40a06862ee3f3916fb60bb07914a4926a1c |
@@ -280,34 +280,44 @@ export async function prepareWorkspaceOpen(
assertWorkspaceOpenSupportedOptions(options);
const workspaceName = resolveOpenWorkspaceName(positionalName, options);
+ const openerOverride = resolveWorkspaceOpenOpenerOverride(options);
const requestedInitiative = await resolveWorkspaceOpe... | bad | review | typescript | Fission-AI/OpenSpec | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 |
diff --git a/src/commands/workspace/open-view.ts b/src/commands/workspace/open-view.ts
index e6c784c15..628677178 100644
--- a/src/commands/workspace/open-view.ts
+++ b/src/commands/workspace/open-view.ts
@@ -20,6 +20,7 @@ import {
getWorkspaceContextInitiativeId,
getWorkspaceOpenerLabel,
} from '../../core/work... | good | review_fixed | typescript | Fission-AI/OpenSpec | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 |
@@ -288,32 +291,43 @@ async function syncWorkspaceCodeWorkspace(
return codeWorkspacePath;
}
-async function syncWorkspaceIgnoreRules(
+async function cleanupLegacyWorkspaceIgnoreRules(
workspaceRoot: string,
workspaceName: string
): Promise<void> {
const gitignorePath = path.join(workspaceRoot, '.gitig... | bad | review | typescript | Fission-AI/OpenSpec | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 |
diff --git a/src/core/workspace/open-surface.ts b/src/core/workspace/open-surface.ts
index 0ba6bec8e..b77a79443 100644
--- a/src/core/workspace/open-surface.ts
+++ b/src/core/workspace/open-surface.ts
@@ -6,13 +6,15 @@ import {
WorkspaceViewState,
getWorkspaceContextInitiativeId,
getWorkspaceCodeWorkspacePath,... | good | review_fixed | typescript | Fission-AI/OpenSpec | 363359b46d47cd8aad21fbb1ea31aeb5584bdc87 |
@@ -161,6 +165,12 @@ program
.action(async (targetPath = '.', options?: { force?: boolean }) => {
try {
const resolvedPath = path.resolve(targetPath);
+ const workspaceRoot = await findWorkspaceRoot(resolvedPath);
+ if (workspaceRoot) {
+ await runWorkspaceUpdateForRoot(workspaceRoot, {}... | bad | review | typescript | Fission-AI/OpenSpec | 829ef46c341a773c52259cd73f2881681ac7e391 |
diff --git a/src/cli/index.ts b/src/cli/index.ts
index f1278dbd7..baa3e48fa 100644
--- a/src/cli/index.ts
+++ b/src/cli/index.ts
@@ -16,7 +16,11 @@ import { CompletionCommand } from '../commands/completion.js';
import { FeedbackCommand } from '../commands/feedback.js';
import { registerConfigCommand } from '../comman... | good | review_fixed | typescript | Fission-AI/OpenSpec | 829ef46c341a773c52259cd73f2881681ac7e391 |
@@ -170,3 +169,27 @@ The system SHALL continue to work with existing changes that do not have project
#### Scenario: Existing change with config added later
- **WHEN** config file is added to project with existing changes
- **THEN** existing changes continue to use their bound schema from `.openspec.yaml`
+
+### Req... | bad | review | Fission-AI/OpenSpec | 829ef46c341a773c52259cd73f2881681ac7e391 | |
diff --git a/openspec/specs/schema-resolution/spec.md b/openspec/specs/schema-resolution/spec.md
index b8c0caace..f243252ad 100644
--- a/openspec/specs/schema-resolution/spec.md
+++ b/openspec/specs/schema-resolution/spec.md
@@ -2,7 +2,6 @@
## Purpose
Define project-local schema resolution behavior, including prece... | good | review_fixed | Fission-AI/OpenSpec | 829ef46c341a773c52259cd73f2881681ac7e391 | |
@@ -360,3 +359,165 @@ OpenSpec SHALL provide JSON output for direct workspace setup commands.
#### Scenario: Commands with JSON output
- **WHEN** users run `workspace setup --no-interactive`, `workspace list`, `workspace link`, `workspace relink`, or `workspace doctor`
- **THEN** each command SHALL support JSON outp... | bad | review | Fission-AI/OpenSpec | 829ef46c341a773c52259cd73f2881681ac7e391 | |
diff --git a/openspec/specs/workspace-links/spec.md b/openspec/specs/workspace-links/spec.md
index f8abc488b..edbc2fea8 100644
--- a/openspec/specs/workspace-links/spec.md
+++ b/openspec/specs/workspace-links/spec.md
@@ -4,7 +4,6 @@
Define the direct workspace setup, discovery, linking, relinking, health check,
and J... | good | review_fixed | Fission-AI/OpenSpec | 829ef46c341a773c52259cd73f2881681ac7e391 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.