text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -0,0 +1,184 @@ +## ADDED Requirements + +### Requirement: Workspace Open Command +OpenSpec SHALL provide a `workspace open` command that opens an OpenSpec workspace working set through an agent or VS Code editor. + +#### Scenario: Opening the current workspace +- **GIVEN** the command runs from inside an OpenSpec wo...
bad
review
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
diff --git a/openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-open/spec.md b/openspec/changes/archive/2026-05-06-workspace-open-agent-context/specs/workspace-open/spec.md new file mode 100644 index 000000000..fc3e565aa --- /dev/null +++ b/openspec/changes/archive/2026-05-06-workspace-ope...
good
review_fixed
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
@@ -334,6 +404,123 @@ function printLinkMutationHuman( console.log(`Workspace: ${payload.workspace.name}`); } +async function resolveWorkspaceOpenOpener( + localState: { preferred_opener?: WorkspacePreferredOpener }, + options: WorkspaceOpenOptions +): Promise<WorkspacePreferredOpener> { + if (options.agent &&...
bad
review
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts index 2afad3c05..6d2eafca7 100644 --- a/src/commands/workspace.ts +++ b/src/commands/workspace.ts @@ -3,7 +3,15 @@ import chalk from 'chalk'; import * as nodeFs from 'node:fs'; import * as path from 'node:path'; -import { listWorkspaceRegistryEntrie...
good
review_fixed
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
@@ -0,0 +1,170 @@ +import { spawn } from 'node:child_process'; + +import { + WorkspaceLocalState, + WorkspacePreferredOpener, + WorkspaceSharedState, + getWorkspaceCodeWorkspacePath, + getWorkspaceOpenerExecutable, + getWorkspaceOpenerLabel, + isWorkspaceExecutableAvailable, + readWorkspaceLocalState, + readWo...
bad
review
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
diff --git a/src/commands/workspace/open.ts b/src/commands/workspace/open.ts new file mode 100644 index 000000000..1745cfc78 --- /dev/null +++ b/src/commands/workspace/open.ts @@ -0,0 +1,176 @@ +import { spawn as nodeSpawn } from 'node:child_process'; +import { createRequire } from 'node:module'; + +import { + Workspa...
good
review_fixed
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
@@ -0,0 +1,112 @@ +import { describe, expect, it } from 'vitest'; + +import { + assertWorkspaceOpenerAvailable, + buildWorkspaceOpenLaunchCommand, + launchWorkspaceOpenCommand, +} from '../../src/commands/workspace/open.js'; + +describe('workspace open launchers', () => { + it('builds launcher commands for VS Code,...
bad
review
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
diff --git a/test/commands/workspace-open.test.ts b/test/commands/workspace-open.test.ts new file mode 100644 index 000000000..c28397db6 --- /dev/null +++ b/test/commands/workspace-open.test.ts @@ -0,0 +1,119 @@ +import { describe, expect, it } from 'vitest'; + +import { + assertWorkspaceOpenerAvailable, + buildWorks...
good
review_fixed
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
@@ -0,0 +1,175 @@ +import { spawn } from 'node:child_process'; + +import { + WorkspaceLocalState, + WorkspacePreferredOpener, + WorkspaceSharedState, + getWorkspaceCodeWorkspacePath, + getWorkspaceOpenerExecutable, + getWorkspaceOpenerLabel, + isWorkspaceExecutableAvailable, + readWorkspaceLocalState, + readWo...
bad
review
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
diff --git a/src/commands/workspace/open.ts b/src/commands/workspace/open.ts new file mode 100644 index 000000000..1745cfc78 --- /dev/null +++ b/src/commands/workspace/open.ts @@ -0,0 +1,176 @@ +import { spawn as nodeSpawn } from 'node:child_process'; +import { createRequire } from 'node:module'; + +import { + Workspa...
good
review_fixed
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
@@ -0,0 +1,213 @@ +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { FileSystemUtils } from '../../utils/file-system.js'; +import { + WorkspaceLocalState, + WorkspaceSharedState, + getWorkspaceCodeWorkspacePath, + getWorkspacePortableIgnorePatterns, +} from './foundation.js'; + +con...
bad
review
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
diff --git a/src/core/workspace/open-surface.ts b/src/core/workspace/open-surface.ts new file mode 100644 index 000000000..10dbf8148 --- /dev/null +++ b/src/core/workspace/open-surface.ts @@ -0,0 +1,212 @@ +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { FileSystemUtils } from '../../...
good
review_fixed
typescript
Fission-AI/OpenSpec
105aafd8a73e5645aba837512737d152430caa94
@@ -0,0 +1,498 @@ +import { Command } from 'commander'; +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { listWorkspaceRegistryEntries } from '../core/workspace/index.js'; +import { isInteractive, resolveNoInteractive } from '../utils/interactive.js'; +import { + addWorkspaceLink, + ...
bad
review
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts new file mode 100644 index 000000000..2afad3c05 --- /dev/null +++ b/src/commands/workspace.ts @@ -0,0 +1,622 @@ +import { Command } from 'commander'; +import chalk from 'chalk'; +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +...
good
review_fixed
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
@@ -0,0 +1,498 @@ +import { Command } from 'commander'; +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { listWorkspaceRegistryEntries } from '../core/workspace/index.js'; +import { isInteractive, resolveNoInteractive } from '../utils/interactive.js'; +import { + addWorkspaceLink, + ...
bad
review
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts new file mode 100644 index 000000000..2afad3c05 --- /dev/null +++ b/src/commands/workspace.ts @@ -0,0 +1,622 @@ +import { Command } from 'commander'; +import chalk from 'chalk'; +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +...
good
review_fixed
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
@@ -0,0 +1,684 @@ +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { + WorkspaceLocalState, + WorkspaceRegistryEntry, + WorkspaceRegistryState, + WorkspaceSharedState, + getManagedWorkspaceRoot, + getWorkspaceChangesDir, + getWorkspacePortableIgnorePatterns, + isWorkspaceRoot, +...
bad
review
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
diff --git a/src/commands/workspace/operations.ts b/src/commands/workspace/operations.ts new file mode 100644 index 000000000..8f58673a9 --- /dev/null +++ b/src/commands/workspace/operations.ts @@ -0,0 +1,695 @@ +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { + WorkspaceLocalState, ...
good
review_fixed
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
@@ -155,6 +155,88 @@ export const COMMAND_REGISTRY: CommandDefinition[] = [ }, ], }, + { + name: 'workspace', + description: 'Set up and inspect coordination workspaces', + flags: [], + subcommands: [ + { + name: 'setup', + description: 'Set up a workspace and link existin...
bad
review
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
diff --git a/src/core/completions/command-registry.ts b/src/core/completions/command-registry.ts index 09c9ecc8d..cb0085bec 100644 --- a/src/core/completions/command-registry.ts +++ b/src/core/completions/command-registry.ts @@ -155,6 +155,106 @@ export const COMMAND_REGISTRY: CommandDefinition[] = [ }, ], ...
good
review_fixed
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
@@ -159,6 +165,103 @@ openspec update --- +## Workspace Commands + +Workspace commands are under active development and are not ready for use yet. Do not build external automation, integrations, or long-lived workflows on top of this command surface; command behavior, state files, and JSON output can change at any...
bad
review
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
diff --git a/docs/cli.md b/docs/cli.md index 35bb527cd..a56bbb3b2 100644 --- a/docs/cli.md +++ b/docs/cli.md @@ -7,6 +7,7 @@ The OpenSpec CLI (`openspec`) provides terminal commands for project setup, vali | Category | Commands | Purpose | |----------|----------|---------| | **Setup** | `init`, `update` | Initialize...
good
review_fixed
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
@@ -0,0 +1,620 @@ +import { Command } from 'commander'; +import chalk from 'chalk'; +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +import { listWorkspaceRegistryEntries } from '../core/workspace/index.js'; +import { isInteractive, resolveNoInteractive } from '../utils/interactive.js'; +impor...
bad
review
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
diff --git a/src/commands/workspace.ts b/src/commands/workspace.ts new file mode 100644 index 000000000..2afad3c05 --- /dev/null +++ b/src/commands/workspace.ts @@ -0,0 +1,622 @@ +import { Command } from 'commander'; +import chalk from 'chalk'; +import * as nodeFs from 'node:fs'; +import * as path from 'node:path'; + +...
good
review_fixed
typescript
Fission-AI/OpenSpec
9ce951d17a429f0e8e811ce0ef7160b3dab3f32a
@@ -0,0 +1,24 @@ +## ADDED Requirements + +### Requirement: Workspace Setup Commands +The CLI artifact workflow SHALL expose workspace setup commands before change creation. + +#### Scenario: Preparing workspace planning before a change +- **WHEN** a user needs to prepare workspace planning across repos or folders +- *...
bad
review
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
diff --git a/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md b/openspec/changes/workspace-create-and-register-repos/specs/cli-artifact-workflow/spec.md new file mode 100644 index 000000000..e969d2bc3 --- /dev/null +++ b/openspec/changes/workspace-create-and-register-repos/specs/...
good
review_fixed
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
@@ -0,0 +1,211 @@ +## ADDED Requirements + +### Requirement: Guided Workspace Setup +OpenSpec SHALL provide a guided setup flow for users starting workspace planning. + +#### Scenario: Creating a workspace through setup +- **WHEN** a user runs `openspec workspace setup` +- **THEN** OpenSpec SHALL guide the user through...
bad
review
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
diff --git a/openspec/changes/workspace-create-and-register-repos/specs/workspace-links/spec.md b/openspec/changes/workspace-create-and-register-repos/specs/workspace-links/spec.md new file mode 100644 index 000000000..e9507b9cf --- /dev/null +++ b/openspec/changes/workspace-create-and-register-repos/specs/workspace-li...
good
review_fixed
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
@@ -140,8 +140,10 @@ Bring back: Focus on: - how a user creates a workspace -- how repo aliases are registered +- how working-set entries are registered - what `doctor` or equivalent status output should explain +- how `setup`, `list`, `create`, `add-repo`, and `doctor` fit together before change creation +- how p...
bad
review
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
diff --git a/openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md b/openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md index bf74950b2..10830b0de 100644 --- a/openspec/changes/workspace-reimplementation-roadmap/POC_REFERENCE_GUIDE.md +++ b/openspec/changes/workspace-reimple...
good
review_fixed
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
@@ -42,9 +42,9 @@ OpenSpec currently discovers active changes as immediate directories under `open `workspace-foundation` establishes the storage, root detection, and naming model. Every later slice should build on that model instead of redefining workspace metadata. -`workspace-create-and-register-repos` makes re...
bad
review
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
diff --git a/openspec/changes/workspace-reimplementation-roadmap/README.md b/openspec/changes/workspace-reimplementation-roadmap/README.md index 0c25b56c1..aa8560c26 100644 --- a/openspec/changes/workspace-reimplementation-roadmap/README.md +++ b/openspec/changes/workspace-reimplementation-roadmap/README.md @@ -42,9 +4...
good
review_fixed
Fission-AI/OpenSpec
772aad1c99a8a7dbcd93ea99f4b2f4dc0b4f3878
@@ -16,7 +16,7 @@ export function normalizeRequirementName(name: string): string { return name.trim(); } -const REQUIREMENT_HEADER_REGEX = /^###\s*Requirement:\s*(.+)\s*$/; +const REQUIREMENT_HEADER_REGEX = /^###\s*Requirement:\s*(.+)\s*$/i;
bad
review
typescript
Fission-AI/OpenSpec
753e36377cfc2b65adbd5f99faf8a30fcfd7650b
diff --git a/src/core/parsers/requirement-blocks.ts b/src/core/parsers/requirement-blocks.ts index 7a8161a94..afc55f891 100644 --- a/src/core/parsers/requirement-blocks.ts +++ b/src/core/parsers/requirement-blocks.ts @@ -16,7 +16,7 @@ export function normalizeRequirementName(name: string): string { return name.trim(...
good
review_fixed
typescript
Fission-AI/OpenSpec
753e36377cfc2b65adbd5f99faf8a30fcfd7650b
@@ -58,7 +58,7 @@ export function extractRequirementsSection(content: string): RequirementsSection let preambleLines: string[] = []; // Collect preamble lines until first requirement header - while (cursor < sectionBodyLines.length && !/^###\s+Requirement:/.test(sectionBodyLines[cursor])) { + while (cursor < ...
bad
review
typescript
Fission-AI/OpenSpec
753e36377cfc2b65adbd5f99faf8a30fcfd7650b
diff --git a/src/core/parsers/requirement-blocks.ts b/src/core/parsers/requirement-blocks.ts index 7a8161a94..afc55f891 100644 --- a/src/core/parsers/requirement-blocks.ts +++ b/src/core/parsers/requirement-blocks.ts @@ -16,7 +16,7 @@ export function normalizeRequirementName(name: string): string { return name.trim(...
good
review_fixed
typescript
Fission-AI/OpenSpec
753e36377cfc2b65adbd5f99faf8a30fcfd7650b
@@ -89,7 +89,7 @@ openspec init [path] [options] `--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`). -**Supported tool IDs (`--tools`):** `amazon-q`, `antigravity`, `auggie`, `claude`, `cline`, `codex`, `codebuddy`, `continue`, `costrict`, `crush`, `curso...
bad
review
Fission-AI/OpenSpec
a84ecda970abfe98178dda074a32098d11639952
diff --git a/docs/cli.md b/docs/cli.md index 5bbe6e018..a5de58260 100644 --- a/docs/cli.md +++ b/docs/cli.md @@ -89,7 +89,7 @@ openspec init [path] [options] `--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`). -**Supported tool IDs (`--tools`):** `amazon-...
good
review_fixed
Fission-AI/OpenSpec
a84ecda970abfe98178dda074a32098d11639952
@@ -72,7 +72,7 @@ openspec init --tools none openspec init --profile core ``` -**Available tool IDs (`--tools`):** `amazon-q`, `antigravity`, `auggie`, `bob`, `claude`, `cline`, `codex`, `codebuddy`, `continue`, `costrict`, `crush`, `cursor`, `factory`, `forgecode`, `gemini`, `github-copilot`, `iflow`, `junie`, `ki...
bad
review
Fission-AI/OpenSpec
a84ecda970abfe98178dda074a32098d11639952
diff --git a/docs/supported-tools.md b/docs/supported-tools.md index b47b73c2a..dc3487a89 100644 --- a/docs/supported-tools.md +++ b/docs/supported-tools.md @@ -42,6 +42,7 @@ You can enable expanded workflows (`new`, `continue`, `ff`, `verify`, `sync`, `b | Kilo Code (`kilocode`) | `.kilocode/skills/openspec-*/SKILL.m...
good
review_fixed
Fission-AI/OpenSpec
a84ecda970abfe98178dda074a32098d11639952
@@ -89,7 +89,7 @@ openspec init [path] [options] `--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`). -**Supported tool IDs (`--tools`):** `amazon-q`, `antigravity`, `auggie`, `claude`, `cline`, `codex`, `codebuddy`, `continue`, `costrict`, `crush`, `curso...
bad
review
Fission-AI/OpenSpec
624ad1a79562e9e2c9748935d851d20195ba5d86
diff --git a/docs/cli.md b/docs/cli.md index ddcdaa0a4..5bbe6e018 100644 --- a/docs/cli.md +++ b/docs/cli.md @@ -89,7 +89,7 @@ openspec init [path] [options] `--profile custom` uses whatever workflows are currently selected in global config (`openspec config profile`). -**Supported tool IDs (`--tools`):** `amazon-...
good
review_fixed
Fission-AI/OpenSpec
624ad1a79562e9e2c9748935d851d20195ba5d86
@@ -71,7 +72,7 @@ openspec init --tools none openspec init --profile core ``` -**Available tool IDs (`--tools`):** `amazon-q`, `antigravity`, `auggie`, `bob`, `claude`, `cline`, `codex`, `codebuddy`, `continue`, `costrict`, `crush`, `cursor`, `factory`, `forgecode`, `gemini`, `github-copilot`, `iflow`, `junie`, `ki...
bad
review
Fission-AI/OpenSpec
624ad1a79562e9e2c9748935d851d20195ba5d86
diff --git a/docs/supported-tools.md b/docs/supported-tools.md index dc5500920..b47b73c2a 100644 --- a/docs/supported-tools.md +++ b/docs/supported-tools.md @@ -40,6 +40,7 @@ You can enable expanded workflows (`new`, `continue`, `ff`, `verify`, `sync`, `b | iFlow (`iflow`) | `.iflow/skills/openspec-*/SKILL.md` | `.ifl...
good
review_fixed
Fission-AI/OpenSpec
624ad1a79562e9e2c9748935d851d20195ba5d86
@@ -16,13 +20,40 @@ export interface GlobalConfig { [key: string]: unknown; // Preserve other fields } +function getConfigDir(): string { + // XDG_CONFIG_HOME takes precedence on all platforms when explicitly set + const xdgConfigHome = process.env.XDG_CONFIG_HOME; + if (xdgConfigHome) { + return path.join(...
bad
review
typescript
Fission-AI/OpenSpec
972a7658e75b6079f5238e0f7d97deb9573c8529
diff --git a/src/telemetry/config.ts b/src/telemetry/config.ts index a79704f0b..5bad282d9 100644 --- a/src/telemetry/config.ts +++ b/src/telemetry/config.ts @@ -1,10 +1,19 @@ /** * Global configuration for telemetry state. - * Stores anonymous ID and notice-seen flag in ~/.config/openspec/config.json + * Stores anon...
good
review_fixed
typescript
Fission-AI/OpenSpec
972a7658e75b6079f5238e0f7d97deb9573c8529
@@ -16,13 +25,101 @@ export interface GlobalConfig { [key: string]: unknown; // Preserve other fields } +function getConfigDir(): string { + return getGlobalConfigDir(); +} + +function getLegacyConfigPath(): string { + return path.join(os.homedir(), '.config', CONFIG_DIR_NAME, CONFIG_FILE_NAME); +} + +async fun...
bad
review
typescript
Fission-AI/OpenSpec
972a7658e75b6079f5238e0f7d97deb9573c8529
diff --git a/src/telemetry/config.ts b/src/telemetry/config.ts index a79704f0b..5bad282d9 100644 --- a/src/telemetry/config.ts +++ b/src/telemetry/config.ts @@ -1,10 +1,19 @@ /** * Global configuration for telemetry state. - * Stores anonymous ID and notice-seen flag in ~/.config/openspec/config.json + * Stores anon...
good
review_fixed
typescript
Fission-AI/OpenSpec
972a7658e75b6079f5238e0f7d97deb9573c8529
@@ -13,26 +14,32 @@ import { describe('telemetry/config', () => { let tempDir: string; - let originalHome: string | undefined; - let originalUserProfile: string | undefined; + let originalEnv: NodeJS.ProcessEnv; + + function restoreEnv(env: NodeJS.ProcessEnv): void { + for (const key of Object.keys(process...
bad
review
typescript
Fission-AI/OpenSpec
972a7658e75b6079f5238e0f7d97deb9573c8529
diff --git a/test/telemetry/config.test.ts b/test/telemetry/config.test.ts index 075b7b8c1..ef5726621 100644 --- a/test/telemetry/config.test.ts +++ b/test/telemetry/config.test.ts @@ -2,6 +2,7 @@ import { describe, it, expect, beforeEach, afterEach } from 'vitest'; import * as fs from 'node:fs'; import * as path fro...
good
review_fixed
typescript
Fission-AI/OpenSpec
972a7658e75b6079f5238e0f7d97deb9573c8529
@@ -0,0 +1,35 @@ +import * as fs from 'node:fs'; +import * as path from 'node:path'; +import fg from 'fast-glob'; +import { FileSystemUtils } from '../../utils/file-system.js'; + +/** + * Checks if a path contains glob pattern characters. + */ +export function isGlobPattern(pattern: string): boolean { + return pattern...
bad
review
typescript
Fission-AI/OpenSpec
5230e8517ba746a5e877413f287e7ee574424950
diff --git a/src/core/artifact-graph/outputs.ts b/src/core/artifact-graph/outputs.ts new file mode 100644 index 000000000..5dff4fc33 --- /dev/null +++ b/src/core/artifact-graph/outputs.ts @@ -0,0 +1,39 @@ +import * as fs from 'node:fs'; +import * as path from 'node:path'; +import fg from 'fast-glob'; +import { FileSyst...
good
review_fixed
typescript
Fission-AI/OpenSpec
5230e8517ba746a5e877413f287e7ee574424950
@@ -9,18 +9,56 @@ export interface Section { export class MarkdownParser { private lines: string[]; + private codeFenceLineMask: boolean[]; private currentLine: number; constructor(content: string) { const normalized = MarkdownParser.normalizeContent(content); this.lines = normalized.split('\n'...
bad
review
typescript
Fission-AI/OpenSpec
fc7680bcc0e7b7a830f6d3460c19f511b537ee7b
diff --git a/src/core/parsers/markdown-parser.ts b/src/core/parsers/markdown-parser.ts index 8bd59d1ae..abad78df2 100644 --- a/src/core/parsers/markdown-parser.ts +++ b/src/core/parsers/markdown-parser.ts @@ -9,11 +9,13 @@ export interface Section { export class MarkdownParser { private lines: string[]; + privat...
good
review_fixed
typescript
Fission-AI/OpenSpec
fc7680bcc0e7b7a830f6d3460c19f511b537ee7b
@@ -30,22 +32,28 @@ async function getSpecFiles(): Promise<string[]> { } describe('source-of-truth specs normalization', () => { - it('enforces required sections and bans archive placeholders/delta headers', async () => { + it('enforces required sections and bans hidden requirements, placeholders, and delta heade...
bad
review
typescript
Fission-AI/OpenSpec
fc7680bcc0e7b7a830f6d3460c19f511b537ee7b
diff --git a/test/specs/source-specs-normalization.test.ts b/test/specs/source-specs-normalization.test.ts index 79ab1e34b..1169e8a26 100644 --- a/test/specs/source-specs-normalization.test.ts +++ b/test/specs/source-specs-normalization.test.ts @@ -2,14 +2,19 @@ import { promises as fs } from 'fs'; import path from 'p...
good
review_fixed
typescript
Fission-AI/OpenSpec
fc7680bcc0e7b7a830f6d3460c19f511b537ee7b
@@ -818,6 +818,8 @@ openspec config profile core - Keep current settings (exit) If you keep current settings, no changes are written and no update prompt is shown. + +Telemetry opt-out is environment-based. If you are in a restricted or firewalled environment, disable telemetry before first run with `OPENSPEC_TELEM...
bad
review
Fission-AI/OpenSpec
2872dbf02d10bea1ad8e2a6b9bb275dc4ec1d9e2
diff --git a/docs/cli.md b/docs/cli.md index ebbb847eb..ddcdaa0a4 100644 --- a/docs/cli.md +++ b/docs/cli.md @@ -920,6 +920,8 @@ openspec completion uninstall | Variable | Description | |----------|-------------| +| `OPENSPEC_TELEMETRY` | Set to `0` to disable telemetry | +| `DO_NOT_TRACK` | Set to `1` to disable t...
good
review_fixed
Fission-AI/OpenSpec
2872dbf02d10bea1ad8e2a6b9bb275dc4ec1d9e2
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -60,7 +75,8 @@ public List<Result> Query(Query query) Score = 8, Action = _ => { - if (!raw.StartsWith("http://", StringComparison.OrdinalIgnoreCase) && !raw.StartsWith("https://", StringComparison.OrdinalIgnoreCase...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -37,20 +47,25 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider "(?:\\.(?:[a-z\\u00a1-\\uffff]{2,}))" + ")" + // port number - "(?::\\d{2,5})?" + + "(?::\\d{1,5})?" +
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -15,19 +16,28 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider // user:pass authentication "(?:\\S+(?::\\S*)?@)?" + "(?:" + - // IP address exclusion - // private & local networks - "(?!(?:10|127)(?:\\.\\d{1,3}){3})" + - ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -37,20 +47,25 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider "(?:\\.(?:[a-z\\u00a1-\\uffff]{2,}))" + ")" + // port number - "(?::\\d{2,5})?" + + "(?::\\d{1,5})?" + // resource path "(?:/\\S*)?" + "$"; ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -60,7 +75,8 @@ public List<Result> Query(Query query) Score = 8, Action = _ => { - if (!raw.StartsWith("http://", StringComparison.OrdinalIgnoreCase) && !raw.StartsWith("https://", StringComparison.OrdinalIgnoreCase...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -15,19 +16,28 @@ public class Main : IPlugin, IPluginI18n, ISettingProvider // user:pass authentication "(?:\\S+(?::\\S*)?@)?" + "(?:" + - // IP address exclusion - // private & local networks - "(?!(?:10|127)(?:\\.\\d{1,3}){3})" + - ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -104,19 +74,50 @@ private static string GetHttpPreference() public bool IsURL(string raw) { - raw = raw.ToLower(); + if (string.IsNullOrWhiteSpace(raw)) + return false; - if (UrlRegex.Match(raw).Value == raw) return true; + var input = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -104,19 +74,50 @@ private static string GetHttpPreference() public bool IsURL(string raw) { - raw = raw.ToLower(); + if (string.IsNullOrWhiteSpace(raw)) + return false; - if (UrlRegex.Match(raw).Value == raw) return true; + var input = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework;
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -104,19 +74,50 @@ private static string GetHttpPreference() public bool IsURL(string raw) { - raw = raw.ToLower(); + if (string.IsNullOrWhiteSpace(raw)) + return false; - if (UrlRegex.Match(raw).Value == raw) return true; + var input = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -104,19 +74,50 @@ private static string GetHttpPreference() public bool IsURL(string raw) { - raw = raw.ToLower(); + if (string.IsNullOrWhiteSpace(raw)) + return false; - if (UrlRegex.Match(raw).Value == raw) return true; + var input = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -104,19 +74,50 @@ private static string GetHttpPreference() public bool IsURL(string raw) { - raw = raw.ToLower(); + if (string.IsNullOrWhiteSpace(raw)) + return false; - if (UrlRegex.Match(raw).Value == raw) return true; + var input = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -1,33 +1,73 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; using Flow.Launcher.Plugin.Url; +using System.Reflection; namespace Flow.Launcher.Test.Plugins { [TestFixture] public class UrlPluginTest { - [Test] - public void URLMatchTest() + private static Main plugi...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs index 0dd1fe4895a..e17070b1284 100644 --- a/Flow.Launcher.Test/Plugins/UrlPluginTest.cs +++ b/Flow.Launcher.Test/Plugins/UrlPluginTest.cs @@ -1,33 +1,95 @@ using NUnit.Framework; -using NUnit.Framework.Legacy; usin...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
@@ -104,19 +74,50 @@ private static string GetHttpPreference() public bool IsURL(string raw) { - raw = raw.ToLower(); + if (string.IsNullOrWhiteSpace(raw)) + return false; - if (UrlRegex.Match(raw).Value == raw) return true; + var input = ...
bad
review
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6
diff --git a/Plugins/Flow.Launcher.Plugin.Url/Main.cs b/Plugins/Flow.Launcher.Plugin.Url/Main.cs index c40b278e596..60a6eec92f1 100644 --- a/Plugins/Flow.Launcher.Plugin.Url/Main.cs +++ b/Plugins/Flow.Launcher.Plugin.Url/Main.cs @@ -1,6 +1,7 @@ -using System; +using System; using System.Collections.Generic; -using Sy...
good
review_fixed
csharp
Flow-Launcher/Flow.Launcher
80d4e30af6a1eb92ae8106ebac620f312274fab6