text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -138,33 +228,56 @@ const ChangesPanelInner = <TDiff extends ChangesPanelDiff>( ); } + const virtualItems = virtualizer.getVirtualItems(); + const paddingTop = virtualItems.length > 0 ? virtualItems[0].start : SPACING; + const paddingBottom = + virtualItems.length > 0 + ? virtualizer.getTotalSize...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/ui/src/components/ChangesPanel.tsx b/packages/ui/src/components/ChangesPanel.tsx index d30d0cf82aa..8bf265fcf88 100644 --- a/packages/ui/src/components/ChangesPanel.tsx +++ b/packages/ui/src/components/ChangesPanel.tsx @@ -1,7 +1,13 @@ import type { ForwardedRef, ReactNode, RefAttributes } from '...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -113,208 +615,262 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -37,11 +43,15 @@ export function ChangesViewProvider({ children }: ChangesViewProviderProps) { const selectFile = useCallback((path: string, lineNumber?: number) => { setSelectedFilePath(path); setSelectedLineNumber(lineNumber ?? null); - setFileInView(path); + useFileInViewStore.getState().setFil...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx index 1cc645209d0..8a4b2e6f728 100644 --- a/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx +++ b/packages/web-core/src/shared/hooks/ChangesViewProvider.tsx @@ -3,25 +3,27 @@ i...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -113,208 +615,262 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -53,23 +49,20 @@ export const ExecutionProcessesProvider: React.FC<{ isLoading, isConnected, error, - }), - [ - executionProcesses, - executionProcessesById, - isAttemptRunning, - visible, - executionProcessesByIdVisible, - isAttemptRunningVisible, - isLo...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx b/packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx index 888006dda59..f986bf8c242 100644 --- a/packages/web-core/src/shared/providers/ExecutionProcessesProvider.tsx +++ b/packages/web-core/src/shared/providers/Execut...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -209,8 +209,8 @@ export function useDiffData( for (const content of hunk.hunkContent) { if (content.type === 'change') { const change = content as ChangeContent; - additions += change.additions.length; - deletions += change.deletions.length; + ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/ui/src/components/PierreConversationDiff.tsx b/packages/ui/src/components/PierreConversationDiff.tsx index 88f86630238..0793d60cbca 100644 --- a/packages/ui/src/components/PierreConversationDiff.tsx +++ b/packages/ui/src/components/PierreConversationDiff.tsx @@ -55,7 +55,7 @@ const PIERRE_DIFFS_TH...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -88,11 +85,6 @@ export function WorkspaceProvider({ children }: WorkspaceProviderProps) { [diffs] ); - useEffect(() => {
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -1,106 +1,609 @@ -import { memo, useRef, useEffect, useCallback, useState, useMemo } from 'react'; +import { memo, useEffect, useCallback, useRef, useState, useMemo } from 'react'; +import { useTranslation } from 'react-i18next'; import { - ChangesPanel, - type ChangesPanelHandle, - type RenderDiffItemProps, -} ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -102,6 +94,73 @@ export function WorkspaceProvider({ children }: WorkspaceProviderProps) { [diffs] ); + const rafRef = useRef<number | null>(null); + const batchCountRef = useRef(0); + + const latestDiffDataRef = useRef({ + diffs, + diffPaths, + diffStats, + gitHubComments, + isGitHubComm...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx index 58bdafb5989..c7676abfbbf 100644 --- a/packages/web-core/src/shared/providers/WorkspaceProvider.tsx +++ b/packages/web-core/src/shared/providers/WorkspaceProvider.tsx @@ -1,4 +1,...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -113,208 +617,262 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -0,0 +1,95 @@ +import { create } from 'zustand'; +import type { ExecutionProcess } from 'shared/types'; + +// --------------------------------------------------------------------------- +// Zustand store for execution processes data (SSE/WebSocket stream). +// Populated by ExecutionProcessesProvider via setExecution...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/shared/stores/useExecutionProcessesStore.ts b/packages/web-core/src/shared/stores/useExecutionProcessesStore.ts new file mode 100644 index 00000000000..4bbb74d6154 --- /dev/null +++ b/packages/web-core/src/shared/stores/useExecutionProcessesStore.ts @@ -0,0 +1,86 @@ +import { create }...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -1,106 +1,610 @@ -import { memo, useRef, useEffect, useCallback, useState, useMemo } from 'react'; +import { memo, useEffect, useCallback, useRef, useState, useMemo } from 'react'; +import { useTranslation } from 'react-i18next'; import { - ChangesPanel, - type ChangesPanelHandle, - type RenderDiffItemProps, -} ...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -113,208 +617,262 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index a8ee45e416b..21c03941354 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -55,7 +55,7 @@ const PIERRE_DIFFS_THEME_CSS = ` } /* Light theme overrides */ - [data-diffs][data-theme-type='light'] { + [data-diff][data-theme-type='light'] {
bad
review
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
diff --git a/packages/ui/src/components/PierreConversationDiff.tsx b/packages/ui/src/components/PierreConversationDiff.tsx index 88f86630238..0793d60cbca 100644 --- a/packages/ui/src/components/PierreConversationDiff.tsx +++ b/packages/ui/src/components/PierreConversationDiff.tsx @@ -55,7 +55,7 @@ const PIERRE_DIFFS_TH...
good
review_fixed
typescript
BloopAI/vibe-kanban
c00c72a0483752b52def22ff165a5cba694ddb44
@@ -0,0 +1,456 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc, time::Duration}; + +use bytes::Bytes; +use tokio::sync::{Mutex, mpsc}; +use tokio_util::sync::CancellationToken; +use uuid::Uuid; +use webrtc::{ + data_channel::{RTCDataChannel, data_channel_message::DataChannelMessage as RtcDcMessage}, +...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/peer.rs b/crates/relay-webrtc/src/peer.rs new file mode 100644 index 00000000000..862ec001709 --- /dev/null +++ b/crates/relay-webrtc/src/peer.rs @@ -0,0 +1,461 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc, time::Duration}; + +use bytes::Bytes; +use tokio::sync::{M...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -380,71 +523,287 @@ impl RelayHost { target_path: &str, headers: &HeaderMap, body: &[u8], - ) -> Result<reqwest::Response, RelayConnectionError> { - let mut transport = self.open_transport().await?; - let response = transport - .send_http(method, target_path, he...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -377,6 +376,16 @@ impl Deployment for LocalDeployment { } impl LocalDeployment { + pub fn webrtc_host(&self) -> Option<Arc<WebRtcHost>> { + let local_addr = self.client_info.get_server_addr()?; + + Some( + self.webrtc_host + .get_or_init(|| Arc::new(WebRtcHost::new(loca...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/local-deployment/src/lib.rs b/crates/local-deployment/src/lib.rs index d7f0fa440b6..50e3f2c62df 100644 --- a/crates/local-deployment/src/lib.rs +++ b/crates/local-deployment/src/lib.rs @@ -1,16 +1,19 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{ + collections::HashMap, + sync::{A...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -36,6 +37,7 @@ COPY crates/api-types crates/api-types COPY crates/relay-types crates/relay-types COPY crates/relay-tunnel-core crates/relay-tunnel-core COPY crates/relay-tunnel crates/relay-tunnel +COPY crates/ws-bridge crates/ws-bridge
bad
review
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-tunnel/Dockerfile b/crates/relay-tunnel/Dockerfile index 566b26845f2..523132b67cd 100644 --- a/crates/relay-tunnel/Dockerfile +++ b/crates/relay-tunnel/Dockerfile @@ -25,6 +25,10 @@ COPY crates/services/Cargo.toml crates/services/Cargo.toml COPY crates/worktree-manager/Cargo.toml crates/workt...
good
review_fixed
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -101,6 +104,7 @@ COPY crates/trusted-key-auth/ crates/trusted-key-auth/ COPY crates/utils/ crates/utils/ COPY crates/workspace-manager/ crates/workspace-manager/ COPY crates/worktree-manager/ crates/worktree-manager/ +COPY crates/ws-bridge/ crates/ws-bridge/
bad
review
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/Dockerfile b/Dockerfile index c1d05d69cb6..8fe31e24523 100644 --- a/Dockerfile +++ b/Dockerfile @@ -72,7 +72,11 @@ COPY crates/git-host/Cargo.toml crates/git-host/Cargo.toml COPY crates/local-deployment/Cargo.toml crates/local-deployment/Cargo.toml COPY crates/mcp/Cargo.toml crates/mcp/Cargo.toml COPY c...
good
review_fixed
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -380,71 +523,302 @@ impl RelayHost { target_path: &str, headers: &HeaderMap, body: &[u8], - ) -> Result<reqwest::Response, RelayConnectionError> { - let mut transport = self.open_transport().await?; - let response = transport - .send_http(method, target_path, he...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -191,30 +211,102 @@ impl RelaySessionCache { } } +pub type ProxiedBodyStream = Pin<Box<dyn Stream<Item = Result<Bytes, io::Error>> + Send>>; + +/// Normalized HTTP response returned from relay-hosts, independent of whether +/// the upstream transport was relay or WebRTC. +pub struct ProxiedResponse { + pu...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,80 @@ +use std::{ + collections::HashMap, + sync::Arc, + time::{Duration, Instant}, +}; + +use relay_webrtc::WebRtcClient; +use tokio::sync::RwLock; +use uuid::Uuid; + +/// How long to wait before retrying a failed WebRTC handshake. +const FAILED_RETRY_COOLDOWN: Duration = Duration::from_secs(5 * 60...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/webrtc_cache.rs b/crates/relay-hosts/src/webrtc_cache.rs new file mode 100644 index 00000000000..de4149bb75f --- /dev/null +++ b/crates/relay-hosts/src/webrtc_cache.rs @@ -0,0 +1,104 @@ +use std::{ + collections::HashMap, + sync::Arc, + time::{Duration, Instant}, +}; + +use ...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,629 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }, +}; + +use bytes::Bytes; +use tokio::{ + sync::{Mutex, Notify, mpsc, oneshot}, + time::Duration, +}; +use tokio_util::sync::{CancellationToken, PollSender}; +use uuid::Uuid; +use we...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/client.rs b/crates/relay-webrtc/src/client.rs new file mode 100644 index 00000000000..c7d23c5778d --- /dev/null +++ b/crates/relay-webrtc/src/client.rs @@ -0,0 +1,683 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -380,71 +524,303 @@ impl RelayHost { target_path: &str, headers: &HeaderMap, body: &[u8], - ) -> Result<reqwest::Response, RelayConnectionError> { - let mut transport = self.open_transport().await?; - let response = transport - .send_http(method, target_path, he...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,629 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }, +}; + +use bytes::Bytes; +use tokio::{ + sync::{Mutex, Notify, mpsc, oneshot}, + time::Duration, +}; +use tokio_util::sync::{CancellationToken, PollSender}; +use uuid::Uuid; +use we...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/client.rs b/crates/relay-webrtc/src/client.rs new file mode 100644 index 00000000000..c7d23c5778d --- /dev/null +++ b/crates/relay-webrtc/src/client.rs @@ -0,0 +1,683 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,629 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }, +}; + +use bytes::Bytes; +use tokio::{ + sync::{Mutex, Notify, mpsc, oneshot}, + time::Duration, +}; +use tokio_util::sync::{CancellationToken, PollSender}; +use uuid::Uuid; +use we...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/client.rs b/crates/relay-webrtc/src/client.rs new file mode 100644 index 00000000000..c7d23c5778d --- /dev/null +++ b/crates/relay-webrtc/src/client.rs @@ -0,0 +1,683 @@ +use std::{ + collections::HashMap, + sync::{ + Arc, + atomic::{AtomicBool, Ordering}, + }...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,131 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc}; + +use tokio::sync::Mutex; +use tokio_util::sync::CancellationToken; +use webrtc::ice_transport::ice_candidate::RTCIceCandidateInit; + +use crate::{ + WebRtcError, + peer::{self, PeerConfig, PeerHandle}, + signaling::{IceCandidate,...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/host.rs b/crates/relay-webrtc/src/host.rs new file mode 100644 index 00000000000..41da49b1b93 --- /dev/null +++ b/crates/relay-webrtc/src/host.rs @@ -0,0 +1,112 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc}; + +use tokio::sync::Mutex; +use tokio_util::sync::Cancell...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,31 @@ +pub mod client; +pub mod error; +pub mod fragment; +pub mod host; +pub mod peer; +pub mod proxy; +pub mod signaling; + +pub use client::{WebRtcClient, WebRtcClientError, WsConnection, WsSender};
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/lib.rs b/crates/relay-webrtc/src/lib.rs new file mode 100644 index 00000000000..19abebdb3d5 --- /dev/null +++ b/crates/relay-webrtc/src/lib.rs @@ -0,0 +1,31 @@ +pub mod client; +pub mod error; +pub mod fragment; +pub mod host; +pub mod peer; +pub mod proxy; +pub mod signaling; + +pu...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -380,71 +524,303 @@ impl RelayHost { target_path: &str, headers: &HeaderMap, body: &[u8], - ) -> Result<reqwest::Response, RelayConnectionError> { - let mut transport = self.open_transport().await?; - let response = transport - .send_http(method, target_path, he...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,104 @@ +use std::{ + collections::HashMap, + sync::Arc, + time::{Duration, Instant}, +}; + +use relay_webrtc::WebRtcClient; +use tokio::sync::RwLock; +use tokio_util::sync::CancellationToken; +use uuid::Uuid; + +/// How long to wait before retrying a failed WebRTC handshake. +const FAILED_RETRY_COOL...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/webrtc_cache.rs b/crates/relay-hosts/src/webrtc_cache.rs new file mode 100644 index 00000000000..de4149bb75f --- /dev/null +++ b/crates/relay-hosts/src/webrtc_cache.rs @@ -0,0 +1,104 @@ +use std::{ + collections::HashMap, + sync::Arc, + time::{Duration, Instant}, +}; + +use ...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -0,0 +1,458 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc, time::Duration}; + +use bytes::Bytes; +use tokio::sync::{Mutex, mpsc}; +use tokio_util::sync::CancellationToken; +use uuid::Uuid; +use webrtc::{ + data_channel::{RTCDataChannel, data_channel_message::DataChannelMessage as RtcDcMessage}, +...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-webrtc/src/peer.rs b/crates/relay-webrtc/src/peer.rs new file mode 100644 index 00000000000..862ec001709 --- /dev/null +++ b/crates/relay-webrtc/src/peer.rs @@ -0,0 +1,461 @@ +use std::{collections::HashMap, net::SocketAddr, sync::Arc, time::Duration}; + +use bytes::Bytes; +use tokio::sync::{M...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -380,83 +477,247 @@ impl RelayHost { target_path: &str, headers: &HeaderMap, body: &[u8], - ) -> Result<reqwest::Response, RelayConnectionError> { - let mut transport = self.open_transport().await?; - let response = transport - .send_http(method, target_path, he...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -368,6 +416,55 @@ impl RelayHost { Ok(transport) } + async fn send_http_via_relay( + &self, + method: &Method, + target_path: &str, + headers: &HeaderMap, + body: &[u8], + ) -> Result<ProxiedResponse, RelayConnectionError> { + let mut transport = self.o...
bad
review
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
diff --git a/crates/relay-hosts/src/lib.rs b/crates/relay-hosts/src/lib.rs index ec382cfea3d..a727079abac 100644 --- a/crates/relay-hosts/src/lib.rs +++ b/crates/relay-hosts/src/lib.rs @@ -1,23 +1,31 @@ -use std::{collections::HashMap, sync::Arc}; +use std::{collections::HashMap, io, pin::Pin, sync::Arc}; +use axum::...
good
review_fixed
rust
BloopAI/vibe-kanban
71ddfea2bd2d4ff75abeaece6dcefe6e9469700a
@@ -1,149 +1,569 @@ -import { memo, useRef, useEffect, useCallback, useState, useMemo } from 'react'; +import { memo, useEffect, useCallback, useRef, useState, useMemo } from 'react'; +import { useTranslation } from 'react-i18next'; import { - ChangesPanel, - type ChangesPanelHandle, - type RenderDiffItemProps, -} ...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -563,25 +563,30 @@ export const useUiPreferencesStore = create<State>()((set, get) => ({ setRightMainPanelMode: (mode, workspaceId) => { if (!workspaceId) return; - const state = get(); - const wsState = - state.workspacePanelStates[workspaceId] ?? DEFAULT_WORKSPACE_PANEL_STATE; - const isMob...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/shared/stores/useUiPreferencesStore.ts b/packages/web-core/src/shared/stores/useUiPreferencesStore.ts index 2626bcfe152..88590b54850 100644 --- a/packages/web-core/src/shared/stores/useUiPreferencesStore.ts +++ b/packages/web-core/src/shared/stores/useUiPreferencesStore.ts @@ -1,4 +1,...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -1,149 +1,569 @@ -import { memo, useRef, useEffect, useCallback, useState, useMemo } from 'react'; +import { memo, useEffect, useCallback, useRef, useState, useMemo } from 'react'; +import { useTranslation } from 'react-i18next'; import { - ChangesPanel, - type ChangesPanelHandle, - type RenderDiffItemProps, -} ...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +580,108 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +603,117 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -184,10 +184,18 @@ export function WorkspacesLayout() { } : { 'left-main': 50, 'right-main': 50 }; - const onLayoutChange = (layout: Layout) => { - if (isLeftMainPanelVisible && rightMainPanelMode !== null) - setRightMainPanelSize(layout['right-main']); - }; + const layoutTimerRef = useR...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx b/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx index 7291a1e48ba..42565b86dd5 100644 --- a/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx +++ b/packages/web-core/src/pages/workspaces/WorkspacesLayout.tsx @@ -184,10 +184...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +603,117 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -42,108 +259,334 @@ function scrollToLineInDiff( lineEl.scrollIntoView({ behavior: 'instant', block: 'nearest' }); } } - onComplete?.(); } -// Auto-collapse defaults based on change type (matches DiffsPanel behavior) -const COLLAPSE_BY_CHANGE_TYPE: Record<DiffChangeKind, boolean> = { - added: fal...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -42,108 +259,334 @@ function scrollToLineInDiff( lineEl.scrollIntoView({ behavior: 'instant', block: 'nearest' }); } } - onComplete?.(); } -// Auto-collapse defaults based on change type (matches DiffsPanel behavior) -const COLLAPSE_BY_CHANGE_TYPE: Record<DiffChangeKind, boolean> = { - added: fal...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -42,108 +259,334 @@ function scrollToLineInDiff( lineEl.scrollIntoView({ behavior: 'instant', block: 'nearest' }); } } - onComplete?.(); } -// Auto-collapse defaults based on change type (matches DiffsPanel behavior) -const COLLAPSE_BY_CHANGE_TYPE: Record<DiffChangeKind, boolean> = { - added: fal...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -64,27 +62,16 @@ export function FileTree({ const { t } = useTranslation(['tasks', 'common']); const renderNodes = (nodeList: FileTreeViewNode[], depth = 0) => { return nodeList.map((node) => ( - <div key={node.id}> + <div key={node.id} style={{ contentVisibility: 'auto', containIntrinsicSize: '...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/ui/src/components/FileTree.tsx b/packages/ui/src/components/FileTree.tsx index e77fb495ab6..2a3e7195882 100644 --- a/packages/ui/src/components/FileTree.tsx +++ b/packages/ui/src/components/FileTree.tsx @@ -1,4 +1,4 @@ -import type { ReactNode } from 'react'; +import { memo, type ReactNode } from ...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +615,222 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -1,6 +1,6 @@ import type { Diff } from 'shared/types'; -export const LARGE_DIFF_THRESHOLD = 1000; +export const LARGE_DIFF_THRESHOLD = 800;
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/shared/lib/diffRenderMode.ts b/packages/web-core/src/shared/lib/diffRenderMode.ts deleted file mode 100644 index cc0f8fe2c4d..00000000000 --- a/packages/web-core/src/shared/lib/diffRenderMode.ts +++ /dev/null @@ -1,17 +0,0 @@ -import type { Diff } from 'shared/types'; - -export const ...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +615,226 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +615,226 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -160,254 +615,226 @@ export function ChangesPanelContainer({ }); }, [diffs, processedPaths]); - const pathToIndex = useMemo(() => { - const map = new Map<string, number>(); - diffItems.forEach(({ diff }, index) => { - const path = diff.newPath || diff.oldPath || ''; - map.set(path, index);...
bad
review
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
diff --git a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx b/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx index d7912b89590..4b968d13a5f 100644 --- a/packages/web-core/src/pages/workspaces/ChangesPanelContainer.tsx +++ b/packages/web-core/src/pages/workspaces/ChangesPanelContainer...
good
review_fixed
typescript
BloopAI/vibe-kanban
ad962d02c1f8bd7aa26744d61a154170509bdf8a
@@ -458,24 +454,9 @@ const WYSIWYGEditor = forwardRef<WYSIWYGEditorRef, WysiwygProps>( [AttachmentNode, ImageNode] ); - // Edit mode: custom elements + text format transformers (so asterisks - // aren't escaped during $convertToMarkdownString and preview can parse them). - // CODE is excluded so ...
bad
review
typescript
BloopAI/vibe-kanban
1764f9957c930b2fd5de52dc34cd261b46d7eb28
diff --git a/packages/web-core/src/shared/components/WYSIWYGEditor.tsx b/packages/web-core/src/shared/components/WYSIWYGEditor.tsx index c4c0abdb084..4b40fd1b688 100644 --- a/packages/web-core/src/shared/components/WYSIWYGEditor.tsx +++ b/packages/web-core/src/shared/components/WYSIWYGEditor.tsx @@ -15,14 +15,10 @@ imp...
good
review_fixed
typescript
BloopAI/vibe-kanban
1764f9957c930b2fd5de52dc34cd261b46d7eb28