text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -219,6 +228,28 @@ const projectSnapshots: Record<string, any[]> = { ], }, ], + // design project snapshots + proj_5145140e072d4007a30bfa6630ddae73: [ + { + ...commonSnapshotProps, + created: '2026-01-22T06:20:00.759Z', + id: '2ce4bced4220de84704bee82b6174890ba4a89f0', + name: ...
bad
review
typescript
Kong/insomnia
cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a
diff --git a/packages/insomnia-smoke-test/server/cloud-sync-api.ts b/packages/insomnia-smoke-test/server/cloud-sync-api.ts index 69e5f113a7ba..3ce4571d85ab 100644 --- a/packages/insomnia-smoke-test/server/cloud-sync-api.ts +++ b/packages/insomnia-smoke-test/server/cloud-sync-api.ts @@ -1,10 +1,10 @@ +import crypto from...
good
review_fixed
typescript
Kong/insomnia
cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a
@@ -406,6 +406,16 @@ export function registerElectronHandlers() { }); }); ipcMainHandle('showOpenDialog', async (_, options: OpenDialogOptions) => { + // Playwright test hook: consume queued responses set via `electronApp.evaluate` + // instead of opening the native dialog. See packages/insomnia-smoke-...
bad
review
typescript
Kong/insomnia
cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a
diff --git a/packages/insomnia/src/main/ipc/electron.ts b/packages/insomnia/src/main/ipc/electron.ts index 214eea46b656..a6caddb93688 100644 --- a/packages/insomnia/src/main/ipc/electron.ts +++ b/packages/insomnia/src/main/ipc/electron.ts @@ -1,5 +1,9 @@ import { mkdirSync } from 'node:fs'; +declare global { + var ...
good
review_fixed
typescript
Kong/insomnia
cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a
@@ -0,0 +1,422 @@ +import fs from 'node:fs'; +import path from 'node:path'; + +import type { Page } from '@playwright/test'; +import { expect } from '@playwright/test'; +import YAML from 'yaml'; + +import playwrightConfig from '../../playwright.config'; +import { launchInsomnia } from '../../playwright/launch'; +import...
bad
review
typescript
Kong/insomnia
cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a
diff --git a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts new file mode 100644 index 000000000000..df4e42d7d530 --- /dev/null +++ b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts @@ -0,0 +1,406 @@ +import fs f...
good
review_fixed
typescript
Kong/insomnia
cc033dbd62ec49d94d0b3b2b51b7f33cef728e5a
@@ -0,0 +1,55 @@ +import { createHash } from 'node:crypto'; +import fs from 'node:fs'; +import path from 'node:path'; + +import { app } from 'electron'; + +import { compileSpectralRulesetFromContent } from '~/common/bundle-spectral-ruleset'; + +// In-memory cache of the last written ruleset content hash for each projec...
bad
review
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
diff --git a/packages/insomnia/src/main/spectral-ruleset-cache.ts b/packages/insomnia/src/main/spectral-ruleset-cache.ts new file mode 100644 index 000000000000..fa30388fef33 --- /dev/null +++ b/packages/insomnia/src/main/spectral-ruleset-cache.ts @@ -0,0 +1,64 @@ +import { createHash } from 'node:crypto'; +import fs f...
good
review_fixed
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
@@ -266,10 +267,10 @@ const Component = ({ params }: Route.ComponentProps) => { }; useEffect(() => { - registerCodeMirrorLint(selectedRulesetPath); + registerCodeMirrorLint(rulesetContent); // when first time into document editor, the lint helper register later than codemirror init, we need to trigge...
bad
review
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 0ec897c198d7..221768d857b2 100644 --- a/packages/insomnia/src/routes/organization...
good
review_fixed
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
@@ -0,0 +1,55 @@ +import { createHash } from 'node:crypto'; +import fs from 'node:fs'; +import path from 'node:path'; + +import { app } from 'electron'; + +import { compileSpectralRulesetFromContent } from '~/common/bundle-spectral-ruleset'; + +// In-memory cache of the last written ruleset content hash for each projec...
bad
review
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
diff --git a/packages/insomnia/src/main/spectral-ruleset-cache.ts b/packages/insomnia/src/main/spectral-ruleset-cache.ts new file mode 100644 index 000000000000..fa30388fef33 --- /dev/null +++ b/packages/insomnia/src/main/spectral-ruleset-cache.ts @@ -0,0 +1,64 @@ +import { createHash } from 'node:crypto'; +import fs f...
good
review_fixed
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
@@ -0,0 +1,55 @@ +import { createHash } from 'node:crypto'; +import fs from 'node:fs'; +import path from 'node:path'; + +import { app } from 'electron'; + +import { compileSpectralRulesetFromContent } from '~/common/bundle-spectral-ruleset'; + +// In-memory cache of the last written ruleset content hash for each projec...
bad
review
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
diff --git a/packages/insomnia/src/main/spectral-ruleset-cache.ts b/packages/insomnia/src/main/spectral-ruleset-cache.ts new file mode 100644 index 000000000000..fa30388fef33 --- /dev/null +++ b/packages/insomnia/src/main/spectral-ruleset-cache.ts @@ -0,0 +1,64 @@ +import { createHash } from 'node:crypto'; +import fs f...
good
review_fixed
typescript
Kong/insomnia
211400f3d2eb449b8a9716420353ae8b9be40453
@@ -347,6 +354,13 @@ export const KeyValueEditor: FC<Props> = ({ /> </div> {valueEditor} + <ToggleButton + className={`${pair.canDisable ? 'flex' : 'invisible'} aspect-square h-7 items-center justify-center rounded-xs text-sm text-(--c...
bad
review
typescript
Kong/insomnia
ce08a276dcf0ef62fbdfaec4b163cdb67089f96b
diff --git a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx b/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx index 2a687c63ceeb..dff5335232b6 100644 --- a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx +++ b/packages/insomnia/src/ui/compon...
good
review_fixed
typescript
Kong/insomnia
ce08a276dcf0ef62fbdfaec4b163cdb67089f96b
@@ -232,6 +233,9 @@ const openWebSocketConnection = async ( const lowerCasedEnabledHeaders = headers .filter(({ name, disabled }) => Boolean(name) && !disabled) .reduce(reduceArrayToLowerCaseKeyedDictionary, {}); + if (!request.disableUserAgentHeader && lowerCasedEnabledHeaders['user-agent'] === u...
bad
review
typescript
Kong/insomnia
ce08a276dcf0ef62fbdfaec4b163cdb67089f96b
diff --git a/packages/insomnia/src/main/network/websocket.ts b/packages/insomnia/src/main/network/websocket.ts index 466f90792061..adfcc9c5431a 100644 --- a/packages/insomnia/src/main/network/websocket.ts +++ b/packages/insomnia/src/main/network/websocket.ts @@ -22,6 +22,7 @@ import { type CloseEvent, type ErrorEvent, ...
good
review_fixed
typescript
Kong/insomnia
ce08a276dcf0ef62fbdfaec4b163cdb67089f96b
@@ -289,6 +290,9 @@ const openSocketIOConnection = async ( const lowerCasedEnabledHeaders = headers .filter(({ name, disabled }) => Boolean(name) && !disabled) .reduce(reduceArrayToLowerCaseKeyedDictionary, {}); + if (!request.disableUserAgentHeader && lowerCasedEnabledHeaders['user-agent'] === un...
bad
review
typescript
Kong/insomnia
ce08a276dcf0ef62fbdfaec4b163cdb67089f96b
diff --git a/packages/insomnia/src/main/network/socket-io.ts b/packages/insomnia/src/main/network/socket-io.ts index 98bbfe32d5cc..be3ed6c43a1e 100644 --- a/packages/insomnia/src/main/network/socket-io.ts +++ b/packages/insomnia/src/main/network/socket-io.ts @@ -18,6 +18,7 @@ import { v4 as uuidV4 } from 'uuid'; imp...
good
review_fixed
typescript
Kong/insomnia
ce08a276dcf0ef62fbdfaec4b163cdb67089f96b
@@ -194,7 +194,7 @@ export const EnvironmentPicker = ({ <div className="group mx-2 my-2 flex items-center gap-2 rounded-xs border border-solid border-(--hl-sm) bg-(--color-bg) px-2 text-(--color-font) transition-colors focus:ring-1 focus:ring-(--hl-md) focus:outline-hidden"> <Input ...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/environment-picker.tsx b/packages/insomnia/src/ui/components/environment-picker.tsx index 4e82bfcb5850..05e13fff70be 100644 --- a/packages/insomnia/src/ui/components/environment-picker.tsx +++ b/packages/insomnia/src/ui/components/environment-picker.tsx @@ -136,9 +136,9 ...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -194,7 +194,7 @@ export const EnvironmentPicker = ({ <div className="group mx-2 my-2 flex items-center gap-2 rounded-xs border border-solid border-(--hl-sm) bg-(--color-bg) px-2 text-(--color-font) transition-colors focus:ring-1 focus:ring-(--hl-md) focus:outline-hidden"> <Input ...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/environment-picker.tsx b/packages/insomnia/src/ui/components/environment-picker.tsx index 4e82bfcb5850..05e13fff70be 100644 --- a/packages/insomnia/src/ui/components/environment-picker.tsx +++ b/packages/insomnia/src/ui/components/environment-picker.tsx @@ -136,9 +136,9 ...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -657,40 +657,38 @@ export const ProjectNavigationSidebar = ({ targetWorkspaceId: string | null, dropPosition: 'before' | 'after', ) => { - setLocalWorkspaceOrders(prev => { - const isMoveToDifferentProject = sourceProjectId !== targetProjectId; - const workspaces = cachedWorkspa...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx index 266bf3749b53..22c34595771b 100644 --- a/packages/insomnia/src/ui/components/sidebar/project-nav...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -657,40 +657,38 @@ export const ProjectNavigationSidebar = ({ targetWorkspaceId: string | null, dropPosition: 'before' | 'after', ) => { - setLocalWorkspaceOrders(prev => { - const isMoveToDifferentProject = sourceProjectId !== targetProjectId; - const workspaces = cachedWorkspa...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx index 266bf3749b53..22c34595771b 100644 --- a/packages/insomnia/src/ui/components/sidebar/project-nav...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -194,7 +194,7 @@ export const EnvironmentPicker = ({ <div className="group mx-2 my-2 flex items-center gap-2 rounded-xs border border-solid border-(--hl-sm) bg-(--color-bg) px-2 text-(--color-font) transition-colors focus:ring-1 focus:ring-(--hl-md) focus:outline-hidden"> <Input ...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/environment-picker.tsx b/packages/insomnia/src/ui/components/environment-picker.tsx index 4e82bfcb5850..05e13fff70be 100644 --- a/packages/insomnia/src/ui/components/environment-picker.tsx +++ b/packages/insomnia/src/ui/components/environment-picker.tsx @@ -136,9 +136,9 ...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -54,26 +58,22 @@ function canDrop( const dropIsProject = realDropItem.kind === 'project'; const dragInCloud = models.project.isRemoteProject(dragItem.project); - - // workspace -> project: cannot involve cloud project, and cannot move into same project if (dragItem.kind === 'workspace') { const drag...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/use-sidebar-drag-and-drop.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/use-sidebar-drag-and-drop.tsx index ac1f8bc75514..028b19d2e18f 100644 --- a/packages/insomnia/src/ui/components/sidebar/project-navig...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -281,7 +281,7 @@ export function filterCollection(collection: Child[], filter: string): Child[] { // Common tailwind classes export const ROW_CLASS = - 'relative flex h-(--line-height-xs) w-full items-center gap-1 overflow-hidden text-[rgba(var(--color-font-rgb),0.8)] outline-hidden transition-colors select-non...
bad
review
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar-utils.ts b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar-utils.ts index 437ab0b1499d..be6383c9f30e 100644 --- a/packages/insomnia/src/ui/components/sidebar/p...
good
review_fixed
typescript
Kong/insomnia
80f29ae9d066ced3c6fb7e40c6dacb77e72cedd1
@@ -109,18 +109,15 @@ export function SelectPopover<T extends SelectPopoverItem>({ items={[...items]} selectedKeys={selectedKey === null || selectedKey === undefined ? [] : [selectedKey]} selectionMode="single" + disallowEmptySelection onSelectionChange={ke...
bad
review
typescript
Kong/insomnia
ce94a6569ee97b12336d1402cdb5c0a306e602e8
diff --git a/packages/insomnia/src/basic-components/select-popover.tsx b/packages/insomnia/src/basic-components/select-popover.tsx index 64a74cdd90bf..2fa8ff65b3a9 100644 --- a/packages/insomnia/src/basic-components/select-popover.tsx +++ b/packages/insomnia/src/basic-components/select-popover.tsx @@ -109,18 +109,15 @@...
good
review_fixed
typescript
Kong/insomnia
ce94a6569ee97b12336d1402cdb5c0a306e602e8
@@ -83,7 +83,7 @@ export async function clientLoader({ params }: LoaderFunctionArgs) { parentId: project._id, }); - return redirect(`/organization/${organizationId}/project/${project._id}`); + return redirect(`/organization/${organizationId}/project/${project._id}?isExpended=true`);
bad
review
typescript
Kong/insomnia
ce94a6569ee97b12336d1402cdb5c0a306e602e8
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project._index.tsx b/packages/insomnia/src/routes/organization.$organizationId.project._index.tsx index c77c1bbdb432..69195ebb0da5 100644 --- a/packages/insomnia/src/routes/organization.$organizationId.project._index.tsx +++ b/packages/insomnia/src/...
good
review_fixed
typescript
Kong/insomnia
ce94a6569ee97b12336d1402cdb5c0a306e602e8
@@ -171,6 +191,15 @@ const Component = ({ loaderData }: Route.ComponentProps) => { gitRepositoryId, }); + const navigationSidebarRef = useRef<ProjectNavigationSidebarHandle>(null); + + useEffect(() => { + const isExpanded = searchParams.get('isExpended') === 'true'; + if (navigationSidebarRef.current ...
bad
review
typescript
Kong/insomnia
ce94a6569ee97b12336d1402cdb5c0a306e602e8
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx index 25ca878a1614..53dc8b5b04ff 100644 --- a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx +++ b/packages/i...
good
review_fixed
typescript
Kong/insomnia
ce94a6569ee97b12336d1402cdb5c0a306e602e8
@@ -1,10 +1,9 @@ -import { generate, runTests, type Test, type TestResults } from 'insomnia-testing'; +import { generate, type Test, type TestResults } from 'insomnia-testing';
bad
review
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.test.$testId.run.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.test.$testId.run.tsx index...
good
review_fixed
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -1,10 +1,9 @@ -import { generate, runTests, type Test, type TestResults } from 'insomnia-testing'; +import { generate, type Test, type TestResults } from 'insomnia-testing';
bad
review
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.run-all-tests.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.test.test-suite.$testSuiteId.run-all-tests.tsx index 7e2f2...
good
review_fixed
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -20,10 +20,7 @@ "verify-bundle-plugins": "esr --cache ./scripts/verify-bundle-plugins.ts", "install-x64-native-dependencies": "esr --cache ./scripts/install-x64-native-dependencies.ts", "build": "react-router build && esr --cache ./scripts/build.ts --noErrorTruncation", - "analyze:renderer-node-imp...
bad
review
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/package.json b/packages/insomnia/package.json index 3d397f365ec4..53ae7bee3153 100644 --- a/packages/insomnia/package.json +++ b/packages/insomnia/package.json @@ -20,9 +20,6 @@ "verify-bundle-plugins": "esr --cache ./scripts/verify-bundle-plugins.ts", "install-x64-native-depend...
good
review_fixed
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -26,7 +26,6 @@ "scripts": { "dev": "npm start -w insomnia", "dev:autoRestart": "npm run start:autoRestart -w insomnia", - "check:renderer-node-imports": "npm run check:renderer-node-imports -w insomnia", "lint": "npm run lint --workspaces --if-present",
bad
review
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/package.json b/package.json index 4eadfc49f85a..61660319017f 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,6 @@ "scripts": { "dev": "npm start -w insomnia", "dev:autoRestart": "npm run start:autoRestart -w insomnia", - "check:renderer-node-imports": "npm run check:renderer-node-...
good
review_fixed
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -1,24 +1,23 @@ import * as session from '../account/session'; import { getAppWebsiteBaseURL, getInsomniaPublicKey, getInsomniaSecretKey } from '../common/constants'; import { invariant } from '../utils/invariant'; -import { keyPair, open } from '../utils/sealedbox'; interface AuthBox { token: string; key...
bad
review
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/src/ui/auth-session-provider.client.ts b/packages/insomnia/src/ui/auth-session-provider.client.ts index cf33fbfee5c7..6d0bc7026ebe 100644 --- a/packages/insomnia/src/ui/auth-session-provider.client.ts +++ b/packages/insomnia/src/ui/auth-session-provider.client.ts @@ -1,24 +1,23 @@ import...
good
review_fixed
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -0,0 +1,88 @@ +[
bad
review
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia-scripting-environment/src/autocomplete-snippets.json b/packages/insomnia-scripting-environment/src/autocomplete-snippets.json new file mode 100644 index 000000000000..c84261c71dbd --- /dev/null +++ b/packages/insomnia-scripting-environment/src/autocomplete-snippets.json @@ -0,0 +1,1137 @@...
good
review_fixed
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -1,10 +1,21 @@ import { getEncryptionKeys, getUserProfile, logout as logoutAPI } from 'insomnia-api'; import type { GitRepository, Project, WorkspaceMeta } from 'insomnia-data'; +import type { AESMessage } from 'insomnia-data'; import { models, services } from 'insomnia-data'; import { AI_PLUGIN_NAME, LLM_BACK...
bad
review
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/src/account/session.ts b/packages/insomnia/src/account/session.ts index 509cffa089e3..aafa473cfe8c 100644 --- a/packages/insomnia/src/account/session.ts +++ b/packages/insomnia/src/account/session.ts @@ -1,10 +1,11 @@ import { getEncryptionKeys, getUserProfile, logout as logoutAPI } from...
good
review_fixed
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -201,10 +199,9 @@ export function createWindow(): ElectronBrowserWindow { webPreferences: { preload: path.join(__dirname, 'entry.preload.min.js'), zoomFactor: getZoomFactor(), - nodeIntegration: true, - nodeIntegrationInWorker: false, // must remain false to ensure the nunjucks web worke...
bad
review
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/src/main/window-utils.ts b/packages/insomnia/src/main/window-utils.ts index e4e17a67dce2..6dd0945d9563 100644 --- a/packages/insomnia/src/main/window-utils.ts +++ b/packages/insomnia/src/main/window-utils.ts @@ -201,7 +201,7 @@ export function createWindow(): ElectronBrowserWindow { ...
good
review_fixed
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -270,7 +267,6 @@ export function createWindow(): ElectronBrowserWindow { { label: `${MNEMONIC_SYM}Preferences`, click: () => {
bad
review
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
diff --git a/packages/insomnia/src/main/window-utils.ts b/packages/insomnia/src/main/window-utils.ts index e4e17a67dce2..6dd0945d9563 100644 --- a/packages/insomnia/src/main/window-utils.ts +++ b/packages/insomnia/src/main/window-utils.ts @@ -201,7 +201,7 @@ export function createWindow(): ElectronBrowserWindow { ...
good
review_fixed
typescript
Kong/insomnia
6b3adaf59737f4c34b813ea3abd3a0cf0d121c38
@@ -1,4 +1,5 @@ import type { IconProp } from '@fortawesome/fontawesome-svg-core'; +import { AnalyticsEvent } from 'insomnia-analytics/events';
bad
review
typescript
Kong/insomnia
b8ebe2e0a284507cb5fc72474fcd5fbc17d91711
diff --git a/packages/insomnia/src/ui/components/first-request-creation.tsx b/packages/insomnia/src/ui/components/first-request-creation.tsx index 0dbe126968c0..ed9fc7359407 100644 --- a/packages/insomnia/src/ui/components/first-request-creation.tsx +++ b/packages/insomnia/src/ui/components/first-request-creation.tsx @...
good
review_fixed
typescript
Kong/insomnia
b8ebe2e0a284507cb5fc72474fcd5fbc17d91711
@@ -0,0 +1,42 @@ +export function utf8BytesFromString(value: string): Uint8Array { + return new TextEncoder().encode(value); +} + +export function utf8ByteLength(value: string): number { + return utf8BytesFromString(value).length; +} + +export function utf8StringFromBytes(bytes: Uint8Array): string { + return new Te...
bad
review
typescript
Kong/insomnia
b6215805a9b161c48d4963da32e03aac2af3e7a0
diff --git a/packages/insomnia/src/utils/utf8-bytes.ts b/packages/insomnia/src/utils/utf8-bytes.ts new file mode 100644 index 000000000000..b93cd68c0cdd --- /dev/null +++ b/packages/insomnia/src/utils/utf8-bytes.ts @@ -0,0 +1,39 @@ +const BASE64_CHUNK_SIZE = 0x80_00; + +export function utf8BytesFromString(value: string...
good
review_fixed
typescript
Kong/insomnia
b6215805a9b161c48d4963da32e03aac2af3e7a0
@@ -0,0 +1,33 @@ +import { expect } from '@playwright/test'; + +import { test } from '../../playwright/test'; + +test.describe('Konnect sidebar tab', () => { + test('shows intro card without a PAT, configure it, then sync', async ({ page, insomnia }) => { + await page.getByTestId('sidebar-tab-konnect').click(); + ...
bad
review
typescript
Kong/insomnia
3554248222ff6051d41f819fd229c74a5daebe8e
diff --git a/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts new file mode 100644 index 000000000000..172592bd35cb --- /dev/null +++ b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts @@ -0,0 +1,40 @@ +import { expect } from '@playwright/test';...
good
review_fixed
typescript
Kong/insomnia
3554248222ff6051d41f819fd229c74a5daebe8e
@@ -99,34 +142,45 @@ export const Url = ({ setIsLoadingModels(false); } }, - [saveLLMSettings, url], + [saveLLMSettings, url, apiKey, modelParameters, selectedModel, currentLLM], ); useEffect(() => { + if (hasHydratedFromConfig && currentLLM?.backend === URL_BACKEND && hasChanges) ...
bad
review
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx index 4e252e31f0d4..ca9777545dbf 100644 --- a/packages/insomnia/src/ui/components/settings/llms/url.tsx +++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx @@ -3,6 +3,17 @@ impo...
good
review_fixed
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
@@ -179,6 +252,99 @@ export const Url = ({ )} </Button> </div> + <div className="form-control form-control--outlined mt-2"> + <label htmlFor={apiKeyId}>API Token</label> + <div className="flex items-center gap-2"> + <Input + id={apiKeyId}...
bad
review
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx index 4e252e31f0d4..ca9777545dbf 100644 --- a/packages/insomnia/src/ui/components/settings/llms/url.tsx +++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx @@ -3,6 +3,17 @@ impo...
good
review_fixed
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
@@ -179,6 +252,99 @@ export const Url = ({ )} </Button> </div> + <div className="form-control form-control--outlined mt-2"> + <label htmlFor={apiKeyId}>API Token</label> + <div className="flex items-center gap-2"> + <Input + id={apiKeyId}...
bad
review
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx index 4e252e31f0d4..ca9777545dbf 100644 --- a/packages/insomnia/src/ui/components/settings/llms/url.tsx +++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx @@ -3,6 +3,17 @@ impo...
good
review_fixed
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
@@ -0,0 +1,86 @@ +import z from 'zod/v4'; + +import type { LLMConfig } from '~/main/llm-config-service'; + +export const urlModelParametersSchema = z.object({ + temperature: z.number().min(0).max(2), + topP: z.number().min(0).max(1), + maxTokens: z.number().int().min(1).max(128_000), +}); + +export type UrlModelPara...
bad
review
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
diff --git a/packages/insomnia/src/ui/components/settings/llms/url-utils.ts b/packages/insomnia/src/ui/components/settings/llms/url-utils.ts new file mode 100644 index 000000000000..61a4564df886 --- /dev/null +++ b/packages/insomnia/src/ui/components/settings/llms/url-utils.ts @@ -0,0 +1,86 @@ +import z from 'zod/v4'; ...
good
review_fixed
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
@@ -797,14 +797,19 @@ export function registerMainHandlers() { reject({ error: err.toString() }); }); const { systemPrompt, messages, modelConfig: modelConfigFromSamplingRequest } = input; + const mergedModelConfig = !modelConfig + ? modelConfigFromSamplingRequest + : modelConf...
bad
review
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
diff --git a/packages/insomnia/src/main/ipc/main.ts b/packages/insomnia/src/main/ipc/main.ts index 71f521eb6604..a6ea08f0c933 100644 --- a/packages/insomnia/src/main/ipc/main.ts +++ b/packages/insomnia/src/main/ipc/main.ts @@ -797,14 +797,17 @@ export function registerMainHandlers() { reject({ error: err.toStr...
good
review_fixed
typescript
Kong/insomnia
479e8d16dfda209ce8dd54f8ffc30b9d762b0694
@@ -40,9 +41,17 @@ def _prepare_message(message: inference.MessageRead) -> str: # Construct prompt messages = [_prepare_message(message) for message in work_request.thread.messages] - # Prepend system prompt if it was specified in work parameters - if work_request.parameters.system_prompt: - pr...
bad
review
python
LAION-AI/Open-Assistant
12c371595070ae312f549dc9d064b0360572173c
diff --git a/inference/worker/work.py b/inference/worker/work.py index 9fe81491d1..c2dfa6f0f7 100644 --- a/inference/worker/work.py +++ b/inference/worker/work.py @@ -9,6 +9,7 @@ import websocket from chat_chain_prompts import ( ASSISTANT_PREFIX, + CUSTOM_INSTRUCTIONS_PREFIX, END_SEQ, OBSERVATION_SE...
good
review_fixed
python
LAION-AI/Open-Assistant
12c371595070ae312f549dc9d064b0360572173c
@@ -355,11 +379,17 @@ def handle_conversation( "language", "current_time", "action_input_format", + "custom_instructions", ] + (["tools_names"] if plugin_enabled else []) # TODO: Consider passing language from the UI here prompt_template = P...
bad
review
python
LAION-AI/Open-Assistant
12c371595070ae312f549dc9d064b0360572173c
diff --git a/inference/worker/chat_chain.py b/inference/worker/chat_chain.py index c4a5406976..70c732bbb3 100644 --- a/inference/worker/chat_chain.py +++ b/inference/worker/chat_chain.py @@ -6,6 +6,7 @@ import websocket from chat_chain_prompts import ( ASSISTANT_PREFIX, + CUSTOM_INSTRUCTIONS_PREFIX, HUMA...
good
review_fixed
python
LAION-AI/Open-Assistant
12c371595070ae312f549dc9d064b0360572173c
@@ -40,9 +41,20 @@ def _prepare_message(message: inference.MessageRead) -> str: # Construct prompt messages = [_prepare_message(message) for message in work_request.thread.messages] - # Prepend system prompt if it was specified in work parameters - if work_request.parameters.system_prompt: - pr...
bad
review
python
LAION-AI/Open-Assistant
12c371595070ae312f549dc9d064b0360572173c
diff --git a/inference/worker/work.py b/inference/worker/work.py index 9fe81491d1..c2dfa6f0f7 100644 --- a/inference/worker/work.py +++ b/inference/worker/work.py @@ -9,6 +9,7 @@ import websocket from chat_chain_prompts import ( ASSISTANT_PREFIX, + CUSTOM_INSTRUCTIONS_PREFIX, END_SEQ, OBSERVATION_SE...
good
review_fixed
python
LAION-AI/Open-Assistant
12c371595070ae312f549dc9d064b0360572173c
@@ -6,6 +6,10 @@ - Minimum Java version now 11 - Issue #323 - `WorkerPool` and `WorkProcessor` have been removed, no more `Disruptor::handleEventsWithWorkerPool` - `Disruptor` constructors using Executor have been removed. Use ThreadFactory instead. + - Rolled up event handling extnsion interfaces on ...
bad
review
LMAX-Exchange/disruptor
41019373a0a8e9ac2708cddd75be338fe69f1171
diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d7f770ca..c3fc4112f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,10 @@ - Minimum Java version now 11 - Issue #323 - `WorkerPool` and `WorkProcessor` have been removed, no more `Disruptor::handleEventsWithWorkerPool` - `Disruptor` constructors usi...
good
review_fixed
LMAX-Exchange/disruptor
41019373a0a8e9ac2708cddd75be338fe69f1171
@@ -12,16 +15,57 @@ private final Sequence sequence; private final Sequence gatingSequence; + /** + * A callback used to process events + * + * @param <T> the type of the event + */ public interface Handler<T> { + /** + * Called for each event to consume it + ...
bad
review
java
LMAX-Exchange/disruptor
e47124de878eecf19ca5499302f549a600542449
diff --git a/src/main/java/com/lmax/disruptor/EventPoller.java b/src/main/java/com/lmax/disruptor/EventPoller.java index 0f55562e3..dc919c4f0 100644 --- a/src/main/java/com/lmax/disruptor/EventPoller.java +++ b/src/main/java/com/lmax/disruptor/EventPoller.java @@ -1,7 +1,10 @@ package com.lmax.disruptor; /** - * Ex...
good
review_fixed
java
LMAX-Exchange/disruptor
e47124de878eecf19ca5499302f549a600542449
@@ -12,16 +15,57 @@ private final Sequence sequence; private final Sequence gatingSequence; + /** + * A callback used to process events + * + * @param <T> the type of the event + */ public interface Handler<T> { + /** + * Called for each event to consume it + ...
bad
review
java
LMAX-Exchange/disruptor
e47124de878eecf19ca5499302f549a600542449
diff --git a/src/main/java/com/lmax/disruptor/EventPoller.java b/src/main/java/com/lmax/disruptor/EventPoller.java index 0f55562e3..dc919c4f0 100644 --- a/src/main/java/com/lmax/disruptor/EventPoller.java +++ b/src/main/java/com/lmax/disruptor/EventPoller.java @@ -1,7 +1,10 @@ package com.lmax.disruptor; /** - * Ex...
good
review_fixed
java
LMAX-Exchange/disruptor
e47124de878eecf19ca5499302f549a600542449
@@ -12,16 +15,57 @@ private final Sequence sequence; private final Sequence gatingSequence; + /** + * A callback used to process events + * + * @param <T> the type of the event + */ public interface Handler<T> { + /** + * Called for each event to consume it + ...
bad
review
java
LMAX-Exchange/disruptor
e47124de878eecf19ca5499302f549a600542449
diff --git a/src/main/java/com/lmax/disruptor/EventPoller.java b/src/main/java/com/lmax/disruptor/EventPoller.java index 0f55562e3..dc919c4f0 100644 --- a/src/main/java/com/lmax/disruptor/EventPoller.java +++ b/src/main/java/com/lmax/disruptor/EventPoller.java @@ -1,7 +1,10 @@ package com.lmax.disruptor; /** - * Ex...
good
review_fixed
java
LMAX-Exchange/disruptor
e47124de878eecf19ca5499302f549a600542449
@@ -38,5 +38,9 @@ */ void halt(); + /** + * @return whether this event processor is running or not + * Implementations should ideally return true only when the associated thread is idle.
bad
review
java
LMAX-Exchange/disruptor
78dc17e921db1df6faaf194a0783cadbba271c69
diff --git a/src/main/java/com/lmax/disruptor/EventProcessor.java b/src/main/java/com/lmax/disruptor/EventProcessor.java index 5fcf20717..482ed3d88 100644 --- a/src/main/java/com/lmax/disruptor/EventProcessor.java +++ b/src/main/java/com/lmax/disruptor/EventProcessor.java @@ -38,5 +38,9 @@ public interface EventProcess...
good
review_fixed
java
LMAX-Exchange/disruptor
78dc17e921db1df6faaf194a0783cadbba271c69
@@ -0,0 +1,9 @@ +package com.lmax.disruptor; + +public class RewindableException extends RuntimeException +{ + public RewindableException(Throwable cause)
bad
review
java
LMAX-Exchange/disruptor
3f9bc8fe1d4af04d0b01f8b0c374c1f3009c01d4
diff --git a/src/main/java/com/lmax/disruptor/RewindableException.java b/src/main/java/com/lmax/disruptor/RewindableException.java new file mode 100644 index 000000000..2b5550cb3 --- /dev/null +++ b/src/main/java/com/lmax/disruptor/RewindableException.java @@ -0,0 +1,17 @@ +package com.lmax.disruptor; + +/** + * A spec...
good
review_fixed
java
LMAX-Exchange/disruptor
3f9bc8fe1d4af04d0b01f8b0c374c1f3009c01d4
@@ -180,6 +198,11 @@ private void processEvents() break; } } + catch (final RewindableException e)
bad
review
java
LMAX-Exchange/disruptor
3f9bc8fe1d4af04d0b01f8b0c374c1f3009c01d4
diff --git a/src/main/java/com/lmax/disruptor/BatchEventProcessor.java b/src/main/java/com/lmax/disruptor/BatchEventProcessor.java index b05ba58ac..9375e15e3 100644 --- a/src/main/java/com/lmax/disruptor/BatchEventProcessor.java +++ b/src/main/java/com/lmax/disruptor/BatchEventProcessor.java @@ -17,6 +17,8 @@ import...
good
review_fixed
java
LMAX-Exchange/disruptor
3f9bc8fe1d4af04d0b01f8b0c374c1f3009c01d4
@@ -14,104 +14,62 @@ * limitations under the License. */ plugins { - id 'java' - id 'osgi' - id 'maven' + id 'java-library' + id 'maven-publish' id 'signing' - id 'eclipse' // Only used so the Eclipse STS Gradle plugin can see the 'perf' source set dependencies. :-( id 'checkstyle' ...
bad
review
LMAX-Exchange/disruptor
ce6f2e4ec3a816e6c0817ee2d8077193aa132c68
diff --git a/build.gradle b/build.gradle index 495402c1d..bccaa0cd6 100644 --- a/build.gradle +++ b/build.gradle @@ -14,41 +14,20 @@ * limitations under the License. */ plugins { - id 'java' - id 'maven' + id 'java-library' + id 'maven-publish' id 'signing' - id 'eclipse' // Only used so the Ec...
good
review_fixed
LMAX-Exchange/disruptor
ce6f2e4ec3a816e6c0817ee2d8077193aa132c68
@@ -132,107 +90,13 @@ jar { 'Automatic-Module-Name': moduleName) } -task sourcesJar(type: Jar) { - classifier = 'sources' - from sourceSets.main.allSource -} - -task javadocJar(type: Jar, dependsOn: javadoc) { - classifier = 'javadoc' - from javadoc.destinationDir -} - -artifacts { - arch...
bad
review
LMAX-Exchange/disruptor
ce6f2e4ec3a816e6c0817ee2d8077193aa132c68
diff --git a/build.gradle b/build.gradle index 495402c1d..bccaa0cd6 100644 --- a/build.gradle +++ b/build.gradle @@ -14,41 +14,20 @@ * limitations under the License. */ plugins { - id 'java' - id 'maven' + id 'java-library' + id 'maven-publish' id 'signing' - id 'eclipse' // Only used so the Ec...
good
review_fixed
LMAX-Exchange/disruptor
ce6f2e4ec3a816e6c0817ee2d8077193aa132c68
@@ -0,0 +1,38 @@ +// +// Configure JMH benchmarks +// + +sourceSets { + jmh { + compileClasspath += sourceSets.main.output + runtimeClasspath += sourceSets.main.output + } +} + +task jmh(type: JavaExec, description: 'Executing JMH benchmarks', group: 'performance') { + classpath = sourceSets.jmh....
bad
review
LMAX-Exchange/disruptor
ce6f2e4ec3a816e6c0817ee2d8077193aa132c68
diff --git a/gradle/jmh.gradle b/gradle/jmh.gradle new file mode 100644 index 000000000..edc14601b --- /dev/null +++ b/gradle/jmh.gradle @@ -0,0 +1,43 @@ +// +// Configure JMH benchmarks +// + +sourceSets { + jmh { + compileClasspath += sourceSets.main.output + runtimeClasspath += sourceSets.main.outpu...
good
review_fixed
LMAX-Exchange/disruptor
ce6f2e4ec3a816e6c0817ee2d8077193aa132c68