text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -5,16 +5,14 @@ open System.Globalization open Microsoft.Extensions.Primitives open Oxpecker open Xunit -open FsUnitTyped +open FsUnit.Xunit
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/tests/Oxpecker.Tests/ModelParser.Tests.fs b/tests/Oxpecker.Tests/ModelParser.Tests.fs index 910e19a1..9032bfa8 100644 --- a/tests/Oxpecker.Tests/ModelParser.Tests.fs +++ b/tests/Oxpecker.Tests/ModelParser.Tests.fs @@ -1,20 +1,22 @@ module Oxpecker.Tests.ModelParser open System +open System.Collections....
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,264 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +[<Struct>] +type internal RawData = + | RawString of rawString: (string | null) + | RawArray of rawArray: (string | null) array + | RawValues of rawDi...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -328,7 +291,4 @@ type ModelBinder(?options: ModelBinderOptions) = /// It will try to match each property of 'T with a key from the data dictionary and parse the associated value to the value of 'T's property. /// </summary> member this.Bind<'T>(data) = - let model = Activator.Cr...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -10,7 +10,7 @@ class Main extends Plugin { protected ?string $vendor = 'laravel/passkeys'; - protected string $version = 'dev-main || ^0.1.0'; + protected string $version = 'dev-main || ^0.2';
bad
review
php
Laravel-Lang/lang
1cefb80c4bc5e049fd70a29e9328d633b955a29a
diff --git a/src/Plugins/Passkeys/Main.php b/src/Plugins/Passkeys/Main.php index aa72932d174..fb829a9dc59 100644 --- a/src/Plugins/Passkeys/Main.php +++ b/src/Plugins/Passkeys/Main.php @@ -10,7 +10,7 @@ class Main extends Plugin { protected ?string $vendor = 'laravel/passkeys'; - protected string $version = ...
good
review_fixed
php
Laravel-Lang/lang
1cefb80c4bc5e049fd70a29e9328d633b955a29a
@@ -556,7 +556,7 @@ "Reset Filters": "بازنشانی فیلتر ها", "Reset Password": "فراموشی رمزعبور", "Reset Password Notification": "پیام فراموشی رمزعبور", - "Reset your password": "Reset your password", + "Reset your password": "بازنشانی رمزعبور خود",
bad
review
Laravel-Lang/lang
ec3a32b3f39d6940b6eb60169e500deb2cb898c0
diff --git a/locales/fa/json.json b/locales/fa/json.json index 9337ab17a32..3008309e6ab 100644 --- a/locales/fa/json.json +++ b/locales/fa/json.json @@ -556,7 +556,7 @@ "Reset Filters": "بازنشانی فیلتر ها", "Reset Password": "فراموشی رمزعبور", "Reset Password Notification": "پیام فراموشی رمزعبور", - "...
good
review_fixed
Laravel-Lang/lang
ec3a32b3f39d6940b6eb60169e500deb2cb898c0
@@ -141,20 +141,20 @@ "Cayman Islands": "Kaaimaneilanden", "Central African Republic": "Centraal-Afrikaanse Republiek", "Chad": "Tsjaad", - "Change Subscription Plan": "Wijzig abonnement", + "Change Subscription Plan": "Abonnement wijzigen", "Change the current payment method attached to your ...
bad
review
Laravel-Lang/lang
203462ddc1e0cc43e30115e8b6739fdc4cd3d0c4
diff --git a/locales/nl/json.json b/locales/nl/json.json index e84e258a87d..5d7548d6b81 100644 --- a/locales/nl/json.json +++ b/locales/nl/json.json @@ -6,7 +6,7 @@ "90 Days": "90 dagen", ":amount selected": ":amount geselecteerd", ":amount Total": ":amount in totaal", - ":days day trial": ":days dage...
good
review_fixed
Laravel-Lang/lang
203462ddc1e0cc43e30115e8b6739fdc4cd3d0c4
@@ -82,3 +82,32 @@ SELECT User, Host FROM mysql.user; # List all current MySQL users SET GLOBAL general_log = 'ON'; # Enable query logging SHOW FULL PROCESSLIST; # Show the last queries executed in MySQL + +# ***************************************************************************** +# Altering Table Structure +...
bad
review
LeCoupa/awesome-cheatsheets
6326628901fce3a80d4f5c31a6ecda147b58d0e0
diff --git a/databases/mysql.sh b/databases/mysql.sh index d90c129a..43226f5f 100644 --- a/databases/mysql.sh +++ b/databases/mysql.sh @@ -82,3 +82,33 @@ SELECT User, Host FROM mysql.user; # List all current MySQL users SET GLOBAL general_log = 'ON'; # Enable query logging SHOW FULL PROCESSLIST; # Show the last que...
good
review_fixed
LeCoupa/awesome-cheatsheets
6326628901fce3a80d4f5c31a6ecda147b58d0e0
@@ -82,3 +82,32 @@ SELECT User, Host FROM mysql.user; # List all current MySQL users SET GLOBAL general_log = 'ON'; # Enable query logging SHOW FULL PROCESSLIST; # Show the last queries executed in MySQL + +# ***************************************************************************** +# Altering Table Structure +...
bad
review
LeCoupa/awesome-cheatsheets
6326628901fce3a80d4f5c31a6ecda147b58d0e0
diff --git a/databases/mysql.sh b/databases/mysql.sh index d90c129a..43226f5f 100644 --- a/databases/mysql.sh +++ b/databases/mysql.sh @@ -82,3 +82,33 @@ SELECT User, Host FROM mysql.user; # List all current MySQL users SET GLOBAL general_log = 'ON'; # Enable query logging SHOW FULL PROCESSLIST; # Show the last que...
good
review_fixed
LeCoupa/awesome-cheatsheets
6326628901fce3a80d4f5c31a6ecda147b58d0e0
@@ -38,6 +65,25 @@ arsort($arr); // Sort associative arrays in descending order, according to the value. krsort($arr); // Sort associative arrays in descending order, according to the key. +/** + * Conditions + */ + + // If/Elseif/Else +if($i > 10) { + +} elseif( $i > 100) { + +} else { + +} + +// Ternary +$string ...
bad
review
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
diff --git a/languages/php.php b/languages/php.php index 876550ec..83d8da2e 100644 --- a/languages/php.php +++ b/languages/php.php @@ -11,9 +11,26 @@ print_r($arr); // Print anything, with type hints for array's and object's var_dump($arr); // Print anything, with type hints for any value and sizes +/** + * Usefull...
good
review_fixed
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
@@ -97,6 +163,31 @@ $argv; // Array of terminal arguments (filename included) $argc; // Number of arguments passed into terminal +/** + * Functions + */ + + // Simple function + function name($parameter); + + // Function with return type (void, int, float, string, array, object, mixed)
bad
review
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
diff --git a/languages/php.php b/languages/php.php index 876550ec..83d8da2e 100644 --- a/languages/php.php +++ b/languages/php.php @@ -11,9 +11,26 @@ print_r($arr); // Print anything, with type hints for array's and object's var_dump($arr); // Print anything, with type hints for any value and sizes +/** + * Usefull...
good
review_fixed
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
@@ -368,6 +459,48 @@ class ClassWithLogger } +/** + * Enums (PHP >=8.1)
bad
review
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
diff --git a/languages/php.php b/languages/php.php index 876550ec..83d8da2e 100644 --- a/languages/php.php +++ b/languages/php.php @@ -11,9 +11,26 @@ print_r($arr); // Print anything, with type hints for array's and object's var_dump($arr); // Print anything, with type hints for any value and sizes +/** + * Usefull...
good
review_fixed
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
@@ -368,6 +459,48 @@ class ClassWithLogger } +/** + * Enums (PHP >=8.1) + * https://www.php.net/manual/fr/language.types.enumerations.php
bad
review
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
diff --git a/languages/php.php b/languages/php.php index 876550ec..83d8da2e 100644 --- a/languages/php.php +++ b/languages/php.php @@ -11,9 +11,26 @@ print_r($arr); // Print anything, with type hints for array's and object's var_dump($arr); // Print anything, with type hints for any value and sizes +/** + * Usefull...
good
review_fixed
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
@@ -97,6 +163,31 @@ $argv; // Array of terminal arguments (filename included) $argc; // Number of arguments passed into terminal +/** + * Functions + */ + + // Simple function
bad
review
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
diff --git a/languages/php.php b/languages/php.php index 876550ec..83d8da2e 100644 --- a/languages/php.php +++ b/languages/php.php @@ -11,9 +11,26 @@ print_r($arr); // Print anything, with type hints for array's and object's var_dump($arr); // Print anything, with type hints for any value and sizes +/** + * Usefull...
good
review_fixed
php
LeCoupa/awesome-cheatsheets
d5b2d4abb640aee277048aeac339422a9a1ec52f
@@ -170,7 +170,6 @@ export class LeafletMap extends Evented { this.callInitHooks(); - // don't animate on browsers without hardware-accelerated transitions or old Android this._zoomAnimated = this.options.zoomAnimation;
bad
review
javascript
Leaflet/Leaflet
a5c7719d9c2e06158b5eb5dce0baa853cd6cbddb
diff --git a/src/map/Map.js b/src/map/Map.js index 0eb1e56451..d32eca949c 100644 --- a/src/map/Map.js +++ b/src/map/Map.js @@ -170,7 +170,6 @@ export class LeafletMap extends Evented { this.callInitHooks(); - // don't animate on browsers without hardware-accelerated transitions or old Android this._zoomAnima...
good
review_fixed
javascript
Leaflet/Leaflet
a5c7719d9c2e06158b5eb5dce0baa853cd6cbddb
@@ -94,17 +94,15 @@ export class TileLayer extends GridLayer { options = Util.setOptions(this, options); - // in case the attribution hasn't been specified, check for known hosts that require attribution - if (options.attribution === null) { - const urlHostname = new URL(url, location.href).hostname; -...
bad
review
javascript
Leaflet/Leaflet
3d0bc3d124f2d97c879ec1d244390faf7270633d
diff --git a/src/layer/tile/TileLayer.js b/src/layer/tile/TileLayer.js index bbaeb88e86..2a059506b8 100644 --- a/src/layer/tile/TileLayer.js +++ b/src/layer/tile/TileLayer.js @@ -78,13 +78,13 @@ export class TileLayer extends GridLayer { // Refer to [CORS Settings](https://developer.mozilla.org/en-US/docs/Web/HTML/...
good
review_fixed
javascript
Leaflet/Leaflet
3d0bc3d124f2d97c879ec1d244390faf7270633d
@@ -192,7 +192,7 @@ export const Layers = Control.extend({ container = this._container = DomUtil.create('div', className), collapsed = this.options.collapsed; - // makes this work on IE touch devices by stopping it from firing a mouseout event when the touch is released + // makes this work on IE ...
bad
review
javascript
Leaflet/Leaflet
abd3c138787ce5de8b5e83d1c6cfcdc06369ae91
diff --git a/src/control/Control.Layers.js b/src/control/Control.Layers.js index b0421c2fa7d..8e42665e5b9 100644 --- a/src/control/Control.Layers.js +++ b/src/control/Control.Layers.js @@ -48,7 +48,7 @@ export const Layers = Control.extend({ // @aka Control.Layers options options: { // @option collapsed: Boole...
good
review_fixed
javascript
Leaflet/Leaflet
abd3c138787ce5de8b5e83d1c6cfcdc06369ae91
@@ -55,7 +55,77 @@ describe('Circle', () => { const circle = new Circle([0, 0], {radius: 200}).addTo(map); - expect(circle._radius).to.eql(3200); + expect(circle._radius).to.eql(200); + expect(circle._pxRadius).to.eql(3200); + }); + }); +}); + +describe('Circle', () => {
bad
review
javascript
Leaflet/Leaflet
46f5153d8e830f6c3c320f153b459ad777f35773
diff --git a/spec/suites/layer/vector/CircleSpec.js b/spec/suites/layer/vector/CircleSpec.js index 88472692da..8d079b165c 100644 --- a/spec/suites/layer/vector/CircleSpec.js +++ b/spec/suites/layer/vector/CircleSpec.js @@ -55,7 +55,70 @@ describe('Circle', () => { const circle = new Circle([0, 0], {radius: 200})....
good
review_fixed
javascript
Leaflet/Leaflet
46f5153d8e830f6c3c320f153b459ad777f35773
@@ -22,7 +22,7 @@ export class CircleMarker extends Path { fill: true, // @option radius: Number = 10 - // Radius of the circle marker, in pixels
bad
review
javascript
Leaflet/Leaflet
46f5153d8e830f6c3c320f153b459ad777f35773
diff --git a/src/layer/vector/CircleMarker.js b/src/layer/vector/CircleMarker.js index 16e33753e3..f64ac91f47 100644 --- a/src/layer/vector/CircleMarker.js +++ b/src/layer/vector/CircleMarker.js @@ -8,7 +8,7 @@ import {Bounds} from '../../geometry/Bounds.js'; * @class CircleMarker * @inherits Path * - * A circle ...
good
review_fixed
javascript
Leaflet/Leaflet
46f5153d8e830f6c3c320f153b459ad777f35773
@@ -182,8 +182,10 @@ export function disableScrollPropagation(el) { } // @function disableClickPropagation(el: HTMLElement): this -// Adds `stopPropagation` to the element's `'click'`, `'dblclick'`, `'contextmenu'` +// Adds `stopPropagation` to the element's `'dblclick'`, `'contextmenu'` // and `'pointerdown'` eve...
bad
review
javascript
Leaflet/Leaflet
84d2431d4cb3626d0920be257ae131d9b44713cb
diff --git a/src/dom/DomEvent.js b/src/dom/DomEvent.js index ec58c8fb6b..a8de0730c3 100644 --- a/src/dom/DomEvent.js +++ b/src/dom/DomEvent.js @@ -182,8 +182,10 @@ export function disableScrollPropagation(el) { } // @function disableClickPropagation(el: HTMLElement): this -// Adds `stopPropagation` to the element's...
good
review_fixed
javascript
Leaflet/Leaflet
84d2431d4cb3626d0920be257ae131d9b44713cb
@@ -181,8 +182,11 @@ export function disableScrollPropagation(el) { } // @function disableClickPropagation(el: HTMLElement): this -// Adds `stopPropagation` to the element's `'click'`, `'dblclick'`, `'contextmenu'` +// Adds `stopPropagation` to the element's `'dblclick'`, `'contextmenu'` // and `'pointerdown'` eve...
bad
review
javascript
Leaflet/Leaflet
84d2431d4cb3626d0920be257ae131d9b44713cb
diff --git a/src/dom/DomEvent.js b/src/dom/DomEvent.js index ec58c8fb6b..a8de0730c3 100644 --- a/src/dom/DomEvent.js +++ b/src/dom/DomEvent.js @@ -182,8 +182,10 @@ export function disableScrollPropagation(el) { } // @function disableClickPropagation(el: HTMLElement): this -// Adds `stopPropagation` to the element's...
good
review_fixed
javascript
Leaflet/Leaflet
84d2431d4cb3626d0920be257ae131d9b44713cb
@@ -106,7 +106,7 @@ export class Draggable extends Evented { // Cache the scale, so that we can continuously compensate for it during drag (_onMove). this._parentScale = DomUtil.getScale(sizedParent); - DomEvent.on(document, 'pointermove', this._onMove, this); + DomEvent.on(this._element.ownerDocument, 'point...
bad
review
javascript
Leaflet/Leaflet
822f2c24835965b580ffd26ac5564c92de5cf06d
diff --git a/src/dom/Draggable.js b/src/dom/Draggable.js index c514b8878b..b368810887 100644 --- a/src/dom/Draggable.js +++ b/src/dom/Draggable.js @@ -106,8 +106,8 @@ export class Draggable extends Evented { // Cache the scale, so that we can continuously compensate for it during drag (_onMove). this._parentScale...
good
review_fixed
javascript
Leaflet/Leaflet
822f2c24835965b580ffd26ac5564c92de5cf06d
@@ -8,16 +8,16 @@ jobs: build: runs-on: windows-2022 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v6
bad
review
LibreHardwareMonitor/LibreHardwareMonitor
571a2e122d6f381a4840a501388c3ddef87856b6
diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index 71ccf172b..de15b70e8 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -8,16 +8,16 @@ jobs: build: runs-on: windows-2022 steps: - - uses: actions/checkout@v4 - - uses: actions/setup-dotnet...
good
review_fixed
LibreHardwareMonitor/LibreHardwareMonitor
571a2e122d6f381a4840a501388c3ddef87856b6
@@ -161,60 +203,70 @@ private void CreateAttributes() { _attributes.Clear(); - var attributes = SmartAttributeTranslator.GetAttributesFor(_storage); + var attributes = _storage.SmartAttributes.Select(a => new SmartAttribute(a, null, 0, null)); _attributes.AddRange(attributes.Whe...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -336,11 +384,11 @@ private void ToggleSpaceSensors() private void UpdateSpaceSensors() { - if (_storage.TotalSize > 0) + if (_storage.DiskSizeBytes > 0) { // Set sensor value - _usageSensor.Value = 100.0f - (100.0f * _storage.TotalFreeSize / _storage.TotalSi...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -1,7 +1,6 @@ // This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. // If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -// Copyright (C) LibreHardwareMonitor and Contributors. -// Partial Copyright (C) Michael Möller <mmo...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -1,13 +1,13 @@ // This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. // If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -// Copyright (C) LibreHardwareMonitor and Contributors. -// Partial Copyright (C) Michael Möller <m...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -1,12 +1,13 @@ // This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. // If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -// Copyright (C) LibreHardwareMonitor and Contributors. -// Partial Copyright (C) Michael Möller <m...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs index b1f8dfe8c..b04809b62 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDeviceSensor.cs @@ ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -1,9 +1,10 @@ // This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. // If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -// Copyright (C) LibreHardwareMonitor and Contributors. -// Partial Copyright (C) Michael Möller <mm...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs b/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs index 06d0c7f36..5a0fe2325 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/SmartAttribute.cs @@ -4,6 +4,8 @@ // Par...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -77,18 +79,37 @@ public override void Update() return; } + // If storage device has no changes, skip update + if (!StorageDIT.Refresh(_storage)) + { + // If not initialized, we need to initialize sensors with initial values, even if there are no changes + ...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -274,7 +322,7 @@ private unsafe void UpdatePerformanceSensors() { DISK_PERFORMANCE diskPerformance = new(); - using var handle = PInvoke.CreateFile(_storage.PhysicalPath, + using var handle = PInvoke.CreateFile(_storage.DevicePath ?? _storage.AlternateDevicePath,
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -1,13 +1,13 @@ // This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. // If a copy of the MPL was not distributed with this file, You can obtain one at http://mozilla.org/MPL/2.0/. -// Copyright (C) LibreHardwareMonitor and Contributors. -// Partial Copyright (C) Michael Möller <m...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -34,49 +34,71 @@ public StorageGroup(ISettings settings) private void AddHardware(ISettings settings) { - StorageManager.StoragesChanged -= OnStoragesChanged; + StorageDIT.DevicesChanged -= OnStoragesChanged; - //Reload storage devices - StorageManager.ReloadStorages(); + ...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -57,16 +60,15 @@ public StorageDevice(DiskInfoToolkit.Storage storage, string id, ISettings setti public override HardwareType HardwareType => HardwareType.Storage; - public DiskInfoToolkit.Storage Storage => _storage; + public StorageDeviceDIT UnderlyingImplementation => _storage;
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs index ac42522a8..523b7145e 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageDevice.cs @@ -13,11 +13,13 @@ using ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -34,49 +35,71 @@ public StorageGroup(ISettings settings) private void AddHardware(ISettings settings) { - StorageManager.StoragesChanged -= OnStoragesChanged; + StorageDIT.DevicesChanged -= OnStoragesChanged; - //Reload storage devices - StorageManager.ReloadStorages(); + ...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
diff --git a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs index 64da879c3..edce57edc 100644 --- a/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Storage/StorageGroup.cs @@ -7,7 +7,8 @@ using System.C...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
3bd3c04079d1c273fba6c8a6f96765d433195332
@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor() ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_LOW_REGISTER)) == NUVOTON_VENDOR_ID; } - private void Set6687DRControl(int index, byte? value) + /// <summary> + /// Request the EC to enter fan configuration phase and w...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor() ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_LOW_REGISTER)) == NUVOTON_VENDOR_ID; } - private void Set6687DRControl(int index, byte? value) + /// <summary> + /// Request the EC to enter fan configuration phase and w...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor() ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_LOW_REGISTER)) == NUVOTON_VENDOR_ID; } - private void Set6687DRControl(int index, byte? value) + /// <summary> + /// Request the EC to enter fan configuration phase and w...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
@@ -1190,35 +1227,90 @@ private bool IsNuvotonVendor() ((ReadByte(VENDOR_ID_HIGH_REGISTER) << 8) | ReadByte(VENDOR_ID_LOW_REGISTER)) == NUVOTON_VENDOR_ID; } - private void Set6687DRControl(int index, byte? value) + /// <summary> + /// Request the EC to enter fan configuration phase and w...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
@@ -19,23 +19,72 @@ namespace LibreHardwareMonitor.Hardware.Motherboard.Lpc; internal class Nct677X : ISuperIO { + #region Constants + + // ReSharper disable InconsistentNaming + private const ushort ADDRESS_REGISTER_OFFSET = 0x05; + private const byte BANK_SELECT_REGISTER = 0x4E; + private const uin...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
@@ -1305,12 +1493,29 @@ not Chip.NCT6799D and _lpcPort.WinbondNuvotonFintekExit(); } + /// <summary> + /// Spin-wait for the specified number of milliseconds using Stopwatch. + /// Thread.Sleep(N) on Windows has ~15.6ms minimum granularity; + /// SpinWait yields progressively to avoid burnin...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index 38f24b845..5ae884703 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -19,23 +19,62 @@...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
451f9728eab092a088b84297a07dd452cd818863
@@ -409,7 +478,13 @@ public void SetControl(int index, byte? value) WriteByte(FAN_PWM_REQUEST_REG[index], 0x80); Thread.Sleep(50); - WriteByte(FAN_PWM_COMMAND_REG[index], value.Value); + if (Chip is Chip.NCT6687DR){ // For MSI AM5/LGA1851 NCT6687D functi...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
13f997598e4deff4358d947817a78891d05aa94b
diff --git a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs index f500f88d8..e94c45721 100644 --- a/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs +++ b/LibreHardwareMonitorLib/Hardware/Motherboard/Lpc/Nct677X.cs @@ -76,6 +76,13 @@ ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
13f997598e4deff4358d947817a78891d05aa94b
@@ -4,100 +4,316 @@ // Partial Copyright (C) Michael Möller <mmoeller@openhardwaremonitor.org> and Contributors. // All Rights Reserved. +using System; using System.Collections.Generic; using System.Globalization; +using System.Linq; using System.Text; +using System.Threading; +using System.Threading.Tasks; usi...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
@@ -4,100 +4,316 @@ // Partial Copyright (C) Michael Möller <mmoeller@openhardwaremonitor.org> and Contributors. // All Rights Reserved. +using System; using System.Collections.Generic; using System.Globalization; +using System.Linq; using System.Text; +using System.Threading; +using System.Threading.Tasks; usi...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
@@ -4,100 +4,316 @@ // Partial Copyright (C) Michael Möller <mmoeller@openhardwaremonitor.org> and Contributors. // All Rights Reserved. +using System; using System.Collections.Generic; using System.Globalization; +using System.Linq; using System.Text; +using System.Threading; +using System.Threading.Tasks; usi...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
@@ -4,100 +4,316 @@ // Partial Copyright (C) Michael Möller <mmoeller@openhardwaremonitor.org> and Contributors. // All Rights Reserved. +using System; using System.Collections.Generic; using System.Globalization; +using System.Linq; using System.Text; +using System.Threading; +using System.Threading.Tasks; usi...
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
diff --git a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs index 039ef97ee..883646c55 100644 --- a/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Gpu/NvidiaGroup.cs @@ -4,100 +4,275 @@ // Partial Copyright (C) Micha...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
9a82e19738bf90b5e19ad37881c08d09b711137a
@@ -129,11 +130,13 @@ public unsafe BatteryGroup(ISettings settings) hdev.Dispose(); } + #endif
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs b/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs index 45fa4fb13..e29f8d0d6 100644 --- a/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs +++ b/LibreHardwareMonitorLib/Hardware/Battery/BatteryGroup.cs @@ -28,6 +28,7 @@ public unsafe...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
@@ -116,6 +115,9 @@ static string GetProperty(SafeHandle hDevInfo, SETUP_DI_REGISTRY_PROPERTY proper return null; } + #endif
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs b/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs index 715322a2d..eefef6511 100644 --- a/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs +++ b/LibreHardwareMonitorLib/Interop/PowerMonitor/Stm32PortFinder.cs @@ ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
@@ -512,7 +512,9 @@ public void Open() _smbios = new SMBios(); - Mutexes.Open(); + if (Software.OperatingSystem.IsWindows8OrGreater)
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
diff --git a/LibreHardwareMonitorLib/Hardware/Computer.cs b/LibreHardwareMonitorLib/Hardware/Computer.cs index bb87340ed..7a23d0106 100644 --- a/LibreHardwareMonitorLib/Hardware/Computer.cs +++ b/LibreHardwareMonitorLib/Hardware/Computer.cs @@ -512,7 +512,9 @@ public void Open() _smbios = new SMBios(); - ...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
6ef07af09797ef2fb4f1ee3ee711bfa8c53e8215
@@ -286,10 +287,21 @@ static string ExtractPawnIO() _showGadget = new UserOption("gadgetMenuItem", false, gadgetMenuItem, _settings); + _forceDriveWakeup = new UserOption("logSensorsMenuItem", true, forceDriveWakeupItem, _settings);
bad
review
csharp
LibreHardwareMonitor/LibreHardwareMonitor
7342bac1ed43dfc1516e048517116531b22e0302
diff --git a/LibreHardwareMonitor/UI/MainForm.cs b/LibreHardwareMonitor/UI/MainForm.cs index b98afb57f..0720794de 100644 --- a/LibreHardwareMonitor/UI/MainForm.cs +++ b/LibreHardwareMonitor/UI/MainForm.cs @@ -33,6 +33,7 @@ public sealed partial class MainForm : Form private readonly UserRadioGroup _updateInterval;...
good
review_fixed
csharp
LibreHardwareMonitor/LibreHardwareMonitor
7342bac1ed43dfc1516e048517116531b22e0302