Datasets:
PotatoHD
/
code-edit-negatives-cls

Dataset card Data Studio Files
xet
 Community
1
text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -15,43 +15,32 @@ */ package com.lmax.disruptor; -import java.util.logging.Level; -import java.util.logging.Logger; +import java.lang.System.Logger.Level; +import java.lang.System.Logger; /** - * Convenience implementation of an exception handler that using standard JDK logging to log - * the exception as {@l...
bad
review
java
LMAX-Exchange/disruptor
a0de4ccdb4183fa7782106e944bdc7feffe9a0ac
diff --git a/src/main/java/com/lmax/disruptor/IgnoreExceptionHandler.java b/src/main/java/com/lmax/disruptor/IgnoreExceptionHandler.java index fbabfb609..0cab19d5e 100644 --- a/src/main/java/com/lmax/disruptor/IgnoreExceptionHandler.java +++ b/src/main/java/com/lmax/disruptor/IgnoreExceptionHandler.java @@ -15,43 +15,3...
good
review_fixed
java
LMAX-Exchange/disruptor
a0de4ccdb4183fa7782106e944bdc7feffe9a0ac
@@ -86,6 +86,21 @@ public void tearDown() throws Exception executor.joinAllThreads(); } + @Test + public void shouldHaveStartedAfterStartCalled() throws Exception { + if (disruptor.hasStarted()) + { + fail("Should only be set to started after start is called"); + } + + d...
bad
review
java
LMAX-Exchange/disruptor
b558f03d1995880f2af9eb20107324971d6c4703
diff --git a/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java b/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java index 56c5a8551..21344d90a 100644 --- a/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java +++ b/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java @@ -54,6 +54,7 @@ import static or...
good
review_fixed
java
LMAX-Exchange/disruptor
b558f03d1995880f2af9eb20107324971d6c4703
@@ -86,6 +86,21 @@ public void tearDown() throws Exception executor.joinAllThreads(); } + @Test + public void shouldHaveStartedAfterStartCalled() throws Exception { + if (disruptor.hasStarted())
bad
review
java
LMAX-Exchange/disruptor
b558f03d1995880f2af9eb20107324971d6c4703
diff --git a/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java b/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java index 56c5a8551..21344d90a 100644 --- a/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java +++ b/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java @@ -54,6 +54,7 @@ import static or...
good
review_fixed
java
LMAX-Exchange/disruptor
b558f03d1995880f2af9eb20107324971d6c4703
@@ -86,6 +86,21 @@ public void tearDown() throws Exception executor.joinAllThreads(); } + @Test + public void shouldHaveStartedAfterStartCalled() throws Exception { + if (disruptor.hasStarted()) + { + fail("Should only be set to started after start is called"); + } + + d...
bad
review
java
LMAX-Exchange/disruptor
b558f03d1995880f2af9eb20107324971d6c4703
diff --git a/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java b/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java index 56c5a8551..21344d90a 100644 --- a/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java +++ b/src/test/java/com/lmax/disruptor/dsl/DisruptorTest.java @@ -54,6 +54,7 @@ import static or...
good
review_fixed
java
LMAX-Exchange/disruptor
b558f03d1995880f2af9eb20107324971d6c4703
@@ -59,9 +59,16 @@ jobs: # and modify them (or add more) to build your code if your project # uses a compiled language - #- run: | - # make bootstrap - # make release - + - name: Set up java + uses: actions/setup-java@v1 + with: + java-version: 11 + + - name: Gr...
bad
review
LMAX-Exchange/disruptor
f6fa8309116eda016816706eeb035ab0fa3065b4
diff --git a/.github/workflows/codeql-analysis.yml b/.github/workflows/codeql-analysis.yml new file mode 100644 index 000000000..7f31ae5d1 --- /dev/null +++ b/.github/workflows/codeql-analysis.yml @@ -0,0 +1,72 @@ +# For most projects, this workflow file will not need changing; you simply need +# to commit it to your r...
good
review_fixed
LMAX-Exchange/disruptor
f6fa8309116eda016816706eeb035ab0fa3065b4
@@ -42,6 +42,42 @@ if (APPLE) target_link_libraries(ladybird PRIVATE Qt::GuiPrivate "-framework Cocoa" "-framework IOSurface" "-framework Metal" "-framework QuartzCore") endif() +if (NOT APPLE AND USE_VULKAN_DMABUF_IMAGES AND Qt6_VERSION VERSION_GREATER_EQUAL 6.7.0) + set(WEB_CONTENT_VIEW_LINUX_VERT_SHADER "...
bad
review
LadybirdBrowser/ladybird
1fae347727f663052281c551db12d4ae9a0ecd4f
diff --git a/UI/Qt/CMakeLists.txt b/UI/Qt/CMakeLists.txt index 6cdbaf00a9c61..582d029c38782 100644 --- a/UI/Qt/CMakeLists.txt +++ b/UI/Qt/CMakeLists.txt @@ -4,8 +4,8 @@ set(CMAKE_AUTOUIC ON) find_package(Qt6 REQUIRED COMPONENTS Core Widgets) if (APPLE) - # The macOS QRhiWidget presentation path uses QRhi's priva...
good
review_fixed
LadybirdBrowser/ladybird
1fae347727f663052281c551db12d4ae9a0ecd4f
@@ -0,0 +1,147 @@ +/* + * Copyright (c) 2026, Ladybird contributors + * + * SPDX-License-Identifier: BSD-2-Clause + */ + +#include <AK/JsonArray.h> +#include <AK/JsonObject.h> +#include <LibDevTools/Actors/CookiesActor.h> +#include <LibDevTools/Actors/TabActor.h> +#include <LibURL/Parser.h> +#include <LibURL/URL.h> + +...
bad
review
cpp
LadybirdBrowser/ladybird
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
diff --git a/Libraries/LibDevTools/Actors/CookiesActor.cpp b/Libraries/LibDevTools/Actors/CookiesActor.cpp new file mode 100644 index 0000000000000..54895f9c3f6ae --- /dev/null +++ b/Libraries/LibDevTools/Actors/CookiesActor.cpp @@ -0,0 +1,736 @@ +/* + * Copyright (c) 2026, Ladybird contributors + * + * SPDX-License-Id...
good
review_fixed
cpp
LadybirdBrowser/ladybird
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
@@ -25,6 +25,61 @@ namespace WebView { static constexpr auto DATABASE_SYNCHRONIZATION_TIMER = AK::Duration::from_seconds(30); +static CookieStorageKey storage_key_for_cookie(HTTP::Cookie::Cookie const& cookie) +{ + return { cookie.name, cookie.domain, cookie.path }; +} + +static ErrorOr<void> validate_devtools_...
bad
review
cpp
LadybirdBrowser/ladybird
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
diff --git a/Libraries/LibWebView/CookieJar.cpp b/Libraries/LibWebView/CookieJar.cpp index ef12748c73d46..96c9c93dfb2c3 100644 --- a/Libraries/LibWebView/CookieJar.cpp +++ b/Libraries/LibWebView/CookieJar.cpp @@ -25,6 +25,34 @@ namespace WebView { static constexpr auto DATABASE_SYNCHRONIZATION_TIMER = AK::Duration::...
good
review_fixed
cpp
LadybirdBrowser/ladybird
b26972d17e4b39446c46c1f13cfc2afbc53ddae6
@@ -83,10 +83,10 @@ module layout = link(rel="stylesheet", href="/bootstrap/bootstrap.min.css") link(rel="stylesheet", href="/app.css") link(rel="icon", type'="image/png", href="/favicon.png") - script(src="https://unpkg.com/htmx.org@1.9.10", crossorigin...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/examples/WeatherApp/templates/shared/layout.fs b/examples/WeatherApp/templates/shared/layout.fs index 869f5f62..6163d1a9 100644 --- a/examples/WeatherApp/templates/shared/layout.fs +++ b/examples/WeatherApp/templates/shared/layout.fs @@ -83,10 +83,10 @@ module layout = link(rel="stylesheet...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -14,12 +14,11 @@ module layout = html(lang="") { head() { title() { "Contact App" } - script(src="https://unpkg.com/htmx.org@1.9.10", + script(src="https://cdn.jsdelivr.net/npm/htmx.org@next/dist/htmx.min.js",
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/examples/ContactApp/templates/shared/layout.fs b/examples/ContactApp/templates/shared/layout.fs index 0ab8adc5..1f0d527c 100644 --- a/examples/ContactApp/templates/shared/layout.fs +++ b/examples/ContactApp/templates/shared/layout.fs @@ -1,4 +1,4 @@ -namespace ContactApp.templates.shared +namespace Contac...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -119,10 +119,9 @@ let streamingHtml1: EndpointHandler = let html = html() { head() { - script(src = "https://unpkg.com/htmx.org@1.9.12") - script(src = "https://unpkg.com/htmx.ext...chunked-transfer@1.0.4/dist/index.js") // workaround, see ...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/examples/Basic/Program.fs b/examples/Basic/Program.fs index 0c2585d9..2650b536 100644 --- a/examples/Basic/Program.fs +++ b/examples/Basic/Program.fs @@ -1,4 +1,4 @@ -open System +open System open System.Text.Json.Serialization open System.Threading.Tasks open Microsoft.AspNetCore.Authorization @@ -118...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -46,76 +45,93 @@ module CoreAttributes = [<AutoOpen>] module AdditionalAttributes = type HtmlTag with + /// Mark element to swap in from a response (out of band) + member this.hxSwapOob + with set (value: string | null) = this.attr("hx-swap-oob", value) |> ignore + /// Push a U...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -46,76 +45,93 @@ module CoreAttributes = [<AutoOpen>] module AdditionalAttributes = type HtmlTag with + /// Mark element to swap in from a response (out of band) + member this.hxSwapOob + with set (value: string | null) = this.attr("hx-swap-oob", value) |> ignore + /// Push a U...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -46,76 +45,93 @@ module CoreAttributes = [<AutoOpen>] module AdditionalAttributes = type HtmlTag with + /// Mark element to swap in from a response (out of band) + member this.hxSwapOob + with set (value: string | null) = this.attr("hx-swap-oob", value) |> ignore + /// Push a U...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Replace: emit attribute a...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Replace: emit attribute a...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Replace: emit attribute a...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Replace: emit attribute a...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -15,87 +17,132 @@ open Oxpecker.Htmx let renderForm q = form(action="/contacts", method="get") { label(for'="search") { "Search Term" } - input(id="search", type'="search", name="q", value=q, style="margin: 0 5px", autocomplete="off", - hxGet="/contacts", - hxTrigger="...
bad
review
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/README.md b/src/Oxpecker.Htmx/README.md index a18c9ace..c415521f 100644 --- a/src/Oxpecker.Htmx/README.md +++ b/src/Oxpecker.Htmx/README.md @@ -2,11 +2,13 @@ --- # Oxpecker.Htmx -`Oxpecker.Htmx` extends `Oxpecker.ViewEngine` package with HTMX attributes and headers. +`Oxpecker.Htmx` e...
good
review_fixed
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,246 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Set: emit attribute as `h...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,246 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Set: emit attribute as `h...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,246 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Set: emit attribute as `h...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,246 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Set: emit attribute as `h...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -0,0 +1,288 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xunit +open FsUnit.Light + +// ─── Verb attributes ─── + +[<Fact>] +let ``hxGet renders hx-get`` () = + div().attr(hxGet "/api") { "content" } + |> Render.toString + |> shouldEqual """<div hx-get="/api">content</di...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..8ab8b204 --- /dev/null +++ b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs @@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xuni...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Set: emit attribute as `h...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,244 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx +open System open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine +[<AutoOpen>] +module ModifierAttributes = + /// Inheritance modifier for htmx 4 attributes. + /// Set: emit attribute as `h...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -0,0 +1,288 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xunit +open FsUnit.Light + +// ─── Verb attributes ─── + +[<Fact>] +let ``hxGet renders hx-get`` () = + div().attr(hxGet "/api") { "content" } + |> Render.toString + |> shouldEqual """<div hx-get="/api">content</di...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..8ab8b204 --- /dev/null +++ b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs @@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xuni...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -15,87 +17,147 @@ open Oxpecker.Htmx let renderForm q = form(action="/contacts", method="get") { label(for'="search") { "Search Term" } - input(id="search", type'="search", name="q", value=q, style="margin: 0 5px", autocomplete="off", - hxGet="/contacts", - hxTrigger="...
bad
review
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/README.md b/src/Oxpecker.Htmx/README.md index a18c9ace..c415521f 100644 --- a/src/Oxpecker.Htmx/README.md +++ b/src/Oxpecker.Htmx/README.md @@ -2,11 +2,13 @@ --- # Oxpecker.Htmx -`Oxpecker.Htmx` extends `Oxpecker.ViewEngine` package with HTMX attributes and headers. +`Oxpecker.Htmx` e...
good
review_fixed
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xunit +open FsUnit.Light + +// ─── Verb attributes ─── + +[<Fact>] +let ``hxGet renders hx-get`` () = + div().hxGet("/api") { "content" } + |> Render.toString + |> shouldEqual """<div hx-get="/api">content</div>"""...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..8ab8b204 --- /dev/null +++ b/tests/Oxpecker.Htmx.Tests/Attributes.Tests.fs @@ -0,0 +1,368 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Htmx +open Xuni...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine -[<AutoOpen>] -module CoreAttributes = - type HtmlTag with - /// Issues a GET to the specified URL - member this.hxGet - ...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices open Oxpecker.ViewEngine -[<AutoOpen>] -module CoreAttributes = - type HtmlTag with - /// Issues a GET to the specified URL - member this.hxGet - ...
bad
review
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
diff --git a/src/Oxpecker.Htmx/Attributes.fs b/src/Oxpecker.Htmx/Attributes.fs index 28126dc6..c2c77411 100644 --- a/src/Oxpecker.Htmx/Attributes.fs +++ b/src/Oxpecker.Htmx/Attributes.fs @@ -1,121 +1,319 @@ -namespace Oxpecker.Htmx +namespace Oxpecker.Htmx open System.Diagnostics.CodeAnalysis +open System.Runtime.C...
good
review_fixed
fsharp
Lanayx/Oxpecker
62c08acd95a55331ffe0a6763ff00ed2063c11e6
@@ -0,0 +1,201 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker.ViewEngine + +/// Frequently used modifiers for Transitions. +/// Each constant includes the leading `.` and is appended verbatim after the attribute name. +[<RequireQualifiedAccess>...
bad
review
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
good
review_fixed
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -0,0 +1,201 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker.ViewEngine + +/// Frequently used modifiers for Transitions. +/// Each constant includes the leading `.` and is appended verbatim after the attribute name. +[<RequireQualifiedAccess>...
bad
review
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
good
review_fixed
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -0,0 +1,201 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker.ViewEngine + +/// Frequently used modifiers for Transitions. +/// Each constant includes the leading `.` and is appended verbatim after the attribute name. +[<RequireQualifiedAccess>...
bad
review
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
good
review_fixed
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -0,0 +1,181 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Alpine +open Xunit +open FsUnit.Light + +[<Fact>] +let ``xData renders x-data with value`` () = + div().xData("{ open: false }") { "content" } + |> Render.toString + |> shouldEqual """<div x-data="{ open: false }">content</di...
bad
review
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs new file mode 100644 index 00000000..251ff29f --- /dev/null +++ b/tests/Oxpecker.Alpine.Tests/Attributes.Tests.fs @@ -0,0 +1,187 @@ +module Attributes.Tests + +open Oxpecker.ViewEngine +open Oxpecker.Alpine +o...
good
review_fixed
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -0,0 +1,201 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker.ViewEngine + +/// Frequently used modifiers for Transitions. +/// Each constant includes the leading `.` and is appended verbatim after the attribute name. +[<RequireQualifiedAccess>...
bad
review
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
good
review_fixed
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -0,0 +1,116 @@ +--- +--- +# Oxpecker.Alpine + +`Oxpecker.Alpine` extends `Oxpecker.ViewEngine` with typed [Alpine.js](https://alpinejs.dev) directives. + +[Nuget package](https://www.nuget.org/packages/Oxpecker.Alpine) `dotnet add package Oxpecker.Alpine` + +Each Alpine directive is exposed as a fluent extension met...
bad
review
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/README.md b/src/Oxpecker.Alpine/README.md new file mode 100644 index 00000000..c9811dbc --- /dev/null +++ b/src/Oxpecker.Alpine/README.md @@ -0,0 +1,116 @@ +--- +--- +# Oxpecker.Alpine + +`Oxpecker.Alpine` extends `Oxpecker.ViewEngine` with typed [Alpine.js](https://alpinejs.dev) direct...
good
review_fixed
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -0,0 +1,205 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker.ViewEngine + +/// Frequently used modifiers for Transitions. +/// Each constant includes the leading `.` and is appended verbatim after the attribute name. +[<RequireQualifiedAccess>...
bad
review
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
diff --git a/src/Oxpecker.Alpine/Attributes.fs b/src/Oxpecker.Alpine/Attributes.fs new file mode 100644 index 00000000..c1af31c5 --- /dev/null +++ b/src/Oxpecker.Alpine/Attributes.fs @@ -0,0 +1,215 @@ +namespace Oxpecker.Alpine + +open System.Diagnostics.CodeAnalysis +open System.Runtime.CompilerServices +open Oxpecker...
good
review_fixed
fsharp
Lanayx/Oxpecker
2ac8f1875cb74e960f024c48d41b59a3ae177e7a
@@ -21,6 +22,35 @@ module private Helpers = else None + let (|OptionalProperties|_|) (ctx: OpenApiSchemaTransformerContext) = + let result = ResizeArray() + for propertyInfo in ctx.JsonTypeInfo.Properties do + match propertyInfo.PropertyType with + | FSharp...
bad
review
fsharp
Lanayx/Oxpecker
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/src/Oxpecker.OpenApi/Transformers.fs b/src/Oxpecker.OpenApi/Transformers.fs index 3cbf1e58..d370152f 100644 --- a/src/Oxpecker.OpenApi/Transformers.fs +++ b/src/Oxpecker.OpenApi/Transformers.fs @@ -21,6 +21,35 @@ module private Helpers = else None + let (|OptionalProperties|_|) (...
good
review_fixed
fsharp
Lanayx/Oxpecker
71851c9106e58849db8cf7be030039796123ca3b
@@ -0,0 +1,28 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <PropertyGroup> + <TargetFramework>net10.0</TargetFramework> + <IsPackable>false</IsPackable> + <IsTestProject>true</IsTestProject> + <TestingPlatformDotnetTestSupport>true</TestingPlatformDotnetTestSupport> + <UseMicrosoftTes...
bad
review
Lanayx/Oxpecker
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj b/tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj new file mode 100644 index 00000000..ef6f2fbd --- /dev/null +++ b/tests/Oxpecker.OpenApi.Tests/Oxpecker.OpenApi.Tests.fsproj @@ -0,0 +1,28 @@ +<Project Sdk="Microsoft.NET.Sdk"> + + <Pr...
good
review_fixed
Lanayx/Oxpecker
71851c9106e58849db8cf7be030039796123ca3b
@@ -21,6 +22,35 @@ module private Helpers = else None + let (|OptionalProperties|_|) (ctx: OpenApiSchemaTransformerContext) = + let result = ResizeArray() + for propertyInfo in ctx.JsonTypeInfo.Properties do + match propertyInfo.PropertyType with + | FSharp...
bad
review
fsharp
Lanayx/Oxpecker
71851c9106e58849db8cf7be030039796123ca3b
diff --git a/src/Oxpecker.OpenApi/Transformers.fs b/src/Oxpecker.OpenApi/Transformers.fs index 3cbf1e58..d370152f 100644 --- a/src/Oxpecker.OpenApi/Transformers.fs +++ b/src/Oxpecker.OpenApi/Transformers.fs @@ -21,6 +21,35 @@ module private Helpers = else None + let (|OptionalProperties|_|) (...
good
review_fixed
fsharp
Lanayx/Oxpecker
71851c9106e58849db8cf7be030039796123ca3b
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
@@ -14,299 +12,259 @@ open Microsoft.Extensions.Primitives type IModelBinder = abstract member Bind<'T> : seq<KeyValuePair<string, StringValues>> -> 'T +module internal StringValues = + let toDict (v: StringValues) = dict [ "", v ] + +module internal String = + let toDict (v: string | null) = StringValues...
bad
review
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429
diff --git a/src/Oxpecker/ModelBinder.fs b/src/Oxpecker/ModelBinder.fs index ad0fce04..b3cb5dd3 100644 --- a/src/Oxpecker/ModelBinder.fs +++ b/src/Oxpecker/ModelBinder.fs @@ -1,5 +1,3 @@ -#nowarn 3261 - namespace Oxpecker open System @@ -12,301 +10,353 @@ open Microsoft.Extensions.Primitives /// Use this interfac...
good
review_fixed
fsharp
Lanayx/Oxpecker
8a68ad9da4745ac12640aaf5c1ed386da2919429