text
stringlengths
19
585k
label
stringclasses
2 values
category
stringclasses
2 values
language
stringclasses
14 values
repo
stringclasses
932 values
sha
stringlengths
40
40
@@ -2282,6 +2281,18 @@ class nsZenWorkspaces { ); } + onBeforeTabSelect(aTab) { + const tabSpace = aTab?.getAttribute("zen-workspace-id"); + if ( + tabSpace && + tabSpace !== this.activeWorkspac &&
bad
review
javascript
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index b75733b8109..43dcb6dda6a 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -1498,7 +1498,6 @@ class nsZenWorkspaces { continue; } - tab.owner = null; if (con...
good
review_fixed
javascript
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
@@ -0,0 +1,69 @@ +/* Any copyright is dedicated to the Public Domain. + https://creativecommons.org/publicdomain/zero/1.0/ */ + +"use strict"; + +function fakeTab(workspaceId) { + return { + getAttribute(name) { + return name === "zen-workspace-id" ? workspaceId : null; + }, + }; +}
bad
review
javascript
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
diff --git a/src/zen/tests/spaces/browser_select_tab_switches_space.js b/src/zen/tests/spaces/browser_select_tab_switches_space.js new file mode 100644 index 00000000000..4fd738f1721 --- /dev/null +++ b/src/zen/tests/spaces/browser_select_tab_switches_space.js @@ -0,0 +1,69 @@ +/* Any copyright is dedicated to the Publ...
good
review_fixed
javascript
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
@@ -82,6 +82,40 @@ class nsZenSpaceRoutingManager { this.#routeToWorkspace(targetRoute, newTab, win); } + /** + * Decides whether an in-place top-level navigation should be pulled out of + * the current tab and re-opened in a new tab, so that addTab()'s routing can + * move it into the space its rule p...
bad
review
javascript
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs index b5d07c7a3e8..e9cf24438eb 100644 --- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -82,6 +82,40 @@ class nsZenSpaceRoutingM...
good
review_fixed
javascript
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
@@ -94,3 +94,8 @@ # See gh-12985 for details on the following preferences - name: browser.search.widget.new value: true + +# Disabled from https://searchfox.org/firefox-main/rev/d6bfff43852356ca98af848b4705d37f8d41856f/modules/libpref/init/StaticPrefList.yaml#2008 +# Only enabled for windows, doesn't really fit in...
bad
review
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml index 341577cac76..4545795c628 100644 --- a/prefs/firefox/browser.yaml +++ b/prefs/firefox/browser.yaml @@ -94,3 +94,8 @@ # See gh-12985 for details on the following preferences - name: browser.search.widget.new value: true + +# Disabled from htt...
good
review_fixed
zen-browser/desktop
3692a5047f9fcc46b6051d738be3587c15e82747
@@ -1,17 +1,13 @@ -/* - * This Source Code Form is subject to the terms of the Mozilla Public +/* This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - */ + * file, You ca...
bad
review
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css index 31aea297e67..172263809fc 100644 --- a/src/zen/space-routing/zen-space-routing.css +++ b/src/zen/space-routing/zen-space-routing.css @@ -1,17 +1,13 @@ -/* - * This Source Code Form is subject to the terms of the ...
good
review_fixed
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
@@ -196,8 +196,17 @@ export class nsZenSpaceRoutingDialog { bottomRow.append(bottomLabelContainer, openInMenulist); root.append(topRow, bottomRow); + + root.style.display = "none"; container.appendChild(root); + // Wait for l10n to catch up and then show the element to avoid flickering. + th...
bad
review
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs index 3bdb6324f9f..786a4fc0151 100644 --- a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -196,8 +196,18 @@ export class nsZenSpaceRoutingDialog { ...
good
review_fixed
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
@@ -254,16 +254,16 @@ class nsZenSpaceRoutingManager { * @param {Window} parentWindow - The parent browser window * @returns {Window|null} The instanced editor window */ - openSpaceRoutingDialog(parentWindow) { - const control = parentWindow.openDialog( + async openSpaceRoutingDialog(parentWindow) { + ...
bad
review
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs index 9109e89245a..b5d07c7a3e8 100644 --- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -254,16 +254,16 @@ class nsZenSpaceRouti...
good
review_fixed
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
@@ -254,16 +254,16 @@ class nsZenSpaceRoutingManager { * @param {Window} parentWindow - The parent browser window * @returns {Window|null} The instanced editor window */ - openSpaceRoutingDialog(parentWindow) { - const control = parentWindow.openDialog( + async openSpaceRoutingDialog(parentWindow) { + ...
bad
review
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs index 9109e89245a..b5d07c7a3e8 100644 --- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -254,16 +254,16 @@ class nsZenSpaceRouti...
good
review_fixed
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
@@ -254,16 +254,16 @@ class nsZenSpaceRoutingManager { * @param {Window} parentWindow - The parent browser window * @returns {Window|null} The instanced editor window */
bad
review
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs index 9109e89245a..b5d07c7a3e8 100644 --- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -254,16 +254,16 @@ class nsZenSpaceRouti...
good
review_fixed
javascript
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
@@ -36,11 +32,7 @@ display: none !important; } -#zen-space-routing-dialog-container { - background-color: var(--sr-background); - padding: 0; - margin: 24px; - +window {
bad
review
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css index 31aea297e67..172263809fc 100644 --- a/src/zen/space-routing/zen-space-routing.css +++ b/src/zen/space-routing/zen-space-routing.css @@ -1,17 +1,13 @@ -/* - * This Source Code Form is subject to the terms of the ...
good
review_fixed
zen-browser/desktop
42b7713f57011c1a174ba4a8533e25ed99771758
@@ -40,6 +40,7 @@ .close-icon, .zen-glance-sidebar-close, .zen-theme-picker-custom-list-item-remove, +.at-remove,
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/themes/shared/zen-icons/icons.css b/src/browser/themes/shared/zen-icons/icons.css index 918a36ec107..513683d2c9e 100644 --- a/src/browser/themes/shared/zen-icons/icons.css +++ b/src/browser/themes/shared/zen-icons/icons.css @@ -51,7 +51,8 @@ } #PanelUI-zen-gradient-generator-color-remove, -...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -133,6 +133,13 @@ document.addEventListener( gZenWorkspaces.unloadAllOtherWorkspaces(); break; } + case "cmd_zenOpenSmartRoutingSettings": { + const { ZenSmartRoutingManager } = ChromeUtils.importESModule( + "resource:///modules/zen/smartrouting/Z...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/common/zen-sets.js b/src/zen/common/zen-sets.js index 1a1acb72854..289dbe9eb71 100644 --- a/src/zen/common/zen-sets.js +++ b/src/zen/common/zen-sets.js @@ -133,6 +133,10 @@ document.addEventListener( gZenWorkspaces.unloadAllOtherWorkspaces(); break; } + ...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -264,23 +264,34 @@ index 43fb79a3060e20f671ae6ffc26350c7abf497702..146b1559b8430773bd4ec173a8f4fe88 focusUrlBar: true, }); resolve(this.selectedBrowser); -@@ -3285,6 +3369,9 @@ +@@ -3285,6 +3369,10 @@ schemelessInput, hasValidUserGestureActivation = fal...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 95bf58cee77..ef96e759e45 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -352,15 +363,25 @@ index 43fb79a3060e20f671ae6ffc26350c7abf497702..146b1559b8430773bd4ec173a8f4fe88 // Additionally send pinned tab events if (pinned) { this.#notifyPinnedStatus(t); -@@ -3750,6 +3869,7 @@ +@@ -3518,6 +3648,9 @@ + if (!inBackground) { + this.selectedTab = t; + ...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 95bf58cee77..ef96e759e45 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,385 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,385 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,455 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,313 @@ +/* + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +:root { + background: none; + appearance: none; + border: none; + outline: none; ...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css new file mode 100644 index 00000000000..31aea297e67 --- /dev/null +++ b/src/zen/space-routing/zen-space-routing.css @@ -0,0 +1,315 @@ +/* + * This Source Code Form is subject to the terms of the Mozilla Public + * Lic...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,313 @@ +/* + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +:root { + background: none; + appearance: none; + border: none; + outline: none; ...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css new file mode 100644 index 00000000000..31aea297e67 --- /dev/null +++ b/src/zen/space-routing/zen-space-routing.css @@ -0,0 +1,315 @@ +/* + * This Source Code Form is subject to the terms of the Mozilla Public + * Lic...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,455 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,455 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,109 @@ +#filter substitution +<?xml version="1.0"?> + +# -*- Mode: HTML -*- +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +<!DOCTYPE window> + +<win...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/zen-space-routing.inc.xhtml b/src/zen/space-routing/zen-space-routing.inc.xhtml new file mode 100644 index 00000000000..dfda3422981 --- /dev/null +++ b/src/zen/space-routing/zen-space-routing.inc.xhtml @@ -0,0 +1,108 @@ +#filter substitution +<?xml version="1.0"?> + +# -*- Mode: HTML ...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,108 @@ +#filter substitution +<?xml version="1.0"?> + +# -*- Mode: HTML -*- +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +<!DOCTYPE window> + +<win...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/zen-space-routing.inc.xhtml b/src/zen/space-routing/zen-space-routing.inc.xhtml new file mode 100644 index 00000000000..dfda3422981 --- /dev/null +++ b/src/zen/space-routing/zen-space-routing.inc.xhtml @@ -0,0 +1,108 @@ +#filter substitution +<?xml version="1.0"?> + +# -*- Mode: HTML ...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -264,23 +264,33 @@ index 43fb79a3060e20f671ae6ffc26350c7abf497702..146b1559b8430773bd4ec173a8f4fe88 focusUrlBar: true, }); resolve(this.selectedBrowser); -@@ -3285,6 +3369,9 @@ +@@ -3285,6 +3369,10 @@ schemelessInput, hasValidUserGestureActivation = fal...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 95bf58cee77..ef96e759e45 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -264,23 +264,33 @@ index 43fb79a3060e20f671ae6ffc26350c7abf497702..146b1559b8430773bd4ec173a8f4fe88 focusUrlBar: true, }); resolve(this.selectedBrowser); -@@ -3285,6 +3369,9 @@ +@@ -3285,6 +3369,10 @@ schemelessInput, hasValidUserGestureActivation = fal...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 95bf58cee77..ef96e759e45 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -10,6 +10,8 @@ zen-space-routing-external-default = Default route for external links zen-space-routing-new-route = New Route zen-space-routing-open-in-space = Open in Space zen-space-routing-most-recent-space = Most recent Space +zen-space-routing-close-button = + .aria-label = Close
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/locales/en-US/browser/browser/zen-space-routing.ftl b/locales/en-US/browser/browser/zen-space-routing.ftl new file mode 100644 index 00000000000..b8f063fb7aa --- /dev/null +++ b/locales/en-US/browser/browser/zen-space-routing.ftl @@ -0,0 +1,25 @@ +# This Source Code Form is subject to the terms of the Mozi...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,404 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,409 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,409 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +import { JSONFile } from "resource://gre/modules/JSONFile.sys.mjs"; + +class nsZenSpaceRout...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs new file mode 100644 index 00000000000..9109e89245a --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs @@ -0,0 +1,413 @@ +/* This Source Code Form is subject to the terms of the...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +// eslint-disable-next-line no-shadow +const { gZenSpaceRoutingManager } = ChromeUtils.impo...
bad
review
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs new file mode 100644 index 00000000000..3bdb6324f9f --- /dev/null +++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs @@ -0,0 +1,454 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public...
good
review_fixed
javascript
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -264,23 +264,32 @@ index 43fb79a3060e20f671ae6ffc26350c7abf497702..146b1559b8430773bd4ec173a8f4fe88 focusUrlBar: true, }); resolve(this.selectedBrowser); -@@ -3285,6 +3369,9 @@ +@@ -3285,6 +3369,10 @@ schemelessInput, hasValidUserGestureActivation = fal...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 95bf58cee77..ef96e759e45 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -352,15 +361,25 @@ index 43fb79a3060e20f671ae6ffc26350c7abf497702..146b1559b8430773bd4ec173a8f4fe88 // Additionally send pinned tab events if (pinned) { this.#notifyPinnedStatus(t); -@@ -3750,6 +3869,7 @@ +@@ -3518,6 +3646,9 @@ + if (!inBackground) { + this.selectedTab = t; + ...
bad
review
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch index 95bf58cee77..ef96e759e45 100644 --- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch +++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch @@ -1,5...
good
review_fixed
zen-browser/desktop
97768c3c7a3d40bdc9eccf5223421d9adf5451d1
@@ -0,0 +1,30 @@ +diff --git a/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs b/toolkit/components/contextualidentity/ContextualIdentityService.sys.mjs +index 5702ff28cc22206f5ce16584dac8a78d816562ce..1cd7f0fd222f5b6d2a98d7b5b76c22063d81894f 100644 +--- a/toolkit/components/contextualidentity/C...
bad
review
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch new file mode 100644 index 00000000000..1b108254d1f --- /dev/null +++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s...
good
review_fixed
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
@@ -170,6 +170,65 @@ class nsZenWorkspaces { } } + /** + * Applies live sync changes: updates workspace cache, removes deleted items, + * then creates/updates pulled items. + * + * @param {{ spaces: Array}} pulled Reconcile-pulled items. + * @param {{ spaces: Array}} removals Items to remove. + ...
bad
review
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c
diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs index a97dd097814..54e1e2d1dd0 100644 --- a/src/zen/spaces/ZenSpaceManager.mjs +++ b/src/zen/spaces/ZenSpaceManager.mjs @@ -11,6 +11,7 @@ const lazy = {}; ChromeUtils.defineESModuleGetters(lazy, { ZenSessionStore: "resource:///mo...
good
review_fixed
javascript
zen-browser/desktop
1ac926bea21e0ea1482583196d427fb08ef8d73c